]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtkcontainer.c
Document expose event->region change and that gtk_widget_event doesn't
[~andy/gtk] / gtk / gtkcontainer.c
index 8f3696f32e117fc02a12cf36e93592446184bebe..760e152966a1bf4828d58c5c0728c15ec8f481e2 100644 (file)
@@ -2,33 +2,42 @@
  * Copyright (C) 1995-1997 Peter Mattis, Spencer Kimball and Josh MacDonald
  *
  * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
+ * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Library General Public License for more details.
+ * Lesser General Public License for more details.
  *
- * You should have received a copy of the GNU Library General Public
+ * You should have received a copy of the GNU Lesser General Public
  * License along with this library; if not, write to the
  * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
  * Boston, MA 02111-1307, USA.
  */
+
+/*
+ * Modified by the GTK+ Team and others 1997-2000.  See the AUTHORS
+ * file for a list of people on the GTK+ Team.  See the ChangeLog
+ * files for a list of changes.  These files are distributed with
+ * GTK+ at ftp://ftp.gtk.org/pub/gtk/. 
+ */
+
+#include <stdarg.h>
 #include <string.h>
+#include <stdlib.h>
+
 #include "gtkcontainer.h"
 #include "gtkprivate.h"
 #include "gtksignal.h"
 #include "gtkmain.h"
-#include <stdarg.h>
-
+#include "gtkwindow.h"
 
 enum {
   ADD,
   REMOVE,
   CHECK_RESIZE,
-  FOREACH,
   FOCUS,
   SET_FOCUS_CHILD,
   LAST_SIGNAL
@@ -37,7 +46,8 @@ enum {
   ARG_0,
   ARG_BORDER_WIDTH,
   ARG_RESIZE_MODE,
-  ARG_CHILD
+  ARG_CHILD,
+  ARG_REALLOCATE_REDRAWS
 };
 
 typedef struct _GtkChildArgInfo        GtkChildArgInfo;
@@ -51,41 +61,47 @@ struct _GtkChildArgInfo
   guint seq_id;
 };
 
-static void gtk_container_base_class_init   (GtkContainerClass *klass);
-static void gtk_container_class_init        (GtkContainerClass *klass);
-static void gtk_container_init              (GtkContainer      *container);
-static void gtk_container_destroy           (GtkObject         *object);
-static void gtk_container_get_arg           (GtkObject        *object,
-                                            GtkArg            *arg,
-                                            guint              arg_id);
-static void gtk_container_set_arg           (GtkObject        *object,
-                                            GtkArg            *arg,
-                                            guint              arg_id);
-static void gtk_container_add_unimplemented (GtkContainer      *container,
-                                            GtkWidget         *widget);
-static void gtk_container_remove_unimplemented (GtkContainer   *container,
-                                               GtkWidget      *widget);
-static void gtk_container_real_check_resize (GtkContainer      *container);
-static gint gtk_container_real_focus        (GtkContainer      *container,
-                                            GtkDirectionType   direction);
-static void gtk_container_real_set_focus_child (GtkContainer      *container,
-                                            GtkWidget         *widget);
-static gint gtk_container_focus_tab         (GtkContainer      *container,
-                                            GList             *children,
-                                            GtkDirectionType   direction);
-static gint gtk_container_focus_up_down     (GtkContainer      *container,
-                                            GList             *children,
-                                            GtkDirectionType   direction);
-static gint gtk_container_focus_left_right  (GtkContainer      *container,
-                                            GList             *children,
-                                            GtkDirectionType   direction);
-static gint gtk_container_focus_move        (GtkContainer      *container,
-                                            GList             *children,
-                                            GtkDirectionType   direction);
-static void gtk_container_children_callback (GtkWidget         *widget,
-                                             gpointer           client_data);
-static void gtk_container_show_all          (GtkWidget         *widget);
-static void gtk_container_hide_all          (GtkWidget         *widget);
+static void     gtk_container_base_class_init      (GtkContainerClass *klass);
+static void     gtk_container_class_init           (GtkContainerClass *klass);
+static void     gtk_container_init                 (GtkContainer      *container);
+static void     gtk_container_destroy              (GtkObject         *object);
+static void     gtk_container_get_arg              (GtkObject         *object,
+                                                   GtkArg            *arg,
+                                                   guint              arg_id);
+static void     gtk_container_set_arg              (GtkObject         *object,
+                                                   GtkArg            *arg,
+                                                   guint              arg_id);
+static void     gtk_container_add_unimplemented    (GtkContainer      *container,
+                                                   GtkWidget         *widget);
+static void     gtk_container_remove_unimplemented (GtkContainer      *container,
+                                                   GtkWidget         *widget);
+static void     gtk_container_real_check_resize    (GtkContainer      *container);
+static gboolean gtk_container_real_focus           (GtkContainer      *container,
+                                                   GtkDirectionType   direction);
+static void     gtk_container_real_set_focus_child (GtkContainer      *container,
+                                                   GtkWidget         *widget);
+static gboolean gtk_container_focus_tab            (GtkContainer      *container,
+                                                   GList             *children,
+                                                   GtkDirectionType   direction);
+static gboolean gtk_container_focus_up_down        (GtkContainer      *container,
+                                                   GList            **children,
+                                                   GtkDirectionType   direction);
+static gboolean gtk_container_focus_left_right     (GtkContainer      *container,
+                                                   GList            **children,
+                                                   GtkDirectionType   direction);
+static gboolean gtk_container_focus_move           (GtkContainer      *container,
+                                                   GList             *children,
+                                                   GtkDirectionType   direction);
+static void     gtk_container_children_callback    (GtkWidget         *widget,
+                                                   gpointer           client_data);
+static void     gtk_container_show_all             (GtkWidget         *widget);
+static void     gtk_container_hide_all             (GtkWidget         *widget);
+static gint     gtk_container_expose               (GtkWidget         *widget,
+                                                   GdkEventExpose    *event);
+
+
+static gchar* gtk_container_child_default_composite_name (GtkContainer *container,
+                                                         GtkWidget    *child);
 
 
 
@@ -107,7 +123,7 @@ gtk_container_get_type (void)
 
   if (!container_type)
     {
-      GtkTypeInfo container_info =
+      static const GtkTypeInfo container_info =
       {
        "GtkContainer",
        sizeof (GtkContainer),
@@ -151,45 +167,56 @@ gtk_container_class_init (GtkContainerClass *class)
   vadjustment_key_id = g_quark_from_static_string (vadjustment_key);
   hadjustment_key_id = g_quark_from_static_string (hadjustment_key);
   
-  gtk_object_add_arg_type ("GtkContainer::border_width", GTK_TYPE_ULONG, GTK_ARG_READWRITE, ARG_BORDER_WIDTH);
+
+  object_class->get_arg = gtk_container_get_arg;
+  object_class->set_arg = gtk_container_set_arg;
+  object_class->destroy = gtk_container_destroy;
+
+  widget_class->show_all = gtk_container_show_all;
+  widget_class->hide_all = gtk_container_hide_all;
+  widget_class->expose_event = gtk_container_expose;
+  
+  class->add = gtk_container_add_unimplemented;
+  class->remove = gtk_container_remove_unimplemented;
+  class->check_resize = gtk_container_real_check_resize;
+  class->forall = NULL;
+  class->focus = gtk_container_real_focus;
+  class->set_focus_child = gtk_container_real_set_focus_child;
+  class->child_type = NULL;
+  class->composite_name = gtk_container_child_default_composite_name;
+
+  gtk_object_add_arg_type ("GtkContainer::border_width", GTK_TYPE_UINT, GTK_ARG_READWRITE, ARG_BORDER_WIDTH);
   gtk_object_add_arg_type ("GtkContainer::resize_mode", GTK_TYPE_RESIZE_MODE, GTK_ARG_READWRITE, ARG_RESIZE_MODE);
   gtk_object_add_arg_type ("GtkContainer::child", GTK_TYPE_WIDGET, GTK_ARG_WRITABLE, ARG_CHILD);
+  gtk_object_add_arg_type ("GtkContainer::reallocate_redraws", GTK_TYPE_BOOL, GTK_ARG_READWRITE, ARG_REALLOCATE_REDRAWS);
 
   container_signals[ADD] =
     gtk_signal_new ("add",
                     GTK_RUN_FIRST,
-                    object_class->type,
+                    GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkContainerClass, add),
-                    gtk_marshal_NONE__POINTER,
+                    gtk_marshal_VOID__OBJECT,
                    GTK_TYPE_NONE, 1,
                     GTK_TYPE_WIDGET);
   container_signals[REMOVE] =
     gtk_signal_new ("remove",
                     GTK_RUN_FIRST,
-                    object_class->type,
+                    GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkContainerClass, remove),
-                    gtk_marshal_NONE__POINTER,
+                    gtk_marshal_VOID__OBJECT,
                    GTK_TYPE_NONE, 1,
                     GTK_TYPE_WIDGET);
   container_signals[CHECK_RESIZE] =
     gtk_signal_new ("check_resize",
                     GTK_RUN_LAST,
-                    object_class->type,
+                    GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkContainerClass, check_resize),
-                   gtk_marshal_NONE__NONE,
+                   gtk_marshal_VOID__VOID,
                    GTK_TYPE_NONE, 0);
-  container_signals[FOREACH] =
-    gtk_signal_new ("foreach",
-                    GTK_RUN_FIRST,
-                    object_class->type,
-                    GTK_SIGNAL_OFFSET (GtkContainerClass, foreach),
-                    gtk_marshal_NONE__C_CALLBACK,
-                   GTK_TYPE_NONE, 1,
-                    GTK_TYPE_C_CALLBACK);
   container_signals[FOCUS] =
     gtk_signal_new ("focus",
                     GTK_RUN_LAST,
-                    object_class->type,
+                    GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkContainerClass, focus),
                     gtk_marshal_ENUM__ENUM,
                    GTK_TYPE_DIRECTION_TYPE, 1,
@@ -197,31 +224,11 @@ gtk_container_class_init (GtkContainerClass *class)
   container_signals[SET_FOCUS_CHILD] =
     gtk_signal_new ("set-focus-child",
                     GTK_RUN_FIRST,
-                    object_class->type,
+                    GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkContainerClass, set_focus_child),
-                    gtk_marshal_NONE__POINTER,
+                    gtk_marshal_VOID__OBJECT,
                    GTK_TYPE_NONE, 1,
                     GTK_TYPE_WIDGET);
-  gtk_object_class_add_signals (object_class, container_signals, LAST_SIGNAL);
-
-  object_class->get_arg = gtk_container_get_arg;
-  object_class->set_arg = gtk_container_set_arg;
-  object_class->destroy = gtk_container_destroy;
-  
-  /* Other container classes should overwrite show_all and hide_all,
-   * for the purpose of showing internal children also, which are not
-   * accessable through gtk_container_foreach.
-  */
-  widget_class->show_all = gtk_container_show_all;
-  widget_class->hide_all = gtk_container_hide_all;
-
-  class->add = gtk_container_add_unimplemented;
-  class->remove = gtk_container_remove_unimplemented;
-  class->check_resize = gtk_container_real_check_resize;
-  class->foreach = NULL;
-  class->focus = gtk_container_real_focus;
-  class->set_focus_child = gtk_container_real_set_focus_child;
-  class->child_type = NULL;
 }
 
 GtkType
@@ -233,7 +240,7 @@ gtk_container_child_type (GtkContainer      *container)
   g_return_val_if_fail (container != NULL, 0);
   g_return_val_if_fail (GTK_IS_CONTAINER (container), 0);
 
-  class = GTK_CONTAINER_CLASS (GTK_OBJECT (container)->klass);
+  class = GTK_CONTAINER_GET_CLASS (container);
   if (class->child_type)
     slot = class->child_type (container);
   else
@@ -250,6 +257,7 @@ gtk_container_child_type (GtkContainer      *container)
 void
 gtk_container_add_with_args (GtkContainer      *container,
                             GtkWidget         *widget,
+                            const gchar       *first_arg_name,
                             ...)
 {
   g_return_if_fail (container != NULL);
@@ -270,11 +278,12 @@ gtk_container_add_with_args (GtkContainer      *container,
       GSList *info_list = NULL;
       gchar *error;
       
-      va_start (var_args, widget);
+      va_start (var_args, first_arg_name);
       error = gtk_container_child_args_collect (GTK_OBJECT_TYPE (container),
                                                &arg_list,
                                                &info_list,
-                                               &var_args);
+                                               first_arg_name,
+                                               var_args);
       va_end (var_args);
 
       if (error)
@@ -375,6 +384,7 @@ gtk_container_child_getv (GtkContainer      *container,
 void
 gtk_container_child_set (GtkContainer      *container,
                         GtkWidget         *child,
+                        const gchar       *first_arg_name,
                         ...)
 {
   va_list var_args;
@@ -388,11 +398,12 @@ gtk_container_child_set (GtkContainer      *container,
   g_return_if_fail (GTK_IS_WIDGET (child));
   g_return_if_fail (child->parent != NULL);
 
-  va_start (var_args, child);
+  va_start (var_args, first_arg_name);
   error = gtk_container_child_args_collect (GTK_OBJECT_TYPE (container),
                                            &arg_list,
                                            &info_list,
-                                           &var_args);
+                                           first_arg_name,
+                                           var_args);
   va_end (var_args);
 
   if (error)
@@ -541,13 +552,15 @@ gchar*
 gtk_container_child_args_collect (GtkType       object_type,
                                  GSList      **arg_list_p,
                                  GSList      **info_list_p,
-                                 gpointer      var_args_p)
+                                 const gchar  *first_arg_name,
+                                 va_list       var_args)
 {
   return gtk_args_collect (object_type,
                           container_child_arg_info_ht,
                           arg_list_p,
                           info_list_p,
-                          var_args_p);
+                          first_arg_name,
+                          var_args);
 }
 
 gchar*
@@ -595,6 +608,7 @@ gtk_container_init (GtkContainer *container)
   container->border_width = 0;
   container->need_resize = FALSE;
   container->resize_mode = GTK_RESIZE_PARENT;
+  container->reallocate_redraws = FALSE;
   container->resize_widgets = NULL;
 }
 
@@ -609,14 +623,11 @@ gtk_container_destroy (GtkObject *object)
   container = GTK_CONTAINER (object);
   
   if (GTK_CONTAINER_RESIZE_PENDING (container))
-    {
-      container_resize_queue = g_slist_remove (container_resize_queue, container);
-      GTK_PRIVATE_UNSET_FLAG (container, GTK_RESIZE_PENDING);
-    }
-  gtk_container_clear_resize_widgets (container);
+    gtk_container_dequeue_resize_handler (container);
+  if (container->resize_widgets)
+    gtk_container_clear_resize_widgets (container);
   
-  gtk_container_foreach (container,
-                        (GtkCallback) gtk_widget_destroy, NULL);
+  gtk_container_foreach (container, (GtkCallback) gtk_widget_destroy, NULL);
   
   if (GTK_OBJECT_CLASS (parent_class)->destroy)
     (* GTK_OBJECT_CLASS (parent_class)->destroy) (object);
@@ -634,11 +645,14 @@ gtk_container_set_arg (GtkObject    *object,
   switch (arg_id)
     {
     case ARG_BORDER_WIDTH:
-      gtk_container_border_width (container, GTK_VALUE_ULONG (*arg));
+      gtk_container_set_border_width (container, GTK_VALUE_UINT (*arg));
       break;
     case ARG_RESIZE_MODE:
       gtk_container_set_resize_mode (container, GTK_VALUE_ENUM (*arg));
       break;
+    case ARG_REALLOCATE_REDRAWS:
+      gtk_container_set_reallocate_redraws (container, GTK_VALUE_BOOL (*arg));
+      break;
     case ARG_CHILD:
       gtk_container_add (container, GTK_WIDGET (GTK_VALUE_OBJECT (*arg)));
       break;
@@ -659,20 +673,37 @@ gtk_container_get_arg (GtkObject    *object,
   switch (arg_id)
     {
     case ARG_BORDER_WIDTH:
-      GTK_VALUE_ULONG (*arg) = container->border_width;
+      GTK_VALUE_UINT (*arg) = container->border_width;
       break;
     case ARG_RESIZE_MODE:
       GTK_VALUE_ENUM (*arg) = container->resize_mode;
       break;
+    case ARG_REALLOCATE_REDRAWS:
+      GTK_VALUE_BOOL (*arg) = container->reallocate_redraws;
+      break;
     default:
       arg->type = GTK_TYPE_INVALID;
       break;
     }
 }
 
+/**
+ * gtk_container_set_border_width:
+ * @container: a #GtkContainer
+ * @border_width: amount of blank space to leave <emphasis>outside</emphasis> the container
+ *
+ * The border width of a container is the amount of space to leave
+ * around the outside of the container. The only exception to this is
+ * #GtkWindow; because toplevel windows can't leave space outside,
+ * they leave the space inside. The border is added on all sides of
+ * the container. To add space to only one side, one approach is to
+ * create a #GtkAlignment widget, call gtk_widget_set_usize() to give
+ * it a size, and place it on the side of the container as a spacer.
+ * 
+ **/
 void
-gtk_container_border_width (GtkContainer *container,
-                           guint         border_width)
+gtk_container_set_border_width (GtkContainer *container,
+                               guint         border_width)
 {
   g_return_if_fail (container != NULL);
   g_return_if_fail (GTK_IS_CONTAINER (container));
@@ -686,6 +717,20 @@ gtk_container_border_width (GtkContainer *container,
     }
 }
 
+/**
+ * gtk_container_add:
+ * @container: a #GtkContainer
+ * @widget: a widget to be placed inside @container
+ * 
+ * Adds @widget to @container. Typically used for simple containers
+ * such as #GtkWindow, #GtkFrame, or #GtkButton; for more complicated
+ * layout containers such as #GtkBox or #GtkTable, this function will
+ * pick default packing parameters that may not be correct.  So
+ * consider functions such as gtk_box_pack_start() and
+ * gtk_table_attach() as an alternative to gtk_container_add() in
+ * those cases. A widget may be added to only one container at a time;
+ * you can't place the same widget inside two different containers.
+ **/
 void
 gtk_container_add (GtkContainer *container,
                   GtkWidget    *widget)
@@ -694,11 +739,32 @@ gtk_container_add (GtkContainer *container,
   g_return_if_fail (GTK_IS_CONTAINER (container));
   g_return_if_fail (widget != NULL);
   g_return_if_fail (GTK_IS_WIDGET (widget));
-  g_return_if_fail (widget->parent == NULL);
+
+  if (widget->parent != NULL)
+    {
+      g_warning ("Attempting to add a widget with type %s to a container of "
+                 "type %s, but the widget is already inside a container of type %s",
+                 g_type_name (G_OBJECT_TYPE (widget)),
+                 g_type_name (G_OBJECT_TYPE (container)),
+                 g_type_name (G_OBJECT_TYPE (widget->parent)));
+      return;
+    }
 
   gtk_signal_emit (GTK_OBJECT (container), container_signals[ADD], widget);
 }
 
+/**
+ * gtk_container_remove:
+ * @container: a #GtkContainer
+ * @widget: a current child of @container
+ * 
+ * Removes @widget from @container. @widget must be inside @container.
+ * Note that @container will own a reference to @widget, and that this
+ * may be the last reference held; so removing a widget from its
+ * container can destroy that widget. If you want to use @widget
+ * again, you need to add a reference to it while it's not inside
+ * a container, using g_object_ref().
+ **/
 void
 gtk_container_remove (GtkContainer *container,
                      GtkWidget    *widget)
@@ -713,31 +779,13 @@ gtk_container_remove (GtkContainer *container,
 }
 
 void
-gtk_container_disable_resize (GtkContainer *container)
+gtk_container_dequeue_resize_handler (GtkContainer *container)
 {
-  g_warning ("gtk_container_disable_resize does nothing!");
-}
-
-void
-gtk_container_enable_resize (GtkContainer *container)
-{
-  g_warning ("gtk_container_enable_resize does nothing!");
-}
-
-void
-gtk_container_block_resize (GtkContainer *container)
-{
-  g_return_if_fail (container != NULL);
   g_return_if_fail (GTK_IS_CONTAINER (container));
+  g_return_if_fail (GTK_CONTAINER_RESIZE_PENDING (container));
 
-}
-
-void
-gtk_container_unblock_resize (GtkContainer *container)
-{
-  g_return_if_fail (container != NULL);
-  g_return_if_fail (GTK_IS_CONTAINER (container));
-  
+  container_resize_queue = g_slist_remove (container_resize_queue, container);
+  GTK_PRIVATE_UNSET_FLAG (container, GTK_RESIZE_PENDING);
 }
 
 void
@@ -750,11 +798,6 @@ gtk_container_clear_resize_widgets (GtkContainer *container)
 
   node = container->resize_widgets;
 
-  if (node)
-    gtk_signal_disconnect_by_func (GTK_OBJECT (container),
-                                  GTK_SIGNAL_FUNC (gtk_container_clear_resize_widgets),
-                                  NULL);
-
   while (node)
     {
       GtkWidget *widget = node->data;
@@ -793,11 +836,19 @@ gtk_container_set_resize_mode (GtkContainer  *container,
     }
 }
 
-gint    
-gtk_container_need_resize (GtkContainer     *container)
+void
+gtk_container_set_reallocate_redraws (GtkContainer *container,
+                                     gboolean      needs_redraws)
 {
-  gtk_container_check_resize (container);
-  return FALSE;
+  g_return_if_fail (GTK_IS_CONTAINER (container));
+
+  needs_redraws = needs_redraws ? TRUE : FALSE;
+  if (needs_redraws != container->reallocate_redraws)
+    {
+      container->reallocate_redraws = needs_redraws;
+      if (container->reallocate_redraws)
+       gtk_widget_queue_draw (GTK_WIDGET (container));
+    }
 }
 
 static GtkContainer*
@@ -820,11 +871,13 @@ gtk_container_get_resize_container (GtkContainer *container)
 static gboolean
 gtk_container_idle_sizer (gpointer data)
 {
+  GDK_THREADS_ENTER ();
+
   /* we may be invoked with a container_resize_queue of NULL, because
    * queue_resize could have been adding an extra idle function while
    * the queue still got processed. we better just ignore such case
    * than trying to explicitely work around them with some extra flags,
-   * sine it doesn't cause any actual harm.
+   * since it doesn't cause any actual harm.
    */
   while (container_resize_queue)
     {
@@ -839,7 +892,11 @@ gtk_container_idle_sizer (gpointer data)
       GTK_PRIVATE_UNSET_FLAG (widget, GTK_RESIZE_PENDING);
       gtk_container_check_resize (GTK_CONTAINER (widget));
     }
-  
+
+  gdk_window_process_all_updates ();
+
+  GDK_THREADS_LEAVE ();
+
   return FALSE;
 }
 
@@ -851,18 +908,23 @@ gtk_container_queue_resize (GtkContainer *container)
   g_return_if_fail (container != NULL);
   g_return_if_fail (GTK_IS_CONTAINER (container));
 
+  /* clear resize widgets for resize containers
+   * before aborting prematurely. this is especially
+   * important for toplevels which may need imemdiate
+   * processing or their resize handler to be queued.
+   */
+  if (GTK_IS_RESIZE_CONTAINER (container))
+    gtk_container_clear_resize_widgets (container);
   if (GTK_OBJECT_DESTROYED (container) ||
       GTK_WIDGET_RESIZE_NEEDED (container))
     return;
-
-  if (GTK_IS_RESIZE_CONTAINER (container))
-    gtk_container_clear_resize_widgets (container);
-
+  
   resize_container = gtk_container_get_resize_container (container);
-
+  
   if (resize_container)
     {
-      if (GTK_WIDGET_VISIBLE (resize_container))
+      if (GTK_WIDGET_VISIBLE (resize_container) &&
+         (GTK_WIDGET_TOPLEVEL (resize_container) || GTK_WIDGET_DRAWABLE (resize_container)))
        {
          switch (resize_container->resize_mode)
            {
@@ -871,47 +933,36 @@ gtk_container_queue_resize (GtkContainer *container)
                {
                  GTK_PRIVATE_SET_FLAG (resize_container, GTK_RESIZE_PENDING);
                  if (container_resize_queue == NULL)
-                   gtk_idle_add_priority (GTK_PRIORITY_INTERNAL - 1,
+                   gtk_idle_add_priority (GTK_PRIORITY_RESIZE,
                                           gtk_container_idle_sizer,
                                           NULL);
                  container_resize_queue = g_slist_prepend (container_resize_queue, resize_container);
                }
              
              GTK_PRIVATE_SET_FLAG (container, GTK_RESIZE_NEEDED);
-             if (!resize_container->resize_widgets)
-               gtk_signal_connect (GTK_OBJECT (resize_container),
-                                   "size_allocate",
-                                   GTK_SIGNAL_FUNC (gtk_container_clear_resize_widgets),
-                                   NULL);
              resize_container->resize_widgets =
                g_slist_prepend (resize_container->resize_widgets, container);
              break;
 
            case GTK_RESIZE_IMMEDIATE:
              GTK_PRIVATE_SET_FLAG (container, GTK_RESIZE_NEEDED);
-             if (!resize_container->resize_widgets)
-               gtk_signal_connect (GTK_OBJECT (resize_container),
-                                   "size_allocate",
-                                   GTK_SIGNAL_FUNC (gtk_container_clear_resize_widgets),
-                                   NULL);
              resize_container->resize_widgets =
                g_slist_prepend (resize_container->resize_widgets, container);
              gtk_container_check_resize (resize_container);
              break;
 
            case GTK_RESIZE_PARENT:
-             /* Ignore */
+             /* Ignore, should not be reached */
              break;
            }
        }
       else
        {
-         /* We need to let hidden toplevels know that something
-          * changed while they where hidden. For other resize containers,
-          * they will get resized when they are shown.
+         /* we need to let hidden resize containers know that something
+          * changed while they where hidden (currently only evaluated by
+          * toplevels).
           */
-         if (GTK_WIDGET_TOPLEVEL (resize_container))
-           gtk_container_check_resize (resize_container);
+         resize_container->need_resize = TRUE;
        }
     }
 }
@@ -921,7 +972,7 @@ gtk_container_check_resize (GtkContainer *container)
 {
   g_return_if_fail (container != NULL);
   g_return_if_fail (GTK_IS_CONTAINER (container));
-
+  
   gtk_signal_emit (GTK_OBJECT (container), container_signals[CHECK_RESIZE]);
 }
 
@@ -929,23 +980,21 @@ static void
 gtk_container_real_check_resize (GtkContainer *container)
 {
   GtkWidget *widget;
+  GtkRequisition requisition;
   
   g_return_if_fail (container != NULL);
   g_return_if_fail (GTK_IS_CONTAINER (container));
   
   widget = GTK_WIDGET (container);
   
-  gtk_widget_size_request (widget, &widget->requisition);
+  gtk_widget_size_request (widget, &requisition);
   
-  if (widget->requisition.width > widget->allocation.width ||
-      widget->requisition.height > widget->allocation.height)
+  if (requisition.width > widget->allocation.width ||
+      requisition.height > widget->allocation.height)
     {
       if (GTK_IS_RESIZE_CONTAINER (container))
-       {
-         gtk_widget_size_allocate (GTK_WIDGET (container),
-                                   &GTK_WIDGET (container)->allocation);
-         gtk_widget_queue_draw (GTK_WIDGET (container));
-       }
+       gtk_widget_size_allocate (GTK_WIDGET (container),
+                                 &GTK_WIDGET (container)->allocation);
       else
        gtk_widget_queue_resize (widget);
     }
@@ -996,7 +1045,7 @@ gtk_container_resize_children (GtkContainer *container)
    * which is not the case if we got another container queued for
    * a resize in our anchestry. also we can skip the whole
    * resize_widgets checks if we are a toplevel and NEED_RESIZE.
-   * this code implies that our allocation is sufficient for our
+   * this code assumes that our allocation is sufficient for our
    * requisition, since otherwise we would NEED_RESIZE.
    */
   resize_container = GTK_WIDGET (container);
@@ -1014,11 +1063,8 @@ gtk_container_resize_children (GtkContainer *container)
       if (resize_container->parent)
        gtk_container_queue_resize (container);
       else
-       {
-         gtk_widget_size_allocate (GTK_WIDGET (container),
-                                   &GTK_WIDGET (container)->allocation);
-         gtk_widget_queue_draw (GTK_WIDGET (container));
-       }
+       gtk_widget_size_allocate (GTK_WIDGET (container),
+                                 &GTK_WIDGET (container)->allocation);
       return;
     }
 
@@ -1029,10 +1075,6 @@ gtk_container_resize_children (GtkContainer *container)
    * is insufficient, since we don't need to reallocate below that.
    */
   resize_widgets = container->resize_widgets;
-  if (resize_widgets)
-    gtk_signal_disconnect_by_func (GTK_OBJECT (container),
-                                  GTK_SIGNAL_FUNC (gtk_container_clear_resize_widgets),
-                                  NULL);
   container->resize_widgets = NULL;
   for (node = resize_widgets; node; node = node->next)
     {
@@ -1089,25 +1131,70 @@ gtk_container_resize_children (GtkContainer *container)
       widget = node->data;
       
       GTK_PRIVATE_UNSET_FLAG (widget, GTK_RESIZE_NEEDED);
+
       gtk_widget_size_allocate (widget, &widget->allocation);
-      gtk_widget_queue_draw (widget);
+
       gtk_widget_unref (widget);
     }
   g_slist_free (resize_containers);
 }
 
+/**
+ * gtk_container_forall:
+ * @container: a #GtkContainer
+ * @callback: a callback
+ * @callback_data: callback user data
+ * 
+ * Invokes @callback on each child of @container, including children
+ * that are considered "internal" (implementation details of the
+ * container). "Internal" children generally weren't added by the user
+ * of the container, but were added by the container implementation
+ * itself.  Most applications should use gtk_container_foreach(),
+ * rather than gtk_container_forall().
+ **/
+void
+gtk_container_forall (GtkContainer *container,
+                     GtkCallback   callback,
+                     gpointer      callback_data)
+{
+  GtkContainerClass *class;
+
+  g_return_if_fail (container != NULL);
+  g_return_if_fail (GTK_IS_CONTAINER (container));
+  g_return_if_fail (callback != NULL);
+
+  class = GTK_CONTAINER_GET_CLASS (container);
+
+  if (class->forall)
+    class->forall (container, TRUE, callback, callback_data);
+}
+
+/**
+ * gtk_container_foreach:
+ * @container: a #GtkContainer
+ * @callback: a callback
+ * @callback_data: callback user data
+ * 
+ * Invokes @callback on each non-internal child of @container.  See
+ * gtk_container_forall() for details on what constitutes an
+ * "internal" child.  Most applications should use
+ * gtk_container_foreach(), rather than gtk_container_forall().
+ **/
 void
 gtk_container_foreach (GtkContainer *container,
                       GtkCallback   callback,
                       gpointer      callback_data)
 {
+  GtkContainerClass *class;
+  
   g_return_if_fail (container != NULL);
   g_return_if_fail (GTK_IS_CONTAINER (container));
   g_return_if_fail (callback != NULL);
 
-  gtk_signal_emit (GTK_OBJECT (container),
-                   container_signals[FOREACH],
-                   callback, callback_data);
+  class = GTK_CONTAINER_GET_CLASS (container);
+
+  if (class->forall)
+    class->forall (container, FALSE, callback, callback_data);
 }
 
 typedef struct _GtkForeachData GtkForeachData;
@@ -1127,8 +1214,8 @@ gtk_container_foreach_unmarshal (GtkWidget *child,
   
   /* first argument */
   args[0].name = NULL;
-  args[0].type = GTK_OBJECT(child)->klass->type;
-  GTK_VALUE_OBJECT(args[0]) = GTK_OBJECT (child);
+  args[0].type = GTK_OBJECT_TYPE (child);
+  GTK_VALUE_OBJECT (args[0]) = GTK_OBJECT (child);
   
   /* location for return value */
   args[1].name = NULL;
@@ -1137,16 +1224,6 @@ gtk_container_foreach_unmarshal (GtkWidget *child,
   fdata->callback (fdata->container, fdata->callback_data, 1, args);
 }
 
-void
-gtk_container_foreach_interp (GtkContainer       *container,
-                             GtkCallbackMarshal  marshal,
-                             gpointer            callback_data,
-                             GtkDestroyNotify    notify)
-{
-  gtk_container_foreach_full (container, NULL, marshal, 
-                             callback_data, notify);
-}
-
 void
 gtk_container_foreach_full (GtkContainer       *container,
                            GtkCallback         callback,
@@ -1178,7 +1255,7 @@ gtk_container_foreach_full (GtkContainer       *container,
     notify (callback_data);
 }
 
-gint
+gboolean
 gtk_container_focus (GtkContainer     *container,
                     GtkDirectionType  direction)
 {
@@ -1195,13 +1272,13 @@ gtk_container_focus (GtkContainer     *container,
 }
 
 void
-gtk_container_set_focus_child (GtkContainer     *container,
-                              GtkWidget          *widget)
+gtk_container_set_focus_child (GtkContainer *container,
+                              GtkWidget    *widget)
 {
   g_return_if_fail (container != NULL);
   g_return_if_fail (GTK_IS_CONTAINER (container));
   if (widget)
-    g_return_if_fail (GTK_IS_WIDGET (container));
+    g_return_if_fail (GTK_IS_WIDGET (widget));
 
   gtk_signal_emit (GTK_OBJECT (container), container_signals[SET_FOCUS_CHILD], widget);
 }
@@ -1220,17 +1297,81 @@ gtk_container_children (GtkContainer *container)
   return g_list_reverse (children);
 }
 
-void
-gtk_container_register_toplevel (GtkContainer *container)
+static void
+gtk_container_child_position_callback (GtkWidget *widget,
+                                      gpointer   client_data)
 {
-  gtk_widget_ref (GTK_WIDGET (container));
-  gtk_object_sink (GTK_OBJECT (container));
+  struct {
+    GtkWidget *child;
+    guint i;
+    guint index;
+  } *data = client_data;
+
+  data->i++;
+  if (data->child == widget)
+    data->index = data->i;
 }
 
-void
-gtk_container_unregister_toplevel (GtkContainer *container)
+static gchar*
+gtk_container_child_default_composite_name (GtkContainer *container,
+                                           GtkWidget    *child)
 {
-  gtk_widget_unref (GTK_WIDGET (container));
+  struct {
+    GtkWidget *child;
+    guint i;
+    guint index;
+  } data;
+  gchar *name;
+
+  /* fallback implementation */
+  data.child = child;
+  data.i = 0;
+  data.index = 0;
+  gtk_container_forall (container,
+                       gtk_container_child_position_callback,
+                       &data);
+  
+  name = g_strdup_printf ("%s-%u",
+                         gtk_type_name (GTK_OBJECT_TYPE (child)),
+                         data.index);
+
+  return name;
+}
+
+gchar*
+gtk_container_child_composite_name (GtkContainer *container,
+                                   GtkWidget    *child)
+{
+  g_return_val_if_fail (container != NULL, NULL);
+  g_return_val_if_fail (GTK_IS_CONTAINER (container), NULL);
+  g_return_val_if_fail (child != NULL, NULL);
+  g_return_val_if_fail (GTK_IS_WIDGET (child), NULL);
+  g_return_val_if_fail (child->parent == GTK_WIDGET (container), NULL);
+
+  if (GTK_WIDGET_COMPOSITE_CHILD (child))
+    {
+      static GQuark quark_composite_name = 0;
+      gchar *name;
+
+      if (!quark_composite_name)
+       quark_composite_name = g_quark_from_static_string ("gtk-composite-name");
+
+      name = gtk_object_get_data_by_id (GTK_OBJECT (child), quark_composite_name);
+      if (!name)
+       {
+         GtkContainerClass *class;
+
+         class = GTK_CONTAINER_GET_CLASS (container);
+         if (class->composite_name)
+           name = class->composite_name (container, child);
+       }
+      else
+       name = g_strdup (name);
+
+      return name;
+    }
+  
+  return NULL;
 }
 
 void
@@ -1274,7 +1415,7 @@ gtk_container_real_set_focus_child (GtkContainer     *container,
     }
 }
 
-static gint
+static gboolean
 gtk_container_real_focus (GtkContainer     *container,
                          GtkDirectionType  direction)
 {
@@ -1286,41 +1427,52 @@ gtk_container_real_focus (GtkContainer     *container,
   g_return_val_if_fail (container != NULL, FALSE);
   g_return_val_if_fail (GTK_IS_CONTAINER (container), FALSE);
 
-  /* Fail if the container is insensitive
+  /* Fail if the container is inappropriate for focus movement
    */
-  if (!GTK_WIDGET_SENSITIVE (container))
+  if (!GTK_WIDGET_DRAWABLE (container) ||
+      !GTK_WIDGET_IS_SENSITIVE (container))
     return FALSE;
 
   return_val = FALSE;
 
   if (GTK_WIDGET_CAN_FOCUS (container))
     {
-      gtk_widget_grab_focus (GTK_WIDGET (container));
-      return_val = TRUE;
+      if (!GTK_WIDGET_HAS_FOCUS (container))
+       {
+         gtk_widget_grab_focus (GTK_WIDGET (container));
+         return_val = TRUE;
+       }
     }
   else
     {
       /* Get a list of the containers children
        */
-      children = gtk_container_children (container);
+      children = NULL;
+      gtk_container_forall (container,
+                           gtk_container_children_callback,
+                           &children);
+      children = g_list_reverse (children);
+      /* children = gtk_container_children (container); */
 
       if (children)
        {
-         /* Remove any children which are insensitive
+         /* Remove any children which are inappropriate for focus movement
           */
          tmp_list = children;
          while (tmp_list)
            {
-             if (!GTK_WIDGET_SENSITIVE (tmp_list->data))
+             if (GTK_WIDGET_IS_SENSITIVE (tmp_list->data) &&
+                 GTK_WIDGET_DRAWABLE (tmp_list->data) &&
+                 (GTK_IS_CONTAINER (tmp_list->data) || GTK_WIDGET_CAN_FOCUS (tmp_list->data)))
+               tmp_list = tmp_list->next;
+             else
                {
                  tmp_list2 = tmp_list;
                  tmp_list = tmp_list->next;
-
+                 
                  children = g_list_remove_link (children, tmp_list2);
                  g_list_free_1 (tmp_list2);
                }
-             else
-               tmp_list = tmp_list->next;
            }
 
          switch (direction)
@@ -1331,11 +1483,11 @@ gtk_container_real_focus (GtkContainer     *container,
              break;
            case GTK_DIR_UP:
            case GTK_DIR_DOWN:
-             return_val = gtk_container_focus_up_down (container, children, direction);
+             return_val = gtk_container_focus_up_down (container, &children, direction);
              break;
            case GTK_DIR_LEFT:
            case GTK_DIR_RIGHT:
-             return_val = gtk_container_focus_left_right (container, children, direction);
+             return_val = gtk_container_focus_left_right (container, &children, direction);
              break;
            }
 
@@ -1346,7 +1498,7 @@ gtk_container_real_focus (GtkContainer     *container,
   return return_val;
 }
 
-static gint
+static gboolean
 gtk_container_focus_tab (GtkContainer     *container,
                         GList            *children,
                         GtkDirectionType  direction)
@@ -1417,227 +1569,285 @@ gtk_container_focus_tab (GtkContainer     *container,
   return gtk_container_focus_move (container, children, direction);
 }
 
-static gint
-gtk_container_focus_up_down (GtkContainer     *container,
-                            GList            *children,
-                            GtkDirectionType  direction)
+static gboolean
+old_focus_coords (GtkContainer *container, GdkRectangle *old_focus_rect)
 {
-  GtkWidget *child;
-  GtkWidget *child2;
-  GList *tmp_list;
-  gint dist1, dist2;
-  gint focus_x;
-  gint focus_width;
-  guint length;
-  guint i, j;
-
-  /* return failure if there isn't a focus child */
-  if (container->focus_child)
+  GtkWidget *widget = GTK_WIDGET (container);
+  GtkWidget *toplevel = gtk_widget_get_toplevel (widget);
+  
+  if (toplevel &&
+      GTK_IS_WINDOW (toplevel) && GTK_WINDOW (toplevel)->focus_widget &&
+      GTK_WIDGET_REALIZED (container) &&
+      GTK_WIDGET_REALIZED (GTK_WINDOW (toplevel)->focus_widget))
     {
-      focus_width = container->focus_child->allocation.width / 2;
-      focus_x = container->focus_child->allocation.x + focus_width;
+      GtkWidget *old_focus = GTK_WINDOW (toplevel)->focus_widget;
+      GdkWindow *old_parent_window = old_focus->parent ? old_focus->parent->window : old_focus->window;
+      GdkWindow *new_parent_window = widget->window;
+      GdkWindow *toplevel_window = toplevel->window;
+      
+      *old_focus_rect = old_focus->allocation;
+      
+      /* Translate coordinates to the toplevel */
+      
+      while (old_parent_window != toplevel_window)
+       {
+         gint dx, dy;
+         
+         gdk_window_get_position (old_parent_window, &dx, &dy);
+         
+         old_focus_rect->x += dx;
+         old_focus_rect->y += dy;
+         
+         old_parent_window = gdk_window_get_parent (old_parent_window);
+       }
+      
+      /* Translate coordinates back to the new container */
+      
+      while (new_parent_window != toplevel_window)
+       {
+         gint dx, dy;
+         
+         gdk_window_get_position (new_parent_window, &dx, &dy);
+         
+         old_focus_rect->x -= dx;
+         old_focus_rect->y -= dy;
+         
+         new_parent_window = gdk_window_get_parent (new_parent_window);
+       }
+
+      return TRUE;
     }
-  else
+
+  return FALSE;
+}
+
+typedef struct _CompareInfo CompareInfo;
+
+struct _CompareInfo
+{
+  gint x;
+  gint y;
+};
+
+static gint
+up_down_compare (gconstpointer a,
+                gconstpointer b,
+                gpointer      data)
+{
+  const GtkWidget *child1 = a;
+  const GtkWidget *child2 = b;
+  CompareInfo *compare = data;
+
+  gint y1 = child1->allocation.y + child1->allocation.height / 2;
+  gint y2 = child2->allocation.y + child2->allocation.height / 2;
+
+  if (y1 == y2)
     {
-      focus_width = GTK_WIDGET (container)->allocation.width;
-      if (GTK_WIDGET_NO_WINDOW (container))
-       focus_x = GTK_WIDGET (container)->allocation.x;
+      gint x1 = abs (child1->allocation.x + child1->allocation.width / 2 - compare->x);
+      gint x2 = abs (child2->allocation.x + child2->allocation.width / 2 - compare->x);
+
+      if (compare->y < y1)
+       return (x1 < x2) ? -1 : ((x1 == x2) ? 0 : 1);
       else
-       focus_x = 0;
+       return (x1 < x2) ? 1 : ((x1 == x2) ? 0 : -1);
     }
+  else
+    return (y1 < y2) ? -1 : 1;
+}
 
-  length = g_list_length (children);
+static gboolean
+gtk_container_focus_up_down (GtkContainer     *container,
+                            GList           **children,
+                            GtkDirectionType  direction)
+{
+  CompareInfo compare;
+  GList *tmp_list;
 
-  /* sort the children in the y direction */
-  for (i = 1; i < length; i++)
+  if (container->focus_child)
     {
-      j = i;
-      tmp_list = g_list_nth (children, j);
-      child = tmp_list->data;
+      gint compare_x1;
+      gint compare_x2;
+      gint compare_y;
+      
+      /* Delete widgets from list that don't match minimum criteria */
 
-      while (j > 0)
+      compare_x1 = container->focus_child->allocation.x;
+      compare_x2 = container->focus_child->allocation.x + container->focus_child->allocation.width;
+
+      if (direction == GTK_DIR_UP)
+       compare_y = container->focus_child->allocation.y;
+      else
+       compare_y = container->focus_child->allocation.y + container->focus_child->allocation.height;
+      
+      tmp_list = *children;
+      while (tmp_list)
        {
-         child2 = tmp_list->prev->data;
-         if (child->allocation.y < child2->allocation.y)
+         GtkWidget *child = tmp_list->data;
+         GList *next = tmp_list->next;
+         gint child_x1, child_x2;
+         
+         if (child != container->focus_child)
            {
-             tmp_list->data = tmp_list->prev->data;
-             tmp_list = tmp_list->prev;
-             j--;
+             child_x1 = child->allocation.x;
+             child_x2 = child->allocation.x + child->allocation.width;
+             
+             if ((child_x2 <= compare_x1 || child_x1 >= compare_x2) /* No horizontal overlap */ ||
+                 (direction == GTK_DIR_DOWN && child->allocation.y + child->allocation.height < compare_y) || /* Not below */
+                 (direction == GTK_DIR_UP && child->allocation.y > compare_y)) /* Not above */
+               {
+                 *children = g_list_delete_link (*children, tmp_list);
+               }
            }
-         else
-           break;
+         
+         tmp_list = next;
        }
 
-      tmp_list->data = child;
+      compare.x = (compare_x1 + compare_x2) / 2;
+      compare.y = container->focus_child->allocation.y + container->focus_child->allocation.height / 2;
     }
-
-  /* sort the children in distance in the x direction
-   *  in distance from the current focus child while maintaining the
-   *  sort in the y direction
-   */
-  for (i = 1; i < length; i++)
+  else
     {
-      j = i;
-      tmp_list = g_list_nth (children, j);
-      child = tmp_list->data;
-      dist1 = (child->allocation.x + child->allocation.width / 2) - focus_x;
+      /* No old focus widget, need to figure out starting x,y some other way
+       */
+      GtkWidget *widget = GTK_WIDGET (container);
+      GdkRectangle old_focus_rect;
 
-      while (j > 0)
+      if (old_focus_coords (container, &old_focus_rect))
        {
-         child2 = tmp_list->prev->data;
-         dist2 = (child2->allocation.x + child2->allocation.width / 2) - focus_x;
-
-         if ((dist1 < dist2) &&
-             (child->allocation.y >= child2->allocation.y))
-           {
-             tmp_list->data = tmp_list->prev->data;
-             tmp_list = tmp_list->prev;
-             j--;
-           }
+         compare.x = old_focus_rect.x + old_focus_rect.width / 2;
+       }
+      else
+       {
+         if (GTK_WIDGET_NO_WINDOW (widget))
+           compare.x = widget->allocation.x + widget->allocation.width / 2;
          else
-           break;
+           compare.x = widget->allocation.width / 2;
        }
-
-      tmp_list->data = child;
+      
+      if (GTK_WIDGET_NO_WINDOW (widget))
+       compare.y = (direction == GTK_DIR_DOWN) ? widget->allocation.y : widget->allocation.y + widget->allocation.height;
+      else
+       compare.y = (direction == GTK_DIR_DOWN) ? 0 : + widget->allocation.height;
     }
 
-  /* go and invalidate any widget which is too
-   *  far from the focus widget.
-   */
-  if (!container->focus_child &&
-      (direction == GTK_DIR_UP))
-    focus_x += focus_width;
+  *children = g_list_sort_with_data (*children, up_down_compare, &compare);
 
-  tmp_list = children;
-  while (tmp_list)
-    {
-      child = tmp_list->data;
+  if (direction == GTK_DIR_UP)
+    *children = g_list_reverse (*children);
 
-      dist1 = (child->allocation.x + child->allocation.width / 2) - focus_x;
-      if (((direction == GTK_DIR_DOWN) && (dist1 < 0)) ||
-         ((direction == GTK_DIR_UP) && (dist1 > 0)))
-       tmp_list->data = NULL;
+  return gtk_container_focus_move (container, *children, direction);
+}
 
-      tmp_list = tmp_list->next;
-    }
+static gint
+left_right_compare (gconstpointer a,
+                   gconstpointer b,
+                   gpointer      data)
+{
+  const GtkWidget *child1 = a;
+  const GtkWidget *child2 = b;
+  CompareInfo *compare = data;
 
-  if (direction == GTK_DIR_UP)
-    children = g_list_reverse (children);
+  gint x1 = child1->allocation.x + child1->allocation.width / 2;
+  gint x2 = child2->allocation.x + child2->allocation.width / 2;
 
-  return gtk_container_focus_move (container, children, direction);
+  if (x1 == x2)
+    {
+      gint y1 = abs (child1->allocation.y + child1->allocation.height / 2 - compare->y);
+      gint y2 = abs (child2->allocation.y + child2->allocation.height / 2 - compare->y);
+
+      if (compare->x < x1)
+       return (y1 < y2) ? -1 : ((y1 == y2) ? 0 : 1);
+      else
+       return (y1 < y2) ? 1 : ((y1 == y2) ? 0 : -1);
+    }
+  else
+    return (x1 < x2) ? -1 : 1;
 }
 
-static gint
+static gboolean
 gtk_container_focus_left_right (GtkContainer     *container,
-                               GList            *children,
+                               GList           **children,
                                GtkDirectionType  direction)
 {
-  GtkWidget *child;
-  GtkWidget *child2;
+  CompareInfo compare;
   GList *tmp_list;
-  gint dist1, dist2;
-  gint focus_y;
-  gint focus_height;
-  guint length;
-  guint i, j;
 
-  /* return failure if there isn't a focus child */
   if (container->focus_child)
     {
-      focus_height = container->focus_child->allocation.height / 2;
-      focus_y = container->focus_child->allocation.y + focus_height;
-    }
-  else
-    {
-      focus_height = GTK_WIDGET (container)->allocation.height;
-      if (GTK_WIDGET_NO_WINDOW (container))
-       focus_y = GTK_WIDGET (container)->allocation.y;
-      else
-       focus_y = 0;
-    }
+      gint compare_y1;
+      gint compare_y2;
+      gint compare_x;
+      
+      /* Delete widgets from list that don't match minimum criteria */
 
-  length = g_list_length (children);
+      compare_y1 = container->focus_child->allocation.y;
+      compare_y2 = container->focus_child->allocation.y + container->focus_child->allocation.height;
 
-  /* sort the children in the x direction */
-  for (i = 1; i < length; i++)
-    {
-      j = i;
-      tmp_list = g_list_nth (children, j);
-      child = tmp_list->data;
-
-      while (j > 0)
+      if (direction == GTK_DIR_LEFT)
+       compare_x = container->focus_child->allocation.x;
+      else
+       compare_x = container->focus_child->allocation.x + container->focus_child->allocation.width;
+      
+      tmp_list = *children;
+      while (tmp_list)
        {
-         child2 = tmp_list->prev->data;
-         if (child->allocation.x < child2->allocation.x)
+         GtkWidget *child = tmp_list->data;
+         GList *next = tmp_list->next;
+         gint child_y1, child_y2;
+         
+         if (child != container->focus_child)
            {
-             tmp_list->data = tmp_list->prev->data;
-             tmp_list = tmp_list->prev;
-             j--;
+             child_y1 = child->allocation.y;
+             child_y2 = child->allocation.y + child->allocation.height;
+             
+             if ((child_y2 <= compare_y1 || child_y1 >= compare_y2) /* No vertical overlap */ ||
+                 (direction == GTK_DIR_RIGHT && child->allocation.x + child->allocation.width < compare_x) || /* Not to left */
+                 (direction == GTK_DIR_LEFT && child->allocation.x > compare_x)) /* Not to right */
+               {
+                 *children = g_list_delete_link (*children, tmp_list);
+               }
            }
-         else
-           break;
+         
+         tmp_list = next;
        }
 
-      tmp_list->data = child;
+      compare.y = (compare_y1 + compare_y2) / 2;
+      compare.x = container->focus_child->allocation.x + container->focus_child->allocation.width / 2;
     }
-
-  /* sort the children in distance in the y direction
-   *  in distance from the current focus child while maintaining the
-   *  sort in the x direction
-   */
-  for (i = 1; i < length; i++)
+  else
     {
-      j = i;
-      tmp_list = g_list_nth (children, j);
-      child = tmp_list->data;
-      dist1 = (child->allocation.y + child->allocation.height / 2) - focus_y;
+      /* No old focus widget, need to figure out starting x,y some other way
+       */
+      GtkWidget *widget = GTK_WIDGET (container);
+      GdkRectangle old_focus_rect;
 
-      while (j > 0)
+      if (old_focus_coords (container, &old_focus_rect))
        {
-         child2 = tmp_list->prev->data;
-         dist2 = (child2->allocation.y + child2->allocation.height / 2) - focus_y;
-
-         if ((dist1 < dist2) &&
-             (child->allocation.x >= child2->allocation.x))
-           {
-             tmp_list->data = tmp_list->prev->data;
-             tmp_list = tmp_list->prev;
-             j--;
-           }
+         compare.y = old_focus_rect.y + old_focus_rect.height / 2;
+       }
+      else
+       {
+         if (GTK_WIDGET_NO_WINDOW (widget))
+           compare.y = widget->allocation.y + widget->allocation.height / 2;
          else
-           break;
+           compare.y = widget->allocation.height / 2;
        }
-
-      tmp_list->data = child;
+      
+      if (GTK_WIDGET_NO_WINDOW (widget))
+       compare.x = (direction == GTK_DIR_RIGHT) ? widget->allocation.x : widget->allocation.x + widget->allocation.width;
+      else
+       compare.x = (direction == GTK_DIR_RIGHT) ? 0 : widget->allocation.width;
     }
 
-  /* go and invalidate any widget which is too
-   *  far from the focus widget.
-   */
-  if (!container->focus_child &&
-      (direction == GTK_DIR_LEFT))
-    focus_y += focus_height;
-
-  tmp_list = children;
-  while (tmp_list)
-    {
-      child = tmp_list->data;
-
-      dist1 = (child->allocation.y + child->allocation.height / 2) - focus_y;
-      if (((direction == GTK_DIR_RIGHT) && (dist1 < 0)) ||
-         ((direction == GTK_DIR_LEFT) && (dist1 > 0)))
-       tmp_list->data = NULL;
-
-      tmp_list = tmp_list->next;
-    }
+  *children = g_list_sort_with_data (*children, left_right_compare, &compare);
 
   if (direction == GTK_DIR_LEFT)
-    children = g_list_reverse (children);
+    *children = g_list_reverse (*children);
 
-  return gtk_container_focus_move (container, children, direction);
+  return gtk_container_focus_move (container, *children, direction);
 }
 
-static gint
+static gboolean
 gtk_container_focus_move (GtkContainer     *container,
                          GList            *children,
                          GtkDirectionType  direction)
@@ -1646,7 +1856,6 @@ gtk_container_focus_move (GtkContainer     *container,
   GtkWidget *child;
 
   focus_child = container->focus_child;
-  gtk_container_set_focus_child (container, NULL);
 
   while (children)
     {
@@ -1662,14 +1871,13 @@ gtk_container_focus_move (GtkContainer     *container,
             {
               focus_child = NULL;
 
-              if (GTK_WIDGET_VISIBLE (child) &&
-                 GTK_IS_CONTAINER (child) &&
-                 !GTK_WIDGET_HAS_FOCUS (child))
+              if (GTK_WIDGET_DRAWABLE (child) &&
+                 GTK_IS_CONTAINER (child))
                if (gtk_container_focus (GTK_CONTAINER (child), direction))
                  return TRUE;
             }
         }
-      else if (GTK_WIDGET_VISIBLE (child))
+      else if (GTK_WIDGET_DRAWABLE (child))
         {
          if (GTK_IS_CONTAINER (child))
             {
@@ -1698,41 +1906,6 @@ gtk_container_children_callback (GtkWidget *widget,
   *children = g_list_prepend (*children, widget);
 }
 
-static void
-gtk_container_show_all (GtkWidget *widget)
-{
-  GtkContainer *container;
-
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_CONTAINER (widget));
-  container = GTK_CONTAINER (widget);
-
-  /* First show children, then self.
-     This makes sure that toplevel windows get shown as last widget.
-     Otherwise the user would see the widgets get
-     visible one after another.
-  */
-  gtk_container_foreach (container, (GtkCallback) gtk_widget_show_all, NULL);
-  gtk_widget_show (widget);
-}
-
-
-static void
-gtk_container_hide_all (GtkWidget *widget)
-{
-  GtkContainer *container;
-
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_CONTAINER (widget));
-  container = GTK_CONTAINER (widget);
-
-  /* First hide self, then children.
-     This is the reverse order of gtk_container_show_all.
-  */
-  gtk_widget_hide (widget);  
-  gtk_container_foreach (container, (GtkCallback) gtk_widget_hide_all, NULL);
-}
-
 void
 gtk_container_set_focus_vadjustment (GtkContainer  *container,
                                     GtkAdjustment *adjustment)
@@ -1768,3 +1941,120 @@ gtk_container_set_focus_hadjustment (GtkContainer  *container,
                                  adjustment,
                                  (GtkDestroyNotify) gtk_object_unref);
 }
+
+
+static void
+gtk_container_show_all (GtkWidget *widget)
+{
+  g_return_if_fail (widget != NULL);
+  g_return_if_fail (GTK_IS_CONTAINER (widget));
+
+  gtk_container_foreach (GTK_CONTAINER (widget),
+                        (GtkCallback) gtk_widget_show_all,
+                        NULL);
+  gtk_widget_show (widget);
+}
+
+static void
+gtk_container_hide_all (GtkWidget *widget)
+{
+  g_return_if_fail (widget != NULL);
+  g_return_if_fail (GTK_IS_CONTAINER (widget));
+
+  gtk_widget_hide (widget);
+  gtk_container_foreach (GTK_CONTAINER (widget),
+                        (GtkCallback) gtk_widget_hide_all,
+                        NULL);
+}
+
+
+static void
+gtk_container_expose_child (GtkWidget *child,
+                           gpointer   client_data)
+{
+  struct {
+    GtkWidget *container;
+    GdkEventExpose *event;
+  } *data = client_data;
+  
+  gtk_container_propagate_expose (GTK_CONTAINER (data->container),
+                                 child,
+                                 data->event);
+}
+
+static gint 
+gtk_container_expose (GtkWidget      *widget,
+                     GdkEventExpose *event)
+{
+  struct {
+    GtkWidget *container;
+    GdkEventExpose *event;
+  } data;
+
+  g_return_val_if_fail (widget != NULL, FALSE);
+  g_return_val_if_fail (GTK_IS_CONTAINER (widget), FALSE);
+  g_return_val_if_fail (event != NULL, FALSE);
+
+  
+  if (GTK_WIDGET_DRAWABLE (widget)) 
+    {
+      data.container = widget;
+      data.event = event;
+      
+      gtk_container_foreach (GTK_CONTAINER (widget),
+                            gtk_container_expose_child,
+                            &data);
+    }   
+  
+  return TRUE;
+}
+
+
+/**
+ * gtk_container_propagate_expose:
+ * @container: a #GtkContainer
+ * @child: a child of @container
+ * @event: a expose event sent to container
+ *
+ *  When a container receives an expose event, it must send synthetic
+ * expose events to all children that don't have their own GdkWindows.
+ * This function provides a convenient way of doing this. A container,
+ * when it receives an expose event, gtk_container_propagate_expose() 
+ * once for each child, passing in the event the container received.
+ *
+ * gtk_container_propagate expose() takes care of deciding whether
+ * an expose event needs to be sent to the child, intersecting
+ * the event's area with the child area, and sending the event.
+ * 
+ * In most cases, a container can simply either simply inherit the
+ * ::expose implementation from GtkContainer, or, do some drawing 
+ * and then chain to the ::expose implementation from GtkContainer.
+ **/
+void
+gtk_container_propagate_expose (GtkContainer   *container,
+                               GtkWidget      *child,
+                               GdkEventExpose *event)
+{
+  GdkEventExpose child_event;
+
+  g_return_if_fail (GTK_IS_CONTAINER (container));
+  g_return_if_fail (GTK_IS_WIDGET (child));
+  g_return_if_fail (event != NULL);
+
+  g_assert (child->parent == GTK_WIDGET (container));
+  
+  if (GTK_WIDGET_DRAWABLE (child) &&
+      GTK_WIDGET_NO_WINDOW (child) &&
+      (child->window == event->window))
+    {
+      child_event = *event;
+
+      child_event.region = gtk_widget_region_intersect (child, event->region);
+      if (!gdk_region_empty (child_event.region))
+       {
+         gdk_region_get_clipbox (child_event.region, &child_event.area);
+         gtk_widget_send_expose (child, (GdkEvent *)&child_event);
+       }
+      gdk_region_destroy (child_event.region);
+    }
+}