]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtkcellrenderercombo.c
Seal priv pointer in GtkPrinter.
[~andy/gtk] / gtk / gtkcellrenderercombo.c
index e03a4873cc92c666687daf4ff2b25cc4878531b6..104dbb5b6c1ae99e6448759ef193c15ad496911a 100644 (file)
 #include "gtkcellrenderertext.h"
 #include "gtkcombobox.h"
 #include "gtkcomboboxentry.h"
+#include "gtkmarshalers.h"
+#include "gtkprivate.h"
+#include "gtkalias.h"
+
+
+#define GTK_CELL_RENDERER_COMBO_GET_PRIVATE(obj) (G_TYPE_INSTANCE_GET_PRIVATE ((obj), GTK_TYPE_CELL_RENDERER_COMBO, GtkCellRendererComboPrivate))
+
+typedef struct _GtkCellRendererComboPrivate GtkCellRendererComboPrivate;
+struct _GtkCellRendererComboPrivate
+{
+  GtkWidget *combo;
+};
+
 
 static void gtk_cell_renderer_combo_class_init (GtkCellRendererComboClass *klass);
 static void gtk_cell_renderer_combo_init       (GtkCellRendererCombo      *self);
+static void gtk_cell_renderer_combo_finalize     (GObject      *object);
 static void gtk_cell_renderer_combo_get_property (GObject      *object,
                                                  guint         prop_id,
                                                  GValue       *value,
@@ -56,37 +70,16 @@ enum {
   PROP_HAS_ENTRY
 };
 
-static GObjectClass *parent_class = NULL;
+enum {
+  CHANGED,
+  LAST_SIGNAL
+};
+
+static guint cell_renderer_combo_signals[LAST_SIGNAL] = { 0, };
 
 #define GTK_CELL_RENDERER_COMBO_PATH "gtk-cell-renderer-combo-path"
 
-GType
-gtk_cell_renderer_combo_get_type (void)
-{
-  static GType gtk_cell_renderer_combo_type = 0;
-
-  if (!gtk_cell_renderer_combo_type)
-    {
-      static const GTypeInfo gtk_cell_renderer_combo_info = 
-       {
-         sizeof (GtkCellRendererComboClass),
-         (GBaseInitFunc)     NULL,
-         (GBaseFinalizeFunc) NULL,
-         (GClassInitFunc)    gtk_cell_renderer_combo_class_init,
-         NULL,
-         NULL,
-         sizeof (GtkCellRendererCombo),
-         0,
-         (GInstanceInitFunc) gtk_cell_renderer_combo_init
-       };
-      gtk_cell_renderer_combo_type =
-       g_type_register_static (GTK_TYPE_CELL_RENDERER_TEXT,
-                               "GtkCellRendererCombo",
-                               &gtk_cell_renderer_combo_info,
-                               0);
-    }
-  return gtk_cell_renderer_combo_type;
-}
+G_DEFINE_TYPE (GtkCellRendererCombo, gtk_cell_renderer_combo, GTK_TYPE_CELL_RENDERER_TEXT)
 
 static void
 gtk_cell_renderer_combo_class_init (GtkCellRendererComboClass *klass)
@@ -94,8 +87,7 @@ gtk_cell_renderer_combo_class_init (GtkCellRendererComboClass *klass)
   GObjectClass *object_class = G_OBJECT_CLASS (klass);
   GtkCellRendererClass *cell_class = GTK_CELL_RENDERER_CLASS (klass);
 
-  parent_class = g_type_class_peek_parent (klass);
-
+  object_class->finalize = gtk_cell_renderer_combo_finalize;
   object_class->get_property = gtk_cell_renderer_combo_get_property;
   object_class->set_property = gtk_cell_renderer_combo_set_property;
 
@@ -104,9 +96,8 @@ gtk_cell_renderer_combo_class_init (GtkCellRendererComboClass *klass)
   /**
    * GtkCellRendererCombo:model:
    *
-   * The :model property holds a tree model containing the possible
-   * values for the combo box. Use the :text_column property to specify
-   * the column holding the values.
+   * Holds a tree model containing the possible values for the combo box. 
+   * Use the text_column property to specify the column holding the values.
    * 
    * Since: 2.6
    */
@@ -116,46 +107,84 @@ gtk_cell_renderer_combo_class_init (GtkCellRendererComboClass *klass)
                                                        P_("Model"),
                                                        P_("The model containing the possible values for the combo box"),
                                                        GTK_TYPE_TREE_MODEL,
-                                                       G_PARAM_READWRITE));
+                                                       GTK_PARAM_READWRITE));
 
   /**
-   * GtkCellRendererCombo:text_column:
+   * GtkCellRendererCombo:text-column:
    *
-   * The :text_column property specifies the model column which
-   * holds the possible values for the combo box. Note that this
-   * refers to the model specified in the :model property, 
-   * <emphasis>not</emphasis> the model backing the tree view to 
-   * which this cell renderer is attached.
+   * Specifies the model column which holds the possible values for the 
+   * combo box. 
+   *
+   * Note that this refers to the model specified in the model property, 
+   * <emphasis>not</emphasis> the model backing the tree view to which 
+   * this cell renderer is attached.
    * 
+   * #GtkCellRendererCombo automatically adds a text cell renderer for 
+   * this column to its combo box.
+   *
    * Since: 2.6
    */
   g_object_class_install_property (object_class,
                                    PROP_TEXT_COLUMN,
-                                   g_param_spec_int ("text_column",
+                                   g_param_spec_int ("text-column",
                                                      P_("Text Column"),
                                                      P_("A column in the data source model to get the strings from"),
                                                      -1,
                                                      G_MAXINT,
                                                      -1,
-                                                     G_PARAM_READWRITE));
+                                                     GTK_PARAM_READWRITE));
 
   /** 
-   * GtkCellRendererCombo:has_entry:
+   * GtkCellRendererCombo:has-entry:
    *
-   * If the :has_entry property is %TRUe, the cell renderer will 
-   * include an entry and allow to enter values other than the ones 
-   * in the popup list. 
+   * If %TRUE, the cell renderer will include an entry and allow to enter 
+   * values other than the ones in the popup list. 
    *
    * Since: 2.6
    */
   g_object_class_install_property (object_class,
                                    PROP_HAS_ENTRY,
-                                   g_param_spec_boolean ("has_entry",
+                                   g_param_spec_boolean ("has-entry",
                                                         P_("Has Entry"),
-                                                        P_("If %FALSE, don't allow to enter strings other than the chosen ones"),
+                                                        P_("If FALSE, don't allow to enter strings other than the chosen ones"),
                                                         TRUE,
-                                                        G_PARAM_READWRITE));
+                                                        GTK_PARAM_READWRITE));
 
+
+  /**
+   * GtkCellRendererCombo::changed:
+   * @combo: the object on which the signal is emitted
+   * @path_string: a string of the path identifying the edited cell
+   *               (relative to the tree view model)
+   * @new_iter: the new iter selected in the combo box
+   *            (relative to the combo box model)
+   *
+   * This signal is emitted each time after the user selected an item in
+   * the combo box, either by using the mouse or the arrow keys.  Contrary
+   * to GtkComboBox, GtkCellRendererCombo::changed is not emitted for
+   * changes made to a selected item in the entry.  The argument @new_iter
+   * corresponds to the newly selected item in the combo box and it is relative
+   * to the GtkTreeModel set via the model property on GtkCellRendererCombo.
+   *
+   * Note that as soon as you change the model displayed in the tree view,
+   * the tree view will immediately cease the editing operating.  This
+   * means that you most probably want to refrain from changing the model
+   * until the combo cell renderer emits the edited or editing_canceled signal.
+   *
+   * Since: 2.14
+   */
+  cell_renderer_combo_signals[CHANGED] =
+    g_signal_new (I_("changed"),
+                 G_TYPE_FROM_CLASS (object_class),
+                 G_SIGNAL_RUN_LAST,
+                 0,
+                 NULL, NULL,
+                 _gtk_marshal_VOID__STRING_BOXED,
+                 G_TYPE_NONE, 2,
+                 G_TYPE_STRING,
+                 GTK_TYPE_TREE_ITER);
+
+  g_type_class_add_private (klass, sizeof (GtkCellRendererComboPrivate));
 }
 
 static void
@@ -163,13 +192,14 @@ gtk_cell_renderer_combo_init (GtkCellRendererCombo *self)
 {
   self->model = NULL;
   self->text_column = -1;
+  self->has_entry = TRUE;
   self->focus_out_id = 0;
 }
 
 /**
  * gtk_cell_renderer_combo_new: 
  * 
- * Creates a new #GtkCellRendererCombo 
+ * Creates a new #GtkCellRendererCombo. 
  * Adjust how text is drawn using object properties. 
  * Object properties can be set globally (with g_object_set()). 
  * Also, with #GtkTreeViewColumn, you can bind a property to a value 
@@ -187,17 +217,27 @@ gtk_cell_renderer_combo_new (void)
   return g_object_new (GTK_TYPE_CELL_RENDERER_COMBO, NULL); 
 }
 
+static void
+gtk_cell_renderer_combo_finalize (GObject *object)
+{
+  GtkCellRendererCombo *cell = GTK_CELL_RENDERER_COMBO (object);
+  
+  if (cell->model)
+    {
+      g_object_unref (cell->model);
+      cell->model = NULL;
+    }
+  
+  G_OBJECT_CLASS (gtk_cell_renderer_combo_parent_class)->finalize (object);
+}
+
 static void
 gtk_cell_renderer_combo_get_property (GObject    *object,
                                      guint       prop_id,
                                      GValue     *value,
                                      GParamSpec *pspec)
 {
-  GtkCellRendererCombo *cell;
-  g_return_if_fail (GTK_IS_CELL_RENDERER_COMBO (object));
-
-  cell = GTK_CELL_RENDERER_COMBO (object);
+  GtkCellRendererCombo *cell = GTK_CELL_RENDERER_COMBO (object);
 
   switch (prop_id)
     {
@@ -212,6 +252,7 @@ gtk_cell_renderer_combo_get_property (GObject    *object,
       break;
    default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
     }
 }
 
@@ -221,17 +262,37 @@ gtk_cell_renderer_combo_set_property (GObject      *object,
                                      const GValue *value,
                                      GParamSpec   *pspec)
 {
-  GtkCellRendererCombo *cell;
-  
-  g_return_if_fail (GTK_IS_CELL_RENDERER_COMBO (object));
-
-  cell = GTK_CELL_RENDERER_COMBO (object);
+  GtkCellRendererCombo *cell = GTK_CELL_RENDERER_COMBO (object);
 
   switch (prop_id)
     {
     case PROP_MODEL:
-      cell->model = g_value_get_object (value);
-      break;
+      {
+       GObject *object;
+        GtkCellRendererComboPrivate *priv;
+
+        priv = GTK_CELL_RENDERER_COMBO_GET_PRIVATE (cell);
+
+       if (cell->model)
+         {
+            if (priv->combo)
+              gtk_combo_box_set_model (GTK_COMBO_BOX (priv->combo), NULL);
+           g_object_unref (cell->model);
+           cell->model = NULL;
+         }
+
+       object = g_value_get_object (value);
+        if (object)
+          {
+            g_return_if_fail (GTK_IS_TREE_MODEL (object));
+            g_object_ref (object);
+
+            cell->model = GTK_TREE_MODEL (object);
+            if (priv->combo)
+              gtk_combo_box_set_model (GTK_COMBO_BOX (priv->combo), cell->model);
+          }
+       break;
+      }
     case PROP_TEXT_COLUMN:
       cell->text_column = g_value_get_int (value);
       break;
@@ -240,6 +301,26 @@ gtk_cell_renderer_combo_set_property (GObject      *object,
       break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
+    }
+}
+
+static void
+gtk_cell_renderer_combo_changed (GtkComboBox *combo,
+                                gpointer     data)
+{
+  GtkTreeIter iter;
+  GtkCellRendererCombo *cell;
+
+  cell = GTK_CELL_RENDERER_COMBO (data);
+
+  if (gtk_combo_box_get_active_iter (combo, &iter))
+    {
+      const char *path;
+
+      path = g_object_get_data (G_OBJECT (combo), GTK_CELL_RENDERER_COMBO_PATH);
+      g_signal_emit (cell, cell_renderer_combo_signals[CHANGED], 0,
+                    path, &iter);
     }
 }
 
@@ -253,18 +334,23 @@ gtk_cell_renderer_combo_editing_done (GtkCellEditable *combo,
   GtkTreeIter iter;
   GtkCellRendererCombo *cell;
   GtkEntry *entry;
+  gboolean canceled;
+  GtkCellRendererComboPrivate *priv;
 
   cell = GTK_CELL_RENDERER_COMBO (data);
+  priv = GTK_CELL_RENDERER_COMBO_GET_PRIVATE (data);
 
   if (cell->focus_out_id > 0)
     {
       g_signal_handler_disconnect (combo, cell->focus_out_id);
       cell->focus_out_id = 0;
     }
-
-  if (_gtk_combo_box_editing_canceled (GTK_COMBO_BOX (combo)))
+  
+  canceled = _gtk_combo_box_editing_canceled (GTK_COMBO_BOX (combo));
+  gtk_cell_renderer_stop_editing (GTK_CELL_RENDERER (data), canceled);
+  if (canceled)
     {
-      gtk_cell_renderer_editing_canceled (GTK_CELL_RENDERER (data));
+      priv->combo = NULL;
       return;
     }
 
@@ -276,13 +362,17 @@ gtk_cell_renderer_combo_editing_done (GtkCellEditable *combo,
   else 
     {
       model = gtk_combo_box_get_model (GTK_COMBO_BOX (combo));
-      if (gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter))
-       gtk_tree_model_get (model, &iter, cell->text_column, &new_text, -1);
+
+      if (model
+          && gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter))
+        gtk_tree_model_get (model, &iter, cell->text_column, &new_text, -1);
     }
 
   path = g_object_get_data (G_OBJECT (combo), GTK_CELL_RENDERER_COMBO_PATH);
   g_signal_emit_by_name (cell, "edited", path, new_text);
 
+  priv->combo = NULL;
+
   g_free (new_text);
 }
 
@@ -320,6 +410,8 @@ find_text (GtkTreeModel *model,
       search_data->iter = *iter;
       search_data->found = TRUE;
     }
+
+  g_free (text);
   
   return search_data->found;
 }
@@ -337,18 +429,26 @@ gtk_cell_renderer_combo_start_editing (GtkCellRenderer     *cell,
   GtkCellRendererText *cell_text;
   GtkWidget *combo;
   SearchData search_data;
+  GtkCellRendererComboPrivate *priv;
 
   cell_text = GTK_CELL_RENDERER_TEXT (cell);
   if (cell_text->editable == FALSE)
     return NULL;
 
   cell_combo = GTK_CELL_RENDERER_COMBO (cell);
-  if (cell_combo->model == NULL || cell_combo->text_column < 0)
+  if (cell_combo->text_column < 0)
     return NULL;
 
+  priv = GTK_CELL_RENDERER_COMBO_GET_PRIVATE (cell_combo);
+
   if (cell_combo->has_entry) 
     {
-      combo = gtk_combo_box_entry_new_with_model (cell_combo->model, cell_combo->text_column);
+      combo = gtk_combo_box_entry_new ();
+
+      if (cell_combo->model)
+        gtk_combo_box_set_model (GTK_COMBO_BOX (combo), cell_combo->model);
+      gtk_combo_box_entry_set_text_column (GTK_COMBO_BOX_ENTRY (combo),
+                                           cell_combo->text_column);
 
       if (cell_text->text)
        gtk_entry_set_text (GTK_ENTRY (GTK_BIN (combo)->child), 
@@ -357,23 +457,31 @@ gtk_cell_renderer_combo_start_editing (GtkCellRenderer     *cell,
   else
     {
       cell = gtk_cell_renderer_text_new ();
-      combo = gtk_combo_box_new_with_model (cell_combo->model);
+
+      combo = gtk_combo_box_new ();
+      if (cell_combo->model)
+        gtk_combo_box_set_model (GTK_COMBO_BOX (combo), cell_combo->model);
+
       gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (combo), cell, TRUE);
       gtk_cell_layout_set_attributes (GTK_CELL_LAYOUT (combo), 
                                      cell, "text", cell_combo->text_column, 
                                      NULL);
 
       /* determine the current value */
-      search_data.cell = cell_combo;
-      search_data.found = FALSE;
-      gtk_tree_model_foreach (cell_combo->model, find_text, &search_data);
-      if (search_data.found)
-       gtk_combo_box_set_active_iter (combo, &(search_data.iter));
+      if (cell_combo->model)
+        {
+          search_data.cell = cell_combo;
+          search_data.found = FALSE;
+          gtk_tree_model_foreach (cell_combo->model, find_text, &search_data);
+          if (search_data.found)
+            gtk_combo_box_set_active_iter (GTK_COMBO_BOX (combo),
+                                           &(search_data.iter));
+        }
     }
 
-  g_object_set (combo, "has_frame", FALSE, NULL);
+  g_object_set (combo, "has-frame", FALSE, NULL);
   g_object_set_data_full (G_OBJECT (combo),
-                         GTK_CELL_RENDERER_COMBO_PATH,
+                         I_(GTK_CELL_RENDERER_COMBO_PATH),
                          g_strdup (path), g_free);
 
   gtk_widget_show (combo);
@@ -381,10 +489,18 @@ gtk_cell_renderer_combo_start_editing (GtkCellRenderer     *cell,
   g_signal_connect (GTK_CELL_EDITABLE (combo), "editing_done",
                    G_CALLBACK (gtk_cell_renderer_combo_editing_done),
                    cell_combo);
+  g_signal_connect (GTK_CELL_EDITABLE (combo), "changed",
+                   G_CALLBACK (gtk_cell_renderer_combo_changed),
+                   cell_combo);
   cell_combo->focus_out_id = 
     g_signal_connect (combo, "focus_out_event",
                      G_CALLBACK (gtk_cell_renderer_combo_focus_out_event),
                      cell_combo);
 
+  priv->combo = combo;
+
   return GTK_CELL_EDITABLE (combo);
 }
+
+#define __GTK_CELL_RENDERER_COMBO_C__
+#include "gtkaliasdef.c"