fusb200h: don't log on every interrupt

[~andy/linux] / drivers / usb / host / fusbh200-hcd.c

diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c
index e1c6d850a7e1320fa38ffcd518afee2dac46b78b..bbe1e22b2cb49f9e24e1db7c5b015390baf2c9b0 100644 (file)
--- a/drivers/usb/host/fusbh200-hcd.c
+++ b/drivers/usb/host/fusbh200-hcd.c
@@ -114,8 +114,6 @@ MODULE_PARM_DESC(hird, "host initiated resume duration, +1 for each 75us");
        static inline void fusbh200_vdbg(struct fusbh200_hcd *fusbh200, ...) {}
 #endif
 
-#ifdef DEBUG
-
 /* check the values in the HCSPARAMS register
  * (host controller _Structural_ parameters)
  * see EHCI spec, Table 2-4 for each value
@@ -130,13 +128,6 @@ static void dbg_hcs_params (struct fusbh200_hcd *fusbh200, char *label)
                HCS_N_PORTS (params)
                );
 }
-#else
-
-static inline void dbg_hcs_params (struct fusbh200_hcd *fusbh200, char *label) {}
-
-#endif
-
-#ifdef DEBUG
 
 /* check the values in the HCCPARAMS register
  * (host controller _Capability_ parameters)
@@ -153,13 +144,6 @@ static void dbg_hcc_params (struct fusbh200_hcd *fusbh200, char *label)
                HCC_PGM_FRAMELISTLEN(params) ? "256/512/1024" : "1024",
                HCC_CANPARK(params) ? " park" : "");
 }
-#else
-
-static inline void dbg_hcc_params (struct fusbh200_hcd *fusbh200, char *label) {}
-
-#endif
-
-#ifdef DEBUG
 
 static void __maybe_unused
 dbg_qtd (const char *label, struct fusbh200_hcd *fusbh200, struct fusbh200_qtd *qtd)
@@ -302,29 +286,6 @@ dbg_port_buf (char *buf, unsigned len, const char *label, int port, u32 status)
                (status & PORT_CONNECT) ? " CONNECT" : "");
 }
 
-#else
-static inline void __maybe_unused
-dbg_qh (char *label, struct fusbh200_hcd *fusbh200, struct fusbh200_qh *qh)
-{}
-
-static inline int __maybe_unused
-dbg_status_buf (char *buf, unsigned len, const char *label, u32 status)
-{ return 0; }
-
-static inline int __maybe_unused
-dbg_command_buf (char *buf, unsigned len, const char *label, u32 command)
-{ return 0; }
-
-static inline int __maybe_unused
-dbg_intr_buf (char *buf, unsigned len, const char *label, u32 enable)
-{ return 0; }
-
-static inline int __maybe_unused
-dbg_port_buf (char *buf, unsigned len, const char *label, int port, u32 status)
-{ return 0; }
-
-#endif /* DEBUG */
-
 /* functions have the "wrong" filename when they're output... */
 #define dbg_status(fusbh200, label, status) { \
        char _buf [80]; \
@@ -5365,13 +5326,6 @@ static irqreturn_t fusbh200_irq (struct usb_hcd *hcd)
        cmd = fusbh200_readl(fusbh200, &fusbh200->regs->command);
        bh = 0;
 
-#ifdef VERBOSE_DEBUG
-       /* unrequested/ignored: Frame List Rollover */
-       dbg_status (fusbh200, "irq", status);
-#endif
-
-       /* INT, ERR, and IAA interrupt rates can be throttled */
-
        /* normal [4.15.1.2] or error [4.15.1.1] completion */
        if (likely ((status & (STS_INT|STS_ERR)) != 0)) {
                if (likely ((status & STS_ERR) == 0))
@@ -5936,13 +5890,11 @@ static int __init fusbh200_hcd_init(void)
                 sizeof(struct fusbh200_qh), sizeof(struct fusbh200_qtd),
                 sizeof(struct fusbh200_itd));
 
-#ifdef DEBUG
        fusbh200_debug_root = debugfs_create_dir("fusbh200", usb_debug_root);
        if (!fusbh200_debug_root) {
                retval = -ENOENT;
                goto err_debug;
        }
-#endif
 
        retval = platform_driver_register(&fusbh200_hcd_fusbh200_driver);
        if (retval < 0)
@@ -5951,11 +5903,9 @@ static int __init fusbh200_hcd_init(void)
 
        platform_driver_unregister(&fusbh200_hcd_fusbh200_driver);
 clean:
-#ifdef DEBUG
        debugfs_remove(fusbh200_debug_root);
        fusbh200_debug_root = NULL;
 err_debug:
-#endif
        clear_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
        return retval;
 }
@@ -5964,9 +5914,7 @@ module_init(fusbh200_hcd_init);
 static void __exit fusbh200_hcd_cleanup(void)
 {
        platform_driver_unregister(&fusbh200_hcd_fusbh200_driver);
-#ifdef DEBUG
        debugfs_remove(fusbh200_debug_root);
-#endif
        clear_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
 }
 module_exit(fusbh200_hcd_cleanup);