Merge branch 'upstream-jgarzik' of git://git.kernel.org/pub/scm/linux/kernel/git...

[~andy/linux] / drivers / scsi / scsi_transport_sas.c

diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
index 010845fd2b8527a535eea44982963ea62a215cb4..b2ef71a86292c6477dacc38ee7e4f37c960be9f2 100644 (file)
--- a/drivers/scsi/scsi_transport_sas.c
+++ b/drivers/scsi/scsi_transport_sas.c
@@ -500,7 +500,7 @@ struct sas_phy *sas_phy_alloc(struct device *parent, int number)
 EXPORT_SYMBOL(sas_phy_alloc);
 
 /**
- * sas_phy_add  --  add a SAS PHY to the device hierachy
+ * sas_phy_add  --  add a SAS PHY to the device hierarchy
  * @phy:       The PHY to be added
  *
  * Publishes a SAS PHY to the rest of the system.
@@ -625,8 +625,19 @@ static void sas_port_release(struct device *dev)
 static void sas_port_create_link(struct sas_port *port,
                                 struct sas_phy *phy)
 {
-       sysfs_create_link(&port->dev.kobj, &phy->dev.kobj, phy->dev.bus_id);
-       sysfs_create_link(&phy->dev.kobj, &port->dev.kobj, "port");
+       int res;
+
+       res = sysfs_create_link(&port->dev.kobj, &phy->dev.kobj,
+                               phy->dev.bus_id);
+       if (res)
+               goto err;
+       res = sysfs_create_link(&phy->dev.kobj, &port->dev.kobj, "port");
+       if (res)
+               goto err;
+       return;
+err:
+       printk(KERN_ERR "%s: Cannot create port links, err=%d\n",
+              __FUNCTION__, res);
 }
 
 static void sas_port_delete_link(struct sas_port *port,
@@ -864,13 +875,20 @@ EXPORT_SYMBOL(sas_port_delete_phy);
 
 void sas_port_mark_backlink(struct sas_port *port)
 {
+       int res;
        struct device *parent = port->dev.parent->parent->parent;
 
        if (port->is_backlink)
                return;
        port->is_backlink = 1;
-       sysfs_create_link(&port->dev.kobj, &parent->kobj,
-                         parent->bus_id);
+       res = sysfs_create_link(&port->dev.kobj, &parent->kobj,
+                               parent->bus_id);
+       if (res)
+               goto err;
+       return;
+err:
+       printk(KERN_ERR "%s: Cannot create port backlink, err=%d\n",
+              __FUNCTION__, res);
 
 }
 EXPORT_SYMBOL(sas_port_mark_backlink);
@@ -1247,7 +1265,7 @@ struct sas_rphy *sas_expander_alloc(struct sas_port *parent,
 EXPORT_SYMBOL(sas_expander_alloc);
 
 /**
- * sas_rphy_add  --  add a SAS remote PHY to the device hierachy
+ * sas_rphy_add  --  add a SAS remote PHY to the device hierarchy
  * @rphy:      The remote PHY to be added
  *
  * Publishes a SAS remote PHY to the rest of the system.