Merge branch 'topic/emu10k1' into for-linus

[~andy/linux] / drivers / regulator / da903x.c

diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
index 3688e339db8762ea976c0052f59ab7d51ac7c260..fe77730a7edb73442b088a4e325dd70d4c2a6366 100644 (file)
--- a/drivers/regulator/da903x.c
+++ b/drivers/regulator/da903x.c
@@ -79,6 +79,11 @@ struct da903x_regulator_info {
        int     enable_bit;
 };
 
+static inline struct device *to_da903x_dev(struct regulator_dev *rdev)
+{
+       return rdev_get_dev(rdev)->parent->parent;
+}
+
 static inline int check_range(struct da903x_regulator_info *info,
                                int min_uV, int max_uV)
 {
@@ -93,11 +98,11 @@ static int da903x_set_ldo_voltage(struct regulator_dev *rdev,
                                  int min_uV, int max_uV)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da9034_dev = rdev_get_dev(rdev)->parent;
+       struct device *da9034_dev = to_da903x_dev(rdev);
        uint8_t val, mask;
 
        if (check_range(info, min_uV, max_uV)) {
-               pr_err("invalid voltage range (%d, %d) uV", min_uV, max_uV);
+               pr_err("invalid voltage range (%d, %d) uV\n", min_uV, max_uV);
                return -EINVAL;
        }
 
@@ -111,7 +116,7 @@ static int da903x_set_ldo_voltage(struct regulator_dev *rdev,
 static int da903x_get_voltage(struct regulator_dev *rdev)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da9034_dev = rdev_get_dev(rdev)->parent;
+       struct device *da9034_dev = to_da903x_dev(rdev);
        uint8_t val, mask;
        int ret;
 
@@ -128,7 +133,7 @@ static int da903x_get_voltage(struct regulator_dev *rdev)
 static int da903x_enable(struct regulator_dev *rdev)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da9034_dev = rdev_get_dev(rdev)->parent;
+       struct device *da9034_dev = to_da903x_dev(rdev);
 
        return da903x_set_bits(da9034_dev, info->enable_reg,
                                        1 << info->enable_bit);
@@ -137,7 +142,7 @@ static int da903x_enable(struct regulator_dev *rdev)
 static int da903x_disable(struct regulator_dev *rdev)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da9034_dev = rdev_get_dev(rdev)->parent;
+       struct device *da9034_dev = to_da903x_dev(rdev);
 
        return da903x_clr_bits(da9034_dev, info->enable_reg,
                                        1 << info->enable_bit);
@@ -146,7 +151,7 @@ static int da903x_disable(struct regulator_dev *rdev)
 static int da903x_is_enabled(struct regulator_dev *rdev)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da9034_dev = rdev_get_dev(rdev)->parent;
+       struct device *da9034_dev = to_da903x_dev(rdev);
        uint8_t reg_val;
        int ret;
 
@@ -154,7 +159,7 @@ static int da903x_is_enabled(struct regulator_dev *rdev)
        if (ret)
                return ret;
 
-       return reg_val & (1 << info->enable_bit);
+       return !!(reg_val & (1 << info->enable_bit));
 }
 
 /* DA9030 specific operations */
@@ -162,12 +167,12 @@ static int da9030_set_ldo1_15_voltage(struct regulator_dev *rdev,
                                       int min_uV, int max_uV)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da903x_dev = rdev_get_dev(rdev)->parent;
+       struct device *da903x_dev = to_da903x_dev(rdev);
        uint8_t val, mask;
        int ret;
 
        if (check_range(info, min_uV, max_uV)) {
-               pr_err("invalid voltage range (%d, %d) uV", min_uV, max_uV);
+               pr_err("invalid voltage range (%d, %d) uV\n", min_uV, max_uV);
                return -EINVAL;
        }
 
@@ -189,12 +194,12 @@ static int da9030_set_ldo14_voltage(struct regulator_dev *rdev,
                                  int min_uV, int max_uV)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da903x_dev = rdev_get_dev(rdev)->parent;
+       struct device *da903x_dev = to_da903x_dev(rdev);
        uint8_t val, mask;
        int thresh;
 
        if (check_range(info, min_uV, max_uV)) {
-               pr_err("invalid voltage range (%d, %d) uV", min_uV, max_uV);
+               pr_err("invalid voltage range (%d, %d) uV\n", min_uV, max_uV);
                return -EINVAL;
        }
 
@@ -215,7 +220,7 @@ static int da9030_set_ldo14_voltage(struct regulator_dev *rdev,
 static int da9030_get_ldo14_voltage(struct regulator_dev *rdev)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da903x_dev = rdev_get_dev(rdev)->parent;
+       struct device *da903x_dev = to_da903x_dev(rdev);
        uint8_t val, mask;
        int ret;
 
@@ -238,12 +243,12 @@ static int da9034_set_dvc_voltage(struct regulator_dev *rdev,
                                  int min_uV, int max_uV)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da9034_dev = rdev_get_dev(rdev)->parent;
+       struct device *da9034_dev = to_da903x_dev(rdev);
        uint8_t val, mask;
        int ret;
 
        if (check_range(info, min_uV, max_uV)) {
-               pr_err("invalid voltage range (%d, %d) uV", min_uV, max_uV);
+               pr_err("invalid voltage range (%d, %d) uV\n", min_uV, max_uV);
                return -EINVAL;
        }
 
@@ -264,11 +269,11 @@ static int da9034_set_ldo12_voltage(struct regulator_dev *rdev,
                                    int min_uV, int max_uV)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da9034_dev = rdev_get_dev(rdev)->parent;
+       struct device *da9034_dev = to_da903x_dev(rdev);
        uint8_t val, mask;
 
        if (check_range(info, min_uV, max_uV)) {
-               pr_err("invalid voltage range (%d, %d) uV", min_uV, max_uV);
+               pr_err("invalid voltage range (%d, %d) uV\n", min_uV, max_uV);
                return -EINVAL;
        }
 
@@ -283,7 +288,7 @@ static int da9034_set_ldo12_voltage(struct regulator_dev *rdev,
 static int da9034_get_ldo12_voltage(struct regulator_dev *rdev)
 {
        struct da903x_regulator_info *info = rdev_get_drvdata(rdev);
-       struct device *da9034_dev = rdev_get_dev(rdev)->parent;
+       struct device *da9034_dev = to_da903x_dev(rdev);
        uint8_t val, mask;
        int ret;
 
@@ -466,7 +471,7 @@ static int __devinit da903x_regulator_probe(struct platform_device *pdev)
        if (ri->desc.id == DA9030_ID_LDO1 || ri->desc.id == DA9030_ID_LDO15)
                ri->desc.ops = &da9030_regulator_ldo1_15_ops;
 
-       rdev = regulator_register(&ri->desc, pdev->dev.parent, ri);
+       rdev = regulator_register(&ri->desc, &pdev->dev, ri);
        if (IS_ERR(rdev)) {
                dev_err(&pdev->dev, "failed to register regulator %s\n",
                                ri->desc.name);