Merge branch 'upstream' of git://ftp.linux-mips.org/pub/scm/upstream-linus

[~andy/linux] / drivers / pnp / quirks.c

diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
index 277df50c89aee76e5e9ad20298ae6bd08dfd5780..e903b8c2b1fa5e200e2140d609deb643ea49d195 100644 (file)
--- a/drivers/pnp/quirks.c
+++ b/drivers/pnp/quirks.c
@@ -17,9 +17,9 @@
 #include <linux/slab.h>
 #include <linux/pnp.h>
 #include <linux/io.h>
+#include <linux/kallsyms.h>
 #include "base.h"
 
-
 static void quirk_awe32_resources(struct pnp_dev *dev)
 {
        struct pnp_port *port, *port2, *port3;
@@ -31,7 +31,7 @@ static void quirk_awe32_resources(struct pnp_dev *dev)
         * two extra ports (at offset 0x400 and 0x800 from the one given) by
         * hand.
         */
-       for ( ; res ; res = res->next ) {
+       for (; res; res = res->next) {
                port2 = pnp_alloc(sizeof(struct pnp_port));
                if (!port2)
                        return;
@@ -58,18 +58,19 @@ static void quirk_cmi8330_resources(struct pnp_dev *dev)
        struct pnp_option *res = dev->dependent;
        unsigned long tmp;
 
-       for ( ; res ; res = res->next ) {
+       for (; res; res = res->next) {
 
                struct pnp_irq *irq;
                struct pnp_dma *dma;
 
-               for( irq = res->irq; irq; irq = irq->next ) {   // Valid irqs are 5, 7, 10
+               for (irq = res->irq; irq; irq = irq->next) {    // Valid irqs are 5, 7, 10
                        tmp = 0x04A0;
                        bitmap_copy(irq->map, &tmp, 16);        // 0000 0100 1010 0000
                }
 
-               for( dma = res->dma; dma; dma = dma->next ) // Valid 8bit dma channels are 1,3
-                       if( ( dma->flags & IORESOURCE_DMA_TYPE_MASK ) == IORESOURCE_DMA_8BIT )
+               for (dma = res->dma; dma; dma = dma->next)      // Valid 8bit dma channels are 1,3
+                       if ((dma->flags & IORESOURCE_DMA_TYPE_MASK) ==
+                           IORESOURCE_DMA_8BIT)
                                dma->map = 0x000A;
        }
        printk(KERN_INFO "pnp: CMI8330 quirk - fixing interrupts and dma\n");
@@ -79,7 +80,7 @@ static void quirk_sb16audio_resources(struct pnp_dev *dev)
 {
        struct pnp_port *port;
        struct pnp_option *res = dev->dependent;
-       int    changed = 0;
+       int changed = 0;
 
        /*
         * The default range on the mpu port for these devices is 0x388-0x388.
@@ -87,54 +88,26 @@ static void quirk_sb16audio_resources(struct pnp_dev *dev)
         * auto-configured.
         */
 
-       for( ; res ; res = res->next ) {
+       for (; res; res = res->next) {
                port = res->port;
-               if(!port)
+               if (!port)
                        continue;
                port = port->next;
-               if(!port)
+               if (!port)
                        continue;
                port = port->next;
-               if(!port)
+               if (!port)
                        continue;
-               if(port->min != port->max)
+               if (port->min != port->max)
                        continue;
                port->max += 0x70;
                changed = 1;
        }
-       if(changed)
-               printk(KERN_INFO "pnp: SB audio device quirk - increasing port range\n");
-       return;
-}
-
-static void quirk_smc_enable(struct pnp_dev *dev)
-{
-       unsigned int firbase;
-
-       if (!dev->active || !pnp_port_valid(dev, 1))
-               return;
-
-       /*
-        * On the HP/Compaq nw8240 (and probably other similar machines),
-        * there is an SMCF010 device with two I/O port regions:
-        *
-        *      0x3e8-0x3ef SIR
-        *      0x100-0x10f FIR
-        *
-        * _STA reports the device is enabled, but in fact, the BIOS
-        * neglects to enable the FIR range.  Fortunately, it does fully
-        * enable the device if we call _SRS.
-        */
-       firbase = pnp_port_start(dev, 1);
-       if (inb(firbase + 0x7 /* IRCC_MASTER */) == 0xff) {
-               pnp_err("%s (%s) enabled but not responding, disabling and "
-                       "re-enabling", dev->dev.bus_id, pnp_dev_name(dev));
-               pnp_disable_dev(dev);
-               pnp_activate_dev(dev);
-       }
+       if (changed)
+               printk(KERN_INFO
+                      "pnp: SB audio device quirk - increasing port range\n");
 }
 
-
 /*
  *  PnP Quirks
  *  Cards or devices that need some tweaking due to incomplete resource info
@@ -142,32 +115,37 @@ static void quirk_smc_enable(struct pnp_dev *dev)
 
 static struct pnp_fixup pnp_fixups[] = {
        /* Soundblaster awe io port quirk */
-       { "CTL0021", quirk_awe32_resources },
-       { "CTL0022", quirk_awe32_resources },
-       { "CTL0023", quirk_awe32_resources },
+       {"CTL0021", quirk_awe32_resources},
+       {"CTL0022", quirk_awe32_resources},
+       {"CTL0023", quirk_awe32_resources},
        /* CMI 8330 interrupt and dma fix */
-       { "@X@0001", quirk_cmi8330_resources },
+       {"@X@0001", quirk_cmi8330_resources},
        /* Soundblaster audio device io port range quirk */
-       { "CTL0001", quirk_sb16audio_resources },
-       { "CTL0031", quirk_sb16audio_resources },
-       { "CTL0041", quirk_sb16audio_resources },
-       { "CTL0042", quirk_sb16audio_resources },
-       { "CTL0043", quirk_sb16audio_resources },
-       { "CTL0044", quirk_sb16audio_resources },
-       { "CTL0045", quirk_sb16audio_resources },
-       { "SMCf010", quirk_smc_enable },
-       { "" }
+       {"CTL0001", quirk_sb16audio_resources},
+       {"CTL0031", quirk_sb16audio_resources},
+       {"CTL0041", quirk_sb16audio_resources},
+       {"CTL0042", quirk_sb16audio_resources},
+       {"CTL0043", quirk_sb16audio_resources},
+       {"CTL0044", quirk_sb16audio_resources},
+       {"CTL0045", quirk_sb16audio_resources},
+       {""}
 };
 
 void pnp_fixup_device(struct pnp_dev *dev)
 {
        int i = 0;
+       void (*quirk)(struct pnp_dev *);
 
        while (*pnp_fixups[i].id) {
-               if (compare_pnp_id(dev->id,pnp_fixups[i].id)) {
-                       pnp_dbg("Calling quirk for %s",
-                                 dev->dev.bus_id);
-                       pnp_fixups[i].quirk_function(dev);
+               if (compare_pnp_id(dev->id, pnp_fixups[i].id)) {
+                       quirk = pnp_fixups[i].quirk_function;
+
+#ifdef DEBUG
+                       dev_dbg(&dev->dev, "calling quirk 0x%p", quirk);
+                       print_fn_descriptor_symbol(": %s()\n",
+                               (unsigned long) *quirk);
+#endif
+                       (*quirk)(dev);
                }
                i++;
        }