]> Pileus Git - ~andy/linux/blobdiff - drivers/net/wireless/libertas/cmd.c
[PATCH] libertas: make the hex dumper nicer
[~andy/linux] / drivers / net / wireless / libertas / cmd.c
index c6e50195d65c5fe4c3b084a722aa3ef45478a602..8d2f9bad8680359fa0cf93115a508d3901fe825a 100644 (file)
@@ -15,7 +15,7 @@
 static void cleanup_cmdnode(struct cmd_ctrl_node *ptempnode);
 
 static u16 commands_allowed_in_ps[] = {
-       cmd_802_11_rssi,
+       CMD_802_11_RSSI,
 };
 
 /**
@@ -25,13 +25,11 @@ static u16 commands_allowed_in_ps[] = {
  *  @param command the command ID
  *  @return       TRUE or FALSE
  */
-static u8 is_command_allowed_in_ps(u16 command)
+static u8 is_command_allowed_in_ps(__le16 command)
 {
-       int count = sizeof(commands_allowed_in_ps)
-           / sizeof(commands_allowed_in_ps[0]);
        int i;
 
-       for (i = 0; i < count; i++) {
+       for (i = 0; i < ARRAY_SIZE(commands_allowed_in_ps); i++) {
                if (command == cpu_to_le16(commands_allowed_in_ps[i]))
                        return 1;
        }
@@ -45,9 +43,8 @@ static int wlan_cmd_hw_spec(wlan_private * priv, struct cmd_ds_command *cmd)
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_get_hw_spec);
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_get_hw_spec) + S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_GET_HW_SPEC);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_get_hw_spec) + S_DS_GEN);
        memcpy(hwspec->permanentaddr, priv->adapter->current_addr, ETH_ALEN);
 
        lbs_deb_leave(LBS_DEB_CMD);
@@ -59,19 +56,17 @@ static int wlan_cmd_802_11_ps_mode(wlan_private * priv,
                                   u16 cmd_action)
 {
        struct cmd_ds_802_11_ps_mode *psm = &cmd->params.psmode;
-       u16 action = cmd_action;
        wlan_adapter *adapter = priv->adapter;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_802_11_ps_mode);
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_802_11_ps_mode) +
-                            S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_802_11_PS_MODE);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_ps_mode) +
+                               S_DS_GEN);
        psm->action = cpu_to_le16(cmd_action);
        psm->multipledtim = 0;
-       switch (action) {
-       case cmd_subcmd_enter_ps:
+       switch (cmd_action) {
+       case CMD_SUBCMD_ENTER_PS:
                lbs_deb_cmd("PS command:" "SubCode- Enter PS\n");
                lbs_deb_cmd("locallisteninterval = %d\n",
                       adapter->locallisteninterval);
@@ -84,11 +79,11 @@ static int wlan_cmd_802_11_ps_mode(wlan_private * priv,
                    cpu_to_le16(priv->adapter->multipledtim);
                break;
 
-       case cmd_subcmd_exit_ps:
+       case CMD_SUBCMD_EXIT_PS:
                lbs_deb_cmd("PS command:" "SubCode- Exit PS\n");
                break;
 
-       case cmd_subcmd_sleep_confirmed:
+       case CMD_SUBCMD_SLEEP_CONFIRMED:
                lbs_deb_cmd("PS command: SubCode- sleep confirm\n");
                break;
 
@@ -106,7 +101,7 @@ static int wlan_cmd_802_11_inactivity_timeout(wlan_private * priv,
 {
        u16 *timeout = pdata_buf;
 
-       cmd->command = cpu_to_le16(cmd_802_11_inactivity_timeout);
+       cmd->command = cpu_to_le16(CMD_802_11_INACTIVITY_TIMEOUT);
        cmd->size =
            cpu_to_le16(sizeof(struct cmd_ds_802_11_inactivity_timeout)
                             + S_DS_GEN);
@@ -114,8 +109,7 @@ static int wlan_cmd_802_11_inactivity_timeout(wlan_private * priv,
        cmd->params.inactivity_timeout.action = cpu_to_le16(cmd_action);
 
        if (cmd_action)
-               cmd->params.inactivity_timeout.timeout =
-                   cpu_to_le16(*timeout);
+               cmd->params.inactivity_timeout.timeout = cpu_to_le16(*timeout);
        else
                cmd->params.inactivity_timeout.timeout = 0;
 
@@ -131,16 +125,15 @@ static int wlan_cmd_802_11_sleep_params(wlan_private * priv,
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->size =
-           cpu_to_le16((sizeof(struct cmd_ds_802_11_sleep_params)) +
-                            S_DS_GEN);
-       cmd->command = cpu_to_le16(cmd_802_11_sleep_params);
+       cmd->size = cpu_to_le16((sizeof(struct cmd_ds_802_11_sleep_params)) +
+                               S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_802_11_SLEEP_PARAMS);
 
-       if (cmd_action == cmd_act_get) {
+       if (cmd_action == CMD_ACT_GET) {
                memset(&adapter->sp, 0, sizeof(struct sleep_params));
                memset(sp, 0, sizeof(struct cmd_ds_802_11_sleep_params));
                sp->action = cpu_to_le16(cmd_action);
-       } else if (cmd_action == cmd_act_set) {
+       } else if (cmd_action == CMD_ACT_SET) {
                sp->action = cpu_to_le16(cmd_action);
                sp->error = cpu_to_le16(adapter->sp.sp_error);
                sp->offset = cpu_to_le16(adapter->sp.sp_offset);
@@ -166,11 +159,10 @@ static int wlan_cmd_802_11_set_wep(wlan_private * priv,
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_802_11_set_wep);
-       cmd->size = cpu_to_le16((sizeof(struct cmd_ds_802_11_set_wep))
-                                    + S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_802_11_SET_WEP);
+       cmd->size = cpu_to_le16(sizeof(*wep) + S_DS_GEN);
 
-       if (cmd_act == cmd_act_add) {
+       if (cmd_act == CMD_ACT_ADD) {
                int i;
 
                if (!assoc_req) {
@@ -179,27 +171,28 @@ static int wlan_cmd_802_11_set_wep(wlan_private * priv,
                        goto done;
                }
 
-               wep->action = cpu_to_le16(cmd_act_add);
+               wep->action = cpu_to_le16(CMD_ACT_ADD);
 
                /* default tx key index */
-               wep->keyindex = cpu_to_le16((u16)
-                                                (assoc_req->wep_tx_keyidx &
-                                                (u32)cmd_WEP_KEY_INDEX_MASK));
+               wep->keyindex = cpu_to_le16((u16)(assoc_req->wep_tx_keyidx &
+                                                 (u32)CMD_WEP_KEY_INDEX_MASK));
 
-               lbs_deb_cmd("Tx key Index: %u\n", wep->keyindex);
+               lbs_deb_cmd("Tx key Index: %u\n", le16_to_cpu(wep->keyindex));
 
                /* Copy key types and material to host command structure */
                for (i = 0; i < 4; i++) {
-                       struct WLAN_802_11_KEY * pkey = &assoc_req->wep_keys[i];
+                       struct enc_key * pkey = &assoc_req->wep_keys[i];
 
                        switch (pkey->len) {
                        case KEY_LEN_WEP_40:
-                               wep->keytype[i] = cmd_type_wep_40_bit;
+                               wep->keytype[i] =
+                                       cpu_to_le16(CMD_TYPE_WEP_40_BIT);
                                memmove(&wep->keymaterial[i], pkey->key,
                                        pkey->len);
                                break;
                        case KEY_LEN_WEP_104:
-                               wep->keytype[i] = cmd_type_wep_104_bit;
+                               wep->keytype[i] =
+                                       cpu_to_le16(CMD_TYPE_WEP_104_BIT);
                                memmove(&wep->keymaterial[i], pkey->key,
                                        pkey->len);
                                break;
@@ -213,14 +206,13 @@ static int wlan_cmd_802_11_set_wep(wlan_private * priv,
                                break;
                        }
                }
-       } else if (cmd_act == cmd_act_remove) {
+       } else if (cmd_act == CMD_ACT_REMOVE) {
                /* ACT_REMOVE clears _all_ WEP keys */
-               wep->action = cpu_to_le16(cmd_act_remove);
+               wep->action = cpu_to_le16(CMD_ACT_REMOVE);
 
                /* default tx key index */
-               wep->keyindex = cpu_to_le16((u16)
-                                                (adapter->wep_tx_keyidx &
-                                                (u32)cmd_WEP_KEY_INDEX_MASK));
+               wep->keyindex = cpu_to_le16((u16)(adapter->wep_tx_keyidx &
+                                                 (u32)CMD_WEP_KEY_INDEX_MASK));
        }
 
        ret = 0;
@@ -232,44 +224,45 @@ done:
 
 static int wlan_cmd_802_11_enable_rsn(wlan_private * priv,
                                      struct cmd_ds_command *cmd,
-                                     u16 cmd_action)
+                                     u16 cmd_action,
+                                     void * pdata_buf)
 {
        struct cmd_ds_802_11_enable_rsn *penableRSN = &cmd->params.enbrsn;
-       wlan_adapter *adapter = priv->adapter;
+       u32 * enable = pdata_buf;
 
-       cmd->command = cpu_to_le16(cmd_802_11_enable_rsn);
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_802_11_enable_rsn) +
-                            S_DS_GEN);
+       lbs_deb_enter(LBS_DEB_CMD);
+
+       cmd->command = cpu_to_le16(CMD_802_11_ENABLE_RSN);
+       cmd->size = cpu_to_le16(sizeof(*penableRSN) + S_DS_GEN);
        penableRSN->action = cpu_to_le16(cmd_action);
-       if (adapter->secinfo.WPAenabled || adapter->secinfo.WPA2enabled) {
-               penableRSN->enable = cpu_to_le16(cmd_enable_rsn);
-       } else {
-               penableRSN->enable = cpu_to_le16(cmd_disable_rsn);
+
+       if (cmd_action == CMD_ACT_SET) {
+               if (*enable)
+                       penableRSN->enable = cpu_to_le16(CMD_ENABLE_RSN);
+               else
+                       penableRSN->enable = cpu_to_le16(CMD_DISABLE_RSN);
        }
 
+       lbs_deb_leave(LBS_DEB_CMD);
        return 0;
 }
 
 
 static void set_one_wpa_key(struct MrvlIEtype_keyParamSet * pkeyparamset,
-                            struct WLAN_802_11_KEY * pkey)
+                            struct enc_key * pkey)
 {
-       pkeyparamset->keytypeid = cpu_to_le16(pkey->type);
-
        if (pkey->flags & KEY_INFO_WPA_ENABLED) {
-               pkeyparamset->keyinfo = cpu_to_le16(KEY_INFO_WPA_ENABLED);
-       } else {
-               pkeyparamset->keyinfo = cpu_to_le16(!KEY_INFO_WPA_ENABLED);
+               pkeyparamset->keyinfo |= cpu_to_le16(KEY_INFO_WPA_ENABLED);
        }
-
        if (pkey->flags & KEY_INFO_WPA_UNICAST) {
                pkeyparamset->keyinfo |= cpu_to_le16(KEY_INFO_WPA_UNICAST);
-       } else if (pkey->flags & KEY_INFO_WPA_MCAST) {
+       }
+       if (pkey->flags & KEY_INFO_WPA_MCAST) {
                pkeyparamset->keyinfo |= cpu_to_le16(KEY_INFO_WPA_MCAST);
        }
 
        pkeyparamset->type = cpu_to_le16(TLV_TYPE_KEY_MATERIAL);
+       pkeyparamset->keytypeid = cpu_to_le16(pkey->type);
        pkeyparamset->keylen = cpu_to_le16(pkey->len);
        memcpy(pkeyparamset->key, pkey->key, pkey->len);
        pkeyparamset->length = cpu_to_le16(  sizeof(pkeyparamset->keytypeid)
@@ -283,41 +276,40 @@ static int wlan_cmd_802_11_key_material(wlan_private * priv,
                                        u16 cmd_action,
                                        u32 cmd_oid, void *pdata_buf)
 {
-       wlan_adapter *adapter = priv->adapter;
        struct cmd_ds_802_11_key_material *pkeymaterial =
            &cmd->params.keymaterial;
+       struct assoc_request * assoc_req = pdata_buf;
        int ret = 0;
        int index = 0;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_802_11_key_material);
+       cmd->command = cpu_to_le16(CMD_802_11_KEY_MATERIAL);
        pkeymaterial->action = cpu_to_le16(cmd_action);
 
-       if (cmd_action == cmd_act_get) {
-               cmd->size = cpu_to_le16(  S_DS_GEN
-                                            + sizeof (pkeymaterial->action));
+       if (cmd_action == CMD_ACT_GET) {
+               cmd->size = cpu_to_le16(S_DS_GEN + sizeof (pkeymaterial->action));
                ret = 0;
                goto done;
        }
 
        memset(&pkeymaterial->keyParamSet, 0, sizeof(pkeymaterial->keyParamSet));
 
-       if (adapter->wpa_unicast_key.len) {
+       if (test_bit(ASSOC_FLAG_WPA_UCAST_KEY, &assoc_req->flags)) {
                set_one_wpa_key(&pkeymaterial->keyParamSet[index],
-                               &adapter->wpa_unicast_key);
+                               &assoc_req->wpa_unicast_key);
                index++;
        }
 
-       if (adapter->wpa_mcast_key.len) {
+       if (test_bit(ASSOC_FLAG_WPA_MCAST_KEY, &assoc_req->flags)) {
                set_one_wpa_key(&pkeymaterial->keyParamSet[index],
-                               &adapter->wpa_mcast_key);
+                               &assoc_req->wpa_mcast_key);
                index++;
        }
 
        cmd->size = cpu_to_le16(  S_DS_GEN
-                                    + sizeof (pkeymaterial->action)
-                                    + index * sizeof(struct MrvlIEtype_keyParamSet));
+                               + sizeof (pkeymaterial->action)
+                               + (index * sizeof(struct MrvlIEtype_keyParamSet)));
 
        ret = 0;
 
@@ -331,7 +323,7 @@ static int wlan_cmd_802_11_reset(wlan_private * priv,
 {
        struct cmd_ds_802_11_reset *reset = &cmd->params.reset;
 
-       cmd->command = cpu_to_le16(cmd_802_11_reset);
+       cmd->command = cpu_to_le16(CMD_802_11_RESET);
        cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_reset) + S_DS_GEN);
        reset->action = cpu_to_le16(cmd_action);
 
@@ -341,7 +333,7 @@ static int wlan_cmd_802_11_reset(wlan_private * priv,
 static int wlan_cmd_802_11_get_log(wlan_private * priv,
                                   struct cmd_ds_command *cmd)
 {
-       cmd->command = cpu_to_le16(cmd_802_11_get_log);
+       cmd->command = cpu_to_le16(CMD_802_11_GET_LOG);
        cmd->size =
                cpu_to_le16(sizeof(struct cmd_ds_802_11_get_log) + S_DS_GEN);
 
@@ -351,10 +343,9 @@ static int wlan_cmd_802_11_get_log(wlan_private * priv,
 static int wlan_cmd_802_11_get_stat(wlan_private * priv,
                                    struct cmd_ds_command *cmd)
 {
-       cmd->command = cpu_to_le16(cmd_802_11_get_stat);
+       cmd->command = cpu_to_le16(CMD_802_11_GET_STAT);
        cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_802_11_get_stat) +
-                            S_DS_GEN);
+           cpu_to_le16(sizeof(struct cmd_ds_802_11_get_stat) + S_DS_GEN);
 
        return 0;
 }
@@ -372,17 +363,15 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
 
        lbs_deb_cmd("SNMP_CMD: cmd_oid = 0x%x\n", cmd_oid);
 
-       cmd->command = cpu_to_le16(cmd_802_11_snmp_mib);
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_802_11_snmp_mib) +
-                            S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_802_11_SNMP_MIB);
+       cmd->size = cpu_to_le16(sizeof(*pSNMPMIB) + S_DS_GEN);
 
        switch (cmd_oid) {
        case OID_802_11_INFRASTRUCTURE_MODE:
        {
                u8 mode = (u8) (size_t) pdata_buf;
-               pSNMPMIB->querytype = cpu_to_le16(cmd_act_set);
-               pSNMPMIB->oid = cpu_to_le16((u16) desired_bsstype_i);
+               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_SET);
+               pSNMPMIB->oid = cpu_to_le16((u16) DESIRED_BSSTYPE_I);
                pSNMPMIB->bufsize = sizeof(u8);
                if (mode == IW_MODE_ADHOC) {
                        ucTemp = SNMP_MIB_VALUE_ADHOC;
@@ -400,13 +389,13 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
                {
                        u32 ulTemp;
 
-                       pSNMPMIB->oid = cpu_to_le16((u16) dot11d_i);
+                       pSNMPMIB->oid = cpu_to_le16((u16) DOT11D_I);
 
-                       if (cmd_action == cmd_act_set) {
-                               pSNMPMIB->querytype = cmd_act_set;
+                       if (cmd_action == CMD_ACT_SET) {
+                               pSNMPMIB->querytype = CMD_ACT_SET;
                                pSNMPMIB->bufsize = sizeof(u16);
                                ulTemp = *(u32 *)pdata_buf;
-                               *((unsigned short *)(pSNMPMIB->value)) =
+                               *((__le16 *)(pSNMPMIB->value)) =
                                    cpu_to_le16((u16) ulTemp);
                        }
                        break;
@@ -416,18 +405,15 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
                {
                        u32 ulTemp;
 
-                       pSNMPMIB->oid = cpu_to_le16((u16) fragthresh_i);
+                       pSNMPMIB->oid = cpu_to_le16((u16) FRAGTHRESH_I);
 
-                       if (cmd_action == cmd_act_get) {
-                               pSNMPMIB->querytype =
-                                   cpu_to_le16(cmd_act_get);
-                       } else if (cmd_action == cmd_act_set) {
-                               pSNMPMIB->querytype =
-                                   cpu_to_le16(cmd_act_set);
-                               pSNMPMIB->bufsize =
-                                   cpu_to_le16(sizeof(u16));
+                       if (cmd_action == CMD_ACT_GET) {
+                               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_GET);
+                       } else if (cmd_action == CMD_ACT_SET) {
+                               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_SET);
+                               pSNMPMIB->bufsize = cpu_to_le16(sizeof(u16));
                                ulTemp = *((u32 *) pdata_buf);
-                               *((unsigned short *)(pSNMPMIB->value)) =
+                               *((__le16 *)(pSNMPMIB->value)) =
                                    cpu_to_le16((u16) ulTemp);
 
                        }
@@ -439,35 +425,29 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
                {
 
                        u32 ulTemp;
-                       pSNMPMIB->oid = le16_to_cpu((u16) rtsthresh_i);
-
-                       if (cmd_action == cmd_act_get) {
-                               pSNMPMIB->querytype =
-                                   cpu_to_le16(cmd_act_get);
-                       } else if (cmd_action == cmd_act_set) {
-                               pSNMPMIB->querytype =
-                                   cpu_to_le16(cmd_act_set);
-                               pSNMPMIB->bufsize =
-                                   cpu_to_le16(sizeof(u16));
-                               ulTemp = *((u32 *)
-                                          pdata_buf);
-                               *(unsigned short *)(pSNMPMIB->value) =
+                       pSNMPMIB->oid = le16_to_cpu((u16) RTSTHRESH_I);
+
+                       if (cmd_action == CMD_ACT_GET) {
+                               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_GET);
+                       } else if (cmd_action == CMD_ACT_SET) {
+                               pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_SET);
+                               pSNMPMIB->bufsize = cpu_to_le16(sizeof(u16));
+                               ulTemp = *((u32 *)pdata_buf);
+                               *(__le16 *)(pSNMPMIB->value) =
                                    cpu_to_le16((u16) ulTemp);
 
                        }
                        break;
                }
        case OID_802_11_TX_RETRYCOUNT:
-               pSNMPMIB->oid = cpu_to_le16((u16) short_retrylim_i);
-
-               if (cmd_action == cmd_act_get) {
-                       pSNMPMIB->querytype =
-                           cpu_to_le16(cmd_act_get);
-               } else if (cmd_action == cmd_act_set) {
-                       pSNMPMIB->querytype =
-                           cpu_to_le16(cmd_act_set);
+               pSNMPMIB->oid = cpu_to_le16((u16) SHORT_RETRYLIM_I);
+
+               if (cmd_action == CMD_ACT_GET) {
+                       pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_GET);
+               } else if (cmd_action == CMD_ACT_SET) {
+                       pSNMPMIB->querytype = cpu_to_le16(CMD_ACT_SET);
                        pSNMPMIB->bufsize = cpu_to_le16(sizeof(u16));
-                       *((unsigned short *)(pSNMPMIB->value)) =
+                       *((__le16 *)(pSNMPMIB->value)) =
                            cpu_to_le16((u16) adapter->txretrycount);
                }
 
@@ -478,12 +458,14 @@ static int wlan_cmd_802_11_snmp_mib(wlan_private * priv,
 
        lbs_deb_cmd(
               "SNMP_CMD: command=0x%x, size=0x%x, seqnum=0x%x, result=0x%x\n",
-              cmd->command, cmd->size, cmd->seqnum, cmd->result);
+              le16_to_cpu(cmd->command), le16_to_cpu(cmd->size),
+              le16_to_cpu(cmd->seqnum), le16_to_cpu(cmd->result));
 
        lbs_deb_cmd(
               "SNMP_CMD: action=0x%x, oid=0x%x, oidsize=0x%x, value=0x%x\n",
-              pSNMPMIB->querytype, pSNMPMIB->oid, pSNMPMIB->bufsize,
-              *(u16 *) pSNMPMIB->value);
+              le16_to_cpu(pSNMPMIB->querytype), le16_to_cpu(pSNMPMIB->oid),
+              le16_to_cpu(pSNMPMIB->bufsize),
+              le16_to_cpu(*(__le16 *) pSNMPMIB->value));
 
        lbs_deb_leave(LBS_DEB_CMD);
        return 0;
@@ -494,28 +476,27 @@ static int wlan_cmd_802_11_radio_control(wlan_private * priv,
                                         int cmd_action)
 {
        wlan_adapter *adapter = priv->adapter;
-       struct cmd_ds_802_11_radio_control *pradiocontrol =
-           &cmd->params.radio;
+       struct cmd_ds_802_11_radio_control *pradiocontrol = &cmd->params.radio;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
        cmd->size =
            cpu_to_le16((sizeof(struct cmd_ds_802_11_radio_control)) +
                             S_DS_GEN);
-       cmd->command = cpu_to_le16(cmd_802_11_radio_control);
+       cmd->command = cpu_to_le16(CMD_802_11_RADIO_CONTROL);
 
        pradiocontrol->action = cpu_to_le16(cmd_action);
 
        switch (adapter->preamble) {
-       case cmd_type_short_preamble:
+       case CMD_TYPE_SHORT_PREAMBLE:
                pradiocontrol->control = cpu_to_le16(SET_SHORT_PREAMBLE);
                break;
 
-       case cmd_type_long_preamble:
+       case CMD_TYPE_LONG_PREAMBLE:
                pradiocontrol->control = cpu_to_le16(SET_LONG_PREAMBLE);
                break;
 
-       case cmd_type_auto_preamble:
+       case CMD_TYPE_AUTO_PREAMBLE:
        default:
                pradiocontrol->control = cpu_to_le16(SET_AUTO_PREAMBLE);
                break;
@@ -540,34 +521,32 @@ static int wlan_cmd_802_11_rf_tx_power(wlan_private * priv,
        lbs_deb_enter(LBS_DEB_CMD);
 
        cmd->size =
-           cpu_to_le16((sizeof(struct cmd_ds_802_11_rf_tx_power)) +
-                            S_DS_GEN);
-       cmd->command = cpu_to_le16(cmd_802_11_rf_tx_power);
-       prtp->action = cmd_action;
+           cpu_to_le16((sizeof(struct cmd_ds_802_11_rf_tx_power)) + S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_802_11_RF_TX_POWER);
+       prtp->action = cpu_to_le16(cmd_action);
 
-       lbs_deb_cmd("RF_TX_POWER_CMD: size:%d cmd:0x%x Act:%d\n", cmd->size,
-              cmd->command, prtp->action);
+       lbs_deb_cmd("RF_TX_POWER_CMD: size:%d cmd:0x%x Act:%d\n",
+                   le16_to_cpu(cmd->size), le16_to_cpu(cmd->command),
+                   le16_to_cpu(prtp->action));
 
        switch (cmd_action) {
-       case cmd_act_tx_power_opt_get:
-               prtp->action = cpu_to_le16(cmd_act_get);
+       case CMD_ACT_TX_POWER_OPT_GET:
+               prtp->action = cpu_to_le16(CMD_ACT_GET);
                prtp->currentlevel = 0;
                break;
 
-       case cmd_act_tx_power_opt_set_high:
-               prtp->action = cpu_to_le16(cmd_act_set);
-               prtp->currentlevel =
-                   cpu_to_le16(cmd_act_tx_power_index_high);
+       case CMD_ACT_TX_POWER_OPT_SET_HIGH:
+               prtp->action = cpu_to_le16(CMD_ACT_SET);
+               prtp->currentlevel = cpu_to_le16(CMD_ACT_TX_POWER_INDEX_HIGH);
                break;
 
-       case cmd_act_tx_power_opt_set_mid:
-               prtp->action = cpu_to_le16(cmd_act_set);
-               prtp->currentlevel =
-                   cpu_to_le16(cmd_act_tx_power_index_mid);
+       case CMD_ACT_TX_POWER_OPT_SET_MID:
+               prtp->action = cpu_to_le16(CMD_ACT_SET);
+               prtp->currentlevel = cpu_to_le16(CMD_ACT_TX_POWER_INDEX_MID);
                break;
 
-       case cmd_act_tx_power_opt_set_low:
-               prtp->action = cpu_to_le16(cmd_act_set);
+       case CMD_ACT_TX_POWER_OPT_SET_LOW:
+               prtp->action = cpu_to_le16(CMD_ACT_SET);
                prtp->currentlevel = cpu_to_le16(*((u16 *) pdata_buf));
                break;
        }
@@ -582,16 +561,13 @@ static int wlan_cmd_802_11_rf_antenna(wlan_private * priv,
 {
        struct cmd_ds_802_11_rf_antenna *rant = &cmd->params.rant;
 
-       cmd->command = cpu_to_le16(cmd_802_11_rf_antenna);
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_802_11_rf_antenna) +
-                            S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_802_11_RF_ANTENNA);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_rf_antenna) +
+                               S_DS_GEN);
 
        rant->action = cpu_to_le16(cmd_action);
-       if ((cmd_action == cmd_act_set_rx) ||
-           (cmd_action == cmd_act_set_tx)) {
-               rant->antennamode =
-                   cpu_to_le16((u16) (*(u32 *) pdata_buf));
+       if ((cmd_action == CMD_ACT_SET_RX) || (cmd_action == CMD_ACT_SET_TX)) {
+               rant->antennamode = cpu_to_le16((u16) (*(u32 *) pdata_buf));
        }
 
        return 0;
@@ -608,13 +584,13 @@ static int wlan_cmd_802_11_rate_adapt_rateset(wlan_private * priv,
        cmd->size =
            cpu_to_le16(sizeof(struct cmd_ds_802_11_rate_adapt_rateset)
                             + S_DS_GEN);
-       cmd->command = cpu_to_le16(cmd_802_11_rate_adapt_rateset);
+       cmd->command = cpu_to_le16(CMD_802_11_RATE_ADAPT_RATESET);
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       rateadapt->action = cmd_action;
-       rateadapt->enablehwauto = adapter->enablehwauto;
-       rateadapt->bitmap = adapter->ratebitmap;
+       rateadapt->action = cpu_to_le16(cmd_action);
+       rateadapt->enablehwauto = cpu_to_le16(adapter->enablehwauto);
+       rateadapt->bitmap = cpu_to_le16(adapter->ratebitmap);
 
        lbs_deb_leave(LBS_DEB_CMD);
        return 0;
@@ -626,25 +602,20 @@ static int wlan_cmd_802_11_data_rate(wlan_private * priv,
 {
        struct cmd_ds_802_11_data_rate *pdatarate = &cmd->params.drate;
        wlan_adapter *adapter = priv->adapter;
-       u16 action = cmd_action;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_802_11_data_rate) +
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_data_rate) +
                             S_DS_GEN);
-
-       cmd->command = cpu_to_le16(cmd_802_11_data_rate);
-
+       cmd->command = cpu_to_le16(CMD_802_11_DATA_RATE);
        memset(pdatarate, 0, sizeof(struct cmd_ds_802_11_data_rate));
-
        pdatarate->action = cpu_to_le16(cmd_action);
 
-       if (action == cmd_act_set_tx_fix_rate) {
-               pdatarate->datarate[0] = libertas_data_rate_to_index(adapter->datarate);
+       if (cmd_action == CMD_ACT_SET_TX_FIX_RATE) {
+               pdatarate->rates[0] = libertas_data_rate_to_fw_index(adapter->cur_rate);
                lbs_deb_cmd("Setting FW for fixed rate 0x%02X\n",
-                      adapter->datarate);
-       } else if (action == cmd_act_set_tx_auto) {
+                      adapter->cur_rate);
+       } else if (cmd_action == CMD_ACT_SET_TX_AUTO) {
                lbs_deb_cmd("Setting FW for AUTO rate\n");
        }
 
@@ -659,10 +630,9 @@ static int wlan_cmd_mac_multicast_adr(wlan_private * priv,
        struct cmd_ds_mac_multicast_adr *pMCastAdr = &cmd->params.madr;
        wlan_adapter *adapter = priv->adapter;
 
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_mac_multicast_adr) +
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_mac_multicast_adr) +
                             S_DS_GEN);
-       cmd->command = cpu_to_le16(cmd_mac_multicast_adr);
+       cmd->command = cpu_to_le16(CMD_MAC_MULTICAST_ADR);
 
        pMCastAdr->action = cpu_to_le16(cmd_action);
        pMCastAdr->nr_of_adrs =
@@ -679,11 +649,11 @@ static int wlan_cmd_802_11_rf_channel(wlan_private * priv,
 {
        struct cmd_ds_802_11_rf_channel *rfchan = &cmd->params.rfchannel;
 
-       cmd->command = cpu_to_le16(cmd_802_11_rf_channel);
-       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_rf_channel)
-                                    + S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_802_11_RF_CHANNEL);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_rf_channel) +
+                               S_DS_GEN);
 
-       if (option == cmd_opt_802_11_rf_channel_set) {
+       if (option == CMD_OPT_802_11_RF_CHANNEL_SET) {
                rfchan->currentchannel = cpu_to_le16(*((u16 *) pdata_buf));
        }
 
@@ -697,10 +667,9 @@ static int wlan_cmd_802_11_rssi(wlan_private * priv,
 {
        wlan_adapter *adapter = priv->adapter;
 
-       cmd->command = cpu_to_le16(cmd_802_11_rssi);
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_802_11_rssi) + S_DS_GEN);
-       cmd->params.rssi.N = priv->adapter->bcn_avg_factor;
+       cmd->command = cpu_to_le16(CMD_802_11_RSSI);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_rssi) + S_DS_GEN);
+       cmd->params.rssi.N = cpu_to_le16(priv->adapter->bcn_avg_factor);
 
        /* reset Beacon SNR/NF/RSSI values */
        adapter->SNR[TYPE_BEACON][TYPE_NOAVG] = 0;
@@ -724,14 +693,13 @@ static int wlan_cmd_reg_access(wlan_private * priv,
        offval = (struct wlan_offset_value *)pdata_buf;
 
        switch (cmdptr->command) {
-       case cmd_mac_reg_access:
+       case CMD_MAC_REG_ACCESS:
                {
                        struct cmd_ds_mac_reg_access *macreg;
 
                        cmdptr->size =
-                           cpu_to_le16(sizeof
-                                            (struct cmd_ds_mac_reg_access)
-                                            + S_DS_GEN);
+                           cpu_to_le16(sizeof (struct cmd_ds_mac_reg_access)
+                                       + S_DS_GEN);
                        macreg =
                            (struct cmd_ds_mac_reg_access *)&cmdptr->params.
                            macreg;
@@ -743,7 +711,7 @@ static int wlan_cmd_reg_access(wlan_private * priv,
                        break;
                }
 
-       case cmd_bbp_reg_access:
+       case CMD_BBP_REG_ACCESS:
                {
                        struct cmd_ds_bbp_reg_access *bbpreg;
 
@@ -762,7 +730,7 @@ static int wlan_cmd_reg_access(wlan_private * priv,
                        break;
                }
 
-       case cmd_rf_reg_access:
+       case CMD_RF_REG_ACCESS:
                {
                        struct cmd_ds_rf_reg_access *rfreg;
 
@@ -795,18 +763,17 @@ static int wlan_cmd_802_11_mac_address(wlan_private * priv,
 {
        wlan_adapter *adapter = priv->adapter;
 
-       cmd->command = cpu_to_le16(cmd_802_11_mac_address);
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_802_11_mac_address) +
+       cmd->command = cpu_to_le16(CMD_802_11_MAC_ADDRESS);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_mac_address) +
                             S_DS_GEN);
        cmd->result = 0;
 
        cmd->params.macadd.action = cpu_to_le16(cmd_action);
 
-       if (cmd_action == cmd_act_set) {
+       if (cmd_action == CMD_ACT_SET) {
                memcpy(cmd->params.macadd.macadd,
                       adapter->current_addr, ETH_ALEN);
-               lbs_dbg_hex("SET_CMD: MAC ADDRESS-", adapter->current_addr, 6);
+               lbs_deb_hex(LBS_DEB_CMD, "SET_CMD: MAC addr", adapter->current_addr, 6);
        }
 
        return 0;
@@ -820,10 +787,9 @@ static int wlan_cmd_802_11_eeprom_access(wlan_private * priv,
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_802_11_eeprom_access);
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_802_11_eeprom_access) +
-                            S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_802_11_EEPROM_ACCESS);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_eeprom_access) +
+                               S_DS_GEN);
        cmd->result = 0;
 
        cmd->params.rdeeprom.action = cpu_to_le16(ea->action);
@@ -841,25 +807,29 @@ static int wlan_cmd_bt_access(wlan_private * priv,
        struct cmd_ds_bt_access *bt_access = &cmd->params.bt;
        lbs_deb_cmd("BT CMD(%d)\n", cmd_action);
 
-       cmd->command = cpu_to_le16(cmd_bt_access);
-       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_bt_access)
-                                    + S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_BT_ACCESS);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_bt_access) + S_DS_GEN);
        cmd->result = 0;
        bt_access->action = cpu_to_le16(cmd_action);
 
        switch (cmd_action) {
-       case cmd_act_bt_access_add:
+       case CMD_ACT_BT_ACCESS_ADD:
                memcpy(bt_access->addr1, pdata_buf, 2 * ETH_ALEN);
-               lbs_dbg_hex("BT_ADD: blinded mac address-", bt_access->addr1, 6);
+               lbs_deb_hex(LBS_DEB_MESH, "BT_ADD: blinded MAC addr", bt_access->addr1, 6);
                break;
-       case cmd_act_bt_access_del:
+       case CMD_ACT_BT_ACCESS_DEL:
                memcpy(bt_access->addr1, pdata_buf, 1 * ETH_ALEN);
-               lbs_dbg_hex("BT_DEL: blinded mac address-", bt_access->addr1, 6);
+               lbs_deb_hex(LBS_DEB_MESH, "BT_DEL: blinded MAC addr", bt_access->addr1, 6);
+               break;
+       case CMD_ACT_BT_ACCESS_LIST:
+               bt_access->id = cpu_to_le32(*(u32 *) pdata_buf);
+               break;
+       case CMD_ACT_BT_ACCESS_RESET:
                break;
-       case cmd_act_bt_access_list:
+       case CMD_ACT_BT_ACCESS_SET_INVERT:
                bt_access->id = cpu_to_le32(*(u32 *) pdata_buf);
                break;
-       case cmd_act_bt_access_reset:
+       case CMD_ACT_BT_ACCESS_GET_INVERT:
                break;
        default:
                break;
@@ -874,9 +844,8 @@ static int wlan_cmd_fwt_access(wlan_private * priv,
        struct cmd_ds_fwt_access *fwt_access = &cmd->params.fwt;
        lbs_deb_cmd("FWT CMD(%d)\n", cmd_action);
 
-       cmd->command = cpu_to_le16(cmd_fwt_access);
-       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_fwt_access)
-                                    + S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_FWT_ACCESS);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_fwt_access) + S_DS_GEN);
        cmd->result = 0;
 
        if (pdata_buf)
@@ -896,9 +865,8 @@ static int wlan_cmd_mesh_access(wlan_private * priv,
        struct cmd_ds_mesh_access *mesh_access = &cmd->params.mesh;
        lbs_deb_cmd("FWT CMD(%d)\n", cmd_action);
 
-       cmd->command = cpu_to_le16(cmd_mesh_access);
-       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_mesh_access)
-                                    + S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_MESH_ACCESS);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_mesh_access) + S_DS_GEN);
        cmd->result = 0;
 
        if (pdata_buf)
@@ -930,9 +898,9 @@ void libertas_queue_cmd(wlan_adapter * adapter, struct cmd_ctrl_node *cmdnode, u
        }
 
        /* Exit_PS command needs to be queued in the header always. */
-       if (cmdptr->command == cmd_802_11_ps_mode) {
+       if (cmdptr->command == CMD_802_11_PS_MODE) {
                struct cmd_ds_802_11_ps_mode *psm = &cmdptr->params.psmode;
-               if (psm->action == cmd_subcmd_exit_ps) {
+               if (psm->action == cpu_to_le16(CMD_SUBCMD_EXIT_PS)) {
                        if (adapter->psstate != PS_STATE_FULL_POWER)
                                addtail = 0;
                }
@@ -950,7 +918,7 @@ void libertas_queue_cmd(wlan_adapter * adapter, struct cmd_ctrl_node *cmdnode, u
 
        lbs_deb_cmd("QUEUE_CMD: Inserted node=%p, cmd=0x%x in cmdpendingq\n",
               cmdnode,
-              ((struct cmd_ds_gen*)cmdnode->bufvirtualaddr)->command);
+              le16_to_cpu(((struct cmd_ds_gen*)cmdnode->bufvirtualaddr)->command));
 
 done:
        lbs_deb_leave(LBS_DEB_CMD);
@@ -1004,7 +972,7 @@ static int DownloadcommandToStation(wlan_private * priv,
        adapter->cur_cmd_retcode = 0;
        spin_unlock_irqrestore(&adapter->driver_lock, flags);
        lbs_deb_cmd("DNLD_CMD:: Before download, size of cmd = %d\n",
-              cmdptr->size);
+                   le16_to_cpu(cmdptr->size));
 
        cmdsize = cmdptr->size;
 
@@ -1025,13 +993,12 @@ static int DownloadcommandToStation(wlan_private * priv,
                goto done;
        }
 
-       lbs_deb_cmd("DNLD_CMD: Sent command 0x%x @ %lu\n", command, jiffies);
-       lbs_dbg_hex("DNLD_CMD: command", cmdnode->bufvirtualaddr, cmdsize);
+       lbs_deb_cmd("DNLD_CMD: sent command 0x%x, jiffies %lu\n", command, jiffies);
+       lbs_deb_hex(LBS_DEB_CMD, "command", cmdnode->bufvirtualaddr, cmdsize);
 
        /* Setup the timer after transmit command */
-       if (command == cmd_802_11_scan
-           || command == cmd_802_11_authenticate
-           || command == cmd_802_11_associate)
+       if (command == CMD_802_11_SCAN || command == CMD_802_11_AUTHENTICATE
+           || command == CMD_802_11_ASSOCIATE)
                mod_timer(&adapter->command_timer, jiffies + (10*HZ));
        else
                mod_timer(&adapter->command_timer, jiffies + (5*HZ));
@@ -1050,13 +1017,12 @@ static int wlan_cmd_mac_control(wlan_private * priv,
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       cmd->command = cpu_to_le16(cmd_mac_control);
-       cmd->size =
-           cpu_to_le16(sizeof(struct cmd_ds_mac_control) + S_DS_GEN);
+       cmd->command = cpu_to_le16(CMD_MAC_CONTROL);
+       cmd->size = cpu_to_le16(sizeof(struct cmd_ds_mac_control) + S_DS_GEN);
        mac->action = cpu_to_le16(priv->adapter->currentpacketfilter);
 
        lbs_deb_cmd("wlan_cmd_mac_control(): action=0x%X size=%d\n",
-              mac->action, cmd->size);
+                   le16_to_cpu(mac->action), le16_to_cpu(cmd->size));
 
        lbs_deb_leave(LBS_DEB_CMD);
        return 0;
@@ -1079,7 +1045,7 @@ done:
        return;
 }
 
-void libertas_cleanup_and_insert_cmd(wlan_private * priv, struct cmd_ctrl_node *ptempcmd)
+static void libertas_cleanup_and_insert_cmd(wlan_private * priv, struct cmd_ctrl_node *ptempcmd)
 {
        unsigned long flags;
 
@@ -1095,9 +1061,9 @@ int libertas_set_radio_control(wlan_private * priv)
        lbs_deb_enter(LBS_DEB_CMD);
 
        ret = libertas_prepare_and_send_command(priv,
-                                   cmd_802_11_radio_control,
-                                   cmd_act_set,
-                                   cmd_option_waitforrsp, 0, NULL);
+                                   CMD_802_11_RADIO_CONTROL,
+                                   CMD_ACT_SET,
+                                   CMD_OPTION_WAITFORRSP, 0, NULL);
 
        lbs_deb_cmd("RADIO_SET: on or off: 0x%X, preamble = 0x%X\n",
               priv->adapter->radioon, priv->adapter->preamble);
@@ -1117,7 +1083,7 @@ int libertas_set_mac_packet_filter(wlan_private * priv)
 
        /* Send MAC control command to station */
        ret = libertas_prepare_and_send_command(priv,
-                                   cmd_mac_control, 0, 0, 0, NULL);
+                                   CMD_MAC_CONTROL, 0, 0, 0, NULL);
 
        lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
        return ret;
@@ -1165,7 +1131,7 @@ int libertas_prepare_and_send_command(wlan_private * priv,
                lbs_deb_cmd("PREP_CMD: No free cmdnode\n");
 
                /* Wake up main thread to execute next command */
-               wake_up_interruptible(&priv->mainthread.waitq);
+               wake_up_interruptible(&priv->waitq);
                ret = -1;
                goto done;
        }
@@ -1188,145 +1154,144 @@ int libertas_prepare_and_send_command(wlan_private * priv,
        adapter->seqnum++;
        cmdptr->seqnum = cpu_to_le16(adapter->seqnum);
 
-       cmdptr->command = cmd_no;
+       cmdptr->command = cpu_to_le16(cmd_no);
        cmdptr->result = 0;
 
        switch (cmd_no) {
-       case cmd_get_hw_spec:
+       case CMD_GET_HW_SPEC:
                ret = wlan_cmd_hw_spec(priv, cmdptr);
                break;
-       case cmd_802_11_ps_mode:
+       case CMD_802_11_PS_MODE:
                ret = wlan_cmd_802_11_ps_mode(priv, cmdptr, cmd_action);
                break;
 
-       case cmd_802_11_scan:
+       case CMD_802_11_SCAN:
                ret = libertas_cmd_80211_scan(priv, cmdptr, pdata_buf);
                break;
 
-       case cmd_mac_control:
+       case CMD_MAC_CONTROL:
                ret = wlan_cmd_mac_control(priv, cmdptr);
                break;
 
-       case cmd_802_11_associate:
-       case cmd_802_11_reassociate:
+       case CMD_802_11_ASSOCIATE:
+       case CMD_802_11_REASSOCIATE:
                ret = libertas_cmd_80211_associate(priv, cmdptr, pdata_buf);
                break;
 
-       case cmd_802_11_deauthenticate:
+       case CMD_802_11_DEAUTHENTICATE:
                ret = libertas_cmd_80211_deauthenticate(priv, cmdptr);
                break;
 
-       case cmd_802_11_set_wep:
+       case CMD_802_11_SET_WEP:
                ret = wlan_cmd_802_11_set_wep(priv, cmdptr, cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_ad_hoc_start:
+       case CMD_802_11_AD_HOC_START:
                ret = libertas_cmd_80211_ad_hoc_start(priv, cmdptr, pdata_buf);
                break;
-       case cmd_code_dnld:
+       case CMD_CODE_DNLD:
                break;
 
-       case cmd_802_11_reset:
+       case CMD_802_11_RESET:
                ret = wlan_cmd_802_11_reset(priv, cmdptr, cmd_action);
                break;
 
-       case cmd_802_11_get_log:
+       case CMD_802_11_GET_LOG:
                ret = wlan_cmd_802_11_get_log(priv, cmdptr);
                break;
 
-       case cmd_802_11_authenticate:
+       case CMD_802_11_AUTHENTICATE:
                ret = libertas_cmd_80211_authenticate(priv, cmdptr, pdata_buf);
                break;
 
-       case cmd_802_11_get_stat:
+       case CMD_802_11_GET_STAT:
                ret = wlan_cmd_802_11_get_stat(priv, cmdptr);
                break;
 
-       case cmd_802_11_snmp_mib:
+       case CMD_802_11_SNMP_MIB:
                ret = wlan_cmd_802_11_snmp_mib(priv, cmdptr,
                                               cmd_action, cmd_oid, pdata_buf);
                break;
 
-       case cmd_mac_reg_access:
-       case cmd_bbp_reg_access:
-       case cmd_rf_reg_access:
+       case CMD_MAC_REG_ACCESS:
+       case CMD_BBP_REG_ACCESS:
+       case CMD_RF_REG_ACCESS:
                ret = wlan_cmd_reg_access(priv, cmdptr, cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_rf_channel:
+       case CMD_802_11_RF_CHANNEL:
                ret = wlan_cmd_802_11_rf_channel(priv, cmdptr,
                                                 cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_rf_tx_power:
+       case CMD_802_11_RF_TX_POWER:
                ret = wlan_cmd_802_11_rf_tx_power(priv, cmdptr,
                                                  cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_radio_control:
+       case CMD_802_11_RADIO_CONTROL:
                ret = wlan_cmd_802_11_radio_control(priv, cmdptr, cmd_action);
                break;
 
-       case cmd_802_11_rf_antenna:
+       case CMD_802_11_RF_ANTENNA:
                ret = wlan_cmd_802_11_rf_antenna(priv, cmdptr,
                                                 cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_data_rate:
+       case CMD_802_11_DATA_RATE:
                ret = wlan_cmd_802_11_data_rate(priv, cmdptr, cmd_action);
                break;
-       case cmd_802_11_rate_adapt_rateset:
+       case CMD_802_11_RATE_ADAPT_RATESET:
                ret = wlan_cmd_802_11_rate_adapt_rateset(priv,
                                                         cmdptr, cmd_action);
                break;
 
-       case cmd_mac_multicast_adr:
+       case CMD_MAC_MULTICAST_ADR:
                ret = wlan_cmd_mac_multicast_adr(priv, cmdptr, cmd_action);
                break;
 
-       case cmd_802_11_ad_hoc_join:
+       case CMD_802_11_AD_HOC_JOIN:
                ret = libertas_cmd_80211_ad_hoc_join(priv, cmdptr, pdata_buf);
                break;
 
-       case cmd_802_11_rssi:
+       case CMD_802_11_RSSI:
                ret = wlan_cmd_802_11_rssi(priv, cmdptr);
                break;
 
-       case cmd_802_11_ad_hoc_stop:
+       case CMD_802_11_AD_HOC_STOP:
                ret = libertas_cmd_80211_ad_hoc_stop(priv, cmdptr);
                break;
 
-       case cmd_802_11_enable_rsn:
-               ret = wlan_cmd_802_11_enable_rsn(priv, cmdptr, cmd_action);
+       case CMD_802_11_ENABLE_RSN:
+               ret = wlan_cmd_802_11_enable_rsn(priv, cmdptr, cmd_action,
+                               pdata_buf);
                break;
 
-       case cmd_802_11_key_material:
-               ret = wlan_cmd_802_11_key_material(priv, cmdptr,
-                                                  cmd_action, cmd_oid,
-                                                  pdata_buf);
+       case CMD_802_11_KEY_MATERIAL:
+               ret = wlan_cmd_802_11_key_material(priv, cmdptr, cmd_action,
+                               cmd_oid, pdata_buf);
                break;
 
-       case cmd_802_11_pairwise_tsc:
+       case CMD_802_11_PAIRWISE_TSC:
                break;
-       case cmd_802_11_group_tsc:
+       case CMD_802_11_GROUP_TSC:
                break;
 
-       case cmd_802_11_mac_address:
+       case CMD_802_11_MAC_ADDRESS:
                ret = wlan_cmd_802_11_mac_address(priv, cmdptr, cmd_action);
                break;
 
-       case cmd_802_11_eeprom_access:
+       case CMD_802_11_EEPROM_ACCESS:
                ret = wlan_cmd_802_11_eeprom_access(priv, cmdptr,
                                                    cmd_action, pdata_buf);
                break;
 
-       case cmd_802_11_set_afc:
-       case cmd_802_11_get_afc:
+       case CMD_802_11_SET_AFC:
+       case CMD_802_11_GET_AFC:
 
                cmdptr->command = cpu_to_le16(cmd_no);
-               cmdptr->size =
-                   cpu_to_le16(sizeof(struct cmd_ds_802_11_afc) +
-                                    S_DS_GEN);
+               cmdptr->size = cpu_to_le16(sizeof(struct cmd_ds_802_11_afc) +
+                                          S_DS_GEN);
 
                memmove(&cmdptr->params.afc,
                        pdata_buf, sizeof(struct cmd_ds_802_11_afc));
@@ -1334,22 +1299,22 @@ int libertas_prepare_and_send_command(wlan_private * priv,
                ret = 0;
                goto done;
 
-       case cmd_802_11d_domain_info:
+       case CMD_802_11D_DOMAIN_INFO:
                ret = libertas_cmd_802_11d_domain_info(priv, cmdptr,
                                                   cmd_no, cmd_action);
                break;
 
-       case cmd_802_11_sleep_params:
+       case CMD_802_11_SLEEP_PARAMS:
                ret = wlan_cmd_802_11_sleep_params(priv, cmdptr, cmd_action);
                break;
-       case cmd_802_11_inactivity_timeout:
+       case CMD_802_11_INACTIVITY_TIMEOUT:
                ret = wlan_cmd_802_11_inactivity_timeout(priv, cmdptr,
                                                         cmd_action, pdata_buf);
                libertas_set_cmd_ctrl_node(priv, cmdnode, 0, 0, pdata_buf);
                break;
 
-       case cmd_802_11_tpc_cfg:
-               cmdptr->command = cpu_to_le16(cmd_802_11_tpc_cfg);
+       case CMD_802_11_TPC_CFG:
+               cmdptr->command = cpu_to_le16(CMD_802_11_TPC_CFG);
                cmdptr->size =
                    cpu_to_le16(sizeof(struct cmd_ds_802_11_tpc_cfg) +
                                     S_DS_GEN);
@@ -1359,7 +1324,7 @@ int libertas_prepare_and_send_command(wlan_private * priv,
 
                ret = 0;
                break;
-       case cmd_802_11_led_gpio_ctrl:
+       case CMD_802_11_LED_GPIO_CTRL:
                {
                        struct mrvlietypes_ledgpio *gpio =
                            (struct mrvlietypes_ledgpio*)
@@ -1370,7 +1335,7 @@ int libertas_prepare_and_send_command(wlan_private * priv,
                                sizeof(struct cmd_ds_802_11_led_ctrl));
 
                        cmdptr->command =
-                           cpu_to_le16(cmd_802_11_led_gpio_ctrl);
+                           cpu_to_le16(CMD_802_11_LED_GPIO_CTRL);
 
 #define ACTION_NUMLED_TLVTYPE_LEN_FIELDS_LEN 8
                        cmdptr->size =
@@ -1381,8 +1346,8 @@ int libertas_prepare_and_send_command(wlan_private * priv,
                        ret = 0;
                        break;
                }
-       case cmd_802_11_pwr_cfg:
-               cmdptr->command = cpu_to_le16(cmd_802_11_pwr_cfg);
+       case CMD_802_11_PWR_CFG:
+               cmdptr->command = cpu_to_le16(CMD_802_11_PWR_CFG);
                cmdptr->size =
                    cpu_to_le16(sizeof(struct cmd_ds_802_11_pwr_cfg) +
                                     S_DS_GEN);
@@ -1391,31 +1356,28 @@ int libertas_prepare_and_send_command(wlan_private * priv,
 
                ret = 0;
                break;
-       case cmd_bt_access:
+       case CMD_BT_ACCESS:
                ret = wlan_cmd_bt_access(priv, cmdptr, cmd_action, pdata_buf);
                break;
 
-       case cmd_fwt_access:
+       case CMD_FWT_ACCESS:
                ret = wlan_cmd_fwt_access(priv, cmdptr, cmd_action, pdata_buf);
                break;
 
-       case cmd_mesh_access:
+       case CMD_MESH_ACCESS:
                ret = wlan_cmd_mesh_access(priv, cmdptr, cmd_action, pdata_buf);
                break;
 
-       case cmd_get_tsf:
-               cmdptr->command = cpu_to_le16(cmd_get_tsf);
-               cmdptr->size =
-                   cpu_to_le16(sizeof(struct cmd_ds_get_tsf)
-                                    + S_DS_GEN);
+       case CMD_GET_TSF:
+               cmdptr->command = cpu_to_le16(CMD_GET_TSF);
+               cmdptr->size = cpu_to_le16(sizeof(struct cmd_ds_get_tsf) +
+                                          S_DS_GEN);
                ret = 0;
                break;
-       case cmd_802_11_tx_rate_query:
-               cmdptr->command =
-                   cpu_to_le16(cmd_802_11_tx_rate_query);
-               cmdptr->size =
-                   cpu_to_le16(sizeof(struct cmd_tx_rate_query) +
-                                    S_DS_GEN);
+       case CMD_802_11_TX_RATE_QUERY:
+               cmdptr->command = cpu_to_le16(CMD_802_11_TX_RATE_QUERY);
+               cmdptr->size = cpu_to_le16(sizeof(struct cmd_tx_rate_query) +
+                                          S_DS_GEN);
                adapter->txrate = 0;
                ret = 0;
                break;
@@ -1437,9 +1399,9 @@ int libertas_prepare_and_send_command(wlan_private * priv,
 
        libertas_queue_cmd(adapter, cmdnode, 1);
        adapter->nr_cmd_pending++;
-       wake_up_interruptible(&priv->mainthread.waitq);
+       wake_up_interruptible(&priv->waitq);
 
-       if (wait_option & cmd_option_waitforrsp) {
+       if (wait_option & CMD_OPTION_WAITFORRSP) {
                lbs_deb_cmd("PREP_CMD: Wait for CMD response\n");
                might_sleep();
                wait_event_interruptible(cmdnode->cmdwait_q,
@@ -1524,7 +1486,7 @@ done:
  */
 int libertas_free_cmd_buffer(wlan_private * priv)
 {
-       u32 ulbufsize;
+       u32 ulbufsize; /* Someone needs to die for this. Slowly and painfully */
        unsigned int i;
        struct cmd_ctrl_node *tempcmd_array;
        wlan_adapter *adapter = priv->adapter;
@@ -1665,7 +1627,7 @@ int libertas_execute_next_command(wlan_private * priv)
        unsigned long flags;
        int ret = 0;
 
-       lbs_deb_cmd("libertas_execute_next_command\n");
+       lbs_deb_enter(LBS_DEB_CMD);
 
        spin_lock_irqsave(&adapter->driver_lock, flags);
 
@@ -1689,18 +1651,19 @@ int libertas_execute_next_command(wlan_private * priv)
                cmdptr = (struct cmd_ds_command *)cmdnode->bufvirtualaddr;
 
                if (is_command_allowed_in_ps(cmdptr->command)) {
-                       if ((adapter->psstate == PS_STATE_SLEEP)
-                           || (adapter->psstate == PS_STATE_PRE_SLEEP)
-                           ) {
+                       if ((adapter->psstate == PS_STATE_SLEEP) ||
+                           (adapter->psstate == PS_STATE_PRE_SLEEP)) {
                                lbs_deb_cmd(
                                       "EXEC_NEXT_CMD: Cannot send cmd 0x%x in psstate %d\n",
-                                      cmdptr->command, adapter->psstate);
+                                      le16_to_cpu(cmdptr->command),
+                                      adapter->psstate);
                                ret = -1;
                                goto done;
                        }
                        lbs_deb_cmd("EXEC_NEXT_CMD: OK to send command "
                               "0x%x in psstate %d\n",
-                              cmdptr->command, adapter->psstate);
+                                   le16_to_cpu(cmdptr->command),
+                                   adapter->psstate);
                } else if (adapter->psstate != PS_STATE_FULL_POWER) {
                        /*
                         * 1. Non-PS command:
@@ -1714,7 +1677,7 @@ int libertas_execute_next_command(wlan_private * priv)
                         * immediately.
                         */
                        if (cmdptr->command !=
-                           cpu_to_le16(cmd_802_11_ps_mode)) {
+                           cpu_to_le16(CMD_802_11_PS_MODE)) {
                                /*  Prepare to send Exit PS,
                                 *  this non PS command will be sent later */
                                if ((adapter->psstate == PS_STATE_SLEEP)
@@ -1740,7 +1703,7 @@ int libertas_execute_next_command(wlan_private * priv)
                                       "EXEC_NEXT_CMD: PS cmd- action=0x%x\n",
                                       psm->action);
                                if (psm->action !=
-                                   cpu_to_le16(cmd_subcmd_exit_ps)) {
+                                   cpu_to_le16(CMD_SUBCMD_EXIT_PS)) {
                                        lbs_deb_cmd(
                                               "EXEC_NEXT_CMD: Ignore Enter PS cmd\n");
                                        list_del((struct list_head *)cmdnode);
@@ -1750,9 +1713,8 @@ int libertas_execute_next_command(wlan_private * priv)
                                        goto done;
                                }
 
-                               if ((adapter->psstate == PS_STATE_SLEEP)
-                                   || (adapter->psstate == PS_STATE_PRE_SLEEP)
-                                   ) {
+                               if ((adapter->psstate == PS_STATE_SLEEP) ||
+                                   (adapter->psstate == PS_STATE_PRE_SLEEP)) {
                                        lbs_deb_cmd(
                                               "EXEC_NEXT_CMD: Ignore ExitPS cmd in sleep\n");
                                        list_del((struct list_head *)cmdnode);
@@ -1769,21 +1731,21 @@ int libertas_execute_next_command(wlan_private * priv)
                }
                list_del((struct list_head *)cmdnode);
                lbs_deb_cmd("EXEC_NEXT_CMD: Sending 0x%04X command\n",
-                      cmdptr->command);
+                           le16_to_cpu(cmdptr->command));
                DownloadcommandToStation(priv, cmdnode);
        } else {
                /*
                 * check if in power save mode, if yes, put the device back
                 * to PS mode
                 */
-               if ((adapter->psmode != wlan802_11powermodecam) &&
+               if ((adapter->psmode != WLAN802_11POWERMODECAM) &&
                    (adapter->psstate == PS_STATE_FULL_POWER) &&
-                   (adapter->connect_status == libertas_connected)) {
-                       if (adapter->secinfo.WPAenabled
-                           || adapter->secinfo.WPA2enabled) {
+                   (adapter->connect_status == LIBERTAS_CONNECTED)) {
+                       if (adapter->secinfo.WPAenabled ||
+                           adapter->secinfo.WPA2enabled) {
                                /* check for valid WPA group keys */
-                               if (adapter->wpa_mcast_key.len
-                                   || adapter->wpa_unicast_key.len) {
+                               if (adapter->wpa_mcast_key.len ||
+                                   adapter->wpa_unicast_key.len) {
                                        lbs_deb_cmd(
                                               "EXEC_NEXT_CMD: WPA enabled and GTK_SET"
                                               " go back to PS_SLEEP");
@@ -1800,6 +1762,7 @@ int libertas_execute_next_command(wlan_private * priv)
 
        ret = 0;
 done:
+       lbs_deb_leave(LBS_DEB_CMD);
        return ret;
 }
 
@@ -1818,12 +1781,11 @@ void libertas_send_iwevcustom_event(wlan_private * priv, s8 * str)
        iwrq.data.length = strlen(buf) + 1 + IW_EV_LCP_LEN;
 
        /* Send Event to upper layer */
-       lbs_deb_cmd("Event Indication string = %s\n",
-              (char *)buf);
+       lbs_deb_cmd("Event Indication string = %s\n", (char *)buf);
        lbs_deb_cmd("Event Indication String length = %d\n", iwrq.data.length);
 
        lbs_deb_cmd("Sending wireless event IWEVCUSTOM for %s\n", str);
-       wireless_send_event(priv->wlan_dev.netdev, IWEVCUSTOM, &iwrq, buf);
+       wireless_send_event(priv->dev, IWEVCUSTOM, &iwrq, buf);
 
        lbs_deb_leave(LBS_DEB_CMD);
 }
@@ -1839,10 +1801,10 @@ static int sendconfirmsleep(wlan_private * priv, u8 * cmdptr, u16 size)
        lbs_deb_cmd("SEND_SLEEPC_CMD: Before download, size of cmd = %d\n",
               size);
 
-       lbs_dbg_hex("SEND_SLEEPC_CMD: Sleep confirm command", cmdptr, size);
+       lbs_deb_hex(LBS_DEB_CMD, "sleep confirm command", cmdptr, size);
 
        ret = priv->hw_host_to_card(priv, MVMS_CMD, cmdptr, size);
-       priv->wlan_dev.dnld_sent = DNLD_RES_RECEIVED;
+       priv->dnld_sent = DNLD_RES_RECEIVED;
 
        spin_lock_irqsave(&adapter->driver_lock, flags);
        if (adapter->intcounter || adapter->currenttxskb)
@@ -1880,8 +1842,8 @@ void libertas_ps_sleep(wlan_private * priv, int wait_option)
         * Remove this check if it is to be supported in IBSS mode also
         */
 
-       libertas_prepare_and_send_command(priv, cmd_802_11_ps_mode,
-                             cmd_subcmd_enter_ps, wait_option, 0, NULL);
+       libertas_prepare_and_send_command(priv, CMD_802_11_PS_MODE,
+                             CMD_SUBCMD_ENTER_PS, wait_option, 0, NULL);
 
        lbs_deb_leave(LBS_DEB_CMD);
 }
@@ -1895,16 +1857,16 @@ void libertas_ps_sleep(wlan_private * priv, int wait_option)
  */
 void libertas_ps_wakeup(wlan_private * priv, int wait_option)
 {
-       enum WLAN_802_11_POWER_MODE Localpsmode;
+       __le32 Localpsmode;
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       Localpsmode = wlan802_11powermodecam;
+       Localpsmode = cpu_to_le32(WLAN802_11POWERMODECAM);
 
-       lbs_deb_cmd("Exit_PS: Localpsmode = %d\n", Localpsmode);
+       lbs_deb_cmd("Exit_PS: Localpsmode = %d\n", WLAN802_11POWERMODECAM);
 
-       libertas_prepare_and_send_command(priv, cmd_802_11_ps_mode,
-                             cmd_subcmd_exit_ps,
+       libertas_prepare_and_send_command(priv, CMD_802_11_PS_MODE,
+                             CMD_SUBCMD_EXIT_PS,
                              wait_option, 0, &Localpsmode);
 
        lbs_deb_leave(LBS_DEB_CMD);
@@ -1926,7 +1888,7 @@ void libertas_ps_confirm_sleep(wlan_private * priv, u16 psmode)
 
        lbs_deb_enter(LBS_DEB_CMD);
 
-       if (priv->wlan_dev.dnld_sent) {
+       if (priv->dnld_sent) {
                allowed = 0;
                lbs_deb_cmd("D");
        }