drivers: misc: ti-st: fix potential race if st_kim_start fails

[~andy/linux] / drivers / misc / ti-st / st_core.c

diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
index 0a1428016350a6f6cb0946188d5b5e8366207426..8d64b681dd9326c830e9d67a3ccf6d11f6e0ab87 100644 (file)
--- a/drivers/misc/ti-st/st_core.c
+++ b/drivers/misc/ti-st/st_core.c
@@ -562,7 +562,9 @@ long st_register(struct st_proto_s *new_proto)
                        if ((st_gdata->protos_registered != ST_EMPTY) &&
                            (test_bit(ST_REG_PENDING, &st_gdata->st_state))) {
                                pr_err(" KIM failure complete callback ");
+                               spin_lock_irqsave(&st_gdata->lock, flags);
                                st_reg_complete(st_gdata, err);
+                               spin_unlock_irqrestore(&st_gdata->lock, flags);
                                clear_bit(ST_REG_PENDING, &st_gdata->st_state);
                        }
                        return -EINVAL;