]> Pileus Git - ~andy/linux/blobdiff - drivers/media/usb/gspca/m5602/m5602_ov9650.c
[media] gscpa_m5602: Convert to the control framework
[~andy/linux] / drivers / media / usb / gspca / m5602 / m5602_ov9650.c
index 2114a8b90ec98d53b16be0ef8a05367c09e5ea99..e2fe2f942fe648e1ae9cecf1e5f59e00dab4f5c3 100644 (file)
 
 #include "m5602_ov9650.h"
 
-static int ov9650_set_exposure(struct gspca_dev *gspca_dev, __s32 val);
-static int ov9650_get_exposure(struct gspca_dev *gspca_dev, __s32 *val);
-static int ov9650_get_gain(struct gspca_dev *gspca_dev, __s32 *val);
-static int ov9650_set_gain(struct gspca_dev *gspca_dev, __s32 val);
-static int ov9650_get_red_balance(struct gspca_dev *gspca_dev, __s32 *val);
-static int ov9650_set_red_balance(struct gspca_dev *gspca_dev, __s32 val);
-static int ov9650_get_blue_balance(struct gspca_dev *gspca_dev, __s32 *val);
-static int ov9650_set_blue_balance(struct gspca_dev *gspca_dev, __s32 val);
-static int ov9650_get_hflip(struct gspca_dev *gspca_dev, __s32 *val);
-static int ov9650_set_hflip(struct gspca_dev *gspca_dev, __s32 val);
-static int ov9650_get_vflip(struct gspca_dev *gspca_dev, __s32 *val);
-static int ov9650_set_vflip(struct gspca_dev *gspca_dev, __s32 val);
-static int ov9650_get_auto_white_balance(struct gspca_dev *gspca_dev,
-                                        __s32 *val);
-static int ov9650_set_auto_white_balance(struct gspca_dev *gspca_dev,
-                                        __s32 val);
-static int ov9650_get_auto_gain(struct gspca_dev *gspca_dev, __s32 *val);
-static int ov9650_set_auto_gain(struct gspca_dev *gspca_dev, __s32 val);
-static int ov9650_get_auto_exposure(struct gspca_dev *gspca_dev, __s32 *val);
-static int ov9650_set_auto_exposure(struct gspca_dev *gspca_dev, __s32 val);
+static int ov9650_s_ctrl(struct v4l2_ctrl *ctrl);
+static void ov9650_dump_registers(struct sd *sd);
 
 /* Vertically and horizontally flips the image if matched, needed for machines
    where the sensor is mounted upside down */
@@ -113,140 +95,6 @@ static
        {}
 };
 
-static const struct ctrl ov9650_ctrls[] = {
-#define EXPOSURE_IDX 0
-       {
-               {
-                       .id             = V4L2_CID_EXPOSURE,
-                       .type           = V4L2_CTRL_TYPE_INTEGER,
-                       .name           = "exposure",
-                       .minimum        = 0x00,
-                       .maximum        = 0x1ff,
-                       .step           = 0x4,
-                       .default_value  = EXPOSURE_DEFAULT,
-                       .flags          = V4L2_CTRL_FLAG_SLIDER
-               },
-               .set = ov9650_set_exposure,
-               .get = ov9650_get_exposure
-       },
-#define GAIN_IDX 1
-       {
-               {
-                       .id             = V4L2_CID_GAIN,
-                       .type           = V4L2_CTRL_TYPE_INTEGER,
-                       .name           = "gain",
-                       .minimum        = 0x00,
-                       .maximum        = 0x3ff,
-                       .step           = 0x1,
-                       .default_value  = GAIN_DEFAULT,
-                       .flags          = V4L2_CTRL_FLAG_SLIDER
-               },
-               .set = ov9650_set_gain,
-               .get = ov9650_get_gain
-       },
-#define RED_BALANCE_IDX 2
-       {
-               {
-                       .id             = V4L2_CID_RED_BALANCE,
-                       .type           = V4L2_CTRL_TYPE_INTEGER,
-                       .name           = "red balance",
-                       .minimum        = 0x00,
-                       .maximum        = 0xff,
-                       .step           = 0x1,
-                       .default_value  = RED_GAIN_DEFAULT,
-                       .flags          = V4L2_CTRL_FLAG_SLIDER
-               },
-               .set = ov9650_set_red_balance,
-               .get = ov9650_get_red_balance
-       },
-#define BLUE_BALANCE_IDX 3
-       {
-               {
-                       .id             = V4L2_CID_BLUE_BALANCE,
-                       .type           = V4L2_CTRL_TYPE_INTEGER,
-                       .name           = "blue balance",
-                       .minimum        = 0x00,
-                       .maximum        = 0xff,
-                       .step           = 0x1,
-                       .default_value  = BLUE_GAIN_DEFAULT,
-                       .flags          = V4L2_CTRL_FLAG_SLIDER
-               },
-               .set = ov9650_set_blue_balance,
-               .get = ov9650_get_blue_balance
-       },
-#define HFLIP_IDX 4
-       {
-               {
-                       .id             = V4L2_CID_HFLIP,
-                       .type           = V4L2_CTRL_TYPE_BOOLEAN,
-                       .name           = "horizontal flip",
-                       .minimum        = 0,
-                       .maximum        = 1,
-                       .step           = 1,
-                       .default_value  = 0
-               },
-               .set = ov9650_set_hflip,
-               .get = ov9650_get_hflip
-       },
-#define VFLIP_IDX 5
-       {
-               {
-                       .id             = V4L2_CID_VFLIP,
-                       .type           = V4L2_CTRL_TYPE_BOOLEAN,
-                       .name           = "vertical flip",
-                       .minimum        = 0,
-                       .maximum        = 1,
-                       .step           = 1,
-                       .default_value  = 0
-               },
-               .set = ov9650_set_vflip,
-               .get = ov9650_get_vflip
-       },
-#define AUTO_WHITE_BALANCE_IDX 6
-       {
-               {
-                       .id             = V4L2_CID_AUTO_WHITE_BALANCE,
-                       .type           = V4L2_CTRL_TYPE_BOOLEAN,
-                       .name           = "auto white balance",
-                       .minimum        = 0,
-                       .maximum        = 1,
-                       .step           = 1,
-                       .default_value  = 1
-               },
-               .set = ov9650_set_auto_white_balance,
-               .get = ov9650_get_auto_white_balance
-       },
-#define AUTO_GAIN_CTRL_IDX 7
-       {
-               {
-                       .id             = V4L2_CID_AUTOGAIN,
-                       .type           = V4L2_CTRL_TYPE_BOOLEAN,
-                       .name           = "auto gain control",
-                       .minimum        = 0,
-                       .maximum        = 1,
-                       .step           = 1,
-                       .default_value  = 1
-               },
-               .set = ov9650_set_auto_gain,
-               .get = ov9650_get_auto_gain
-       },
-#define AUTO_EXPOSURE_IDX 8
-       {
-               {
-                       .id             = V4L2_CID_EXPOSURE_AUTO,
-                       .type           = V4L2_CTRL_TYPE_BOOLEAN,
-                       .name           = "auto exposure",
-                       .minimum        = 0,
-                       .maximum        = 1,
-                       .step           = 1,
-                       .default_value  = 1
-               },
-               .set = ov9650_set_auto_exposure,
-               .get = ov9650_get_auto_exposure
-       }
-
-};
-
 static struct v4l2_pix_format ov9650_modes[] = {
        {
                176,
@@ -291,13 +139,14 @@ static struct v4l2_pix_format ov9650_modes[] = {
        }
 };
 
-static void ov9650_dump_registers(struct sd *sd);
+static const struct v4l2_ctrl_ops ov9650_ctrl_ops = {
+       .s_ctrl = ov9650_s_ctrl,
+};
 
 int ov9650_probe(struct sd *sd)
 {
        int err = 0;
        u8 prod_id = 0, ver_id = 0, i;
-       s32 *sensor_settings;
 
        if (force_sensor) {
                if (force_sensor == OV9650_SENSOR) {
@@ -338,19 +187,9 @@ int ov9650_probe(struct sd *sd)
        return -ENODEV;
 
 sensor_found:
-       sensor_settings = kmalloc(
-               ARRAY_SIZE(ov9650_ctrls) * sizeof(s32), GFP_KERNEL);
-       if (!sensor_settings)
-               return -ENOMEM;
-
        sd->gspca_dev.cam.cam_mode = ov9650_modes;
        sd->gspca_dev.cam.nmodes = ARRAY_SIZE(ov9650_modes);
-       sd->desc->ctrls = ov9650_ctrls;
-       sd->desc->nctrls = ARRAY_SIZE(ov9650_ctrls);
 
-       for (i = 0; i < ARRAY_SIZE(ov9650_ctrls); i++)
-               sensor_settings[i] = ov9650_ctrls[i].qctrl.default_value;
-       sd->sensor_priv = sensor_settings;
        return 0;
 }
 
@@ -358,7 +197,6 @@ int ov9650_init(struct sd *sd)
 {
        int i, err = 0;
        u8 data;
-       s32 *sensor_settings = sd->sensor_priv;
 
        if (dump_sensor)
                ov9650_dump_registers(sd);
@@ -372,46 +210,52 @@ int ov9650_init(struct sd *sd)
                        err = m5602_write_bridge(sd, init_ov9650[i][1], data);
        }
 
-       err = ov9650_set_exposure(&sd->gspca_dev,
-                                  sensor_settings[EXPOSURE_IDX]);
-       if (err < 0)
-               return err;
-
-       err = ov9650_set_gain(&sd->gspca_dev, sensor_settings[GAIN_IDX]);
-       if (err < 0)
-               return err;
-
-       err = ov9650_set_red_balance(&sd->gspca_dev,
-                                     sensor_settings[RED_BALANCE_IDX]);
-       if (err < 0)
-               return err;
-
-       err = ov9650_set_blue_balance(&sd->gspca_dev,
-                                      sensor_settings[BLUE_BALANCE_IDX]);
-       if (err < 0)
-               return err;
-
-       err = ov9650_set_hflip(&sd->gspca_dev, sensor_settings[HFLIP_IDX]);
-       if (err < 0)
-               return err;
-
-       err = ov9650_set_vflip(&sd->gspca_dev, sensor_settings[VFLIP_IDX]);
-       if (err < 0)
-               return err;
+       return 0;
+}
 
-       err = ov9650_set_auto_exposure(&sd->gspca_dev,
-                               sensor_settings[AUTO_EXPOSURE_IDX]);
-       if (err < 0)
-               return err;
+int ov9650_init_controls(struct sd *sd)
+{
+       struct v4l2_ctrl_handler *hdl = &sd->gspca_dev.ctrl_handler;
+
+       sd->gspca_dev.vdev.ctrl_handler = hdl;
+       v4l2_ctrl_handler_init(hdl, 9);
+
+       sd->auto_white_bal = v4l2_ctrl_new_std(hdl, &ov9650_ctrl_ops,
+                                              V4L2_CID_AUTO_WHITE_BALANCE,
+                                              0, 1, 1, 1);
+       sd->red_bal = v4l2_ctrl_new_std(hdl, &ov9650_ctrl_ops,
+                                       V4L2_CID_RED_BALANCE, 0, 255, 1,
+                                       RED_GAIN_DEFAULT);
+       sd->blue_bal = v4l2_ctrl_new_std(hdl, &ov9650_ctrl_ops,
+                                       V4L2_CID_BLUE_BALANCE, 0, 255, 1,
+                                       BLUE_GAIN_DEFAULT);
+
+       sd->autoexpo = v4l2_ctrl_new_std_menu(hdl, &ov9650_ctrl_ops,
+                         V4L2_CID_EXPOSURE_AUTO, 1, 0, V4L2_EXPOSURE_AUTO);
+       sd->expo = v4l2_ctrl_new_std(hdl, &ov9650_ctrl_ops, V4L2_CID_EXPOSURE,
+                         0, 0x1ff, 4, EXPOSURE_DEFAULT);
+
+       sd->autogain = v4l2_ctrl_new_std(hdl, &ov9650_ctrl_ops,
+                                        V4L2_CID_AUTOGAIN, 0, 1, 1, 1);
+       sd->gain = v4l2_ctrl_new_std(hdl, &ov9650_ctrl_ops, V4L2_CID_GAIN, 0,
+                                    0x3ff, 1, GAIN_DEFAULT);
+
+       sd->hflip = v4l2_ctrl_new_std(hdl, &ov9650_ctrl_ops, V4L2_CID_HFLIP,
+                                     0, 1, 1, 0);
+       sd->vflip = v4l2_ctrl_new_std(hdl, &ov9650_ctrl_ops, V4L2_CID_VFLIP,
+                                     0, 1, 1, 0);
+
+       if (hdl->error) {
+               pr_err("Could not initialize controls\n");
+               return hdl->error;
+       }
 
-       err = ov9650_set_auto_white_balance(&sd->gspca_dev,
-                               sensor_settings[AUTO_WHITE_BALANCE_IDX]);
-       if (err < 0)
-               return err;
+       v4l2_ctrl_auto_cluster(3, &sd->auto_white_bal, 0, false);
+       v4l2_ctrl_auto_cluster(2, &sd->autoexpo, 0, false);
+       v4l2_ctrl_auto_cluster(2, &sd->autogain, 0, false);
+       v4l2_ctrl_cluster(2, &sd->hflip);
 
-       err = ov9650_set_auto_gain(&sd->gspca_dev,
-                               sensor_settings[AUTO_GAIN_CTRL_IDX]);
-       return err;
+       return 0;
 }
 
 int ov9650_start(struct sd *sd)
@@ -419,7 +263,6 @@ int ov9650_start(struct sd *sd)
        u8 data;
        int i, err = 0;
        struct cam *cam = &sd->gspca_dev.cam;
-       s32 *sensor_settings = sd->sensor_priv;
 
        int width = cam->cam_mode[sd->gspca_dev.curr_mode].width;
        int height = cam->cam_mode[sd->gspca_dev.curr_mode].height;
@@ -427,9 +270,9 @@ int ov9650_start(struct sd *sd)
        int hor_offs = OV9650_LEFT_OFFSET;
 
        if ((!dmi_check_system(ov9650_flip_dmi_table) &&
-               sensor_settings[VFLIP_IDX]) ||
+               sd->vflip->val) ||
                (dmi_check_system(ov9650_flip_dmi_table) &&
-               !sensor_settings[VFLIP_IDX]))
+               !sd->vflip->val))
                ver_offs--;
 
        if (width <= 320)
@@ -553,29 +396,16 @@ void ov9650_disconnect(struct sd *sd)
        ov9650_stop(sd);
 
        sd->sensor = NULL;
-       kfree(sd->sensor_priv);
-}
-
-static int ov9650_get_exposure(struct gspca_dev *gspca_dev, __s32 *val)
-{
-       struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
-
-       *val = sensor_settings[EXPOSURE_IDX];
-       PDEBUG(D_V4L2, "Read exposure %d", *val);
-       return 0;
 }
 
 static int ov9650_set_exposure(struct gspca_dev *gspca_dev, __s32 val)
 {
        struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
        u8 i2c_data;
        int err;
 
        PDEBUG(D_V4L2, "Set exposure to %d", val);
 
-       sensor_settings[EXPOSURE_IDX] = val;
        /* The 6 MSBs */
        i2c_data = (val >> 10) & 0x3f;
        err = m5602_write_sensor(sd, OV9650_AECHM,
@@ -596,27 +426,14 @@ static int ov9650_set_exposure(struct gspca_dev *gspca_dev, __s32 val)
        return err;
 }
 
-static int ov9650_get_gain(struct gspca_dev *gspca_dev, __s32 *val)
-{
-       struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
-
-       *val = sensor_settings[GAIN_IDX];
-       PDEBUG(D_V4L2, "Read gain %d", *val);
-       return 0;
-}
-
 static int ov9650_set_gain(struct gspca_dev *gspca_dev, __s32 val)
 {
        int err;
        u8 i2c_data;
        struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
 
        PDEBUG(D_V4L2, "Setting gain to %d", val);
 
-       sensor_settings[GAIN_IDX] = val;
-
        /* The 2 MSB */
        /* Read the OV9650_VREF register first to avoid
           corrupting the VREF high and low bits */
@@ -637,117 +454,46 @@ static int ov9650_set_gain(struct gspca_dev *gspca_dev, __s32 val)
        return err;
 }
 
-static int ov9650_get_red_balance(struct gspca_dev *gspca_dev, __s32 *val)
-{
-       struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
-
-       *val = sensor_settings[RED_BALANCE_IDX];
-       PDEBUG(D_V4L2, "Read red gain %d", *val);
-       return 0;
-}
-
 static int ov9650_set_red_balance(struct gspca_dev *gspca_dev, __s32 val)
 {
        int err;
        u8 i2c_data;
        struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
 
        PDEBUG(D_V4L2, "Set red gain to %d", val);
 
-       sensor_settings[RED_BALANCE_IDX] = val;
-
        i2c_data = val & 0xff;
        err = m5602_write_sensor(sd, OV9650_RED, &i2c_data, 1);
        return err;
 }
 
-static int ov9650_get_blue_balance(struct gspca_dev *gspca_dev, __s32 *val)
-{
-       struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
-
-       *val = sensor_settings[BLUE_BALANCE_IDX];
-       PDEBUG(D_V4L2, "Read blue gain %d", *val);
-
-       return 0;
-}
-
 static int ov9650_set_blue_balance(struct gspca_dev *gspca_dev, __s32 val)
 {
        int err;
        u8 i2c_data;
        struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
 
        PDEBUG(D_V4L2, "Set blue gain to %d", val);
 
-       sensor_settings[BLUE_BALANCE_IDX] = val;
-
        i2c_data = val & 0xff;
        err = m5602_write_sensor(sd, OV9650_BLUE, &i2c_data, 1);
        return err;
 }
 
-static int ov9650_get_hflip(struct gspca_dev *gspca_dev, __s32 *val)
-{
-       struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
-
-       *val = sensor_settings[HFLIP_IDX];
-       PDEBUG(D_V4L2, "Read horizontal flip %d", *val);
-       return 0;
-}
-
-static int ov9650_set_hflip(struct gspca_dev *gspca_dev, __s32 val)
+static int ov9650_set_hvflip(struct gspca_dev *gspca_dev)
 {
        int err;
        u8 i2c_data;
        struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
+       int hflip = sd->hflip->val;
+       int vflip = sd->vflip->val;
 
-       PDEBUG(D_V4L2, "Set horizontal flip to %d", val);
-
-       sensor_settings[HFLIP_IDX] = val;
-
-       if (!dmi_check_system(ov9650_flip_dmi_table))
-               i2c_data = ((val & 0x01) << 5) |
-                               (sensor_settings[VFLIP_IDX] << 4);
-       else
-               i2c_data = ((val & 0x01) << 5) |
-                               (!sensor_settings[VFLIP_IDX] << 4);
-
-       err = m5602_write_sensor(sd, OV9650_MVFP, &i2c_data, 1);
-
-       return err;
-}
-
-static int ov9650_get_vflip(struct gspca_dev *gspca_dev, __s32 *val)
-{
-       struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
-
-       *val = sensor_settings[VFLIP_IDX];
-       PDEBUG(D_V4L2, "Read vertical flip %d", *val);
-
-       return 0;
-}
-
-static int ov9650_set_vflip(struct gspca_dev *gspca_dev, __s32 val)
-{
-       int err;
-       u8 i2c_data;
-       struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
-
-       PDEBUG(D_V4L2, "Set vertical flip to %d", val);
-       sensor_settings[VFLIP_IDX] = val;
+       PDEBUG(D_V4L2, "Set hvflip to %d %d", hflip, vflip);
 
        if (dmi_check_system(ov9650_flip_dmi_table))
-               val = !val;
+               vflip = !vflip;
 
-       i2c_data = ((val & 0x01) << 4) | (sensor_settings[VFLIP_IDX] << 5);
+       i2c_data = (hflip << 5) | (vflip << 4);
        err = m5602_write_sensor(sd, OV9650_MVFP, &i2c_data, 1);
        if (err < 0)
                return err;
@@ -759,57 +505,34 @@ static int ov9650_set_vflip(struct gspca_dev *gspca_dev, __s32 val)
        return err;
 }
 
-static int ov9650_get_auto_exposure(struct gspca_dev *gspca_dev, __s32 *val)
-{
-       struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
-
-       *val = sensor_settings[AUTO_EXPOSURE_IDX];
-       PDEBUG(D_V4L2, "Read auto exposure control %d", *val);
-       return 0;
-}
-
 static int ov9650_set_auto_exposure(struct gspca_dev *gspca_dev,
                                    __s32 val)
 {
        int err;
        u8 i2c_data;
        struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
 
        PDEBUG(D_V4L2, "Set auto exposure control to %d", val);
 
-       sensor_settings[AUTO_EXPOSURE_IDX] = val;
        err = m5602_read_sensor(sd, OV9650_COM8, &i2c_data, 1);
        if (err < 0)
                return err;
 
+       val = (val == V4L2_EXPOSURE_AUTO);
        i2c_data = ((i2c_data & 0xfe) | ((val & 0x01) << 0));
 
        return m5602_write_sensor(sd, OV9650_COM8, &i2c_data, 1);
 }
 
-static int ov9650_get_auto_white_balance(struct gspca_dev *gspca_dev,
-                                        __s32 *val)
-{
-       struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
-
-       *val = sensor_settings[AUTO_WHITE_BALANCE_IDX];
-       return 0;
-}
-
 static int ov9650_set_auto_white_balance(struct gspca_dev *gspca_dev,
                                         __s32 val)
 {
        int err;
        u8 i2c_data;
        struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
 
        PDEBUG(D_V4L2, "Set auto white balance to %d", val);
 
-       sensor_settings[AUTO_WHITE_BALANCE_IDX] = val;
        err = m5602_read_sensor(sd, OV9650_COM8, &i2c_data, 1);
        if (err < 0)
                return err;
@@ -820,26 +543,14 @@ static int ov9650_set_auto_white_balance(struct gspca_dev *gspca_dev,
        return err;
 }
 
-static int ov9650_get_auto_gain(struct gspca_dev *gspca_dev, __s32 *val)
-{
-       struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
-
-       *val = sensor_settings[AUTO_GAIN_CTRL_IDX];
-       PDEBUG(D_V4L2, "Read auto gain control %d", *val);
-       return 0;
-}
-
 static int ov9650_set_auto_gain(struct gspca_dev *gspca_dev, __s32 val)
 {
        int err;
        u8 i2c_data;
        struct sd *sd = (struct sd *) gspca_dev;
-       s32 *sensor_settings = sd->sensor_priv;
 
        PDEBUG(D_V4L2, "Set auto gain control to %d", val);
 
-       sensor_settings[AUTO_GAIN_CTRL_IDX] = val;
        err = m5602_read_sensor(sd, OV9650_COM8, &i2c_data, 1);
        if (err < 0)
                return err;
@@ -849,6 +560,48 @@ static int ov9650_set_auto_gain(struct gspca_dev *gspca_dev, __s32 val)
        return m5602_write_sensor(sd, OV9650_COM8, &i2c_data, 1);
 }
 
+static int ov9650_s_ctrl(struct v4l2_ctrl *ctrl)
+{
+       struct gspca_dev *gspca_dev =
+               container_of(ctrl->handler, struct gspca_dev, ctrl_handler);
+       struct sd *sd = (struct sd *) gspca_dev;
+       int err;
+
+       if (!gspca_dev->streaming)
+               return 0;
+
+       switch (ctrl->id) {
+       case V4L2_CID_AUTO_WHITE_BALANCE:
+               err = ov9650_set_auto_white_balance(gspca_dev, ctrl->val);
+               if (err || ctrl->val)
+                       return err;
+               err = ov9650_set_red_balance(gspca_dev, sd->red_bal->val);
+               if (err)
+                       return err;
+               err = ov9650_set_blue_balance(gspca_dev, sd->blue_bal->val);
+               break;
+       case V4L2_CID_EXPOSURE_AUTO:
+               err = ov9650_set_auto_exposure(gspca_dev, ctrl->val);
+               if (err || ctrl->val == V4L2_EXPOSURE_AUTO)
+                       return err;
+               err = ov9650_set_exposure(gspca_dev, sd->expo->val);
+               break;
+       case V4L2_CID_AUTOGAIN:
+               err = ov9650_set_auto_gain(gspca_dev, ctrl->val);
+               if (err || ctrl->val)
+                       return err;
+               err = ov9650_set_gain(gspca_dev, sd->gain->val);
+               break;
+       case V4L2_CID_HFLIP:
+               err = ov9650_set_hvflip(gspca_dev);
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return err;
+}
+
 static void ov9650_dump_registers(struct sd *sd)
 {
        int address;