]> Pileus Git - ~andy/linux/blobdiff - drivers/media/dvb/dvb-usb/m920x.c
V4L/DVB (5426): M920x: remove unneeded code
[~andy/linux] / drivers / media / dvb / dvb-usb / m920x.c
index f06fee3af9e626f7ad881da34b3ce6f0594e07e8..621819f6597aec5fa45f3003f16dcab5b15fe368 100644 (file)
@@ -39,7 +39,8 @@ static struct dvb_usb_rc_key megasky_rc_keys [] = {
        { 0x0, 0x0e, KEY_COFFEE }, /* "MTS" */
 };
 
-static inline int m9206_read(struct usb_device *udev, u8 request, u16 value, u16 index, void *data, int size)
+static inline int m9206_read(struct usb_device *udev, u8 request, u16 value,\
+                            u16 index, void *data, int size)
 {
        int ret;
 
@@ -55,7 +56,8 @@ static inline int m9206_read(struct usb_device *udev, u8 request, u16 value, u16
        return 0;
 }
 
-static inline int m9206_write(struct usb_device *udev, u8 request, u16 value, u16 index)
+static inline int m9206_write(struct usb_device *udev, u8 request,
+                             u16 value, u16 index)
 {
        int ret;
 
@@ -65,16 +67,18 @@ static inline int m9206_write(struct usb_device *udev, u8 request, u16 value, u1
        return ret;
 }
 
-static int m9206_rc_init(struct usb_device *udev)
+static int m9206_init(struct dvb_usb_device *d)
 {
        int ret = 0;
 
        /* Remote controller init. */
-       if ((ret = m9206_write(udev, M9206_CORE, 0xa8, M9206_RC_INIT2)) != 0)
-               return ret;
+       if (d->props.rc_query) {
+               if ((ret = m9206_write(d->udev, M9206_CORE, 0xa8, M9206_RC_INIT2)) != 0)
+                       return ret;
 
-       if ((ret = m9206_write(udev, M9206_CORE, 0x51, M9206_RC_INIT1)) != 0)
-               return ret;
+               if ((ret = m9206_write(d->udev, M9206_CORE, 0x51, M9206_RC_INIT1)) != 0)
+                       return ret;
+       }
 
        return ret;
 }
@@ -85,16 +89,15 @@ static int m9206_rc_query(struct dvb_usb_device *d, u32 *event, int *state)
        int i, ret = 0;
        u8 rc_state[2];
 
-
        if ((ret = m9206_read(d->udev, M9206_CORE, 0x0, M9206_RC_STATE, rc_state, 1)) != 0)
                goto unlock;
 
        if ((ret = m9206_read(d->udev, M9206_CORE, 0x0, M9206_RC_KEY, rc_state + 1, 1)) != 0)
                goto unlock;
 
-       for (i = 0; i < ARRAY_SIZE(megasky_rc_keys); i++)
-               if (megasky_rc_keys[i].data == rc_state[1]) {
-                       *event = megasky_rc_keys[i].event;
+       for (i = 0; i < d->props.rc_key_map_size; i++)
+               if (d->props.rc_key_map[i].data == rc_state[1]) {
+                       *event = d->props.rc_key_map[i].event;
 
                        switch(rc_state[0]) {
                        case 0x80:
@@ -131,55 +134,49 @@ static int m9206_rc_query(struct dvb_usb_device *d, u32 *event, int *state)
 }
 
 /* I2C */
-static int m9206_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msg[], int num)
+static int m9206_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msg[],
+                         int num)
 {
        struct dvb_usb_device *d = i2c_get_adapdata(adap);
-       struct m9206_state *m = d->priv;
-       int i;
+       int i, j;
        int ret = 0;
 
        if (mutex_lock_interruptible(&d->i2c_mutex) < 0)
                return -EAGAIN;
 
-       if (num > 2)
-               return -EINVAL;
-
        for (i = 0; i < num; i++) {
-               if ((ret = m9206_write(d->udev, M9206_I2C, msg[i].addr, 0x80)) != 0)
-                       goto unlock;
+               if (msg[i].flags & I2C_M_RD) {
 
-               if ((ret = m9206_write(d->udev, M9206_I2C, msg[i].buf[0], 0x0)) != 0)
-                       goto unlock;
-
-               if (i + 1 < num && msg[i + 1].flags & I2C_M_RD) {
-                       int i2c_i;
-
-                       for (i2c_i = 0; i2c_i < M9206_I2C_MAX; i2c_i++)
-                               if (msg[i].addr == m->i2c_r[i2c_i].addr)
-                                       break;
-
-                       if (i2c_i >= M9206_I2C_MAX) {
-                               deb_rc("No magic for i2c addr!\n");
-                               ret = -EINVAL;
+                       if ((ret = m9206_write(d->udev, M9206_I2C, (msg[i].addr << 1) | 0x01, 0x80)) != 0)
                                goto unlock;
-                       }
 
-                       if ((ret = m9206_write(d->udev, M9206_I2C, m->i2c_r[i2c_i].magic, 0x80)) != 0)
-                               goto unlock;
+                       for(j = 0; j < msg[i].len; j++) {
+                               if (j + 1 == msg[i].len && i + 1== num) {
+                                       if ((ret = m9206_read(d->udev, M9206_I2C, 0x0, 0x60, &msg[i].buf[j], msg[i].len)) != 0)
+                                               goto unlock;
+                               } else {
+                                       if ((ret = m9206_read(d->udev, M9206_I2C, 0x0, 0x21, &msg[i].buf[j], msg[i].len)) != 0)
+                                               goto unlock;
+                               }
+                       }
 
-                       if ((ret = m9206_read(d->udev, M9206_I2C, 0x0, 0x60, msg[i + 1].buf, msg[i + 1].len)) != 0)
+               } else {
+                       if ((ret = m9206_write(d->udev, M9206_I2C, msg[i].addr << 1, 0x80)) != 0)
                                goto unlock;
 
-                       i++;
-               } else {
-                       if (msg[i].len != 2)
-                               return -EINVAL;
+                       for(j = 0; j < msg[i].len; j++) {
+                               if (j + 1 == msg[i].len && i + 1== num) {
+                                       if ((ret = m9206_write(d->udev, M9206_I2C, msg[i].buf[j], 0x40)) != 0)
+                                               goto unlock;
 
-                       if ((ret = m9206_write(d->udev, M9206_I2C, msg[i].buf[1], 0x40)) != 0)
-                               goto unlock;
+                               } else {
+                                       if ((ret = m9206_write(d->udev, M9206_I2C, msg[i].buf[j], 0x0)) != 0)
+                                               goto unlock;
+                               }
+                       }
                }
        }
-       ret = i;
+       ret = num;
        unlock:
        mutex_unlock(&d->i2c_mutex);
 
@@ -196,67 +193,9 @@ static struct i2c_algorithm m9206_i2c_algo = {
        .functionality = m9206_i2c_func,
 };
 
-/* Callbacks for DVB USB */
-static int megasky_identify_state(struct usb_device *udev,
-                                 struct dvb_usb_device_properties *props,
-                                 struct dvb_usb_device_description **desc,
-                                 int *cold)
-{
-       struct usb_host_interface *alt;
-
-       alt = usb_altnum_to_altsetting(usb_ifnum_to_if(udev, 0), 1);
-       *cold = (alt == NULL) ? 1 : 0;
-
-       return 0;
-}
-
-static int megasky_mt352_demod_init(struct dvb_frontend *fe)
-{
-       u8 config[] = { CONFIG, 0x3d };
-       u8 clock[] = { CLOCK_CTL, 0x30 };
-       u8 reset[] = { RESET, 0x80 };
-       u8 adc_ctl[] = { ADC_CTL_1, 0x40 };
-       u8 agc[] = { AGC_TARGET, 0x1c, 0x20 };
-       u8 sec_agc[] = { 0x69, 0x00, 0xff, 0xff, 0x40, 0xff, 0x00, 0x40, 0x40 };
-       u8 unk1[] = { 0x93, 0x1a };
-       u8 unk2[] = { 0xb5, 0x7a };
-
-       mt352_write(fe, config, ARRAY_SIZE(config));
-       mt352_write(fe, clock, ARRAY_SIZE(clock));
-       mt352_write(fe, reset, ARRAY_SIZE(reset));
-       mt352_write(fe, adc_ctl, ARRAY_SIZE(adc_ctl));
-       mt352_write(fe, agc, ARRAY_SIZE(agc));
-       mt352_write(fe, sec_agc, ARRAY_SIZE(sec_agc));
-       mt352_write(fe, unk1, ARRAY_SIZE(unk1));
-       mt352_write(fe, unk2, ARRAY_SIZE(unk2));
-
-       deb_rc("Demod init!\n");
-
-       return 0;
-}
-
-static struct mt352_config megasky_mt352_config = {
-       .demod_address = 0x1e,
-       .no_tuner = 1,
-       .demod_init = megasky_mt352_demod_init,
-};
 
-static int megasky_frontend_attach(struct dvb_usb_adapter *adap)
-{
-       struct m9206_state *m = adap->dev->priv;
-
-       deb_rc("megasky_frontend_attach!\n");
-
-       m->i2c_r[M9206_I2C_DEMOD].addr = megasky_mt352_config.demod_address;
-       m->i2c_r[M9206_I2C_DEMOD].magic = 0x1f;
-
-       if ((adap->fe = dvb_attach(mt352_attach, &megasky_mt352_config, &adap->dev->i2c_adap)) == NULL)
-               return -EIO;
-
-       return 0;
-}
-
-static int m9206_set_filter(struct dvb_usb_adapter *adap, int type, int idx, int pid)
+static int m9206_set_filter(struct dvb_usb_adapter *adap, int type, int idx,
+                           int pid)
 {
        int ret = 0;
 
@@ -323,7 +262,8 @@ static int m9206_pid_filter_ctrl(struct dvb_usb_adapter *adap, int onoff)
        return m9206_update_filters(adap);
 }
 
-static int m9206_pid_filter(struct dvb_usb_adapter *adap, int index, u16 pid, int onoff)
+static int m9206_pid_filter(struct dvb_usb_adapter *adap, int index, u16 pid,
+                           int onoff)
 {
        struct m9206_state *m = adap->dev->priv;
 
@@ -332,7 +272,8 @@ static int m9206_pid_filter(struct dvb_usb_adapter *adap, int index, u16 pid, in
        return m9206_update_filters(adap);
 }
 
-static int m9206_firmware_download(struct usb_device *udev, const struct firmware *fw)
+static int m9206_firmware_download(struct usb_device *udev,
+                                  const struct firmware *fw)
 {
        u16 value, index, size;
        u8 read[4], *buff;
@@ -394,17 +335,67 @@ static int m9206_firmware_download(struct usb_device *udev, const struct firmwar
        return ret;
 }
 
-static struct qt1010_config megasky_qt1010_config = {
-       .i2c_address = 0xc4
+/* Callbacks for DVB USB */
+static int megasky_identify_state(struct usb_device *udev,
+                                 struct dvb_usb_device_properties *props,
+                                 struct dvb_usb_device_description **desc,
+                                 int *cold)
+{
+       struct usb_host_interface *alt;
+
+       alt = usb_altnum_to_altsetting(usb_ifnum_to_if(udev, 0), 1);
+       *cold = (alt == NULL) ? 1 : 0;
+
+       return 0;
+}
+
+static int megasky_mt352_demod_init(struct dvb_frontend *fe)
+{
+       u8 config[] = { CONFIG, 0x3d };
+       u8 clock[] = { CLOCK_CTL, 0x30 };
+       u8 reset[] = { RESET, 0x80 };
+       u8 adc_ctl[] = { ADC_CTL_1, 0x40 };
+       u8 agc[] = { AGC_TARGET, 0x1c, 0x20 };
+       u8 sec_agc[] = { 0x69, 0x00, 0xff, 0xff, 0x40, 0xff, 0x00, 0x40, 0x40 };
+       u8 unk1[] = { 0x93, 0x1a };
+       u8 unk2[] = { 0xb5, 0x7a };
+
+       mt352_write(fe, config, ARRAY_SIZE(config));
+       mt352_write(fe, clock, ARRAY_SIZE(clock));
+       mt352_write(fe, reset, ARRAY_SIZE(reset));
+       mt352_write(fe, adc_ctl, ARRAY_SIZE(adc_ctl));
+       mt352_write(fe, agc, ARRAY_SIZE(agc));
+       mt352_write(fe, sec_agc, ARRAY_SIZE(sec_agc));
+       mt352_write(fe, unk1, ARRAY_SIZE(unk1));
+       mt352_write(fe, unk2, ARRAY_SIZE(unk2));
+
+       deb_rc("Demod init!\n");
+
+       return 0;
+}
+
+static struct mt352_config megasky_mt352_config = {
+       .demod_address = 0x0f,
+       .no_tuner = 1,
+       .demod_init = megasky_mt352_demod_init,
 };
 
-static int megasky_tuner_attach(struct dvb_usb_adapter *adap)
+static int megasky_mt352_frontend_attach(struct dvb_usb_adapter *adap)
 {
-       struct m9206_state *m = adap->dev->priv;
+       deb_rc("megasky_frontend_attach!\n");
 
-       m->i2c_r[M9206_I2C_TUNER].addr = megasky_qt1010_config.i2c_address;
-       m->i2c_r[M9206_I2C_TUNER].magic = 0xc5;
+       if ((adap->fe = dvb_attach(mt352_attach, &megasky_mt352_config, &adap->dev->i2c_adap)) == NULL)
+               return -EIO;
+
+       return 0;
+}
 
+static struct qt1010_config megasky_qt1010_config = {
+       .i2c_address = 0x62
+};
+
+static int megasky_qt1010_tuner_attach(struct dvb_usb_adapter *adap)
+{
        if (dvb_attach(qt1010_attach, adap->fe, &adap->dev->i2c_adap,
                       &megasky_qt1010_config) == NULL)
                return -ENODEV;
@@ -415,30 +406,35 @@ static int megasky_tuner_attach(struct dvb_usb_adapter *adap)
 /* DVB USB Driver stuff */
 static struct dvb_usb_device_properties megasky_properties;
 
-static int m920x_probe(struct usb_interface *intf, const struct usb_device_id *id)
+static int m920x_probe(struct usb_interface *intf,
+                      const struct usb_device_id *id)
 {
        struct dvb_usb_device *d;
        struct usb_host_interface *alt;
        int ret;
 
-       if ((ret = dvb_usb_device_init(intf, &megasky_properties, THIS_MODULE, &d)) == 0) {
-               deb_rc("probed!\n");
+       deb_rc("Probed!\n");
 
-               alt = usb_altnum_to_altsetting(intf, 1);
-               if (alt == NULL) {
-                       deb_rc("not alt found!\n");
-                       return -ENODEV;
-               }
+       if ((ret = dvb_usb_device_init(intf, &megasky_properties, THIS_MODULE, &d)) == 0)
+               goto found;
 
-               ret = usb_set_interface(d->udev, alt->desc.bInterfaceNumber, alt->desc.bAlternateSetting);
-               if (ret < 0)
-                       return ret;
-
-               deb_rc("Changed to alternate setting!\n");
+       return ret;
 
-               if ((ret = m9206_rc_init(d->udev)) != 0)
-                       return ret;
+found:
+       alt = usb_altnum_to_altsetting(intf, 1);
+       if (alt == NULL) {
+               deb_rc("No alt found!\n");
+               return -ENODEV;
        }
+
+       ret = usb_set_interface(d->udev, alt->desc.bInterfaceNumber,
+                               alt->desc.bAlternateSetting);
+       if (ret < 0)
+               return ret;
+
+       if ((ret = m9206_init(d)) != 0)
+               return ret;
+
        return ret;
 }
 
@@ -449,8 +445,7 @@ static struct usb_device_id m920x_table [] = {
 MODULE_DEVICE_TABLE (usb, m920x_table);
 
 static struct dvb_usb_device_properties megasky_properties = {
-       .caps = DVB_USB_IS_AN_I2C_ADAPTER | DVB_USB_ADAP_HAS_PID_FILTER |
-               DVB_USB_ADAP_PID_FILTER_CAN_BE_TURNED_OFF,
+       .caps = DVB_USB_IS_AN_I2C_ADAPTER,
 
        .usb_ctrl = DEVICE_SPECIFIC,
        .firmware = "dvb-usb-megasky-02.fw",
@@ -466,12 +461,15 @@ static struct dvb_usb_device_properties megasky_properties = {
        .identify_state   = megasky_identify_state,
        .num_adapters = 1,
        .adapter = {{
+               .caps = DVB_USB_ADAP_HAS_PID_FILTER |
+                       DVB_USB_ADAP_PID_FILTER_CAN_BE_TURNED_OFF,
+
                .pid_filter_count = 8,
                .pid_filter       = m9206_pid_filter,
                .pid_filter_ctrl  = m9206_pid_filter_ctrl,
 
-               .frontend_attach  = megasky_frontend_attach,
-               .tuner_attach     = megasky_tuner_attach,
+               .frontend_attach  = megasky_mt352_frontend_attach,
+               .tuner_attach     = megasky_qt1010_tuner_attach,
 
                .stream = {
                        .type = USB_BULK,