#include <linux/list.h>
#include <linux/jiffies.h>
#include <linux/kernel.h>
-#include <linux/bug.h>
#include <linux/hid.h>
#include <linux/i2c/i2c-hid.h>
__le16 wVendorID;
__le16 wProductID;
__le16 wVersionID;
+ __le32 reserved;
} __packed;
struct i2c_hid_cmd {
.wait = true };
static const struct i2c_hid_cmd hid_get_report_cmd = { I2C_HID_CMD(0x02) };
static const struct i2c_hid_cmd hid_set_report_cmd = { I2C_HID_CMD(0x03) };
-static const struct i2c_hid_cmd hid_get_idle_cmd = { I2C_HID_CMD(0x04) };
-static const struct i2c_hid_cmd hid_set_idle_cmd = { I2C_HID_CMD(0x05) };
-static const struct i2c_hid_cmd hid_get_protocol_cmd = { I2C_HID_CMD(0x06) };
-static const struct i2c_hid_cmd hid_set_protocol_cmd = { I2C_HID_CMD(0x07) };
static const struct i2c_hid_cmd hid_set_power_cmd = { I2C_HID_CMD(0x08) };
-/* read/write data register */
-static const struct i2c_hid_cmd hid_data_cmd = {
- .registerIndex = offsetof(struct i2c_hid_desc, wDataRegister),
- .opcode = 0x00,
- .length = 2 };
-/* write output reports */
-static const struct i2c_hid_cmd hid_out_cmd = {
- .registerIndex = offsetof(struct i2c_hid_desc,
- wOutputRegister),
- .opcode = 0x00,
- .length = 2 };
+
+/*
+ * These definitions are not used here, but are defined by the spec.
+ * Keeping them here for documentation purposes.
+ *
+ * static const struct i2c_hid_cmd hid_get_idle_cmd = { I2C_HID_CMD(0x04) };
+ * static const struct i2c_hid_cmd hid_set_idle_cmd = { I2C_HID_CMD(0x05) };
+ * static const struct i2c_hid_cmd hid_get_protocol_cmd = { I2C_HID_CMD(0x06) };
+ * static const struct i2c_hid_cmd hid_set_protocol_cmd = { I2C_HID_CMD(0x07) };
+ */
/* The main device structure */
struct i2c_hid {
unsigned long flags; /* device flags */
- int irq; /* the interrupt line irq */
-
wait_queue_head_t wait; /* For waiting the interrupt */
};
if (ret) {
dev_err(&client->dev,
"failed to retrieve report from device.\n");
- return -EINVAL;
+ return ret;
}
return 0;
reportType, args, args_len, NULL, 0);
if (ret) {
dev_err(&client->dev, "failed to set a report to device.\n");
- return -EINVAL;
+ return ret;
}
return data_len;
return 0;
}
-static int i2c_hid_get_input(struct i2c_hid *ihid)
+static void i2c_hid_get_input(struct i2c_hid *ihid)
{
int ret, ret_size;
int size = le16_to_cpu(ihid->hdesc.wMaxInputLength);
ret = i2c_master_recv(ihid->client, ihid->inbuf, size);
if (ret != size) {
if (ret < 0)
- return ret;
+ return;
dev_err(&ihid->client->dev, "%s: got %d data instead of %d\n",
__func__, ret, size);
- return ret;
+ return;
}
ret_size = ihid->inbuf[0] | ihid->inbuf[1] << 8;
/* host or device initiated RESET completed */
if (test_and_clear_bit(I2C_HID_RESET_PENDING, &ihid->flags))
wake_up(&ihid->wait);
- return 0;
+ return;
}
if (ret_size > size) {
dev_err(&ihid->client->dev, "%s: incomplete report (%d/%d)\n",
__func__, size, ret_size);
- return -EIO;
+ return;
}
i2c_hid_dbg(ihid, "input: %*ph\n", ret_size, ihid->inbuf);
hid_input_report(ihid->hid, HID_INPUT_REPORT, ihid->inbuf + 2,
ret_size - 2, 1);
- return 0;
+ return;
}
static irqreturn_t i2c_hid_irq(int irq, void *dev_id)
unsigned int size, ret_size;
size = i2c_hid_get_report_length(report);
- i2c_hid_get_report(client,
+ if (i2c_hid_get_report(client,
report->type == HID_FEATURE_REPORT ? 0x03 : 0x01,
- report->id, buffer, size);
+ report->id, buffer, size))
+ return;
i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, ihid->inbuf);
struct i2c_hid *ihid = i2c_get_clientdata(client);
u8 *inbuf = kzalloc(ihid->bufsize, GFP_KERNEL);
- if (!inbuf)
+ if (!inbuf) {
+ dev_err(&client->dev, "can not retrieve initial reports\n");
return;
+ }
list_for_each_entry(report,
&hid->report_enum[HID_INPUT_REPORT].report_list, list)
}
}
-static int i2c_hid_alloc_buffers(struct i2c_hid *ihid)
+static void i2c_hid_free_buffers(struct i2c_hid *ihid)
+{
+ kfree(ihid->inbuf);
+ kfree(ihid->argsbuf);
+ kfree(ihid->cmdbuf);
+ ihid->inbuf = NULL;
+ ihid->cmdbuf = NULL;
+ ihid->argsbuf = NULL;
+ ihid->bufsize = 0;
+}
+
+static int i2c_hid_alloc_buffers(struct i2c_hid *ihid, size_t report_size)
{
/* the worst case is computed from the set_report command with a
* reportID > 15 and the maximum report length */
int args_len = sizeof(__u8) + /* optional ReportID byte */
sizeof(__u16) + /* data register */
sizeof(__u16) + /* size of the report */
- ihid->bufsize; /* report */
-
- ihid->inbuf = kzalloc(ihid->bufsize, GFP_KERNEL);
-
- if (!ihid->inbuf)
- return -ENOMEM;
+ report_size; /* report */
+ ihid->inbuf = kzalloc(report_size, GFP_KERNEL);
ihid->argsbuf = kzalloc(args_len, GFP_KERNEL);
-
- if (!ihid->argsbuf) {
- kfree(ihid->inbuf);
- return -ENOMEM;
- }
-
ihid->cmdbuf = kzalloc(sizeof(union command) + args_len, GFP_KERNEL);
- if (!ihid->cmdbuf) {
- kfree(ihid->inbuf);
- kfree(ihid->argsbuf);
- ihid->inbuf = NULL;
- ihid->argsbuf = NULL;
+ if (!ihid->inbuf || !ihid->argsbuf || !ihid->cmdbuf) {
+ i2c_hid_free_buffers(ihid);
return -ENOMEM;
}
- return 0;
-}
+ ihid->bufsize = report_size;
-static void i2c_hid_free_buffers(struct i2c_hid *ihid)
-{
- kfree(ihid->inbuf);
- kfree(ihid->argsbuf);
- kfree(ihid->cmdbuf);
- ihid->inbuf = NULL;
- ihid->cmdbuf = NULL;
- ihid->argsbuf = NULL;
+ return 0;
}
static int i2c_hid_get_raw_report(struct hid_device *hid,
struct i2c_client *client = hid->driver_data;
struct i2c_hid *ihid = i2c_get_clientdata(client);
int ret;
- int old_bufsize = ihid->bufsize;
+ unsigned int bufsize = HID_MIN_BUFFER_SIZE;
- ihid->bufsize = HID_MIN_BUFFER_SIZE;
- i2c_hid_find_max_report(hid, HID_INPUT_REPORT, &ihid->bufsize);
- i2c_hid_find_max_report(hid, HID_OUTPUT_REPORT, &ihid->bufsize);
- i2c_hid_find_max_report(hid, HID_FEATURE_REPORT, &ihid->bufsize);
+ i2c_hid_find_max_report(hid, HID_INPUT_REPORT, &bufsize);
+ i2c_hid_find_max_report(hid, HID_OUTPUT_REPORT, &bufsize);
+ i2c_hid_find_max_report(hid, HID_FEATURE_REPORT, &bufsize);
- if (ihid->bufsize > old_bufsize || !ihid->inbuf || !ihid->cmdbuf) {
+ if (bufsize > ihid->bufsize) {
i2c_hid_free_buffers(ihid);
- ret = i2c_hid_alloc_buffers(ihid);
+ ret = i2c_hid_alloc_buffers(ihid, bufsize);
- if (ret) {
- ihid->bufsize = old_bufsize;
+ if (ret)
return ret;
- }
}
if (!(hid->quirks & HID_QUIRK_NO_INIT_REPORTS))
return -1;
}
- hid_set_field(field, offset, value);
-
- return 0;
+ return hid_set_field(field, offset, value);
}
static struct hid_ll_driver i2c_hid_ll_driver = {
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
client->name, ihid);
if (ret < 0) {
- dev_dbg(&client->dev,
+ dev_warn(&client->dev,
"Could not register for %s interrupt, irq = %d,"
" ret = %d\n",
- client->name, client->irq, ret);
+ client->name, client->irq, ret);
return ret;
}
- ihid->irq = client->irq;
-
return 0;
}
__func__, 4, ihid->hdesc_buffer);
if (ret) {
- dev_err(&client->dev, "HID_DESCR_LENGTH_CMD Fail (ret=%d)\n",
+ dev_err(&client->dev,
+ "unable to fetch the size of HID descriptor (ret=%d)\n",
ret);
return -ENODEV;
}
dsize = le16_to_cpu(hdesc->wHIDDescLength);
- if (!dsize || dsize > HID_MAX_DESCRIPTOR_SIZE) {
+ /*
+ * the size of the HID descriptor should at least contain
+ * its size and the bcdVersion (4 bytes), and should not be greater
+ * than sizeof(struct i2c_hid_desc) as we directly fill this struct
+ * through i2c_hid_command.
+ */
+ if (dsize < 4 || dsize > sizeof(struct i2c_hid_desc)) {
dev_err(&client->dev, "weird size of HID descriptor (%u)\n",
dsize);
return -ENODEV;
/* check bcdVersion == 1.0 */
if (le16_to_cpu(hdesc->bcdVersion) != 0x0100) {
dev_err(&client->dev,
- "unexpected HID descriptor bcdVersion (0x%04x)\n",
+ "unexpected HID descriptor bcdVersion (0x%04hx)\n",
le16_to_cpu(hdesc->bcdVersion));
return -ENODEV;
}
/* we need to allocate the command buffer without knowing the maximum
* size of the reports. Let's use HID_MIN_BUFFER_SIZE, then we do the
* real computation later. */
- ihid->bufsize = HID_MIN_BUFFER_SIZE;
- i2c_hid_alloc_buffers(ihid);
+ ret = i2c_hid_alloc_buffers(ihid, HID_MIN_BUFFER_SIZE);
+ if (ret < 0)
+ goto err;
ret = i2c_hid_fetch_hid_descriptor(ihid);
if (ret < 0)
hid = hid_allocate_device();
if (IS_ERR(hid)) {
ret = PTR_ERR(hid);
- goto err;
+ goto err_irq;
}
ihid->hid = hid;
hid->vendor = le16_to_cpu(ihid->hdesc.wVendorID);
hid->product = le16_to_cpu(ihid->hdesc.wProductID);
- snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X",
+ snprintf(hid->name, sizeof(hid->name), "%s %04hX:%04hX",
client->name, hid->vendor, hid->product);
ret = hid_add_device(hid);
err_mem_free:
hid_destroy_device(hid);
-err:
- if (ihid->irq)
- free_irq(ihid->irq, ihid);
+err_irq:
+ free_irq(client->irq, ihid);
+err:
i2c_hid_free_buffers(ihid);
kfree(ihid);
return ret;
struct i2c_hid *ihid = i2c_get_clientdata(client);
struct hid_device *hid;
- if (WARN_ON(!ihid))
- return -1;
-
hid = ihid->hid;
hid_destroy_device(hid);
free_irq(client->irq, ihid);
+ if (ihid->bufsize)
+ i2c_hid_free_buffers(ihid);
+
kfree(ihid);
return 0;
static int i2c_hid_suspend(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
- struct i2c_hid *ihid = i2c_get_clientdata(client);
if (device_may_wakeup(&client->dev))
- enable_irq_wake(ihid->irq);
+ enable_irq_wake(client->irq);
/* Save some power */
i2c_hid_set_power(client, I2C_HID_PWR_SLEEP);
projects / ~andy / linux / blobdiff