+Thu Mar 11 14:07:18 2004 Owen Taylor <otaylor@redhat.com>
+
+ * gtk/gtklabel.c (gtk_label_focus): Fix a missing return
+ value.
+
+Thu Mar 11 13:58:24 2004 Owen Taylor <otaylor@redhat.com>
+
+ * gtk/gtkmessagedialog.c gtk/gtklabel.c: Back out the
+ put-labels-into-the-standard-focus-chain patches
+ from bug #59707.
+
+ * gtk/gtklabel.c (gtk_label_focus): Only put the
+ label in the tab chain when the control key is pressed.
+
+2004-03-11 Federico Mena Quintero <federico@ximian.com>
+
+ * gtk/gtkfilechooserdefault.c (error_message_with_parent): Use a
+ single OK button, not a Close button, as per the HIG.
+
+ * gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Likewise.
+
+2004-03-11 Federico Mena Quintero <federico@ximian.com>
+
+ * gtk/gtkfilechooserdefault.c (shortcuts_drag_motion_cb): Oops,
+ initialize "action" before jumping. Fixes #136900.
+
+2004-03-11 Mark McLoughlin <mark@skynet.ie>
+
+ * gtk/gtksettings.c: (apply_queued_setting): don't overwrite
+ application properties. Fixes bug #136802.
+
+2004-03-11 Dov Grobgeld <dov@imagic.weizmann.ac.il>
+
+ * gtk/gtktextlayer.c: (gtk_text_layout_set_buffer): Added
+ call to gtk_text_layout_update_cursor_line() to solve in
+ problem of switching keyboard direction at widget creation:
+ bug #136680
+
+Thu Mar 11 10:28:30 2004 Owen Taylor <otaylor@redhat.com>
+
+ * gtk/gtkfilechooserembed.c (delegate_initial_focus): Remove
+ stray 'return' statement. (#136855, David L. Cooper II)
+
+2004-03-11 Mark McLoughlin <mark@skynet.ie>
+
+ * gtk/gtkstyle.c: (gtk_default_draw_expander): Use the PRELIGHT
+ fg color for drawing the expander when prelit. Fixes problem
+ with the HighContrast theme: bug #136789.
+
+2004-03-11 Federico Mena Quintero <federico@ximian.com>
+
+ Fix #135912 and #135913.
+
+ * gtk/gtkfilechooserdefault.c
+ (shortcuts_filter_model_row_draggable): Implement.
+ (shortcuts_model_filter_new): New function, create a
+ ShortcutsModelFilterClass derived from GtkTreeModelFilter, so that
+ we can implement our own DnD interface methods.
+ (shortcuts_model_create): Use shortcuts_model_filter_new().
+ (shortcuts_list_create): Enable the shortcuts list as a drag
+ source.
+ (file_list_source_targets): Renamed from shortcuts_targets.
+ (shortcuts_list_create): Change the options for
+ gtk_drag_dest_set(). Connect to more drag signals so that we can
+ implement drops by hand.
+ (shortcuts_drag_data_delete_cb): New handler; just stop the emission.
+ (shortcuts_drag_motion_cb): New handler; validate the drop.
+ (shortcuts_drag_leave_cb): New handler; unset the drag_dest_row.
+ (shortcuts_drag_drop_cb): New handler; just stop the emission and
+ remove the idle handler for the drag cursor.
+ (shortcuts_add_bookmark_from_path): Add a position argument,
+ return a boolean success code.
+ (shortcuts_drag_data_received_cb): Handle two cases: 1) Insert
+ the bookmarks at the proper position, rather than always appending
+ them to the list; 2) alternatively, reorder the bookmarks.
+ (struct _GtkFileChooserDefault): New field shortcuts_drag_outside.
+ (shortcuts_drag_motion_cb): Turn off impl->shortcuts_drag_outside.
+ (shortcuts_drag_leave_cb): Turn on impl->shortcuts_drag_outside in
+ an idle handler.
+ (shortcuts_drag_end_cb): New handler; remove the selected bookmark.
+
+Thu Mar 11 01:08:25 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkfilechooserdefault.c (location_entry_create): up the
+ width of the entry a tad.
+
+ * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_init): use
+ gtk_entry_completion_selection_changed. Also, unref the
+ completion as we were leaking a reference to it.
+
+2004-03-10 Federico Mena Quintero <federico@ximian.com>
+
+ * gtk/gtkstyle.c (draw_dot): Remove spurious semicolon. Thanks to
+ Kjartan Maraas for pointing it out.
+
+Wed Mar 10 23:40:15 2004 Matthias Clasen <maclas@gmx.de>
+
+ * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Set the background
+ on the action view cell renderer here, not in init, so that a) we catch
+ style changes, and b) we get the real style, not the default one.
+ Partial fix for #127648, reported by Dave Bordoley.
+
+2004-03-10 Tor Lillqvist <tml@iki.fi>
+
+ * gdk/win32/gdkevents-win32.c (build_key_event_state): Set also
+ the pointer button bits. (#136636, Dave Neary)
+
+ * gdk/win32/gdkwindow-win32.c (show_window_internal): Show
+ transparent (input only) windows using SetWindowPos(). (#132331,
+ John Ehresman)
+
+ (gdk_window_set_type_hint): For splash screens, remove the resize
+ handles, menu, and minimize/maximize/close buttons. (#132896)
+
+Wed Mar 10 22:30:23 2004 Matthias Clasen <maclas@gmx.de>
+
+ * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Keep the
+ cell_list in a consistent state while iterating over it, since
+ clear_attributes() also iterates over it. (#136585, Morten Welinder)
+
+2004-03-10 Mark McLoughlin <mark@skynet.ie>
+
+ * gtk/gtkexpander.c: (gtk_expander_expose): don't propagate
+ the expose to the label. The expose handler for GtkContainer
+ already does that. Fixes bug #136719. Reported by Dennis
+ Cranston, exact cause nailed down by Owen.
+
+2004-03-10 Federico Mena Quintero <federico@ximian.com>
+
+ * gtk/gtkfilechooserdefault.c (list_mtime_data_func): Use an
+ untranslatable "%x" for dates, rather than a custom format. Fixes
+ #136357.
+
+2004-03-10 Morten Welinder <terra@gnome.org>
+
+ * gtk/gtkfilechooserdefault.c
+ (gtk_file_chooser_default_add_shortcut_folder): Test validity of
+ path here.
+ (shortcuts_insert_path): Don't check here.
+ (get_file_info): Barf if name-only fails.
+
+ * tests/testfilechooser.c (main): Add support for --multiple.
+
+Wed Mar 10 02:41:05 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkpathbar.c: (gtk_path_bar_init), (gtk_path_bar_class_init),
+ (remove_settings_signal), (gtk_path_bar_dispose),
+ (gtk_path_bar_style_set), (gtk_path_bar_screen_changed),
+ (gtk_path_bar_scroll_up), (reload_icons), (change_icon_theme),
+ (settings_notify_cb), (gtk_path_bar_check_icon_theme),
+ (get_button_image), (gtk_path_bar_update_button_appearance),
+ (make_directory_button), (gtk_path_bar_check_parent_path): Support
+ changes in icon themes.
+
+ * gtk/gtkpathbar.h: add two elements
+
+ * tests/testfilechooser.c: (main): use gnome-vfs method again to
+ get more testing.
+
+Wed Mar 10 01:17:40 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkpathbar.c: added 'Desktop' to the list of volumes. We
+ don't have any more untranlated strings in the dialog.
+
+Wed Mar 10 00:24:24 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkfilechooserdefault.c (error_dialog): use uri instead of
+ the pathname for UTF-8 safety.
+
+Wed Mar 10 00:10:47 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Always
+ check to see if the shortcuts exists. We don't want to put
+ invalid dirs in the shortcuts pane.
+
+Tue Mar 9 16:40:34 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
+ remove unneeded shortuts_swin;
+
+Wed Mar 10 01:49:27 2004 Matthias Clasen <maclas@gmx.de>
+
+ Fix #136614 in a better way:
+
+ * gtk/gtkoptionmenu.c (gtk_option_menu_init): Undo the last change.
+ * gtk/gtkbutton.c (struct _GtkButtonPrivate): Add a flag, align_set.
+ * gtk/gtkbutton.c (gtk_button_init): Initialize align_set to 0.
+ * gtk/gtkbutton.c (maybe_set_alignment): Rework to only set the
+ alignment if priv->align_set is set.
+ * gtk/gtkbutton.c (gtk_button_set_alignment): Set align_set to 1.
+
+Wed Mar 10 01:21:05 2004 Matthias Clasen <maclas@gmx.de>
+
+ * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Place
+ grid mode popups left aligned, not right aligned.
+
+Tue Mar 9 23:09:46 2004 Matthias Clasen <maclas@gmx.de>
+
+ * gtk/gtkoptionmenu.c (gtk_option_menu_init): Avoid centering
+ the label that is reparented from the menuitem. (#136614, Dennis
+ Cranston)
+
+Tue Mar 9 16:19:09 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkpathbar.c (struct _ButtonData): Encapsulate all of the
+ information about a button in a struct instead of ugly
+ g_object_set_data.
+ (gtk_path_bar_size_request): Use ButtonData.
+ (gtk_path_bar_update_slider_buttons): ditto
+ (gtk_path_bar_size_allocate): ditto
+ (gtk_path_bar_remove): ditto
+ (gtk_path_bar_forall): ditto
+ (gtk_path_bar_scroll_down): ditto
+ (gtk_path_bar_clear_buttons): ditto
+ (button_clicked_cb): ditto. Also, add an ignore_changes variable
+ (button_data_free): destroy ButtonData
+ (update_button_appearance): Use ButtonData
+ (make_directory_button): ditto
+ (gtk_path_bar_check_parent_path): ditto
+ (_gtk_path_bar_set_path): ditto
+
+2004-03-09 Federico Mena Quintero <federico@ximian.com>
+
+ Fix #136533.
+
+ * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): New
+ function.
+ (check_icon_theme): New helper function, installs a handler for
+ changes in the icon theme.
+ (gtk_file_chooser_default_style_set): Use check_icon_theme().
+ (gtk_file_chooser_default_screen_changed): Use check_icon_theme().
+ (gtk_file_chooser_default_dispose): Disconnect from GtkSettings.
+ (change_icon_theme): New function, updates impl->icon_size and
+ reloads the icons.
+ (struct _GtkFileChooserDefault): New field settings_signal_id.
+ (struct _GtkFileChooserDefault): New field icon_size.
+ (shortcuts_insert_path): Use impl->icon_size.
+ (list_icon_data_func): Likewise.
+
+2004-03-09 Federico Mena Quintero <federico@ximian.com>
+
+ * gtk/gtkfilechooserdefault.c (get_file_info): Handle the returned
+ parent_path being NULL. Fixes #136662.
+
+2004-03-09 Federico Mena Quintero <federico@ximian.com>
+
+ * gtk/gtkfilechooserdefault.c (shortcuts_drag_data_received_cb):
+ Stop the emission so that GtkTreeView's handler won't try to poke
+ the filter model. Fixes #136127.
+
+Tue Mar 9 13:49:14 2004 Owen Taylor <otaylor@redhat.com>
+
+ * gtk/gtkstyle.c (gtk_paint_polygon): Fix
+ g_return_if_fail() that was checking draw_shadow.
+ (#136669, Morten Welinder)
+
+Tue Mar 9 09:57:25 2004 Owen Taylor <otaylor@redhat.com>
+
+ * === Released 2.3.6 ===
+
+ * configure.in: Version 2.3.6, interface age 0.
+
+ * NEWS: Updates
+
+Tue Mar 9 11:01:45 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkpathbar.c (gtk_path_bar_finalize): unref the correct
+ icon. Reported by Michael Natterer <mitch@gimp.org>.
+
+2004-03-09 Morten Welinder <terra@gnome.org>
+
+ * tests/testfilechooser.c (main): Destroy widgets to reveal leaks.
+
+Tue Mar 9 02:11:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
+
+ * gtk/gtkmenu.c Fix bug 136446. [Marco Pesenti Gritti]
+ (struct _GtkMenuPrivate): Add boolean destroying
+ (gtk_menu_destroy): Set priv->destroying
+ (gtk_menu_remove): don't update the table information when the
+ menu is being destroyed.
+
+ * gtk/gtkmenu.c (gtk_menu_set_monitor): Formatting fix
+
+ * gtk/gtktoolbar.[ch]: Some formatting fixes
+
+Tue Mar 9 01:25:10 2004 Matthias Clasen <maclas@gmx.de>
+
+ * gtk/gtkframe.c (gtk_frame_paint): Fix a typo.
+
+2004-03-08 Federico Mena Quintero <federico@ximian.com>
+
+ Fixes #136080.
+
+ * gtk/gtkfilesystemunix.c: Only lstat() if stat() failed due to
+ ENOENT.
+ (filename_get_info): Likewise.
+
+2004-03-08 Federico Mena Quintero <federico@ximian.com>
+
+ * gtk/gtkfilechooserdefault.c
+ (gtk_file_chooser_default_initial_focus): Use
+ gtk_tree_view_set_cursor().
+
+2004-03-08 Federico Mena Quintero <federico@ximian.com>
+
+ Patch "1a" from #136185, by Morten Welinder.
+
+ * gtk/gtkfilechooserdefault.c (get_file_info): Take in an argument
+ that says whether the caller just wants the display name.
+ (shortcuts_insert_path): We only want the name in the call to
+ get_file_info().
+
+ * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Don't request more
+ info than needed from the file_folder.
+
+2004-03-08 Federico Mena Quintero <federico@ximian.com>
+
+ Fixes #136105.
+
+ * gtk/gtkfilechooserembed.h (struct _GtkFileChooserEmbedIface):
+ Added an ::initial_focus() method.
+
+ * gtk/gtkfilechooserembed.c
+ (_gtk_file_chooser_embed_delegate_iface_init): Set the
+ initial_focus method.
+ (delegate_initial_focus): Implement.
+ (_gtk_file_chooser_embed_initial_focus): New function.
+
+ * gtk/gtkfilechooserdialog.c
+ (gtk_file_chooser_dialog_constructor): Call
+ _gtk_file_chooser_embed_initial_focus().
+
+ * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
+ Install the ::initial_focus() handler.
+ (gtk_file_chooser_default_initial_focus): Implement.
+
+2004-03-08 Federico Mena Quintero <federico@ximian.com>
+
+ * gtk/gtkfilechooserdefault.c (update_from_entry): Return a
+ boolean success code.
+ (location_popup_handler): Refocus the file chooser if appropriate.
+ Fixes #135905.
+ (save_widgets_create): Don't set the text of the save_folder_label
+ here.
+ (update_appearance): Set the text here as appropriate for the save
+ mode. Also fixes #136387.
+ (update_appearance): Don't show the Create Folder button in
+ SELECT_FOLDER mode.
+ (update_appearance): Show the extra widget in all Save modes
+ correctly.
+
+Mon Mar 8 11:57:27 2004 Owen Taylor <otaylor@redhat.com>
+
+ * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't
+ call g_signal_handler_disonnect() if priv->model is
+ NULL. (#136551, Damon Chaplin)
+
+ * gtk/gtkcombobox.c (gtk_combo_box_model_row_inserted):
+ Back out code to set the active item when the first
+ item is added to the model; this causes problems for
+ GtkComboBoxText. (#136535)
+
+ * gtk/gtkcombobox.c (gtk_combo_box_menu_destroy)
+ * gtk/gtkcombobox.c (gtk_combo_box_list_destroy):
+ * gtk/gtkcombobox.c (gtk_combo_box_list_setup):
+ * gtk/gtkcombobox.c (gtk_combo_box_menu_setup):
+ Remove calls to gtk_combo_box_unset_model.
+
+ * gtk/gtkcombobox.c (gtk_combo_box_check_appearance):
+ Clean up handling of wrap->width > 0.
+
+ * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't
+ switch list/menu mode here.
+
+ * gtk/gtkcombobox.c (gtk_combo_box_set_model): Protect
+ against the same model being set back.
+
+ * gtk/gtkcombobox.c (gtk_combo_box_relayout): Call
+ gtk_combo_box_menu_fill() rather than duplicating
+ a large chunk of code.
+
+2004-03-08 Anders Carlsson <andersca@gnome.org>
+
+ * gtk/gtkfilesystemmodel.c (gtk_file_system_model_get_flags):
+ If max_depth is 0 then we have a list.
+
+2004-03-08 Morten Welinder <terra@gnome.org>
+
+ * gtk/gtkpathbar.c (_gtk_path_bar_set_path): If we fail, leave
+ widget unchanged. Explicitly verify final directory.
+
+ * gtk/gtkfilesystemunix.c (gtk_file_system_unix_create_folder,
+ get_icon_type, filename_get_info): Protect errno.
+
+2004-03-08 Marco Pesenti Gritti <marco@gnome.org>
+
+ * gtk/gtkentry.c: (gtk_entry_completion_key_press):
+
+ When an action is selected stop the event to be propagated
+ otherwise the activate signal is emitted too. (Bug #133394)
+
+Mon Mar 8 04:50:12 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkfilechooserdefault.c (create_path_bar): new function to
+ consolidate creating the path_bar.
+ (gtk_file_chooser_default_set_current_folder): no longer need to
+ pass in the filesystem.
+
+ * gtk/gtkpathbar.h: Removed unused set_pixbuf functions in favor
+ of just setting the filesystem.
+
+ * gtk/gtkpathbar.c (gtk_path_bar_finalize): Free root path and
+ home_dir.
+ (get_button_image): Add images to path_bar.
+ (update_button_appearance): use images
+ (make_directory_button): Clasify buttons based upon location.
+ (_gtk_path_bar_set_path): no longer need a file-system. Also, add
+ rerooting, #135845, #135914
+
+ * tests/testfilechooser.c: Fix reused error handling.
+
+2004-03-08 Anders Carlsson <andersca@gnome.org>
+
+ * gtk/gtkfilesystemunix.c: (get_icon_for_directory),
+ (gtk_file_system_unix_render_icon):
+ Use better icons for home and desktop.
+
+2004-03-08 Anders Carlsson <andersca@gnome.org>
+
+ * gtk/gtkfilechooserentry.c:
+ (_gtk_file_chooser_entry_set_base_folder):
+ Set the base folder path in the entry.
+
+2004-03-08 Christian Neumair <chris@gnome-de.org>
+
+ * tests/testentrycompletion.c: Fix typo.
+
+2004-03-08 Tor Lillqvist <tml@iki.fi>
+
+ * README.win32: Update.
+
+ * gtk/gtk.def: Small update. Thanks to J. Ali Harlow. Re-sorted.
+
+ * tests/testfilechooser.c: Correct localtime_r() emulation on
+ Win32. Remove a couple of unnecessary Win32-only includes.
+
+Mon Mar 8 01:06:17 2004 Matthias Clasen <maclas@gmx.de>
+
+ * tests/testentrycompletion.c: Test dynamic addition/removal.
+
+Sun Mar 7 22:38:49 2004 Matthias Clasen <maclas@gmx.de>
+
+ * gtk/gtkframe.c (gtk_frame_paint): Use ythickness, not
+ xthickness in the calculation of vertical dimensions.
+
+Sun Mar 7 17:38:03 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkbutton.c (gtk_button_class_init): actually use
+ gtk_button_add.
+
+ * gtk/gtkfilechooserdefault.c (error_building_filename_dialog):
+ use the uri, not the path, #136317
+ (renderer_edited_cb): ditto
+ (shortcuts_add_bookmark_from_path): ditto
+ (remove_bookmark_button_clicked_cb): ditto
+ (gtk_file_chooser_default_remove_shortcut): ditto
+ (update_from_entry): ditto
+ (up_folder_handler): ditto
+
+Sun Mar 7 16:07:08 2004 Jonathan Blandford <jrb@gnome.org>
+
+ * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): set
+ redraw_on_allocate, #135902.
+
+ * gtk/gtkfilesystemmodel.c (model_refilter_recurse): Patch from
+ Damon Chaplin to set a node to be visible before emitting the
+ inserted signal, #135555.
+
Sun Mar 7 22:24:28 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtkbutton.c (_gtk_button_paint): Don't use xthickness in the
Sun Mar 7 14:34:04 2004 Jonathan Blandford <jrb@gnome.org>
+ Fixes #121500.
+
* gtk/gtkfilechooserdefault.c (trap_activate_cb): stop activate
from unselecting rows when pressed in multiple-selection mode.
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_select_path): Likewise.
- (gtk_file_chooser_default_set_current_folder): Likewise.
+ (gtk_file_chooser_default_set_current_folder): Likewise; this also
+ fixes #136024.
(error_changing_folder_dialog): New helper function.
(change_folder_and_display_error): New helper function.
(switch_to_selected_folder): Use change_folder_and_display_error().