]> Pileus Git - ~andy/linux/blob - drivers/mfd/arizona-core.c
mfd: arizona: Factor out register polling
[~andy/linux] / drivers / mfd / arizona-core.c
1 /*
2  * Arizona core driver
3  *
4  * Copyright 2012 Wolfson Microelectronics plc
5  *
6  * Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
7  *
8  * This program is free software; you can redistribute it and/or modify
9  * it under the terms of the GNU General Public License version 2 as
10  * published by the Free Software Foundation.
11  */
12
13 #include <linux/delay.h>
14 #include <linux/err.h>
15 #include <linux/gpio.h>
16 #include <linux/interrupt.h>
17 #include <linux/mfd/core.h>
18 #include <linux/module.h>
19 #include <linux/pm_runtime.h>
20 #include <linux/regmap.h>
21 #include <linux/regulator/consumer.h>
22 #include <linux/slab.h>
23
24 #include <linux/mfd/arizona/core.h>
25 #include <linux/mfd/arizona/registers.h>
26
27 #include "arizona.h"
28
29 static const char *wm5102_core_supplies[] = {
30         "AVDD",
31         "DBVDD1",
32 };
33
34 int arizona_clk32k_enable(struct arizona *arizona)
35 {
36         int ret = 0;
37
38         mutex_lock(&arizona->clk_lock);
39
40         arizona->clk32k_ref++;
41
42         if (arizona->clk32k_ref == 1) {
43                 switch (arizona->pdata.clk32k_src) {
44                 case ARIZONA_32KZ_MCLK1:
45                         ret = pm_runtime_get_sync(arizona->dev);
46                         if (ret != 0)
47                                 goto out;
48                         break;
49                 }
50
51                 ret = regmap_update_bits(arizona->regmap, ARIZONA_CLOCK_32K_1,
52                                          ARIZONA_CLK_32K_ENA,
53                                          ARIZONA_CLK_32K_ENA);
54         }
55
56 out:
57         if (ret != 0)
58                 arizona->clk32k_ref--;
59
60         mutex_unlock(&arizona->clk_lock);
61
62         return ret;
63 }
64 EXPORT_SYMBOL_GPL(arizona_clk32k_enable);
65
66 int arizona_clk32k_disable(struct arizona *arizona)
67 {
68         int ret = 0;
69
70         mutex_lock(&arizona->clk_lock);
71
72         BUG_ON(arizona->clk32k_ref <= 0);
73
74         arizona->clk32k_ref--;
75
76         if (arizona->clk32k_ref == 0) {
77                 regmap_update_bits(arizona->regmap, ARIZONA_CLOCK_32K_1,
78                                    ARIZONA_CLK_32K_ENA, 0);
79
80                 switch (arizona->pdata.clk32k_src) {
81                 case ARIZONA_32KZ_MCLK1:
82                         pm_runtime_put_sync(arizona->dev);
83                         break;
84                 }
85         }
86
87         mutex_unlock(&arizona->clk_lock);
88
89         return ret;
90 }
91 EXPORT_SYMBOL_GPL(arizona_clk32k_disable);
92
93 static irqreturn_t arizona_clkgen_err(int irq, void *data)
94 {
95         struct arizona *arizona = data;
96
97         dev_err(arizona->dev, "CLKGEN error\n");
98
99         return IRQ_HANDLED;
100 }
101
102 static irqreturn_t arizona_underclocked(int irq, void *data)
103 {
104         struct arizona *arizona = data;
105         unsigned int val;
106         int ret;
107
108         ret = regmap_read(arizona->regmap, ARIZONA_INTERRUPT_RAW_STATUS_8,
109                           &val);
110         if (ret != 0) {
111                 dev_err(arizona->dev, "Failed to read underclock status: %d\n",
112                         ret);
113                 return IRQ_NONE;
114         }
115
116         if (val & ARIZONA_AIF3_UNDERCLOCKED_STS)
117                 dev_err(arizona->dev, "AIF3 underclocked\n");
118         if (val & ARIZONA_AIF2_UNDERCLOCKED_STS)
119                 dev_err(arizona->dev, "AIF2 underclocked\n");
120         if (val & ARIZONA_AIF1_UNDERCLOCKED_STS)
121                 dev_err(arizona->dev, "AIF1 underclocked\n");
122         if (val & ARIZONA_ISRC2_UNDERCLOCKED_STS)
123                 dev_err(arizona->dev, "ISRC2 underclocked\n");
124         if (val & ARIZONA_ISRC1_UNDERCLOCKED_STS)
125                 dev_err(arizona->dev, "ISRC1 underclocked\n");
126         if (val & ARIZONA_FX_UNDERCLOCKED_STS)
127                 dev_err(arizona->dev, "FX underclocked\n");
128         if (val & ARIZONA_ASRC_UNDERCLOCKED_STS)
129                 dev_err(arizona->dev, "ASRC underclocked\n");
130         if (val & ARIZONA_DAC_UNDERCLOCKED_STS)
131                 dev_err(arizona->dev, "DAC underclocked\n");
132         if (val & ARIZONA_ADC_UNDERCLOCKED_STS)
133                 dev_err(arizona->dev, "ADC underclocked\n");
134         if (val & ARIZONA_MIXER_UNDERCLOCKED_STS)
135                 dev_err(arizona->dev, "Mixer dropped sample\n");
136
137         return IRQ_HANDLED;
138 }
139
140 static irqreturn_t arizona_overclocked(int irq, void *data)
141 {
142         struct arizona *arizona = data;
143         unsigned int val[2];
144         int ret;
145         
146         ret = regmap_bulk_read(arizona->regmap, ARIZONA_INTERRUPT_RAW_STATUS_6,
147                                &val[0], 2);
148         if (ret != 0) {
149                 dev_err(arizona->dev, "Failed to read overclock status: %d\n",
150                         ret);
151                 return IRQ_NONE;
152         }
153
154         if (val[0] & ARIZONA_PWM_OVERCLOCKED_STS)
155                 dev_err(arizona->dev, "PWM overclocked\n");
156         if (val[0] & ARIZONA_FX_CORE_OVERCLOCKED_STS)
157                 dev_err(arizona->dev, "FX core overclocked\n");
158         if (val[0] & ARIZONA_DAC_SYS_OVERCLOCKED_STS)
159                 dev_err(arizona->dev, "DAC SYS overclocked\n");
160         if (val[0] & ARIZONA_DAC_WARP_OVERCLOCKED_STS)
161                 dev_err(arizona->dev, "DAC WARP overclocked\n");
162         if (val[0] & ARIZONA_ADC_OVERCLOCKED_STS)
163                 dev_err(arizona->dev, "ADC overclocked\n");
164         if (val[0] & ARIZONA_MIXER_OVERCLOCKED_STS)
165                 dev_err(arizona->dev, "Mixer overclocked\n");
166         if (val[0] & ARIZONA_AIF3_SYNC_OVERCLOCKED_STS)
167                 dev_err(arizona->dev, "AIF3 overclocked\n");
168         if (val[0] & ARIZONA_AIF2_SYNC_OVERCLOCKED_STS)
169                 dev_err(arizona->dev, "AIF2 overclocked\n");
170         if (val[0] & ARIZONA_AIF1_SYNC_OVERCLOCKED_STS)
171                 dev_err(arizona->dev, "AIF1 overclocked\n");
172         if (val[0] & ARIZONA_PAD_CTRL_OVERCLOCKED_STS)
173                 dev_err(arizona->dev, "Pad control overclocked\n");
174
175         if (val[1] & ARIZONA_SLIMBUS_SUBSYS_OVERCLOCKED_STS)
176                 dev_err(arizona->dev, "Slimbus subsystem overclocked\n");
177         if (val[1] & ARIZONA_SLIMBUS_ASYNC_OVERCLOCKED_STS)
178                 dev_err(arizona->dev, "Slimbus async overclocked\n");
179         if (val[1] & ARIZONA_SLIMBUS_SYNC_OVERCLOCKED_STS)
180                 dev_err(arizona->dev, "Slimbus sync overclocked\n");
181         if (val[1] & ARIZONA_ASRC_ASYNC_SYS_OVERCLOCKED_STS)
182                 dev_err(arizona->dev, "ASRC async system overclocked\n");
183         if (val[1] & ARIZONA_ASRC_ASYNC_WARP_OVERCLOCKED_STS)
184                 dev_err(arizona->dev, "ASRC async WARP overclocked\n");
185         if (val[1] & ARIZONA_ASRC_SYNC_SYS_OVERCLOCKED_STS)
186                 dev_err(arizona->dev, "ASRC sync system overclocked\n");
187         if (val[1] & ARIZONA_ASRC_SYNC_WARP_OVERCLOCKED_STS)
188                 dev_err(arizona->dev, "ASRC sync WARP overclocked\n");
189         if (val[1] & ARIZONA_ADSP2_1_OVERCLOCKED_STS)
190                 dev_err(arizona->dev, "DSP1 overclocked\n");
191         if (val[1] & ARIZONA_ISRC2_OVERCLOCKED_STS)
192                 dev_err(arizona->dev, "ISRC2 overclocked\n");
193         if (val[1] & ARIZONA_ISRC1_OVERCLOCKED_STS)
194                 dev_err(arizona->dev, "ISRC1 overclocked\n");
195
196         return IRQ_HANDLED;
197 }
198
199 static int arizona_poll_reg(struct arizona *arizona,
200                             int timeout, unsigned int reg,
201                             unsigned int mask, unsigned int target)
202 {
203         unsigned int val = 0;
204         int ret, i;
205
206         for (i = 0; i < timeout; i++) {
207                 ret = regmap_read(arizona->regmap, reg, &val);
208                 if (ret != 0) {
209                         dev_err(arizona->dev, "Failed to read reg %u: %d\n",
210                                 reg, ret);
211                         continue;
212                 }
213
214                 if ((val & mask) == target)
215                         return 0;
216
217                 msleep(1);
218         }
219
220         dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val);
221         return -ETIMEDOUT;
222 }
223
224 static int arizona_wait_for_boot(struct arizona *arizona)
225 {
226         int ret;
227
228         /*
229          * We can't use an interrupt as we need to runtime resume to do so,
230          * we won't race with the interrupt handler as it'll be blocked on
231          * runtime resume.
232          */
233         ret = arizona_poll_reg(arizona, 5, ARIZONA_INTERRUPT_RAW_STATUS_5,
234                                ARIZONA_BOOT_DONE_STS, ARIZONA_BOOT_DONE_STS);
235
236         if (!ret)
237                 regmap_write(arizona->regmap, ARIZONA_INTERRUPT_STATUS_5,
238                              ARIZONA_BOOT_DONE_STS);
239
240         pm_runtime_mark_last_busy(arizona->dev);
241
242         return ret;
243 }
244
245 #ifdef CONFIG_PM_RUNTIME
246 static int arizona_runtime_resume(struct device *dev)
247 {
248         struct arizona *arizona = dev_get_drvdata(dev);
249         int ret;
250
251         dev_dbg(arizona->dev, "Leaving AoD mode\n");
252
253         ret = regulator_enable(arizona->dcvdd);
254         if (ret != 0) {
255                 dev_err(arizona->dev, "Failed to enable DCVDD: %d\n", ret);
256                 return ret;
257         }
258
259         regcache_cache_only(arizona->regmap, false);
260
261         ret = arizona_wait_for_boot(arizona);
262         if (ret != 0) {
263                 goto err;
264         }
265
266         switch (arizona->type) {
267         case WM5102:
268                 ret = wm5102_patch(arizona);
269                 if (ret != 0) {
270                         dev_err(arizona->dev, "Failed to apply patch: %d\n",
271                                 ret);
272                         goto err;
273                 }
274         }
275
276         ret = regcache_sync(arizona->regmap);
277         if (ret != 0) {
278                 dev_err(arizona->dev, "Failed to restore register cache\n");
279                 goto err;
280         }
281
282         return 0;
283
284 err:
285         regcache_cache_only(arizona->regmap, true);
286         regulator_disable(arizona->dcvdd);
287         return ret;
288 }
289
290 static int arizona_runtime_suspend(struct device *dev)
291 {
292         struct arizona *arizona = dev_get_drvdata(dev);
293
294         dev_dbg(arizona->dev, "Entering AoD mode\n");
295
296         regulator_disable(arizona->dcvdd);
297         regcache_cache_only(arizona->regmap, true);
298         regcache_mark_dirty(arizona->regmap);
299
300         return 0;
301 }
302 #endif
303
304 #ifdef CONFIG_PM_SLEEP
305 static int arizona_resume_noirq(struct device *dev)
306 {
307         struct arizona *arizona = dev_get_drvdata(dev);
308
309         dev_dbg(arizona->dev, "Early resume, disabling IRQ\n");
310         disable_irq(arizona->irq);
311
312         return 0;
313 }
314
315 static int arizona_resume(struct device *dev)
316 {
317         struct arizona *arizona = dev_get_drvdata(dev);
318
319         dev_dbg(arizona->dev, "Late resume, reenabling IRQ\n");
320         enable_irq(arizona->irq);
321
322         return 0;
323 }
324 #endif
325
326 const struct dev_pm_ops arizona_pm_ops = {
327         SET_RUNTIME_PM_OPS(arizona_runtime_suspend,
328                            arizona_runtime_resume,
329                            NULL)
330         SET_SYSTEM_SLEEP_PM_OPS(NULL, arizona_resume)
331 #ifdef CONFIG_PM_SLEEP
332         .resume_noirq = arizona_resume_noirq,
333 #endif
334 };
335 EXPORT_SYMBOL_GPL(arizona_pm_ops);
336
337 static struct mfd_cell early_devs[] = {
338         { .name = "arizona-ldo1" },
339 };
340
341 static struct mfd_cell wm5102_devs[] = {
342         { .name = "arizona-micsupp" },
343         { .name = "arizona-extcon" },
344         { .name = "arizona-gpio" },
345         { .name = "arizona-haptics" },
346         { .name = "arizona-pwm" },
347         { .name = "wm5102-codec" },
348 };
349
350 static struct mfd_cell wm5110_devs[] = {
351         { .name = "arizona-micsupp" },
352         { .name = "arizona-extcon" },
353         { .name = "arizona-gpio" },
354         { .name = "arizona-haptics" },
355         { .name = "arizona-pwm" },
356         { .name = "wm5110-codec" },
357 };
358
359 int arizona_dev_init(struct arizona *arizona)
360 {
361         struct device *dev = arizona->dev;
362         const char *type_name;
363         unsigned int reg, val;
364         int (*apply_patch)(struct arizona *) = NULL;
365         int ret, i;
366
367         dev_set_drvdata(arizona->dev, arizona);
368         mutex_init(&arizona->clk_lock);
369
370         if (dev_get_platdata(arizona->dev))
371                 memcpy(&arizona->pdata, dev_get_platdata(arizona->dev),
372                        sizeof(arizona->pdata));
373
374         regcache_cache_only(arizona->regmap, true);
375
376         switch (arizona->type) {
377         case WM5102:
378         case WM5110:
379                 for (i = 0; i < ARRAY_SIZE(wm5102_core_supplies); i++)
380                         arizona->core_supplies[i].supply
381                                 = wm5102_core_supplies[i];
382                 arizona->num_core_supplies = ARRAY_SIZE(wm5102_core_supplies);
383                 break;
384         default:
385                 dev_err(arizona->dev, "Unknown device type %d\n",
386                         arizona->type);
387                 return -EINVAL;
388         }
389
390         ret = mfd_add_devices(arizona->dev, -1, early_devs,
391                               ARRAY_SIZE(early_devs), NULL, 0, NULL);
392         if (ret != 0) {
393                 dev_err(dev, "Failed to add early children: %d\n", ret);
394                 return ret;
395         }
396
397         ret = devm_regulator_bulk_get(dev, arizona->num_core_supplies,
398                                       arizona->core_supplies);
399         if (ret != 0) {
400                 dev_err(dev, "Failed to request core supplies: %d\n",
401                         ret);
402                 goto err_early;
403         }
404
405         arizona->dcvdd = devm_regulator_get(arizona->dev, "DCVDD");
406         if (IS_ERR(arizona->dcvdd)) {
407                 ret = PTR_ERR(arizona->dcvdd);
408                 dev_err(dev, "Failed to request DCVDD: %d\n", ret);
409                 goto err_early;
410         }
411
412         ret = regulator_bulk_enable(arizona->num_core_supplies,
413                                     arizona->core_supplies);
414         if (ret != 0) {
415                 dev_err(dev, "Failed to enable core supplies: %d\n",
416                         ret);
417                 goto err_early;
418         }
419
420         ret = regulator_enable(arizona->dcvdd);
421         if (ret != 0) {
422                 dev_err(dev, "Failed to enable DCVDD: %d\n", ret);
423                 goto err_enable;
424         }
425
426         if (arizona->pdata.reset) {
427                 /* Start out with /RESET low to put the chip into reset */
428                 ret = gpio_request_one(arizona->pdata.reset,
429                                        GPIOF_DIR_OUT | GPIOF_INIT_LOW,
430                                        "arizona /RESET");
431                 if (ret != 0) {
432                         dev_err(dev, "Failed to request /RESET: %d\n", ret);
433                         goto err_dcvdd;
434                 }
435
436                 gpio_set_value_cansleep(arizona->pdata.reset, 1);
437         }
438
439         regcache_cache_only(arizona->regmap, false);
440
441         ret = regmap_read(arizona->regmap, ARIZONA_SOFTWARE_RESET, &reg);
442         if (ret != 0) {
443                 dev_err(dev, "Failed to read ID register: %d\n", ret);
444                 goto err_reset;
445         }
446
447         ret = regmap_read(arizona->regmap, ARIZONA_DEVICE_REVISION,
448                           &arizona->rev);
449         if (ret != 0) {
450                 dev_err(dev, "Failed to read revision register: %d\n", ret);
451                 goto err_reset;
452         }
453         arizona->rev &= ARIZONA_DEVICE_REVISION_MASK;
454
455         switch (reg) {
456 #ifdef CONFIG_MFD_WM5102
457         case 0x5102:
458                 type_name = "WM5102";
459                 if (arizona->type != WM5102) {
460                         dev_err(arizona->dev, "WM5102 registered as %d\n",
461                                 arizona->type);
462                         arizona->type = WM5102;
463                 }
464                 apply_patch = wm5102_patch;
465                 arizona->rev &= 0x7;
466                 break;
467 #endif
468 #ifdef CONFIG_MFD_WM5110
469         case 0x5110:
470                 type_name = "WM5110";
471                 if (arizona->type != WM5110) {
472                         dev_err(arizona->dev, "WM5110 registered as %d\n",
473                                 arizona->type);
474                         arizona->type = WM5110;
475                 }
476                 apply_patch = wm5110_patch;
477                 break;
478 #endif
479         default:
480                 dev_err(arizona->dev, "Unknown device ID %x\n", reg);
481                 goto err_reset;
482         }
483
484         dev_info(dev, "%s revision %c\n", type_name, arizona->rev + 'A');
485
486         /* If we have a /RESET GPIO we'll already be reset */
487         if (!arizona->pdata.reset) {
488                 regcache_mark_dirty(arizona->regmap);
489
490                 ret = regmap_write(arizona->regmap, ARIZONA_SOFTWARE_RESET, 0);
491                 if (ret != 0) {
492                         dev_err(dev, "Failed to reset device: %d\n", ret);
493                         goto err_reset;
494                 }
495
496                 ret = regcache_sync(arizona->regmap);
497                 if (ret != 0) {
498                         dev_err(dev, "Failed to sync device: %d\n", ret);
499                         goto err_reset;
500                 }
501         }
502
503         ret = arizona_wait_for_boot(arizona);
504         if (ret != 0) {
505                 dev_err(arizona->dev, "Device failed initial boot: %d\n", ret);
506                 goto err_reset;
507         }
508
509         if (apply_patch) {
510                 ret = apply_patch(arizona);
511                 if (ret != 0) {
512                         dev_err(arizona->dev, "Failed to apply patch: %d\n",
513                                 ret);
514                         goto err_reset;
515                 }
516         }
517
518         for (i = 0; i < ARRAY_SIZE(arizona->pdata.gpio_defaults); i++) {
519                 if (!arizona->pdata.gpio_defaults[i])
520                         continue;
521
522                 regmap_write(arizona->regmap, ARIZONA_GPIO1_CTRL + i,
523                              arizona->pdata.gpio_defaults[i]);
524         }
525
526         pm_runtime_set_autosuspend_delay(arizona->dev, 100);
527         pm_runtime_use_autosuspend(arizona->dev);
528         pm_runtime_enable(arizona->dev);
529
530         /* Chip default */
531         if (!arizona->pdata.clk32k_src)
532                 arizona->pdata.clk32k_src = ARIZONA_32KZ_MCLK2;
533
534         switch (arizona->pdata.clk32k_src) {
535         case ARIZONA_32KZ_MCLK1:
536         case ARIZONA_32KZ_MCLK2:
537                 regmap_update_bits(arizona->regmap, ARIZONA_CLOCK_32K_1,
538                                    ARIZONA_CLK_32K_SRC_MASK,
539                                    arizona->pdata.clk32k_src - 1);
540                 arizona_clk32k_enable(arizona);
541                 break;
542         case ARIZONA_32KZ_NONE:
543                 regmap_update_bits(arizona->regmap, ARIZONA_CLOCK_32K_1,
544                                    ARIZONA_CLK_32K_SRC_MASK, 2);
545                 break;
546         default:
547                 dev_err(arizona->dev, "Invalid 32kHz clock source: %d\n",
548                         arizona->pdata.clk32k_src);
549                 ret = -EINVAL;
550                 goto err_reset;
551         }
552
553         for (i = 0; i < ARIZONA_MAX_MICBIAS; i++) {
554                 if (!arizona->pdata.micbias[i].mV &&
555                     !arizona->pdata.micbias[i].bypass)
556                         continue;
557
558                 /* Apply default for bypass mode */
559                 if (!arizona->pdata.micbias[i].mV)
560                         arizona->pdata.micbias[i].mV = 2800;
561
562                 val = (arizona->pdata.micbias[i].mV - 1500) / 100;
563
564                 val <<= ARIZONA_MICB1_LVL_SHIFT;
565
566                 if (arizona->pdata.micbias[i].ext_cap)
567                         val |= ARIZONA_MICB1_EXT_CAP;
568
569                 if (arizona->pdata.micbias[i].discharge)
570                         val |= ARIZONA_MICB1_DISCH;
571
572                 if (arizona->pdata.micbias[i].fast_start)
573                         val |= ARIZONA_MICB1_RATE;
574
575                 if (arizona->pdata.micbias[i].bypass)
576                         val |= ARIZONA_MICB1_BYPASS;
577
578                 regmap_update_bits(arizona->regmap,
579                                    ARIZONA_MIC_BIAS_CTRL_1 + i,
580                                    ARIZONA_MICB1_LVL_MASK |
581                                    ARIZONA_MICB1_DISCH |
582                                    ARIZONA_MICB1_BYPASS |
583                                    ARIZONA_MICB1_RATE, val);
584         }
585
586         for (i = 0; i < ARIZONA_MAX_INPUT; i++) {
587                 /* Default for both is 0 so noop with defaults */
588                 val = arizona->pdata.dmic_ref[i]
589                         << ARIZONA_IN1_DMIC_SUP_SHIFT;
590                 val |= arizona->pdata.inmode[i] << ARIZONA_IN1_MODE_SHIFT;
591
592                 regmap_update_bits(arizona->regmap,
593                                    ARIZONA_IN1L_CONTROL + (i * 8),
594                                    ARIZONA_IN1_DMIC_SUP_MASK |
595                                    ARIZONA_IN1_MODE_MASK, val);
596         }
597
598         for (i = 0; i < ARIZONA_MAX_OUTPUT; i++) {
599                 /* Default is 0 so noop with defaults */
600                 if (arizona->pdata.out_mono[i])
601                         val = ARIZONA_OUT1_MONO;
602                 else
603                         val = 0;
604
605                 regmap_update_bits(arizona->regmap,
606                                    ARIZONA_OUTPUT_PATH_CONFIG_1L + (i * 8),
607                                    ARIZONA_OUT1_MONO, val);
608         }
609
610         for (i = 0; i < ARIZONA_MAX_PDM_SPK; i++) {
611                 if (arizona->pdata.spk_mute[i])
612                         regmap_update_bits(arizona->regmap,
613                                            ARIZONA_PDM_SPK1_CTRL_1 + (i * 2),
614                                            ARIZONA_SPK1_MUTE_ENDIAN_MASK |
615                                            ARIZONA_SPK1_MUTE_SEQ1_MASK,
616                                            arizona->pdata.spk_mute[i]);
617
618                 if (arizona->pdata.spk_fmt[i])
619                         regmap_update_bits(arizona->regmap,
620                                            ARIZONA_PDM_SPK1_CTRL_2 + (i * 2),
621                                            ARIZONA_SPK1_FMT_MASK,
622                                            arizona->pdata.spk_fmt[i]);
623         }
624
625         /* Set up for interrupts */
626         ret = arizona_irq_init(arizona);
627         if (ret != 0)
628                 goto err_reset;
629
630         arizona_request_irq(arizona, ARIZONA_IRQ_CLKGEN_ERR, "CLKGEN error",
631                             arizona_clkgen_err, arizona);
632         arizona_request_irq(arizona, ARIZONA_IRQ_OVERCLOCKED, "Overclocked",
633                             arizona_overclocked, arizona);
634         arizona_request_irq(arizona, ARIZONA_IRQ_UNDERCLOCKED, "Underclocked",
635                             arizona_underclocked, arizona);
636
637         switch (arizona->type) {
638         case WM5102:
639                 ret = mfd_add_devices(arizona->dev, -1, wm5102_devs,
640                                       ARRAY_SIZE(wm5102_devs), NULL, 0, NULL);
641                 break;
642         case WM5110:
643                 ret = mfd_add_devices(arizona->dev, -1, wm5110_devs,
644                                       ARRAY_SIZE(wm5110_devs), NULL, 0, NULL);
645                 break;
646         }
647
648         if (ret != 0) {
649                 dev_err(arizona->dev, "Failed to add subdevices: %d\n", ret);
650                 goto err_irq;
651         }
652
653 #ifdef CONFIG_PM_RUNTIME
654         regulator_disable(arizona->dcvdd);
655 #endif
656
657         return 0;
658
659 err_irq:
660         arizona_irq_exit(arizona);
661 err_reset:
662         if (arizona->pdata.reset) {
663                 gpio_set_value_cansleep(arizona->pdata.reset, 1);
664                 gpio_free(arizona->pdata.reset);
665         }
666 err_dcvdd:
667         regulator_disable(arizona->dcvdd);
668 err_enable:
669         regulator_bulk_disable(arizona->num_core_supplies,
670                                arizona->core_supplies);
671 err_early:
672         mfd_remove_devices(dev);
673         return ret;
674 }
675 EXPORT_SYMBOL_GPL(arizona_dev_init);
676
677 int arizona_dev_exit(struct arizona *arizona)
678 {
679         mfd_remove_devices(arizona->dev);
680         arizona_free_irq(arizona, ARIZONA_IRQ_UNDERCLOCKED, arizona);
681         arizona_free_irq(arizona, ARIZONA_IRQ_OVERCLOCKED, arizona);
682         arizona_free_irq(arizona, ARIZONA_IRQ_CLKGEN_ERR, arizona);
683         pm_runtime_disable(arizona->dev);
684         arizona_irq_exit(arizona);
685         return 0;
686 }
687 EXPORT_SYMBOL_GPL(arizona_dev_exit);