]> Pileus Git - ~andy/linux/blob - drivers/ide/ide-probe.c
ide: move handling of I/O resources out of ide_probe_port()
[~andy/linux] / drivers / ide / ide-probe.c
1 /*
2  *  Copyright (C) 1994-1998   Linus Torvalds & authors (see below)
3  *  Copyright (C) 2005, 2007  Bartlomiej Zolnierkiewicz
4  */
5
6 /*
7  *  Mostly written by Mark Lord <mlord@pobox.com>
8  *                and Gadi Oxman <gadio@netvision.net.il>
9  *                and Andre Hedrick <andre@linux-ide.org>
10  *
11  *  See linux/MAINTAINERS for address of current maintainer.
12  *
13  * This is the IDE probe module, as evolved from hd.c and ide.c.
14  *
15  * -- increase WAIT_PIDENTIFY to avoid CD-ROM locking at boot
16  *       by Andrea Arcangeli
17  */
18
19 #include <linux/module.h>
20 #include <linux/types.h>
21 #include <linux/string.h>
22 #include <linux/kernel.h>
23 #include <linux/timer.h>
24 #include <linux/mm.h>
25 #include <linux/interrupt.h>
26 #include <linux/major.h>
27 #include <linux/errno.h>
28 #include <linux/genhd.h>
29 #include <linux/slab.h>
30 #include <linux/delay.h>
31 #include <linux/ide.h>
32 #include <linux/spinlock.h>
33 #include <linux/kmod.h>
34 #include <linux/pci.h>
35 #include <linux/scatterlist.h>
36
37 #include <asm/byteorder.h>
38 #include <asm/irq.h>
39 #include <asm/uaccess.h>
40 #include <asm/io.h>
41
42 /**
43  *      generic_id              -       add a generic drive id
44  *      @drive: drive to make an ID block for
45  *      
46  *      Add a fake id field to the drive we are passed. This allows
47  *      use to skip a ton of NULL checks (which people always miss) 
48  *      and make drive properties unconditional outside of this file
49  */
50  
51 static void generic_id(ide_drive_t *drive)
52 {
53         drive->id->cyls = drive->cyl;
54         drive->id->heads = drive->head;
55         drive->id->sectors = drive->sect;
56         drive->id->cur_cyls = drive->cyl;
57         drive->id->cur_heads = drive->head;
58         drive->id->cur_sectors = drive->sect;
59 }
60
61 static void ide_disk_init_chs(ide_drive_t *drive)
62 {
63         struct hd_driveid *id = drive->id;
64
65         /* Extract geometry if we did not already have one for the drive */
66         if (!drive->cyl || !drive->head || !drive->sect) {
67                 drive->cyl  = drive->bios_cyl  = id->cyls;
68                 drive->head = drive->bios_head = id->heads;
69                 drive->sect = drive->bios_sect = id->sectors;
70         }
71
72         /* Handle logical geometry translation by the drive */
73         if ((id->field_valid & 1) && id->cur_cyls &&
74             id->cur_heads && (id->cur_heads <= 16) && id->cur_sectors) {
75                 drive->cyl  = id->cur_cyls;
76                 drive->head = id->cur_heads;
77                 drive->sect = id->cur_sectors;
78         }
79
80         /* Use physical geometry if what we have still makes no sense */
81         if (drive->head > 16 && id->heads && id->heads <= 16) {
82                 drive->cyl  = id->cyls;
83                 drive->head = id->heads;
84                 drive->sect = id->sectors;
85         }
86 }
87
88 static void ide_disk_init_mult_count(ide_drive_t *drive)
89 {
90         struct hd_driveid *id = drive->id;
91
92         drive->mult_count = 0;
93         if (id->max_multsect) {
94 #ifdef CONFIG_IDEDISK_MULTI_MODE
95                 id->multsect = ((id->max_multsect/2) > 1) ? id->max_multsect : 0;
96                 id->multsect_valid = id->multsect ? 1 : 0;
97                 drive->mult_req = id->multsect_valid ? id->max_multsect : 0;
98                 drive->special.b.set_multmode = drive->mult_req ? 1 : 0;
99 #else   /* original, pre IDE-NFG, per request of AC */
100                 drive->mult_req = 0;
101                 if (drive->mult_req > id->max_multsect)
102                         drive->mult_req = id->max_multsect;
103                 if (drive->mult_req || ((id->multsect_valid & 1) && id->multsect))
104                         drive->special.b.set_multmode = 1;
105 #endif
106         }
107 }
108
109 /**
110  *      do_identify     -       identify a drive
111  *      @drive: drive to identify 
112  *      @cmd: command used
113  *
114  *      Called when we have issued a drive identify command to
115  *      read and parse the results. This function is run with
116  *      interrupts disabled. 
117  */
118  
119 static inline void do_identify (ide_drive_t *drive, u8 cmd)
120 {
121         ide_hwif_t *hwif = HWIF(drive);
122         int bswap = 1;
123         struct hd_driveid *id;
124
125         id = drive->id;
126         /* read 512 bytes of id info */
127         hwif->ata_input_data(drive, id, SECTOR_WORDS);
128
129         drive->id_read = 1;
130         local_irq_enable();
131 #ifdef DEBUG
132         printk(KERN_INFO "%s: dumping identify data\n", drive->name);
133         ide_dump_identify((u8 *)id);
134 #endif
135         ide_fix_driveid(id);
136
137 #if defined (CONFIG_SCSI_EATA_PIO) || defined (CONFIG_SCSI_EATA)
138         /*
139          * EATA SCSI controllers do a hardware ATA emulation:
140          * Ignore them if there is a driver for them available.
141          */
142         if ((id->model[0] == 'P' && id->model[1] == 'M') ||
143             (id->model[0] == 'S' && id->model[1] == 'K')) {
144                 printk("%s: EATA SCSI HBA %.10s\n", drive->name, id->model);
145                 goto err_misc;
146         }
147 #endif /* CONFIG_SCSI_EATA || CONFIG_SCSI_EATA_PIO */
148
149         /*
150          *  WIN_IDENTIFY returns little-endian info,
151          *  WIN_PIDENTIFY *usually* returns little-endian info.
152          */
153         if (cmd == WIN_PIDENTIFY) {
154                 if ((id->model[0] == 'N' && id->model[1] == 'E') /* NEC */
155                  || (id->model[0] == 'F' && id->model[1] == 'X') /* Mitsumi */
156                  || (id->model[0] == 'P' && id->model[1] == 'i'))/* Pioneer */
157                         /* Vertos drives may still be weird */
158                         bswap ^= 1;     
159         }
160         ide_fixstring(id->model,     sizeof(id->model),     bswap);
161         ide_fixstring(id->fw_rev,    sizeof(id->fw_rev),    bswap);
162         ide_fixstring(id->serial_no, sizeof(id->serial_no), bswap);
163
164         /* we depend on this a lot! */
165         id->model[sizeof(id->model)-1] = '\0';
166
167         if (strstr(id->model, "E X A B Y T E N E S T"))
168                 goto err_misc;
169
170         printk("%s: %s, ", drive->name, id->model);
171         drive->present = 1;
172         drive->dead = 0;
173
174         /*
175          * Check for an ATAPI device
176          */
177         if (cmd == WIN_PIDENTIFY) {
178                 u8 type = (id->config >> 8) & 0x1f;
179                 printk("ATAPI ");
180                 switch (type) {
181                         case ide_floppy:
182                                 if (!strstr(id->model, "CD-ROM")) {
183                                         if (!strstr(id->model, "oppy") &&
184                                             !strstr(id->model, "poyp") &&
185                                             !strstr(id->model, "ZIP"))
186                                                 printk("cdrom or floppy?, assuming ");
187                                         if (drive->media != ide_cdrom) {
188                                                 printk ("FLOPPY");
189                                                 drive->removable = 1;
190                                                 break;
191                                         }
192                                 }
193                                 /* Early cdrom models used zero */
194                                 type = ide_cdrom;
195                         case ide_cdrom:
196                                 drive->removable = 1;
197 #ifdef CONFIG_PPC
198                                 /* kludge for Apple PowerBook internal zip */
199                                 if (!strstr(id->model, "CD-ROM") &&
200                                     strstr(id->model, "ZIP")) {
201                                         printk ("FLOPPY");
202                                         type = ide_floppy;
203                                         break;
204                                 }
205 #endif
206                                 printk ("CD/DVD-ROM");
207                                 break;
208                         case ide_tape:
209                                 printk ("TAPE");
210                                 break;
211                         case ide_optical:
212                                 printk ("OPTICAL");
213                                 drive->removable = 1;
214                                 break;
215                         default:
216                                 printk("UNKNOWN (type %d)", type);
217                                 break;
218                 }
219                 printk (" drive\n");
220                 drive->media = type;
221                 /* an ATAPI device ignores DRDY */
222                 drive->ready_stat = 0;
223                 return;
224         }
225
226         /*
227          * Not an ATAPI device: looks like a "regular" hard disk
228          */
229
230         /*
231          * 0x848a = CompactFlash device
232          * These are *not* removable in Linux definition of the term
233          */
234
235         if ((id->config != 0x848a) && (id->config & (1<<7)))
236                 drive->removable = 1;
237
238         drive->media = ide_disk;
239         printk("%s DISK drive\n", (id->config == 0x848a) ? "CFA" : "ATA" );
240
241         return;
242
243 err_misc:
244         kfree(id);
245         drive->present = 0;
246         return;
247 }
248
249 /**
250  *      actual_try_to_identify  -       send ata/atapi identify
251  *      @drive: drive to identify
252  *      @cmd: command to use
253  *
254  *      try_to_identify() sends an ATA(PI) IDENTIFY request to a drive
255  *      and waits for a response.  It also monitors irqs while this is
256  *      happening, in hope of automatically determining which one is
257  *      being used by the interface.
258  *
259  *      Returns:        0  device was identified
260  *                      1  device timed-out (no response to identify request)
261  *                      2  device aborted the command (refused to identify itself)
262  */
263
264 static int actual_try_to_identify (ide_drive_t *drive, u8 cmd)
265 {
266         ide_hwif_t *hwif = HWIF(drive);
267         int rc;
268         unsigned long hd_status;
269         unsigned long timeout;
270         u8 s = 0, a = 0;
271
272         /* take a deep breath */
273         msleep(50);
274
275         if (IDE_CONTROL_REG) {
276                 a = hwif->INB(IDE_ALTSTATUS_REG);
277                 s = hwif->INB(IDE_STATUS_REG);
278                 if ((a ^ s) & ~INDEX_STAT) {
279                         printk(KERN_INFO "%s: probing with STATUS(0x%02x) instead of "
280                                 "ALTSTATUS(0x%02x)\n", drive->name, s, a);
281                         /* ancient Seagate drives, broken interfaces */
282                         hd_status = IDE_STATUS_REG;
283                 } else {
284                         /* use non-intrusive polling */
285                         hd_status = IDE_ALTSTATUS_REG;
286                 }
287         } else
288                 hd_status = IDE_STATUS_REG;
289
290         /* set features register for atapi
291          * identify command to be sure of reply
292          */
293         if ((cmd == WIN_PIDENTIFY))
294                 /* disable dma & overlap */
295                 hwif->OUTB(0, IDE_FEATURE_REG);
296
297         /* ask drive for ID */
298         hwif->OUTB(cmd, IDE_COMMAND_REG);
299
300         timeout = ((cmd == WIN_IDENTIFY) ? WAIT_WORSTCASE : WAIT_PIDENTIFY) / 2;
301         timeout += jiffies;
302         do {
303                 if (time_after(jiffies, timeout)) {
304                         /* drive timed-out */
305                         return 1;
306                 }
307                 /* give drive a breather */
308                 msleep(50);
309         } while ((hwif->INB(hd_status)) & BUSY_STAT);
310
311         /* wait for IRQ and DRQ_STAT */
312         msleep(50);
313         if (OK_STAT((hwif->INB(IDE_STATUS_REG)), DRQ_STAT, BAD_R_STAT)) {
314                 unsigned long flags;
315
316                 /* local CPU only; some systems need this */
317                 local_irq_save(flags);
318                 /* drive returned ID */
319                 do_identify(drive, cmd);
320                 /* drive responded with ID */
321                 rc = 0;
322                 /* clear drive IRQ */
323                 (void) hwif->INB(IDE_STATUS_REG);
324                 local_irq_restore(flags);
325         } else {
326                 /* drive refused ID */
327                 rc = 2;
328         }
329         return rc;
330 }
331
332 /**
333  *      try_to_identify -       try to identify a drive
334  *      @drive: drive to probe
335  *      @cmd: command to use
336  *
337  *      Issue the identify command and then do IRQ probing to
338  *      complete the identification when needed by finding the
339  *      IRQ the drive is attached to
340  */
341  
342 static int try_to_identify (ide_drive_t *drive, u8 cmd)
343 {
344         ide_hwif_t *hwif = HWIF(drive);
345         int retval;
346         int autoprobe = 0;
347         unsigned long cookie = 0;
348
349         /*
350          * Disable device irq unless we need to
351          * probe for it. Otherwise we'll get spurious
352          * interrupts during the identify-phase that
353          * the irq handler isn't expecting.
354          */
355         if (IDE_CONTROL_REG) {
356                 if (!hwif->irq) {
357                         autoprobe = 1;
358                         cookie = probe_irq_on();
359                 }
360                 ide_set_irq(drive, autoprobe);
361         }
362
363         retval = actual_try_to_identify(drive, cmd);
364
365         if (autoprobe) {
366                 int irq;
367
368                 ide_set_irq(drive, 0);
369                 /* clear drive IRQ */
370                 (void) hwif->INB(IDE_STATUS_REG);
371                 udelay(5);
372                 irq = probe_irq_off(cookie);
373                 if (!hwif->irq) {
374                         if (irq > 0) {
375                                 hwif->irq = irq;
376                         } else {
377                                 /* Mmmm.. multiple IRQs..
378                                  * don't know which was ours
379                                  */
380                                 printk("%s: IRQ probe failed (0x%lx)\n",
381                                         drive->name, cookie);
382                         }
383                 }
384         }
385         return retval;
386 }
387
388 static int ide_busy_sleep(ide_hwif_t *hwif)
389 {
390         unsigned long timeout = jiffies + WAIT_WORSTCASE;
391         u8 stat;
392
393         do {
394                 msleep(50);
395                 stat = hwif->INB(hwif->io_ports[IDE_STATUS_OFFSET]);
396                 if ((stat & BUSY_STAT) == 0)
397                         return 0;
398         } while (time_before(jiffies, timeout));
399
400         return 1;
401 }
402
403 /**
404  *      do_probe                -       probe an IDE device
405  *      @drive: drive to probe
406  *      @cmd: command to use
407  *
408  *      do_probe() has the difficult job of finding a drive if it exists,
409  *      without getting hung up if it doesn't exist, without trampling on
410  *      ethernet cards, and without leaving any IRQs dangling to haunt us later.
411  *
412  *      If a drive is "known" to exist (from CMOS or kernel parameters),
413  *      but does not respond right away, the probe will "hang in there"
414  *      for the maximum wait time (about 30 seconds), otherwise it will
415  *      exit much more quickly.
416  *
417  * Returns:     0  device was identified
418  *              1  device timed-out (no response to identify request)
419  *              2  device aborted the command (refused to identify itself)
420  *              3  bad status from device (possible for ATAPI drives)
421  *              4  probe was not attempted because failure was obvious
422  */
423
424 static int do_probe (ide_drive_t *drive, u8 cmd)
425 {
426         int rc;
427         ide_hwif_t *hwif = HWIF(drive);
428
429         if (drive->present) {
430                 /* avoid waiting for inappropriate probes */
431                 if ((drive->media != ide_disk) && (cmd == WIN_IDENTIFY))
432                         return 4;
433         }
434 #ifdef DEBUG
435         printk("probing for %s: present=%d, media=%d, probetype=%s\n",
436                 drive->name, drive->present, drive->media,
437                 (cmd == WIN_IDENTIFY) ? "ATA" : "ATAPI");
438 #endif
439
440         /* needed for some systems
441          * (e.g. crw9624 as drive0 with disk as slave)
442          */
443         msleep(50);
444         SELECT_DRIVE(drive);
445         msleep(50);
446         if (hwif->INB(IDE_SELECT_REG) != drive->select.all && !drive->present) {
447                 if (drive->select.b.unit != 0) {
448                         /* exit with drive0 selected */
449                         SELECT_DRIVE(&hwif->drives[0]);
450                         /* allow BUSY_STAT to assert & clear */
451                         msleep(50);
452                 }
453                 /* no i/f present: mmm.. this should be a 4 -ml */
454                 return 3;
455         }
456
457         if (OK_STAT((hwif->INB(IDE_STATUS_REG)), READY_STAT, BUSY_STAT) ||
458             drive->present || cmd == WIN_PIDENTIFY) {
459                 /* send cmd and wait */
460                 if ((rc = try_to_identify(drive, cmd))) {
461                         /* failed: try again */
462                         rc = try_to_identify(drive,cmd);
463                 }
464                 if (hwif->INB(IDE_STATUS_REG) == (BUSY_STAT|READY_STAT))
465                         return 4;
466
467                 if ((rc == 1 && cmd == WIN_PIDENTIFY) &&
468                         ((drive->autotune == IDE_TUNE_DEFAULT) ||
469                         (drive->autotune == IDE_TUNE_AUTO))) {
470                         printk("%s: no response (status = 0x%02x), "
471                                 "resetting drive\n", drive->name,
472                                 hwif->INB(IDE_STATUS_REG));
473                         msleep(50);
474                         hwif->OUTB(drive->select.all, IDE_SELECT_REG);
475                         msleep(50);
476                         hwif->OUTB(WIN_SRST, IDE_COMMAND_REG);
477                         (void)ide_busy_sleep(hwif);
478                         rc = try_to_identify(drive, cmd);
479                 }
480                 if (rc == 1)
481                         printk("%s: no response (status = 0x%02x)\n",
482                                 drive->name, hwif->INB(IDE_STATUS_REG));
483                 /* ensure drive irq is clear */
484                 (void) hwif->INB(IDE_STATUS_REG);
485         } else {
486                 /* not present or maybe ATAPI */
487                 rc = 3;
488         }
489         if (drive->select.b.unit != 0) {
490                 /* exit with drive0 selected */
491                 SELECT_DRIVE(&hwif->drives[0]);
492                 msleep(50);
493                 /* ensure drive irq is clear */
494                 (void) hwif->INB(IDE_STATUS_REG);
495         }
496         return rc;
497 }
498
499 /*
500  *
501  */
502 static void enable_nest (ide_drive_t *drive)
503 {
504         ide_hwif_t *hwif = HWIF(drive);
505
506         printk("%s: enabling %s -- ", hwif->name, drive->id->model);
507         SELECT_DRIVE(drive);
508         msleep(50);
509         hwif->OUTB(EXABYTE_ENABLE_NEST, IDE_COMMAND_REG);
510
511         if (ide_busy_sleep(hwif)) {
512                 printk(KERN_CONT "failed (timeout)\n");
513                 return;
514         }
515
516         msleep(50);
517
518         if (!OK_STAT((hwif->INB(IDE_STATUS_REG)), 0, BAD_STAT)) {
519                 printk("failed (status = 0x%02x)\n", hwif->INB(IDE_STATUS_REG));
520         } else {
521                 printk("success\n");
522         }
523
524         /* if !(success||timed-out) */
525         if (do_probe(drive, WIN_IDENTIFY) >= 2) {
526                 /* look for ATAPI device */
527                 (void) do_probe(drive, WIN_PIDENTIFY);
528         }
529 }
530
531 /**
532  *      probe_for_drives        -       upper level drive probe
533  *      @drive: drive to probe for
534  *
535  *      probe_for_drive() tests for existence of a given drive using do_probe()
536  *      and presents things to the user as needed.
537  *
538  *      Returns:        0  no device was found
539  *                      1  device was found (note: drive->present might
540  *                         still be 0)
541  */
542  
543 static inline u8 probe_for_drive (ide_drive_t *drive)
544 {
545         /*
546          *      In order to keep things simple we have an id
547          *      block for all drives at all times. If the device
548          *      is pre ATA or refuses ATA/ATAPI identify we
549          *      will add faked data to this.
550          *
551          *      Also note that 0 everywhere means "can't do X"
552          */
553  
554         drive->id = kzalloc(SECTOR_WORDS *4, GFP_KERNEL);
555         drive->id_read = 0;
556         if(drive->id == NULL)
557         {
558                 printk(KERN_ERR "ide: out of memory for id data.\n");
559                 return 0;
560         }
561         strcpy(drive->id->model, "UNKNOWN");
562         
563         /* skip probing? */
564         if (!drive->noprobe)
565         {
566                 /* if !(success||timed-out) */
567                 if (do_probe(drive, WIN_IDENTIFY) >= 2) {
568                         /* look for ATAPI device */
569                         (void) do_probe(drive, WIN_PIDENTIFY);
570                 }
571                 if (!drive->present)
572                         /* drive not found */
573                         return 0;
574                 if (strstr(drive->id->model, "E X A B Y T E N E S T"))
575                         enable_nest(drive);
576         
577                 /* identification failed? */
578                 if (!drive->id_read) {
579                         if (drive->media == ide_disk) {
580                                 printk(KERN_INFO "%s: non-IDE drive, CHS=%d/%d/%d\n",
581                                         drive->name, drive->cyl,
582                                         drive->head, drive->sect);
583                         } else if (drive->media == ide_cdrom) {
584                                 printk(KERN_INFO "%s: ATAPI cdrom (?)\n", drive->name);
585                         } else {
586                                 /* nuke it */
587                                 printk(KERN_WARNING "%s: Unknown device on bus refused identification. Ignoring.\n", drive->name);
588                                 drive->present = 0;
589                         }
590                 }
591                 /* drive was found */
592         }
593         if(!drive->present)
594                 return 0;
595         /* The drive wasn't being helpful. Add generic info only */
596         if (drive->id_read == 0) {
597                 generic_id(drive);
598                 return 1;
599         }
600
601         if (drive->media == ide_disk) {
602                 ide_disk_init_chs(drive);
603                 ide_disk_init_mult_count(drive);
604         }
605
606         return drive->present;
607 }
608
609 static void hwif_release_dev (struct device *dev)
610 {
611         ide_hwif_t *hwif = container_of(dev, ide_hwif_t, gendev);
612
613         complete(&hwif->gendev_rel_comp);
614 }
615
616 static void hwif_register (ide_hwif_t *hwif)
617 {
618         int ret;
619
620         /* register with global device tree */
621         strlcpy(hwif->gendev.bus_id,hwif->name,BUS_ID_SIZE);
622         hwif->gendev.driver_data = hwif;
623         if (hwif->gendev.parent == NULL) {
624                 if (hwif->dev)
625                         hwif->gendev.parent = hwif->dev;
626                 else
627                         /* Would like to do = &device_legacy */
628                         hwif->gendev.parent = NULL;
629         }
630         hwif->gendev.release = hwif_release_dev;
631         ret = device_register(&hwif->gendev);
632         if (ret < 0)
633                 printk(KERN_WARNING "IDE: %s: device_register error: %d\n",
634                         __FUNCTION__, ret);
635 }
636
637 /**
638  *      ide_port_wait_ready     -       wait for port to become ready
639  *      @hwif: IDE port
640  *
641  *      This is needed on some PPCs and a bunch of BIOS-less embedded
642  *      platforms.  Typical cases are:
643  *
644  *      - The firmware hard reset the disk before booting the kernel,
645  *        the drive is still doing it's poweron-reset sequence, that
646  *        can take up to 30 seconds.
647  *
648  *      - The firmware does nothing (or no firmware), the device is
649  *        still in POST state (same as above actually).
650  *
651  *      - Some CD/DVD/Writer combo drives tend to drive the bus during
652  *        their reset sequence even when they are non-selected slave
653  *        devices, thus preventing discovery of the main HD.
654  *
655  *      Doing this wait-for-non-busy should not harm any existing
656  *      configuration and fix some issues like the above.
657  *
658  *      BenH.
659  *
660  *      Returns 0 on success, error code (< 0) otherwise.
661  */
662
663 static int ide_port_wait_ready(ide_hwif_t *hwif)
664 {
665         int unit, rc;
666
667         printk(KERN_DEBUG "Probing IDE interface %s...\n", hwif->name);
668
669         /* Let HW settle down a bit from whatever init state we
670          * come from */
671         mdelay(2);
672
673         /* Wait for BSY bit to go away, spec timeout is 30 seconds,
674          * I know of at least one disk who takes 31 seconds, I use 35
675          * here to be safe
676          */
677         rc = ide_wait_not_busy(hwif, 35000);
678         if (rc)
679                 return rc;
680
681         /* Now make sure both master & slave are ready */
682         for (unit = 0; unit < MAX_DRIVES; unit++) {
683                 ide_drive_t *drive = &hwif->drives[unit];
684
685                 /* Ignore disks that we will not probe for later. */
686                 if (!drive->noprobe || drive->present) {
687                         SELECT_DRIVE(drive);
688                         ide_set_irq(drive, 1);
689                         mdelay(2);
690                         rc = ide_wait_not_busy(hwif, 35000);
691                         if (rc)
692                                 goto out;
693                 } else
694                         printk(KERN_DEBUG "%s: ide_wait_not_busy() skipped\n",
695                                           drive->name);
696         }
697 out:
698         /* Exit function with master reselected (let's be sane) */
699         if (unit)
700                 SELECT_DRIVE(&hwif->drives[0]);
701
702         return rc;
703 }
704
705 /**
706  *      ide_undecoded_slave     -       look for bad CF adapters
707  *      @drive1: drive
708  *
709  *      Analyse the drives on the interface and attempt to decide if we
710  *      have the same drive viewed twice. This occurs with crap CF adapters
711  *      and PCMCIA sometimes.
712  */
713
714 void ide_undecoded_slave(ide_drive_t *drive1)
715 {
716         ide_drive_t *drive0 = &drive1->hwif->drives[0];
717
718         if ((drive1->dn & 1) == 0 || drive0->present == 0)
719                 return;
720
721         /* If the models don't match they are not the same product */
722         if (strcmp(drive0->id->model, drive1->id->model))
723                 return;
724
725         /* Serial numbers do not match */
726         if (strncmp(drive0->id->serial_no, drive1->id->serial_no, 20))
727                 return;
728
729         /* No serial number, thankfully very rare for CF */
730         if (drive0->id->serial_no[0] == 0)
731                 return;
732
733         /* Appears to be an IDE flash adapter with decode bugs */
734         printk(KERN_WARNING "ide-probe: ignoring undecoded slave\n");
735
736         drive1->present = 0;
737 }
738
739 EXPORT_SYMBOL_GPL(ide_undecoded_slave);
740
741 static int ide_probe_port(ide_hwif_t *hwif)
742 {
743         unsigned long flags;
744         unsigned int irqd;
745         int unit;
746
747         if (hwif->noprobe)
748                 return -EACCES;
749
750         /*
751          * We must always disable IRQ, as probe_for_drive will assert IRQ, but
752          * we'll install our IRQ driver much later...
753          */
754         irqd = hwif->irq;
755         if (irqd)
756                 disable_irq(hwif->irq);
757
758         local_irq_set(flags);
759
760         if (ide_port_wait_ready(hwif) == -EBUSY)
761                 printk(KERN_DEBUG "%s: Wait for ready failed before probe !\n", hwif->name);
762
763         /*
764          * Need to probe slave device first to make it release PDIAG-.
765          */
766         for (unit = MAX_DRIVES - 1; unit >= 0; unit--) {
767                 ide_drive_t *drive = &hwif->drives[unit];
768                 drive->dn = (hwif->channel ? 2 : 0) + unit;
769                 (void) probe_for_drive(drive);
770                 if (drive->present && !hwif->present) {
771                         hwif->present = 1;
772                         if (hwif->chipset != ide_4drives ||
773                             !hwif->mate || 
774                             !hwif->mate->present) {
775                                 hwif_register(hwif);
776                         }
777                 }
778         }
779         if (hwif->io_ports[IDE_CONTROL_OFFSET] && hwif->reset) {
780                 printk(KERN_WARNING "%s: reset\n", hwif->name);
781                 hwif->OUTB(12, hwif->io_ports[IDE_CONTROL_OFFSET]);
782                 udelay(10);
783                 hwif->OUTB(8, hwif->io_ports[IDE_CONTROL_OFFSET]);
784                 (void)ide_busy_sleep(hwif);
785         }
786         local_irq_restore(flags);
787         /*
788          * Use cached IRQ number. It might be (and is...) changed by probe
789          * code above
790          */
791         if (irqd)
792                 enable_irq(irqd);
793
794         if (!hwif->present)
795                 return -ENODEV;
796
797         for (unit = 0; unit < MAX_DRIVES; unit++) {
798                 ide_drive_t *drive = &hwif->drives[unit];
799
800                 if (drive->present && hwif->quirkproc)
801                         hwif->quirkproc(drive);
802         }
803
804         for (unit = 0; unit < MAX_DRIVES; ++unit) {
805                 ide_drive_t *drive = &hwif->drives[unit];
806
807                 if (drive->present) {
808                         if (drive->autotune == IDE_TUNE_AUTO)
809                                 ide_set_max_pio(drive);
810
811                         if (drive->autotune != IDE_TUNE_DEFAULT &&
812                             drive->autotune != IDE_TUNE_AUTO)
813                                 continue;
814
815                         drive->nice1 = 1;
816
817                         if (hwif->dma_host_set)
818                                 ide_set_dma(drive);
819                 }
820         }
821
822         for (unit = 0; unit < MAX_DRIVES; ++unit) {
823                 ide_drive_t *drive = &hwif->drives[unit];
824
825                 if (hwif->no_io_32bit)
826                         drive->no_io_32bit = 1;
827                 else
828                         drive->no_io_32bit = drive->id->dword_io ? 1 : 0;
829         }
830
831         return 0;
832 }
833
834 #if MAX_HWIFS > 1
835 /*
836  * save_match() is used to simplify logic in init_irq() below.
837  *
838  * A loophole here is that we may not know about a particular
839  * hwif's irq until after that hwif is actually probed/initialized..
840  * This could be a problem for the case where an hwif is on a
841  * dual interface that requires serialization (eg. cmd640) and another
842  * hwif using one of the same irqs is initialized beforehand.
843  *
844  * This routine detects and reports such situations, but does not fix them.
845  */
846 static void save_match(ide_hwif_t *hwif, ide_hwif_t *new, ide_hwif_t **match)
847 {
848         ide_hwif_t *m = *match;
849
850         if (m && m->hwgroup && m->hwgroup != new->hwgroup) {
851                 if (!new->hwgroup)
852                         return;
853                 printk("%s: potential irq problem with %s and %s\n",
854                         hwif->name, new->name, m->name);
855         }
856         if (!m || m->irq != hwif->irq) /* don't undo a prior perfect match */
857                 *match = new;
858 }
859 #endif /* MAX_HWIFS > 1 */
860
861 /*
862  * init request queue
863  */
864 static int ide_init_queue(ide_drive_t *drive)
865 {
866         struct request_queue *q;
867         ide_hwif_t *hwif = HWIF(drive);
868         int max_sectors = 256;
869         int max_sg_entries = PRD_ENTRIES;
870
871         /*
872          *      Our default set up assumes the normal IDE case,
873          *      that is 64K segmenting, standard PRD setup
874          *      and LBA28. Some drivers then impose their own
875          *      limits and LBA48 we could raise it but as yet
876          *      do not.
877          */
878
879         q = blk_init_queue_node(do_ide_request, &ide_lock, hwif_to_node(hwif));
880         if (!q)
881                 return 1;
882
883         q->queuedata = drive;
884         blk_queue_segment_boundary(q, 0xffff);
885
886         if (!hwif->rqsize) {
887                 if ((hwif->host_flags & IDE_HFLAG_NO_LBA48) ||
888                     (hwif->host_flags & IDE_HFLAG_NO_LBA48_DMA))
889                         hwif->rqsize = 256;
890                 else
891                         hwif->rqsize = 65536;
892         }
893         if (hwif->rqsize < max_sectors)
894                 max_sectors = hwif->rqsize;
895         blk_queue_max_sectors(q, max_sectors);
896
897 #ifdef CONFIG_PCI
898         /* When we have an IOMMU, we may have a problem where pci_map_sg()
899          * creates segments that don't completely match our boundary
900          * requirements and thus need to be broken up again. Because it
901          * doesn't align properly either, we may actually have to break up
902          * to more segments than what was we got in the first place, a max
903          * worst case is twice as many.
904          * This will be fixed once we teach pci_map_sg() about our boundary
905          * requirements, hopefully soon. *FIXME*
906          */
907         if (!PCI_DMA_BUS_IS_PHYS)
908                 max_sg_entries >>= 1;
909 #endif /* CONFIG_PCI */
910
911         blk_queue_max_hw_segments(q, max_sg_entries);
912         blk_queue_max_phys_segments(q, max_sg_entries);
913
914         /* assign drive queue */
915         drive->queue = q;
916
917         /* needs drive->queue to be set */
918         ide_toggle_bounce(drive, 1);
919
920         return 0;
921 }
922
923 /*
924  * This routine sets up the irq for an ide interface, and creates a new
925  * hwgroup for the irq/hwif if none was previously assigned.
926  *
927  * Much of the code is for correctly detecting/handling irq sharing
928  * and irq serialization situations.  This is somewhat complex because
929  * it handles static as well as dynamic (PCMCIA) IDE interfaces.
930  */
931 static int init_irq (ide_hwif_t *hwif)
932 {
933         unsigned int index;
934         ide_hwgroup_t *hwgroup;
935         ide_hwif_t *match = NULL;
936
937
938         BUG_ON(in_interrupt());
939         BUG_ON(irqs_disabled());        
940         BUG_ON(hwif == NULL);
941
942         mutex_lock(&ide_cfg_mtx);
943         hwif->hwgroup = NULL;
944 #if MAX_HWIFS > 1
945         /*
946          * Group up with any other hwifs that share our irq(s).
947          */
948         for (index = 0; index < MAX_HWIFS; index++) {
949                 ide_hwif_t *h = &ide_hwifs[index];
950                 if (h->hwgroup) {  /* scan only initialized hwif's */
951                         if (hwif->irq == h->irq) {
952                                 hwif->sharing_irq = h->sharing_irq = 1;
953                                 if (hwif->chipset != ide_pci ||
954                                     h->chipset != ide_pci) {
955                                         save_match(hwif, h, &match);
956                                 }
957                         }
958                         if (hwif->serialized) {
959                                 if (hwif->mate && hwif->mate->irq == h->irq)
960                                         save_match(hwif, h, &match);
961                         }
962                         if (h->serialized) {
963                                 if (h->mate && hwif->irq == h->mate->irq)
964                                         save_match(hwif, h, &match);
965                         }
966                 }
967         }
968 #endif /* MAX_HWIFS > 1 */
969         /*
970          * If we are still without a hwgroup, then form a new one
971          */
972         if (match) {
973                 hwgroup = match->hwgroup;
974                 hwif->hwgroup = hwgroup;
975                 /*
976                  * Link us into the hwgroup.
977                  * This must be done early, do ensure that unexpected_intr
978                  * can find the hwif and prevent irq storms.
979                  * No drives are attached to the new hwif, choose_drive
980                  * can't do anything stupid (yet).
981                  * Add ourself as the 2nd entry to the hwgroup->hwif
982                  * linked list, the first entry is the hwif that owns
983                  * hwgroup->handler - do not change that.
984                  */
985                 spin_lock_irq(&ide_lock);
986                 hwif->next = hwgroup->hwif->next;
987                 hwgroup->hwif->next = hwif;
988                 BUG_ON(hwif->next == hwif);
989                 spin_unlock_irq(&ide_lock);
990         } else {
991                 hwgroup = kmalloc_node(sizeof(*hwgroup), GFP_KERNEL|__GFP_ZERO,
992                                        hwif_to_node(hwif));
993                 if (hwgroup == NULL)
994                         goto out_up;
995
996                 hwif->hwgroup = hwgroup;
997                 hwgroup->hwif = hwif->next = hwif;
998
999                 init_timer(&hwgroup->timer);
1000                 hwgroup->timer.function = &ide_timer_expiry;
1001                 hwgroup->timer.data = (unsigned long) hwgroup;
1002         }
1003
1004         /*
1005          * Allocate the irq, if not already obtained for another hwif
1006          */
1007         if (!match || match->irq != hwif->irq) {
1008                 int sa = 0;
1009 #if defined(__mc68000__) || defined(CONFIG_APUS)
1010                 sa = IRQF_SHARED;
1011 #endif /* __mc68000__ || CONFIG_APUS */
1012
1013                 if (IDE_CHIPSET_IS_PCI(hwif->chipset))
1014                         sa = IRQF_SHARED;
1015
1016                 if (hwif->io_ports[IDE_CONTROL_OFFSET])
1017                         /* clear nIEN */
1018                         hwif->OUTB(0x08, hwif->io_ports[IDE_CONTROL_OFFSET]);
1019
1020                 if (request_irq(hwif->irq,&ide_intr,sa,hwif->name,hwgroup))
1021                         goto out_unlink;
1022         }
1023
1024         /*
1025          * For any present drive:
1026          * - allocate the block device queue
1027          * - link drive into the hwgroup
1028          */
1029         for (index = 0; index < MAX_DRIVES; ++index) {
1030                 ide_drive_t *drive = &hwif->drives[index];
1031                 if (!drive->present)
1032                         continue;
1033                 if (ide_init_queue(drive)) {
1034                         printk(KERN_ERR "ide: failed to init %s\n",drive->name);
1035                         continue;
1036                 }
1037                 spin_lock_irq(&ide_lock);
1038                 if (!hwgroup->drive) {
1039                         /* first drive for hwgroup. */
1040                         drive->next = drive;
1041                         hwgroup->drive = drive;
1042                         hwgroup->hwif = HWIF(hwgroup->drive);
1043                 } else {
1044                         drive->next = hwgroup->drive->next;
1045                         hwgroup->drive->next = drive;
1046                 }
1047                 spin_unlock_irq(&ide_lock);
1048         }
1049
1050 #if !defined(__mc68000__) && !defined(CONFIG_APUS)
1051         printk("%s at 0x%03lx-0x%03lx,0x%03lx on irq %d", hwif->name,
1052                 hwif->io_ports[IDE_DATA_OFFSET],
1053                 hwif->io_ports[IDE_DATA_OFFSET]+7,
1054                 hwif->io_ports[IDE_CONTROL_OFFSET], hwif->irq);
1055 #else
1056         printk("%s at 0x%08lx on irq %d", hwif->name,
1057                 hwif->io_ports[IDE_DATA_OFFSET], hwif->irq);
1058 #endif /* __mc68000__ && CONFIG_APUS */
1059         if (match)
1060                 printk(" (%sed with %s)",
1061                         hwif->sharing_irq ? "shar" : "serializ", match->name);
1062         printk("\n");
1063         mutex_unlock(&ide_cfg_mtx);
1064         return 0;
1065 out_unlink:
1066         ide_remove_port_from_hwgroup(hwif);
1067 out_up:
1068         mutex_unlock(&ide_cfg_mtx);
1069         return 1;
1070 }
1071
1072 static int ata_lock(dev_t dev, void *data)
1073 {
1074         /* FIXME: we want to pin hwif down */
1075         return 0;
1076 }
1077
1078 static struct kobject *ata_probe(dev_t dev, int *part, void *data)
1079 {
1080         ide_hwif_t *hwif = data;
1081         int unit = *part >> PARTN_BITS;
1082         ide_drive_t *drive = &hwif->drives[unit];
1083         if (!drive->present)
1084                 return NULL;
1085
1086         if (drive->media == ide_disk)
1087                 request_module("ide-disk");
1088         if (drive->scsi)
1089                 request_module("ide-scsi");
1090         if (drive->media == ide_cdrom || drive->media == ide_optical)
1091                 request_module("ide-cd");
1092         if (drive->media == ide_tape)
1093                 request_module("ide-tape");
1094         if (drive->media == ide_floppy)
1095                 request_module("ide-floppy");
1096
1097         return NULL;
1098 }
1099
1100 static struct kobject *exact_match(dev_t dev, int *part, void *data)
1101 {
1102         struct gendisk *p = data;
1103         *part &= (1 << PARTN_BITS) - 1;
1104         return &p->dev.kobj;
1105 }
1106
1107 static int exact_lock(dev_t dev, void *data)
1108 {
1109         struct gendisk *p = data;
1110
1111         if (!get_disk(p))
1112                 return -1;
1113         return 0;
1114 }
1115
1116 void ide_register_region(struct gendisk *disk)
1117 {
1118         blk_register_region(MKDEV(disk->major, disk->first_minor),
1119                             disk->minors, NULL, exact_match, exact_lock, disk);
1120 }
1121
1122 EXPORT_SYMBOL_GPL(ide_register_region);
1123
1124 void ide_unregister_region(struct gendisk *disk)
1125 {
1126         blk_unregister_region(MKDEV(disk->major, disk->first_minor),
1127                               disk->minors);
1128 }
1129
1130 EXPORT_SYMBOL_GPL(ide_unregister_region);
1131
1132 void ide_init_disk(struct gendisk *disk, ide_drive_t *drive)
1133 {
1134         ide_hwif_t *hwif = drive->hwif;
1135         unsigned int unit = (drive->select.all >> 4) & 1;
1136
1137         disk->major = hwif->major;
1138         disk->first_minor = unit << PARTN_BITS;
1139         sprintf(disk->disk_name, "hd%c", 'a' + hwif->index * MAX_DRIVES + unit);
1140         disk->queue = drive->queue;
1141 }
1142
1143 EXPORT_SYMBOL_GPL(ide_init_disk);
1144
1145 static void ide_remove_drive_from_hwgroup(ide_drive_t *drive)
1146 {
1147         ide_hwgroup_t *hwgroup = drive->hwif->hwgroup;
1148
1149         if (drive == drive->next) {
1150                 /* special case: last drive from hwgroup. */
1151                 BUG_ON(hwgroup->drive != drive);
1152                 hwgroup->drive = NULL;
1153         } else {
1154                 ide_drive_t *walk;
1155
1156                 walk = hwgroup->drive;
1157                 while (walk->next != drive)
1158                         walk = walk->next;
1159                 walk->next = drive->next;
1160                 if (hwgroup->drive == drive) {
1161                         hwgroup->drive = drive->next;
1162                         hwgroup->hwif = hwgroup->drive->hwif;
1163                 }
1164         }
1165         BUG_ON(hwgroup->drive == drive);
1166 }
1167
1168 static void drive_release_dev (struct device *dev)
1169 {
1170         ide_drive_t *drive = container_of(dev, ide_drive_t, gendev);
1171
1172         spin_lock_irq(&ide_lock);
1173         ide_remove_drive_from_hwgroup(drive);
1174         kfree(drive->id);
1175         drive->id = NULL;
1176         drive->present = 0;
1177         /* Messed up locking ... */
1178         spin_unlock_irq(&ide_lock);
1179         blk_cleanup_queue(drive->queue);
1180         spin_lock_irq(&ide_lock);
1181         drive->queue = NULL;
1182         spin_unlock_irq(&ide_lock);
1183
1184         complete(&drive->gendev_rel_comp);
1185 }
1186
1187 /*
1188  * init_gendisk() (as opposed to ide_geninit) is called for each major device,
1189  * after probing for drives, to allocate partition tables and other data
1190  * structures needed for the routines in genhd.c.  ide_geninit() gets called
1191  * somewhat later, during the partition check.
1192  */
1193 static void init_gendisk (ide_hwif_t *hwif)
1194 {
1195         unsigned int unit;
1196
1197         for (unit = 0; unit < MAX_DRIVES; ++unit) {
1198                 ide_drive_t * drive = &hwif->drives[unit];
1199                 ide_add_generic_settings(drive);
1200                 snprintf(drive->gendev.bus_id,BUS_ID_SIZE,"%u.%u",
1201                          hwif->index,unit);
1202                 drive->gendev.parent = &hwif->gendev;
1203                 drive->gendev.bus = &ide_bus_type;
1204                 drive->gendev.driver_data = drive;
1205                 drive->gendev.release = drive_release_dev;
1206         }
1207         blk_register_region(MKDEV(hwif->major, 0), MAX_DRIVES << PARTN_BITS,
1208                         THIS_MODULE, ata_probe, ata_lock, hwif);
1209 }
1210
1211 static int hwif_init(ide_hwif_t *hwif)
1212 {
1213         int old_irq;
1214
1215         if (!hwif->irq) {
1216                 if (!(hwif->irq = ide_default_irq(hwif->io_ports[IDE_DATA_OFFSET])))
1217                 {
1218                         printk("%s: DISABLED, NO IRQ\n", hwif->name);
1219                         return 0;
1220                 }
1221         }
1222 #ifdef CONFIG_BLK_DEV_HD
1223         if (hwif->irq == HD_IRQ && hwif->io_ports[IDE_DATA_OFFSET] != HD_DATA) {
1224                 printk("%s: CANNOT SHARE IRQ WITH OLD "
1225                         "HARDDISK DRIVER (hd.c)\n", hwif->name);
1226                 return 0;
1227         }
1228 #endif /* CONFIG_BLK_DEV_HD */
1229
1230         if (register_blkdev(hwif->major, hwif->name))
1231                 return 0;
1232
1233         if (!hwif->sg_max_nents)
1234                 hwif->sg_max_nents = PRD_ENTRIES;
1235
1236         hwif->sg_table = kmalloc(sizeof(struct scatterlist)*hwif->sg_max_nents,
1237                                  GFP_KERNEL);
1238         if (!hwif->sg_table) {
1239                 printk(KERN_ERR "%s: unable to allocate SG table.\n", hwif->name);
1240                 goto out;
1241         }
1242
1243         sg_init_table(hwif->sg_table, hwif->sg_max_nents);
1244         
1245         if (init_irq(hwif) == 0)
1246                 goto done;
1247
1248         old_irq = hwif->irq;
1249         /*
1250          *      It failed to initialise. Find the default IRQ for 
1251          *      this port and try that.
1252          */
1253         if (!(hwif->irq = ide_default_irq(hwif->io_ports[IDE_DATA_OFFSET]))) {
1254                 printk("%s: Disabled unable to get IRQ %d.\n",
1255                         hwif->name, old_irq);
1256                 goto out;
1257         }
1258         if (init_irq(hwif)) {
1259                 printk("%s: probed IRQ %d and default IRQ %d failed.\n",
1260                         hwif->name, old_irq, hwif->irq);
1261                 goto out;
1262         }
1263         printk("%s: probed IRQ %d failed, using default.\n",
1264                 hwif->name, hwif->irq);
1265
1266 done:
1267         init_gendisk(hwif);
1268         ide_acpi_init(hwif);
1269         return 1;
1270
1271 out:
1272         unregister_blkdev(hwif->major, hwif->name);
1273         return 0;
1274 }
1275
1276 static void hwif_register_devices(ide_hwif_t *hwif)
1277 {
1278         unsigned int i;
1279
1280         for (i = 0; i < MAX_DRIVES; i++) {
1281                 ide_drive_t *drive = &hwif->drives[i];
1282
1283                 if (drive->present) {
1284                         int ret = device_register(&drive->gendev);
1285
1286                         if (ret < 0)
1287                                 printk(KERN_WARNING "IDE: %s: "
1288                                         "device_register error: %d\n",
1289                                         __FUNCTION__, ret);
1290                 }
1291         }
1292 }
1293
1294 int ide_device_add_all(u8 *idx)
1295 {
1296         ide_hwif_t *hwif;
1297         int i, rc = 0;
1298
1299         for (i = 0; i < MAX_HWIFS; i++) {
1300                 if (idx[i] == 0xff)
1301                         continue;
1302
1303                 hwif = &ide_hwifs[idx[i]];
1304
1305                 if ((hwif->chipset != ide_4drives || !hwif->mate ||
1306                      !hwif->mate->present) && ide_hwif_request_regions(hwif)) {
1307                         printk(KERN_ERR "%s: ports already in use, "
1308                                         "skipping probe\n", hwif->name);
1309                         continue;
1310                 }
1311
1312                 if (ide_probe_port(hwif) < 0)
1313                         ide_hwif_release_regions(hwif);
1314         }
1315
1316         for (i = 0; i < MAX_HWIFS; i++) {
1317                 if (idx[i] == 0xff)
1318                         continue;
1319
1320                 hwif = &ide_hwifs[idx[i]];
1321
1322                 if (!hwif->present)
1323                         continue;
1324
1325                 if (hwif_init(hwif) == 0) {
1326                         printk(KERN_INFO "%s: failed to initialize IDE "
1327                                          "interface\n", hwif->name);
1328                         hwif->present = 0;
1329                         rc = -1;
1330                         continue;
1331                 }
1332         }
1333
1334         for (i = 0; i < MAX_HWIFS; i++) {
1335                 if (idx[i] == 0xff)
1336                         continue;
1337
1338                 hwif = &ide_hwifs[idx[i]];
1339
1340                 if (hwif->present) {
1341                         if (hwif->chipset == ide_unknown ||
1342                             hwif->chipset == ide_forced)
1343                                 hwif->chipset = ide_generic;
1344                         hwif_register_devices(hwif);
1345                 }
1346         }
1347
1348         for (i = 0; i < MAX_HWIFS; i++) {
1349                 if (idx[i] != 0xff)
1350                         ide_proc_register_port(&ide_hwifs[idx[i]]);
1351         }
1352
1353         return rc;
1354 }
1355 EXPORT_SYMBOL_GPL(ide_device_add_all);
1356
1357 int ide_device_add(u8 idx[4])
1358 {
1359         u8 idx_all[MAX_HWIFS];
1360         int i;
1361
1362         for (i = 0; i < MAX_HWIFS; i++)
1363                 idx_all[i] = (i < 4) ? idx[i] : 0xff;
1364
1365         return ide_device_add_all(idx_all);
1366 }
1367 EXPORT_SYMBOL_GPL(ide_device_add);