1 Sat Jul 10 01:06:05 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3 * gdk/x11/gdkwindow-x11.c (post_unmap): Fix a warning
4 * gdk/x11/gdkwindow-x11.c (show_window_internal): Actually unset
7 Sat Jul 10 00:37:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
11 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{un|re}set_bg):
12 New functions that can do a recursive unset/reset bg.
14 * gdk/x11/gdkgeometry-x11.c: Remove
15 gdk_window_tmp_{un|re}set_bg().
17 * gdk/x11/gdkwindow-x11.c (pre_unmap, post_unmap): New functions
18 called before and after unmapping a window. They unset the
19 background of all other windows to prevent flicker from the X
20 server repainting the background. post_unmap() also invalidates
21 the parent of the unmapped window to draw it without roundtrips.
23 * gdk/x11/gdkwindow-x11.c (show_window_internal): Unset
24 background of newly mapped windows and all desendants to prevent
27 Fri Jul 9 15:33:55 2004 Manish Singh <yosh@gimp.org>
29 * gdk/gdkevents.c: have a dummy case GDK_OWNER_CHANGE in switch
30 statements to avoid gcc warnings about not all enum values handled.
32 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): ignore should live in
35 Fri Jul 9 23:26:09 2004 Soeren Sandmann <sandmann@daimi.au.dk>
39 * gdk/x11/gdkwindow-x11.h (struct _GdkWindowImplX11): Add an
40 "override_redirect" bit.
42 * gdk/x11/gdkwindow-x11.c (gdk_window_new): Set it here.
44 * gdk/x11/gdkwindow-x11.c (gdk_window_move, gdk_window_resize,
45 gdk_window_move_resize):
46 Update the local size/position cache
47 immediately for override redirect windows.
49 * gdk/x11/gdkwindow-x11.c (show_window_internal): Invalidate
50 newly mapped child and override redirect windows.
52 2004-07-09 Federico Mena Quintero <federico@ximian.com>
56 * gtk/gtkfilesystemunix.c (get_fallback_icon): New helper
57 function, fetches a stock icon as a fallback.
58 (gtk_file_system_unix_volume_render_icon): Fall back to a stock
60 (gtk_file_system_unix_render_icon): Fall back to a stock icon.
61 Use helper functions rather than being a mega-function.
62 (get_icon_name_for_directory): Renamed from
63 get_icon_for_directory().
64 (get_icon_type_from_path): New helper function; code pulled out
65 from gtk_file_system_unix_render_icon().
66 (get_special_icon): Likewise.
67 (get_icon_for_mime_type): Likewise.
69 2004-07-09 Federico Mena Quintero <federico@ximian.com>
71 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Fix typo; tmp_event ->
74 2004-07-09 Matthias Clasen <mclasen@redhat.com>
76 * gtk/gtktooltips.c (gtk_tooltips_paint_window): Use the
77 requisition of the widget instead of relying on the style
78 drawing function to supply the size of the drawable. (#146531)
80 2004-07-09 Matthias Clasen <mclasen@redhat.com>
82 Make GtkEntry work harder to protect passwords: (#143955,
85 * gtk/gtkentry.c (gtk_entry_destroy): Add a destroy handler
86 to clear the password even if the widget is leaked.
88 * gtk/gtkentry.c (gtk_entry_real_delete_text):
89 * gtk/gtkentry.c (gtk_entry_finalize): Zero out the memory
92 * gtk/gtkentry.c (gtk_entry_real_insert_text): Zero and free
93 the old memory instead of just reallocating it.
95 * gtk/gtkentry.c (gtk_entry_create_layout): Don't leak text
96 direction information for passwords.
98 2004-07-09 Matthias Clasen <mclasen@redhat.com>
100 * gtk/gtkstyle.c: Fix some cases where style functions were
101 not handling widget == NULL properly. (#146282)
103 Thu Jul 8 22:38:58 2004 Matthias Clasen <maclas@gmx.de>
105 * gtk/gtktreeview.c: Improve the EXPANDER_MAX warning.
107 2004-07-08 Federico Mena Quintero <federico@ximian.com>
111 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Add a
112 GError argument. Do check for errors when getting the
113 GtkFileFolder: get the folder and read the children before
114 actually creating the model. Removed obsolete code that handled
115 roots-changed on the file system.
116 (file_model_node_get_info): Assert that we don't reach the old
117 case to display file system roots.
118 (roots_changed_callback): Removed.
120 * gtk/gtkfilechooserdefault.c (set_list_model): Add a GError
121 argument, and a boolean return value. Return an error if we
122 cannot create the file system model. On error, set a NULL model
124 (gtk_file_chooser_default_set_current_folder): Use the error value
125 from set_list_model().
126 (gtk_file_chooser_default_set_property): Set the show_hidden
127 property only if the browse_files_model exists.
128 (gtk_file_chooser_default_unselect_path): Only operate if the
129 browse_files_model exists.
130 (check_preview_change): Check whether we have the sort_model.
131 (change_folder_and_display_error): Copy the path we get passed
132 before using it. There's a comment in there that explains why we
133 need to copy it; basically, if the passed path belongs to the
134 model, the model may go away in the middle of this function and
135 we'll be left with a dangling pointer.
136 (install_list_model_filter): Assert that the model is not NULL.
137 (set_current_filter): Check whether the model exists.
139 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Don't
140 g_return_if_fail if the model is NULL.
141 (gtk_tree_selection_get_selected_rows): Likewise.
142 (gtk_tree_selection_count_selected_rows): Likewise.
143 (gtk_tree_selection_selected_foreach): Likewise.
144 (gtk_tree_selection_path_is_selected): Likewise; rather just
146 (gtk_tree_selection_select_all): Likewise.
147 (gtk_tree_selection_unselect_all): Likewise.
148 (gtk_tree_selection_select_range): Do g_return_if_fail() if the
150 (gtk_tree_selection_unselect_range): Likewise.
152 * gtk/gtkfilesystemunix.c (fill_in_names): Return immediately if
153 g_dir_open() fails: there is no need to set the error ourselves,
154 as g_dir_open() already does it.
156 2004-07-08 Matthias Clasen <mclasen@redhat.com>
158 * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Allow
159 to restore the default search function. (#145365, John Finlay)
161 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Don't leak
162 references to the drag context. (#144324, Alex Larsson)
164 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
166 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
167 when a new model is set. (#145566, Dmitry M. Shatrov)
169 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
171 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
172 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
173 in order to avoid rendering artifacts from misaligned
174 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
176 2004-07-07 Matthias Clasen <mclasen@redhat.com>
179 * gtk/gtktreeview.h: Small documentation fixes.
181 2004-07-07 Matthias Clasen <mclasen@redhat.com>
183 Support separators in combo boxes and more generally in tree
187 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
188 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
189 Add a ::row-separator-column property with getter and setter,
190 which can indicate a boolean model column to determine which
193 * gtk/gtkcombobox.c: Display separator rows as separator menu
194 items in menu mode, and by using the new treeview separator
195 functionality in list mode.
198 * gtk/gtktreeprivate.h:
199 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
200 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
201 Add a callback to determine whether a row is a separator.
203 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
204 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
205 * gtk/gtktreeview.c (validate_row): Use the new callback
206 to determine whether a row is a separator, and draw it
207 as a separator then. Since separators should take up less
208 vertical space than regular rows, this requires removing
209 the redundant MAX(...,expander_size) calls which appear in
210 many places. Instead, the MAX() is now only done in
211 validate_row(), and only if the row is not a separator.
212 To catch possible side effects of this intrusive change,
213 I have left EXPANDER_MAX() calls in place of the MAX() calls
214 which will emit a warning if something breaks. They should
215 be removed before 2.6.
217 * gtk/gtktreeselection.c (row_is_selectable): Don't let
218 separator rows be selected.
220 * tests/testcombo.c (create_blaat): Add a separator column.
222 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
224 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
225 a 64bit alignment issue. (#144302, Sunil)
227 2004-07-07 Tor Lillqvist <tml@iki.fi>
229 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
230 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
231 * gdk/win32/gdkproperty-win32.c (find_common_locale,
233 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
234 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
237 * gdk/win32/gdkglobals-win32.c
238 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
239 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
240 atom. Initialize it. Declare it. Drop the variable for the
243 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
244 function is supposed to return the string in the locale's charset
245 and encoding. Use g_convert().
247 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
248 string in the locale's charset. Use g_convert().
250 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
251 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
252 GLib's UTF-16 functions instead. Windows uses UTF-16.
254 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
255 functions mentioned above.
257 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
258 also if the string is of type STRING, i.e. ISO-8859-1, and the
259 current codepage is 1252, and contains no C1 chars. Accept
262 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
263 Mark as static. When storing STRING data, convert to
265 (gdk_selection_owner_set_for_display): Now that STRING is always
266 ISO-8859-1, use UTF8_STRING when sending the selection request
269 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
272 (gdk_text_property_to_text_list_for_display): Make work more like
273 X11 version. Do obey the encoding parameter.
275 (gdk_string_to_compound_text_for_display,
276 gdk_utf8_to_compound_text_for_display): Don't even pretend
277 supporting COMPOUND_TEXT.
279 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
281 (sanitize_utf8): Zero-terminate string.
283 2004-07-06 Matthias Clasen <mclasen@redhat.com>
285 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
286 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
288 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
289 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
290 fallbacks for gtkfilechooser. Currently these are the same images
291 as the "new" and "open" items...
293 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
295 Fix for #136496, Pawel Salek:
297 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
298 a node when it changes in fixed_height mode.
300 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
303 2004-07-06 Matthias Clasen <mclasen@redhat.com>
305 * gtk/gtkmenu.c (gtk_menu_position): Make sure
306 private->monitor_num is a valid monitor number before
307 using it. (#139187, Michael Natterer)
309 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
311 * gtk/gtkfilechooserdefault.c (popup_position_func):
312 * gtk/gtkentry.c (popup_position_func):
313 * gtk/gtktextview.c (popup_position_func): Improve positioning
314 of keyboard-activated menus with Xinerama.
316 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
318 * gtk/gtkuimanager.c (do_updates):
319 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
320 when called from an idle handler. (#145429, Jan-Marek Glogowski)
322 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
324 * gtk/gtkfilechooserutils.c (delegate_notify): Use
325 the less efficient g_object_interface_find_property () instead
326 of the param_id range check, since the GParamSpecs we're
327 dealing with are the overridden onces on the interface, whose
328 param_id is always zero. (#145312, Alex Roitman, fix proposed
331 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
333 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
334 virtual method of GtkContainer.
335 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
336 method slot of the container class.
338 2004-07-05 Anders Carlsson <andersca@gnome.org>
340 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
342 Use gint, not int in gtk_icon_view_set_markup_column,
345 2004-07-05 Anders Carlsson <andersca@gnome.org>
347 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
348 (gtk_icon_view_real_select_cursor_item),
349 (gtk_icon_view_real_activate_cursor_item):
351 Add an "activate_cursor_item" action signal
352 and bind it to the return key.
354 2004-07-04 Anders Carlsson <andersca@gnome.org>
356 * demos/gtk-demo/Makefile.am:
357 * demos/gtk-demo/gnome-fs-directory.png:
358 * demos/gtk-demo/gnome-fs-regular.png:
359 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
360 (sort_func), (create_store), (item_activated), (up_clicked),
361 (home_clicked), (do_iconview):
362 Add a simple file browser based on the icon view.
365 Add gtk/gtkiconview.h
367 * gtk/gtkiconview.c: (gtk_icon_view_layout),
368 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
369 Fix a few bugs discovered while writing the demo.
371 2004-07-04 Anders Carlsson <andersca@gnome.org>
376 Add GtkIconView to the build, remove debugging output.
378 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
380 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
381 (gtk_calendar_drag_data_received): Fix off-by-one error.
382 GDate month is one-based and GtkCalendar month is zero-based.
383 (#145134, William Jon McCann)
385 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
387 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
388 somebody tries to move a node after itself in a list of
389 length 1. (#145291, Sampo Nurmentaus)
391 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
393 * docs/faq/gtk-faq.sgml:
394 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
397 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
399 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
400 and current_height to 0 when ending the embedding. (#143675,
403 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
405 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
406 to the right end of the entry text, even if it ends in combining
407 marks. (#141728, Theppitak Karoonboonyanan)
409 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
411 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
412 row when unsetting the model. (#138560, Christian Persch)
414 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
416 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
419 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
421 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
422 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
424 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
426 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
427 to the event mask, set a scroll_event handler.
428 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
429 by switching tabs. (#145244, Gabriel de Perthuis)
431 2004-07-02 Anders Carlsson <andersca@gnome.org>
433 * gtk/gtktreeview.c (gtk_tree_view_set_model):
434 Make sure we check for a NULL model first.
436 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
438 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
439 win32 build problem w/o wintab. Fixed #145242
441 2004-06-30 Anders Carlsson <andersca@gnome.org>
443 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
444 g_return_if_fail to make sure that the model is a GtkTreeModel.
446 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
448 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
449 current state, not GTK_STATE_NORMAL
451 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
453 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
455 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
457 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
459 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
460 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
463 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
465 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
466 recursion by resetting icon_set->cache before freeing
467 the cache. (#144947, Tim Janik)
469 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
471 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
472 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
473 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
476 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
478 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
479 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
480 last change in the docs.
482 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
484 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
485 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
486 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
488 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
490 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
491 placement policy for GtkComboBoxEntry to be: if it fits below,
492 place below, if it fits above place above, else place in the
493 larger space and scroll so that the scroll arrow appear at the
494 far end. (#144362, David A. Knight)
496 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
498 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
499 use of &parent_iter. (#145007, John Finlay)
501 2004-06-25 Bastien Nocera <hadess@hadess.net>
503 reviewed by: Matthias Clasen <maclas@gmx.de>
505 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
506 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
507 the number of keysyms per keycode is odd. Fixes #144808.
509 2004-06-25 Matthias Clasen <mclasen@redhat.com>
511 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
512 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
514 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
516 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
517 which was mentioned below.
519 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
521 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
522 string change. (#139503, Baris Cicek)
524 2004-06-22 Federico Mena Quintero <federico@ximian.com>
526 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
527 or an Open stock button for the C-l dialog depending on the action
528 in which the file chooser operates. Fixes #141753.
530 2004-06-22 Federico Mena Quintero <federico@ximian.com>
532 Fixes the GTK+ part of #142308:
534 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
535 Use filename_to_path().
536 (gtk_file_system_unix_uri_to_path): Likewise.
537 (filename_to_path): Use remove_trailing_slash().
539 2004-06-22 Matthias Clasen <mclasen@redhat.com>
541 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
542 for the ::move_cursor signal.
544 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
545 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
548 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
549 this gets defined for all backends, so linux-fb has a
552 * gdk/x11/gdkgc-x11.c:
553 * gdk/gdkgc.c: Move function docs inline, add hints about
554 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
556 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
557 for children of the root. (#139785, Jean-François Wauthy,
558 patch by John Finlay)
560 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
561 fix. (#144750, Jeff Franks)
563 2004-06-21 Michael Natterer <mitch@gimp.org>
566 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
567 function public as _gdk_x11_convert_to_format().
569 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
570 the pixels from the GdkPixbuf when putting them in the
571 Xcursor image. Fixes bug #144350.
573 2004-06-16 Federico Mena Quintero <federico@ximian.com>
575 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
576 visible node, free the old path before creating the new one.
579 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
581 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
582 (#144198, Mariano Suárez-Alvarez)
584 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
586 * gtk/gtkfilechooserdefault.c: Don't use
587 contractions like "don't" or "isn't" in error messages.
588 It isn't nice to use them in log entries either...
589 (#137774, Morten Welinder, patch by Alexander Winston)
591 2004-06-11 Federico Mena Quintero <federico@ximian.com>
595 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
596 Don't ref the editable node.
597 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
598 (_gtk_file_system_model_remove_editable): Ahem, free the node.
600 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
601 Added fields for edited_idle and edited_new_text.
602 (renderer_edited_cb): Queue the
603 creation of the folder in an idle handler.
604 (renderer_editing_canceled_cb): Likewise for the cancellation.
605 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
607 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
609 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
611 2004-06-10 Federico Mena Quintero <federico@ximian.com>
613 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
615 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
616 Refer to gtk_file_chooser_add_shortcut_folder().
617 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
618 gtk_file_chooser_add_shortcut_folder_uri().
620 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
622 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
623 the drag before focusing the selected.day.
624 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
625 a beginning drag if the widget becomes insensitive.
627 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
629 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
630 spinning before calling arrow_action(), so that a signal
631 handler triggered from arrow_action() has a chance to
632 stop the spinning. (#143966, Davyd Madeley)
634 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
636 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
637 typo. (#144070, Kent Sandvik)
639 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
641 * gtk/gtkmenu.c: Revert the "drag select" part of
644 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
646 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
647 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
649 2004-06-07 Federico Mena Quintero <federico@ximian.com>
651 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
652 from 2003/Sep/12. This kept DnD in tree views within modal
653 dialogs from working, which is especially bad for the file
654 chooser. Fixes #135168.
656 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
658 Make the entry context menu work in editable text cells. The changes
659 are based on a patch by Kristian Rietveld, which implemented an
660 approach outlined by Owen Taylor. (#50075)
662 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
663 Ignore focus out if the entry menu is posted.
664 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
665 posted, and set up a signal handler to clear the flag if the menu
667 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
668 set up a timeout to stop editing if the focus is lost.
669 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
670 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
671 signal on the entry and keep a pointer to the entry.
672 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
673 clear the pointer to the entry.
675 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
677 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
678 of the ::language property. (#143802, Owen Taylor)
680 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
682 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
683 (gtk_entry_completion_list_enter_notify),
684 (gtk_entry_completion_list_motion_notify),
685 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
686 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
687 use it as in the menu code to avoid the initial selection if
688 the window pops up under the pointer. (Anders Carlsson)
690 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
692 * tests/testmerge.c: Add a checkbox to queue an
693 merge/unmerge. Patch from Matthias Clasen.
695 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
697 (rebuild_menu): New function that rebuilds the overflow menu and
698 makes sure it doesn't start or end with a separator.
699 (toolbar_content_new_tool_item)
700 (toolbar_content_remove)
701 (toolbar_content_new_compatibility): Set the rebuild_needed flag
702 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
703 have actually overflown an item with a proxy menu item. Also make
704 sure we rebuild the menu if needed.
706 Fix #125504, #142377, #143463
708 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
709 Obey the "priv->draw" flag. (#143692)
711 2004-06-04 Matthias Clasen <mclasen@redhat.com>
713 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
714 quirk in the button size allocation code.
716 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
717 requested for drawing the focus indicator to the child in the
718 !CAN_FOCUS case. This should fix issues which the Gimp has with
719 the button allocation changes in 2.4.2.
721 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
723 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
724 length of the entry contents in characters, not in bytes.
726 * gtk/gtkentry.c (paste_received): Don't pop up the completion
727 window on paste, noticed by Anders Carlsson.
729 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
731 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
732 values and default value for the ::active property. (#143669,
735 2004-06-03 Michael Natterer <mitch@gimp.org>
737 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
738 instead of accessing item->image->allocation.width/height
739 directly. Makes widgets which only have a requisition set using
740 gtk_widget_set_size_request() work and fixes bug #142789.
742 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
744 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
745 of sticky right click menus to return.
747 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
749 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
750 better handle the "click" case. bug Better fix for #141169.
752 2004-06-02 Federico Mena Quintero <federico@ximian.com>
754 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
755 model is empty. Fixes #143536.
757 2004-06-02 Matthias Clasen <mclasen@redhat.com>
759 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
760 close the dialog on focus out of the size entry. (#143505,
763 2004-06-02 Federico Mena Quintero <federico@ximian.com>
767 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
768 (gtk_fnmatch_intern): Likewise; also implement this option.
770 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
772 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
773 no_leading_period argument of _gtk_fnmatch().
774 (attempt_file_completion): Likewise.
776 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
777 no_leading_period argument of _gtk_fnmatch().
779 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
781 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
784 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
786 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
787 allow unless selection mode is multiple. (#142634, John Finlay)
789 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
793 * gtk/gtkentrycompletion.h:
794 * gtk/gtkentrycompletion.c:
796 * gtk/gtkcombobox.c: Rename function parameters from
797 index to index_ to prevent clash with BSD index(). (#143001)
799 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
801 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
802 NULL on an accel label. (#139641, Sam Stephenson, patch by
805 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
807 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
808 lookup finding icons in the wrong prefix. (#143328,
811 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
815 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
816 only stay up if you release within 500 milliseconds.
817 (gtk_menu_shell_button_press): Set the activate_time to the event
818 time when a button is pressed.
820 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
821 Interprete button releases as activate when we have seen both an
822 enter an a motion event.
824 2004-06-01 Federico Mena Quintero <federico@ximian.com>
826 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
827 dummy node if there is no parent node. Fixes #143362.
829 2004-05-31 Federico Mena Quintero <federico@ximian.com>
831 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
832 newly-created folder. Fixes #138932.
833 (trap_activate_cb): Only return TRUE if we did handle the event.
834 Fixes #143359; patch by jylefort@brutele.be.
836 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
838 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
839 docs. (#142892, Tommi Komulainen)
841 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
843 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
844 parent is minimized, porting the fix from 1.2. (#1923, #57182)
846 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
848 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
849 unmapped windows work.
851 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
853 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
856 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
858 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
859 Refer to ::update-preview, not ::selection-changed.
861 2004-05-29 Christian Rose <menthos@menthos.com>
863 * configure.in: Added "tk" to ALL_LINGUAS.
865 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
867 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
868 messages for common problems. (#137974, Owen Taylor)
870 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
872 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
873 errors. (#143337, Billy Biggs)
875 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
877 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
878 bits within visual->depth that aren't used for color to
879 1s, in case they are alpha.
881 2004-05-27 Anders Carlsson <andersca@gnome.org>
883 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
884 Make separator rows insensitive.
886 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
888 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
891 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
893 * gtk/gtkentrycompletion.h:
894 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
895 Getter for text_column. Also make ::text_column a property.
897 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
899 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
901 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
903 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
904 signal if the box exists.
906 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
908 Support insensitive cells in tree views and combo boxes:
910 * gtk/gtkcellrenderer.h:
911 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
913 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
914 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
915 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
916 Support drawing insensitive.
919 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
920 function to obtain the cell renderers from a cell view. Also
921 export gtk_cell_view_set_cell_data().
923 * gtk/gtktreeselection.c (tree_column_is_sensitive):
924 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
925 to determine whether all visible cells in a row are insensitive
926 and whether a row is selectable. A row is not selectable if the
927 user function says so or if all visible cells are insensitive.
928 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
929 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
930 Use row_is_selectable().
932 * gtk/gtkcombobox.c (row_is_sensitive):
933 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
934 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
935 to determine row sensitivity in menu or list mode.
937 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
938 to set up sensitivity menu items from the underlying rows.
940 * gtk/gtkcombobox.c (gtk_combo_box_popup):
941 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
942 update_menu_sensitivity().
944 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
947 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
950 * tests/testcombo.c (main): Make some rows insensitive.
952 2004-05-26 Robert Ögren <gtk@roboros.com>
954 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
955 modifiers (shift, ctrl etc) in button and motion events from the
958 2004-05-26 Robert Ögren <gtk@roboros.com>
960 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
961 implementation for extended input devices using last known
962 device state (#143237)
964 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
966 * gtk/gtkframe.c: Move docs inline, fixing them on the
967 way. (#143029, Steve Chaplin)
969 2004-05-11 Robert Ögren <gtk@roboros.com>
971 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
972 events to windows that want extended input events. (#142943)
973 (gdk_event_translate): Move check for extended input devices to
974 propagate, new parameter to propagate.
975 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
976 _gdk_input_(un)grab_pointer. (#142943)
978 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
979 input grab. [Fix missing update of impl in "dijkstra" event
980 propagation loop] Drop the parallel "impl" pointer, just use a
981 cast. Don't propagate beyond windows that want normal input
983 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
984 implementation of input grab. (#142943)
986 2004-05-22 Tor Lillqvist <tml@iki.fi>
988 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
989 line. (Spotted by Benoît Carpentier.)
991 2004-05-18 Matthias Clasen <mclasen@redhat.com>
993 * configure.in: Check for XFIXES extension.
995 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
996 a gboolean have_xfixes member.
998 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
999 XFIXES events and set have_xfixes.
1001 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
1002 (GdkEventOwnerChange): New event struct for owner change events.
1003 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
1005 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
1006 XFixesSelectionNotify events into GdkEventOwnerChange events.
1009 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
1010 (gdk_display_request_selection_notification): New api
1011 to support selection ownership notification.
1013 * gtk/gtkclipboard.h:
1014 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
1015 api to handle owner change events.
1016 (clipboard_peek): Refactored out the body of
1017 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
1019 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
1020 by calling _gtk_clipboard_handle_event().
1022 2004-05-18 Matthias Clasen <mclasen@redhat.com>
1024 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
1025 the P_() macros ourselves.
1027 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1028 Restrict the width of the popup to be no larger than the
1029 monitor. (#142678, DmD Ljungmark)
1031 * gtk/gtkbutton.c: Go back to the initial fix for the
1032 focus-overdrawing problem, which was actually correct
1033 according to docs/widget_geometry.txt.
1035 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
1036 arrow size from 11 to 15 to compensate for that.
1038 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
1039 arguments of the ::move-cursor signal. (#142725)
1041 2004-05-17 Matthias Clasen <mclasen@redhat.com>
1045 * gtk/gtkbutton.c (gtk_button_size_request)
1046 (gtk_button_size_allocate, _gtk_button_paint): Allocate
1047 space for the focus rectangle only if necessary. (#142668,
1050 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
1054 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
1055 lines. (#142479, Morten Welinder)
1057 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
1059 * gtk/gtkintl.h (Q_): Add a Q_() macro.
1061 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
1062 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
1063 they are not really needed.
1065 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
1066 instead of hardwired padding, use Q_() for the default label,
1067 compute a reasonable minimal size. (#142571, #142572, #142573,
1068 Tommi Komulainen, Christian Persch)
1070 2004-05-15 Tor Lillqvist <tml@iki.fi>
1072 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
1073 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
1074 time). It is used by the OLE2_DND code, which is unfinished and
1075 presumably horribly broken, but still, let's not make it not
1076 compile on purpose. Silence some gcc warnings in the OLE2_DND
1079 2004-05-14 Matthias Clasen <mclasen@redhat.com>
1081 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
1082 New function to go from tree window to tree coordinates, kept
1083 static for now until we figure out the multiple coordinate
1084 system mess in GtkTreeView API-wise.
1085 (gtk_tree_view_scroll_to_cell): Transform the coordinates
1086 from tree window to tree coordinates, using the new function.
1087 Previously, the x coordinate was wrongly transformed. (#142494)
1089 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
1092 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
1093 modifier bit to mark stock item which need to be freed
1094 eventually. (#140654, Michal Pasternak, Scott Tsai)
1096 2004-05-11 Robert Ögren <gtk@roboros.com>
1098 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
1099 call to g_object_ref in Wintab code. (#138341)
1101 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
1102 including unallocated buffers for event->motion.axes and
1103 event->button.axes, unsigned wraparound problem in the code for
1104 detecting missing press/release events and assigning min instead
1105 of max when setting up axes.
1107 2004-05-12 Matthias Clasen <mclasen@redhat.com>
1109 * tests/testtreeedit.c: Add a progress column.
1111 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
1114 * gtk/gtk.h: Include gtkcellrendererprogress.h.
1116 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
1117 based on the one found in Epiphany.
1119 2004-05-11 Michael Natterer <mitch@gimp.org>
1121 * gtk/gtkcombobox.c (gtk_combo_box_popup)
1122 (gtk_combo_box_menu_button_press): don't allocate the popup
1123 smaller than the combobox. Fixes bug #59660.
1125 2004-05-11 Matthias Clasen <mclasen@redhat.com>
1127 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
1128 previous change to this function, clarify the docs instead.
1130 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
1131 GTK_SELECTION_BROWSE.
1133 * gtk/gtktreeview.c: Make hover selection work for
1134 GTK_SELECTION_BROWSE as well.
1136 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
1138 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
1139 Document the ::toggled signal.
1141 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1143 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
1145 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1147 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
1149 * gdk/gdkdisplay.c (singlehead_...):
1150 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
1151 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
1152 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
1154 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
1155 note about COLUMN_FIXED restriction.
1157 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
1158 Set the entry in the default handler of the ::match-selected signal.
1161 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
1162 do the move-selected-item below pointer thingie, do the
1163 place-below-or-above one.
1165 * tests/testentrycompletion.c: Make the second example use the
1166 ::match-selected signal to make it actually work.
1168 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
1169 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
1170 mode. (#127648, Dave Bordoley)
1172 * gtk/gtktreeview.h:
1173 * gtk/gtktreeview.c: Add a new property "hover_selection", which
1174 when TRUE makes the selection follow the mouse. Also add setter
1175 and getter for the fixed_height property.
1177 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1179 * gtk/gtkcombobox.c (gtk_combo_box_popup)
1180 (gtk_combo_box_menu_button_press): Make sure the menu pops up
1181 as wide as the combobox. (#59660, Havoc Pennington)
1183 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1185 * gtk/gtkcombobox.h:
1186 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
1187 mode). Add a new property, add-tearoffs, for this. (#135956)
1189 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
1190 default button. (#118921)
1192 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1194 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
1195 that emits the grab notify signal.
1197 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
1199 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
1201 * gtk/gtkmenu.c: Make destruction of a torn off menu work
1202 like un-tearing off.
1204 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
1208 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1209 Allow to suppress the stock accelerator by using "". (#142196,
1212 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
1216 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
1217 In list mode, accept the same mouse/wheel bindings on
1218 the cellview as on the button. (#136967)
1220 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
1222 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
1223 cached icons. (#135888, Crispin Flowerday)
1225 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
1227 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
1228 that we actually return menus for nodes of type menu, not the
1229 menuitems they're attached to.
1231 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
1233 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
1234 Add a note regarding UTF-8 requirements, proposed by
1235 Mariano Suárez-Alvarez.
1237 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
1239 * gtk/gtktearoffmenuitem.h:
1240 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
1241 into the GtkTearoffMenuItem struct, since it is used
1242 by the Gimp, and keep it synchronized with the
1243 tearoff_state property of the parent menu.
1245 2004-05-08 Hans Breuer <hans@breuer.org>
1247 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
1248 create the correct mask for 'pseudo mime' icons
1250 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
1251 take focus_on_map into account
1253 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
1255 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
1256 ... must return a value
1258 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
1260 2004-05-07 Matthias Clasen <mclasen@redhat.com>
1262 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
1263 draw over the focus rectangle.
1265 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
1266 standard focus style. (#63071, Bill Haneman, idea for new
1267 style by Owen Taylor)
1269 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
1270 focus on the colorwheel via details.
1272 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1276 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
1277 this no longer needed signal handler. (#141817, Paul Pogonyshev)
1279 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
1281 * gtk/gtktearoffmenuitem.h:
1282 * gtk/gtktearoffmenuitem.c: Make the tearoff
1283 functionality model/view, the tearoffmenuitem being
1284 the view and the tearoff_state property of the menu
1285 being the model. (#101185, Owen Taylor)
1287 * gtk/gtkmenu.c: Add a tearoff_state property.
1289 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
1293 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
1294 popup the submenu for items in torn off menus. (#122051)
1296 2004-05-06 Sven Neumann <sven@gimp.org>
1298 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
1299 position the title lable next to the arrow just as we do for LTR
1300 rendering. Fixes bug #141825.
1302 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1304 * docs/RELEASE-HOWTO: Document the new policy of
1305 bumping version numbers after release.
1307 * configure.in: Bump version number to 2.5.0.
1309 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
1312 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
1315 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
1317 * gtk/gtkactiongroup.h:
1318 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
1319 New function to translate a string with translate_func.
1322 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
1324 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
1325 (gtk_combo_box_get_row_span_column):
1326 (gtk_combo_box_get_column_span_column): Add missing getters
1327 for readwrite properies. (#135649)
1329 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
1331 * gtk/gtkcombobox.h:
1332 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
1333 Add gtk_combo_box_get_active_text() convenience
1334 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
1336 2004-05-05 Elijah Newren <newren@math.utah.edu>
1338 Changes to support do-not-focus-on-map hint in conjunction with
1339 _NET_WM_USER_TIME (#115650):
1341 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
1344 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
1347 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
1348 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
1350 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
1351 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
1352 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
1353 Initialize the focus_on_map field to TRUE.
1355 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
1356 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
1357 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
1358 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
1359 Implementations for the various backends. The Win32 and linux-fb
1360 implementations set the focus_on_map field, but don't use it yet
1361 to actually implement noinput windows. The X implementation sets
1362 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
1364 * gdk/x11/gdkwindow-x11.h:
1365 * gdk/x11/gdkevents-x11.c (set_user_time):
1366 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1367 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
1368 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
1369 since we want that function to be part of the public API.
1371 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
1375 * gtk/gtkiconfactory.c (icon_source_clear): Don't
1376 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
1378 2004-05-05 Matthias Clasen <mclasen@redhat.com>
1382 * gtk/gtkuimanager.c (print_node): Make the output
1383 parseable. (#141929, Sven Neumann)
1385 2004-05-05 Tor Lillqvist <tml@iki.fi>
1387 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
1388 multi-monitor offset. (#141842, John Ehresman)
1390 2004-05-04 Federico Mena Quintero <federico@ximian.com>
1392 Fixes #139562, based on a patch by Christian Neumair.
1394 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
1395 a filter_combo_hbox field to contain the filter combo.
1396 (show_filters): Show/hide the filter_combo_hbox.
1397 (create_filename_entry_and_filter_combo): Removed.
1398 (file_pane_create): Create the filter_combo_hbox here.
1400 2004-05-04 Matthias Clasen <mclasen@redhat.com>
1402 * modules/input/gtkimcontextxim.c: Fix the recent
1403 string_conversion_callback change to work on
1404 Solaris. (#141190, Padraig O'Briain)
1406 * gtk/gtkselection.c: Disable debug logging again.
1408 2004-05-03 Matthias Clasen <mclasen@redhat.com>
1410 * gtk/gtkselection.c: Make the chunk size for
1411 incremental transfers depend on the maximal request
1412 size, capped at 256k. This should allow most selections
1413 to be transferred nonincrementally, avoiding many
1414 roundtrips and protocol overhead.
1416 2004-05-03 Federico Mena Quintero <federico@ximian.com>
1418 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
1419 g_signal_new() correctly and initialize the signal fields. Fixes
1420 #141749; patch based on Michael Natterer's.
1422 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
1424 * gtk/gtkselection.c (_gtk_selection_request): Fix
1425 a debug message to show correct information.
1426 (_gtk_selection_incr_event): Make INCRemental transfer
1427 of MULTIPLE targets work. This was broken since 1997!
1429 2004-05-02 Hans Breuer <hans@breuer.org>
1431 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
1432 modify the passed in GdkSegment(s) in place, we may get
1433 them again to draw at the same place. Fixes bug #129095,
1435 (draw_segments) draw the end pixel again to get the
1436 pixmap mask right, fixes bug #126710, #130202
1438 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
1439 fixes bug #106013, John Ehresman
1441 * gtk/makefile.msc.in : don't try to link gtk.res but
1442 use gtk-win32.res (as supposed to be fixed below :)
1444 2004-05-01 Hans Breuer <hans@breuer.org>
1446 * tests/Makefile.am : tests/makefile.msc is in CVS for
1447 a long time, finally added to EXTRA_DIST : fixes bug
1448 #141334, John Ehresman
1450 2004-04-30 Matthias Clasen <mclasen@redhat.com>
1452 * === Released 2.4.1 ===
1454 * configure.in: Version 2.4.1, interface age 1.
1458 2004-04-29 Federico Mena Quintero <federico@ximian.com>
1462 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
1463 function; moved the code over from
1464 remove_bookmark_button_clicked_cb().
1465 (remove_selected_bookmarks): Now, getting a non-removable bookmark
1466 is not an error, as we may be called as a result of hitting the
1468 (shortcuts_key_press_event_cb): New handler; delete the bookmark
1469 if the user presses Backspace, Delete, or KP_Delete.
1471 2004-04-29 Matthias Clasen <mclasen@redhat.com>
1473 * gtk/gtkaction.c (closure_accel_activate): Use
1474 _gtk_action_emit_activate() instead of directly
1475 emitting the activate signal. (#141429, Jody Goldberg)
1477 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1478 Warn people when the accelerator can not be
1479 parsed. (#141429, Jody Goldberg)
1481 2004-04-29 Matthias Clasen <mclasen@redhat.com>
1483 * tests/testentrycompletion.c (main): Add a missing
1484 cat. (#141070, Chris Sherlock)
1486 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
1487 variable. (#141022, Chris Sherlock)
1489 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
1490 cast. (#141013, Chris Sherlock)
1492 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
1493 unused variable. (#141011, Chris Sherlock)
1495 2004-04-29 Tor Lillqvist <tml@iki.fi>
1497 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
1498 leak. (#140775, John Ehresman)
1500 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
1502 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
1503 to index the cached gcs, not depth. (#139494)
1505 2004-04-28 Matthias Clasen <mclasen@redhat.com>
1507 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
1509 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1511 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
1512 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
1514 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
1516 Patch to add support for string conversion callbacks to
1517 GtkIMContextXIM (#101814)
1519 * modules/input/gtkimcontextxim.c: Set the string conversion callback
1520 if supported by the XIC.
1522 (struct _GtkIMContextXIM): Add string_conversion_callback member.
1524 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
1525 whether string conversion callback is supported.
1527 (gtk_im_context_get_ic, +set_string_conversion_callback,
1528 +string_conversion_callback): Also initialize string conversion
1529 callback, if supported, along with the IC initialization.
1531 * modules/input/imxim.c: Make "xim" module default for Thai as well.
1533 2004-04-23 Matthias Clasen <mclasen@redhat.com>
1535 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
1536 initialize targets. (#139883, John Finlay)
1538 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
1540 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
1541 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
1542 Tim-Philipp Müller)
1544 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
1545 Remove an excessive g_return_if_fail().
1547 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
1549 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1550 _-prefix calls of gdk_x11_window_set_user_time().
1552 2004-04-22 Matthias Clasen <mclasen@redhat.com>
1554 * gtk/gtkuimanager.c (update_node): Make sure the separators
1555 used to demarkate placeholder ends don't show up on
1556 show_all(). (#140496, Murray Cumming)
1558 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
1559 work with negative increments. (#137975, Tim Gerla)
1561 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1563 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
1564 gtk_tool_button_set_icon_widget): Remove the old widget from the
1565 tool button before overwriting it with the new widget.
1567 (#140508, Todd Goyen)
1569 2004-04-22 Tor Lillqvist <tml@iki.fi>
1571 Fix the file chooser on Windows. I can't make it misbehave or
1572 crash any more now. But presumably there are still corner cases
1573 not handled. I haven't really checked behaviour of UNC paths, for
1576 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
1577 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
1580 (gtk_file_system_win32_get_parent): Like the Unix version, assert
1581 filename is absolute, and avoid one unnecessary string allocation
1584 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
1585 letters more correctly.
1587 (gtk_file_system_win32_render_icon): Assure correct syntax is used
1588 for root folder of a drive. (#137962, Morten Welinder)
1590 (filename_is_some_root): New function that accepts also root
1591 without any drive specified.
1593 (filename_is_drive_root): Rename from filename_is_root.
1595 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
1598 2004-04-21 Matthias Clasen <mclasen@redhat.com>
1600 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
1601 completion window if there are no completions anymore.
1603 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1604 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
1605 It doesn't like that. (#140642, Christian Persch)
1607 * demos/gtk-demo/expander.c (do_expander): A new demo.
1609 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
1611 2004-04-20 Matthias Clasen <mclasen@redhat.com>
1613 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
1614 sure anchored children get size allocated, even if the layout
1615 is valid. (#122323, Andrew E. Makeev)
1616 (gtk_text_view_scroll_pages):
1617 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
1618 if we already have pending scrolls. Bandaid fix for #78513.
1620 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
1622 * INSTALL.in: Update libpng and libjpeg URLs, remove
1623 note about building without since that's not the normal
1626 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
1628 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
1629 handling of SVG/non-SVG unthemed icons.
1631 2004-04-19 Morten Welinder <terra@gnome.org>
1633 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
1636 2004-04-19 Matthias Clasen <mclasen@redhat.com>
1638 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1639 Don't stop the iteration up to the tag_root too
1640 early. (#109945, Dongho Shin)
1642 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1644 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
1645 gdk_keymap_translate_keyboard_state() handle NULL
1646 keymaps. (#139715, Torsten Schoenfeld).
1648 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1650 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
1651 reported by Pedro RODRIGUEZ, about compilation problems when
1652 Xcursor is installed in a non-standard location.
1654 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1656 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
1659 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
1660 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
1662 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
1664 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
1667 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
1668 property on user interaction.
1670 2004-04-15 Federico Mena Quintero <federico@ximian.com>
1672 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
1673 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
1675 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
1676 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
1679 2004-04-15 Matthias Clasen <mclasen@redhat.com>
1681 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1682 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
1684 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1686 * gtk/gtkcombobox.c:
1688 Make all style properties readonly.
1690 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1692 * gtk/gtkcolorsel.c: Add a11y relations between the color
1693 wheel and the spin buttons. (#132745, Padraig O'Briain)
1695 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
1696 the meaning of size == -1.
1698 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
1699 a size of -1. (#137436, Brian Cameron)
1701 * gtk/gtkcombobox.c: Make the arrow and separator regular
1702 children of an hbox inside the button, and propagate state
1703 changes from the button to the cell view. (part of the fix
1704 for #138650, should also fix #137535)
1706 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
1707 state to gtk_cell_renderer_render() when prelighted. (part
1708 of the fix for #138650)
1710 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1711 Use PRELIGHT state when appropriate. (part of the fix for
1714 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
1715 out warnings if called before the combo box is
1716 realized. (#139742, Philip Langdale)
1718 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
1720 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
1723 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
1725 * gtk/gtkpathbar.c (make_directory_button): remove spurious
1728 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
1730 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
1731 make the buttons sized by a bold label. This makes the text
1732 'swim' a little, but stops the buttons from resizing, #137210
1734 2004-04-13 Matthias Clasen <mclasen@redhat.com>
1736 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
1738 (start_element_handler): Accept separators without unique
1739 names. (#133302, Anders Carlsson)
1741 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
1742 possible accelerator gotcha when using this function. (#139641,
1745 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
1746 list nodes. (#138862, Morten Welinder)
1748 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
1750 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
1752 (gtk_tree_view_button_press): If we activated the row we don't
1753 want to grab focus back, as moving focus to another widget is
1754 pretty common, #138458
1756 2004-04-12 Federico Mena Quintero <federico@ximian.com>
1758 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
1759 documentation to all the signals.
1761 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
1763 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
1764 model if it is NULL. (#139770)
1766 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
1768 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
1769 a shadow inside the scrolled window, add it around the vbox.
1771 * gtk/gtkentryprivate.h:
1772 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1773 Return a boolean indicating whether the popup is positioned above
1774 or below. Scroll the completions to the beginning or the end,
1775 depending on the positioning.
1777 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
1778 wrap around in the entry completion popup, and allow GDK_UP to
1779 enter the popup. (#137440)
1781 2004-04-12 Matthias Clasen <mclasen@redhat.com>
1783 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
1784 there before using it.
1786 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
1788 * gtk/gtktreeprivate.h: Moved search entries into priv data.
1790 * gtk/gtktreeview.c: Prep for type-ahead support.
1792 (gtk_tree_view_destroy): Destroy the search window explicitly.
1793 (gtk_tree_view_key_press): Minor change; prep for type-ahead
1794 (gtk_tree_view_ensure_interactive_directory): New function
1795 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
1796 (gtk_tree_view_real_start_interactive_search): rework
1797 (gtk_tree_view_search_dialog_hide): ditto
1798 (gtk_tree_view_search_delete_event): ditto
1799 (gtk_tree_view_search_button_press_event): ditto
1800 (gtk_tree_view_search_key_press_event): ditto
1801 (gtk_tree_view_search_move): ditto
1802 (gtk_tree_view_search_init): ditto
1804 * gtk/gtktreeviewcolumn.c:
1805 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
1807 * tests/testfilechooser.c: (main): change
1809 2004-04-11 Hans Breuer <hans@breuer.org>
1811 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
1812 the real fix would involve just another small API breakage,
1813 i.e. gdk_spawn_* using GPid not just gint.
1815 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
1817 2004-04-10 Tor Lillqvist <tml@iki.fi>
1819 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
1820 If both Shift and CapsLock pressed, ignore the shift only for
1821 letters (that would have been affected by the CapsLock). (#139095)
1823 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
1824 seems to be even buggier now than it used to be. (#138341)
1825 Initialize _gdk_input_ignore_wintab to TRUE.
1827 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
1828 GDK_USE_WINTAB environment variable to turn on tablet support.
1830 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
1832 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
1833 (gtk_ui_manager_remove_action_group): Terminate
1834 g_object_[dis]connect() calls with NULL instead of 0.
1837 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
1839 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
1841 2004-04-07 Federico Mena Quintero <federico@ximian.com>
1845 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
1846 passed-in 'str' is not NULL.
1848 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
1849 expands "~/" or "~foo/" at the beginning of a filename.
1850 (gtk_file_system_unix_parse): Use expand_tilde() before doing
1853 * gtk/gtkfilechooserentry.c
1854 (gtk_file_chooser_entry_maybe_update_directory): Take in a
1855 force_reload argument.
1856 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
1857 returns an error, set the file_part_pos to -1.
1858 (load_directory_callback): Only populate the model if the
1859 file_part_pos is not -1.
1861 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
1863 * configure.in: Added Icelandic (is) to ALL_LINGUAS
1865 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1867 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
1868 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
1870 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
1871 for G_DIR_SEPARATOR in the display_name, and err out if it is
1872 present; use the same error message as Nautilus. Fixes #136467.
1874 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
1875 new-folder button say "Create Fo_lder" rather than "Create
1876 _Folder", so that the mnemonic doesn't conflict with the "Save in
1877 _folder" label. Fixes #136975.
1879 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1881 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
1882 buttons. Also, free them correctly upon failure. Based on a
1883 patch by Morten Welinder, fixes #137956.
1885 2004-04-05 Anders Carlsson <andersca@gnome.org>
1887 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
1889 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
1891 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
1892 correctly for fixed height when inserting a node, #138082
1894 2004-04-01 Federico Mena Quintero <federico@ximian.com>
1898 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
1899 "child_is_hidden" boolean argument to the "path-clicked" signal.
1901 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
1903 (make_directory_button): Take a file_is_hidden argument; put it in
1905 (_gtk_path_bar_set_path): See whether each path component path is
1907 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
1908 "path-clicked" signal.
1909 (button_clicked_cb): See if the downwards button represents a
1910 hidden file for the file_is_hidden argument in the signal
1913 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
1915 * gtk/gtkfilechooserdefault.c
1916 (gtk_file_chooser_default_select_path): If we fail to switch
1917 folders, don't try to select the path in the file system model.
1918 Also, return the result from _gtk_file_system_model_path_do().
1919 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
1920 file system model if we are asked to select a hidden file.
1921 (path_bar_clicked): Show hidden files based on whether the
1922 immediate downwards folder in the path bar is a hidden file
1924 (struct _GtkFileChooserDefault): Added fields
1925 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
1926 (create_file_list): Set an object data key of
1927 "GtkFileChooserDefault" on the tree view so that we can find the
1928 impl from the popup menu callbacks. Also, hook up to the
1929 "button-press-event" and "popup-menu" signals in the file list to
1930 bring up a popup menu.
1931 (list_popup_menu_cb): New callback.
1932 (list_button_press_event_cb): New callback.
1936 * gtk/gtkfilesystemmodel.c
1937 (_gtk_file_system_model_new): Oops, connect_object to
1940 2004-03-31 Tor Lillqvist <tml@iki.fi>
1942 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
1943 for native Win32. (#136559, J. Ali Harlow)
1945 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
1946 angles. Thanks to Tim Newsham.
1948 2004-03-29 Federico Mena Quintero <federico@ximian.com>
1952 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1953 for an ::is_finished_loading() method and a ::finished_loading()
1954 signal at the end of the struct.
1956 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1957 "finished-loading" signal.
1958 (gtk_file_folder_is_finished_loading): New function.
1960 * gtk/gtkfilesystemunix.c
1961 (gtk_file_folder_unix_is_finished_loading): Implement.
1963 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1964 slot for a "finished-loading" signal.
1965 (gtk_file_system_model_class_init): Create the "finished-loading"
1967 (struct _GtkFileSystemModel): New field
1968 idle_finished_loading_source. We emit the "finished-loading"
1969 signal in an idle if the root folder was done loading right in
1970 _gtk_file_system_model_new(), so that the caller has a chance to
1971 connect to the signal.
1972 (_gtk_file_system_model_new): Connect to the normal signals of the
1973 folder even if the initial _list_children() fails. Also, see if
1974 the folder is finished loading; connect to the "finished-loading"
1976 (gtk_file_system_model_finalize): Remove the idle handler.
1978 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1979 and connect to the model's "finished-loading" signal.
1980 (get_toplevel): New helper function.
1981 (error_message): Use get_toplevel().
1982 (trap_activate_cb): Likewise.
1983 (location_popup_handler): Likewise.
1984 (set_busy_cursor): New function.
1985 (browse_files_model_finished_loading_cb): New callback.
1987 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1989 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
1990 file under the cursor; we don't need the logic from
1991 GtkFileSelection after all. Fixes #132255.
1993 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1995 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
1996 location entry with the display name of the file under the cursor
1997 for Open mode, or the typed filename in Save mode.
1999 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2001 * gtk/gtkfilesystemwin32.c
2002 (filename_is_root): Bare drive designators (eg., "c:") are
2003 no longer considered as root filenames. Fixed #137942
2005 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2007 * gtk/gtkfilesystemwin32.c
2008 (gtk_file_system_win32_create_folder): Invert test for error in
2009 mkdir. Fixes #137945
2011 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2013 Fixed #138004 using Federico's code from #132327.
2015 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
2016 folder_hash field to keep a list of live folder objects.
2017 (gtk_file_system_win32_init): Create the folder_hash.
2018 (gtk_file_system_win32_finalize): Destroy the folder_hash.
2019 (gtk_file_system_win32_get_folder): Ref and return an existing
2020 folder if we have it around, otherwise return a new folder object.
2021 (struct _GtkFileFolderWin32): Add a field for the parent file system.
2022 (gtk_file_folder_win32_finalize): Remove the folder from the file
2023 system's hash table.
2024 (gtk_file_system_win32_create_folder): Emit "files-added" on the
2025 newly-created folder's parent. Fixes #138004.
2027 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2029 * gtk/gtkfilesystemwin32.c
2030 (gtk_file_system_win32_get_folder): Test that path is actually
2031 a directory and throw error if not. Fixed bug #137950
2033 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
2035 * gtk/gtkfilesystemwin32.c
2036 (gtk_file_system_win32_volume_get_display_name): Ignore empty
2037 volume labels; assume that GetVolumeInformation would fail if
2038 GetVolumeInformationW does; catches a small memory leak;
2039 pass the buffer size to GetVolumeInformationW in wide
2040 characters instead of bytes. Fixes bug #137543
2041 (list_volumes): Cope with the theoretical possibility of
2042 more than 26 logical drives. Fixes bug #137940
2043 (bookmarks_serialize): Now actually removes bookmarks.
2046 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
2048 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
2050 2004-03-21 Tor Lillqvist <tml@iki.fi>
2052 * gtk/gtkfilesystemwin32.c
2053 (gtk_file_system_win32_volume_get_base_path): Include the
2054 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
2055 NULL for a volume base path, as g_filename_to_uri() requires an
2056 absolute path, and just a drive letter and colon isn't. (#137543)
2058 2004-03-20 Hans Breuer <hans@breuer.org>
2060 * gtk/gtkfilesystemwin32.c : applied the undisputable and
2061 required [due to recent gtkfilesystem internal api semantic
2062 changes] part of patches to fix bug #137543 (Tor Lillqvist,
2065 * gdk/gdkevents-win32.c (handle_configure_event) :
2066 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
2067 GdkWindowObject::x, y with screen coords to make
2068 gdk_window_get_position () return the right thing and thus fix
2069 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
2071 2004-03-19 Federico Mena Quintero <federico@ximian.com>
2073 * Revert the patch to #137520, as 2.4.1 is for conservative bug
2074 fixes only. The patch is attached to the bug report, for
2077 2004-03-19 Morten Welinder <terra@gnome.org>
2079 * gtk/gtkfilechooserdefault.c
2080 (gtk_file_chooser_default_set_current_folder): Test existance of
2081 the path after checking for locality, if needed.
2083 2004-03-19 Federico Mena Quintero <federico@ximian.com>
2087 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
2088 for an ::is_finished_loading() method and a ::finished_loading()
2089 signal at the end of the struct.
2091 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
2092 "finished-loading" signal.
2093 (gtk_file_folder_is_finished_loading): New function.
2095 * gtk/gtkfilesystemunix.c
2096 (gtk_file_folder_unix_is_finished_loading): Implement.
2098 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
2099 slot for a "finished-loading" signal.
2100 (gtk_file_system_model_class_init): Create the "finished-loading"
2102 (struct _GtkFileSystemModel): New field
2103 idle_finished_loading_source. We emit the "finished-loading"
2104 signal in an idle if the root folder was done loading right in
2105 _gtk_file_system_model_new(), so that the caller has a chance to
2106 connect to the signal.
2107 (_gtk_file_system_model_new): Connect to the normal signals of the
2108 folder even if the initial _list_children() fails. Also, see if
2109 the folder is finished loading; connect to the "finished-loading"
2111 (gtk_file_system_model_finalize): Remove the idle handler.
2113 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
2114 and connect to the model's "finished-loading" signal.
2115 (get_toplevel): New helper function.
2116 (error_message): Use get_toplevel().
2117 (trap_activate_cb): Likewise.
2118 (location_popup_handler): Likewise.
2119 (set_busy_cursor): New function.
2120 (browse_files_model_finished_loading_cb): New callback.
2122 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
2124 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
2125 eventbox for expander. (#137564, reported by
2128 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
2130 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
2132 2004-03-17 Morten Welinder <terra@gnome.org>
2134 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
2135 volumes not actually put into the shortcut list.
2137 * tests/prop-editor.c (object_changed): Plug leak.
2139 * tests/testfilechooser.c (main): Plug some leaks and expose
2142 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
2143 object. Fixed #136652.
2145 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
2146 have no screen. Fixes #137260.
2147 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
2148 thereby fixing leak. Fixes #137259.
2150 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
2151 slider buttons have been destroyed.
2152 (gtk_path_bar_remove): Make this work for slider buttons too.
2155 2004-03-15 Morten Welinder <terra@gnome.org>
2157 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
2158 Sanitize and plug leak.
2159 (check_icon_theme): Only do something if the widget has a screen.
2161 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
2163 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2164 Move the repositioning logic from _gtk_entry_completion() popup
2165 over here. Fixes #137355, reported by Niklas Knutsson.