1 2004-06-22 Federico Mena Quintero <federico@ximian.com>
3 Fixes the GTK+ part of #142308:
5 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
6 Use filename_to_path().
7 (gtk_file_system_unix_uri_to_path): Likewise.
8 (filename_to_path): Use remove_trailing_slash().
10 2004-06-22 Matthias Clasen <mclasen@redhat.com>
12 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
13 for the ::move_cursor signal.
15 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
16 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
19 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
20 this gets defined for all backends, so linux-fb has a
23 * gdk/x11/gdkgc-x11.c:
24 * gdk/gdkgc.c: Move function docs inline, add hints about
25 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
27 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
28 for children of the root. (#139785, Jean-François Wauthy,
31 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
32 fix. (#144750, Jeff Franks)
34 2004-06-21 Michael Natterer <mitch@gimp.org>
37 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
38 function public as _gdk_x11_convert_to_format().
40 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
41 the pixels from the GdkPixbuf when putting them in the
42 Xcursor image. Fixes bug #144350.
44 2004-06-16 Federico Mena Quintero <federico@ximian.com>
46 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
47 visible node, free the old path before creating the new one.
50 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
52 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
53 (#144198, Mariano Suárez-Alvarez)
55 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
57 * gtk/gtkfilechooserdefault.c: Don't use
58 contractions like "don't" or "isn't" in error messages.
59 It isn't nice to use them in log entries either...
60 (#137774, Morten Welinder, patch by Alexander Winston)
62 2004-06-11 Federico Mena Quintero <federico@ximian.com>
66 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
67 Don't ref the editable node.
68 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
69 (_gtk_file_system_model_remove_editable): Ahem, free the node.
71 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
72 Added fields for edited_idle and edited_new_text.
73 (renderer_edited_cb): Queue the
74 creation of the folder in an idle handler.
75 (renderer_editing_canceled_cb): Likewise for the cancellation.
76 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
78 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
80 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
82 2004-06-10 Federico Mena Quintero <federico@ximian.com>
84 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
86 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
87 Refer to gtk_file_chooser_add_shortcut_folder().
88 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
89 gtk_file_chooser_add_shortcut_folder_uri().
91 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
93 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
94 the drag before focusing the selected.day.
95 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
96 a beginning drag if the widget becomes insensitive.
98 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
100 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
101 spinning before calling arrow_action(), so that a signal
102 handler triggered from arrow_action() has a chance to
103 stop the spinning. (#143966, Davyd Madeley)
105 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
107 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
108 typo. (#144070, Kent Sandvik)
110 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
112 * gtk/gtkmenu.c: Revert the "drag select" part of
115 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
117 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
118 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
120 2004-06-07 Federico Mena Quintero <federico@ximian.com>
122 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
123 from 2003/Sep/12. This kept DnD in tree views within modal
124 dialogs from working, which is especially bad for the file
125 chooser. Fixes #135168.
127 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
129 Make the entry context menu work in editable text cells. The changes
130 are based on a patch by Kristian Rietveld, which implemented an
131 approach outlined by Owen Taylor. (#50075)
133 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
134 Ignore focus out if the entry menu is posted.
135 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
136 posted, and set up a signal handler to clear the flag if the menu
138 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
139 set up a timeout to stop editing if the focus is lost.
140 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
141 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
142 signal on the entry and keep a pointer to the entry.
143 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
144 clear the pointer to the entry.
146 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
148 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
149 of the ::language property. (#143802, Owen Taylor)
151 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
153 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
154 (gtk_entry_completion_list_enter_notify),
155 (gtk_entry_completion_list_motion_notify),
156 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
157 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
158 use it as in the menu code to avoid the initial selection if
159 the window pops up under the pointer. (Anders Carlsson)
161 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
163 * tests/testmerge.c: Add a checkbox to queue an
164 merge/unmerge. Patch from Matthias Clasen.
166 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
168 (rebuild_menu): New function that rebuilds the overflow menu and
169 makes sure it doesn't start or end with a separator.
170 (toolbar_content_new_tool_item)
171 (toolbar_content_remove)
172 (toolbar_content_new_compatibility): Set the rebuild_needed flag
173 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
174 have actually overflown an item with a proxy menu item. Also make
175 sure we rebuild the menu if needed.
177 Fix #125504, #142377, #143463
179 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
180 Obey the "priv->draw" flag. (#143692)
182 2004-06-04 Matthias Clasen <mclasen@redhat.com>
184 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
185 quirk in the button size allocation code.
187 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
188 requested for drawing the focus indicator to the child in the
189 !CAN_FOCUS case. This should fix issues which the Gimp has with
190 the button allocation changes in 2.4.2.
192 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
194 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
195 length of the entry contents in characters, not in bytes.
197 * gtk/gtkentry.c (paste_received): Don't pop up the completion
198 window on paste, noticed by Anders Carlsson.
200 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
202 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
203 values and default value for the ::active property. (#143669,
206 2004-06-03 Michael Natterer <mitch@gimp.org>
208 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
209 instead of accessing item->image->allocation.width/height
210 directly. Makes widgets which only have a requisition set using
211 gtk_widget_set_size_request() work and fixes bug #142789.
213 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
215 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
216 of sticky right click menus to return.
218 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
220 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
221 better handle the "click" case. bug Better fix for #141169.
223 2004-06-02 Federico Mena Quintero <federico@ximian.com>
225 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
226 model is empty. Fixes #143536.
228 2004-06-02 Matthias Clasen <mclasen@redhat.com>
230 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
231 close the dialog on focus out of the size entry. (#143505,
234 2004-06-02 Federico Mena Quintero <federico@ximian.com>
238 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
239 (gtk_fnmatch_intern): Likewise; also implement this option.
241 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
243 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
244 no_leading_period argument of _gtk_fnmatch().
245 (attempt_file_completion): Likewise.
247 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
248 no_leading_period argument of _gtk_fnmatch().
250 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
252 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
255 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
257 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
258 allow unless selection mode is multiple. (#142634, John Finlay)
260 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
264 * gtk/gtkentrycompletion.h:
265 * gtk/gtkentrycompletion.c:
267 * gtk/gtkcombobox.c: Rename function parameters from
268 index to index_ to prevent clash with BSD index(). (#143001)
270 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
272 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
273 NULL on an accel label. (#139641, Sam Stephenson, patch by
276 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
278 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
279 lookup finding icons in the wrong prefix. (#143328,
282 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
286 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
287 only stay up if you release within 500 milliseconds.
288 (gtk_menu_shell_button_press): Set the activate_time to the event
289 time when a button is pressed.
291 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
292 Interprete button releases as activate when we have seen both an
293 enter an a motion event.
295 2004-06-01 Federico Mena Quintero <federico@ximian.com>
297 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
298 dummy node if there is no parent node. Fixes #143362.
300 2004-05-31 Federico Mena Quintero <federico@ximian.com>
302 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
303 newly-created folder. Fixes #138932.
304 (trap_activate_cb): Only return TRUE if we did handle the event.
305 Fixes #143359; patch by jylefort@brutele.be.
307 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
309 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
310 docs. (#142892, Tommi Komulainen)
312 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
314 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
315 parent is minimized, porting the fix from 1.2. (#1923, #57182)
317 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
319 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
320 unmapped windows work.
322 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
324 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
327 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
329 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
330 Refer to ::update-preview, not ::selection-changed.
332 2004-05-29 Christian Rose <menthos@menthos.com>
334 * configure.in: Added "tk" to ALL_LINGUAS.
336 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
338 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
339 messages for common problems. (#137974, Owen Taylor)
341 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
343 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
344 errors. (#143337, Billy Biggs)
346 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
348 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
349 bits within visual->depth that aren't used for color to
350 1s, in case they are alpha.
352 2004-05-27 Anders Carlsson <andersca@gnome.org>
354 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
355 Make separator rows insensitive.
357 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
359 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
362 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
364 * gtk/gtkentrycompletion.h:
365 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
366 Getter for text_column. Also make ::text_column a property.
368 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
370 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
372 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
374 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
375 signal if the box exists.
377 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
379 Support insensitive cells in tree views and combo boxes:
381 * gtk/gtkcellrenderer.h:
382 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
384 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
385 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
386 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
387 Support drawing insensitive.
390 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
391 function to obtain the cell renderers from a cell view. Also
392 export gtk_cell_view_set_cell_data().
394 * gtk/gtktreeselection.c (tree_column_is_sensitive):
395 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
396 to determine whether all visible cells in a row are insensitive
397 and whether a row is selectable. A row is not selectable if the
398 user function says so or if all visible cells are insensitive.
399 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
400 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
401 Use row_is_selectable().
403 * gtk/gtkcombobox.c (row_is_sensitive):
404 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
405 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
406 to determine row sensitivity in menu or list mode.
408 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
409 to set up sensitivity menu items from the underlying rows.
411 * gtk/gtkcombobox.c (gtk_combo_box_popup):
412 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
413 update_menu_sensitivity().
415 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
418 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
421 * tests/testcombo.c (main): Make some rows insensitive.
423 2004-05-26 Robert Ögren <gtk@roboros.com>
425 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
426 modifiers (shift, ctrl etc) in button and motion events from the
429 2004-05-26 Robert Ögren <gtk@roboros.com>
431 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
432 implementation for extended input devices using last known
433 device state (#143237)
435 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
437 * gtk/gtkframe.c: Move docs inline, fixing them on the
438 way. (#143029, Steve Chaplin)
440 2004-05-11 Robert Ögren <gtk@roboros.com>
442 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
443 events to windows that want extended input events. (#142943)
444 (gdk_event_translate): Move check for extended input devices to
445 propagate, new parameter to propagate.
446 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
447 _gdk_input_(un)grab_pointer. (#142943)
449 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
450 input grab. [Fix missing update of impl in "dijkstra" event
451 propagation loop] Drop the parallel "impl" pointer, just use a
452 cast. Don't propagate beyond windows that want normal input
454 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
455 implementation of input grab. (#142943)
457 2004-05-22 Tor Lillqvist <tml@iki.fi>
459 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
460 line. (Spotted by Benoît Carpentier.)
462 2004-05-18 Matthias Clasen <mclasen@redhat.com>
464 * configure.in: Check for XFIXES extension.
466 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
467 a gboolean have_xfixes member.
469 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
470 XFIXES events and set have_xfixes.
472 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
473 (GdkEventOwnerChange): New event struct for owner change events.
474 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
476 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
477 XFixesSelectionNotify events into GdkEventOwnerChange events.
480 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
481 (gdk_display_request_selection_notification): New api
482 to support selection ownership notification.
484 * gtk/gtkclipboard.h:
485 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
486 api to handle owner change events.
487 (clipboard_peek): Refactored out the body of
488 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
490 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
491 by calling _gtk_clipboard_handle_event().
493 2004-05-18 Matthias Clasen <mclasen@redhat.com>
495 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
496 the P_() macros ourselves.
498 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
499 Restrict the width of the popup to be no larger than the
500 monitor. (#142678, DmD Ljungmark)
502 * gtk/gtkbutton.c: Go back to the initial fix for the
503 focus-overdrawing problem, which was actually correct
504 according to docs/widget_geometry.txt.
506 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
507 arrow size from 11 to 15 to compensate for that.
509 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
510 arguments of the ::move-cursor signal. (#142725)
512 2004-05-17 Matthias Clasen <mclasen@redhat.com>
516 * gtk/gtkbutton.c (gtk_button_size_request)
517 (gtk_button_size_allocate, _gtk_button_paint): Allocate
518 space for the focus rectangle only if necessary. (#142668,
521 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
525 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
526 lines. (#142479, Morten Welinder)
528 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
530 * gtk/gtkintl.h (Q_): Add a Q_() macro.
532 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
533 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
534 they are not really needed.
536 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
537 instead of hardwired padding, use Q_() for the default label,
538 compute a reasonable minimal size. (#142571, #142572, #142573,
539 Tommi Komulainen, Christian Persch)
541 2004-05-15 Tor Lillqvist <tml@iki.fi>
543 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
544 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
545 time). It is used by the OLE2_DND code, which is unfinished and
546 presumably horribly broken, but still, let's not make it not
547 compile on purpose. Silence some gcc warnings in the OLE2_DND
550 2004-05-14 Matthias Clasen <mclasen@redhat.com>
552 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
553 New function to go from tree window to tree coordinates, kept
554 static for now until we figure out the multiple coordinate
555 system mess in GtkTreeView API-wise.
556 (gtk_tree_view_scroll_to_cell): Transform the coordinates
557 from tree window to tree coordinates, using the new function.
558 Previously, the x coordinate was wrongly transformed. (#142494)
560 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
563 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
564 modifier bit to mark stock item which need to be freed
565 eventually. (#140654, Michal Pasternak, Scott Tsai)
567 2004-05-11 Robert Ögren <gtk@roboros.com>
569 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
570 call to g_object_ref in Wintab code. (#138341)
572 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
573 including unallocated buffers for event->motion.axes and
574 event->button.axes, unsigned wraparound problem in the code for
575 detecting missing press/release events and assigning min instead
576 of max when setting up axes.
578 2004-05-12 Matthias Clasen <mclasen@redhat.com>
580 * tests/testtreeedit.c: Add a progress column.
582 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
585 * gtk/gtk.h: Include gtkcellrendererprogress.h.
587 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
588 based on the one found in Epiphany.
590 2004-05-11 Michael Natterer <mitch@gimp.org>
592 * gtk/gtkcombobox.c (gtk_combo_box_popup)
593 (gtk_combo_box_menu_button_press): don't allocate the popup
594 smaller than the combobox. Fixes bug #59660.
596 2004-05-11 Matthias Clasen <mclasen@redhat.com>
598 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
599 previous change to this function, clarify the docs instead.
601 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
602 GTK_SELECTION_BROWSE.
604 * gtk/gtktreeview.c: Make hover selection work for
605 GTK_SELECTION_BROWSE as well.
607 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
609 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
610 Document the ::toggled signal.
612 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
614 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
616 2004-05-10 Matthias Clasen <mclasen@redhat.com>
618 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
620 * gdk/gdkdisplay.c (singlehead_...):
621 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
622 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
623 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
625 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
626 note about COLUMN_FIXED restriction.
628 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
629 Set the entry in the default handler of the ::match-selected signal.
632 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
633 do the move-selected-item below pointer thingie, do the
634 place-below-or-above one.
636 * tests/testentrycompletion.c: Make the second example use the
637 ::match-selected signal to make it actually work.
639 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
640 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
641 mode. (#127648, Dave Bordoley)
644 * gtk/gtktreeview.c: Add a new property "hover_selection", which
645 when TRUE makes the selection follow the mouse. Also add setter
646 and getter for the fixed_height property.
648 2004-05-10 Matthias Clasen <mclasen@redhat.com>
650 * gtk/gtkcombobox.c (gtk_combo_box_popup)
651 (gtk_combo_box_menu_button_press): Make sure the menu pops up
652 as wide as the combobox. (#59660, Havoc Pennington)
654 2004-05-10 Matthias Clasen <mclasen@redhat.com>
657 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
658 mode). Add a new property, add-tearoffs, for this. (#135956)
660 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
661 default button. (#118921)
663 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
665 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
666 that emits the grab notify signal.
668 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
670 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
672 * gtk/gtkmenu.c: Make destruction of a torn off menu work
675 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
679 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
680 Allow to suppress the stock accelerator by using "". (#142196,
683 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
687 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
688 In list mode, accept the same mouse/wheel bindings on
689 the cellview as on the button. (#136967)
691 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
693 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
694 cached icons. (#135888, Crispin Flowerday)
696 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
698 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
699 that we actually return menus for nodes of type menu, not the
700 menuitems they're attached to.
702 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
704 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
705 Add a note regarding UTF-8 requirements, proposed by
706 Mariano Suárez-Alvarez.
708 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
710 * gtk/gtktearoffmenuitem.h:
711 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
712 into the GtkTearoffMenuItem struct, since it is used
713 by the Gimp, and keep it synchronized with the
714 tearoff_state property of the parent menu.
716 2004-05-08 Hans Breuer <hans@breuer.org>
718 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
719 create the correct mask for 'pseudo mime' icons
721 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
722 take focus_on_map into account
724 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
726 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
727 ... must return a value
729 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
731 2004-05-07 Matthias Clasen <mclasen@redhat.com>
733 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
734 draw over the focus rectangle.
736 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
737 standard focus style. (#63071, Bill Haneman, idea for new
738 style by Owen Taylor)
740 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
741 focus on the colorwheel via details.
743 2004-05-06 Matthias Clasen <mclasen@redhat.com>
747 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
748 this no longer needed signal handler. (#141817, Paul Pogonyshev)
750 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
752 * gtk/gtktearoffmenuitem.h:
753 * gtk/gtktearoffmenuitem.c: Make the tearoff
754 functionality model/view, the tearoffmenuitem being
755 the view and the tearoff_state property of the menu
756 being the model. (#101185, Owen Taylor)
758 * gtk/gtkmenu.c: Add a tearoff_state property.
760 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
764 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
765 popup the submenu for items in torn off menus. (#122051)
767 2004-05-06 Sven Neumann <sven@gimp.org>
769 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
770 position the title lable next to the arrow just as we do for LTR
771 rendering. Fixes bug #141825.
773 2004-05-06 Matthias Clasen <mclasen@redhat.com>
775 * docs/RELEASE-HOWTO: Document the new policy of
776 bumping version numbers after release.
778 * configure.in: Bump version number to 2.5.0.
780 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
783 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
786 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
788 * gtk/gtkactiongroup.h:
789 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
790 New function to translate a string with translate_func.
793 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
795 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
796 (gtk_combo_box_get_row_span_column):
797 (gtk_combo_box_get_column_span_column): Add missing getters
798 for readwrite properies. (#135649)
800 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
803 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
804 Add gtk_combo_box_get_active_text() convenience
805 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
807 2004-05-05 Elijah Newren <newren@math.utah.edu>
809 Changes to support do-not-focus-on-map hint in conjunction with
810 _NET_WM_USER_TIME (#115650):
812 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
815 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
818 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
819 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
821 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
822 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
823 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
824 Initialize the focus_on_map field to TRUE.
826 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
827 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
828 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
829 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
830 Implementations for the various backends. The Win32 and linux-fb
831 implementations set the focus_on_map field, but don't use it yet
832 to actually implement noinput windows. The X implementation sets
833 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
835 * gdk/x11/gdkwindow-x11.h:
836 * gdk/x11/gdkevents-x11.c (set_user_time):
837 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
838 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
839 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
840 since we want that function to be part of the public API.
842 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
846 * gtk/gtkiconfactory.c (icon_source_clear): Don't
847 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
849 2004-05-05 Matthias Clasen <mclasen@redhat.com>
853 * gtk/gtkuimanager.c (print_node): Make the output
854 parseable. (#141929, Sven Neumann)
856 2004-05-05 Tor Lillqvist <tml@iki.fi>
858 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
859 multi-monitor offset. (#141842, John Ehresman)
861 2004-05-04 Federico Mena Quintero <federico@ximian.com>
863 Fixes #139562, based on a patch by Christian Neumair.
865 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
866 a filter_combo_hbox field to contain the filter combo.
867 (show_filters): Show/hide the filter_combo_hbox.
868 (create_filename_entry_and_filter_combo): Removed.
869 (file_pane_create): Create the filter_combo_hbox here.
871 2004-05-04 Matthias Clasen <mclasen@redhat.com>
873 * modules/input/gtkimcontextxim.c: Fix the recent
874 string_conversion_callback change to work on
875 Solaris. (#141190, Padraig O'Briain)
877 * gtk/gtkselection.c: Disable debug logging again.
879 2004-05-03 Matthias Clasen <mclasen@redhat.com>
881 * gtk/gtkselection.c: Make the chunk size for
882 incremental transfers depend on the maximal request
883 size, capped at 256k. This should allow most selections
884 to be transferred nonincrementally, avoiding many
885 roundtrips and protocol overhead.
887 2004-05-03 Federico Mena Quintero <federico@ximian.com>
889 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
890 g_signal_new() correctly and initialize the signal fields. Fixes
891 #141749; patch based on Michael Natterer's.
893 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
895 * gtk/gtkselection.c (_gtk_selection_request): Fix
896 a debug message to show correct information.
897 (_gtk_selection_incr_event): Make INCRemental transfer
898 of MULTIPLE targets work. This was broken since 1997!
900 2004-05-02 Hans Breuer <hans@breuer.org>
902 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
903 modify the passed in GdkSegment(s) in place, we may get
904 them again to draw at the same place. Fixes bug #129095,
906 (draw_segments) draw the end pixel again to get the
907 pixmap mask right, fixes bug #126710, #130202
909 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
910 fixes bug #106013, John Ehresman
912 * gtk/makefile.msc.in : don't try to link gtk.res but
913 use gtk-win32.res (as supposed to be fixed below :)
915 2004-05-01 Hans Breuer <hans@breuer.org>
917 * tests/Makefile.am : tests/makefile.msc is in CVS for
918 a long time, finally added to EXTRA_DIST : fixes bug
919 #141334, John Ehresman
921 2004-04-30 Matthias Clasen <mclasen@redhat.com>
923 * === Released 2.4.1 ===
925 * configure.in: Version 2.4.1, interface age 1.
929 2004-04-29 Federico Mena Quintero <federico@ximian.com>
933 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
934 function; moved the code over from
935 remove_bookmark_button_clicked_cb().
936 (remove_selected_bookmarks): Now, getting a non-removable bookmark
937 is not an error, as we may be called as a result of hitting the
939 (shortcuts_key_press_event_cb): New handler; delete the bookmark
940 if the user presses Backspace, Delete, or KP_Delete.
942 2004-04-29 Matthias Clasen <mclasen@redhat.com>
944 * gtk/gtkaction.c (closure_accel_activate): Use
945 _gtk_action_emit_activate() instead of directly
946 emitting the activate signal. (#141429, Jody Goldberg)
948 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
949 Warn people when the accelerator can not be
950 parsed. (#141429, Jody Goldberg)
952 2004-04-29 Matthias Clasen <mclasen@redhat.com>
954 * tests/testentrycompletion.c (main): Add a missing
955 cat. (#141070, Chris Sherlock)
957 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
958 variable. (#141022, Chris Sherlock)
960 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
961 cast. (#141013, Chris Sherlock)
963 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
964 unused variable. (#141011, Chris Sherlock)
966 2004-04-29 Tor Lillqvist <tml@iki.fi>
968 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
969 leak. (#140775, John Ehresman)
971 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
973 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
974 to index the cached gcs, not depth. (#139494)
976 2004-04-28 Matthias Clasen <mclasen@redhat.com>
978 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
980 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
982 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
983 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
985 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
987 Patch to add support for string conversion callbacks to
988 GtkIMContextXIM (#101814)
990 * modules/input/gtkimcontextxim.c: Set the string conversion callback
991 if supported by the XIC.
993 (struct _GtkIMContextXIM): Add string_conversion_callback member.
995 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
996 whether string conversion callback is supported.
998 (gtk_im_context_get_ic, +set_string_conversion_callback,
999 +string_conversion_callback): Also initialize string conversion
1000 callback, if supported, along with the IC initialization.
1002 * modules/input/imxim.c: Make "xim" module default for Thai as well.
1004 2004-04-23 Matthias Clasen <mclasen@redhat.com>
1006 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
1007 initialize targets. (#139883, John Finlay)
1009 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
1011 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
1012 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
1015 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
1016 Remove an excessive g_return_if_fail().
1018 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
1020 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1021 _-prefix calls of gdk_x11_window_set_user_time().
1023 2004-04-22 Matthias Clasen <mclasen@redhat.com>
1025 * gtk/gtkuimanager.c (update_node): Make sure the separators
1026 used to demarkate placeholder ends don't show up on
1027 show_all(). (#140496, Murray Cumming)
1029 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
1030 work with negative increments. (#137975, Tim Gerla)
1032 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1034 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
1035 gtk_tool_button_set_icon_widget): Remove the old widget from the
1036 tool button before overwriting it with the new widget.
1038 (#140508, Todd Goyen)
1040 2004-04-22 Tor Lillqvist <tml@iki.fi>
1042 Fix the file chooser on Windows. I can't make it misbehave or
1043 crash any more now. But presumably there are still corner cases
1044 not handled. I haven't really checked behaviour of UNC paths, for
1047 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
1048 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
1051 (gtk_file_system_win32_get_parent): Like the Unix version, assert
1052 filename is absolute, and avoid one unnecessary string allocation
1055 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
1056 letters more correctly.
1058 (gtk_file_system_win32_render_icon): Assure correct syntax is used
1059 for root folder of a drive. (#137962, Morten Welinder)
1061 (filename_is_some_root): New function that accepts also root
1062 without any drive specified.
1064 (filename_is_drive_root): Rename from filename_is_root.
1066 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
1069 2004-04-21 Matthias Clasen <mclasen@redhat.com>
1071 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
1072 completion window if there are no completions anymore.
1074 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1075 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
1076 It doesn't like that. (#140642, Christian Persch)
1078 * demos/gtk-demo/expander.c (do_expander): A new demo.
1080 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
1082 2004-04-20 Matthias Clasen <mclasen@redhat.com>
1084 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
1085 sure anchored children get size allocated, even if the layout
1086 is valid. (#122323, Andrew E. Makeev)
1087 (gtk_text_view_scroll_pages):
1088 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
1089 if we already have pending scrolls. Bandaid fix for #78513.
1091 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
1093 * INSTALL.in: Update libpng and libjpeg URLs, remove
1094 note about building without since that's not the normal
1097 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
1099 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
1100 handling of SVG/non-SVG unthemed icons.
1102 2004-04-19 Morten Welinder <terra@gnome.org>
1104 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
1107 2004-04-19 Matthias Clasen <mclasen@redhat.com>
1109 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1110 Don't stop the iteration up to the tag_root too
1111 early. (#109945, Dongho Shin)
1113 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1115 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
1116 gdk_keymap_translate_keyboard_state() handle NULL
1117 keymaps. (#139715, Torsten Schoenfeld).
1119 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1121 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
1122 reported by Pedro RODRIGUEZ, about compilation problems when
1123 Xcursor is installed in a non-standard location.
1125 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1127 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
1130 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
1131 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
1133 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
1135 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
1138 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
1139 property on user interaction.
1141 2004-04-15 Federico Mena Quintero <federico@ximian.com>
1143 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
1144 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
1146 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
1147 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
1150 2004-04-15 Matthias Clasen <mclasen@redhat.com>
1152 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1153 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
1155 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1157 * gtk/gtkcombobox.c:
1159 Make all style properties readonly.
1161 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1163 * gtk/gtkcolorsel.c: Add a11y relations between the color
1164 wheel and the spin buttons. (#132745, Padraig O'Briain)
1166 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
1167 the meaning of size == -1.
1169 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
1170 a size of -1. (#137436, Brian Cameron)
1172 * gtk/gtkcombobox.c: Make the arrow and separator regular
1173 children of an hbox inside the button, and propagate state
1174 changes from the button to the cell view. (part of the fix
1175 for #138650, should also fix #137535)
1177 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
1178 state to gtk_cell_renderer_render() when prelighted. (part
1179 of the fix for #138650)
1181 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1182 Use PRELIGHT state when appropriate. (part of the fix for
1185 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
1186 out warnings if called before the combo box is
1187 realized. (#139742, Philip Langdale)
1189 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
1191 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
1194 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
1196 * gtk/gtkpathbar.c (make_directory_button): remove spurious
1199 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
1201 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
1202 make the buttons sized by a bold label. This makes the text
1203 'swim' a little, but stops the buttons from resizing, #137210
1205 2004-04-13 Matthias Clasen <mclasen@redhat.com>
1207 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
1209 (start_element_handler): Accept separators without unique
1210 names. (#133302, Anders Carlsson)
1212 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
1213 possible accelerator gotcha when using this function. (#139641,
1216 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
1217 list nodes. (#138862, Morten Welinder)
1219 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
1221 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
1223 (gtk_tree_view_button_press): If we activated the row we don't
1224 want to grab focus back, as moving focus to another widget is
1225 pretty common, #138458
1227 2004-04-12 Federico Mena Quintero <federico@ximian.com>
1229 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
1230 documentation to all the signals.
1232 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
1234 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
1235 model if it is NULL. (#139770)
1237 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
1239 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
1240 a shadow inside the scrolled window, add it around the vbox.
1242 * gtk/gtkentryprivate.h:
1243 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1244 Return a boolean indicating whether the popup is positioned above
1245 or below. Scroll the completions to the beginning or the end,
1246 depending on the positioning.
1248 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
1249 wrap around in the entry completion popup, and allow GDK_UP to
1250 enter the popup. (#137440)
1252 2004-04-12 Matthias Clasen <mclasen@redhat.com>
1254 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
1255 there before using it.
1257 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
1259 * gtk/gtktreeprivate.h: Moved search entries into priv data.
1261 * gtk/gtktreeview.c: Prep for type-ahead support.
1263 (gtk_tree_view_destroy): Destroy the search window explicitly.
1264 (gtk_tree_view_key_press): Minor change; prep for type-ahead
1265 (gtk_tree_view_ensure_interactive_directory): New function
1266 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
1267 (gtk_tree_view_real_start_interactive_search): rework
1268 (gtk_tree_view_search_dialog_hide): ditto
1269 (gtk_tree_view_search_delete_event): ditto
1270 (gtk_tree_view_search_button_press_event): ditto
1271 (gtk_tree_view_search_key_press_event): ditto
1272 (gtk_tree_view_search_move): ditto
1273 (gtk_tree_view_search_init): ditto
1275 * gtk/gtktreeviewcolumn.c:
1276 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
1278 * tests/testfilechooser.c: (main): change
1280 2004-04-11 Hans Breuer <hans@breuer.org>
1282 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
1283 the real fix would involve just another small API breakage,
1284 i.e. gdk_spawn_* using GPid not just gint.
1286 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
1288 2004-04-10 Tor Lillqvist <tml@iki.fi>
1290 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
1291 If both Shift and CapsLock pressed, ignore the shift only for
1292 letters (that would have been affected by the CapsLock). (#139095)
1294 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
1295 seems to be even buggier now than it used to be. (#138341)
1296 Initialize _gdk_input_ignore_wintab to TRUE.
1298 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
1299 GDK_USE_WINTAB environment variable to turn on tablet support.
1301 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
1303 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
1304 (gtk_ui_manager_remove_action_group): Terminate
1305 g_object_[dis]connect() calls with NULL instead of 0.
1308 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
1310 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
1312 2004-04-07 Federico Mena Quintero <federico@ximian.com>
1316 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
1317 passed-in 'str' is not NULL.
1319 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
1320 expands "~/" or "~foo/" at the beginning of a filename.
1321 (gtk_file_system_unix_parse): Use expand_tilde() before doing
1324 * gtk/gtkfilechooserentry.c
1325 (gtk_file_chooser_entry_maybe_update_directory): Take in a
1326 force_reload argument.
1327 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
1328 returns an error, set the file_part_pos to -1.
1329 (load_directory_callback): Only populate the model if the
1330 file_part_pos is not -1.
1332 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
1334 * configure.in: Added Icelandic (is) to ALL_LINGUAS
1336 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1338 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
1339 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
1341 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
1342 for G_DIR_SEPARATOR in the display_name, and err out if it is
1343 present; use the same error message as Nautilus. Fixes #136467.
1345 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
1346 new-folder button say "Create Fo_lder" rather than "Create
1347 _Folder", so that the mnemonic doesn't conflict with the "Save in
1348 _folder" label. Fixes #136975.
1350 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1352 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
1353 buttons. Also, free them correctly upon failure. Based on a
1354 patch by Morten Welinder, fixes #137956.
1356 2004-04-05 Anders Carlsson <andersca@gnome.org>
1358 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
1360 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
1362 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
1363 correctly for fixed height when inserting a node, #138082
1365 2004-04-01 Federico Mena Quintero <federico@ximian.com>
1369 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
1370 "child_is_hidden" boolean argument to the "path-clicked" signal.
1372 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
1374 (make_directory_button): Take a file_is_hidden argument; put it in
1376 (_gtk_path_bar_set_path): See whether each path component path is
1378 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
1379 "path-clicked" signal.
1380 (button_clicked_cb): See if the downwards button represents a
1381 hidden file for the file_is_hidden argument in the signal
1384 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
1386 * gtk/gtkfilechooserdefault.c
1387 (gtk_file_chooser_default_select_path): If we fail to switch
1388 folders, don't try to select the path in the file system model.
1389 Also, return the result from _gtk_file_system_model_path_do().
1390 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
1391 file system model if we are asked to select a hidden file.
1392 (path_bar_clicked): Show hidden files based on whether the
1393 immediate downwards folder in the path bar is a hidden file
1395 (struct _GtkFileChooserDefault): Added fields
1396 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
1397 (create_file_list): Set an object data key of
1398 "GtkFileChooserDefault" on the tree view so that we can find the
1399 impl from the popup menu callbacks. Also, hook up to the
1400 "button-press-event" and "popup-menu" signals in the file list to
1401 bring up a popup menu.
1402 (list_popup_menu_cb): New callback.
1403 (list_button_press_event_cb): New callback.
1407 * gtk/gtkfilesystemmodel.c
1408 (_gtk_file_system_model_new): Oops, connect_object to
1411 2004-03-31 Tor Lillqvist <tml@iki.fi>
1413 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
1414 for native Win32. (#136559, J. Ali Harlow)
1416 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
1417 angles. Thanks to Tim Newsham.
1419 2004-03-29 Federico Mena Quintero <federico@ximian.com>
1423 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1424 for an ::is_finished_loading() method and a ::finished_loading()
1425 signal at the end of the struct.
1427 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1428 "finished-loading" signal.
1429 (gtk_file_folder_is_finished_loading): New function.
1431 * gtk/gtkfilesystemunix.c
1432 (gtk_file_folder_unix_is_finished_loading): Implement.
1434 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1435 slot for a "finished-loading" signal.
1436 (gtk_file_system_model_class_init): Create the "finished-loading"
1438 (struct _GtkFileSystemModel): New field
1439 idle_finished_loading_source. We emit the "finished-loading"
1440 signal in an idle if the root folder was done loading right in
1441 _gtk_file_system_model_new(), so that the caller has a chance to
1442 connect to the signal.
1443 (_gtk_file_system_model_new): Connect to the normal signals of the
1444 folder even if the initial _list_children() fails. Also, see if
1445 the folder is finished loading; connect to the "finished-loading"
1447 (gtk_file_system_model_finalize): Remove the idle handler.
1449 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1450 and connect to the model's "finished-loading" signal.
1451 (get_toplevel): New helper function.
1452 (error_message): Use get_toplevel().
1453 (trap_activate_cb): Likewise.
1454 (location_popup_handler): Likewise.
1455 (set_busy_cursor): New function.
1456 (browse_files_model_finished_loading_cb): New callback.
1458 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1460 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
1461 file under the cursor; we don't need the logic from
1462 GtkFileSelection after all. Fixes #132255.
1464 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1466 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
1467 location entry with the display name of the file under the cursor
1468 for Open mode, or the typed filename in Save mode.
1470 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1472 * gtk/gtkfilesystemwin32.c
1473 (filename_is_root): Bare drive designators (eg., "c:") are
1474 no longer considered as root filenames. Fixed #137942
1476 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1478 * gtk/gtkfilesystemwin32.c
1479 (gtk_file_system_win32_create_folder): Invert test for error in
1480 mkdir. Fixes #137945
1482 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1484 Fixed #138004 using Federico's code from #132327.
1486 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
1487 folder_hash field to keep a list of live folder objects.
1488 (gtk_file_system_win32_init): Create the folder_hash.
1489 (gtk_file_system_win32_finalize): Destroy the folder_hash.
1490 (gtk_file_system_win32_get_folder): Ref and return an existing
1491 folder if we have it around, otherwise return a new folder object.
1492 (struct _GtkFileFolderWin32): Add a field for the parent file system.
1493 (gtk_file_folder_win32_finalize): Remove the folder from the file
1494 system's hash table.
1495 (gtk_file_system_win32_create_folder): Emit "files-added" on the
1496 newly-created folder's parent. Fixes #138004.
1498 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1500 * gtk/gtkfilesystemwin32.c
1501 (gtk_file_system_win32_get_folder): Test that path is actually
1502 a directory and throw error if not. Fixed bug #137950
1504 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
1506 * gtk/gtkfilesystemwin32.c
1507 (gtk_file_system_win32_volume_get_display_name): Ignore empty
1508 volume labels; assume that GetVolumeInformation would fail if
1509 GetVolumeInformationW does; catches a small memory leak;
1510 pass the buffer size to GetVolumeInformationW in wide
1511 characters instead of bytes. Fixes bug #137543
1512 (list_volumes): Cope with the theoretical possibility of
1513 more than 26 logical drives. Fixes bug #137940
1514 (bookmarks_serialize): Now actually removes bookmarks.
1517 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
1519 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
1521 2004-03-21 Tor Lillqvist <tml@iki.fi>
1523 * gtk/gtkfilesystemwin32.c
1524 (gtk_file_system_win32_volume_get_base_path): Include the
1525 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
1526 NULL for a volume base path, as g_filename_to_uri() requires an
1527 absolute path, and just a drive letter and colon isn't. (#137543)
1529 2004-03-20 Hans Breuer <hans@breuer.org>
1531 * gtk/gtkfilesystemwin32.c : applied the undisputable and
1532 required [due to recent gtkfilesystem internal api semantic
1533 changes] part of patches to fix bug #137543 (Tor Lillqvist,
1536 * gdk/gdkevents-win32.c (handle_configure_event) :
1537 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
1538 GdkWindowObject::x, y with screen coords to make
1539 gdk_window_get_position () return the right thing and thus fix
1540 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
1542 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1544 * Revert the patch to #137520, as 2.4.1 is for conservative bug
1545 fixes only. The patch is attached to the bug report, for
1548 2004-03-19 Morten Welinder <terra@gnome.org>
1550 * gtk/gtkfilechooserdefault.c
1551 (gtk_file_chooser_default_set_current_folder): Test existance of
1552 the path after checking for locality, if needed.
1554 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1558 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1559 for an ::is_finished_loading() method and a ::finished_loading()
1560 signal at the end of the struct.
1562 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1563 "finished-loading" signal.
1564 (gtk_file_folder_is_finished_loading): New function.
1566 * gtk/gtkfilesystemunix.c
1567 (gtk_file_folder_unix_is_finished_loading): Implement.
1569 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1570 slot for a "finished-loading" signal.
1571 (gtk_file_system_model_class_init): Create the "finished-loading"
1573 (struct _GtkFileSystemModel): New field
1574 idle_finished_loading_source. We emit the "finished-loading"
1575 signal in an idle if the root folder was done loading right in
1576 _gtk_file_system_model_new(), so that the caller has a chance to
1577 connect to the signal.
1578 (_gtk_file_system_model_new): Connect to the normal signals of the
1579 folder even if the initial _list_children() fails. Also, see if
1580 the folder is finished loading; connect to the "finished-loading"
1582 (gtk_file_system_model_finalize): Remove the idle handler.
1584 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1585 and connect to the model's "finished-loading" signal.
1586 (get_toplevel): New helper function.
1587 (error_message): Use get_toplevel().
1588 (trap_activate_cb): Likewise.
1589 (location_popup_handler): Likewise.
1590 (set_busy_cursor): New function.
1591 (browse_files_model_finished_loading_cb): New callback.
1593 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
1595 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
1596 eventbox for expander. (#137564, reported by
1599 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
1601 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
1603 2004-03-17 Morten Welinder <terra@gnome.org>
1605 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
1606 volumes not actually put into the shortcut list.
1608 * tests/prop-editor.c (object_changed): Plug leak.
1610 * tests/testfilechooser.c (main): Plug some leaks and expose
1613 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
1614 object. Fixed #136652.
1616 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
1617 have no screen. Fixes #137260.
1618 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
1619 thereby fixing leak. Fixes #137259.
1621 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
1622 slider buttons have been destroyed.
1623 (gtk_path_bar_remove): Make this work for slider buttons too.
1626 2004-03-15 Morten Welinder <terra@gnome.org>
1628 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
1629 Sanitize and plug leak.
1630 (check_icon_theme): Only do something if the widget has a screen.
1632 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
1634 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1635 Move the repositioning logic from _gtk_entry_completion() popup
1636 over here. Fixes #137355, reported by Niklas Knutsson.