1 Fri Jul 9 15:33:55 2004 Manish Singh <yosh@gimp.org>
3 * gdk/gdkevents.c: have a dummy case GDK_OWNER_CHANGE in switch
4 statements to avoid gcc warnings about not all enum values handled.
6 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): ignore should live in
9 Fri Jul 9 23:26:09 2004 Soeren Sandmann <sandmann@daimi.au.dk>
11 * gdk/x11/gdkwindow-x11.h (struct _GdkWindowImplX11): Add an
12 "override_redirect" bit.
14 * gdk/x11/gdkwindow-x11.c (gdk_window_new): Set it here.
16 * gdk/x11/gdkwindow-x11.c (gdk_window_move, gdk_window_resize,
17 gdk_window_move_resize):
18 Update the local size/position cache
19 immediately for override redirect windows.
21 * gdk/x11/gdkwindow-x11.c (show_window_internal): Invalidate
22 newly mapped child and override redirect windows.
24 2004-07-09 Federico Mena Quintero <federico@ximian.com>
28 * gtk/gtkfilesystemunix.c (get_fallback_icon): New helper
29 function, fetches a stock icon as a fallback.
30 (gtk_file_system_unix_volume_render_icon): Fall back to a stock
32 (gtk_file_system_unix_render_icon): Fall back to a stock icon.
33 Use helper functions rather than being a mega-function.
34 (get_icon_name_for_directory): Renamed from
35 get_icon_for_directory().
36 (get_icon_type_from_path): New helper function; code pulled out
37 from gtk_file_system_unix_render_icon().
38 (get_special_icon): Likewise.
39 (get_icon_for_mime_type): Likewise.
41 2004-07-09 Federico Mena Quintero <federico@ximian.com>
43 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Fix typo; tmp_event ->
46 2004-07-09 Matthias Clasen <mclasen@redhat.com>
48 * gtk/gtktooltips.c (gtk_tooltips_paint_window): Use the
49 requisition of the widget instead of relying on the style
50 drawing function to supply the size of the drawable. (#146531)
52 2004-07-09 Matthias Clasen <mclasen@redhat.com>
54 Make GtkEntry work harder to protect passwords: (#143955,
57 * gtk/gtkentry.c (gtk_entry_destroy): Add a destroy handler
58 to clear the password even if the widget is leaked.
60 * gtk/gtkentry.c (gtk_entry_real_delete_text):
61 * gtk/gtkentry.c (gtk_entry_finalize): Zero out the memory
64 * gtk/gtkentry.c (gtk_entry_real_insert_text): Zero and free
65 the old memory instead of just reallocating it.
67 * gtk/gtkentry.c (gtk_entry_create_layout): Don't leak text
68 direction information for passwords.
70 2004-07-09 Matthias Clasen <mclasen@redhat.com>
72 * gtk/gtkstyle.c: Fix some cases where style functions were
73 not handling widget == NULL properly. (#146282)
75 Thu Jul 8 22:38:58 2004 Matthias Clasen <maclas@gmx.de>
77 * gtk/gtktreeview.c: Improve the EXPANDER_MAX warning.
79 2004-07-08 Federico Mena Quintero <federico@ximian.com>
83 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Add a
84 GError argument. Do check for errors when getting the
85 GtkFileFolder: get the folder and read the children before
86 actually creating the model. Removed obsolete code that handled
87 roots-changed on the file system.
88 (file_model_node_get_info): Assert that we don't reach the old
89 case to display file system roots.
90 (roots_changed_callback): Removed.
92 * gtk/gtkfilechooserdefault.c (set_list_model): Add a GError
93 argument, and a boolean return value. Return an error if we
94 cannot create the file system model. On error, set a NULL model
96 (gtk_file_chooser_default_set_current_folder): Use the error value
97 from set_list_model().
98 (gtk_file_chooser_default_set_property): Set the show_hidden
99 property only if the browse_files_model exists.
100 (gtk_file_chooser_default_unselect_path): Only operate if the
101 browse_files_model exists.
102 (check_preview_change): Check whether we have the sort_model.
103 (change_folder_and_display_error): Copy the path we get passed
104 before using it. There's a comment in there that explains why we
105 need to copy it; basically, if the passed path belongs to the
106 model, the model may go away in the middle of this function and
107 we'll be left with a dangling pointer.
108 (install_list_model_filter): Assert that the model is not NULL.
109 (set_current_filter): Check whether the model exists.
111 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Don't
112 g_return_if_fail if the model is NULL.
113 (gtk_tree_selection_get_selected_rows): Likewise.
114 (gtk_tree_selection_count_selected_rows): Likewise.
115 (gtk_tree_selection_selected_foreach): Likewise.
116 (gtk_tree_selection_path_is_selected): Likewise; rather just
118 (gtk_tree_selection_select_all): Likewise.
119 (gtk_tree_selection_unselect_all): Likewise.
120 (gtk_tree_selection_select_range): Do g_return_if_fail() if the
122 (gtk_tree_selection_unselect_range): Likewise.
124 * gtk/gtkfilesystemunix.c (fill_in_names): Return immediately if
125 g_dir_open() fails: there is no need to set the error ourselves,
126 as g_dir_open() already does it.
128 2004-07-08 Matthias Clasen <mclasen@redhat.com>
130 * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Allow
131 to restore the default search function. (#145365, John Finlay)
133 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Don't leak
134 references to the drag context. (#144324, Alex Larsson)
136 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
138 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
139 when a new model is set. (#145566, Dmitry M. Shatrov)
141 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
143 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
144 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
145 in order to avoid rendering artifacts from misaligned
146 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
148 2004-07-07 Matthias Clasen <mclasen@redhat.com>
151 * gtk/gtktreeview.h: Small documentation fixes.
153 2004-07-07 Matthias Clasen <mclasen@redhat.com>
155 Support separators in combo boxes and more generally in tree
159 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
160 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
161 Add a ::row-separator-column property with getter and setter,
162 which can indicate a boolean model column to determine which
165 * gtk/gtkcombobox.c: Display separator rows as separator menu
166 items in menu mode, and by using the new treeview separator
167 functionality in list mode.
170 * gtk/gtktreeprivate.h:
171 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
172 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
173 Add a callback to determine whether a row is a separator.
175 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
176 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
177 * gtk/gtktreeview.c (validate_row): Use the new callback
178 to determine whether a row is a separator, and draw it
179 as a separator then. Since separators should take up less
180 vertical space than regular rows, this requires removing
181 the redundant MAX(...,expander_size) calls which appear in
182 many places. Instead, the MAX() is now only done in
183 validate_row(), and only if the row is not a separator.
184 To catch possible side effects of this intrusive change,
185 I have left EXPANDER_MAX() calls in place of the MAX() calls
186 which will emit a warning if something breaks. They should
187 be removed before 2.6.
189 * gtk/gtktreeselection.c (row_is_selectable): Don't let
190 separator rows be selected.
192 * tests/testcombo.c (create_blaat): Add a separator column.
194 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
196 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
197 a 64bit alignment issue. (#144302, Sunil)
199 2004-07-07 Tor Lillqvist <tml@iki.fi>
201 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
202 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
203 * gdk/win32/gdkproperty-win32.c (find_common_locale,
205 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
206 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
209 * gdk/win32/gdkglobals-win32.c
210 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
211 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
212 atom. Initialize it. Declare it. Drop the variable for the
215 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
216 function is supposed to return the string in the locale's charset
217 and encoding. Use g_convert().
219 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
220 string in the locale's charset. Use g_convert().
222 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
223 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
224 GLib's UTF-16 functions instead. Windows uses UTF-16.
226 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
227 functions mentioned above.
229 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
230 also if the string is of type STRING, i.e. ISO-8859-1, and the
231 current codepage is 1252, and contains no C1 chars. Accept
234 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
235 Mark as static. When storing STRING data, convert to
237 (gdk_selection_owner_set_for_display): Now that STRING is always
238 ISO-8859-1, use UTF8_STRING when sending the selection request
241 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
244 (gdk_text_property_to_text_list_for_display): Make work more like
245 X11 version. Do obey the encoding parameter.
247 (gdk_string_to_compound_text_for_display,
248 gdk_utf8_to_compound_text_for_display): Don't even pretend
249 supporting COMPOUND_TEXT.
251 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
253 (sanitize_utf8): Zero-terminate string.
255 2004-07-06 Matthias Clasen <mclasen@redhat.com>
257 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
258 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
260 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
261 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
262 fallbacks for gtkfilechooser. Currently these are the same images
263 as the "new" and "open" items...
265 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
267 Fix for #136496, Pawel Salek:
269 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
270 a node when it changes in fixed_height mode.
272 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
275 2004-07-06 Matthias Clasen <mclasen@redhat.com>
277 * gtk/gtkmenu.c (gtk_menu_position): Make sure
278 private->monitor_num is a valid monitor number before
279 using it. (#139187, Michael Natterer)
281 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
283 * gtk/gtkfilechooserdefault.c (popup_position_func):
284 * gtk/gtkentry.c (popup_position_func):
285 * gtk/gtktextview.c (popup_position_func): Improve positioning
286 of keyboard-activated menus with Xinerama.
288 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
290 * gtk/gtkuimanager.c (do_updates):
291 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
292 when called from an idle handler. (#145429, Jan-Marek Glogowski)
294 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
296 * gtk/gtkfilechooserutils.c (delegate_notify): Use
297 the less efficient g_object_interface_find_property () instead
298 of the param_id range check, since the GParamSpecs we're
299 dealing with are the overridden onces on the interface, whose
300 param_id is always zero. (#145312, Alex Roitman, fix proposed
303 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
305 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
306 virtual method of GtkContainer.
307 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
308 method slot of the container class.
310 2004-07-05 Anders Carlsson <andersca@gnome.org>
312 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
314 Use gint, not int in gtk_icon_view_set_markup_column,
317 2004-07-05 Anders Carlsson <andersca@gnome.org>
319 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
320 (gtk_icon_view_real_select_cursor_item),
321 (gtk_icon_view_real_activate_cursor_item):
323 Add an "activate_cursor_item" action signal
324 and bind it to the return key.
326 2004-07-04 Anders Carlsson <andersca@gnome.org>
328 * demos/gtk-demo/Makefile.am:
329 * demos/gtk-demo/gnome-fs-directory.png:
330 * demos/gtk-demo/gnome-fs-regular.png:
331 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
332 (sort_func), (create_store), (item_activated), (up_clicked),
333 (home_clicked), (do_iconview):
334 Add a simple file browser based on the icon view.
337 Add gtk/gtkiconview.h
339 * gtk/gtkiconview.c: (gtk_icon_view_layout),
340 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
341 Fix a few bugs discovered while writing the demo.
343 2004-07-04 Anders Carlsson <andersca@gnome.org>
348 Add GtkIconView to the build, remove debugging output.
350 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
352 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
353 (gtk_calendar_drag_data_received): Fix off-by-one error.
354 GDate month is one-based and GtkCalendar month is zero-based.
355 (#145134, William Jon McCann)
357 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
359 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
360 somebody tries to move a node after itself in a list of
361 length 1. (#145291, Sampo Nurmentaus)
363 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
365 * docs/faq/gtk-faq.sgml:
366 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
369 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
371 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
372 and current_height to 0 when ending the embedding. (#143675,
375 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
377 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
378 to the right end of the entry text, even if it ends in combining
379 marks. (#141728, Theppitak Karoonboonyanan)
381 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
383 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
384 row when unsetting the model. (#138560, Christian Persch)
386 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
388 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
391 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
393 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
394 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
396 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
398 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
399 to the event mask, set a scroll_event handler.
400 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
401 by switching tabs. (#145244, Gabriel de Perthuis)
403 2004-07-02 Anders Carlsson <andersca@gnome.org>
405 * gtk/gtktreeview.c (gtk_tree_view_set_model):
406 Make sure we check for a NULL model first.
408 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
410 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
411 win32 build problem w/o wintab. Fixed #145242
413 2004-06-30 Anders Carlsson <andersca@gnome.org>
415 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
416 g_return_if_fail to make sure that the model is a GtkTreeModel.
418 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
420 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
421 current state, not GTK_STATE_NORMAL
423 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
425 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
427 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
429 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
431 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
432 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
435 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
437 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
438 recursion by resetting icon_set->cache before freeing
439 the cache. (#144947, Tim Janik)
441 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
443 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
444 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
445 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
448 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
450 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
451 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
452 last change in the docs.
454 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
456 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
457 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
458 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
460 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
462 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
463 placement policy for GtkComboBoxEntry to be: if it fits below,
464 place below, if it fits above place above, else place in the
465 larger space and scroll so that the scroll arrow appear at the
466 far end. (#144362, David A. Knight)
468 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
470 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
471 use of &parent_iter. (#145007, John Finlay)
473 2004-06-25 Bastien Nocera <hadess@hadess.net>
475 reviewed by: Matthias Clasen <maclas@gmx.de>
477 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
478 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
479 the number of keysyms per keycode is odd. Fixes #144808.
481 2004-06-25 Matthias Clasen <mclasen@redhat.com>
483 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
484 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
486 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
488 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
489 which was mentioned below.
491 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
493 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
494 string change. (#139503, Baris Cicek)
496 2004-06-22 Federico Mena Quintero <federico@ximian.com>
498 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
499 or an Open stock button for the C-l dialog depending on the action
500 in which the file chooser operates. Fixes #141753.
502 2004-06-22 Federico Mena Quintero <federico@ximian.com>
504 Fixes the GTK+ part of #142308:
506 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
507 Use filename_to_path().
508 (gtk_file_system_unix_uri_to_path): Likewise.
509 (filename_to_path): Use remove_trailing_slash().
511 2004-06-22 Matthias Clasen <mclasen@redhat.com>
513 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
514 for the ::move_cursor signal.
516 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
517 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
520 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
521 this gets defined for all backends, so linux-fb has a
524 * gdk/x11/gdkgc-x11.c:
525 * gdk/gdkgc.c: Move function docs inline, add hints about
526 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
528 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
529 for children of the root. (#139785, Jean-François Wauthy,
530 patch by John Finlay)
532 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
533 fix. (#144750, Jeff Franks)
535 2004-06-21 Michael Natterer <mitch@gimp.org>
538 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
539 function public as _gdk_x11_convert_to_format().
541 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
542 the pixels from the GdkPixbuf when putting them in the
543 Xcursor image. Fixes bug #144350.
545 2004-06-16 Federico Mena Quintero <federico@ximian.com>
547 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
548 visible node, free the old path before creating the new one.
551 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
553 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
554 (#144198, Mariano Suárez-Alvarez)
556 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
558 * gtk/gtkfilechooserdefault.c: Don't use
559 contractions like "don't" or "isn't" in error messages.
560 It isn't nice to use them in log entries either...
561 (#137774, Morten Welinder, patch by Alexander Winston)
563 2004-06-11 Federico Mena Quintero <federico@ximian.com>
567 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
568 Don't ref the editable node.
569 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
570 (_gtk_file_system_model_remove_editable): Ahem, free the node.
572 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
573 Added fields for edited_idle and edited_new_text.
574 (renderer_edited_cb): Queue the
575 creation of the folder in an idle handler.
576 (renderer_editing_canceled_cb): Likewise for the cancellation.
577 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
579 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
581 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
583 2004-06-10 Federico Mena Quintero <federico@ximian.com>
585 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
587 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
588 Refer to gtk_file_chooser_add_shortcut_folder().
589 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
590 gtk_file_chooser_add_shortcut_folder_uri().
592 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
594 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
595 the drag before focusing the selected.day.
596 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
597 a beginning drag if the widget becomes insensitive.
599 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
601 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
602 spinning before calling arrow_action(), so that a signal
603 handler triggered from arrow_action() has a chance to
604 stop the spinning. (#143966, Davyd Madeley)
606 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
608 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
609 typo. (#144070, Kent Sandvik)
611 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
613 * gtk/gtkmenu.c: Revert the "drag select" part of
616 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
618 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
619 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
621 2004-06-07 Federico Mena Quintero <federico@ximian.com>
623 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
624 from 2003/Sep/12. This kept DnD in tree views within modal
625 dialogs from working, which is especially bad for the file
626 chooser. Fixes #135168.
628 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
630 Make the entry context menu work in editable text cells. The changes
631 are based on a patch by Kristian Rietveld, which implemented an
632 approach outlined by Owen Taylor. (#50075)
634 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
635 Ignore focus out if the entry menu is posted.
636 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
637 posted, and set up a signal handler to clear the flag if the menu
639 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
640 set up a timeout to stop editing if the focus is lost.
641 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
642 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
643 signal on the entry and keep a pointer to the entry.
644 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
645 clear the pointer to the entry.
647 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
649 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
650 of the ::language property. (#143802, Owen Taylor)
652 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
654 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
655 (gtk_entry_completion_list_enter_notify),
656 (gtk_entry_completion_list_motion_notify),
657 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
658 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
659 use it as in the menu code to avoid the initial selection if
660 the window pops up under the pointer. (Anders Carlsson)
662 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
664 * tests/testmerge.c: Add a checkbox to queue an
665 merge/unmerge. Patch from Matthias Clasen.
667 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
669 (rebuild_menu): New function that rebuilds the overflow menu and
670 makes sure it doesn't start or end with a separator.
671 (toolbar_content_new_tool_item)
672 (toolbar_content_remove)
673 (toolbar_content_new_compatibility): Set the rebuild_needed flag
674 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
675 have actually overflown an item with a proxy menu item. Also make
676 sure we rebuild the menu if needed.
678 Fix #125504, #142377, #143463
680 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
681 Obey the "priv->draw" flag. (#143692)
683 2004-06-04 Matthias Clasen <mclasen@redhat.com>
685 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
686 quirk in the button size allocation code.
688 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
689 requested for drawing the focus indicator to the child in the
690 !CAN_FOCUS case. This should fix issues which the Gimp has with
691 the button allocation changes in 2.4.2.
693 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
695 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
696 length of the entry contents in characters, not in bytes.
698 * gtk/gtkentry.c (paste_received): Don't pop up the completion
699 window on paste, noticed by Anders Carlsson.
701 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
703 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
704 values and default value for the ::active property. (#143669,
707 2004-06-03 Michael Natterer <mitch@gimp.org>
709 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
710 instead of accessing item->image->allocation.width/height
711 directly. Makes widgets which only have a requisition set using
712 gtk_widget_set_size_request() work and fixes bug #142789.
714 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
716 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
717 of sticky right click menus to return.
719 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
721 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
722 better handle the "click" case. bug Better fix for #141169.
724 2004-06-02 Federico Mena Quintero <federico@ximian.com>
726 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
727 model is empty. Fixes #143536.
729 2004-06-02 Matthias Clasen <mclasen@redhat.com>
731 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
732 close the dialog on focus out of the size entry. (#143505,
735 2004-06-02 Federico Mena Quintero <federico@ximian.com>
739 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
740 (gtk_fnmatch_intern): Likewise; also implement this option.
742 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
744 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
745 no_leading_period argument of _gtk_fnmatch().
746 (attempt_file_completion): Likewise.
748 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
749 no_leading_period argument of _gtk_fnmatch().
751 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
753 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
756 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
758 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
759 allow unless selection mode is multiple. (#142634, John Finlay)
761 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
765 * gtk/gtkentrycompletion.h:
766 * gtk/gtkentrycompletion.c:
768 * gtk/gtkcombobox.c: Rename function parameters from
769 index to index_ to prevent clash with BSD index(). (#143001)
771 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
773 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
774 NULL on an accel label. (#139641, Sam Stephenson, patch by
777 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
779 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
780 lookup finding icons in the wrong prefix. (#143328,
783 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
787 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
788 only stay up if you release within 500 milliseconds.
789 (gtk_menu_shell_button_press): Set the activate_time to the event
790 time when a button is pressed.
792 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
793 Interprete button releases as activate when we have seen both an
794 enter an a motion event.
796 2004-06-01 Federico Mena Quintero <federico@ximian.com>
798 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
799 dummy node if there is no parent node. Fixes #143362.
801 2004-05-31 Federico Mena Quintero <federico@ximian.com>
803 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
804 newly-created folder. Fixes #138932.
805 (trap_activate_cb): Only return TRUE if we did handle the event.
806 Fixes #143359; patch by jylefort@brutele.be.
808 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
810 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
811 docs. (#142892, Tommi Komulainen)
813 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
815 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
816 parent is minimized, porting the fix from 1.2. (#1923, #57182)
818 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
820 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
821 unmapped windows work.
823 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
825 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
828 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
830 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
831 Refer to ::update-preview, not ::selection-changed.
833 2004-05-29 Christian Rose <menthos@menthos.com>
835 * configure.in: Added "tk" to ALL_LINGUAS.
837 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
839 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
840 messages for common problems. (#137974, Owen Taylor)
842 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
844 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
845 errors. (#143337, Billy Biggs)
847 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
849 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
850 bits within visual->depth that aren't used for color to
851 1s, in case they are alpha.
853 2004-05-27 Anders Carlsson <andersca@gnome.org>
855 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
856 Make separator rows insensitive.
858 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
860 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
863 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
865 * gtk/gtkentrycompletion.h:
866 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
867 Getter for text_column. Also make ::text_column a property.
869 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
871 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
873 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
875 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
876 signal if the box exists.
878 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
880 Support insensitive cells in tree views and combo boxes:
882 * gtk/gtkcellrenderer.h:
883 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
885 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
886 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
887 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
888 Support drawing insensitive.
891 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
892 function to obtain the cell renderers from a cell view. Also
893 export gtk_cell_view_set_cell_data().
895 * gtk/gtktreeselection.c (tree_column_is_sensitive):
896 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
897 to determine whether all visible cells in a row are insensitive
898 and whether a row is selectable. A row is not selectable if the
899 user function says so or if all visible cells are insensitive.
900 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
901 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
902 Use row_is_selectable().
904 * gtk/gtkcombobox.c (row_is_sensitive):
905 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
906 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
907 to determine row sensitivity in menu or list mode.
909 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
910 to set up sensitivity menu items from the underlying rows.
912 * gtk/gtkcombobox.c (gtk_combo_box_popup):
913 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
914 update_menu_sensitivity().
916 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
919 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
922 * tests/testcombo.c (main): Make some rows insensitive.
924 2004-05-26 Robert Ögren <gtk@roboros.com>
926 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
927 modifiers (shift, ctrl etc) in button and motion events from the
930 2004-05-26 Robert Ögren <gtk@roboros.com>
932 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
933 implementation for extended input devices using last known
934 device state (#143237)
936 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
938 * gtk/gtkframe.c: Move docs inline, fixing them on the
939 way. (#143029, Steve Chaplin)
941 2004-05-11 Robert Ögren <gtk@roboros.com>
943 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
944 events to windows that want extended input events. (#142943)
945 (gdk_event_translate): Move check for extended input devices to
946 propagate, new parameter to propagate.
947 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
948 _gdk_input_(un)grab_pointer. (#142943)
950 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
951 input grab. [Fix missing update of impl in "dijkstra" event
952 propagation loop] Drop the parallel "impl" pointer, just use a
953 cast. Don't propagate beyond windows that want normal input
955 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
956 implementation of input grab. (#142943)
958 2004-05-22 Tor Lillqvist <tml@iki.fi>
960 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
961 line. (Spotted by Benoît Carpentier.)
963 2004-05-18 Matthias Clasen <mclasen@redhat.com>
965 * configure.in: Check for XFIXES extension.
967 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
968 a gboolean have_xfixes member.
970 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
971 XFIXES events and set have_xfixes.
973 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
974 (GdkEventOwnerChange): New event struct for owner change events.
975 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
977 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
978 XFixesSelectionNotify events into GdkEventOwnerChange events.
981 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
982 (gdk_display_request_selection_notification): New api
983 to support selection ownership notification.
985 * gtk/gtkclipboard.h:
986 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
987 api to handle owner change events.
988 (clipboard_peek): Refactored out the body of
989 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
991 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
992 by calling _gtk_clipboard_handle_event().
994 2004-05-18 Matthias Clasen <mclasen@redhat.com>
996 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
997 the P_() macros ourselves.
999 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1000 Restrict the width of the popup to be no larger than the
1001 monitor. (#142678, DmD Ljungmark)
1003 * gtk/gtkbutton.c: Go back to the initial fix for the
1004 focus-overdrawing problem, which was actually correct
1005 according to docs/widget_geometry.txt.
1007 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
1008 arrow size from 11 to 15 to compensate for that.
1010 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
1011 arguments of the ::move-cursor signal. (#142725)
1013 2004-05-17 Matthias Clasen <mclasen@redhat.com>
1017 * gtk/gtkbutton.c (gtk_button_size_request)
1018 (gtk_button_size_allocate, _gtk_button_paint): Allocate
1019 space for the focus rectangle only if necessary. (#142668,
1022 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
1026 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
1027 lines. (#142479, Morten Welinder)
1029 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
1031 * gtk/gtkintl.h (Q_): Add a Q_() macro.
1033 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
1034 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
1035 they are not really needed.
1037 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
1038 instead of hardwired padding, use Q_() for the default label,
1039 compute a reasonable minimal size. (#142571, #142572, #142573,
1040 Tommi Komulainen, Christian Persch)
1042 2004-05-15 Tor Lillqvist <tml@iki.fi>
1044 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
1045 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
1046 time). It is used by the OLE2_DND code, which is unfinished and
1047 presumably horribly broken, but still, let's not make it not
1048 compile on purpose. Silence some gcc warnings in the OLE2_DND
1051 2004-05-14 Matthias Clasen <mclasen@redhat.com>
1053 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
1054 New function to go from tree window to tree coordinates, kept
1055 static for now until we figure out the multiple coordinate
1056 system mess in GtkTreeView API-wise.
1057 (gtk_tree_view_scroll_to_cell): Transform the coordinates
1058 from tree window to tree coordinates, using the new function.
1059 Previously, the x coordinate was wrongly transformed. (#142494)
1061 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
1064 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
1065 modifier bit to mark stock item which need to be freed
1066 eventually. (#140654, Michal Pasternak, Scott Tsai)
1068 2004-05-11 Robert Ögren <gtk@roboros.com>
1070 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
1071 call to g_object_ref in Wintab code. (#138341)
1073 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
1074 including unallocated buffers for event->motion.axes and
1075 event->button.axes, unsigned wraparound problem in the code for
1076 detecting missing press/release events and assigning min instead
1077 of max when setting up axes.
1079 2004-05-12 Matthias Clasen <mclasen@redhat.com>
1081 * tests/testtreeedit.c: Add a progress column.
1083 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
1086 * gtk/gtk.h: Include gtkcellrendererprogress.h.
1088 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
1089 based on the one found in Epiphany.
1091 2004-05-11 Michael Natterer <mitch@gimp.org>
1093 * gtk/gtkcombobox.c (gtk_combo_box_popup)
1094 (gtk_combo_box_menu_button_press): don't allocate the popup
1095 smaller than the combobox. Fixes bug #59660.
1097 2004-05-11 Matthias Clasen <mclasen@redhat.com>
1099 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
1100 previous change to this function, clarify the docs instead.
1102 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
1103 GTK_SELECTION_BROWSE.
1105 * gtk/gtktreeview.c: Make hover selection work for
1106 GTK_SELECTION_BROWSE as well.
1108 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
1110 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
1111 Document the ::toggled signal.
1113 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1115 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
1117 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1119 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
1121 * gdk/gdkdisplay.c (singlehead_...):
1122 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
1123 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
1124 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
1126 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
1127 note about COLUMN_FIXED restriction.
1129 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
1130 Set the entry in the default handler of the ::match-selected signal.
1133 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
1134 do the move-selected-item below pointer thingie, do the
1135 place-below-or-above one.
1137 * tests/testentrycompletion.c: Make the second example use the
1138 ::match-selected signal to make it actually work.
1140 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
1141 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
1142 mode. (#127648, Dave Bordoley)
1144 * gtk/gtktreeview.h:
1145 * gtk/gtktreeview.c: Add a new property "hover_selection", which
1146 when TRUE makes the selection follow the mouse. Also add setter
1147 and getter for the fixed_height property.
1149 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1151 * gtk/gtkcombobox.c (gtk_combo_box_popup)
1152 (gtk_combo_box_menu_button_press): Make sure the menu pops up
1153 as wide as the combobox. (#59660, Havoc Pennington)
1155 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1157 * gtk/gtkcombobox.h:
1158 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
1159 mode). Add a new property, add-tearoffs, for this. (#135956)
1161 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
1162 default button. (#118921)
1164 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1166 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
1167 that emits the grab notify signal.
1169 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
1171 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
1173 * gtk/gtkmenu.c: Make destruction of a torn off menu work
1174 like un-tearing off.
1176 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
1180 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1181 Allow to suppress the stock accelerator by using "". (#142196,
1184 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
1188 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
1189 In list mode, accept the same mouse/wheel bindings on
1190 the cellview as on the button. (#136967)
1192 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
1194 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
1195 cached icons. (#135888, Crispin Flowerday)
1197 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
1199 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
1200 that we actually return menus for nodes of type menu, not the
1201 menuitems they're attached to.
1203 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
1205 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
1206 Add a note regarding UTF-8 requirements, proposed by
1207 Mariano Suárez-Alvarez.
1209 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
1211 * gtk/gtktearoffmenuitem.h:
1212 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
1213 into the GtkTearoffMenuItem struct, since it is used
1214 by the Gimp, and keep it synchronized with the
1215 tearoff_state property of the parent menu.
1217 2004-05-08 Hans Breuer <hans@breuer.org>
1219 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
1220 create the correct mask for 'pseudo mime' icons
1222 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
1223 take focus_on_map into account
1225 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
1227 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
1228 ... must return a value
1230 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
1232 2004-05-07 Matthias Clasen <mclasen@redhat.com>
1234 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
1235 draw over the focus rectangle.
1237 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
1238 standard focus style. (#63071, Bill Haneman, idea for new
1239 style by Owen Taylor)
1241 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
1242 focus on the colorwheel via details.
1244 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1248 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
1249 this no longer needed signal handler. (#141817, Paul Pogonyshev)
1251 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
1253 * gtk/gtktearoffmenuitem.h:
1254 * gtk/gtktearoffmenuitem.c: Make the tearoff
1255 functionality model/view, the tearoffmenuitem being
1256 the view and the tearoff_state property of the menu
1257 being the model. (#101185, Owen Taylor)
1259 * gtk/gtkmenu.c: Add a tearoff_state property.
1261 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
1265 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
1266 popup the submenu for items in torn off menus. (#122051)
1268 2004-05-06 Sven Neumann <sven@gimp.org>
1270 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
1271 position the title lable next to the arrow just as we do for LTR
1272 rendering. Fixes bug #141825.
1274 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1276 * docs/RELEASE-HOWTO: Document the new policy of
1277 bumping version numbers after release.
1279 * configure.in: Bump version number to 2.5.0.
1281 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
1284 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
1287 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
1289 * gtk/gtkactiongroup.h:
1290 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
1291 New function to translate a string with translate_func.
1294 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
1296 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
1297 (gtk_combo_box_get_row_span_column):
1298 (gtk_combo_box_get_column_span_column): Add missing getters
1299 for readwrite properies. (#135649)
1301 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
1303 * gtk/gtkcombobox.h:
1304 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
1305 Add gtk_combo_box_get_active_text() convenience
1306 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
1308 2004-05-05 Elijah Newren <newren@math.utah.edu>
1310 Changes to support do-not-focus-on-map hint in conjunction with
1311 _NET_WM_USER_TIME (#115650):
1313 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
1316 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
1319 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
1320 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
1322 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
1323 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
1324 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
1325 Initialize the focus_on_map field to TRUE.
1327 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
1328 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
1329 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
1330 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
1331 Implementations for the various backends. The Win32 and linux-fb
1332 implementations set the focus_on_map field, but don't use it yet
1333 to actually implement noinput windows. The X implementation sets
1334 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
1336 * gdk/x11/gdkwindow-x11.h:
1337 * gdk/x11/gdkevents-x11.c (set_user_time):
1338 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1339 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
1340 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
1341 since we want that function to be part of the public API.
1343 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
1347 * gtk/gtkiconfactory.c (icon_source_clear): Don't
1348 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
1350 2004-05-05 Matthias Clasen <mclasen@redhat.com>
1354 * gtk/gtkuimanager.c (print_node): Make the output
1355 parseable. (#141929, Sven Neumann)
1357 2004-05-05 Tor Lillqvist <tml@iki.fi>
1359 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
1360 multi-monitor offset. (#141842, John Ehresman)
1362 2004-05-04 Federico Mena Quintero <federico@ximian.com>
1364 Fixes #139562, based on a patch by Christian Neumair.
1366 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
1367 a filter_combo_hbox field to contain the filter combo.
1368 (show_filters): Show/hide the filter_combo_hbox.
1369 (create_filename_entry_and_filter_combo): Removed.
1370 (file_pane_create): Create the filter_combo_hbox here.
1372 2004-05-04 Matthias Clasen <mclasen@redhat.com>
1374 * modules/input/gtkimcontextxim.c: Fix the recent
1375 string_conversion_callback change to work on
1376 Solaris. (#141190, Padraig O'Briain)
1378 * gtk/gtkselection.c: Disable debug logging again.
1380 2004-05-03 Matthias Clasen <mclasen@redhat.com>
1382 * gtk/gtkselection.c: Make the chunk size for
1383 incremental transfers depend on the maximal request
1384 size, capped at 256k. This should allow most selections
1385 to be transferred nonincrementally, avoiding many
1386 roundtrips and protocol overhead.
1388 2004-05-03 Federico Mena Quintero <federico@ximian.com>
1390 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
1391 g_signal_new() correctly and initialize the signal fields. Fixes
1392 #141749; patch based on Michael Natterer's.
1394 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
1396 * gtk/gtkselection.c (_gtk_selection_request): Fix
1397 a debug message to show correct information.
1398 (_gtk_selection_incr_event): Make INCRemental transfer
1399 of MULTIPLE targets work. This was broken since 1997!
1401 2004-05-02 Hans Breuer <hans@breuer.org>
1403 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
1404 modify the passed in GdkSegment(s) in place, we may get
1405 them again to draw at the same place. Fixes bug #129095,
1407 (draw_segments) draw the end pixel again to get the
1408 pixmap mask right, fixes bug #126710, #130202
1410 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
1411 fixes bug #106013, John Ehresman
1413 * gtk/makefile.msc.in : don't try to link gtk.res but
1414 use gtk-win32.res (as supposed to be fixed below :)
1416 2004-05-01 Hans Breuer <hans@breuer.org>
1418 * tests/Makefile.am : tests/makefile.msc is in CVS for
1419 a long time, finally added to EXTRA_DIST : fixes bug
1420 #141334, John Ehresman
1422 2004-04-30 Matthias Clasen <mclasen@redhat.com>
1424 * === Released 2.4.1 ===
1426 * configure.in: Version 2.4.1, interface age 1.
1430 2004-04-29 Federico Mena Quintero <federico@ximian.com>
1434 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
1435 function; moved the code over from
1436 remove_bookmark_button_clicked_cb().
1437 (remove_selected_bookmarks): Now, getting a non-removable bookmark
1438 is not an error, as we may be called as a result of hitting the
1440 (shortcuts_key_press_event_cb): New handler; delete the bookmark
1441 if the user presses Backspace, Delete, or KP_Delete.
1443 2004-04-29 Matthias Clasen <mclasen@redhat.com>
1445 * gtk/gtkaction.c (closure_accel_activate): Use
1446 _gtk_action_emit_activate() instead of directly
1447 emitting the activate signal. (#141429, Jody Goldberg)
1449 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1450 Warn people when the accelerator can not be
1451 parsed. (#141429, Jody Goldberg)
1453 2004-04-29 Matthias Clasen <mclasen@redhat.com>
1455 * tests/testentrycompletion.c (main): Add a missing
1456 cat. (#141070, Chris Sherlock)
1458 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
1459 variable. (#141022, Chris Sherlock)
1461 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
1462 cast. (#141013, Chris Sherlock)
1464 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
1465 unused variable. (#141011, Chris Sherlock)
1467 2004-04-29 Tor Lillqvist <tml@iki.fi>
1469 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
1470 leak. (#140775, John Ehresman)
1472 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
1474 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
1475 to index the cached gcs, not depth. (#139494)
1477 2004-04-28 Matthias Clasen <mclasen@redhat.com>
1479 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
1481 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1483 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
1484 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
1486 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
1488 Patch to add support for string conversion callbacks to
1489 GtkIMContextXIM (#101814)
1491 * modules/input/gtkimcontextxim.c: Set the string conversion callback
1492 if supported by the XIC.
1494 (struct _GtkIMContextXIM): Add string_conversion_callback member.
1496 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
1497 whether string conversion callback is supported.
1499 (gtk_im_context_get_ic, +set_string_conversion_callback,
1500 +string_conversion_callback): Also initialize string conversion
1501 callback, if supported, along with the IC initialization.
1503 * modules/input/imxim.c: Make "xim" module default for Thai as well.
1505 2004-04-23 Matthias Clasen <mclasen@redhat.com>
1507 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
1508 initialize targets. (#139883, John Finlay)
1510 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
1512 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
1513 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
1514 Tim-Philipp Müller)
1516 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
1517 Remove an excessive g_return_if_fail().
1519 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
1521 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1522 _-prefix calls of gdk_x11_window_set_user_time().
1524 2004-04-22 Matthias Clasen <mclasen@redhat.com>
1526 * gtk/gtkuimanager.c (update_node): Make sure the separators
1527 used to demarkate placeholder ends don't show up on
1528 show_all(). (#140496, Murray Cumming)
1530 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
1531 work with negative increments. (#137975, Tim Gerla)
1533 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1535 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
1536 gtk_tool_button_set_icon_widget): Remove the old widget from the
1537 tool button before overwriting it with the new widget.
1539 (#140508, Todd Goyen)
1541 2004-04-22 Tor Lillqvist <tml@iki.fi>
1543 Fix the file chooser on Windows. I can't make it misbehave or
1544 crash any more now. But presumably there are still corner cases
1545 not handled. I haven't really checked behaviour of UNC paths, for
1548 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
1549 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
1552 (gtk_file_system_win32_get_parent): Like the Unix version, assert
1553 filename is absolute, and avoid one unnecessary string allocation
1556 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
1557 letters more correctly.
1559 (gtk_file_system_win32_render_icon): Assure correct syntax is used
1560 for root folder of a drive. (#137962, Morten Welinder)
1562 (filename_is_some_root): New function that accepts also root
1563 without any drive specified.
1565 (filename_is_drive_root): Rename from filename_is_root.
1567 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
1570 2004-04-21 Matthias Clasen <mclasen@redhat.com>
1572 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
1573 completion window if there are no completions anymore.
1575 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1576 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
1577 It doesn't like that. (#140642, Christian Persch)
1579 * demos/gtk-demo/expander.c (do_expander): A new demo.
1581 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
1583 2004-04-20 Matthias Clasen <mclasen@redhat.com>
1585 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
1586 sure anchored children get size allocated, even if the layout
1587 is valid. (#122323, Andrew E. Makeev)
1588 (gtk_text_view_scroll_pages):
1589 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
1590 if we already have pending scrolls. Bandaid fix for #78513.
1592 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
1594 * INSTALL.in: Update libpng and libjpeg URLs, remove
1595 note about building without since that's not the normal
1598 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
1600 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
1601 handling of SVG/non-SVG unthemed icons.
1603 2004-04-19 Morten Welinder <terra@gnome.org>
1605 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
1608 2004-04-19 Matthias Clasen <mclasen@redhat.com>
1610 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1611 Don't stop the iteration up to the tag_root too
1612 early. (#109945, Dongho Shin)
1614 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1616 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
1617 gdk_keymap_translate_keyboard_state() handle NULL
1618 keymaps. (#139715, Torsten Schoenfeld).
1620 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1622 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
1623 reported by Pedro RODRIGUEZ, about compilation problems when
1624 Xcursor is installed in a non-standard location.
1626 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1628 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
1631 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
1632 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
1634 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
1636 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
1639 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
1640 property on user interaction.
1642 2004-04-15 Federico Mena Quintero <federico@ximian.com>
1644 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
1645 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
1647 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
1648 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
1651 2004-04-15 Matthias Clasen <mclasen@redhat.com>
1653 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1654 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
1656 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1658 * gtk/gtkcombobox.c:
1660 Make all style properties readonly.
1662 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1664 * gtk/gtkcolorsel.c: Add a11y relations between the color
1665 wheel and the spin buttons. (#132745, Padraig O'Briain)
1667 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
1668 the meaning of size == -1.
1670 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
1671 a size of -1. (#137436, Brian Cameron)
1673 * gtk/gtkcombobox.c: Make the arrow and separator regular
1674 children of an hbox inside the button, and propagate state
1675 changes from the button to the cell view. (part of the fix
1676 for #138650, should also fix #137535)
1678 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
1679 state to gtk_cell_renderer_render() when prelighted. (part
1680 of the fix for #138650)
1682 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1683 Use PRELIGHT state when appropriate. (part of the fix for
1686 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
1687 out warnings if called before the combo box is
1688 realized. (#139742, Philip Langdale)
1690 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
1692 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
1695 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
1697 * gtk/gtkpathbar.c (make_directory_button): remove spurious
1700 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
1702 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
1703 make the buttons sized by a bold label. This makes the text
1704 'swim' a little, but stops the buttons from resizing, #137210
1706 2004-04-13 Matthias Clasen <mclasen@redhat.com>
1708 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
1710 (start_element_handler): Accept separators without unique
1711 names. (#133302, Anders Carlsson)
1713 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
1714 possible accelerator gotcha when using this function. (#139641,
1717 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
1718 list nodes. (#138862, Morten Welinder)
1720 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
1722 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
1724 (gtk_tree_view_button_press): If we activated the row we don't
1725 want to grab focus back, as moving focus to another widget is
1726 pretty common, #138458
1728 2004-04-12 Federico Mena Quintero <federico@ximian.com>
1730 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
1731 documentation to all the signals.
1733 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
1735 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
1736 model if it is NULL. (#139770)
1738 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
1740 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
1741 a shadow inside the scrolled window, add it around the vbox.
1743 * gtk/gtkentryprivate.h:
1744 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1745 Return a boolean indicating whether the popup is positioned above
1746 or below. Scroll the completions to the beginning or the end,
1747 depending on the positioning.
1749 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
1750 wrap around in the entry completion popup, and allow GDK_UP to
1751 enter the popup. (#137440)
1753 2004-04-12 Matthias Clasen <mclasen@redhat.com>
1755 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
1756 there before using it.
1758 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
1760 * gtk/gtktreeprivate.h: Moved search entries into priv data.
1762 * gtk/gtktreeview.c: Prep for type-ahead support.
1764 (gtk_tree_view_destroy): Destroy the search window explicitly.
1765 (gtk_tree_view_key_press): Minor change; prep for type-ahead
1766 (gtk_tree_view_ensure_interactive_directory): New function
1767 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
1768 (gtk_tree_view_real_start_interactive_search): rework
1769 (gtk_tree_view_search_dialog_hide): ditto
1770 (gtk_tree_view_search_delete_event): ditto
1771 (gtk_tree_view_search_button_press_event): ditto
1772 (gtk_tree_view_search_key_press_event): ditto
1773 (gtk_tree_view_search_move): ditto
1774 (gtk_tree_view_search_init): ditto
1776 * gtk/gtktreeviewcolumn.c:
1777 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
1779 * tests/testfilechooser.c: (main): change
1781 2004-04-11 Hans Breuer <hans@breuer.org>
1783 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
1784 the real fix would involve just another small API breakage,
1785 i.e. gdk_spawn_* using GPid not just gint.
1787 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
1789 2004-04-10 Tor Lillqvist <tml@iki.fi>
1791 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
1792 If both Shift and CapsLock pressed, ignore the shift only for
1793 letters (that would have been affected by the CapsLock). (#139095)
1795 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
1796 seems to be even buggier now than it used to be. (#138341)
1797 Initialize _gdk_input_ignore_wintab to TRUE.
1799 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
1800 GDK_USE_WINTAB environment variable to turn on tablet support.
1802 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
1804 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
1805 (gtk_ui_manager_remove_action_group): Terminate
1806 g_object_[dis]connect() calls with NULL instead of 0.
1809 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
1811 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
1813 2004-04-07 Federico Mena Quintero <federico@ximian.com>
1817 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
1818 passed-in 'str' is not NULL.
1820 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
1821 expands "~/" or "~foo/" at the beginning of a filename.
1822 (gtk_file_system_unix_parse): Use expand_tilde() before doing
1825 * gtk/gtkfilechooserentry.c
1826 (gtk_file_chooser_entry_maybe_update_directory): Take in a
1827 force_reload argument.
1828 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
1829 returns an error, set the file_part_pos to -1.
1830 (load_directory_callback): Only populate the model if the
1831 file_part_pos is not -1.
1833 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
1835 * configure.in: Added Icelandic (is) to ALL_LINGUAS
1837 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1839 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
1840 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
1842 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
1843 for G_DIR_SEPARATOR in the display_name, and err out if it is
1844 present; use the same error message as Nautilus. Fixes #136467.
1846 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
1847 new-folder button say "Create Fo_lder" rather than "Create
1848 _Folder", so that the mnemonic doesn't conflict with the "Save in
1849 _folder" label. Fixes #136975.
1851 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1853 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
1854 buttons. Also, free them correctly upon failure. Based on a
1855 patch by Morten Welinder, fixes #137956.
1857 2004-04-05 Anders Carlsson <andersca@gnome.org>
1859 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
1861 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
1863 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
1864 correctly for fixed height when inserting a node, #138082
1866 2004-04-01 Federico Mena Quintero <federico@ximian.com>
1870 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
1871 "child_is_hidden" boolean argument to the "path-clicked" signal.
1873 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
1875 (make_directory_button): Take a file_is_hidden argument; put it in
1877 (_gtk_path_bar_set_path): See whether each path component path is
1879 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
1880 "path-clicked" signal.
1881 (button_clicked_cb): See if the downwards button represents a
1882 hidden file for the file_is_hidden argument in the signal
1885 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
1887 * gtk/gtkfilechooserdefault.c
1888 (gtk_file_chooser_default_select_path): If we fail to switch
1889 folders, don't try to select the path in the file system model.
1890 Also, return the result from _gtk_file_system_model_path_do().
1891 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
1892 file system model if we are asked to select a hidden file.
1893 (path_bar_clicked): Show hidden files based on whether the
1894 immediate downwards folder in the path bar is a hidden file
1896 (struct _GtkFileChooserDefault): Added fields
1897 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
1898 (create_file_list): Set an object data key of
1899 "GtkFileChooserDefault" on the tree view so that we can find the
1900 impl from the popup menu callbacks. Also, hook up to the
1901 "button-press-event" and "popup-menu" signals in the file list to
1902 bring up a popup menu.
1903 (list_popup_menu_cb): New callback.
1904 (list_button_press_event_cb): New callback.
1908 * gtk/gtkfilesystemmodel.c
1909 (_gtk_file_system_model_new): Oops, connect_object to
1912 2004-03-31 Tor Lillqvist <tml@iki.fi>
1914 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
1915 for native Win32. (#136559, J. Ali Harlow)
1917 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
1918 angles. Thanks to Tim Newsham.
1920 2004-03-29 Federico Mena Quintero <federico@ximian.com>
1924 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1925 for an ::is_finished_loading() method and a ::finished_loading()
1926 signal at the end of the struct.
1928 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1929 "finished-loading" signal.
1930 (gtk_file_folder_is_finished_loading): New function.
1932 * gtk/gtkfilesystemunix.c
1933 (gtk_file_folder_unix_is_finished_loading): Implement.
1935 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1936 slot for a "finished-loading" signal.
1937 (gtk_file_system_model_class_init): Create the "finished-loading"
1939 (struct _GtkFileSystemModel): New field
1940 idle_finished_loading_source. We emit the "finished-loading"
1941 signal in an idle if the root folder was done loading right in
1942 _gtk_file_system_model_new(), so that the caller has a chance to
1943 connect to the signal.
1944 (_gtk_file_system_model_new): Connect to the normal signals of the
1945 folder even if the initial _list_children() fails. Also, see if
1946 the folder is finished loading; connect to the "finished-loading"
1948 (gtk_file_system_model_finalize): Remove the idle handler.
1950 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1951 and connect to the model's "finished-loading" signal.
1952 (get_toplevel): New helper function.
1953 (error_message): Use get_toplevel().
1954 (trap_activate_cb): Likewise.
1955 (location_popup_handler): Likewise.
1956 (set_busy_cursor): New function.
1957 (browse_files_model_finished_loading_cb): New callback.
1959 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1961 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
1962 file under the cursor; we don't need the logic from
1963 GtkFileSelection after all. Fixes #132255.
1965 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1967 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
1968 location entry with the display name of the file under the cursor
1969 for Open mode, or the typed filename in Save mode.
1971 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1973 * gtk/gtkfilesystemwin32.c
1974 (filename_is_root): Bare drive designators (eg., "c:") are
1975 no longer considered as root filenames. Fixed #137942
1977 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1979 * gtk/gtkfilesystemwin32.c
1980 (gtk_file_system_win32_create_folder): Invert test for error in
1981 mkdir. Fixes #137945
1983 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1985 Fixed #138004 using Federico's code from #132327.
1987 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
1988 folder_hash field to keep a list of live folder objects.
1989 (gtk_file_system_win32_init): Create the folder_hash.
1990 (gtk_file_system_win32_finalize): Destroy the folder_hash.
1991 (gtk_file_system_win32_get_folder): Ref and return an existing
1992 folder if we have it around, otherwise return a new folder object.
1993 (struct _GtkFileFolderWin32): Add a field for the parent file system.
1994 (gtk_file_folder_win32_finalize): Remove the folder from the file
1995 system's hash table.
1996 (gtk_file_system_win32_create_folder): Emit "files-added" on the
1997 newly-created folder's parent. Fixes #138004.
1999 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2001 * gtk/gtkfilesystemwin32.c
2002 (gtk_file_system_win32_get_folder): Test that path is actually
2003 a directory and throw error if not. Fixed bug #137950
2005 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
2007 * gtk/gtkfilesystemwin32.c
2008 (gtk_file_system_win32_volume_get_display_name): Ignore empty
2009 volume labels; assume that GetVolumeInformation would fail if
2010 GetVolumeInformationW does; catches a small memory leak;
2011 pass the buffer size to GetVolumeInformationW in wide
2012 characters instead of bytes. Fixes bug #137543
2013 (list_volumes): Cope with the theoretical possibility of
2014 more than 26 logical drives. Fixes bug #137940
2015 (bookmarks_serialize): Now actually removes bookmarks.
2018 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
2020 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
2022 2004-03-21 Tor Lillqvist <tml@iki.fi>
2024 * gtk/gtkfilesystemwin32.c
2025 (gtk_file_system_win32_volume_get_base_path): Include the
2026 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
2027 NULL for a volume base path, as g_filename_to_uri() requires an
2028 absolute path, and just a drive letter and colon isn't. (#137543)
2030 2004-03-20 Hans Breuer <hans@breuer.org>
2032 * gtk/gtkfilesystemwin32.c : applied the undisputable and
2033 required [due to recent gtkfilesystem internal api semantic
2034 changes] part of patches to fix bug #137543 (Tor Lillqvist,
2037 * gdk/gdkevents-win32.c (handle_configure_event) :
2038 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
2039 GdkWindowObject::x, y with screen coords to make
2040 gdk_window_get_position () return the right thing and thus fix
2041 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
2043 2004-03-19 Federico Mena Quintero <federico@ximian.com>
2045 * Revert the patch to #137520, as 2.4.1 is for conservative bug
2046 fixes only. The patch is attached to the bug report, for
2049 2004-03-19 Morten Welinder <terra@gnome.org>
2051 * gtk/gtkfilechooserdefault.c
2052 (gtk_file_chooser_default_set_current_folder): Test existance of
2053 the path after checking for locality, if needed.
2055 2004-03-19 Federico Mena Quintero <federico@ximian.com>
2059 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
2060 for an ::is_finished_loading() method and a ::finished_loading()
2061 signal at the end of the struct.
2063 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
2064 "finished-loading" signal.
2065 (gtk_file_folder_is_finished_loading): New function.
2067 * gtk/gtkfilesystemunix.c
2068 (gtk_file_folder_unix_is_finished_loading): Implement.
2070 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
2071 slot for a "finished-loading" signal.
2072 (gtk_file_system_model_class_init): Create the "finished-loading"
2074 (struct _GtkFileSystemModel): New field
2075 idle_finished_loading_source. We emit the "finished-loading"
2076 signal in an idle if the root folder was done loading right in
2077 _gtk_file_system_model_new(), so that the caller has a chance to
2078 connect to the signal.
2079 (_gtk_file_system_model_new): Connect to the normal signals of the
2080 folder even if the initial _list_children() fails. Also, see if
2081 the folder is finished loading; connect to the "finished-loading"
2083 (gtk_file_system_model_finalize): Remove the idle handler.
2085 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
2086 and connect to the model's "finished-loading" signal.
2087 (get_toplevel): New helper function.
2088 (error_message): Use get_toplevel().
2089 (trap_activate_cb): Likewise.
2090 (location_popup_handler): Likewise.
2091 (set_busy_cursor): New function.
2092 (browse_files_model_finished_loading_cb): New callback.
2094 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
2096 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
2097 eventbox for expander. (#137564, reported by
2100 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
2102 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
2104 2004-03-17 Morten Welinder <terra@gnome.org>
2106 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
2107 volumes not actually put into the shortcut list.
2109 * tests/prop-editor.c (object_changed): Plug leak.
2111 * tests/testfilechooser.c (main): Plug some leaks and expose
2114 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
2115 object. Fixed #136652.
2117 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
2118 have no screen. Fixes #137260.
2119 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
2120 thereby fixing leak. Fixes #137259.
2122 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
2123 slider buttons have been destroyed.
2124 (gtk_path_bar_remove): Make this work for slider buttons too.
2127 2004-03-15 Morten Welinder <terra@gnome.org>
2129 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
2130 Sanitize and plug leak.
2131 (check_icon_theme): Only do something if the widget has a screen.
2133 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
2135 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2136 Move the repositioning logic from _gtk_entry_completion() popup
2137 over here. Fixes #137355, reported by Niklas Knutsson.