1 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
3 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
4 when a new model is set. (#145566, Dmitry M. Shatrov)
6 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
8 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
9 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
10 in order to avoid rendering artifacts from misaligned
11 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
13 2004-07-07 Matthias Clasen <mclasen@redhat.com>
16 * gtk/gtktreeview.h: Small documentation fixes.
18 2004-07-07 Matthias Clasen <mclasen@redhat.com>
20 Support separators in combo boxes and more generally in tree
24 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
25 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
26 Add a ::row-separator-column property with getter and setter,
27 which can indicate a boolean model column to determine which
30 * gtk/gtkcombobox.c: Display separator rows as separator menu
31 items in menu mode, and by using the new treeview separator
32 functionality in list mode.
35 * gtk/gtktreeprivate.h:
36 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
37 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
38 Add a callback to determine whether a row is a separator.
40 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
41 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
42 * gtk/gtktreeview.c (validate_row): Use the new callback
43 to determine whether a row is a separator, and draw it
44 as a separator then. Since separators should take up less
45 vertical space than regular rows, this requires removing
46 the redundant MAX(...,expander_size) calls which appear in
47 many places. Instead, the MAX() is now only done in
48 validate_row(), and only if the row is not a separator.
49 To catch possible side effects of this intrusive change,
50 I have left EXPANDER_MAX() calls in place of the MAX() calls
51 which will emit a warning if something breaks. They should
52 be removed before 2.6.
54 * gtk/gtktreeselection.c (row_is_selectable): Don't let
55 separator rows be selected.
57 * tests/testcombo.c (create_blaat): Add a separator column.
59 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
61 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
62 a 64bit alignment issue. (#144302, Sunil)
64 2004-07-07 Tor Lillqvist <tml@iki.fi>
66 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
67 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
68 * gdk/win32/gdkproperty-win32.c (find_common_locale,
70 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
71 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
74 * gdk/win32/gdkglobals-win32.c
75 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
76 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
77 atom. Initialize it. Declare it. Drop the variable for the
80 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
81 function is supposed to return the string in the locale's charset
82 and encoding. Use g_convert().
84 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
85 string in the locale's charset. Use g_convert().
87 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
88 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
89 GLib's UTF-16 functions instead. Windows uses UTF-16.
91 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
92 functions mentioned above.
94 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
95 also if the string is of type STRING, i.e. ISO-8859-1, and the
96 current codepage is 1252, and contains no C1 chars. Accept
99 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
100 Mark as static. When storing STRING data, convert to
102 (gdk_selection_owner_set_for_display): Now that STRING is always
103 ISO-8859-1, use UTF8_STRING when sending the selection request
106 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
109 (gdk_text_property_to_text_list_for_display): Make work more like
110 X11 version. Do obey the encoding parameter.
112 (gdk_string_to_compound_text_for_display,
113 gdk_utf8_to_compound_text_for_display): Don't even pretend
114 supporting COMPOUND_TEXT.
116 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
118 (sanitize_utf8): Zero-terminate string.
120 2004-07-06 Matthias Clasen <mclasen@redhat.com>
122 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
123 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
125 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
126 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
127 fallbacks for gtkfilechooser. Currently these are the same images
128 as the "new" and "open" items...
130 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
132 Fix for #136496, Pawel Salek:
134 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
135 a node when it changes in fixed_height mode.
137 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
140 2004-07-06 Matthias Clasen <mclasen@redhat.com>
142 * gtk/gtkmenu.c (gtk_menu_position): Make sure
143 private->monitor_num is a valid monitor number before
144 using it. (#139187, Michael Natterer)
146 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
148 * gtk/gtkfilechooserdefault.c (popup_position_func):
149 * gtk/gtkentry.c (popup_position_func):
150 * gtk/gtktextview.c (popup_position_func): Improve positioning
151 of keyboard-activated menus with Xinerama.
153 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
155 * gtk/gtkuimanager.c (do_updates):
156 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
157 when called from an idle handler. (#145429, Jan-Marek Glogowski)
159 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
161 * gtk/gtkfilechooserutils.c (delegate_notify): Use
162 the less efficient g_object_interface_find_property () instead
163 of the param_id range check, since the GParamSpecs we're
164 dealing with are the overridden onces on the interface, whose
165 param_id is always zero. (#145312, Alex Roitman, fix proposed
168 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
170 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
171 virtual method of GtkContainer.
172 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
173 method slot of the container class.
175 2004-07-05 Anders Carlsson <andersca@gnome.org>
177 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
179 Use gint, not int in gtk_icon_view_set_markup_column,
182 2004-07-05 Anders Carlsson <andersca@gnome.org>
184 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
185 (gtk_icon_view_real_select_cursor_item),
186 (gtk_icon_view_real_activate_cursor_item):
188 Add an "activate_cursor_item" action signal
189 and bind it to the return key.
191 2004-07-04 Anders Carlsson <andersca@gnome.org>
193 * demos/gtk-demo/Makefile.am:
194 * demos/gtk-demo/gnome-fs-directory.png:
195 * demos/gtk-demo/gnome-fs-regular.png:
196 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
197 (sort_func), (create_store), (item_activated), (up_clicked),
198 (home_clicked), (do_iconview):
199 Add a simple file browser based on the icon view.
202 Add gtk/gtkiconview.h
204 * gtk/gtkiconview.c: (gtk_icon_view_layout),
205 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
206 Fix a few bugs discovered while writing the demo.
208 2004-07-04 Anders Carlsson <andersca@gnome.org>
213 Add GtkIconView to the build, remove debugging output.
215 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
217 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
218 (gtk_calendar_drag_data_received): Fix off-by-one error.
219 GDate month is one-based and GtkCalendar month is zero-based.
220 (#145134, William Jon McCann)
222 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
224 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
225 somebody tries to move a node after itself in a list of
226 length 1. (#145291, Sampo Nurmentaus)
228 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
230 * docs/faq/gtk-faq.sgml:
231 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
234 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
236 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
237 and current_height to 0 when ending the embedding. (#143675,
240 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
242 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
243 to the right end of the entry text, even if it ends in combining
244 marks. (#141728, Theppitak Karoonboonyanan)
246 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
248 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
249 row when unsetting the model. (#138560, Christian Persch)
251 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
253 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
256 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
258 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
259 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
261 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
263 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
264 to the event mask, set a scroll_event handler.
265 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
266 by switching tabs. (#145244, Gabriel de Perthuis)
268 2004-07-02 Anders Carlsson <andersca@gnome.org>
270 * gtk/gtktreeview.c (gtk_tree_view_set_model):
271 Make sure we check for a NULL model first.
273 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
275 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
276 win32 build problem w/o wintab. Fixed #145242
278 2004-06-30 Anders Carlsson <andersca@gnome.org>
280 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
281 g_return_if_fail to make sure that the model is a GtkTreeModel.
283 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
285 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
286 current state, not GTK_STATE_NORMAL
288 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
290 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
292 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
294 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
296 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
297 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
300 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
302 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
303 recursion by resetting icon_set->cache before freeing
304 the cache. (#144947, Tim Janik)
306 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
308 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
309 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
310 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
313 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
315 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
316 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
317 last change in the docs.
319 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
321 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
322 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
323 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
325 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
327 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
328 placement policy for GtkComboBoxEntry to be: if it fits below,
329 place below, if it fits above place above, else place in the
330 larger space and scroll so that the scroll arrow appear at the
331 far end. (#144362, David A. Knight)
333 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
335 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
336 use of &parent_iter. (#145007, John Finlay)
338 2004-06-25 Bastien Nocera <hadess@hadess.net>
340 reviewed by: Matthias Clasen <maclas@gmx.de>
342 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
343 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
344 the number of keysyms per keycode is odd. Fixes #144808.
346 2004-06-25 Matthias Clasen <mclasen@redhat.com>
348 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
349 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
351 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
353 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
354 which was mentioned below.
356 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
358 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
359 string change. (#139503, Baris Cicek)
361 2004-06-22 Federico Mena Quintero <federico@ximian.com>
363 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
364 or an Open stock button for the C-l dialog depending on the action
365 in which the file chooser operates. Fixes #141753.
367 2004-06-22 Federico Mena Quintero <federico@ximian.com>
369 Fixes the GTK+ part of #142308:
371 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
372 Use filename_to_path().
373 (gtk_file_system_unix_uri_to_path): Likewise.
374 (filename_to_path): Use remove_trailing_slash().
376 2004-06-22 Matthias Clasen <mclasen@redhat.com>
378 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
379 for the ::move_cursor signal.
381 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
382 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
385 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
386 this gets defined for all backends, so linux-fb has a
389 * gdk/x11/gdkgc-x11.c:
390 * gdk/gdkgc.c: Move function docs inline, add hints about
391 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
393 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
394 for children of the root. (#139785, Jean-François Wauthy,
395 patch by John Finlay)
397 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
398 fix. (#144750, Jeff Franks)
400 2004-06-21 Michael Natterer <mitch@gimp.org>
403 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
404 function public as _gdk_x11_convert_to_format().
406 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
407 the pixels from the GdkPixbuf when putting them in the
408 Xcursor image. Fixes bug #144350.
410 2004-06-16 Federico Mena Quintero <federico@ximian.com>
412 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
413 visible node, free the old path before creating the new one.
416 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
418 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
419 (#144198, Mariano Suárez-Alvarez)
421 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
423 * gtk/gtkfilechooserdefault.c: Don't use
424 contractions like "don't" or "isn't" in error messages.
425 It isn't nice to use them in log entries either...
426 (#137774, Morten Welinder, patch by Alexander Winston)
428 2004-06-11 Federico Mena Quintero <federico@ximian.com>
432 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
433 Don't ref the editable node.
434 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
435 (_gtk_file_system_model_remove_editable): Ahem, free the node.
437 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
438 Added fields for edited_idle and edited_new_text.
439 (renderer_edited_cb): Queue the
440 creation of the folder in an idle handler.
441 (renderer_editing_canceled_cb): Likewise for the cancellation.
442 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
444 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
446 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
448 2004-06-10 Federico Mena Quintero <federico@ximian.com>
450 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
452 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
453 Refer to gtk_file_chooser_add_shortcut_folder().
454 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
455 gtk_file_chooser_add_shortcut_folder_uri().
457 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
459 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
460 the drag before focusing the selected.day.
461 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
462 a beginning drag if the widget becomes insensitive.
464 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
466 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
467 spinning before calling arrow_action(), so that a signal
468 handler triggered from arrow_action() has a chance to
469 stop the spinning. (#143966, Davyd Madeley)
471 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
473 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
474 typo. (#144070, Kent Sandvik)
476 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
478 * gtk/gtkmenu.c: Revert the "drag select" part of
481 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
483 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
484 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
486 2004-06-07 Federico Mena Quintero <federico@ximian.com>
488 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
489 from 2003/Sep/12. This kept DnD in tree views within modal
490 dialogs from working, which is especially bad for the file
491 chooser. Fixes #135168.
493 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
495 Make the entry context menu work in editable text cells. The changes
496 are based on a patch by Kristian Rietveld, which implemented an
497 approach outlined by Owen Taylor. (#50075)
499 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
500 Ignore focus out if the entry menu is posted.
501 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
502 posted, and set up a signal handler to clear the flag if the menu
504 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
505 set up a timeout to stop editing if the focus is lost.
506 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
507 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
508 signal on the entry and keep a pointer to the entry.
509 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
510 clear the pointer to the entry.
512 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
514 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
515 of the ::language property. (#143802, Owen Taylor)
517 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
519 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
520 (gtk_entry_completion_list_enter_notify),
521 (gtk_entry_completion_list_motion_notify),
522 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
523 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
524 use it as in the menu code to avoid the initial selection if
525 the window pops up under the pointer. (Anders Carlsson)
527 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
529 * tests/testmerge.c: Add a checkbox to queue an
530 merge/unmerge. Patch from Matthias Clasen.
532 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
534 (rebuild_menu): New function that rebuilds the overflow menu and
535 makes sure it doesn't start or end with a separator.
536 (toolbar_content_new_tool_item)
537 (toolbar_content_remove)
538 (toolbar_content_new_compatibility): Set the rebuild_needed flag
539 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
540 have actually overflown an item with a proxy menu item. Also make
541 sure we rebuild the menu if needed.
543 Fix #125504, #142377, #143463
545 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
546 Obey the "priv->draw" flag. (#143692)
548 2004-06-04 Matthias Clasen <mclasen@redhat.com>
550 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
551 quirk in the button size allocation code.
553 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
554 requested for drawing the focus indicator to the child in the
555 !CAN_FOCUS case. This should fix issues which the Gimp has with
556 the button allocation changes in 2.4.2.
558 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
560 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
561 length of the entry contents in characters, not in bytes.
563 * gtk/gtkentry.c (paste_received): Don't pop up the completion
564 window on paste, noticed by Anders Carlsson.
566 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
568 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
569 values and default value for the ::active property. (#143669,
572 2004-06-03 Michael Natterer <mitch@gimp.org>
574 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
575 instead of accessing item->image->allocation.width/height
576 directly. Makes widgets which only have a requisition set using
577 gtk_widget_set_size_request() work and fixes bug #142789.
579 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
581 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
582 of sticky right click menus to return.
584 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
586 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
587 better handle the "click" case. bug Better fix for #141169.
589 2004-06-02 Federico Mena Quintero <federico@ximian.com>
591 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
592 model is empty. Fixes #143536.
594 2004-06-02 Matthias Clasen <mclasen@redhat.com>
596 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
597 close the dialog on focus out of the size entry. (#143505,
600 2004-06-02 Federico Mena Quintero <federico@ximian.com>
604 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
605 (gtk_fnmatch_intern): Likewise; also implement this option.
607 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
609 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
610 no_leading_period argument of _gtk_fnmatch().
611 (attempt_file_completion): Likewise.
613 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
614 no_leading_period argument of _gtk_fnmatch().
616 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
618 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
621 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
623 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
624 allow unless selection mode is multiple. (#142634, John Finlay)
626 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
630 * gtk/gtkentrycompletion.h:
631 * gtk/gtkentrycompletion.c:
633 * gtk/gtkcombobox.c: Rename function parameters from
634 index to index_ to prevent clash with BSD index(). (#143001)
636 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
638 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
639 NULL on an accel label. (#139641, Sam Stephenson, patch by
642 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
644 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
645 lookup finding icons in the wrong prefix. (#143328,
648 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
652 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
653 only stay up if you release within 500 milliseconds.
654 (gtk_menu_shell_button_press): Set the activate_time to the event
655 time when a button is pressed.
657 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
658 Interprete button releases as activate when we have seen both an
659 enter an a motion event.
661 2004-06-01 Federico Mena Quintero <federico@ximian.com>
663 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
664 dummy node if there is no parent node. Fixes #143362.
666 2004-05-31 Federico Mena Quintero <federico@ximian.com>
668 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
669 newly-created folder. Fixes #138932.
670 (trap_activate_cb): Only return TRUE if we did handle the event.
671 Fixes #143359; patch by jylefort@brutele.be.
673 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
675 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
676 docs. (#142892, Tommi Komulainen)
678 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
680 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
681 parent is minimized, porting the fix from 1.2. (#1923, #57182)
683 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
685 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
686 unmapped windows work.
688 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
690 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
693 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
695 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
696 Refer to ::update-preview, not ::selection-changed.
698 2004-05-29 Christian Rose <menthos@menthos.com>
700 * configure.in: Added "tk" to ALL_LINGUAS.
702 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
704 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
705 messages for common problems. (#137974, Owen Taylor)
707 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
709 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
710 errors. (#143337, Billy Biggs)
712 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
714 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
715 bits within visual->depth that aren't used for color to
716 1s, in case they are alpha.
718 2004-05-27 Anders Carlsson <andersca@gnome.org>
720 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
721 Make separator rows insensitive.
723 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
725 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
728 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
730 * gtk/gtkentrycompletion.h:
731 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
732 Getter for text_column. Also make ::text_column a property.
734 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
736 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
738 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
740 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
741 signal if the box exists.
743 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
745 Support insensitive cells in tree views and combo boxes:
747 * gtk/gtkcellrenderer.h:
748 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
750 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
751 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
752 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
753 Support drawing insensitive.
756 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
757 function to obtain the cell renderers from a cell view. Also
758 export gtk_cell_view_set_cell_data().
760 * gtk/gtktreeselection.c (tree_column_is_sensitive):
761 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
762 to determine whether all visible cells in a row are insensitive
763 and whether a row is selectable. A row is not selectable if the
764 user function says so or if all visible cells are insensitive.
765 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
766 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
767 Use row_is_selectable().
769 * gtk/gtkcombobox.c (row_is_sensitive):
770 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
771 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
772 to determine row sensitivity in menu or list mode.
774 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
775 to set up sensitivity menu items from the underlying rows.
777 * gtk/gtkcombobox.c (gtk_combo_box_popup):
778 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
779 update_menu_sensitivity().
781 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
784 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
787 * tests/testcombo.c (main): Make some rows insensitive.
789 2004-05-26 Robert Ögren <gtk@roboros.com>
791 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
792 modifiers (shift, ctrl etc) in button and motion events from the
795 2004-05-26 Robert Ögren <gtk@roboros.com>
797 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
798 implementation for extended input devices using last known
799 device state (#143237)
801 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
803 * gtk/gtkframe.c: Move docs inline, fixing them on the
804 way. (#143029, Steve Chaplin)
806 2004-05-11 Robert Ögren <gtk@roboros.com>
808 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
809 events to windows that want extended input events. (#142943)
810 (gdk_event_translate): Move check for extended input devices to
811 propagate, new parameter to propagate.
812 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
813 _gdk_input_(un)grab_pointer. (#142943)
815 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
816 input grab. [Fix missing update of impl in "dijkstra" event
817 propagation loop] Drop the parallel "impl" pointer, just use a
818 cast. Don't propagate beyond windows that want normal input
820 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
821 implementation of input grab. (#142943)
823 2004-05-22 Tor Lillqvist <tml@iki.fi>
825 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
826 line. (Spotted by Benoît Carpentier.)
828 2004-05-18 Matthias Clasen <mclasen@redhat.com>
830 * configure.in: Check for XFIXES extension.
832 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
833 a gboolean have_xfixes member.
835 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
836 XFIXES events and set have_xfixes.
838 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
839 (GdkEventOwnerChange): New event struct for owner change events.
840 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
842 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
843 XFixesSelectionNotify events into GdkEventOwnerChange events.
846 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
847 (gdk_display_request_selection_notification): New api
848 to support selection ownership notification.
850 * gtk/gtkclipboard.h:
851 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
852 api to handle owner change events.
853 (clipboard_peek): Refactored out the body of
854 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
856 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
857 by calling _gtk_clipboard_handle_event().
859 2004-05-18 Matthias Clasen <mclasen@redhat.com>
861 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
862 the P_() macros ourselves.
864 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
865 Restrict the width of the popup to be no larger than the
866 monitor. (#142678, DmD Ljungmark)
868 * gtk/gtkbutton.c: Go back to the initial fix for the
869 focus-overdrawing problem, which was actually correct
870 according to docs/widget_geometry.txt.
872 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
873 arrow size from 11 to 15 to compensate for that.
875 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
876 arguments of the ::move-cursor signal. (#142725)
878 2004-05-17 Matthias Clasen <mclasen@redhat.com>
882 * gtk/gtkbutton.c (gtk_button_size_request)
883 (gtk_button_size_allocate, _gtk_button_paint): Allocate
884 space for the focus rectangle only if necessary. (#142668,
887 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
891 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
892 lines. (#142479, Morten Welinder)
894 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
896 * gtk/gtkintl.h (Q_): Add a Q_() macro.
898 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
899 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
900 they are not really needed.
902 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
903 instead of hardwired padding, use Q_() for the default label,
904 compute a reasonable minimal size. (#142571, #142572, #142573,
905 Tommi Komulainen, Christian Persch)
907 2004-05-15 Tor Lillqvist <tml@iki.fi>
909 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
910 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
911 time). It is used by the OLE2_DND code, which is unfinished and
912 presumably horribly broken, but still, let's not make it not
913 compile on purpose. Silence some gcc warnings in the OLE2_DND
916 2004-05-14 Matthias Clasen <mclasen@redhat.com>
918 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
919 New function to go from tree window to tree coordinates, kept
920 static for now until we figure out the multiple coordinate
921 system mess in GtkTreeView API-wise.
922 (gtk_tree_view_scroll_to_cell): Transform the coordinates
923 from tree window to tree coordinates, using the new function.
924 Previously, the x coordinate was wrongly transformed. (#142494)
926 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
929 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
930 modifier bit to mark stock item which need to be freed
931 eventually. (#140654, Michal Pasternak, Scott Tsai)
933 2004-05-11 Robert Ögren <gtk@roboros.com>
935 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
936 call to g_object_ref in Wintab code. (#138341)
938 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
939 including unallocated buffers for event->motion.axes and
940 event->button.axes, unsigned wraparound problem in the code for
941 detecting missing press/release events and assigning min instead
942 of max when setting up axes.
944 2004-05-12 Matthias Clasen <mclasen@redhat.com>
946 * tests/testtreeedit.c: Add a progress column.
948 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
951 * gtk/gtk.h: Include gtkcellrendererprogress.h.
953 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
954 based on the one found in Epiphany.
956 2004-05-11 Michael Natterer <mitch@gimp.org>
958 * gtk/gtkcombobox.c (gtk_combo_box_popup)
959 (gtk_combo_box_menu_button_press): don't allocate the popup
960 smaller than the combobox. Fixes bug #59660.
962 2004-05-11 Matthias Clasen <mclasen@redhat.com>
964 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
965 previous change to this function, clarify the docs instead.
967 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
968 GTK_SELECTION_BROWSE.
970 * gtk/gtktreeview.c: Make hover selection work for
971 GTK_SELECTION_BROWSE as well.
973 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
975 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
976 Document the ::toggled signal.
978 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
980 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
982 2004-05-10 Matthias Clasen <mclasen@redhat.com>
984 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
986 * gdk/gdkdisplay.c (singlehead_...):
987 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
988 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
989 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
991 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
992 note about COLUMN_FIXED restriction.
994 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
995 Set the entry in the default handler of the ::match-selected signal.
998 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
999 do the move-selected-item below pointer thingie, do the
1000 place-below-or-above one.
1002 * tests/testentrycompletion.c: Make the second example use the
1003 ::match-selected signal to make it actually work.
1005 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
1006 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
1007 mode. (#127648, Dave Bordoley)
1009 * gtk/gtktreeview.h:
1010 * gtk/gtktreeview.c: Add a new property "hover_selection", which
1011 when TRUE makes the selection follow the mouse. Also add setter
1012 and getter for the fixed_height property.
1014 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1016 * gtk/gtkcombobox.c (gtk_combo_box_popup)
1017 (gtk_combo_box_menu_button_press): Make sure the menu pops up
1018 as wide as the combobox. (#59660, Havoc Pennington)
1020 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1022 * gtk/gtkcombobox.h:
1023 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
1024 mode). Add a new property, add-tearoffs, for this. (#135956)
1026 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
1027 default button. (#118921)
1029 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1031 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
1032 that emits the grab notify signal.
1034 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
1036 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
1038 * gtk/gtkmenu.c: Make destruction of a torn off menu work
1039 like un-tearing off.
1041 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
1045 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1046 Allow to suppress the stock accelerator by using "". (#142196,
1049 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
1053 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
1054 In list mode, accept the same mouse/wheel bindings on
1055 the cellview as on the button. (#136967)
1057 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
1059 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
1060 cached icons. (#135888, Crispin Flowerday)
1062 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
1064 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
1065 that we actually return menus for nodes of type menu, not the
1066 menuitems they're attached to.
1068 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
1070 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
1071 Add a note regarding UTF-8 requirements, proposed by
1072 Mariano Suárez-Alvarez.
1074 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
1076 * gtk/gtktearoffmenuitem.h:
1077 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
1078 into the GtkTearoffMenuItem struct, since it is used
1079 by the Gimp, and keep it synchronized with the
1080 tearoff_state property of the parent menu.
1082 2004-05-08 Hans Breuer <hans@breuer.org>
1084 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
1085 create the correct mask for 'pseudo mime' icons
1087 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
1088 take focus_on_map into account
1090 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
1092 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
1093 ... must return a value
1095 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
1097 2004-05-07 Matthias Clasen <mclasen@redhat.com>
1099 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
1100 draw over the focus rectangle.
1102 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
1103 standard focus style. (#63071, Bill Haneman, idea for new
1104 style by Owen Taylor)
1106 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
1107 focus on the colorwheel via details.
1109 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1113 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
1114 this no longer needed signal handler. (#141817, Paul Pogonyshev)
1116 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
1118 * gtk/gtktearoffmenuitem.h:
1119 * gtk/gtktearoffmenuitem.c: Make the tearoff
1120 functionality model/view, the tearoffmenuitem being
1121 the view and the tearoff_state property of the menu
1122 being the model. (#101185, Owen Taylor)
1124 * gtk/gtkmenu.c: Add a tearoff_state property.
1126 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
1130 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
1131 popup the submenu for items in torn off menus. (#122051)
1133 2004-05-06 Sven Neumann <sven@gimp.org>
1135 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
1136 position the title lable next to the arrow just as we do for LTR
1137 rendering. Fixes bug #141825.
1139 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1141 * docs/RELEASE-HOWTO: Document the new policy of
1142 bumping version numbers after release.
1144 * configure.in: Bump version number to 2.5.0.
1146 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
1149 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
1152 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
1154 * gtk/gtkactiongroup.h:
1155 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
1156 New function to translate a string with translate_func.
1159 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
1161 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
1162 (gtk_combo_box_get_row_span_column):
1163 (gtk_combo_box_get_column_span_column): Add missing getters
1164 for readwrite properies. (#135649)
1166 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
1168 * gtk/gtkcombobox.h:
1169 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
1170 Add gtk_combo_box_get_active_text() convenience
1171 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
1173 2004-05-05 Elijah Newren <newren@math.utah.edu>
1175 Changes to support do-not-focus-on-map hint in conjunction with
1176 _NET_WM_USER_TIME (#115650):
1178 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
1181 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
1184 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
1185 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
1187 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
1188 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
1189 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
1190 Initialize the focus_on_map field to TRUE.
1192 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
1193 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
1194 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
1195 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
1196 Implementations for the various backends. The Win32 and linux-fb
1197 implementations set the focus_on_map field, but don't use it yet
1198 to actually implement noinput windows. The X implementation sets
1199 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
1201 * gdk/x11/gdkwindow-x11.h:
1202 * gdk/x11/gdkevents-x11.c (set_user_time):
1203 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1204 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
1205 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
1206 since we want that function to be part of the public API.
1208 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
1212 * gtk/gtkiconfactory.c (icon_source_clear): Don't
1213 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
1215 2004-05-05 Matthias Clasen <mclasen@redhat.com>
1219 * gtk/gtkuimanager.c (print_node): Make the output
1220 parseable. (#141929, Sven Neumann)
1222 2004-05-05 Tor Lillqvist <tml@iki.fi>
1224 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
1225 multi-monitor offset. (#141842, John Ehresman)
1227 2004-05-04 Federico Mena Quintero <federico@ximian.com>
1229 Fixes #139562, based on a patch by Christian Neumair.
1231 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
1232 a filter_combo_hbox field to contain the filter combo.
1233 (show_filters): Show/hide the filter_combo_hbox.
1234 (create_filename_entry_and_filter_combo): Removed.
1235 (file_pane_create): Create the filter_combo_hbox here.
1237 2004-05-04 Matthias Clasen <mclasen@redhat.com>
1239 * modules/input/gtkimcontextxim.c: Fix the recent
1240 string_conversion_callback change to work on
1241 Solaris. (#141190, Padraig O'Briain)
1243 * gtk/gtkselection.c: Disable debug logging again.
1245 2004-05-03 Matthias Clasen <mclasen@redhat.com>
1247 * gtk/gtkselection.c: Make the chunk size for
1248 incremental transfers depend on the maximal request
1249 size, capped at 256k. This should allow most selections
1250 to be transferred nonincrementally, avoiding many
1251 roundtrips and protocol overhead.
1253 2004-05-03 Federico Mena Quintero <federico@ximian.com>
1255 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
1256 g_signal_new() correctly and initialize the signal fields. Fixes
1257 #141749; patch based on Michael Natterer's.
1259 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
1261 * gtk/gtkselection.c (_gtk_selection_request): Fix
1262 a debug message to show correct information.
1263 (_gtk_selection_incr_event): Make INCRemental transfer
1264 of MULTIPLE targets work. This was broken since 1997!
1266 2004-05-02 Hans Breuer <hans@breuer.org>
1268 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
1269 modify the passed in GdkSegment(s) in place, we may get
1270 them again to draw at the same place. Fixes bug #129095,
1272 (draw_segments) draw the end pixel again to get the
1273 pixmap mask right, fixes bug #126710, #130202
1275 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
1276 fixes bug #106013, John Ehresman
1278 * gtk/makefile.msc.in : don't try to link gtk.res but
1279 use gtk-win32.res (as supposed to be fixed below :)
1281 2004-05-01 Hans Breuer <hans@breuer.org>
1283 * tests/Makefile.am : tests/makefile.msc is in CVS for
1284 a long time, finally added to EXTRA_DIST : fixes bug
1285 #141334, John Ehresman
1287 2004-04-30 Matthias Clasen <mclasen@redhat.com>
1289 * === Released 2.4.1 ===
1291 * configure.in: Version 2.4.1, interface age 1.
1295 2004-04-29 Federico Mena Quintero <federico@ximian.com>
1299 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
1300 function; moved the code over from
1301 remove_bookmark_button_clicked_cb().
1302 (remove_selected_bookmarks): Now, getting a non-removable bookmark
1303 is not an error, as we may be called as a result of hitting the
1305 (shortcuts_key_press_event_cb): New handler; delete the bookmark
1306 if the user presses Backspace, Delete, or KP_Delete.
1308 2004-04-29 Matthias Clasen <mclasen@redhat.com>
1310 * gtk/gtkaction.c (closure_accel_activate): Use
1311 _gtk_action_emit_activate() instead of directly
1312 emitting the activate signal. (#141429, Jody Goldberg)
1314 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1315 Warn people when the accelerator can not be
1316 parsed. (#141429, Jody Goldberg)
1318 2004-04-29 Matthias Clasen <mclasen@redhat.com>
1320 * tests/testentrycompletion.c (main): Add a missing
1321 cat. (#141070, Chris Sherlock)
1323 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
1324 variable. (#141022, Chris Sherlock)
1326 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
1327 cast. (#141013, Chris Sherlock)
1329 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
1330 unused variable. (#141011, Chris Sherlock)
1332 2004-04-29 Tor Lillqvist <tml@iki.fi>
1334 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
1335 leak. (#140775, John Ehresman)
1337 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
1339 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
1340 to index the cached gcs, not depth. (#139494)
1342 2004-04-28 Matthias Clasen <mclasen@redhat.com>
1344 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
1346 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1348 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
1349 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
1351 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
1353 Patch to add support for string conversion callbacks to
1354 GtkIMContextXIM (#101814)
1356 * modules/input/gtkimcontextxim.c: Set the string conversion callback
1357 if supported by the XIC.
1359 (struct _GtkIMContextXIM): Add string_conversion_callback member.
1361 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
1362 whether string conversion callback is supported.
1364 (gtk_im_context_get_ic, +set_string_conversion_callback,
1365 +string_conversion_callback): Also initialize string conversion
1366 callback, if supported, along with the IC initialization.
1368 * modules/input/imxim.c: Make "xim" module default for Thai as well.
1370 2004-04-23 Matthias Clasen <mclasen@redhat.com>
1372 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
1373 initialize targets. (#139883, John Finlay)
1375 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
1377 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
1378 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
1379 Tim-Philipp Müller)
1381 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
1382 Remove an excessive g_return_if_fail().
1384 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
1386 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1387 _-prefix calls of gdk_x11_window_set_user_time().
1389 2004-04-22 Matthias Clasen <mclasen@redhat.com>
1391 * gtk/gtkuimanager.c (update_node): Make sure the separators
1392 used to demarkate placeholder ends don't show up on
1393 show_all(). (#140496, Murray Cumming)
1395 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
1396 work with negative increments. (#137975, Tim Gerla)
1398 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1400 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
1401 gtk_tool_button_set_icon_widget): Remove the old widget from the
1402 tool button before overwriting it with the new widget.
1404 (#140508, Todd Goyen)
1406 2004-04-22 Tor Lillqvist <tml@iki.fi>
1408 Fix the file chooser on Windows. I can't make it misbehave or
1409 crash any more now. But presumably there are still corner cases
1410 not handled. I haven't really checked behaviour of UNC paths, for
1413 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
1414 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
1417 (gtk_file_system_win32_get_parent): Like the Unix version, assert
1418 filename is absolute, and avoid one unnecessary string allocation
1421 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
1422 letters more correctly.
1424 (gtk_file_system_win32_render_icon): Assure correct syntax is used
1425 for root folder of a drive. (#137962, Morten Welinder)
1427 (filename_is_some_root): New function that accepts also root
1428 without any drive specified.
1430 (filename_is_drive_root): Rename from filename_is_root.
1432 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
1435 2004-04-21 Matthias Clasen <mclasen@redhat.com>
1437 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
1438 completion window if there are no completions anymore.
1440 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1441 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
1442 It doesn't like that. (#140642, Christian Persch)
1444 * demos/gtk-demo/expander.c (do_expander): A new demo.
1446 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
1448 2004-04-20 Matthias Clasen <mclasen@redhat.com>
1450 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
1451 sure anchored children get size allocated, even if the layout
1452 is valid. (#122323, Andrew E. Makeev)
1453 (gtk_text_view_scroll_pages):
1454 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
1455 if we already have pending scrolls. Bandaid fix for #78513.
1457 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
1459 * INSTALL.in: Update libpng and libjpeg URLs, remove
1460 note about building without since that's not the normal
1463 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
1465 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
1466 handling of SVG/non-SVG unthemed icons.
1468 2004-04-19 Morten Welinder <terra@gnome.org>
1470 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
1473 2004-04-19 Matthias Clasen <mclasen@redhat.com>
1475 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1476 Don't stop the iteration up to the tag_root too
1477 early. (#109945, Dongho Shin)
1479 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1481 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
1482 gdk_keymap_translate_keyboard_state() handle NULL
1483 keymaps. (#139715, Torsten Schoenfeld).
1485 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1487 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
1488 reported by Pedro RODRIGUEZ, about compilation problems when
1489 Xcursor is installed in a non-standard location.
1491 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1493 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
1496 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
1497 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
1499 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
1501 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
1504 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
1505 property on user interaction.
1507 2004-04-15 Federico Mena Quintero <federico@ximian.com>
1509 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
1510 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
1512 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
1513 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
1516 2004-04-15 Matthias Clasen <mclasen@redhat.com>
1518 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1519 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
1521 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1523 * gtk/gtkcombobox.c:
1525 Make all style properties readonly.
1527 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1529 * gtk/gtkcolorsel.c: Add a11y relations between the color
1530 wheel and the spin buttons. (#132745, Padraig O'Briain)
1532 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
1533 the meaning of size == -1.
1535 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
1536 a size of -1. (#137436, Brian Cameron)
1538 * gtk/gtkcombobox.c: Make the arrow and separator regular
1539 children of an hbox inside the button, and propagate state
1540 changes from the button to the cell view. (part of the fix
1541 for #138650, should also fix #137535)
1543 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
1544 state to gtk_cell_renderer_render() when prelighted. (part
1545 of the fix for #138650)
1547 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1548 Use PRELIGHT state when appropriate. (part of the fix for
1551 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
1552 out warnings if called before the combo box is
1553 realized. (#139742, Philip Langdale)
1555 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
1557 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
1560 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
1562 * gtk/gtkpathbar.c (make_directory_button): remove spurious
1565 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
1567 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
1568 make the buttons sized by a bold label. This makes the text
1569 'swim' a little, but stops the buttons from resizing, #137210
1571 2004-04-13 Matthias Clasen <mclasen@redhat.com>
1573 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
1575 (start_element_handler): Accept separators without unique
1576 names. (#133302, Anders Carlsson)
1578 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
1579 possible accelerator gotcha when using this function. (#139641,
1582 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
1583 list nodes. (#138862, Morten Welinder)
1585 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
1587 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
1589 (gtk_tree_view_button_press): If we activated the row we don't
1590 want to grab focus back, as moving focus to another widget is
1591 pretty common, #138458
1593 2004-04-12 Federico Mena Quintero <federico@ximian.com>
1595 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
1596 documentation to all the signals.
1598 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
1600 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
1601 model if it is NULL. (#139770)
1603 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
1605 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
1606 a shadow inside the scrolled window, add it around the vbox.
1608 * gtk/gtkentryprivate.h:
1609 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1610 Return a boolean indicating whether the popup is positioned above
1611 or below. Scroll the completions to the beginning or the end,
1612 depending on the positioning.
1614 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
1615 wrap around in the entry completion popup, and allow GDK_UP to
1616 enter the popup. (#137440)
1618 2004-04-12 Matthias Clasen <mclasen@redhat.com>
1620 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
1621 there before using it.
1623 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
1625 * gtk/gtktreeprivate.h: Moved search entries into priv data.
1627 * gtk/gtktreeview.c: Prep for type-ahead support.
1629 (gtk_tree_view_destroy): Destroy the search window explicitly.
1630 (gtk_tree_view_key_press): Minor change; prep for type-ahead
1631 (gtk_tree_view_ensure_interactive_directory): New function
1632 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
1633 (gtk_tree_view_real_start_interactive_search): rework
1634 (gtk_tree_view_search_dialog_hide): ditto
1635 (gtk_tree_view_search_delete_event): ditto
1636 (gtk_tree_view_search_button_press_event): ditto
1637 (gtk_tree_view_search_key_press_event): ditto
1638 (gtk_tree_view_search_move): ditto
1639 (gtk_tree_view_search_init): ditto
1641 * gtk/gtktreeviewcolumn.c:
1642 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
1644 * tests/testfilechooser.c: (main): change
1646 2004-04-11 Hans Breuer <hans@breuer.org>
1648 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
1649 the real fix would involve just another small API breakage,
1650 i.e. gdk_spawn_* using GPid not just gint.
1652 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
1654 2004-04-10 Tor Lillqvist <tml@iki.fi>
1656 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
1657 If both Shift and CapsLock pressed, ignore the shift only for
1658 letters (that would have been affected by the CapsLock). (#139095)
1660 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
1661 seems to be even buggier now than it used to be. (#138341)
1662 Initialize _gdk_input_ignore_wintab to TRUE.
1664 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
1665 GDK_USE_WINTAB environment variable to turn on tablet support.
1667 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
1669 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
1670 (gtk_ui_manager_remove_action_group): Terminate
1671 g_object_[dis]connect() calls with NULL instead of 0.
1674 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
1676 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
1678 2004-04-07 Federico Mena Quintero <federico@ximian.com>
1682 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
1683 passed-in 'str' is not NULL.
1685 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
1686 expands "~/" or "~foo/" at the beginning of a filename.
1687 (gtk_file_system_unix_parse): Use expand_tilde() before doing
1690 * gtk/gtkfilechooserentry.c
1691 (gtk_file_chooser_entry_maybe_update_directory): Take in a
1692 force_reload argument.
1693 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
1694 returns an error, set the file_part_pos to -1.
1695 (load_directory_callback): Only populate the model if the
1696 file_part_pos is not -1.
1698 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
1700 * configure.in: Added Icelandic (is) to ALL_LINGUAS
1702 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1704 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
1705 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
1707 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
1708 for G_DIR_SEPARATOR in the display_name, and err out if it is
1709 present; use the same error message as Nautilus. Fixes #136467.
1711 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
1712 new-folder button say "Create Fo_lder" rather than "Create
1713 _Folder", so that the mnemonic doesn't conflict with the "Save in
1714 _folder" label. Fixes #136975.
1716 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1718 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
1719 buttons. Also, free them correctly upon failure. Based on a
1720 patch by Morten Welinder, fixes #137956.
1722 2004-04-05 Anders Carlsson <andersca@gnome.org>
1724 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
1726 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
1728 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
1729 correctly for fixed height when inserting a node, #138082
1731 2004-04-01 Federico Mena Quintero <federico@ximian.com>
1735 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
1736 "child_is_hidden" boolean argument to the "path-clicked" signal.
1738 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
1740 (make_directory_button): Take a file_is_hidden argument; put it in
1742 (_gtk_path_bar_set_path): See whether each path component path is
1744 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
1745 "path-clicked" signal.
1746 (button_clicked_cb): See if the downwards button represents a
1747 hidden file for the file_is_hidden argument in the signal
1750 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
1752 * gtk/gtkfilechooserdefault.c
1753 (gtk_file_chooser_default_select_path): If we fail to switch
1754 folders, don't try to select the path in the file system model.
1755 Also, return the result from _gtk_file_system_model_path_do().
1756 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
1757 file system model if we are asked to select a hidden file.
1758 (path_bar_clicked): Show hidden files based on whether the
1759 immediate downwards folder in the path bar is a hidden file
1761 (struct _GtkFileChooserDefault): Added fields
1762 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
1763 (create_file_list): Set an object data key of
1764 "GtkFileChooserDefault" on the tree view so that we can find the
1765 impl from the popup menu callbacks. Also, hook up to the
1766 "button-press-event" and "popup-menu" signals in the file list to
1767 bring up a popup menu.
1768 (list_popup_menu_cb): New callback.
1769 (list_button_press_event_cb): New callback.
1773 * gtk/gtkfilesystemmodel.c
1774 (_gtk_file_system_model_new): Oops, connect_object to
1777 2004-03-31 Tor Lillqvist <tml@iki.fi>
1779 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
1780 for native Win32. (#136559, J. Ali Harlow)
1782 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
1783 angles. Thanks to Tim Newsham.
1785 2004-03-29 Federico Mena Quintero <federico@ximian.com>
1789 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1790 for an ::is_finished_loading() method and a ::finished_loading()
1791 signal at the end of the struct.
1793 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1794 "finished-loading" signal.
1795 (gtk_file_folder_is_finished_loading): New function.
1797 * gtk/gtkfilesystemunix.c
1798 (gtk_file_folder_unix_is_finished_loading): Implement.
1800 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1801 slot for a "finished-loading" signal.
1802 (gtk_file_system_model_class_init): Create the "finished-loading"
1804 (struct _GtkFileSystemModel): New field
1805 idle_finished_loading_source. We emit the "finished-loading"
1806 signal in an idle if the root folder was done loading right in
1807 _gtk_file_system_model_new(), so that the caller has a chance to
1808 connect to the signal.
1809 (_gtk_file_system_model_new): Connect to the normal signals of the
1810 folder even if the initial _list_children() fails. Also, see if
1811 the folder is finished loading; connect to the "finished-loading"
1813 (gtk_file_system_model_finalize): Remove the idle handler.
1815 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1816 and connect to the model's "finished-loading" signal.
1817 (get_toplevel): New helper function.
1818 (error_message): Use get_toplevel().
1819 (trap_activate_cb): Likewise.
1820 (location_popup_handler): Likewise.
1821 (set_busy_cursor): New function.
1822 (browse_files_model_finished_loading_cb): New callback.
1824 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1826 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
1827 file under the cursor; we don't need the logic from
1828 GtkFileSelection after all. Fixes #132255.
1830 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1832 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
1833 location entry with the display name of the file under the cursor
1834 for Open mode, or the typed filename in Save mode.
1836 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1838 * gtk/gtkfilesystemwin32.c
1839 (filename_is_root): Bare drive designators (eg., "c:") are
1840 no longer considered as root filenames. Fixed #137942
1842 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1844 * gtk/gtkfilesystemwin32.c
1845 (gtk_file_system_win32_create_folder): Invert test for error in
1846 mkdir. Fixes #137945
1848 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1850 Fixed #138004 using Federico's code from #132327.
1852 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
1853 folder_hash field to keep a list of live folder objects.
1854 (gtk_file_system_win32_init): Create the folder_hash.
1855 (gtk_file_system_win32_finalize): Destroy the folder_hash.
1856 (gtk_file_system_win32_get_folder): Ref and return an existing
1857 folder if we have it around, otherwise return a new folder object.
1858 (struct _GtkFileFolderWin32): Add a field for the parent file system.
1859 (gtk_file_folder_win32_finalize): Remove the folder from the file
1860 system's hash table.
1861 (gtk_file_system_win32_create_folder): Emit "files-added" on the
1862 newly-created folder's parent. Fixes #138004.
1864 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1866 * gtk/gtkfilesystemwin32.c
1867 (gtk_file_system_win32_get_folder): Test that path is actually
1868 a directory and throw error if not. Fixed bug #137950
1870 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
1872 * gtk/gtkfilesystemwin32.c
1873 (gtk_file_system_win32_volume_get_display_name): Ignore empty
1874 volume labels; assume that GetVolumeInformation would fail if
1875 GetVolumeInformationW does; catches a small memory leak;
1876 pass the buffer size to GetVolumeInformationW in wide
1877 characters instead of bytes. Fixes bug #137543
1878 (list_volumes): Cope with the theoretical possibility of
1879 more than 26 logical drives. Fixes bug #137940
1880 (bookmarks_serialize): Now actually removes bookmarks.
1883 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
1885 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
1887 2004-03-21 Tor Lillqvist <tml@iki.fi>
1889 * gtk/gtkfilesystemwin32.c
1890 (gtk_file_system_win32_volume_get_base_path): Include the
1891 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
1892 NULL for a volume base path, as g_filename_to_uri() requires an
1893 absolute path, and just a drive letter and colon isn't. (#137543)
1895 2004-03-20 Hans Breuer <hans@breuer.org>
1897 * gtk/gtkfilesystemwin32.c : applied the undisputable and
1898 required [due to recent gtkfilesystem internal api semantic
1899 changes] part of patches to fix bug #137543 (Tor Lillqvist,
1902 * gdk/gdkevents-win32.c (handle_configure_event) :
1903 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
1904 GdkWindowObject::x, y with screen coords to make
1905 gdk_window_get_position () return the right thing and thus fix
1906 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
1908 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1910 * Revert the patch to #137520, as 2.4.1 is for conservative bug
1911 fixes only. The patch is attached to the bug report, for
1914 2004-03-19 Morten Welinder <terra@gnome.org>
1916 * gtk/gtkfilechooserdefault.c
1917 (gtk_file_chooser_default_set_current_folder): Test existance of
1918 the path after checking for locality, if needed.
1920 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1924 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1925 for an ::is_finished_loading() method and a ::finished_loading()
1926 signal at the end of the struct.
1928 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1929 "finished-loading" signal.
1930 (gtk_file_folder_is_finished_loading): New function.
1932 * gtk/gtkfilesystemunix.c
1933 (gtk_file_folder_unix_is_finished_loading): Implement.
1935 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1936 slot for a "finished-loading" signal.
1937 (gtk_file_system_model_class_init): Create the "finished-loading"
1939 (struct _GtkFileSystemModel): New field
1940 idle_finished_loading_source. We emit the "finished-loading"
1941 signal in an idle if the root folder was done loading right in
1942 _gtk_file_system_model_new(), so that the caller has a chance to
1943 connect to the signal.
1944 (_gtk_file_system_model_new): Connect to the normal signals of the
1945 folder even if the initial _list_children() fails. Also, see if
1946 the folder is finished loading; connect to the "finished-loading"
1948 (gtk_file_system_model_finalize): Remove the idle handler.
1950 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1951 and connect to the model's "finished-loading" signal.
1952 (get_toplevel): New helper function.
1953 (error_message): Use get_toplevel().
1954 (trap_activate_cb): Likewise.
1955 (location_popup_handler): Likewise.
1956 (set_busy_cursor): New function.
1957 (browse_files_model_finished_loading_cb): New callback.
1959 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
1961 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
1962 eventbox for expander. (#137564, reported by
1965 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
1967 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
1969 2004-03-17 Morten Welinder <terra@gnome.org>
1971 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
1972 volumes not actually put into the shortcut list.
1974 * tests/prop-editor.c (object_changed): Plug leak.
1976 * tests/testfilechooser.c (main): Plug some leaks and expose
1979 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
1980 object. Fixed #136652.
1982 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
1983 have no screen. Fixes #137260.
1984 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
1985 thereby fixing leak. Fixes #137259.
1987 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
1988 slider buttons have been destroyed.
1989 (gtk_path_bar_remove): Make this work for slider buttons too.
1992 2004-03-15 Morten Welinder <terra@gnome.org>
1994 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
1995 Sanitize and plug leak.
1996 (check_icon_theme): Only do something if the widget has a screen.
1998 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
2000 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2001 Move the repositioning logic from _gtk_entry_completion() popup
2002 over here. Fixes #137355, reported by Niklas Knutsson.