1 Fri Jul 30 02:21:41 2004 Matthias Clasen <maclas@gmx.de>
3 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
4 Fix the positioning of the popup.
6 Fri Jul 30 00:56:31 2004 Matthias Clasen <maclas@gmx.de>
8 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_active_changed):
9 Implement this in terms of gtk_combo_box_get_active_iter(),
10 instead of gtk_combo_box_get_active().
12 2004-07-29 Federico Mena Quintero <federico@ximian.com>
14 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
15 a field for an "add to shortcuts" menu item.
16 (popup_menu_detach_cb): Clear out the field.
17 (file_list_build_popup_menu): Only build the menu here.
18 (file_list_update_popup_menu): Build the menu, then update the
19 sensitivity of its items.
20 (file_list_popup_menu): Use file_list_update_popup_menu().
21 (bookmarks_check_add_sensitivity): Also set the sensitivity of the
22 popup menu item. Correctly handle the case for a *single* file.
24 (bookmarks_add_selected_folder): New helper function; code moved
25 over from add_bookmark_button_clicked_cb().
26 (add_bookmark_button_clicked_cb): Use the function above.
27 (selection_check): Rather than returning a boolean value for
28 emptiness, actually return the number of selected rows. Also,
30 (get_selected_path): New helper function.
32 2004-07-29 Anders Carlsson <andersca@gnome.org>
34 * demos/gtk-demo/Makefile.am:
35 * demos/gtk-demo/clipboard.c: (copy_button_clicked),
36 (paste_received), (paste_button_clicked), (do_clipboard):
39 2004-07-28 Federico Mena Quintero <federico@ximian.com>
41 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
42 Store signal IDs in gulongs, not guints!
43 (gtk_file_chooser_default_hierarchy_changed): We now monitor the
44 focus widget on our toplevel to know which widget was last focused
45 at the time our "should_respond" method gets called.
46 (shortcuts_activate_selected): New helper function.
47 (shortcuts_get_selected): New helper function.
48 (remove_selected_bookmarks): Use shortcuts_get_selected().
49 (bookmarks_check_remove_sensitivity): Likewise.
50 (shortcuts_reorder): Likewise.
51 (shortcuts_activate_iter): Renamed from shortcuts_activate_item().
52 Activate by iter, not by item number.
53 (save_folder_combo_changed_cb): Use shortcuts_activate_iter().
54 (shortcuts_row_activated_cb): Likewise.
55 (gtk_file_chooser_default_should_respond): If the last focused
56 widget on the toplevel was the shortcuts list, activate the
59 2004-07-28 Matthias Clasen <mclasen@redhat.com>
61 * gdk/linux-fb/gdkprivate-fb.h: Make the fb backend compile against
62 current freetype. (#148558, Nicolas Deves)
64 * gtk/gtktreeview.c: Replace the EXPANDER_MAX macro by
67 * gtk/gtkuimanager.c: Warning fixes.
69 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_background): Fix
70 prototype mismatch. (#148589, Nicolas Deves)
72 2004-07-28 Anders Carlsson <andersca@gnome.org>
74 * gdk/x11/gdkdrawable-x11.c (gdk_draw_rectangle_alpha_libgtk_only):
75 Cast to 32-bit integers when premultiplying, suggested by Keith Packard.
77 2004-07-27 Anders Carlsson <andersca@gnome.org>
79 * demos/gtk-demo/iconview.c: (do_iconview):
80 Change selection mode to multiple.
83 * gdk/linux-fb/gdkdrawable-fb2.c:
84 (gdk_draw_rectangle_alpha_libgtk_only):
85 * gdk/win32/gdkdrawable-win32.c:
86 (gdk_draw_rectangle_alpha_libgtk_only):
87 * gdk/x11/gdkdrawable-x11.c: (gdk_x11_draw_image),
88 (get_impl_drawable), (gdk_x11_draw_pixbuf),
89 (gdk_draw_rectangle_alpha_libgtk_only):
90 Add gdk_draw_rectangle_alpha_libgtk_only which uses
91 XRenderFillRectangle on X11. It's stubbed out on the
92 Win32 and fb backends.
95 (gtk_icon_view_paint_rubberband):
96 Use gdk_draw_rectangle_alpha_libgtk_only here.
98 2004-07-27 Anders Carlsson <andersca@gnome.org>
100 * gtk/gtkaboutdialog.c: (gtk_about_dialog_init),
101 (text_view_style_set), (add_credits_page),
102 (display_credits_dialog), (display_license_dialog):
103 Remove dialog separators, fix text view background setting,
104 use Close buttons instead of OK buttons.
106 2004-07-27 Matthias Clasen <mclasen@redhat.com>
108 * gtk/gtktreeview.c (gtk_tree_view_ensure_interactive_directory):
109 Add a frame around the C-f popup to stop it from merging visually
110 in whatever is underneath.
113 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible): New
114 function necessary to make GtkComboBox accessible. (#132847,
117 Tue Jul 27 02:34:06 2004 Matthias Clasen <maclas@gmx.de>
119 * gtk/gtkwidget.c (gtk_widget_dispose): Hide parentless
120 windows when disposing them. (#133231, Michael Natterer)
122 2004-07-26 Matthias Clasen <mclasen@redhat.com>
124 * gtk/gtklabel.c (gtk_label_class_init): Expand the documentation
125 for GtkLabel::ellipsize.
127 Mon Jul 26 00:38:27 2004 Matthias Clasen <maclas@gmx.de>
129 Make the GtkComboBox in list mode scroll if the list is too
130 large to fit in the popup. (#135543)
132 * gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Add a
133 scrolled window to the popup in list mode.
134 (gtk_combo_box_list_position): Calculate the height of the
135 popup so that it fits on the screen, set the scrollbar policy
136 of the scrolled window appropriately.
137 (gtk_combo_box_popup): Use the height calculated by
138 gtk_combo_box_list_position().
139 (gtk_combo_box_remeasure): Don't add unnecessary padding.
140 (gtk_combo_box_size_request): But add the focus with here.
141 (gtk_combo_box_list_setup): Connect to enter notify on the
142 popup window to activate auto scrolling.
143 (gtk_combo_box_list_enter_notify): Activate auto scrolling.
144 (gtk_combo_box_list_button_pressed): Setup a timeout for
146 (gtk_combo_box_list_scroll_timeout): Timeout function for
148 (gtk_combo_box_list_auto_scroll): Scroll the list when the
149 pointer leaves the window.
151 Sun Jul 25 19:51:17 2004 Matthias Clasen <maclas@gmx.de>
153 * gtk/gtknotebook.c (gtk_notebook_scroll): Ignore scroll
154 events from the content of the page. (#148409, Gabriel
157 Sat Jul 24 21:38:12 2004 Soeren Sandmann <sandmann@daimi.au.dk>
159 * gtk/gtktoolbar.c (internal_insert_element): Warn if you try to
160 add a tool item to a toolbar using the deprecated API.
162 Fri Jul 23 13:04:10 2004 Matthias Clasen <maclas@gmx.de>
164 * gtk/gtkdnd.c (gtk_drag_dest_set): Create the change to
165 initialize target_list to an empty list instead of NULL,
166 since it broke tree dnd. (#148215, Ernst Persson)
168 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
169 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): Instead
170 handle target list being NULL here.
172 2004-07-23 Dafydd Harries <daf@muse.19inch.net>
174 * gtk/gtkradioaction.c:
175 * gtk/gtkradiobutton.c:
178 Improve various translatable messages. (#137616)
180 Fri Jul 23 11:11:10 2004 Matthias Clasen <maclas@gmx.de>
182 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
183 Align the entry in the same way as the cell. (#136749)
185 Fri Jul 23 11:01:00 2004 Matthias Clasen <maclas@gmx.de>
187 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
188 Don't iterate too far up. (#147965, Olivier Sessink)
190 Fri Jul 23 10:28:43 2004 Matthias Clasen <maclas@gmx.de>
192 * gtk/gtktreeview.c (gtk_tree_view_finalize):
193 * gtk/gtkradioaction.c (gtk_radio_action_finalize):
194 * gtk/gtkfontsel.c (gtk_font_selection_finalize):
195 * gtk/gtkcellview.c (gtk_cell_view_finalize):
196 * gtk/gtkcalendar.c (gtk_calendar_finalize):
197 * gtk/gtkactiongroup.c (gtk_action_group_finalize): Remove
198 unnecessary checks. (#148175, Morten Welinder)
200 Thu Jul 22 01:42:16 2004 Matthias Clasen <maclas@gmx.de>
202 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
203 Add a new :ellipsize property which controls ellipsization of the
204 rendered text. (#144835, Vincent Untz, patch by Jonathan Blandford
207 * gtk/gtkfilechooserdefault.c (create_file_list): Use ellipsization
210 Thu Jul 22 01:21:28 2004 Matthias Clasen <maclas@gmx.de>
212 * gtk/gtkfontsel.c (gtk_font_selection_init): Add additional
213 accessability relations. (#141804, Padraig O'Briain)
215 Thu Jul 22 01:16:23 2004 Matthias Clasen <maclas@gmx.de>
217 * gtk/gtkcombobox.c: Avoid some warnings.
219 Thu Jul 22 01:05:16 2004 Matthias Clasen <maclas@gmx.de>
221 * configure.in: Require Pango 1.5.1 (for ellipsisation).
224 * gtk/gtklabel.c (gtk_label_class_init): Add a new :ellipsize
225 property which controls ellipsization of the label. (#125250,
226 Tim Van Wassenhove, patch by James M. Cape)
228 * tests/testellipsise.c: Simple test for ellipsizsation.
230 Wed Jul 21 22:46:27 2004 Matthias Clasen <maclas@gmx.de>
232 * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
233 list store. (#148134, Crispin Flowerday)
235 Wed Jul 21 22:35:47 2004 Matthias Clasen <maclas@gmx.de>
237 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
238 menu. (#148110, Tommi Komulainen)
240 Wed Jul 21 22:24:10 2004 Matthias Clasen <maclas@gmx.de>
242 * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak
243 tree model and tree row reference. (#148125, Crispin Flowerday)
245 Wed Jul 21 22:17:06 2004 Matthias Clasen <maclas@gmx.de>
247 * tests/testcombo.c (main): Don't leak models. (#148128,
250 Wed Jul 21 21:26:08 2004 Matthias Clasen <maclas@gmx.de>
252 * gtk/gtkviewport.c (viewport_set_adjustment): Don't leak
253 the adjustments. (#148089, Tommi Komulainen)
255 Wed Jul 21 21:20:21 2004 Matthias Clasen <maclas@gmx.de>
257 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't leak
258 the adjustments. (#148073, Tommi Komulainen)
260 Wed Jul 21 21:04:50 2004 Matthias Clasen <maclas@gmx.de>
262 * gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the
263 arrow. (#148064, Tommi Komulainen)
265 2004-07-21 Matthias Clasen <mclasen@redhat.com>
267 * gtk/gtkcalendar.c: Use the new text target functionality
268 in GtkTargetList instead of hardcoding a subset of text targets.
270 Tue Jul 20 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
272 * gdk/x11/gdkevents-x11.c: Hook up gtk-menu-bar-accel to
273 an XSetting, Gtk/MenuBarAccel. (#120859, Scott James Remnant)
275 Tue Jul 20 22:26:29 2004 Matthias Clasen <maclas@gmx.de>
277 * gtk/gtkfilechooserutils.h:
278 * gtk/gtktoolbutton.c:
280 * gtk/gtkicontheme.c:
282 * demos/gtk-demo/ui_manager.c:
283 * demos/gtk-demo/appwindow.c: Remove trailing commas
284 from enumerations. (#148035)
286 2004-07-20 Federico Mena Quintero <federico@ximian.com>
288 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Fix the
289 documentation comment for the editing-started signal.
291 * gtk/gtkmarshalers.list: Added VOID:OBJECT,STRING for
292 GtkCellRenderer::editing-started.
294 2004-07-20 Matthias Clasen <mclasen@redhat.com>
296 * tests/testactions.c (main):
297 * tests/testmerge.c (main): Add some refcount debugging.
299 * gtk/gtkuimanager.c (update_node, free_node): Ref an sink
300 all proxies, so that we can properly clean up floating proxies
301 which the app didn't adopt. (#147926, Tommi Komulainen)
303 2004-07-20 Matthias Clasen <mclasen@redhat.com>
305 Allow custom initialization of cell editables. (#147221)
307 * gtk/gtkcellrenderer.h (struct _GtkCellRendererClass):
308 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Add a
309 ::editing-started signal as a hook for setting up the
311 (gtk_cell_renderer_start_editing): ...and emit it here.
313 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
315 * gtk/gtktreeview.c (gtk_tree_view_button_press): Set drag_pos
316 before grabbing the focus, since we may reenter into
317 gtk_tree_view_motion_resize_column() which requires drag_pos
318 to be set. (#147913, Guilherme Salgado, patch by John Finlay)
320 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
322 * gtk/gtktreeview.c (gtk_tree_view_enter_notify): Don't
323 use uninitialized node pointer. (#147911, Peter Zelezny)
325 Tue Jul 20 04:34:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
327 * configure.in: Bump version number
329 Sun Jul 18 17:21:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
331 * === Released 2.5.0 ===
335 * tests/testcombo.c: Fix compilation
337 2004-07-19 Matthias Clasen <mclasen@redhat.com>
339 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_popup_completion):
342 2004-07-19 Matthias Clasen <mclasen@redhat.com>
344 Make GtkCellView public, since people seem to have uses for it,
345 it is clean API and we were just conservative in not making it
346 public initially. At the same time, get rid of GtkCellViewMenuItem,
347 which doesn't have any function which can't be served by a
348 GtkMenuItem with a GtkCellView child. (#136637, Padraig O'Briain)
350 * gtk/gtk.h: Include gtkcellview.h
352 * gtk/Makefile.am (gtk_public_h_sources):
354 * gtk/Makefile.am (gtk_private_h_sources):
355 (gtk_c_sources): Remove gtkcellviewmenuitem.[hc]
356 * gtk/gtkcombobox.c: Replace all uses of GtkCellViewMenuItem by
357 GtkMenuItem with a GtkCellView child.
359 * gtk/gtkcellviewmenuitem.[hc]: Removed.
361 2004-07-19 Matthias Clasen <mclasen@redhat.com>
363 Support inline autocompletion in entries (#135953)
365 * gtk/gtkentryprivate.h:
366 * gtk/gtkentrycompletion.h:
367 * gtk/gtkentrycompletion.c (gtk_entry_completion_class_init):
368 Add a new signal ::insert-prefix which can be used to override
369 the default inline-completion behaviour. Add two new boolean
370 properties, :popup_completion and :inline_completion which
371 determine how the possible completions should be presented.
372 (gtk_entry_completion_insert_prefix): New function to request
375 * gtk/gtkentry.c: Add the necessary glue for inline completion.
377 Sun Jul 18 15:28:24 2004 Soeren Sandmann <sandmann@daimi.au.dk>
379 * gtk/gtkdnd.c (gtk_drag_source_set, gtk_drag_dest_set): Create an
380 empty target list if targets is NULL.
382 * configure.in: Add check for X11/extensions/sync.h. (#147416,
385 Sun Jul 18 01:24:31 2004 Matthias Clasen <maclas@gmx.de>
387 * NEWS: Updates for 2.5.0
389 Sat Jul 17 23:11:04 2004 Matthias Clasen <maclas@gmx.de>
392 * gtk/gtkiconview.c (gtk_icon_view_class_init):
393 * gtk/gtkiconview.c (gtk_icon_view_set_orientation):
394 * gtk/gtkiconview.c (gtk_icon_view_get_orientation):
395 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
396 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row):
397 Add a new :orientation property to determine whether text
398 is positioned below or beside icons. (#147463)
400 Sat Jul 17 23:03:30 2004 Matthias Clasen <maclas@gmx.de>
402 * gtk/gtkiconview.c (gtk_icon_view_paint_item):
403 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
404 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row): Draw
405 focus indicator outside the selection, respect focus
406 line width. (#147460)
408 Sat Jul 17 01:17:33 2004 Matthias Clasen <maclas@gmx.de>
410 * gdk/x11/gdkdnd-x11.c (xdnd_check_dest): Fix a warning
413 Sat Jul 17 00:48:27 2004 Matthias Clasen <maclas@gmx.de>
415 Support text/plain selection target (#55117, Owen Taylor)
417 * gtk/gtkselection.h:
419 * gtk/gtkselection.c (gtk_target_list_add_text_targets):
420 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
421 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): New
422 functions to facilitate handling of text targets.
425 * gtk/gtktextview.c: Use the new text target handling
426 functions instead of hardwiring the list of supported
427 text targets everywhere.
429 * gtk/gtkselection.c (gtk_selection_data_get_text):
430 (gtk_selection_data_set_text):
431 Support the targets text/plain, text/plain?charset=utf-8
432 and text/plain?charset=<LOCALE-CHARSET> as outlined in
434 For text/plain send only ASCII, but accept 8-bit text
435 and treat it as ISO-8859-1 as specified by the Xdnd spec.
436 Always send CRLF terminators. Accept either and convert
437 into the native terminator for the platform.
439 Fri Jul 16 23:20:34 2004 Matthias Clasen <maclas@gmx.de>
441 Support themed window icons. (#92346, Calum Benson)
443 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): New
444 function to obtain information about the sizes in which an
448 * gtk/gtkwindow.c (gtk_window_class_init):
449 (gtk_window_set_icon_name):
450 (gtk_window_get_icon_name): Add an "icon_name" property
451 (gtk_window_set_default_icon_name): ...and a default icon name.
452 (icon_list_from_theme):
453 (update_themed_icon): New auxiliary functions to create a
454 list of all available sizes of a themed icon and update the
455 window icon list from it.
457 2004-07-16 Matthias Clasen <mclasen@redhat.com>
459 * gtk/gtkcombobox.c (gtk_combo_box_scroll_event): Make
460 scrolling work if no item is selected.
461 (gtk_cell_editable_key_press): Don't eat space.
463 Add a combo box cell renderer (#139347, Lorenzo Gil Sanchez)
465 * gtk/gtkcellrenderercombo.[hc]: New Files.
468 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
471 * gtk/gtkcombobox.[hc]: Implement GtkCellEditable, add a
472 :has-frame property for suppressing the frame around
473 the child and redo the size allocation logic to take
474 focus width into account.
476 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_init):
477 Acknowledge the GtkComboBox:has-frame property and make
478 the entry fill its allocation vertically.
480 * gtk/gtkmarshalers.list: Add BOOLEAN:STRING.
482 * gtk/gtktreeview.c (gtk_tree_view_remove_widget): Queue
483 a draw here to keep non-widget windows from leaving
486 2004-07-16 Matthias Clasen <mclasen@redhat.com>
488 * gtk/gtkcombobox.c (gtk_combo_box_forall): Don't iterate
489 multiple times over some of the children.
491 Thu Jul 15 22:19:40 2004 Matthias Clasen <maclas@gmx.de>
493 Fix #60128, #58307, #144706:
495 * gtk/gtkstyle.c (gtk_style_real_copy): Handle references
496 to bg_pixmaps properly.
497 (gtk_style_real_unrealize): Don't keep dangling references
499 (gtk_style_attach): Split the loop into two loops, first
500 looking for a matching style, then for an empty one.
501 (gtk_style_finalize):
502 (gtk_style_duplicate): Add comments explaining the handling
505 Thu Jul 15 20:31:28 2004 Matthias Clasen <maclas@gmx.de>
507 * gtk/gtkspinbutton.c (start_spinning): Install the timeout
508 before changing the value, so that a ::value_changed handler
509 has a chance to remove it. (#122427, Elke Meier)
511 Thu Jul 15 19:20:05 2004 Matthias Clasen <maclas@gmx.de>
513 * gdk/x11/gdkgtk+/im-x11.c (_gdk_x11_initialize_locale):
514 * gtk/gtkcalendar.c (gtk_calendar_class_init): Use 'cannot'
515 instead of 'can not' in messages. (#144226, Morten Welinder)
517 2004-07-15 Matthias Clasen <mclasen@redhat.com>
519 * gtk/gtktreeview.c (gtk_tree_view_class_init):
520 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
521 Correct the declared default values of several properties
522 to be in sync with the actual initial values.
524 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_class_init):
525 Make spacing a property, correct the declared default values
526 of several properties to be in sync with the actual initial
527 values. (#147654, Matthias Clasen)
529 * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Don't reparent
530 back to menu->toplevel if it is already gone because we're
531 shutting down. (#147656, John Cupitt)
533 2004-07-14 Federico Mena Quintero <federico@ximian.com>
537 * gtk/gtktreeview.c (gtk_tree_view_bin_expose): Draw a focus
538 indicator along the edge of the bin_window when the tree is empty.
539 (grab_focus_and_unset_draw_keyfocus): New helper function.
540 (gtk_tree_view_button_press): Remove a bit of superfluous code.
541 Use the helper function to save on duplicated code.
542 (gtk_tree_view_button_press): Grab the focus if the tree is empty.
543 (gtk_tree_view_focus): Allow focusing into an empty tree.
545 2004-07-14 Matthias Clasen <mclasen@redhat.com>
547 * gtk/gtkaboutdialog.c (add_credits_page): Don't use
548 gcc extensions for the ternary ?: operator. (#147590,
551 2004-07-14 Federico Mena Quintero <federico@ximian.com>
553 Fix #144405, patch by Padraig O'Briain <padraig.obriain@sun.com>:
555 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): Set the
556 accessible object name for the tree view.
557 (create_file_list): Likewise.
559 Tue Jul 13 21:53:08 2004 Matthias Clasen <maclas@gmx.de>
561 * gtk/gtkicontheme.c (free_unthemed_icon): Don't leak
562 no_svg_filename. (#147399, Kjartan Maraas)
564 2004-07-13 Matthias Clasen <mclasen@redhat.com>
566 * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_get_neighbor_sizes):
567 Make this work in RTL context.
569 2004-07-13 Federico Mena Quintero <federico@ximian.com>
571 * gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Set a
572 busy cursor while mounting the volume. Also, ref the chooser
573 while mounting, as we may re-enter. Fixes #139376.
575 2004-07-13 Matthias Clasen <mclasen@redhat.com>
577 * gtk/gtktreeview.c (gtk_tree_view_adjustment_changed):
578 Prepare to handle composite implementations of
579 GtkCellEditable, but recursively poking at
580 allocation->y (hack stolen from GtkCList).
581 (check_expander_max): Tweak the warning.
583 * gtk/gtkmain.h: Add gtk_parse_args(), its a public
584 function. (#147476, Owen Taylor)
586 * gtk/gtkcombobox.c (gtk_combo_box_popdown): Don't
589 Tue Jul 13 01:50:06 2004 Matthias Clasen <maclas@gmx.de>
591 * gtk/gtkaboutdialog.c (display_credits_dialog): Don't
592 display untranslated translator credits.
594 Tue Jul 13 01:15:05 2004 Matthias Clasen <maclas@gmx.de>
596 * gtk/gtkiconview.c: Some documentation updates.
598 Tue Jul 13 00:40:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
600 * gdk/gdkwindow.c (gdk_window_process_updates_internal): Do an
601 empty begin_paint_region()/end_paint() for windows without
604 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_unset_bg,
605 _gdk_x11_window_tmp_reset_bg): Remove checks for EXPOSURE_MASK.
607 2004-07-12 Matthias Clasen <mclasen@redhat.com>
609 * demos/gtk-demo/appwindow.c: Use a GtkAboutDialog.
611 * gtk/gtkaboutdialog.h:
612 * gtk/gtkaboutdialog.c: New widget: GtkAboutDialog.
614 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
615 * gtk/gtk.h: Add GtkAboutDialog. (#109435, Paolo Borelli,
616 patch by Matthias Clasen)
618 * gtk/gtkrc.c (_gtk_rc_init): Apply the gtk-default-menu-item-style
619 to cell view menu items as well. (#147405, John Cupitt)
621 * gtk/gtkentrycompletion.c: Warning fixes. (#147420,
624 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Pop down
625 first. (#147399, John Cupitt)
627 Mon Jul 12 01:56:26 2004 Matthias Clasen <maclas@gmx.de>
629 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
630 Include the update_counter check in the HAVE_XSYNC condition,
631 since update_counter isn't present in the !HAVE_XSYNC case.
633 Mon Jul 12 00:52:04 2004 Matthias Clasen <maclas@gmx.de>
635 * gtk/stock-icons/Makefile.am:
636 * gtk/stock-icons/stock_about_{16,24}.png:
637 * gtk/stock-icons/stock_connect_{16,24}.png:
638 * gtk/stock-icons/stock_disconnect_{16,24}.png:
639 * gtk/stock-icons/stock_edit_{16,24}.png:
640 * gtk/stock-icons/stock_media_forward_{16,24}.png:
641 * gtk/stock-icons/stock_media_next_{16,24}.png:
642 * gtk/stock-icons/stock_media_pause_{16,24}.png:
643 * gtk/stock-icons/stock_media_play_{16,24}.png:
644 * gtk/stock-icons/stock_media_previous_{16,24}.png:
645 * gtk/stock-icons/stock_media_record_{16,24}.png:
646 * gtk/stock-icons/stock_media_rewind_{16,24}.png:
647 * gtk/stock-icons/stock_media_stop_{16,24}.png:
648 * gtk/gtkstock.h (GTK_STOCK_ABOUT):
649 * gtk/gtkstock.h (GTK_STOCK_CONNECT):
650 * gtk/gtkstock.h (GTK_STOCK_DISCONNECT):
651 * gtk/gtkstock.h (GTK_STOCK_EDIT):
652 * gtk/gtkstock.h (GTK_STOCK_MEDIA_FORWARD):
653 * gtk/gtkstock.h (GTK_STOCK_MEDIA_NEXT):
654 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PAUSE):
655 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PLAY):
656 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PREVIOUS):
657 * gtk/gtkstock.h (GTK_STOCK_MEDIA_RECORD):
658 * gtk/gtkstock.h (GTK_STOCK_MEDIA_REWIND):
659 * gtk/gtkstock.h (GTK_STOCK_MEDIA_STOP):
660 * gtk/gtkiconfactory.c (get_default_icons):
661 * gtk/gtkstock.c (builtin_items): Add a number of new stock
662 items. (#102530, #68015, #109811, Jordi Mallach, Benjamin Otte,
665 Sun Jul 11 15:24:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
667 Bug 143330, support update counter spec.
669 * configure.in: Add check for the Sync extension
671 * gdk/gdkwindow.h: gdk_window_enable_synchronized_configure() and
672 gdk_window_configure_finished()
674 * gtk/gtkwindow.c (gtk_window_move_resize): Call gdk_window_finish_configure().
675 * gtk/gtkwindow.c (gtk_window_realize): Automatically enable
676 synchronized configures.
678 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Store current
679 and pending counter values.
681 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): New function.
682 * gdk/x11/gdkwindow-x11.c
683 (gdk_window_enable_synchronized_configure): New function.
684 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
685 Delete update counter.
686 * gdk/x11/gdkwindow-x11.c (set_wm_protocols): Advertise
687 _NET_WM_SYNC_REQUEST when Sync is available
689 * gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Handle
690 _NET_WM_SYNC_REQUEST messages
691 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Save counter
692 value for use by gdk_window_configure_finished() when receiving
695 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add use_sync flag
696 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Check if the XSync
697 extension is available
698 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_SYNC_REQUEST and
699 _NET_WM_SYNC_REQUEST_COUNTER to list of supported atoms.
701 * gdk/linux-fb/gdkwindow-fb.c, gdk/win32/gdkwindow-win32.c: Add
702 stubs for enable_synchronized_configure() and configure_finished()
704 Sat Jul 10 23:35:13 2004 Matthias Clasen <maclas@gmx.de>
706 * gtk/gtkentry.c (paste_received): Make middle-button pasting
707 work as expected inside the entry. (#116789, Scott Bronson)
709 Sat Jul 10 22:13:53 2004 Matthias Clasen <maclas@gmx.de>
711 * gtk/gtktextbuffer.c (gtk_text_buffer_select_range): Update
712 clipboards. (#142805, Mikael Hallendal)
714 Sun Jul 11 01:38:48 2004 Soeren Sandmann <sandmann@daimi.au.dk>
716 * gtk/gtkpaned.c (gtk_paned_expose): Remove clip-region computing
717 code. Just use &paned->handle_pos.
719 Sun Jul 11 01:12:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
723 * gtk/gtknotebook.c (gtk_notebook_size_allocate): Remove an
726 * gtk/gtknotebook.c (gtk_notebook_page_allocate): Remove some
729 Sat Jul 10 01:33:25 2004 Matthias Clasen <maclas@gmx.de>
731 * docs/RELEASE-HOWTO: Updates.
733 Sat Jul 10 01:55:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
735 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{re|un}set_bg):
736 Insert checks for root window. The root window is never mapped.
738 Sat Jul 10 01:06:05 2004 Soeren Sandmann <sandmann@daimi.au.dk>
740 * gdk/x11/gdkwindow-x11.c (post_unmap): Fix a warning
741 * gdk/x11/gdkwindow-x11.c (show_window_internal): Actually unset
744 Sat Jul 10 00:37:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
748 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{un|re}set_bg):
749 New functions that can do a recursive unset/reset bg.
751 * gdk/x11/gdkgeometry-x11.c: Remove
752 gdk_window_tmp_{un|re}set_bg().
754 * gdk/x11/gdkwindow-x11.c (pre_unmap, post_unmap): New functions
755 called before and after unmapping a window. They unset the
756 background of all other windows to prevent flicker from the X
757 server repainting the background. post_unmap() also invalidates
758 the parent of the unmapped window to draw it without roundtrips.
760 * gdk/x11/gdkwindow-x11.c (show_window_internal): Unset
761 background of newly mapped windows and all desendants to prevent
764 Fri Jul 9 15:33:55 2004 Manish Singh <yosh@gimp.org>
766 * gdk/gdkevents.c: have a dummy case GDK_OWNER_CHANGE in switch
767 statements to avoid gcc warnings about not all enum values handled.
769 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): ignore should live in
772 Fri Jul 9 23:26:09 2004 Soeren Sandmann <sandmann@daimi.au.dk>
776 * gdk/x11/gdkwindow-x11.h (struct _GdkWindowImplX11): Add an
777 "override_redirect" bit.
779 * gdk/x11/gdkwindow-x11.c (gdk_window_new): Set it here.
781 * gdk/x11/gdkwindow-x11.c (gdk_window_move, gdk_window_resize,
782 gdk_window_move_resize):
783 Update the local size/position cache
784 immediately for override redirect windows.
786 * gdk/x11/gdkwindow-x11.c (show_window_internal): Invalidate
787 newly mapped child and override redirect windows.
789 2004-07-09 Federico Mena Quintero <federico@ximian.com>
793 * gtk/gtkfilesystemunix.c (get_fallback_icon): New helper
794 function, fetches a stock icon as a fallback.
795 (gtk_file_system_unix_volume_render_icon): Fall back to a stock
797 (gtk_file_system_unix_render_icon): Fall back to a stock icon.
798 Use helper functions rather than being a mega-function.
799 (get_icon_name_for_directory): Renamed from
800 get_icon_for_directory().
801 (get_icon_type_from_path): New helper function; code pulled out
802 from gtk_file_system_unix_render_icon().
803 (get_special_icon): Likewise.
804 (get_icon_for_mime_type): Likewise.
806 2004-07-09 Federico Mena Quintero <federico@ximian.com>
808 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Fix typo; tmp_event ->
811 2004-07-09 Matthias Clasen <mclasen@redhat.com>
813 * gtk/gtktooltips.c (gtk_tooltips_paint_window): Use the
814 requisition of the widget instead of relying on the style
815 drawing function to supply the size of the drawable. (#146531)
817 2004-07-09 Matthias Clasen <mclasen@redhat.com>
819 Make GtkEntry work harder to protect passwords: (#143955,
822 * gtk/gtkentry.c (gtk_entry_destroy): Add a destroy handler
823 to clear the password even if the widget is leaked.
825 * gtk/gtkentry.c (gtk_entry_real_delete_text):
826 * gtk/gtkentry.c (gtk_entry_finalize): Zero out the memory
829 * gtk/gtkentry.c (gtk_entry_real_insert_text): Zero and free
830 the old memory instead of just reallocating it.
832 * gtk/gtkentry.c (gtk_entry_create_layout): Don't leak text
833 direction information for passwords.
835 2004-07-09 Matthias Clasen <mclasen@redhat.com>
837 * gtk/gtkstyle.c: Fix some cases where style functions were
838 not handling widget == NULL properly. (#146282)
840 Thu Jul 8 22:38:58 2004 Matthias Clasen <maclas@gmx.de>
842 * gtk/gtktreeview.c: Improve the EXPANDER_MAX warning.
844 2004-07-08 Federico Mena Quintero <federico@ximian.com>
848 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Add a
849 GError argument. Do check for errors when getting the
850 GtkFileFolder: get the folder and read the children before
851 actually creating the model. Removed obsolete code that handled
852 roots-changed on the file system.
853 (file_model_node_get_info): Assert that we don't reach the old
854 case to display file system roots.
855 (roots_changed_callback): Removed.
857 * gtk/gtkfilechooserdefault.c (set_list_model): Add a GError
858 argument, and a boolean return value. Return an error if we
859 cannot create the file system model. On error, set a NULL model
861 (gtk_file_chooser_default_set_current_folder): Use the error value
862 from set_list_model().
863 (gtk_file_chooser_default_set_property): Set the show_hidden
864 property only if the browse_files_model exists.
865 (gtk_file_chooser_default_unselect_path): Only operate if the
866 browse_files_model exists.
867 (check_preview_change): Check whether we have the sort_model.
868 (change_folder_and_display_error): Copy the path we get passed
869 before using it. There's a comment in there that explains why we
870 need to copy it; basically, if the passed path belongs to the
871 model, the model may go away in the middle of this function and
872 we'll be left with a dangling pointer.
873 (install_list_model_filter): Assert that the model is not NULL.
874 (set_current_filter): Check whether the model exists.
876 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Don't
877 g_return_if_fail if the model is NULL.
878 (gtk_tree_selection_get_selected_rows): Likewise.
879 (gtk_tree_selection_count_selected_rows): Likewise.
880 (gtk_tree_selection_selected_foreach): Likewise.
881 (gtk_tree_selection_path_is_selected): Likewise; rather just
883 (gtk_tree_selection_select_all): Likewise.
884 (gtk_tree_selection_unselect_all): Likewise.
885 (gtk_tree_selection_select_range): Do g_return_if_fail() if the
887 (gtk_tree_selection_unselect_range): Likewise.
889 * gtk/gtkfilesystemunix.c (fill_in_names): Return immediately if
890 g_dir_open() fails: there is no need to set the error ourselves,
891 as g_dir_open() already does it.
893 2004-07-08 Matthias Clasen <mclasen@redhat.com>
895 * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Allow
896 to restore the default search function. (#145365, John Finlay)
898 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Don't leak
899 references to the drag context. (#144324, Alex Larsson)
901 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
903 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
904 when a new model is set. (#145566, Dmitry M. Shatrov)
906 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
908 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
909 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
910 in order to avoid rendering artifacts from misaligned
911 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
913 2004-07-07 Matthias Clasen <mclasen@redhat.com>
916 * gtk/gtktreeview.h: Small documentation fixes.
918 2004-07-07 Matthias Clasen <mclasen@redhat.com>
920 Support separators in combo boxes and more generally in tree
924 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
925 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
926 Add a ::row-separator-column property with getter and setter,
927 which can indicate a boolean model column to determine which
930 * gtk/gtkcombobox.c: Display separator rows as separator menu
931 items in menu mode, and by using the new treeview separator
932 functionality in list mode.
935 * gtk/gtktreeprivate.h:
936 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
937 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
938 Add a callback to determine whether a row is a separator.
940 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
941 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
942 * gtk/gtktreeview.c (validate_row): Use the new callback
943 to determine whether a row is a separator, and draw it
944 as a separator then. Since separators should take up less
945 vertical space than regular rows, this requires removing
946 the redundant MAX(...,expander_size) calls which appear in
947 many places. Instead, the MAX() is now only done in
948 validate_row(), and only if the row is not a separator.
949 To catch possible side effects of this intrusive change,
950 I have left EXPANDER_MAX() calls in place of the MAX() calls
951 which will emit a warning if something breaks. They should
952 be removed before 2.6.
954 * gtk/gtktreeselection.c (row_is_selectable): Don't let
955 separator rows be selected.
957 * tests/testcombo.c (create_blaat): Add a separator column.
959 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
961 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
962 a 64bit alignment issue. (#144302, Sunil)
964 2004-07-07 Tor Lillqvist <tml@iki.fi>
966 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
967 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
968 * gdk/win32/gdkproperty-win32.c (find_common_locale,
970 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
971 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
974 * gdk/win32/gdkglobals-win32.c
975 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
976 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
977 atom. Initialize it. Declare it. Drop the variable for the
980 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
981 function is supposed to return the string in the locale's charset
982 and encoding. Use g_convert().
984 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
985 string in the locale's charset. Use g_convert().
987 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
988 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
989 GLib's UTF-16 functions instead. Windows uses UTF-16.
991 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
992 functions mentioned above.
994 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
995 also if the string is of type STRING, i.e. ISO-8859-1, and the
996 current codepage is 1252, and contains no C1 chars. Accept
999 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
1000 Mark as static. When storing STRING data, convert to
1002 (gdk_selection_owner_set_for_display): Now that STRING is always
1003 ISO-8859-1, use UTF8_STRING when sending the selection request
1006 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
1009 (gdk_text_property_to_text_list_for_display): Make work more like
1010 X11 version. Do obey the encoding parameter.
1012 (gdk_string_to_compound_text_for_display,
1013 gdk_utf8_to_compound_text_for_display): Don't even pretend
1014 supporting COMPOUND_TEXT.
1016 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
1018 (sanitize_utf8): Zero-terminate string.
1020 2004-07-06 Matthias Clasen <mclasen@redhat.com>
1022 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
1023 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
1025 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
1026 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
1027 fallbacks for gtkfilechooser. Currently these are the same images
1028 as the "new" and "open" items...
1030 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
1032 Fix for #136496, Pawel Salek:
1034 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
1035 a node when it changes in fixed_height mode.
1037 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
1040 2004-07-06 Matthias Clasen <mclasen@redhat.com>
1042 * gtk/gtkmenu.c (gtk_menu_position): Make sure
1043 private->monitor_num is a valid monitor number before
1044 using it. (#139187, Michael Natterer)
1046 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
1048 * gtk/gtkfilechooserdefault.c (popup_position_func):
1049 * gtk/gtkentry.c (popup_position_func):
1050 * gtk/gtktextview.c (popup_position_func): Improve positioning
1051 of keyboard-activated menus with Xinerama.
1053 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
1055 * gtk/gtkuimanager.c (do_updates):
1056 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
1057 when called from an idle handler. (#145429, Jan-Marek Glogowski)
1059 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
1061 * gtk/gtkfilechooserutils.c (delegate_notify): Use
1062 the less efficient g_object_interface_find_property () instead
1063 of the param_id range check, since the GParamSpecs we're
1064 dealing with are the overridden onces on the interface, whose
1065 param_id is always zero. (#145312, Alex Roitman, fix proposed
1068 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
1070 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
1071 virtual method of GtkContainer.
1072 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
1073 method slot of the container class.
1075 2004-07-05 Anders Carlsson <andersca@gnome.org>
1077 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
1078 * gtk/gtkiconview.h:
1079 Use gint, not int in gtk_icon_view_set_markup_column,
1082 2004-07-05 Anders Carlsson <andersca@gnome.org>
1084 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
1085 (gtk_icon_view_real_select_cursor_item),
1086 (gtk_icon_view_real_activate_cursor_item):
1087 * gtk/gtkiconview.h:
1088 Add an "activate_cursor_item" action signal
1089 and bind it to the return key.
1091 2004-07-04 Anders Carlsson <andersca@gnome.org>
1093 * demos/gtk-demo/Makefile.am:
1094 * demos/gtk-demo/gnome-fs-directory.png:
1095 * demos/gtk-demo/gnome-fs-regular.png:
1096 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
1097 (sort_func), (create_store), (item_activated), (up_clicked),
1098 (home_clicked), (do_iconview):
1099 Add a simple file browser based on the icon view.
1102 Add gtk/gtkiconview.h
1104 * gtk/gtkiconview.c: (gtk_icon_view_layout),
1105 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
1106 Fix a few bugs discovered while writing the demo.
1108 2004-07-04 Anders Carlsson <andersca@gnome.org>
1112 * gtk/gtkiconview.h:
1113 Add GtkIconView to the build, remove debugging output.
1115 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
1117 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
1118 (gtk_calendar_drag_data_received): Fix off-by-one error.
1119 GDate month is one-based and GtkCalendar month is zero-based.
1120 (#145134, William Jon McCann)
1122 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
1124 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
1125 somebody tries to move a node after itself in a list of
1126 length 1. (#145291, Sampo Nurmentaus)
1128 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
1130 * docs/faq/gtk-faq.sgml:
1131 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
1134 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
1136 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
1137 and current_height to 0 when ending the embedding. (#143675,
1138 Nickolay V. Shmyrev)
1140 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
1142 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
1143 to the right end of the entry text, even if it ends in combining
1144 marks. (#141728, Theppitak Karoonboonyanan)
1146 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
1148 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
1149 row when unsetting the model. (#138560, Christian Persch)
1151 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
1153 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
1156 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
1158 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
1159 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
1161 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
1163 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
1164 to the event mask, set a scroll_event handler.
1165 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
1166 by switching tabs. (#145244, Gabriel de Perthuis)
1168 2004-07-02 Anders Carlsson <andersca@gnome.org>
1170 * gtk/gtktreeview.c (gtk_tree_view_set_model):
1171 Make sure we check for a NULL model first.
1173 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
1175 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
1176 win32 build problem w/o wintab. Fixed #145242
1178 2004-06-30 Anders Carlsson <andersca@gnome.org>
1180 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
1181 g_return_if_fail to make sure that the model is a GtkTreeModel.
1183 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1185 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
1186 current state, not GTK_STATE_NORMAL
1188 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
1190 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1192 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
1194 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
1196 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
1197 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
1200 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
1202 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
1203 recursion by resetting icon_set->cache before freeing
1204 the cache. (#144947, Tim Janik)
1206 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
1208 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
1209 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
1210 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
1213 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
1215 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
1216 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
1217 last change in the docs.
1219 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
1221 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
1222 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
1223 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
1225 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
1227 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
1228 placement policy for GtkComboBoxEntry to be: if it fits below,
1229 place below, if it fits above place above, else place in the
1230 larger space and scroll so that the scroll arrow appear at the
1231 far end. (#144362, David A. Knight)
1233 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
1235 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
1236 use of &parent_iter. (#145007, John Finlay)
1238 2004-06-25 Bastien Nocera <hadess@hadess.net>
1240 reviewed by: Matthias Clasen <maclas@gmx.de>
1242 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
1243 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
1244 the number of keysyms per keycode is odd. Fixes #144808.
1246 2004-06-25 Matthias Clasen <mclasen@redhat.com>
1248 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
1249 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
1251 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
1253 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
1254 which was mentioned below.
1256 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
1258 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
1259 string change. (#139503, Baris Cicek)
1261 2004-06-22 Federico Mena Quintero <federico@ximian.com>
1263 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
1264 or an Open stock button for the C-l dialog depending on the action
1265 in which the file chooser operates. Fixes #141753.
1267 2004-06-22 Federico Mena Quintero <federico@ximian.com>
1269 Fixes the GTK+ part of #142308:
1271 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
1272 Use filename_to_path().
1273 (gtk_file_system_unix_uri_to_path): Likewise.
1274 (filename_to_path): Use remove_trailing_slash().
1276 2004-06-22 Matthias Clasen <mclasen@redhat.com>
1278 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
1279 for the ::move_cursor signal.
1281 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
1282 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
1285 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
1286 this gets defined for all backends, so linux-fb has a
1287 chance of compiling.
1289 * gdk/x11/gdkgc-x11.c:
1290 * gdk/gdkgc.c: Move function docs inline, add hints about
1291 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
1293 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
1294 for children of the root. (#139785, Jean-François Wauthy,
1295 patch by John Finlay)
1297 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
1298 fix. (#144750, Jeff Franks)
1300 2004-06-21 Michael Natterer <mitch@gimp.org>
1303 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
1304 function public as _gdk_x11_convert_to_format().
1306 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
1307 the pixels from the GdkPixbuf when putting them in the
1308 Xcursor image. Fixes bug #144350.
1310 2004-06-16 Federico Mena Quintero <federico@ximian.com>
1312 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
1313 visible node, free the old path before creating the new one.
1316 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
1318 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
1319 (#144198, Mariano Suárez-Alvarez)
1321 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
1323 * gtk/gtkfilechooserdefault.c: Don't use
1324 contractions like "don't" or "isn't" in error messages.
1325 It isn't nice to use them in log entries either...
1326 (#137774, Morten Welinder, patch by Alexander Winston)
1328 2004-06-11 Federico Mena Quintero <federico@ximian.com>
1332 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
1333 Don't ref the editable node.
1334 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
1335 (_gtk_file_system_model_remove_editable): Ahem, free the node.
1337 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
1338 Added fields for edited_idle and edited_new_text.
1339 (renderer_edited_cb): Queue the
1340 creation of the folder in an idle handler.
1341 (renderer_editing_canceled_cb): Likewise for the cancellation.
1342 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
1344 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
1346 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
1348 2004-06-10 Federico Mena Quintero <federico@ximian.com>
1350 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
1352 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
1353 Refer to gtk_file_chooser_add_shortcut_folder().
1354 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
1355 gtk_file_chooser_add_shortcut_folder_uri().
1357 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
1359 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
1360 the drag before focusing the selected.day.
1361 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
1362 a beginning drag if the widget becomes insensitive.
1364 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
1366 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
1367 spinning before calling arrow_action(), so that a signal
1368 handler triggered from arrow_action() has a chance to
1369 stop the spinning. (#143966, Davyd Madeley)
1371 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
1373 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
1374 typo. (#144070, Kent Sandvik)
1376 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1378 * gtk/gtkmenu.c: Revert the "drag select" part of
1381 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
1383 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
1384 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
1386 2004-06-07 Federico Mena Quintero <federico@ximian.com>
1388 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
1389 from 2003/Sep/12. This kept DnD in tree views within modal
1390 dialogs from working, which is especially bad for the file
1391 chooser. Fixes #135168.
1393 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
1395 Make the entry context menu work in editable text cells. The changes
1396 are based on a patch by Kristian Rietveld, which implemented an
1397 approach outlined by Owen Taylor. (#50075)
1399 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
1400 Ignore focus out if the entry menu is posted.
1401 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
1402 posted, and set up a signal handler to clear the flag if the menu
1404 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
1405 set up a timeout to stop editing if the focus is lost.
1406 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
1407 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
1408 signal on the entry and keep a pointer to the entry.
1409 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
1410 clear the pointer to the entry.
1412 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
1414 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
1415 of the ::language property. (#143802, Owen Taylor)
1417 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
1419 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
1420 (gtk_entry_completion_list_enter_notify),
1421 (gtk_entry_completion_list_motion_notify),
1422 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
1423 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
1424 use it as in the menu code to avoid the initial selection if
1425 the window pops up under the pointer. (Anders Carlsson)
1427 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1429 * tests/testmerge.c: Add a checkbox to queue an
1430 merge/unmerge. Patch from Matthias Clasen.
1432 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
1434 (rebuild_menu): New function that rebuilds the overflow menu and
1435 makes sure it doesn't start or end with a separator.
1436 (toolbar_content_new_tool_item)
1437 (toolbar_content_remove)
1438 (toolbar_content_new_compatibility): Set the rebuild_needed flag
1439 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
1440 have actually overflown an item with a proxy menu item. Also make
1441 sure we rebuild the menu if needed.
1443 Fix #125504, #142377, #143463
1445 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
1446 Obey the "priv->draw" flag. (#143692)
1448 2004-06-04 Matthias Clasen <mclasen@redhat.com>
1450 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
1451 quirk in the button size allocation code.
1453 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
1454 requested for drawing the focus indicator to the child in the
1455 !CAN_FOCUS case. This should fix issues which the Gimp has with
1456 the button allocation changes in 2.4.2.
1458 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
1460 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
1461 length of the entry contents in characters, not in bytes.
1463 * gtk/gtkentry.c (paste_received): Don't pop up the completion
1464 window on paste, noticed by Anders Carlsson.
1466 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
1468 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
1469 values and default value for the ::active property. (#143669,
1472 2004-06-03 Michael Natterer <mitch@gimp.org>
1474 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
1475 instead of accessing item->image->allocation.width/height
1476 directly. Makes widgets which only have a requisition set using
1477 gtk_widget_set_size_request() work and fixes bug #142789.
1479 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1481 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
1482 of sticky right click menus to return.
1484 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1486 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
1487 better handle the "click" case. bug Better fix for #141169.
1489 2004-06-02 Federico Mena Quintero <federico@ximian.com>
1491 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
1492 model is empty. Fixes #143536.
1494 2004-06-02 Matthias Clasen <mclasen@redhat.com>
1496 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
1497 close the dialog on focus out of the size entry. (#143505,
1500 2004-06-02 Federico Mena Quintero <federico@ximian.com>
1504 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
1505 (gtk_fnmatch_intern): Likewise; also implement this option.
1507 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
1509 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
1510 no_leading_period argument of _gtk_fnmatch().
1511 (attempt_file_completion): Likewise.
1513 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
1514 no_leading_period argument of _gtk_fnmatch().
1516 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
1518 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
1521 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
1523 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
1524 allow unless selection mode is multiple. (#142634, John Finlay)
1526 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
1530 * gtk/gtkentrycompletion.h:
1531 * gtk/gtkentrycompletion.c:
1532 * gtk/gtkcombobox.h:
1533 * gtk/gtkcombobox.c: Rename function parameters from
1534 index to index_ to prevent clash with BSD index(). (#143001)
1536 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
1538 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
1539 NULL on an accel label. (#139641, Sam Stephenson, patch by
1542 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
1544 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
1545 lookup finding icons in the wrong prefix. (#143328,
1548 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1552 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
1553 only stay up if you release within 500 milliseconds.
1554 (gtk_menu_shell_button_press): Set the activate_time to the event
1555 time when a button is pressed.
1557 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
1558 Interprete button releases as activate when we have seen both an
1559 enter an a motion event.
1561 2004-06-01 Federico Mena Quintero <federico@ximian.com>
1563 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
1564 dummy node if there is no parent node. Fixes #143362.
1566 2004-05-31 Federico Mena Quintero <federico@ximian.com>
1568 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
1569 newly-created folder. Fixes #138932.
1570 (trap_activate_cb): Only return TRUE if we did handle the event.
1571 Fixes #143359; patch by jylefort@brutele.be.
1573 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
1575 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
1576 docs. (#142892, Tommi Komulainen)
1578 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
1580 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
1581 parent is minimized, porting the fix from 1.2. (#1923, #57182)
1583 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
1585 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
1586 unmapped windows work.
1588 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
1590 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
1593 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
1595 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
1596 Refer to ::update-preview, not ::selection-changed.
1598 2004-05-29 Christian Rose <menthos@menthos.com>
1600 * configure.in: Added "tk" to ALL_LINGUAS.
1602 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
1604 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
1605 messages for common problems. (#137974, Owen Taylor)
1607 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
1609 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
1610 errors. (#143337, Billy Biggs)
1612 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
1614 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
1615 bits within visual->depth that aren't used for color to
1616 1s, in case they are alpha.
1618 2004-05-27 Anders Carlsson <andersca@gnome.org>
1620 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
1621 Make separator rows insensitive.
1623 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
1625 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
1628 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
1630 * gtk/gtkentrycompletion.h:
1631 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
1632 Getter for text_column. Also make ::text_column a property.
1634 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
1636 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
1638 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
1640 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
1641 signal if the box exists.
1643 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
1645 Support insensitive cells in tree views and combo boxes:
1647 * gtk/gtkcellrenderer.h:
1648 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
1650 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
1651 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1652 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
1653 Support drawing insensitive.
1655 * gtk/gtkcellview.h:
1656 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
1657 function to obtain the cell renderers from a cell view. Also
1658 export gtk_cell_view_set_cell_data().
1660 * gtk/gtktreeselection.c (tree_column_is_sensitive):
1661 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
1662 to determine whether all visible cells in a row are insensitive
1663 and whether a row is selectable. A row is not selectable if the
1664 user function says so or if all visible cells are insensitive.
1665 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
1666 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
1667 Use row_is_selectable().
1669 * gtk/gtkcombobox.c (row_is_sensitive):
1670 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
1671 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
1672 to determine row sensitivity in menu or list mode.
1674 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
1675 to set up sensitivity menu items from the underlying rows.
1677 * gtk/gtkcombobox.c (gtk_combo_box_popup):
1678 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
1679 update_menu_sensitivity().
1681 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
1684 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
1687 * tests/testcombo.c (main): Make some rows insensitive.
1689 2004-05-26 Robert Ögren <gtk@roboros.com>
1691 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
1692 modifiers (shift, ctrl etc) in button and motion events from the
1695 2004-05-26 Robert Ögren <gtk@roboros.com>
1697 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
1698 implementation for extended input devices using last known
1699 device state (#143237)
1701 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
1703 * gtk/gtkframe.c: Move docs inline, fixing them on the
1704 way. (#143029, Steve Chaplin)
1706 2004-05-11 Robert Ögren <gtk@roboros.com>
1708 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
1709 events to windows that want extended input events. (#142943)
1710 (gdk_event_translate): Move check for extended input devices to
1711 propagate, new parameter to propagate.
1712 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
1713 _gdk_input_(un)grab_pointer. (#142943)
1715 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
1716 input grab. [Fix missing update of impl in "dijkstra" event
1717 propagation loop] Drop the parallel "impl" pointer, just use a
1718 cast. Don't propagate beyond windows that want normal input
1720 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
1721 implementation of input grab. (#142943)
1723 2004-05-22 Tor Lillqvist <tml@iki.fi>
1725 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
1726 line. (Spotted by Benoît Carpentier.)
1728 2004-05-18 Matthias Clasen <mclasen@redhat.com>
1730 * configure.in: Check for XFIXES extension.
1732 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
1733 a gboolean have_xfixes member.
1735 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
1736 XFIXES events and set have_xfixes.
1738 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
1739 (GdkEventOwnerChange): New event struct for owner change events.
1740 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
1742 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
1743 XFixesSelectionNotify events into GdkEventOwnerChange events.
1746 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
1747 (gdk_display_request_selection_notification): New api
1748 to support selection ownership notification.
1750 * gtk/gtkclipboard.h:
1751 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
1752 api to handle owner change events.
1753 (clipboard_peek): Refactored out the body of
1754 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
1756 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
1757 by calling _gtk_clipboard_handle_event().
1759 2004-05-18 Matthias Clasen <mclasen@redhat.com>
1761 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
1762 the P_() macros ourselves.
1764 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1765 Restrict the width of the popup to be no larger than the
1766 monitor. (#142678, DmD Ljungmark)
1768 * gtk/gtkbutton.c: Go back to the initial fix for the
1769 focus-overdrawing problem, which was actually correct
1770 according to docs/widget_geometry.txt.
1772 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
1773 arrow size from 11 to 15 to compensate for that.
1775 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
1776 arguments of the ::move-cursor signal. (#142725)
1778 2004-05-17 Matthias Clasen <mclasen@redhat.com>
1782 * gtk/gtkbutton.c (gtk_button_size_request)
1783 (gtk_button_size_allocate, _gtk_button_paint): Allocate
1784 space for the focus rectangle only if necessary. (#142668,
1787 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
1791 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
1792 lines. (#142479, Morten Welinder)
1794 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
1796 * gtk/gtkintl.h (Q_): Add a Q_() macro.
1798 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
1799 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
1800 they are not really needed.
1802 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
1803 instead of hardwired padding, use Q_() for the default label,
1804 compute a reasonable minimal size. (#142571, #142572, #142573,
1805 Tommi Komulainen, Christian Persch)
1807 2004-05-15 Tor Lillqvist <tml@iki.fi>
1809 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
1810 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
1811 time). It is used by the OLE2_DND code, which is unfinished and
1812 presumably horribly broken, but still, let's not make it not
1813 compile on purpose. Silence some gcc warnings in the OLE2_DND
1816 2004-05-14 Matthias Clasen <mclasen@redhat.com>
1818 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
1819 New function to go from tree window to tree coordinates, kept
1820 static for now until we figure out the multiple coordinate
1821 system mess in GtkTreeView API-wise.
1822 (gtk_tree_view_scroll_to_cell): Transform the coordinates
1823 from tree window to tree coordinates, using the new function.
1824 Previously, the x coordinate was wrongly transformed. (#142494)
1826 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
1829 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
1830 modifier bit to mark stock item which need to be freed
1831 eventually. (#140654, Michal Pasternak, Scott Tsai)
1833 2004-05-11 Robert Ögren <gtk@roboros.com>
1835 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
1836 call to g_object_ref in Wintab code. (#138341)
1838 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
1839 including unallocated buffers for event->motion.axes and
1840 event->button.axes, unsigned wraparound problem in the code for
1841 detecting missing press/release events and assigning min instead
1842 of max when setting up axes.
1844 2004-05-12 Matthias Clasen <mclasen@redhat.com>
1846 * tests/testtreeedit.c: Add a progress column.
1848 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
1851 * gtk/gtk.h: Include gtkcellrendererprogress.h.
1853 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
1854 based on the one found in Epiphany.
1856 2004-05-11 Michael Natterer <mitch@gimp.org>
1858 * gtk/gtkcombobox.c (gtk_combo_box_popup)
1859 (gtk_combo_box_menu_button_press): don't allocate the popup
1860 smaller than the combobox. Fixes bug #59660.
1862 2004-05-11 Matthias Clasen <mclasen@redhat.com>
1864 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
1865 previous change to this function, clarify the docs instead.
1867 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
1868 GTK_SELECTION_BROWSE.
1870 * gtk/gtktreeview.c: Make hover selection work for
1871 GTK_SELECTION_BROWSE as well.
1873 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
1875 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
1876 Document the ::toggled signal.
1878 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1880 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
1882 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1884 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
1886 * gdk/gdkdisplay.c (singlehead_...):
1887 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
1888 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
1889 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
1891 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
1892 note about COLUMN_FIXED restriction.
1894 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
1895 Set the entry in the default handler of the ::match-selected signal.
1898 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
1899 do the move-selected-item below pointer thingie, do the
1900 place-below-or-above one.
1902 * tests/testentrycompletion.c: Make the second example use the
1903 ::match-selected signal to make it actually work.
1905 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
1906 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
1907 mode. (#127648, Dave Bordoley)
1909 * gtk/gtktreeview.h:
1910 * gtk/gtktreeview.c: Add a new property "hover_selection", which
1911 when TRUE makes the selection follow the mouse. Also add setter
1912 and getter for the fixed_height property.
1914 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1916 * gtk/gtkcombobox.c (gtk_combo_box_popup)
1917 (gtk_combo_box_menu_button_press): Make sure the menu pops up
1918 as wide as the combobox. (#59660, Havoc Pennington)
1920 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1922 * gtk/gtkcombobox.h:
1923 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
1924 mode). Add a new property, add-tearoffs, for this. (#135956)
1926 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
1927 default button. (#118921)
1929 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1931 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
1932 that emits the grab notify signal.
1934 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
1936 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
1938 * gtk/gtkmenu.c: Make destruction of a torn off menu work
1939 like un-tearing off.
1941 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
1945 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1946 Allow to suppress the stock accelerator by using "". (#142196,
1949 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
1953 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
1954 In list mode, accept the same mouse/wheel bindings on
1955 the cellview as on the button. (#136967)
1957 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
1959 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
1960 cached icons. (#135888, Crispin Flowerday)
1962 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
1964 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
1965 that we actually return menus for nodes of type menu, not the
1966 menuitems they're attached to.
1968 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
1970 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
1971 Add a note regarding UTF-8 requirements, proposed by
1972 Mariano Suárez-Alvarez.
1974 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
1976 * gtk/gtktearoffmenuitem.h:
1977 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
1978 into the GtkTearoffMenuItem struct, since it is used
1979 by the Gimp, and keep it synchronized with the
1980 tearoff_state property of the parent menu.
1982 2004-05-08 Hans Breuer <hans@breuer.org>
1984 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
1985 create the correct mask for 'pseudo mime' icons
1987 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
1988 take focus_on_map into account
1990 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
1992 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
1993 ... must return a value
1995 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
1997 2004-05-07 Matthias Clasen <mclasen@redhat.com>
1999 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
2000 draw over the focus rectangle.
2002 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
2003 standard focus style. (#63071, Bill Haneman, idea for new
2004 style by Owen Taylor)
2006 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
2007 focus on the colorwheel via details.
2009 2004-05-06 Matthias Clasen <mclasen@redhat.com>
2013 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
2014 this no longer needed signal handler. (#141817, Paul Pogonyshev)
2016 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
2018 * gtk/gtktearoffmenuitem.h:
2019 * gtk/gtktearoffmenuitem.c: Make the tearoff
2020 functionality model/view, the tearoffmenuitem being
2021 the view and the tearoff_state property of the menu
2022 being the model. (#101185, Owen Taylor)
2024 * gtk/gtkmenu.c: Add a tearoff_state property.
2026 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
2030 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
2031 popup the submenu for items in torn off menus. (#122051)
2033 2004-05-06 Sven Neumann <sven@gimp.org>
2035 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
2036 position the title lable next to the arrow just as we do for LTR
2037 rendering. Fixes bug #141825.
2039 2004-05-06 Matthias Clasen <mclasen@redhat.com>
2041 * docs/RELEASE-HOWTO: Document the new policy of
2042 bumping version numbers after release.
2044 * configure.in: Bump version number to 2.5.0.
2046 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
2049 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
2052 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
2054 * gtk/gtkactiongroup.h:
2055 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
2056 New function to translate a string with translate_func.
2059 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
2061 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
2062 (gtk_combo_box_get_row_span_column):
2063 (gtk_combo_box_get_column_span_column): Add missing getters
2064 for readwrite properies. (#135649)
2066 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
2068 * gtk/gtkcombobox.h:
2069 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
2070 Add gtk_combo_box_get_active_text() convenience
2071 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
2073 2004-05-05 Elijah Newren <newren@math.utah.edu>
2075 Changes to support do-not-focus-on-map hint in conjunction with
2076 _NET_WM_USER_TIME (#115650):
2078 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
2081 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
2084 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
2085 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
2087 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
2088 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
2089 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
2090 Initialize the focus_on_map field to TRUE.
2092 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
2093 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
2094 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
2095 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
2096 Implementations for the various backends. The Win32 and linux-fb
2097 implementations set the focus_on_map field, but don't use it yet
2098 to actually implement noinput windows. The X implementation sets
2099 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
2101 * gdk/x11/gdkwindow-x11.h:
2102 * gdk/x11/gdkevents-x11.c (set_user_time):
2103 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
2104 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
2105 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
2106 since we want that function to be part of the public API.
2108 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
2112 * gtk/gtkiconfactory.c (icon_source_clear): Don't
2113 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
2115 2004-05-05 Matthias Clasen <mclasen@redhat.com>
2119 * gtk/gtkuimanager.c (print_node): Make the output
2120 parseable. (#141929, Sven Neumann)
2122 2004-05-05 Tor Lillqvist <tml@iki.fi>
2124 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
2125 multi-monitor offset. (#141842, John Ehresman)
2127 2004-05-04 Federico Mena Quintero <federico@ximian.com>
2129 Fixes #139562, based on a patch by Christian Neumair.
2131 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
2132 a filter_combo_hbox field to contain the filter combo.
2133 (show_filters): Show/hide the filter_combo_hbox.
2134 (create_filename_entry_and_filter_combo): Removed.
2135 (file_pane_create): Create the filter_combo_hbox here.
2137 2004-05-04 Matthias Clasen <mclasen@redhat.com>
2139 * modules/input/gtkimcontextxim.c: Fix the recent
2140 string_conversion_callback change to work on
2141 Solaris. (#141190, Padraig O'Briain)
2143 * gtk/gtkselection.c: Disable debug logging again.
2145 2004-05-03 Matthias Clasen <mclasen@redhat.com>
2147 * gtk/gtkselection.c: Make the chunk size for
2148 incremental transfers depend on the maximal request
2149 size, capped at 256k. This should allow most selections
2150 to be transferred nonincrementally, avoiding many
2151 roundtrips and protocol overhead.
2153 2004-05-03 Federico Mena Quintero <federico@ximian.com>
2155 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
2156 g_signal_new() correctly and initialize the signal fields. Fixes
2157 #141749; patch based on Michael Natterer's.
2159 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
2161 * gtk/gtkselection.c (_gtk_selection_request): Fix
2162 a debug message to show correct information.
2163 (_gtk_selection_incr_event): Make INCRemental transfer
2164 of MULTIPLE targets work. This was broken since 1997!
2166 2004-05-02 Hans Breuer <hans@breuer.org>
2168 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
2169 modify the passed in GdkSegment(s) in place, we may get
2170 them again to draw at the same place. Fixes bug #129095,
2172 (draw_segments) draw the end pixel again to get the
2173 pixmap mask right, fixes bug #126710, #130202
2175 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
2176 fixes bug #106013, John Ehresman
2178 * gtk/makefile.msc.in : don't try to link gtk.res but
2179 use gtk-win32.res (as supposed to be fixed below :)
2181 2004-05-01 Hans Breuer <hans@breuer.org>
2183 * tests/Makefile.am : tests/makefile.msc is in CVS for
2184 a long time, finally added to EXTRA_DIST : fixes bug
2185 #141334, John Ehresman
2187 2004-04-30 Matthias Clasen <mclasen@redhat.com>
2189 * === Released 2.4.1 ===
2191 * configure.in: Version 2.4.1, interface age 1.
2195 2004-04-29 Federico Mena Quintero <federico@ximian.com>
2199 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
2200 function; moved the code over from
2201 remove_bookmark_button_clicked_cb().
2202 (remove_selected_bookmarks): Now, getting a non-removable bookmark
2203 is not an error, as we may be called as a result of hitting the
2205 (shortcuts_key_press_event_cb): New handler; delete the bookmark
2206 if the user presses Backspace, Delete, or KP_Delete.
2208 2004-04-29 Matthias Clasen <mclasen@redhat.com>
2210 * gtk/gtkaction.c (closure_accel_activate): Use
2211 _gtk_action_emit_activate() instead of directly
2212 emitting the activate signal. (#141429, Jody Goldberg)
2214 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
2215 Warn people when the accelerator can not be
2216 parsed. (#141429, Jody Goldberg)
2218 2004-04-29 Matthias Clasen <mclasen@redhat.com>
2220 * tests/testentrycompletion.c (main): Add a missing
2221 cat. (#141070, Chris Sherlock)
2223 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
2224 variable. (#141022, Chris Sherlock)
2226 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
2227 cast. (#141013, Chris Sherlock)
2229 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
2230 unused variable. (#141011, Chris Sherlock)
2232 2004-04-29 Tor Lillqvist <tml@iki.fi>
2234 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
2235 leak. (#140775, John Ehresman)
2237 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
2239 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
2240 to index the cached gcs, not depth. (#139494)
2242 2004-04-28 Matthias Clasen <mclasen@redhat.com>
2244 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
2246 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2248 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
2249 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
2251 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
2253 Patch to add support for string conversion callbacks to
2254 GtkIMContextXIM (#101814)
2256 * modules/input/gtkimcontextxim.c: Set the string conversion callback
2257 if supported by the XIC.
2259 (struct _GtkIMContextXIM): Add string_conversion_callback member.
2261 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
2262 whether string conversion callback is supported.
2264 (gtk_im_context_get_ic, +set_string_conversion_callback,
2265 +string_conversion_callback): Also initialize string conversion
2266 callback, if supported, along with the IC initialization.
2268 * modules/input/imxim.c: Make "xim" module default for Thai as well.
2270 2004-04-23 Matthias Clasen <mclasen@redhat.com>
2272 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
2273 initialize targets. (#139883, John Finlay)
2275 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
2277 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
2278 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
2279 Tim-Philipp Müller)
2281 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
2282 Remove an excessive g_return_if_fail().
2284 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
2286 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
2287 _-prefix calls of gdk_x11_window_set_user_time().
2289 2004-04-22 Matthias Clasen <mclasen@redhat.com>
2291 * gtk/gtkuimanager.c (update_node): Make sure the separators
2292 used to demarkate placeholder ends don't show up on
2293 show_all(). (#140496, Murray Cumming)
2295 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
2296 work with negative increments. (#137975, Tim Gerla)
2298 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2300 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
2301 gtk_tool_button_set_icon_widget): Remove the old widget from the
2302 tool button before overwriting it with the new widget.
2304 (#140508, Todd Goyen)
2306 2004-04-22 Tor Lillqvist <tml@iki.fi>
2308 Fix the file chooser on Windows. I can't make it misbehave or
2309 crash any more now. But presumably there are still corner cases
2310 not handled. I haven't really checked behaviour of UNC paths, for
2313 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
2314 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
2317 (gtk_file_system_win32_get_parent): Like the Unix version, assert
2318 filename is absolute, and avoid one unnecessary string allocation
2321 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
2322 letters more correctly.
2324 (gtk_file_system_win32_render_icon): Assure correct syntax is used
2325 for root folder of a drive. (#137962, Morten Welinder)
2327 (filename_is_some_root): New function that accepts also root
2328 without any drive specified.
2330 (filename_is_drive_root): Rename from filename_is_root.
2332 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
2335 2004-04-21 Matthias Clasen <mclasen@redhat.com>
2337 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
2338 completion window if there are no completions anymore.
2340 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2341 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
2342 It doesn't like that. (#140642, Christian Persch)
2344 * demos/gtk-demo/expander.c (do_expander): A new demo.
2346 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
2348 2004-04-20 Matthias Clasen <mclasen@redhat.com>
2350 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
2351 sure anchored children get size allocated, even if the layout
2352 is valid. (#122323, Andrew E. Makeev)
2353 (gtk_text_view_scroll_pages):
2354 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
2355 if we already have pending scrolls. Bandaid fix for #78513.
2357 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
2359 * INSTALL.in: Update libpng and libjpeg URLs, remove
2360 note about building without since that's not the normal
2363 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
2365 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
2366 handling of SVG/non-SVG unthemed icons.
2368 2004-04-19 Morten Welinder <terra@gnome.org>
2370 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
2373 2004-04-19 Matthias Clasen <mclasen@redhat.com>
2375 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
2376 Don't stop the iteration up to the tag_root too
2377 early. (#109945, Dongho Shin)
2379 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2381 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
2382 gdk_keymap_translate_keyboard_state() handle NULL
2383 keymaps. (#139715, Torsten Schoenfeld).
2385 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2387 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
2388 reported by Pedro RODRIGUEZ, about compilation problems when
2389 Xcursor is installed in a non-standard location.
2391 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2393 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
2396 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
2397 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
2399 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
2401 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
2404 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
2405 property on user interaction.
2407 2004-04-15 Federico Mena Quintero <federico@ximian.com>
2409 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
2410 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
2412 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
2413 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
2416 2004-04-15 Matthias Clasen <mclasen@redhat.com>
2418 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
2419 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
2421 2004-04-14 Matthias Clasen <mclasen@redhat.com>
2423 * gtk/gtkcombobox.c:
2425 Make all style properties readonly.
2427 2004-04-14 Matthias Clasen <mclasen@redhat.com>
2429 * gtk/gtkcolorsel.c: Add a11y relations between the color
2430 wheel and the spin buttons. (#132745, Padraig O'Briain)
2432 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
2433 the meaning of size == -1.
2435 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
2436 a size of -1. (#137436, Brian Cameron)
2438 * gtk/gtkcombobox.c: Make the arrow and separator regular
2439 children of an hbox inside the button, and propagate state
2440 changes from the button to the cell view. (part of the fix
2441 for #138650, should also fix #137535)
2443 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
2444 state to gtk_cell_renderer_render() when prelighted. (part
2445 of the fix for #138650)
2447 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
2448 Use PRELIGHT state when appropriate. (part of the fix for
2451 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
2452 out warnings if called before the combo box is
2453 realized. (#139742, Philip Langdale)
2455 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
2457 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
2460 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
2462 * gtk/gtkpathbar.c (make_directory_button): remove spurious
2465 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
2467 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
2468 make the buttons sized by a bold label. This makes the text
2469 'swim' a little, but stops the buttons from resizing, #137210
2471 2004-04-13 Matthias Clasen <mclasen@redhat.com>
2473 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
2475 (start_element_handler): Accept separators without unique
2476 names. (#133302, Anders Carlsson)
2478 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
2479 possible accelerator gotcha when using this function. (#139641,
2482 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
2483 list nodes. (#138862, Morten Welinder)
2485 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
2487 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
2489 (gtk_tree_view_button_press): If we activated the row we don't
2490 want to grab focus back, as moving focus to another widget is
2491 pretty common, #138458
2493 2004-04-12 Federico Mena Quintero <federico@ximian.com>
2495 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
2496 documentation to all the signals.
2498 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
2500 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
2501 model if it is NULL. (#139770)
2503 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
2505 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
2506 a shadow inside the scrolled window, add it around the vbox.
2508 * gtk/gtkentryprivate.h:
2509 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2510 Return a boolean indicating whether the popup is positioned above
2511 or below. Scroll the completions to the beginning or the end,
2512 depending on the positioning.
2514 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
2515 wrap around in the entry completion popup, and allow GDK_UP to
2516 enter the popup. (#137440)
2518 2004-04-12 Matthias Clasen <mclasen@redhat.com>
2520 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
2521 there before using it.
2523 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
2525 * gtk/gtktreeprivate.h: Moved search entries into priv data.
2527 * gtk/gtktreeview.c: Prep for type-ahead support.
2529 (gtk_tree_view_destroy): Destroy the search window explicitly.
2530 (gtk_tree_view_key_press): Minor change; prep for type-ahead
2531 (gtk_tree_view_ensure_interactive_directory): New function
2532 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
2533 (gtk_tree_view_real_start_interactive_search): rework
2534 (gtk_tree_view_search_dialog_hide): ditto
2535 (gtk_tree_view_search_delete_event): ditto
2536 (gtk_tree_view_search_button_press_event): ditto
2537 (gtk_tree_view_search_key_press_event): ditto
2538 (gtk_tree_view_search_move): ditto
2539 (gtk_tree_view_search_init): ditto
2541 * gtk/gtktreeviewcolumn.c:
2542 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
2544 * tests/testfilechooser.c: (main): change
2546 2004-04-11 Hans Breuer <hans@breuer.org>
2548 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
2549 the real fix would involve just another small API breakage,
2550 i.e. gdk_spawn_* using GPid not just gint.
2552 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
2554 2004-04-10 Tor Lillqvist <tml@iki.fi>
2556 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
2557 If both Shift and CapsLock pressed, ignore the shift only for
2558 letters (that would have been affected by the CapsLock). (#139095)
2560 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
2561 seems to be even buggier now than it used to be. (#138341)
2562 Initialize _gdk_input_ignore_wintab to TRUE.
2564 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
2565 GDK_USE_WINTAB environment variable to turn on tablet support.
2567 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
2569 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
2570 (gtk_ui_manager_remove_action_group): Terminate
2571 g_object_[dis]connect() calls with NULL instead of 0.
2574 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
2576 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
2578 2004-04-07 Federico Mena Quintero <federico@ximian.com>
2582 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
2583 passed-in 'str' is not NULL.
2585 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
2586 expands "~/" or "~foo/" at the beginning of a filename.
2587 (gtk_file_system_unix_parse): Use expand_tilde() before doing
2590 * gtk/gtkfilechooserentry.c
2591 (gtk_file_chooser_entry_maybe_update_directory): Take in a
2592 force_reload argument.
2593 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
2594 returns an error, set the file_part_pos to -1.
2595 (load_directory_callback): Only populate the model if the
2596 file_part_pos is not -1.
2598 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
2600 * configure.in: Added Icelandic (is) to ALL_LINGUAS
2602 2004-04-05 Federico Mena Quintero <federico@ximian.com>
2604 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
2605 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
2607 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
2608 for G_DIR_SEPARATOR in the display_name, and err out if it is
2609 present; use the same error message as Nautilus. Fixes #136467.
2611 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
2612 new-folder button say "Create Fo_lder" rather than "Create
2613 _Folder", so that the mnemonic doesn't conflict with the "Save in
2614 _folder" label. Fixes #136975.
2616 2004-04-05 Federico Mena Quintero <federico@ximian.com>
2618 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
2619 buttons. Also, free them correctly upon failure. Based on a
2620 patch by Morten Welinder, fixes #137956.
2622 2004-04-05 Anders Carlsson <andersca@gnome.org>
2624 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
2626 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
2628 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
2629 correctly for fixed height when inserting a node, #138082
2631 2004-04-01 Federico Mena Quintero <federico@ximian.com>
2635 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
2636 "child_is_hidden" boolean argument to the "path-clicked" signal.
2638 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
2640 (make_directory_button): Take a file_is_hidden argument; put it in
2642 (_gtk_path_bar_set_path): See whether each path component path is
2644 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
2645 "path-clicked" signal.
2646 (button_clicked_cb): See if the downwards button represents a
2647 hidden file for the file_is_hidden argument in the signal
2650 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
2652 * gtk/gtkfilechooserdefault.c
2653 (gtk_file_chooser_default_select_path): If we fail to switch
2654 folders, don't try to select the path in the file system model.
2655 Also, return the result from _gtk_file_system_model_path_do().
2656 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
2657 file system model if we are asked to select a hidden file.
2658 (path_bar_clicked): Show hidden files based on whether the
2659 immediate downwards folder in the path bar is a hidden file
2661 (struct _GtkFileChooserDefault): Added fields
2662 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
2663 (create_file_list): Set an object data key of
2664 "GtkFileChooserDefault" on the tree view so that we can find the
2665 impl from the popup menu callbacks. Also, hook up to the
2666 "button-press-event" and "popup-menu" signals in the file list to
2667 bring up a popup menu.
2668 (list_popup_menu_cb): New callback.
2669 (list_button_press_event_cb): New callback.
2673 * gtk/gtkfilesystemmodel.c
2674 (_gtk_file_system_model_new): Oops, connect_object to
2677 2004-03-31 Tor Lillqvist <tml@iki.fi>
2679 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
2680 for native Win32. (#136559, J. Ali Harlow)
2682 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
2683 angles. Thanks to Tim Newsham.
2685 2004-03-29 Federico Mena Quintero <federico@ximian.com>
2689 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
2690 for an ::is_finished_loading() method and a ::finished_loading()
2691 signal at the end of the struct.
2693 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
2694 "finished-loading" signal.
2695 (gtk_file_folder_is_finished_loading): New function.
2697 * gtk/gtkfilesystemunix.c
2698 (gtk_file_folder_unix_is_finished_loading): Implement.
2700 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
2701 slot for a "finished-loading" signal.
2702 (gtk_file_system_model_class_init): Create the "finished-loading"
2704 (struct _GtkFileSystemModel): New field
2705 idle_finished_loading_source. We emit the "finished-loading"
2706 signal in an idle if the root folder was done loading right in
2707 _gtk_file_system_model_new(), so that the caller has a chance to
2708 connect to the signal.
2709 (_gtk_file_system_model_new): Connect to the normal signals of the
2710 folder even if the initial _list_children() fails. Also, see if
2711 the folder is finished loading; connect to the "finished-loading"
2713 (gtk_file_system_model_finalize): Remove the idle handler.
2715 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
2716 and connect to the model's "finished-loading" signal.
2717 (get_toplevel): New helper function.
2718 (error_message): Use get_toplevel().
2719 (trap_activate_cb): Likewise.
2720 (location_popup_handler): Likewise.
2721 (set_busy_cursor): New function.
2722 (browse_files_model_finished_loading_cb): New callback.
2724 2004-03-25 Federico Mena Quintero <federico@ximian.com>
2726 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
2727 file under the cursor; we don't need the logic from
2728 GtkFileSelection after all. Fixes #132255.
2730 2004-03-25 Federico Mena Quintero <federico@ximian.com>
2732 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
2733 location entry with the display name of the file under the cursor
2734 for Open mode, or the typed filename in Save mode.
2736 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2738 * gtk/gtkfilesystemwin32.c
2739 (filename_is_root): Bare drive designators (eg., "c:") are
2740 no longer considered as root filenames. Fixed #137942
2742 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2744 * gtk/gtkfilesystemwin32.c
2745 (gtk_file_system_win32_create_folder): Invert test for error in
2746 mkdir. Fixes #137945
2748 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2750 Fixed #138004 using Federico's code from #132327.
2752 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
2753 folder_hash field to keep a list of live folder objects.
2754 (gtk_file_system_win32_init): Create the folder_hash.
2755 (gtk_file_system_win32_finalize): Destroy the folder_hash.
2756 (gtk_file_system_win32_get_folder): Ref and return an existing
2757 folder if we have it around, otherwise return a new folder object.
2758 (struct _GtkFileFolderWin32): Add a field for the parent file system.
2759 (gtk_file_folder_win32_finalize): Remove the folder from the file
2760 system's hash table.
2761 (gtk_file_system_win32_create_folder): Emit "files-added" on the
2762 newly-created folder's parent. Fixes #138004.
2764 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2766 * gtk/gtkfilesystemwin32.c
2767 (gtk_file_system_win32_get_folder): Test that path is actually
2768 a directory and throw error if not. Fixed bug #137950
2770 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
2772 * gtk/gtkfilesystemwin32.c
2773 (gtk_file_system_win32_volume_get_display_name): Ignore empty
2774 volume labels; assume that GetVolumeInformation would fail if
2775 GetVolumeInformationW does; catches a small memory leak;
2776 pass the buffer size to GetVolumeInformationW in wide
2777 characters instead of bytes. Fixes bug #137543
2778 (list_volumes): Cope with the theoretical possibility of
2779 more than 26 logical drives. Fixes bug #137940
2780 (bookmarks_serialize): Now actually removes bookmarks.
2783 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
2785 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
2787 2004-03-21 Tor Lillqvist <tml@iki.fi>
2789 * gtk/gtkfilesystemwin32.c
2790 (gtk_file_system_win32_volume_get_base_path): Include the
2791 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
2792 NULL for a volume base path, as g_filename_to_uri() requires an
2793 absolute path, and just a drive letter and colon isn't. (#137543)
2795 2004-03-20 Hans Breuer <hans@breuer.org>
2797 * gtk/gtkfilesystemwin32.c : applied the undisputable and
2798 required [due to recent gtkfilesystem internal api semantic
2799 changes] part of patches to fix bug #137543 (Tor Lillqvist,
2802 * gdk/gdkevents-win32.c (handle_configure_event) :
2803 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
2804 GdkWindowObject::x, y with screen coords to make
2805 gdk_window_get_position () return the right thing and thus fix
2806 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
2808 2004-03-19 Federico Mena Quintero <federico@ximian.com>
2810 * Revert the patch to #137520, as 2.4.1 is for conservative bug
2811 fixes only. The patch is attached to the bug report, for
2814 2004-03-19 Morten Welinder <terra@gnome.org>
2816 * gtk/gtkfilechooserdefault.c
2817 (gtk_file_chooser_default_set_current_folder): Test existance of
2818 the path after checking for locality, if needed.
2820 2004-03-19 Federico Mena Quintero <federico@ximian.com>
2824 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
2825 for an ::is_finished_loading() method and a ::finished_loading()
2826 signal at the end of the struct.
2828 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
2829 "finished-loading" signal.
2830 (gtk_file_folder_is_finished_loading): New function.
2832 * gtk/gtkfilesystemunix.c
2833 (gtk_file_folder_unix_is_finished_loading): Implement.
2835 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
2836 slot for a "finished-loading" signal.
2837 (gtk_file_system_model_class_init): Create the "finished-loading"
2839 (struct _GtkFileSystemModel): New field
2840 idle_finished_loading_source. We emit the "finished-loading"
2841 signal in an idle if the root folder was done loading right in
2842 _gtk_file_system_model_new(), so that the caller has a chance to
2843 connect to the signal.
2844 (_gtk_file_system_model_new): Connect to the normal signals of the
2845 folder even if the initial _list_children() fails. Also, see if
2846 the folder is finished loading; connect to the "finished-loading"
2848 (gtk_file_system_model_finalize): Remove the idle handler.
2850 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
2851 and connect to the model's "finished-loading" signal.
2852 (get_toplevel): New helper function.
2853 (error_message): Use get_toplevel().
2854 (trap_activate_cb): Likewise.
2855 (location_popup_handler): Likewise.
2856 (set_busy_cursor): New function.
2857 (browse_files_model_finished_loading_cb): New callback.
2859 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
2861 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
2862 eventbox for expander. (#137564, reported by
2865 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
2867 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
2869 2004-03-17 Morten Welinder <terra@gnome.org>
2871 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
2872 volumes not actually put into the shortcut list.
2874 * tests/prop-editor.c (object_changed): Plug leak.
2876 * tests/testfilechooser.c (main): Plug some leaks and expose
2879 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
2880 object. Fixed #136652.
2882 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
2883 have no screen. Fixes #137260.
2884 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
2885 thereby fixing leak. Fixes #137259.
2887 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
2888 slider buttons have been destroyed.
2889 (gtk_path_bar_remove): Make this work for slider buttons too.
2892 2004-03-15 Morten Welinder <terra@gnome.org>
2894 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
2895 Sanitize and plug leak.
2896 (check_icon_theme): Only do something if the widget has a screen.
2898 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
2900 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2901 Move the repositioning logic from _gtk_entry_completion() popup
2902 over here. Fixes #137355, reported by Niklas Knutsson.