1 Fri Mar 29 18:09:18 2002 Owen Taylor <otaylor@redhat.com>
3 * gtk/gtkaccelgroup.c (gtk_accel_group_query): Call
4 gdk_keyval_to_lower() on the key passed in, since we
5 lowercase all other key vals passed in, so querying
6 keyvals will otherwise fail if the caller used
7 an uppercase accelerators (#76899, Vitaly Tishkov)
9 Fri Mar 29 17:41:21 2002 Owen Taylor <otaylor@redhat.com>
11 * gtk/gtkmain.c (load_modules): Fix screwup in handling
12 of module path that was resulting in freed memory being
13 accessed when both GTK_MODULES and a theme were set.
14 (#76902, Johan Dahlin)
16 Fri Mar 29 17:57:36 2002 Owen Taylor <otaylor@redhat.com>
18 * gtk/gtkiconfactory.c (get_default_icons): Fix wrong
19 stock id's for ADD/REMOVE. (#76915, Vitaly Tishkov)
21 2002-03-29 Hans Breuer <hans@breuer.org>
23 * gtk/gtkmain.h : fix typo in gtk_init_check macro, which
24 caused crashes if argc != 0
26 * gtk/stock-icons/makefile.msc : added new icons
28 Fri Mar 29 20:17:35 2002 Kristian Rietveld <kris@gtk.org>
30 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_rows_reordered):
31 remove call to gtk_tree_model_sort_increment_stamp
32 (gtk_tree_model_sort_sort_level): always increment the stamp
34 Fri Mar 29 00:19:41 2002 Owen Taylor <otaylor@redhat.com>
38 * configure.in: Version 2.0.1, binary, interface age 1.
40 * configure.in (GDK_PIXBUF_VERSION): Up required versions
43 * gtk/gtkiconfactory.c gtk/stock-icons/Makefile.am:
44 Add stock_add/remove_16.
46 Thu Mar 28 18:38:30 2002 Owen Taylor <otaylor@redhat.com>
48 * gtk/gtk[hv]paned.c (gtk_[hv]paned_size_allocate):
49 Don't show the window unless the widget is mapped.
50 (#76742, Dennis Björklund, Soeren Sandmann)
52 2002-03-29 Hans Breuer <hans@breuer.org>
54 Fixed dashed line issues (#74441) to an IMO reasonable extend.
55 That is: use PS_USERSTYLE on WinNT (the next GDI limit appears
56 to be with lines width > 50); Render horizontal and vertical
57 dashed lines on Win9x 'by hand'. Dotted selection rectangles
60 * gdk/win32/gdkprivate-win32.h : add pen_dashes pointer and
61 num_pen_dashes to _GdkGCWin32
62 * gdk/win32/gdkgc-win32.c : initialize pen_dashes and remove
63 the guesses from dashes to windoze line styles.
64 (predraw_set_forground) : always ExtCreatePen (PS_SOLID) on
65 Win9x, which does not support PS_USERSTYLE.
66 * gdk/win32/gdkdrawable-win32.c : new functions render_line_
67 <horizontal|vertical>. Use them if not running on NT in
68 gdk_win32_draw_<rectangle|segments|lines> ()
70 * gdk/win32/gdkkeys-win32.c (gdk_keyval_name) : return NULL
71 for keyval == 0 to avoid to have zeros in all menu entries
74 2002-03-29 Jakub Steiner <jimmac@ximian.com>
76 * gtk/stock-icons/stock_add_24.png:
77 * gtk/stock-icons/stock_add_16.png:
78 * gtk/stock-icons/stock_remove_24.png:
79 * gtk/stock-icons/stock_remove_16.png: use a simple '+' and '-',
80 works better. the old box was too clumsy
82 Thu Mar 28 21:11:04 2002 Tim Janik <timj@gtk.org>
84 * gtk/gtkfilesel.c (open_new_dir): when encountering non-UTF-8 file
85 names, alert the user with g_message() instead of g_warning() and
86 put out the actual conversion error.
88 2002-03-28 Dave Camp <dave@ximian.com>
90 * gtk/gtktreeview.c (install_scroll_sync_handler): Don't install
91 the handler if the widget isn't realized.
93 2002-03-28 Jakub Steiner <jimmac@ximian.com>
95 * gtk/stock-icons/stock_font*:
96 * gtk/stock-icons/stock_align*:
97 * gtk/stock-icons/stock_text*: better solution to the dark theme
98 problem. Also looks more pretty IMHO
100 2002-03-27 Matthias Clasen <maclas@gmx.de>
102 * configure.in: Try to find libpng via pkg-config first,
103 since libpng-1.2.2 will come with a .pc file.
105 Wed Mar 27 11:10:39 2002 Owen Taylor <otaylor@redhat.com>
107 * gtk/gtknotebook.c (gtk_notebook_real_remove): Set
108 page->last_focus_child to NULL as well as removing the
109 weak reference, to deal with reentrancy in set_focus_child().
110 (#76634, Dennis Björklund)
112 2002-03-27 Murray Cumming <murrayc@usa.net>
114 * gtk/gtktreeview.c: Corrected registered return type of
115 "move-cursor" signal. Had to add a marshaller to
116 gtk/gtkmarshalers.list.
118 Tue Mar 26 14:46:50 2002 Owen Taylor <otaylor@redhat.com>
120 * gtk/gtkmenu.c (gtk_menu_popup): Shuffle the ordering around
121 some more (position before realizing) fixing problems with
122 arrows popping up at the wrong time (#73386), hopefully not
123 introducing other problems. (Reported by Ettore Perrazoli, others)
125 2002-03-26 Dave Camp <dave@ximian.com>
127 * gtk/gtktreeview.c (gtk_tree_view_button_press): Free the path
128 after calling gtk_tree_view_row_activated() rather than before.
130 2002-03-25 Sven Neumann <sven@gimp.org>
132 * gtk/gtkrc.c (gtk_rc_parse_font_name): free the style's
133 font_description before assigning a new one.
134 (gtk_rc_parse_stock): always unref the created icon_set. #76289
136 2002-03-25 Mark McLoughlin <mark@skynet.ie>
138 * gtk/gtkbindings.c: (gtk_binding_entry_add_signal),
139 kill code duplicated in gtk_binding_entry_add_signall.
141 Sun Mar 24 10:32:38 2002 Jonathan Blandford <jrb@redhat.com>
143 * gtk/gtktreemodel.c (gtk_tree_path_copy): Make path arg const, #75653
145 * gtk/gtkfontsel.c (gtk_font_selection_show_available_styles): fix
148 * gtk/gtktreeview.c (gtk_tree_view_button_press): remove the grab
149 when we emit row_activated so that listeners of this signal can
150 grab the mouse, #75629
152 2002-03-23 Havoc Pennington <hp@pobox.com>
154 * gtk/gtktextlayout.c (gtk_text_layout_real_invalidate):
155 invalidate the line containing start, even if the [start,end)
156 range is empty (just invalidate [start,end], essentially).
157 Partially fixes #72374
159 2002-03-23 Havoc Pennington <hp@pobox.com>
161 * gtk/gtktextview.c (gtk_text_view_do_popup): end any selection in
162 progress, patch from db@zigo.dhs.org, #74620
164 2002-03-23 Havoc Pennington <hp@pobox.com>
166 * gtk/gtktextview.c (gtk_text_view_move_cursor_internal): extend
167 selection for pageup/pagedown and ctrl+pageup/pagedown if
168 shift is held. more of #53934
170 2002-03-23 Havoc Pennington <hp@pobox.com>
172 * gtk/gtktextview.c (gtk_text_view_destroy_layout): disconnect
173 layout handlers earlier in the function, to avoid possible
175 (gtk_text_view_invalidate): Don't install idle handlers if
176 layout == NULL, otherwise we get problems during finalization
177 since clearing the buffer invalidates and puts the idle handlers
178 back after we destroy the layout. #74660
179 (gtk_text_view_ensure_layout): Install the validation handlers
180 right after creating the layout.
182 * gtk/gtktexttagtable.c (foreach_unref): call
183 _gtk_text_buffer_notify_will_remove_tag(), #75126
185 2002-03-22 Havoc Pennington <hp@pobox.com>
187 * gdk/x11/gdkfont-x11.c (gdk_fontset_load): add more explanatory
188 text to the error message about missing charsets, and use
189 g_printerr() not g_warning() since this is typically not a
190 programming error (we do not export any API to ask whether
191 a font set will have missing charsets so apps realistically can't
192 do anything other than try the gdk_fontset_load())
194 * gtk/gtktextview.c (gtk_text_view_key_press_event): return FALSE
195 if the text view isn't editable and the user presses Return,
196 so default buttons and such can be activated, #74937
198 * gtk/gtktextbuffer.c (paste_from_buffer): don't insert
199 if the insertion point is not editable and the paste
200 is interactive, #74125
202 * gtk/gtkwindow.c (gtk_window_move_resize): enhance the #if 0
205 * gtk/gtktextbuffer.c (cut_or_copy): only remove the previous
206 cut/copied data right before replacing it, when we know we are
207 going to replace it. Fixes #74049
209 2002-03-22 Richard Hult <rhult@codefactory.se>
211 * gdk/gdkevents.c (gdk_event_get_root_coords): Fix typo, where x
212 value was assigned to both x and y.
214 Fri Mar 22 11:29:11 2002 Owen Taylor <otaylor@redhat.com>
216 Partial fix for problem where keypad keys acted
217 as shift-arrows in an entry rather than arrows (#74327)
219 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Sort lookup
220 results by number of modifiers in the entry. Fixes
221 problem where if a key matched both modified and unmodified
222 key bindings ... e.g., the distinguishing key binding
223 was consumed, then it was random which was used.
225 * gtk/gtkbindings.c (gtk_binding_entries_sort_patterns):
226 Catch the case where there are multiple entries from the
227 same bindingset (with different modifiers), and use only
228 the first entry, which, with the change in _gtk_key_hash_lookup()
229 will be the preferred value.
231 Fri Mar 22 10:56:19 2002 Owen Taylor <otaylor@redhat.com>
233 * gtk/gtkaccelmap.c (gtk_accel_map_save_fd): Fix memory
234 leak. (#74400, Morten Welinder.)
236 * gtk/gtkaccelmap.c: Properly handle short returns from
237 write() calls. (Handling EINTR isn't enough... that only
238 handles the case where you were interrupted before you
239 wrote a single byte.)
241 * gdk/linux-fb/gdkmouse-fb.c gdk/linux-fb/gdkkeyboard-fb.c:
242 Robustify against short returns from write() calls.
244 Fri Mar 22 10:12:10 2002 Owen Taylor <otaylor@redhat.com>
246 * gtk/gtktextview.c (gtk_text_view_paint): Change
247 G_BREAKPOINT() to g_assert_not_reached ().
248 (#75865, Ashok Venkiteswaran)
250 2002-03-22 Tor Lillqvist <tml@iki.fi>
252 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Don't clear
253 all of the pen_style, just the PS_STYLE_MASK. Seems to fix #74441,
254 but that is just the special case of one-pixel wide one-pixel
255 on-off dotted lines. To fully implement generic X11 style dashed
256 lines a major rewrite would be needed.
258 2002-03-21 Matthias Clasen <maclas@gmx.de>
260 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Trivial typo
261 fix. (Vitaly Tishkov, #75726)
263 Thu Mar 21 10:04:05 2002 Owen Taylor <otaylor@redhat.com>
265 * gdk/gdkwindow.c (gdk_window_real_get_depth): Remove
266 some left over debugging code with a G_BREAKPOINT()
269 Wed Mar 20 19:33:31 2002 Owen Taylor <otaylor@redhat.com>
271 * gtk/gtkcalendar.c (gtk_calendar_main_button): When
272 changing months when the user clicks on a prev-month
273 or next-month day, focus and select the new day.
274 Ignore double clicks on prev-month, next-month days.
275 (Based on suggestions from Andras Salamon, #74173)
277 * gtk/gtkcalendar.c: Implement the focused/unfocused
278 selected color change.
280 2002-03-20 Alex Larsson <alexl@redhat.com>
282 Patches from Carlo E. Prelz <fluido@fluido.as>
283 Now gtkfb at least compiles and mostly works. The keyboard
284 stuff needs more loving.
286 * gdk/linux-fb/gdkkeyboard-fb.c (xlate_get_for_keyval,
287 xlate_get_for_keycode, raw_get_for_keyval, raw_get_for_keycode):
288 At least set the out parameters for these calls.
290 * gdk/linux-fb/gdkmain-fb.c:
291 (gdk_pointer_grab_info_libgtk_only, gdk_keyboard_grab_info_libgtk_only):
292 Implement new functions.
294 Wed Mar 20 19:00:03 2002 Owen Taylor <otaylor@redhat.com>
296 * gtk/gtkentry.c (gtk_entry_set_text): Short-circuit
297 the text to the exact same thing, so we don't
298 unexpectedly change the selection or cursor position.
299 (#74290, John Ellis.)
301 Thu Mar 21 00:05:14 2002 Kristian Rietveld <kris@gtk.org>
303 * gtk/gtktreeview.c (gtk_tree_view_get_background_area),
304 (gtk_tree_view_get_cell_area): fix logic (fixes #74235, #73593)
306 Wed Mar 20 17:11:51 2002 Owen Taylor <otaylor@redhat.com>
308 * gtk/gtkrc.c: Patch from Richard Hestilow to fix
309 gtk-font-name changes for widgets that get the actual
310 default style. (#73709)
312 Wed Mar 20 22:59:23 2002 Kristian Rietveld <kris@gtk.org>
314 * gtk/gtkrbtree.[ch]: add _gtk_rbtree_set_fixed_height()
316 * gtk/gtktreeprivate.h: add fixed_height_check field
318 * gtk/gtktreeview.c (gtk_tree_view_init): initialize
319 scroll_sync_timer and fixed_height_check
320 (do_validate_rows): add fixed_height_check. If all validated rows
321 in the first cycle have the same height, then we set that height for
322 the entire tree. This is some sort of 'fake' optimization, but helps
323 a lot for the common case. We keep validating the entire tree in
324 the background though.
325 (gtk_tree_view_set_model): reset fixed_height_check
327 Wed Mar 20 16:36:08 2002 Owen Taylor <otaylor@redhat.com>
329 * gtk/*.c: Patch from Erwann Chenede, #73900 fixing
330 a lot of warnings with Forte CC, mostly implicit
331 casts between void * and function pointers.
333 * gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's
334 state field is not a GdkModifierType. (Also #73900)
336 Wed Mar 20 12:35:22 2002 Owen Taylor <otaylor@redhat.com>
338 * gtk/gtkwidget.c (gtk_widget_grab_default): Remove
339 leftover notification of has-default. (#75508, Jacob
342 Wed Mar 20 12:27:07 2002 Owen Taylor <otaylor@redhat.com>
344 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Allow
345 arrow keys as accelerators, as long as some modifier
348 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Fix
349 incorrect example in the docs.
351 Wed Mar 20 12:06:30 2002 Owen Taylor <otaylor@redhat.com>
353 * gtk/gtkwidget.c (gtk_widget_set_child_visible):
354 Fix segfault when widget->parent is NULL.
355 (#75615, Alexey A. Malyshev)
357 Wed Mar 20 11:32:07 2002 Owen Taylor <otaylor@redhat.com>
359 * gtk/gtkentry.c: Improve test to prevent infinite
360 loop. (#74952, Thomas Leonard)
362 * gtk/gtkmenushell.c (gtk_real_menu_shell_cycle_focus):
363 Fix warning when toplevel menu shell isn't a menu
364 bar. (Thomas Leonard, #75602)
366 Wed Mar 20 11:00:59 2002 Owen Taylor <otaylor@redhat.com>
368 * configure.in: Use $PKG_CONFIG, not pkg-config.
369 (LEE Sau Dan, #75572)
371 Wed Mar 20 10:55:56 2002 Owen Taylor <otaylor@redhat.com>
373 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Fix assignment
374 of time in scroll events. (Sven Neumann, #75574)
376 2002-03-20 Tor Lillqvist <tml@iki.fi>
378 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window): Use
379 gdk_window_get_toplevel(), as it is the top-level windows that are
382 * gdk/win32/gdkwin32.h: Don't include gdkinternals.h.
384 2002-03-19 jacob berkman <jacob@ximian.com>
386 * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
387 gtk_combo_func() returns NULL (bug #75464)
389 2002-03-18 jacob berkman <jacob@ximian.com>
391 * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the
392 correct min/max values for the ratio property (fixes #75331)
394 Mon Mar 18 11:55:03 2002 Owen Taylor <otaylor@redhat.com>
396 * gtk/gtkimmulticontext.c (gtk_im_multicontext_get_slave):
397 Patch from Yao Zhang fixing reference count leak.
399 * gtk/gtkentry.c (gtk_entry_key_release): if (entry->editable),
400 not if (!entry->editable).
402 Mon Mar 18 11:09:17 2002 Owen Taylor <otaylor@redhat.com>
404 * gdk/x11/gdkwindow-x11.c (gdk_window_set_override_redirect):
405 Fix backwards conditional. (#75019, Dan Winship.)
407 Sun Mar 17 01:11:16 2002 Kristian Rietveld <kris@gtk.org>
409 * gtk/gtktreeview.c (gtk_tree_view_size_request): use
410 do_validate_rows instead of validate_rows_handler (fix by
413 Sat Mar 16 23:54:56 2002 Kristian Rietveld <kris@gtk.org>
415 * gdk/x11/gdkwindow-x11.c (gdk_window_set_static_bit_gravity): just
416 return when we have an input_only window (fix by Owen Taylor)
418 * gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): add
421 * gtk/gtktreeview.c (install_scroll_sync_handler): new function,
422 (scroll_sync_handler): ditto,
423 (gtk_tree_view_unrealize): take scroll_sync_timer into account
424 (gtk_tree_view_row_deleted): install scroll_sync_timer instead of
425 calling top_row_to_dy/dy_to_top_row directly
426 -- this greatly speeds up clearing the model (#73199)
428 * gtk/gtktreemodelsort.c
429 (gtk_tree_model_sort_convert_path_to_child_path): fix up this function,
430 for some reason I really screwed it up (fixes #74663)
432 2002-03-16 Sven Neumann <sven@gimp.org>
434 * configure.in (GDK_PIXBUF_DEP_CFLAGS) (GDK_PIXBUF_XLIB_DEP_CFLAGS)
435 (GDK_DEP_CFLAGS) (GTK_DEP_CFLAGS): include CFLAGS from gthread-2.0
436 so that the libs work correctly in a threaded environment.
438 Fri Mar 15 12:51:42 2002 Jonathan Blandford <jrb@redhat.com>
440 * gtk/gtktreeviewcolumn.c
441 (gtk_tree_view_column_new_with_attributes): add example to docs,
442 as people are seeming to have trouble with this function.
444 2002-03-15 Tor Lillqvist <tml@iki.fi>
446 * configure.in: Set MATH_LIB to empty also on Win32.
448 Fri Mar 15 15:37:01 2002 Owen Taylor <otaylor@redhat.com>
450 * gdk/x11/gdkdrawable-x11.c (convert_to_format):
451 Fix byte shift arithmetic for big-endian. (Tracked
452 down with help from Tuomas Kuosmanen)
454 Fri Mar 15 11:28:41 2002 Jonathan Blandford <jrb@redhat.com>
456 * gtk/gtktreeview.c (gtk_tree_view_insert_column_with_data_func):
457 make args const, 74159
458 (gtk_tree_view_insert_column_with_attributes): ditto
460 * gtk/gtktreeviewcolumn.c
461 (gtk_tree_view_column_cell_process_action): remov unused variables.
463 Fri Mar 15 13:31:51 2002 Soeren Sandmann <sandmann@daimi.au.dk>
465 * gtk/gtkmenu.c (gtk_menu_leave_notify): Fix test for "active
468 2002-03-15 Padraig O'Briain <padraig.obriain@sun.com>
470 * gdk/x11/gdkkeys-x11.c (update_keymaps): Fudge keymap to have lower
471 upper case variants if there is only a single keysym per keycode and
472 the key symbol has upper and lower case variants (#74512)
474 Thu Mar 14 17:09:52 2002 Owen Taylor <otaylor@redhat.com>
476 * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
477 improbable reentrancy problem if a window is destroyed
478 while updates are being processed on another window. (Noticed
479 by Michael Meeks, #74708)
481 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
483 * gtk/gtktreemodelsort.c
484 typo in docs for gtk_tree_model_sort_convert_iter_to_child_iter() fixed
487 Thu Mar 14 11:17:18 2002 Owen Taylor <otaylor@redhat.com>
489 * gtk/gtkkeyhash.c (_gtk_key_hash_remove_entry): When
490 removing keys from the key hash, reinsert the right list
491 back into the hash. (Dave Camp, #74571)
493 Wed Mar 13 17:17:40 2002 Owen Taylor <otaylor@redhat.com>
495 * gtk/gtkobject.h: Remove left-over GTK_OBJECT_CONNECTED
496 macro that was defined in terms of the now-gone GTK_CONNECTED
497 flag. (Seth Burgess, #74028)
499 Wed Mar 13 17:11:10 2002 Owen Taylor <otaylor@redhat.com>
501 * gtk/gtkaccelgroup.c (accel_group_weak_ref_detach): Unset
502 the acceleratable_groups qdata because qdata isn't removed
503 on ->dispose but rather on ->finalize. (#74569, found
506 Tue Mar 12 23:14:23 2002 Jonathan Blandford <jrb@redhat.com>
508 * gtk/gtktreeselection.c (gtk_tree_selection_unselect_iter): Fix
511 Sat Mar 9 18:23:25 2002 Richard Hestilow <hestilow@ximian.com>
513 * gtk/gtkimage.c (gtk_image_set_from_filename): Allow NULL
516 Tue Mar 12 10:50:09 2002 Owen Taylor <otaylor@redhat.com>
518 * modules/input/gtkimcontextxim.c (gtk_im_context_xim_filter_keypress):
519 Fix incorrect return value, filter out returns of 0x7f for
520 the delete key. (#74179, Kang Jeong-He)
522 Mon Mar 11 23:42:11 2002 Jonathan Blandford <jrb@redhat.com>
524 * gtk/gtktreemodel.c (gtk_tree_model_foreach): fix totally broken
527 2002-03-11 Matthias Clasen <maclas@gmx.de>
529 * gtk/gtkitemfactory.c (gtk_item_factory_add_foreign): Document
530 gtk_{menu_item,widget}_set_accel_path() as the recommended API.
533 2002-03-11 James Henstridge <james@daa.com.au>
535 * configure.in: set CCAS and CCASFLAGS to get automake 1.6
536 compatibility without breaking things for people using 1.4.
538 Sun Mar 10 21:04:30 2002 Jonathan Blandford <jrb@redhat.com>
540 * gtk/gtktreeview.c (gtk_tree_view_button_press): finally get the
543 Mon Mar 11 01:25:14 2002 Kristian Rietveld <kris@gtk.org>
545 * gtk/gtktreeview.c (gtk_tree_view_button_press): compare path with
546 cursor path and not with the selected iter in the 'decide to edit'