1 2002-03-28 Dave Camp <dave@ximian.com>
3 * gtk/gtktreeview.c (install_scroll_sync_handler): Don't install
4 the handler if the widget isn't realized.
6 2002-03-28 Jakub Steiner <jimmac@ximian.com>
8 * gtk/stock-icons/stock_font*:
9 * gtk/stock-icons/stock_align*:
10 * gtk/stock-icons/stock_text*: better solution to the dark theme
11 problem. Also looks more pretty IMHO
13 2002-03-27 Matthias Clasen <maclas@gmx.de>
15 * configure.in: Try to find libpng via pkg-config first,
16 since libpng-1.2.2 will come with a .pc file.
18 Wed Mar 27 11:10:39 2002 Owen Taylor <otaylor@redhat.com>
20 * gtk/gtknotebook.c (gtk_notebook_real_remove): Set
21 page->last_focus_child to NULL as well as removing the
22 weak reference, to deal with reentrancy in set_focus_child().
23 (#76634, Dennis Björklund)
25 2002-03-27 Murray Cumming <murrayc@usa.net>
27 * gtk/gtktreeview.c: Corrected registered return type of
28 "move-cursor" signal. Had to add a marshaller to
29 gtk/gtkmarshalers.list.
31 Tue Mar 26 14:46:50 2002 Owen Taylor <otaylor@redhat.com>
33 * gtk/gtkmenu.c (gtk_menu_popup): Shuffle the ordering around
34 some more (position before realizing) fixing problems with
35 arrows popping up at the wrong time (#73386), hopefully not
36 introducing other problems. (Reported by Ettore Perrazoli, others)
38 2002-03-26 Dave Camp <dave@ximian.com>
40 * gtk/gtktreeview.c (gtk_tree_view_button_press): Free the path
41 after calling gtk_tree_view_row_activated() rather than before.
43 2002-03-25 Sven Neumann <sven@gimp.org>
45 * gtk/gtkrc.c (gtk_rc_parse_font_name): free the style's
46 font_description before assigning a new one.
47 (gtk_rc_parse_stock): always unref the created icon_set. #76289
49 2002-03-25 Mark McLoughlin <mark@skynet.ie>
51 * gtk/gtkbindings.c: (gtk_binding_entry_add_signal),
52 kill code duplicated in gtk_binding_entry_add_signall.
54 Sun Mar 24 10:32:38 2002 Jonathan Blandford <jrb@redhat.com>
56 * gtk/gtktreemodel.c (gtk_tree_path_copy): Make path arg const, #75653
58 * gtk/gtkfontsel.c (gtk_font_selection_show_available_styles): fix
61 * gtk/gtktreeview.c (gtk_tree_view_button_press): remove the grab
62 when we emit row_activated so that listeners of this signal can
63 grab the mouse, #75629
65 2002-03-23 Havoc Pennington <hp@pobox.com>
67 * gtk/gtktextlayout.c (gtk_text_layout_real_invalidate):
68 invalidate the line containing start, even if the [start,end)
69 range is empty (just invalidate [start,end], essentially).
70 Partially fixes #72374
72 2002-03-23 Havoc Pennington <hp@pobox.com>
74 * gtk/gtktextview.c (gtk_text_view_do_popup): end any selection in
75 progress, patch from db@zigo.dhs.org, #74620
77 2002-03-23 Havoc Pennington <hp@pobox.com>
79 * gtk/gtktextview.c (gtk_text_view_move_cursor_internal): extend
80 selection for pageup/pagedown and ctrl+pageup/pagedown if
81 shift is held. more of #53934
83 2002-03-23 Havoc Pennington <hp@pobox.com>
85 * gtk/gtktextview.c (gtk_text_view_destroy_layout): disconnect
86 layout handlers earlier in the function, to avoid possible
88 (gtk_text_view_invalidate): Don't install idle handlers if
89 layout == NULL, otherwise we get problems during finalization
90 since clearing the buffer invalidates and puts the idle handlers
91 back after we destroy the layout. #74660
92 (gtk_text_view_ensure_layout): Install the validation handlers
93 right after creating the layout.
95 * gtk/gtktexttagtable.c (foreach_unref): call
96 _gtk_text_buffer_notify_will_remove_tag(), #75126
98 2002-03-22 Havoc Pennington <hp@pobox.com>
100 * gdk/x11/gdkfont-x11.c (gdk_fontset_load): add more explanatory
101 text to the error message about missing charsets, and use
102 g_printerr() not g_warning() since this is typically not a
103 programming error (we do not export any API to ask whether
104 a font set will have missing charsets so apps realistically can't
105 do anything other than try the gdk_fontset_load())
107 * gtk/gtktextview.c (gtk_text_view_key_press_event): return FALSE
108 if the text view isn't editable and the user presses Return,
109 so default buttons and such can be activated, #74937
111 * gtk/gtktextbuffer.c (paste_from_buffer): don't insert
112 if the insertion point is not editable and the paste
113 is interactive, #74125
115 * gtk/gtkwindow.c (gtk_window_move_resize): enhance the #if 0
118 * gtk/gtktextbuffer.c (cut_or_copy): only remove the previous
119 cut/copied data right before replacing it, when we know we are
120 going to replace it. Fixes #74049
122 2002-03-22 Richard Hult <rhult@codefactory.se>
124 * gdk/gdkevents.c (gdk_event_get_root_coords): Fix typo, where x
125 value was assigned to both x and y.
127 Fri Mar 22 11:29:11 2002 Owen Taylor <otaylor@redhat.com>
129 Partial fix for problem where keypad keys acted
130 as shift-arrows in an entry rather than arrows (#74327)
132 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Sort lookup
133 results by number of modifiers in the entry. Fixes
134 problem where if a key matched both modified and unmodified
135 key bindings ... e.g., the distinguishing key binding
136 was consumed, then it was random which was used.
138 * gtk/gtkbindings.c (gtk_binding_entries_sort_patterns):
139 Catch the case where there are multiple entries from the
140 same bindingset (with different modifiers), and use only
141 the first entry, which, with the change in _gtk_key_hash_lookup()
142 will be the preferred value.
144 Fri Mar 22 10:56:19 2002 Owen Taylor <otaylor@redhat.com>
146 * gtk/gtkaccelmap.c (gtk_accel_map_save_fd): Fix memory
147 leak. (#74400, Morten Welinder.)
149 * gtk/gtkaccelmap.c: Properly handle short returns from
150 write() calls. (Handling EINTR isn't enough... that only
151 handles the case where you were interrupted before you
152 wrote a single byte.)
154 * gdk/linux-fb/gdkmouse-fb.c gdk/linux-fb/gdkkeyboard-fb.c:
155 Robustify against short returns from write() calls.
157 Fri Mar 22 10:12:10 2002 Owen Taylor <otaylor@redhat.com>
159 * gtk/gtktextview.c (gtk_text_view_paint): Change
160 G_BREAKPOINT() to g_assert_not_reached ().
161 (#75865, Ashok Venkiteswaran)
163 2002-03-22 Tor Lillqvist <tml@iki.fi>
165 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Don't clear
166 all of the pen_style, just the PS_STYLE_MASK. Seems to fix #74441,
167 but that is just the special case of one-pixel wide one-pixel
168 on-off dotted lines. To fully implement generic X11 style dashed
169 lines a major rewrite would be needed.
171 2002-03-21 Matthias Clasen <maclas@gmx.de>
173 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Trivial typo
174 fix. (Vitaly Tishkov, #75726)
176 Thu Mar 21 10:04:05 2002 Owen Taylor <otaylor@redhat.com>
178 * gdk/gdkwindow.c (gdk_window_real_get_depth): Remove
179 some left over debugging code with a G_BREAKPOINT()
182 Wed Mar 20 19:33:31 2002 Owen Taylor <otaylor@redhat.com>
184 * gtk/gtkcalendar.c (gtk_calendar_main_button): When
185 changing months when the user clicks on a prev-month
186 or next-month day, focus and select the new day.
187 Ignore double clicks on prev-month, next-month days.
188 (Based on suggestions from Andras Salamon, #74173)
190 * gtk/gtkcalendar.c: Implement the focused/unfocused
191 selected color change.
193 2002-03-20 Alex Larsson <alexl@redhat.com>
195 Patches from Carlo E. Prelz <fluido@fluido.as>
196 Now gtkfb at least compiles and mostly works. The keyboard
197 stuff needs more loving.
199 * gdk/linux-fb/gdkkeyboard-fb.c (xlate_get_for_keyval,
200 xlate_get_for_keycode, raw_get_for_keyval, raw_get_for_keycode):
201 At least set the out parameters for these calls.
203 * gdk/linux-fb/gdkmain-fb.c:
204 (gdk_pointer_grab_info_libgtk_only, gdk_keyboard_grab_info_libgtk_only):
205 Implement new functions.
207 Wed Mar 20 19:00:03 2002 Owen Taylor <otaylor@redhat.com>
209 * gtk/gtkentry.c (gtk_entry_set_text): Short-circuit
210 the text to the exact same thing, so we don't
211 unexpectedly change the selection or cursor position.
212 (#74290, John Ellis.)
214 Thu Mar 21 00:05:14 2002 Kristian Rietveld <kris@gtk.org>
216 * gtk/gtktreeview.c (gtk_tree_view_get_background_area),
217 (gtk_tree_view_get_cell_area): fix logic (fixes #74235, #73593)
219 Wed Mar 20 17:11:51 2002 Owen Taylor <otaylor@redhat.com>
221 * gtk/gtkrc.c: Patch from Richard Hestilow to fix
222 gtk-font-name changes for widgets that get the actual
223 default style. (#73709)
225 Wed Mar 20 22:59:23 2002 Kristian Rietveld <kris@gtk.org>
227 * gtk/gtkrbtree.[ch]: add _gtk_rbtree_set_fixed_height()
229 * gtk/gtktreeprivate.h: add fixed_height_check field
231 * gtk/gtktreeview.c (gtk_tree_view_init): initialize
232 scroll_sync_timer and fixed_height_check
233 (do_validate_rows): add fixed_height_check. If all validated rows
234 in the first cycle have the same height, then we set that height for
235 the entire tree. This is some sort of 'fake' optimization, but helps
236 a lot for the common case. We keep validating the entire tree in
237 the background though.
238 (gtk_tree_view_set_model): reset fixed_height_check
240 Wed Mar 20 16:36:08 2002 Owen Taylor <otaylor@redhat.com>
242 * gtk/*.c: Patch from Erwann Chenede, #73900 fixing
243 a lot of warnings with Forte CC, mostly implicit
244 casts between void * and function pointers.
246 * gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's
247 state field is not a GdkModifierType. (Also #73900)
249 Wed Mar 20 12:35:22 2002 Owen Taylor <otaylor@redhat.com>
251 * gtk/gtkwidget.c (gtk_widget_grab_default): Remove
252 leftover notification of has-default. (#75508, Jacob
255 Wed Mar 20 12:27:07 2002 Owen Taylor <otaylor@redhat.com>
257 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Allow
258 arrow keys as accelerators, as long as some modifier
261 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Fix
262 incorrect example in the docs.
264 Wed Mar 20 12:06:30 2002 Owen Taylor <otaylor@redhat.com>
266 * gtk/gtkwidget.c (gtk_widget_set_child_visible):
267 Fix segfault when widget->parent is NULL.
268 (#75615, Alexey A. Malyshev)
270 Wed Mar 20 11:32:07 2002 Owen Taylor <otaylor@redhat.com>
272 * gtk/gtkentry.c: Improve test to prevent infinite
273 loop. (#74952, Thomas Leonard)
275 * gtk/gtkmenushell.c (gtk_real_menu_shell_cycle_focus):
276 Fix warning when toplevel menu shell isn't a menu
277 bar. (Thomas Leonard, #75602)
279 Wed Mar 20 11:00:59 2002 Owen Taylor <otaylor@redhat.com>
281 * configure.in: Use $PKG_CONFIG, not pkg-config.
282 (LEE Sau Dan, #75572)
284 Wed Mar 20 10:55:56 2002 Owen Taylor <otaylor@redhat.com>
286 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Fix assignment
287 of time in scroll events. (Sven Neumann, #75574)
289 2002-03-20 Tor Lillqvist <tml@iki.fi>
291 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window): Use
292 gdk_window_get_toplevel(), as it is the top-level windows that are
295 * gdk/win32/gdkwin32.h: Don't include gdkinternals.h.
297 2002-03-19 jacob berkman <jacob@ximian.com>
299 * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
300 gtk_combo_func() returns NULL (bug #75464)
302 2002-03-18 jacob berkman <jacob@ximian.com>
304 * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the
305 correct min/max values for the ratio property (fixes #75331)
307 Mon Mar 18 11:55:03 2002 Owen Taylor <otaylor@redhat.com>
309 * gtk/gtkimmulticontext.c (gtk_im_multicontext_get_slave):
310 Patch from Yao Zhang fixing reference count leak.
312 * gtk/gtkentry.c (gtk_entry_key_release): if (entry->editable),
313 not if (!entry->editable).
315 Mon Mar 18 11:09:17 2002 Owen Taylor <otaylor@redhat.com>
317 * gdk/x11/gdkwindow-x11.c (gdk_window_set_override_redirect):
318 Fix backwards conditional. (#75019, Dan Winship.)
320 Sun Mar 17 01:11:16 2002 Kristian Rietveld <kris@gtk.org>
322 * gtk/gtktreeview.c (gtk_tree_view_size_request): use
323 do_validate_rows instead of validate_rows_handler (fix by
326 Sat Mar 16 23:54:56 2002 Kristian Rietveld <kris@gtk.org>
328 * gdk/x11/gdkwindow-x11.c (gdk_window_set_static_bit_gravity): just
329 return when we have an input_only window (fix by Owen Taylor)
331 * gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): add
334 * gtk/gtktreeview.c (install_scroll_sync_handler): new function,
335 (scroll_sync_handler): ditto,
336 (gtk_tree_view_unrealize): take scroll_sync_timer into account
337 (gtk_tree_view_row_deleted): install scroll_sync_timer instead of
338 calling top_row_to_dy/dy_to_top_row directly
339 -- this greatly speeds up clearing the model (#73199)
341 * gtk/gtktreemodelsort.c
342 (gtk_tree_model_sort_convert_path_to_child_path): fix up this function,
343 for some reason I really screwed it up (fixes #74663)
345 2002-03-16 Sven Neumann <sven@gimp.org>
347 * configure.in (GDK_PIXBUF_DEP_CFLAGS) (GDK_PIXBUF_XLIB_DEP_CFLAGS)
348 (GDK_DEP_CFLAGS) (GTK_DEP_CFLAGS): include CFLAGS from gthread-2.0
349 so that the libs work correctly in a threaded environment.
351 Fri Mar 15 12:51:42 2002 Jonathan Blandford <jrb@redhat.com>
353 * gtk/gtktreeviewcolumn.c
354 (gtk_tree_view_column_new_with_attributes): add example to docs,
355 as people are seeming to have trouble with this function.
357 2002-03-15 Tor Lillqvist <tml@iki.fi>
359 * configure.in: Set MATH_LIB to empty also on Win32.
361 Fri Mar 15 15:37:01 2002 Owen Taylor <otaylor@redhat.com>
363 * gdk/x11/gdkdrawable-x11.c (convert_to_format):
364 Fix byte shift arithmetic for big-endian. (Tracked
365 down with help from Tuomas Kuosmanen)
367 Fri Mar 15 11:28:41 2002 Jonathan Blandford <jrb@redhat.com>
369 * gtk/gtktreeview.c (gtk_tree_view_insert_column_with_data_func):
370 make args const, 74159
371 (gtk_tree_view_insert_column_with_attributes): ditto
373 * gtk/gtktreeviewcolumn.c
374 (gtk_tree_view_column_cell_process_action): remov unused variables.
376 Fri Mar 15 13:31:51 2002 Soeren Sandmann <sandmann@daimi.au.dk>
378 * gtk/gtkmenu.c (gtk_menu_leave_notify): Fix test for "active
381 2002-03-15 Padraig O'Briain <padraig.obriain@sun.com>
383 * gdk/x11/gdkkeys-x11.c (update_keymaps): Fudge keymap to have lower
384 upper case variants if there is only a single keysym per keycode and
385 the key symbol has upper and lower case variants (#74512)
387 Thu Mar 14 17:09:52 2002 Owen Taylor <otaylor@redhat.com>
389 * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
390 improbable reentrancy problem if a window is destroyed
391 while updates are being processed on another window. (Noticed
392 by Michael Meeks, #74708)
394 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
396 * gtk/gtktreemodelsort.c
397 typo in docs for gtk_tree_model_sort_convert_iter_to_child_iter() fixed
400 Thu Mar 14 11:17:18 2002 Owen Taylor <otaylor@redhat.com>
402 * gtk/gtkkeyhash.c (_gtk_key_hash_remove_entry): When
403 removing keys from the key hash, reinsert the right list
404 back into the hash. (Dave Camp, #74571)
406 Wed Mar 13 17:17:40 2002 Owen Taylor <otaylor@redhat.com>
408 * gtk/gtkobject.h: Remove left-over GTK_OBJECT_CONNECTED
409 macro that was defined in terms of the now-gone GTK_CONNECTED
410 flag. (Seth Burgess, #74028)
412 Wed Mar 13 17:11:10 2002 Owen Taylor <otaylor@redhat.com>
414 * gtk/gtkaccelgroup.c (accel_group_weak_ref_detach): Unset
415 the acceleratable_groups qdata because qdata isn't removed
416 on ->dispose but rather on ->finalize. (#74569, found
419 Tue Mar 12 23:14:23 2002 Jonathan Blandford <jrb@redhat.com>
421 * gtk/gtktreeselection.c (gtk_tree_selection_unselect_iter): Fix
424 Sat Mar 9 18:23:25 2002 Richard Hestilow <hestilow@ximian.com>
426 * gtk/gtkimage.c (gtk_image_set_from_filename): Allow NULL
429 Tue Mar 12 10:50:09 2002 Owen Taylor <otaylor@redhat.com>
431 * modules/input/gtkimcontextxim.c (gtk_im_context_xim_filter_keypress):
432 Fix incorrect return value, filter out returns of 0x7f for
433 the delete key. (#74179, Kang Jeong-He)
435 Mon Mar 11 23:42:11 2002 Jonathan Blandford <jrb@redhat.com>
437 * gtk/gtktreemodel.c (gtk_tree_model_foreach): fix totally broken
440 2002-03-11 Matthias Clasen <maclas@gmx.de>
442 * gtk/gtkitemfactory.c (gtk_item_factory_add_foreign): Document
443 gtk_{menu_item,widget}_set_accel_path() as the recommended API.
446 2002-03-11 James Henstridge <james@daa.com.au>
448 * configure.in: set CCAS and CCASFLAGS to get automake 1.6
449 compatibility without breaking things for people using 1.4.
451 Sun Mar 10 21:04:30 2002 Jonathan Blandford <jrb@redhat.com>
453 * gtk/gtktreeview.c (gtk_tree_view_button_press): finally get the
456 Mon Mar 11 01:25:14 2002 Kristian Rietveld <kris@gtk.org>
458 * gtk/gtktreeview.c (gtk_tree_view_button_press): compare path with
459 cursor path and not with the selected iter in the 'decide to edit'