1 Sun Aug 22 00:08:44 2004 Matthias Clasen <maclas@gmx.de>
3 Fix #150406, reported by Fernando San Martín Woerner, patch
6 * gtk/gtkentrycompletion.c
7 (gtk_entry_completion_default_completion_func): Check that
8 column is of type G_TYPE_STRING before proceeding.
10 Sat Aug 21 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
12 * gtk/gtktreestore.c (gtk_tree_store_swap): Don't use an
13 uninitialized tree iter. (#150414, Torsten Schoenfeld)
15 Sat Aug 21 23:29:54 2004 Matthias Clasen <maclas@gmx.de>
17 Fix #150738, Tomislav Jonjic.
19 * gtk/gtktoolitem.h (GTK_IS_TOOL_ITEM_CLASS):
20 * gtk/gtktoolbutton.h (GTK_IS_TOOL_BUTTON_CLASS):
21 * gtk/gtktoggleaction.h (GTK_IS_TOGGLE_ACTION_CLASS):
22 * gtk/gtkseparatortoolitem.h (GTK_IS_SEPARATOR_TOOL_ITEM_CLASS):
23 * gtk/gtkradiotoolbutton.h (GTK_IS_RADIO_TOOL_BUTTON_CLASS):
24 * gtk/gtkradioaction.h (GTK_IS_RADIO_ACTION_CLASS):
25 * gtk/gtkuimanager.h (GTK_IS_UI_MANAGER_CLASS):
26 * gtk/gtkaction.h (GTK_IS_ACTION_CLASS): Fix macro definitions.
28 Wed Aug 18 17:25:26 2004 Manish Singh <yosh@gimp.org>
30 * demos/testpixbuf-save.c
31 * demos/gtk-demo/hypertext.c: Get rid of some unnecessary casts.
33 * demos/gtk-demo/appwindow.c: Make activate_email and activate_url
34 match the arguments for GtkAboutDialogActivateLinkFunc.
36 Wed Aug 18 16:18:00 2004 Manish Singh <yosh@gimp.org>
38 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): Initialize height
39 from fixed_height before we do anything, so it always has a valid
42 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Fix call
43 to gtk_tree_model_get (missing "," in param list).
45 2004-08-18 Federico Mena Quintero <federico@ximian.com>
51 * gtk/gtkfilechooserdefault.c: Renamed SHORTCUTS_COL_PATH to
52 SHORTCUTS_COL_DATA. Add SHORTCUTS_COL_IS_VOLUME, to determine
53 easily whether the SHORTCUTS_COL_DATA points to a GtkFilePath or a
55 (shortcuts_model_create): Create a boolean column for
56 SHORTCUTS_COL_IS_VOLUME.
57 (shortcuts_reload_icons): Simplify with the use of the
58 SHORTCUTS_COL_IS_VOLUME column. Don't leak the pixbuf.
59 (shortcuts_insert_path): Add the SHORTCUTS_COL_IS_VOLUME data.
60 (shortcuts_free_row_data): New helper function; frees the data
62 (shortcuts_remove_rows): Don't take a callback for freeing the
63 data; free everything here instead. Use
64 shortcuts_free_row_data().
65 (volume_remove_cb): Removed.
66 (remove_bookmark_cb): Removed.
67 (remove_row_cb): Make this a single generic function to delete
69 (shortcuts_add_volumes): Use remove_row_cb().
70 (shortcuts_add_bookmarks): Likewise.
71 (struct _GtkFileChooserDefault): Removed the
72 shortcuts_current_folder_is_volume field.
73 (shortcuts_add_current_folder): Oops, don't free the volume.
74 (remove_current_folder_cb): Removed.
75 (shortcut_find_position): Simplify through the use of the
76 SHORTCUTS_COL_IS_VOLUME column.
77 (remove_selected_bookmarks): Assert that we don't get a volume.
78 (shortcuts_reorder): Likewise; also, plug a leak.
79 (gtk_file_chooser_default_remove_shortcut_folder): Simplify
80 through the use of shortcuts_remove_rows().
81 (gtk_file_chooser_default_list_shortcut_folders): Assert that we
83 (shortcuts_activate_iter): Simplify.
84 (home_folder_handler): Simplify by using
85 shortcuts_activate_iter().
86 (shortcuts_free): New function; frees all the data columns.
87 (gtk_file_chooser_default_finalize): Unref the
88 shortcuts_filter_model and the shortcuts model data first.
90 Wed Aug 18 08:31:17 2004 Manish Singh <yosh@gimp.org>
92 * gtk/gtkiconview.c: Applied patch from Olivier Andrieu to fix
95 * gtk/gtkicontheme.c (gtk_icon_theme_init): xdg_data_dirs should
96 match constness attributes of g_get_system_data_dirs ().
98 2004-08-17 Matthias Clasen <mclasen@redhat.com>
100 * gtk/gtkicontheme.c (gtk_icon_theme_init): Look up icon themes in the
101 directories specified in the icon theme spec: $HOME/.icons,
102 $XDG_DATA_DIRS/icons, /usr/share/pixmaps. Note that GTK+ used to also look
103 in $GTK_DATA_DIR/icons, $GTK_DATA_DIR/pixmaps and /usr/share/icons. (#148694)
106 * gtk/gtkframe.c (gtk_frame_paint): Take widget->state into account when
107 painting the shadows. (#150351, Tim Janik)
109 2004-08-17 Matthias Clasen <mclasen@redhat.com>
111 * gtk/abicheck.sh: No need for INCLUDE_INTERNAL_SYMBOLS anymore.
113 * gdk/gdk.symbols: Don't use #if defined().
115 * gdk/Makefile.am (gdkalias.h):
116 * gtk/Makefile.am (gtkalias.h): Don't use cpp to filter gtk.symbols.
118 * gdk/makegdkalias.pl:
119 * gtk/makegtkalias.pl: Move the #ifdef processing into the perl script, and
120 keep the #ifdefs which differentiate between platforms.
122 * gtk/Makefile.am (gtk_private_h_sources): Remove gtkinternals.h, it is no
125 2004-08-17 Matthias Clasen <mclasen@redhat.com>
127 * tests/testfilechooserbutton.c: Use g_message() throughout, add RTL envar for
130 * gtk/gtkfilechooserbutton.c: Get rid of HAVE_CONFIG_H.
131 (gtk_file_chooser_button_init): Use gtk_drag_dest_add_text_targets().
132 (gtk_file_chooser_button_drag_data_received): Use gtk_selection_data_get_text().
133 (gtk_file_chooser_button_set_dialog): _gtk_file_chooser_entry_set_base_folder()
134 seems to expect a path, not an uri.
135 (update_dialog): Handle g_filename_from_uri() returning NULL, don't free
138 * gtk/gtkfilechooserbutton.h: Minor stylistic changes.
140 2004-08-17 Matthias Clasen <mclasen@redhat.com>
142 * gtk/gtkfilechooserbutton.[hc]: New widget to go along with
143 GtkFontButton and GtkColorButton for use in preference dialogs.
144 Replaces GnomeFileEntry. (#148108, James M. Cape)
146 * gtk/gtk.h: Include gtkfilechooserbutton.h
148 * gtk/Makefile.am (gtk_public_h_sources): Add gtkfilechooserbutton.h
149 (gtk_c_sources): Add gtkfilechooserbutton.c
151 * gtk/gtk.symbols: Add the GtkFileChooserButton symbols.
153 * gtk/gtkfilechooserutils.[hc]: Make the delegate quark available.
155 * gtk/gtkfilechooserentry.[hc] (_gtk_file_chooser_entry_new): Allow
156 to suppress tab-eating using the new eat_tabs argument. Adjust all
159 * tests/testfilechooserbutton.c: Test for GtkFileChooserButton.
161 * tests/Makefile.am (noinst_PROGRAMS): Add testfilechooserbutton
163 2004-08-16 Matthias Clasen <mclasen@redhat.com>
165 * gtk/gtkwidget.c (gtk_widget_render_icon): Doc update.
167 * gtk/gtkiconfactory.c (render_icon_name_pixbuf): When the size is -1,
168 use the available size closest to 48. (#150147)
170 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): Actually return
171 a pointer to the beginning of the sizes array, not the end.
173 2004-08-16 Morten Welinder <terra@gnome.org>
175 * tests/testtreemodel.c (test_run): Comment out mallinfo stuff.
176 Fix g_print %-strings.
178 * gtk/gtksequence.c (_gtk_sequence_set): Fix C99ism.
180 2004-08-16 Christian Rose <menthos@menthos.com>
182 * configure.in: Added "bs" to ALL_LINGUAS.
184 Mon Aug 16 01:35:25 2004 Matthias Clasen <maclas@gmx.de>
187 * gtk/gtkcombobox.[hc]: Add a ::focus-on-click property and
188 change the default behaviour to focus on click.
190 * gtk/gtkbutton.c (gtk_button_set_focus_on_click): Typo fix.
192 Mon Aug 16 01:03:08 2004 Matthias Clasen <maclas@gmx.de>
194 * gtk/gtktextiter.c (gtk_text_iter_set_visible_line_offset):
195 (gtk_text_iter_set_visible_line_index): Count from the
196 beginning of the line, not from the current position. (#150101,
199 2004-08-15 Tor Lillqvist <tml@iki.fi>
201 * gtk-zip.sh.in: Fix typo. The gtk.immodules file had never been
202 included in my zipfiles...!
204 * gtk/gtkfilesystemwin32.c (extract_icon): Improve handling of
205 icon alpha channel (on Windows XP) and mask (older Windows
206 versions). (#148641, Tim Evans)
208 Sun Aug 15 02:31:55 2004 Matthias Clasen <maclas@gmx.de>
210 * gtk/gtkfilesystemunix.c (get_icon_type_from_stat): Make
211 the use of S_ISFIFO and S_ISSOCK conditional. (#150146,
214 2004-08-14 Tor Lillqvist <tml@iki.fi>
216 * gtk/gtkfilechooserdefault.c (shortcuts_append_home,
217 shortcuts_append_desktop, set_local_only)
218 * gtk/gtkfilesystemwin32.c (gtk_file_system_win32_render_icon)
219 * gtk/gtkpathbar.c (find_button_type, _gtk_path_bar_set_file_system):
220 Guard against g_get_home_dir() returning NULL. (#150007)
222 Sat Aug 14 17:56:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
224 * gtk/gtkentry.c (gtk_entry_get_pixel_ranges): New function.
226 * gtk/gtkentry.c (in_selection): New function using
227 gtk_entry_get_pixel_ranges() to determine whether a click is in
228 the selection. Improve entry behavior wrt. dragging and
229 selecting. Bug #143249.
231 Sat Aug 14 17:53:46 2004 Soeren Sandmann <sandmann@daimi.au.dk>
233 * configure.in: Require glib 2.5.2
235 * gtk/gtksequence.[ch]: New internal data structure.
237 * gtk/gtkliststore.[hc]: Reimplement in terms of new data
240 * tests/Makefile.am (testtreemodel_SOURCES):
241 * tests/testtreemodel.c: New test program written by Matthias.
243 2004-08-13 Matthias Clasen <mclasen@redhat.com>
245 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_style_set):
246 Don't install the settings_notify_cb from here, since it
247 may be called before the first screen_changed signal,
248 confusing the logic in gtk_file_chooser_screen_changed().
249 (#148803, Abel Daniel)
251 * gtk/gtkcombobox.c: Make re-sensitivation work
254 * gtk/gtkaction.c (gtk_action_new): Fix the docs.
256 Fri Aug 13 01:06:56 2004 Matthias Clasen <maclas@gmx.de>
258 * gtk/gtktreeview.c (gtk_tree_view_row_inserted):
259 Make fixed height mode handle insertions. (#135955,
260 Michael Vogt, testcase by Tim-Philipp Müller, fix by
263 Fri Aug 13 00:40:18 2004 Matthias Clasen <maclas@gmx.de>
265 * gtk/gtkhandlebox.c: Add missing include.
267 Thu Aug 12 23:52:12 2004 Matthias Clasen <maclas@gmx.de>
269 Fix #149547, Markus Lausser:
271 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate):
272 * gtk/gtkcombobox.c (gtk_combo_box_size_request): Don't
273 crash if size_request or size_allocate are called early.
275 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate): Protect
276 against being allocated too small.
278 Thu Aug 12 21:02:57 2004 Matthias Clasen <maclas@gmx.de>
280 * demos/gtk-demo/appwindow.c (about_cb): Adjust to GtkAboutDialog
283 * gtk/gtkaboutdialog.h:
284 * gtk/gtkaboutdialog.c (gtk_about_dialog_set_email_hook):
285 (gtk_about_dialog_set_url_hook): Add callback data and destroy notify
286 for language bindings. (#149999, Olivier Andrieu)
288 2004-08-12 Matthias Clasen <mclasen@redhat.com>
290 * gtk/gtkfilesystem.c: Underscore-prefix gtk_file_system_module_get_type().
291 * gtk/gtkfilechooserdefault.c: Underscore-prefix shortcuts_model_filter_get_type().
293 * gtk/gtkimmodule.c: Make gtk_im_module_get_type() static.
295 * gtk/gtkinternals.h: Remove the no longer exported get_type functions.
297 Thu Aug 12 01:35:46 2004 Matthias Clasen <maclas@gmx.de>
299 * gtk/gtkiconview.c: Make the icon view accessible by
300 implementing the necesssary ATK interfaces. (#149728,
303 Thu Aug 12 00:02:29 2004 Matthias Clasen <maclas@gmx.de
305 * gtk/gtkaction.c (gtk_action_new): Link to information about
306 allowed action names. (#149620, David Malcolm)
308 Wed Aug 11 23:14:25 2004 Matthias Clasen <maclas@gmx.de>
312 * gtk/gtkaction.c (gtk_action_set_sensitive):
313 (gtk_action_set_visible): Add setters for the ::sensitive
314 and ::visible properties of GtkAction. (#149622, David Malcolm)
316 2004-08-11 Federico Mena Quintero <federico@ximian.com>
318 Fix #149422, #143457:
320 * gtk/gtkfilechooserdefault.c
321 (gtk_file_chooser_default_should_respond): Rewrite to take the
322 current focus into account, the contents of the save entry, and
323 the last focus for the shortcuts list.
324 (switch_to_selected_folder): We don't need an assertion on the
327 Wed Aug 11 20:56:00 2004 Matthias Clasen <maclas@gmx.de>
329 * gtk/gtkinternals.h:
330 * gtk/gtk.symbols: Add shortcuts_model_filter_get_type.
332 * gtk/abicheck.sh: Check all symbols.
334 Wed Aug 11 19:20:34 2004 Matthias Clasen <maclas@gmx.de>
336 * gtk/gtktreeview.c (gtk_tree_view_maybe_begin_dragging_row):
337 Don't start a drag if the treeview is only a
338 drag destination. (#149836, Pawel Salek)
340 2004-08-11 Matthias Clasen <mclasen@redhat.com>
342 * gtk/gtktreedatalist.[hc]:
343 * gtk/gtkliststore.c:
344 * gtk/gtktreestore.c: Underscore-prefix
345 gtk_tree_data_list_compare_func.
347 * gtk/gtk.symbols: Remove gtk_tree_data_list_compare_func.
349 * gtk/makegtkalias.pl: No need to include gtktreedatalist.h
352 2004-08-10 Matthias Clasen <mclasen@redhat.com>
355 * gtk/Makefile.am: Define TESTS, not TEST, so that make check
356 actually triggers abicheck.sh.
358 * gdk/makegdkalias.pl:
359 * gtk/makegtkalias.pl: Include glib.h before using glib symbols. D'oh.
361 * gdk/makegdkalias.pl:
362 * gtk/makegtkalias.pl: Protect gtkalias.h by G_HAVE_GNUC_VISIBILITY.
364 * gtk/Makefile.am: Include gtkalias.h in the generated
365 sources gtkmarhalers.c and gtkmarshal.c.
367 * gtk/makegtkalias.pl: Cosmetic fix.
369 * gdk/Makefile.am: Remove the . which was accidentally added
370 to SUBDIRS. Include gdkalias.h in the generated sources
371 gdkenumtypes.c and gdkmarshalers.c.
373 * gdk/makegdkalias.pl: Cosmetic fix.
375 * gdk/Makefile.am: Add gdkalias.h to BUILT_SOURCES.
377 2004-08-09 Hans Breuer <hans@breuer.org>
379 * gtk/makefile.msc.in : autogenerate gtk.def, cleanup
381 * gdk/win32/gdkwindow-win32.c gdk/win32/gdkevents-win32.c :
382 removed long time unused ifdef/ed code (WITHOUT_WM_CREATE),
383 removed duplicated call to gdk_window_set_cursor()
385 Mon Aug 9 15:41:17 2004 Matthias Clasen <maclas@gmx.de>
387 Add hidden aliases for exported symbols which are
388 used internally in order to get rid of many PLT
389 entries. (#145519, Arjan van de Ven)
391 * gdk/Makefile.am: Add rules to generate gdk.def and
392 gdkalias.h from gdk.symbols, and make make check check
393 the abi with abicheck.sh.
395 * gdk/gdk.symbols: New file. Definition of the GDK ABI.
396 The file can be processed by cpp to filter out certain
399 * gdk/abicheck.sh: New file. Script to check the actually
400 symbols exported from libgdk-x11.2.0.so against the symbols
401 found in gdk.symbols.
403 * gdk/makegdkalias.pl: New file. Perl script to generate the
404 header containing the alias definitions for internally used
405 exported symbols from a list of symbols.
407 * gdk/*.c, gdk/x11/*.c: Include gdkalias.h
409 2004-08-09 Morten Welinder <terra@gnome.org>
411 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): Fix C99ism.
413 Mon Aug 9 15:27:01 2004 Matthias Clasen <maclas@gmx.de>
415 * gtk/makegtkalias.pl: Also revert
416 GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API to its old status.
418 Mon Aug 9 15:19:34 2004 Matthias Clasen <maclas@gmx.de>
421 * gdk/gdkrgb.h: Add the exported functions
422 gdk_rgb_colormap_ditherable(), gdk_pointer_grab_info_libgtk_only(),
423 gdk_keyboard_grab_info_libgtk_only() to the appropriate
426 Mon Aug 9 14:24:46 2004 Matthias Clasen <maclas@gmx.de>
428 * gdk/x11/gdkevents-x11.c (gdk_event_send_client_message_to_all_recurse):
431 Mon Aug 9 12:48:04 2004 Matthias Clasen <maclas@gmx.de>
433 Add hidden aliases for exported symbols which are
434 used internally in order to get rid of many PLT
435 entries. (#145519, Arjan van de Ven)
437 * gtk/Makefile.am: Add rules to generate gtk.def and
438 gtkalias.h from gtk.symbols, and make make check check
439 the abi with abicheck.sh.
440 (gtk_private_h_sources): Add gtkinternals.h
441 (gtk_built_private_headers): Add gtkalias.h
442 (gtk_extra_sources): Add gtk.symbols
443 (EXTRA_DIST): Add makegtkalias.pl and abicheck.sh
445 * gtk/gtk.symbols: New file. Definition of the GTK+ ABI.
446 The file can be processed by cpp to filter out certain
449 * gtk/abicheck.sh: New file. Script to check the actually
450 symbols exported from libgtk-x11.2.0.so against the symbols
451 found in gtk.symbols.
453 * gtk/makegtkalias.pl: New file. Perl script to generate the
454 header containing the alias definitions for internally used
455 exported symbols from a list of symbols.
457 * gtk/gtkinternals.h: New file. An uninstalled header listing
458 symbols which must be exported for some reason and do not appear
461 * gtk/*.c: Include gtkalias.h
463 Mon Aug 9 11:49:46 2004 Matthias Clasen <maclas@gmx.de>
465 * gtk/gtkmain.c: Only undef gtk_init_check and gtk_init on win32.
467 Mon Aug 9 10:50:05 2004 Matthias Clasen <maclas@gmx.de>
469 * gtk/gtkentry.h: Add gtk_entry_layout_index_to_text_index()
470 and its inverse. The have always been exported and are meant
473 Mon Aug 9 00:28:34 2004 Matthias Clasen <maclas@gmx.de>
475 * gtk/gtkicontheme.c (load_svg_at_size): Don't leak the
478 Mon Aug 9 00:13:03 2004 Matthias Clasen <maclas@gmx.de>
480 * gtk/gtkaboutdialog.c (icon_set_new_from_pixbufs): Don't
481 leak the icon source.
483 Sun Aug 8 23:46:20 2004 Matthias Clasen <maclas@gmx.de>
485 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Don't
486 leak a reference to the pixbufs.
488 Sun Aug 8 23:36:55 2004 Matthias Clasen <maclas@gmx.de>
490 * gtk/gtkcombobox.c (gtk_combo_box_menu_setup): Ref
492 (gtk_combo_box_menu_destroy): Unref the column.
494 Sun Aug 8 23:35:00 2004 Matthias Clasen <maclas@gmx.de>
496 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets):
497 (gtk_drag_dest_add_text_targets): Don't leak a reference
500 Sun Aug 8 22:52:26 2004 Matthias Clasen <maclas@gmx.de>
502 * gtk/gtkcombobox.c (find_menu_by_path): Don't stumble over
503 separators which are not backed by model rows.
505 Sun Aug 8 11:01:23 2004 Matthias Clasen <maclas@gmx.de>
507 * gtk/gtkcombobox.c (gtk_combo_box_set_active): Don't leak
510 2004-08-08 Hans Breuer <hans@breuer.org>
512 * gtk/gtkdnd.c (gtk_drag_dest_set) : take targets into
513 account again to allow dnd of other things than text
515 * gdk/win32/gdkselection-win32.c : offer windows bitmap to
516 be pasted from clipboard (makes The GIMP 2.1's
517 "File/Acquire/Paste as New" work, only using gtk+ API)
519 Sun Aug 8 01:32:36 2004 Matthias Clasen <maclas@gmx.de>
521 * gtk/gtk.def: Add gtk_cell_renderer_progress_get_type.
523 Sun Aug 8 01:29:08 2004 Matthias Clasen <maclas@gmx.de>
525 * gtk/gtk.def: Replace duplicate gtk_tree_view_get_hover_expand
526 by gtk_tree_view_set_hover_expand.
528 Sun Aug 8 01:23:08 2004 Matthias Clasen <maclas@gmx.de>
530 * gtk/gtk.def: Remove the static function gtk_menu_get_private.
532 2004-08-07 Tor Lillqvist <tml@iki.fi>
534 * gdk/win32/gdkkeys-win32.c (update_keymap): Don't hardcode
535 mapping of VK_DECIMAL to GDK_KP_Decimal. Instead, let ToAsciiEx()
536 map it to what's printed on the keypad decimal key for the current
537 input locale (keyboard layout). (#149404)
539 Sat Aug 7 18:19:03 2004 Matthias Clasen <maclas@gmx.de>
541 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
542 (shortcuts_list_create): Use GtkTreeViewRowSeparatorFunc
543 instead of GtkCellRendererSepText. (#147864)
545 * gtk/gtkcellrendererseptext.[hc]: Removed.
547 * gtk/Makefile.am: Remove gtkcellrendererseptext.[hc]
549 Sat Aug 7 18:15:15 2004 Matthias Clasen <maclas@gmx.de>
551 * gtk/gtkcombobox.c (gtk_combo_box_menu_row_deleted):
552 (gtk_combo_box_menu_row_inserted):
553 (gtk_combo_box_menu_row_changed): Correctly handle
554 insertion and deletion of separators in menu mode.
556 2004-08-07 Tor Lillqvist <tml@iki.fi>
558 * gdk/win32/gdkevents-win32.c (handle_configure_event,
559 gdk_event_translate:WM_WINDOWPOSCHANGED): Add _gdk_offset_{x,y} to
560 top-level window coordinates, not just in generated
561 events. (#148526, Robert Ögren)
563 Sat Aug 7 01:26:08 2004 Matthias Clasen <maclas@gmx.de>
565 Make the column drag code a bit more robust (still scary,
566 though). (#106992, Christian Biere)
568 * gtk/gtktreeview.c (_gtk_tree_view_column_start_drag): Assert
569 that cur_reorder is NULL here.
571 * gtk/gtktreeview.c (gtk_tree_view_button_release_drag_column):
572 Reset cur_reorder to NULL, and only hide drag_highlight_window
575 2004-08-06 Federico Mena Quintero <federico@ximian.com>
579 * gtk/gtkfilechooserdefault.c (save_widgets_create): Use a
580 GtkFileChooserEntry for the file name, rather than a GtkEntry.
581 (update_chooser_entry): Set the contents of the file chooser entry
582 rather than the plain entry's.
583 (gtk_file_chooser_default_set_current_folder): Set the new folder
585 (gtk_file_chooser_default_set_current_name): Set the name on the
587 (check_save_entry): Use the file chooser entry rather than the
590 * gtk/gtkfilechooserentry.c
591 (_gtk_file_chooser_entry_set_base_folder): Call
592 gtk_file_chooser_entry_changed() so that we recompute the current
593 folder based on the new base folder.
595 2004-08-06 Hans Breuer <hans@breuer.org>
597 * gdk/win32/gdkwindow-win32.c : make it compile and more
598 similar to the X11 implementation [backward compatibility
599 for GDK_WINDOW_TEMP, GDK_INPUT_ONLY (fixes bug #148702),
600 use the *screen* function variants, dont reparent already
602 (get_visible_region) : take the win32 part into account
603 (_gdk_windowing_window_destroy) : remove from handle table
605 * gdk/win32/gdkdisplay-win32.c : added
606 gdk_display_(request|supports)_selection_notification ()
607 with a currently mostly pointless implementation ;-)
609 * gtk/gtkfilesystemwin32.c (*_to_path) : same changes as on *NIX,
611 (gtk_file_system_win32_render_icon) : use new GTK_STOCK_DIRECTORY
613 * gtk/makefile.msc.in demos/gtk-demo/makefile.msc.in
614 gtk/stock-icons/makefile.msc tests/makefile.msc : updated
616 * gdk/gdk.def gtk/gtk.def : updated externals
618 * tests/testiconview.c : remove unneeded dirent.h inclusion
620 2004-08-06 Matthias Clasen <mclasen@redhat.com>
622 * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): Fix
623 an off-by-one error. (#141809, Markku Vire)
625 * gtk/gtkdnd.c (gtk_drag_dest_set, gtk_drag_source_set): Really
626 fix the initialization of the target list.
628 Support XDND v5. (#10220, Owen Taylor)
630 * gdk/x11/gdkdnd-x11.c: Record the XDND version and whether the
631 drop was successful in the GdkDragContextPrivateX11 struct.
632 (xdnd_finished_filter): Store the success status of the drop
633 for an XDND version 5 interaction. For other versions, always
634 assume the drop was successful.
635 (xdnd_check_dest): Return the protocol version.
636 (_gdk_drag_get_protocol_for_display): Return the protocol version.
637 (gdk_drag_find_window_for_screen): Store the used protocol version
638 in the GdkDragContext.
639 (xdnd_send_enter): Send the used protocol version from the context,
640 instead of hardwiring 3.
641 (xdnd_enter_filter): Accept protocol versions >= 3 and store the
642 used protocol version in the context.
645 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): New function
646 to find out whether a drop was successful.
648 2004-07-28 Robert Ögren <gtk@roboros.com>
650 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Set x_root
651 and y_root in button and motion events from the tablet. (#148715)
653 Thu Aug 5 19:58:08 2004 Soeren Sandmann <sandmann@daimi.au.dk>
655 * gtk/gtkplug.c (gtk_plug_realize): Call
656 gdk_window_enable_synchronized_configure()
658 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): Make
659 noop if gdk_window_enable_synchronized_configure() has not been
662 2004-08-04 Matthias Clasen <mclasen@redhat.com>
664 * gtk/gtkfilechooser.[hc]: Add setter and getter for the
665 ::show-hidden property. (#145610, Jeff Franks)
667 * tests/testiconview.c: Add buttons to select and unselect all
668 nodes, make the popup menu actually work.
670 * gtk/gtkiconview.c: Make GTK_SELECTION_BROWSE work as intended,
671 let button 3 presses through to the app, to make popup menus
674 * tests/Makefile.am: Add testiconview.
675 * tests/testiconview.c: A test for GtkIconView
676 * tests/gnome-textfile.png: ...which uses this image.
678 Wed Aug 4 01:37:57 2004 Matthias Clasen <maclas@gmx.de>
681 * gtk/gtktreestore.c:
682 * gtk/gtktreemodelfilter.c:
683 * gtk/gtknotebook.c: s/childs/children/g.
685 Wed Aug 4 01:04:48 2004 Matthias Clasen <maclas@gmx.de>
687 Fix #133446, noticed by Christian Persch:
689 * gtk/gtkaction.c (gtk_action_class_init): Add a new boolean
690 property ::visible-overflown.
691 * gtk/gtkaction.c (gtk_action_create_menu_proxy): Don't create
692 a menu proxy if visible_overflown is FALSE.
694 Tue Aug 3 20:16:26 2004 Matthias Clasen <maclas@gmx.de>
696 * gtk/gtkactiongroup.[hc]: Make the the GtkAction{Toggle,Radio,}Entry*
697 arguments to the gtk_action_group_add_..._actions() functions const,
698 since the most common use case is to use a static array. (142334,
699 Mariano Suarez-Alvarez)
701 Tue Aug 3 20:03:33 2004 Matthias Clasen <maclas@gmx.de>
703 * gtk/gtkuimanager.c (get_node): Make gtk_ui_manager_add_ui()
704 accept paths with a leading "/ui". (#149077, David Malcolm)
706 Tue Aug 3 19:59:29 2004 Matthias Clasen <maclas@gmx.de>
708 * gtk/gtkiconview.c: Fix some warnings.
710 Tue Aug 3 18:38:40 2004 Matthias Clasen <maclas@gmx.de>
712 * gtk/gtktreemodelfilter.c: Correct the return type
713 of gtk_tree_model_filter_get_flags(). (#149195, Morten Welinder)
715 Tue Aug 3 18:16:55 2004 Matthias Clasen <maclas@gmx.de>
717 Fix #149191, reported by Morten Welinder:
719 * gtk/gtkmain.c: Include gtkclipboard.h,
720 * gtk/gtkwidget.h: Declare _gtk_widget_grab_notify, not
721 _gtk_widget_emit_grab_notify.
723 Tue Aug 3 14:50:14 2004 Matthias Clasen <maclas@gmx.de>
725 * gtk/gtkicontheme.c (add_size): Add missing parens.
726 (#149190, Morten Welinder)
728 Tue Aug 3 14:29:49 2004 Matthias Clasen <maclas@gmx.de>
730 * gtk/gtkcombobox.c (gtk_combo_box_menu_fill): Remove
731 accidentally committed debug code.
733 Tue Aug 3 01:19:12 2004 Matthias Clasen <maclas@gmx.de>
735 * gtk/gtkcombobox.c (gtk_combo_box_relayout_item): Optimize
736 for the case that row_column and col_column are unset.
737 (#148868, Lorenzo Gil Sánchez)
739 Mon Aug 2 21:52:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
741 * gdk/x11/gdkwindow-x11.c (ensure_sync_counter): New
742 function. Make sure the sync counter is recreated when a window is
743 reparented to become a toplevel. (#148358)
745 2004-08-02 Matthias Clasen <mclasen@redhat.com>
747 * tests/testcombo.c: Some trees in combo boxes.
749 * gtk/gtkcombobox.c: Rework the combo box to handle
750 tree models. (#139582, Matt Walton)
754 * gtk/gtktreeprivate.h: Add a new boolean property
755 ::hover-expand and make the treeview expand/collapse rows
756 on mouseover if it is set.
758 * gtk/gtkiconview.h: Remove some erroneous declarations.
760 * gtk/gtkcellview.c (gtk_cell_view_set_cell_data): Don't
761 crash if the displayed row is gone.
763 2004-08-02 Morten Welinder <terra@gnome.org>
765 * gtk/gtkentry.c (gtk_entry_motion_notify): C99ism.
767 Mon Aug 2 01:30:03 2004 Matthias Clasen <maclas@gmx.de>
769 * gtk/gtktextview.[hc]:
770 * gtk/gtkentry.[hc]: Add a new binding signal ::backspace,
771 bind it to the backspace key, and make it pay attention
772 to the Pango backspace_deletes_character
773 attribute. (#119891, Noah Levitt, patch by Theppitak
776 Mon Aug 2 01:02:57 2004 Matthias Clasen <maclas@gmx.de>
778 * gdk/x11/gdkevents-x11.c (gdk_check_wm_state_changed):
779 (gdk_check_wm_desktop_changed): Add missing error
780 traps. (#149011, Thomas Leonard)
782 Mon Aug 2 00:21:26 2004 Matthias Clasen <maclas@gmx.de>
784 * gtk/gtktextview.c (blink_cb): Add the same warning
785 that the blink_cb() in GtkEntry already has. (#148733)
787 Mon Aug 2 00:12:16 2004 Matthias Clasen <maclas@gmx.de>
789 * gtk/gtkentry.c (gtk_entry_class_init):
790 (gtk_entry_get_alignment):
791 (gtk_entry_set_alignment): Document the xalign property
792 and its getter and setter as 2.4 additions. (#148978,
795 Mon Aug 2 00:11:31 2004 Matthias Clasen <maclas@gmx.de>
797 * gtk/gtkuimanager.c (gtk_ui_manager_class_init):
798 * gtk/gtkactiongroup.c (gtk_action_group_class_init): Use
799 canonical signal names in doc comments, since gtk-doc won't
800 pick up signal docs with underscores.
802 2004-08-01 Matthias Clasen <mclasen@redhat.com>
804 * configure.in: Post-release version bump
806 * === Released 2.5.1 ===
808 Thu Jul 29 16:36:42 2004 Jonathan Blandford <jrb@redhat.com>
810 * gtk/gtktreeprivate.h: New arguments
813 (gtk_tree_view_class_init): Add key_release callback
814 (gtk_tree_view_init): Initialize timeout handler
815 (gtk_tree_view_unrealize): clear timeout if needed
816 (gtk_tree_view_key_press): Typeahead support
817 (gtk_tree_view_key_release): Not used yet -- will be needed for
819 (gtk_tree_view_search_entry_flush_timeout): Remove typeahead entry
821 (gtk_tree_view_ensure_interactive_directory):
822 (gtk_tree_view_real_start_interactive_search):
823 (gtk_tree_view_search_init):
824 (gtk_tree_view_start_interactive_search): Typeahead support added.
825 (gtk_tree_view_search_dialog_hide): Clear timeout and text when we
828 Sat Jul 31 23:17:44 2004 Matthias Clasen <maclas@gmx.de>
832 Sat Jul 31 01:13:01 2004 Matthias Clasen <maclas@gmx.de>
836 * gtk/gtkaction.c: Use the canonical form of signal names
837 after "notify::". Otherwise, no notification arrives.
838 GObject should have a warning for that, really. (#148879,
841 Sat Jul 31 00:42:08 2004 Matthias Clasen <maclas@gmx.de>
843 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below):
844 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_above): Don't
845 set both states at once. (#148789, Matthew Garrett)
847 2004-07-30 Matthias Clasen <mclasen@redhat.com>
849 * gtk/gtkcombobox.c: Don't forget to destroy the row separator
850 function user data when the combo box is destroyed.
852 2004-07-30 Matthias Clasen <mclasen@redhat.com>
855 * gtk/gtkcombobox.c: Change the api for separators to use a
856 separator function instead of a boolean column.
858 * tests/testcombo.c: Update to match the api change.
860 Fri Jul 30 02:21:41 2004 Matthias Clasen <maclas@gmx.de>
862 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
863 Fix the positioning of the popup.
865 Fri Jul 30 00:56:31 2004 Matthias Clasen <maclas@gmx.de>
867 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_active_changed):
868 Implement this in terms of gtk_combo_box_get_active_iter(),
869 instead of gtk_combo_box_get_active().
871 2004-07-29 Federico Mena Quintero <federico@ximian.com>
873 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
874 a field for an "add to shortcuts" menu item.
875 (popup_menu_detach_cb): Clear out the field.
876 (file_list_build_popup_menu): Only build the menu here.
877 (file_list_update_popup_menu): Build the menu, then update the
878 sensitivity of its items.
879 (file_list_popup_menu): Use file_list_update_popup_menu().
880 (bookmarks_check_add_sensitivity): Also set the sensitivity of the
881 popup menu item. Correctly handle the case for a *single* file.
883 (bookmarks_add_selected_folder): New helper function; code moved
884 over from add_bookmark_button_clicked_cb().
885 (add_bookmark_button_clicked_cb): Use the function above.
886 (selection_check): Rather than returning a boolean value for
887 emptiness, actually return the number of selected rows. Also,
889 (get_selected_path): New helper function.
891 2004-07-29 Anders Carlsson <andersca@gnome.org>
893 * demos/gtk-demo/Makefile.am:
894 * demos/gtk-demo/clipboard.c: (copy_button_clicked),
895 (paste_received), (paste_button_clicked), (do_clipboard):
898 2004-07-28 Federico Mena Quintero <federico@ximian.com>
900 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
901 Store signal IDs in gulongs, not guints!
902 (gtk_file_chooser_default_hierarchy_changed): We now monitor the
903 focus widget on our toplevel to know which widget was last focused
904 at the time our "should_respond" method gets called.
905 (shortcuts_activate_selected): New helper function.
906 (shortcuts_get_selected): New helper function.
907 (remove_selected_bookmarks): Use shortcuts_get_selected().
908 (bookmarks_check_remove_sensitivity): Likewise.
909 (shortcuts_reorder): Likewise.
910 (shortcuts_activate_iter): Renamed from shortcuts_activate_item().
911 Activate by iter, not by item number.
912 (save_folder_combo_changed_cb): Use shortcuts_activate_iter().
913 (shortcuts_row_activated_cb): Likewise.
914 (gtk_file_chooser_default_should_respond): If the last focused
915 widget on the toplevel was the shortcuts list, activate the
918 2004-07-28 Matthias Clasen <mclasen@redhat.com>
920 * gdk/linux-fb/gdkprivate-fb.h: Make the fb backend compile against
921 current freetype. (#148558, Nicolas Deves)
923 * gtk/gtktreeview.c: Replace the EXPANDER_MAX macro by
924 ROW_HEIGHT. (#145528)
926 * gtk/gtkuimanager.c: Warning fixes.
928 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_background): Fix
929 prototype mismatch. (#148589, Nicolas Deves)
931 2004-07-28 Anders Carlsson <andersca@gnome.org>
933 * gdk/x11/gdkdrawable-x11.c (gdk_draw_rectangle_alpha_libgtk_only):
934 Cast to 32-bit integers when premultiplying, suggested by Keith Packard.
936 2004-07-27 Anders Carlsson <andersca@gnome.org>
938 * demos/gtk-demo/iconview.c: (do_iconview):
939 Change selection mode to multiple.
942 * gdk/linux-fb/gdkdrawable-fb2.c:
943 (gdk_draw_rectangle_alpha_libgtk_only):
944 * gdk/win32/gdkdrawable-win32.c:
945 (gdk_draw_rectangle_alpha_libgtk_only):
946 * gdk/x11/gdkdrawable-x11.c: (gdk_x11_draw_image),
947 (get_impl_drawable), (gdk_x11_draw_pixbuf),
948 (gdk_draw_rectangle_alpha_libgtk_only):
949 Add gdk_draw_rectangle_alpha_libgtk_only which uses
950 XRenderFillRectangle on X11. It's stubbed out on the
951 Win32 and fb backends.
954 (gtk_icon_view_paint_rubberband):
955 Use gdk_draw_rectangle_alpha_libgtk_only here.
957 2004-07-27 Anders Carlsson <andersca@gnome.org>
959 * gtk/gtkaboutdialog.c: (gtk_about_dialog_init),
960 (text_view_style_set), (add_credits_page),
961 (display_credits_dialog), (display_license_dialog):
962 Remove dialog separators, fix text view background setting,
963 use Close buttons instead of OK buttons.
965 2004-07-27 Matthias Clasen <mclasen@redhat.com>
967 * gtk/gtktreeview.c (gtk_tree_view_ensure_interactive_directory):
968 Add a frame around the C-f popup to stop it from merging visually
969 in whatever is underneath.
972 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible): New
973 function necessary to make GtkComboBox accessible. (#132847,
976 Tue Jul 27 02:34:06 2004 Matthias Clasen <maclas@gmx.de>
978 * gtk/gtkwidget.c (gtk_widget_dispose): Hide parentless
979 windows when disposing them. (#133231, Michael Natterer)
981 2004-07-26 Matthias Clasen <mclasen@redhat.com>
983 * gtk/gtklabel.c (gtk_label_class_init): Expand the documentation
984 for GtkLabel::ellipsize.
986 Mon Jul 26 00:38:27 2004 Matthias Clasen <maclas@gmx.de>
988 Make the GtkComboBox in list mode scroll if the list is too
989 large to fit in the popup. (#135543)
991 * gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Add a
992 o scrolled window to the popup in list mode.
993 (gtk_combo_box_list_position): Calculate the height of the
994 popup so that it fits on the screen, set the scrollbar policy
995 of the scrolled window appropriately.
996 (gtk_combo_box_popup): Use the height calculated by
997 gtk_combo_box_list_position().
998 (gtk_combo_box_remeasure): Don't add unnecessary padding.
999 (gtk_combo_box_size_request): But add the focus with here.
1000 (gtk_combo_box_list_setup): Connect to enter notify on the
1001 popup window to activate auto scrolling.
1002 (gtk_combo_box_list_enter_notify): Activate auto scrolling.
1003 (gtk_combo_box_list_button_pressed): Setup a timeout for
1005 (gtk_combo_box_list_scroll_timeout): Timeout function for
1007 (gtk_combo_box_list_auto_scroll): Scroll the list when the
1008 pointer leaves the window.
1010 Sun Jul 25 19:51:17 2004 Matthias Clasen <maclas@gmx.de>
1012 * gtk/gtknotebook.c (gtk_notebook_scroll): Ignore scroll
1013 events from the content of the page. (#148409, Gabriel
1016 Sat Jul 24 21:38:12 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1018 * gtk/gtktoolbar.c (internal_insert_element): Warn if you try to
1019 add a tool item to a toolbar using the deprecated API.
1021 Fri Jul 23 13:04:10 2004 Matthias Clasen <maclas@gmx.de>
1023 * gtk/gtkdnd.c (gtk_drag_dest_set): Revert the change to
1024 initialize target_list to an empty list instead of NULL,
1025 since it broke tree dnd. (#148215, Ernst Persson)
1027 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
1028 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): Instead
1029 handle target list being NULL here.
1031 2004-07-23 Dafydd Harries <daf@muse.19inch.net>
1033 * gtk/gtkradioaction.c:
1034 * gtk/gtkradiobutton.c:
1037 Improve various translatable messages. (#137616)
1039 Fri Jul 23 11:11:10 2004 Matthias Clasen <maclas@gmx.de>
1041 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1042 Align the entry in the same way as the cell. (#136749)
1044 Fri Jul 23 11:01:00 2004 Matthias Clasen <maclas@gmx.de>
1046 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1047 Don't iterate too far up. (#147965, Olivier Sessink)
1049 Fri Jul 23 10:28:43 2004 Matthias Clasen <maclas@gmx.de>
1051 * gtk/gtktreeview.c (gtk_tree_view_finalize):
1052 * gtk/gtkradioaction.c (gtk_radio_action_finalize):
1053 * gtk/gtkfontsel.c (gtk_font_selection_finalize):
1054 * gtk/gtkcellview.c (gtk_cell_view_finalize):
1055 * gtk/gtkcalendar.c (gtk_calendar_finalize):
1056 * gtk/gtkactiongroup.c (gtk_action_group_finalize): Remove
1057 unnecessary checks. (#148175, Morten Welinder)
1059 Thu Jul 22 01:42:16 2004 Matthias Clasen <maclas@gmx.de>
1061 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1062 Add a new :ellipsize property which controls ellipsization of the
1063 rendered text. (#144835, Vincent Untz, patch by Jonathan Blandford
1064 and Anders Carlsson)
1066 * gtk/gtkfilechooserdefault.c (create_file_list): Use ellipsization
1067 for the name column.
1069 Thu Jul 22 01:21:28 2004 Matthias Clasen <maclas@gmx.de>
1071 * gtk/gtkfontsel.c (gtk_font_selection_init): Add additional
1072 accessability relations. (#141804, Padraig O'Briain)
1074 Thu Jul 22 01:16:23 2004 Matthias Clasen <maclas@gmx.de>
1076 * gtk/gtkcombobox.c: Avoid some warnings.
1078 Thu Jul 22 01:05:16 2004 Matthias Clasen <maclas@gmx.de>
1080 * configure.in: Require Pango 1.5.1 (for ellipsisation).
1083 * gtk/gtklabel.c (gtk_label_class_init): Add a new :ellipsize
1084 property which controls ellipsization of the label. (#125250,
1085 Tim Van Wassenhove, patch by James M. Cape)
1087 * tests/testellipsise.c: Simple test for ellipsizsation.
1089 Wed Jul 21 22:46:27 2004 Matthias Clasen <maclas@gmx.de>
1091 * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
1092 list store. (#148134, Crispin Flowerday)
1094 Wed Jul 21 22:35:47 2004 Matthias Clasen <maclas@gmx.de>
1096 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
1097 menu. (#148110, Tommi Komulainen)
1099 Wed Jul 21 22:24:10 2004 Matthias Clasen <maclas@gmx.de>
1101 * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak
1102 tree model and tree row reference. (#148125, Crispin Flowerday)
1104 Wed Jul 21 22:17:06 2004 Matthias Clasen <maclas@gmx.de>
1106 * tests/testcombo.c (main): Don't leak models. (#148128,
1109 Wed Jul 21 21:26:08 2004 Matthias Clasen <maclas@gmx.de>
1111 * gtk/gtkviewport.c (viewport_set_adjustment): Don't leak
1112 the adjustments. (#148089, Tommi Komulainen)
1114 Wed Jul 21 21:20:21 2004 Matthias Clasen <maclas@gmx.de>
1116 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't leak
1117 the adjustments. (#148073, Tommi Komulainen)
1119 Wed Jul 21 21:04:50 2004 Matthias Clasen <maclas@gmx.de>
1121 * gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the
1122 arrow. (#148064, Tommi Komulainen)
1124 2004-07-21 Matthias Clasen <mclasen@redhat.com>
1126 * gtk/gtkcalendar.c: Use the new text target functionality
1127 in GtkTargetList instead of hardcoding a subset of text targets.
1129 Tue Jul 20 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
1131 * gdk/x11/gdkevents-x11.c: Hook up gtk-menu-bar-accel to
1132 an XSetting, Gtk/MenuBarAccel. (#120859, Scott James Remnant)
1134 Tue Jul 20 22:26:29 2004 Matthias Clasen <maclas@gmx.de>
1136 * gtk/gtkfilechooserutils.h:
1137 * gtk/gtktoolbutton.c:
1139 * gtk/gtkicontheme.c:
1140 * gtk/gtkcalendar.c:
1141 * demos/gtk-demo/ui_manager.c:
1142 * demos/gtk-demo/appwindow.c: Remove trailing commas
1143 from enumerations. (#148035)
1145 2004-07-20 Federico Mena Quintero <federico@ximian.com>
1147 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Fix the
1148 documentation comment for the editing-started signal.
1150 * gtk/gtkmarshalers.list: Added VOID:OBJECT,STRING for
1151 GtkCellRenderer::editing-started.
1153 2004-07-20 Matthias Clasen <mclasen@redhat.com>
1155 * tests/testactions.c (main):
1156 * tests/testmerge.c (main): Add some refcount debugging.
1158 * gtk/gtkuimanager.c (update_node, free_node): Ref an sink
1159 all proxies, so that we can properly clean up floating proxies
1160 which the app didn't adopt. (#147926, Tommi Komulainen)
1162 2004-07-20 Matthias Clasen <mclasen@redhat.com>
1164 Allow custom initialization of cell editables. (#147221)
1166 * gtk/gtkcellrenderer.h (struct _GtkCellRendererClass):
1167 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Add a
1168 ::editing-started signal as a hook for setting up the
1170 (gtk_cell_renderer_start_editing): ...and emit it here.
1172 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
1174 * gtk/gtktreeview.c (gtk_tree_view_button_press): Set drag_pos
1175 before grabbing the focus, since we may reenter into
1176 gtk_tree_view_motion_resize_column() which requires drag_pos
1177 to be set. (#147913, Guilherme Salgado, patch by John Finlay)
1179 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
1181 * gtk/gtktreeview.c (gtk_tree_view_enter_notify): Don't
1182 use uninitialized node pointer. (#147911, Peter Zelezny)
1184 Tue Jul 20 04:34:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1186 * configure.in: Bump version number
1188 Sun Jul 18 17:21:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1190 * === Released 2.5.0 ===
1194 * tests/testcombo.c: Fix compilation
1196 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1198 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_popup_completion):
1201 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1203 Make GtkCellView public, since people seem to have uses for it,
1204 it is clean API and we were just conservative in not making it
1205 public initially. At the same time, get rid of GtkCellViewMenuItem,
1206 which doesn't have any function which can't be served by a
1207 GtkMenuItem with a GtkCellView child. (#136637, Padraig O'Briain)
1209 * gtk/gtk.h: Include gtkcellview.h
1211 * gtk/Makefile.am (gtk_public_h_sources):
1213 * gtk/Makefile.am (gtk_private_h_sources):
1214 (gtk_c_sources): Remove gtkcellviewmenuitem.[hc]
1215 * gtk/gtkcombobox.c: Replace all uses of GtkCellViewMenuItem by
1216 GtkMenuItem with a GtkCellView child.
1218 * gtk/gtkcellviewmenuitem.[hc]: Removed.
1220 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1222 Support inline autocompletion in entries (#135953)
1224 * gtk/gtkentryprivate.h:
1225 * gtk/gtkentrycompletion.h:
1226 * gtk/gtkentrycompletion.c (gtk_entry_completion_class_init):
1227 Add a new signal ::insert-prefix which can be used to override
1228 the default inline-completion behaviour. Add two new boolean
1229 properties, :popup_completion and :inline_completion which
1230 determine how the possible completions should be presented.
1231 (gtk_entry_completion_insert_prefix): New function to request
1234 * gtk/gtkentry.c: Add the necessary glue for inline completion.
1236 Sun Jul 18 15:28:24 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1238 * gtk/gtkdnd.c (gtk_drag_source_set, gtk_drag_dest_set): Create an
1239 empty target list if targets is NULL.
1241 * configure.in: Add check for X11/extensions/sync.h. (#147416,
1244 Sun Jul 18 01:24:31 2004 Matthias Clasen <maclas@gmx.de>
1246 * NEWS: Updates for 2.5.0
1248 Sat Jul 17 23:11:04 2004 Matthias Clasen <maclas@gmx.de>
1250 * gtk/gtkiconview.h:
1251 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1252 * gtk/gtkiconview.c (gtk_icon_view_set_orientation):
1253 * gtk/gtkiconview.c (gtk_icon_view_get_orientation):
1254 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
1255 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row):
1256 Add a new :orientation property to determine whether text
1257 is positioned below or beside icons. (#147463)
1259 Sat Jul 17 23:03:30 2004 Matthias Clasen <maclas@gmx.de>
1261 * gtk/gtkiconview.c (gtk_icon_view_paint_item):
1262 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
1263 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row): Draw
1264 focus indicator outside the selection, respect focus
1265 line width. (#147460)
1267 Sat Jul 17 01:17:33 2004 Matthias Clasen <maclas@gmx.de>
1269 * gdk/x11/gdkdnd-x11.c (xdnd_check_dest): Fix a warning
1272 Sat Jul 17 00:48:27 2004 Matthias Clasen <maclas@gmx.de>
1274 Support text/plain selection target (#55117, Owen Taylor)
1276 * gtk/gtkselection.h:
1278 * gtk/gtkselection.c (gtk_target_list_add_text_targets):
1279 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
1280 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): New
1281 functions to facilitate handling of text targets.
1284 * gtk/gtktextview.c: Use the new text target handling
1285 functions instead of hardwiring the list of supported
1286 text targets everywhere.
1288 * gtk/gtkselection.c (gtk_selection_data_get_text):
1289 (gtk_selection_data_set_text):
1290 Support the targets text/plain, text/plain?charset=utf-8
1291 and text/plain?charset=<LOCALE-CHARSET> as outlined in
1293 For text/plain send only ASCII, but accept 8-bit text
1294 and treat it as ISO-8859-1 as specified by the Xdnd spec.
1295 Always send CRLF terminators. Accept either and convert
1296 into the native terminator for the platform.
1298 Fri Jul 16 23:20:34 2004 Matthias Clasen <maclas@gmx.de>
1300 Support themed window icons. (#92346, Calum Benson)
1302 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): New
1303 function to obtain information about the sizes in which an
1307 * gtk/gtkwindow.c (gtk_window_class_init):
1308 (gtk_window_set_icon_name):
1309 (gtk_window_get_icon_name): Add an "icon_name" property
1310 (gtk_window_set_default_icon_name): ...and a default icon name.
1311 (icon_list_from_theme):
1312 (update_themed_icon): New auxiliary functions to create a
1313 list of all available sizes of a themed icon and update the
1314 window icon list from it.
1316 2004-07-16 Matthias Clasen <mclasen@redhat.com>
1318 * gtk/gtkcombobox.c (gtk_combo_box_scroll_event): Make
1319 scrolling work if no item is selected.
1320 (gtk_cell_editable_key_press): Don't eat space.
1322 Add a combo box cell renderer (#139347, Lorenzo Gil Sanchez)
1324 * gtk/gtkcellrenderercombo.[hc]: New Files.
1327 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
1330 * gtk/gtkcombobox.[hc]: Implement GtkCellEditable, add a
1331 :has-frame property for suppressing the frame around
1332 the child and redo the size allocation logic to take
1333 focus width into account.
1335 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_init):
1336 Acknowledge the GtkComboBox:has-frame property and make
1337 the entry fill its allocation vertically.
1339 * gtk/gtkmarshalers.list: Add BOOLEAN:STRING.
1341 * gtk/gtktreeview.c (gtk_tree_view_remove_widget): Queue
1342 a draw here to keep non-widget windows from leaving
1345 2004-07-16 Matthias Clasen <mclasen@redhat.com>
1347 * gtk/gtkcombobox.c (gtk_combo_box_forall): Don't iterate
1348 multiple times over some of the children.
1350 Thu Jul 15 22:19:40 2004 Matthias Clasen <maclas@gmx.de>
1352 Fix #60128, #58307, #144706:
1354 * gtk/gtkstyle.c (gtk_style_real_copy): Handle references
1355 to bg_pixmaps properly.
1356 (gtk_style_real_unrealize): Don't keep dangling references
1358 (gtk_style_attach): Split the loop into two loops, first
1359 looking for a matching style, then for an empty one.
1360 (gtk_style_finalize):
1361 (gtk_style_duplicate): Add comments explaining the handling
1364 Thu Jul 15 20:31:28 2004 Matthias Clasen <maclas@gmx.de>
1366 * gtk/gtkspinbutton.c (start_spinning): Install the timeout
1367 before changing the value, so that a ::value_changed handler
1368 has a chance to remove it. (#122427, Elke Meier)
1370 Thu Jul 15 19:20:05 2004 Matthias Clasen <maclas@gmx.de>
1372 * gdk/x11/gdkgtk+/im-x11.c (_gdk_x11_initialize_locale):
1373 * gtk/gtkcalendar.c (gtk_calendar_class_init): Use 'cannot'
1374 instead of 'can not' in messages. (#144226, Morten Welinder)
1376 2004-07-15 Matthias Clasen <mclasen@redhat.com>
1378 * gtk/gtktreeview.c (gtk_tree_view_class_init):
1379 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1380 Correct the declared default values of several properties
1381 to be in sync with the actual initial values.
1383 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_class_init):
1384 Make spacing a property, correct the declared default values
1385 of several properties to be in sync with the actual initial
1386 values. (#147654, Matthias Clasen)
1388 * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Don't reparent
1389 back to menu->toplevel if it is already gone because we're
1390 shutting down. (#147656, John Cupitt)
1392 2004-07-14 Federico Mena Quintero <federico@ximian.com>
1396 * gtk/gtktreeview.c (gtk_tree_view_bin_expose): Draw a focus
1397 indicator along the edge of the bin_window when the tree is empty.
1398 (grab_focus_and_unset_draw_keyfocus): New helper function.
1399 (gtk_tree_view_button_press): Remove a bit of superfluous code.
1400 Use the helper function to save on duplicated code.
1401 (gtk_tree_view_button_press): Grab the focus if the tree is empty.
1402 (gtk_tree_view_focus): Allow focusing into an empty tree.
1404 2004-07-14 Matthias Clasen <mclasen@redhat.com>
1406 * gtk/gtkaboutdialog.c (add_credits_page): Don't use
1407 gcc extensions for the ternary ?: operator. (#147590,
1410 2004-07-14 Federico Mena Quintero <federico@ximian.com>
1412 Fix #144405, patch by Padraig O'Briain <padraig.obriain@sun.com>:
1414 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): Set the
1415 accessible object name for the tree view.
1416 (create_file_list): Likewise.
1418 Tue Jul 13 21:53:08 2004 Matthias Clasen <maclas@gmx.de>
1420 * gtk/gtkicontheme.c (free_unthemed_icon): Don't leak
1421 no_svg_filename. (#147399, Kjartan Maraas)
1423 2004-07-13 Matthias Clasen <mclasen@redhat.com>
1425 * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_get_neighbor_sizes):
1426 Make this work in RTL context.
1428 2004-07-13 Federico Mena Quintero <federico@ximian.com>
1430 * gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Set a
1431 busy cursor while mounting the volume. Also, ref the chooser
1432 while mounting, as we may re-enter. Fixes #139376.
1434 2004-07-13 Matthias Clasen <mclasen@redhat.com>
1436 * gtk/gtktreeview.c (gtk_tree_view_adjustment_changed):
1437 Prepare to handle composite implementations of
1438 GtkCellEditable, but recursively poking at
1439 allocation->y (hack stolen from GtkCList).
1440 (check_expander_max): Tweak the warning.
1442 * gtk/gtkmain.h: Add gtk_parse_args(), its a public
1443 function. (#147476, Owen Taylor)
1445 * gtk/gtkcombobox.c (gtk_combo_box_popdown): Don't
1446 crash if unrealized.
1448 Tue Jul 13 01:50:06 2004 Matthias Clasen <maclas@gmx.de>
1450 * gtk/gtkaboutdialog.c (display_credits_dialog): Don't
1451 display untranslated translator credits.
1453 Tue Jul 13 01:15:05 2004 Matthias Clasen <maclas@gmx.de>
1455 * gtk/gtkiconview.c: Some documentation updates.
1457 Tue Jul 13 00:40:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1459 * gdk/gdkwindow.c (gdk_window_process_updates_internal): Do an
1460 empty begin_paint_region()/end_paint() for windows without
1463 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_unset_bg,
1464 _gdk_x11_window_tmp_reset_bg): Remove checks for EXPOSURE_MASK.
1466 2004-07-12 Matthias Clasen <mclasen@redhat.com>
1468 * demos/gtk-demo/appwindow.c: Use a GtkAboutDialog.
1470 * gtk/gtkaboutdialog.h:
1471 * gtk/gtkaboutdialog.c: New widget: GtkAboutDialog.
1473 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
1474 * gtk/gtk.h: Add GtkAboutDialog. (#109435, Paolo Borelli,
1475 patch by Matthias Clasen)
1477 * gtk/gtkrc.c (_gtk_rc_init): Apply the gtk-default-menu-item-style
1478 to cell view menu items as well. (#147405, John Cupitt)
1480 * gtk/gtkentrycompletion.c: Warning fixes. (#147420,
1483 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Pop down
1484 first. (#147399, John Cupitt)
1486 Mon Jul 12 01:56:26 2004 Matthias Clasen <maclas@gmx.de>
1488 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
1489 Include the update_counter check in the HAVE_XSYNC condition,
1490 since update_counter isn't present in the !HAVE_XSYNC case.
1492 Mon Jul 12 00:52:04 2004 Matthias Clasen <maclas@gmx.de>
1494 * gtk/stock-icons/Makefile.am:
1495 * gtk/stock-icons/stock_about_{16,24}.png:
1496 * gtk/stock-icons/stock_connect_{16,24}.png:
1497 * gtk/stock-icons/stock_disconnect_{16,24}.png:
1498 * gtk/stock-icons/stock_edit_{16,24}.png:
1499 * gtk/stock-icons/stock_media_forward_{16,24}.png:
1500 * gtk/stock-icons/stock_media_next_{16,24}.png:
1501 * gtk/stock-icons/stock_media_pause_{16,24}.png:
1502 * gtk/stock-icons/stock_media_play_{16,24}.png:
1503 * gtk/stock-icons/stock_media_previous_{16,24}.png:
1504 * gtk/stock-icons/stock_media_record_{16,24}.png:
1505 * gtk/stock-icons/stock_media_rewind_{16,24}.png:
1506 * gtk/stock-icons/stock_media_stop_{16,24}.png:
1507 * gtk/gtkstock.h (GTK_STOCK_ABOUT):
1508 * gtk/gtkstock.h (GTK_STOCK_CONNECT):
1509 * gtk/gtkstock.h (GTK_STOCK_DISCONNECT):
1510 * gtk/gtkstock.h (GTK_STOCK_EDIT):
1511 * gtk/gtkstock.h (GTK_STOCK_MEDIA_FORWARD):
1512 * gtk/gtkstock.h (GTK_STOCK_MEDIA_NEXT):
1513 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PAUSE):
1514 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PLAY):
1515 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PREVIOUS):
1516 * gtk/gtkstock.h (GTK_STOCK_MEDIA_RECORD):
1517 * gtk/gtkstock.h (GTK_STOCK_MEDIA_REWIND):
1518 * gtk/gtkstock.h (GTK_STOCK_MEDIA_STOP):
1519 * gtk/gtkiconfactory.c (get_default_icons):
1520 * gtk/gtkstock.c (builtin_items): Add a number of new stock
1521 items. (#102530, #68015, #109811, Jordi Mallach, Benjamin Otte,
1524 Sun Jul 11 15:24:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1526 Bug 143330, support update counter spec.
1528 * configure.in: Add check for the Sync extension
1530 * gdk/gdkwindow.h: gdk_window_enable_synchronized_configure() and
1531 gdk_window_configure_finished()
1533 * gtk/gtkwindow.c (gtk_window_move_resize): Call gdk_window_finish_configure().
1534 * gtk/gtkwindow.c (gtk_window_realize): Automatically enable
1535 synchronized configures.
1537 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Store current
1538 and pending counter values.
1540 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): New function.
1541 * gdk/x11/gdkwindow-x11.c
1542 (gdk_window_enable_synchronized_configure): New function.
1543 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
1544 Delete update counter.
1545 * gdk/x11/gdkwindow-x11.c (set_wm_protocols): Advertise
1546 _NET_WM_SYNC_REQUEST when Sync is available
1548 * gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Handle
1549 _NET_WM_SYNC_REQUEST messages
1550 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Save counter
1551 value for use by gdk_window_configure_finished() when receiving
1554 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add use_sync flag
1555 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Check if the XSync
1556 extension is available
1557 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_SYNC_REQUEST and
1558 _NET_WM_SYNC_REQUEST_COUNTER to list of supported atoms.
1560 * gdk/linux-fb/gdkwindow-fb.c, gdk/win32/gdkwindow-win32.c: Add
1561 stubs for enable_synchronized_configure() and configure_finished()
1563 Sat Jul 10 23:35:13 2004 Matthias Clasen <maclas@gmx.de>
1565 * gtk/gtkentry.c (paste_received): Make middle-button pasting
1566 work as expected inside the entry. (#116789, Scott Bronson)
1568 Sat Jul 10 22:13:53 2004 Matthias Clasen <maclas@gmx.de>
1570 * gtk/gtktextbuffer.c (gtk_text_buffer_select_range): Update
1571 clipboards. (#142805, Mikael Hallendal)
1573 Sun Jul 11 01:38:48 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1575 * gtk/gtkpaned.c (gtk_paned_expose): Remove clip-region computing
1576 code. Just use &paned->handle_pos.
1578 Sun Jul 11 01:12:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1582 * gtk/gtknotebook.c (gtk_notebook_size_allocate): Remove an
1583 unnecessary redraw..
1585 * gtk/gtknotebook.c (gtk_notebook_page_allocate): Remove some
1588 Sat Jul 10 01:33:25 2004 Matthias Clasen <maclas@gmx.de>
1590 * docs/RELEASE-HOWTO: Updates.
1592 Sat Jul 10 01:55:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1594 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{re|un}set_bg):
1595 Insert checks for root window. The root window is never mapped.
1597 Sat Jul 10 01:06:05 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1599 * gdk/x11/gdkwindow-x11.c (post_unmap): Fix a warning
1600 * gdk/x11/gdkwindow-x11.c (show_window_internal): Actually unset
1603 Sat Jul 10 00:37:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1607 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{un|re}set_bg):
1608 New functions that can do a recursive unset/reset bg.
1610 * gdk/x11/gdkgeometry-x11.c: Remove
1611 gdk_window_tmp_{un|re}set_bg().
1613 * gdk/x11/gdkwindow-x11.c (pre_unmap, post_unmap): New functions
1614 called before and after unmapping a window. They unset the
1615 background of all other windows to prevent flicker from the X
1616 server repainting the background. post_unmap() also invalidates
1617 the parent of the unmapped window to draw it without roundtrips.
1619 * gdk/x11/gdkwindow-x11.c (show_window_internal): Unset
1620 background of newly mapped windows and all desendants to prevent
1623 Fri Jul 9 15:33:55 2004 Manish Singh <yosh@gimp.org>
1625 * gdk/gdkevents.c: have a dummy case GDK_OWNER_CHANGE in switch
1626 statements to avoid gcc warnings about not all enum values handled.
1628 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): ignore should live in
1631 Fri Jul 9 23:26:09 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1635 * gdk/x11/gdkwindow-x11.h (struct _GdkWindowImplX11): Add an
1636 "override_redirect" bit.
1638 * gdk/x11/gdkwindow-x11.c (gdk_window_new): Set it here.
1640 * gdk/x11/gdkwindow-x11.c (gdk_window_move, gdk_window_resize,
1641 gdk_window_move_resize):
1642 Update the local size/position cache
1643 immediately for override redirect windows.
1645 * gdk/x11/gdkwindow-x11.c (show_window_internal): Invalidate
1646 newly mapped child and override redirect windows.
1648 2004-07-09 Federico Mena Quintero <federico@ximian.com>
1652 * gtk/gtkfilesystemunix.c (get_fallback_icon): New helper
1653 function, fetches a stock icon as a fallback.
1654 (gtk_file_system_unix_volume_render_icon): Fall back to a stock
1656 (gtk_file_system_unix_render_icon): Fall back to a stock icon.
1657 Use helper functions rather than being a mega-function.
1658 (get_icon_name_for_directory): Renamed from
1659 get_icon_for_directory().
1660 (get_icon_type_from_path): New helper function; code pulled out
1661 from gtk_file_system_unix_render_icon().
1662 (get_special_icon): Likewise.
1663 (get_icon_for_mime_type): Likewise.
1665 2004-07-09 Federico Mena Quintero <federico@ximian.com>
1667 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Fix typo; tmp_event ->
1670 2004-07-09 Matthias Clasen <mclasen@redhat.com>
1672 * gtk/gtktooltips.c (gtk_tooltips_paint_window): Use the
1673 requisition of the widget instead of relying on the style
1674 drawing function to supply the size of the drawable. (#146531)
1676 2004-07-09 Matthias Clasen <mclasen@redhat.com>
1678 Make GtkEntry work harder to protect passwords: (#143955,
1681 * gtk/gtkentry.c (gtk_entry_destroy): Add a destroy handler
1682 to clear the password even if the widget is leaked.
1684 * gtk/gtkentry.c (gtk_entry_real_delete_text):
1685 * gtk/gtkentry.c (gtk_entry_finalize): Zero out the memory
1688 * gtk/gtkentry.c (gtk_entry_real_insert_text): Zero and free
1689 the old memory instead of just reallocating it.
1691 * gtk/gtkentry.c (gtk_entry_create_layout): Don't leak text
1692 direction information for passwords.
1694 2004-07-09 Matthias Clasen <mclasen@redhat.com>
1696 * gtk/gtkstyle.c: Fix some cases where style functions were
1697 not handling widget == NULL properly. (#146282)
1699 Thu Jul 8 22:38:58 2004 Matthias Clasen <maclas@gmx.de>
1701 * gtk/gtktreeview.c: Improve the EXPANDER_MAX warning.
1703 2004-07-08 Federico Mena Quintero <federico@ximian.com>
1707 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Add a
1708 GError argument. Do check for errors when getting the
1709 GtkFileFolder: get the folder and read the children before
1710 actually creating the model. Removed obsolete code that handled
1711 roots-changed on the file system.
1712 (file_model_node_get_info): Assert that we don't reach the old
1713 case to display file system roots.
1714 (roots_changed_callback): Removed.
1716 * gtk/gtkfilechooserdefault.c (set_list_model): Add a GError
1717 argument, and a boolean return value. Return an error if we
1718 cannot create the file system model. On error, set a NULL model
1720 (gtk_file_chooser_default_set_current_folder): Use the error value
1721 from set_list_model().
1722 (gtk_file_chooser_default_set_property): Set the show_hidden
1723 property only if the browse_files_model exists.
1724 (gtk_file_chooser_default_unselect_path): Only operate if the
1725 browse_files_model exists.
1726 (check_preview_change): Check whether we have the sort_model.
1727 (change_folder_and_display_error): Copy the path we get passed
1728 before using it. There's a comment in there that explains why we
1729 need to copy it; basically, if the passed path belongs to the
1730 model, the model may go away in the middle of this function and
1731 we'll be left with a dangling pointer.
1732 (install_list_model_filter): Assert that the model is not NULL.
1733 (set_current_filter): Check whether the model exists.
1735 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Don't
1736 g_return_if_fail if the model is NULL.
1737 (gtk_tree_selection_get_selected_rows): Likewise.
1738 (gtk_tree_selection_count_selected_rows): Likewise.
1739 (gtk_tree_selection_selected_foreach): Likewise.
1740 (gtk_tree_selection_path_is_selected): Likewise; rather just
1742 (gtk_tree_selection_select_all): Likewise.
1743 (gtk_tree_selection_unselect_all): Likewise.
1744 (gtk_tree_selection_select_range): Do g_return_if_fail() if the
1746 (gtk_tree_selection_unselect_range): Likewise.
1748 * gtk/gtkfilesystemunix.c (fill_in_names): Return immediately if
1749 g_dir_open() fails: there is no need to set the error ourselves,
1750 as g_dir_open() already does it.
1752 2004-07-08 Matthias Clasen <mclasen@redhat.com>
1754 * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Allow
1755 to restore the default search function. (#145365, John Finlay)
1757 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Don't leak
1758 references to the drag context. (#144324, Alex Larsson)
1760 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
1762 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
1763 when a new model is set. (#145566, Dmitry M. Shatrov)
1765 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
1767 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
1768 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
1769 in order to avoid rendering artifacts from misaligned
1770 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
1772 2004-07-07 Matthias Clasen <mclasen@redhat.com>
1774 * gtk/gtktreeview.c:
1775 * gtk/gtktreeview.h: Small documentation fixes.
1777 2004-07-07 Matthias Clasen <mclasen@redhat.com>
1779 Support separators in combo boxes and more generally in tree
1782 * gtk/gtkcombobox.h:
1783 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
1784 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
1785 Add a ::row-separator-column property with getter and setter,
1786 which can indicate a boolean model column to determine which
1787 rows are separators.
1789 * gtk/gtkcombobox.c: Display separator rows as separator menu
1790 items in menu mode, and by using the new treeview separator
1791 functionality in list mode.
1793 * gtk/gtktreeview.h:
1794 * gtk/gtktreeprivate.h:
1795 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
1796 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
1797 Add a callback to determine whether a row is a separator.
1799 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
1800 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1801 * gtk/gtktreeview.c (validate_row): Use the new callback
1802 to determine whether a row is a separator, and draw it
1803 as a separator then. Since separators should take up less
1804 vertical space than regular rows, this requires removing
1805 the redundant MAX(...,expander_size) calls which appear in
1806 many places. Instead, the MAX() is now only done in
1807 validate_row(), and only if the row is not a separator.
1808 To catch possible side effects of this intrusive change,
1809 I have left EXPANDER_MAX() calls in place of the MAX() calls
1810 which will emit a warning if something breaks. They should
1811 be removed before 2.6.
1813 * gtk/gtktreeselection.c (row_is_selectable): Don't let
1814 separator rows be selected.
1816 * tests/testcombo.c (create_blaat): Add a separator column.
1818 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
1820 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
1821 a 64bit alignment issue. (#144302, Sunil)
1823 2004-07-07 Tor Lillqvist <tml@iki.fi>
1825 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
1826 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
1827 * gdk/win32/gdkproperty-win32.c (find_common_locale,
1828 gdk_property_change)
1829 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
1830 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
1833 * gdk/win32/gdkglobals-win32.c
1834 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
1835 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
1836 atom. Initialize it. Declare it. Drop the variable for the
1839 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
1840 function is supposed to return the string in the locale's charset
1841 and encoding. Use g_convert().
1843 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
1844 string in the locale's charset. Use g_convert().
1846 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
1847 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
1848 GLib's UTF-16 functions instead. Windows uses UTF-16.
1850 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
1851 functions mentioned above.
1853 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
1854 also if the string is of type STRING, i.e. ISO-8859-1, and the
1855 current codepage is 1252, and contains no C1 chars. Accept
1858 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
1859 Mark as static. When storing STRING data, convert to
1861 (gdk_selection_owner_set_for_display): Now that STRING is always
1862 ISO-8859-1, use UTF8_STRING when sending the selection request
1865 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
1868 (gdk_text_property_to_text_list_for_display): Make work more like
1869 X11 version. Do obey the encoding parameter.
1871 (gdk_string_to_compound_text_for_display,
1872 gdk_utf8_to_compound_text_for_display): Don't even pretend
1873 supporting COMPOUND_TEXT.
1875 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
1877 (sanitize_utf8): Zero-terminate string.
1879 2004-07-06 Matthias Clasen <mclasen@redhat.com>
1881 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
1882 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
1884 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
1885 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
1886 fallbacks for gtkfilechooser. Currently these are the same images
1887 as the "new" and "open" items...
1889 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
1891 Fix for #136496, Pawel Salek:
1893 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
1894 a node when it changes in fixed_height mode.
1896 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
1899 2004-07-06 Matthias Clasen <mclasen@redhat.com>
1901 * gtk/gtkmenu.c (gtk_menu_position): Make sure
1902 private->monitor_num is a valid monitor number before
1903 using it. (#139187, Michael Natterer)
1905 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
1907 * gtk/gtkfilechooserdefault.c (popup_position_func):
1908 * gtk/gtkentry.c (popup_position_func):
1909 * gtk/gtktextview.c (popup_position_func): Improve positioning
1910 of keyboard-activated menus with Xinerama.
1912 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
1914 * gtk/gtkuimanager.c (do_updates):
1915 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
1916 when called from an idle handler. (#145429, Jan-Marek Glogowski)
1918 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
1920 * gtk/gtkfilechooserutils.c (delegate_notify): Use
1921 the less efficient g_object_interface_find_property () instead
1922 of the param_id range check, since the GParamSpecs we're
1923 dealing with are the overridden onces on the interface, whose
1924 param_id is always zero. (#145312, Alex Roitman, fix proposed
1927 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
1929 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
1930 virtual method of GtkContainer.
1931 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
1932 method slot of the container class.
1934 2004-07-05 Anders Carlsson <andersca@gnome.org>
1936 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
1937 * gtk/gtkiconview.h:
1938 Use gint, not int in gtk_icon_view_set_markup_column,
1941 2004-07-05 Anders Carlsson <andersca@gnome.org>
1943 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
1944 (gtk_icon_view_real_select_cursor_item),
1945 (gtk_icon_view_real_activate_cursor_item):
1946 * gtk/gtkiconview.h:
1947 Add an "activate_cursor_item" action signal
1948 and bind it to the return key.
1950 2004-07-04 Anders Carlsson <andersca@gnome.org>
1952 * demos/gtk-demo/Makefile.am:
1953 * demos/gtk-demo/gnome-fs-directory.png:
1954 * demos/gtk-demo/gnome-fs-regular.png:
1955 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
1956 (sort_func), (create_store), (item_activated), (up_clicked),
1957 (home_clicked), (do_iconview):
1958 Add a simple file browser based on the icon view.
1961 Add gtk/gtkiconview.h
1963 * gtk/gtkiconview.c: (gtk_icon_view_layout),
1964 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
1965 Fix a few bugs discovered while writing the demo.
1967 2004-07-04 Anders Carlsson <andersca@gnome.org>
1971 * gtk/gtkiconview.h:
1972 Add GtkIconView to the build, remove debugging output.
1974 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
1976 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
1977 (gtk_calendar_drag_data_received): Fix off-by-one error.
1978 GDate month is one-based and GtkCalendar month is zero-based.
1979 (#145134, William Jon McCann)
1981 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
1983 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
1984 somebody tries to move a node after itself in a list of
1985 length 1. (#145291, Sampo Nurmentaus)
1987 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
1989 * docs/faq/gtk-faq.sgml:
1990 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
1993 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
1995 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
1996 and current_height to 0 when ending the embedding. (#143675,
1997 Nickolay V. Shmyrev)
1999 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
2001 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
2002 to the right end of the entry text, even if it ends in combining
2003 marks. (#141728, Theppitak Karoonboonyanan)
2005 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
2007 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
2008 row when unsetting the model. (#138560, Christian Persch)
2010 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
2012 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
2015 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
2017 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
2018 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
2020 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
2022 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
2023 to the event mask, set a scroll_event handler.
2024 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
2025 by switching tabs. (#145244, Gabriel de Perthuis)
2027 2004-07-02 Anders Carlsson <andersca@gnome.org>
2029 * gtk/gtktreeview.c (gtk_tree_view_set_model):
2030 Make sure we check for a NULL model first.
2032 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
2034 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
2035 win32 build problem w/o wintab. Fixed #145242
2037 2004-06-30 Anders Carlsson <andersca@gnome.org>
2039 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
2040 g_return_if_fail to make sure that the model is a GtkTreeModel.
2042 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2044 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
2045 current state, not GTK_STATE_NORMAL
2047 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
2049 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2051 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
2053 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
2055 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
2056 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
2059 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
2061 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
2062 recursion by resetting icon_set->cache before freeing
2063 the cache. (#144947, Tim Janik)
2065 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
2067 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
2068 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
2069 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
2072 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
2074 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
2075 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
2076 last change in the docs.
2078 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
2080 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
2081 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
2082 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
2084 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
2086 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
2087 placement policy for GtkComboBoxEntry to be: if it fits below,
2088 place below, if it fits above place above, else place in the
2089 larger space and scroll so that the scroll arrow appear at the
2090 far end. (#144362, David A. Knight)
2092 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
2094 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
2095 use of &parent_iter. (#145007, John Finlay)
2097 2004-06-25 Bastien Nocera <hadess@hadess.net>
2099 reviewed by: Matthias Clasen <maclas@gmx.de>
2101 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
2102 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
2103 the number of keysyms per keycode is odd. Fixes #144808.
2105 2004-06-25 Matthias Clasen <mclasen@redhat.com>
2107 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
2108 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
2110 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
2112 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
2113 which was mentioned below.
2115 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
2117 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
2118 string change. (#139503, Baris Cicek)
2120 2004-06-22 Federico Mena Quintero <federico@ximian.com>
2122 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
2123 or an Open stock button for the C-l dialog depending on the action
2124 in which the file chooser operates. Fixes #141753.
2126 2004-06-22 Federico Mena Quintero <federico@ximian.com>
2128 Fixes the GTK+ part of #142308:
2130 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
2131 Use filename_to_path().
2132 (gtk_file_system_unix_uri_to_path): Likewise.
2133 (filename_to_path): Use remove_trailing_slash().
2135 2004-06-22 Matthias Clasen <mclasen@redhat.com>
2137 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
2138 for the ::move_cursor signal.
2140 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
2141 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
2144 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
2145 this gets defined for all backends, so linux-fb has a
2146 chance of compiling.
2148 * gdk/x11/gdkgc-x11.c:
2149 * gdk/gdkgc.c: Move function docs inline, add hints about
2150 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
2152 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
2153 for children of the root. (#139785, Jean-François Wauthy,
2154 patch by John Finlay)
2156 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
2157 fix. (#144750, Jeff Franks)
2159 2004-06-21 Michael Natterer <mitch@gimp.org>
2162 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
2163 function public as _gdk_x11_convert_to_format().
2165 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
2166 the pixels from the GdkPixbuf when putting them in the
2167 Xcursor image. Fixes bug #144350.
2169 2004-06-16 Federico Mena Quintero <federico@ximian.com>
2171 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
2172 visible node, free the old path before creating the new one.
2175 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
2177 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
2178 (#144198, Mariano Suárez-Alvarez)
2180 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
2182 * gtk/gtkfilechooserdefault.c: Don't use
2183 contractions like "don't" or "isn't" in error messages.
2184 It isn't nice to use them in log entries either...
2185 (#137774, Morten Welinder, patch by Alexander Winston)
2187 2004-06-11 Federico Mena Quintero <federico@ximian.com>
2191 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
2192 Don't ref the editable node.
2193 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
2194 (_gtk_file_system_model_remove_editable): Ahem, free the node.
2196 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
2197 Added fields for edited_idle and edited_new_text.
2198 (renderer_edited_cb): Queue the
2199 creation of the folder in an idle handler.
2200 (renderer_editing_canceled_cb): Likewise for the cancellation.
2201 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
2203 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
2205 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
2207 2004-06-10 Federico Mena Quintero <federico@ximian.com>
2209 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
2211 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
2212 Refer to gtk_file_chooser_add_shortcut_folder().
2213 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
2214 gtk_file_chooser_add_shortcut_folder_uri().
2216 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
2218 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
2219 the drag before focusing the selected.day.
2220 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
2221 a beginning drag if the widget becomes insensitive.
2223 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
2225 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
2226 spinning before calling arrow_action(), so that a signal
2227 handler triggered from arrow_action() has a chance to
2228 stop the spinning. (#143966, Davyd Madeley)
2230 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
2232 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
2233 typo. (#144070, Kent Sandvik)
2235 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2237 * gtk/gtkmenu.c: Revert the "drag select" part of
2240 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
2242 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
2243 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
2245 2004-06-07 Federico Mena Quintero <federico@ximian.com>
2247 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
2248 from 2003/Sep/12. This kept DnD in tree views within modal
2249 dialogs from working, which is especially bad for the file
2250 chooser. Fixes #135168.
2252 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
2254 Make the entry context menu work in editable text cells. The changes
2255 are based on a patch by Kristian Rietveld, which implemented an
2256 approach outlined by Owen Taylor. (#50075)
2258 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
2259 Ignore focus out if the entry menu is posted.
2260 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
2261 posted, and set up a signal handler to clear the flag if the menu
2263 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
2264 set up a timeout to stop editing if the focus is lost.
2265 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
2266 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
2267 signal on the entry and keep a pointer to the entry.
2268 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
2269 clear the pointer to the entry.
2271 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
2273 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
2274 of the ::language property. (#143802, Owen Taylor)
2276 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
2278 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
2279 (gtk_entry_completion_list_enter_notify),
2280 (gtk_entry_completion_list_motion_notify),
2281 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
2282 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
2283 use it as in the menu code to avoid the initial selection if
2284 the window pops up under the pointer. (Anders Carlsson)
2286 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2288 * tests/testmerge.c: Add a checkbox to queue an
2289 merge/unmerge. Patch from Matthias Clasen.
2291 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
2293 (rebuild_menu): New function that rebuilds the overflow menu and
2294 makes sure it doesn't start or end with a separator.
2295 (toolbar_content_new_tool_item)
2296 (toolbar_content_remove)
2297 (toolbar_content_new_compatibility): Set the rebuild_needed flag
2298 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
2299 have actually overflown an item with a proxy menu item. Also make
2300 sure we rebuild the menu if needed.
2302 Fix #125504, #142377, #143463
2304 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
2305 Obey the "priv->draw" flag. (#143692)
2307 2004-06-04 Matthias Clasen <mclasen@redhat.com>
2309 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
2310 quirk in the button size allocation code.
2312 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
2313 requested for drawing the focus indicator to the child in the
2314 !CAN_FOCUS case. This should fix issues which the Gimp has with
2315 the button allocation changes in 2.4.2.
2317 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
2319 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
2320 length of the entry contents in characters, not in bytes.
2322 * gtk/gtkentry.c (paste_received): Don't pop up the completion
2323 window on paste, noticed by Anders Carlsson.
2325 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
2327 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
2328 values and default value for the ::active property. (#143669,
2331 2004-06-03 Michael Natterer <mitch@gimp.org>
2333 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
2334 instead of accessing item->image->allocation.width/height
2335 directly. Makes widgets which only have a requisition set using
2336 gtk_widget_set_size_request() work and fixes bug #142789.
2338 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2340 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
2341 of sticky right click menus to return.
2343 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2345 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
2346 better handle the "click" case. bug Better fix for #141169.
2348 2004-06-02 Federico Mena Quintero <federico@ximian.com>
2350 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
2351 model is empty. Fixes #143536.
2353 2004-06-02 Matthias Clasen <mclasen@redhat.com>
2355 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
2356 close the dialog on focus out of the size entry. (#143505,
2359 2004-06-02 Federico Mena Quintero <federico@ximian.com>
2363 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
2364 (gtk_fnmatch_intern): Likewise; also implement this option.
2366 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
2368 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
2369 no_leading_period argument of _gtk_fnmatch().
2370 (attempt_file_completion): Likewise.
2372 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
2373 no_leading_period argument of _gtk_fnmatch().
2375 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
2377 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
2380 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
2382 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
2383 allow unless selection mode is multiple. (#142634, John Finlay)
2385 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
2389 * gtk/gtkentrycompletion.h:
2390 * gtk/gtkentrycompletion.c:
2391 * gtk/gtkcombobox.h:
2392 * gtk/gtkcombobox.c: Rename function parameters from
2393 index to index_ to prevent clash with BSD index(). (#143001)
2395 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
2397 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
2398 NULL on an accel label. (#139641, Sam Stephenson, patch by
2401 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
2403 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
2404 lookup finding icons in the wrong prefix. (#143328,
2407 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2411 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
2412 only stay up if you release within 500 milliseconds.
2413 (gtk_menu_shell_button_press): Set the activate_time to the event
2414 time when a button is pressed.
2416 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
2417 Interprete button releases as activate when we have seen both an
2418 enter an a motion event.
2420 2004-06-01 Federico Mena Quintero <federico@ximian.com>
2422 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
2423 dummy node if there is no parent node. Fixes #143362.
2425 2004-05-31 Federico Mena Quintero <federico@ximian.com>
2427 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
2428 newly-created folder. Fixes #138932.
2429 (trap_activate_cb): Only return TRUE if we did handle the event.
2430 Fixes #143359; patch by jylefort@brutele.be.
2432 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
2434 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
2435 docs. (#142892, Tommi Komulainen)
2437 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
2439 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
2440 parent is minimized, porting the fix from 1.2. (#1923, #57182)
2442 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
2444 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
2445 unmapped windows work.
2447 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
2449 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
2452 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
2454 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
2455 Refer to ::update-preview, not ::selection-changed.
2457 2004-05-29 Christian Rose <menthos@menthos.com>
2459 * configure.in: Added "tk" to ALL_LINGUAS.
2461 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
2463 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
2464 messages for common problems. (#137974, Owen Taylor)
2466 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
2468 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
2469 errors. (#143337, Billy Biggs)
2471 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
2473 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
2474 bits within visual->depth that aren't used for color to
2475 1s, in case they are alpha.
2477 2004-05-27 Anders Carlsson <andersca@gnome.org>
2479 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
2480 Make separator rows insensitive.
2482 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
2484 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
2487 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
2489 * gtk/gtkentrycompletion.h:
2490 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
2491 Getter for text_column. Also make ::text_column a property.
2493 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
2495 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
2497 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
2499 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
2500 signal if the box exists.
2502 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
2504 Support insensitive cells in tree views and combo boxes:
2506 * gtk/gtkcellrenderer.h:
2507 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
2509 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
2510 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
2511 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
2512 Support drawing insensitive.
2514 * gtk/gtkcellview.h:
2515 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
2516 function to obtain the cell renderers from a cell view. Also
2517 export gtk_cell_view_set_cell_data().
2519 * gtk/gtktreeselection.c (tree_column_is_sensitive):
2520 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
2521 to determine whether all visible cells in a row are insensitive
2522 and whether a row is selectable. A row is not selectable if the
2523 user function says so or if all visible cells are insensitive.
2524 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
2525 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
2526 Use row_is_selectable().
2528 * gtk/gtkcombobox.c (row_is_sensitive):
2529 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
2530 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
2531 to determine row sensitivity in menu or list mode.
2533 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
2534 to set up sensitivity menu items from the underlying rows.
2536 * gtk/gtkcombobox.c (gtk_combo_box_popup):
2537 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
2538 update_menu_sensitivity().
2540 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
2543 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
2546 * tests/testcombo.c (main): Make some rows insensitive.
2548 2004-05-26 Robert Ögren <gtk@roboros.com>
2550 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
2551 modifiers (shift, ctrl etc) in button and motion events from the
2554 2004-05-26 Robert Ögren <gtk@roboros.com>
2556 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
2557 implementation for extended input devices using last known
2558 device state (#143237)
2560 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
2562 * gtk/gtkframe.c: Move docs inline, fixing them on the
2563 way. (#143029, Steve Chaplin)
2565 2004-05-11 Robert Ögren <gtk@roboros.com>
2567 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
2568 events to windows that want extended input events. (#142943)
2569 (gdk_event_translate): Move check for extended input devices to
2570 propagate, new parameter to propagate.
2571 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
2572 _gdk_input_(un)grab_pointer. (#142943)
2574 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
2575 input grab. [Fix missing update of impl in "dijkstra" event
2576 propagation loop] Drop the parallel "impl" pointer, just use a
2577 cast. Don't propagate beyond windows that want normal input
2579 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
2580 implementation of input grab. (#142943)
2582 2004-05-22 Tor Lillqvist <tml@iki.fi>
2584 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
2585 line. (Spotted by Benoît Carpentier.)
2587 2004-05-18 Matthias Clasen <mclasen@redhat.com>
2589 * configure.in: Check for XFIXES extension.
2591 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
2592 a gboolean have_xfixes member.
2594 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
2595 XFIXES events and set have_xfixes.
2597 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
2598 (GdkEventOwnerChange): New event struct for owner change events.
2599 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
2601 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
2602 XFixesSelectionNotify events into GdkEventOwnerChange events.
2605 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
2606 (gdk_display_request_selection_notification): New api
2607 to support selection ownership notification.
2609 * gtk/gtkclipboard.h:
2610 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
2611 api to handle owner change events.
2612 (clipboard_peek): Refactored out the body of
2613 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
2615 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
2616 by calling _gtk_clipboard_handle_event().
2618 2004-05-18 Matthias Clasen <mclasen@redhat.com>
2620 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
2621 the P_() macros ourselves.
2623 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2624 Restrict the width of the popup to be no larger than the
2625 monitor. (#142678, DmD Ljungmark)
2627 * gtk/gtkbutton.c: Go back to the initial fix for the
2628 focus-overdrawing problem, which was actually correct
2629 according to docs/widget_geometry.txt.
2631 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
2632 arrow size from 11 to 15 to compensate for that.
2634 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
2635 arguments of the ::move-cursor signal. (#142725)
2637 2004-05-17 Matthias Clasen <mclasen@redhat.com>
2641 * gtk/gtkbutton.c (gtk_button_size_request)
2642 (gtk_button_size_allocate, _gtk_button_paint): Allocate
2643 space for the focus rectangle only if necessary. (#142668,
2646 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
2650 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
2651 lines. (#142479, Morten Welinder)
2653 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
2655 * gtk/gtkintl.h (Q_): Add a Q_() macro.
2657 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
2658 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
2659 they are not really needed.
2661 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
2662 instead of hardwired padding, use Q_() for the default label,
2663 compute a reasonable minimal size. (#142571, #142572, #142573,
2664 Tommi Komulainen, Christian Persch)
2666 2004-05-15 Tor Lillqvist <tml@iki.fi>
2668 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
2669 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
2670 time). It is used by the OLE2_DND code, which is unfinished and
2671 presumably horribly broken, but still, let's not make it not
2672 compile on purpose. Silence some gcc warnings in the OLE2_DND
2675 2004-05-14 Matthias Clasen <mclasen@redhat.com>
2677 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
2678 New function to go from tree window to tree coordinates, kept
2679 static for now until we figure out the multiple coordinate
2680 system mess in GtkTreeView API-wise.
2681 (gtk_tree_view_scroll_to_cell): Transform the coordinates
2682 from tree window to tree coordinates, using the new function.
2683 Previously, the x coordinate was wrongly transformed. (#142494)
2685 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
2688 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
2689 modifier bit to mark stock item which need to be freed
2690 eventually. (#140654, Michal Pasternak, Scott Tsai)
2692 2004-05-11 Robert Ögren <gtk@roboros.com>
2694 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
2695 call to g_object_ref in Wintab code. (#138341)
2697 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
2698 including unallocated buffers for event->motion.axes and
2699 event->button.axes, unsigned wraparound problem in the code for
2700 detecting missing press/release events and assigning min instead
2701 of max when setting up axes.
2703 2004-05-12 Matthias Clasen <mclasen@redhat.com>
2705 * tests/testtreeedit.c: Add a progress column.
2707 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
2710 * gtk/gtk.h: Include gtkcellrendererprogress.h.
2712 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
2713 based on the one found in Epiphany.
2715 2004-05-11 Michael Natterer <mitch@gimp.org>
2717 * gtk/gtkcombobox.c (gtk_combo_box_popup)
2718 (gtk_combo_box_menu_button_press): don't allocate the popup
2719 smaller than the combobox. Fixes bug #59660.
2721 2004-05-11 Matthias Clasen <mclasen@redhat.com>
2723 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
2724 previous change to this function, clarify the docs instead.
2726 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
2727 GTK_SELECTION_BROWSE.
2729 * gtk/gtktreeview.c: Make hover selection work for
2730 GTK_SELECTION_BROWSE as well.
2732 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
2734 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
2735 Document the ::toggled signal.
2737 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2739 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
2741 2004-05-10 Matthias Clasen <mclasen@redhat.com>
2743 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
2745 * gdk/gdkdisplay.c (singlehead_...):
2746 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
2747 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
2748 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
2750 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
2751 note about COLUMN_FIXED restriction.
2753 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
2754 Set the entry in the default handler of the ::match-selected signal.
2757 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
2758 do the move-selected-item below pointer thingie, do the
2759 place-below-or-above one.
2761 * tests/testentrycompletion.c: Make the second example use the
2762 ::match-selected signal to make it actually work.
2764 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
2765 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
2766 mode. (#127648, Dave Bordoley)
2768 * gtk/gtktreeview.h:
2769 * gtk/gtktreeview.c: Add a new property "hover_selection", which
2770 when TRUE makes the selection follow the mouse. Also add setter
2771 and getter for the fixed_height property.
2773 2004-05-10 Matthias Clasen <mclasen@redhat.com>
2775 * gtk/gtkcombobox.c (gtk_combo_box_popup)
2776 (gtk_combo_box_menu_button_press): Make sure the menu pops up
2777 as wide as the combobox. (#59660, Havoc Pennington)
2779 2004-05-10 Matthias Clasen <mclasen@redhat.com>
2781 * gtk/gtkcombobox.h:
2782 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
2783 mode). Add a new property, add-tearoffs, for this. (#135956)
2785 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
2786 default button. (#118921)
2788 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2790 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
2791 that emits the grab notify signal.
2793 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
2795 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
2797 * gtk/gtkmenu.c: Make destruction of a torn off menu work
2798 like un-tearing off.
2800 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
2804 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
2805 Allow to suppress the stock accelerator by using "". (#142196,
2808 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
2812 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
2813 In list mode, accept the same mouse/wheel bindings on
2814 the cellview as on the button. (#136967)
2816 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
2818 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
2819 cached icons. (#135888, Crispin Flowerday)
2821 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
2823 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
2824 that we actually return menus for nodes of type menu, not the
2825 menuitems they're attached to.
2827 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
2829 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
2830 Add a note regarding UTF-8 requirements, proposed by
2831 Mariano Suárez-Alvarez.
2833 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
2835 * gtk/gtktearoffmenuitem.h:
2836 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
2837 into the GtkTearoffMenuItem struct, since it is used
2838 by the Gimp, and keep it synchronized with the
2839 tearoff_state property of the parent menu.
2841 2004-05-08 Hans Breuer <hans@breuer.org>
2843 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
2844 create the correct mask for 'pseudo mime' icons
2846 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
2847 take focus_on_map into account
2849 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
2851 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
2852 ... must return a value
2854 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
2856 2004-05-07 Matthias Clasen <mclasen@redhat.com>
2858 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
2859 draw over the focus rectangle.
2861 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
2862 standard focus style. (#63071, Bill Haneman, idea for new
2863 style by Owen Taylor)
2865 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
2866 focus on the colorwheel via details.
2868 2004-05-06 Matthias Clasen <mclasen@redhat.com>
2872 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
2873 this no longer needed signal handler. (#141817, Paul Pogonyshev)
2875 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
2877 * gtk/gtktearoffmenuitem.h:
2878 * gtk/gtktearoffmenuitem.c: Make the tearoff
2879 functionality model/view, the tearoffmenuitem being
2880 the view and the tearoff_state property of the menu
2881 being the model. (#101185, Owen Taylor)
2883 * gtk/gtkmenu.c: Add a tearoff_state property.
2885 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
2889 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
2890 popup the submenu for items in torn off menus. (#122051)
2892 2004-05-06 Sven Neumann <sven@gimp.org>
2894 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
2895 position the title lable next to the arrow just as we do for LTR
2896 rendering. Fixes bug #141825.
2898 2004-05-06 Matthias Clasen <mclasen@redhat.com>
2900 * docs/RELEASE-HOWTO: Document the new policy of
2901 bumping version numbers after release.
2903 * configure.in: Bump version number to 2.5.0.
2905 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
2908 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
2911 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
2913 * gtk/gtkactiongroup.h:
2914 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
2915 New function to translate a string with translate_func.
2918 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
2920 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
2921 (gtk_combo_box_get_row_span_column):
2922 (gtk_combo_box_get_column_span_column): Add missing getters
2923 for readwrite properies. (#135649)
2925 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
2927 * gtk/gtkcombobox.h:
2928 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
2929 Add gtk_combo_box_get_active_text() convenience
2930 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
2932 2004-05-05 Elijah Newren <newren@math.utah.edu>
2934 Changes to support do-not-focus-on-map hint in conjunction with
2935 _NET_WM_USER_TIME (#115650):
2937 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
2940 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
2943 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
2944 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
2946 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
2947 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
2948 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
2949 Initialize the focus_on_map field to TRUE.
2951 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
2952 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
2953 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
2954 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
2955 Implementations for the various backends. The Win32 and linux-fb
2956 implementations set the focus_on_map field, but don't use it yet
2957 to actually implement noinput windows. The X implementation sets
2958 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
2960 * gdk/x11/gdkwindow-x11.h:
2961 * gdk/x11/gdkevents-x11.c (set_user_time):
2962 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
2963 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
2964 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
2965 since we want that function to be part of the public API.
2967 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
2971 * gtk/gtkiconfactory.c (icon_source_clear): Don't
2972 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
2974 2004-05-05 Matthias Clasen <mclasen@redhat.com>
2978 * gtk/gtkuimanager.c (print_node): Make the output
2979 parseable. (#141929, Sven Neumann)
2981 2004-05-05 Tor Lillqvist <tml@iki.fi>
2983 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
2984 multi-monitor offset. (#141842, John Ehresman)
2986 2004-05-04 Federico Mena Quintero <federico@ximian.com>
2988 Fixes #139562, based on a patch by Christian Neumair.
2990 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
2991 a filter_combo_hbox field to contain the filter combo.
2992 (show_filters): Show/hide the filter_combo_hbox.
2993 (create_filename_entry_and_filter_combo): Removed.
2994 (file_pane_create): Create the filter_combo_hbox here.
2996 2004-05-04 Matthias Clasen <mclasen@redhat.com>
2998 * modules/input/gtkimcontextxim.c: Fix the recent
2999 string_conversion_callback change to work on
3000 Solaris. (#141190, Padraig O'Briain)
3002 * gtk/gtkselection.c: Disable debug logging again.
3004 2004-05-03 Matthias Clasen <mclasen@redhat.com>
3006 * gtk/gtkselection.c: Make the chunk size for
3007 incremental transfers depend on the maximal request
3008 size, capped at 256k. This should allow most selections
3009 to be transferred nonincrementally, avoiding many
3010 roundtrips and protocol overhead.
3012 2004-05-03 Federico Mena Quintero <federico@ximian.com>
3014 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
3015 g_signal_new() correctly and initialize the signal fields. Fixes
3016 #141749; patch based on Michael Natterer's.
3018 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
3020 * gtk/gtkselection.c (_gtk_selection_request): Fix
3021 a debug message to show correct information.
3022 (_gtk_selection_incr_event): Make INCRemental transfer
3023 of MULTIPLE targets work. This was broken since 1997!
3025 2004-05-02 Hans Breuer <hans@breuer.org>
3027 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
3028 modify the passed in GdkSegment(s) in place, we may get
3029 them again to draw at the same place. Fixes bug #129095,
3031 (draw_segments) draw the end pixel again to get the
3032 pixmap mask right, fixes bug #126710, #130202
3034 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
3035 fixes bug #106013, John Ehresman
3037 * gtk/makefile.msc.in : don't try to link gtk.res but
3038 use gtk-win32.res (as supposed to be fixed below :)
3040 2004-05-01 Hans Breuer <hans@breuer.org>
3042 * tests/Makefile.am : tests/makefile.msc is in CVS for
3043 a long time, finally added to EXTRA_DIST : fixes bug
3044 #141334, John Ehresman
3046 2004-04-30 Matthias Clasen <mclasen@redhat.com>
3048 * === Released 2.4.1 ===
3050 * configure.in: Version 2.4.1, interface age 1.
3054 2004-04-29 Federico Mena Quintero <federico@ximian.com>
3058 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
3059 function; moved the code over from
3060 remove_bookmark_button_clicked_cb().
3061 (remove_selected_bookmarks): Now, getting a non-removable bookmark
3062 is not an error, as we may be called as a result of hitting the
3064 (shortcuts_key_press_event_cb): New handler; delete the bookmark
3065 if the user presses Backspace, Delete, or KP_Delete.
3067 2004-04-29 Matthias Clasen <mclasen@redhat.com>
3069 * gtk/gtkaction.c (closure_accel_activate): Use
3070 _gtk_action_emit_activate() instead of directly
3071 emitting the activate signal. (#141429, Jody Goldberg)
3073 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
3074 Warn people when the accelerator can not be
3075 parsed. (#141429, Jody Goldberg)
3077 2004-04-29 Matthias Clasen <mclasen@redhat.com>
3079 * tests/testentrycompletion.c (main): Add a missing
3080 cat. (#141070, Chris Sherlock)
3082 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
3083 variable. (#141022, Chris Sherlock)
3085 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
3086 cast. (#141013, Chris Sherlock)
3088 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
3089 unused variable. (#141011, Chris Sherlock)
3091 2004-04-29 Tor Lillqvist <tml@iki.fi>
3093 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
3094 leak. (#140775, John Ehresman)
3096 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
3098 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
3099 to index the cached gcs, not depth. (#139494)
3101 2004-04-28 Matthias Clasen <mclasen@redhat.com>
3103 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
3105 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3107 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
3108 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
3110 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
3112 Patch to add support for string conversion callbacks to
3113 GtkIMContextXIM (#101814)
3115 * modules/input/gtkimcontextxim.c: Set the string conversion callback
3116 if supported by the XIC.
3118 (struct _GtkIMContextXIM): Add string_conversion_callback member.
3120 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
3121 whether string conversion callback is supported.
3123 (gtk_im_context_get_ic, +set_string_conversion_callback,
3124 +string_conversion_callback): Also initialize string conversion
3125 callback, if supported, along with the IC initialization.
3127 * modules/input/imxim.c: Make "xim" module default for Thai as well.
3129 2004-04-23 Matthias Clasen <mclasen@redhat.com>
3131 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
3132 initialize targets. (#139883, John Finlay)
3134 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
3136 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
3137 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
3140 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
3141 Remove an excessive g_return_if_fail().
3143 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
3145 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
3146 _-prefix calls of gdk_x11_window_set_user_time().
3148 2004-04-22 Matthias Clasen <mclasen@redhat.com>
3150 * gtk/gtkuimanager.c (update_node): Make sure the separators
3151 used to demarkate placeholder ends don't show up on
3152 show_all(). (#140496, Murray Cumming)
3154 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
3155 work with negative increments. (#137975, Tim Gerla)
3157 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3159 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
3160 gtk_tool_button_set_icon_widget): Remove the old widget from the
3161 tool button before overwriting it with the new widget.
3163 (#140508, Todd Goyen)
3165 2004-04-22 Tor Lillqvist <tml@iki.fi>
3167 Fix the file chooser on Windows. I can't make it misbehave or
3168 crash any more now. But presumably there are still corner cases
3169 not handled. I haven't really checked behaviour of UNC paths, for
3172 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
3173 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
3176 (gtk_file_system_win32_get_parent): Like the Unix version, assert
3177 filename is absolute, and avoid one unnecessary string allocation
3180 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
3181 letters more correctly.
3183 (gtk_file_system_win32_render_icon): Assure correct syntax is used
3184 for root folder of a drive. (#137962, Morten Welinder)
3186 (filename_is_some_root): New function that accepts also root
3187 without any drive specified.
3189 (filename_is_drive_root): Rename from filename_is_root.
3191 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
3194 2004-04-21 Matthias Clasen <mclasen@redhat.com>
3196 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
3197 completion window if there are no completions anymore.
3199 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3200 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
3201 It doesn't like that. (#140642, Christian Persch)
3203 * demos/gtk-demo/expander.c (do_expander): A new demo.
3205 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
3207 2004-04-20 Matthias Clasen <mclasen@redhat.com>
3209 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
3210 sure anchored children get size allocated, even if the layout
3211 is valid. (#122323, Andrew E. Makeev)
3212 (gtk_text_view_scroll_pages):
3213 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
3214 if we already have pending scrolls. Bandaid fix for #78513.
3216 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
3218 * INSTALL.in: Update libpng and libjpeg URLs, remove
3219 note about building without since that's not the normal
3222 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
3224 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
3225 handling of SVG/non-SVG unthemed icons.
3227 2004-04-19 Morten Welinder <terra@gnome.org>
3229 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
3232 2004-04-19 Matthias Clasen <mclasen@redhat.com>
3234 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
3235 Don't stop the iteration up to the tag_root too
3236 early. (#109945, Dongho Shin)
3238 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3240 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
3241 gdk_keymap_translate_keyboard_state() handle NULL
3242 keymaps. (#139715, Torsten Schoenfeld).
3244 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3246 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
3247 reported by Pedro RODRIGUEZ, about compilation problems when
3248 Xcursor is installed in a non-standard location.
3250 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3252 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
3255 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
3256 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
3258 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
3260 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
3263 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
3264 property on user interaction.
3266 2004-04-15 Federico Mena Quintero <federico@ximian.com>
3268 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
3269 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
3271 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
3272 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
3275 2004-04-15 Matthias Clasen <mclasen@redhat.com>
3277 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
3278 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
3280 2004-04-14 Matthias Clasen <mclasen@redhat.com>
3282 * gtk/gtkcombobox.c:
3284 Make all style properties readonly.
3286 2004-04-14 Matthias Clasen <mclasen@redhat.com>
3288 * gtk/gtkcolorsel.c: Add a11y relations between the color
3289 wheel and the spin buttons. (#132745, Padraig O'Briain)
3291 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
3292 the meaning of size == -1.
3294 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
3295 a size of -1. (#137436, Brian Cameron)
3297 * gtk/gtkcombobox.c: Make the arrow and separator regular
3298 children of an hbox inside the button, and propagate state
3299 changes from the button to the cell view. (part of the fix
3300 for #138650, should also fix #137535)
3302 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
3303 state to gtk_cell_renderer_render() when prelighted. (part
3304 of the fix for #138650)
3306 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
3307 Use PRELIGHT state when appropriate. (part of the fix for
3310 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
3311 out warnings if called before the combo box is
3312 realized. (#139742, Philip Langdale)
3314 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
3316 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
3319 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
3321 * gtk/gtkpathbar.c (make_directory_button): remove spurious
3324 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
3326 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
3327 make the buttons sized by a bold label. This makes the text
3328 'swim' a little, but stops the buttons from resizing, #137210
3330 2004-04-13 Matthias Clasen <mclasen@redhat.com>
3332 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
3334 (start_element_handler): Accept separators without unique
3335 names. (#133302, Anders Carlsson)
3337 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
3338 possible accelerator gotcha when using this function. (#139641,
3341 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
3342 list nodes. (#138862, Morten Welinder)
3344 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
3346 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
3348 (gtk_tree_view_button_press): If we activated the row we don't
3349 want to grab focus back, as moving focus to another widget is
3350 pretty common, #138458
3352 2004-04-12 Federico Mena Quintero <federico@ximian.com>
3354 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
3355 documentation to all the signals.
3357 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
3359 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
3360 model if it is NULL. (#139770)
3362 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
3364 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
3365 a shadow inside the scrolled window, add it around the vbox.
3367 * gtk/gtkentryprivate.h:
3368 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3369 Return a boolean indicating whether the popup is positioned above
3370 or below. Scroll the completions to the beginning or the end,
3371 depending on the positioning.
3373 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
3374 wrap around in the entry completion popup, and allow GDK_UP to
3375 enter the popup. (#137440)
3377 2004-04-12 Matthias Clasen <mclasen@redhat.com>
3379 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
3380 there before using it.
3382 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
3384 * gtk/gtktreeprivate.h: Moved search entries into priv data.
3386 * gtk/gtktreeview.c: Prep for type-ahead support.
3388 (gtk_tree_view_destroy): Destroy the search window explicitly.
3389 (gtk_tree_view_key_press): Minor change; prep for type-ahead
3390 (gtk_tree_view_ensure_interactive_directory): New function
3391 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
3392 (gtk_tree_view_real_start_interactive_search): rework
3393 (gtk_tree_view_search_dialog_hide): ditto
3394 (gtk_tree_view_search_delete_event): ditto
3395 (gtk_tree_view_search_button_press_event): ditto
3396 (gtk_tree_view_search_key_press_event): ditto
3397 (gtk_tree_view_search_move): ditto
3398 (gtk_tree_view_search_init): ditto
3400 * gtk/gtktreeviewcolumn.c:
3401 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
3403 * tests/testfilechooser.c: (main): change
3405 2004-04-11 Hans Breuer <hans@breuer.org>
3407 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
3408 the real fix would involve just another small API breakage,
3409 i.e. gdk_spawn_* using GPid not just gint.
3411 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
3413 2004-04-10 Tor Lillqvist <tml@iki.fi>
3415 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
3416 If both Shift and CapsLock pressed, ignore the shift only for
3417 letters (that would have been affected by the CapsLock). (#139095)
3419 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
3420 seems to be even buggier now than it used to be. (#138341)
3421 Initialize _gdk_input_ignore_wintab to TRUE.
3423 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
3424 GDK_USE_WINTAB environment variable to turn on tablet support.
3426 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
3428 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
3429 (gtk_ui_manager_remove_action_group): Terminate
3430 g_object_[dis]connect() calls with NULL instead of 0.
3433 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
3435 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
3437 2004-04-07 Federico Mena Quintero <federico@ximian.com>
3441 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
3442 passed-in 'str' is not NULL.
3444 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
3445 expands "~/" or "~foo/" at the beginning of a filename.
3446 (gtk_file_system_unix_parse): Use expand_tilde() before doing
3449 * gtk/gtkfilechooserentry.c
3450 (gtk_file_chooser_entry_maybe_update_directory): Take in a
3451 force_reload argument.
3452 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
3453 returns an error, set the file_part_pos to -1.
3454 (load_directory_callback): Only populate the model if the
3455 file_part_pos is not -1.
3457 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
3459 * configure.in: Added Icelandic (is) to ALL_LINGUAS
3461 2004-04-05 Federico Mena Quintero <federico@ximian.com>
3463 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
3464 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
3466 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
3467 for G_DIR_SEPARATOR in the display_name, and err out if it is
3468 present; use the same error message as Nautilus. Fixes #136467.
3470 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
3471 new-folder button say "Create Fo_lder" rather than "Create
3472 _Folder", so that the mnemonic doesn't conflict with the "Save in
3473 _folder" label. Fixes #136975.
3475 2004-04-05 Federico Mena Quintero <federico@ximian.com>
3477 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
3478 buttons. Also, free them correctly upon failure. Based on a
3479 patch by Morten Welinder, fixes #137956.
3481 2004-04-05 Anders Carlsson <andersca@gnome.org>
3483 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
3485 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
3487 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
3488 correctly for fixed height when inserting a node, #138082
3490 2004-04-01 Federico Mena Quintero <federico@ximian.com>
3494 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
3495 "child_is_hidden" boolean argument to the "path-clicked" signal.
3497 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
3499 (make_directory_button): Take a file_is_hidden argument; put it in
3501 (_gtk_path_bar_set_path): See whether each path component path is
3503 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
3504 "path-clicked" signal.
3505 (button_clicked_cb): See if the downwards button represents a
3506 hidden file for the file_is_hidden argument in the signal
3509 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
3511 * gtk/gtkfilechooserdefault.c
3512 (gtk_file_chooser_default_select_path): If we fail to switch
3513 folders, don't try to select the path in the file system model.
3514 Also, return the result from _gtk_file_system_model_path_do().
3515 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
3516 file system model if we are asked to select a hidden file.
3517 (path_bar_clicked): Show hidden files based on whether the
3518 immediate downwards folder in the path bar is a hidden file
3520 (struct _GtkFileChooserDefault): Added fields
3521 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
3522 (create_file_list): Set an object data key of
3523 "GtkFileChooserDefault" on the tree view so that we can find the
3524 impl from the popup menu callbacks. Also, hook up to the
3525 "button-press-event" and "popup-menu" signals in the file list to
3526 bring up a popup menu.
3527 (list_popup_menu_cb): New callback.
3528 (list_button_press_event_cb): New callback.
3532 * gtk/gtkfilesystemmodel.c
3533 (_gtk_file_system_model_new): Oops, connect_object to
3536 2004-03-31 Tor Lillqvist <tml@iki.fi>
3538 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
3539 for native Win32. (#136559, J. Ali Harlow)
3541 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
3542 angles. Thanks to Tim Newsham.
3544 2004-03-29 Federico Mena Quintero <federico@ximian.com>
3548 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
3549 for an ::is_finished_loading() method and a ::finished_loading()
3550 signal at the end of the struct.
3552 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
3553 "finished-loading" signal.
3554 (gtk_file_folder_is_finished_loading): New function.
3556 * gtk/gtkfilesystemunix.c
3557 (gtk_file_folder_unix_is_finished_loading): Implement.
3559 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
3560 slot for a "finished-loading" signal.
3561 (gtk_file_system_model_class_init): Create the "finished-loading"
3563 (struct _GtkFileSystemModel): New field
3564 idle_finished_loading_source. We emit the "finished-loading"
3565 signal in an idle if the root folder was done loading right in
3566 _gtk_file_system_model_new(), so that the caller has a chance to
3567 connect to the signal.
3568 (_gtk_file_system_model_new): Connect to the normal signals of the
3569 folder even if the initial _list_children() fails. Also, see if
3570 the folder is finished loading; connect to the "finished-loading"
3572 (gtk_file_system_model_finalize): Remove the idle handler.
3574 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
3575 and connect to the model's "finished-loading" signal.
3576 (get_toplevel): New helper function.
3577 (error_message): Use get_toplevel().
3578 (trap_activate_cb): Likewise.
3579 (location_popup_handler): Likewise.
3580 (set_busy_cursor): New function.
3581 (browse_files_model_finished_loading_cb): New callback.
3583 2004-03-25 Federico Mena Quintero <federico@ximian.com>
3585 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
3586 file under the cursor; we don't need the logic from
3587 GtkFileSelection after all. Fixes #132255.
3589 2004-03-25 Federico Mena Quintero <federico@ximian.com>
3591 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
3592 location entry with the display name of the file under the cursor
3593 for Open mode, or the typed filename in Save mode.
3595 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
3597 * gtk/gtkfilesystemwin32.c
3598 (filename_is_root): Bare drive designators (eg., "c:") are
3599 no longer considered as root filenames. Fixed #137942
3601 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
3603 * gtk/gtkfilesystemwin32.c
3604 (gtk_file_system_win32_create_folder): Invert test for error in
3605 mkdir. Fixes #137945
3607 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
3609 Fixed #138004 using Federico's code from #132327.
3611 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
3612 folder_hash field to keep a list of live folder objects.
3613 (gtk_file_system_win32_init): Create the folder_hash.
3614 (gtk_file_system_win32_finalize): Destroy the folder_hash.
3615 (gtk_file_system_win32_get_folder): Ref and return an existing
3616 folder if we have it around, otherwise return a new folder object.
3617 (struct _GtkFileFolderWin32): Add a field for the parent file system.
3618 (gtk_file_folder_win32_finalize): Remove the folder from the file
3619 system's hash table.
3620 (gtk_file_system_win32_create_folder): Emit "files-added" on the
3621 newly-created folder's parent. Fixes #138004.
3623 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
3625 * gtk/gtkfilesystemwin32.c
3626 (gtk_file_system_win32_get_folder): Test that path is actually
3627 a directory and throw error if not. Fixed bug #137950
3629 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
3631 * gtk/gtkfilesystemwin32.c
3632 (gtk_file_system_win32_volume_get_display_name): Ignore empty
3633 volume labels; assume that GetVolumeInformation would fail if
3634 GetVolumeInformationW does; catches a small memory leak;
3635 pass the buffer size to GetVolumeInformationW in wide
3636 characters instead of bytes. Fixes bug #137543
3637 (list_volumes): Cope with the theoretical possibility of
3638 more than 26 logical drives. Fixes bug #137940
3639 (bookmarks_serialize): Now actually removes bookmarks.
3642 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
3644 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
3646 2004-03-21 Tor Lillqvist <tml@iki.fi>
3648 * gtk/gtkfilesystemwin32.c
3649 (gtk_file_system_win32_volume_get_base_path): Include the
3650 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
3651 NULL for a volume base path, as g_filename_to_uri() requires an
3652 absolute path, and just a drive letter and colon isn't. (#137543)
3654 2004-03-20 Hans Breuer <hans@breuer.org>
3656 * gtk/gtkfilesystemwin32.c : applied the undisputable and
3657 required [due to recent gtkfilesystem internal api semantic
3658 changes] part of patches to fix bug #137543 (Tor Lillqvist,
3661 * gdk/gdkevents-win32.c (handle_configure_event) :
3662 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
3663 GdkWindowObject::x, y with screen coords to make
3664 gdk_window_get_position () return the right thing and thus fix
3665 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
3667 2004-03-19 Federico Mena Quintero <federico@ximian.com>
3669 * Revert the patch to #137520, as 2.4.1 is for conservative bug
3670 fixes only. The patch is attached to the bug report, for
3673 2004-03-19 Morten Welinder <terra@gnome.org>
3675 * gtk/gtkfilechooserdefault.c
3676 (gtk_file_chooser_default_set_current_folder): Test existance of
3677 the path after checking for locality, if needed.
3679 2004-03-19 Federico Mena Quintero <federico@ximian.com>
3683 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
3684 for an ::is_finished_loading() method and a ::finished_loading()
3685 signal at the end of the struct.
3687 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
3688 "finished-loading" signal.
3689 (gtk_file_folder_is_finished_loading): New function.
3691 * gtk/gtkfilesystemunix.c
3692 (gtk_file_folder_unix_is_finished_loading): Implement.
3694 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
3695 slot for a "finished-loading" signal.
3696 (gtk_file_system_model_class_init): Create the "finished-loading"
3698 (struct _GtkFileSystemModel): New field
3699 idle_finished_loading_source. We emit the "finished-loading"
3700 signal in an idle if the root folder was done loading right in
3701 _gtk_file_system_model_new(), so that the caller has a chance to
3702 connect to the signal.
3703 (_gtk_file_system_model_new): Connect to the normal signals of the
3704 folder even if the initial _list_children() fails. Also, see if
3705 the folder is finished loading; connect to the "finished-loading"
3707 (gtk_file_system_model_finalize): Remove the idle handler.
3709 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
3710 and connect to the model's "finished-loading" signal.
3711 (get_toplevel): New helper function.
3712 (error_message): Use get_toplevel().
3713 (trap_activate_cb): Likewise.
3714 (location_popup_handler): Likewise.
3715 (set_busy_cursor): New function.
3716 (browse_files_model_finished_loading_cb): New callback.
3718 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
3720 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
3721 eventbox for expander. (#137564, reported by
3724 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
3726 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
3728 2004-03-17 Morten Welinder <terra@gnome.org>
3730 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
3731 volumes not actually put into the shortcut list.
3733 * tests/prop-editor.c (object_changed): Plug leak.
3735 * tests/testfilechooser.c (main): Plug some leaks and expose
3738 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
3739 object. Fixed #136652.
3741 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
3742 have no screen. Fixes #137260.
3743 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
3744 thereby fixing leak. Fixes #137259.
3746 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
3747 slider buttons have been destroyed.
3748 (gtk_path_bar_remove): Make this work for slider buttons too.
3751 2004-03-15 Morten Welinder <terra@gnome.org>
3753 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
3754 Sanitize and plug leak.
3755 (check_icon_theme): Only do something if the widget has a screen.
3757 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
3759 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3760 Move the repositioning logic from _gtk_entry_completion() popup
3761 over here. Fixes #137355, reported by Niklas Knutsson.