1 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
3 Support insensitive cells in tree views and combo boxes:
5 * gtk/gtkcellrenderer.h:
6 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
8 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
9 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
10 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
11 Support drawing insensitive.
14 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
15 function to obtain the cell renderers from a cell view. Also
16 export gtk_cell_view_set_cell_data().
18 * gtk/gtktreeselection.c (tree_column_is_sensitive):
19 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
20 to determine whether all visible cells in a row are insensitive
21 and whether a row is selectable. A row is not selectable if the
22 user function says so or if all visible cells are insensitive.
23 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
24 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
25 Use row_is_selectable().
27 * gtk/gtkcombobox.c (row_is_sensitive):
28 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
29 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
30 to determine row sensitivity in menu or list mode.
32 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
33 to set up sensitivity menu items from the underlying rows.
35 * gtk/gtkcombobox.c (gtk_combo_box_popup):
36 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
37 update_menu_sensitivity().
39 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
42 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
45 * tests/testcombo.c (main): Make some rows insensitive.
47 2004-05-26 Robert Ögren <gtk@roboros.com>
49 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
50 modifiers (shift, ctrl etc) in button and motion events from the
53 2004-05-26 Robert Ögren <gtk@roboros.com>
55 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
56 implementation for extended input devices using last known
57 device state (#143237)
59 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
61 * gtk/gtkframe.c: Move docs inline, fixing them on the
62 way. (#143029, Steve Chaplin)
64 2004-05-11 Robert Ögren <gtk@roboros.com>
66 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
67 events to windows that want extended input events. (#142943)
68 (gdk_event_translate): Move check for extended input devices to
69 propagate, new parameter to propagate.
70 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
71 _gdk_input_(un)grab_pointer. (#142943)
73 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
74 input grab. [Fix missing update of impl in "dijkstra" event
75 propagation loop] Drop the parallel "impl" pointer, just use a
76 cast. Don't propagate beyond windows that want normal input
78 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
79 implementation of input grab. (#142943)
81 2004-05-22 Tor Lillqvist <tml@iki.fi>
83 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
84 line. (Spotted by Benoît Carpentier.)
86 2004-05-18 Matthias Clasen <mclasen@redhat.com>
88 * configure.in: Check for XFIXES extension.
90 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
91 a gboolean have_xfixes member.
93 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
94 XFIXES events and set have_xfixes.
96 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
97 (GdkEventOwnerChange): New event struct for owner change events.
98 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
100 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
101 XFixesSelectionNotify events into GdkEventOwnerChange events.
104 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
105 (gdk_display_request_selection_notification): New api
106 to support selection ownership notification.
108 * gtk/gtkclipboard.h:
109 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
110 api to handle owner change events.
111 (clipboard_peek): Refactored out the body of
112 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
114 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
115 by calling _gtk_clipboard_handle_event().
117 2004-05-18 Matthias Clasen <mclasen@redhat.com>
119 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
120 the P_() macros ourselves.
122 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
123 Restrict the width of the popup to be no larger than the
124 monitor. (#142678, DmD Ljungmark)
126 * gtk/gtkbutton.c: Go back to the initial fix for the
127 focus-overdrawing problem, which was actually correct
128 according to docs/widget_geometry.txt.
130 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
131 arrow size from 11 to 15 to compensate for that.
133 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
134 arguments of the ::move-cursor signal. (#142725)
136 2004-05-17 Matthias Clasen <mclasen@redhat.com>
140 * gtk/gtkbutton.c (gtk_button_size_request)
141 (gtk_button_size_allocate, _gtk_button_paint): Allocate
142 space for the focus rectangle only if necessary. (#142668,
145 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
149 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
150 lines. (#142479, Morten Welinder)
152 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
154 * gtk/gtkintl.h (Q_): Add a Q_() macro.
156 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
157 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
158 they are not really needed.
160 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
161 instead of hardwired padding, use Q_() for the default label,
162 compute a reasonable minimal size. (#142571, #142572, #142573,
163 Tommi Komulainen, Christian Persch)
165 2004-05-15 Tor Lillqvist <tml@iki.fi>
167 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
168 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
169 time). It is used by the OLE2_DND code, which is unfinished and
170 presumably horribly broken, but still, let's not make it not
171 compile on purpose. Silence some gcc warnings in the OLE2_DND
174 2004-05-14 Matthias Clasen <mclasen@redhat.com>
176 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
177 New function to go from tree window to tree coordinates, kept
178 static for now until we figure out the multiple coordinate
179 system mess in GtkTreeView API-wise.
180 (gtk_tree_view_scroll_to_cell): Transform the coordinates
181 from tree window to tree coordinates, using the new function.
182 Previously, the x coordinate was wrongly transformed. (#142494)
184 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
187 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
188 modifier bit to mark stock item which need to be freed
189 eventually. (#140654, Michal Pasternak, Scott Tsai)
191 2004-05-11 Robert Ögren <gtk@roboros.com>
193 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
194 call to g_object_ref in Wintab code. (#138341)
196 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
197 including unallocated buffers for event->motion.axes and
198 event->button.axes, unsigned wraparound problem in the code for
199 detecting missing press/release events and assigning min instead
200 of max when setting up axes.
202 2004-05-12 Matthias Clasen <mclasen@redhat.com>
204 * tests/testtreeedit.c: Add a progress column.
206 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
209 * gtk/gtk.h: Include gtkcellrendererprogress.h.
211 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
212 based on the one found in Epiphany.
214 2004-05-11 Michael Natterer <mitch@gimp.org>
216 * gtk/gtkcombobox.c (gtk_combo_box_popup)
217 (gtk_combo_box_menu_button_press): don't allocate the popup
218 smaller than the combobox. Fixes bug #59660.
220 2004-05-11 Matthias Clasen <mclasen@redhat.com>
222 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
223 previous change to this function, clarify the docs instead.
225 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
226 GTK_SELECTION_BROWSE.
228 * gtk/gtktreeview.c: Make hover selection work for
229 GTK_SELECTION_BROWSE as well.
231 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
233 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
234 Document the ::toggled signal.
236 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
238 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
240 2004-05-10 Matthias Clasen <mclasen@redhat.com>
242 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
244 * gdk/gdkdisplay.c (singlehead_...):
245 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
246 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
247 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
249 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
250 note about COLUMN_FIXED restriction.
252 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
253 Set the entry in the default handler of the ::match-selected signal.
256 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
257 do the move-selected-item below pointer thingie, do the
258 place-below-or-above one.
260 * tests/testentrycompletion.c: Make the second example use the
261 ::match-selected signal to make it actually work.
263 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
264 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
265 mode. (#127648, Dave Bordoley)
268 * gtk/gtktreeview.c: Add a new property "hover_selection", which
269 when TRUE makes the selection follow the mouse. Also add setter
270 and getter for the fixed_height property.
272 2004-05-10 Matthias Clasen <mclasen@redhat.com>
274 * gtk/gtkcombobox.c (gtk_combo_box_popup)
275 (gtk_combo_box_menu_button_press): Make sure the menu pops up
276 as wide as the combobox. (#59660, Havoc Pennington)
278 2004-05-10 Matthias Clasen <mclasen@redhat.com>
281 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
282 mode). Add a new property, add-tearoffs, for this. (#135956)
284 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
285 default button. (#118921)
287 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
289 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
290 that emits the grab notify signal.
292 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
294 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
296 * gtk/gtkmenu.c: Make destruction of a torn off menu work
299 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
303 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
304 Allow to suppress the stock accelerator by using "". (#142196,
307 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
311 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
312 In list mode, accept the same mouse/wheel bindings on
313 the cellview as on the button. (#136967)
315 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
317 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
318 cached icons. (#135888, Crispin Flowerday)
320 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
322 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
323 that we actually return menus for nodes of type menu, not the
324 menuitems they're attached to.
326 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
328 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
329 Add a note regarding UTF-8 requirements, proposed by
330 Mariano Suárez-Alvarez.
332 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
334 * gtk/gtktearoffmenuitem.h:
335 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
336 into the GtkTearoffMenuItem struct, since it is used
337 by the Gimp, and keep it synchronized with the
338 tearoff_state property of the parent menu.
340 2004-05-08 Hans Breuer <hans@breuer.org>
342 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
343 create the correct mask for 'pseudo mime' icons
345 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
346 take focus_on_map into account
348 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
350 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
351 ... must return a value
353 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
355 2004-05-07 Matthias Clasen <mclasen@redhat.com>
357 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
358 draw over the focus rectangle.
360 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
361 standard focus style. (#63071, Bill Haneman, idea for new
362 style by Owen Taylor)
364 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
365 focus on the colorwheel via details.
367 2004-05-06 Matthias Clasen <mclasen@redhat.com>
371 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
372 this no longer needed signal handler. (#141817, Paul Pogonyshev)
374 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
376 * gtk/gtktearoffmenuitem.h:
377 * gtk/gtktearoffmenuitem.c: Make the tearoff
378 functionality model/view, the tearoffmenuitem being
379 the view and the tearoff_state property of the menu
380 being the model. (#101185, Owen Taylor)
382 * gtk/gtkmenu.c: Add a tearoff_state property.
384 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
388 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
389 popup the submenu for items in torn off menus. (#122051)
391 2004-05-06 Sven Neumann <sven@gimp.org>
393 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
394 position the title lable next to the arrow just as we do for LTR
395 rendering. Fixes bug #141825.
397 2004-05-06 Matthias Clasen <mclasen@redhat.com>
399 * docs/RELEASE-HOWTO: Document the new policy of
400 bumping version numbers after release.
402 * configure.in: Bump version number to 2.5.0.
404 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
407 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
410 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
412 * gtk/gtkactiongroup.h:
413 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
414 New function to translate a string with translate_func.
417 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
419 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
420 (gtk_combo_box_get_row_span_column):
421 (gtk_combo_box_get_column_span_column): Add missing getters
422 for readwrite properies. (#135649)
424 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
427 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
428 Add gtk_combo_box_get_active_text() convenience
429 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
431 2004-05-05 Elijah Newren <newren@math.utah.edu>
433 Changes to support do-not-focus-on-map hint in conjunction with
434 _NET_WM_USER_TIME (#115650):
436 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
439 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
442 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
443 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
445 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
446 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
447 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
448 Initialize the focus_on_map field to TRUE.
450 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
451 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
452 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
453 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
454 Implementations for the various backends. The Win32 and linux-fb
455 implementations set the focus_on_map field, but don't use it yet
456 to actually implement noinput windows. The X implementation sets
457 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
459 * gdk/x11/gdkwindow-x11.h:
460 * gdk/x11/gdkevents-x11.c (set_user_time):
461 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
462 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
463 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
464 since we want that function to be part of the public API.
466 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
470 * gtk/gtkiconfactory.c (icon_source_clear): Don't
471 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
473 2004-05-05 Matthias Clasen <mclasen@redhat.com>
477 * gtk/gtkuimanager.c (print_node): Make the output
478 parseable. (#141929, Sven Neumann)
480 2004-05-05 Tor Lillqvist <tml@iki.fi>
482 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
483 multi-monitor offset. (#141842, John Ehresman)
485 2004-05-04 Federico Mena Quintero <federico@ximian.com>
487 Fixes #139562, based on a patch by Christian Neumair.
489 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
490 a filter_combo_hbox field to contain the filter combo.
491 (show_filters): Show/hide the filter_combo_hbox.
492 (create_filename_entry_and_filter_combo): Removed.
493 (file_pane_create): Create the filter_combo_hbox here.
495 2004-05-04 Matthias Clasen <mclasen@redhat.com>
497 * modules/input/gtkimcontextxim.c: Fix the recent
498 string_conversion_callback change to work on
499 Solaris. (#141190, Padraig O'Briain)
501 * gtk/gtkselection.c: Disable debug logging again.
503 2004-05-03 Matthias Clasen <mclasen@redhat.com>
505 * gtk/gtkselection.c: Make the chunk size for
506 incremental transfers depend on the maximal request
507 size, capped at 256k. This should allow most selections
508 to be transferred nonincrementally, avoiding many
509 roundtrips and protocol overhead.
511 2004-05-03 Federico Mena Quintero <federico@ximian.com>
513 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
514 g_signal_new() correctly and initialize the signal fields. Fixes
515 #141749; patch based on Michael Natterer's.
517 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
519 * gtk/gtkselection.c (_gtk_selection_request): Fix
520 a debug message to show correct information.
521 (_gtk_selection_incr_event): Make INCRemental transfer
522 of MULTIPLE targets work. This was broken since 1997!
524 2004-05-02 Hans Breuer <hans@breuer.org>
526 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
527 modify the passed in GdkSegment(s) in place, we may get
528 them again to draw at the same place. Fixes bug #129095,
530 (draw_segments) draw the end pixel again to get the
531 pixmap mask right, fixes bug #126710, #130202
533 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
534 fixes bug #106013, John Ehresman
536 * gtk/makefile.msc.in : don't try to link gtk.res but
537 use gtk-win32.res (as supposed to be fixed below :)
539 2004-05-01 Hans Breuer <hans@breuer.org>
541 * tests/Makefile.am : tests/makefile.msc is in CVS for
542 a long time, finally added to EXTRA_DIST : fixes bug
543 #141334, John Ehresman
545 2004-04-30 Matthias Clasen <mclasen@redhat.com>
547 * === Released 2.4.1 ===
549 * configure.in: Version 2.4.1, interface age 1.
553 2004-04-29 Federico Mena Quintero <federico@ximian.com>
557 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
558 function; moved the code over from
559 remove_bookmark_button_clicked_cb().
560 (remove_selected_bookmarks): Now, getting a non-removable bookmark
561 is not an error, as we may be called as a result of hitting the
563 (shortcuts_key_press_event_cb): New handler; delete the bookmark
564 if the user presses Backspace, Delete, or KP_Delete.
566 2004-04-29 Matthias Clasen <mclasen@redhat.com>
568 * gtk/gtkaction.c (closure_accel_activate): Use
569 _gtk_action_emit_activate() instead of directly
570 emitting the activate signal. (#141429, Jody Goldberg)
572 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
573 Warn people when the accelerator can not be
574 parsed. (#141429, Jody Goldberg)
576 2004-04-29 Matthias Clasen <mclasen@redhat.com>
578 * tests/testentrycompletion.c (main): Add a missing
579 cat. (#141070, Chris Sherlock)
581 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
582 variable. (#141022, Chris Sherlock)
584 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
585 cast. (#141013, Chris Sherlock)
587 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
588 unused variable. (#141011, Chris Sherlock)
590 2004-04-29 Tor Lillqvist <tml@iki.fi>
592 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
593 leak. (#140775, John Ehresman)
595 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
597 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
598 to index the cached gcs, not depth. (#139494)
600 2004-04-28 Matthias Clasen <mclasen@redhat.com>
602 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
604 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
606 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
607 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
609 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
611 Patch to add support for string conversion callbacks to
612 GtkIMContextXIM (#101814)
614 * modules/input/gtkimcontextxim.c: Set the string conversion callback
615 if supported by the XIC.
617 (struct _GtkIMContextXIM): Add string_conversion_callback member.
619 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
620 whether string conversion callback is supported.
622 (gtk_im_context_get_ic, +set_string_conversion_callback,
623 +string_conversion_callback): Also initialize string conversion
624 callback, if supported, along with the IC initialization.
626 * modules/input/imxim.c: Make "xim" module default for Thai as well.
628 2004-04-23 Matthias Clasen <mclasen@redhat.com>
630 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
631 initialize targets. (#139883, John Finlay)
633 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
635 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
636 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
639 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
640 Remove an excessive g_return_if_fail().
642 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
644 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
645 _-prefix calls of gdk_x11_window_set_user_time().
647 2004-04-22 Matthias Clasen <mclasen@redhat.com>
649 * gtk/gtkuimanager.c (update_node): Make sure the separators
650 used to demarkate placeholder ends don't show up on
651 show_all(). (#140496, Murray Cumming)
653 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
654 work with negative increments. (#137975, Tim Gerla)
656 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
658 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
659 gtk_tool_button_set_icon_widget): Remove the old widget from the
660 tool button before overwriting it with the new widget.
662 (#140508, Todd Goyen)
664 2004-04-22 Tor Lillqvist <tml@iki.fi>
666 Fix the file chooser on Windows. I can't make it misbehave or
667 crash any more now. But presumably there are still corner cases
668 not handled. I haven't really checked behaviour of UNC paths, for
671 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
672 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
675 (gtk_file_system_win32_get_parent): Like the Unix version, assert
676 filename is absolute, and avoid one unnecessary string allocation
679 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
680 letters more correctly.
682 (gtk_file_system_win32_render_icon): Assure correct syntax is used
683 for root folder of a drive. (#137962, Morten Welinder)
685 (filename_is_some_root): New function that accepts also root
686 without any drive specified.
688 (filename_is_drive_root): Rename from filename_is_root.
690 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
693 2004-04-21 Matthias Clasen <mclasen@redhat.com>
695 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
696 completion window if there are no completions anymore.
698 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
699 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
700 It doesn't like that. (#140642, Christian Persch)
702 * demos/gtk-demo/expander.c (do_expander): A new demo.
704 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
706 2004-04-20 Matthias Clasen <mclasen@redhat.com>
708 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
709 sure anchored children get size allocated, even if the layout
710 is valid. (#122323, Andrew E. Makeev)
711 (gtk_text_view_scroll_pages):
712 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
713 if we already have pending scrolls. Bandaid fix for #78513.
715 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
717 * INSTALL.in: Update libpng and libjpeg URLs, remove
718 note about building without since that's not the normal
721 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
723 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
724 handling of SVG/non-SVG unthemed icons.
726 2004-04-19 Morten Welinder <terra@gnome.org>
728 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
731 2004-04-19 Matthias Clasen <mclasen@redhat.com>
733 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
734 Don't stop the iteration up to the tag_root too
735 early. (#109945, Dongho Shin)
737 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
739 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
740 gdk_keymap_translate_keyboard_state() handle NULL
741 keymaps. (#139715, Torsten Schoenfeld).
743 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
745 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
746 reported by Pedro RODRIGUEZ, about compilation problems when
747 Xcursor is installed in a non-standard location.
749 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
751 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
754 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
755 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
757 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
759 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
762 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
763 property on user interaction.
765 2004-04-15 Federico Mena Quintero <federico@ximian.com>
767 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
768 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
770 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
771 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
774 2004-04-15 Matthias Clasen <mclasen@redhat.com>
776 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
777 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
779 2004-04-14 Matthias Clasen <mclasen@redhat.com>
783 Make all style properties readonly.
785 2004-04-14 Matthias Clasen <mclasen@redhat.com>
787 * gtk/gtkcolorsel.c: Add a11y relations between the color
788 wheel and the spin buttons. (#132745, Padraig O'Briain)
790 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
791 the meaning of size == -1.
793 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
794 a size of -1. (#137436, Brian Cameron)
796 * gtk/gtkcombobox.c: Make the arrow and separator regular
797 children of an hbox inside the button, and propagate state
798 changes from the button to the cell view. (part of the fix
799 for #138650, should also fix #137535)
801 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
802 state to gtk_cell_renderer_render() when prelighted. (part
803 of the fix for #138650)
805 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
806 Use PRELIGHT state when appropriate. (part of the fix for
809 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
810 out warnings if called before the combo box is
811 realized. (#139742, Philip Langdale)
813 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
815 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
818 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
820 * gtk/gtkpathbar.c (make_directory_button): remove spurious
823 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
825 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
826 make the buttons sized by a bold label. This makes the text
827 'swim' a little, but stops the buttons from resizing, #137210
829 2004-04-13 Matthias Clasen <mclasen@redhat.com>
831 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
833 (start_element_handler): Accept separators without unique
834 names. (#133302, Anders Carlsson)
836 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
837 possible accelerator gotcha when using this function. (#139641,
840 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
841 list nodes. (#138862, Morten Welinder)
843 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
845 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
847 (gtk_tree_view_button_press): If we activated the row we don't
848 want to grab focus back, as moving focus to another widget is
849 pretty common, #138458
851 2004-04-12 Federico Mena Quintero <federico@ximian.com>
853 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
854 documentation to all the signals.
856 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
858 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
859 model if it is NULL. (#139770)
861 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
863 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
864 a shadow inside the scrolled window, add it around the vbox.
866 * gtk/gtkentryprivate.h:
867 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
868 Return a boolean indicating whether the popup is positioned above
869 or below. Scroll the completions to the beginning or the end,
870 depending on the positioning.
872 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
873 wrap around in the entry completion popup, and allow GDK_UP to
874 enter the popup. (#137440)
876 2004-04-12 Matthias Clasen <mclasen@redhat.com>
878 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
879 there before using it.
881 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
883 * gtk/gtktreeprivate.h: Moved search entries into priv data.
885 * gtk/gtktreeview.c: Prep for type-ahead support.
887 (gtk_tree_view_destroy): Destroy the search window explicitly.
888 (gtk_tree_view_key_press): Minor change; prep for type-ahead
889 (gtk_tree_view_ensure_interactive_directory): New function
890 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
891 (gtk_tree_view_real_start_interactive_search): rework
892 (gtk_tree_view_search_dialog_hide): ditto
893 (gtk_tree_view_search_delete_event): ditto
894 (gtk_tree_view_search_button_press_event): ditto
895 (gtk_tree_view_search_key_press_event): ditto
896 (gtk_tree_view_search_move): ditto
897 (gtk_tree_view_search_init): ditto
899 * gtk/gtktreeviewcolumn.c:
900 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
902 * tests/testfilechooser.c: (main): change
904 2004-04-11 Hans Breuer <hans@breuer.org>
906 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
907 the real fix would involve just another small API breakage,
908 i.e. gdk_spawn_* using GPid not just gint.
910 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
912 2004-04-10 Tor Lillqvist <tml@iki.fi>
914 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
915 If both Shift and CapsLock pressed, ignore the shift only for
916 letters (that would have been affected by the CapsLock). (#139095)
918 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
919 seems to be even buggier now than it used to be. (#138341)
920 Initialize _gdk_input_ignore_wintab to TRUE.
922 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
923 GDK_USE_WINTAB environment variable to turn on tablet support.
925 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
927 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
928 (gtk_ui_manager_remove_action_group): Terminate
929 g_object_[dis]connect() calls with NULL instead of 0.
932 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
934 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
936 2004-04-07 Federico Mena Quintero <federico@ximian.com>
940 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
941 passed-in 'str' is not NULL.
943 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
944 expands "~/" or "~foo/" at the beginning of a filename.
945 (gtk_file_system_unix_parse): Use expand_tilde() before doing
948 * gtk/gtkfilechooserentry.c
949 (gtk_file_chooser_entry_maybe_update_directory): Take in a
950 force_reload argument.
951 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
952 returns an error, set the file_part_pos to -1.
953 (load_directory_callback): Only populate the model if the
954 file_part_pos is not -1.
956 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
958 * configure.in: Added Icelandic (is) to ALL_LINGUAS
960 2004-04-05 Federico Mena Quintero <federico@ximian.com>
962 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
963 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
965 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
966 for G_DIR_SEPARATOR in the display_name, and err out if it is
967 present; use the same error message as Nautilus. Fixes #136467.
969 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
970 new-folder button say "Create Fo_lder" rather than "Create
971 _Folder", so that the mnemonic doesn't conflict with the "Save in
972 _folder" label. Fixes #136975.
974 2004-04-05 Federico Mena Quintero <federico@ximian.com>
976 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
977 buttons. Also, free them correctly upon failure. Based on a
978 patch by Morten Welinder, fixes #137956.
980 2004-04-05 Anders Carlsson <andersca@gnome.org>
982 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
984 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
986 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
987 correctly for fixed height when inserting a node, #138082
989 2004-04-01 Federico Mena Quintero <federico@ximian.com>
993 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
994 "child_is_hidden" boolean argument to the "path-clicked" signal.
996 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
998 (make_directory_button): Take a file_is_hidden argument; put it in
1000 (_gtk_path_bar_set_path): See whether each path component path is
1002 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
1003 "path-clicked" signal.
1004 (button_clicked_cb): See if the downwards button represents a
1005 hidden file for the file_is_hidden argument in the signal
1008 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
1010 * gtk/gtkfilechooserdefault.c
1011 (gtk_file_chooser_default_select_path): If we fail to switch
1012 folders, don't try to select the path in the file system model.
1013 Also, return the result from _gtk_file_system_model_path_do().
1014 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
1015 file system model if we are asked to select a hidden file.
1016 (path_bar_clicked): Show hidden files based on whether the
1017 immediate downwards folder in the path bar is a hidden file
1019 (struct _GtkFileChooserDefault): Added fields
1020 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
1021 (create_file_list): Set an object data key of
1022 "GtkFileChooserDefault" on the tree view so that we can find the
1023 impl from the popup menu callbacks. Also, hook up to the
1024 "button-press-event" and "popup-menu" signals in the file list to
1025 bring up a popup menu.
1026 (list_popup_menu_cb): New callback.
1027 (list_button_press_event_cb): New callback.
1031 * gtk/gtkfilesystemmodel.c
1032 (_gtk_file_system_model_new): Oops, connect_object to
1035 2004-03-31 Tor Lillqvist <tml@iki.fi>
1037 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
1038 for native Win32. (#136559, J. Ali Harlow)
1040 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
1041 angles. Thanks to Tim Newsham.
1043 2004-03-29 Federico Mena Quintero <federico@ximian.com>
1047 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1048 for an ::is_finished_loading() method and a ::finished_loading()
1049 signal at the end of the struct.
1051 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1052 "finished-loading" signal.
1053 (gtk_file_folder_is_finished_loading): New function.
1055 * gtk/gtkfilesystemunix.c
1056 (gtk_file_folder_unix_is_finished_loading): Implement.
1058 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1059 slot for a "finished-loading" signal.
1060 (gtk_file_system_model_class_init): Create the "finished-loading"
1062 (struct _GtkFileSystemModel): New field
1063 idle_finished_loading_source. We emit the "finished-loading"
1064 signal in an idle if the root folder was done loading right in
1065 _gtk_file_system_model_new(), so that the caller has a chance to
1066 connect to the signal.
1067 (_gtk_file_system_model_new): Connect to the normal signals of the
1068 folder even if the initial _list_children() fails. Also, see if
1069 the folder is finished loading; connect to the "finished-loading"
1071 (gtk_file_system_model_finalize): Remove the idle handler.
1073 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1074 and connect to the model's "finished-loading" signal.
1075 (get_toplevel): New helper function.
1076 (error_message): Use get_toplevel().
1077 (trap_activate_cb): Likewise.
1078 (location_popup_handler): Likewise.
1079 (set_busy_cursor): New function.
1080 (browse_files_model_finished_loading_cb): New callback.
1082 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1084 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
1085 file under the cursor; we don't need the logic from
1086 GtkFileSelection after all. Fixes #132255.
1088 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1090 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
1091 location entry with the display name of the file under the cursor
1092 for Open mode, or the typed filename in Save mode.
1094 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1096 * gtk/gtkfilesystemwin32.c
1097 (filename_is_root): Bare drive designators (eg., "c:") are
1098 no longer considered as root filenames. Fixed #137942
1100 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1102 * gtk/gtkfilesystemwin32.c
1103 (gtk_file_system_win32_create_folder): Invert test for error in
1104 mkdir. Fixes #137945
1106 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1108 Fixed #138004 using Federico's code from #132327.
1110 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
1111 folder_hash field to keep a list of live folder objects.
1112 (gtk_file_system_win32_init): Create the folder_hash.
1113 (gtk_file_system_win32_finalize): Destroy the folder_hash.
1114 (gtk_file_system_win32_get_folder): Ref and return an existing
1115 folder if we have it around, otherwise return a new folder object.
1116 (struct _GtkFileFolderWin32): Add a field for the parent file system.
1117 (gtk_file_folder_win32_finalize): Remove the folder from the file
1118 system's hash table.
1119 (gtk_file_system_win32_create_folder): Emit "files-added" on the
1120 newly-created folder's parent. Fixes #138004.
1122 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1124 * gtk/gtkfilesystemwin32.c
1125 (gtk_file_system_win32_get_folder): Test that path is actually
1126 a directory and throw error if not. Fixed bug #137950
1128 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
1130 * gtk/gtkfilesystemwin32.c
1131 (gtk_file_system_win32_volume_get_display_name): Ignore empty
1132 volume labels; assume that GetVolumeInformation would fail if
1133 GetVolumeInformationW does; catches a small memory leak;
1134 pass the buffer size to GetVolumeInformationW in wide
1135 characters instead of bytes. Fixes bug #137543
1136 (list_volumes): Cope with the theoretical possibility of
1137 more than 26 logical drives. Fixes bug #137940
1138 (bookmarks_serialize): Now actually removes bookmarks.
1141 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
1143 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
1145 2004-03-21 Tor Lillqvist <tml@iki.fi>
1147 * gtk/gtkfilesystemwin32.c
1148 (gtk_file_system_win32_volume_get_base_path): Include the
1149 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
1150 NULL for a volume base path, as g_filename_to_uri() requires an
1151 absolute path, and just a drive letter and colon isn't. (#137543)
1153 2004-03-20 Hans Breuer <hans@breuer.org>
1155 * gtk/gtkfilesystemwin32.c : applied the undisputable and
1156 required [due to recent gtkfilesystem internal api semantic
1157 changes] part of patches to fix bug #137543 (Tor Lillqvist,
1160 * gdk/gdkevents-win32.c (handle_configure_event) :
1161 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
1162 GdkWindowObject::x, y with screen coords to make
1163 gdk_window_get_position () return the right thing and thus fix
1164 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
1166 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1168 * Revert the patch to #137520, as 2.4.1 is for conservative bug
1169 fixes only. The patch is attached to the bug report, for
1172 2004-03-19 Morten Welinder <terra@gnome.org>
1174 * gtk/gtkfilechooserdefault.c
1175 (gtk_file_chooser_default_set_current_folder): Test existance of
1176 the path after checking for locality, if needed.
1178 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1182 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1183 for an ::is_finished_loading() method and a ::finished_loading()
1184 signal at the end of the struct.
1186 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1187 "finished-loading" signal.
1188 (gtk_file_folder_is_finished_loading): New function.
1190 * gtk/gtkfilesystemunix.c
1191 (gtk_file_folder_unix_is_finished_loading): Implement.
1193 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1194 slot for a "finished-loading" signal.
1195 (gtk_file_system_model_class_init): Create the "finished-loading"
1197 (struct _GtkFileSystemModel): New field
1198 idle_finished_loading_source. We emit the "finished-loading"
1199 signal in an idle if the root folder was done loading right in
1200 _gtk_file_system_model_new(), so that the caller has a chance to
1201 connect to the signal.
1202 (_gtk_file_system_model_new): Connect to the normal signals of the
1203 folder even if the initial _list_children() fails. Also, see if
1204 the folder is finished loading; connect to the "finished-loading"
1206 (gtk_file_system_model_finalize): Remove the idle handler.
1208 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1209 and connect to the model's "finished-loading" signal.
1210 (get_toplevel): New helper function.
1211 (error_message): Use get_toplevel().
1212 (trap_activate_cb): Likewise.
1213 (location_popup_handler): Likewise.
1214 (set_busy_cursor): New function.
1215 (browse_files_model_finished_loading_cb): New callback.
1217 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
1219 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
1220 eventbox for expander. (#137564, reported by
1223 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
1225 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
1227 2004-03-17 Morten Welinder <terra@gnome.org>
1229 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
1230 volumes not actually put into the shortcut list.
1232 * tests/prop-editor.c (object_changed): Plug leak.
1234 * tests/testfilechooser.c (main): Plug some leaks and expose
1237 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
1238 object. Fixed #136652.
1240 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
1241 have no screen. Fixes #137260.
1242 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
1243 thereby fixing leak. Fixes #137259.
1245 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
1246 slider buttons have been destroyed.
1247 (gtk_path_bar_remove): Make this work for slider buttons too.
1250 2004-03-15 Morten Welinder <terra@gnome.org>
1252 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
1253 Sanitize and plug leak.
1254 (check_icon_theme): Only do something if the widget has a screen.
1256 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
1258 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1259 Move the repositioning logic from _gtk_entry_completion() popup
1260 over here. Fixes #137355, reported by Niklas Knutsson.