1 2002-03-27 Murray Cumming <murrayc@usa.net>
3 * gtk/gtktreeview.cc: Corrected registered return type of
4 "move-cursor" signal. Had to add a marshaller to
5 gtk/gtkmarshalers.list.
7 Tue Mar 26 14:46:50 2002 Owen Taylor <otaylor@redhat.com>
9 * gtk/gtkmenu.c (gtk_menu_popup): Shuffle the ordering around
10 some more (position before realizing) fixing problems with
11 arrows popping up at the wrong time (#73386), hopefully not
12 introducing other problems. (Reported by Ettore Perrazoli, others)
14 2002-03-26 Dave Camp <dave@ximian.com>
16 * gtk/gtktreeview.c (gtk_tree_view_button_press): Free the path
17 after calling gtk_tree_view_row_activated() rather than before.
19 2002-03-25 Sven Neumann <sven@gimp.org>
21 * gtk/gtkrc.c (gtk_rc_parse_font_name): free the style's
22 font_description before assigning a new one.
23 (gtk_rc_parse_stock): always unref the created icon_set. #76289
25 2002-03-25 Mark McLoughlin <mark@skynet.ie>
27 * gtk/gtkbindings.c: (gtk_binding_entry_add_signal),
28 kill code duplicated in gtk_binding_entry_add_signall.
30 Sun Mar 24 10:32:38 2002 Jonathan Blandford <jrb@redhat.com>
32 * gtk/gtktreemodel.c (gtk_tree_path_copy): Make path arg const, #75653
34 * gtk/gtkfontsel.c (gtk_font_selection_show_available_styles): fix
37 * gtk/gtktreeview.c (gtk_tree_view_button_press): remove the grab
38 when we emit row_activated so that listeners of this signal can
39 grab the mouse, #75629
41 2002-03-23 Havoc Pennington <hp@pobox.com>
43 * gtk/gtktextlayout.c (gtk_text_layout_real_invalidate):
44 invalidate the line containing start, even if the [start,end)
45 range is empty (just invalidate [start,end], essentially).
46 Partially fixes #72374
48 2002-03-23 Havoc Pennington <hp@pobox.com>
50 * gtk/gtktextview.c (gtk_text_view_do_popup): end any selection in
51 progress, patch from db@zigo.dhs.org, #74620
53 2002-03-23 Havoc Pennington <hp@pobox.com>
55 * gtk/gtktextview.c (gtk_text_view_move_cursor_internal): extend
56 selection for pageup/pagedown and ctrl+pageup/pagedown if
57 shift is held. more of #53934
59 2002-03-23 Havoc Pennington <hp@pobox.com>
61 * gtk/gtktextview.c (gtk_text_view_destroy_layout): disconnect
62 layout handlers earlier in the function, to avoid possible
64 (gtk_text_view_invalidate): Don't install idle handlers if
65 layout == NULL, otherwise we get problems during finalization
66 since clearing the buffer invalidates and puts the idle handlers
67 back after we destroy the layout. #74660
68 (gtk_text_view_ensure_layout): Install the validation handlers
69 right after creating the layout.
71 * gtk/gtktexttagtable.c (foreach_unref): call
72 _gtk_text_buffer_notify_will_remove_tag(), #75126
74 2002-03-22 Havoc Pennington <hp@pobox.com>
76 * gdk/x11/gdkfont-x11.c (gdk_fontset_load): add more explanatory
77 text to the error message about missing charsets, and use
78 g_printerr() not g_warning() since this is typically not a
79 programming error (we do not export any API to ask whether
80 a font set will have missing charsets so apps realistically can't
81 do anything other than try the gdk_fontset_load())
83 * gtk/gtktextview.c (gtk_text_view_key_press_event): return FALSE
84 if the text view isn't editable and the user presses Return,
85 so default buttons and such can be activated, #74937
87 * gtk/gtktextbuffer.c (paste_from_buffer): don't insert
88 if the insertion point is not editable and the paste
89 is interactive, #74125
91 * gtk/gtkwindow.c (gtk_window_move_resize): enhance the #if 0
94 * gtk/gtktextbuffer.c (cut_or_copy): only remove the previous
95 cut/copied data right before replacing it, when we know we are
96 going to replace it. Fixes #74049
98 2002-03-22 Richard Hult <rhult@codefactory.se>
100 * gdk/gdkevents.c (gdk_event_get_root_coords): Fix typo, where x
101 value was assigned to both x and y.
103 Fri Mar 22 11:29:11 2002 Owen Taylor <otaylor@redhat.com>
105 Partial fix for problem where keypad keys acted
106 as shift-arrows in an entry rather than arrows (#74327)
108 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Sort lookup
109 results by number of modifiers in the entry. Fixes
110 problem where if a key matched both modified and unmodified
111 key bindings ... e.g., the distinguishing key binding
112 was consumed, then it was random which was used.
114 * gtk/gtkbindings.c (gtk_binding_entries_sort_patterns):
115 Catch the case where there are multiple entries from the
116 same bindingset (with different modifiers), and use only
117 the first entry, which, with the change in _gtk_key_hash_lookup()
118 will be the preferred value.
120 Fri Mar 22 10:56:19 2002 Owen Taylor <otaylor@redhat.com>
122 * gtk/gtkaccelmap.c (gtk_accel_map_save_fd): Fix memory
123 leak. (#74400, Morten Welinder.)
125 * gtk/gtkaccelmap.c: Properly handle short returns from
126 write() calls. (Handling EINTR isn't enough... that only
127 handles the case where you were interrupted before you
128 wrote a single byte.)
130 * gdk/linux-fb/gdkmouse-fb.c gdk/linux-fb/gdkkeyboard-fb.c:
131 Robustify against short returns from write() calls.
133 Fri Mar 22 10:12:10 2002 Owen Taylor <otaylor@redhat.com>
135 * gtk/gtktextview.c (gtk_text_view_paint): Change
136 G_BREAKPOINT() to g_assert_not_reached ().
137 (#75865, Ashok Venkiteswaran)
139 2002-03-22 Tor Lillqvist <tml@iki.fi>
141 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Don't clear
142 all of the pen_style, just the PS_STYLE_MASK. Seems to fix #74441,
143 but that is just the special case of one-pixel wide one-pixel
144 on-off dotted lines. To fully implement generic X11 style dashed
145 lines a major rewrite would be needed.
147 2002-03-21 Matthias Clasen <maclas@gmx.de>
149 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Trivial typo
150 fix. (Vitaly Tishkov, #75726)
152 Thu Mar 21 10:04:05 2002 Owen Taylor <otaylor@redhat.com>
154 * gdk/gdkwindow.c (gdk_window_real_get_depth): Remove
155 some left over debugging code with a G_BREAKPOINT()
158 Wed Mar 20 19:33:31 2002 Owen Taylor <otaylor@redhat.com>
160 * gtk/gtkcalendar.c (gtk_calendar_main_button): When
161 changing months when the user clicks on a prev-month
162 or next-month day, focus and select the new day.
163 Ignore double clicks on prev-month, next-month days.
164 (Based on suggestions from Andras Salamon, #74173)
166 * gtk/gtkcalendar.c: Implement the focused/unfocused
167 selected color change.
169 2002-03-20 Alex Larsson <alexl@redhat.com>
171 Patches from Carlo E. Prelz <fluido@fluido.as>
172 Now gtkfb at least compiles and mostly works. The keyboard
173 stuff needs more loving.
175 * gdk/linux-fb/gdkkeyboard-fb.c (xlate_get_for_keyval,
176 xlate_get_for_keycode, raw_get_for_keyval, raw_get_for_keycode):
177 At least set the out parameters for these calls.
179 * gdk/linux-fb/gdkmain-fb.c:
180 (gdk_pointer_grab_info_libgtk_only, gdk_keyboard_grab_info_libgtk_only):
181 Implement new functions.
183 Wed Mar 20 19:00:03 2002 Owen Taylor <otaylor@redhat.com>
185 * gtk/gtkentry.c (gtk_entry_set_text): Short-circuit
186 the text to the exact same thing, so we don't
187 unexpectedly change the selection or cursor position.
188 (#74290, John Ellis.)
190 Thu Mar 21 00:05:14 2002 Kristian Rietveld <kris@gtk.org>
192 * gtk/gtktreeview.c (gtk_tree_view_get_background_area),
193 (gtk_tree_view_get_cell_area): fix logic (fixes #74235, #73593)
195 Wed Mar 20 17:11:51 2002 Owen Taylor <otaylor@redhat.com>
197 * gtk/gtkrc.c: Patch from Richard Hestilow to fix
198 gtk-font-name changes for widgets that get the actual
199 default style. (#73709)
201 Wed Mar 20 22:59:23 2002 Kristian Rietveld <kris@gtk.org>
203 * gtk/gtkrbtree.[ch]: add _gtk_rbtree_set_fixed_height()
205 * gtk/gtktreeprivate.h: add fixed_height_check field
207 * gtk/gtktreeview.c (gtk_tree_view_init): initialize
208 scroll_sync_timer and fixed_height_check
209 (do_validate_rows): add fixed_height_check. If all validated rows
210 in the first cycle have the same height, then we set that height for
211 the entire tree. This is some sort of 'fake' optimization, but helps
212 a lot for the common case. We keep validating the entire tree in
213 the background though.
214 (gtk_tree_view_set_model): reset fixed_height_check
216 Wed Mar 20 16:36:08 2002 Owen Taylor <otaylor@redhat.com>
218 * gtk/*.c: Patch from Erwann Chenede, #73900 fixing
219 a lot of warnings with Forte CC, mostly implicit
220 casts between void * and function pointers.
222 * gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's
223 state field is not a GdkModifierType. (Also #73900)
225 Wed Mar 20 12:35:22 2002 Owen Taylor <otaylor@redhat.com>
227 * gtk/gtkwidget.c (gtk_widget_grab_default): Remove
228 leftover notification of has-default. (#75508, Jacob
231 Wed Mar 20 12:27:07 2002 Owen Taylor <otaylor@redhat.com>
233 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Allow
234 arrow keys as accelerators, as long as some modifier
237 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Fix
238 incorrect example in the docs.
240 Wed Mar 20 12:06:30 2002 Owen Taylor <otaylor@redhat.com>
242 * gtk/gtkwidget.c (gtk_widget_set_child_visible):
243 Fix segfault when widget->parent is NULL.
244 (#75615, Alexey A. Malyshev)
246 Wed Mar 20 11:32:07 2002 Owen Taylor <otaylor@redhat.com>
248 * gtk/gtkentry.c: Improve test to prevent infinite
249 loop. (#74952, Thomas Leonard)
251 * gtk/gtkmenushell.c (gtk_real_menu_shell_cycle_focus):
252 Fix warning when toplevel menu shell isn't a menu
253 bar. (Thomas Leonard, #75602)
255 Wed Mar 20 11:00:59 2002 Owen Taylor <otaylor@redhat.com>
257 * configure.in: Use $PKG_CONFIG, not pkg-config.
258 (LEE Sau Dan, #75572)
260 Wed Mar 20 10:55:56 2002 Owen Taylor <otaylor@redhat.com>
262 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Fix assignment
263 of time in scroll events. (Sven Neumann, #75574)
265 2002-03-20 Tor Lillqvist <tml@iki.fi>
267 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window): Use
268 gdk_window_get_toplevel(), as it is the top-level windows that are
271 * gdk/win32/gdkwin32.h: Don't include gdkinternals.h.
273 2002-03-19 jacob berkman <jacob@ximian.com>
275 * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
276 gtk_combo_func() returns NULL (bug #75464)
278 2002-03-18 jacob berkman <jacob@ximian.com>
280 * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the
281 correct min/max values for the ratio property (fixes #75331)
283 Mon Mar 18 11:55:03 2002 Owen Taylor <otaylor@redhat.com>
285 * gtk/gtkimmulticontext.c (gtk_im_multicontext_get_slave):
286 Patch from Yao Zhang fixing reference count leak.
288 * gtk/gtkentry.c (gtk_entry_key_release): if (entry->editable),
289 not if (!entry->editable).
291 Mon Mar 18 11:09:17 2002 Owen Taylor <otaylor@redhat.com>
293 * gdk/x11/gdkwindow-x11.c (gdk_window_set_override_redirect):
294 Fix backwards conditional. (#75019, Dan Winship.)
296 Sun Mar 17 01:11:16 2002 Kristian Rietveld <kris@gtk.org>
298 * gtk/gtktreeview.c (gtk_tree_view_size_request): use
299 do_validate_rows instead of validate_rows_handler (fix by
302 Sat Mar 16 23:54:56 2002 Kristian Rietveld <kris@gtk.org>
304 * gdk/x11/gdkwindow-x11.c (gdk_window_set_static_bit_gravity): just
305 return when we have an input_only window (fix by Owen Taylor)
307 * gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): add
310 * gtk/gtktreeview.c (install_scroll_sync_handler): new function,
311 (scroll_sync_handler): ditto,
312 (gtk_tree_view_unrealize): take scroll_sync_timer into account
313 (gtk_tree_view_row_deleted): install scroll_sync_timer instead of
314 calling top_row_to_dy/dy_to_top_row directly
315 -- this greatly speeds up clearing the model (#73199)
317 * gtk/gtktreemodelsort.c
318 (gtk_tree_model_sort_convert_path_to_child_path): fix up this function,
319 for some reason I really screwed it up (fixes #74663)
321 2002-03-16 Sven Neumann <sven@gimp.org>
323 * configure.in (GDK_PIXBUF_DEP_CFLAGS) (GDK_PIXBUF_XLIB_DEP_CFLAGS)
324 (GDK_DEP_CFLAGS) (GTK_DEP_CFLAGS): include CFLAGS from gthread-2.0
325 so that the libs work correctly in a threaded environment.
327 Fri Mar 15 12:51:42 2002 Jonathan Blandford <jrb@redhat.com>
329 * gtk/gtktreeviewcolumn.c
330 (gtk_tree_view_column_new_with_attributes): add example to docs,
331 as people are seeming to have trouble with this function.
333 2002-03-15 Tor Lillqvist <tml@iki.fi>
335 * configure.in: Set MATH_LIB to empty also on Win32.
337 Fri Mar 15 15:37:01 2002 Owen Taylor <otaylor@redhat.com>
339 * gdk/x11/gdkdrawable-x11.c (convert_to_format):
340 Fix byte shift arithmetic for big-endian. (Tracked
341 down with help from Tuomas Kuosmanen)
343 Fri Mar 15 11:28:41 2002 Jonathan Blandford <jrb@redhat.com>
345 * gtk/gtktreeview.c (gtk_tree_view_insert_column_with_data_func):
346 make args const, 74159
347 (gtk_tree_view_insert_column_with_attributes): ditto
349 * gtk/gtktreeviewcolumn.c
350 (gtk_tree_view_column_cell_process_action): remov unused variables.
352 Fri Mar 15 13:31:51 2002 Soeren Sandmann <sandmann@daimi.au.dk>
354 * gtk/gtkmenu.c (gtk_menu_leave_notify): Fix test for "active
357 2002-03-15 Padraig O'Briain <padraig.obriain@sun.com>
359 * gdk/x11/gdkkeys-x11.c (update_keymaps): Fudge keymap to have lower
360 upper case variants if there is only a single keysym per keycode and
361 the key symbol has upper and lower case variants (#74512)
363 Thu Mar 14 17:09:52 2002 Owen Taylor <otaylor@redhat.com>
365 * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
366 improbable reentrancy problem if a window is destroyed
367 while updates are being processed on another window. (Noticed
368 by Michael Meeks, #74708)
370 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
372 * gtk/gtktreemodelsort.c
373 typo in docs for gtk_tree_model_sort_convert_iter_to_child_iter() fixed
376 Thu Mar 14 11:17:18 2002 Owen Taylor <otaylor@redhat.com>
378 * gtk/gtkkeyhash.c (_gtk_key_hash_remove_entry): When
379 removing keys from the key hash, reinsert the right list
380 back into the hash. (Dave Camp, #74571)
382 Wed Mar 13 17:17:40 2002 Owen Taylor <otaylor@redhat.com>
384 * gtk/gtkobject.h: Remove left-over GTK_OBJECT_CONNECTED
385 macro that was defined in terms of the now-gone GTK_CONNECTED
386 flag. (Seth Burgess, #74028)
388 Wed Mar 13 17:11:10 2002 Owen Taylor <otaylor@redhat.com>
390 * gtk/gtkaccelgroup.c (accel_group_weak_ref_detach): Unset
391 the acceleratable_groups qdata because qdata isn't removed
392 on ->dispose but rather on ->finalize. (#74569, found
395 Tue Mar 12 23:14:23 2002 Jonathan Blandford <jrb@redhat.com>
397 * gtk/gtktreeselection.c (gtk_tree_selection_unselect_iter): Fix
400 Sat Mar 9 18:23:25 2002 Richard Hestilow <hestilow@ximian.com>
402 * gtk/gtkimage.c (gtk_image_set_from_filename): Allow NULL
405 Tue Mar 12 10:50:09 2002 Owen Taylor <otaylor@redhat.com>
407 * modules/input/gtkimcontextxim.c (gtk_im_context_xim_filter_keypress):
408 Fix incorrect return value, filter out returns of 0x7f for
409 the delete key. (#74179, Kang Jeong-He)
411 Mon Mar 11 23:42:11 2002 Jonathan Blandford <jrb@redhat.com>
413 * gtk/gtktreemodel.c (gtk_tree_model_foreach): fix totally broken
416 2002-03-11 Matthias Clasen <maclas@gmx.de>
418 * gtk/gtkitemfactory.c (gtk_item_factory_add_foreign): Document
419 gtk_{menu_item,widget}_set_accel_path() as the recommended API.
422 2002-03-11 James Henstridge <james@daa.com.au>
424 * configure.in: set CCAS and CCASFLAGS to get automake 1.6
425 compatibility without breaking things for people using 1.4.
427 Sun Mar 10 21:04:30 2002 Jonathan Blandford <jrb@redhat.com>
429 * gtk/gtktreeview.c (gtk_tree_view_button_press): finally get the
432 Mon Mar 11 01:25:14 2002 Kristian Rietveld <kris@gtk.org>
434 * gtk/gtktreeview.c (gtk_tree_view_button_press): compare path with
435 cursor path and not with the selected iter in the 'decide to edit'