1 2002-03-23 Havoc Pennington <hp@pobox.com>
3 * gtk/gtktextview.c (gtk_text_view_do_popup): end any selection in
4 progress, patch from db@zigo.dhs.org, #74620
6 2002-03-23 Havoc Pennington <hp@pobox.com>
8 * gtk/gtktextview.c (gtk_text_view_move_cursor_internal): extend
9 selection for pageup/pagedown and ctrl+pageup/pagedown if
10 shift is held. more of #53934
12 2002-03-23 Havoc Pennington <hp@pobox.com>
14 * gtk/gtktextview.c (gtk_text_view_destroy_layout): disconnect
15 layout handlers earlier in the function, to avoid possible
17 (gtk_text_view_invalidate): Don't install idle handlers if
18 layout == NULL, otherwise we get problems during finalization
19 since clearing the buffer invalidates and puts the idle handlers
20 back after we destroy the layout. #74660
21 (gtk_text_view_ensure_layout): Install the validation handlers
22 right after creating the layout.
24 * gtk/gtktexttagtable.c (foreach_unref): call
25 _gtk_text_buffer_notify_will_remove_tag(), #75126
27 2002-03-22 Havoc Pennington <hp@pobox.com>
29 * gdk/x11/gdkfont-x11.c (gdk_fontset_load): add more explanatory
30 text to the error message about missing charsets, and use
31 g_printerr() not g_warning() since this is typically not a
32 programming error (we do not export any API to ask whether
33 a font set will have missing charsets so apps realistically can't
34 do anything other than try the gdk_fontset_load())
36 * gtk/gtktextview.c (gtk_text_view_key_press_event): return FALSE
37 if the text view isn't editable and the user presses Return,
38 so default buttons and such can be activated, #74937
40 * gtk/gtktextbuffer.c (paste_from_buffer): don't insert
41 if the insertion point is not editable and the paste
42 is interactive, #74125
44 * gtk/gtkwindow.c (gtk_window_move_resize): enhance the #if 0
47 * gtk/gtktextbuffer.c (cut_or_copy): only remove the previous
48 cut/copied data right before replacing it, when we know we are
49 going to replace it. Fixes #74049
51 2002-03-22 Richard Hult <rhult@codefactory.se>
53 * gdk/gdkevents.c (gdk_event_get_root_coords): Fix typo, where x
54 value was assigned to both x and y.
56 Fri Mar 22 11:29:11 2002 Owen Taylor <otaylor@redhat.com>
58 Partial fix for problem where keypad keys acted
59 as shift-arrows in an entry rather than arrows (#74327)
61 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Sort lookup
62 results by number of modifiers in the entry. Fixes
63 problem where if a key matched both modified and unmodified
64 key bindings ... e.g., the distinguishing key binding
65 was consumed, then it was random which was used.
67 * gtk/gtkbindings.c (gtk_binding_entries_sort_patterns):
68 Catch the case where there are multiple entries from the
69 same bindingset (with different modifiers), and use only
70 the first entry, which, with the change in _gtk_key_hash_lookup()
71 will be the preferred value.
73 Fri Mar 22 10:56:19 2002 Owen Taylor <otaylor@redhat.com>
75 * gtk/gtkaccelmap.c (gtk_accel_map_save_fd): Fix memory
76 leak. (#74400, Morten Welinder.)
78 * gtk/gtkaccelmap.c: Properly handle short returns from
79 write() calls. (Handling EINTR isn't enough... that only
80 handles the case where you were interrupted before you
83 * gdk/linux-fb/gdkmouse-fb.c gdk/linux-fb/gdkkeyboard-fb.c:
84 Robustify against short returns from write() calls.
86 Fri Mar 22 10:12:10 2002 Owen Taylor <otaylor@redhat.com>
88 * gtk/gtktextview.c (gtk_text_view_paint): Change
89 G_BREAKPOINT() to g_assert_not_reached ().
90 (#75865, Ashok Venkiteswaran)
92 2002-03-22 Tor Lillqvist <tml@iki.fi>
94 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Don't clear
95 all of the pen_style, just the PS_STYLE_MASK. Seems to fix #74441,
96 but that is just the special case of one-pixel wide one-pixel
97 on-off dotted lines. To fully implement generic X11 style dashed
98 lines a major rewrite would be needed.
100 2002-03-21 Matthias Clasen <maclas@gmx.de>
102 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Trivial typo
103 fix. (Vitaly Tishkov, #75726)
105 Thu Mar 21 10:04:05 2002 Owen Taylor <otaylor@redhat.com>
107 * gdk/gdkwindow.c (gdk_window_real_get_depth): Remove
108 some left over debugging code with a G_BREAKPOINT()
111 Wed Mar 20 19:33:31 2002 Owen Taylor <otaylor@redhat.com>
113 * gtk/gtkcalendar.c (gtk_calendar_main_button): When
114 changing months when the user clicks on a prev-month
115 or next-month day, focus and select the new day.
116 Ignore double clicks on prev-month, next-month days.
117 (Based on suggestions from Andras Salamon, #74173)
119 * gtk/gtkcalendar.c: Implement the focused/unfocused
120 selected color change.
122 2002-03-20 Alex Larsson <alexl@redhat.com>
124 Patches from Carlo E. Prelz <fluido@fluido.as>
125 Now gtkfb at least compiles and mostly works. The keyboard
126 stuff needs more loving.
128 * gdk/linux-fb/gdkkeyboard-fb.c (xlate_get_for_keyval,
129 xlate_get_for_keycode, raw_get_for_keyval, raw_get_for_keycode):
130 At least set the out parameters for these calls.
132 * gdk/linux-fb/gdkmain-fb.c:
133 (gdk_pointer_grab_info_libgtk_only, gdk_keyboard_grab_info_libgtk_only):
134 Implement new functions.
136 Wed Mar 20 19:00:03 2002 Owen Taylor <otaylor@redhat.com>
138 * gtk/gtkentry.c (gtk_entry_set_text): Short-circuit
139 the text to the exact same thing, so we don't
140 unexpectedly change the selection or cursor position.
141 (#74290, John Ellis.)
143 Thu Mar 21 00:05:14 2002 Kristian Rietveld <kris@gtk.org>
145 * gtk/gtktreeview.c (gtk_tree_view_get_background_area),
146 (gtk_tree_view_get_cell_area): fix logic (fixes #74235, #73593)
148 Wed Mar 20 17:11:51 2002 Owen Taylor <otaylor@redhat.com>
150 * gtk/gtkrc.c: Patch from Richard Hestilow to fix
151 gtk-font-name changes for widgets that get the actual
152 default style. (#73709)
154 Wed Mar 20 22:59:23 2002 Kristian Rietveld <kris@gtk.org>
156 * gtk/gtkrbtree.[ch]: add _gtk_rbtree_set_fixed_height()
158 * gtk/gtktreeprivate.h: add fixed_height_check field
160 * gtk/gtktreeview.c (gtk_tree_view_init): initialize
161 scroll_sync_timer and fixed_height_check
162 (do_validate_rows): add fixed_height_check. If all validated rows
163 in the first cycle have the same height, then we set that height for
164 the entire tree. This is some sort of 'fake' optimization, but helps
165 a lot for the common case. We keep validating the entire tree in
166 the background though.
167 (gtk_tree_view_set_model): reset fixed_height_check
169 Wed Mar 20 16:36:08 2002 Owen Taylor <otaylor@redhat.com>
171 * gtk/*.c: Patch from Erwann Chenede, #73900 fixing
172 a lot of warnings with Forte CC, mostly implicit
173 casts between void * and function pointers.
175 * gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's
176 state field is not a GdkModifierType. (Also #73900)
178 Wed Mar 20 12:35:22 2002 Owen Taylor <otaylor@redhat.com>
180 * gtk/gtkwidget.c (gtk_widget_grab_default): Remove
181 leftover notification of has-default. (#75508, Jacob
184 Wed Mar 20 12:27:07 2002 Owen Taylor <otaylor@redhat.com>
186 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Allow
187 arrow keys as accelerators, as long as some modifier
190 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Fix
191 incorrect example in the docs.
193 Wed Mar 20 12:06:30 2002 Owen Taylor <otaylor@redhat.com>
195 * gtk/gtkwidget.c (gtk_widget_set_child_visible):
196 Fix segfault when widget->parent is NULL.
197 (#75615, Alexey A. Malyshev)
199 Wed Mar 20 11:32:07 2002 Owen Taylor <otaylor@redhat.com>
201 * gtk/gtkentry.c: Improve test to prevent infinite
202 loop. (#74952, Thomas Leonard)
204 * gtk/gtkmenushell.c (gtk_real_menu_shell_cycle_focus):
205 Fix warning when toplevel menu shell isn't a menu
206 bar. (Thomas Leonard, #75602)
208 Wed Mar 20 11:00:59 2002 Owen Taylor <otaylor@redhat.com>
210 * configure.in: Use $PKG_CONFIG, not pkg-config.
211 (LEE Sau Dan, #75572)
213 Wed Mar 20 10:55:56 2002 Owen Taylor <otaylor@redhat.com>
215 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Fix assignment
216 of time in scroll events. (Sven Neumann, #75574)
218 2002-03-20 Tor Lillqvist <tml@iki.fi>
220 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window): Use
221 gdk_window_get_toplevel(), as it is the top-level windows that are
224 * gdk/win32/gdkwin32.h: Don't include gdkinternals.h.
226 2002-03-19 jacob berkman <jacob@ximian.com>
228 * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
229 gtk_combo_func() returns NULL (bug #75464)
231 2002-03-18 jacob berkman <jacob@ximian.com>
233 * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the
234 correct min/max values for the ratio property (fixes #75331)
236 Mon Mar 18 11:55:03 2002 Owen Taylor <otaylor@redhat.com>
238 * gtk/gtkimmulticontext.c (gtk_im_multicontext_get_slave):
239 Patch from Yao Zhang fixing reference count leak.
241 * gtk/gtkentry.c (gtk_entry_key_release): if (entry->editable),
242 not if (!entry->editable).
244 Mon Mar 18 11:09:17 2002 Owen Taylor <otaylor@redhat.com>
246 * gdk/x11/gdkwindow-x11.c (gdk_window_set_override_redirect):
247 Fix backwards conditional. (#75019, Dan Winship.)
249 Sun Mar 17 01:11:16 2002 Kristian Rietveld <kris@gtk.org>
251 * gtk/gtktreeview.c (gtk_tree_view_size_request): use
252 do_validate_rows instead of validate_rows_handler (fix by
255 Sat Mar 16 23:54:56 2002 Kristian Rietveld <kris@gtk.org>
257 * gdk/x11/gdkwindow-x11.c (gdk_window_set_static_bit_gravity): just
258 return when we have an input_only window (fix by Owen Taylor)
260 * gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): add
263 * gtk/gtktreeview.c (install_scroll_sync_handler): new function,
264 (scroll_sync_handler): ditto,
265 (gtk_tree_view_unrealize): take scroll_sync_timer into account
266 (gtk_tree_view_row_deleted): install scroll_sync_timer instead of
267 calling top_row_to_dy/dy_to_top_row directly
268 -- this greatly speeds up clearing the model (#73199)
270 * gtk/gtktreemodelsort.c
271 (gtk_tree_model_sort_convert_path_to_child_path): fix up this function,
272 for some reason I really screwed it up (fixes #74663)
274 2002-03-16 Sven Neumann <sven@gimp.org>
276 * configure.in (GDK_PIXBUF_DEP_CFLAGS) (GDK_PIXBUF_XLIB_DEP_CFLAGS)
277 (GDK_DEP_CFLAGS) (GTK_DEP_CFLAGS): include CFLAGS from gthread-2.0
278 so that the libs work correctly in a threaded environment.
280 Fri Mar 15 12:51:42 2002 Jonathan Blandford <jrb@redhat.com>
282 * gtk/gtktreeviewcolumn.c
283 (gtk_tree_view_column_new_with_attributes): add example to docs,
284 as people are seeming to have trouble with this function.
286 2002-03-15 Tor Lillqvist <tml@iki.fi>
288 * configure.in: Set MATH_LIB to empty also on Win32.
290 Fri Mar 15 15:37:01 2002 Owen Taylor <otaylor@redhat.com>
292 * gdk/x11/gdkdrawable-x11.c (convert_to_format):
293 Fix byte shift arithmetic for big-endian. (Tracked
294 down with help from Tuomas Kuosmanen)
296 Fri Mar 15 11:28:41 2002 Jonathan Blandford <jrb@redhat.com>
298 * gtk/gtktreeview.c (gtk_tree_view_insert_column_with_data_func):
299 make args const, 74159
300 (gtk_tree_view_insert_column_with_attributes): ditto
302 * gtk/gtktreeviewcolumn.c
303 (gtk_tree_view_column_cell_process_action): remov unused variables.
305 Fri Mar 15 13:31:51 2002 Soeren Sandmann <sandmann@daimi.au.dk>
307 * gtk/gtkmenu.c (gtk_menu_leave_notify): Fix test for "active
310 2002-03-15 Padraig O'Briain <padraig.obriain@sun.com>
312 * gdk/x11/gdkkeys-x11.c (update_keymaps): Fudge keymap to have lower
313 upper case variants if there is only a single keysym per keycode and
314 the key symbol has upper and lower case variants (#74512)
316 Thu Mar 14 17:09:52 2002 Owen Taylor <otaylor@redhat.com>
318 * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
319 improbable reentrancy problem if a window is destroyed
320 while updates are being processed on another window. (Noticed
321 by Michael Meeks, #74708)
323 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
325 * gtk/gtktreemodelsort.c
326 typo in docs for gtk_tree_model_sort_convert_iter_to_child_iter() fixed
329 Thu Mar 14 11:17:18 2002 Owen Taylor <otaylor@redhat.com>
331 * gtk/gtkkeyhash.c (_gtk_key_hash_remove_entry): When
332 removing keys from the key hash, reinsert the right list
333 back into the hash. (Dave Camp, #74571)
335 Wed Mar 13 17:17:40 2002 Owen Taylor <otaylor@redhat.com>
337 * gtk/gtkobject.h: Remove left-over GTK_OBJECT_CONNECTED
338 macro that was defined in terms of the now-gone GTK_CONNECTED
339 flag. (Seth Burgess, #74028)
341 Wed Mar 13 17:11:10 2002 Owen Taylor <otaylor@redhat.com>
343 * gtk/gtkaccelgroup.c (accel_group_weak_ref_detach): Unset
344 the acceleratable_groups qdata because qdata isn't removed
345 on ->dispose but rather on ->finalize. (#74569, found
348 Tue Mar 12 23:14:23 2002 Jonathan Blandford <jrb@redhat.com>
350 * gtk/gtktreeselection.c (gtk_tree_selection_unselect_iter): Fix
353 Sat Mar 9 18:23:25 2002 Richard Hestilow <hestilow@ximian.com>
355 * gtk/gtkimage.c (gtk_image_set_from_filename): Allow NULL
358 Tue Mar 12 10:50:09 2002 Owen Taylor <otaylor@redhat.com>
360 * modules/input/gtkimcontextxim.c (gtk_im_context_xim_filter_keypress):
361 Fix incorrect return value, filter out returns of 0x7f for
362 the delete key. (#74179, Kang Jeong-He)
364 Mon Mar 11 23:42:11 2002 Jonathan Blandford <jrb@redhat.com>
366 * gtk/gtktreemodel.c (gtk_tree_model_foreach): fix totally broken
369 2002-03-11 Matthias Clasen <maclas@gmx.de>
371 * gtk/gtkitemfactory.c (gtk_item_factory_add_foreign): Document
372 gtk_{menu_item,widget}_set_accel_path() as the recommended API.
375 2002-03-11 James Henstridge <james@daa.com.au>
377 * configure.in: set CCAS and CCASFLAGS to get automake 1.6
378 compatibility without breaking things for people using 1.4.
380 Sun Mar 10 21:04:30 2002 Jonathan Blandford <jrb@redhat.com>
382 * gtk/gtktreeview.c (gtk_tree_view_button_press): finally get the
385 Mon Mar 11 01:25:14 2002 Kristian Rietveld <kris@gtk.org>
387 * gtk/gtktreeview.c (gtk_tree_view_button_press): compare path with
388 cursor path and not with the selected iter in the 'decide to edit'