1 2004-06-22 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
4 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
7 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
8 this gets defined for all backends, so linux-fb has a
11 * gdk/x11/gdkgc-x11.c:
12 * gdk/gdkgc.c: Move function docs inline, add hints about
13 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
15 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
16 for children of the root. (#139785, Jean-François Wauthy,
19 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
20 fix. (#144750, Jeff Franks)
22 2004-06-21 Michael Natterer <mitch@gimp.org>
25 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
26 function public as _gdk_x11_convert_to_format().
28 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
29 the pixels from the GdkPixbuf when putting them in the
30 Xcursor image. Fixes bug #144350.
32 2004-06-16 Federico Mena Quintero <federico@ximian.com>
34 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
35 visible node, free the old path before creating the new one.
38 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
40 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
41 (#144198, Mariano Suárez-Alvarez)
43 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
45 * gtk/gtkfilechooserdefault.c: Don't use
46 contractions like "don't" or "isn't" in error messages.
47 It isn't nice to use them in log entries either...
48 (#137774, Morten Welinder, patch by Alexander Winston)
50 2004-06-11 Federico Mena Quintero <federico@ximian.com>
54 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
55 Don't ref the editable node.
56 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
57 (_gtk_file_system_model_remove_editable): Ahem, free the node.
59 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
60 Added fields for edited_idle and edited_new_text.
61 (renderer_edited_cb): Queue the
62 creation of the folder in an idle handler.
63 (renderer_editing_canceled_cb): Likewise for the cancellation.
64 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
66 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
68 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
70 2004-06-10 Federico Mena Quintero <federico@ximian.com>
72 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
74 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
75 Refer to gtk_file_chooser_add_shortcut_folder().
76 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
77 gtk_file_chooser_add_shortcut_folder_uri().
79 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
81 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
82 the drag before focusing the selected.day.
83 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
84 a beginning drag if the widget becomes insensitive.
86 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
88 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
89 spinning before calling arrow_action(), so that a signal
90 handler triggered from arrow_action() has a chance to
91 stop the spinning. (#143966, Davyd Madeley)
93 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
95 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
96 typo. (#144070, Kent Sandvik)
98 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
100 * gtk/gtkmenu.c: Revert the "drag select" part of
103 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
105 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
106 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
108 2004-06-07 Federico Mena Quintero <federico@ximian.com>
110 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
111 from 2003/Sep/12. This kept DnD in tree views within modal
112 dialogs from working, which is especially bad for the file
113 chooser. Fixes #135168.
115 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
117 Make the entry context menu work in editable text cells. The changes
118 are based on a patch by Kristian Rietveld, which implemented an
119 approach outlined by Owen Taylor. (#50075)
121 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
122 Ignore focus out if the entry menu is posted.
123 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
124 posted, and set up a signal handler to clear the flag if the menu
126 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
127 set up a timeout to stop editing if the focus is lost.
128 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
129 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
130 signal on the entry and keep a pointer to the entry.
131 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
132 clear the pointer to the entry.
134 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
136 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
137 of the ::language property. (#143802, Owen Taylor)
139 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
141 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
142 (gtk_entry_completion_list_enter_notify),
143 (gtk_entry_completion_list_motion_notify),
144 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
145 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
146 use it as in the menu code to avoid the initial selection if
147 the window pops up under the pointer. (Anders Carlsson)
149 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
151 * tests/testmerge.c: Add a checkbox to queue an
152 merge/unmerge. Patch from Matthias Clasen.
154 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
156 (rebuild_menu): New function that rebuilds the overflow menu and
157 makes sure it doesn't start or end with a separator.
158 (toolbar_content_new_tool_item)
159 (toolbar_content_remove)
160 (toolbar_content_new_compatibility): Set the rebuild_needed flag
161 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
162 have actually overflown an item with a proxy menu item. Also make
163 sure we rebuild the menu if needed.
165 Fix #125504, #142377, #143463
167 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
168 Obey the "priv->draw" flag. (#143692)
170 2004-06-04 Matthias Clasen <mclasen@redhat.com>
172 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
173 quirk in the button size allocation code.
175 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
176 requested for drawing the focus indicator to the child in the
177 !CAN_FOCUS case. This should fix issues which the Gimp has with
178 the button allocation changes in 2.4.2.
180 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
182 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
183 length of the entry contents in characters, not in bytes.
185 * gtk/gtkentry.c (paste_received): Don't pop up the completion
186 window on paste, noticed by Anders Carlsson.
188 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
190 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
191 values and default value for the ::active property. (#143669,
194 2004-06-03 Michael Natterer <mitch@gimp.org>
196 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
197 instead of accessing item->image->allocation.width/height
198 directly. Makes widgets which only have a requisition set using
199 gtk_widget_set_size_request() work and fixes bug #142789.
201 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
203 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
204 of sticky right click menus to return.
206 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
208 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
209 better handle the "click" case. bug Better fix for #141169.
211 2004-06-02 Federico Mena Quintero <federico@ximian.com>
213 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
214 model is empty. Fixes #143536.
216 2004-06-02 Matthias Clasen <mclasen@redhat.com>
218 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
219 close the dialog on focus out of the size entry. (#143505,
222 2004-06-02 Federico Mena Quintero <federico@ximian.com>
226 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
227 (gtk_fnmatch_intern): Likewise; also implement this option.
229 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
231 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
232 no_leading_period argument of _gtk_fnmatch().
233 (attempt_file_completion): Likewise.
235 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
236 no_leading_period argument of _gtk_fnmatch().
238 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
240 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
243 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
245 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
246 allow unless selection mode is multiple. (#142634, John Finlay)
248 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
252 * gtk/gtkentrycompletion.h:
253 * gtk/gtkentrycompletion.c:
255 * gtk/gtkcombobox.c: Rename function parameters from
256 index to index_ to prevent clash with BSD index(). (#143001)
258 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
260 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
261 NULL on an accel label. (#139641, Sam Stephenson, patch by
264 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
266 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
267 lookup finding icons in the wrong prefix. (#143328,
270 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
274 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
275 only stay up if you release within 500 milliseconds.
276 (gtk_menu_shell_button_press): Set the activate_time to the event
277 time when a button is pressed.
279 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
280 Interprete button releases as activate when we have seen both an
281 enter an a motion event.
283 2004-06-01 Federico Mena Quintero <federico@ximian.com>
285 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
286 dummy node if there is no parent node. Fixes #143362.
288 2004-05-31 Federico Mena Quintero <federico@ximian.com>
290 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
291 newly-created folder. Fixes #138932.
292 (trap_activate_cb): Only return TRUE if we did handle the event.
293 Fixes #143359; patch by jylefort@brutele.be.
295 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
297 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
298 docs. (#142892, Tommi Komulainen)
300 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
302 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
303 parent is minimized, porting the fix from 1.2. (#1923, #57182)
305 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
307 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
308 unmapped windows work.
310 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
312 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
315 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
317 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
318 Refer to ::update-preview, not ::selection-changed.
320 2004-05-29 Christian Rose <menthos@menthos.com>
322 * configure.in: Added "tk" to ALL_LINGUAS.
324 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
326 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
327 messages for common problems. (#137974, Owen Taylor)
329 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
331 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
332 errors. (#143337, Billy Biggs)
334 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
336 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
337 bits within visual->depth that aren't used for color to
338 1s, in case they are alpha.
340 2004-05-27 Anders Carlsson <andersca@gnome.org>
342 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
343 Make separator rows insensitive.
345 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
347 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
350 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
352 * gtk/gtkentrycompletion.h:
353 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
354 Getter for text_column. Also make ::text_column a property.
356 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
358 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
360 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
362 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
363 signal if the box exists.
365 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
367 Support insensitive cells in tree views and combo boxes:
369 * gtk/gtkcellrenderer.h:
370 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
372 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
373 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
374 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
375 Support drawing insensitive.
378 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
379 function to obtain the cell renderers from a cell view. Also
380 export gtk_cell_view_set_cell_data().
382 * gtk/gtktreeselection.c (tree_column_is_sensitive):
383 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
384 to determine whether all visible cells in a row are insensitive
385 and whether a row is selectable. A row is not selectable if the
386 user function says so or if all visible cells are insensitive.
387 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
388 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
389 Use row_is_selectable().
391 * gtk/gtkcombobox.c (row_is_sensitive):
392 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
393 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
394 to determine row sensitivity in menu or list mode.
396 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
397 to set up sensitivity menu items from the underlying rows.
399 * gtk/gtkcombobox.c (gtk_combo_box_popup):
400 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
401 update_menu_sensitivity().
403 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
406 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
409 * tests/testcombo.c (main): Make some rows insensitive.
411 2004-05-26 Robert Ögren <gtk@roboros.com>
413 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
414 modifiers (shift, ctrl etc) in button and motion events from the
417 2004-05-26 Robert Ögren <gtk@roboros.com>
419 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
420 implementation for extended input devices using last known
421 device state (#143237)
423 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
425 * gtk/gtkframe.c: Move docs inline, fixing them on the
426 way. (#143029, Steve Chaplin)
428 2004-05-11 Robert Ögren <gtk@roboros.com>
430 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
431 events to windows that want extended input events. (#142943)
432 (gdk_event_translate): Move check for extended input devices to
433 propagate, new parameter to propagate.
434 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
435 _gdk_input_(un)grab_pointer. (#142943)
437 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
438 input grab. [Fix missing update of impl in "dijkstra" event
439 propagation loop] Drop the parallel "impl" pointer, just use a
440 cast. Don't propagate beyond windows that want normal input
442 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
443 implementation of input grab. (#142943)
445 2004-05-22 Tor Lillqvist <tml@iki.fi>
447 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
448 line. (Spotted by Benoît Carpentier.)
450 2004-05-18 Matthias Clasen <mclasen@redhat.com>
452 * configure.in: Check for XFIXES extension.
454 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
455 a gboolean have_xfixes member.
457 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
458 XFIXES events and set have_xfixes.
460 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
461 (GdkEventOwnerChange): New event struct for owner change events.
462 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
464 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
465 XFixesSelectionNotify events into GdkEventOwnerChange events.
468 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
469 (gdk_display_request_selection_notification): New api
470 to support selection ownership notification.
472 * gtk/gtkclipboard.h:
473 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
474 api to handle owner change events.
475 (clipboard_peek): Refactored out the body of
476 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
478 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
479 by calling _gtk_clipboard_handle_event().
481 2004-05-18 Matthias Clasen <mclasen@redhat.com>
483 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
484 the P_() macros ourselves.
486 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
487 Restrict the width of the popup to be no larger than the
488 monitor. (#142678, DmD Ljungmark)
490 * gtk/gtkbutton.c: Go back to the initial fix for the
491 focus-overdrawing problem, which was actually correct
492 according to docs/widget_geometry.txt.
494 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
495 arrow size from 11 to 15 to compensate for that.
497 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
498 arguments of the ::move-cursor signal. (#142725)
500 2004-05-17 Matthias Clasen <mclasen@redhat.com>
504 * gtk/gtkbutton.c (gtk_button_size_request)
505 (gtk_button_size_allocate, _gtk_button_paint): Allocate
506 space for the focus rectangle only if necessary. (#142668,
509 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
513 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
514 lines. (#142479, Morten Welinder)
516 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
518 * gtk/gtkintl.h (Q_): Add a Q_() macro.
520 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
521 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
522 they are not really needed.
524 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
525 instead of hardwired padding, use Q_() for the default label,
526 compute a reasonable minimal size. (#142571, #142572, #142573,
527 Tommi Komulainen, Christian Persch)
529 2004-05-15 Tor Lillqvist <tml@iki.fi>
531 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
532 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
533 time). It is used by the OLE2_DND code, which is unfinished and
534 presumably horribly broken, but still, let's not make it not
535 compile on purpose. Silence some gcc warnings in the OLE2_DND
538 2004-05-14 Matthias Clasen <mclasen@redhat.com>
540 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
541 New function to go from tree window to tree coordinates, kept
542 static for now until we figure out the multiple coordinate
543 system mess in GtkTreeView API-wise.
544 (gtk_tree_view_scroll_to_cell): Transform the coordinates
545 from tree window to tree coordinates, using the new function.
546 Previously, the x coordinate was wrongly transformed. (#142494)
548 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
551 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
552 modifier bit to mark stock item which need to be freed
553 eventually. (#140654, Michal Pasternak, Scott Tsai)
555 2004-05-11 Robert Ögren <gtk@roboros.com>
557 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
558 call to g_object_ref in Wintab code. (#138341)
560 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
561 including unallocated buffers for event->motion.axes and
562 event->button.axes, unsigned wraparound problem in the code for
563 detecting missing press/release events and assigning min instead
564 of max when setting up axes.
566 2004-05-12 Matthias Clasen <mclasen@redhat.com>
568 * tests/testtreeedit.c: Add a progress column.
570 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
573 * gtk/gtk.h: Include gtkcellrendererprogress.h.
575 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
576 based on the one found in Epiphany.
578 2004-05-11 Michael Natterer <mitch@gimp.org>
580 * gtk/gtkcombobox.c (gtk_combo_box_popup)
581 (gtk_combo_box_menu_button_press): don't allocate the popup
582 smaller than the combobox. Fixes bug #59660.
584 2004-05-11 Matthias Clasen <mclasen@redhat.com>
586 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
587 previous change to this function, clarify the docs instead.
589 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
590 GTK_SELECTION_BROWSE.
592 * gtk/gtktreeview.c: Make hover selection work for
593 GTK_SELECTION_BROWSE as well.
595 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
597 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
598 Document the ::toggled signal.
600 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
602 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
604 2004-05-10 Matthias Clasen <mclasen@redhat.com>
606 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
608 * gdk/gdkdisplay.c (singlehead_...):
609 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
610 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
611 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
613 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
614 note about COLUMN_FIXED restriction.
616 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
617 Set the entry in the default handler of the ::match-selected signal.
620 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
621 do the move-selected-item below pointer thingie, do the
622 place-below-or-above one.
624 * tests/testentrycompletion.c: Make the second example use the
625 ::match-selected signal to make it actually work.
627 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
628 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
629 mode. (#127648, Dave Bordoley)
632 * gtk/gtktreeview.c: Add a new property "hover_selection", which
633 when TRUE makes the selection follow the mouse. Also add setter
634 and getter for the fixed_height property.
636 2004-05-10 Matthias Clasen <mclasen@redhat.com>
638 * gtk/gtkcombobox.c (gtk_combo_box_popup)
639 (gtk_combo_box_menu_button_press): Make sure the menu pops up
640 as wide as the combobox. (#59660, Havoc Pennington)
642 2004-05-10 Matthias Clasen <mclasen@redhat.com>
645 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
646 mode). Add a new property, add-tearoffs, for this. (#135956)
648 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
649 default button. (#118921)
651 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
653 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
654 that emits the grab notify signal.
656 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
658 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
660 * gtk/gtkmenu.c: Make destruction of a torn off menu work
663 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
667 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
668 Allow to suppress the stock accelerator by using "". (#142196,
671 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
675 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
676 In list mode, accept the same mouse/wheel bindings on
677 the cellview as on the button. (#136967)
679 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
681 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
682 cached icons. (#135888, Crispin Flowerday)
684 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
686 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
687 that we actually return menus for nodes of type menu, not the
688 menuitems they're attached to.
690 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
692 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
693 Add a note regarding UTF-8 requirements, proposed by
694 Mariano Suárez-Alvarez.
696 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
698 * gtk/gtktearoffmenuitem.h:
699 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
700 into the GtkTearoffMenuItem struct, since it is used
701 by the Gimp, and keep it synchronized with the
702 tearoff_state property of the parent menu.
704 2004-05-08 Hans Breuer <hans@breuer.org>
706 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
707 create the correct mask for 'pseudo mime' icons
709 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
710 take focus_on_map into account
712 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
714 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
715 ... must return a value
717 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
719 2004-05-07 Matthias Clasen <mclasen@redhat.com>
721 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
722 draw over the focus rectangle.
724 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
725 standard focus style. (#63071, Bill Haneman, idea for new
726 style by Owen Taylor)
728 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
729 focus on the colorwheel via details.
731 2004-05-06 Matthias Clasen <mclasen@redhat.com>
735 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
736 this no longer needed signal handler. (#141817, Paul Pogonyshev)
738 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
740 * gtk/gtktearoffmenuitem.h:
741 * gtk/gtktearoffmenuitem.c: Make the tearoff
742 functionality model/view, the tearoffmenuitem being
743 the view and the tearoff_state property of the menu
744 being the model. (#101185, Owen Taylor)
746 * gtk/gtkmenu.c: Add a tearoff_state property.
748 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
752 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
753 popup the submenu for items in torn off menus. (#122051)
755 2004-05-06 Sven Neumann <sven@gimp.org>
757 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
758 position the title lable next to the arrow just as we do for LTR
759 rendering. Fixes bug #141825.
761 2004-05-06 Matthias Clasen <mclasen@redhat.com>
763 * docs/RELEASE-HOWTO: Document the new policy of
764 bumping version numbers after release.
766 * configure.in: Bump version number to 2.5.0.
768 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
771 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
774 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
776 * gtk/gtkactiongroup.h:
777 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
778 New function to translate a string with translate_func.
781 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
783 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
784 (gtk_combo_box_get_row_span_column):
785 (gtk_combo_box_get_column_span_column): Add missing getters
786 for readwrite properies. (#135649)
788 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
791 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
792 Add gtk_combo_box_get_active_text() convenience
793 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
795 2004-05-05 Elijah Newren <newren@math.utah.edu>
797 Changes to support do-not-focus-on-map hint in conjunction with
798 _NET_WM_USER_TIME (#115650):
800 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
803 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
806 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
807 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
809 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
810 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
811 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
812 Initialize the focus_on_map field to TRUE.
814 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
815 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
816 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
817 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
818 Implementations for the various backends. The Win32 and linux-fb
819 implementations set the focus_on_map field, but don't use it yet
820 to actually implement noinput windows. The X implementation sets
821 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
823 * gdk/x11/gdkwindow-x11.h:
824 * gdk/x11/gdkevents-x11.c (set_user_time):
825 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
826 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
827 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
828 since we want that function to be part of the public API.
830 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
834 * gtk/gtkiconfactory.c (icon_source_clear): Don't
835 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
837 2004-05-05 Matthias Clasen <mclasen@redhat.com>
841 * gtk/gtkuimanager.c (print_node): Make the output
842 parseable. (#141929, Sven Neumann)
844 2004-05-05 Tor Lillqvist <tml@iki.fi>
846 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
847 multi-monitor offset. (#141842, John Ehresman)
849 2004-05-04 Federico Mena Quintero <federico@ximian.com>
851 Fixes #139562, based on a patch by Christian Neumair.
853 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
854 a filter_combo_hbox field to contain the filter combo.
855 (show_filters): Show/hide the filter_combo_hbox.
856 (create_filename_entry_and_filter_combo): Removed.
857 (file_pane_create): Create the filter_combo_hbox here.
859 2004-05-04 Matthias Clasen <mclasen@redhat.com>
861 * modules/input/gtkimcontextxim.c: Fix the recent
862 string_conversion_callback change to work on
863 Solaris. (#141190, Padraig O'Briain)
865 * gtk/gtkselection.c: Disable debug logging again.
867 2004-05-03 Matthias Clasen <mclasen@redhat.com>
869 * gtk/gtkselection.c: Make the chunk size for
870 incremental transfers depend on the maximal request
871 size, capped at 256k. This should allow most selections
872 to be transferred nonincrementally, avoiding many
873 roundtrips and protocol overhead.
875 2004-05-03 Federico Mena Quintero <federico@ximian.com>
877 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
878 g_signal_new() correctly and initialize the signal fields. Fixes
879 #141749; patch based on Michael Natterer's.
881 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
883 * gtk/gtkselection.c (_gtk_selection_request): Fix
884 a debug message to show correct information.
885 (_gtk_selection_incr_event): Make INCRemental transfer
886 of MULTIPLE targets work. This was broken since 1997!
888 2004-05-02 Hans Breuer <hans@breuer.org>
890 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
891 modify the passed in GdkSegment(s) in place, we may get
892 them again to draw at the same place. Fixes bug #129095,
894 (draw_segments) draw the end pixel again to get the
895 pixmap mask right, fixes bug #126710, #130202
897 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
898 fixes bug #106013, John Ehresman
900 * gtk/makefile.msc.in : don't try to link gtk.res but
901 use gtk-win32.res (as supposed to be fixed below :)
903 2004-05-01 Hans Breuer <hans@breuer.org>
905 * tests/Makefile.am : tests/makefile.msc is in CVS for
906 a long time, finally added to EXTRA_DIST : fixes bug
907 #141334, John Ehresman
909 2004-04-30 Matthias Clasen <mclasen@redhat.com>
911 * === Released 2.4.1 ===
913 * configure.in: Version 2.4.1, interface age 1.
917 2004-04-29 Federico Mena Quintero <federico@ximian.com>
921 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
922 function; moved the code over from
923 remove_bookmark_button_clicked_cb().
924 (remove_selected_bookmarks): Now, getting a non-removable bookmark
925 is not an error, as we may be called as a result of hitting the
927 (shortcuts_key_press_event_cb): New handler; delete the bookmark
928 if the user presses Backspace, Delete, or KP_Delete.
930 2004-04-29 Matthias Clasen <mclasen@redhat.com>
932 * gtk/gtkaction.c (closure_accel_activate): Use
933 _gtk_action_emit_activate() instead of directly
934 emitting the activate signal. (#141429, Jody Goldberg)
936 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
937 Warn people when the accelerator can not be
938 parsed. (#141429, Jody Goldberg)
940 2004-04-29 Matthias Clasen <mclasen@redhat.com>
942 * tests/testentrycompletion.c (main): Add a missing
943 cat. (#141070, Chris Sherlock)
945 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
946 variable. (#141022, Chris Sherlock)
948 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
949 cast. (#141013, Chris Sherlock)
951 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
952 unused variable. (#141011, Chris Sherlock)
954 2004-04-29 Tor Lillqvist <tml@iki.fi>
956 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
957 leak. (#140775, John Ehresman)
959 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
961 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
962 to index the cached gcs, not depth. (#139494)
964 2004-04-28 Matthias Clasen <mclasen@redhat.com>
966 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
968 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
970 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
971 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
973 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
975 Patch to add support for string conversion callbacks to
976 GtkIMContextXIM (#101814)
978 * modules/input/gtkimcontextxim.c: Set the string conversion callback
979 if supported by the XIC.
981 (struct _GtkIMContextXIM): Add string_conversion_callback member.
983 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
984 whether string conversion callback is supported.
986 (gtk_im_context_get_ic, +set_string_conversion_callback,
987 +string_conversion_callback): Also initialize string conversion
988 callback, if supported, along with the IC initialization.
990 * modules/input/imxim.c: Make "xim" module default for Thai as well.
992 2004-04-23 Matthias Clasen <mclasen@redhat.com>
994 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
995 initialize targets. (#139883, John Finlay)
997 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
999 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
1000 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
1003 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
1004 Remove an excessive g_return_if_fail().
1006 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
1008 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1009 _-prefix calls of gdk_x11_window_set_user_time().
1011 2004-04-22 Matthias Clasen <mclasen@redhat.com>
1013 * gtk/gtkuimanager.c (update_node): Make sure the separators
1014 used to demarkate placeholder ends don't show up on
1015 show_all(). (#140496, Murray Cumming)
1017 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
1018 work with negative increments. (#137975, Tim Gerla)
1020 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1022 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
1023 gtk_tool_button_set_icon_widget): Remove the old widget from the
1024 tool button before overwriting it with the new widget.
1026 (#140508, Todd Goyen)
1028 2004-04-22 Tor Lillqvist <tml@iki.fi>
1030 Fix the file chooser on Windows. I can't make it misbehave or
1031 crash any more now. But presumably there are still corner cases
1032 not handled. I haven't really checked behaviour of UNC paths, for
1035 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
1036 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
1039 (gtk_file_system_win32_get_parent): Like the Unix version, assert
1040 filename is absolute, and avoid one unnecessary string allocation
1043 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
1044 letters more correctly.
1046 (gtk_file_system_win32_render_icon): Assure correct syntax is used
1047 for root folder of a drive. (#137962, Morten Welinder)
1049 (filename_is_some_root): New function that accepts also root
1050 without any drive specified.
1052 (filename_is_drive_root): Rename from filename_is_root.
1054 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
1057 2004-04-21 Matthias Clasen <mclasen@redhat.com>
1059 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
1060 completion window if there are no completions anymore.
1062 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1063 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
1064 It doesn't like that. (#140642, Christian Persch)
1066 * demos/gtk-demo/expander.c (do_expander): A new demo.
1068 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
1070 2004-04-20 Matthias Clasen <mclasen@redhat.com>
1072 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
1073 sure anchored children get size allocated, even if the layout
1074 is valid. (#122323, Andrew E. Makeev)
1075 (gtk_text_view_scroll_pages):
1076 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
1077 if we already have pending scrolls. Bandaid fix for #78513.
1079 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
1081 * INSTALL.in: Update libpng and libjpeg URLs, remove
1082 note about building without since that's not the normal
1085 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
1087 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
1088 handling of SVG/non-SVG unthemed icons.
1090 2004-04-19 Morten Welinder <terra@gnome.org>
1092 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
1095 2004-04-19 Matthias Clasen <mclasen@redhat.com>
1097 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1098 Don't stop the iteration up to the tag_root too
1099 early. (#109945, Dongho Shin)
1101 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1103 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
1104 gdk_keymap_translate_keyboard_state() handle NULL
1105 keymaps. (#139715, Torsten Schoenfeld).
1107 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1109 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
1110 reported by Pedro RODRIGUEZ, about compilation problems when
1111 Xcursor is installed in a non-standard location.
1113 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1115 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
1118 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
1119 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
1121 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
1123 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
1126 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
1127 property on user interaction.
1129 2004-04-15 Federico Mena Quintero <federico@ximian.com>
1131 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
1132 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
1134 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
1135 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
1138 2004-04-15 Matthias Clasen <mclasen@redhat.com>
1140 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1141 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
1143 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1145 * gtk/gtkcombobox.c:
1147 Make all style properties readonly.
1149 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1151 * gtk/gtkcolorsel.c: Add a11y relations between the color
1152 wheel and the spin buttons. (#132745, Padraig O'Briain)
1154 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
1155 the meaning of size == -1.
1157 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
1158 a size of -1. (#137436, Brian Cameron)
1160 * gtk/gtkcombobox.c: Make the arrow and separator regular
1161 children of an hbox inside the button, and propagate state
1162 changes from the button to the cell view. (part of the fix
1163 for #138650, should also fix #137535)
1165 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
1166 state to gtk_cell_renderer_render() when prelighted. (part
1167 of the fix for #138650)
1169 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1170 Use PRELIGHT state when appropriate. (part of the fix for
1173 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
1174 out warnings if called before the combo box is
1175 realized. (#139742, Philip Langdale)
1177 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
1179 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
1182 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
1184 * gtk/gtkpathbar.c (make_directory_button): remove spurious
1187 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
1189 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
1190 make the buttons sized by a bold label. This makes the text
1191 'swim' a little, but stops the buttons from resizing, #137210
1193 2004-04-13 Matthias Clasen <mclasen@redhat.com>
1195 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
1197 (start_element_handler): Accept separators without unique
1198 names. (#133302, Anders Carlsson)
1200 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
1201 possible accelerator gotcha when using this function. (#139641,
1204 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
1205 list nodes. (#138862, Morten Welinder)
1207 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
1209 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
1211 (gtk_tree_view_button_press): If we activated the row we don't
1212 want to grab focus back, as moving focus to another widget is
1213 pretty common, #138458
1215 2004-04-12 Federico Mena Quintero <federico@ximian.com>
1217 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
1218 documentation to all the signals.
1220 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
1222 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
1223 model if it is NULL. (#139770)
1225 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
1227 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
1228 a shadow inside the scrolled window, add it around the vbox.
1230 * gtk/gtkentryprivate.h:
1231 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1232 Return a boolean indicating whether the popup is positioned above
1233 or below. Scroll the completions to the beginning or the end,
1234 depending on the positioning.
1236 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
1237 wrap around in the entry completion popup, and allow GDK_UP to
1238 enter the popup. (#137440)
1240 2004-04-12 Matthias Clasen <mclasen@redhat.com>
1242 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
1243 there before using it.
1245 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
1247 * gtk/gtktreeprivate.h: Moved search entries into priv data.
1249 * gtk/gtktreeview.c: Prep for type-ahead support.
1251 (gtk_tree_view_destroy): Destroy the search window explicitly.
1252 (gtk_tree_view_key_press): Minor change; prep for type-ahead
1253 (gtk_tree_view_ensure_interactive_directory): New function
1254 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
1255 (gtk_tree_view_real_start_interactive_search): rework
1256 (gtk_tree_view_search_dialog_hide): ditto
1257 (gtk_tree_view_search_delete_event): ditto
1258 (gtk_tree_view_search_button_press_event): ditto
1259 (gtk_tree_view_search_key_press_event): ditto
1260 (gtk_tree_view_search_move): ditto
1261 (gtk_tree_view_search_init): ditto
1263 * gtk/gtktreeviewcolumn.c:
1264 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
1266 * tests/testfilechooser.c: (main): change
1268 2004-04-11 Hans Breuer <hans@breuer.org>
1270 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
1271 the real fix would involve just another small API breakage,
1272 i.e. gdk_spawn_* using GPid not just gint.
1274 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
1276 2004-04-10 Tor Lillqvist <tml@iki.fi>
1278 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
1279 If both Shift and CapsLock pressed, ignore the shift only for
1280 letters (that would have been affected by the CapsLock). (#139095)
1282 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
1283 seems to be even buggier now than it used to be. (#138341)
1284 Initialize _gdk_input_ignore_wintab to TRUE.
1286 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
1287 GDK_USE_WINTAB environment variable to turn on tablet support.
1289 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
1291 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
1292 (gtk_ui_manager_remove_action_group): Terminate
1293 g_object_[dis]connect() calls with NULL instead of 0.
1296 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
1298 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
1300 2004-04-07 Federico Mena Quintero <federico@ximian.com>
1304 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
1305 passed-in 'str' is not NULL.
1307 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
1308 expands "~/" or "~foo/" at the beginning of a filename.
1309 (gtk_file_system_unix_parse): Use expand_tilde() before doing
1312 * gtk/gtkfilechooserentry.c
1313 (gtk_file_chooser_entry_maybe_update_directory): Take in a
1314 force_reload argument.
1315 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
1316 returns an error, set the file_part_pos to -1.
1317 (load_directory_callback): Only populate the model if the
1318 file_part_pos is not -1.
1320 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
1322 * configure.in: Added Icelandic (is) to ALL_LINGUAS
1324 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1326 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
1327 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
1329 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
1330 for G_DIR_SEPARATOR in the display_name, and err out if it is
1331 present; use the same error message as Nautilus. Fixes #136467.
1333 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
1334 new-folder button say "Create Fo_lder" rather than "Create
1335 _Folder", so that the mnemonic doesn't conflict with the "Save in
1336 _folder" label. Fixes #136975.
1338 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1340 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
1341 buttons. Also, free them correctly upon failure. Based on a
1342 patch by Morten Welinder, fixes #137956.
1344 2004-04-05 Anders Carlsson <andersca@gnome.org>
1346 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
1348 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
1350 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
1351 correctly for fixed height when inserting a node, #138082
1353 2004-04-01 Federico Mena Quintero <federico@ximian.com>
1357 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
1358 "child_is_hidden" boolean argument to the "path-clicked" signal.
1360 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
1362 (make_directory_button): Take a file_is_hidden argument; put it in
1364 (_gtk_path_bar_set_path): See whether each path component path is
1366 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
1367 "path-clicked" signal.
1368 (button_clicked_cb): See if the downwards button represents a
1369 hidden file for the file_is_hidden argument in the signal
1372 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
1374 * gtk/gtkfilechooserdefault.c
1375 (gtk_file_chooser_default_select_path): If we fail to switch
1376 folders, don't try to select the path in the file system model.
1377 Also, return the result from _gtk_file_system_model_path_do().
1378 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
1379 file system model if we are asked to select a hidden file.
1380 (path_bar_clicked): Show hidden files based on whether the
1381 immediate downwards folder in the path bar is a hidden file
1383 (struct _GtkFileChooserDefault): Added fields
1384 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
1385 (create_file_list): Set an object data key of
1386 "GtkFileChooserDefault" on the tree view so that we can find the
1387 impl from the popup menu callbacks. Also, hook up to the
1388 "button-press-event" and "popup-menu" signals in the file list to
1389 bring up a popup menu.
1390 (list_popup_menu_cb): New callback.
1391 (list_button_press_event_cb): New callback.
1395 * gtk/gtkfilesystemmodel.c
1396 (_gtk_file_system_model_new): Oops, connect_object to
1399 2004-03-31 Tor Lillqvist <tml@iki.fi>
1401 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
1402 for native Win32. (#136559, J. Ali Harlow)
1404 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
1405 angles. Thanks to Tim Newsham.
1407 2004-03-29 Federico Mena Quintero <federico@ximian.com>
1411 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1412 for an ::is_finished_loading() method and a ::finished_loading()
1413 signal at the end of the struct.
1415 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1416 "finished-loading" signal.
1417 (gtk_file_folder_is_finished_loading): New function.
1419 * gtk/gtkfilesystemunix.c
1420 (gtk_file_folder_unix_is_finished_loading): Implement.
1422 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1423 slot for a "finished-loading" signal.
1424 (gtk_file_system_model_class_init): Create the "finished-loading"
1426 (struct _GtkFileSystemModel): New field
1427 idle_finished_loading_source. We emit the "finished-loading"
1428 signal in an idle if the root folder was done loading right in
1429 _gtk_file_system_model_new(), so that the caller has a chance to
1430 connect to the signal.
1431 (_gtk_file_system_model_new): Connect to the normal signals of the
1432 folder even if the initial _list_children() fails. Also, see if
1433 the folder is finished loading; connect to the "finished-loading"
1435 (gtk_file_system_model_finalize): Remove the idle handler.
1437 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1438 and connect to the model's "finished-loading" signal.
1439 (get_toplevel): New helper function.
1440 (error_message): Use get_toplevel().
1441 (trap_activate_cb): Likewise.
1442 (location_popup_handler): Likewise.
1443 (set_busy_cursor): New function.
1444 (browse_files_model_finished_loading_cb): New callback.
1446 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1448 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
1449 file under the cursor; we don't need the logic from
1450 GtkFileSelection after all. Fixes #132255.
1452 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1454 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
1455 location entry with the display name of the file under the cursor
1456 for Open mode, or the typed filename in Save mode.
1458 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1460 * gtk/gtkfilesystemwin32.c
1461 (filename_is_root): Bare drive designators (eg., "c:") are
1462 no longer considered as root filenames. Fixed #137942
1464 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1466 * gtk/gtkfilesystemwin32.c
1467 (gtk_file_system_win32_create_folder): Invert test for error in
1468 mkdir. Fixes #137945
1470 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1472 Fixed #138004 using Federico's code from #132327.
1474 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
1475 folder_hash field to keep a list of live folder objects.
1476 (gtk_file_system_win32_init): Create the folder_hash.
1477 (gtk_file_system_win32_finalize): Destroy the folder_hash.
1478 (gtk_file_system_win32_get_folder): Ref and return an existing
1479 folder if we have it around, otherwise return a new folder object.
1480 (struct _GtkFileFolderWin32): Add a field for the parent file system.
1481 (gtk_file_folder_win32_finalize): Remove the folder from the file
1482 system's hash table.
1483 (gtk_file_system_win32_create_folder): Emit "files-added" on the
1484 newly-created folder's parent. Fixes #138004.
1486 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1488 * gtk/gtkfilesystemwin32.c
1489 (gtk_file_system_win32_get_folder): Test that path is actually
1490 a directory and throw error if not. Fixed bug #137950
1492 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
1494 * gtk/gtkfilesystemwin32.c
1495 (gtk_file_system_win32_volume_get_display_name): Ignore empty
1496 volume labels; assume that GetVolumeInformation would fail if
1497 GetVolumeInformationW does; catches a small memory leak;
1498 pass the buffer size to GetVolumeInformationW in wide
1499 characters instead of bytes. Fixes bug #137543
1500 (list_volumes): Cope with the theoretical possibility of
1501 more than 26 logical drives. Fixes bug #137940
1502 (bookmarks_serialize): Now actually removes bookmarks.
1505 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
1507 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
1509 2004-03-21 Tor Lillqvist <tml@iki.fi>
1511 * gtk/gtkfilesystemwin32.c
1512 (gtk_file_system_win32_volume_get_base_path): Include the
1513 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
1514 NULL for a volume base path, as g_filename_to_uri() requires an
1515 absolute path, and just a drive letter and colon isn't. (#137543)
1517 2004-03-20 Hans Breuer <hans@breuer.org>
1519 * gtk/gtkfilesystemwin32.c : applied the undisputable and
1520 required [due to recent gtkfilesystem internal api semantic
1521 changes] part of patches to fix bug #137543 (Tor Lillqvist,
1524 * gdk/gdkevents-win32.c (handle_configure_event) :
1525 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
1526 GdkWindowObject::x, y with screen coords to make
1527 gdk_window_get_position () return the right thing and thus fix
1528 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
1530 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1532 * Revert the patch to #137520, as 2.4.1 is for conservative bug
1533 fixes only. The patch is attached to the bug report, for
1536 2004-03-19 Morten Welinder <terra@gnome.org>
1538 * gtk/gtkfilechooserdefault.c
1539 (gtk_file_chooser_default_set_current_folder): Test existance of
1540 the path after checking for locality, if needed.
1542 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1546 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1547 for an ::is_finished_loading() method and a ::finished_loading()
1548 signal at the end of the struct.
1550 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1551 "finished-loading" signal.
1552 (gtk_file_folder_is_finished_loading): New function.
1554 * gtk/gtkfilesystemunix.c
1555 (gtk_file_folder_unix_is_finished_loading): Implement.
1557 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1558 slot for a "finished-loading" signal.
1559 (gtk_file_system_model_class_init): Create the "finished-loading"
1561 (struct _GtkFileSystemModel): New field
1562 idle_finished_loading_source. We emit the "finished-loading"
1563 signal in an idle if the root folder was done loading right in
1564 _gtk_file_system_model_new(), so that the caller has a chance to
1565 connect to the signal.
1566 (_gtk_file_system_model_new): Connect to the normal signals of the
1567 folder even if the initial _list_children() fails. Also, see if
1568 the folder is finished loading; connect to the "finished-loading"
1570 (gtk_file_system_model_finalize): Remove the idle handler.
1572 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1573 and connect to the model's "finished-loading" signal.
1574 (get_toplevel): New helper function.
1575 (error_message): Use get_toplevel().
1576 (trap_activate_cb): Likewise.
1577 (location_popup_handler): Likewise.
1578 (set_busy_cursor): New function.
1579 (browse_files_model_finished_loading_cb): New callback.
1581 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
1583 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
1584 eventbox for expander. (#137564, reported by
1587 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
1589 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
1591 2004-03-17 Morten Welinder <terra@gnome.org>
1593 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
1594 volumes not actually put into the shortcut list.
1596 * tests/prop-editor.c (object_changed): Plug leak.
1598 * tests/testfilechooser.c (main): Plug some leaks and expose
1601 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
1602 object. Fixed #136652.
1604 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
1605 have no screen. Fixes #137260.
1606 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
1607 thereby fixing leak. Fixes #137259.
1609 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
1610 slider buttons have been destroyed.
1611 (gtk_path_bar_remove): Make this work for slider buttons too.
1614 2004-03-15 Morten Welinder <terra@gnome.org>
1616 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
1617 Sanitize and plug leak.
1618 (check_icon_theme): Only do something if the widget has a screen.
1620 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
1622 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1623 Move the repositioning logic from _gtk_entry_completion() popup
1624 over here. Fixes #137355, reported by Niklas Knutsson.