1 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
3 Fix for #136496, Pawel Salek:
5 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
6 a node when it changes in fixed_height mode.
8 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
11 2004-07-06 Matthias Clasen <mclasen@redhat.com>
13 * gtk/gtkmenu.c (gtk_menu_position): Make sure
14 private->monitor_num is a valid monitor number before
15 using it. (#139187, Michael Natterer)
17 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
19 * gtk/gtkfilechooserdefault.c (popup_position_func):
20 * gtk/gtkentry.c (popup_position_func):
21 * gtk/gtktextview.c (popup_position_func): Improve positioning
22 of keyboard-activated menus with Xinerama.
24 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
26 * gtk/gtkuimanager.c (do_updates):
27 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
28 when called from an idle handler. (#145429, Jan-Marek Glogowski)
30 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
32 * gtk/gtkfilechooserutils.c (delegate_notify): Use
33 the less efficient g_object_interface_find_property () instead
34 of the param_id range check, since the GParamSpecs we're
35 dealing with are the overridden onces on the interface, whose
36 param_id is always zero. (#145312, Alex Roitman, fix proposed
39 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
41 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
42 virtual method of GtkContainer.
43 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
44 method slot of the container class.
46 2004-07-05 Anders Carlsson <andersca@gnome.org>
48 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
50 Use gint, not int in gtk_icon_view_set_markup_column,
53 2004-07-05 Anders Carlsson <andersca@gnome.org>
55 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
56 (gtk_icon_view_real_select_cursor_item),
57 (gtk_icon_view_real_activate_cursor_item):
59 Add an "activate_cursor_item" action signal
60 and bind it to the return key.
62 2004-07-04 Anders Carlsson <andersca@gnome.org>
64 * demos/gtk-demo/Makefile.am:
65 * demos/gtk-demo/gnome-fs-directory.png:
66 * demos/gtk-demo/gnome-fs-regular.png:
67 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
68 (sort_func), (create_store), (item_activated), (up_clicked),
69 (home_clicked), (do_iconview):
70 Add a simple file browser based on the icon view.
75 * gtk/gtkiconview.c: (gtk_icon_view_layout),
76 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
77 Fix a few bugs discovered while writing the demo.
79 2004-07-04 Anders Carlsson <andersca@gnome.org>
84 Add GtkIconView to the build, remove debugging output.
86 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
88 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
89 (gtk_calendar_drag_data_received): Fix off-by-one error.
90 GDate month is one-based and GtkCalendar month is zero-based.
91 (#145134, William Jon McCann)
93 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
95 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
96 somebody tries to move a node after itself in a list of
97 length 1. (#145291, Sampo Nurmentaus)
99 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
101 * docs/faq/gtk-faq.sgml:
102 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
105 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
107 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
108 and current_height to 0 when ending the embedding. (#143675,
111 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
113 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
114 to the right end of the entry text, even if it ends in combining
115 marks. (#141728, Theppitak Karoonboonyanan)
117 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
119 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
120 row when unsetting the model. (#138560, Christian Persch)
122 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
124 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
127 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
129 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
130 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
132 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
134 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
135 to the event mask, set a scroll_event handler.
136 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
137 by switching tabs. (#145244, Gabriel de Perthuis)
139 2004-07-02 Anders Carlsson <andersca@gnome.org>
141 * gtk/gtktreeview.c (gtk_tree_view_set_model):
142 Make sure we check for a NULL model first.
144 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
146 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
147 win32 build problem w/o wintab. Fixed #145242
149 2004-06-30 Anders Carlsson <andersca@gnome.org>
151 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
152 g_return_if_fail to make sure that the model is a GtkTreeModel.
154 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
156 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
157 current state, not GTK_STATE_NORMAL
159 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
161 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
163 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
165 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
167 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
168 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
171 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
173 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
174 recursion by resetting icon_set->cache before freeing
175 the cache. (#144947, Tim Janik)
177 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
179 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
180 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
181 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
184 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
186 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
187 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
188 last change in the docs.
190 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
192 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
193 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
194 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
196 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
198 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
199 placement policy for GtkComboBoxEntry to be: if it fits below,
200 place below, if it fits above place above, else place in the
201 larger space and scroll so that the scroll arrow appear at the
202 far end. (#144362, David A. Knight)
204 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
206 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
207 use of &parent_iter. (#145007, John Finlay)
209 2004-06-25 Bastien Nocera <hadess@hadess.net>
211 reviewed by: Matthias Clasen <maclas@gmx.de>
213 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
214 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
215 the number of keysyms per keycode is odd. Fixes #144808.
217 2004-06-25 Matthias Clasen <mclasen@redhat.com>
219 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
220 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
222 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
224 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
225 which was mentioned below.
227 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
229 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
230 string change. (#139503, Baris Cicek)
232 2004-06-22 Federico Mena Quintero <federico@ximian.com>
234 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
235 or an Open stock button for the C-l dialog depending on the action
236 in which the file chooser operates. Fixes #141753.
238 2004-06-22 Federico Mena Quintero <federico@ximian.com>
240 Fixes the GTK+ part of #142308:
242 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
243 Use filename_to_path().
244 (gtk_file_system_unix_uri_to_path): Likewise.
245 (filename_to_path): Use remove_trailing_slash().
247 2004-06-22 Matthias Clasen <mclasen@redhat.com>
249 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
250 for the ::move_cursor signal.
252 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
253 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
256 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
257 this gets defined for all backends, so linux-fb has a
260 * gdk/x11/gdkgc-x11.c:
261 * gdk/gdkgc.c: Move function docs inline, add hints about
262 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
264 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
265 for children of the root. (#139785, Jean-François Wauthy,
266 patch by John Finlay)
268 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
269 fix. (#144750, Jeff Franks)
271 2004-06-21 Michael Natterer <mitch@gimp.org>
274 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
275 function public as _gdk_x11_convert_to_format().
277 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
278 the pixels from the GdkPixbuf when putting them in the
279 Xcursor image. Fixes bug #144350.
281 2004-06-16 Federico Mena Quintero <federico@ximian.com>
283 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
284 visible node, free the old path before creating the new one.
287 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
289 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
290 (#144198, Mariano Suárez-Alvarez)
292 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
294 * gtk/gtkfilechooserdefault.c: Don't use
295 contractions like "don't" or "isn't" in error messages.
296 It isn't nice to use them in log entries either...
297 (#137774, Morten Welinder, patch by Alexander Winston)
299 2004-06-11 Federico Mena Quintero <federico@ximian.com>
303 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
304 Don't ref the editable node.
305 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
306 (_gtk_file_system_model_remove_editable): Ahem, free the node.
308 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
309 Added fields for edited_idle and edited_new_text.
310 (renderer_edited_cb): Queue the
311 creation of the folder in an idle handler.
312 (renderer_editing_canceled_cb): Likewise for the cancellation.
313 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
315 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
317 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
319 2004-06-10 Federico Mena Quintero <federico@ximian.com>
321 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
323 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
324 Refer to gtk_file_chooser_add_shortcut_folder().
325 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
326 gtk_file_chooser_add_shortcut_folder_uri().
328 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
330 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
331 the drag before focusing the selected.day.
332 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
333 a beginning drag if the widget becomes insensitive.
335 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
337 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
338 spinning before calling arrow_action(), so that a signal
339 handler triggered from arrow_action() has a chance to
340 stop the spinning. (#143966, Davyd Madeley)
342 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
344 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
345 typo. (#144070, Kent Sandvik)
347 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
349 * gtk/gtkmenu.c: Revert the "drag select" part of
352 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
354 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
355 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
357 2004-06-07 Federico Mena Quintero <federico@ximian.com>
359 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
360 from 2003/Sep/12. This kept DnD in tree views within modal
361 dialogs from working, which is especially bad for the file
362 chooser. Fixes #135168.
364 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
366 Make the entry context menu work in editable text cells. The changes
367 are based on a patch by Kristian Rietveld, which implemented an
368 approach outlined by Owen Taylor. (#50075)
370 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
371 Ignore focus out if the entry menu is posted.
372 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
373 posted, and set up a signal handler to clear the flag if the menu
375 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
376 set up a timeout to stop editing if the focus is lost.
377 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
378 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
379 signal on the entry and keep a pointer to the entry.
380 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
381 clear the pointer to the entry.
383 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
385 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
386 of the ::language property. (#143802, Owen Taylor)
388 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
390 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
391 (gtk_entry_completion_list_enter_notify),
392 (gtk_entry_completion_list_motion_notify),
393 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
394 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
395 use it as in the menu code to avoid the initial selection if
396 the window pops up under the pointer. (Anders Carlsson)
398 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
400 * tests/testmerge.c: Add a checkbox to queue an
401 merge/unmerge. Patch from Matthias Clasen.
403 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
405 (rebuild_menu): New function that rebuilds the overflow menu and
406 makes sure it doesn't start or end with a separator.
407 (toolbar_content_new_tool_item)
408 (toolbar_content_remove)
409 (toolbar_content_new_compatibility): Set the rebuild_needed flag
410 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
411 have actually overflown an item with a proxy menu item. Also make
412 sure we rebuild the menu if needed.
414 Fix #125504, #142377, #143463
416 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
417 Obey the "priv->draw" flag. (#143692)
419 2004-06-04 Matthias Clasen <mclasen@redhat.com>
421 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
422 quirk in the button size allocation code.
424 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
425 requested for drawing the focus indicator to the child in the
426 !CAN_FOCUS case. This should fix issues which the Gimp has with
427 the button allocation changes in 2.4.2.
429 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
431 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
432 length of the entry contents in characters, not in bytes.
434 * gtk/gtkentry.c (paste_received): Don't pop up the completion
435 window on paste, noticed by Anders Carlsson.
437 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
439 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
440 values and default value for the ::active property. (#143669,
443 2004-06-03 Michael Natterer <mitch@gimp.org>
445 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
446 instead of accessing item->image->allocation.width/height
447 directly. Makes widgets which only have a requisition set using
448 gtk_widget_set_size_request() work and fixes bug #142789.
450 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
452 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
453 of sticky right click menus to return.
455 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
457 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
458 better handle the "click" case. bug Better fix for #141169.
460 2004-06-02 Federico Mena Quintero <federico@ximian.com>
462 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
463 model is empty. Fixes #143536.
465 2004-06-02 Matthias Clasen <mclasen@redhat.com>
467 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
468 close the dialog on focus out of the size entry. (#143505,
471 2004-06-02 Federico Mena Quintero <federico@ximian.com>
475 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
476 (gtk_fnmatch_intern): Likewise; also implement this option.
478 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
480 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
481 no_leading_period argument of _gtk_fnmatch().
482 (attempt_file_completion): Likewise.
484 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
485 no_leading_period argument of _gtk_fnmatch().
487 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
489 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
492 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
494 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
495 allow unless selection mode is multiple. (#142634, John Finlay)
497 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
501 * gtk/gtkentrycompletion.h:
502 * gtk/gtkentrycompletion.c:
504 * gtk/gtkcombobox.c: Rename function parameters from
505 index to index_ to prevent clash with BSD index(). (#143001)
507 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
509 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
510 NULL on an accel label. (#139641, Sam Stephenson, patch by
513 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
515 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
516 lookup finding icons in the wrong prefix. (#143328,
519 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
523 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
524 only stay up if you release within 500 milliseconds.
525 (gtk_menu_shell_button_press): Set the activate_time to the event
526 time when a button is pressed.
528 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
529 Interprete button releases as activate when we have seen both an
530 enter an a motion event.
532 2004-06-01 Federico Mena Quintero <federico@ximian.com>
534 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
535 dummy node if there is no parent node. Fixes #143362.
537 2004-05-31 Federico Mena Quintero <federico@ximian.com>
539 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
540 newly-created folder. Fixes #138932.
541 (trap_activate_cb): Only return TRUE if we did handle the event.
542 Fixes #143359; patch by jylefort@brutele.be.
544 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
546 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
547 docs. (#142892, Tommi Komulainen)
549 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
551 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
552 parent is minimized, porting the fix from 1.2. (#1923, #57182)
554 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
556 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
557 unmapped windows work.
559 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
561 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
564 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
566 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
567 Refer to ::update-preview, not ::selection-changed.
569 2004-05-29 Christian Rose <menthos@menthos.com>
571 * configure.in: Added "tk" to ALL_LINGUAS.
573 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
575 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
576 messages for common problems. (#137974, Owen Taylor)
578 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
580 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
581 errors. (#143337, Billy Biggs)
583 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
585 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
586 bits within visual->depth that aren't used for color to
587 1s, in case they are alpha.
589 2004-05-27 Anders Carlsson <andersca@gnome.org>
591 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
592 Make separator rows insensitive.
594 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
596 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
599 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
601 * gtk/gtkentrycompletion.h:
602 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
603 Getter for text_column. Also make ::text_column a property.
605 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
607 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
609 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
611 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
612 signal if the box exists.
614 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
616 Support insensitive cells in tree views and combo boxes:
618 * gtk/gtkcellrenderer.h:
619 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
621 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
622 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
623 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
624 Support drawing insensitive.
627 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
628 function to obtain the cell renderers from a cell view. Also
629 export gtk_cell_view_set_cell_data().
631 * gtk/gtktreeselection.c (tree_column_is_sensitive):
632 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
633 to determine whether all visible cells in a row are insensitive
634 and whether a row is selectable. A row is not selectable if the
635 user function says so or if all visible cells are insensitive.
636 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
637 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
638 Use row_is_selectable().
640 * gtk/gtkcombobox.c (row_is_sensitive):
641 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
642 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
643 to determine row sensitivity in menu or list mode.
645 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
646 to set up sensitivity menu items from the underlying rows.
648 * gtk/gtkcombobox.c (gtk_combo_box_popup):
649 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
650 update_menu_sensitivity().
652 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
655 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
658 * tests/testcombo.c (main): Make some rows insensitive.
660 2004-05-26 Robert Ögren <gtk@roboros.com>
662 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
663 modifiers (shift, ctrl etc) in button and motion events from the
666 2004-05-26 Robert Ögren <gtk@roboros.com>
668 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
669 implementation for extended input devices using last known
670 device state (#143237)
672 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
674 * gtk/gtkframe.c: Move docs inline, fixing them on the
675 way. (#143029, Steve Chaplin)
677 2004-05-11 Robert Ögren <gtk@roboros.com>
679 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
680 events to windows that want extended input events. (#142943)
681 (gdk_event_translate): Move check for extended input devices to
682 propagate, new parameter to propagate.
683 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
684 _gdk_input_(un)grab_pointer. (#142943)
686 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
687 input grab. [Fix missing update of impl in "dijkstra" event
688 propagation loop] Drop the parallel "impl" pointer, just use a
689 cast. Don't propagate beyond windows that want normal input
691 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
692 implementation of input grab. (#142943)
694 2004-05-22 Tor Lillqvist <tml@iki.fi>
696 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
697 line. (Spotted by Benoît Carpentier.)
699 2004-05-18 Matthias Clasen <mclasen@redhat.com>
701 * configure.in: Check for XFIXES extension.
703 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
704 a gboolean have_xfixes member.
706 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
707 XFIXES events and set have_xfixes.
709 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
710 (GdkEventOwnerChange): New event struct for owner change events.
711 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
713 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
714 XFixesSelectionNotify events into GdkEventOwnerChange events.
717 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
718 (gdk_display_request_selection_notification): New api
719 to support selection ownership notification.
721 * gtk/gtkclipboard.h:
722 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
723 api to handle owner change events.
724 (clipboard_peek): Refactored out the body of
725 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
727 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
728 by calling _gtk_clipboard_handle_event().
730 2004-05-18 Matthias Clasen <mclasen@redhat.com>
732 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
733 the P_() macros ourselves.
735 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
736 Restrict the width of the popup to be no larger than the
737 monitor. (#142678, DmD Ljungmark)
739 * gtk/gtkbutton.c: Go back to the initial fix for the
740 focus-overdrawing problem, which was actually correct
741 according to docs/widget_geometry.txt.
743 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
744 arrow size from 11 to 15 to compensate for that.
746 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
747 arguments of the ::move-cursor signal. (#142725)
749 2004-05-17 Matthias Clasen <mclasen@redhat.com>
753 * gtk/gtkbutton.c (gtk_button_size_request)
754 (gtk_button_size_allocate, _gtk_button_paint): Allocate
755 space for the focus rectangle only if necessary. (#142668,
758 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
762 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
763 lines. (#142479, Morten Welinder)
765 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
767 * gtk/gtkintl.h (Q_): Add a Q_() macro.
769 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
770 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
771 they are not really needed.
773 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
774 instead of hardwired padding, use Q_() for the default label,
775 compute a reasonable minimal size. (#142571, #142572, #142573,
776 Tommi Komulainen, Christian Persch)
778 2004-05-15 Tor Lillqvist <tml@iki.fi>
780 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
781 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
782 time). It is used by the OLE2_DND code, which is unfinished and
783 presumably horribly broken, but still, let's not make it not
784 compile on purpose. Silence some gcc warnings in the OLE2_DND
787 2004-05-14 Matthias Clasen <mclasen@redhat.com>
789 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
790 New function to go from tree window to tree coordinates, kept
791 static for now until we figure out the multiple coordinate
792 system mess in GtkTreeView API-wise.
793 (gtk_tree_view_scroll_to_cell): Transform the coordinates
794 from tree window to tree coordinates, using the new function.
795 Previously, the x coordinate was wrongly transformed. (#142494)
797 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
800 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
801 modifier bit to mark stock item which need to be freed
802 eventually. (#140654, Michal Pasternak, Scott Tsai)
804 2004-05-11 Robert Ögren <gtk@roboros.com>
806 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
807 call to g_object_ref in Wintab code. (#138341)
809 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
810 including unallocated buffers for event->motion.axes and
811 event->button.axes, unsigned wraparound problem in the code for
812 detecting missing press/release events and assigning min instead
813 of max when setting up axes.
815 2004-05-12 Matthias Clasen <mclasen@redhat.com>
817 * tests/testtreeedit.c: Add a progress column.
819 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
822 * gtk/gtk.h: Include gtkcellrendererprogress.h.
824 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
825 based on the one found in Epiphany.
827 2004-05-11 Michael Natterer <mitch@gimp.org>
829 * gtk/gtkcombobox.c (gtk_combo_box_popup)
830 (gtk_combo_box_menu_button_press): don't allocate the popup
831 smaller than the combobox. Fixes bug #59660.
833 2004-05-11 Matthias Clasen <mclasen@redhat.com>
835 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
836 previous change to this function, clarify the docs instead.
838 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
839 GTK_SELECTION_BROWSE.
841 * gtk/gtktreeview.c: Make hover selection work for
842 GTK_SELECTION_BROWSE as well.
844 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
846 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
847 Document the ::toggled signal.
849 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
851 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
853 2004-05-10 Matthias Clasen <mclasen@redhat.com>
855 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
857 * gdk/gdkdisplay.c (singlehead_...):
858 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
859 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
860 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
862 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
863 note about COLUMN_FIXED restriction.
865 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
866 Set the entry in the default handler of the ::match-selected signal.
869 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
870 do the move-selected-item below pointer thingie, do the
871 place-below-or-above one.
873 * tests/testentrycompletion.c: Make the second example use the
874 ::match-selected signal to make it actually work.
876 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
877 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
878 mode. (#127648, Dave Bordoley)
881 * gtk/gtktreeview.c: Add a new property "hover_selection", which
882 when TRUE makes the selection follow the mouse. Also add setter
883 and getter for the fixed_height property.
885 2004-05-10 Matthias Clasen <mclasen@redhat.com>
887 * gtk/gtkcombobox.c (gtk_combo_box_popup)
888 (gtk_combo_box_menu_button_press): Make sure the menu pops up
889 as wide as the combobox. (#59660, Havoc Pennington)
891 2004-05-10 Matthias Clasen <mclasen@redhat.com>
894 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
895 mode). Add a new property, add-tearoffs, for this. (#135956)
897 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
898 default button. (#118921)
900 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
902 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
903 that emits the grab notify signal.
905 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
907 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
909 * gtk/gtkmenu.c: Make destruction of a torn off menu work
912 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
916 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
917 Allow to suppress the stock accelerator by using "". (#142196,
920 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
924 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
925 In list mode, accept the same mouse/wheel bindings on
926 the cellview as on the button. (#136967)
928 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
930 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
931 cached icons. (#135888, Crispin Flowerday)
933 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
935 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
936 that we actually return menus for nodes of type menu, not the
937 menuitems they're attached to.
939 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
941 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
942 Add a note regarding UTF-8 requirements, proposed by
943 Mariano Suárez-Alvarez.
945 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
947 * gtk/gtktearoffmenuitem.h:
948 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
949 into the GtkTearoffMenuItem struct, since it is used
950 by the Gimp, and keep it synchronized with the
951 tearoff_state property of the parent menu.
953 2004-05-08 Hans Breuer <hans@breuer.org>
955 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
956 create the correct mask for 'pseudo mime' icons
958 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
959 take focus_on_map into account
961 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
963 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
964 ... must return a value
966 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
968 2004-05-07 Matthias Clasen <mclasen@redhat.com>
970 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
971 draw over the focus rectangle.
973 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
974 standard focus style. (#63071, Bill Haneman, idea for new
975 style by Owen Taylor)
977 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
978 focus on the colorwheel via details.
980 2004-05-06 Matthias Clasen <mclasen@redhat.com>
984 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
985 this no longer needed signal handler. (#141817, Paul Pogonyshev)
987 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
989 * gtk/gtktearoffmenuitem.h:
990 * gtk/gtktearoffmenuitem.c: Make the tearoff
991 functionality model/view, the tearoffmenuitem being
992 the view and the tearoff_state property of the menu
993 being the model. (#101185, Owen Taylor)
995 * gtk/gtkmenu.c: Add a tearoff_state property.
997 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
1001 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
1002 popup the submenu for items in torn off menus. (#122051)
1004 2004-05-06 Sven Neumann <sven@gimp.org>
1006 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
1007 position the title lable next to the arrow just as we do for LTR
1008 rendering. Fixes bug #141825.
1010 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1012 * docs/RELEASE-HOWTO: Document the new policy of
1013 bumping version numbers after release.
1015 * configure.in: Bump version number to 2.5.0.
1017 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
1020 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
1023 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
1025 * gtk/gtkactiongroup.h:
1026 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
1027 New function to translate a string with translate_func.
1030 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
1032 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
1033 (gtk_combo_box_get_row_span_column):
1034 (gtk_combo_box_get_column_span_column): Add missing getters
1035 for readwrite properies. (#135649)
1037 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
1039 * gtk/gtkcombobox.h:
1040 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
1041 Add gtk_combo_box_get_active_text() convenience
1042 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
1044 2004-05-05 Elijah Newren <newren@math.utah.edu>
1046 Changes to support do-not-focus-on-map hint in conjunction with
1047 _NET_WM_USER_TIME (#115650):
1049 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
1052 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
1055 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
1056 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
1058 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
1059 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
1060 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
1061 Initialize the focus_on_map field to TRUE.
1063 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
1064 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
1065 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
1066 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
1067 Implementations for the various backends. The Win32 and linux-fb
1068 implementations set the focus_on_map field, but don't use it yet
1069 to actually implement noinput windows. The X implementation sets
1070 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
1072 * gdk/x11/gdkwindow-x11.h:
1073 * gdk/x11/gdkevents-x11.c (set_user_time):
1074 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1075 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
1076 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
1077 since we want that function to be part of the public API.
1079 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
1083 * gtk/gtkiconfactory.c (icon_source_clear): Don't
1084 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
1086 2004-05-05 Matthias Clasen <mclasen@redhat.com>
1090 * gtk/gtkuimanager.c (print_node): Make the output
1091 parseable. (#141929, Sven Neumann)
1093 2004-05-05 Tor Lillqvist <tml@iki.fi>
1095 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
1096 multi-monitor offset. (#141842, John Ehresman)
1098 2004-05-04 Federico Mena Quintero <federico@ximian.com>
1100 Fixes #139562, based on a patch by Christian Neumair.
1102 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
1103 a filter_combo_hbox field to contain the filter combo.
1104 (show_filters): Show/hide the filter_combo_hbox.
1105 (create_filename_entry_and_filter_combo): Removed.
1106 (file_pane_create): Create the filter_combo_hbox here.
1108 2004-05-04 Matthias Clasen <mclasen@redhat.com>
1110 * modules/input/gtkimcontextxim.c: Fix the recent
1111 string_conversion_callback change to work on
1112 Solaris. (#141190, Padraig O'Briain)
1114 * gtk/gtkselection.c: Disable debug logging again.
1116 2004-05-03 Matthias Clasen <mclasen@redhat.com>
1118 * gtk/gtkselection.c: Make the chunk size for
1119 incremental transfers depend on the maximal request
1120 size, capped at 256k. This should allow most selections
1121 to be transferred nonincrementally, avoiding many
1122 roundtrips and protocol overhead.
1124 2004-05-03 Federico Mena Quintero <federico@ximian.com>
1126 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
1127 g_signal_new() correctly and initialize the signal fields. Fixes
1128 #141749; patch based on Michael Natterer's.
1130 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
1132 * gtk/gtkselection.c (_gtk_selection_request): Fix
1133 a debug message to show correct information.
1134 (_gtk_selection_incr_event): Make INCRemental transfer
1135 of MULTIPLE targets work. This was broken since 1997!
1137 2004-05-02 Hans Breuer <hans@breuer.org>
1139 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
1140 modify the passed in GdkSegment(s) in place, we may get
1141 them again to draw at the same place. Fixes bug #129095,
1143 (draw_segments) draw the end pixel again to get the
1144 pixmap mask right, fixes bug #126710, #130202
1146 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
1147 fixes bug #106013, John Ehresman
1149 * gtk/makefile.msc.in : don't try to link gtk.res but
1150 use gtk-win32.res (as supposed to be fixed below :)
1152 2004-05-01 Hans Breuer <hans@breuer.org>
1154 * tests/Makefile.am : tests/makefile.msc is in CVS for
1155 a long time, finally added to EXTRA_DIST : fixes bug
1156 #141334, John Ehresman
1158 2004-04-30 Matthias Clasen <mclasen@redhat.com>
1160 * === Released 2.4.1 ===
1162 * configure.in: Version 2.4.1, interface age 1.
1166 2004-04-29 Federico Mena Quintero <federico@ximian.com>
1170 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
1171 function; moved the code over from
1172 remove_bookmark_button_clicked_cb().
1173 (remove_selected_bookmarks): Now, getting a non-removable bookmark
1174 is not an error, as we may be called as a result of hitting the
1176 (shortcuts_key_press_event_cb): New handler; delete the bookmark
1177 if the user presses Backspace, Delete, or KP_Delete.
1179 2004-04-29 Matthias Clasen <mclasen@redhat.com>
1181 * gtk/gtkaction.c (closure_accel_activate): Use
1182 _gtk_action_emit_activate() instead of directly
1183 emitting the activate signal. (#141429, Jody Goldberg)
1185 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1186 Warn people when the accelerator can not be
1187 parsed. (#141429, Jody Goldberg)
1189 2004-04-29 Matthias Clasen <mclasen@redhat.com>
1191 * tests/testentrycompletion.c (main): Add a missing
1192 cat. (#141070, Chris Sherlock)
1194 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
1195 variable. (#141022, Chris Sherlock)
1197 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
1198 cast. (#141013, Chris Sherlock)
1200 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
1201 unused variable. (#141011, Chris Sherlock)
1203 2004-04-29 Tor Lillqvist <tml@iki.fi>
1205 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
1206 leak. (#140775, John Ehresman)
1208 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
1210 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
1211 to index the cached gcs, not depth. (#139494)
1213 2004-04-28 Matthias Clasen <mclasen@redhat.com>
1215 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
1217 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1219 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
1220 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
1222 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
1224 Patch to add support for string conversion callbacks to
1225 GtkIMContextXIM (#101814)
1227 * modules/input/gtkimcontextxim.c: Set the string conversion callback
1228 if supported by the XIC.
1230 (struct _GtkIMContextXIM): Add string_conversion_callback member.
1232 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
1233 whether string conversion callback is supported.
1235 (gtk_im_context_get_ic, +set_string_conversion_callback,
1236 +string_conversion_callback): Also initialize string conversion
1237 callback, if supported, along with the IC initialization.
1239 * modules/input/imxim.c: Make "xim" module default for Thai as well.
1241 2004-04-23 Matthias Clasen <mclasen@redhat.com>
1243 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
1244 initialize targets. (#139883, John Finlay)
1246 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
1248 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
1249 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
1252 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
1253 Remove an excessive g_return_if_fail().
1255 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
1257 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1258 _-prefix calls of gdk_x11_window_set_user_time().
1260 2004-04-22 Matthias Clasen <mclasen@redhat.com>
1262 * gtk/gtkuimanager.c (update_node): Make sure the separators
1263 used to demarkate placeholder ends don't show up on
1264 show_all(). (#140496, Murray Cumming)
1266 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
1267 work with negative increments. (#137975, Tim Gerla)
1269 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1271 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
1272 gtk_tool_button_set_icon_widget): Remove the old widget from the
1273 tool button before overwriting it with the new widget.
1275 (#140508, Todd Goyen)
1277 2004-04-22 Tor Lillqvist <tml@iki.fi>
1279 Fix the file chooser on Windows. I can't make it misbehave or
1280 crash any more now. But presumably there are still corner cases
1281 not handled. I haven't really checked behaviour of UNC paths, for
1284 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
1285 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
1288 (gtk_file_system_win32_get_parent): Like the Unix version, assert
1289 filename is absolute, and avoid one unnecessary string allocation
1292 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
1293 letters more correctly.
1295 (gtk_file_system_win32_render_icon): Assure correct syntax is used
1296 for root folder of a drive. (#137962, Morten Welinder)
1298 (filename_is_some_root): New function that accepts also root
1299 without any drive specified.
1301 (filename_is_drive_root): Rename from filename_is_root.
1303 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
1306 2004-04-21 Matthias Clasen <mclasen@redhat.com>
1308 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
1309 completion window if there are no completions anymore.
1311 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1312 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
1313 It doesn't like that. (#140642, Christian Persch)
1315 * demos/gtk-demo/expander.c (do_expander): A new demo.
1317 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
1319 2004-04-20 Matthias Clasen <mclasen@redhat.com>
1321 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
1322 sure anchored children get size allocated, even if the layout
1323 is valid. (#122323, Andrew E. Makeev)
1324 (gtk_text_view_scroll_pages):
1325 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
1326 if we already have pending scrolls. Bandaid fix for #78513.
1328 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
1330 * INSTALL.in: Update libpng and libjpeg URLs, remove
1331 note about building without since that's not the normal
1334 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
1336 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
1337 handling of SVG/non-SVG unthemed icons.
1339 2004-04-19 Morten Welinder <terra@gnome.org>
1341 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
1344 2004-04-19 Matthias Clasen <mclasen@redhat.com>
1346 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1347 Don't stop the iteration up to the tag_root too
1348 early. (#109945, Dongho Shin)
1350 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1352 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
1353 gdk_keymap_translate_keyboard_state() handle NULL
1354 keymaps. (#139715, Torsten Schoenfeld).
1356 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1358 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
1359 reported by Pedro RODRIGUEZ, about compilation problems when
1360 Xcursor is installed in a non-standard location.
1362 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1364 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
1367 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
1368 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
1370 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
1372 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
1375 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
1376 property on user interaction.
1378 2004-04-15 Federico Mena Quintero <federico@ximian.com>
1380 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
1381 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
1383 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
1384 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
1387 2004-04-15 Matthias Clasen <mclasen@redhat.com>
1389 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1390 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
1392 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1394 * gtk/gtkcombobox.c:
1396 Make all style properties readonly.
1398 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1400 * gtk/gtkcolorsel.c: Add a11y relations between the color
1401 wheel and the spin buttons. (#132745, Padraig O'Briain)
1403 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
1404 the meaning of size == -1.
1406 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
1407 a size of -1. (#137436, Brian Cameron)
1409 * gtk/gtkcombobox.c: Make the arrow and separator regular
1410 children of an hbox inside the button, and propagate state
1411 changes from the button to the cell view. (part of the fix
1412 for #138650, should also fix #137535)
1414 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
1415 state to gtk_cell_renderer_render() when prelighted. (part
1416 of the fix for #138650)
1418 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1419 Use PRELIGHT state when appropriate. (part of the fix for
1422 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
1423 out warnings if called before the combo box is
1424 realized. (#139742, Philip Langdale)
1426 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
1428 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
1431 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
1433 * gtk/gtkpathbar.c (make_directory_button): remove spurious
1436 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
1438 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
1439 make the buttons sized by a bold label. This makes the text
1440 'swim' a little, but stops the buttons from resizing, #137210
1442 2004-04-13 Matthias Clasen <mclasen@redhat.com>
1444 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
1446 (start_element_handler): Accept separators without unique
1447 names. (#133302, Anders Carlsson)
1449 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
1450 possible accelerator gotcha when using this function. (#139641,
1453 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
1454 list nodes. (#138862, Morten Welinder)
1456 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
1458 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
1460 (gtk_tree_view_button_press): If we activated the row we don't
1461 want to grab focus back, as moving focus to another widget is
1462 pretty common, #138458
1464 2004-04-12 Federico Mena Quintero <federico@ximian.com>
1466 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
1467 documentation to all the signals.
1469 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
1471 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
1472 model if it is NULL. (#139770)
1474 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
1476 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
1477 a shadow inside the scrolled window, add it around the vbox.
1479 * gtk/gtkentryprivate.h:
1480 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1481 Return a boolean indicating whether the popup is positioned above
1482 or below. Scroll the completions to the beginning or the end,
1483 depending on the positioning.
1485 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
1486 wrap around in the entry completion popup, and allow GDK_UP to
1487 enter the popup. (#137440)
1489 2004-04-12 Matthias Clasen <mclasen@redhat.com>
1491 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
1492 there before using it.
1494 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
1496 * gtk/gtktreeprivate.h: Moved search entries into priv data.
1498 * gtk/gtktreeview.c: Prep for type-ahead support.
1500 (gtk_tree_view_destroy): Destroy the search window explicitly.
1501 (gtk_tree_view_key_press): Minor change; prep for type-ahead
1502 (gtk_tree_view_ensure_interactive_directory): New function
1503 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
1504 (gtk_tree_view_real_start_interactive_search): rework
1505 (gtk_tree_view_search_dialog_hide): ditto
1506 (gtk_tree_view_search_delete_event): ditto
1507 (gtk_tree_view_search_button_press_event): ditto
1508 (gtk_tree_view_search_key_press_event): ditto
1509 (gtk_tree_view_search_move): ditto
1510 (gtk_tree_view_search_init): ditto
1512 * gtk/gtktreeviewcolumn.c:
1513 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
1515 * tests/testfilechooser.c: (main): change
1517 2004-04-11 Hans Breuer <hans@breuer.org>
1519 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
1520 the real fix would involve just another small API breakage,
1521 i.e. gdk_spawn_* using GPid not just gint.
1523 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
1525 2004-04-10 Tor Lillqvist <tml@iki.fi>
1527 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
1528 If both Shift and CapsLock pressed, ignore the shift only for
1529 letters (that would have been affected by the CapsLock). (#139095)
1531 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
1532 seems to be even buggier now than it used to be. (#138341)
1533 Initialize _gdk_input_ignore_wintab to TRUE.
1535 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
1536 GDK_USE_WINTAB environment variable to turn on tablet support.
1538 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
1540 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
1541 (gtk_ui_manager_remove_action_group): Terminate
1542 g_object_[dis]connect() calls with NULL instead of 0.
1545 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
1547 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
1549 2004-04-07 Federico Mena Quintero <federico@ximian.com>
1553 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
1554 passed-in 'str' is not NULL.
1556 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
1557 expands "~/" or "~foo/" at the beginning of a filename.
1558 (gtk_file_system_unix_parse): Use expand_tilde() before doing
1561 * gtk/gtkfilechooserentry.c
1562 (gtk_file_chooser_entry_maybe_update_directory): Take in a
1563 force_reload argument.
1564 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
1565 returns an error, set the file_part_pos to -1.
1566 (load_directory_callback): Only populate the model if the
1567 file_part_pos is not -1.
1569 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
1571 * configure.in: Added Icelandic (is) to ALL_LINGUAS
1573 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1575 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
1576 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
1578 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
1579 for G_DIR_SEPARATOR in the display_name, and err out if it is
1580 present; use the same error message as Nautilus. Fixes #136467.
1582 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
1583 new-folder button say "Create Fo_lder" rather than "Create
1584 _Folder", so that the mnemonic doesn't conflict with the "Save in
1585 _folder" label. Fixes #136975.
1587 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1589 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
1590 buttons. Also, free them correctly upon failure. Based on a
1591 patch by Morten Welinder, fixes #137956.
1593 2004-04-05 Anders Carlsson <andersca@gnome.org>
1595 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
1597 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
1599 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
1600 correctly for fixed height when inserting a node, #138082
1602 2004-04-01 Federico Mena Quintero <federico@ximian.com>
1606 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
1607 "child_is_hidden" boolean argument to the "path-clicked" signal.
1609 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
1611 (make_directory_button): Take a file_is_hidden argument; put it in
1613 (_gtk_path_bar_set_path): See whether each path component path is
1615 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
1616 "path-clicked" signal.
1617 (button_clicked_cb): See if the downwards button represents a
1618 hidden file for the file_is_hidden argument in the signal
1621 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
1623 * gtk/gtkfilechooserdefault.c
1624 (gtk_file_chooser_default_select_path): If we fail to switch
1625 folders, don't try to select the path in the file system model.
1626 Also, return the result from _gtk_file_system_model_path_do().
1627 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
1628 file system model if we are asked to select a hidden file.
1629 (path_bar_clicked): Show hidden files based on whether the
1630 immediate downwards folder in the path bar is a hidden file
1632 (struct _GtkFileChooserDefault): Added fields
1633 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
1634 (create_file_list): Set an object data key of
1635 "GtkFileChooserDefault" on the tree view so that we can find the
1636 impl from the popup menu callbacks. Also, hook up to the
1637 "button-press-event" and "popup-menu" signals in the file list to
1638 bring up a popup menu.
1639 (list_popup_menu_cb): New callback.
1640 (list_button_press_event_cb): New callback.
1644 * gtk/gtkfilesystemmodel.c
1645 (_gtk_file_system_model_new): Oops, connect_object to
1648 2004-03-31 Tor Lillqvist <tml@iki.fi>
1650 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
1651 for native Win32. (#136559, J. Ali Harlow)
1653 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
1654 angles. Thanks to Tim Newsham.
1656 2004-03-29 Federico Mena Quintero <federico@ximian.com>
1660 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1661 for an ::is_finished_loading() method and a ::finished_loading()
1662 signal at the end of the struct.
1664 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1665 "finished-loading" signal.
1666 (gtk_file_folder_is_finished_loading): New function.
1668 * gtk/gtkfilesystemunix.c
1669 (gtk_file_folder_unix_is_finished_loading): Implement.
1671 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1672 slot for a "finished-loading" signal.
1673 (gtk_file_system_model_class_init): Create the "finished-loading"
1675 (struct _GtkFileSystemModel): New field
1676 idle_finished_loading_source. We emit the "finished-loading"
1677 signal in an idle if the root folder was done loading right in
1678 _gtk_file_system_model_new(), so that the caller has a chance to
1679 connect to the signal.
1680 (_gtk_file_system_model_new): Connect to the normal signals of the
1681 folder even if the initial _list_children() fails. Also, see if
1682 the folder is finished loading; connect to the "finished-loading"
1684 (gtk_file_system_model_finalize): Remove the idle handler.
1686 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1687 and connect to the model's "finished-loading" signal.
1688 (get_toplevel): New helper function.
1689 (error_message): Use get_toplevel().
1690 (trap_activate_cb): Likewise.
1691 (location_popup_handler): Likewise.
1692 (set_busy_cursor): New function.
1693 (browse_files_model_finished_loading_cb): New callback.
1695 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1697 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
1698 file under the cursor; we don't need the logic from
1699 GtkFileSelection after all. Fixes #132255.
1701 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1703 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
1704 location entry with the display name of the file under the cursor
1705 for Open mode, or the typed filename in Save mode.
1707 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1709 * gtk/gtkfilesystemwin32.c
1710 (filename_is_root): Bare drive designators (eg., "c:") are
1711 no longer considered as root filenames. Fixed #137942
1713 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1715 * gtk/gtkfilesystemwin32.c
1716 (gtk_file_system_win32_create_folder): Invert test for error in
1717 mkdir. Fixes #137945
1719 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1721 Fixed #138004 using Federico's code from #132327.
1723 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
1724 folder_hash field to keep a list of live folder objects.
1725 (gtk_file_system_win32_init): Create the folder_hash.
1726 (gtk_file_system_win32_finalize): Destroy the folder_hash.
1727 (gtk_file_system_win32_get_folder): Ref and return an existing
1728 folder if we have it around, otherwise return a new folder object.
1729 (struct _GtkFileFolderWin32): Add a field for the parent file system.
1730 (gtk_file_folder_win32_finalize): Remove the folder from the file
1731 system's hash table.
1732 (gtk_file_system_win32_create_folder): Emit "files-added" on the
1733 newly-created folder's parent. Fixes #138004.
1735 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1737 * gtk/gtkfilesystemwin32.c
1738 (gtk_file_system_win32_get_folder): Test that path is actually
1739 a directory and throw error if not. Fixed bug #137950
1741 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
1743 * gtk/gtkfilesystemwin32.c
1744 (gtk_file_system_win32_volume_get_display_name): Ignore empty
1745 volume labels; assume that GetVolumeInformation would fail if
1746 GetVolumeInformationW does; catches a small memory leak;
1747 pass the buffer size to GetVolumeInformationW in wide
1748 characters instead of bytes. Fixes bug #137543
1749 (list_volumes): Cope with the theoretical possibility of
1750 more than 26 logical drives. Fixes bug #137940
1751 (bookmarks_serialize): Now actually removes bookmarks.
1754 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
1756 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
1758 2004-03-21 Tor Lillqvist <tml@iki.fi>
1760 * gtk/gtkfilesystemwin32.c
1761 (gtk_file_system_win32_volume_get_base_path): Include the
1762 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
1763 NULL for a volume base path, as g_filename_to_uri() requires an
1764 absolute path, and just a drive letter and colon isn't. (#137543)
1766 2004-03-20 Hans Breuer <hans@breuer.org>
1768 * gtk/gtkfilesystemwin32.c : applied the undisputable and
1769 required [due to recent gtkfilesystem internal api semantic
1770 changes] part of patches to fix bug #137543 (Tor Lillqvist,
1773 * gdk/gdkevents-win32.c (handle_configure_event) :
1774 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
1775 GdkWindowObject::x, y with screen coords to make
1776 gdk_window_get_position () return the right thing and thus fix
1777 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
1779 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1781 * Revert the patch to #137520, as 2.4.1 is for conservative bug
1782 fixes only. The patch is attached to the bug report, for
1785 2004-03-19 Morten Welinder <terra@gnome.org>
1787 * gtk/gtkfilechooserdefault.c
1788 (gtk_file_chooser_default_set_current_folder): Test existance of
1789 the path after checking for locality, if needed.
1791 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1795 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1796 for an ::is_finished_loading() method and a ::finished_loading()
1797 signal at the end of the struct.
1799 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1800 "finished-loading" signal.
1801 (gtk_file_folder_is_finished_loading): New function.
1803 * gtk/gtkfilesystemunix.c
1804 (gtk_file_folder_unix_is_finished_loading): Implement.
1806 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1807 slot for a "finished-loading" signal.
1808 (gtk_file_system_model_class_init): Create the "finished-loading"
1810 (struct _GtkFileSystemModel): New field
1811 idle_finished_loading_source. We emit the "finished-loading"
1812 signal in an idle if the root folder was done loading right in
1813 _gtk_file_system_model_new(), so that the caller has a chance to
1814 connect to the signal.
1815 (_gtk_file_system_model_new): Connect to the normal signals of the
1816 folder even if the initial _list_children() fails. Also, see if
1817 the folder is finished loading; connect to the "finished-loading"
1819 (gtk_file_system_model_finalize): Remove the idle handler.
1821 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1822 and connect to the model's "finished-loading" signal.
1823 (get_toplevel): New helper function.
1824 (error_message): Use get_toplevel().
1825 (trap_activate_cb): Likewise.
1826 (location_popup_handler): Likewise.
1827 (set_busy_cursor): New function.
1828 (browse_files_model_finished_loading_cb): New callback.
1830 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
1832 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
1833 eventbox for expander. (#137564, reported by
1836 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
1838 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
1840 2004-03-17 Morten Welinder <terra@gnome.org>
1842 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
1843 volumes not actually put into the shortcut list.
1845 * tests/prop-editor.c (object_changed): Plug leak.
1847 * tests/testfilechooser.c (main): Plug some leaks and expose
1850 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
1851 object. Fixed #136652.
1853 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
1854 have no screen. Fixes #137260.
1855 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
1856 thereby fixing leak. Fixes #137259.
1858 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
1859 slider buttons have been destroyed.
1860 (gtk_path_bar_remove): Make this work for slider buttons too.
1863 2004-03-15 Morten Welinder <terra@gnome.org>
1865 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
1866 Sanitize and plug leak.
1867 (check_icon_theme): Only do something if the widget has a screen.
1869 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
1871 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1872 Move the repositioning logic from _gtk_entry_completion() popup
1873 over here. Fixes #137355, reported by Niklas Knutsson.