1 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
3 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
4 Experimentally, scrollbar steppers can shrink to 8 pixels on
5 Win32. Reflect that in the theme.
6 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
7 there is a 1-pixel border between a scrollbar and its child
8 in ScrolledWindows on Win32. Reflect that in the theme.
10 2005-10-20 Matthias Clasen <mclasen@redhat.com>
12 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
13 for the selection window. (#318806, Alex Larsson)
15 2005-10-18 Federico Mena Quintero <federico@ximian.com>
19 * tests/autotestfilechooser.c
20 (test_button_folder_states_for_action): Test that we have either
21 $cwd or the explicitly-set folder.
22 (test_reload_sequence): Likewise.
24 * gtk/gtkfilechooserdefault.c
25 (gtk_file_chooser_default_get_current_folder): If our reload_state
26 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
28 2005-10-14 Tor Lillqvist <tml@novell.com>
30 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
31 It didn't really do anything useful, and was just confusing and
32 incomplete. Comments claimed we don't do delayed rendering, but in
33 fact we do, for images. (The delayed rendering code has other
34 problems, though, see #168173.) The clipboard viewer code was
35 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
36 the message when necessary). It was just test code, it said so in
37 a comment. Add something similar back later if necessary.
39 (_win32_on_clipboard_change,
40 _gdk_win32_register_clipboard_notification): Remove.
42 (gdk_display_supports_selection_notification,
43 gdk_display_request_selection_notification): Always just return
44 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
46 2005-10-13 Tor Lillqvist <tml@novell.com>
48 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
49 Alt-Enter specially. It does not have any special meaning and
50 should be passed on to the application. (#318378, Tim Evans)
52 2005-10-13 Tor Lillqvist <tml@novell.com>
54 Set visual depth to 24 for 32 bits-per-pixel devices on
55 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
56 optimized composite_0888() function rather than the slower image
57 dithering functions to draw pixbufs (#313993, John Ehresman)
59 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
60 _gdk_windowing_get_bits_for_depth() to initialize
61 GdkImage::bits_per_pixel.
62 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
64 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
65 _gdk_windowing_get_bits_for_depth() to initialize
66 BITMAPINFOHEADER::biBitCount.
68 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
69 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
72 2005-10-12 Stefan Kost <ensonic@users.sf.net>
74 * demos/gtk-demo/appwindow.c: (about_cb):
75 use PACKAGE_VERSION,bump year (#318654)
77 2005-10-11 Matthias Clasen <mclasen@redhat.com>
79 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
80 toggle here with the matching on toggle if it immediately follows.
81 This is a common case, and handling it here prevents quadratic blowup
82 in cleanup_line() below. (#317125)
84 * gtk/gtktextsegment.h:
85 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
86 the character counts into this function instead of computing them
89 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
91 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
93 * gtk/gtkfilechooserdefault.c
94 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
95 when the shortcut already exists in the sidebar. (#147521)
97 2005-10-09 Matthias Clasen <mclasen@redhat.com>
99 * tests/testcombo.c: Demonstrate how to use custom widgets in
102 2005-10-07 Federico Mena Quintero <federico@ximian.com>
106 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
107 the the result of gtk_file_chooser_get_folder() is NULL or
108 non-NULL at the right times. Log the tests.
109 (test_button_folder_states): New test for the initial states of
110 the current folder in GtkFileChooserButton.
111 (main): Test that the number of warnings/errors/critical errors is
114 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
115 Clarify the documentation on when this can return NULL.
116 (gtk_file_chooser_get_current_folder_uri): Likewise.
118 * gtk/gtkfilechooserbutton.c (struct
119 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
120 we use it to keep track of whether a folder has been set.
121 (gtk_file_chooser_button_map): Implement. If no folder has been
122 loaded before, we at least try to load $cwd here.
123 (gtk_file_chooser_button_constructor): If the construct-time
124 dialog already has a folder set, turn on our folder_has_been_set
126 (dialog_current_folder_changed_cb): Turn on our
127 folder_has_been_set flag.
129 2005-10-07 Michael Natterer <mitch@gimp.org>
131 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
132 PROFILE_FILE_CHOOSER because they break compilation after the
133 removal of <unistd.h>.
135 2005-10-07 Matthias Clasen <mclasen@redhat.com>
137 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
138 by moving it out of the profiling ifdef.
140 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
141 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
143 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
144 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
147 2005-10-06 Matthias Clasen <mclasen@redhat.com>
150 * gtk/gtktextbuffer.h:
151 * gtk/gtktextbuffer.c: Add a readonly has-selection property
152 with a getter. (#318161, Paolo Borelli)
154 2005-10-05 Matthias Clasen <mclasen@redhat.com>
156 * README.in: Start collecting release notes for 2.10.
158 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
159 leak fix, since the assertion failures were traced to
160 an xchat bug. (#314696)
162 * gtk/gtkstyle.c (gtk_style_detach):
163 (gtk_style_attach): Documentation improvements.
164 (gtk_style_detach): Assert that the attach_count is > 0.
166 2005-10-04 Federico Mena Quintero <federico@ximian.com>
168 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
169 shortcut position, not a ShortcutsIndex, to make the function more
171 (home_folder_handler): Pass the resolved index to
172 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
173 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
174 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
175 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
176 make the respective key switch to the first, second, ..., tenth
178 (quick_bookmark_handler): Implement.
180 2005-10-04 Federico Mena Quintero <federico@ximian.com>
182 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
183 Desktop; just use their real names on the file system for the
186 * gtk/gtkfilechooserdefault.c
187 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
188 binding signal, and bind it to M-d by default.
189 (desktop_folder_handler): Implement the default handler.
190 (home_folder_handler): Use a helper function.
191 (switch_to_shortcut): New helper function.
192 (shortcuts_append_home): Don't special-case the name of "Home";
193 just use the folder name.
195 2005-10-04 Tor Lillqvist <tml@novell.com>
197 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
198 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
200 2005-10-04 Matthias Clasen <mclasen@redhat.com>
202 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
203 from yesterday, since it leads to assertion failures. (#317879,
206 2005-10-03 Matthias Clasen <mclasen@redhat.com>
208 * gtk/gtkcalendar.c (gtk_calendar_init): Call
209 calendar_compute_days() after setting priv->week_start.
211 2005-10-03 Matthias Clasen <mclasen@redhat.com>
213 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
214 removing it from the hash table. (#314696, Benjamin Berg)
216 2005-10-01 Tor Lillqvist <tml@novell.com>
218 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
219 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
220 is that the the desktop isn't visible because the session has been
221 switched, the screen is locked, or a terminal server session
222 disconnected, so no error message necessary. (#137796)
224 It is of course remotely possible that BitBlt() failing with
225 ERROR_INVALID_HANDLE might also be caused by some other
226 problem. We could strive for perfection and track whether the
227 desktop is visible by using WTSRegisterSessionNotification() and
228 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
229 this issue, though. If we would track desktop visibility, we
230 should then avoid even trying to update the display at all while
231 the desktop isn't visible.
233 2005-09-30 Matthias Clasen <mclasen@redhat.com>
235 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
236 to correct the calculations for the first week day. We may
237 just have to remove this code if too many locales turn out
240 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
241 some cases. (#317611, Tommi Komulainen)
243 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
244 Prevent overflow when storing size hints in an unsigned
245 short variable. Tracked down by Ray Strode and Søren Sandmann.
247 2005-09-29 Matthias Clasen <mclasen@redhat.com>
249 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
252 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
253 grab shadowed. (#317332)
255 2005-09-29 Tor Lillqvist <tml@novell.com>
257 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
259 2005-09-28 Federico Mena Quintero <federico@ximian.com>
261 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
262 if the unmap test fails.
263 (test_reload_sequence): Use gtk_widget_show_now() instead of
264 gtk_widget_show() for the dialog.
265 Thanks to Tim Janik for noticing these.
267 2005-09-28 Federico Mena Quintero <federico@ximian.com>
269 * tests/testcellrenderertext.c: New file with a set of tests for
270 GtkCellRendererText. The idea is to run a text renderer through
271 most of its interesting property values to see that it works
274 * tests/Makefile.am: Added testcellrenderertext.
276 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
277 entry/exit of this function for profiling.
278 (gtk_file_chooser_default_style_set): Mark the start/end of the
279 calls to the parent class and the the signal emission for profiling.
281 2005-09-29 Tor Lillqvist <tml@novell.com>
283 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
284 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
285 system codepage using g_win32_locale_filename_from_utf8().
286 (#317457, Kazuki Iwamoto)
288 2005-09-28 Matthias Clasen <mclasen@redhat.com>
290 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
291 here. (#317039, Paolo Borelli)
294 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
295 to make this function work as boxed copy function. (#317455,
298 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
299 NULL. (#316828, Tor Lillqvist)
301 2005-09-28 Tor Lillqvist <tml@novell.com>
303 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
306 2005-09-27 Federico Mena Quintero <federico@ximian.com>
308 Don't reload the current folder unnecessarily on ::map().
310 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
312 (struct _GtkFileChooserDefault): Added a "reload_state" field.
314 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
315 Initialize impl->reload_state.
316 (gtk_file_chooser_default_map): Check the impl->reload_state; load
317 a default folder if no folder has been set, or reload the current
318 one only if we had been unmapped first.
319 (gtk_file_chooser_default_update_current_folder): Set the
320 reload_state to RELOAD_HAS_FOLDER.
321 (gtk_file_chooser_default_unmap): Implement, and set the
322 reload_state to RELOAD_WAS_UNMAPPED.
323 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
324 here; they'll get (re)loaded on ::map() anyway.
326 * gtk/gtkfilechooserwidget.c
327 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
329 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
330 a dialog; build it ourselves.
331 (test_reload): New test to ensure that we don't load the default
332 folder more than once, and that we reload it when
334 (get_impl_from_dialog): New utility function.
335 (test_widgets_for_current_action): Use get_impl_from_dialog().
337 2005-09-27 Federico Mena Quintero <federico@ximian.com>
339 * gtk/gtkfilechooserdefault.c
340 (gtk_file_chooser_default_constructor): Mark the entry/exit of
341 this function for profiling.
342 (check_icon_theme): Likewise.
343 (change_icon_theme): Likewise.
344 (settings_notify_cb): Likewise.
345 (gtk_file_chooser_default_screen_changed): Likewise.
346 (update_chooser_entry): If the selection is empty, clear the file
347 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
348 nothing will be selected when the user starts typeahead in the
349 treeview, and we don't want to clear the file name entry in that
350 case --- the user could be typing-ahead to look for a folder name.
351 Fixes bug #308332, patch by Jürg Billeter.
353 2005-09-27 Matthias Clasen <mclasen@redhat.com>
355 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
356 Pop below the entry if there's more free space below the entry
357 than above. (#316948, Tommi Komulainen)
359 2005-09-26 Federico Mena Quintero <federico@ximian.com>
361 Do not create the save mode-specific widgets in the open modes, so
362 that we don't carry their baggage around.
364 * gtk/gtkfilechooserdefault.c
365 (gtk_file_chooser_default_constructor): Don't create the
367 (save_widgets_create): Set the impl->save_widgets directly here,
368 instead of passing the widgets back to the caller. Also, pack
369 them into the impl's box.
370 (update_appearance): Create or destroy the save widgets as
371 appropriate. Set the action of the save_file_name_entry here.
372 (shortcuts_add_current_folder): Set the active item in the
373 save_folder_combo only if it exists.
374 (gtk_file_chooser_default_set_property): Don't set the action of
375 the save_file_name_entry here.
376 (gtk_file_chooser_default_update_current_folder): Set the base
377 folder of the save_file_name_entry only if the entry exists.
378 (shortcuts_drag_data_received_cb): Cast the selection_data->data
379 to (const char *) since that's what shortcuts_drop_uris() expects.
380 (file_list_drag_data_received_cb): Likewise, for
381 g_uri_list_extract_uris().
383 2005-09-26 Tor Lillqvist <tml@novell.com>
385 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
386 the shaped flag here, too. (#316871)
387 (gdk_window_shape_combine_region): Currently unimplemented, so
388 don't do anything to the shaped flag here.
390 2005-09-26 Matthias Clasen <mclasen@redhat.com>
392 Fix #316871, reported by Dan Winship:
394 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
396 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
397 (gdk_window_shape_combine_region): Set it here.
399 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
400 remove the child area for shaped windows.
402 2005-09-23 Matthias Clasen <mclasen@redhat.com>
404 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
405 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
407 2005-09-22 Michael Natterer <mitch@imendio.com>
409 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
410 consistent with GTK+ terminology:
412 * gtk/gtkcellrendererkeys.[ch]
413 * tests/testkeys.c: removed...
415 * gtk/gtkcellrendereraccel.[ch]
416 * tests/testaccel.c: ...and added.
421 * tests/Makefile.am: changed accordingly.
423 2005-09-22 Matthias Clasen <mclasen@redhat.com>
425 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
426 for the grab-broken-event signal, noticed by Damon Chaplin.
428 2005-09-21 Tor Lillqvist <tml@novell.com>
430 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
431 gdk_text_property_to_text_list_for_display,
432 gdk_text_property_to_utf8_list_for_display,
433 gdk_win32_selection_add_targets,
434 _gdk_win32_selection_convert_to_dib): Free return value from
436 (gdk_text_property_to_text_list_for_display): Drop GError variable
437 that isn't actually used after being set.
439 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
441 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
444 2005-09-20 Tor Lillqvist <tml@novell.com>
446 * gdk/win32/gdkselection-win32.c
447 (gdk_selection_owner_get_for_display): Do return the correct owner
448 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
449 a window GDK knows about). The reason to return NULL seems to have
450 gone when in the fix for bug #163702 the artificial
451 GDK_SELECTION_CLEAR event generation was removed from
452 gdk_selection_send_notify_for_display(). Fixes bug #316552.
454 2005-09-20 Matthias Clasen <mclasen@redhat.com>
456 Avoid unnecessary XkbGetState() calls and XkbStateNotify
457 events. (#151555, Søren Sandmann)
459 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
460 XkbSelectEventDetails() to select XkbStateNotify events
461 for only the state we care about.
463 * gdk/x11/gdkprivate-x11.h:
464 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
465 the event into the function and update the keymap state from
466 the state information contained in the event. Adjust all callers.
468 2005-09-19 Matthias Clasen <mclasen@redhat.com>
470 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
471 in multiple places to avoid segfaults if the index is out of range.
472 (#316422, Guillaume Cottenceau)
473 (gtk_icon_view_set_drag_dest_item):
474 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
475 #316424, Guillaume Cottenceau)
477 2005-09-18 Hans Breuer <hans@breuer.org>
479 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
480 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
482 2005-09-18 Hans Breuer <hans@breuer.org>
484 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
485 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
486 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
487 the icon and is blinking with teststatusicon. More to come ...
489 2005-09-18 Hans Breuer <hans@breuer.org>
491 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
492 cause gtkprogressbar.c has #include <config.h> conditionally; less
493 noise from generated gtk.def
494 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
496 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
497 For me it works as well as the *NIX implemenation, that is not at all.
499 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
501 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
502 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
503 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
504 again - if compiled properly.
506 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
507 already coming with Gtk+. Makes it compile on win32.
509 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
511 * README.cvs-commits: fixed some tiny typos
513 2005-09-16 Tor Lillqvist <tml@novell.com>
515 * modules/engines/ms-windows/msw_style.c (draw_extension,
516 draw_box_gap): Check whether the widget actually is a GtkNotebook
517 before treating it as such. Drop some unneeded local variables,
518 use parameter with same information instead. (#316412)
520 2005-09-15 Federico Mena Quintero <federico@ximian.com>
522 * tests/autotestfilechooser.c: Start a set of automated tests for
523 the file chooser. The only test in there right now doesn't pass
524 yet. It specifies the intended behavior of the first optimization
525 of a series which I'll do on the file chooser (see
526 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
527 details of this optimization).
529 * tests/Makefile.am: Added autotestfilechooser.c.
531 * gtk/gtkfilechooserprivate.h (struct
532 _GtkFileChooserDialogPrivate): Move all the file chooser's private
533 structures to here, so that they can be accessed by
534 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
535 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
537 * gtk/gtkfilechooserdialog.c: See above.
539 * gtk/gtkfilechooserwidget.c: See above.
541 * gtk/gtkfilechooserdefault.c: See above.
543 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
546 gtk_window_map_event(): new function to work around lost unmap requests.
549 2005-09-14 Federico Mena Quintero <federico@ximian.com>
551 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
552 an easy-to-find profiling marker when starting to create a file
554 (browse_files_model_finished_loading_cb): Likewise, for when the
555 chooser is finished loading.
557 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
559 * gtk/gtkcolorbutton.c: Check "color" argument in
560 gtk_color_button_set_color ()
562 2005-09-14 Matthias Clasen <mclasen@redhat.com>
564 * gtk/gtklabel.c (gtk_label_get_type):
565 * gtk/gtkbutton.c (gtk_button_get_type):
566 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
567 using a mem chunk for window groups, buttons, labels.
569 * gtk/updateiconcache.c (foreach_remove_func): Fix
570 a use-after-free bug. (#316256, Alexander Nedotsukov)
572 2005-09-13 Matthias Clasen <mclasen@redhat.com>
574 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
576 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
578 2005-09-13 Matthias Clasen <mclasen@redhat.com>
580 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
581 Let GDK_Return pass through in some more cases.
583 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
584 activating the entry.
586 * gtk/gtkiconview.c (gtk_icon_view_class_init):
587 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
588 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
590 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
591 (#316001, Guillaume Cottenceau)
593 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
594 mistake in the docs. (#315993, Guillaume Cottenceau)
596 * tests/testentrycompletion.c (create_simple_completion_model): Add
597 some strings containing multibyte characters.
599 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
600 Fix prefix insertion for multibyte characters. (#316095,
603 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
604 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
605 return NULL if the widget is not realized. (#316023,
606 Guillaume Cottenceau)
608 2005-09-11 Matthias Clasen <mclasen@redhat.com>
612 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
613 New function to avoid pointless strdups when creating atoms
617 * gtk/*.c: Use gdk_atom_intern_static_string() where
620 2005-09-09 Matthias Clasen <mclasen@redhat.com>
622 * gtk/gtkcellrendererkeys.h:
623 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
624 and editing accelerators, a port of EggCellRendererKeys .
628 * gtk/Makefile.am: Add the keys cell renderer.
631 * tests/testkeys.c: Test GtkCellRendererKeys
633 2005-09-09 Matthias Clasen <mclasen@redhat.com>
635 Make it possible to determine if a key event is for a
638 * gdk/x11/gdkprivate-x11.h:
639 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
640 New function to determine if a keycode is mapped to a modifier.
641 (get_xkb): Get the modmap.
643 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
644 is_modifier bit by calling _gdk_keymap_key_is_modifier().
646 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
649 2005-09-09 Matthias Clasen <mclasen@redhat.com>
651 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
652 unused variable, noticed by Kjartan Maraas.
654 2005-09-09 Matthias Clasen <mclasen@redhat.com>
656 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
657 Make drag reordering work properly for columns other than the
658 first. (#315054, Dan Winship)
660 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
661 invalid fontnames better. (#136926, Michael R. Walton)
663 Stop cursor blinking in non-editable regions of a text view.
664 (#311508, Torbjörn Andersson)
666 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
667 (cursor_blinks): Take editability into account when deciding
668 whether the cursor blinks.
669 (gtk_text_view_button_release_event):
670 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
672 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
673 Use connect_after to connect to the focus_out event. This
674 ensures that the entry has already stopped blinking by the time
675 we emit the edited signal. (#315229, Thomas Leonard)
677 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
679 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
680 unsigned ints to -1. (#315481, Kjartan Maraas)
682 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
683 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
684 (#314473, Stanislav Brabec)
686 2005-09-09 Matthias Clasen <mclasen@redhat.com>
688 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
689 memory handling. (#314975, Torsten Schoenfeld)
691 * gtk/gtkiconview.c (gtk_icon_view_class_init):
692 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
693 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
694 * gtk/gtklabel.c (gtk_label_class_init):
695 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
696 Stylistic improvements and clarifications for some blurbs.
697 (#315520, Clytie Siddall)
699 2005-09-09 Tor Lillqvist <tml@novell.com>
701 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
702 display name. There is only one GdkDisplay on Win32, and
703 constructing the display name isn't entirely trivial, so cacheing
704 is probably worth it. For instance GIMP calls this function a lot.
705 (gdk_display_open): Call gdk_display_get_name() to prime the
707 (gdk_display_get_n_screens, gdk_display_get_screen,
708 gdk_display_get_default_screen): Verify parameter correctness like
709 the X11 backend does.
711 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
712 Return a freshly allocated string, as the API specifies. Fixes a
713 heap corruption problem that caused random errors and crashes in
716 2005-09-07 Matthias Clasen <mclasen@redhat.com>
718 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
719 Make C-u commit and restart hex input if we are already in a
722 2005-09-06 Matthias Clasen <mclasen@redhat.com>
724 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
725 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
726 if they are mapped to the same modifier.
728 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
729 to gtkstatusicon.c and gtktrayicon-x11.c
731 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
732 default accel mod mask.
734 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
735 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
736 Don't use GDK_ALT_MASK.
738 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
740 2005-09-06 Matthias Clasen <mclasen@redhat.com>
742 Add support for extra virtual modifiers: (#85780, Owen Taylor)
744 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
747 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
748 Mod2 - Mod5 and against Super, Hyper, Meta.
750 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
751 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
752 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
754 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
755 modmap to maintain the information which X modifiers map to
757 (get_xkb): Set up the modmap from the XKB tables.
758 (update_keymaps): Set up the modmap from the information returned
759 by XGetModifierMapping in the non-XKB case.
761 * gdk/x11/gdkprivate-x11.h:
762 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
763 function to set the virtual modifiers in the state.
765 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
766 _gdk_keymap_add_virtual_modifiers here.
768 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
769 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
772 2005-09-05 Matthias Clasen <mclasen@redhat.com>
774 * gtk/gtkaction.c (connect_proxy): Set the label of a button
775 if it has no child. (#315253, John Finlay)
777 2005-09-02 Matthias Clasen <mclasen@redhat.com>
779 * gtkimcontextsimple.h: Add a modifiers_dropped bit
781 2005-09-02 Matthias Clasen <mclasen@redhat.com>
783 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
784 on destroy to avoid problems when they are called on a destroyed
785 widget. (#315135, John Cupitt)
787 * gtk/gtkentry.c (gtk_entry_class_init):
788 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
789 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
791 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
792 code. Now we only steal a single key combination, Ctrl-Shift-U,
794 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
795 by a sequence of hex digits entered with Ctrl-Shift still held.
796 Releasing one of the modifiers or pressing space while the modifiers
797 are still held commits the character. It is possible to erase
798 digits using backspace.
799 As an extension to the above, we also allow to start the sequence
800 with Ctrl-Shift-U, then release the modifiers before typing any
801 digits, and enter the digits without modifiers.
802 (#82011, Owen Taylor)
804 2005-09-02 Matthias Clasen <mclasen@redhat.com>
806 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
807 we still need to deliver the destroy event. (#314980, Chris Lahey)
809 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
810 im context before committing \n or \t.
812 2005-09-02 Alexander Larsson <alexl@redhat.com>
814 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
815 (shortcuts_activate_volume):
816 Handle base_path being null in the rest of the cases (#310270)
818 2005-09-02 Tor Lillqvist <tml@novell.com>
820 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
821 cursor position also in root window coordinates. Prune out
822 superfluous WM_MOUSEMOVE events even earlier, based on root window
823 coordinates. Windows sends WM_MOUSEMOVE messages after a new
824 window has ben mapped below the cursor even if the mouse doesn't
825 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
826 confused at least gtk_menu_motion_notify(). (#314995)
828 * gtk/gtkintl.h: No need to include config.h here. It caused
829 warnings about GTK_LOCALEDIR being redefined on Win32 when
830 compiling files where gtkintl.h is included after gtkprivate.h
831 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
833 * gtk/gtkplug.c: Include config.h.
835 2005-09-01 Matthias Clasen <mclasen@redhat.com>
837 * gtk/gtkfilesystemunix.c: Pass statbufs down to
838 xdg_mime_get_mime_type_for_file() where possible, to avoid
841 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
842 typo. (#314921, Guillaume Cottenceau)
844 * gdk/*.c: Intern some more strings.
846 * gtk/*.c: Define an I_() macro and use it instead of the
847 bulky g_intern_static_string().
849 2005-08-31 Matthias Clasen <mclasen@redhat.com>
851 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
852 instead of copying it.
854 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
856 * gtk/*.c: Also intern static strings passed to
860 * gtk/Makefile.am: Intern type names in code generated by
865 * gdk/*.c: Intern type names before registering the type to avoid
868 * configure.in: Require GLib 2.9.0
870 2005-08-31 Matthias Clasen <mclasen@redhat.com>
872 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
873 and add icon-size and icon-size-set properties. (#314172)
875 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
876 groups across transient parents. (#312918, Christian Persch)
878 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
879 Guillaume Cottenceau)
881 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
882 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
884 2005-08-30 Matthias Clasen <mclasen@redhat.com>
886 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
887 make C-/ select all and C-\ unselect all. (#309301,
890 * gtk/gtkimcontextsimple.c: Change the compose sequence for
891 soft hyphen to be multi_key-minus-minus-space, and add
892 compose sequences multi_key-minus-minus-period and
893 multi_key-minus-minus-minus for en dash and em dash.
894 (#172653, Christian Lohmaier)
896 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
897 code. (#313946, Christian Persch)
899 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
900 fix for the default value of the "ui" property.
902 2005-08-30 Matthias Clasen <mclasen@redhat.com>
905 * gtk/gtkselection.h:
906 * gtk/gtkselection.c: Add functions which look for text, image
907 or uri targets in an array of atoms. (#314089, Mark Wielaard)
910 * gtk/gtkselection.h:
911 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
912 Add a function to check wether targets include uri.
913 (#314092, Mark Wielaard)
917 * gtk/gtkwindow.c: Add a deletable property with getter
918 and setter, to control the close button in the window
919 frame. (#59718, Havoc Pennington)
921 2005-08-29 Matthias Clasen <mclasen@redhat.com>
923 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
924 to the arrow keys for menu navigation. (#162825, Carl Worth)
926 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
928 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
930 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
931 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
932 refer to nonexisting stock ids.
934 * gtk/gtktextview.c (popup_targets_received):
935 * gtk/gtkentry.c (popup_targets_received): Construct
936 the "Select All" menuitem from stock.
938 * gtk/stock-icons/stock_select_all_{16,24}.png:
939 * gtk/stock-icons/Makefile.am:
940 * gtk/gtkiconfactory.c:
942 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
945 * gtk/gtktrayicon.c: Add a pointer to the spec.
947 * gtk/gtkstatusicon-x11.c: Add docs.
949 * gtk/gtkstatusicon.h: Fix a typo.
951 Add a cross-platform "tray icon" API, by
952 porting EggStatusIcon/EggTrayIcon (#105101)
954 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
955 displays an icon in a notification area.
957 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
958 X11, using GtkTrayIcon.
961 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
962 system tray specification, not public API.
964 * gtk/gtk.symbols: Add new exported functions.
966 * gtk/gtk.h: Include gtkstatusicon.h.
968 * gtk/Makefile.am: Add new files.
971 * tests/teststatusicon.c: Test for GtkStatusIcon.
973 2005-08-29 Christopher Aillon <caillon@redhat.com>
975 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
976 and GTK_STOCK_DISCONNECT
978 2005-08-29 Matthias Clasen <mclasen@redhat.com>
980 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
981 Use XFixesChangeSaveSet if available. (#314682)
983 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
984 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
986 2005-08-29 Matthias Clasen <mclasen@redhat.com>
988 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
989 accidentally leftover duplicate pixbuf creation. (#314700,
992 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
993 leak the cursor theme name. (#314693, Kjartan Maraas)
995 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
996 state.children in all cases. (#313862, Kjartan Maraas)
998 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1000 * po/POTFILES.in, po-properties/POTFILES.in:
1003 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1005 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1006 value of the ui property. (#314532, Yong Wang)
1008 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1009 when G_MAXLONG is passed as length.
1011 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1013 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1014 to avoid overloading --force. (JP Rosevaar)
1016 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1018 * configure.in: Bump version to 2.9.0
1022 * gdk/gdkscreen.c: Make the GdkScreen font options api
1023 public, and add properties GdkScreen::font-options and
1024 GdkScreen::resolution. (#314004)
1027 * gtk/gtksettings.c:
1028 * gtk/gtkwidget.c: Adjust all callers.
1030 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1031 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1032 * gdk/gdkscreen.c: Include gdkintl.h.
1034 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1035 variable warning, pointed out by Colin Walters. (#314585)
1037 2005-08-26 Tor Lillqvist <tml@novell.com>
1039 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1041 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1043 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1045 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1046 of week_start. (#314473, JP Rosevaar)
1048 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1050 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1051 lock. (#314533, Thomas Fitzsimmons)
1053 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1055 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1056 NULL gracefully. (#314523, Ed Catmur)
1058 2005-08-25 Owen Taylor <otaylor@redhat.com>
1060 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1061 Handle theme == NULL.
1063 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1065 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1066 y offset into account when positioning the popup. (#314470,
1069 2005-08-25 Owen Taylor <otaylor@redhat.com>
1071 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1072 as instance_init, not base_init! (#314452, Fix from Frederic
1073 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1074 rather than 1 for a negative flag value.
1076 2005-08-24 Owen Taylor <otaylor@redhat.com>
1078 * gdk/gdkpango.c (draw_error_underline): Add a note about
1079 cut-and-paste between here and Pango.
1081 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1083 * === Released 2.8.2 ===
1085 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1086 callback for image/gif, and also try image/bmp. (#314086, Mark
1089 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1090 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1095 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1096 and cursor settings get propagated down to the screen initially.
1097 Pointed out by Frederic Crozat.
1099 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1100 message if the screen is NULL. Noticed by Kjartan Maraas.
1102 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1106 * === Released 2.8.1 ===
1110 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1112 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1113 against lazy filterers which return values other than TRUE or
1114 FALSE from their visible func. (#314335)
1116 2005-08-23 Owen Taylor <otaylor@redhat.com>
1118 Fix for #314004, reported by Michael Reinsch:
1121 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1122 Add gdk_screen_get/set_resolution_libgtk_only()
1124 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1125 the options for the screen on the newly created context.
1127 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1128 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1129 the font options on the screen.
1131 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1132 the font options from the screen and set them on the context.
1134 2005-08-23 Kristian Rietveld <kris@gtk.org>
1136 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1137 bother inserting new rows in a level with a zero refcount and
1138 immediately free the level. (Fixes #312350, reported by Markku Vire).
1140 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1142 * gtk/updateiconcache.c: Complain when there is no index.theme file
1143 in the specified directory, unless --force is used. Also add an
1144 --index-only option to create caches without image data.
1146 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1147 C99ism. (#314262, Robert Jeff Mitchell)
1149 2005-08-22 Manish Singh <yosh@gimp.org>
1151 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1153 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1155 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1157 * gtk/gtkwindow.c (gtk_window_client_event):
1158 * gtk/gtkicontheme.c (ensure_valid_themes)
1159 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1160 scheme for makeing sure that all GTK+ applications notice if an
1161 icon theme has been updated. This should prevent multiple versions
1162 of an icon theme cache to be mapped in memory at the same time,
1163 which can cause excessive memory consumption. (#313156, Chris
1166 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1168 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1169 regarding icon theme changes.
1171 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1172 pixbufs which are backed by the mmapped memory of an icon cache,
1173 increase the refcount of the icon cache, so that the memory is not
1174 munmapped away underneath the pixbuf upon icon theme changes.
1175 (#314170, Kjartan Maraas)
1177 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1178 to link against Xext. (#314062)
1180 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1181 overruns. (#314081, Hans Breuer)
1183 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1185 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1186 returned layout must not be modified.
1188 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1190 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1191 scroll_to_path if the model changes.
1193 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1194 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1195 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1196 we're realized, #312798
1197 (gtk_icon_view_set_model): clear scroll_to_path if the model
1200 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1202 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1203 (gtk_range_adjustment_value_changed): Don't queue a draw
1204 if the layout has not changed. (#313991, Benjamin Berg)
1206 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1208 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1211 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1214 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1215 (model_add_special, model_add_special, model_add_volumes):
1216 Handle pixbuf being NULL without warnings. Also, don't
1217 leak pixbuf references when the icon theme is changed.
1219 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1220 the user data on destroyed windows, since at best
1221 it can be a stale pointer. (#313953, Robin Green)
1223 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1225 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1226 (#313900, Sebastien Bacher)
1228 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1229 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1231 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1232 (xdnd_read_actions, get_client_window_at_coords_recurse):
1233 Free data returned from XGetWindowProperty.
1235 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1236 Free data returned from XGetWindowProperty. (313867, Kjartan
1239 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1240 children in all cases. (#313862, Kjartan Maraas)
1242 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1243 in the per-directory hash, even if they come from the icon cache.
1244 We tried to avoid that before, but as a result leaked icon data
1245 structs. (#313852, Kjartan Maraas)
1247 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1249 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1250 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1252 2005-08-15 Owen Taylor <otaylor@redhat.com>
1254 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1255 files for x11/xext. (Jonas Bonn)
1257 2005-08-15 Tor Lillqvist <tml@novell.com>
1259 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1262 2005-08-15 Owen Taylor <otaylor@redhat.com>
1264 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1266 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1267 (#313417, James Andrewartha)
1269 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1270 FcNameConstant(). (More of #313417)
1272 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1274 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1275 modal dialogs, make sure to inherit the window group from
1276 the parent, since we don't inherit window groups across
1277 transient parents currently. (#312918, Christian Persch)
1279 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1280 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1282 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1283 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1284 gracefully. (#312796, Jonathan Blandford)
1286 * tests/testtoolbar.c: Add some more tests for menu placement.
1288 * gtk/gtkmenutoolbutton.c (menu_position_func):
1289 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1290 of toolbutton menus and of the overflow menu. (#312937,
1291 #153870, Christian Persch, Paolo Borelli)
1293 2005-08-15 Tor Lillqvist <tml@novell.com>
1295 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1296 the nonportable <libgen.h> and dirname().
1298 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1300 * gtk/gtksizegroup.c: Use object data to mark widgets and
1301 groups as visited, so that we avoid constant extra list
1302 traversals. Also allocate quarks in class_init. (#311618,
1305 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1306 download location for the hicolor icon theme. (#313475, Olexiy
1309 * gtk/gtkicontheme.c: Remove debug spew.
1311 2005-08-15 Owen Taylor <otaylor@redhat.com>
1313 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1314 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1315 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1316 Handle pixmap == NULL when checking for a colormap.
1319 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1321 * gtk/updateiconcache.c: Store only one copy of the pixel data
1322 for symlinked icons. To achieve this, maintain a hashtable
1323 mapping pathnames to pixel data, and share the pixel data for
1324 all symlinks resolving to the same pathname. When writing out
1325 the image data, write out the pixel data only the first time
1326 it is met, and store the offset pointing to the first copy
1327 for use in all later cases.
1328 This reduces the size of the Bluecurve icon cache from 40