1 Tue Dec 6 10:32:17 2005 Tim Janik <timj@gtk.org>
3 * gtk/gtkstatusbar.c: ported memchunk uses to g_slice, so the code
6 2005-12-05 Federico Mena Quintero <federico@ximian.com>
8 * gtk/gtkfilechooserdefault.c (trap_activate_cb): "event->state &
9 modifiers", not "event->state && modifiers". Patch by Sadrul
10 Habib Chowdhury <imadil@gmail.com>. Fixes bug #323073.
12 2005-12-05 Matthias Clasen <mclasen@redhat.com>
16 * gtk/gtktreedatalist.c:
19 * gtk/gtkitemfactory.c:
20 * gtk/gtkseparator.[hc]:
23 * gtk/gtkgc.c: Use g_slice instead of mem chunks.
25 2005-12-05 Michael Natterer <mitch@imendio.com>
27 * gdk/x11/gdkevents-x11.c: map the new GtkSettings properties
28 "timeout-initial", "timeout-repeat", "color-scheme" and
29 "enable-enimations" to X settings.
31 2005-12-05 Matthias Clasen <mclasen@redhat.com>
34 * gdk/gdkcolor.c: Use g_slice instead of mem chunks.
36 * gtk/gtktreeview.c (gtk_tree_view_key_press): Free new_event
37 after sending it to the search entry. (#323209, Crispin Flowerday)
39 * README.in: Add a note about GTK_FLOATING.
41 * gtk/gtkobject.h (GTK_OBJECT_FLOATING): Use g_object_is_floating.
43 2005-12-02 Matthias Clasen <mclasen@redhat.com>
45 * gtk/gtktoolbutton.c (clone_image_menu_size): Don't leak
46 a pixbuf. (#323024, Paolo Borelli)
48 2005-12-02 Matthias Clasen <mclasen@redhat.com>
50 * gtk/gtkfilesystemunix.c (get_icon_for_mime_type): Don't crash
51 if mime_type is NULL. (#322998, Sadrul Habib Chowdhury)
53 2005-12-02 Michael Natterer <mitch@imendio.com>
55 * gtk/gtkmenu.c: applied modified patch from maemo-gtk which
56 adds a "horizontal-padding" style property. Fixes bug #323036.
58 2005-12-01 Michael Natterer <mitch@imendio.com>
60 Merged modified patch from maemo-gtk that allows to disable
61 toolbar animations. Addresses bug #142582.
63 * gtk/gtksettings.c: added boolean property "gtk-enable-animations".
64 (patch from Christian Neumair)
66 * gtk/gtktoolbar.c: don't animate toolbar changes if the settings
67 property is FALSE. Replaced the individual "notify::foo"
68 connections to GtkSettings by a single "notify" callback and
71 2005-12-01 Michael Natterer <mitch@imendio.com>
73 * gtk/gtkmenu.c (gtk_menu_class_init): removed redundant
74 assignment of widget_class->motion_notify_event.
76 2005-11-29 Matthias Clasen <mclasen@redhat.com>
78 * gtk/gtktoggleaction.c (gtk_toggle_action_class_init): Add
79 an active property. (#322673, Jorn Baayen)
81 Properly handle model changes in GtkTreeSelection: (#322569,
84 * gtk/gtktreeselection.c (gtk_tree_selection_selected_foreach):
85 Get a reference to the model, and stop the iteration if the model
86 of the treeview is changed on the way.
88 * gtk/gtktreeprivate.h:
89 * gtk/gtktreeselection.c (_gtk_tree_selection_emit_changed): New
90 private function to emit the GtkTreeSelection::changed signal.
92 * gtk/gtktreeview.c (gtk_tree_view_set_model): Call
93 _gtk_tree_selection_emit_changed() when the model changes.
95 2005-11-28 Federico Mena Quintero <federico@ximian.com>
97 Fixes the critical warnings from bug #317999, thus fixing the bug
100 * gtk/gtkfilechooserdefault.c
101 (gtk_file_chooser_default_get_paths): In SELECT_FOLDER mode,
102 use _gtk_file_chooser_get_current_folder_path() instead of fetching the
103 impl->current_folder directly. The latter may be null if we are
104 in RELOAD_NONE state.
106 2005-11-28 Federico Mena Quintero <federico@ximian.com>
108 Fix bug #321560, based on a patch by Bogdan Nicula (bogdanni@hotmail.com):
110 * gtk/gtkfilechooserdefault.c (up_folder_handler): Don't add the
111 current_folder to the pending select paths here; the path bar will
113 (path_bar_clicked): Add the child_path to the pending select paths
115 (show_and_select_paths): Don't filter out folders.
116 (show_and_select_paths): Don't take separate arguments for
117 only_one_path and multiple paths.
119 * tests/autotestfilechooser.c (test_folder_switch_and_filters):
120 New test about preserving the filters when we change folders.
122 2005-11-28 Matthias Clasen <mclasen@redhat.com>
124 * gtk/gtkscale.c (_gtk_scale_format_value): Insert an LRM, to prevent
125 -20 to come out as 20- in RTL locales. (#322571, Tze'ela Hebron)
127 * gtk/gtkaction.c (gtk_action_sync_button_stock_id)
128 (connect_proxy): Buttons use the label property for stock ids. (#322565,
131 * gtk/gtkiconview.c (update_text_cell, update_pixbuf_cell): Correctly
132 handle the cell list and indices into it. (#321856)
134 2005-11-28 Matthias Clasen <mclasen@redhat.com>
136 * gtk/gtktooltips.c (gtk_tooltips_timeout): Set timer_tag to 0 when
137 the timeout is done. (#322291, Jean-Yves Lefort)
139 2005-11-28 Matthias Clasen <mclasen@redhat.com>
141 * gtk/gtkfilechooserdefault.c (shortcuts_key_press_event_cb): Make
142 F2 work for renaming bookmarks. (#320822, Jaap A. Haitsma, patch
145 2005-11-28 Tor Lillqvist <tml@novell.com>
147 * gdk/win32/gdkwindow-win32.c (gdk_window_set_urgency_hint):
148 Implement the conditional use of FlashWindowEx() properly for MSVC
149 compilations. The code was confusingly assuming that if compiled
150 with a "new" compiler, it will only be run on "new" Windows
151 versions. We want it to run on "old" versions, too, even if
152 compiled with a "new" compiler. There are two orthogonal issues:
153 whether the compiler defines the necessary API in its headers, and
154 whether it is present at run-time. (#318077)
156 * gtk/gtkcalendar.c (gtk_calendar_init): Use GetLocaleInfo() on
157 Windows to get the localized weekday and month names. strftime()
158 in the Microsoft C library returns strings in the default codepage
159 for the locale of the process, not the system codepage. Thus
160 g_locale_to_utf8() isn't useable on the return value from
161 strftime(). (#322603)
163 2005-11-27 Matthias Clasen <mclasen@redhat.com>
165 * gtk/gtkmessagedialog.c (gtk_message_dialog_new_with_markup):
166 Fix an example. (#322493, Elie De Brauwer)
168 Fix two memory handling problems in GtkTreeView: (#322350,
171 * gtk/gtktreeview.c (gtk_tree_view_destroy)
172 (gtk_tree_view_set_model): Remove all references to nodes in
174 (gtk_tree_view_real_collapse_row): Unmark expanded_collapsed_node
175 before removing the children.
177 * gtk/gtkcolorbutton.c (gtk_color_button_init): Don't leak a
178 PangoLayout here. (#322505, Paolo Borelli)
180 2005-11-27 Tor Lillqvist <tml@novell.com>
182 Once again rework Win32 window decoration code. Doesn't break
183 #104514. The dialogs in gtk-demo now have the same decorations and
184 behaviour as on X11. Tried to fix #322516 but it seems very hard
185 to make the trivial sample program there behave as expected. OTOH,
186 simply moving the gtk_window_decorate() call in the #322516 sample
187 program after the call to gtk_widget_show() helps...
189 * gdk/win32/gdkwindow-win32.c (set_or_clear_style_bits): Revert to
190 the correct semantics. Each call to gdk_window_set_decorations()
191 which calls this function is supposed to affect all decorations.
193 (decorate_based_on_hints): New function, looks at both geometry
194 hints and type hint and sets window decorations based on
195 that. Consolidate code from gdk_window_set_geometry_hints() and
196 gdk_window_set_type_hint() here.
198 (gdk_window_set_geometry_hints, gdk_window_set_type_hint): Call
199 decorate_based_on_hints().
201 2005-11-25 Dom Lachowicz <cinamod@hotmail.com>
203 * modules/engines/ms-windows/*.[ch]: Merge with gtk-wimp's CVS.
204 Includes improved menu icon spacing, [+]/[-] expander drawing,
205 status-bar gippie drawing, and notebook tab drawing.
207 2005-11-24 Michael Natterer <mitch@imendio.com>
209 * gtk/gtktoolbar.h (struct _GtkToolbar): changed two private guint
210 that used to hold signal handler IDs to two guint of padding.
212 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): added them as
215 (gtk_toolbar_screen_changed): changed accordingly.
217 Wed Nov 23 18:55:47 2005 Tim Janik <timj@imendio.com>
219 * gtk/gtkobject.[hc]: deprecated floating/sink API and implemented it
220 in terms of the GObject floating/sink API.
222 * gtk/gtkaboutdialog.c:
228 * gtk/gtkfilechooserdefault.c:
230 * gtk/gtkinvisible.c:
231 * gtk/gtkitemfactory.c:
234 * gtk/gtkmenutoolbutton.c:
238 * gtk/gtkspinbutton.c:
239 * gtk/gtkstatusicon.c:
243 * gtk/gtktoolbutton.c:
247 * gtk/gtktreeviewcolumn.c:
248 * gtk/gtkuimanager.c:
252 ported to use GObject's g_object_ref_sink().
255 * gtk/gtkfilechooserdefault.c:
256 * gtk/gtkaboutdialog.c:
257 fixed compiler warnings.
259 2005-11-23 Matthias Clasen <mclasen@redhat.com>
261 * gtk/gtksettings.c (gtk_settings_class_init): Add some docs
262 about gtk-color-scheme.
264 2005-11-23 Behdad Esfahbod <behdad@gnome.org>
266 * configure.in (enable_explicit_deps): Fix typo when checking
267 libtool config deplibs_check_method. Moreover, enable explicit
268 deps if we get anything other than pass_all from libtool. (part of
271 2005-11-23 Matthias Clasen <mclasen@redhat.com>
273 * gtk/updateiconcache.c (write_csource): Don't create a big
274 string, since Visual C++ doesn't like strings longer than 64k.
275 (#322238, Kazuki IWAMOTO
277 * gtk/gtkentry.c: Include gtkimcontextsimple.h (#322235,
280 2005-11-23 Michael Natterer <mitch@imendio.com>
282 * gtk/gtkrc.c (gtk_rc_reset_widgets): don't leak all toplevel
283 windows on other screens (correctly remove all temporary
286 2005-11-23 Michael Natterer <mitch@imendio.com>
288 Added symbolic themable colors. Patch is a merged version of
289 proposals from Matthias and maemo-gtk. Fixes bug #114355.
291 * configure.in: require glib >= 2.9.1 for refcountable hashtables.
293 * gtk/gtksettings.c: added property "color-scheme" which is a
294 string defining colors like "foreground:black\nbackground:grey".
295 Automatically provide a name->GdkColor hash table mapping for the
298 * gtk/gtkrc.[ch]: added list of color hashes that works like the
299 list of icon factories. Append the color scheme hash from
300 GtkSettings if it exists. Extended gtkrc syntax to allow defining
301 and referencing of logical colors. Also allow to modulate colors
302 in gtkrc by using arbitrary expressions of mix(), shade(),
303 lighter() and darker(). Added internal function
304 _gtk_rc_style_get_color_hashes().
306 * gtk/gtkstyle.[ch]: keep a private list of color hashes around.
307 Get the list from _gtk_rc_style_get_color_hashes(). Export
308 internal function _gtk_style_shade() (used by above color
309 expressions). Added public API gtk_style_lookup_color() which
310 looks up a logical color by name.
312 * gtk/gtk.symbols: add gtk_style_lookup_color
314 * tests/testgtkrc: use symbolic colors for making
317 2005-11-22 Michael Natterer <mitch@imendio.com>
319 Made button-press timeouts which work like key repeat timeouts
320 configurable. Addresses bug #142582:
322 * gtk/gtksettings.c: added properties "gtk-timeout-initial" and
323 "gtk-timeout-repeat" which defalt to 200/20 (ms).
325 Use the values from GtkSettings instead of hardcoding them
326 (the repeat value is either taken as-is for fast repeat or
327 multiplied by 5 for slow repeat). Changed all places to use these
328 two standard initial/repeat timings:
330 * gtk/gtkcalendar.c (unchanged 200/20)
331 * gtk/gtknotebook.c (unchanged 200/100)
332 * gtk/gtkpathbar.c (changed from 300/150 to 200/100)
333 * gtk/gtkrange.c (changed from 250/100 to 200/100)
334 * gtk/gtkspinbutton.c (unchanged 200/20)
336 2005-11-21 Anders Carlsson <andersca@imendio.com>
344 * docs/tools/Makefile.am:
345 Only build docshooter when the X11 backend is used.
347 * gtk/gtkplug-stub.c:
348 Include gtkplug.h here.
350 * gtk/gtksocket-stub.c:
351 Include gtksocket.h here.
353 2005-11-21 Matthias Clasen <mclasen@redhat.com>
355 * gtk/gtkinputdialog.c: Convert GtkInputDialog to
356 g_type_class_add_private.
358 * gtk/gtksocket.c: Convert GtkSocket to g_type_class_add_private.
360 * gtk/gtkmenu.c: Convert GtkMenu to g_type_class_add_private.
363 * gtk/gtkcombobox.[hc]: Add a tearoff-title property,
364 with getter and setter. (#316482, Olexiy Avramchenko)
366 * tests/testcombo.c (main): Test gtk_combo_box_set_title
368 * gtk/gtkpathbar.c: Merge remaining fixes from the 2.8 branch,
369 pointed out by Michael Natterer.
371 Fix for bug #321542, Benedikt Meurer:
373 * gtk/gtkcombobox.c (gtk_combo_box_set_active_internal):
376 (gtk_combo_box_child_show, gtk_combo_box_child_hide): Use
377 g_signal_emit, not g_signal_emit_by_name.
379 2005-11-18 Matthias Clasen <mclasen@redhat.com>
381 Fix crashes in connection with pathbar scrolling (#321560,
384 * gtk/gtkpathbar.c (gtk_path_bar_update_slider_buttons):
385 Stop scrolling when desensitising slider buttons.
386 (gtk_path_bar_scroll_timeout, gtk_path_bar_slider_button_press):
389 * gtk/gtkpathbar.h (struct _GtkPathBar): Add a separate
392 2005-11-18 Matthias Clasen <mclasen@redhat.com>
394 * gtk/gtkpathbar.c (button_clicked_cb): Fix a C99ism.
395 (#321777, Jens Granseuer)
397 * gtk/gtkaction.c (disconnect_proxy): Disconnect the
398 sync callback for the visibility property. (#321761,
401 Turn off input methods in invisible entries, since
402 they are confusing. (#317002, James Su)
404 * gtk/gtkentry.c (gtk_entry_set_visibility): Toggle input
405 methods if visibility changes.
406 (popup_targets_received): Don't show the input method
407 menu if the entry is invisible.
409 2005-11-17 Matthias Clasen <mclasen@redhat.com>
411 * README.in: Add a note about range arrow sensitivity.
413 * perf/treeview.c: const correctness fixes
414 found by Arjan van de Ven and gcc.
416 2005-11-16 Michael Natterer <mitch@imendio.com>
418 * gtk/gtkimage.c (animation_timeout): call
419 gtk_window_process_updates() so the animation keeps running even
420 if the main loop is busy with sources that eat a lot of cpu with
421 high priority. Fixes bug #321444.
423 (gtk_image_new_from_animation): document the fact that the
424 animation will stop running if the main loop is busy with sources
425 that have priorities higher than G_PRIORITY_DEFAULT.
427 * tests/testimage.c: added test case that shows an animation even
428 though a cpu-eating idle function is running.
430 2005-11-16 Michael Natterer <mitch@imendio.com>
432 * gdk/x11/gdkevents-x11.c (_gdk_events_uninit): new internal
433 function which destroys the display's event source. Also removes
434 the source from the global display_sources list and unrefs it.
436 * gdk/x11/gdkprivate-x11.h: declare the function.
438 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_dispose): call it
439 instead of half-destroying the source here.
441 2005-11-15 Matthias Clasen <mclasen@redhat.com>
443 * gtk/gtktreestore.c (gtk_tree_store_move): Fix a memory
444 leak. (#321032, Peter Zelezny)
446 2005-11-15 Michael Natterer <mitch@imendio.com>
448 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_finalize): destroy
449 display->xid_ht as late as possible (right before XCloseDisplay)
450 because it still needs to be around when the display's screens are
453 2005-11-14 Matthias Clasen <mclasen@redhat.com>
455 * gtk/gtkselection.c (gtk_selection_data_set_uris): Don't
456 leak result. (#321441, Tommi Komulainen)
458 2005-11-14 Matthias Clasen <mclasen@redhat.com>
460 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes):
461 Don't crash if there is no builtin icon.
463 2005-11-14 Michael Natterer <mitch@imendio.com>
465 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_set_property):
466 removed redundant calls to g_object_notify().
468 2005-11-13 Matthias Clasen <mclasen@redhat.com>
470 * gdk/gdkcolor.c (gdk_color_parse): Documentation
471 improvements. (#321338)
473 * gtk/gtktextiter.c (gtk_text_iter_forward_search): Make
474 limit an inclusive boundary. (#321299)
476 2005-11-12 Michael Natterer <mitch@imendio.com>
478 * gtk/Makefile.am: fixed icon rules so gtkbuiltincache.h is only
481 2005-11-12 Dom Lachowicz <cinamod@hotmail.com>
483 * modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
484 theme's handling of toolbars, handleboxes, and menubars more in-line
485 with Microsoft's IE style.
486 * modules/engines/ms-windows/*.c: Indentation cleanups
488 2005-11-12 Matthias Clasen <mclasen@redhat.com>
490 Make builtin icons work in gtk_window_set_icon_name()
491 (#321046, Maxim Udushlivy)
493 * gtk/gtkicontheme.c (insert_theme): Always insert the default
495 (ensure_valid_themes): Call _gtk_icon_theme_ensure_builtin_cache()
497 (theme_lookup_icon, find_builtin_icon): ...and not from here.
498 (gtk_icon_theme_lookup_icon): Remove an unncessary assert.
499 (gtk_icon_theme_get_icon_sizes): Also check builtin icons.
501 2005-11-12 Tor Lillqvist <tml@novell.com>
503 * gtk/gtkfilesystemwin32.c (filename_get_info): Don't hide
504 dotfiles, no such convention on Win32. Just hide files with the
505 hidden attribute. (#314627)
507 2005-11-11 Federico Mena Quintero <federico@ximian.com>
509 * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Do not
510 check whether the path is a folder. It is useful to bookmark
511 files as well (e.g. todo.txt), and this will also help
513 (shortcuts_add_bookmark_from_path): Likewise.
514 (shortcuts_activate_iter): Change folders or select files, as
517 2005-11-11 Federico Mena Quintero <federico@ximian.com>
519 * tests/autotestfilechooser.c (main): Use
520 g_log_set_default_handler() instead of explicitly setting a
521 handler for each domain.
523 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Only get
524 the base path of the volume if it is mounted.
526 2005-11-11 Michael Natterer <mitch@imendio.com>
528 Added per-stepper API for GtkRange's stepper sensitivity as
529 discussed in bug #321056:
531 * gtk/gtkenums.h: added GtkSensitivityType which can be
534 * gtk/gtkrange.[ch]: added properties "lower-stepper-sensitivity"
535 and "upper-stepper-sensitivity" and public getters/setters for
536 them. Changed stepper drawing to honor the new properties.
538 * gtk/gtk.symbols: added the new symbols.
540 2005-11-10 Matthias Clasen <mclasen@redhat.com>
542 * gtk/gtkcombobox.c: Add show-popup and hide-popup signals and
543 emit them when the popup is shown or hidden. (#162531, Tommi
546 * tests/testcombo.c: Add an example of popuplating a combobox
549 * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Another
552 * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
555 Don't corrupt odd keymaps (#316638, Kean Johnston)
557 * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
558 handle frobbing keymaps with odd numbers of syms/code.
560 * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
563 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
565 * gtk/gtkpathbar.[hc]: Add a child_path argument to
566 the path_clicked signal.
567 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
568 child_path, if it is provided.
569 * gtk/marshalers.list (path_bar_clicked): Add the necessary
572 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
577 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
578 (#163851, Richard Hult)
580 2005-11-10 Michael Natterer <mitch@imendio.com>
582 Applied patch from maemo-gtk that addresses many issues wrt
583 display migration and display closing (bug #85715).
585 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
586 default display to NULL when it's closed. Instead set the most
587 recently opened display as new default (if one exists).
589 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
592 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
593 exist before unrefing them.
595 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
596 is closed, allow destruction of the root window.
598 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
599 dispose(), free stuff that was leaked before.
601 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
602 the xsettings_client still exists before destroying it.
604 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
607 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
608 dispose() implementation.
610 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
611 dispose() and check if it still exists before unrefing it. Set
612 their pointers to NULL/None *after* upchaining in dispose(),
613 because X11 implementations of members of the parent class still
614 need them for their own destruction.
616 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
617 was g_error()ing when finalizing a visual.
619 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
620 get_clipboard_widget() because it would create the widget if it
621 doesn't exist. Use g_object_get_data() directly instead.
623 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
626 2005-11-10 Simos Xenitellis <simos@gnome.org>
628 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
630 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
632 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
633 to render its arrows insensitive when the adjustment is in
634 its min or max position. this makes range arrow behaviour
635 consistent with spin button behaviour. (#321056)
637 2005-11-09 Tor Lillqvist <tml@novell.com>
640 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
641 the GdkDebugFlag enum.
643 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
644 this file instead of MISC. Now asking for MISC will give mainly
645 window manipulation debugging output with the Win32 backend.
647 2005-11-09 Tor Lillqvist <tml@novell.com>
649 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
651 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
652 function which was used only in one place.
654 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
656 (gdk_window_set_geometry_hints): If we have identical minimum and
657 maximum size hints, remove the resize and maximize
658 decorations/functions. (#104514)
660 If we have a maximum size hint, remove the maximize
661 decoration/function but ensure the resize decoration/function is
662 available. Otherwise ensure both resize and maximize
663 decorations/functions are there.
665 (set_or_clear_style_bits): Factored out common code from
666 gdk_window_set_decorations() and gdk_window_set_functions().
668 Hack the window style setting once more: Only touch the window
669 style bits corresponding to the GdkWMDecoration or GdkWMFunction
670 parameter bitmasks. Hopefully this finally is the correct thing to
671 do. We used to clear all other bits than those that were being
672 set, or set all other bits than those that were being cleared.
674 Take into account that adding or removing decorations leaves the
675 window's outer size unchanged, i.e., the client area's size and
676 position change. This is apparently not what we want, so change
677 also the window's (outer) position and size appropriately so that
678 the client area's position and size stay constant.
680 gtk-demo's color selector dialog is now non-resizable like on X11
681 (I tested with metacity in GNOME). Torn off menus are shrinkable
682 vertically but have a maximum size, and are not maximizable or
683 minimizable, like on X11.
685 (gdk_window_set_decorations, gdk_window_set_functions): Let
686 set_or_clear_decorations() do most of the job.
688 * gdk/win32/gdkprivate-win32.h: Remove declaration of
689 _gdk_win32_get_adjusted_client_rect().
691 2005-11-09 Tor Lillqvist <tml@novell.com>
693 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
694 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
695 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
696 type hint. Implement gdk_window_get_type_hint() by just returning
699 2005-11-09 Tor Lillqvist <tml@novell.com>
701 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
702 Remove code that has been permanently ifdeffed out for two years.
704 2005-11-08 Matthias Clasen <mclasen@redhat.com>
706 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
707 finalizing a gc. (#320789, Nickolay V. Shmyrev)
709 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
710 icons if they would make the request large enough to cause
711 Xlib to loose the connection. (#320909, Claudio Saavedra)
713 2005-11-08 Michael Natterer <mitch@imendio.com>
717 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
718 extracted from maemo-gtk). Fixes bug #320872.
720 2005-11-07 Matthias Clasen <mclasen@redhat.com>
722 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
723 looks the bookmark label when reordering. (#320720, Jeremy Cook)
725 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
726 Don't grab focus when a slider button is pressed, instead, use
727 a bit in the pathbar struct to determine whether to scroll up
728 or down. (#314486, Carlos Garnacho)
730 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
731 Don't popup the completions if the focus has already been
732 moved somewhere else. (#319914, Christian Persch)
734 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
735 Raise the drag_window after reconfiguring the
736 toolbar. (#320803, Christian Persch)
739 * gtk/gtkfilechooserbutton.h:
740 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
741 with setter and getter. (#318945, Christian Persch)
743 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
745 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
747 2005-11-07 Matthias Clasen <mclasen@redhat.com>
749 * configure.in: Adjust to the stock icon changes.
751 2005-11-07 Tor Lillqvist <tml@novell.com>
753 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
754 Correct the calculation of maskstride. (#320152, Peter Zelezny)
756 2005-11-06 Michael Natterer <mitch@imendio.com>
758 * gtk/Makefile.am (icons): fixed rule to actually create the
759 symlinks, erroring out if anything goes wrong.
761 2005-11-06 Tor Lillqvist <tml@novell.com>
763 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
764 target exists on Win32. First rename the target temporarily, then
765 if the renaming of the source to target fails, restore the
766 original name for the target.
768 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
770 2005-11-06 Tor Lillqvist <tml@novell.com>
772 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
773 like pixbuf_to_hbitmaps_normal().
774 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
775 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
776 setting the G_WIN32_PRETEND_WIN9X environment variable.
778 2005-11-06 Tor Lillqvist <tml@novell.com>
780 Make icon masks work on Win98 (#320152, Peter Zelezny)
782 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
783 parameter for the depth of the bitmap, so that this function can
784 be used to create 1-bit bitmaps, too.
785 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
786 and initialize it properly.
788 2005-11-04 Matthias Clasen <mclasen@redhat.com>
790 Store builtin stock icons in an icon cache, instead of
791 populating a hash table with pixbufs at startup, to save both
792 memory and startup time.
794 * gtk/stock-icons/*: Reorganize the icons in a directory structure
795 suitable for gtk-update-icon-cache, and rename them to match the
798 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
799 add _gtk_icon_cache_has_icon_in_directory().
801 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
802 to store the contents of the icon cache in a C header.
804 * gtk/gtkbuiltincache.h: Generated private header which contains
805 the icon cache for the builtin icons.
807 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
808 icons, and use that in addition to the hash table whenever
809 builtin icons are searched.
811 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
812 use it for static stock ids.
813 (get_default_icons): Don't add the builtin
814 icons to the icon theme, just register the stock ids.
815 (render_fallback_image): Take the fallback image out of the
818 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
819 the necessary machinery to rebuild gtkbuiltincache.h.
821 2005-11-04 Michael Natterer <mitch@imendio.com>
823 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
824 from maemo-gtk that changes the mtime check for rc files from
825 '>' to '!=', otherwise theme changes go unnoticed when turning
826 back the clock (Tommi Komulainen).
828 2005-11-04 Tor Lillqvist <tml@novell.com>
830 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
833 2005-11-03 Tor Lillqvist <tml@novell.com>
835 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
836 the Win32 backend, check that GdkDisplay* parameters are equal to
837 _gdk_display instead of using the unnecessarily general
840 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
841 color bitmap to have "color" in their name, for similarity with
842 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
843 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
844 the mask bitmap's contents, ones for those pixels in the color
845 bitmap where the alpha is zero, zero for other pixels. We used to
846 use an uninitialized mask bitmap! This meant that icons and
847 cursors created presumably worked more or less by accident.
848 Totally blank icons with zero alpha everywhere (as used by
849 gtktrayicon.c) definitely did not work as expected.
851 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
853 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
854 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
855 necessary and can be removed from CVS. It has never been mentioned
856 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
857 are used on Win32. One label widget is used (but never shown) as
858 gtk_widget_render_icon() needs a widget.
860 Ifdefs used as necessary in several places. It might be cleaner to
861 split out the backend-specific parts to separate files, or at
862 least collect them into separate blocks in the file.
864 (wndproc): New function. Window procedure to monitor mouse events
865 in the system tray icon. Call gtk_status_icon_button_press() as
867 (create_tray_observer): New function. Creates a hidden window that
868 only serves as a tray icon message observer.
870 * tests/teststatusicon.c (icon_activated): Position the dialog
871 with GTK_WIN_POS_CENTER.
872 (do_quit): New function, hide and unref the GtkStatusIcon, and
873 call gtk_main_quit().
874 (popup_menu): Add a Quit menu item that calls do_quit().
876 2005-11-02 Tor Lillqvist <tml@novell.com>
878 * gdk/win32/gdkcolor-win32.c
879 * gdk/win32/gdkscreen-win32.c
880 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
881 fixes. Remove superfluous test for GdkWindow* parameters being
882 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
883 GdkScreen and one GdkDisplay in the Win32 backend, use those
884 variables instead of the getter functions. For GdkDisplay* and
885 GdkScreen* parameters, check that they are equal to the
886 corresponding singleton variables instead of the more general
887 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
889 2005-11-02 Matthias Clasen <mclasen@redhat.com>
891 * gtk/gtktextview.c: Remove some g_return_if_fail() from
892 static functions, replace some others by g_assert().
894 * gtk/gtktextview.c (selection_motion_event_handler)
895 (gtk_text_view_start_selection_drag): Keep track of the original
896 selection boundaries during a drag selection, in order to correctly
897 decide when to extend or shrink the selection. (#320167,
898 reported by Arvind S N, patch by Paolo Borelli)
900 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
901 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
902 manual offset calculations by g_utf8_offset_to_pointer().
903 (#320360, Paolo Borelli)
905 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
907 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
908 nodes via the g_slice_*() API.
909 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
911 2005-11-01 Tor Lillqvist <tml@novell.com>
913 * gdk/win32/gdkprivate-win32.h
914 * gdk/win32/gdkglobals-win32.c
915 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
916 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
917 their declarations, definitions and assignments into a more
918 logical and consistent order.
920 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
921 CF_ prefix for the predefined clipboard format names. Put quotes
922 around registered format names to distinguish them.
924 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
925 immediately with a warning if the property type is STRING, TEXT,
926 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
927 should never pretend to handle on Win32. Handle only UTF8_STRING
928 here, other formats with delayed rendering. Use \uc1 instead of
929 \uc0 when generating Rich Text Format for easier testability on
930 XP, where WordPad misinterprets \uc0 encoded characters. Add more
931 GDK_NOTE debugging output for Clipboard operations.
933 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
934 (gdk_selection_convert): Don't pretent to handle STRING, just
935 UTF8_STRING. Streamline error handling, don't unnecessarily have a
936 GError which then isn't used for anything anyway if it gets set.
937 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
938 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
940 * config.h.win32.in: Sync with what configure produces.
942 * configure.in: Don't look for X_PACKAGES unless building for
943 x11. (#313986, John Ehresman)
945 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
947 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
948 Wondered why there was no ku there before??
950 2005-10-28 Matthias Clasen <mclasen@redhat.com>
952 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
953 window to the toplevels window group. (#319912, Christian Persch)
955 2005-10-28 Kristian Rietveld <kris@gtk.org>
957 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
960 2005-10-28 Matthias Clasen <mclasen@redhat.com>
962 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
963 drag cursors. (#319200, Federico Mena Quintero)
965 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
966 Shift-G to go to the previous match, like firefox. (#320061, Christian
969 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
970 C99ism. (#320000, Kazuki Iwamoto)
972 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
973 stars. (#319985, Bastien Nocera)
975 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
976 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
978 2005-10-26 Michael Natterer <mitch@imendio.com>
982 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
983 make sure that setting any of pixbuf/stock-id/icon-name resets the
984 others because they are mutually exclusive, and that unsetting any
985 of them only resets the pixbuf and nothing else. Also added
986 some missing g_object_notify().
988 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
989 g_value_set_object().
991 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
992 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
993 g_object_notify ("pixbuf").
995 2005-10-27 Matthias Clasen <mclasen@redhat.com>
997 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
998 careful about initializing cell_area. (#319382, Tommi
1001 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
1002 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
1004 * demos/gtk-demo/clipboard.c (paste_received): Only set the
1005 text if it is not NULL. (#319930, Thomas Klausner)
1007 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
1008 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
1010 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1012 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
1013 * gtk/gtkthemes.c (gtk_theme_engine_load):
1014 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
1015 when dlopening modules. (#319557, Laszlo Peter)
1017 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1019 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
1020 segments when determining text direction. (#319065, Tommi Komulainen)
1022 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
1023 on duplicate destroy. (#318953, Gustavo Carneiro)
1025 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
1026 Point out that destroy-with-parent is a bad idea for the dialog
1027 passed to this function. (#318943, Christian Persch)
1029 * */Makefile.am: use $(GLIB_MKENUMS) instead of
1030 glib-mkenums. (#318582, Damien Carbery)
1032 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
1033 docs. (#317682, Christian Neumair)
1035 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
1036 seem to affect the placement of the data in the readonly
1037 section, and causes problems with some compilers. (#317844)
1039 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1041 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
1042 Fix some issues with background drawing in RTL. (#318781,
1045 * tests/Makefile.am:
1046 * tests/testentrycompletion.c: Apply a patch by Christian
1047 Persch to add property editors.
1049 * gtk/gtkstatusicon.c: Emit activate on single-click,
1050 not on double-click, change proposed by Milosz Derezynski.
1052 2005-10-25 Kristian Rietveld <kris@gtk.org>
1054 Fixes #311955, reported by Markku Vire; and a lot more.
1056 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
1057 Levels can now have invisible nodes cached, functions have been
1058 rewritten/refactored to take this into account; also the logic in
1059 some functions has been corrected.
1061 Each referenced node now references all visible children or a single
1062 invisible child, in order to be able to monitor all changes in the
1063 child model required for correct operation.
1065 When a virtual root is set, all nodes on the virtual root level are
1068 At last, a bunch of random bug fixes and comment updates.
1070 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1072 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
1073 more docs. (#319722, Paolo Borelli)
1075 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
1076 initialization of screen_x11->xft_rgba more explicit. (#319627,
1079 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
1080 in a blurb. (#319499, Francisco Javier F. Serrador)
1082 2005-10-24 Matthias Clasen <mclasen@redhat.com>
1084 Add settings to hide the input method and Unicode control character
1085 submenus in the context menus of GtkEntry and GtkTextView.
1087 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
1089 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
1091 * gtk/gtktextview.c (popup_targets_received):
1092 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
1094 2005-10-24 Kristian Rietveld <kris@gtk.org>
1096 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
1097 row-has-child-toggled when the level is not in the cache does not
1098 make sense. (This bug probably crept in during the early stages
1099 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
1100 implementation yet),
1101 (gtk_tree_model_sort_real_unref_node): only get the child iter
1102 when we will actually also use it.
1104 2005-10-22 Michael Natterer <mitch@imendio.com>
1106 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
1107 widget being realized, in addition to being visible, to avoid
1108 running into precondition check in gtk_tree_view_get_cell_area().
1111 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
1113 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
1114 Experimentally, scrollbar steppers can shrink to 8 pixels on
1115 Win32. Reflect that in the theme.
1116 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
1117 there is a 1-pixel border between a scrollbar and its child
1118 in ScrolledWindows on Win32. Reflect that in the theme.
1120 2005-10-20 Matthias Clasen <mclasen@redhat.com>
1122 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
1123 for the selection window. (#318806, Alex Larsson)
1125 2005-10-18 Federico Mena Quintero <federico@ximian.com>
1129 * tests/autotestfilechooser.c
1130 (test_button_folder_states_for_action): Test that we have either
1131 $cwd or the explicitly-set folder.
1132 (test_reload_sequence): Likewise.
1134 * gtk/gtkfilechooserdefault.c
1135 (gtk_file_chooser_default_get_current_folder): If our reload_state
1136 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
1138 2005-10-14 Tor Lillqvist <tml@novell.com>
1140 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
1141 It didn't really do anything useful, and was just confusing and
1142 incomplete. Comments claimed we don't do delayed rendering, but in
1143 fact we do, for images. (The delayed rendering code has other
1144 problems, though, see #168173.) The clipboard viewer code was
1145 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
1146 the message when necessary). It was just test code, it said so in
1147 a comment. Add something similar back later if necessary.
1149 (_win32_on_clipboard_change,
1150 _gdk_win32_register_clipboard_notification): Remove.
1152 (gdk_display_supports_selection_notification,
1153 gdk_display_request_selection_notification): Always just return
1154 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
1156 2005-10-13 Tor Lillqvist <tml@novell.com>
1158 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
1159 Alt-Enter specially. It does not have any special meaning and
1160 should be passed on to the application. (#318378, Tim Evans)
1162 2005-10-13 Tor Lillqvist <tml@novell.com>
1164 Set visual depth to 24 for 32 bits-per-pixel devices on
1165 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
1166 optimized composite_0888() function rather than the slower image
1167 dithering functions to draw pixbufs (#313993, John Ehresman)
1169 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
1170 _gdk_windowing_get_bits_for_depth() to initialize
1171 GdkImage::bits_per_pixel.
1172 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
1174 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
1175 _gdk_windowing_get_bits_for_depth() to initialize
1176 BITMAPINFOHEADER::biBitCount.
1178 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
1179 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
1182 2005-10-12 Stefan Kost <ensonic@users.sf.net>
1184 * demos/gtk-demo/appwindow.c: (about_cb):
1185 use PACKAGE_VERSION,bump year (#318654)
1187 2005-10-11 Matthias Clasen <mclasen@redhat.com>
1189 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
1190 toggle here with the matching on toggle if it immediately follows.
1191 This is a common case, and handling it here prevents quadratic blowup
1192 in cleanup_line() below. (#317125)
1194 * gtk/gtktextsegment.h:
1195 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
1196 the character counts into this function instead of computing them
1199 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
1201 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
1203 * gtk/gtkfilechooserdefault.c
1204 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
1205 when the shortcut already exists in the sidebar. (#147521)
1207 2005-10-09 Matthias Clasen <mclasen@redhat.com>
1209 * tests/testcombo.c: Demonstrate how to use custom widgets in
1212 2005-10-07 Federico Mena Quintero <federico@ximian.com>
1216 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
1217 the the result of gtk_file_chooser_get_folder() is NULL or
1218 non-NULL at the right times. Log the tests.
1219 (test_button_folder_states): New test for the initial states of
1220 the current folder in GtkFileChooserButton.
1221 (main): Test that the number of warnings/errors/critical errors is
1224 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
1225 Clarify the documentation on when this can return NULL.
1226 (gtk_file_chooser_get_current_folder_uri): Likewise.
1228 * gtk/gtkfilechooserbutton.c (struct
1229 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
1230 we use it to keep track of whether a folder has been set.
1231 (gtk_file_chooser_button_map): Implement. If no folder has been
1232 loaded before, we at least try to load $cwd here.
1233 (gtk_file_chooser_button_constructor): If the construct-time
1234 dialog already has a folder set, turn on our folder_has_been_set
1236 (dialog_current_folder_changed_cb): Turn on our
1237 folder_has_been_set flag.
1239 2005-10-07 Michael Natterer <mitch@gimp.org>
1241 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
1242 PROFILE_FILE_CHOOSER because they break compilation after the
1243 removal of <unistd.h>.
1245 2005-10-07 Matthias Clasen <mclasen@redhat.com>
1247 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
1248 by moving it out of the profiling ifdef.
1250 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
1251 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
1253 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
1254 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
1257 2005-10-06 Matthias Clasen <mclasen@redhat.com>
1260 * gtk/gtktextbuffer.h:
1261 * gtk/gtktextbuffer.c: Add a readonly has-selection property
1262 with a getter. (#318161, Paolo Borelli)
1264 2005-10-05 Matthias Clasen <mclasen@redhat.com>
1266 * README.in: Start collecting release notes for 2.10.
1268 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
1269 leak fix, since the assertion failures were traced to
1270 an xchat bug. (#314696)
1272 * gtk/gtkstyle.c (gtk_style_detach):
1273 (gtk_style_attach): Documentation improvements.
1274 (gtk_style_detach): Assert that the attach_count is > 0.
1276 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1278 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
1279 shortcut position, not a ShortcutsIndex, to make the function more
1281 (home_folder_handler): Pass the resolved index to
1282 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
1283 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
1284 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
1285 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
1286 make the respective key switch to the first, second, ..., tenth
1288 (quick_bookmark_handler): Implement.
1290 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1292 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
1293 Desktop; just use their real names on the file system for the
1296 * gtk/gtkfilechooserdefault.c
1297 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
1298 binding signal, and bind it to M-d by default.
1299 (desktop_folder_handler): Implement the default handler.
1300 (home_folder_handler): Use a helper function.
1301 (switch_to_shortcut): New helper function.
1302 (shortcuts_append_home): Don't special-case the name of "Home";
1303 just use the folder name.
1305 2005-10-04 Tor Lillqvist <tml@novell.com>
1307 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
1308 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
1310 2005-10-04 Matthias Clasen <mclasen@redhat.com>
1312 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
1313 from yesterday, since it leads to assertion failures. (#317879,
1316 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1318 * gtk/gtkcalendar.c (gtk_calendar_init): Call
1319 calendar_compute_days() after setting priv->week_start.
1321 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1323 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
1324 removing it from the hash table. (#314696, Benjamin Berg)
1326 2005-10-01 Tor Lillqvist <tml@novell.com>
1328 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
1329 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
1330 is that the the desktop isn't visible because the session has been
1331 switched, the screen is locked, or a terminal server session
1332 disconnected, so no error message necessary. (#137796)
1334 It is of course remotely possible that BitBlt() failing with
1335 ERROR_INVALID_HANDLE might also be caused by some other
1336 problem. We could strive for perfection and track whether the
1337 desktop is visible by using WTSRegisterSessionNotification() and
1338 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
1339 this issue, though. If we would track desktop visibility, we
1340 should then avoid even trying to update the display at all while
1341 the desktop isn't visible.
1343 2005-09-30 Matthias Clasen <mclasen@redhat.com>
1345 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
1346 to correct the calculations for the first week day. We may
1347 just have to remove this code if too many locales turn out
1348 to have broken data.
1350 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
1351 some cases. (#317611, Tommi Komulainen)
1353 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
1354 Prevent overflow when storing size hints in an unsigned
1355 short variable. Tracked down by Ray Strode and Søren Sandmann.
1357 2005-09-29 Matthias Clasen <mclasen@redhat.com>
1359 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
1362 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
1363 grab shadowed. (#317332)
1365 2005-09-29 Tor Lillqvist <tml@novell.com>
1367 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
1369 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1371 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
1372 if the unmap test fails.
1373 (test_reload_sequence): Use gtk_widget_show_now() instead of
1374 gtk_widget_show() for the dialog.
1375 Thanks to Tim Janik for noticing these.
1377 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1379 * tests/testcellrenderertext.c: New file with a set of tests for
1380 GtkCellRendererText. The idea is to run a text renderer through
1381 most of its interesting property values to see that it works
1384 * tests/Makefile.am: Added testcellrenderertext.
1386 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
1387 entry/exit of this function for profiling.
1388 (gtk_file_chooser_default_style_set): Mark the start/end of the
1389 calls to the parent class and the the signal emission for profiling.
1391 2005-09-29 Tor Lillqvist <tml@novell.com>
1393 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
1394 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
1395 system codepage using g_win32_locale_filename_from_utf8().
1396 (#317457, Kazuki Iwamoto)
1398 2005-09-28 Matthias Clasen <mclasen@redhat.com>
1400 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
1401 here. (#317039, Paolo Borelli)
1404 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
1405 to make this function work as boxed copy function. (#317455,
1408 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
1409 NULL. (#316828, Tor Lillqvist)
1411 2005-09-28 Tor Lillqvist <tml@novell.com>
1413 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
1416 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1418 Don't reload the current folder unnecessarily on ::map().
1420 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
1421 the reloading state.
1422 (struct _GtkFileChooserDefault): Added a "reload_state" field.
1424 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
1425 Initialize impl->reload_state.
1426 (gtk_file_chooser_default_map): Check the impl->reload_state; load
1427 a default folder if no folder has been set, or reload the current
1428 one only if we had been unmapped first.
1429 (gtk_file_chooser_default_update_current_folder): Set the
1430 reload_state to RELOAD_HAS_FOLDER.
1431 (gtk_file_chooser_default_unmap): Implement, and set the
1432 reload_state to RELOAD_WAS_UNMAPPED.
1433 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
1434 here; they'll get (re)loaded on ::map() anyway.
1436 * gtk/gtkfilechooserwidget.c
1437 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
1439 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
1440 a dialog; build it ourselves.
1441 (test_reload): New test to ensure that we don't load the default
1442 folder more than once, and that we reload it when
1443 unmapping/remapping.
1444 (get_impl_from_dialog): New utility function.
1445 (test_widgets_for_current_action): Use get_impl_from_dialog().
1447 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1449 * gtk/gtkfilechooserdefault.c
1450 (gtk_file_chooser_default_constructor): Mark the entry/exit of
1451 this function for profiling.
1452 (check_icon_theme): Likewise.
1453 (change_icon_theme): Likewise.
1454 (settings_notify_cb): Likewise.
1455 (gtk_file_chooser_default_screen_changed): Likewise.
1456 (update_chooser_entry): If the selection is empty, clear the file
1457 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
1458 nothing will be selected when the user starts typeahead in the
1459 treeview, and we don't want to clear the file name entry in that
1460 case --- the user could be typing-ahead to look for a folder name.
1461 Fixes bug #308332, patch by Jürg Billeter.
1463 2005-09-27 Matthias Clasen <mclasen@redhat.com>
1465 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1466 Pop below the entry if there's more free space below the entry
1467 than above. (#316948, Tommi Komulainen)
1469 2005-09-26 Federico Mena Quintero <federico@ximian.com>
1471 Do not create the save mode-specific widgets in the open modes, so
1472 that we don't carry their baggage around.
1474 * gtk/gtkfilechooserdefault.c
1475 (gtk_file_chooser_default_constructor): Don't create the
1477 (save_widgets_create): Set the impl->save_widgets directly here,
1478 instead of passing the widgets back to the caller. Also, pack
1479 them into the impl's box.
1480 (update_appearance): Create or destroy the save widgets as
1481 appropriate. Set the action of the save_file_name_entry here.
1482 (shortcuts_add_current_folder): Set the active item in the
1483 save_folder_combo only if it exists.
1484 (gtk_file_chooser_default_set_property): Don't set the action of
1485 the save_file_name_entry here.
1486 (gtk_file_chooser_default_update_current_folder): Set the base
1487 folder of the save_file_name_entry only if the entry exists.
1488 (shortcuts_drag_data_received_cb): Cast the selection_data->data
1489 to (const char *) since that's what shortcuts_drop_uris() expects.
1490 (file_list_drag_data_received_cb): Likewise, for
1491 g_uri_list_extract_uris().
1493 2005-09-26 Tor Lillqvist <tml@novell.com>
1495 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
1496 the shaped flag here, too. (#316871)
1497 (gdk_window_shape_combine_region): Currently unimplemented, so
1498 don't do anything to the shaped flag here.
1500 2005-09-26 Matthias Clasen <mclasen@redhat.com>
1502 Fix #316871, reported by Dan Winship:
1504 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
1506 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
1507 (gdk_window_shape_combine_region): Set it here.
1509 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
1510 remove the child area for shaped windows.
1512 2005-09-23 Matthias Clasen <mclasen@redhat.com>
1514 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
1515 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
1517 2005-09-22 Michael Natterer <mitch@imendio.com>
1519 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
1520 consistent with GTK+ terminology:
1522 * gtk/gtkcellrendererkeys.[ch]
1523 * tests/testkeys.c: removed...
1525 * gtk/gtkcellrendereraccel.[ch]
1526 * tests/testaccel.c: ...and added.
1531 * tests/Makefile.am: changed accordingly.
1533 2005-09-22 Matthias Clasen <mclasen@redhat.com>
1535 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
1536 for the grab-broken-event signal, noticed by Damon Chaplin.
1538 2005-09-21 Tor Lillqvist <tml@novell.com>
1540 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
1541 gdk_text_property_to_text_list_for_display,
1542 gdk_text_property_to_utf8_list_for_display,
1543 gdk_win32_selection_add_targets,
1544 _gdk_win32_selection_convert_to_dib): Free return value from
1546 (gdk_text_property_to_text_list_for_display): Drop GError variable
1547 that isn't actually used after being set.
1549 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
1551 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
1554 2005-09-20 Tor Lillqvist <tml@novell.com>
1556 * gdk/win32/gdkselection-win32.c
1557 (gdk_selection_owner_get_for_display): Do return the correct owner
1558 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
1559 a window GDK knows about). The reason to return NULL seems to have
1560 gone when in the fix for bug #163702 the artificial
1561 GDK_SELECTION_CLEAR event generation was removed from
1562 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1564 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1566 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1567 events. (#151555, Søren Sandmann)
1569 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1570 XkbSelectEventDetails() to select XkbStateNotify events
1571 for only the state we care about.
1573 * gdk/x11/gdkprivate-x11.h:
1574 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1575 the event into the function and update the keymap state from
1576 the state information contained in the event. Adjust all callers.
1578 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1580 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1581 in multiple places to avoid segfaults if the index is out of range.
1582 (#316422, Guillaume Cottenceau)
1583 (gtk_icon_view_set_drag_dest_item):
1584 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1585 #316424, Guillaume Cottenceau)
1587 2005-09-18 Hans Breuer <hans@breuer.org>
1589 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1590 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1592 2005-09-18 Hans Breuer <hans@breuer.org>
1594 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1595 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1596 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1597 the icon and is blinking with teststatusicon. More to come ...
1599 2005-09-18 Hans Breuer <hans@breuer.org>
1601 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1602 cause gtkprogressbar.c has #include <config.h> conditionally; less
1603 noise from generated gtk.def
1604 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1606 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1607 For me it works as well as the *NIX implemenation, that is not at all.
1609 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1611 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1612 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1613 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1614 again - if compiled properly.
1616 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1617 already coming with Gtk+. Makes it compile on win32.
1619 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1621 * README.cvs-commits: fixed some tiny typos
1623 2005-09-16 Tor Lillqvist <tml@novell.com>
1625 * modules/engines/ms-windows/msw_style.c (draw_extension,
1626 draw_box_gap): Check whether the widget actually is a GtkNotebook
1627 before treating it as such. Drop some unneeded local variables,
1628 use parameter with same information instead. (#316412)
1630 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1632 * tests/autotestfilechooser.c: Start a set of automated tests for
1633 the file chooser. The only test in there right now doesn't pass
1634 yet. It specifies the intended behavior of the first optimization
1635 of a series which I'll do on the file chooser (see
1636 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1637 details of this optimization).
1639 * tests/Makefile.am: Added autotestfilechooser.c.
1641 * gtk/gtkfilechooserprivate.h (struct
1642 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1643 structures to here, so that they can be accessed by
1644 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1645 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1647 * gtk/gtkfilechooserdialog.c: See above.
1649 * gtk/gtkfilechooserwidget.c: See above.
1651 * gtk/gtkfilechooserdefault.c: See above.
1653 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1656 gtk_window_map_event(): new function to work around lost unmap requests.
1659 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1661 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1662 an easy-to-find profiling marker when starting to create a file
1664 (browse_files_model_finished_loading_cb): Likewise, for when the
1665 chooser is finished loading.
1667 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1669 * gtk/gtkcolorbutton.c: Check "color" argument in
1670 gtk_color_button_set_color ()
1672 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1674 * gtk/gtklabel.c (gtk_label_get_type):
1675 * gtk/gtkbutton.c (gtk_button_get_type):
1676 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1677 using a mem chunk for window groups, buttons, labels.
1679 * gtk/updateiconcache.c (foreach_remove_func): Fix
1680 a use-after-free bug. (#316256, Alexander Nedotsukov)
1682 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1684 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1686 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1688 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1690 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1691 Let GDK_Return pass through in some more cases.
1693 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1694 activating the entry.
1696 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1697 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1698 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1700 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1701 (#316001, Guillaume Cottenceau)
1703 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1704 mistake in the docs. (#315993, Guillaume Cottenceau)
1706 * tests/testentrycompletion.c (create_simple_completion_model): Add
1707 some strings containing multibyte characters.
1709 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1710 Fix prefix insertion for multibyte characters. (#316095,
1713 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1714 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1715 return NULL if the widget is not realized. (#316023,
1716 Guillaume Cottenceau)
1718 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1721 * gdk/gdkproperty.h:
1722 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1723 New function to avoid pointless strdups when creating atoms
1724 from static strings.
1727 * gtk/*.c: Use gdk_atom_intern_static_string() where
1730 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1732 * gtk/gtkcellrendererkeys.h:
1733 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1734 and editing accelerators, a port of EggCellRendererKeys .
1738 * gtk/Makefile.am: Add the keys cell renderer.
1740 * tests/Makefile.am:
1741 * tests/testkeys.c: Test GtkCellRendererKeys
1743 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1745 Make it possible to determine if a key event is for a
1748 * gdk/x11/gdkprivate-x11.h:
1749 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1750 New function to determine if a keycode is mapped to a modifier.
1751 (get_xkb): Get the modmap.
1753 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1754 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1756 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1759 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1761 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1762 unused variable, noticed by Kjartan Maraas.
1764 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1766 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1767 Make drag reordering work properly for columns other than the
1768 first. (#315054, Dan Winship)
1770 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1771 invalid fontnames better. (#136926, Michael R. Walton)
1773 Stop cursor blinking in non-editable regions of a text view.
1774 (#311508, Torbjörn Andersson)
1776 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1777 (cursor_blinks): Take editability into account when deciding
1778 whether the cursor blinks.
1779 (gtk_text_view_button_release_event):
1780 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1782 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1783 Use connect_after to connect to the focus_out event. This
1784 ensures that the entry has already stopped blinking by the time
1785 we emit the edited signal. (#315229, Thomas Leonard)
1787 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1789 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1790 unsigned ints to -1. (#315481, Kjartan Maraas)
1792 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1793 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1794 (#314473, Stanislav Brabec)
1796 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1798 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1799 memory handling. (#314975, Torsten Schoenfeld)
1801 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1802 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1803 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1804 * gtk/gtklabel.c (gtk_label_class_init):
1805 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1806 Stylistic improvements and clarifications for some blurbs.
1807 (#315520, Clytie Siddall)
1809 2005-09-09 Tor Lillqvist <tml@novell.com>
1811 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1812 display name. There is only one GdkDisplay on Win32, and
1813 constructing the display name isn't entirely trivial, so cacheing
1814 is probably worth it. For instance GIMP calls this function a lot.
1815 (gdk_display_open): Call gdk_display_get_name() to prime the
1817 (gdk_display_get_n_screens, gdk_display_get_screen,
1818 gdk_display_get_default_screen): Verify parameter correctness like
1819 the X11 backend does.
1821 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1822 Return a freshly allocated string, as the API specifies. Fixes a
1823 heap corruption problem that caused random errors and crashes in
1826 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1828 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1829 Make C-u commit and restart hex input if we are already in a
1832 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1834 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1835 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1836 if they are mapped to the same modifier.
1838 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1839 to gtkstatusicon.c and gtktrayicon-x11.c
1841 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1842 default accel mod mask.
1844 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1845 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1846 Don't use GDK_ALT_MASK.
1848 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1850 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1852 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1854 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1857 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1858 Mod2 - Mod5 and against Super, Hyper, Meta.
1860 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1861 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1862 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1864 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1865 modmap to maintain the information which X modifiers map to
1867 (get_xkb): Set up the modmap from the XKB tables.
1868 (update_keymaps): Set up the modmap from the information returned
1869 by XGetModifierMapping in the non-XKB case.
1871 * gdk/x11/gdkprivate-x11.h:
1872 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1873 function to set the virtual modifiers in the state.
1875 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1876 _gdk_keymap_add_virtual_modifiers here.
1878 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1879 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1882 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1884 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1885 if it has no child. (#315253, John Finlay)
1887 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1889 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1891 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1893 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1894 on destroy to avoid problems when they are called on a destroyed
1895 widget. (#315135, John Cupitt)
1897 * gtk/gtkentry.c (gtk_entry_class_init):
1898 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1899 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1901 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1902 code. Now we only steal a single key combination, Ctrl-Shift-U,
1904 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1905 by a sequence of hex digits entered with Ctrl-Shift still held.
1906 Releasing one of the modifiers or pressing space while the modifiers
1907 are still held commits the character. It is possible to erase
1908 digits using backspace.
1909 As an extension to the above, we also allow to start the sequence
1910 with Ctrl-Shift-U, then release the modifiers before typing any
1911 digits, and enter the digits without modifiers.
1912 (#82011, Owen Taylor)
1914 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1916 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1917 we still need to deliver the destroy event. (#314980, Chris Lahey)
1919 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1920 im context before committing \n or \t.
1922 2005-09-02 Alexander Larsson <alexl@redhat.com>
1924 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1925 (shortcuts_activate_volume):
1926 Handle base_path being null in the rest of the cases (#310270)
1928 2005-09-02 Tor Lillqvist <tml@novell.com>
1930 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1931 cursor position also in root window coordinates. Prune out
1932 superfluous WM_MOUSEMOVE events even earlier, based on root window
1933 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1934 window has ben mapped below the cursor even if the mouse doesn't
1935 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1936 confused at least gtk_menu_motion_notify(). (#314995)
1938 * gtk/gtkintl.h: No need to include config.h here. It caused
1939 warnings about GTK_LOCALEDIR being redefined on Win32 when
1940 compiling files where gtkintl.h is included after gtkprivate.h
1941 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1943 * gtk/gtkplug.c: Include config.h.
1945 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1947 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1948 xdg_mime_get_mime_type_for_file() where possible, to avoid
1951 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1952 typo. (#314921, Guillaume Cottenceau)
1954 * gdk/*.c: Intern some more strings.
1956 * gtk/*.c: Define an I_() macro and use it instead of the
1957 bulky g_intern_static_string().
1959 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1961 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1962 instead of copying it.
1964 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1966 * gtk/*.c: Also intern static strings passed to
1967 g_object_set_data().
1970 * gtk/Makefile.am: Intern type names in code generated by
1975 * gdk/*.c: Intern type names before registering the type to avoid
1978 * configure.in: Require GLib 2.9.0
1980 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1982 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1983 and add icon-size and icon-size-set properties. (#314172)
1985 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1986 groups across transient parents. (#312918, Christian Persch)
1988 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1989 Guillaume Cottenceau)
1991 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1992 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1994 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1996 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1997 make C-/ select all and C-\ unselect all. (#309301,
2000 * gtk/gtkimcontextsimple.c: Change the compose sequence for
2001 soft hyphen to be multi_key-minus-minus-space, and add
2002 compose sequences multi_key-minus-minus-period and
2003 multi_key-minus-minus-minus for en dash and em dash.
2004 (#172653, Christian Lohmaier)
2006 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
2007 code. (#313946, Christian Persch)
2009 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
2010 fix for the default value of the "ui" property.
2012 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2015 * gtk/gtkselection.h:
2016 * gtk/gtkselection.c: Add functions which look for text, image
2017 or uri targets in an array of atoms. (#314089, Mark Wielaard)
2020 * gtk/gtkselection.h:
2021 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
2022 Add a function to check wether targets include uri.
2023 (#314092, Mark Wielaard)
2027 * gtk/gtkwindow.c: Add a deletable property with getter
2028 and setter, to control the close button in the window
2029 frame. (#59718, Havoc Pennington)
2031 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2033 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
2034 to the arrow keys for menu navigation. (#162825, Carl Worth)
2036 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
2038 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
2040 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
2041 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
2042 refer to nonexisting stock ids.
2044 * gtk/gtktextview.c (popup_targets_received):
2045 * gtk/gtkentry.c (popup_targets_received): Construct
2046 the "Select All" menuitem from stock.
2048 * gtk/stock-icons/stock_select_all_{16,24}.png:
2049 * gtk/stock-icons/Makefile.am:
2050 * gtk/gtkiconfactory.c:
2052 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
2055 * gtk/gtktrayicon.c: Add a pointer to the spec.
2057 * gtk/gtkstatusicon-x11.c: Add docs.
2059 * gtk/gtkstatusicon.h: Fix a typo.
2061 Add a cross-platform "tray icon" API, by
2062 porting EggStatusIcon/EggTrayIcon (#105101)
2064 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
2065 displays an icon in a notification area.
2067 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
2068 X11, using GtkTrayIcon.
2070 * gtk/gtktrayicon.h:
2071 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
2072 system tray specification, not public API.
2074 * gtk/gtk.symbols: Add new exported functions.
2076 * gtk/gtk.h: Include gtkstatusicon.h.
2078 * gtk/Makefile.am: Add new files.
2080 * tests/Makefile.am:
2081 * tests/teststatusicon.c: Test for GtkStatusIcon.
2083 2005-08-29 Christopher Aillon <caillon@redhat.com>
2085 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
2086 and GTK_STOCK_DISCONNECT
2088 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2090 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
2091 Use XFixesChangeSaveSet if available. (#314682)
2093 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
2094 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
2096 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2098 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
2099 accidentally leftover duplicate pixbuf creation. (#314700,
2102 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
2103 leak the cursor theme name. (#314693, Kjartan Maraas)
2105 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
2106 state.children in all cases. (#313862, Kjartan Maraas)
2108 2005-08-28 Matthias Clasen <mclasen@redhat.com>
2110 * po/POTFILES.in, po-properties/POTFILES.in:
2113 2005-08-27 Matthias Clasen <mclasen@redhat.com>
2115 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
2116 value of the ui property. (#314532, Yong Wang)
2118 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
2119 when G_MAXLONG is passed as length.
2121 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2123 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
2124 to avoid overloading --force. (JP Rosevaar)
2126 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2128 * configure.in: Bump version to 2.9.0
2132 * gdk/gdkscreen.c: Make the GdkScreen font options api
2133 public, and add properties GdkScreen::font-options and
2134 GdkScreen::resolution. (#314004)
2137 * gtk/gtksettings.c:
2138 * gtk/gtkwidget.c: Adjust all callers.
2140 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
2141 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
2142 * gdk/gdkscreen.c: Include gdkintl.h.
2144 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
2145 variable warning, pointed out by Colin Walters. (#314585)
2147 2005-08-26 Tor Lillqvist <tml@novell.com>
2149 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
2151 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
2153 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2155 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
2156 of week_start. (#314473, JP Rosevaar)
2158 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
2160 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
2161 lock. (#314533, Thomas Fitzsimmons)
2163 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2165 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
2166 NULL gracefully. (#314523, Ed Catmur)
2168 2005-08-25 Owen Taylor <otaylor@redhat.com>
2170 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
2171 Handle theme == NULL.
2173 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2175 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
2176 y offset into account when positioning the popup. (#314470,
2179 2005-08-25 Owen Taylor <otaylor@redhat.com>
2181 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
2182 as instance_init, not base_init! (#314452, Fix from Frederic
2183 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
2184 rather than 1 for a negative flag value.
2186 2005-08-24 Owen Taylor <otaylor@redhat.com>
2188 * gdk/gdkpango.c (draw_error_underline): Add a note about
2189 cut-and-paste between here and Pango.
2191 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2193 * === Released 2.8.2 ===
2195 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
2196 callback for image/gif, and also try image/bmp. (#314086, Mark
2199 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
2200 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
2205 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
2206 and cursor settings get propagated down to the screen initially.
2207 Pointed out by Frederic Crozat.
2209 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
2210 message if the screen is NULL. Noticed by Kjartan Maraas.
2212 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2216 * === Released 2.8.1 ===
2220 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2222 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
2223 against lazy filterers which return values other than TRUE or
2224 FALSE from their visible func. (#314335)
2226 2005-08-23 Owen Taylor <otaylor@redhat.com>
2228 Fix for #314004, reported by Michael Reinsch:
2231 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
2232 Add gdk_screen_get/set_resolution_libgtk_only()
2234 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
2235 the options for the screen on the newly created context.
2237 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
2238 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
2239 the font options on the screen.
2241 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
2242 the font options from the screen and set them on the context.
2244 2005-08-23 Kristian Rietveld <kris@gtk.org>
2246 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
2247 bother inserting new rows in a level with a zero refcount and
2248 immediately free the level. (Fixes #312350, reported by Markku Vire).
2250 2005-08-23 Matthias Clasen <mclasen@redhat.com>
2252 * gtk/updateiconcache.c: Complain when there is no index.theme file
2253 in the specified directory, unless --force is used. Also add an
2254 --index-only option to create caches without image data.
2256 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
2257 C99ism. (#314262, Robert Jeff Mitchell)
2259 2005-08-22 Manish Singh <yosh@gimp.org>
2261 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
2263 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
2265 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2267 * gtk/gtkwindow.c (gtk_window_client_event):
2268 * gtk/gtkicontheme.c (ensure_valid_themes)
2269 (_gtk_icon_theme_check_reload): Implement a clientmessage based
2270 scheme for makeing sure that all GTK+ applications notice if an
2271 icon theme has been updated. This should prevent multiple versions
2272 of an icon theme cache to be mapped in memory at the same time,
2273 which can cause excessive memory consumption. (#313156, Chris
2276 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2278 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
2279 regarding icon theme changes.
2281 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
2282 pixbufs which are backed by the mmapped memory of an icon cache,
2283 increase the refcount of the icon cache, so that the memory is not
2284 munmapped away underneath the pixbuf upon icon theme changes.
2285 (#314170, Kjartan Maraas)
2287 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
2288 to link against Xext. (#314062)
2290 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
2291 overruns. (#314081, Hans Breuer)
2293 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2295 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
2296 returned layout must not be modified.
2298 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
2300 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
2301 scroll_to_path if the model changes.
2303 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
2304 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
2305 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
2306 we're realized, #312798
2307 (gtk_icon_view_set_model): clear scroll_to_path if the model
2310 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2312 * gtk/gtkrange.c (gtk_range_adjustment_changed)
2313 (gtk_range_adjustment_value_changed): Don't queue a draw
2314 if the layout has not changed. (#313991, Benjamin Berg)
2316 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2318 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
2321 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
2324 * gtk/gtkfilechooserbutton.c (change_icon_theme)
2325 (model_add_special, model_add_special, model_add_volumes):
2326 Handle pixbuf being NULL without warnings. Also, don't
2327 leak pixbuf references when the icon theme is changed.
2329 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
2330 the user data on destroyed windows, since at best
2331 it can be a stale pointer. (#313953, Robin Green)
2333 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2335 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
2336 (#313900, Sebastien Bacher)
2338 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
2339 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
2341 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
2342 (xdnd_read_actions, get_client_window_at_coords_recurse):
2343 Free data returned from XGetWindowProperty.
2345 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
2346 Free data returned from XGetWindowProperty. (313867, Kjartan
2349 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
2350 children in all cases. (#313862, Kjartan Maraas)
2352 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
2353 in the per-directory hash, even if they come from the icon cache.
2354 We tried to avoid that before, but as a result leaked icon data
2355 structs. (#313852, Kjartan Maraas)
2357 2005-08-18 Matthias Clasen <mclasen@redhat.com>
2359 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
2360 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
2362 2005-08-15 Owen Taylor <otaylor@redhat.com>
2364 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
2365 files for x11/xext. (Jonas Bonn)
2367 2005-08-15 Tor Lillqvist <tml@novell.com>
2369 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
2372 2005-08-15 Owen Taylor <otaylor@redhat.com>
2374 * configure.in: Fix have_base_pc / have_base_x_pc typo.
2376 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
2377 (#313417, James Andrewartha)
2379 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
2380 FcNameConstant(). (More of #313417)
2382 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2384 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
2385 modal dialogs, make sure to inherit the window group from
2386 the parent, since we don't inherit window groups across
2387 transient parents currently. (#312918, Christian Persch)
2389 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
2390 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
2392 * gtk/gtkiconview.c (gtk_icon_view_select_path)
2393 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
2394 gracefully. (#312796, Jonathan Blandford)
2396 * tests/testtoolbar.c: Add some more tests for menu placement.
2398 * gtk/gtkmenutoolbutton.c (menu_position_func):
2399 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
2400 of toolbutton menus and of the overflow menu. (#312937,
2401 #153870, Christian Persch, Paolo Borelli)
2403 2005-08-15 Tor Lillqvist <tml@novell.com>
2405 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
2406 the nonportable <libgen.h> and dirname().
2408 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2410 * gtk/gtksizegroup.c: Use object data to mark widgets and
2411 groups as visited, so that we avoid constant extra list
2412 traversals. Also allocate quarks in class_init. (#311618,
2415 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
2416 download location for the hicolor icon theme. (#313475, Olexiy
2419 * gtk/gtkicontheme.c: Remove debug spew.
2421 2005-08-15 Owen Taylor <otaylor@redhat.com>
2423 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
2424 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
2425 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
2426 Handle pixmap == NULL when checking for a colormap.
2429 2005-08-14 Matthias Clasen <mclasen@redhat.com>
2431 * gtk/updateiconcache.c: Store only one copy of the pixel data
2432 for symlinked icons. To achieve this, maintain a hashtable
2433 mapping pathnames to pixel data, and share the pixel data for
2434 all symlinks resolving to the same pathname. When writing out
2435 the image data, write out the pixel data only the first time
2436 it is met, and store the offset pointing to the first copy
2437 for use in all later cases.
2438 This reduces the size of the Bluecurve icon cache from 40