1 2005-11-04 Michael Natterer <mitch@imendio.com>
3 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
4 from maemo-gtk that changes the mtime check for rc files from
5 '>' to '!=', otherwise theme changes go unnoticed when turning
6 back the clock (Tommi Komulainen).
8 2005-11-04 Tor Lillqvist <tml@novell.com>
10 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
13 2005-11-03 Tor Lillqvist <tml@novell.com>
15 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
16 the Win32 backend, check that GdkDisplay* parameters are equal to
17 _gdk_display instead of using the unnecessarily general
20 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
21 color bitmap to have "color" in their name, for similarity with
22 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
23 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
24 the mask bitmap's contents, ones for those pixels in the color
25 bitmap where the alpha is zero, zero for other pixels. We used to
26 use an uninitialized mask bitmap! This meant that icons and
27 cursors created presumably worked more or less by accident.
28 Totally blank icons with zero alpha everywhere (as used by
29 gtktrayicon.c) definitely did not work as expected.
31 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
33 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
34 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
35 necessary and can be removed from CVS. It has never been mentioned
36 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
37 are used on Win32. One label widget is used (but never shown) as
38 gtk_widget_render_icon() needs a widget.
40 Ifdefs used as necessary in several places. It might be cleaner to
41 split out the backend-specific parts to separate files, or at
42 least collect them into separate blocks in the file.
44 (wndproc): New function. Window procedure to monitor mouse events
45 in the system tray icon. Call gtk_status_icon_button_press() as
47 (create_tray_observer): New function. Creates a hidden window that
48 only serves as a tray icon message observer.
50 * tests/teststatusicon.c (icon_activated): Position the dialog
51 with GTK_WIN_POS_CENTER.
52 (do_quit): New function, hide and unref the GtkStatusIcon, and
54 (popup_menu): Add a Quit menu item that calls do_quit().
56 2005-11-02 Tor Lillqvist <tml@novell.com>
58 * gdk/win32/gdkcolor-win32.c
59 * gdk/win32/gdkscreen-win32.c
60 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
61 fixes. Remove superfluous test for GdkWindow* parameters being
62 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
63 GdkScreen and one GdkDisplay in the Win32 backend, use those
64 variables instead of the getter functions. For GdkDisplay* and
65 GdkScreen* parameters, check that they are equal to the
66 corresponding singleton variables instead of the more general
67 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
69 2005-11-02 Matthias Clasen <mclasen@redhat.com>
71 * gtk/gtktextview.c: Remove some g_return_if_fail() from
72 static functions, replace some others by g_assert().
74 * gtk/gtktextview.c (selection_motion_event_handler)
75 (gtk_text_view_start_selection_drag): Keep track of the original
76 selection boundaries during a drag selection, in order to correctly
77 decide when to extend or shrink the selection. (#320167,
78 reported by Arvind S N, patch by Paolo Borelli)
80 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
81 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
82 manual offset calculations by g_utf8_offset_to_pointer().
83 (#320360, Paolo Borelli)
85 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
87 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
88 nodes via the g_slice_*() API.
89 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
91 2005-11-01 Tor Lillqvist <tml@novell.com>
93 * gdk/win32/gdkprivate-win32.h
94 * gdk/win32/gdkglobals-win32.c
95 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
96 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
97 their declarations, definitions and assignments into a more
98 logical and consistent order.
100 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
101 CF_ prefix for the predefined clipboard format names. Put quotes
102 around registered format names to distinguish them.
104 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
105 immediately with a warning if the property type is STRING, TEXT,
106 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
107 should never pretend to handle on Win32. Handle only UTF8_STRING
108 here, other formats with delayed rendering. Use \uc1 instead of
109 \uc0 when generating Rich Text Format for easier testability on
110 XP, where WordPad misinterprets \uc0 encoded characters. Add more
111 GDK_NOTE debugging output for Clipboard operations.
113 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
114 (gdk_selection_convert): Don't pretent to handle STRING, just
115 UTF8_STRING. Streamline error handling, don't unnecessarily have a
116 GError which then isn't used for anything anyway if it gets set.
117 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
118 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
120 * config.h.win32.in: Sync with what configure produces.
122 * configure.in: Don't look for X_PACKAGES unless building for
123 x11. (#313986, John Ehresman)
125 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
127 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
128 Wondered why there was no ku there before??
130 2005-10-28 Matthias Clasen <mclasen@redhat.com>
132 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
133 window to the toplevels window group. (#319912, Christian Persch)
135 2005-10-28 Kristian Rietveld <kris@gtk.org>
137 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
140 2005-10-28 Matthias Clasen <mclasen@redhat.com>
142 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
143 drag cursors. (#319200, Federico Mena Quintero)
145 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
146 Shift-G to go to the previous match, like firefox. (#320061, Christian
149 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
150 C99ism. (#320000, Kazuki Iwamoto)
152 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
153 stars. (#319985, Bastien Nocera)
155 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
156 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
158 2005-10-26 Michael Natterer <mitch@imendio.com>
162 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
163 make sure that setting any of pixbuf/stock-id/icon-name resets the
164 others because they are mutually exclusive, and that unsetting any
165 of them only resets the pixbuf and nothing else. Also added
166 some missing g_object_notify().
168 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
169 g_value_set_object().
171 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
172 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
173 g_object_notify ("pixbuf").
175 2005-10-27 Matthias Clasen <mclasen@redhat.com>
177 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
178 careful about initializing cell_area. (#319382, Tommi
181 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
182 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
184 * demos/gtk-demo/clipboard.c (paste_received): Only set the
185 text if it is not NULL. (#319930, Thomas Klausner)
187 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
188 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
190 2005-10-26 Matthias Clasen <mclasen@redhat.com>
192 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
193 * gtk/gtkthemes.c (gtk_theme_engine_load):
194 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
195 when dlopening modules. (#319557, Laszlo Peter)
197 2005-10-26 Matthias Clasen <mclasen@redhat.com>
199 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
200 segments when determining text direction. (#319065, Tommi Komulainen)
202 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
203 on duplicate destroy. (#318953, Gustavo Carneiro)
205 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
206 Point out that destroy-with-parent is a bad idea for the dialog
207 passed to this function. (#318943, Christian Persch)
209 * */Makefile.am: use $(GLIB_MKENUMS) instead of
210 glib-mkenums. (#318582, Damien Carbery)
212 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
213 docs. (#317682, Christian Neumair)
215 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
216 seem to affect the placement of the data in the readonly
217 section, and causes problems with some compilers. (#317844)
219 2005-10-25 Matthias Clasen <mclasen@redhat.com>
221 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
222 Fix some issues with background drawing in RTL. (#318781,
226 * tests/testentrycompletion.c: Apply a patch by Christian
227 Persch to add property editors.
229 * gtk/gtkstatusicon.c: Emit activate on single-click,
230 not on double-click, change proposed by Milosz Derezynski.
232 2005-10-25 Kristian Rietveld <kris@gtk.org>
234 Fixes #311955, reported by Markku Vire; and a lot more.
236 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
237 Levels can now have invisible nodes cached, functions have been
238 rewritten/refactored to take this into account; also the logic in
239 some functions has been corrected.
241 Each referenced node now references all visible children or a single
242 invisible child, in order to be able to monitor all changes in the
243 child model required for correct operation.
245 When a virtual root is set, all nodes on the virtual root level are
248 At last, a bunch of random bug fixes and comment updates.
250 2005-10-25 Matthias Clasen <mclasen@redhat.com>
252 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
253 more docs. (#319722, Paolo Borelli)
255 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
256 initialization of screen_x11->xft_rgba more explicit. (#319627,
259 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
260 in a blurb. (#319499, Francisco Javier F. Serrador)
262 2005-10-24 Matthias Clasen <mclasen@redhat.com>
264 Add settings to hide the input method and Unicode control character
265 submenus in the context menus of GtkEntry and GtkTextView.
267 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
269 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
271 * gtk/gtktextview.c (popup_targets_received):
272 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
274 2005-10-24 Kristian Rietveld <kris@gtk.org>
276 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
277 row-has-child-toggled when the level is not in the cache does not
278 make sense. (This bug probably crept in during the early stages
279 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
281 (gtk_tree_model_sort_real_unref_node): only get the child iter
282 when we will actually also use it.
284 2005-10-22 Michael Natterer <mitch@imendio.com>
286 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
287 widget being realized, in addition to being visible, to avoid
288 running into precondition check in gtk_tree_view_get_cell_area().
291 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
293 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
294 Experimentally, scrollbar steppers can shrink to 8 pixels on
295 Win32. Reflect that in the theme.
296 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
297 there is a 1-pixel border between a scrollbar and its child
298 in ScrolledWindows on Win32. Reflect that in the theme.
300 2005-10-20 Matthias Clasen <mclasen@redhat.com>
302 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
303 for the selection window. (#318806, Alex Larsson)
305 2005-10-18 Federico Mena Quintero <federico@ximian.com>
309 * tests/autotestfilechooser.c
310 (test_button_folder_states_for_action): Test that we have either
311 $cwd or the explicitly-set folder.
312 (test_reload_sequence): Likewise.
314 * gtk/gtkfilechooserdefault.c
315 (gtk_file_chooser_default_get_current_folder): If our reload_state
316 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
318 2005-10-14 Tor Lillqvist <tml@novell.com>
320 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
321 It didn't really do anything useful, and was just confusing and
322 incomplete. Comments claimed we don't do delayed rendering, but in
323 fact we do, for images. (The delayed rendering code has other
324 problems, though, see #168173.) The clipboard viewer code was
325 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
326 the message when necessary). It was just test code, it said so in
327 a comment. Add something similar back later if necessary.
329 (_win32_on_clipboard_change,
330 _gdk_win32_register_clipboard_notification): Remove.
332 (gdk_display_supports_selection_notification,
333 gdk_display_request_selection_notification): Always just return
334 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
336 2005-10-13 Tor Lillqvist <tml@novell.com>
338 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
339 Alt-Enter specially. It does not have any special meaning and
340 should be passed on to the application. (#318378, Tim Evans)
342 2005-10-13 Tor Lillqvist <tml@novell.com>
344 Set visual depth to 24 for 32 bits-per-pixel devices on
345 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
346 optimized composite_0888() function rather than the slower image
347 dithering functions to draw pixbufs (#313993, John Ehresman)
349 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
350 _gdk_windowing_get_bits_for_depth() to initialize
351 GdkImage::bits_per_pixel.
352 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
354 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
355 _gdk_windowing_get_bits_for_depth() to initialize
356 BITMAPINFOHEADER::biBitCount.
358 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
359 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
362 2005-10-12 Stefan Kost <ensonic@users.sf.net>
364 * demos/gtk-demo/appwindow.c: (about_cb):
365 use PACKAGE_VERSION,bump year (#318654)
367 2005-10-11 Matthias Clasen <mclasen@redhat.com>
369 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
370 toggle here with the matching on toggle if it immediately follows.
371 This is a common case, and handling it here prevents quadratic blowup
372 in cleanup_line() below. (#317125)
374 * gtk/gtktextsegment.h:
375 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
376 the character counts into this function instead of computing them
379 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
381 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
383 * gtk/gtkfilechooserdefault.c
384 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
385 when the shortcut already exists in the sidebar. (#147521)
387 2005-10-09 Matthias Clasen <mclasen@redhat.com>
389 * tests/testcombo.c: Demonstrate how to use custom widgets in
392 2005-10-07 Federico Mena Quintero <federico@ximian.com>
396 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
397 the the result of gtk_file_chooser_get_folder() is NULL or
398 non-NULL at the right times. Log the tests.
399 (test_button_folder_states): New test for the initial states of
400 the current folder in GtkFileChooserButton.
401 (main): Test that the number of warnings/errors/critical errors is
404 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
405 Clarify the documentation on when this can return NULL.
406 (gtk_file_chooser_get_current_folder_uri): Likewise.
408 * gtk/gtkfilechooserbutton.c (struct
409 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
410 we use it to keep track of whether a folder has been set.
411 (gtk_file_chooser_button_map): Implement. If no folder has been
412 loaded before, we at least try to load $cwd here.
413 (gtk_file_chooser_button_constructor): If the construct-time
414 dialog already has a folder set, turn on our folder_has_been_set
416 (dialog_current_folder_changed_cb): Turn on our
417 folder_has_been_set flag.
419 2005-10-07 Michael Natterer <mitch@gimp.org>
421 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
422 PROFILE_FILE_CHOOSER because they break compilation after the
423 removal of <unistd.h>.
425 2005-10-07 Matthias Clasen <mclasen@redhat.com>
427 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
428 by moving it out of the profiling ifdef.
430 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
431 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
433 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
434 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
437 2005-10-06 Matthias Clasen <mclasen@redhat.com>
440 * gtk/gtktextbuffer.h:
441 * gtk/gtktextbuffer.c: Add a readonly has-selection property
442 with a getter. (#318161, Paolo Borelli)
444 2005-10-05 Matthias Clasen <mclasen@redhat.com>
446 * README.in: Start collecting release notes for 2.10.
448 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
449 leak fix, since the assertion failures were traced to
450 an xchat bug. (#314696)
452 * gtk/gtkstyle.c (gtk_style_detach):
453 (gtk_style_attach): Documentation improvements.
454 (gtk_style_detach): Assert that the attach_count is > 0.
456 2005-10-04 Federico Mena Quintero <federico@ximian.com>
458 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
459 shortcut position, not a ShortcutsIndex, to make the function more
461 (home_folder_handler): Pass the resolved index to
462 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
463 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
464 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
465 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
466 make the respective key switch to the first, second, ..., tenth
468 (quick_bookmark_handler): Implement.
470 2005-10-04 Federico Mena Quintero <federico@ximian.com>
472 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
473 Desktop; just use their real names on the file system for the
476 * gtk/gtkfilechooserdefault.c
477 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
478 binding signal, and bind it to M-d by default.
479 (desktop_folder_handler): Implement the default handler.
480 (home_folder_handler): Use a helper function.
481 (switch_to_shortcut): New helper function.
482 (shortcuts_append_home): Don't special-case the name of "Home";
483 just use the folder name.
485 2005-10-04 Tor Lillqvist <tml@novell.com>
487 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
488 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
490 2005-10-04 Matthias Clasen <mclasen@redhat.com>
492 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
493 from yesterday, since it leads to assertion failures. (#317879,
496 2005-10-03 Matthias Clasen <mclasen@redhat.com>
498 * gtk/gtkcalendar.c (gtk_calendar_init): Call
499 calendar_compute_days() after setting priv->week_start.
501 2005-10-03 Matthias Clasen <mclasen@redhat.com>
503 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
504 removing it from the hash table. (#314696, Benjamin Berg)
506 2005-10-01 Tor Lillqvist <tml@novell.com>
508 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
509 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
510 is that the the desktop isn't visible because the session has been
511 switched, the screen is locked, or a terminal server session
512 disconnected, so no error message necessary. (#137796)
514 It is of course remotely possible that BitBlt() failing with
515 ERROR_INVALID_HANDLE might also be caused by some other
516 problem. We could strive for perfection and track whether the
517 desktop is visible by using WTSRegisterSessionNotification() and
518 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
519 this issue, though. If we would track desktop visibility, we
520 should then avoid even trying to update the display at all while
521 the desktop isn't visible.
523 2005-09-30 Matthias Clasen <mclasen@redhat.com>
525 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
526 to correct the calculations for the first week day. We may
527 just have to remove this code if too many locales turn out
530 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
531 some cases. (#317611, Tommi Komulainen)
533 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
534 Prevent overflow when storing size hints in an unsigned
535 short variable. Tracked down by Ray Strode and Søren Sandmann.
537 2005-09-29 Matthias Clasen <mclasen@redhat.com>
539 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
542 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
543 grab shadowed. (#317332)
545 2005-09-29 Tor Lillqvist <tml@novell.com>
547 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
549 2005-09-28 Federico Mena Quintero <federico@ximian.com>
551 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
552 if the unmap test fails.
553 (test_reload_sequence): Use gtk_widget_show_now() instead of
554 gtk_widget_show() for the dialog.
555 Thanks to Tim Janik for noticing these.
557 2005-09-28 Federico Mena Quintero <federico@ximian.com>
559 * tests/testcellrenderertext.c: New file with a set of tests for
560 GtkCellRendererText. The idea is to run a text renderer through
561 most of its interesting property values to see that it works
564 * tests/Makefile.am: Added testcellrenderertext.
566 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
567 entry/exit of this function for profiling.
568 (gtk_file_chooser_default_style_set): Mark the start/end of the
569 calls to the parent class and the the signal emission for profiling.
571 2005-09-29 Tor Lillqvist <tml@novell.com>
573 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
574 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
575 system codepage using g_win32_locale_filename_from_utf8().
576 (#317457, Kazuki Iwamoto)
578 2005-09-28 Matthias Clasen <mclasen@redhat.com>
580 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
581 here. (#317039, Paolo Borelli)
584 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
585 to make this function work as boxed copy function. (#317455,
588 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
589 NULL. (#316828, Tor Lillqvist)
591 2005-09-28 Tor Lillqvist <tml@novell.com>
593 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
596 2005-09-27 Federico Mena Quintero <federico@ximian.com>
598 Don't reload the current folder unnecessarily on ::map().
600 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
602 (struct _GtkFileChooserDefault): Added a "reload_state" field.
604 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
605 Initialize impl->reload_state.
606 (gtk_file_chooser_default_map): Check the impl->reload_state; load
607 a default folder if no folder has been set, or reload the current
608 one only if we had been unmapped first.
609 (gtk_file_chooser_default_update_current_folder): Set the
610 reload_state to RELOAD_HAS_FOLDER.
611 (gtk_file_chooser_default_unmap): Implement, and set the
612 reload_state to RELOAD_WAS_UNMAPPED.
613 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
614 here; they'll get (re)loaded on ::map() anyway.
616 * gtk/gtkfilechooserwidget.c
617 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
619 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
620 a dialog; build it ourselves.
621 (test_reload): New test to ensure that we don't load the default
622 folder more than once, and that we reload it when
624 (get_impl_from_dialog): New utility function.
625 (test_widgets_for_current_action): Use get_impl_from_dialog().
627 2005-09-27 Federico Mena Quintero <federico@ximian.com>
629 * gtk/gtkfilechooserdefault.c
630 (gtk_file_chooser_default_constructor): Mark the entry/exit of
631 this function for profiling.
632 (check_icon_theme): Likewise.
633 (change_icon_theme): Likewise.
634 (settings_notify_cb): Likewise.
635 (gtk_file_chooser_default_screen_changed): Likewise.
636 (update_chooser_entry): If the selection is empty, clear the file
637 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
638 nothing will be selected when the user starts typeahead in the
639 treeview, and we don't want to clear the file name entry in that
640 case --- the user could be typing-ahead to look for a folder name.
641 Fixes bug #308332, patch by Jürg Billeter.
643 2005-09-27 Matthias Clasen <mclasen@redhat.com>
645 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
646 Pop below the entry if there's more free space below the entry
647 than above. (#316948, Tommi Komulainen)
649 2005-09-26 Federico Mena Quintero <federico@ximian.com>
651 Do not create the save mode-specific widgets in the open modes, so
652 that we don't carry their baggage around.
654 * gtk/gtkfilechooserdefault.c
655 (gtk_file_chooser_default_constructor): Don't create the
657 (save_widgets_create): Set the impl->save_widgets directly here,
658 instead of passing the widgets back to the caller. Also, pack
659 them into the impl's box.
660 (update_appearance): Create or destroy the save widgets as
661 appropriate. Set the action of the save_file_name_entry here.
662 (shortcuts_add_current_folder): Set the active item in the
663 save_folder_combo only if it exists.
664 (gtk_file_chooser_default_set_property): Don't set the action of
665 the save_file_name_entry here.
666 (gtk_file_chooser_default_update_current_folder): Set the base
667 folder of the save_file_name_entry only if the entry exists.
668 (shortcuts_drag_data_received_cb): Cast the selection_data->data
669 to (const char *) since that's what shortcuts_drop_uris() expects.
670 (file_list_drag_data_received_cb): Likewise, for
671 g_uri_list_extract_uris().
673 2005-09-26 Tor Lillqvist <tml@novell.com>
675 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
676 the shaped flag here, too. (#316871)
677 (gdk_window_shape_combine_region): Currently unimplemented, so
678 don't do anything to the shaped flag here.
680 2005-09-26 Matthias Clasen <mclasen@redhat.com>
682 Fix #316871, reported by Dan Winship:
684 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
686 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
687 (gdk_window_shape_combine_region): Set it here.
689 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
690 remove the child area for shaped windows.
692 2005-09-23 Matthias Clasen <mclasen@redhat.com>
694 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
695 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
697 2005-09-22 Michael Natterer <mitch@imendio.com>
699 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
700 consistent with GTK+ terminology:
702 * gtk/gtkcellrendererkeys.[ch]
703 * tests/testkeys.c: removed...
705 * gtk/gtkcellrendereraccel.[ch]
706 * tests/testaccel.c: ...and added.
711 * tests/Makefile.am: changed accordingly.
713 2005-09-22 Matthias Clasen <mclasen@redhat.com>
715 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
716 for the grab-broken-event signal, noticed by Damon Chaplin.
718 2005-09-21 Tor Lillqvist <tml@novell.com>
720 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
721 gdk_text_property_to_text_list_for_display,
722 gdk_text_property_to_utf8_list_for_display,
723 gdk_win32_selection_add_targets,
724 _gdk_win32_selection_convert_to_dib): Free return value from
726 (gdk_text_property_to_text_list_for_display): Drop GError variable
727 that isn't actually used after being set.
729 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
731 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
734 2005-09-20 Tor Lillqvist <tml@novell.com>
736 * gdk/win32/gdkselection-win32.c
737 (gdk_selection_owner_get_for_display): Do return the correct owner
738 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
739 a window GDK knows about). The reason to return NULL seems to have
740 gone when in the fix for bug #163702 the artificial
741 GDK_SELECTION_CLEAR event generation was removed from
742 gdk_selection_send_notify_for_display(). Fixes bug #316552.
744 2005-09-20 Matthias Clasen <mclasen@redhat.com>
746 Avoid unnecessary XkbGetState() calls and XkbStateNotify
747 events. (#151555, Søren Sandmann)
749 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
750 XkbSelectEventDetails() to select XkbStateNotify events
751 for only the state we care about.
753 * gdk/x11/gdkprivate-x11.h:
754 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
755 the event into the function and update the keymap state from
756 the state information contained in the event. Adjust all callers.
758 2005-09-19 Matthias Clasen <mclasen@redhat.com>
760 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
761 in multiple places to avoid segfaults if the index is out of range.
762 (#316422, Guillaume Cottenceau)
763 (gtk_icon_view_set_drag_dest_item):
764 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
765 #316424, Guillaume Cottenceau)
767 2005-09-18 Hans Breuer <hans@breuer.org>
769 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
770 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
772 2005-09-18 Hans Breuer <hans@breuer.org>
774 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
775 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
776 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
777 the icon and is blinking with teststatusicon. More to come ...
779 2005-09-18 Hans Breuer <hans@breuer.org>
781 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
782 cause gtkprogressbar.c has #include <config.h> conditionally; less
783 noise from generated gtk.def
784 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
786 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
787 For me it works as well as the *NIX implemenation, that is not at all.
789 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
791 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
792 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
793 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
794 again - if compiled properly.
796 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
797 already coming with Gtk+. Makes it compile on win32.
799 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
801 * README.cvs-commits: fixed some tiny typos
803 2005-09-16 Tor Lillqvist <tml@novell.com>
805 * modules/engines/ms-windows/msw_style.c (draw_extension,
806 draw_box_gap): Check whether the widget actually is a GtkNotebook
807 before treating it as such. Drop some unneeded local variables,
808 use parameter with same information instead. (#316412)
810 2005-09-15 Federico Mena Quintero <federico@ximian.com>
812 * tests/autotestfilechooser.c: Start a set of automated tests for
813 the file chooser. The only test in there right now doesn't pass
814 yet. It specifies the intended behavior of the first optimization
815 of a series which I'll do on the file chooser (see
816 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
817 details of this optimization).
819 * tests/Makefile.am: Added autotestfilechooser.c.
821 * gtk/gtkfilechooserprivate.h (struct
822 _GtkFileChooserDialogPrivate): Move all the file chooser's private
823 structures to here, so that they can be accessed by
824 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
825 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
827 * gtk/gtkfilechooserdialog.c: See above.
829 * gtk/gtkfilechooserwidget.c: See above.
831 * gtk/gtkfilechooserdefault.c: See above.
833 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
836 gtk_window_map_event(): new function to work around lost unmap requests.
839 2005-09-14 Federico Mena Quintero <federico@ximian.com>
841 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
842 an easy-to-find profiling marker when starting to create a file
844 (browse_files_model_finished_loading_cb): Likewise, for when the
845 chooser is finished loading.
847 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
849 * gtk/gtkcolorbutton.c: Check "color" argument in
850 gtk_color_button_set_color ()
852 2005-09-14 Matthias Clasen <mclasen@redhat.com>
854 * gtk/gtklabel.c (gtk_label_get_type):
855 * gtk/gtkbutton.c (gtk_button_get_type):
856 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
857 using a mem chunk for window groups, buttons, labels.
859 * gtk/updateiconcache.c (foreach_remove_func): Fix
860 a use-after-free bug. (#316256, Alexander Nedotsukov)
862 2005-09-13 Matthias Clasen <mclasen@redhat.com>
864 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
866 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
868 2005-09-13 Matthias Clasen <mclasen@redhat.com>
870 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
871 Let GDK_Return pass through in some more cases.
873 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
874 activating the entry.
876 * gtk/gtkiconview.c (gtk_icon_view_class_init):
877 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
878 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
880 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
881 (#316001, Guillaume Cottenceau)
883 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
884 mistake in the docs. (#315993, Guillaume Cottenceau)
886 * tests/testentrycompletion.c (create_simple_completion_model): Add
887 some strings containing multibyte characters.
889 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
890 Fix prefix insertion for multibyte characters. (#316095,
893 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
894 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
895 return NULL if the widget is not realized. (#316023,
896 Guillaume Cottenceau)
898 2005-09-11 Matthias Clasen <mclasen@redhat.com>
902 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
903 New function to avoid pointless strdups when creating atoms
907 * gtk/*.c: Use gdk_atom_intern_static_string() where
910 2005-09-09 Matthias Clasen <mclasen@redhat.com>
912 * gtk/gtkcellrendererkeys.h:
913 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
914 and editing accelerators, a port of EggCellRendererKeys .
918 * gtk/Makefile.am: Add the keys cell renderer.
921 * tests/testkeys.c: Test GtkCellRendererKeys
923 2005-09-09 Matthias Clasen <mclasen@redhat.com>
925 Make it possible to determine if a key event is for a
928 * gdk/x11/gdkprivate-x11.h:
929 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
930 New function to determine if a keycode is mapped to a modifier.
931 (get_xkb): Get the modmap.
933 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
934 is_modifier bit by calling _gdk_keymap_key_is_modifier().
936 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
939 2005-09-09 Matthias Clasen <mclasen@redhat.com>
941 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
942 unused variable, noticed by Kjartan Maraas.
944 2005-09-09 Matthias Clasen <mclasen@redhat.com>
946 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
947 Make drag reordering work properly for columns other than the
948 first. (#315054, Dan Winship)
950 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
951 invalid fontnames better. (#136926, Michael R. Walton)
953 Stop cursor blinking in non-editable regions of a text view.
954 (#311508, Torbjörn Andersson)
956 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
957 (cursor_blinks): Take editability into account when deciding
958 whether the cursor blinks.
959 (gtk_text_view_button_release_event):
960 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
962 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
963 Use connect_after to connect to the focus_out event. This
964 ensures that the entry has already stopped blinking by the time
965 we emit the edited signal. (#315229, Thomas Leonard)
967 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
969 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
970 unsigned ints to -1. (#315481, Kjartan Maraas)
972 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
973 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
974 (#314473, Stanislav Brabec)
976 2005-09-09 Matthias Clasen <mclasen@redhat.com>
978 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
979 memory handling. (#314975, Torsten Schoenfeld)
981 * gtk/gtkiconview.c (gtk_icon_view_class_init):
982 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
983 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
984 * gtk/gtklabel.c (gtk_label_class_init):
985 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
986 Stylistic improvements and clarifications for some blurbs.
987 (#315520, Clytie Siddall)
989 2005-09-09 Tor Lillqvist <tml@novell.com>
991 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
992 display name. There is only one GdkDisplay on Win32, and
993 constructing the display name isn't entirely trivial, so cacheing
994 is probably worth it. For instance GIMP calls this function a lot.
995 (gdk_display_open): Call gdk_display_get_name() to prime the
997 (gdk_display_get_n_screens, gdk_display_get_screen,
998 gdk_display_get_default_screen): Verify parameter correctness like
999 the X11 backend does.
1001 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1002 Return a freshly allocated string, as the API specifies. Fixes a
1003 heap corruption problem that caused random errors and crashes in
1006 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1008 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1009 Make C-u commit and restart hex input if we are already in a
1012 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1014 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1015 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1016 if they are mapped to the same modifier.
1018 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1019 to gtkstatusicon.c and gtktrayicon-x11.c
1021 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1022 default accel mod mask.
1024 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1025 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1026 Don't use GDK_ALT_MASK.
1028 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1030 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1032 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1034 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1037 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1038 Mod2 - Mod5 and against Super, Hyper, Meta.
1040 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1041 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1042 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1044 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1045 modmap to maintain the information which X modifiers map to
1047 (get_xkb): Set up the modmap from the XKB tables.
1048 (update_keymaps): Set up the modmap from the information returned
1049 by XGetModifierMapping in the non-XKB case.
1051 * gdk/x11/gdkprivate-x11.h:
1052 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1053 function to set the virtual modifiers in the state.
1055 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1056 _gdk_keymap_add_virtual_modifiers here.
1058 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1059 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1062 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1064 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1065 if it has no child. (#315253, John Finlay)
1067 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1069 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1071 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1073 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1074 on destroy to avoid problems when they are called on a destroyed
1075 widget. (#315135, John Cupitt)
1077 * gtk/gtkentry.c (gtk_entry_class_init):
1078 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1079 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1081 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1082 code. Now we only steal a single key combination, Ctrl-Shift-U,
1084 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1085 by a sequence of hex digits entered with Ctrl-Shift still held.
1086 Releasing one of the modifiers or pressing space while the modifiers
1087 are still held commits the character. It is possible to erase
1088 digits using backspace.
1089 As an extension to the above, we also allow to start the sequence
1090 with Ctrl-Shift-U, then release the modifiers before typing any
1091 digits, and enter the digits without modifiers.
1092 (#82011, Owen Taylor)
1094 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1096 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1097 we still need to deliver the destroy event. (#314980, Chris Lahey)
1099 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1100 im context before committing \n or \t.
1102 2005-09-02 Alexander Larsson <alexl@redhat.com>
1104 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1105 (shortcuts_activate_volume):
1106 Handle base_path being null in the rest of the cases (#310270)
1108 2005-09-02 Tor Lillqvist <tml@novell.com>
1110 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1111 cursor position also in root window coordinates. Prune out
1112 superfluous WM_MOUSEMOVE events even earlier, based on root window
1113 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1114 window has ben mapped below the cursor even if the mouse doesn't
1115 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1116 confused at least gtk_menu_motion_notify(). (#314995)
1118 * gtk/gtkintl.h: No need to include config.h here. It caused
1119 warnings about GTK_LOCALEDIR being redefined on Win32 when
1120 compiling files where gtkintl.h is included after gtkprivate.h
1121 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1123 * gtk/gtkplug.c: Include config.h.
1125 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1127 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1128 xdg_mime_get_mime_type_for_file() where possible, to avoid
1131 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1132 typo. (#314921, Guillaume Cottenceau)
1134 * gdk/*.c: Intern some more strings.
1136 * gtk/*.c: Define an I_() macro and use it instead of the
1137 bulky g_intern_static_string().
1139 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1141 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1142 instead of copying it.
1144 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1146 * gtk/*.c: Also intern static strings passed to
1147 g_object_set_data().
1150 * gtk/Makefile.am: Intern type names in code generated by
1155 * gdk/*.c: Intern type names before registering the type to avoid
1158 * configure.in: Require GLib 2.9.0
1160 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1162 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1163 and add icon-size and icon-size-set properties. (#314172)
1165 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1166 groups across transient parents. (#312918, Christian Persch)
1168 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1169 Guillaume Cottenceau)
1171 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1172 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1174 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1176 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1177 make C-/ select all and C-\ unselect all. (#309301,
1180 * gtk/gtkimcontextsimple.c: Change the compose sequence for
1181 soft hyphen to be multi_key-minus-minus-space, and add
1182 compose sequences multi_key-minus-minus-period and
1183 multi_key-minus-minus-minus for en dash and em dash.
1184 (#172653, Christian Lohmaier)
1186 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
1187 code. (#313946, Christian Persch)
1189 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
1190 fix for the default value of the "ui" property.
1192 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1195 * gtk/gtkselection.h:
1196 * gtk/gtkselection.c: Add functions which look for text, image
1197 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1200 * gtk/gtkselection.h:
1201 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1202 Add a function to check wether targets include uri.
1203 (#314092, Mark Wielaard)
1207 * gtk/gtkwindow.c: Add a deletable property with getter
1208 and setter, to control the close button in the window
1209 frame. (#59718, Havoc Pennington)
1211 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1213 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1214 to the arrow keys for menu navigation. (#162825, Carl Worth)
1216 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1218 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1220 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1221 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1222 refer to nonexisting stock ids.
1224 * gtk/gtktextview.c (popup_targets_received):
1225 * gtk/gtkentry.c (popup_targets_received): Construct
1226 the "Select All" menuitem from stock.
1228 * gtk/stock-icons/stock_select_all_{16,24}.png:
1229 * gtk/stock-icons/Makefile.am:
1230 * gtk/gtkiconfactory.c:
1232 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1235 * gtk/gtktrayicon.c: Add a pointer to the spec.
1237 * gtk/gtkstatusicon-x11.c: Add docs.
1239 * gtk/gtkstatusicon.h: Fix a typo.
1241 Add a cross-platform "tray icon" API, by
1242 porting EggStatusIcon/EggTrayIcon (#105101)
1244 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1245 displays an icon in a notification area.
1247 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1248 X11, using GtkTrayIcon.
1250 * gtk/gtktrayicon.h:
1251 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1252 system tray specification, not public API.
1254 * gtk/gtk.symbols: Add new exported functions.
1256 * gtk/gtk.h: Include gtkstatusicon.h.
1258 * gtk/Makefile.am: Add new files.
1260 * tests/Makefile.am:
1261 * tests/teststatusicon.c: Test for GtkStatusIcon.
1263 2005-08-29 Christopher Aillon <caillon@redhat.com>
1265 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1266 and GTK_STOCK_DISCONNECT
1268 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1270 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1271 Use XFixesChangeSaveSet if available. (#314682)
1273 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1274 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1276 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1278 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1279 accidentally leftover duplicate pixbuf creation. (#314700,
1282 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1283 leak the cursor theme name. (#314693, Kjartan Maraas)
1285 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1286 state.children in all cases. (#313862, Kjartan Maraas)
1288 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1290 * po/POTFILES.in, po-properties/POTFILES.in:
1293 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1295 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1296 value of the ui property. (#314532, Yong Wang)
1298 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1299 when G_MAXLONG is passed as length.
1301 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1303 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1304 to avoid overloading --force. (JP Rosevaar)
1306 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1308 * configure.in: Bump version to 2.9.0
1312 * gdk/gdkscreen.c: Make the GdkScreen font options api
1313 public, and add properties GdkScreen::font-options and
1314 GdkScreen::resolution. (#314004)
1317 * gtk/gtksettings.c:
1318 * gtk/gtkwidget.c: Adjust all callers.
1320 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1321 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1322 * gdk/gdkscreen.c: Include gdkintl.h.
1324 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1325 variable warning, pointed out by Colin Walters. (#314585)
1327 2005-08-26 Tor Lillqvist <tml@novell.com>
1329 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1331 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1333 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1335 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1336 of week_start. (#314473, JP Rosevaar)
1338 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1340 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1341 lock. (#314533, Thomas Fitzsimmons)
1343 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1345 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1346 NULL gracefully. (#314523, Ed Catmur)
1348 2005-08-25 Owen Taylor <otaylor@redhat.com>
1350 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1351 Handle theme == NULL.
1353 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1355 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1356 y offset into account when positioning the popup. (#314470,
1359 2005-08-25 Owen Taylor <otaylor@redhat.com>
1361 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1362 as instance_init, not base_init! (#314452, Fix from Frederic
1363 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1364 rather than 1 for a negative flag value.
1366 2005-08-24 Owen Taylor <otaylor@redhat.com>
1368 * gdk/gdkpango.c (draw_error_underline): Add a note about
1369 cut-and-paste between here and Pango.
1371 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1373 * === Released 2.8.2 ===
1375 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1376 callback for image/gif, and also try image/bmp. (#314086, Mark
1379 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1380 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1385 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1386 and cursor settings get propagated down to the screen initially.
1387 Pointed out by Frederic Crozat.
1389 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1390 message if the screen is NULL. Noticed by Kjartan Maraas.
1392 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1396 * === Released 2.8.1 ===
1400 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1402 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1403 against lazy filterers which return values other than TRUE or
1404 FALSE from their visible func. (#314335)
1406 2005-08-23 Owen Taylor <otaylor@redhat.com>
1408 Fix for #314004, reported by Michael Reinsch:
1411 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1412 Add gdk_screen_get/set_resolution_libgtk_only()
1414 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1415 the options for the screen on the newly created context.
1417 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1418 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1419 the font options on the screen.
1421 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1422 the font options from the screen and set them on the context.
1424 2005-08-23 Kristian Rietveld <kris@gtk.org>
1426 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1427 bother inserting new rows in a level with a zero refcount and
1428 immediately free the level. (Fixes #312350, reported by Markku Vire).
1430 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1432 * gtk/updateiconcache.c: Complain when there is no index.theme file
1433 in the specified directory, unless --force is used. Also add an
1434 --index-only option to create caches without image data.
1436 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1437 C99ism. (#314262, Robert Jeff Mitchell)
1439 2005-08-22 Manish Singh <yosh@gimp.org>
1441 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1443 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1445 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1447 * gtk/gtkwindow.c (gtk_window_client_event):
1448 * gtk/gtkicontheme.c (ensure_valid_themes)
1449 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1450 scheme for makeing sure that all GTK+ applications notice if an
1451 icon theme has been updated. This should prevent multiple versions
1452 of an icon theme cache to be mapped in memory at the same time,
1453 which can cause excessive memory consumption. (#313156, Chris
1456 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1458 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1459 regarding icon theme changes.
1461 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1462 pixbufs which are backed by the mmapped memory of an icon cache,
1463 increase the refcount of the icon cache, so that the memory is not
1464 munmapped away underneath the pixbuf upon icon theme changes.
1465 (#314170, Kjartan Maraas)
1467 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1468 to link against Xext. (#314062)
1470 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1471 overruns. (#314081, Hans Breuer)
1473 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1475 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1476 returned layout must not be modified.
1478 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1480 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1481 scroll_to_path if the model changes.
1483 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1484 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1485 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1486 we're realized, #312798
1487 (gtk_icon_view_set_model): clear scroll_to_path if the model
1490 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1492 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1493 (gtk_range_adjustment_value_changed): Don't queue a draw
1494 if the layout has not changed. (#313991, Benjamin Berg)
1496 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1498 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1501 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1504 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1505 (model_add_special, model_add_special, model_add_volumes):
1506 Handle pixbuf being NULL without warnings. Also, don't
1507 leak pixbuf references when the icon theme is changed.
1509 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1510 the user data on destroyed windows, since at best
1511 it can be a stale pointer. (#313953, Robin Green)
1513 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1515 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1516 (#313900, Sebastien Bacher)
1518 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1519 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1521 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1522 (xdnd_read_actions, get_client_window_at_coords_recurse):
1523 Free data returned from XGetWindowProperty.
1525 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1526 Free data returned from XGetWindowProperty. (313867, Kjartan
1529 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1530 children in all cases. (#313862, Kjartan Maraas)
1532 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1533 in the per-directory hash, even if they come from the icon cache.
1534 We tried to avoid that before, but as a result leaked icon data
1535 structs. (#313852, Kjartan Maraas)
1537 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1539 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1540 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1542 2005-08-15 Owen Taylor <otaylor@redhat.com>
1544 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1545 files for x11/xext. (Jonas Bonn)
1547 2005-08-15 Tor Lillqvist <tml@novell.com>
1549 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1552 2005-08-15 Owen Taylor <otaylor@redhat.com>
1554 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1556 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1557 (#313417, James Andrewartha)
1559 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1560 FcNameConstant(). (More of #313417)
1562 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1564 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1565 modal dialogs, make sure to inherit the window group from
1566 the parent, since we don't inherit window groups across
1567 transient parents currently. (#312918, Christian Persch)
1569 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1570 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1572 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1573 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1574 gracefully. (#312796, Jonathan Blandford)
1576 * tests/testtoolbar.c: Add some more tests for menu placement.
1578 * gtk/gtkmenutoolbutton.c (menu_position_func):
1579 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1580 of toolbutton menus and of the overflow menu. (#312937,
1581 #153870, Christian Persch, Paolo Borelli)
1583 2005-08-15 Tor Lillqvist <tml@novell.com>
1585 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1586 the nonportable <libgen.h> and dirname().
1588 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1590 * gtk/gtksizegroup.c: Use object data to mark widgets and
1591 groups as visited, so that we avoid constant extra list
1592 traversals. Also allocate quarks in class_init. (#311618,
1595 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1596 download location for the hicolor icon theme. (#313475, Olexiy
1599 * gtk/gtkicontheme.c: Remove debug spew.
1601 2005-08-15 Owen Taylor <otaylor@redhat.com>
1603 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1604 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1605 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1606 Handle pixmap == NULL when checking for a colormap.
1609 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1611 * gtk/updateiconcache.c: Store only one copy of the pixel data
1612 for symlinked icons. To achieve this, maintain a hashtable
1613 mapping pathnames to pixel data, and share the pixel data for
1614 all symlinks resolving to the same pathname. When writing out
1615 the image data, write out the pixel data only the first time
1616 it is met, and store the offset pointing to the first copy
1617 for use in all later cases.
1618 This reduces the size of the Bluecurve icon cache from 40