1 2005-12-07 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtktreeview.c (gtk_tree_view_key_press): Use the correct
4 window when synthesizing the key event. (#323077,
5 Sadrul Habib Chowdhury)
7 (gtk_tree_view_search_key_press_event): Also listen for
8 GDK_ISO_Left_Tab. (#323077, Sadrul Habib Chowdhury)
10 * gtk/gtktextview.c (gtk_text_view_preedit_changed_handler):
11 Only scroll if we have focus. (#316310, Paolo Borelli)
13 * gtk/gtkfilesystemunix.c (cb_fill_in_mime_type): Fix a C99ism,
14 spotted by Crispin Flowerday.
16 2005-12-06 Behdad Esfahbod <behdad@gnome.org>
18 * gtk/gtksettings.c (settings_update_font_options): Turn metrics
19 hinting on (part of #307196)
21 2005-12-06 Matthias Clasen <mclasen@redhat.com>
23 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_reset): Don't
24 commit from reset, it upstets GtkTextView.
26 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink): Be more
27 careful when turning blinking on and off.
28 (gtk_text_view_focus_out_event): Make the cursor really invisible
29 when the focus goes away. (#323087, Sadrul Habib Chowdhury)
30 (cursor_blinks): Check the gtk-cursor-blink setting first.
32 * gtk/gtktreeview.c (gtk_tree_view_key_press): Fix refcounting
33 issues with new_event and its window.
35 * gtk/gtkmenu.c (gtk_menu_attach_to_widget): Accept NULL
36 as a detach func. (#323386, Jorn Baayen)
38 * gtk/gtkcalendar.c: Avoid conflict with win32 headers in
39 the libdate routines. (#323045, Kazuki Iwamoto)
41 * gdk/gdk.c (gdk_parse_args):
42 * gtk/gtkmain.c (gtk_parse_args): Don't ignore errors
43 from g_option_context_parse().
45 Tue Dec 6 11:37:59 2005 Tim Janik <timj@gtk.org>
47 * gdk/gdkevents.c (gdk_event_new): fix missing hash table
50 Tue Dec 6 10:32:17 2005 Tim Janik <timj@gtk.org>
52 * gtk/gtkstatusbar.c: ported memchunk uses to g_slice, so the code
55 2005-12-05 Federico Mena Quintero <federico@ximian.com>
57 * gtk/gtkfilechooserdefault.c (trap_activate_cb): "event->state &
58 modifiers", not "event->state && modifiers". Patch by Sadrul
59 Habib Chowdhury <imadil@gmail.com>. Fixes bug #323073.
61 2005-12-05 Matthias Clasen <mclasen@redhat.com>
65 * gtk/gtktreedatalist.c:
68 * gtk/gtkitemfactory.c:
69 * gtk/gtkseparator.[hc]:
72 * gtk/gtkgc.c: Use g_slice instead of mem chunks.
74 2005-12-05 Michael Natterer <mitch@imendio.com>
76 * gdk/x11/gdkevents-x11.c: map the new GtkSettings properties
77 "timeout-initial", "timeout-repeat", "color-scheme" and
78 "enable-enimations" to X settings.
80 2005-12-05 Matthias Clasen <mclasen@redhat.com>
83 * gdk/gdkcolor.c: Use g_slice instead of mem chunks.
85 * gtk/gtktreeview.c (gtk_tree_view_key_press): Free new_event
86 after sending it to the search entry. (#323209, Crispin Flowerday)
88 * README.in: Add a note about GTK_FLOATING.
90 * gtk/gtkobject.h (GTK_OBJECT_FLOATING): Use g_object_is_floating.
92 2005-12-02 Matthias Clasen <mclasen@redhat.com>
94 * gtk/gtktoolbutton.c (clone_image_menu_size): Don't leak
95 a pixbuf. (#323024, Paolo Borelli)
97 2005-12-02 Matthias Clasen <mclasen@redhat.com>
99 * gtk/gtkfilesystemunix.c (get_icon_for_mime_type): Don't crash
100 if mime_type is NULL. (#322998, Sadrul Habib Chowdhury)
102 2005-12-02 Michael Natterer <mitch@imendio.com>
104 * gtk/gtkmenu.c: applied modified patch from maemo-gtk which
105 adds a "horizontal-padding" style property. Fixes bug #323036.
107 2005-12-01 Michael Natterer <mitch@imendio.com>
109 Merged modified patch from maemo-gtk that allows to disable
110 toolbar animations. Addresses bug #142582.
112 * gtk/gtksettings.c: added boolean property "gtk-enable-animations".
113 (patch from Christian Neumair)
115 * gtk/gtktoolbar.c: don't animate toolbar changes if the settings
116 property is FALSE. Replaced the individual "notify::foo"
117 connections to GtkSettings by a single "notify" callback and
120 2005-12-01 Michael Natterer <mitch@imendio.com>
122 * gtk/gtkmenu.c (gtk_menu_class_init): removed redundant
123 assignment of widget_class->motion_notify_event.
125 2005-11-29 Matthias Clasen <mclasen@redhat.com>
127 * gtk/gtktoggleaction.c (gtk_toggle_action_class_init): Add
128 an active property. (#322673, Jorn Baayen)
130 Properly handle model changes in GtkTreeSelection: (#322569,
133 * gtk/gtktreeselection.c (gtk_tree_selection_selected_foreach):
134 Get a reference to the model, and stop the iteration if the model
135 of the treeview is changed on the way.
137 * gtk/gtktreeprivate.h:
138 * gtk/gtktreeselection.c (_gtk_tree_selection_emit_changed): New
139 private function to emit the GtkTreeSelection::changed signal.
141 * gtk/gtktreeview.c (gtk_tree_view_set_model): Call
142 _gtk_tree_selection_emit_changed() when the model changes.
144 2005-11-28 Federico Mena Quintero <federico@ximian.com>
146 Fixes the critical warnings from bug #317999, thus fixing the bug
149 * gtk/gtkfilechooserdefault.c
150 (gtk_file_chooser_default_get_paths): In SELECT_FOLDER mode,
151 use _gtk_file_chooser_get_current_folder_path() instead of fetching the
152 impl->current_folder directly. The latter may be null if we are
153 in RELOAD_NONE state.
155 2005-11-28 Federico Mena Quintero <federico@ximian.com>
157 Fix bug #321560, based on a patch by Bogdan Nicula (bogdanni@hotmail.com):
159 * gtk/gtkfilechooserdefault.c (up_folder_handler): Don't add the
160 current_folder to the pending select paths here; the path bar will
162 (path_bar_clicked): Add the child_path to the pending select paths
164 (show_and_select_paths): Don't filter out folders.
165 (show_and_select_paths): Don't take separate arguments for
166 only_one_path and multiple paths.
168 * tests/autotestfilechooser.c (test_folder_switch_and_filters):
169 New test about preserving the filters when we change folders.
171 2005-11-28 Matthias Clasen <mclasen@redhat.com>
173 * gtk/gtkscale.c (_gtk_scale_format_value): Insert an LRM, to prevent
174 -20 to come out as 20- in RTL locales. (#322571, Tze'ela Hebron)
176 * gtk/gtkaction.c (gtk_action_sync_button_stock_id)
177 (connect_proxy): Buttons use the label property for stock ids. (#322565,
180 * gtk/gtkiconview.c (update_text_cell, update_pixbuf_cell): Correctly
181 handle the cell list and indices into it. (#321856)
183 2005-11-28 Matthias Clasen <mclasen@redhat.com>
185 * gtk/gtktooltips.c (gtk_tooltips_timeout): Set timer_tag to 0 when
186 the timeout is done. (#322291, Jean-Yves Lefort)
188 2005-11-28 Matthias Clasen <mclasen@redhat.com>
190 * gtk/gtkfilechooserdefault.c (shortcuts_key_press_event_cb): Make
191 F2 work for renaming bookmarks. (#320822, Jaap A. Haitsma, patch
194 2005-11-28 Tor Lillqvist <tml@novell.com>
196 * gdk/win32/gdkwindow-win32.c (gdk_window_set_urgency_hint):
197 Implement the conditional use of FlashWindowEx() properly for MSVC
198 compilations. The code was confusingly assuming that if compiled
199 with a "new" compiler, it will only be run on "new" Windows
200 versions. We want it to run on "old" versions, too, even if
201 compiled with a "new" compiler. There are two orthogonal issues:
202 whether the compiler defines the necessary API in its headers, and
203 whether it is present at run-time. (#318077)
205 * gtk/gtkcalendar.c (gtk_calendar_init): Use GetLocaleInfo() on
206 Windows to get the localized weekday and month names. strftime()
207 in the Microsoft C library returns strings in the default codepage
208 for the locale of the process, not the system codepage. Thus
209 g_locale_to_utf8() isn't useable on the return value from
210 strftime(). (#322603)
212 2005-11-27 Matthias Clasen <mclasen@redhat.com>
214 * gtk/gtkmessagedialog.c (gtk_message_dialog_new_with_markup):
215 Fix an example. (#322493, Elie De Brauwer)
217 Fix two memory handling problems in GtkTreeView: (#322350,
220 * gtk/gtktreeview.c (gtk_tree_view_destroy)
221 (gtk_tree_view_set_model): Remove all references to nodes in
223 (gtk_tree_view_real_collapse_row): Unmark expanded_collapsed_node
224 before removing the children.
226 * gtk/gtkcolorbutton.c (gtk_color_button_init): Don't leak a
227 PangoLayout here. (#322505, Paolo Borelli)
229 2005-11-27 Tor Lillqvist <tml@novell.com>
231 Once again rework Win32 window decoration code. Doesn't break
232 #104514. The dialogs in gtk-demo now have the same decorations and
233 behaviour as on X11. Tried to fix #322516 but it seems very hard
234 to make the trivial sample program there behave as expected. OTOH,
235 simply moving the gtk_window_decorate() call in the #322516 sample
236 program after the call to gtk_widget_show() helps...
238 * gdk/win32/gdkwindow-win32.c (set_or_clear_style_bits): Revert to
239 the correct semantics. Each call to gdk_window_set_decorations()
240 which calls this function is supposed to affect all decorations.
242 (decorate_based_on_hints): New function, looks at both geometry
243 hints and type hint and sets window decorations based on
244 that. Consolidate code from gdk_window_set_geometry_hints() and
245 gdk_window_set_type_hint() here.
247 (gdk_window_set_geometry_hints, gdk_window_set_type_hint): Call
248 decorate_based_on_hints().
250 2005-11-25 Dom Lachowicz <cinamod@hotmail.com>
252 * modules/engines/ms-windows/*.[ch]: Merge with gtk-wimp's CVS.
253 Includes improved menu icon spacing, [+]/[-] expander drawing,
254 status-bar gippie drawing, and notebook tab drawing.
256 2005-11-24 Michael Natterer <mitch@imendio.com>
258 * gtk/gtktoolbar.h (struct _GtkToolbar): changed two private guint
259 that used to hold signal handler IDs to two guint of padding.
261 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): added them as
264 (gtk_toolbar_screen_changed): changed accordingly.
266 Wed Nov 23 18:55:47 2005 Tim Janik <timj@imendio.com>
268 * gtk/gtkobject.[hc]: deprecated floating/sink API and implemented it
269 in terms of the GObject floating/sink API.
271 * gtk/gtkaboutdialog.c:
277 * gtk/gtkfilechooserdefault.c:
279 * gtk/gtkinvisible.c:
280 * gtk/gtkitemfactory.c:
283 * gtk/gtkmenutoolbutton.c:
287 * gtk/gtkspinbutton.c:
288 * gtk/gtkstatusicon.c:
292 * gtk/gtktoolbutton.c:
296 * gtk/gtktreeviewcolumn.c:
297 * gtk/gtkuimanager.c:
301 ported to use GObject's g_object_ref_sink().
304 * gtk/gtkfilechooserdefault.c:
305 * gtk/gtkaboutdialog.c:
306 fixed compiler warnings.
308 2005-11-23 Matthias Clasen <mclasen@redhat.com>
310 * gtk/gtksettings.c (gtk_settings_class_init): Add some docs
311 about gtk-color-scheme.
313 2005-11-23 Behdad Esfahbod <behdad@gnome.org>
315 * configure.in (enable_explicit_deps): Fix typo when checking
316 libtool config deplibs_check_method. Moreover, enable explicit
317 deps if we get anything other than pass_all from libtool. (part of
320 2005-11-23 Matthias Clasen <mclasen@redhat.com>
322 * gtk/updateiconcache.c (write_csource): Don't create a big
323 string, since Visual C++ doesn't like strings longer than 64k.
324 (#322238, Kazuki IWAMOTO
326 * gtk/gtkentry.c: Include gtkimcontextsimple.h (#322235,
329 2005-11-23 Michael Natterer <mitch@imendio.com>
331 * gtk/gtkrc.c (gtk_rc_reset_widgets): don't leak all toplevel
332 windows on other screens (correctly remove all temporary
335 2005-11-23 Michael Natterer <mitch@imendio.com>
337 Added symbolic themable colors. Patch is a merged version of
338 proposals from Matthias and maemo-gtk. Fixes bug #114355.
340 * configure.in: require glib >= 2.9.1 for refcountable hashtables.
342 * gtk/gtksettings.c: added property "color-scheme" which is a
343 string defining colors like "foreground:black\nbackground:grey".
344 Automatically provide a name->GdkColor hash table mapping for the
347 * gtk/gtkrc.[ch]: added list of color hashes that works like the
348 list of icon factories. Append the color scheme hash from
349 GtkSettings if it exists. Extended gtkrc syntax to allow defining
350 and referencing of logical colors. Also allow to modulate colors
351 in gtkrc by using arbitrary expressions of mix(), shade(),
352 lighter() and darker(). Added internal function
353 _gtk_rc_style_get_color_hashes().
355 * gtk/gtkstyle.[ch]: keep a private list of color hashes around.
356 Get the list from _gtk_rc_style_get_color_hashes(). Export
357 internal function _gtk_style_shade() (used by above color
358 expressions). Added public API gtk_style_lookup_color() which
359 looks up a logical color by name.
361 * gtk/gtk.symbols: add gtk_style_lookup_color
363 * tests/testgtkrc: use symbolic colors for making
366 2005-11-22 Michael Natterer <mitch@imendio.com>
368 Made button-press timeouts which work like key repeat timeouts
369 configurable. Addresses bug #142582:
371 * gtk/gtksettings.c: added properties "gtk-timeout-initial" and
372 "gtk-timeout-repeat" which defalt to 200/20 (ms).
374 Use the values from GtkSettings instead of hardcoding them
375 (the repeat value is either taken as-is for fast repeat or
376 multiplied by 5 for slow repeat). Changed all places to use these
377 two standard initial/repeat timings:
379 * gtk/gtkcalendar.c (unchanged 200/20)
380 * gtk/gtknotebook.c (unchanged 200/100)
381 * gtk/gtkpathbar.c (changed from 300/150 to 200/100)
382 * gtk/gtkrange.c (changed from 250/100 to 200/100)
383 * gtk/gtkspinbutton.c (unchanged 200/20)
385 2005-11-21 Anders Carlsson <andersca@imendio.com>
393 * docs/tools/Makefile.am:
394 Only build docshooter when the X11 backend is used.
396 * gtk/gtkplug-stub.c:
397 Include gtkplug.h here.
399 * gtk/gtksocket-stub.c:
400 Include gtksocket.h here.
402 2005-11-21 Matthias Clasen <mclasen@redhat.com>
404 * gtk/gtkinputdialog.c: Convert GtkInputDialog to
405 g_type_class_add_private.
407 * gtk/gtksocket.c: Convert GtkSocket to g_type_class_add_private.
409 * gtk/gtkmenu.c: Convert GtkMenu to g_type_class_add_private.
412 * gtk/gtkcombobox.[hc]: Add a tearoff-title property,
413 with getter and setter. (#316482, Olexiy Avramchenko)
415 * tests/testcombo.c (main): Test gtk_combo_box_set_title
417 * gtk/gtkpathbar.c: Merge remaining fixes from the 2.8 branch,
418 pointed out by Michael Natterer.
420 Fix for bug #321542, Benedikt Meurer:
422 * gtk/gtkcombobox.c (gtk_combo_box_set_active_internal):
425 (gtk_combo_box_child_show, gtk_combo_box_child_hide): Use
426 g_signal_emit, not g_signal_emit_by_name.
428 2005-11-18 Matthias Clasen <mclasen@redhat.com>
430 Fix crashes in connection with pathbar scrolling (#321560,
433 * gtk/gtkpathbar.c (gtk_path_bar_update_slider_buttons):
434 Stop scrolling when desensitising slider buttons.
435 (gtk_path_bar_scroll_timeout, gtk_path_bar_slider_button_press):
438 * gtk/gtkpathbar.h (struct _GtkPathBar): Add a separate
441 2005-11-18 Matthias Clasen <mclasen@redhat.com>
443 * gtk/gtkpathbar.c (button_clicked_cb): Fix a C99ism.
444 (#321777, Jens Granseuer)
446 * gtk/gtkaction.c (disconnect_proxy): Disconnect the
447 sync callback for the visibility property. (#321761,
450 Turn off input methods in invisible entries, since
451 they are confusing. (#317002, James Su)
453 * gtk/gtkentry.c (gtk_entry_set_visibility): Toggle input
454 methods if visibility changes.
455 (popup_targets_received): Don't show the input method
456 menu if the entry is invisible.
458 2005-11-17 Matthias Clasen <mclasen@redhat.com>
460 * README.in: Add a note about range arrow sensitivity.
462 * perf/treeview.c: const correctness fixes
463 found by Arjan van de Ven and gcc.
465 2005-11-16 Michael Natterer <mitch@imendio.com>
467 * gtk/gtkimage.c (animation_timeout): call
468 gtk_window_process_updates() so the animation keeps running even
469 if the main loop is busy with sources that eat a lot of cpu with
470 high priority. Fixes bug #321444.
472 (gtk_image_new_from_animation): document the fact that the
473 animation will stop running if the main loop is busy with sources
474 that have priorities higher than G_PRIORITY_DEFAULT.
476 * tests/testimage.c: added test case that shows an animation even
477 though a cpu-eating idle function is running.
479 2005-11-16 Michael Natterer <mitch@imendio.com>
481 * gdk/x11/gdkevents-x11.c (_gdk_events_uninit): new internal
482 function which destroys the display's event source. Also removes
483 the source from the global display_sources list and unrefs it.
485 * gdk/x11/gdkprivate-x11.h: declare the function.
487 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_dispose): call it
488 instead of half-destroying the source here.
490 2005-11-15 Matthias Clasen <mclasen@redhat.com>
492 * gtk/gtktreestore.c (gtk_tree_store_move): Fix a memory
493 leak. (#321032, Peter Zelezny)
495 2005-11-15 Michael Natterer <mitch@imendio.com>
497 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_finalize): destroy
498 display->xid_ht as late as possible (right before XCloseDisplay)
499 because it still needs to be around when the display's screens are
502 2005-11-14 Matthias Clasen <mclasen@redhat.com>
504 * gtk/gtkselection.c (gtk_selection_data_set_uris): Don't
505 leak result. (#321441, Tommi Komulainen)
507 2005-11-14 Matthias Clasen <mclasen@redhat.com>
509 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes):
510 Don't crash if there is no builtin icon.
512 2005-11-14 Michael Natterer <mitch@imendio.com>
514 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_set_property):
515 removed redundant calls to g_object_notify().
517 2005-11-13 Matthias Clasen <mclasen@redhat.com>
519 * gdk/gdkcolor.c (gdk_color_parse): Documentation
520 improvements. (#321338)
522 * gtk/gtktextiter.c (gtk_text_iter_forward_search): Make
523 limit an inclusive boundary. (#321299)
525 2005-11-12 Michael Natterer <mitch@imendio.com>
527 * gtk/Makefile.am: fixed icon rules so gtkbuiltincache.h is only
530 2005-11-12 Dom Lachowicz <cinamod@hotmail.com>
532 * modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
533 theme's handling of toolbars, handleboxes, and menubars more in-line
534 with Microsoft's IE style.
535 * modules/engines/ms-windows/*.c: Indentation cleanups
537 2005-11-12 Matthias Clasen <mclasen@redhat.com>
539 Make builtin icons work in gtk_window_set_icon_name()
540 (#321046, Maxim Udushlivy)
542 * gtk/gtkicontheme.c (insert_theme): Always insert the default
544 (ensure_valid_themes): Call _gtk_icon_theme_ensure_builtin_cache()
546 (theme_lookup_icon, find_builtin_icon): ...and not from here.
547 (gtk_icon_theme_lookup_icon): Remove an unncessary assert.
548 (gtk_icon_theme_get_icon_sizes): Also check builtin icons.
550 2005-11-12 Tor Lillqvist <tml@novell.com>
552 * gtk/gtkfilesystemwin32.c (filename_get_info): Don't hide
553 dotfiles, no such convention on Win32. Just hide files with the
554 hidden attribute. (#314627)
556 2005-11-11 Federico Mena Quintero <federico@ximian.com>
558 * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Do not
559 check whether the path is a folder. It is useful to bookmark
560 files as well (e.g. todo.txt), and this will also help
562 (shortcuts_add_bookmark_from_path): Likewise.
563 (shortcuts_activate_iter): Change folders or select files, as
566 2005-11-11 Federico Mena Quintero <federico@ximian.com>
568 * tests/autotestfilechooser.c (main): Use
569 g_log_set_default_handler() instead of explicitly setting a
570 handler for each domain.
572 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Only get
573 the base path of the volume if it is mounted.
575 2005-11-11 Michael Natterer <mitch@imendio.com>
577 Added per-stepper API for GtkRange's stepper sensitivity as
578 discussed in bug #321056:
580 * gtk/gtkenums.h: added GtkSensitivityType which can be
583 * gtk/gtkrange.[ch]: added properties "lower-stepper-sensitivity"
584 and "upper-stepper-sensitivity" and public getters/setters for
585 them. Changed stepper drawing to honor the new properties.
587 * gtk/gtk.symbols: added the new symbols.
589 2005-11-10 Matthias Clasen <mclasen@redhat.com>
591 * gtk/gtkcombobox.c: Add show-popup and hide-popup signals and
592 emit them when the popup is shown or hidden. (#162531, Tommi
595 * tests/testcombo.c: Add an example of popuplating a combobox
598 * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Another
601 * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
604 Don't corrupt odd keymaps (#316638, Kean Johnston)
606 * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
607 handle frobbing keymaps with odd numbers of syms/code.
609 * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
612 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
614 * gtk/gtkpathbar.[hc]: Add a child_path argument to
615 the path_clicked signal.
616 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
617 child_path, if it is provided.
618 * gtk/marshalers.list (path_bar_clicked): Add the necessary
621 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
626 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
627 (#163851, Richard Hult)
629 2005-11-10 Michael Natterer <mitch@imendio.com>
631 Applied patch from maemo-gtk that addresses many issues wrt
632 display migration and display closing (bug #85715).
634 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
635 default display to NULL when it's closed. Instead set the most
636 recently opened display as new default (if one exists).
638 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
641 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
642 exist before unrefing them.
644 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
645 is closed, allow destruction of the root window.
647 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
648 dispose(), free stuff that was leaked before.
650 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
651 the xsettings_client still exists before destroying it.
653 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
656 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
657 dispose() implementation.
659 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
660 dispose() and check if it still exists before unrefing it. Set
661 their pointers to NULL/None *after* upchaining in dispose(),
662 because X11 implementations of members of the parent class still
663 need them for their own destruction.
665 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
666 was g_error()ing when finalizing a visual.
668 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
669 get_clipboard_widget() because it would create the widget if it
670 doesn't exist. Use g_object_get_data() directly instead.
672 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
675 2005-11-10 Simos Xenitellis <simos@gnome.org>
677 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
679 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
681 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
682 to render its arrows insensitive when the adjustment is in
683 its min or max position. this makes range arrow behaviour
684 consistent with spin button behaviour. (#321056)
686 2005-11-09 Tor Lillqvist <tml@novell.com>
689 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
690 the GdkDebugFlag enum.
692 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
693 this file instead of MISC. Now asking for MISC will give mainly
694 window manipulation debugging output with the Win32 backend.
696 2005-11-09 Tor Lillqvist <tml@novell.com>
698 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
700 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
701 function which was used only in one place.
703 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
705 (gdk_window_set_geometry_hints): If we have identical minimum and
706 maximum size hints, remove the resize and maximize
707 decorations/functions. (#104514)
709 If we have a maximum size hint, remove the maximize
710 decoration/function but ensure the resize decoration/function is
711 available. Otherwise ensure both resize and maximize
712 decorations/functions are there.
714 (set_or_clear_style_bits): Factored out common code from
715 gdk_window_set_decorations() and gdk_window_set_functions().
717 Hack the window style setting once more: Only touch the window
718 style bits corresponding to the GdkWMDecoration or GdkWMFunction
719 parameter bitmasks. Hopefully this finally is the correct thing to
720 do. We used to clear all other bits than those that were being
721 set, or set all other bits than those that were being cleared.
723 Take into account that adding or removing decorations leaves the
724 window's outer size unchanged, i.e., the client area's size and
725 position change. This is apparently not what we want, so change
726 also the window's (outer) position and size appropriately so that
727 the client area's position and size stay constant.
729 gtk-demo's color selector dialog is now non-resizable like on X11
730 (I tested with metacity in GNOME). Torn off menus are shrinkable
731 vertically but have a maximum size, and are not maximizable or
732 minimizable, like on X11.
734 (gdk_window_set_decorations, gdk_window_set_functions): Let
735 set_or_clear_decorations() do most of the job.
737 * gdk/win32/gdkprivate-win32.h: Remove declaration of
738 _gdk_win32_get_adjusted_client_rect().
740 2005-11-09 Tor Lillqvist <tml@novell.com>
742 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
743 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
744 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
745 type hint. Implement gdk_window_get_type_hint() by just returning
748 2005-11-09 Tor Lillqvist <tml@novell.com>
750 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
751 Remove code that has been permanently ifdeffed out for two years.
753 2005-11-08 Matthias Clasen <mclasen@redhat.com>
755 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
756 finalizing a gc. (#320789, Nickolay V. Shmyrev)
758 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
759 icons if they would make the request large enough to cause
760 Xlib to loose the connection. (#320909, Claudio Saavedra)
762 2005-11-08 Michael Natterer <mitch@imendio.com>
766 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
767 extracted from maemo-gtk). Fixes bug #320872.
769 2005-11-07 Matthias Clasen <mclasen@redhat.com>
771 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
772 looks the bookmark label when reordering. (#320720, Jeremy Cook)
774 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
775 Don't grab focus when a slider button is pressed, instead, use
776 a bit in the pathbar struct to determine whether to scroll up
777 or down. (#314486, Carlos Garnacho)
779 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
780 Don't popup the completions if the focus has already been
781 moved somewhere else. (#319914, Christian Persch)
783 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
784 Raise the drag_window after reconfiguring the
785 toolbar. (#320803, Christian Persch)
788 * gtk/gtkfilechooserbutton.h:
789 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
790 with setter and getter. (#318945, Christian Persch)
792 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
794 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
796 2005-11-07 Matthias Clasen <mclasen@redhat.com>
798 * configure.in: Adjust to the stock icon changes.
800 2005-11-07 Tor Lillqvist <tml@novell.com>
802 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
803 Correct the calculation of maskstride. (#320152, Peter Zelezny)
805 2005-11-06 Michael Natterer <mitch@imendio.com>
807 * gtk/Makefile.am (icons): fixed rule to actually create the
808 symlinks, erroring out if anything goes wrong.
810 2005-11-06 Tor Lillqvist <tml@novell.com>
812 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
813 target exists on Win32. First rename the target temporarily, then
814 if the renaming of the source to target fails, restore the
815 original name for the target.
817 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
819 2005-11-06 Tor Lillqvist <tml@novell.com>
821 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
822 like pixbuf_to_hbitmaps_normal().
823 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
824 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
825 setting the G_WIN32_PRETEND_WIN9X environment variable.
827 2005-11-06 Tor Lillqvist <tml@novell.com>
829 Make icon masks work on Win98 (#320152, Peter Zelezny)
831 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
832 parameter for the depth of the bitmap, so that this function can
833 be used to create 1-bit bitmaps, too.
834 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
835 and initialize it properly.
837 2005-11-04 Matthias Clasen <mclasen@redhat.com>
839 Store builtin stock icons in an icon cache, instead of
840 populating a hash table with pixbufs at startup, to save both
841 memory and startup time.
843 * gtk/stock-icons/*: Reorganize the icons in a directory structure
844 suitable for gtk-update-icon-cache, and rename them to match the
847 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
848 add _gtk_icon_cache_has_icon_in_directory().
850 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
851 to store the contents of the icon cache in a C header.
853 * gtk/gtkbuiltincache.h: Generated private header which contains
854 the icon cache for the builtin icons.
856 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
857 icons, and use that in addition to the hash table whenever
858 builtin icons are searched.
860 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
861 use it for static stock ids.
862 (get_default_icons): Don't add the builtin
863 icons to the icon theme, just register the stock ids.
864 (render_fallback_image): Take the fallback image out of the
867 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
868 the necessary machinery to rebuild gtkbuiltincache.h.
870 2005-11-04 Michael Natterer <mitch@imendio.com>
872 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
873 from maemo-gtk that changes the mtime check for rc files from
874 '>' to '!=', otherwise theme changes go unnoticed when turning
875 back the clock (Tommi Komulainen).
877 2005-11-04 Tor Lillqvist <tml@novell.com>
879 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
882 2005-11-03 Tor Lillqvist <tml@novell.com>
884 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
885 the Win32 backend, check that GdkDisplay* parameters are equal to
886 _gdk_display instead of using the unnecessarily general
889 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
890 color bitmap to have "color" in their name, for similarity with
891 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
892 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
893 the mask bitmap's contents, ones for those pixels in the color
894 bitmap where the alpha is zero, zero for other pixels. We used to
895 use an uninitialized mask bitmap! This meant that icons and
896 cursors created presumably worked more or less by accident.
897 Totally blank icons with zero alpha everywhere (as used by
898 gtktrayicon.c) definitely did not work as expected.
900 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
902 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
903 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
904 necessary and can be removed from CVS. It has never been mentioned
905 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
906 are used on Win32. One label widget is used (but never shown) as
907 gtk_widget_render_icon() needs a widget.
909 Ifdefs used as necessary in several places. It might be cleaner to
910 split out the backend-specific parts to separate files, or at
911 least collect them into separate blocks in the file.
913 (wndproc): New function. Window procedure to monitor mouse events
914 in the system tray icon. Call gtk_status_icon_button_press() as
916 (create_tray_observer): New function. Creates a hidden window that
917 only serves as a tray icon message observer.
919 * tests/teststatusicon.c (icon_activated): Position the dialog
920 with GTK_WIN_POS_CENTER.
921 (do_quit): New function, hide and unref the GtkStatusIcon, and
922 call gtk_main_quit().
923 (popup_menu): Add a Quit menu item that calls do_quit().
925 2005-11-02 Tor Lillqvist <tml@novell.com>
927 * gdk/win32/gdkcolor-win32.c
928 * gdk/win32/gdkscreen-win32.c
929 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
930 fixes. Remove superfluous test for GdkWindow* parameters being
931 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
932 GdkScreen and one GdkDisplay in the Win32 backend, use those
933 variables instead of the getter functions. For GdkDisplay* and
934 GdkScreen* parameters, check that they are equal to the
935 corresponding singleton variables instead of the more general
936 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
938 2005-11-02 Matthias Clasen <mclasen@redhat.com>
940 * gtk/gtktextview.c: Remove some g_return_if_fail() from
941 static functions, replace some others by g_assert().
943 * gtk/gtktextview.c (selection_motion_event_handler)
944 (gtk_text_view_start_selection_drag): Keep track of the original
945 selection boundaries during a drag selection, in order to correctly
946 decide when to extend or shrink the selection. (#320167,
947 reported by Arvind S N, patch by Paolo Borelli)
949 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
950 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
951 manual offset calculations by g_utf8_offset_to_pointer().
952 (#320360, Paolo Borelli)
954 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
956 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
957 nodes via the g_slice_*() API.
958 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
960 2005-11-01 Tor Lillqvist <tml@novell.com>
962 * gdk/win32/gdkprivate-win32.h
963 * gdk/win32/gdkglobals-win32.c
964 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
965 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
966 their declarations, definitions and assignments into a more
967 logical and consistent order.
969 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
970 CF_ prefix for the predefined clipboard format names. Put quotes
971 around registered format names to distinguish them.
973 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
974 immediately with a warning if the property type is STRING, TEXT,
975 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
976 should never pretend to handle on Win32. Handle only UTF8_STRING
977 here, other formats with delayed rendering. Use \uc1 instead of
978 \uc0 when generating Rich Text Format for easier testability on
979 XP, where WordPad misinterprets \uc0 encoded characters. Add more
980 GDK_NOTE debugging output for Clipboard operations.
982 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
983 (gdk_selection_convert): Don't pretent to handle STRING, just
984 UTF8_STRING. Streamline error handling, don't unnecessarily have a
985 GError which then isn't used for anything anyway if it gets set.
986 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
987 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
989 * config.h.win32.in: Sync with what configure produces.
991 * configure.in: Don't look for X_PACKAGES unless building for
992 x11. (#313986, John Ehresman)
994 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
996 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
997 Wondered why there was no ku there before??
999 2005-10-28 Matthias Clasen <mclasen@redhat.com>
1001 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
1002 window to the toplevels window group. (#319912, Christian Persch)
1004 2005-10-28 Kristian Rietveld <kris@gtk.org>
1006 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
1009 2005-10-28 Matthias Clasen <mclasen@redhat.com>
1011 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
1012 drag cursors. (#319200, Federico Mena Quintero)
1014 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
1015 Shift-G to go to the previous match, like firefox. (#320061, Christian
1018 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
1019 C99ism. (#320000, Kazuki Iwamoto)
1021 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
1022 stars. (#319985, Bastien Nocera)
1024 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
1025 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
1027 2005-10-26 Michael Natterer <mitch@imendio.com>
1031 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
1032 make sure that setting any of pixbuf/stock-id/icon-name resets the
1033 others because they are mutually exclusive, and that unsetting any
1034 of them only resets the pixbuf and nothing else. Also added
1035 some missing g_object_notify().
1037 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
1038 g_value_set_object().
1040 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
1041 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
1042 g_object_notify ("pixbuf").
1044 2005-10-27 Matthias Clasen <mclasen@redhat.com>
1046 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
1047 careful about initializing cell_area. (#319382, Tommi
1050 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
1051 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
1053 * demos/gtk-demo/clipboard.c (paste_received): Only set the
1054 text if it is not NULL. (#319930, Thomas Klausner)
1056 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
1057 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
1059 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1061 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
1062 * gtk/gtkthemes.c (gtk_theme_engine_load):
1063 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
1064 when dlopening modules. (#319557, Laszlo Peter)
1066 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1068 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
1069 segments when determining text direction. (#319065, Tommi Komulainen)
1071 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
1072 on duplicate destroy. (#318953, Gustavo Carneiro)
1074 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
1075 Point out that destroy-with-parent is a bad idea for the dialog
1076 passed to this function. (#318943, Christian Persch)
1078 * */Makefile.am: use $(GLIB_MKENUMS) instead of
1079 glib-mkenums. (#318582, Damien Carbery)
1081 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
1082 docs. (#317682, Christian Neumair)
1084 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
1085 seem to affect the placement of the data in the readonly
1086 section, and causes problems with some compilers. (#317844)
1088 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1090 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
1091 Fix some issues with background drawing in RTL. (#318781,
1094 * tests/Makefile.am:
1095 * tests/testentrycompletion.c: Apply a patch by Christian
1096 Persch to add property editors.
1098 * gtk/gtkstatusicon.c: Emit activate on single-click,
1099 not on double-click, change proposed by Milosz Derezynski.
1101 2005-10-25 Kristian Rietveld <kris@gtk.org>
1103 Fixes #311955, reported by Markku Vire; and a lot more.
1105 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
1106 Levels can now have invisible nodes cached, functions have been
1107 rewritten/refactored to take this into account; also the logic in
1108 some functions has been corrected.
1110 Each referenced node now references all visible children or a single
1111 invisible child, in order to be able to monitor all changes in the
1112 child model required for correct operation.
1114 When a virtual root is set, all nodes on the virtual root level are
1117 At last, a bunch of random bug fixes and comment updates.
1119 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1121 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
1122 more docs. (#319722, Paolo Borelli)
1124 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
1125 initialization of screen_x11->xft_rgba more explicit. (#319627,
1128 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
1129 in a blurb. (#319499, Francisco Javier F. Serrador)
1131 2005-10-24 Matthias Clasen <mclasen@redhat.com>
1133 Add settings to hide the input method and Unicode control character
1134 submenus in the context menus of GtkEntry and GtkTextView.
1136 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
1138 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
1140 * gtk/gtktextview.c (popup_targets_received):
1141 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
1143 2005-10-24 Kristian Rietveld <kris@gtk.org>
1145 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
1146 row-has-child-toggled when the level is not in the cache does not
1147 make sense. (This bug probably crept in during the early stages
1148 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
1149 implementation yet),
1150 (gtk_tree_model_sort_real_unref_node): only get the child iter
1151 when we will actually also use it.
1153 2005-10-22 Michael Natterer <mitch@imendio.com>
1155 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
1156 widget being realized, in addition to being visible, to avoid
1157 running into precondition check in gtk_tree_view_get_cell_area().
1160 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
1162 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
1163 Experimentally, scrollbar steppers can shrink to 8 pixels on
1164 Win32. Reflect that in the theme.
1165 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
1166 there is a 1-pixel border between a scrollbar and its child
1167 in ScrolledWindows on Win32. Reflect that in the theme.
1169 2005-10-20 Matthias Clasen <mclasen@redhat.com>
1171 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
1172 for the selection window. (#318806, Alex Larsson)
1174 2005-10-18 Federico Mena Quintero <federico@ximian.com>
1178 * tests/autotestfilechooser.c
1179 (test_button_folder_states_for_action): Test that we have either
1180 $cwd or the explicitly-set folder.
1181 (test_reload_sequence): Likewise.
1183 * gtk/gtkfilechooserdefault.c
1184 (gtk_file_chooser_default_get_current_folder): If our reload_state
1185 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
1187 2005-10-14 Tor Lillqvist <tml@novell.com>
1189 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
1190 It didn't really do anything useful, and was just confusing and
1191 incomplete. Comments claimed we don't do delayed rendering, but in
1192 fact we do, for images. (The delayed rendering code has other
1193 problems, though, see #168173.) The clipboard viewer code was
1194 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
1195 the message when necessary). It was just test code, it said so in
1196 a comment. Add something similar back later if necessary.
1198 (_win32_on_clipboard_change,
1199 _gdk_win32_register_clipboard_notification): Remove.
1201 (gdk_display_supports_selection_notification,
1202 gdk_display_request_selection_notification): Always just return
1203 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
1205 2005-10-13 Tor Lillqvist <tml@novell.com>
1207 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
1208 Alt-Enter specially. It does not have any special meaning and
1209 should be passed on to the application. (#318378, Tim Evans)
1211 2005-10-13 Tor Lillqvist <tml@novell.com>
1213 Set visual depth to 24 for 32 bits-per-pixel devices on
1214 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
1215 optimized composite_0888() function rather than the slower image
1216 dithering functions to draw pixbufs (#313993, John Ehresman)
1218 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
1219 _gdk_windowing_get_bits_for_depth() to initialize
1220 GdkImage::bits_per_pixel.
1221 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
1223 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
1224 _gdk_windowing_get_bits_for_depth() to initialize
1225 BITMAPINFOHEADER::biBitCount.
1227 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
1228 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
1231 2005-10-12 Stefan Kost <ensonic@users.sf.net>
1233 * demos/gtk-demo/appwindow.c: (about_cb):
1234 use PACKAGE_VERSION,bump year (#318654)
1236 2005-10-11 Matthias Clasen <mclasen@redhat.com>
1238 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
1239 toggle here with the matching on toggle if it immediately follows.
1240 This is a common case, and handling it here prevents quadratic blowup
1241 in cleanup_line() below. (#317125)
1243 * gtk/gtktextsegment.h:
1244 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
1245 the character counts into this function instead of computing them
1248 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
1250 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
1252 * gtk/gtkfilechooserdefault.c
1253 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
1254 when the shortcut already exists in the sidebar. (#147521)
1256 2005-10-09 Matthias Clasen <mclasen@redhat.com>
1258 * tests/testcombo.c: Demonstrate how to use custom widgets in
1261 2005-10-07 Federico Mena Quintero <federico@ximian.com>
1265 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
1266 the the result of gtk_file_chooser_get_folder() is NULL or
1267 non-NULL at the right times. Log the tests.
1268 (test_button_folder_states): New test for the initial states of
1269 the current folder in GtkFileChooserButton.
1270 (main): Test that the number of warnings/errors/critical errors is
1273 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
1274 Clarify the documentation on when this can return NULL.
1275 (gtk_file_chooser_get_current_folder_uri): Likewise.
1277 * gtk/gtkfilechooserbutton.c (struct
1278 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
1279 we use it to keep track of whether a folder has been set.
1280 (gtk_file_chooser_button_map): Implement. If no folder has been
1281 loaded before, we at least try to load $cwd here.
1282 (gtk_file_chooser_button_constructor): If the construct-time
1283 dialog already has a folder set, turn on our folder_has_been_set
1285 (dialog_current_folder_changed_cb): Turn on our
1286 folder_has_been_set flag.
1288 2005-10-07 Michael Natterer <mitch@gimp.org>
1290 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
1291 PROFILE_FILE_CHOOSER because they break compilation after the
1292 removal of <unistd.h>.
1294 2005-10-07 Matthias Clasen <mclasen@redhat.com>
1296 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
1297 by moving it out of the profiling ifdef.
1299 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
1300 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
1302 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
1303 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
1306 2005-10-06 Matthias Clasen <mclasen@redhat.com>
1309 * gtk/gtktextbuffer.h:
1310 * gtk/gtktextbuffer.c: Add a readonly has-selection property
1311 with a getter. (#318161, Paolo Borelli)
1313 2005-10-05 Matthias Clasen <mclasen@redhat.com>
1315 * README.in: Start collecting release notes for 2.10.
1317 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
1318 leak fix, since the assertion failures were traced to
1319 an xchat bug. (#314696)
1321 * gtk/gtkstyle.c (gtk_style_detach):
1322 (gtk_style_attach): Documentation improvements.
1323 (gtk_style_detach): Assert that the attach_count is > 0.
1325 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1327 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
1328 shortcut position, not a ShortcutsIndex, to make the function more
1330 (home_folder_handler): Pass the resolved index to
1331 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
1332 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
1333 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
1334 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
1335 make the respective key switch to the first, second, ..., tenth
1337 (quick_bookmark_handler): Implement.
1339 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1341 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
1342 Desktop; just use their real names on the file system for the
1345 * gtk/gtkfilechooserdefault.c
1346 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
1347 binding signal, and bind it to M-d by default.
1348 (desktop_folder_handler): Implement the default handler.
1349 (home_folder_handler): Use a helper function.
1350 (switch_to_shortcut): New helper function.
1351 (shortcuts_append_home): Don't special-case the name of "Home";
1352 just use the folder name.
1354 2005-10-04 Tor Lillqvist <tml@novell.com>
1356 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
1357 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
1359 2005-10-04 Matthias Clasen <mclasen@redhat.com>
1361 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
1362 from yesterday, since it leads to assertion failures. (#317879,
1365 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1367 * gtk/gtkcalendar.c (gtk_calendar_init): Call
1368 calendar_compute_days() after setting priv->week_start.
1370 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1372 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
1373 removing it from the hash table. (#314696, Benjamin Berg)
1375 2005-10-01 Tor Lillqvist <tml@novell.com>
1377 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
1378 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
1379 is that the the desktop isn't visible because the session has been
1380 switched, the screen is locked, or a terminal server session
1381 disconnected, so no error message necessary. (#137796)
1383 It is of course remotely possible that BitBlt() failing with
1384 ERROR_INVALID_HANDLE might also be caused by some other
1385 problem. We could strive for perfection and track whether the
1386 desktop is visible by using WTSRegisterSessionNotification() and
1387 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
1388 this issue, though. If we would track desktop visibility, we
1389 should then avoid even trying to update the display at all while
1390 the desktop isn't visible.
1392 2005-09-30 Matthias Clasen <mclasen@redhat.com>
1394 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
1395 to correct the calculations for the first week day. We may
1396 just have to remove this code if too many locales turn out
1397 to have broken data.
1399 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
1400 some cases. (#317611, Tommi Komulainen)
1402 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
1403 Prevent overflow when storing size hints in an unsigned
1404 short variable. Tracked down by Ray Strode and Søren Sandmann.
1406 2005-09-29 Matthias Clasen <mclasen@redhat.com>
1408 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
1411 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
1412 grab shadowed. (#317332)
1414 2005-09-29 Tor Lillqvist <tml@novell.com>
1416 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
1418 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1420 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
1421 if the unmap test fails.
1422 (test_reload_sequence): Use gtk_widget_show_now() instead of
1423 gtk_widget_show() for the dialog.
1424 Thanks to Tim Janik for noticing these.
1426 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1428 * tests/testcellrenderertext.c: New file with a set of tests for
1429 GtkCellRendererText. The idea is to run a text renderer through
1430 most of its interesting property values to see that it works
1433 * tests/Makefile.am: Added testcellrenderertext.
1435 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
1436 entry/exit of this function for profiling.
1437 (gtk_file_chooser_default_style_set): Mark the start/end of the
1438 calls to the parent class and the the signal emission for profiling.
1440 2005-09-29 Tor Lillqvist <tml@novell.com>
1442 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
1443 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
1444 system codepage using g_win32_locale_filename_from_utf8().
1445 (#317457, Kazuki Iwamoto)
1447 2005-09-28 Matthias Clasen <mclasen@redhat.com>
1449 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
1450 here. (#317039, Paolo Borelli)
1453 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
1454 to make this function work as boxed copy function. (#317455,
1457 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
1458 NULL. (#316828, Tor Lillqvist)
1460 2005-09-28 Tor Lillqvist <tml@novell.com>
1462 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
1465 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1467 Don't reload the current folder unnecessarily on ::map().
1469 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
1470 the reloading state.
1471 (struct _GtkFileChooserDefault): Added a "reload_state" field.
1473 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
1474 Initialize impl->reload_state.
1475 (gtk_file_chooser_default_map): Check the impl->reload_state; load
1476 a default folder if no folder has been set, or reload the current
1477 one only if we had been unmapped first.
1478 (gtk_file_chooser_default_update_current_folder): Set the
1479 reload_state to RELOAD_HAS_FOLDER.
1480 (gtk_file_chooser_default_unmap): Implement, and set the
1481 reload_state to RELOAD_WAS_UNMAPPED.
1482 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
1483 here; they'll get (re)loaded on ::map() anyway.
1485 * gtk/gtkfilechooserwidget.c
1486 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
1488 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
1489 a dialog; build it ourselves.
1490 (test_reload): New test to ensure that we don't load the default
1491 folder more than once, and that we reload it when
1492 unmapping/remapping.
1493 (get_impl_from_dialog): New utility function.
1494 (test_widgets_for_current_action): Use get_impl_from_dialog().
1496 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1498 * gtk/gtkfilechooserdefault.c
1499 (gtk_file_chooser_default_constructor): Mark the entry/exit of
1500 this function for profiling.
1501 (check_icon_theme): Likewise.
1502 (change_icon_theme): Likewise.
1503 (settings_notify_cb): Likewise.
1504 (gtk_file_chooser_default_screen_changed): Likewise.
1505 (update_chooser_entry): If the selection is empty, clear the file
1506 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
1507 nothing will be selected when the user starts typeahead in the
1508 treeview, and we don't want to clear the file name entry in that
1509 case --- the user could be typing-ahead to look for a folder name.
1510 Fixes bug #308332, patch by Jürg Billeter.
1512 2005-09-27 Matthias Clasen <mclasen@redhat.com>
1514 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1515 Pop below the entry if there's more free space below the entry
1516 than above. (#316948, Tommi Komulainen)
1518 2005-09-26 Federico Mena Quintero <federico@ximian.com>
1520 Do not create the save mode-specific widgets in the open modes, so
1521 that we don't carry their baggage around.
1523 * gtk/gtkfilechooserdefault.c
1524 (gtk_file_chooser_default_constructor): Don't create the
1526 (save_widgets_create): Set the impl->save_widgets directly here,
1527 instead of passing the widgets back to the caller. Also, pack
1528 them into the impl's box.
1529 (update_appearance): Create or destroy the save widgets as
1530 appropriate. Set the action of the save_file_name_entry here.
1531 (shortcuts_add_current_folder): Set the active item in the
1532 save_folder_combo only if it exists.
1533 (gtk_file_chooser_default_set_property): Don't set the action of
1534 the save_file_name_entry here.
1535 (gtk_file_chooser_default_update_current_folder): Set the base
1536 folder of the save_file_name_entry only if the entry exists.
1537 (shortcuts_drag_data_received_cb): Cast the selection_data->data
1538 to (const char *) since that's what shortcuts_drop_uris() expects.
1539 (file_list_drag_data_received_cb): Likewise, for
1540 g_uri_list_extract_uris().
1542 2005-09-26 Tor Lillqvist <tml@novell.com>
1544 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
1545 the shaped flag here, too. (#316871)
1546 (gdk_window_shape_combine_region): Currently unimplemented, so
1547 don't do anything to the shaped flag here.
1549 2005-09-26 Matthias Clasen <mclasen@redhat.com>
1551 Fix #316871, reported by Dan Winship:
1553 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
1555 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
1556 (gdk_window_shape_combine_region): Set it here.
1558 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
1559 remove the child area for shaped windows.
1561 2005-09-23 Matthias Clasen <mclasen@redhat.com>
1563 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
1564 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
1566 2005-09-22 Michael Natterer <mitch@imendio.com>
1568 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
1569 consistent with GTK+ terminology:
1571 * gtk/gtkcellrendererkeys.[ch]
1572 * tests/testkeys.c: removed...
1574 * gtk/gtkcellrendereraccel.[ch]
1575 * tests/testaccel.c: ...and added.
1580 * tests/Makefile.am: changed accordingly.
1582 2005-09-22 Matthias Clasen <mclasen@redhat.com>
1584 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
1585 for the grab-broken-event signal, noticed by Damon Chaplin.
1587 2005-09-21 Tor Lillqvist <tml@novell.com>
1589 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
1590 gdk_text_property_to_text_list_for_display,
1591 gdk_text_property_to_utf8_list_for_display,
1592 gdk_win32_selection_add_targets,
1593 _gdk_win32_selection_convert_to_dib): Free return value from
1595 (gdk_text_property_to_text_list_for_display): Drop GError variable
1596 that isn't actually used after being set.
1598 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
1600 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
1603 2005-09-20 Tor Lillqvist <tml@novell.com>
1605 * gdk/win32/gdkselection-win32.c
1606 (gdk_selection_owner_get_for_display): Do return the correct owner
1607 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
1608 a window GDK knows about). The reason to return NULL seems to have
1609 gone when in the fix for bug #163702 the artificial
1610 GDK_SELECTION_CLEAR event generation was removed from
1611 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1613 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1615 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1616 events. (#151555, Søren Sandmann)
1618 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1619 XkbSelectEventDetails() to select XkbStateNotify events
1620 for only the state we care about.
1622 * gdk/x11/gdkprivate-x11.h:
1623 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1624 the event into the function and update the keymap state from
1625 the state information contained in the event. Adjust all callers.
1627 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1629 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1630 in multiple places to avoid segfaults if the index is out of range.
1631 (#316422, Guillaume Cottenceau)
1632 (gtk_icon_view_set_drag_dest_item):
1633 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1634 #316424, Guillaume Cottenceau)
1636 2005-09-18 Hans Breuer <hans@breuer.org>
1638 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1639 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1641 2005-09-18 Hans Breuer <hans@breuer.org>
1643 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1644 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1645 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1646 the icon and is blinking with teststatusicon. More to come ...
1648 2005-09-18 Hans Breuer <hans@breuer.org>
1650 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1651 cause gtkprogressbar.c has #include <config.h> conditionally; less
1652 noise from generated gtk.def
1653 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1655 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1656 For me it works as well as the *NIX implemenation, that is not at all.
1658 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1660 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1661 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1662 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1663 again - if compiled properly.
1665 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1666 already coming with Gtk+. Makes it compile on win32.
1668 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1670 * README.cvs-commits: fixed some tiny typos
1672 2005-09-16 Tor Lillqvist <tml@novell.com>
1674 * modules/engines/ms-windows/msw_style.c (draw_extension,
1675 draw_box_gap): Check whether the widget actually is a GtkNotebook
1676 before treating it as such. Drop some unneeded local variables,
1677 use parameter with same information instead. (#316412)
1679 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1681 * tests/autotestfilechooser.c: Start a set of automated tests for
1682 the file chooser. The only test in there right now doesn't pass
1683 yet. It specifies the intended behavior of the first optimization
1684 of a series which I'll do on the file chooser (see
1685 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1686 details of this optimization).
1688 * tests/Makefile.am: Added autotestfilechooser.c.
1690 * gtk/gtkfilechooserprivate.h (struct
1691 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1692 structures to here, so that they can be accessed by
1693 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1694 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1696 * gtk/gtkfilechooserdialog.c: See above.
1698 * gtk/gtkfilechooserwidget.c: See above.
1700 * gtk/gtkfilechooserdefault.c: See above.
1702 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1705 gtk_window_map_event(): new function to work around lost unmap requests.
1708 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1710 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1711 an easy-to-find profiling marker when starting to create a file
1713 (browse_files_model_finished_loading_cb): Likewise, for when the
1714 chooser is finished loading.
1716 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1718 * gtk/gtkcolorbutton.c: Check "color" argument in
1719 gtk_color_button_set_color ()
1721 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1723 * gtk/gtklabel.c (gtk_label_get_type):
1724 * gtk/gtkbutton.c (gtk_button_get_type):
1725 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1726 using a mem chunk for window groups, buttons, labels.
1728 * gtk/updateiconcache.c (foreach_remove_func): Fix
1729 a use-after-free bug. (#316256, Alexander Nedotsukov)
1731 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1733 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1735 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1737 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1739 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1740 Let GDK_Return pass through in some more cases.
1742 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1743 activating the entry.
1745 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1746 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1747 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1749 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1750 (#316001, Guillaume Cottenceau)
1752 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1753 mistake in the docs. (#315993, Guillaume Cottenceau)
1755 * tests/testentrycompletion.c (create_simple_completion_model): Add
1756 some strings containing multibyte characters.
1758 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1759 Fix prefix insertion for multibyte characters. (#316095,
1762 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1763 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1764 return NULL if the widget is not realized. (#316023,
1765 Guillaume Cottenceau)
1767 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1770 * gdk/gdkproperty.h:
1771 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1772 New function to avoid pointless strdups when creating atoms
1773 from static strings.
1776 * gtk/*.c: Use gdk_atom_intern_static_string() where
1779 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1781 * gtk/gtkcellrendererkeys.h:
1782 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1783 and editing accelerators, a port of EggCellRendererKeys .
1787 * gtk/Makefile.am: Add the keys cell renderer.
1789 * tests/Makefile.am:
1790 * tests/testkeys.c: Test GtkCellRendererKeys
1792 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1794 Make it possible to determine if a key event is for a
1797 * gdk/x11/gdkprivate-x11.h:
1798 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1799 New function to determine if a keycode is mapped to a modifier.
1800 (get_xkb): Get the modmap.
1802 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1803 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1805 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1808 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1810 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1811 unused variable, noticed by Kjartan Maraas.
1813 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1815 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1816 Make drag reordering work properly for columns other than the
1817 first. (#315054, Dan Winship)
1819 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1820 invalid fontnames better. (#136926, Michael R. Walton)
1822 Stop cursor blinking in non-editable regions of a text view.
1823 (#311508, Torbjörn Andersson)
1825 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1826 (cursor_blinks): Take editability into account when deciding
1827 whether the cursor blinks.
1828 (gtk_text_view_button_release_event):
1829 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1831 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1832 Use connect_after to connect to the focus_out event. This
1833 ensures that the entry has already stopped blinking by the time
1834 we emit the edited signal. (#315229, Thomas Leonard)
1836 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1838 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1839 unsigned ints to -1. (#315481, Kjartan Maraas)
1841 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1842 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1843 (#314473, Stanislav Brabec)
1845 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1847 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1848 memory handling. (#314975, Torsten Schoenfeld)
1850 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1851 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1852 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1853 * gtk/gtklabel.c (gtk_label_class_init):
1854 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1855 Stylistic improvements and clarifications for some blurbs.
1856 (#315520, Clytie Siddall)
1858 2005-09-09 Tor Lillqvist <tml@novell.com>
1860 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1861 display name. There is only one GdkDisplay on Win32, and
1862 constructing the display name isn't entirely trivial, so cacheing
1863 is probably worth it. For instance GIMP calls this function a lot.
1864 (gdk_display_open): Call gdk_display_get_name() to prime the
1866 (gdk_display_get_n_screens, gdk_display_get_screen,
1867 gdk_display_get_default_screen): Verify parameter correctness like
1868 the X11 backend does.
1870 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1871 Return a freshly allocated string, as the API specifies. Fixes a
1872 heap corruption problem that caused random errors and crashes in
1875 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1877 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1878 Make C-u commit and restart hex input if we are already in a
1881 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1883 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1884 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1885 if they are mapped to the same modifier.
1887 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1888 to gtkstatusicon.c and gtktrayicon-x11.c
1890 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1891 default accel mod mask.
1893 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1894 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1895 Don't use GDK_ALT_MASK.
1897 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1899 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1901 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1903 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1906 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1907 Mod2 - Mod5 and against Super, Hyper, Meta.
1909 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1910 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1911 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1913 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1914 modmap to maintain the information which X modifiers map to
1916 (get_xkb): Set up the modmap from the XKB tables.
1917 (update_keymaps): Set up the modmap from the information returned
1918 by XGetModifierMapping in the non-XKB case.
1920 * gdk/x11/gdkprivate-x11.h:
1921 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1922 function to set the virtual modifiers in the state.
1924 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1925 _gdk_keymap_add_virtual_modifiers here.
1927 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1928 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1931 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1933 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1934 if it has no child. (#315253, John Finlay)
1936 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1938 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1940 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1942 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1943 on destroy to avoid problems when they are called on a destroyed
1944 widget. (#315135, John Cupitt)
1946 * gtk/gtkentry.c (gtk_entry_class_init):
1947 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1948 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1950 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1951 code. Now we only steal a single key combination, Ctrl-Shift-U,
1953 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1954 by a sequence of hex digits entered with Ctrl-Shift still held.
1955 Releasing one of the modifiers or pressing space while the modifiers
1956 are still held commits the character. It is possible to erase
1957 digits using backspace.
1958 As an extension to the above, we also allow to start the sequence
1959 with Ctrl-Shift-U, then release the modifiers before typing any
1960 digits, and enter the digits without modifiers.
1961 (#82011, Owen Taylor)
1963 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1965 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1966 we still need to deliver the destroy event. (#314980, Chris Lahey)
1968 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1969 im context before committing \n or \t.
1971 2005-09-02 Alexander Larsson <alexl@redhat.com>
1973 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1974 (shortcuts_activate_volume):
1975 Handle base_path being null in the rest of the cases (#310270)
1977 2005-09-02 Tor Lillqvist <tml@novell.com>
1979 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1980 cursor position also in root window coordinates. Prune out
1981 superfluous WM_MOUSEMOVE events even earlier, based on root window
1982 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1983 window has ben mapped below the cursor even if the mouse doesn't
1984 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1985 confused at least gtk_menu_motion_notify(). (#314995)
1987 * gtk/gtkintl.h: No need to include config.h here. It caused
1988 warnings about GTK_LOCALEDIR being redefined on Win32 when
1989 compiling files where gtkintl.h is included after gtkprivate.h
1990 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1992 * gtk/gtkplug.c: Include config.h.
1994 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1996 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1997 xdg_mime_get_mime_type_for_file() where possible, to avoid
2000 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
2001 typo. (#314921, Guillaume Cottenceau)
2003 * gdk/*.c: Intern some more strings.
2005 * gtk/*.c: Define an I_() macro and use it instead of the
2006 bulky g_intern_static_string().
2008 2005-08-31 Matthias Clasen <mclasen@redhat.com>
2010 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
2011 instead of copying it.
2013 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
2015 * gtk/*.c: Also intern static strings passed to
2016 g_object_set_data().
2019 * gtk/Makefile.am: Intern type names in code generated by
2024 * gdk/*.c: Intern type names before registering the type to avoid
2027 * configure.in: Require GLib 2.9.0
2029 2005-08-31 Matthias Clasen <mclasen@redhat.com>
2031 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
2032 and add icon-size and icon-size-set properties. (#314172)
2034 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
2035 groups across transient parents. (#312918, Christian Persch)
2037 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
2038 Guillaume Cottenceau)
2040 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
2041 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
2043 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2045 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
2046 make C-/ select all and C-\ unselect all. (#309301,
2049 * gtk/gtkimcontextsimple.c: Change the compose sequence for
2050 soft hyphen to be multi_key-minus-minus-space, and add
2051 compose sequences multi_key-minus-minus-period and
2052 multi_key-minus-minus-minus for en dash and em dash.
2053 (#172653, Christian Lohmaier)
2055 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
2056 code. (#313946, Christian Persch)
2058 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
2059 fix for the default value of the "ui" property.
2061 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2064 * gtk/gtkselection.h:
2065 * gtk/gtkselection.c: Add functions which look for text, image
2066 or uri targets in an array of atoms. (#314089, Mark Wielaard)
2069 * gtk/gtkselection.h:
2070 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
2071 Add a function to check wether targets include uri.
2072 (#314092, Mark Wielaard)
2076 * gtk/gtkwindow.c: Add a deletable property with getter
2077 and setter, to control the close button in the window
2078 frame. (#59718, Havoc Pennington)
2080 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2082 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
2083 to the arrow keys for menu navigation. (#162825, Carl Worth)
2085 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
2087 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
2089 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
2090 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
2091 refer to nonexisting stock ids.
2093 * gtk/gtktextview.c (popup_targets_received):
2094 * gtk/gtkentry.c (popup_targets_received): Construct
2095 the "Select All" menuitem from stock.
2097 * gtk/stock-icons/stock_select_all_{16,24}.png:
2098 * gtk/stock-icons/Makefile.am:
2099 * gtk/gtkiconfactory.c:
2101 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
2104 * gtk/gtktrayicon.c: Add a pointer to the spec.
2106 * gtk/gtkstatusicon-x11.c: Add docs.
2108 * gtk/gtkstatusicon.h: Fix a typo.
2110 Add a cross-platform "tray icon" API, by
2111 porting EggStatusIcon/EggTrayIcon (#105101)
2113 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
2114 displays an icon in a notification area.
2116 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
2117 X11, using GtkTrayIcon.
2119 * gtk/gtktrayicon.h:
2120 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
2121 system tray specification, not public API.
2123 * gtk/gtk.symbols: Add new exported functions.
2125 * gtk/gtk.h: Include gtkstatusicon.h.
2127 * gtk/Makefile.am: Add new files.
2129 * tests/Makefile.am:
2130 * tests/teststatusicon.c: Test for GtkStatusIcon.
2132 2005-08-29 Christopher Aillon <caillon@redhat.com>
2134 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
2135 and GTK_STOCK_DISCONNECT
2137 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2139 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
2140 Use XFixesChangeSaveSet if available. (#314682)
2142 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
2143 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
2145 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2147 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
2148 accidentally leftover duplicate pixbuf creation. (#314700,
2151 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
2152 leak the cursor theme name. (#314693, Kjartan Maraas)
2154 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
2155 state.children in all cases. (#313862, Kjartan Maraas)
2157 2005-08-28 Matthias Clasen <mclasen@redhat.com>
2159 * po/POTFILES.in, po-properties/POTFILES.in:
2162 2005-08-27 Matthias Clasen <mclasen@redhat.com>
2164 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
2165 value of the ui property. (#314532, Yong Wang)
2167 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
2168 when G_MAXLONG is passed as length.
2170 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2172 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
2173 to avoid overloading --force. (JP Rosevaar)
2175 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2177 * configure.in: Bump version to 2.9.0
2181 * gdk/gdkscreen.c: Make the GdkScreen font options api
2182 public, and add properties GdkScreen::font-options and
2183 GdkScreen::resolution. (#314004)
2186 * gtk/gtksettings.c:
2187 * gtk/gtkwidget.c: Adjust all callers.
2189 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
2190 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
2191 * gdk/gdkscreen.c: Include gdkintl.h.
2193 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
2194 variable warning, pointed out by Colin Walters. (#314585)
2196 2005-08-26 Tor Lillqvist <tml@novell.com>
2198 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
2200 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
2202 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2204 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
2205 of week_start. (#314473, JP Rosevaar)
2207 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
2209 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
2210 lock. (#314533, Thomas Fitzsimmons)
2212 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2214 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
2215 NULL gracefully. (#314523, Ed Catmur)
2217 2005-08-25 Owen Taylor <otaylor@redhat.com>
2219 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
2220 Handle theme == NULL.
2222 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2224 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
2225 y offset into account when positioning the popup. (#314470,
2228 2005-08-25 Owen Taylor <otaylor@redhat.com>
2230 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
2231 as instance_init, not base_init! (#314452, Fix from Frederic
2232 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
2233 rather than 1 for a negative flag value.
2235 2005-08-24 Owen Taylor <otaylor@redhat.com>
2237 * gdk/gdkpango.c (draw_error_underline): Add a note about
2238 cut-and-paste between here and Pango.
2240 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2242 * === Released 2.8.2 ===
2244 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
2245 callback for image/gif, and also try image/bmp. (#314086, Mark
2248 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
2249 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
2254 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
2255 and cursor settings get propagated down to the screen initially.
2256 Pointed out by Frederic Crozat.
2258 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
2259 message if the screen is NULL. Noticed by Kjartan Maraas.
2261 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2265 * === Released 2.8.1 ===
2269 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2271 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
2272 against lazy filterers which return values other than TRUE or
2273 FALSE from their visible func. (#314335)
2275 2005-08-23 Owen Taylor <otaylor@redhat.com>
2277 Fix for #314004, reported by Michael Reinsch:
2280 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
2281 Add gdk_screen_get/set_resolution_libgtk_only()
2283 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
2284 the options for the screen on the newly created context.
2286 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
2287 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
2288 the font options on the screen.
2290 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
2291 the font options from the screen and set them on the context.
2293 2005-08-23 Kristian Rietveld <kris@gtk.org>
2295 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
2296 bother inserting new rows in a level with a zero refcount and
2297 immediately free the level. (Fixes #312350, reported by Markku Vire).
2299 2005-08-23 Matthias Clasen <mclasen@redhat.com>
2301 * gtk/updateiconcache.c: Complain when there is no index.theme file
2302 in the specified directory, unless --force is used. Also add an
2303 --index-only option to create caches without image data.
2305 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
2306 C99ism. (#314262, Robert Jeff Mitchell)
2308 2005-08-22 Manish Singh <yosh@gimp.org>
2310 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
2312 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
2314 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2316 * gtk/gtkwindow.c (gtk_window_client_event):
2317 * gtk/gtkicontheme.c (ensure_valid_themes)
2318 (_gtk_icon_theme_check_reload): Implement a clientmessage based
2319 scheme for makeing sure that all GTK+ applications notice if an
2320 icon theme has been updated. This should prevent multiple versions
2321 of an icon theme cache to be mapped in memory at the same time,
2322 which can cause excessive memory consumption. (#313156, Chris
2325 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2327 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
2328 regarding icon theme changes.
2330 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
2331 pixbufs which are backed by the mmapped memory of an icon cache,
2332 increase the refcount of the icon cache, so that the memory is not
2333 munmapped away underneath the pixbuf upon icon theme changes.
2334 (#314170, Kjartan Maraas)
2336 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
2337 to link against Xext. (#314062)
2339 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
2340 overruns. (#314081, Hans Breuer)
2342 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2344 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
2345 returned layout must not be modified.
2347 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
2349 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
2350 scroll_to_path if the model changes.
2352 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
2353 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
2354 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
2355 we're realized, #312798
2356 (gtk_icon_view_set_model): clear scroll_to_path if the model
2359 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2361 * gtk/gtkrange.c (gtk_range_adjustment_changed)
2362 (gtk_range_adjustment_value_changed): Don't queue a draw
2363 if the layout has not changed. (#313991, Benjamin Berg)
2365 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2367 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
2370 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
2373 * gtk/gtkfilechooserbutton.c (change_icon_theme)
2374 (model_add_special, model_add_special, model_add_volumes):
2375 Handle pixbuf being NULL without warnings. Also, don't
2376 leak pixbuf references when the icon theme is changed.
2378 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
2379 the user data on destroyed windows, since at best
2380 it can be a stale pointer. (#313953, Robin Green)
2382 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2384 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
2385 (#313900, Sebastien Bacher)
2387 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
2388 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
2390 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
2391 (xdnd_read_actions, get_client_window_at_coords_recurse):
2392 Free data returned from XGetWindowProperty.
2394 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
2395 Free data returned from XGetWindowProperty. (313867, Kjartan
2398 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
2399 children in all cases. (#313862, Kjartan Maraas)
2401 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
2402 in the per-directory hash, even if they come from the icon cache.
2403 We tried to avoid that before, but as a result leaked icon data
2404 structs. (#313852, Kjartan Maraas)
2406 2005-08-18 Matthias Clasen <mclasen@redhat.com>
2408 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
2409 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
2411 2005-08-15 Owen Taylor <otaylor@redhat.com>
2413 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
2414 files for x11/xext. (Jonas Bonn)
2416 2005-08-15 Tor Lillqvist <tml@novell.com>
2418 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
2421 2005-08-15 Owen Taylor <otaylor@redhat.com>
2423 * configure.in: Fix have_base_pc / have_base_x_pc typo.
2425 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
2426 (#313417, James Andrewartha)
2428 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
2429 FcNameConstant(). (More of #313417)
2431 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2433 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
2434 modal dialogs, make sure to inherit the window group from
2435 the parent, since we don't inherit window groups across
2436 transient parents currently. (#312918, Christian Persch)
2438 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
2439 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
2441 * gtk/gtkiconview.c (gtk_icon_view_select_path)
2442 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
2443 gracefully. (#312796, Jonathan Blandford)
2445 * tests/testtoolbar.c: Add some more tests for menu placement.
2447 * gtk/gtkmenutoolbutton.c (menu_position_func):
2448 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
2449 of toolbutton menus and of the overflow menu. (#312937,
2450 #153870, Christian Persch, Paolo Borelli)
2452 2005-08-15 Tor Lillqvist <tml@novell.com>
2454 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
2455 the nonportable <libgen.h> and dirname().
2457 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2459 * gtk/gtksizegroup.c: Use object data to mark widgets and
2460 groups as visited, so that we avoid constant extra list
2461 traversals. Also allocate quarks in class_init. (#311618,
2464 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
2465 download location for the hicolor icon theme. (#313475, Olexiy
2468 * gtk/gtkicontheme.c: Remove debug spew.
2470 2005-08-15 Owen Taylor <otaylor@redhat.com>
2472 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
2473 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
2474 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
2475 Handle pixmap == NULL when checking for a colormap.
2478 2005-08-14 Matthias Clasen <mclasen@redhat.com>
2480 * gtk/updateiconcache.c: Store only one copy of the pixel data
2481 for symlinked icons. To achieve this, maintain a hashtable
2482 mapping pathnames to pixel data, and share the pixel data for
2483 all symlinks resolving to the same pathname. When writing out
2484 the image data, write out the pixel data only the first time
2485 it is met, and store the offset pointing to the first copy
2486 for use in all later cases.
2487 This reduces the size of the Bluecurve icon cache from 40