1 2005-11-10 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Another
6 * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
9 Don't corrupt odd keymaps (#316638, Kean Johnston)
11 * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
12 handle frobbing keymaps with odd numbers of syms/code.
14 * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
17 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
19 * gtk/gtkpathbar.[hc]: Add a child_path argument to
20 the path_clicked signal.
21 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
22 child_path, if it is provided.
23 * gtk/marshalers.list (path_bar_clicked): Add the necessary
26 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
31 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
32 (#163851, Richard Hult)
34 2005-11-10 Michael Natterer <mitch@imendio.com>
36 Applied patch from maemo-gtk that addresses many issues wrt
37 display migration and display closing (bug #85715).
39 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
40 default display to NULL when it's closed. Instead set the most
41 recently opened display as new default (if one exists).
43 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
46 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
47 exist before unrefing them.
49 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
50 is closed, allow destruction of the root window.
52 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
53 dispose(), free stuff that was leaked before.
55 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
56 the xsettings_client still exists before destroying it.
58 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
61 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
62 dispose() implementation.
64 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
65 dispose() and check if it still exists before unrefing it. Set
66 their pointers to NULL/None *after* upchaining in dispose(),
67 because X11 implementations of members of the parent class still
68 need them for their own destruction.
70 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
71 was g_error()ing when finalizing a visual.
73 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
74 get_clipboard_widget() because it would create the widget if it
75 doesn't exist. Use g_object_get_data() directly instead.
77 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
80 2005-11-10 Simos Xenitellis <simos@gnome.org>
82 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
84 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
86 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
87 to render its arrows insensitive when the adjustment is in
88 its min or max position. this makes range arrow behaviour
89 consistent with spin button behaviour. (#321056)
91 2005-11-09 Tor Lillqvist <tml@novell.com>
94 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
95 the GdkDebugFlag enum.
97 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
98 this file instead of MISC. Now asking for MISC will give mainly
99 window manipulation debugging output with the Win32 backend.
101 2005-11-09 Tor Lillqvist <tml@novell.com>
103 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
105 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
106 function which was used only in one place.
108 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
110 (gdk_window_set_geometry_hints): If we have identical minimum and
111 maximum size hints, remove the resize and maximize
112 decorations/functions. (#104514)
114 If we have a maximum size hint, remove the maximize
115 decoration/function but ensure the resize decoration/function is
116 available. Otherwise ensure both resize and maximize
117 decorations/functions are there.
119 (set_or_clear_style_bits): Factored out common code from
120 gdk_window_set_decorations() and gdk_window_set_functions().
122 Hack the window style setting once more: Only touch the window
123 style bits corresponding to the GdkWMDecoration or GdkWMFunction
124 parameter bitmasks. Hopefully this finally is the correct thing to
125 do. We used to clear all other bits than those that were being
126 set, or set all other bits than those that were being cleared.
128 Take into account that adding or removing decorations leaves the
129 window's outer size unchanged, i.e., the client area's size and
130 position change. This is apparently not what we want, so change
131 also the window's (outer) position and size appropriately so that
132 the client area's position and size stay constant.
134 gtk-demo's color selector dialog is now non-resizable like on X11
135 (I tested with metacity in GNOME). Torn off menus are shrinkable
136 vertically but have a maximum size, and are not maximizable or
137 minimizable, like on X11.
139 (gdk_window_set_decorations, gdk_window_set_functions): Let
140 set_or_clear_decorations() do most of the job.
142 * gdk/win32/gdkprivate-win32.h: Remove declaration of
143 _gdk_win32_get_adjusted_client_rect().
145 2005-11-09 Tor Lillqvist <tml@novell.com>
147 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
148 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
149 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
150 type hint. Implement gdk_window_get_type_hint() by just returning
153 2005-11-09 Tor Lillqvist <tml@novell.com>
155 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
156 Remove code that has been permanently ifdeffed out for two years.
158 2005-11-08 Matthias Clasen <mclasen@redhat.com>
160 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
161 finalizing a gc. (#320789, Nickolay V. Shmyrev)
163 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
164 icons if they would make the request large enough to cause
165 Xlib to loose the connection. (#320909, Claudio Saavedra)
167 2005-11-08 Michael Natterer <mitch@imendio.com>
171 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
172 extracted from maemo-gtk). Fixes bug #320872.
174 2005-11-07 Matthias Clasen <mclasen@redhat.com>
176 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
177 looks the bookmark label when reordering. (#320720, Jeremy Cook)
179 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
180 Don't grab focus when a slider button is pressed, instead, use
181 a bit in the pathbar struct to determine whether to scroll up
182 or down. (#314486, Carlos Garnacho)
184 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
185 Don't popup the completions if the focus has already been
186 moved somewhere else. (#319914, Christian Persch)
188 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
189 Raise the drag_window after reconfiguring the
190 toolbar. (#320803, Christian Persch)
193 * gtk/gtkfilechooserbutton.h:
194 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
195 with setter and getter. (#318945, Christian Persch)
197 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
199 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
201 2005-11-07 Matthias Clasen <mclasen@redhat.com>
203 * configure.in: Adjust to the stock icon changes.
205 2005-11-07 Tor Lillqvist <tml@novell.com>
207 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
208 Correct the calculation of maskstride. (#320152, Peter Zelezny)
210 2005-11-06 Michael Natterer <mitch@imendio.com>
212 * gtk/Makefile.am (icons): fixed rule to actually create the
213 symlinks, erroring out if anything goes wrong.
215 2005-11-06 Tor Lillqvist <tml@novell.com>
217 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
218 target exists on Win32. First rename the target temporarily, then
219 if the renaming of the source to target fails, restore the
220 original name for the target.
222 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
224 2005-11-06 Tor Lillqvist <tml@novell.com>
226 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
227 like pixbuf_to_hbitmaps_normal().
228 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
229 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
230 setting the G_WIN32_PRETEND_WIN9X environment variable.
232 2005-11-06 Tor Lillqvist <tml@novell.com>
234 Make icon masks work on Win98 (#320152, Peter Zelezny)
236 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
237 parameter for the depth of the bitmap, so that this function can
238 be used to create 1-bit bitmaps, too.
239 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
240 and initialize it properly.
242 2005-11-04 Matthias Clasen <mclasen@redhat.com>
244 Store builtin stock icons in an icon cache, instead of
245 populating a hash table with pixbufs at startup, to save both
246 memory and startup time.
248 * gtk/stock-icons/*: Reorganize the icons in a directory structure
249 suitable for gtk-update-icon-cache, and rename them to match the
252 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
253 add _gtk_icon_cache_has_icon_in_directory().
255 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
256 to store the contents of the icon cache in a C header.
258 * gtk/gtkbuiltincache.h: Generated private header which contains
259 the icon cache for the builtin icons.
261 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
262 icons, and use that in addition to the hash table whenever
263 builtin icons are searched.
265 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
266 use it for static stock ids.
267 (get_default_icons): Don't add the builtin
268 icons to the icon theme, just register the stock ids.
269 (render_fallback_image): Take the fallback image out of the
272 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
273 the necessary machinery to rebuild gtkbuiltincache.h.
275 2005-11-04 Michael Natterer <mitch@imendio.com>
277 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
278 from maemo-gtk that changes the mtime check for rc files from
279 '>' to '!=', otherwise theme changes go unnoticed when turning
280 back the clock (Tommi Komulainen).
282 2005-11-04 Tor Lillqvist <tml@novell.com>
284 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
287 2005-11-03 Tor Lillqvist <tml@novell.com>
289 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
290 the Win32 backend, check that GdkDisplay* parameters are equal to
291 _gdk_display instead of using the unnecessarily general
294 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
295 color bitmap to have "color" in their name, for similarity with
296 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
297 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
298 the mask bitmap's contents, ones for those pixels in the color
299 bitmap where the alpha is zero, zero for other pixels. We used to
300 use an uninitialized mask bitmap! This meant that icons and
301 cursors created presumably worked more or less by accident.
302 Totally blank icons with zero alpha everywhere (as used by
303 gtktrayicon.c) definitely did not work as expected.
305 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
307 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
308 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
309 necessary and can be removed from CVS. It has never been mentioned
310 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
311 are used on Win32. One label widget is used (but never shown) as
312 gtk_widget_render_icon() needs a widget.
314 Ifdefs used as necessary in several places. It might be cleaner to
315 split out the backend-specific parts to separate files, or at
316 least collect them into separate blocks in the file.
318 (wndproc): New function. Window procedure to monitor mouse events
319 in the system tray icon. Call gtk_status_icon_button_press() as
321 (create_tray_observer): New function. Creates a hidden window that
322 only serves as a tray icon message observer.
324 * tests/teststatusicon.c (icon_activated): Position the dialog
325 with GTK_WIN_POS_CENTER.
326 (do_quit): New function, hide and unref the GtkStatusIcon, and
327 call gtk_main_quit().
328 (popup_menu): Add a Quit menu item that calls do_quit().
330 2005-11-02 Tor Lillqvist <tml@novell.com>
332 * gdk/win32/gdkcolor-win32.c
333 * gdk/win32/gdkscreen-win32.c
334 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
335 fixes. Remove superfluous test for GdkWindow* parameters being
336 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
337 GdkScreen and one GdkDisplay in the Win32 backend, use those
338 variables instead of the getter functions. For GdkDisplay* and
339 GdkScreen* parameters, check that they are equal to the
340 corresponding singleton variables instead of the more general
341 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
343 2005-11-02 Matthias Clasen <mclasen@redhat.com>
345 * gtk/gtktextview.c: Remove some g_return_if_fail() from
346 static functions, replace some others by g_assert().
348 * gtk/gtktextview.c (selection_motion_event_handler)
349 (gtk_text_view_start_selection_drag): Keep track of the original
350 selection boundaries during a drag selection, in order to correctly
351 decide when to extend or shrink the selection. (#320167,
352 reported by Arvind S N, patch by Paolo Borelli)
354 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
355 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
356 manual offset calculations by g_utf8_offset_to_pointer().
357 (#320360, Paolo Borelli)
359 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
361 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
362 nodes via the g_slice_*() API.
363 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
365 2005-11-01 Tor Lillqvist <tml@novell.com>
367 * gdk/win32/gdkprivate-win32.h
368 * gdk/win32/gdkglobals-win32.c
369 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
370 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
371 their declarations, definitions and assignments into a more
372 logical and consistent order.
374 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
375 CF_ prefix for the predefined clipboard format names. Put quotes
376 around registered format names to distinguish them.
378 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
379 immediately with a warning if the property type is STRING, TEXT,
380 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
381 should never pretend to handle on Win32. Handle only UTF8_STRING
382 here, other formats with delayed rendering. Use \uc1 instead of
383 \uc0 when generating Rich Text Format for easier testability on
384 XP, where WordPad misinterprets \uc0 encoded characters. Add more
385 GDK_NOTE debugging output for Clipboard operations.
387 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
388 (gdk_selection_convert): Don't pretent to handle STRING, just
389 UTF8_STRING. Streamline error handling, don't unnecessarily have a
390 GError which then isn't used for anything anyway if it gets set.
391 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
392 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
394 * config.h.win32.in: Sync with what configure produces.
396 * configure.in: Don't look for X_PACKAGES unless building for
397 x11. (#313986, John Ehresman)
399 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
401 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
402 Wondered why there was no ku there before??
404 2005-10-28 Matthias Clasen <mclasen@redhat.com>
406 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
407 window to the toplevels window group. (#319912, Christian Persch)
409 2005-10-28 Kristian Rietveld <kris@gtk.org>
411 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
414 2005-10-28 Matthias Clasen <mclasen@redhat.com>
416 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
417 drag cursors. (#319200, Federico Mena Quintero)
419 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
420 Shift-G to go to the previous match, like firefox. (#320061, Christian
423 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
424 C99ism. (#320000, Kazuki Iwamoto)
426 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
427 stars. (#319985, Bastien Nocera)
429 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
430 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
432 2005-10-26 Michael Natterer <mitch@imendio.com>
436 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
437 make sure that setting any of pixbuf/stock-id/icon-name resets the
438 others because they are mutually exclusive, and that unsetting any
439 of them only resets the pixbuf and nothing else. Also added
440 some missing g_object_notify().
442 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
443 g_value_set_object().
445 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
446 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
447 g_object_notify ("pixbuf").
449 2005-10-27 Matthias Clasen <mclasen@redhat.com>
451 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
452 careful about initializing cell_area. (#319382, Tommi
455 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
456 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
458 * demos/gtk-demo/clipboard.c (paste_received): Only set the
459 text if it is not NULL. (#319930, Thomas Klausner)
461 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
462 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
464 2005-10-26 Matthias Clasen <mclasen@redhat.com>
466 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
467 * gtk/gtkthemes.c (gtk_theme_engine_load):
468 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
469 when dlopening modules. (#319557, Laszlo Peter)
471 2005-10-26 Matthias Clasen <mclasen@redhat.com>
473 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
474 segments when determining text direction. (#319065, Tommi Komulainen)
476 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
477 on duplicate destroy. (#318953, Gustavo Carneiro)
479 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
480 Point out that destroy-with-parent is a bad idea for the dialog
481 passed to this function. (#318943, Christian Persch)
483 * */Makefile.am: use $(GLIB_MKENUMS) instead of
484 glib-mkenums. (#318582, Damien Carbery)
486 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
487 docs. (#317682, Christian Neumair)
489 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
490 seem to affect the placement of the data in the readonly
491 section, and causes problems with some compilers. (#317844)
493 2005-10-25 Matthias Clasen <mclasen@redhat.com>
495 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
496 Fix some issues with background drawing in RTL. (#318781,
500 * tests/testentrycompletion.c: Apply a patch by Christian
501 Persch to add property editors.
503 * gtk/gtkstatusicon.c: Emit activate on single-click,
504 not on double-click, change proposed by Milosz Derezynski.
506 2005-10-25 Kristian Rietveld <kris@gtk.org>
508 Fixes #311955, reported by Markku Vire; and a lot more.
510 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
511 Levels can now have invisible nodes cached, functions have been
512 rewritten/refactored to take this into account; also the logic in
513 some functions has been corrected.
515 Each referenced node now references all visible children or a single
516 invisible child, in order to be able to monitor all changes in the
517 child model required for correct operation.
519 When a virtual root is set, all nodes on the virtual root level are
522 At last, a bunch of random bug fixes and comment updates.
524 2005-10-25 Matthias Clasen <mclasen@redhat.com>
526 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
527 more docs. (#319722, Paolo Borelli)
529 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
530 initialization of screen_x11->xft_rgba more explicit. (#319627,
533 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
534 in a blurb. (#319499, Francisco Javier F. Serrador)
536 2005-10-24 Matthias Clasen <mclasen@redhat.com>
538 Add settings to hide the input method and Unicode control character
539 submenus in the context menus of GtkEntry and GtkTextView.
541 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
543 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
545 * gtk/gtktextview.c (popup_targets_received):
546 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
548 2005-10-24 Kristian Rietveld <kris@gtk.org>
550 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
551 row-has-child-toggled when the level is not in the cache does not
552 make sense. (This bug probably crept in during the early stages
553 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
555 (gtk_tree_model_sort_real_unref_node): only get the child iter
556 when we will actually also use it.
558 2005-10-22 Michael Natterer <mitch@imendio.com>
560 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
561 widget being realized, in addition to being visible, to avoid
562 running into precondition check in gtk_tree_view_get_cell_area().
565 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
567 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
568 Experimentally, scrollbar steppers can shrink to 8 pixels on
569 Win32. Reflect that in the theme.
570 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
571 there is a 1-pixel border between a scrollbar and its child
572 in ScrolledWindows on Win32. Reflect that in the theme.
574 2005-10-20 Matthias Clasen <mclasen@redhat.com>
576 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
577 for the selection window. (#318806, Alex Larsson)
579 2005-10-18 Federico Mena Quintero <federico@ximian.com>
583 * tests/autotestfilechooser.c
584 (test_button_folder_states_for_action): Test that we have either
585 $cwd or the explicitly-set folder.
586 (test_reload_sequence): Likewise.
588 * gtk/gtkfilechooserdefault.c
589 (gtk_file_chooser_default_get_current_folder): If our reload_state
590 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
592 2005-10-14 Tor Lillqvist <tml@novell.com>
594 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
595 It didn't really do anything useful, and was just confusing and
596 incomplete. Comments claimed we don't do delayed rendering, but in
597 fact we do, for images. (The delayed rendering code has other
598 problems, though, see #168173.) The clipboard viewer code was
599 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
600 the message when necessary). It was just test code, it said so in
601 a comment. Add something similar back later if necessary.
603 (_win32_on_clipboard_change,
604 _gdk_win32_register_clipboard_notification): Remove.
606 (gdk_display_supports_selection_notification,
607 gdk_display_request_selection_notification): Always just return
608 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
610 2005-10-13 Tor Lillqvist <tml@novell.com>
612 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
613 Alt-Enter specially. It does not have any special meaning and
614 should be passed on to the application. (#318378, Tim Evans)
616 2005-10-13 Tor Lillqvist <tml@novell.com>
618 Set visual depth to 24 for 32 bits-per-pixel devices on
619 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
620 optimized composite_0888() function rather than the slower image
621 dithering functions to draw pixbufs (#313993, John Ehresman)
623 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
624 _gdk_windowing_get_bits_for_depth() to initialize
625 GdkImage::bits_per_pixel.
626 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
628 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
629 _gdk_windowing_get_bits_for_depth() to initialize
630 BITMAPINFOHEADER::biBitCount.
632 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
633 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
636 2005-10-12 Stefan Kost <ensonic@users.sf.net>
638 * demos/gtk-demo/appwindow.c: (about_cb):
639 use PACKAGE_VERSION,bump year (#318654)
641 2005-10-11 Matthias Clasen <mclasen@redhat.com>
643 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
644 toggle here with the matching on toggle if it immediately follows.
645 This is a common case, and handling it here prevents quadratic blowup
646 in cleanup_line() below. (#317125)
648 * gtk/gtktextsegment.h:
649 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
650 the character counts into this function instead of computing them
653 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
655 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
657 * gtk/gtkfilechooserdefault.c
658 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
659 when the shortcut already exists in the sidebar. (#147521)
661 2005-10-09 Matthias Clasen <mclasen@redhat.com>
663 * tests/testcombo.c: Demonstrate how to use custom widgets in
666 2005-10-07 Federico Mena Quintero <federico@ximian.com>
670 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
671 the the result of gtk_file_chooser_get_folder() is NULL or
672 non-NULL at the right times. Log the tests.
673 (test_button_folder_states): New test for the initial states of
674 the current folder in GtkFileChooserButton.
675 (main): Test that the number of warnings/errors/critical errors is
678 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
679 Clarify the documentation on when this can return NULL.
680 (gtk_file_chooser_get_current_folder_uri): Likewise.
682 * gtk/gtkfilechooserbutton.c (struct
683 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
684 we use it to keep track of whether a folder has been set.
685 (gtk_file_chooser_button_map): Implement. If no folder has been
686 loaded before, we at least try to load $cwd here.
687 (gtk_file_chooser_button_constructor): If the construct-time
688 dialog already has a folder set, turn on our folder_has_been_set
690 (dialog_current_folder_changed_cb): Turn on our
691 folder_has_been_set flag.
693 2005-10-07 Michael Natterer <mitch@gimp.org>
695 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
696 PROFILE_FILE_CHOOSER because they break compilation after the
697 removal of <unistd.h>.
699 2005-10-07 Matthias Clasen <mclasen@redhat.com>
701 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
702 by moving it out of the profiling ifdef.
704 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
705 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
707 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
708 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
711 2005-10-06 Matthias Clasen <mclasen@redhat.com>
714 * gtk/gtktextbuffer.h:
715 * gtk/gtktextbuffer.c: Add a readonly has-selection property
716 with a getter. (#318161, Paolo Borelli)
718 2005-10-05 Matthias Clasen <mclasen@redhat.com>
720 * README.in: Start collecting release notes for 2.10.
722 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
723 leak fix, since the assertion failures were traced to
724 an xchat bug. (#314696)
726 * gtk/gtkstyle.c (gtk_style_detach):
727 (gtk_style_attach): Documentation improvements.
728 (gtk_style_detach): Assert that the attach_count is > 0.
730 2005-10-04 Federico Mena Quintero <federico@ximian.com>
732 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
733 shortcut position, not a ShortcutsIndex, to make the function more
735 (home_folder_handler): Pass the resolved index to
736 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
737 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
738 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
739 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
740 make the respective key switch to the first, second, ..., tenth
742 (quick_bookmark_handler): Implement.
744 2005-10-04 Federico Mena Quintero <federico@ximian.com>
746 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
747 Desktop; just use their real names on the file system for the
750 * gtk/gtkfilechooserdefault.c
751 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
752 binding signal, and bind it to M-d by default.
753 (desktop_folder_handler): Implement the default handler.
754 (home_folder_handler): Use a helper function.
755 (switch_to_shortcut): New helper function.
756 (shortcuts_append_home): Don't special-case the name of "Home";
757 just use the folder name.
759 2005-10-04 Tor Lillqvist <tml@novell.com>
761 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
762 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
764 2005-10-04 Matthias Clasen <mclasen@redhat.com>
766 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
767 from yesterday, since it leads to assertion failures. (#317879,
770 2005-10-03 Matthias Clasen <mclasen@redhat.com>
772 * gtk/gtkcalendar.c (gtk_calendar_init): Call
773 calendar_compute_days() after setting priv->week_start.
775 2005-10-03 Matthias Clasen <mclasen@redhat.com>
777 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
778 removing it from the hash table. (#314696, Benjamin Berg)
780 2005-10-01 Tor Lillqvist <tml@novell.com>
782 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
783 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
784 is that the the desktop isn't visible because the session has been
785 switched, the screen is locked, or a terminal server session
786 disconnected, so no error message necessary. (#137796)
788 It is of course remotely possible that BitBlt() failing with
789 ERROR_INVALID_HANDLE might also be caused by some other
790 problem. We could strive for perfection and track whether the
791 desktop is visible by using WTSRegisterSessionNotification() and
792 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
793 this issue, though. If we would track desktop visibility, we
794 should then avoid even trying to update the display at all while
795 the desktop isn't visible.
797 2005-09-30 Matthias Clasen <mclasen@redhat.com>
799 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
800 to correct the calculations for the first week day. We may
801 just have to remove this code if too many locales turn out
804 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
805 some cases. (#317611, Tommi Komulainen)
807 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
808 Prevent overflow when storing size hints in an unsigned
809 short variable. Tracked down by Ray Strode and Søren Sandmann.
811 2005-09-29 Matthias Clasen <mclasen@redhat.com>
813 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
816 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
817 grab shadowed. (#317332)
819 2005-09-29 Tor Lillqvist <tml@novell.com>
821 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
823 2005-09-28 Federico Mena Quintero <federico@ximian.com>
825 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
826 if the unmap test fails.
827 (test_reload_sequence): Use gtk_widget_show_now() instead of
828 gtk_widget_show() for the dialog.
829 Thanks to Tim Janik for noticing these.
831 2005-09-28 Federico Mena Quintero <federico@ximian.com>
833 * tests/testcellrenderertext.c: New file with a set of tests for
834 GtkCellRendererText. The idea is to run a text renderer through
835 most of its interesting property values to see that it works
838 * tests/Makefile.am: Added testcellrenderertext.
840 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
841 entry/exit of this function for profiling.
842 (gtk_file_chooser_default_style_set): Mark the start/end of the
843 calls to the parent class and the the signal emission for profiling.
845 2005-09-29 Tor Lillqvist <tml@novell.com>
847 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
848 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
849 system codepage using g_win32_locale_filename_from_utf8().
850 (#317457, Kazuki Iwamoto)
852 2005-09-28 Matthias Clasen <mclasen@redhat.com>
854 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
855 here. (#317039, Paolo Borelli)
858 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
859 to make this function work as boxed copy function. (#317455,
862 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
863 NULL. (#316828, Tor Lillqvist)
865 2005-09-28 Tor Lillqvist <tml@novell.com>
867 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
870 2005-09-27 Federico Mena Quintero <federico@ximian.com>
872 Don't reload the current folder unnecessarily on ::map().
874 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
876 (struct _GtkFileChooserDefault): Added a "reload_state" field.
878 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
879 Initialize impl->reload_state.
880 (gtk_file_chooser_default_map): Check the impl->reload_state; load
881 a default folder if no folder has been set, or reload the current
882 one only if we had been unmapped first.
883 (gtk_file_chooser_default_update_current_folder): Set the
884 reload_state to RELOAD_HAS_FOLDER.
885 (gtk_file_chooser_default_unmap): Implement, and set the
886 reload_state to RELOAD_WAS_UNMAPPED.
887 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
888 here; they'll get (re)loaded on ::map() anyway.
890 * gtk/gtkfilechooserwidget.c
891 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
893 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
894 a dialog; build it ourselves.
895 (test_reload): New test to ensure that we don't load the default
896 folder more than once, and that we reload it when
898 (get_impl_from_dialog): New utility function.
899 (test_widgets_for_current_action): Use get_impl_from_dialog().
901 2005-09-27 Federico Mena Quintero <federico@ximian.com>
903 * gtk/gtkfilechooserdefault.c
904 (gtk_file_chooser_default_constructor): Mark the entry/exit of
905 this function for profiling.
906 (check_icon_theme): Likewise.
907 (change_icon_theme): Likewise.
908 (settings_notify_cb): Likewise.
909 (gtk_file_chooser_default_screen_changed): Likewise.
910 (update_chooser_entry): If the selection is empty, clear the file
911 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
912 nothing will be selected when the user starts typeahead in the
913 treeview, and we don't want to clear the file name entry in that
914 case --- the user could be typing-ahead to look for a folder name.
915 Fixes bug #308332, patch by Jürg Billeter.
917 2005-09-27 Matthias Clasen <mclasen@redhat.com>
919 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
920 Pop below the entry if there's more free space below the entry
921 than above. (#316948, Tommi Komulainen)
923 2005-09-26 Federico Mena Quintero <federico@ximian.com>
925 Do not create the save mode-specific widgets in the open modes, so
926 that we don't carry their baggage around.
928 * gtk/gtkfilechooserdefault.c
929 (gtk_file_chooser_default_constructor): Don't create the
931 (save_widgets_create): Set the impl->save_widgets directly here,
932 instead of passing the widgets back to the caller. Also, pack
933 them into the impl's box.
934 (update_appearance): Create or destroy the save widgets as
935 appropriate. Set the action of the save_file_name_entry here.
936 (shortcuts_add_current_folder): Set the active item in the
937 save_folder_combo only if it exists.
938 (gtk_file_chooser_default_set_property): Don't set the action of
939 the save_file_name_entry here.
940 (gtk_file_chooser_default_update_current_folder): Set the base
941 folder of the save_file_name_entry only if the entry exists.
942 (shortcuts_drag_data_received_cb): Cast the selection_data->data
943 to (const char *) since that's what shortcuts_drop_uris() expects.
944 (file_list_drag_data_received_cb): Likewise, for
945 g_uri_list_extract_uris().
947 2005-09-26 Tor Lillqvist <tml@novell.com>
949 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
950 the shaped flag here, too. (#316871)
951 (gdk_window_shape_combine_region): Currently unimplemented, so
952 don't do anything to the shaped flag here.
954 2005-09-26 Matthias Clasen <mclasen@redhat.com>
956 Fix #316871, reported by Dan Winship:
958 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
960 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
961 (gdk_window_shape_combine_region): Set it here.
963 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
964 remove the child area for shaped windows.
966 2005-09-23 Matthias Clasen <mclasen@redhat.com>
968 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
969 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
971 2005-09-22 Michael Natterer <mitch@imendio.com>
973 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
974 consistent with GTK+ terminology:
976 * gtk/gtkcellrendererkeys.[ch]
977 * tests/testkeys.c: removed...
979 * gtk/gtkcellrendereraccel.[ch]
980 * tests/testaccel.c: ...and added.
985 * tests/Makefile.am: changed accordingly.
987 2005-09-22 Matthias Clasen <mclasen@redhat.com>
989 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
990 for the grab-broken-event signal, noticed by Damon Chaplin.
992 2005-09-21 Tor Lillqvist <tml@novell.com>
994 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
995 gdk_text_property_to_text_list_for_display,
996 gdk_text_property_to_utf8_list_for_display,
997 gdk_win32_selection_add_targets,
998 _gdk_win32_selection_convert_to_dib): Free return value from
1000 (gdk_text_property_to_text_list_for_display): Drop GError variable
1001 that isn't actually used after being set.
1003 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
1005 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
1008 2005-09-20 Tor Lillqvist <tml@novell.com>
1010 * gdk/win32/gdkselection-win32.c
1011 (gdk_selection_owner_get_for_display): Do return the correct owner
1012 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
1013 a window GDK knows about). The reason to return NULL seems to have
1014 gone when in the fix for bug #163702 the artificial
1015 GDK_SELECTION_CLEAR event generation was removed from
1016 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1018 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1020 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1021 events. (#151555, Søren Sandmann)
1023 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1024 XkbSelectEventDetails() to select XkbStateNotify events
1025 for only the state we care about.
1027 * gdk/x11/gdkprivate-x11.h:
1028 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1029 the event into the function and update the keymap state from
1030 the state information contained in the event. Adjust all callers.
1032 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1034 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1035 in multiple places to avoid segfaults if the index is out of range.
1036 (#316422, Guillaume Cottenceau)
1037 (gtk_icon_view_set_drag_dest_item):
1038 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1039 #316424, Guillaume Cottenceau)
1041 2005-09-18 Hans Breuer <hans@breuer.org>
1043 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1044 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1046 2005-09-18 Hans Breuer <hans@breuer.org>
1048 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1049 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1050 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1051 the icon and is blinking with teststatusicon. More to come ...
1053 2005-09-18 Hans Breuer <hans@breuer.org>
1055 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1056 cause gtkprogressbar.c has #include <config.h> conditionally; less
1057 noise from generated gtk.def
1058 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1060 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1061 For me it works as well as the *NIX implemenation, that is not at all.
1063 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1065 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1066 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1067 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1068 again - if compiled properly.
1070 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1071 already coming with Gtk+. Makes it compile on win32.
1073 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1075 * README.cvs-commits: fixed some tiny typos
1077 2005-09-16 Tor Lillqvist <tml@novell.com>
1079 * modules/engines/ms-windows/msw_style.c (draw_extension,
1080 draw_box_gap): Check whether the widget actually is a GtkNotebook
1081 before treating it as such. Drop some unneeded local variables,
1082 use parameter with same information instead. (#316412)
1084 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1086 * tests/autotestfilechooser.c: Start a set of automated tests for
1087 the file chooser. The only test in there right now doesn't pass
1088 yet. It specifies the intended behavior of the first optimization
1089 of a series which I'll do on the file chooser (see
1090 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1091 details of this optimization).
1093 * tests/Makefile.am: Added autotestfilechooser.c.
1095 * gtk/gtkfilechooserprivate.h (struct
1096 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1097 structures to here, so that they can be accessed by
1098 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1099 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1101 * gtk/gtkfilechooserdialog.c: See above.
1103 * gtk/gtkfilechooserwidget.c: See above.
1105 * gtk/gtkfilechooserdefault.c: See above.
1107 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1110 gtk_window_map_event(): new function to work around lost unmap requests.
1113 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1115 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1116 an easy-to-find profiling marker when starting to create a file
1118 (browse_files_model_finished_loading_cb): Likewise, for when the
1119 chooser is finished loading.
1121 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1123 * gtk/gtkcolorbutton.c: Check "color" argument in
1124 gtk_color_button_set_color ()
1126 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1128 * gtk/gtklabel.c (gtk_label_get_type):
1129 * gtk/gtkbutton.c (gtk_button_get_type):
1130 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1131 using a mem chunk for window groups, buttons, labels.
1133 * gtk/updateiconcache.c (foreach_remove_func): Fix
1134 a use-after-free bug. (#316256, Alexander Nedotsukov)
1136 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1138 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1140 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1142 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1144 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1145 Let GDK_Return pass through in some more cases.
1147 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1148 activating the entry.
1150 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1151 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1152 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1154 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1155 (#316001, Guillaume Cottenceau)
1157 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1158 mistake in the docs. (#315993, Guillaume Cottenceau)
1160 * tests/testentrycompletion.c (create_simple_completion_model): Add
1161 some strings containing multibyte characters.
1163 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1164 Fix prefix insertion for multibyte characters. (#316095,
1167 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1168 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1169 return NULL if the widget is not realized. (#316023,
1170 Guillaume Cottenceau)
1172 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1175 * gdk/gdkproperty.h:
1176 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1177 New function to avoid pointless strdups when creating atoms
1178 from static strings.
1181 * gtk/*.c: Use gdk_atom_intern_static_string() where
1184 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1186 * gtk/gtkcellrendererkeys.h:
1187 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1188 and editing accelerators, a port of EggCellRendererKeys .
1192 * gtk/Makefile.am: Add the keys cell renderer.
1194 * tests/Makefile.am:
1195 * tests/testkeys.c: Test GtkCellRendererKeys
1197 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1199 Make it possible to determine if a key event is for a
1202 * gdk/x11/gdkprivate-x11.h:
1203 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1204 New function to determine if a keycode is mapped to a modifier.
1205 (get_xkb): Get the modmap.
1207 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1208 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1210 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1213 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1215 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1216 unused variable, noticed by Kjartan Maraas.
1218 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1220 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1221 Make drag reordering work properly for columns other than the
1222 first. (#315054, Dan Winship)
1224 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1225 invalid fontnames better. (#136926, Michael R. Walton)
1227 Stop cursor blinking in non-editable regions of a text view.
1228 (#311508, Torbjörn Andersson)
1230 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1231 (cursor_blinks): Take editability into account when deciding
1232 whether the cursor blinks.
1233 (gtk_text_view_button_release_event):
1234 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1236 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1237 Use connect_after to connect to the focus_out event. This
1238 ensures that the entry has already stopped blinking by the time
1239 we emit the edited signal. (#315229, Thomas Leonard)
1241 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1243 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1244 unsigned ints to -1. (#315481, Kjartan Maraas)
1246 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1247 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1248 (#314473, Stanislav Brabec)
1250 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1252 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1253 memory handling. (#314975, Torsten Schoenfeld)
1255 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1256 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1257 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1258 * gtk/gtklabel.c (gtk_label_class_init):
1259 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1260 Stylistic improvements and clarifications for some blurbs.
1261 (#315520, Clytie Siddall)
1263 2005-09-09 Tor Lillqvist <tml@novell.com>
1265 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1266 display name. There is only one GdkDisplay on Win32, and
1267 constructing the display name isn't entirely trivial, so cacheing
1268 is probably worth it. For instance GIMP calls this function a lot.
1269 (gdk_display_open): Call gdk_display_get_name() to prime the
1271 (gdk_display_get_n_screens, gdk_display_get_screen,
1272 gdk_display_get_default_screen): Verify parameter correctness like
1273 the X11 backend does.
1275 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1276 Return a freshly allocated string, as the API specifies. Fixes a
1277 heap corruption problem that caused random errors and crashes in
1280 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1282 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1283 Make C-u commit and restart hex input if we are already in a
1286 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1288 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1289 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1290 if they are mapped to the same modifier.
1292 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1293 to gtkstatusicon.c and gtktrayicon-x11.c
1295 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1296 default accel mod mask.
1298 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1299 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1300 Don't use GDK_ALT_MASK.
1302 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1304 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1306 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1308 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1311 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1312 Mod2 - Mod5 and against Super, Hyper, Meta.
1314 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1315 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1316 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1318 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1319 modmap to maintain the information which X modifiers map to
1321 (get_xkb): Set up the modmap from the XKB tables.
1322 (update_keymaps): Set up the modmap from the information returned
1323 by XGetModifierMapping in the non-XKB case.
1325 * gdk/x11/gdkprivate-x11.h:
1326 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1327 function to set the virtual modifiers in the state.
1329 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1330 _gdk_keymap_add_virtual_modifiers here.
1332 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1333 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1336 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1338 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1339 if it has no child. (#315253, John Finlay)
1341 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1343 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1345 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1347 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1348 on destroy to avoid problems when they are called on a destroyed
1349 widget. (#315135, John Cupitt)
1351 * gtk/gtkentry.c (gtk_entry_class_init):
1352 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1353 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1355 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1356 code. Now we only steal a single key combination, Ctrl-Shift-U,
1358 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1359 by a sequence of hex digits entered with Ctrl-Shift still held.
1360 Releasing one of the modifiers or pressing space while the modifiers
1361 are still held commits the character. It is possible to erase
1362 digits using backspace.
1363 As an extension to the above, we also allow to start the sequence
1364 with Ctrl-Shift-U, then release the modifiers before typing any
1365 digits, and enter the digits without modifiers.
1366 (#82011, Owen Taylor)
1368 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1370 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1371 we still need to deliver the destroy event. (#314980, Chris Lahey)
1373 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1374 im context before committing \n or \t.
1376 2005-09-02 Alexander Larsson <alexl@redhat.com>
1378 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1379 (shortcuts_activate_volume):
1380 Handle base_path being null in the rest of the cases (#310270)
1382 2005-09-02 Tor Lillqvist <tml@novell.com>
1384 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1385 cursor position also in root window coordinates. Prune out
1386 superfluous WM_MOUSEMOVE events even earlier, based on root window
1387 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1388 window has ben mapped below the cursor even if the mouse doesn't
1389 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1390 confused at least gtk_menu_motion_notify(). (#314995)
1392 * gtk/gtkintl.h: No need to include config.h here. It caused
1393 warnings about GTK_LOCALEDIR being redefined on Win32 when
1394 compiling files where gtkintl.h is included after gtkprivate.h
1395 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1397 * gtk/gtkplug.c: Include config.h.
1399 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1401 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1402 xdg_mime_get_mime_type_for_file() where possible, to avoid
1405 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1406 typo. (#314921, Guillaume Cottenceau)
1408 * gdk/*.c: Intern some more strings.
1410 * gtk/*.c: Define an I_() macro and use it instead of the
1411 bulky g_intern_static_string().
1413 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1415 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1416 instead of copying it.
1418 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1420 * gtk/*.c: Also intern static strings passed to
1421 g_object_set_data().
1424 * gtk/Makefile.am: Intern type names in code generated by
1429 * gdk/*.c: Intern type names before registering the type to avoid
1432 * configure.in: Require GLib 2.9.0
1434 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1436 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1437 and add icon-size and icon-size-set properties. (#314172)
1439 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1440 groups across transient parents. (#312918, Christian Persch)
1442 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1443 Guillaume Cottenceau)
1445 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1446 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1448 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1450 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1451 make C-/ select all and C-\ unselect all. (#309301,
1454 * gtk/gtkimcontextsimple.c: Change the compose sequence for
1455 soft hyphen to be multi_key-minus-minus-space, and add
1456 compose sequences multi_key-minus-minus-period and
1457 multi_key-minus-minus-minus for en dash and em dash.
1458 (#172653, Christian Lohmaier)
1460 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
1461 code. (#313946, Christian Persch)
1463 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
1464 fix for the default value of the "ui" property.
1466 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1469 * gtk/gtkselection.h:
1470 * gtk/gtkselection.c: Add functions which look for text, image
1471 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1474 * gtk/gtkselection.h:
1475 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1476 Add a function to check wether targets include uri.
1477 (#314092, Mark Wielaard)
1481 * gtk/gtkwindow.c: Add a deletable property with getter
1482 and setter, to control the close button in the window
1483 frame. (#59718, Havoc Pennington)
1485 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1487 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1488 to the arrow keys for menu navigation. (#162825, Carl Worth)
1490 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1492 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1494 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1495 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1496 refer to nonexisting stock ids.
1498 * gtk/gtktextview.c (popup_targets_received):
1499 * gtk/gtkentry.c (popup_targets_received): Construct
1500 the "Select All" menuitem from stock.
1502 * gtk/stock-icons/stock_select_all_{16,24}.png:
1503 * gtk/stock-icons/Makefile.am:
1504 * gtk/gtkiconfactory.c:
1506 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1509 * gtk/gtktrayicon.c: Add a pointer to the spec.
1511 * gtk/gtkstatusicon-x11.c: Add docs.
1513 * gtk/gtkstatusicon.h: Fix a typo.
1515 Add a cross-platform "tray icon" API, by
1516 porting EggStatusIcon/EggTrayIcon (#105101)
1518 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1519 displays an icon in a notification area.
1521 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1522 X11, using GtkTrayIcon.
1524 * gtk/gtktrayicon.h:
1525 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1526 system tray specification, not public API.
1528 * gtk/gtk.symbols: Add new exported functions.
1530 * gtk/gtk.h: Include gtkstatusicon.h.
1532 * gtk/Makefile.am: Add new files.
1534 * tests/Makefile.am:
1535 * tests/teststatusicon.c: Test for GtkStatusIcon.
1537 2005-08-29 Christopher Aillon <caillon@redhat.com>
1539 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1540 and GTK_STOCK_DISCONNECT
1542 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1544 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1545 Use XFixesChangeSaveSet if available. (#314682)
1547 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1548 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1550 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1552 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1553 accidentally leftover duplicate pixbuf creation. (#314700,
1556 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1557 leak the cursor theme name. (#314693, Kjartan Maraas)
1559 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1560 state.children in all cases. (#313862, Kjartan Maraas)
1562 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1564 * po/POTFILES.in, po-properties/POTFILES.in:
1567 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1569 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1570 value of the ui property. (#314532, Yong Wang)
1572 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1573 when G_MAXLONG is passed as length.
1575 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1577 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1578 to avoid overloading --force. (JP Rosevaar)
1580 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1582 * configure.in: Bump version to 2.9.0
1586 * gdk/gdkscreen.c: Make the GdkScreen font options api
1587 public, and add properties GdkScreen::font-options and
1588 GdkScreen::resolution. (#314004)
1591 * gtk/gtksettings.c:
1592 * gtk/gtkwidget.c: Adjust all callers.
1594 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1595 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1596 * gdk/gdkscreen.c: Include gdkintl.h.
1598 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1599 variable warning, pointed out by Colin Walters. (#314585)
1601 2005-08-26 Tor Lillqvist <tml@novell.com>
1603 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1605 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1607 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1609 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1610 of week_start. (#314473, JP Rosevaar)
1612 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1614 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1615 lock. (#314533, Thomas Fitzsimmons)
1617 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1619 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1620 NULL gracefully. (#314523, Ed Catmur)
1622 2005-08-25 Owen Taylor <otaylor@redhat.com>
1624 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1625 Handle theme == NULL.
1627 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1629 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1630 y offset into account when positioning the popup. (#314470,
1633 2005-08-25 Owen Taylor <otaylor@redhat.com>
1635 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1636 as instance_init, not base_init! (#314452, Fix from Frederic
1637 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1638 rather than 1 for a negative flag value.
1640 2005-08-24 Owen Taylor <otaylor@redhat.com>
1642 * gdk/gdkpango.c (draw_error_underline): Add a note about
1643 cut-and-paste between here and Pango.
1645 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1647 * === Released 2.8.2 ===
1649 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1650 callback for image/gif, and also try image/bmp. (#314086, Mark
1653 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1654 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1659 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1660 and cursor settings get propagated down to the screen initially.
1661 Pointed out by Frederic Crozat.
1663 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1664 message if the screen is NULL. Noticed by Kjartan Maraas.
1666 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1670 * === Released 2.8.1 ===
1674 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1676 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1677 against lazy filterers which return values other than TRUE or
1678 FALSE from their visible func. (#314335)
1680 2005-08-23 Owen Taylor <otaylor@redhat.com>
1682 Fix for #314004, reported by Michael Reinsch:
1685 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1686 Add gdk_screen_get/set_resolution_libgtk_only()
1688 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1689 the options for the screen on the newly created context.
1691 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1692 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1693 the font options on the screen.
1695 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1696 the font options from the screen and set them on the context.
1698 2005-08-23 Kristian Rietveld <kris@gtk.org>
1700 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1701 bother inserting new rows in a level with a zero refcount and
1702 immediately free the level. (Fixes #312350, reported by Markku Vire).
1704 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1706 * gtk/updateiconcache.c: Complain when there is no index.theme file
1707 in the specified directory, unless --force is used. Also add an
1708 --index-only option to create caches without image data.
1710 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1711 C99ism. (#314262, Robert Jeff Mitchell)
1713 2005-08-22 Manish Singh <yosh@gimp.org>
1715 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1717 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1719 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1721 * gtk/gtkwindow.c (gtk_window_client_event):
1722 * gtk/gtkicontheme.c (ensure_valid_themes)
1723 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1724 scheme for makeing sure that all GTK+ applications notice if an
1725 icon theme has been updated. This should prevent multiple versions
1726 of an icon theme cache to be mapped in memory at the same time,
1727 which can cause excessive memory consumption. (#313156, Chris
1730 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1732 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1733 regarding icon theme changes.
1735 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1736 pixbufs which are backed by the mmapped memory of an icon cache,
1737 increase the refcount of the icon cache, so that the memory is not
1738 munmapped away underneath the pixbuf upon icon theme changes.
1739 (#314170, Kjartan Maraas)
1741 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1742 to link against Xext. (#314062)
1744 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1745 overruns. (#314081, Hans Breuer)
1747 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1749 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1750 returned layout must not be modified.
1752 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1754 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1755 scroll_to_path if the model changes.
1757 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1758 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1759 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1760 we're realized, #312798
1761 (gtk_icon_view_set_model): clear scroll_to_path if the model
1764 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1766 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1767 (gtk_range_adjustment_value_changed): Don't queue a draw
1768 if the layout has not changed. (#313991, Benjamin Berg)
1770 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1772 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1775 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1778 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1779 (model_add_special, model_add_special, model_add_volumes):
1780 Handle pixbuf being NULL without warnings. Also, don't
1781 leak pixbuf references when the icon theme is changed.
1783 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1784 the user data on destroyed windows, since at best
1785 it can be a stale pointer. (#313953, Robin Green)
1787 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1789 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1790 (#313900, Sebastien Bacher)
1792 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1793 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1795 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1796 (xdnd_read_actions, get_client_window_at_coords_recurse):
1797 Free data returned from XGetWindowProperty.
1799 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1800 Free data returned from XGetWindowProperty. (313867, Kjartan
1803 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1804 children in all cases. (#313862, Kjartan Maraas)
1806 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1807 in the per-directory hash, even if they come from the icon cache.
1808 We tried to avoid that before, but as a result leaked icon data
1809 structs. (#313852, Kjartan Maraas)
1811 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1813 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1814 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1816 2005-08-15 Owen Taylor <otaylor@redhat.com>
1818 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1819 files for x11/xext. (Jonas Bonn)
1821 2005-08-15 Tor Lillqvist <tml@novell.com>
1823 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1826 2005-08-15 Owen Taylor <otaylor@redhat.com>
1828 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1830 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1831 (#313417, James Andrewartha)
1833 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1834 FcNameConstant(). (More of #313417)
1836 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1838 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1839 modal dialogs, make sure to inherit the window group from
1840 the parent, since we don't inherit window groups across
1841 transient parents currently. (#312918, Christian Persch)
1843 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1844 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1846 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1847 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1848 gracefully. (#312796, Jonathan Blandford)
1850 * tests/testtoolbar.c: Add some more tests for menu placement.
1852 * gtk/gtkmenutoolbutton.c (menu_position_func):
1853 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1854 of toolbutton menus and of the overflow menu. (#312937,
1855 #153870, Christian Persch, Paolo Borelli)
1857 2005-08-15 Tor Lillqvist <tml@novell.com>
1859 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1860 the nonportable <libgen.h> and dirname().
1862 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1864 * gtk/gtksizegroup.c: Use object data to mark widgets and
1865 groups as visited, so that we avoid constant extra list
1866 traversals. Also allocate quarks in class_init. (#311618,
1869 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1870 download location for the hicolor icon theme. (#313475, Olexiy
1873 * gtk/gtkicontheme.c: Remove debug spew.
1875 2005-08-15 Owen Taylor <otaylor@redhat.com>
1877 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1878 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1879 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1880 Handle pixmap == NULL when checking for a colormap.
1883 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1885 * gtk/updateiconcache.c: Store only one copy of the pixel data
1886 for symlinked icons. To achieve this, maintain a hashtable
1887 mapping pathnames to pixel data, and share the pixel data for
1888 all symlinks resolving to the same pathname. When writing out
1889 the image data, write out the pixel data only the first time
1890 it is met, and store the offset pointing to the first copy
1891 for use in all later cases.
1892 This reduces the size of the Bluecurve icon cache from 40