1 2005-11-10 Matthias Clasen <mclasen@redhat.com>
3 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
5 * gtk/gtkpathbar.[hc]: Add a child_path argument to
6 the path_clicked signal.
7 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
8 child_path, if it is provided.
9 * gtk/marshalers.list (path_bar_clicked): Add the necessary
12 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
17 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
18 (#163851, Richard Hult)
20 2005-11-10 Michael Natterer <mitch@imendio.com>
22 Applied patch from maemo-gtk that addresses many issues wrt
23 display migration and display closing (bug #85715).
25 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
26 default display to NULL when it's closed. Instead set the most
27 recently opened display as new default (if one exists).
29 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
32 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
33 exist before unrefing them.
35 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
36 is closed, allow destruction of the root window.
38 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
39 dispose(), free stuff that was leaked before.
41 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
42 the xsettings_client still exists before destroying it.
44 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
47 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
48 dispose() implementation.
50 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
51 dispose() and check if it still exists before unrefing it. Set
52 their pointers to NULL/None *after* upchaining in dispose(),
53 because X11 implementations of members of the parent class still
54 need them for their own destruction.
56 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
57 was g_error()ing when finalizing a visual.
59 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
60 get_clipboard_widget() because it would create the widget if it
61 doesn't exist. Use g_object_get_data() directly instead.
63 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
66 2005-11-10 Simos Xenitellis <simos@gnome.org>
68 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
70 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
72 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
73 to render its arrows insensitive when the adjustment is in
74 its min or max position. this makes range arrow behaviour
75 consistent with spin button behaviour. (#321056)
77 2005-11-09 Tor Lillqvist <tml@novell.com>
80 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
81 the GdkDebugFlag enum.
83 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
84 this file instead of MISC. Now asking for MISC will give mainly
85 window manipulation debugging output with the Win32 backend.
87 2005-11-09 Tor Lillqvist <tml@novell.com>
89 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
91 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
92 function which was used only in one place.
94 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
96 (gdk_window_set_geometry_hints): If we have identical minimum and
97 maximum size hints, remove the resize and maximize
98 decorations/functions. (#104514)
100 If we have a maximum size hint, remove the maximize
101 decoration/function but ensure the resize decoration/function is
102 available. Otherwise ensure both resize and maximize
103 decorations/functions are there.
105 (set_or_clear_style_bits): Factored out common code from
106 gdk_window_set_decorations() and gdk_window_set_functions().
108 Hack the window style setting once more: Only touch the window
109 style bits corresponding to the GdkWMDecoration or GdkWMFunction
110 parameter bitmasks. Hopefully this finally is the correct thing to
111 do. We used to clear all other bits than those that were being
112 set, or set all other bits than those that were being cleared.
114 Take into account that adding or removing decorations leaves the
115 window's outer size unchanged, i.e., the client area's size and
116 position change. This is apparently not what we want, so change
117 also the window's (outer) position and size appropriately so that
118 the client area's position and size stay constant.
120 gtk-demo's color selector dialog is now non-resizable like on X11
121 (I tested with metacity in GNOME). Torn off menus are shrinkable
122 vertically but have a maximum size, and are not maximizable or
123 minimizable, like on X11.
125 (gdk_window_set_decorations, gdk_window_set_functions): Let
126 set_or_clear_decorations() do most of the job.
128 * gdk/win32/gdkprivate-win32.h: Remove declaration of
129 _gdk_win32_get_adjusted_client_rect().
131 2005-11-09 Tor Lillqvist <tml@novell.com>
133 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
134 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
135 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
136 type hint. Implement gdk_window_get_type_hint() by just returning
139 2005-11-09 Tor Lillqvist <tml@novell.com>
141 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
142 Remove code that has been permanently ifdeffed out for two years.
144 2005-11-08 Matthias Clasen <mclasen@redhat.com>
146 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
147 finalizing a gc. (#320789, Nickolay V. Shmyrev)
149 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
150 icons if they would make the request large enough to cause
151 Xlib to loose the connection. (#320909, Claudio Saavedra)
153 2005-11-08 Michael Natterer <mitch@imendio.com>
157 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
158 extracted from maemo-gtk). Fixes bug #320872.
160 2005-11-07 Matthias Clasen <mclasen@redhat.com>
162 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
163 looks the bookmark label when reordering. (#320720, Jeremy Cook)
165 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
166 Don't grab focus when a slider button is pressed, instead, use
167 a bit in the pathbar struct to determine whether to scroll up
168 or down. (#314486, Carlos Garnacho)
170 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
171 Don't popup the completions if the focus has already been
172 moved somewhere else. (#319914, Christian Persch)
174 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
175 Raise the drag_window after reconfiguring the
176 toolbar. (#320803, Christian Persch)
179 * gtk/gtkfilechooserbutton.h:
180 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
181 with setter and getter. (#318945, Christian Persch)
183 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
185 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
187 2005-11-07 Matthias Clasen <mclasen@redhat.com>
189 * configure.in: Adjust to the stock icon changes.
191 2005-11-07 Tor Lillqvist <tml@novell.com>
193 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
194 Correct the calculation of maskstride. (#320152, Peter Zelezny)
196 2005-11-06 Michael Natterer <mitch@imendio.com>
198 * gtk/Makefile.am (icons): fixed rule to actually create the
199 symlinks, erroring out if anything goes wrong.
201 2005-11-06 Tor Lillqvist <tml@novell.com>
203 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
204 target exists on Win32. First rename the target temporarily, then
205 if the renaming of the source to target fails, restore the
206 original name for the target.
208 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
210 2005-11-06 Tor Lillqvist <tml@novell.com>
212 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
213 like pixbuf_to_hbitmaps_normal().
214 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
215 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
216 setting the G_WIN32_PRETEND_WIN9X environment variable.
218 2005-11-06 Tor Lillqvist <tml@novell.com>
220 Make icon masks work on Win98 (#320152, Peter Zelezny)
222 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
223 parameter for the depth of the bitmap, so that this function can
224 be used to create 1-bit bitmaps, too.
225 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
226 and initialize it properly.
228 2005-11-04 Matthias Clasen <mclasen@redhat.com>
230 Store builtin stock icons in an icon cache, instead of
231 populating a hash table with pixbufs at startup, to save both
232 memory and startup time.
234 * gtk/stock-icons/*: Reorganize the icons in a directory structure
235 suitable for gtk-update-icon-cache, and rename them to match the
238 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
239 add _gtk_icon_cache_has_icon_in_directory().
241 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
242 to store the contents of the icon cache in a C header.
244 * gtk/gtkbuiltincache.h: Generated private header which contains
245 the icon cache for the builtin icons.
247 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
248 icons, and use that in addition to the hash table whenever
249 builtin icons are searched.
251 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
252 use it for static stock ids.
253 (get_default_icons): Don't add the builtin
254 icons to the icon theme, just register the stock ids.
255 (render_fallback_image): Take the fallback image out of the
258 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
259 the necessary machinery to rebuild gtkbuiltincache.h.
261 2005-11-04 Michael Natterer <mitch@imendio.com>
263 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
264 from maemo-gtk that changes the mtime check for rc files from
265 '>' to '!=', otherwise theme changes go unnoticed when turning
266 back the clock (Tommi Komulainen).
268 2005-11-04 Tor Lillqvist <tml@novell.com>
270 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
273 2005-11-03 Tor Lillqvist <tml@novell.com>
275 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
276 the Win32 backend, check that GdkDisplay* parameters are equal to
277 _gdk_display instead of using the unnecessarily general
280 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
281 color bitmap to have "color" in their name, for similarity with
282 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
283 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
284 the mask bitmap's contents, ones for those pixels in the color
285 bitmap where the alpha is zero, zero for other pixels. We used to
286 use an uninitialized mask bitmap! This meant that icons and
287 cursors created presumably worked more or less by accident.
288 Totally blank icons with zero alpha everywhere (as used by
289 gtktrayicon.c) definitely did not work as expected.
291 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
293 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
294 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
295 necessary and can be removed from CVS. It has never been mentioned
296 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
297 are used on Win32. One label widget is used (but never shown) as
298 gtk_widget_render_icon() needs a widget.
300 Ifdefs used as necessary in several places. It might be cleaner to
301 split out the backend-specific parts to separate files, or at
302 least collect them into separate blocks in the file.
304 (wndproc): New function. Window procedure to monitor mouse events
305 in the system tray icon. Call gtk_status_icon_button_press() as
307 (create_tray_observer): New function. Creates a hidden window that
308 only serves as a tray icon message observer.
310 * tests/teststatusicon.c (icon_activated): Position the dialog
311 with GTK_WIN_POS_CENTER.
312 (do_quit): New function, hide and unref the GtkStatusIcon, and
313 call gtk_main_quit().
314 (popup_menu): Add a Quit menu item that calls do_quit().
316 2005-11-02 Tor Lillqvist <tml@novell.com>
318 * gdk/win32/gdkcolor-win32.c
319 * gdk/win32/gdkscreen-win32.c
320 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
321 fixes. Remove superfluous test for GdkWindow* parameters being
322 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
323 GdkScreen and one GdkDisplay in the Win32 backend, use those
324 variables instead of the getter functions. For GdkDisplay* and
325 GdkScreen* parameters, check that they are equal to the
326 corresponding singleton variables instead of the more general
327 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
329 2005-11-02 Matthias Clasen <mclasen@redhat.com>
331 * gtk/gtktextview.c: Remove some g_return_if_fail() from
332 static functions, replace some others by g_assert().
334 * gtk/gtktextview.c (selection_motion_event_handler)
335 (gtk_text_view_start_selection_drag): Keep track of the original
336 selection boundaries during a drag selection, in order to correctly
337 decide when to extend or shrink the selection. (#320167,
338 reported by Arvind S N, patch by Paolo Borelli)
340 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
341 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
342 manual offset calculations by g_utf8_offset_to_pointer().
343 (#320360, Paolo Borelli)
345 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
347 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
348 nodes via the g_slice_*() API.
349 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
351 2005-11-01 Tor Lillqvist <tml@novell.com>
353 * gdk/win32/gdkprivate-win32.h
354 * gdk/win32/gdkglobals-win32.c
355 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
356 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
357 their declarations, definitions and assignments into a more
358 logical and consistent order.
360 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
361 CF_ prefix for the predefined clipboard format names. Put quotes
362 around registered format names to distinguish them.
364 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
365 immediately with a warning if the property type is STRING, TEXT,
366 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
367 should never pretend to handle on Win32. Handle only UTF8_STRING
368 here, other formats with delayed rendering. Use \uc1 instead of
369 \uc0 when generating Rich Text Format for easier testability on
370 XP, where WordPad misinterprets \uc0 encoded characters. Add more
371 GDK_NOTE debugging output for Clipboard operations.
373 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
374 (gdk_selection_convert): Don't pretent to handle STRING, just
375 UTF8_STRING. Streamline error handling, don't unnecessarily have a
376 GError which then isn't used for anything anyway if it gets set.
377 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
378 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
380 * config.h.win32.in: Sync with what configure produces.
382 * configure.in: Don't look for X_PACKAGES unless building for
383 x11. (#313986, John Ehresman)
385 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
387 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
388 Wondered why there was no ku there before??
390 2005-10-28 Matthias Clasen <mclasen@redhat.com>
392 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
393 window to the toplevels window group. (#319912, Christian Persch)
395 2005-10-28 Kristian Rietveld <kris@gtk.org>
397 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
400 2005-10-28 Matthias Clasen <mclasen@redhat.com>
402 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
403 drag cursors. (#319200, Federico Mena Quintero)
405 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
406 Shift-G to go to the previous match, like firefox. (#320061, Christian
409 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
410 C99ism. (#320000, Kazuki Iwamoto)
412 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
413 stars. (#319985, Bastien Nocera)
415 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
416 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
418 2005-10-26 Michael Natterer <mitch@imendio.com>
422 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
423 make sure that setting any of pixbuf/stock-id/icon-name resets the
424 others because they are mutually exclusive, and that unsetting any
425 of them only resets the pixbuf and nothing else. Also added
426 some missing g_object_notify().
428 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
429 g_value_set_object().
431 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
432 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
433 g_object_notify ("pixbuf").
435 2005-10-27 Matthias Clasen <mclasen@redhat.com>
437 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
438 careful about initializing cell_area. (#319382, Tommi
441 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
442 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
444 * demos/gtk-demo/clipboard.c (paste_received): Only set the
445 text if it is not NULL. (#319930, Thomas Klausner)
447 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
448 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
450 2005-10-26 Matthias Clasen <mclasen@redhat.com>
452 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
453 * gtk/gtkthemes.c (gtk_theme_engine_load):
454 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
455 when dlopening modules. (#319557, Laszlo Peter)
457 2005-10-26 Matthias Clasen <mclasen@redhat.com>
459 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
460 segments when determining text direction. (#319065, Tommi Komulainen)
462 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
463 on duplicate destroy. (#318953, Gustavo Carneiro)
465 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
466 Point out that destroy-with-parent is a bad idea for the dialog
467 passed to this function. (#318943, Christian Persch)
469 * */Makefile.am: use $(GLIB_MKENUMS) instead of
470 glib-mkenums. (#318582, Damien Carbery)
472 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
473 docs. (#317682, Christian Neumair)
475 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
476 seem to affect the placement of the data in the readonly
477 section, and causes problems with some compilers. (#317844)
479 2005-10-25 Matthias Clasen <mclasen@redhat.com>
481 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
482 Fix some issues with background drawing in RTL. (#318781,
486 * tests/testentrycompletion.c: Apply a patch by Christian
487 Persch to add property editors.
489 * gtk/gtkstatusicon.c: Emit activate on single-click,
490 not on double-click, change proposed by Milosz Derezynski.
492 2005-10-25 Kristian Rietveld <kris@gtk.org>
494 Fixes #311955, reported by Markku Vire; and a lot more.
496 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
497 Levels can now have invisible nodes cached, functions have been
498 rewritten/refactored to take this into account; also the logic in
499 some functions has been corrected.
501 Each referenced node now references all visible children or a single
502 invisible child, in order to be able to monitor all changes in the
503 child model required for correct operation.
505 When a virtual root is set, all nodes on the virtual root level are
508 At last, a bunch of random bug fixes and comment updates.
510 2005-10-25 Matthias Clasen <mclasen@redhat.com>
512 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
513 more docs. (#319722, Paolo Borelli)
515 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
516 initialization of screen_x11->xft_rgba more explicit. (#319627,
519 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
520 in a blurb. (#319499, Francisco Javier F. Serrador)
522 2005-10-24 Matthias Clasen <mclasen@redhat.com>
524 Add settings to hide the input method and Unicode control character
525 submenus in the context menus of GtkEntry and GtkTextView.
527 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
529 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
531 * gtk/gtktextview.c (popup_targets_received):
532 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
534 2005-10-24 Kristian Rietveld <kris@gtk.org>
536 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
537 row-has-child-toggled when the level is not in the cache does not
538 make sense. (This bug probably crept in during the early stages
539 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
541 (gtk_tree_model_sort_real_unref_node): only get the child iter
542 when we will actually also use it.
544 2005-10-22 Michael Natterer <mitch@imendio.com>
546 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
547 widget being realized, in addition to being visible, to avoid
548 running into precondition check in gtk_tree_view_get_cell_area().
551 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
553 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
554 Experimentally, scrollbar steppers can shrink to 8 pixels on
555 Win32. Reflect that in the theme.
556 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
557 there is a 1-pixel border between a scrollbar and its child
558 in ScrolledWindows on Win32. Reflect that in the theme.
560 2005-10-20 Matthias Clasen <mclasen@redhat.com>
562 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
563 for the selection window. (#318806, Alex Larsson)
565 2005-10-18 Federico Mena Quintero <federico@ximian.com>
569 * tests/autotestfilechooser.c
570 (test_button_folder_states_for_action): Test that we have either
571 $cwd or the explicitly-set folder.
572 (test_reload_sequence): Likewise.
574 * gtk/gtkfilechooserdefault.c
575 (gtk_file_chooser_default_get_current_folder): If our reload_state
576 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
578 2005-10-14 Tor Lillqvist <tml@novell.com>
580 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
581 It didn't really do anything useful, and was just confusing and
582 incomplete. Comments claimed we don't do delayed rendering, but in
583 fact we do, for images. (The delayed rendering code has other
584 problems, though, see #168173.) The clipboard viewer code was
585 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
586 the message when necessary). It was just test code, it said so in
587 a comment. Add something similar back later if necessary.
589 (_win32_on_clipboard_change,
590 _gdk_win32_register_clipboard_notification): Remove.
592 (gdk_display_supports_selection_notification,
593 gdk_display_request_selection_notification): Always just return
594 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
596 2005-10-13 Tor Lillqvist <tml@novell.com>
598 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
599 Alt-Enter specially. It does not have any special meaning and
600 should be passed on to the application. (#318378, Tim Evans)
602 2005-10-13 Tor Lillqvist <tml@novell.com>
604 Set visual depth to 24 for 32 bits-per-pixel devices on
605 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
606 optimized composite_0888() function rather than the slower image
607 dithering functions to draw pixbufs (#313993, John Ehresman)
609 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
610 _gdk_windowing_get_bits_for_depth() to initialize
611 GdkImage::bits_per_pixel.
612 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
614 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
615 _gdk_windowing_get_bits_for_depth() to initialize
616 BITMAPINFOHEADER::biBitCount.
618 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
619 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
622 2005-10-12 Stefan Kost <ensonic@users.sf.net>
624 * demos/gtk-demo/appwindow.c: (about_cb):
625 use PACKAGE_VERSION,bump year (#318654)
627 2005-10-11 Matthias Clasen <mclasen@redhat.com>
629 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
630 toggle here with the matching on toggle if it immediately follows.
631 This is a common case, and handling it here prevents quadratic blowup
632 in cleanup_line() below. (#317125)
634 * gtk/gtktextsegment.h:
635 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
636 the character counts into this function instead of computing them
639 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
641 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
643 * gtk/gtkfilechooserdefault.c
644 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
645 when the shortcut already exists in the sidebar. (#147521)
647 2005-10-09 Matthias Clasen <mclasen@redhat.com>
649 * tests/testcombo.c: Demonstrate how to use custom widgets in
652 2005-10-07 Federico Mena Quintero <federico@ximian.com>
656 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
657 the the result of gtk_file_chooser_get_folder() is NULL or
658 non-NULL at the right times. Log the tests.
659 (test_button_folder_states): New test for the initial states of
660 the current folder in GtkFileChooserButton.
661 (main): Test that the number of warnings/errors/critical errors is
664 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
665 Clarify the documentation on when this can return NULL.
666 (gtk_file_chooser_get_current_folder_uri): Likewise.
668 * gtk/gtkfilechooserbutton.c (struct
669 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
670 we use it to keep track of whether a folder has been set.
671 (gtk_file_chooser_button_map): Implement. If no folder has been
672 loaded before, we at least try to load $cwd here.
673 (gtk_file_chooser_button_constructor): If the construct-time
674 dialog already has a folder set, turn on our folder_has_been_set
676 (dialog_current_folder_changed_cb): Turn on our
677 folder_has_been_set flag.
679 2005-10-07 Michael Natterer <mitch@gimp.org>
681 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
682 PROFILE_FILE_CHOOSER because they break compilation after the
683 removal of <unistd.h>.
685 2005-10-07 Matthias Clasen <mclasen@redhat.com>
687 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
688 by moving it out of the profiling ifdef.
690 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
691 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
693 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
694 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
697 2005-10-06 Matthias Clasen <mclasen@redhat.com>
700 * gtk/gtktextbuffer.h:
701 * gtk/gtktextbuffer.c: Add a readonly has-selection property
702 with a getter. (#318161, Paolo Borelli)
704 2005-10-05 Matthias Clasen <mclasen@redhat.com>
706 * README.in: Start collecting release notes for 2.10.
708 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
709 leak fix, since the assertion failures were traced to
710 an xchat bug. (#314696)
712 * gtk/gtkstyle.c (gtk_style_detach):
713 (gtk_style_attach): Documentation improvements.
714 (gtk_style_detach): Assert that the attach_count is > 0.
716 2005-10-04 Federico Mena Quintero <federico@ximian.com>
718 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
719 shortcut position, not a ShortcutsIndex, to make the function more
721 (home_folder_handler): Pass the resolved index to
722 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
723 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
724 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
725 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
726 make the respective key switch to the first, second, ..., tenth
728 (quick_bookmark_handler): Implement.
730 2005-10-04 Federico Mena Quintero <federico@ximian.com>
732 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
733 Desktop; just use their real names on the file system for the
736 * gtk/gtkfilechooserdefault.c
737 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
738 binding signal, and bind it to M-d by default.
739 (desktop_folder_handler): Implement the default handler.
740 (home_folder_handler): Use a helper function.
741 (switch_to_shortcut): New helper function.
742 (shortcuts_append_home): Don't special-case the name of "Home";
743 just use the folder name.
745 2005-10-04 Tor Lillqvist <tml@novell.com>
747 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
748 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
750 2005-10-04 Matthias Clasen <mclasen@redhat.com>
752 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
753 from yesterday, since it leads to assertion failures. (#317879,
756 2005-10-03 Matthias Clasen <mclasen@redhat.com>
758 * gtk/gtkcalendar.c (gtk_calendar_init): Call
759 calendar_compute_days() after setting priv->week_start.
761 2005-10-03 Matthias Clasen <mclasen@redhat.com>
763 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
764 removing it from the hash table. (#314696, Benjamin Berg)
766 2005-10-01 Tor Lillqvist <tml@novell.com>
768 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
769 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
770 is that the the desktop isn't visible because the session has been
771 switched, the screen is locked, or a terminal server session
772 disconnected, so no error message necessary. (#137796)
774 It is of course remotely possible that BitBlt() failing with
775 ERROR_INVALID_HANDLE might also be caused by some other
776 problem. We could strive for perfection and track whether the
777 desktop is visible by using WTSRegisterSessionNotification() and
778 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
779 this issue, though. If we would track desktop visibility, we
780 should then avoid even trying to update the display at all while
781 the desktop isn't visible.
783 2005-09-30 Matthias Clasen <mclasen@redhat.com>
785 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
786 to correct the calculations for the first week day. We may
787 just have to remove this code if too many locales turn out
790 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
791 some cases. (#317611, Tommi Komulainen)
793 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
794 Prevent overflow when storing size hints in an unsigned
795 short variable. Tracked down by Ray Strode and Søren Sandmann.
797 2005-09-29 Matthias Clasen <mclasen@redhat.com>
799 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
802 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
803 grab shadowed. (#317332)
805 2005-09-29 Tor Lillqvist <tml@novell.com>
807 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
809 2005-09-28 Federico Mena Quintero <federico@ximian.com>
811 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
812 if the unmap test fails.
813 (test_reload_sequence): Use gtk_widget_show_now() instead of
814 gtk_widget_show() for the dialog.
815 Thanks to Tim Janik for noticing these.
817 2005-09-28 Federico Mena Quintero <federico@ximian.com>
819 * tests/testcellrenderertext.c: New file with a set of tests for
820 GtkCellRendererText. The idea is to run a text renderer through
821 most of its interesting property values to see that it works
824 * tests/Makefile.am: Added testcellrenderertext.
826 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
827 entry/exit of this function for profiling.
828 (gtk_file_chooser_default_style_set): Mark the start/end of the
829 calls to the parent class and the the signal emission for profiling.
831 2005-09-29 Tor Lillqvist <tml@novell.com>
833 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
834 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
835 system codepage using g_win32_locale_filename_from_utf8().
836 (#317457, Kazuki Iwamoto)
838 2005-09-28 Matthias Clasen <mclasen@redhat.com>
840 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
841 here. (#317039, Paolo Borelli)
844 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
845 to make this function work as boxed copy function. (#317455,
848 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
849 NULL. (#316828, Tor Lillqvist)
851 2005-09-28 Tor Lillqvist <tml@novell.com>
853 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
856 2005-09-27 Federico Mena Quintero <federico@ximian.com>
858 Don't reload the current folder unnecessarily on ::map().
860 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
862 (struct _GtkFileChooserDefault): Added a "reload_state" field.
864 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
865 Initialize impl->reload_state.
866 (gtk_file_chooser_default_map): Check the impl->reload_state; load
867 a default folder if no folder has been set, or reload the current
868 one only if we had been unmapped first.
869 (gtk_file_chooser_default_update_current_folder): Set the
870 reload_state to RELOAD_HAS_FOLDER.
871 (gtk_file_chooser_default_unmap): Implement, and set the
872 reload_state to RELOAD_WAS_UNMAPPED.
873 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
874 here; they'll get (re)loaded on ::map() anyway.
876 * gtk/gtkfilechooserwidget.c
877 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
879 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
880 a dialog; build it ourselves.
881 (test_reload): New test to ensure that we don't load the default
882 folder more than once, and that we reload it when
884 (get_impl_from_dialog): New utility function.
885 (test_widgets_for_current_action): Use get_impl_from_dialog().
887 2005-09-27 Federico Mena Quintero <federico@ximian.com>
889 * gtk/gtkfilechooserdefault.c
890 (gtk_file_chooser_default_constructor): Mark the entry/exit of
891 this function for profiling.
892 (check_icon_theme): Likewise.
893 (change_icon_theme): Likewise.
894 (settings_notify_cb): Likewise.
895 (gtk_file_chooser_default_screen_changed): Likewise.
896 (update_chooser_entry): If the selection is empty, clear the file
897 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
898 nothing will be selected when the user starts typeahead in the
899 treeview, and we don't want to clear the file name entry in that
900 case --- the user could be typing-ahead to look for a folder name.
901 Fixes bug #308332, patch by Jürg Billeter.
903 2005-09-27 Matthias Clasen <mclasen@redhat.com>
905 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
906 Pop below the entry if there's more free space below the entry
907 than above. (#316948, Tommi Komulainen)
909 2005-09-26 Federico Mena Quintero <federico@ximian.com>
911 Do not create the save mode-specific widgets in the open modes, so
912 that we don't carry their baggage around.
914 * gtk/gtkfilechooserdefault.c
915 (gtk_file_chooser_default_constructor): Don't create the
917 (save_widgets_create): Set the impl->save_widgets directly here,
918 instead of passing the widgets back to the caller. Also, pack
919 them into the impl's box.
920 (update_appearance): Create or destroy the save widgets as
921 appropriate. Set the action of the save_file_name_entry here.
922 (shortcuts_add_current_folder): Set the active item in the
923 save_folder_combo only if it exists.
924 (gtk_file_chooser_default_set_property): Don't set the action of
925 the save_file_name_entry here.
926 (gtk_file_chooser_default_update_current_folder): Set the base
927 folder of the save_file_name_entry only if the entry exists.
928 (shortcuts_drag_data_received_cb): Cast the selection_data->data
929 to (const char *) since that's what shortcuts_drop_uris() expects.
930 (file_list_drag_data_received_cb): Likewise, for
931 g_uri_list_extract_uris().
933 2005-09-26 Tor Lillqvist <tml@novell.com>
935 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
936 the shaped flag here, too. (#316871)
937 (gdk_window_shape_combine_region): Currently unimplemented, so
938 don't do anything to the shaped flag here.
940 2005-09-26 Matthias Clasen <mclasen@redhat.com>
942 Fix #316871, reported by Dan Winship:
944 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
946 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
947 (gdk_window_shape_combine_region): Set it here.
949 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
950 remove the child area for shaped windows.
952 2005-09-23 Matthias Clasen <mclasen@redhat.com>
954 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
955 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
957 2005-09-22 Michael Natterer <mitch@imendio.com>
959 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
960 consistent with GTK+ terminology:
962 * gtk/gtkcellrendererkeys.[ch]
963 * tests/testkeys.c: removed...
965 * gtk/gtkcellrendereraccel.[ch]
966 * tests/testaccel.c: ...and added.
971 * tests/Makefile.am: changed accordingly.
973 2005-09-22 Matthias Clasen <mclasen@redhat.com>
975 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
976 for the grab-broken-event signal, noticed by Damon Chaplin.
978 2005-09-21 Tor Lillqvist <tml@novell.com>
980 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
981 gdk_text_property_to_text_list_for_display,
982 gdk_text_property_to_utf8_list_for_display,
983 gdk_win32_selection_add_targets,
984 _gdk_win32_selection_convert_to_dib): Free return value from
986 (gdk_text_property_to_text_list_for_display): Drop GError variable
987 that isn't actually used after being set.
989 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
991 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
994 2005-09-20 Tor Lillqvist <tml@novell.com>
996 * gdk/win32/gdkselection-win32.c
997 (gdk_selection_owner_get_for_display): Do return the correct owner
998 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
999 a window GDK knows about). The reason to return NULL seems to have
1000 gone when in the fix for bug #163702 the artificial
1001 GDK_SELECTION_CLEAR event generation was removed from
1002 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1004 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1006 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1007 events. (#151555, Søren Sandmann)
1009 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1010 XkbSelectEventDetails() to select XkbStateNotify events
1011 for only the state we care about.
1013 * gdk/x11/gdkprivate-x11.h:
1014 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1015 the event into the function and update the keymap state from
1016 the state information contained in the event. Adjust all callers.
1018 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1020 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1021 in multiple places to avoid segfaults if the index is out of range.
1022 (#316422, Guillaume Cottenceau)
1023 (gtk_icon_view_set_drag_dest_item):
1024 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1025 #316424, Guillaume Cottenceau)
1027 2005-09-18 Hans Breuer <hans@breuer.org>
1029 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1030 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1032 2005-09-18 Hans Breuer <hans@breuer.org>
1034 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1035 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1036 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1037 the icon and is blinking with teststatusicon. More to come ...
1039 2005-09-18 Hans Breuer <hans@breuer.org>
1041 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1042 cause gtkprogressbar.c has #include <config.h> conditionally; less
1043 noise from generated gtk.def
1044 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1046 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1047 For me it works as well as the *NIX implemenation, that is not at all.
1049 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1051 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1052 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1053 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1054 again - if compiled properly.
1056 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1057 already coming with Gtk+. Makes it compile on win32.
1059 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1061 * README.cvs-commits: fixed some tiny typos
1063 2005-09-16 Tor Lillqvist <tml@novell.com>
1065 * modules/engines/ms-windows/msw_style.c (draw_extension,
1066 draw_box_gap): Check whether the widget actually is a GtkNotebook
1067 before treating it as such. Drop some unneeded local variables,
1068 use parameter with same information instead. (#316412)
1070 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1072 * tests/autotestfilechooser.c: Start a set of automated tests for
1073 the file chooser. The only test in there right now doesn't pass
1074 yet. It specifies the intended behavior of the first optimization
1075 of a series which I'll do on the file chooser (see
1076 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1077 details of this optimization).
1079 * tests/Makefile.am: Added autotestfilechooser.c.
1081 * gtk/gtkfilechooserprivate.h (struct
1082 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1083 structures to here, so that they can be accessed by
1084 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1085 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1087 * gtk/gtkfilechooserdialog.c: See above.
1089 * gtk/gtkfilechooserwidget.c: See above.
1091 * gtk/gtkfilechooserdefault.c: See above.
1093 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1096 gtk_window_map_event(): new function to work around lost unmap requests.
1099 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1101 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1102 an easy-to-find profiling marker when starting to create a file
1104 (browse_files_model_finished_loading_cb): Likewise, for when the
1105 chooser is finished loading.
1107 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1109 * gtk/gtkcolorbutton.c: Check "color" argument in
1110 gtk_color_button_set_color ()
1112 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1114 * gtk/gtklabel.c (gtk_label_get_type):
1115 * gtk/gtkbutton.c (gtk_button_get_type):
1116 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1117 using a mem chunk for window groups, buttons, labels.
1119 * gtk/updateiconcache.c (foreach_remove_func): Fix
1120 a use-after-free bug. (#316256, Alexander Nedotsukov)
1122 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1124 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1126 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1128 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1130 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1131 Let GDK_Return pass through in some more cases.
1133 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1134 activating the entry.
1136 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1137 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1138 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1140 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1141 (#316001, Guillaume Cottenceau)
1143 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1144 mistake in the docs. (#315993, Guillaume Cottenceau)
1146 * tests/testentrycompletion.c (create_simple_completion_model): Add
1147 some strings containing multibyte characters.
1149 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1150 Fix prefix insertion for multibyte characters. (#316095,
1153 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1154 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1155 return NULL if the widget is not realized. (#316023,
1156 Guillaume Cottenceau)
1158 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1161 * gdk/gdkproperty.h:
1162 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1163 New function to avoid pointless strdups when creating atoms
1164 from static strings.
1167 * gtk/*.c: Use gdk_atom_intern_static_string() where
1170 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1172 * gtk/gtkcellrendererkeys.h:
1173 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1174 and editing accelerators, a port of EggCellRendererKeys .
1178 * gtk/Makefile.am: Add the keys cell renderer.
1180 * tests/Makefile.am:
1181 * tests/testkeys.c: Test GtkCellRendererKeys
1183 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1185 Make it possible to determine if a key event is for a
1188 * gdk/x11/gdkprivate-x11.h:
1189 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1190 New function to determine if a keycode is mapped to a modifier.
1191 (get_xkb): Get the modmap.
1193 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1194 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1196 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1199 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1201 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1202 unused variable, noticed by Kjartan Maraas.
1204 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1206 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1207 Make drag reordering work properly for columns other than the
1208 first. (#315054, Dan Winship)
1210 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1211 invalid fontnames better. (#136926, Michael R. Walton)
1213 Stop cursor blinking in non-editable regions of a text view.
1214 (#311508, Torbjörn Andersson)
1216 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1217 (cursor_blinks): Take editability into account when deciding
1218 whether the cursor blinks.
1219 (gtk_text_view_button_release_event):
1220 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1222 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1223 Use connect_after to connect to the focus_out event. This
1224 ensures that the entry has already stopped blinking by the time
1225 we emit the edited signal. (#315229, Thomas Leonard)
1227 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1229 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1230 unsigned ints to -1. (#315481, Kjartan Maraas)
1232 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1233 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1234 (#314473, Stanislav Brabec)
1236 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1238 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1239 memory handling. (#314975, Torsten Schoenfeld)
1241 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1242 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1243 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1244 * gtk/gtklabel.c (gtk_label_class_init):
1245 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1246 Stylistic improvements and clarifications for some blurbs.
1247 (#315520, Clytie Siddall)
1249 2005-09-09 Tor Lillqvist <tml@novell.com>
1251 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1252 display name. There is only one GdkDisplay on Win32, and
1253 constructing the display name isn't entirely trivial, so cacheing
1254 is probably worth it. For instance GIMP calls this function a lot.
1255 (gdk_display_open): Call gdk_display_get_name() to prime the
1257 (gdk_display_get_n_screens, gdk_display_get_screen,
1258 gdk_display_get_default_screen): Verify parameter correctness like
1259 the X11 backend does.
1261 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1262 Return a freshly allocated string, as the API specifies. Fixes a
1263 heap corruption problem that caused random errors and crashes in
1266 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1268 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1269 Make C-u commit and restart hex input if we are already in a
1272 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1274 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1275 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1276 if they are mapped to the same modifier.
1278 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1279 to gtkstatusicon.c and gtktrayicon-x11.c
1281 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1282 default accel mod mask.
1284 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1285 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1286 Don't use GDK_ALT_MASK.
1288 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1290 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1292 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1294 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1297 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1298 Mod2 - Mod5 and against Super, Hyper, Meta.
1300 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1301 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1302 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1304 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1305 modmap to maintain the information which X modifiers map to
1307 (get_xkb): Set up the modmap from the XKB tables.
1308 (update_keymaps): Set up the modmap from the information returned
1309 by XGetModifierMapping in the non-XKB case.
1311 * gdk/x11/gdkprivate-x11.h:
1312 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1313 function to set the virtual modifiers in the state.
1315 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1316 _gdk_keymap_add_virtual_modifiers here.
1318 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1319 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1322 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1324 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1325 if it has no child. (#315253, John Finlay)
1327 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1329 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1331 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1333 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1334 on destroy to avoid problems when they are called on a destroyed
1335 widget. (#315135, John Cupitt)
1337 * gtk/gtkentry.c (gtk_entry_class_init):
1338 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1339 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1341 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1342 code. Now we only steal a single key combination, Ctrl-Shift-U,
1344 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1345 by a sequence of hex digits entered with Ctrl-Shift still held.
1346 Releasing one of the modifiers or pressing space while the modifiers
1347 are still held commits the character. It is possible to erase
1348 digits using backspace.
1349 As an extension to the above, we also allow to start the sequence
1350 with Ctrl-Shift-U, then release the modifiers before typing any
1351 digits, and enter the digits without modifiers.
1352 (#82011, Owen Taylor)
1354 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1356 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1357 we still need to deliver the destroy event. (#314980, Chris Lahey)
1359 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1360 im context before committing \n or \t.
1362 2005-09-02 Alexander Larsson <alexl@redhat.com>
1364 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1365 (shortcuts_activate_volume):
1366 Handle base_path being null in the rest of the cases (#310270)
1368 2005-09-02 Tor Lillqvist <tml@novell.com>
1370 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1371 cursor position also in root window coordinates. Prune out
1372 superfluous WM_MOUSEMOVE events even earlier, based on root window
1373 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1374 window has ben mapped below the cursor even if the mouse doesn't
1375 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1376 confused at least gtk_menu_motion_notify(). (#314995)
1378 * gtk/gtkintl.h: No need to include config.h here. It caused
1379 warnings about GTK_LOCALEDIR being redefined on Win32 when
1380 compiling files where gtkintl.h is included after gtkprivate.h
1381 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1383 * gtk/gtkplug.c: Include config.h.
1385 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1387 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1388 xdg_mime_get_mime_type_for_file() where possible, to avoid
1391 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1392 typo. (#314921, Guillaume Cottenceau)
1394 * gdk/*.c: Intern some more strings.
1396 * gtk/*.c: Define an I_() macro and use it instead of the
1397 bulky g_intern_static_string().
1399 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1401 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1402 instead of copying it.
1404 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1406 * gtk/*.c: Also intern static strings passed to
1407 g_object_set_data().
1410 * gtk/Makefile.am: Intern type names in code generated by
1415 * gdk/*.c: Intern type names before registering the type to avoid
1418 * configure.in: Require GLib 2.9.0
1420 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1422 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1423 and add icon-size and icon-size-set properties. (#314172)
1425 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1426 groups across transient parents. (#312918, Christian Persch)
1428 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1429 Guillaume Cottenceau)
1431 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1432 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1434 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1436 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1437 make C-/ select all and C-\ unselect all. (#309301,
1440 * gtk/gtkimcontextsimple.c: Change the compose sequence for
1441 soft hyphen to be multi_key-minus-minus-space, and add
1442 compose sequences multi_key-minus-minus-period and
1443 multi_key-minus-minus-minus for en dash and em dash.
1444 (#172653, Christian Lohmaier)
1446 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
1447 code. (#313946, Christian Persch)
1449 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
1450 fix for the default value of the "ui" property.
1452 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1455 * gtk/gtkselection.h:
1456 * gtk/gtkselection.c: Add functions which look for text, image
1457 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1460 * gtk/gtkselection.h:
1461 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1462 Add a function to check wether targets include uri.
1463 (#314092, Mark Wielaard)
1467 * gtk/gtkwindow.c: Add a deletable property with getter
1468 and setter, to control the close button in the window
1469 frame. (#59718, Havoc Pennington)
1471 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1473 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1474 to the arrow keys for menu navigation. (#162825, Carl Worth)
1476 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1478 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1480 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1481 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1482 refer to nonexisting stock ids.
1484 * gtk/gtktextview.c (popup_targets_received):
1485 * gtk/gtkentry.c (popup_targets_received): Construct
1486 the "Select All" menuitem from stock.
1488 * gtk/stock-icons/stock_select_all_{16,24}.png:
1489 * gtk/stock-icons/Makefile.am:
1490 * gtk/gtkiconfactory.c:
1492 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1495 * gtk/gtktrayicon.c: Add a pointer to the spec.
1497 * gtk/gtkstatusicon-x11.c: Add docs.
1499 * gtk/gtkstatusicon.h: Fix a typo.
1501 Add a cross-platform "tray icon" API, by
1502 porting EggStatusIcon/EggTrayIcon (#105101)
1504 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1505 displays an icon in a notification area.
1507 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1508 X11, using GtkTrayIcon.
1510 * gtk/gtktrayicon.h:
1511 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1512 system tray specification, not public API.
1514 * gtk/gtk.symbols: Add new exported functions.
1516 * gtk/gtk.h: Include gtkstatusicon.h.
1518 * gtk/Makefile.am: Add new files.
1520 * tests/Makefile.am:
1521 * tests/teststatusicon.c: Test for GtkStatusIcon.
1523 2005-08-29 Christopher Aillon <caillon@redhat.com>
1525 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1526 and GTK_STOCK_DISCONNECT
1528 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1530 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1531 Use XFixesChangeSaveSet if available. (#314682)
1533 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1534 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1536 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1538 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1539 accidentally leftover duplicate pixbuf creation. (#314700,
1542 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1543 leak the cursor theme name. (#314693, Kjartan Maraas)
1545 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1546 state.children in all cases. (#313862, Kjartan Maraas)
1548 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1550 * po/POTFILES.in, po-properties/POTFILES.in:
1553 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1555 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1556 value of the ui property. (#314532, Yong Wang)
1558 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1559 when G_MAXLONG is passed as length.
1561 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1563 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1564 to avoid overloading --force. (JP Rosevaar)
1566 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1568 * configure.in: Bump version to 2.9.0
1572 * gdk/gdkscreen.c: Make the GdkScreen font options api
1573 public, and add properties GdkScreen::font-options and
1574 GdkScreen::resolution. (#314004)
1577 * gtk/gtksettings.c:
1578 * gtk/gtkwidget.c: Adjust all callers.
1580 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1581 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1582 * gdk/gdkscreen.c: Include gdkintl.h.
1584 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1585 variable warning, pointed out by Colin Walters. (#314585)
1587 2005-08-26 Tor Lillqvist <tml@novell.com>
1589 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1591 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1593 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1595 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1596 of week_start. (#314473, JP Rosevaar)
1598 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1600 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1601 lock. (#314533, Thomas Fitzsimmons)
1603 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1605 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1606 NULL gracefully. (#314523, Ed Catmur)
1608 2005-08-25 Owen Taylor <otaylor@redhat.com>
1610 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1611 Handle theme == NULL.
1613 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1615 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1616 y offset into account when positioning the popup. (#314470,
1619 2005-08-25 Owen Taylor <otaylor@redhat.com>
1621 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1622 as instance_init, not base_init! (#314452, Fix from Frederic
1623 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1624 rather than 1 for a negative flag value.
1626 2005-08-24 Owen Taylor <otaylor@redhat.com>
1628 * gdk/gdkpango.c (draw_error_underline): Add a note about
1629 cut-and-paste between here and Pango.
1631 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1633 * === Released 2.8.2 ===
1635 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1636 callback for image/gif, and also try image/bmp. (#314086, Mark
1639 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1640 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1645 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1646 and cursor settings get propagated down to the screen initially.
1647 Pointed out by Frederic Crozat.
1649 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1650 message if the screen is NULL. Noticed by Kjartan Maraas.
1652 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1656 * === Released 2.8.1 ===
1660 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1662 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1663 against lazy filterers which return values other than TRUE or
1664 FALSE from their visible func. (#314335)
1666 2005-08-23 Owen Taylor <otaylor@redhat.com>
1668 Fix for #314004, reported by Michael Reinsch:
1671 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1672 Add gdk_screen_get/set_resolution_libgtk_only()
1674 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1675 the options for the screen on the newly created context.
1677 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1678 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1679 the font options on the screen.
1681 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1682 the font options from the screen and set them on the context.
1684 2005-08-23 Kristian Rietveld <kris@gtk.org>
1686 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1687 bother inserting new rows in a level with a zero refcount and
1688 immediately free the level. (Fixes #312350, reported by Markku Vire).
1690 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1692 * gtk/updateiconcache.c: Complain when there is no index.theme file
1693 in the specified directory, unless --force is used. Also add an
1694 --index-only option to create caches without image data.
1696 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1697 C99ism. (#314262, Robert Jeff Mitchell)
1699 2005-08-22 Manish Singh <yosh@gimp.org>
1701 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1703 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1705 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1707 * gtk/gtkwindow.c (gtk_window_client_event):
1708 * gtk/gtkicontheme.c (ensure_valid_themes)
1709 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1710 scheme for makeing sure that all GTK+ applications notice if an
1711 icon theme has been updated. This should prevent multiple versions
1712 of an icon theme cache to be mapped in memory at the same time,
1713 which can cause excessive memory consumption. (#313156, Chris
1716 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1718 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1719 regarding icon theme changes.
1721 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1722 pixbufs which are backed by the mmapped memory of an icon cache,
1723 increase the refcount of the icon cache, so that the memory is not
1724 munmapped away underneath the pixbuf upon icon theme changes.
1725 (#314170, Kjartan Maraas)
1727 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1728 to link against Xext. (#314062)
1730 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1731 overruns. (#314081, Hans Breuer)
1733 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1735 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1736 returned layout must not be modified.
1738 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1740 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1741 scroll_to_path if the model changes.
1743 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1744 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1745 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1746 we're realized, #312798
1747 (gtk_icon_view_set_model): clear scroll_to_path if the model
1750 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1752 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1753 (gtk_range_adjustment_value_changed): Don't queue a draw
1754 if the layout has not changed. (#313991, Benjamin Berg)
1756 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1758 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1761 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1764 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1765 (model_add_special, model_add_special, model_add_volumes):
1766 Handle pixbuf being NULL without warnings. Also, don't
1767 leak pixbuf references when the icon theme is changed.
1769 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1770 the user data on destroyed windows, since at best
1771 it can be a stale pointer. (#313953, Robin Green)
1773 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1775 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1776 (#313900, Sebastien Bacher)
1778 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1779 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1781 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1782 (xdnd_read_actions, get_client_window_at_coords_recurse):
1783 Free data returned from XGetWindowProperty.
1785 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1786 Free data returned from XGetWindowProperty. (313867, Kjartan
1789 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1790 children in all cases. (#313862, Kjartan Maraas)
1792 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1793 in the per-directory hash, even if they come from the icon cache.
1794 We tried to avoid that before, but as a result leaked icon data
1795 structs. (#313852, Kjartan Maraas)
1797 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1799 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1800 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1802 2005-08-15 Owen Taylor <otaylor@redhat.com>
1804 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1805 files for x11/xext. (Jonas Bonn)
1807 2005-08-15 Tor Lillqvist <tml@novell.com>
1809 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1812 2005-08-15 Owen Taylor <otaylor@redhat.com>
1814 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1816 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1817 (#313417, James Andrewartha)
1819 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1820 FcNameConstant(). (More of #313417)
1822 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1824 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1825 modal dialogs, make sure to inherit the window group from
1826 the parent, since we don't inherit window groups across
1827 transient parents currently. (#312918, Christian Persch)
1829 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1830 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1832 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1833 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1834 gracefully. (#312796, Jonathan Blandford)
1836 * tests/testtoolbar.c: Add some more tests for menu placement.
1838 * gtk/gtkmenutoolbutton.c (menu_position_func):
1839 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1840 of toolbutton menus and of the overflow menu. (#312937,
1841 #153870, Christian Persch, Paolo Borelli)
1843 2005-08-15 Tor Lillqvist <tml@novell.com>
1845 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1846 the nonportable <libgen.h> and dirname().
1848 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1850 * gtk/gtksizegroup.c: Use object data to mark widgets and
1851 groups as visited, so that we avoid constant extra list
1852 traversals. Also allocate quarks in class_init. (#311618,
1855 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1856 download location for the hicolor icon theme. (#313475, Olexiy
1859 * gtk/gtkicontheme.c: Remove debug spew.
1861 2005-08-15 Owen Taylor <otaylor@redhat.com>
1863 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1864 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1865 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1866 Handle pixmap == NULL when checking for a colormap.
1869 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1871 * gtk/updateiconcache.c: Store only one copy of the pixel data
1872 for symlinked icons. To achieve this, maintain a hashtable
1873 mapping pathnames to pixel data, and share the pixel data for
1874 all symlinks resolving to the same pathname. When writing out
1875 the image data, write out the pixel data only the first time
1876 it is met, and store the offset pointing to the first copy
1877 for use in all later cases.
1878 This reduces the size of the Bluecurve icon cache from 40