1 2005-10-26 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
4 segments when determining text direction. (#319065, Tommi Komulainen)
6 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
7 on duplicate destroy. (#318953, Gustavo Carneiro)
9 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
10 Point out that destroy-with-parent is a bad idea for the dialog
11 passed to this function. (#318943, Christian Persch)
13 * */Makefile.am: use $(GLIB_MKENUMS) instead of
14 glib-mkenums. (#318582, Damien Carbery)
16 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
17 docs. (#317682, Christian - Manny Calavera - Neumair)
19 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
20 seem to affect the placement of the data in the readonly
21 section, and causes problems with some compilers. (#317844)
23 2005-10-25 Matthias Clasen <mclasen@redhat.com>
25 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
26 Fix some issues with background drawing in RTL. (#318781,
30 * tests/testentrycompletion.c: Apply a patch by Christian
31 Persch to add property editors.
33 * gtk/gtkstatusicon.c: Emit activate on single-click,
34 not on double-click, change proposed by Milosz Derezynski.
36 2005-10-25 Kristian Rietveld <kris@gtk.org>
38 Fixes #311955, reported by Markku Vire; and a lot more.
40 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
41 Levels can now have invisible nodes cached, functions have been
42 rewritten/refactored to take this into account; also the logic in
43 some functions has been corrected.
45 Each referenced node now references all visible children or a single
46 invisible child, in order to be able to monitor all changes in the
47 child model required for correct operation.
49 When a virtual root is set, all nodes on the virtual root level are
52 At last, a bunch of random bug fixes and comment updates.
54 2005-10-25 Matthias Clasen <mclasen@redhat.com>
56 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
57 more docs. (#319722, Paolo Borelli)
59 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
60 initialization of screen_x11->xft_rgba more explicit. (#319627,
63 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
64 in a blurb. (#319499, Francisco Javier F. Serrador)
66 2005-10-24 Matthias Clasen <mclasen@redhat.com>
68 Add settings to hide the input method and Unicode control character
69 submenus in the context menus of GtkEntry and GtkTextView.
71 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
73 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
75 * gtk/gtktextview.c (popup_targets_received):
76 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
78 2005-10-24 Kristian Rietveld <kris@gtk.org>
80 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
81 row-has-child-toggled when the level is not in the cache does not
82 make sense. (This bug probably crept in during the early stages
83 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
85 (gtk_tree_model_sort_real_unref_node): only get the child iter
86 when we will actually also use it.
88 2005-10-22 Michael Natterer <mitch@imendio.com>
90 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
91 widget being realized, in addition to being visible, to avoid
92 running into precondition check in gtk_tree_view_get_cell_area().
95 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
97 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
98 Experimentally, scrollbar steppers can shrink to 8 pixels on
99 Win32. Reflect that in the theme.
100 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
101 there is a 1-pixel border between a scrollbar and its child
102 in ScrolledWindows on Win32. Reflect that in the theme.
104 2005-10-20 Matthias Clasen <mclasen@redhat.com>
106 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
107 for the selection window. (#318806, Alex Larsson)
109 2005-10-18 Federico Mena Quintero <federico@ximian.com>
113 * tests/autotestfilechooser.c
114 (test_button_folder_states_for_action): Test that we have either
115 $cwd or the explicitly-set folder.
116 (test_reload_sequence): Likewise.
118 * gtk/gtkfilechooserdefault.c
119 (gtk_file_chooser_default_get_current_folder): If our reload_state
120 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
122 2005-10-14 Tor Lillqvist <tml@novell.com>
124 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
125 It didn't really do anything useful, and was just confusing and
126 incomplete. Comments claimed we don't do delayed rendering, but in
127 fact we do, for images. (The delayed rendering code has other
128 problems, though, see #168173.) The clipboard viewer code was
129 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
130 the message when necessary). It was just test code, it said so in
131 a comment. Add something similar back later if necessary.
133 (_win32_on_clipboard_change,
134 _gdk_win32_register_clipboard_notification): Remove.
136 (gdk_display_supports_selection_notification,
137 gdk_display_request_selection_notification): Always just return
138 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
140 2005-10-13 Tor Lillqvist <tml@novell.com>
142 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
143 Alt-Enter specially. It does not have any special meaning and
144 should be passed on to the application. (#318378, Tim Evans)
146 2005-10-13 Tor Lillqvist <tml@novell.com>
148 Set visual depth to 24 for 32 bits-per-pixel devices on
149 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
150 optimized composite_0888() function rather than the slower image
151 dithering functions to draw pixbufs (#313993, John Ehresman)
153 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
154 _gdk_windowing_get_bits_for_depth() to initialize
155 GdkImage::bits_per_pixel.
156 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
158 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
159 _gdk_windowing_get_bits_for_depth() to initialize
160 BITMAPINFOHEADER::biBitCount.
162 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
163 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
166 2005-10-12 Stefan Kost <ensonic@users.sf.net>
168 * demos/gtk-demo/appwindow.c: (about_cb):
169 use PACKAGE_VERSION,bump year (#318654)
171 2005-10-11 Matthias Clasen <mclasen@redhat.com>
173 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
174 toggle here with the matching on toggle if it immediately follows.
175 This is a common case, and handling it here prevents quadratic blowup
176 in cleanup_line() below. (#317125)
178 * gtk/gtktextsegment.h:
179 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
180 the character counts into this function instead of computing them
183 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
185 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
187 * gtk/gtkfilechooserdefault.c
188 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
189 when the shortcut already exists in the sidebar. (#147521)
191 2005-10-09 Matthias Clasen <mclasen@redhat.com>
193 * tests/testcombo.c: Demonstrate how to use custom widgets in
196 2005-10-07 Federico Mena Quintero <federico@ximian.com>
200 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
201 the the result of gtk_file_chooser_get_folder() is NULL or
202 non-NULL at the right times. Log the tests.
203 (test_button_folder_states): New test for the initial states of
204 the current folder in GtkFileChooserButton.
205 (main): Test that the number of warnings/errors/critical errors is
208 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
209 Clarify the documentation on when this can return NULL.
210 (gtk_file_chooser_get_current_folder_uri): Likewise.
212 * gtk/gtkfilechooserbutton.c (struct
213 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
214 we use it to keep track of whether a folder has been set.
215 (gtk_file_chooser_button_map): Implement. If no folder has been
216 loaded before, we at least try to load $cwd here.
217 (gtk_file_chooser_button_constructor): If the construct-time
218 dialog already has a folder set, turn on our folder_has_been_set
220 (dialog_current_folder_changed_cb): Turn on our
221 folder_has_been_set flag.
223 2005-10-07 Michael Natterer <mitch@gimp.org>
225 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
226 PROFILE_FILE_CHOOSER because they break compilation after the
227 removal of <unistd.h>.
229 2005-10-07 Matthias Clasen <mclasen@redhat.com>
231 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
232 by moving it out of the profiling ifdef.
234 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
235 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
237 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
238 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
241 2005-10-06 Matthias Clasen <mclasen@redhat.com>
244 * gtk/gtktextbuffer.h:
245 * gtk/gtktextbuffer.c: Add a readonly has-selection property
246 with a getter. (#318161, Paolo Borelli)
248 2005-10-05 Matthias Clasen <mclasen@redhat.com>
250 * README.in: Start collecting release notes for 2.10.
252 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
253 leak fix, since the assertion failures were traced to
254 an xchat bug. (#314696)
256 * gtk/gtkstyle.c (gtk_style_detach):
257 (gtk_style_attach): Documentation improvements.
258 (gtk_style_detach): Assert that the attach_count is > 0.
260 2005-10-04 Federico Mena Quintero <federico@ximian.com>
262 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
263 shortcut position, not a ShortcutsIndex, to make the function more
265 (home_folder_handler): Pass the resolved index to
266 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
267 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
268 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
269 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
270 make the respective key switch to the first, second, ..., tenth
272 (quick_bookmark_handler): Implement.
274 2005-10-04 Federico Mena Quintero <federico@ximian.com>
276 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
277 Desktop; just use their real names on the file system for the
280 * gtk/gtkfilechooserdefault.c
281 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
282 binding signal, and bind it to M-d by default.
283 (desktop_folder_handler): Implement the default handler.
284 (home_folder_handler): Use a helper function.
285 (switch_to_shortcut): New helper function.
286 (shortcuts_append_home): Don't special-case the name of "Home";
287 just use the folder name.
289 2005-10-04 Tor Lillqvist <tml@novell.com>
291 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
292 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
294 2005-10-04 Matthias Clasen <mclasen@redhat.com>
296 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
297 from yesterday, since it leads to assertion failures. (#317879,
300 2005-10-03 Matthias Clasen <mclasen@redhat.com>
302 * gtk/gtkcalendar.c (gtk_calendar_init): Call
303 calendar_compute_days() after setting priv->week_start.
305 2005-10-03 Matthias Clasen <mclasen@redhat.com>
307 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
308 removing it from the hash table. (#314696, Benjamin Berg)
310 2005-10-01 Tor Lillqvist <tml@novell.com>
312 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
313 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
314 is that the the desktop isn't visible because the session has been
315 switched, the screen is locked, or a terminal server session
316 disconnected, so no error message necessary. (#137796)
318 It is of course remotely possible that BitBlt() failing with
319 ERROR_INVALID_HANDLE might also be caused by some other
320 problem. We could strive for perfection and track whether the
321 desktop is visible by using WTSRegisterSessionNotification() and
322 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
323 this issue, though. If we would track desktop visibility, we
324 should then avoid even trying to update the display at all while
325 the desktop isn't visible.
327 2005-09-30 Matthias Clasen <mclasen@redhat.com>
329 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
330 to correct the calculations for the first week day. We may
331 just have to remove this code if too many locales turn out
334 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
335 some cases. (#317611, Tommi Komulainen)
337 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
338 Prevent overflow when storing size hints in an unsigned
339 short variable. Tracked down by Ray Strode and Søren Sandmann.
341 2005-09-29 Matthias Clasen <mclasen@redhat.com>
343 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
346 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
347 grab shadowed. (#317332)
349 2005-09-29 Tor Lillqvist <tml@novell.com>
351 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
353 2005-09-28 Federico Mena Quintero <federico@ximian.com>
355 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
356 if the unmap test fails.
357 (test_reload_sequence): Use gtk_widget_show_now() instead of
358 gtk_widget_show() for the dialog.
359 Thanks to Tim Janik for noticing these.
361 2005-09-28 Federico Mena Quintero <federico@ximian.com>
363 * tests/testcellrenderertext.c: New file with a set of tests for
364 GtkCellRendererText. The idea is to run a text renderer through
365 most of its interesting property values to see that it works
368 * tests/Makefile.am: Added testcellrenderertext.
370 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
371 entry/exit of this function for profiling.
372 (gtk_file_chooser_default_style_set): Mark the start/end of the
373 calls to the parent class and the the signal emission for profiling.
375 2005-09-29 Tor Lillqvist <tml@novell.com>
377 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
378 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
379 system codepage using g_win32_locale_filename_from_utf8().
380 (#317457, Kazuki Iwamoto)
382 2005-09-28 Matthias Clasen <mclasen@redhat.com>
384 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
385 here. (#317039, Paolo Borelli)
388 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
389 to make this function work as boxed copy function. (#317455,
392 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
393 NULL. (#316828, Tor Lillqvist)
395 2005-09-28 Tor Lillqvist <tml@novell.com>
397 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
400 2005-09-27 Federico Mena Quintero <federico@ximian.com>
402 Don't reload the current folder unnecessarily on ::map().
404 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
406 (struct _GtkFileChooserDefault): Added a "reload_state" field.
408 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
409 Initialize impl->reload_state.
410 (gtk_file_chooser_default_map): Check the impl->reload_state; load
411 a default folder if no folder has been set, or reload the current
412 one only if we had been unmapped first.
413 (gtk_file_chooser_default_update_current_folder): Set the
414 reload_state to RELOAD_HAS_FOLDER.
415 (gtk_file_chooser_default_unmap): Implement, and set the
416 reload_state to RELOAD_WAS_UNMAPPED.
417 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
418 here; they'll get (re)loaded on ::map() anyway.
420 * gtk/gtkfilechooserwidget.c
421 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
423 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
424 a dialog; build it ourselves.
425 (test_reload): New test to ensure that we don't load the default
426 folder more than once, and that we reload it when
428 (get_impl_from_dialog): New utility function.
429 (test_widgets_for_current_action): Use get_impl_from_dialog().
431 2005-09-27 Federico Mena Quintero <federico@ximian.com>
433 * gtk/gtkfilechooserdefault.c
434 (gtk_file_chooser_default_constructor): Mark the entry/exit of
435 this function for profiling.
436 (check_icon_theme): Likewise.
437 (change_icon_theme): Likewise.
438 (settings_notify_cb): Likewise.
439 (gtk_file_chooser_default_screen_changed): Likewise.
440 (update_chooser_entry): If the selection is empty, clear the file
441 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
442 nothing will be selected when the user starts typeahead in the
443 treeview, and we don't want to clear the file name entry in that
444 case --- the user could be typing-ahead to look for a folder name.
445 Fixes bug #308332, patch by Jürg Billeter.
447 2005-09-27 Matthias Clasen <mclasen@redhat.com>
449 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
450 Pop below the entry if there's more free space below the entry
451 than above. (#316948, Tommi Komulainen)
453 2005-09-26 Federico Mena Quintero <federico@ximian.com>
455 Do not create the save mode-specific widgets in the open modes, so
456 that we don't carry their baggage around.
458 * gtk/gtkfilechooserdefault.c
459 (gtk_file_chooser_default_constructor): Don't create the
461 (save_widgets_create): Set the impl->save_widgets directly here,
462 instead of passing the widgets back to the caller. Also, pack
463 them into the impl's box.
464 (update_appearance): Create or destroy the save widgets as
465 appropriate. Set the action of the save_file_name_entry here.
466 (shortcuts_add_current_folder): Set the active item in the
467 save_folder_combo only if it exists.
468 (gtk_file_chooser_default_set_property): Don't set the action of
469 the save_file_name_entry here.
470 (gtk_file_chooser_default_update_current_folder): Set the base
471 folder of the save_file_name_entry only if the entry exists.
472 (shortcuts_drag_data_received_cb): Cast the selection_data->data
473 to (const char *) since that's what shortcuts_drop_uris() expects.
474 (file_list_drag_data_received_cb): Likewise, for
475 g_uri_list_extract_uris().
477 2005-09-26 Tor Lillqvist <tml@novell.com>
479 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
480 the shaped flag here, too. (#316871)
481 (gdk_window_shape_combine_region): Currently unimplemented, so
482 don't do anything to the shaped flag here.
484 2005-09-26 Matthias Clasen <mclasen@redhat.com>
486 Fix #316871, reported by Dan Winship:
488 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
490 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
491 (gdk_window_shape_combine_region): Set it here.
493 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
494 remove the child area for shaped windows.
496 2005-09-23 Matthias Clasen <mclasen@redhat.com>
498 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
499 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
501 2005-09-22 Michael Natterer <mitch@imendio.com>
503 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
504 consistent with GTK+ terminology:
506 * gtk/gtkcellrendererkeys.[ch]
507 * tests/testkeys.c: removed...
509 * gtk/gtkcellrendereraccel.[ch]
510 * tests/testaccel.c: ...and added.
515 * tests/Makefile.am: changed accordingly.
517 2005-09-22 Matthias Clasen <mclasen@redhat.com>
519 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
520 for the grab-broken-event signal, noticed by Damon Chaplin.
522 2005-09-21 Tor Lillqvist <tml@novell.com>
524 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
525 gdk_text_property_to_text_list_for_display,
526 gdk_text_property_to_utf8_list_for_display,
527 gdk_win32_selection_add_targets,
528 _gdk_win32_selection_convert_to_dib): Free return value from
530 (gdk_text_property_to_text_list_for_display): Drop GError variable
531 that isn't actually used after being set.
533 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
535 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
538 2005-09-20 Tor Lillqvist <tml@novell.com>
540 * gdk/win32/gdkselection-win32.c
541 (gdk_selection_owner_get_for_display): Do return the correct owner
542 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
543 a window GDK knows about). The reason to return NULL seems to have
544 gone when in the fix for bug #163702 the artificial
545 GDK_SELECTION_CLEAR event generation was removed from
546 gdk_selection_send_notify_for_display(). Fixes bug #316552.
548 2005-09-20 Matthias Clasen <mclasen@redhat.com>
550 Avoid unnecessary XkbGetState() calls and XkbStateNotify
551 events. (#151555, Søren Sandmann)
553 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
554 XkbSelectEventDetails() to select XkbStateNotify events
555 for only the state we care about.
557 * gdk/x11/gdkprivate-x11.h:
558 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
559 the event into the function and update the keymap state from
560 the state information contained in the event. Adjust all callers.
562 2005-09-19 Matthias Clasen <mclasen@redhat.com>
564 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
565 in multiple places to avoid segfaults if the index is out of range.
566 (#316422, Guillaume Cottenceau)
567 (gtk_icon_view_set_drag_dest_item):
568 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
569 #316424, Guillaume Cottenceau)
571 2005-09-18 Hans Breuer <hans@breuer.org>
573 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
574 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
576 2005-09-18 Hans Breuer <hans@breuer.org>
578 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
579 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
580 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
581 the icon and is blinking with teststatusicon. More to come ...
583 2005-09-18 Hans Breuer <hans@breuer.org>
585 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
586 cause gtkprogressbar.c has #include <config.h> conditionally; less
587 noise from generated gtk.def
588 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
590 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
591 For me it works as well as the *NIX implemenation, that is not at all.
593 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
595 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
596 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
597 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
598 again - if compiled properly.
600 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
601 already coming with Gtk+. Makes it compile on win32.
603 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
605 * README.cvs-commits: fixed some tiny typos
607 2005-09-16 Tor Lillqvist <tml@novell.com>
609 * modules/engines/ms-windows/msw_style.c (draw_extension,
610 draw_box_gap): Check whether the widget actually is a GtkNotebook
611 before treating it as such. Drop some unneeded local variables,
612 use parameter with same information instead. (#316412)
614 2005-09-15 Federico Mena Quintero <federico@ximian.com>
616 * tests/autotestfilechooser.c: Start a set of automated tests for
617 the file chooser. The only test in there right now doesn't pass
618 yet. It specifies the intended behavior of the first optimization
619 of a series which I'll do on the file chooser (see
620 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
621 details of this optimization).
623 * tests/Makefile.am: Added autotestfilechooser.c.
625 * gtk/gtkfilechooserprivate.h (struct
626 _GtkFileChooserDialogPrivate): Move all the file chooser's private
627 structures to here, so that they can be accessed by
628 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
629 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
631 * gtk/gtkfilechooserdialog.c: See above.
633 * gtk/gtkfilechooserwidget.c: See above.
635 * gtk/gtkfilechooserdefault.c: See above.
637 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
640 gtk_window_map_event(): new function to work around lost unmap requests.
643 2005-09-14 Federico Mena Quintero <federico@ximian.com>
645 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
646 an easy-to-find profiling marker when starting to create a file
648 (browse_files_model_finished_loading_cb): Likewise, for when the
649 chooser is finished loading.
651 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
653 * gtk/gtkcolorbutton.c: Check "color" argument in
654 gtk_color_button_set_color ()
656 2005-09-14 Matthias Clasen <mclasen@redhat.com>
658 * gtk/gtklabel.c (gtk_label_get_type):
659 * gtk/gtkbutton.c (gtk_button_get_type):
660 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
661 using a mem chunk for window groups, buttons, labels.
663 * gtk/updateiconcache.c (foreach_remove_func): Fix
664 a use-after-free bug. (#316256, Alexander Nedotsukov)
666 2005-09-13 Matthias Clasen <mclasen@redhat.com>
668 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
670 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
672 2005-09-13 Matthias Clasen <mclasen@redhat.com>
674 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
675 Let GDK_Return pass through in some more cases.
677 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
678 activating the entry.
680 * gtk/gtkiconview.c (gtk_icon_view_class_init):
681 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
682 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
684 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
685 (#316001, Guillaume Cottenceau)
687 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
688 mistake in the docs. (#315993, Guillaume Cottenceau)
690 * tests/testentrycompletion.c (create_simple_completion_model): Add
691 some strings containing multibyte characters.
693 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
694 Fix prefix insertion for multibyte characters. (#316095,
697 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
698 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
699 return NULL if the widget is not realized. (#316023,
700 Guillaume Cottenceau)
702 2005-09-11 Matthias Clasen <mclasen@redhat.com>
706 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
707 New function to avoid pointless strdups when creating atoms
711 * gtk/*.c: Use gdk_atom_intern_static_string() where
714 2005-09-09 Matthias Clasen <mclasen@redhat.com>
716 * gtk/gtkcellrendererkeys.h:
717 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
718 and editing accelerators, a port of EggCellRendererKeys .
722 * gtk/Makefile.am: Add the keys cell renderer.
725 * tests/testkeys.c: Test GtkCellRendererKeys
727 2005-09-09 Matthias Clasen <mclasen@redhat.com>
729 Make it possible to determine if a key event is for a
732 * gdk/x11/gdkprivate-x11.h:
733 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
734 New function to determine if a keycode is mapped to a modifier.
735 (get_xkb): Get the modmap.
737 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
738 is_modifier bit by calling _gdk_keymap_key_is_modifier().
740 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
743 2005-09-09 Matthias Clasen <mclasen@redhat.com>
745 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
746 unused variable, noticed by Kjartan Maraas.
748 2005-09-09 Matthias Clasen <mclasen@redhat.com>
750 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
751 Make drag reordering work properly for columns other than the
752 first. (#315054, Dan Winship)
754 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
755 invalid fontnames better. (#136926, Michael R. Walton)
757 Stop cursor blinking in non-editable regions of a text view.
758 (#311508, Torbjörn Andersson)
760 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
761 (cursor_blinks): Take editability into account when deciding
762 whether the cursor blinks.
763 (gtk_text_view_button_release_event):
764 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
766 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
767 Use connect_after to connect to the focus_out event. This
768 ensures that the entry has already stopped blinking by the time
769 we emit the edited signal. (#315229, Thomas Leonard)
771 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
773 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
774 unsigned ints to -1. (#315481, Kjartan Maraas)
776 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
777 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
778 (#314473, Stanislav Brabec)
780 2005-09-09 Matthias Clasen <mclasen@redhat.com>
782 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
783 memory handling. (#314975, Torsten Schoenfeld)
785 * gtk/gtkiconview.c (gtk_icon_view_class_init):
786 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
787 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
788 * gtk/gtklabel.c (gtk_label_class_init):
789 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
790 Stylistic improvements and clarifications for some blurbs.
791 (#315520, Clytie Siddall)
793 2005-09-09 Tor Lillqvist <tml@novell.com>
795 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
796 display name. There is only one GdkDisplay on Win32, and
797 constructing the display name isn't entirely trivial, so cacheing
798 is probably worth it. For instance GIMP calls this function a lot.
799 (gdk_display_open): Call gdk_display_get_name() to prime the
801 (gdk_display_get_n_screens, gdk_display_get_screen,
802 gdk_display_get_default_screen): Verify parameter correctness like
803 the X11 backend does.
805 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
806 Return a freshly allocated string, as the API specifies. Fixes a
807 heap corruption problem that caused random errors and crashes in
810 2005-09-07 Matthias Clasen <mclasen@redhat.com>
812 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
813 Make C-u commit and restart hex input if we are already in a
816 2005-09-06 Matthias Clasen <mclasen@redhat.com>
818 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
819 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
820 if they are mapped to the same modifier.
822 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
823 to gtkstatusicon.c and gtktrayicon-x11.c
825 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
826 default accel mod mask.
828 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
829 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
830 Don't use GDK_ALT_MASK.
832 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
834 2005-09-06 Matthias Clasen <mclasen@redhat.com>
836 Add support for extra virtual modifiers: (#85780, Owen Taylor)
838 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
841 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
842 Mod2 - Mod5 and against Super, Hyper, Meta.
844 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
845 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
846 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
848 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
849 modmap to maintain the information which X modifiers map to
851 (get_xkb): Set up the modmap from the XKB tables.
852 (update_keymaps): Set up the modmap from the information returned
853 by XGetModifierMapping in the non-XKB case.
855 * gdk/x11/gdkprivate-x11.h:
856 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
857 function to set the virtual modifiers in the state.
859 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
860 _gdk_keymap_add_virtual_modifiers here.
862 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
863 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
866 2005-09-05 Matthias Clasen <mclasen@redhat.com>
868 * gtk/gtkaction.c (connect_proxy): Set the label of a button
869 if it has no child. (#315253, John Finlay)
871 2005-09-02 Matthias Clasen <mclasen@redhat.com>
873 * gtkimcontextsimple.h: Add a modifiers_dropped bit
875 2005-09-02 Matthias Clasen <mclasen@redhat.com>
877 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
878 on destroy to avoid problems when they are called on a destroyed
879 widget. (#315135, John Cupitt)
881 * gtk/gtkentry.c (gtk_entry_class_init):
882 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
883 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
885 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
886 code. Now we only steal a single key combination, Ctrl-Shift-U,
888 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
889 by a sequence of hex digits entered with Ctrl-Shift still held.
890 Releasing one of the modifiers or pressing space while the modifiers
891 are still held commits the character. It is possible to erase
892 digits using backspace.
893 As an extension to the above, we also allow to start the sequence
894 with Ctrl-Shift-U, then release the modifiers before typing any
895 digits, and enter the digits without modifiers.
896 (#82011, Owen Taylor)
898 2005-09-02 Matthias Clasen <mclasen@redhat.com>
900 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
901 we still need to deliver the destroy event. (#314980, Chris Lahey)
903 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
904 im context before committing \n or \t.
906 2005-09-02 Alexander Larsson <alexl@redhat.com>
908 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
909 (shortcuts_activate_volume):
910 Handle base_path being null in the rest of the cases (#310270)
912 2005-09-02 Tor Lillqvist <tml@novell.com>
914 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
915 cursor position also in root window coordinates. Prune out
916 superfluous WM_MOUSEMOVE events even earlier, based on root window
917 coordinates. Windows sends WM_MOUSEMOVE messages after a new
918 window has ben mapped below the cursor even if the mouse doesn't
919 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
920 confused at least gtk_menu_motion_notify(). (#314995)
922 * gtk/gtkintl.h: No need to include config.h here. It caused
923 warnings about GTK_LOCALEDIR being redefined on Win32 when
924 compiling files where gtkintl.h is included after gtkprivate.h
925 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
927 * gtk/gtkplug.c: Include config.h.
929 2005-09-01 Matthias Clasen <mclasen@redhat.com>
931 * gtk/gtkfilesystemunix.c: Pass statbufs down to
932 xdg_mime_get_mime_type_for_file() where possible, to avoid
935 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
936 typo. (#314921, Guillaume Cottenceau)
938 * gdk/*.c: Intern some more strings.
940 * gtk/*.c: Define an I_() macro and use it instead of the
941 bulky g_intern_static_string().
943 2005-08-31 Matthias Clasen <mclasen@redhat.com>
945 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
946 instead of copying it.
948 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
950 * gtk/*.c: Also intern static strings passed to
954 * gtk/Makefile.am: Intern type names in code generated by
959 * gdk/*.c: Intern type names before registering the type to avoid
962 * configure.in: Require GLib 2.9.0
964 2005-08-31 Matthias Clasen <mclasen@redhat.com>
966 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
967 and add icon-size and icon-size-set properties. (#314172)
969 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
970 groups across transient parents. (#312918, Christian Persch)
972 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
973 Guillaume Cottenceau)
975 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
976 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
978 2005-08-30 Matthias Clasen <mclasen@redhat.com>
980 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
981 make C-/ select all and C-\ unselect all. (#309301,
984 * gtk/gtkimcontextsimple.c: Change the compose sequence for
985 soft hyphen to be multi_key-minus-minus-space, and add
986 compose sequences multi_key-minus-minus-period and
987 multi_key-minus-minus-minus for en dash and em dash.
988 (#172653, Christian Lohmaier)
990 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
991 code. (#313946, Christian Persch)
993 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
994 fix for the default value of the "ui" property.
996 2005-08-30 Matthias Clasen <mclasen@redhat.com>
999 * gtk/gtkselection.h:
1000 * gtk/gtkselection.c: Add functions which look for text, image
1001 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1004 * gtk/gtkselection.h:
1005 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1006 Add a function to check wether targets include uri.
1007 (#314092, Mark Wielaard)
1011 * gtk/gtkwindow.c: Add a deletable property with getter
1012 and setter, to control the close button in the window
1013 frame. (#59718, Havoc Pennington)
1015 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1017 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1018 to the arrow keys for menu navigation. (#162825, Carl Worth)
1020 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1022 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1024 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1025 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1026 refer to nonexisting stock ids.
1028 * gtk/gtktextview.c (popup_targets_received):
1029 * gtk/gtkentry.c (popup_targets_received): Construct
1030 the "Select All" menuitem from stock.
1032 * gtk/stock-icons/stock_select_all_{16,24}.png:
1033 * gtk/stock-icons/Makefile.am:
1034 * gtk/gtkiconfactory.c:
1036 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1039 * gtk/gtktrayicon.c: Add a pointer to the spec.
1041 * gtk/gtkstatusicon-x11.c: Add docs.
1043 * gtk/gtkstatusicon.h: Fix a typo.
1045 Add a cross-platform "tray icon" API, by
1046 porting EggStatusIcon/EggTrayIcon (#105101)
1048 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1049 displays an icon in a notification area.
1051 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1052 X11, using GtkTrayIcon.
1054 * gtk/gtktrayicon.h:
1055 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1056 system tray specification, not public API.
1058 * gtk/gtk.symbols: Add new exported functions.
1060 * gtk/gtk.h: Include gtkstatusicon.h.
1062 * gtk/Makefile.am: Add new files.
1064 * tests/Makefile.am:
1065 * tests/teststatusicon.c: Test for GtkStatusIcon.
1067 2005-08-29 Christopher Aillon <caillon@redhat.com>
1069 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1070 and GTK_STOCK_DISCONNECT
1072 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1074 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1075 Use XFixesChangeSaveSet if available. (#314682)
1077 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1078 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1080 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1082 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1083 accidentally leftover duplicate pixbuf creation. (#314700,
1086 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1087 leak the cursor theme name. (#314693, Kjartan Maraas)
1089 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1090 state.children in all cases. (#313862, Kjartan Maraas)
1092 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1094 * po/POTFILES.in, po-properties/POTFILES.in:
1097 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1099 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1100 value of the ui property. (#314532, Yong Wang)
1102 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1103 when G_MAXLONG is passed as length.
1105 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1107 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1108 to avoid overloading --force. (JP Rosevaar)
1110 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1112 * configure.in: Bump version to 2.9.0
1116 * gdk/gdkscreen.c: Make the GdkScreen font options api
1117 public, and add properties GdkScreen::font-options and
1118 GdkScreen::resolution. (#314004)
1121 * gtk/gtksettings.c:
1122 * gtk/gtkwidget.c: Adjust all callers.
1124 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1125 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1126 * gdk/gdkscreen.c: Include gdkintl.h.
1128 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1129 variable warning, pointed out by Colin Walters. (#314585)
1131 2005-08-26 Tor Lillqvist <tml@novell.com>
1133 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1135 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1137 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1139 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1140 of week_start. (#314473, JP Rosevaar)
1142 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1144 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1145 lock. (#314533, Thomas Fitzsimmons)
1147 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1149 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1150 NULL gracefully. (#314523, Ed Catmur)
1152 2005-08-25 Owen Taylor <otaylor@redhat.com>
1154 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1155 Handle theme == NULL.
1157 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1159 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1160 y offset into account when positioning the popup. (#314470,
1163 2005-08-25 Owen Taylor <otaylor@redhat.com>
1165 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1166 as instance_init, not base_init! (#314452, Fix from Frederic
1167 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1168 rather than 1 for a negative flag value.
1170 2005-08-24 Owen Taylor <otaylor@redhat.com>
1172 * gdk/gdkpango.c (draw_error_underline): Add a note about
1173 cut-and-paste between here and Pango.
1175 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1177 * === Released 2.8.2 ===
1179 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1180 callback for image/gif, and also try image/bmp. (#314086, Mark
1183 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1184 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1189 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1190 and cursor settings get propagated down to the screen initially.
1191 Pointed out by Frederic Crozat.
1193 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1194 message if the screen is NULL. Noticed by Kjartan Maraas.
1196 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1200 * === Released 2.8.1 ===
1204 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1206 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1207 against lazy filterers which return values other than TRUE or
1208 FALSE from their visible func. (#314335)
1210 2005-08-23 Owen Taylor <otaylor@redhat.com>
1212 Fix for #314004, reported by Michael Reinsch:
1215 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1216 Add gdk_screen_get/set_resolution_libgtk_only()
1218 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1219 the options for the screen on the newly created context.
1221 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1222 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1223 the font options on the screen.
1225 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1226 the font options from the screen and set them on the context.
1228 2005-08-23 Kristian Rietveld <kris@gtk.org>
1230 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1231 bother inserting new rows in a level with a zero refcount and
1232 immediately free the level. (Fixes #312350, reported by Markku Vire).
1234 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1236 * gtk/updateiconcache.c: Complain when there is no index.theme file
1237 in the specified directory, unless --force is used. Also add an
1238 --index-only option to create caches without image data.
1240 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1241 C99ism. (#314262, Robert Jeff Mitchell)
1243 2005-08-22 Manish Singh <yosh@gimp.org>
1245 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1247 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1249 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1251 * gtk/gtkwindow.c (gtk_window_client_event):
1252 * gtk/gtkicontheme.c (ensure_valid_themes)
1253 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1254 scheme for makeing sure that all GTK+ applications notice if an
1255 icon theme has been updated. This should prevent multiple versions
1256 of an icon theme cache to be mapped in memory at the same time,
1257 which can cause excessive memory consumption. (#313156, Chris
1260 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1262 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1263 regarding icon theme changes.
1265 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1266 pixbufs which are backed by the mmapped memory of an icon cache,
1267 increase the refcount of the icon cache, so that the memory is not
1268 munmapped away underneath the pixbuf upon icon theme changes.
1269 (#314170, Kjartan Maraas)
1271 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1272 to link against Xext. (#314062)
1274 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1275 overruns. (#314081, Hans Breuer)
1277 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1279 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1280 returned layout must not be modified.
1282 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1284 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1285 scroll_to_path if the model changes.
1287 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1288 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1289 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1290 we're realized, #312798
1291 (gtk_icon_view_set_model): clear scroll_to_path if the model
1294 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1296 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1297 (gtk_range_adjustment_value_changed): Don't queue a draw
1298 if the layout has not changed. (#313991, Benjamin Berg)
1300 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1302 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1305 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1308 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1309 (model_add_special, model_add_special, model_add_volumes):
1310 Handle pixbuf being NULL without warnings. Also, don't
1311 leak pixbuf references when the icon theme is changed.
1313 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1314 the user data on destroyed windows, since at best
1315 it can be a stale pointer. (#313953, Robin Green)
1317 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1319 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1320 (#313900, Sebastien Bacher)
1322 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1323 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1325 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1326 (xdnd_read_actions, get_client_window_at_coords_recurse):
1327 Free data returned from XGetWindowProperty.
1329 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1330 Free data returned from XGetWindowProperty. (313867, Kjartan
1333 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1334 children in all cases. (#313862, Kjartan Maraas)
1336 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1337 in the per-directory hash, even if they come from the icon cache.
1338 We tried to avoid that before, but as a result leaked icon data
1339 structs. (#313852, Kjartan Maraas)
1341 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1343 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1344 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1346 2005-08-15 Owen Taylor <otaylor@redhat.com>
1348 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1349 files for x11/xext. (Jonas Bonn)
1351 2005-08-15 Tor Lillqvist <tml@novell.com>
1353 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1356 2005-08-15 Owen Taylor <otaylor@redhat.com>
1358 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1360 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1361 (#313417, James Andrewartha)
1363 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1364 FcNameConstant(). (More of #313417)
1366 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1368 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1369 modal dialogs, make sure to inherit the window group from
1370 the parent, since we don't inherit window groups across
1371 transient parents currently. (#312918, Christian Persch)
1373 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1374 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1376 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1377 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1378 gracefully. (#312796, Jonathan Blandford)
1380 * tests/testtoolbar.c: Add some more tests for menu placement.
1382 * gtk/gtkmenutoolbutton.c (menu_position_func):
1383 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1384 of toolbutton menus and of the overflow menu. (#312937,
1385 #153870, Christian Persch, Paolo Borelli)
1387 2005-08-15 Tor Lillqvist <tml@novell.com>
1389 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1390 the nonportable <libgen.h> and dirname().
1392 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1394 * gtk/gtksizegroup.c: Use object data to mark widgets and
1395 groups as visited, so that we avoid constant extra list
1396 traversals. Also allocate quarks in class_init. (#311618,
1399 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1400 download location for the hicolor icon theme. (#313475, Olexiy
1403 * gtk/gtkicontheme.c: Remove debug spew.
1405 2005-08-15 Owen Taylor <otaylor@redhat.com>
1407 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1408 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1409 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1410 Handle pixmap == NULL when checking for a colormap.
1413 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1415 * gtk/updateiconcache.c: Store only one copy of the pixel data
1416 for symlinked icons. To achieve this, maintain a hashtable
1417 mapping pathnames to pixel data, and share the pixel data for
1418 all symlinks resolving to the same pathname. When writing out
1419 the image data, write out the pixel data only the first time
1420 it is met, and store the offset pointing to the first copy
1421 for use in all later cases.
1422 This reduces the size of the Bluecurve icon cache from 40