1 Tue Dec 6 11:37:59 2005 Tim Janik <timj@gtk.org>
3 * gdk/gdkevents.c (gdk_event_new): fix missing hash table
6 Tue Dec 6 10:32:17 2005 Tim Janik <timj@gtk.org>
8 * gtk/gtkstatusbar.c: ported memchunk uses to g_slice, so the code
11 2005-12-05 Federico Mena Quintero <federico@ximian.com>
13 * gtk/gtkfilechooserdefault.c (trap_activate_cb): "event->state &
14 modifiers", not "event->state && modifiers". Patch by Sadrul
15 Habib Chowdhury <imadil@gmail.com>. Fixes bug #323073.
17 2005-12-05 Matthias Clasen <mclasen@redhat.com>
21 * gtk/gtktreedatalist.c:
24 * gtk/gtkitemfactory.c:
25 * gtk/gtkseparator.[hc]:
28 * gtk/gtkgc.c: Use g_slice instead of mem chunks.
30 2005-12-05 Michael Natterer <mitch@imendio.com>
32 * gdk/x11/gdkevents-x11.c: map the new GtkSettings properties
33 "timeout-initial", "timeout-repeat", "color-scheme" and
34 "enable-enimations" to X settings.
36 2005-12-05 Matthias Clasen <mclasen@redhat.com>
39 * gdk/gdkcolor.c: Use g_slice instead of mem chunks.
41 * gtk/gtktreeview.c (gtk_tree_view_key_press): Free new_event
42 after sending it to the search entry. (#323209, Crispin Flowerday)
44 * README.in: Add a note about GTK_FLOATING.
46 * gtk/gtkobject.h (GTK_OBJECT_FLOATING): Use g_object_is_floating.
48 2005-12-02 Matthias Clasen <mclasen@redhat.com>
50 * gtk/gtktoolbutton.c (clone_image_menu_size): Don't leak
51 a pixbuf. (#323024, Paolo Borelli)
53 2005-12-02 Matthias Clasen <mclasen@redhat.com>
55 * gtk/gtkfilesystemunix.c (get_icon_for_mime_type): Don't crash
56 if mime_type is NULL. (#322998, Sadrul Habib Chowdhury)
58 2005-12-02 Michael Natterer <mitch@imendio.com>
60 * gtk/gtkmenu.c: applied modified patch from maemo-gtk which
61 adds a "horizontal-padding" style property. Fixes bug #323036.
63 2005-12-01 Michael Natterer <mitch@imendio.com>
65 Merged modified patch from maemo-gtk that allows to disable
66 toolbar animations. Addresses bug #142582.
68 * gtk/gtksettings.c: added boolean property "gtk-enable-animations".
69 (patch from Christian Neumair)
71 * gtk/gtktoolbar.c: don't animate toolbar changes if the settings
72 property is FALSE. Replaced the individual "notify::foo"
73 connections to GtkSettings by a single "notify" callback and
76 2005-12-01 Michael Natterer <mitch@imendio.com>
78 * gtk/gtkmenu.c (gtk_menu_class_init): removed redundant
79 assignment of widget_class->motion_notify_event.
81 2005-11-29 Matthias Clasen <mclasen@redhat.com>
83 * gtk/gtktoggleaction.c (gtk_toggle_action_class_init): Add
84 an active property. (#322673, Jorn Baayen)
86 Properly handle model changes in GtkTreeSelection: (#322569,
89 * gtk/gtktreeselection.c (gtk_tree_selection_selected_foreach):
90 Get a reference to the model, and stop the iteration if the model
91 of the treeview is changed on the way.
93 * gtk/gtktreeprivate.h:
94 * gtk/gtktreeselection.c (_gtk_tree_selection_emit_changed): New
95 private function to emit the GtkTreeSelection::changed signal.
97 * gtk/gtktreeview.c (gtk_tree_view_set_model): Call
98 _gtk_tree_selection_emit_changed() when the model changes.
100 2005-11-28 Federico Mena Quintero <federico@ximian.com>
102 Fixes the critical warnings from bug #317999, thus fixing the bug
105 * gtk/gtkfilechooserdefault.c
106 (gtk_file_chooser_default_get_paths): In SELECT_FOLDER mode,
107 use _gtk_file_chooser_get_current_folder_path() instead of fetching the
108 impl->current_folder directly. The latter may be null if we are
109 in RELOAD_NONE state.
111 2005-11-28 Federico Mena Quintero <federico@ximian.com>
113 Fix bug #321560, based on a patch by Bogdan Nicula (bogdanni@hotmail.com):
115 * gtk/gtkfilechooserdefault.c (up_folder_handler): Don't add the
116 current_folder to the pending select paths here; the path bar will
118 (path_bar_clicked): Add the child_path to the pending select paths
120 (show_and_select_paths): Don't filter out folders.
121 (show_and_select_paths): Don't take separate arguments for
122 only_one_path and multiple paths.
124 * tests/autotestfilechooser.c (test_folder_switch_and_filters):
125 New test about preserving the filters when we change folders.
127 2005-11-28 Matthias Clasen <mclasen@redhat.com>
129 * gtk/gtkscale.c (_gtk_scale_format_value): Insert an LRM, to prevent
130 -20 to come out as 20- in RTL locales. (#322571, Tze'ela Hebron)
132 * gtk/gtkaction.c (gtk_action_sync_button_stock_id)
133 (connect_proxy): Buttons use the label property for stock ids. (#322565,
136 * gtk/gtkiconview.c (update_text_cell, update_pixbuf_cell): Correctly
137 handle the cell list and indices into it. (#321856)
139 2005-11-28 Matthias Clasen <mclasen@redhat.com>
141 * gtk/gtktooltips.c (gtk_tooltips_timeout): Set timer_tag to 0 when
142 the timeout is done. (#322291, Jean-Yves Lefort)
144 2005-11-28 Matthias Clasen <mclasen@redhat.com>
146 * gtk/gtkfilechooserdefault.c (shortcuts_key_press_event_cb): Make
147 F2 work for renaming bookmarks. (#320822, Jaap A. Haitsma, patch
150 2005-11-28 Tor Lillqvist <tml@novell.com>
152 * gdk/win32/gdkwindow-win32.c (gdk_window_set_urgency_hint):
153 Implement the conditional use of FlashWindowEx() properly for MSVC
154 compilations. The code was confusingly assuming that if compiled
155 with a "new" compiler, it will only be run on "new" Windows
156 versions. We want it to run on "old" versions, too, even if
157 compiled with a "new" compiler. There are two orthogonal issues:
158 whether the compiler defines the necessary API in its headers, and
159 whether it is present at run-time. (#318077)
161 * gtk/gtkcalendar.c (gtk_calendar_init): Use GetLocaleInfo() on
162 Windows to get the localized weekday and month names. strftime()
163 in the Microsoft C library returns strings in the default codepage
164 for the locale of the process, not the system codepage. Thus
165 g_locale_to_utf8() isn't useable on the return value from
166 strftime(). (#322603)
168 2005-11-27 Matthias Clasen <mclasen@redhat.com>
170 * gtk/gtkmessagedialog.c (gtk_message_dialog_new_with_markup):
171 Fix an example. (#322493, Elie De Brauwer)
173 Fix two memory handling problems in GtkTreeView: (#322350,
176 * gtk/gtktreeview.c (gtk_tree_view_destroy)
177 (gtk_tree_view_set_model): Remove all references to nodes in
179 (gtk_tree_view_real_collapse_row): Unmark expanded_collapsed_node
180 before removing the children.
182 * gtk/gtkcolorbutton.c (gtk_color_button_init): Don't leak a
183 PangoLayout here. (#322505, Paolo Borelli)
185 2005-11-27 Tor Lillqvist <tml@novell.com>
187 Once again rework Win32 window decoration code. Doesn't break
188 #104514. The dialogs in gtk-demo now have the same decorations and
189 behaviour as on X11. Tried to fix #322516 but it seems very hard
190 to make the trivial sample program there behave as expected. OTOH,
191 simply moving the gtk_window_decorate() call in the #322516 sample
192 program after the call to gtk_widget_show() helps...
194 * gdk/win32/gdkwindow-win32.c (set_or_clear_style_bits): Revert to
195 the correct semantics. Each call to gdk_window_set_decorations()
196 which calls this function is supposed to affect all decorations.
198 (decorate_based_on_hints): New function, looks at both geometry
199 hints and type hint and sets window decorations based on
200 that. Consolidate code from gdk_window_set_geometry_hints() and
201 gdk_window_set_type_hint() here.
203 (gdk_window_set_geometry_hints, gdk_window_set_type_hint): Call
204 decorate_based_on_hints().
206 2005-11-25 Dom Lachowicz <cinamod@hotmail.com>
208 * modules/engines/ms-windows/*.[ch]: Merge with gtk-wimp's CVS.
209 Includes improved menu icon spacing, [+]/[-] expander drawing,
210 status-bar gippie drawing, and notebook tab drawing.
212 2005-11-24 Michael Natterer <mitch@imendio.com>
214 * gtk/gtktoolbar.h (struct _GtkToolbar): changed two private guint
215 that used to hold signal handler IDs to two guint of padding.
217 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): added them as
220 (gtk_toolbar_screen_changed): changed accordingly.
222 Wed Nov 23 18:55:47 2005 Tim Janik <timj@imendio.com>
224 * gtk/gtkobject.[hc]: deprecated floating/sink API and implemented it
225 in terms of the GObject floating/sink API.
227 * gtk/gtkaboutdialog.c:
233 * gtk/gtkfilechooserdefault.c:
235 * gtk/gtkinvisible.c:
236 * gtk/gtkitemfactory.c:
239 * gtk/gtkmenutoolbutton.c:
243 * gtk/gtkspinbutton.c:
244 * gtk/gtkstatusicon.c:
248 * gtk/gtktoolbutton.c:
252 * gtk/gtktreeviewcolumn.c:
253 * gtk/gtkuimanager.c:
257 ported to use GObject's g_object_ref_sink().
260 * gtk/gtkfilechooserdefault.c:
261 * gtk/gtkaboutdialog.c:
262 fixed compiler warnings.
264 2005-11-23 Matthias Clasen <mclasen@redhat.com>
266 * gtk/gtksettings.c (gtk_settings_class_init): Add some docs
267 about gtk-color-scheme.
269 2005-11-23 Behdad Esfahbod <behdad@gnome.org>
271 * configure.in (enable_explicit_deps): Fix typo when checking
272 libtool config deplibs_check_method. Moreover, enable explicit
273 deps if we get anything other than pass_all from libtool. (part of
276 2005-11-23 Matthias Clasen <mclasen@redhat.com>
278 * gtk/updateiconcache.c (write_csource): Don't create a big
279 string, since Visual C++ doesn't like strings longer than 64k.
280 (#322238, Kazuki IWAMOTO
282 * gtk/gtkentry.c: Include gtkimcontextsimple.h (#322235,
285 2005-11-23 Michael Natterer <mitch@imendio.com>
287 * gtk/gtkrc.c (gtk_rc_reset_widgets): don't leak all toplevel
288 windows on other screens (correctly remove all temporary
291 2005-11-23 Michael Natterer <mitch@imendio.com>
293 Added symbolic themable colors. Patch is a merged version of
294 proposals from Matthias and maemo-gtk. Fixes bug #114355.
296 * configure.in: require glib >= 2.9.1 for refcountable hashtables.
298 * gtk/gtksettings.c: added property "color-scheme" which is a
299 string defining colors like "foreground:black\nbackground:grey".
300 Automatically provide a name->GdkColor hash table mapping for the
303 * gtk/gtkrc.[ch]: added list of color hashes that works like the
304 list of icon factories. Append the color scheme hash from
305 GtkSettings if it exists. Extended gtkrc syntax to allow defining
306 and referencing of logical colors. Also allow to modulate colors
307 in gtkrc by using arbitrary expressions of mix(), shade(),
308 lighter() and darker(). Added internal function
309 _gtk_rc_style_get_color_hashes().
311 * gtk/gtkstyle.[ch]: keep a private list of color hashes around.
312 Get the list from _gtk_rc_style_get_color_hashes(). Export
313 internal function _gtk_style_shade() (used by above color
314 expressions). Added public API gtk_style_lookup_color() which
315 looks up a logical color by name.
317 * gtk/gtk.symbols: add gtk_style_lookup_color
319 * tests/testgtkrc: use symbolic colors for making
322 2005-11-22 Michael Natterer <mitch@imendio.com>
324 Made button-press timeouts which work like key repeat timeouts
325 configurable. Addresses bug #142582:
327 * gtk/gtksettings.c: added properties "gtk-timeout-initial" and
328 "gtk-timeout-repeat" which defalt to 200/20 (ms).
330 Use the values from GtkSettings instead of hardcoding them
331 (the repeat value is either taken as-is for fast repeat or
332 multiplied by 5 for slow repeat). Changed all places to use these
333 two standard initial/repeat timings:
335 * gtk/gtkcalendar.c (unchanged 200/20)
336 * gtk/gtknotebook.c (unchanged 200/100)
337 * gtk/gtkpathbar.c (changed from 300/150 to 200/100)
338 * gtk/gtkrange.c (changed from 250/100 to 200/100)
339 * gtk/gtkspinbutton.c (unchanged 200/20)
341 2005-11-21 Anders Carlsson <andersca@imendio.com>
349 * docs/tools/Makefile.am:
350 Only build docshooter when the X11 backend is used.
352 * gtk/gtkplug-stub.c:
353 Include gtkplug.h here.
355 * gtk/gtksocket-stub.c:
356 Include gtksocket.h here.
358 2005-11-21 Matthias Clasen <mclasen@redhat.com>
360 * gtk/gtkinputdialog.c: Convert GtkInputDialog to
361 g_type_class_add_private.
363 * gtk/gtksocket.c: Convert GtkSocket to g_type_class_add_private.
365 * gtk/gtkmenu.c: Convert GtkMenu to g_type_class_add_private.
368 * gtk/gtkcombobox.[hc]: Add a tearoff-title property,
369 with getter and setter. (#316482, Olexiy Avramchenko)
371 * tests/testcombo.c (main): Test gtk_combo_box_set_title
373 * gtk/gtkpathbar.c: Merge remaining fixes from the 2.8 branch,
374 pointed out by Michael Natterer.
376 Fix for bug #321542, Benedikt Meurer:
378 * gtk/gtkcombobox.c (gtk_combo_box_set_active_internal):
381 (gtk_combo_box_child_show, gtk_combo_box_child_hide): Use
382 g_signal_emit, not g_signal_emit_by_name.
384 2005-11-18 Matthias Clasen <mclasen@redhat.com>
386 Fix crashes in connection with pathbar scrolling (#321560,
389 * gtk/gtkpathbar.c (gtk_path_bar_update_slider_buttons):
390 Stop scrolling when desensitising slider buttons.
391 (gtk_path_bar_scroll_timeout, gtk_path_bar_slider_button_press):
394 * gtk/gtkpathbar.h (struct _GtkPathBar): Add a separate
397 2005-11-18 Matthias Clasen <mclasen@redhat.com>
399 * gtk/gtkpathbar.c (button_clicked_cb): Fix a C99ism.
400 (#321777, Jens Granseuer)
402 * gtk/gtkaction.c (disconnect_proxy): Disconnect the
403 sync callback for the visibility property. (#321761,
406 Turn off input methods in invisible entries, since
407 they are confusing. (#317002, James Su)
409 * gtk/gtkentry.c (gtk_entry_set_visibility): Toggle input
410 methods if visibility changes.
411 (popup_targets_received): Don't show the input method
412 menu if the entry is invisible.
414 2005-11-17 Matthias Clasen <mclasen@redhat.com>
416 * README.in: Add a note about range arrow sensitivity.
418 * perf/treeview.c: const correctness fixes
419 found by Arjan van de Ven and gcc.
421 2005-11-16 Michael Natterer <mitch@imendio.com>
423 * gtk/gtkimage.c (animation_timeout): call
424 gtk_window_process_updates() so the animation keeps running even
425 if the main loop is busy with sources that eat a lot of cpu with
426 high priority. Fixes bug #321444.
428 (gtk_image_new_from_animation): document the fact that the
429 animation will stop running if the main loop is busy with sources
430 that have priorities higher than G_PRIORITY_DEFAULT.
432 * tests/testimage.c: added test case that shows an animation even
433 though a cpu-eating idle function is running.
435 2005-11-16 Michael Natterer <mitch@imendio.com>
437 * gdk/x11/gdkevents-x11.c (_gdk_events_uninit): new internal
438 function which destroys the display's event source. Also removes
439 the source from the global display_sources list and unrefs it.
441 * gdk/x11/gdkprivate-x11.h: declare the function.
443 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_dispose): call it
444 instead of half-destroying the source here.
446 2005-11-15 Matthias Clasen <mclasen@redhat.com>
448 * gtk/gtktreestore.c (gtk_tree_store_move): Fix a memory
449 leak. (#321032, Peter Zelezny)
451 2005-11-15 Michael Natterer <mitch@imendio.com>
453 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_finalize): destroy
454 display->xid_ht as late as possible (right before XCloseDisplay)
455 because it still needs to be around when the display's screens are
458 2005-11-14 Matthias Clasen <mclasen@redhat.com>
460 * gtk/gtkselection.c (gtk_selection_data_set_uris): Don't
461 leak result. (#321441, Tommi Komulainen)
463 2005-11-14 Matthias Clasen <mclasen@redhat.com>
465 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes):
466 Don't crash if there is no builtin icon.
468 2005-11-14 Michael Natterer <mitch@imendio.com>
470 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_set_property):
471 removed redundant calls to g_object_notify().
473 2005-11-13 Matthias Clasen <mclasen@redhat.com>
475 * gdk/gdkcolor.c (gdk_color_parse): Documentation
476 improvements. (#321338)
478 * gtk/gtktextiter.c (gtk_text_iter_forward_search): Make
479 limit an inclusive boundary. (#321299)
481 2005-11-12 Michael Natterer <mitch@imendio.com>
483 * gtk/Makefile.am: fixed icon rules so gtkbuiltincache.h is only
486 2005-11-12 Dom Lachowicz <cinamod@hotmail.com>
488 * modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
489 theme's handling of toolbars, handleboxes, and menubars more in-line
490 with Microsoft's IE style.
491 * modules/engines/ms-windows/*.c: Indentation cleanups
493 2005-11-12 Matthias Clasen <mclasen@redhat.com>
495 Make builtin icons work in gtk_window_set_icon_name()
496 (#321046, Maxim Udushlivy)
498 * gtk/gtkicontheme.c (insert_theme): Always insert the default
500 (ensure_valid_themes): Call _gtk_icon_theme_ensure_builtin_cache()
502 (theme_lookup_icon, find_builtin_icon): ...and not from here.
503 (gtk_icon_theme_lookup_icon): Remove an unncessary assert.
504 (gtk_icon_theme_get_icon_sizes): Also check builtin icons.
506 2005-11-12 Tor Lillqvist <tml@novell.com>
508 * gtk/gtkfilesystemwin32.c (filename_get_info): Don't hide
509 dotfiles, no such convention on Win32. Just hide files with the
510 hidden attribute. (#314627)
512 2005-11-11 Federico Mena Quintero <federico@ximian.com>
514 * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Do not
515 check whether the path is a folder. It is useful to bookmark
516 files as well (e.g. todo.txt), and this will also help
518 (shortcuts_add_bookmark_from_path): Likewise.
519 (shortcuts_activate_iter): Change folders or select files, as
522 2005-11-11 Federico Mena Quintero <federico@ximian.com>
524 * tests/autotestfilechooser.c (main): Use
525 g_log_set_default_handler() instead of explicitly setting a
526 handler for each domain.
528 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Only get
529 the base path of the volume if it is mounted.
531 2005-11-11 Michael Natterer <mitch@imendio.com>
533 Added per-stepper API for GtkRange's stepper sensitivity as
534 discussed in bug #321056:
536 * gtk/gtkenums.h: added GtkSensitivityType which can be
539 * gtk/gtkrange.[ch]: added properties "lower-stepper-sensitivity"
540 and "upper-stepper-sensitivity" and public getters/setters for
541 them. Changed stepper drawing to honor the new properties.
543 * gtk/gtk.symbols: added the new symbols.
545 2005-11-10 Matthias Clasen <mclasen@redhat.com>
547 * gtk/gtkcombobox.c: Add show-popup and hide-popup signals and
548 emit them when the popup is shown or hidden. (#162531, Tommi
551 * tests/testcombo.c: Add an example of popuplating a combobox
554 * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Another
557 * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
560 Don't corrupt odd keymaps (#316638, Kean Johnston)
562 * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
563 handle frobbing keymaps with odd numbers of syms/code.
565 * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
568 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
570 * gtk/gtkpathbar.[hc]: Add a child_path argument to
571 the path_clicked signal.
572 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
573 child_path, if it is provided.
574 * gtk/marshalers.list (path_bar_clicked): Add the necessary
577 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
582 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
583 (#163851, Richard Hult)
585 2005-11-10 Michael Natterer <mitch@imendio.com>
587 Applied patch from maemo-gtk that addresses many issues wrt
588 display migration and display closing (bug #85715).
590 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
591 default display to NULL when it's closed. Instead set the most
592 recently opened display as new default (if one exists).
594 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
597 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
598 exist before unrefing them.
600 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
601 is closed, allow destruction of the root window.
603 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
604 dispose(), free stuff that was leaked before.
606 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
607 the xsettings_client still exists before destroying it.
609 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
612 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
613 dispose() implementation.
615 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
616 dispose() and check if it still exists before unrefing it. Set
617 their pointers to NULL/None *after* upchaining in dispose(),
618 because X11 implementations of members of the parent class still
619 need them for their own destruction.
621 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
622 was g_error()ing when finalizing a visual.
624 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
625 get_clipboard_widget() because it would create the widget if it
626 doesn't exist. Use g_object_get_data() directly instead.
628 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
631 2005-11-10 Simos Xenitellis <simos@gnome.org>
633 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
635 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
637 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
638 to render its arrows insensitive when the adjustment is in
639 its min or max position. this makes range arrow behaviour
640 consistent with spin button behaviour. (#321056)
642 2005-11-09 Tor Lillqvist <tml@novell.com>
645 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
646 the GdkDebugFlag enum.
648 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
649 this file instead of MISC. Now asking for MISC will give mainly
650 window manipulation debugging output with the Win32 backend.
652 2005-11-09 Tor Lillqvist <tml@novell.com>
654 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
656 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
657 function which was used only in one place.
659 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
661 (gdk_window_set_geometry_hints): If we have identical minimum and
662 maximum size hints, remove the resize and maximize
663 decorations/functions. (#104514)
665 If we have a maximum size hint, remove the maximize
666 decoration/function but ensure the resize decoration/function is
667 available. Otherwise ensure both resize and maximize
668 decorations/functions are there.
670 (set_or_clear_style_bits): Factored out common code from
671 gdk_window_set_decorations() and gdk_window_set_functions().
673 Hack the window style setting once more: Only touch the window
674 style bits corresponding to the GdkWMDecoration or GdkWMFunction
675 parameter bitmasks. Hopefully this finally is the correct thing to
676 do. We used to clear all other bits than those that were being
677 set, or set all other bits than those that were being cleared.
679 Take into account that adding or removing decorations leaves the
680 window's outer size unchanged, i.e., the client area's size and
681 position change. This is apparently not what we want, so change
682 also the window's (outer) position and size appropriately so that
683 the client area's position and size stay constant.
685 gtk-demo's color selector dialog is now non-resizable like on X11
686 (I tested with metacity in GNOME). Torn off menus are shrinkable
687 vertically but have a maximum size, and are not maximizable or
688 minimizable, like on X11.
690 (gdk_window_set_decorations, gdk_window_set_functions): Let
691 set_or_clear_decorations() do most of the job.
693 * gdk/win32/gdkprivate-win32.h: Remove declaration of
694 _gdk_win32_get_adjusted_client_rect().
696 2005-11-09 Tor Lillqvist <tml@novell.com>
698 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
699 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
700 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
701 type hint. Implement gdk_window_get_type_hint() by just returning
704 2005-11-09 Tor Lillqvist <tml@novell.com>
706 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
707 Remove code that has been permanently ifdeffed out for two years.
709 2005-11-08 Matthias Clasen <mclasen@redhat.com>
711 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
712 finalizing a gc. (#320789, Nickolay V. Shmyrev)
714 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
715 icons if they would make the request large enough to cause
716 Xlib to loose the connection. (#320909, Claudio Saavedra)
718 2005-11-08 Michael Natterer <mitch@imendio.com>
722 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
723 extracted from maemo-gtk). Fixes bug #320872.
725 2005-11-07 Matthias Clasen <mclasen@redhat.com>
727 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
728 looks the bookmark label when reordering. (#320720, Jeremy Cook)
730 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
731 Don't grab focus when a slider button is pressed, instead, use
732 a bit in the pathbar struct to determine whether to scroll up
733 or down. (#314486, Carlos Garnacho)
735 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
736 Don't popup the completions if the focus has already been
737 moved somewhere else. (#319914, Christian Persch)
739 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
740 Raise the drag_window after reconfiguring the
741 toolbar. (#320803, Christian Persch)
744 * gtk/gtkfilechooserbutton.h:
745 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
746 with setter and getter. (#318945, Christian Persch)
748 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
750 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
752 2005-11-07 Matthias Clasen <mclasen@redhat.com>
754 * configure.in: Adjust to the stock icon changes.
756 2005-11-07 Tor Lillqvist <tml@novell.com>
758 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
759 Correct the calculation of maskstride. (#320152, Peter Zelezny)
761 2005-11-06 Michael Natterer <mitch@imendio.com>
763 * gtk/Makefile.am (icons): fixed rule to actually create the
764 symlinks, erroring out if anything goes wrong.
766 2005-11-06 Tor Lillqvist <tml@novell.com>
768 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
769 target exists on Win32. First rename the target temporarily, then
770 if the renaming of the source to target fails, restore the
771 original name for the target.
773 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
775 2005-11-06 Tor Lillqvist <tml@novell.com>
777 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
778 like pixbuf_to_hbitmaps_normal().
779 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
780 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
781 setting the G_WIN32_PRETEND_WIN9X environment variable.
783 2005-11-06 Tor Lillqvist <tml@novell.com>
785 Make icon masks work on Win98 (#320152, Peter Zelezny)
787 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
788 parameter for the depth of the bitmap, so that this function can
789 be used to create 1-bit bitmaps, too.
790 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
791 and initialize it properly.
793 2005-11-04 Matthias Clasen <mclasen@redhat.com>
795 Store builtin stock icons in an icon cache, instead of
796 populating a hash table with pixbufs at startup, to save both
797 memory and startup time.
799 * gtk/stock-icons/*: Reorganize the icons in a directory structure
800 suitable for gtk-update-icon-cache, and rename them to match the
803 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
804 add _gtk_icon_cache_has_icon_in_directory().
806 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
807 to store the contents of the icon cache in a C header.
809 * gtk/gtkbuiltincache.h: Generated private header which contains
810 the icon cache for the builtin icons.
812 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
813 icons, and use that in addition to the hash table whenever
814 builtin icons are searched.
816 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
817 use it for static stock ids.
818 (get_default_icons): Don't add the builtin
819 icons to the icon theme, just register the stock ids.
820 (render_fallback_image): Take the fallback image out of the
823 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
824 the necessary machinery to rebuild gtkbuiltincache.h.
826 2005-11-04 Michael Natterer <mitch@imendio.com>
828 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
829 from maemo-gtk that changes the mtime check for rc files from
830 '>' to '!=', otherwise theme changes go unnoticed when turning
831 back the clock (Tommi Komulainen).
833 2005-11-04 Tor Lillqvist <tml@novell.com>
835 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
838 2005-11-03 Tor Lillqvist <tml@novell.com>
840 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
841 the Win32 backend, check that GdkDisplay* parameters are equal to
842 _gdk_display instead of using the unnecessarily general
845 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
846 color bitmap to have "color" in their name, for similarity with
847 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
848 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
849 the mask bitmap's contents, ones for those pixels in the color
850 bitmap where the alpha is zero, zero for other pixels. We used to
851 use an uninitialized mask bitmap! This meant that icons and
852 cursors created presumably worked more or less by accident.
853 Totally blank icons with zero alpha everywhere (as used by
854 gtktrayicon.c) definitely did not work as expected.
856 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
858 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
859 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
860 necessary and can be removed from CVS. It has never been mentioned
861 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
862 are used on Win32. One label widget is used (but never shown) as
863 gtk_widget_render_icon() needs a widget.
865 Ifdefs used as necessary in several places. It might be cleaner to
866 split out the backend-specific parts to separate files, or at
867 least collect them into separate blocks in the file.
869 (wndproc): New function. Window procedure to monitor mouse events
870 in the system tray icon. Call gtk_status_icon_button_press() as
872 (create_tray_observer): New function. Creates a hidden window that
873 only serves as a tray icon message observer.
875 * tests/teststatusicon.c (icon_activated): Position the dialog
876 with GTK_WIN_POS_CENTER.
877 (do_quit): New function, hide and unref the GtkStatusIcon, and
878 call gtk_main_quit().
879 (popup_menu): Add a Quit menu item that calls do_quit().
881 2005-11-02 Tor Lillqvist <tml@novell.com>
883 * gdk/win32/gdkcolor-win32.c
884 * gdk/win32/gdkscreen-win32.c
885 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
886 fixes. Remove superfluous test for GdkWindow* parameters being
887 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
888 GdkScreen and one GdkDisplay in the Win32 backend, use those
889 variables instead of the getter functions. For GdkDisplay* and
890 GdkScreen* parameters, check that they are equal to the
891 corresponding singleton variables instead of the more general
892 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
894 2005-11-02 Matthias Clasen <mclasen@redhat.com>
896 * gtk/gtktextview.c: Remove some g_return_if_fail() from
897 static functions, replace some others by g_assert().
899 * gtk/gtktextview.c (selection_motion_event_handler)
900 (gtk_text_view_start_selection_drag): Keep track of the original
901 selection boundaries during a drag selection, in order to correctly
902 decide when to extend or shrink the selection. (#320167,
903 reported by Arvind S N, patch by Paolo Borelli)
905 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
906 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
907 manual offset calculations by g_utf8_offset_to_pointer().
908 (#320360, Paolo Borelli)
910 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
912 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
913 nodes via the g_slice_*() API.
914 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
916 2005-11-01 Tor Lillqvist <tml@novell.com>
918 * gdk/win32/gdkprivate-win32.h
919 * gdk/win32/gdkglobals-win32.c
920 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
921 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
922 their declarations, definitions and assignments into a more
923 logical and consistent order.
925 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
926 CF_ prefix for the predefined clipboard format names. Put quotes
927 around registered format names to distinguish them.
929 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
930 immediately with a warning if the property type is STRING, TEXT,
931 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
932 should never pretend to handle on Win32. Handle only UTF8_STRING
933 here, other formats with delayed rendering. Use \uc1 instead of
934 \uc0 when generating Rich Text Format for easier testability on
935 XP, where WordPad misinterprets \uc0 encoded characters. Add more
936 GDK_NOTE debugging output for Clipboard operations.
938 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
939 (gdk_selection_convert): Don't pretent to handle STRING, just
940 UTF8_STRING. Streamline error handling, don't unnecessarily have a
941 GError which then isn't used for anything anyway if it gets set.
942 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
943 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
945 * config.h.win32.in: Sync with what configure produces.
947 * configure.in: Don't look for X_PACKAGES unless building for
948 x11. (#313986, John Ehresman)
950 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
952 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
953 Wondered why there was no ku there before??
955 2005-10-28 Matthias Clasen <mclasen@redhat.com>
957 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
958 window to the toplevels window group. (#319912, Christian Persch)
960 2005-10-28 Kristian Rietveld <kris@gtk.org>
962 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
965 2005-10-28 Matthias Clasen <mclasen@redhat.com>
967 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
968 drag cursors. (#319200, Federico Mena Quintero)
970 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
971 Shift-G to go to the previous match, like firefox. (#320061, Christian
974 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
975 C99ism. (#320000, Kazuki Iwamoto)
977 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
978 stars. (#319985, Bastien Nocera)
980 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
981 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
983 2005-10-26 Michael Natterer <mitch@imendio.com>
987 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
988 make sure that setting any of pixbuf/stock-id/icon-name resets the
989 others because they are mutually exclusive, and that unsetting any
990 of them only resets the pixbuf and nothing else. Also added
991 some missing g_object_notify().
993 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
994 g_value_set_object().
996 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
997 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
998 g_object_notify ("pixbuf").
1000 2005-10-27 Matthias Clasen <mclasen@redhat.com>
1002 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
1003 careful about initializing cell_area. (#319382, Tommi
1006 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
1007 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
1009 * demos/gtk-demo/clipboard.c (paste_received): Only set the
1010 text if it is not NULL. (#319930, Thomas Klausner)
1012 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
1013 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
1015 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1017 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
1018 * gtk/gtkthemes.c (gtk_theme_engine_load):
1019 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
1020 when dlopening modules. (#319557, Laszlo Peter)
1022 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1024 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
1025 segments when determining text direction. (#319065, Tommi Komulainen)
1027 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
1028 on duplicate destroy. (#318953, Gustavo Carneiro)
1030 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
1031 Point out that destroy-with-parent is a bad idea for the dialog
1032 passed to this function. (#318943, Christian Persch)
1034 * */Makefile.am: use $(GLIB_MKENUMS) instead of
1035 glib-mkenums. (#318582, Damien Carbery)
1037 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
1038 docs. (#317682, Christian Neumair)
1040 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
1041 seem to affect the placement of the data in the readonly
1042 section, and causes problems with some compilers. (#317844)
1044 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1046 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
1047 Fix some issues with background drawing in RTL. (#318781,
1050 * tests/Makefile.am:
1051 * tests/testentrycompletion.c: Apply a patch by Christian
1052 Persch to add property editors.
1054 * gtk/gtkstatusicon.c: Emit activate on single-click,
1055 not on double-click, change proposed by Milosz Derezynski.
1057 2005-10-25 Kristian Rietveld <kris@gtk.org>
1059 Fixes #311955, reported by Markku Vire; and a lot more.
1061 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
1062 Levels can now have invisible nodes cached, functions have been
1063 rewritten/refactored to take this into account; also the logic in
1064 some functions has been corrected.
1066 Each referenced node now references all visible children or a single
1067 invisible child, in order to be able to monitor all changes in the
1068 child model required for correct operation.
1070 When a virtual root is set, all nodes on the virtual root level are
1073 At last, a bunch of random bug fixes and comment updates.
1075 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1077 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
1078 more docs. (#319722, Paolo Borelli)
1080 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
1081 initialization of screen_x11->xft_rgba more explicit. (#319627,
1084 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
1085 in a blurb. (#319499, Francisco Javier F. Serrador)
1087 2005-10-24 Matthias Clasen <mclasen@redhat.com>
1089 Add settings to hide the input method and Unicode control character
1090 submenus in the context menus of GtkEntry and GtkTextView.
1092 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
1094 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
1096 * gtk/gtktextview.c (popup_targets_received):
1097 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
1099 2005-10-24 Kristian Rietveld <kris@gtk.org>
1101 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
1102 row-has-child-toggled when the level is not in the cache does not
1103 make sense. (This bug probably crept in during the early stages
1104 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
1105 implementation yet),
1106 (gtk_tree_model_sort_real_unref_node): only get the child iter
1107 when we will actually also use it.
1109 2005-10-22 Michael Natterer <mitch@imendio.com>
1111 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
1112 widget being realized, in addition to being visible, to avoid
1113 running into precondition check in gtk_tree_view_get_cell_area().
1116 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
1118 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
1119 Experimentally, scrollbar steppers can shrink to 8 pixels on
1120 Win32. Reflect that in the theme.
1121 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
1122 there is a 1-pixel border between a scrollbar and its child
1123 in ScrolledWindows on Win32. Reflect that in the theme.
1125 2005-10-20 Matthias Clasen <mclasen@redhat.com>
1127 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
1128 for the selection window. (#318806, Alex Larsson)
1130 2005-10-18 Federico Mena Quintero <federico@ximian.com>
1134 * tests/autotestfilechooser.c
1135 (test_button_folder_states_for_action): Test that we have either
1136 $cwd or the explicitly-set folder.
1137 (test_reload_sequence): Likewise.
1139 * gtk/gtkfilechooserdefault.c
1140 (gtk_file_chooser_default_get_current_folder): If our reload_state
1141 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
1143 2005-10-14 Tor Lillqvist <tml@novell.com>
1145 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
1146 It didn't really do anything useful, and was just confusing and
1147 incomplete. Comments claimed we don't do delayed rendering, but in
1148 fact we do, for images. (The delayed rendering code has other
1149 problems, though, see #168173.) The clipboard viewer code was
1150 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
1151 the message when necessary). It was just test code, it said so in
1152 a comment. Add something similar back later if necessary.
1154 (_win32_on_clipboard_change,
1155 _gdk_win32_register_clipboard_notification): Remove.
1157 (gdk_display_supports_selection_notification,
1158 gdk_display_request_selection_notification): Always just return
1159 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
1161 2005-10-13 Tor Lillqvist <tml@novell.com>
1163 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
1164 Alt-Enter specially. It does not have any special meaning and
1165 should be passed on to the application. (#318378, Tim Evans)
1167 2005-10-13 Tor Lillqvist <tml@novell.com>
1169 Set visual depth to 24 for 32 bits-per-pixel devices on
1170 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
1171 optimized composite_0888() function rather than the slower image
1172 dithering functions to draw pixbufs (#313993, John Ehresman)
1174 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
1175 _gdk_windowing_get_bits_for_depth() to initialize
1176 GdkImage::bits_per_pixel.
1177 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
1179 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
1180 _gdk_windowing_get_bits_for_depth() to initialize
1181 BITMAPINFOHEADER::biBitCount.
1183 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
1184 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
1187 2005-10-12 Stefan Kost <ensonic@users.sf.net>
1189 * demos/gtk-demo/appwindow.c: (about_cb):
1190 use PACKAGE_VERSION,bump year (#318654)
1192 2005-10-11 Matthias Clasen <mclasen@redhat.com>
1194 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
1195 toggle here with the matching on toggle if it immediately follows.
1196 This is a common case, and handling it here prevents quadratic blowup
1197 in cleanup_line() below. (#317125)
1199 * gtk/gtktextsegment.h:
1200 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
1201 the character counts into this function instead of computing them
1204 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
1206 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
1208 * gtk/gtkfilechooserdefault.c
1209 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
1210 when the shortcut already exists in the sidebar. (#147521)
1212 2005-10-09 Matthias Clasen <mclasen@redhat.com>
1214 * tests/testcombo.c: Demonstrate how to use custom widgets in
1217 2005-10-07 Federico Mena Quintero <federico@ximian.com>
1221 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
1222 the the result of gtk_file_chooser_get_folder() is NULL or
1223 non-NULL at the right times. Log the tests.
1224 (test_button_folder_states): New test for the initial states of
1225 the current folder in GtkFileChooserButton.
1226 (main): Test that the number of warnings/errors/critical errors is
1229 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
1230 Clarify the documentation on when this can return NULL.
1231 (gtk_file_chooser_get_current_folder_uri): Likewise.
1233 * gtk/gtkfilechooserbutton.c (struct
1234 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
1235 we use it to keep track of whether a folder has been set.
1236 (gtk_file_chooser_button_map): Implement. If no folder has been
1237 loaded before, we at least try to load $cwd here.
1238 (gtk_file_chooser_button_constructor): If the construct-time
1239 dialog already has a folder set, turn on our folder_has_been_set
1241 (dialog_current_folder_changed_cb): Turn on our
1242 folder_has_been_set flag.
1244 2005-10-07 Michael Natterer <mitch@gimp.org>
1246 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
1247 PROFILE_FILE_CHOOSER because they break compilation after the
1248 removal of <unistd.h>.
1250 2005-10-07 Matthias Clasen <mclasen@redhat.com>
1252 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
1253 by moving it out of the profiling ifdef.
1255 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
1256 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
1258 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
1259 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
1262 2005-10-06 Matthias Clasen <mclasen@redhat.com>
1265 * gtk/gtktextbuffer.h:
1266 * gtk/gtktextbuffer.c: Add a readonly has-selection property
1267 with a getter. (#318161, Paolo Borelli)
1269 2005-10-05 Matthias Clasen <mclasen@redhat.com>
1271 * README.in: Start collecting release notes for 2.10.
1273 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
1274 leak fix, since the assertion failures were traced to
1275 an xchat bug. (#314696)
1277 * gtk/gtkstyle.c (gtk_style_detach):
1278 (gtk_style_attach): Documentation improvements.
1279 (gtk_style_detach): Assert that the attach_count is > 0.
1281 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1283 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
1284 shortcut position, not a ShortcutsIndex, to make the function more
1286 (home_folder_handler): Pass the resolved index to
1287 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
1288 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
1289 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
1290 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
1291 make the respective key switch to the first, second, ..., tenth
1293 (quick_bookmark_handler): Implement.
1295 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1297 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
1298 Desktop; just use their real names on the file system for the
1301 * gtk/gtkfilechooserdefault.c
1302 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
1303 binding signal, and bind it to M-d by default.
1304 (desktop_folder_handler): Implement the default handler.
1305 (home_folder_handler): Use a helper function.
1306 (switch_to_shortcut): New helper function.
1307 (shortcuts_append_home): Don't special-case the name of "Home";
1308 just use the folder name.
1310 2005-10-04 Tor Lillqvist <tml@novell.com>
1312 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
1313 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
1315 2005-10-04 Matthias Clasen <mclasen@redhat.com>
1317 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
1318 from yesterday, since it leads to assertion failures. (#317879,
1321 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1323 * gtk/gtkcalendar.c (gtk_calendar_init): Call
1324 calendar_compute_days() after setting priv->week_start.
1326 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1328 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
1329 removing it from the hash table. (#314696, Benjamin Berg)
1331 2005-10-01 Tor Lillqvist <tml@novell.com>
1333 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
1334 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
1335 is that the the desktop isn't visible because the session has been
1336 switched, the screen is locked, or a terminal server session
1337 disconnected, so no error message necessary. (#137796)
1339 It is of course remotely possible that BitBlt() failing with
1340 ERROR_INVALID_HANDLE might also be caused by some other
1341 problem. We could strive for perfection and track whether the
1342 desktop is visible by using WTSRegisterSessionNotification() and
1343 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
1344 this issue, though. If we would track desktop visibility, we
1345 should then avoid even trying to update the display at all while
1346 the desktop isn't visible.
1348 2005-09-30 Matthias Clasen <mclasen@redhat.com>
1350 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
1351 to correct the calculations for the first week day. We may
1352 just have to remove this code if too many locales turn out
1353 to have broken data.
1355 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
1356 some cases. (#317611, Tommi Komulainen)
1358 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
1359 Prevent overflow when storing size hints in an unsigned
1360 short variable. Tracked down by Ray Strode and Søren Sandmann.
1362 2005-09-29 Matthias Clasen <mclasen@redhat.com>
1364 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
1367 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
1368 grab shadowed. (#317332)
1370 2005-09-29 Tor Lillqvist <tml@novell.com>
1372 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
1374 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1376 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
1377 if the unmap test fails.
1378 (test_reload_sequence): Use gtk_widget_show_now() instead of
1379 gtk_widget_show() for the dialog.
1380 Thanks to Tim Janik for noticing these.
1382 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1384 * tests/testcellrenderertext.c: New file with a set of tests for
1385 GtkCellRendererText. The idea is to run a text renderer through
1386 most of its interesting property values to see that it works
1389 * tests/Makefile.am: Added testcellrenderertext.
1391 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
1392 entry/exit of this function for profiling.
1393 (gtk_file_chooser_default_style_set): Mark the start/end of the
1394 calls to the parent class and the the signal emission for profiling.
1396 2005-09-29 Tor Lillqvist <tml@novell.com>
1398 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
1399 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
1400 system codepage using g_win32_locale_filename_from_utf8().
1401 (#317457, Kazuki Iwamoto)
1403 2005-09-28 Matthias Clasen <mclasen@redhat.com>
1405 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
1406 here. (#317039, Paolo Borelli)
1409 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
1410 to make this function work as boxed copy function. (#317455,
1413 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
1414 NULL. (#316828, Tor Lillqvist)
1416 2005-09-28 Tor Lillqvist <tml@novell.com>
1418 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
1421 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1423 Don't reload the current folder unnecessarily on ::map().
1425 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
1426 the reloading state.
1427 (struct _GtkFileChooserDefault): Added a "reload_state" field.
1429 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
1430 Initialize impl->reload_state.
1431 (gtk_file_chooser_default_map): Check the impl->reload_state; load
1432 a default folder if no folder has been set, or reload the current
1433 one only if we had been unmapped first.
1434 (gtk_file_chooser_default_update_current_folder): Set the
1435 reload_state to RELOAD_HAS_FOLDER.
1436 (gtk_file_chooser_default_unmap): Implement, and set the
1437 reload_state to RELOAD_WAS_UNMAPPED.
1438 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
1439 here; they'll get (re)loaded on ::map() anyway.
1441 * gtk/gtkfilechooserwidget.c
1442 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
1444 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
1445 a dialog; build it ourselves.
1446 (test_reload): New test to ensure that we don't load the default
1447 folder more than once, and that we reload it when
1448 unmapping/remapping.
1449 (get_impl_from_dialog): New utility function.
1450 (test_widgets_for_current_action): Use get_impl_from_dialog().
1452 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1454 * gtk/gtkfilechooserdefault.c
1455 (gtk_file_chooser_default_constructor): Mark the entry/exit of
1456 this function for profiling.
1457 (check_icon_theme): Likewise.
1458 (change_icon_theme): Likewise.
1459 (settings_notify_cb): Likewise.
1460 (gtk_file_chooser_default_screen_changed): Likewise.
1461 (update_chooser_entry): If the selection is empty, clear the file
1462 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
1463 nothing will be selected when the user starts typeahead in the
1464 treeview, and we don't want to clear the file name entry in that
1465 case --- the user could be typing-ahead to look for a folder name.
1466 Fixes bug #308332, patch by Jürg Billeter.
1468 2005-09-27 Matthias Clasen <mclasen@redhat.com>
1470 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1471 Pop below the entry if there's more free space below the entry
1472 than above. (#316948, Tommi Komulainen)
1474 2005-09-26 Federico Mena Quintero <federico@ximian.com>
1476 Do not create the save mode-specific widgets in the open modes, so
1477 that we don't carry their baggage around.
1479 * gtk/gtkfilechooserdefault.c
1480 (gtk_file_chooser_default_constructor): Don't create the
1482 (save_widgets_create): Set the impl->save_widgets directly here,
1483 instead of passing the widgets back to the caller. Also, pack
1484 them into the impl's box.
1485 (update_appearance): Create or destroy the save widgets as
1486 appropriate. Set the action of the save_file_name_entry here.
1487 (shortcuts_add_current_folder): Set the active item in the
1488 save_folder_combo only if it exists.
1489 (gtk_file_chooser_default_set_property): Don't set the action of
1490 the save_file_name_entry here.
1491 (gtk_file_chooser_default_update_current_folder): Set the base
1492 folder of the save_file_name_entry only if the entry exists.
1493 (shortcuts_drag_data_received_cb): Cast the selection_data->data
1494 to (const char *) since that's what shortcuts_drop_uris() expects.
1495 (file_list_drag_data_received_cb): Likewise, for
1496 g_uri_list_extract_uris().
1498 2005-09-26 Tor Lillqvist <tml@novell.com>
1500 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
1501 the shaped flag here, too. (#316871)
1502 (gdk_window_shape_combine_region): Currently unimplemented, so
1503 don't do anything to the shaped flag here.
1505 2005-09-26 Matthias Clasen <mclasen@redhat.com>
1507 Fix #316871, reported by Dan Winship:
1509 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
1511 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
1512 (gdk_window_shape_combine_region): Set it here.
1514 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
1515 remove the child area for shaped windows.
1517 2005-09-23 Matthias Clasen <mclasen@redhat.com>
1519 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
1520 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
1522 2005-09-22 Michael Natterer <mitch@imendio.com>
1524 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
1525 consistent with GTK+ terminology:
1527 * gtk/gtkcellrendererkeys.[ch]
1528 * tests/testkeys.c: removed...
1530 * gtk/gtkcellrendereraccel.[ch]
1531 * tests/testaccel.c: ...and added.
1536 * tests/Makefile.am: changed accordingly.
1538 2005-09-22 Matthias Clasen <mclasen@redhat.com>
1540 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
1541 for the grab-broken-event signal, noticed by Damon Chaplin.
1543 2005-09-21 Tor Lillqvist <tml@novell.com>
1545 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
1546 gdk_text_property_to_text_list_for_display,
1547 gdk_text_property_to_utf8_list_for_display,
1548 gdk_win32_selection_add_targets,
1549 _gdk_win32_selection_convert_to_dib): Free return value from
1551 (gdk_text_property_to_text_list_for_display): Drop GError variable
1552 that isn't actually used after being set.
1554 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
1556 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
1559 2005-09-20 Tor Lillqvist <tml@novell.com>
1561 * gdk/win32/gdkselection-win32.c
1562 (gdk_selection_owner_get_for_display): Do return the correct owner
1563 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
1564 a window GDK knows about). The reason to return NULL seems to have
1565 gone when in the fix for bug #163702 the artificial
1566 GDK_SELECTION_CLEAR event generation was removed from
1567 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1569 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1571 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1572 events. (#151555, Søren Sandmann)
1574 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1575 XkbSelectEventDetails() to select XkbStateNotify events
1576 for only the state we care about.
1578 * gdk/x11/gdkprivate-x11.h:
1579 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1580 the event into the function and update the keymap state from
1581 the state information contained in the event. Adjust all callers.
1583 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1585 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1586 in multiple places to avoid segfaults if the index is out of range.
1587 (#316422, Guillaume Cottenceau)
1588 (gtk_icon_view_set_drag_dest_item):
1589 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1590 #316424, Guillaume Cottenceau)
1592 2005-09-18 Hans Breuer <hans@breuer.org>
1594 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1595 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1597 2005-09-18 Hans Breuer <hans@breuer.org>
1599 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1600 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1601 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1602 the icon and is blinking with teststatusicon. More to come ...
1604 2005-09-18 Hans Breuer <hans@breuer.org>
1606 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1607 cause gtkprogressbar.c has #include <config.h> conditionally; less
1608 noise from generated gtk.def
1609 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1611 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1612 For me it works as well as the *NIX implemenation, that is not at all.
1614 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1616 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1617 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1618 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1619 again - if compiled properly.
1621 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1622 already coming with Gtk+. Makes it compile on win32.
1624 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1626 * README.cvs-commits: fixed some tiny typos
1628 2005-09-16 Tor Lillqvist <tml@novell.com>
1630 * modules/engines/ms-windows/msw_style.c (draw_extension,
1631 draw_box_gap): Check whether the widget actually is a GtkNotebook
1632 before treating it as such. Drop some unneeded local variables,
1633 use parameter with same information instead. (#316412)
1635 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1637 * tests/autotestfilechooser.c: Start a set of automated tests for
1638 the file chooser. The only test in there right now doesn't pass
1639 yet. It specifies the intended behavior of the first optimization
1640 of a series which I'll do on the file chooser (see
1641 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1642 details of this optimization).
1644 * tests/Makefile.am: Added autotestfilechooser.c.
1646 * gtk/gtkfilechooserprivate.h (struct
1647 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1648 structures to here, so that they can be accessed by
1649 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1650 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1652 * gtk/gtkfilechooserdialog.c: See above.
1654 * gtk/gtkfilechooserwidget.c: See above.
1656 * gtk/gtkfilechooserdefault.c: See above.
1658 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1661 gtk_window_map_event(): new function to work around lost unmap requests.
1664 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1666 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1667 an easy-to-find profiling marker when starting to create a file
1669 (browse_files_model_finished_loading_cb): Likewise, for when the
1670 chooser is finished loading.
1672 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1674 * gtk/gtkcolorbutton.c: Check "color" argument in
1675 gtk_color_button_set_color ()
1677 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1679 * gtk/gtklabel.c (gtk_label_get_type):
1680 * gtk/gtkbutton.c (gtk_button_get_type):
1681 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1682 using a mem chunk for window groups, buttons, labels.
1684 * gtk/updateiconcache.c (foreach_remove_func): Fix
1685 a use-after-free bug. (#316256, Alexander Nedotsukov)
1687 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1689 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1691 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1693 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1695 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1696 Let GDK_Return pass through in some more cases.
1698 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1699 activating the entry.
1701 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1702 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1703 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1705 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1706 (#316001, Guillaume Cottenceau)
1708 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1709 mistake in the docs. (#315993, Guillaume Cottenceau)
1711 * tests/testentrycompletion.c (create_simple_completion_model): Add
1712 some strings containing multibyte characters.
1714 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1715 Fix prefix insertion for multibyte characters. (#316095,
1718 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1719 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1720 return NULL if the widget is not realized. (#316023,
1721 Guillaume Cottenceau)
1723 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1726 * gdk/gdkproperty.h:
1727 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1728 New function to avoid pointless strdups when creating atoms
1729 from static strings.
1732 * gtk/*.c: Use gdk_atom_intern_static_string() where
1735 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1737 * gtk/gtkcellrendererkeys.h:
1738 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1739 and editing accelerators, a port of EggCellRendererKeys .
1743 * gtk/Makefile.am: Add the keys cell renderer.
1745 * tests/Makefile.am:
1746 * tests/testkeys.c: Test GtkCellRendererKeys
1748 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1750 Make it possible to determine if a key event is for a
1753 * gdk/x11/gdkprivate-x11.h:
1754 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1755 New function to determine if a keycode is mapped to a modifier.
1756 (get_xkb): Get the modmap.
1758 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1759 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1761 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1764 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1766 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1767 unused variable, noticed by Kjartan Maraas.
1769 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1771 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1772 Make drag reordering work properly for columns other than the
1773 first. (#315054, Dan Winship)
1775 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1776 invalid fontnames better. (#136926, Michael R. Walton)
1778 Stop cursor blinking in non-editable regions of a text view.
1779 (#311508, Torbjörn Andersson)
1781 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1782 (cursor_blinks): Take editability into account when deciding
1783 whether the cursor blinks.
1784 (gtk_text_view_button_release_event):
1785 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1787 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1788 Use connect_after to connect to the focus_out event. This
1789 ensures that the entry has already stopped blinking by the time
1790 we emit the edited signal. (#315229, Thomas Leonard)
1792 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1794 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1795 unsigned ints to -1. (#315481, Kjartan Maraas)
1797 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1798 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1799 (#314473, Stanislav Brabec)
1801 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1803 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1804 memory handling. (#314975, Torsten Schoenfeld)
1806 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1807 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1808 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1809 * gtk/gtklabel.c (gtk_label_class_init):
1810 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1811 Stylistic improvements and clarifications for some blurbs.
1812 (#315520, Clytie Siddall)
1814 2005-09-09 Tor Lillqvist <tml@novell.com>
1816 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1817 display name. There is only one GdkDisplay on Win32, and
1818 constructing the display name isn't entirely trivial, so cacheing
1819 is probably worth it. For instance GIMP calls this function a lot.
1820 (gdk_display_open): Call gdk_display_get_name() to prime the
1822 (gdk_display_get_n_screens, gdk_display_get_screen,
1823 gdk_display_get_default_screen): Verify parameter correctness like
1824 the X11 backend does.
1826 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1827 Return a freshly allocated string, as the API specifies. Fixes a
1828 heap corruption problem that caused random errors and crashes in
1831 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1833 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1834 Make C-u commit and restart hex input if we are already in a
1837 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1839 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1840 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1841 if they are mapped to the same modifier.
1843 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1844 to gtkstatusicon.c and gtktrayicon-x11.c
1846 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1847 default accel mod mask.
1849 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1850 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1851 Don't use GDK_ALT_MASK.
1853 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1855 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1857 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1859 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1862 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1863 Mod2 - Mod5 and against Super, Hyper, Meta.
1865 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1866 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1867 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1869 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1870 modmap to maintain the information which X modifiers map to
1872 (get_xkb): Set up the modmap from the XKB tables.
1873 (update_keymaps): Set up the modmap from the information returned
1874 by XGetModifierMapping in the non-XKB case.
1876 * gdk/x11/gdkprivate-x11.h:
1877 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1878 function to set the virtual modifiers in the state.
1880 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1881 _gdk_keymap_add_virtual_modifiers here.
1883 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1884 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1887 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1889 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1890 if it has no child. (#315253, John Finlay)
1892 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1894 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1896 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1898 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1899 on destroy to avoid problems when they are called on a destroyed
1900 widget. (#315135, John Cupitt)
1902 * gtk/gtkentry.c (gtk_entry_class_init):
1903 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1904 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1906 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1907 code. Now we only steal a single key combination, Ctrl-Shift-U,
1909 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1910 by a sequence of hex digits entered with Ctrl-Shift still held.
1911 Releasing one of the modifiers or pressing space while the modifiers
1912 are still held commits the character. It is possible to erase
1913 digits using backspace.
1914 As an extension to the above, we also allow to start the sequence
1915 with Ctrl-Shift-U, then release the modifiers before typing any
1916 digits, and enter the digits without modifiers.
1917 (#82011, Owen Taylor)
1919 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1921 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1922 we still need to deliver the destroy event. (#314980, Chris Lahey)
1924 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1925 im context before committing \n or \t.
1927 2005-09-02 Alexander Larsson <alexl@redhat.com>
1929 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1930 (shortcuts_activate_volume):
1931 Handle base_path being null in the rest of the cases (#310270)
1933 2005-09-02 Tor Lillqvist <tml@novell.com>
1935 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1936 cursor position also in root window coordinates. Prune out
1937 superfluous WM_MOUSEMOVE events even earlier, based on root window
1938 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1939 window has ben mapped below the cursor even if the mouse doesn't
1940 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1941 confused at least gtk_menu_motion_notify(). (#314995)
1943 * gtk/gtkintl.h: No need to include config.h here. It caused
1944 warnings about GTK_LOCALEDIR being redefined on Win32 when
1945 compiling files where gtkintl.h is included after gtkprivate.h
1946 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1948 * gtk/gtkplug.c: Include config.h.
1950 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1952 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1953 xdg_mime_get_mime_type_for_file() where possible, to avoid
1956 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1957 typo. (#314921, Guillaume Cottenceau)
1959 * gdk/*.c: Intern some more strings.
1961 * gtk/*.c: Define an I_() macro and use it instead of the
1962 bulky g_intern_static_string().
1964 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1966 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1967 instead of copying it.
1969 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1971 * gtk/*.c: Also intern static strings passed to
1972 g_object_set_data().
1975 * gtk/Makefile.am: Intern type names in code generated by
1980 * gdk/*.c: Intern type names before registering the type to avoid
1983 * configure.in: Require GLib 2.9.0
1985 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1987 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1988 and add icon-size and icon-size-set properties. (#314172)
1990 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1991 groups across transient parents. (#312918, Christian Persch)
1993 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1994 Guillaume Cottenceau)
1996 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1997 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1999 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2001 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
2002 make C-/ select all and C-\ unselect all. (#309301,
2005 * gtk/gtkimcontextsimple.c: Change the compose sequence for
2006 soft hyphen to be multi_key-minus-minus-space, and add
2007 compose sequences multi_key-minus-minus-period and
2008 multi_key-minus-minus-minus for en dash and em dash.
2009 (#172653, Christian Lohmaier)
2011 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
2012 code. (#313946, Christian Persch)
2014 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
2015 fix for the default value of the "ui" property.
2017 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2020 * gtk/gtkselection.h:
2021 * gtk/gtkselection.c: Add functions which look for text, image
2022 or uri targets in an array of atoms. (#314089, Mark Wielaard)
2025 * gtk/gtkselection.h:
2026 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
2027 Add a function to check wether targets include uri.
2028 (#314092, Mark Wielaard)
2032 * gtk/gtkwindow.c: Add a deletable property with getter
2033 and setter, to control the close button in the window
2034 frame. (#59718, Havoc Pennington)
2036 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2038 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
2039 to the arrow keys for menu navigation. (#162825, Carl Worth)
2041 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
2043 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
2045 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
2046 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
2047 refer to nonexisting stock ids.
2049 * gtk/gtktextview.c (popup_targets_received):
2050 * gtk/gtkentry.c (popup_targets_received): Construct
2051 the "Select All" menuitem from stock.
2053 * gtk/stock-icons/stock_select_all_{16,24}.png:
2054 * gtk/stock-icons/Makefile.am:
2055 * gtk/gtkiconfactory.c:
2057 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
2060 * gtk/gtktrayicon.c: Add a pointer to the spec.
2062 * gtk/gtkstatusicon-x11.c: Add docs.
2064 * gtk/gtkstatusicon.h: Fix a typo.
2066 Add a cross-platform "tray icon" API, by
2067 porting EggStatusIcon/EggTrayIcon (#105101)
2069 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
2070 displays an icon in a notification area.
2072 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
2073 X11, using GtkTrayIcon.
2075 * gtk/gtktrayicon.h:
2076 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
2077 system tray specification, not public API.
2079 * gtk/gtk.symbols: Add new exported functions.
2081 * gtk/gtk.h: Include gtkstatusicon.h.
2083 * gtk/Makefile.am: Add new files.
2085 * tests/Makefile.am:
2086 * tests/teststatusicon.c: Test for GtkStatusIcon.
2088 2005-08-29 Christopher Aillon <caillon@redhat.com>
2090 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
2091 and GTK_STOCK_DISCONNECT
2093 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2095 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
2096 Use XFixesChangeSaveSet if available. (#314682)
2098 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
2099 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
2101 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2103 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
2104 accidentally leftover duplicate pixbuf creation. (#314700,
2107 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
2108 leak the cursor theme name. (#314693, Kjartan Maraas)
2110 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
2111 state.children in all cases. (#313862, Kjartan Maraas)
2113 2005-08-28 Matthias Clasen <mclasen@redhat.com>
2115 * po/POTFILES.in, po-properties/POTFILES.in:
2118 2005-08-27 Matthias Clasen <mclasen@redhat.com>
2120 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
2121 value of the ui property. (#314532, Yong Wang)
2123 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
2124 when G_MAXLONG is passed as length.
2126 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2128 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
2129 to avoid overloading --force. (JP Rosevaar)
2131 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2133 * configure.in: Bump version to 2.9.0
2137 * gdk/gdkscreen.c: Make the GdkScreen font options api
2138 public, and add properties GdkScreen::font-options and
2139 GdkScreen::resolution. (#314004)
2142 * gtk/gtksettings.c:
2143 * gtk/gtkwidget.c: Adjust all callers.
2145 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
2146 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
2147 * gdk/gdkscreen.c: Include gdkintl.h.
2149 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
2150 variable warning, pointed out by Colin Walters. (#314585)
2152 2005-08-26 Tor Lillqvist <tml@novell.com>
2154 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
2156 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
2158 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2160 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
2161 of week_start. (#314473, JP Rosevaar)
2163 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
2165 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
2166 lock. (#314533, Thomas Fitzsimmons)
2168 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2170 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
2171 NULL gracefully. (#314523, Ed Catmur)
2173 2005-08-25 Owen Taylor <otaylor@redhat.com>
2175 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
2176 Handle theme == NULL.
2178 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2180 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
2181 y offset into account when positioning the popup. (#314470,
2184 2005-08-25 Owen Taylor <otaylor@redhat.com>
2186 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
2187 as instance_init, not base_init! (#314452, Fix from Frederic
2188 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
2189 rather than 1 for a negative flag value.
2191 2005-08-24 Owen Taylor <otaylor@redhat.com>
2193 * gdk/gdkpango.c (draw_error_underline): Add a note about
2194 cut-and-paste between here and Pango.
2196 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2198 * === Released 2.8.2 ===
2200 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
2201 callback for image/gif, and also try image/bmp. (#314086, Mark
2204 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
2205 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
2210 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
2211 and cursor settings get propagated down to the screen initially.
2212 Pointed out by Frederic Crozat.
2214 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
2215 message if the screen is NULL. Noticed by Kjartan Maraas.
2217 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2221 * === Released 2.8.1 ===
2225 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2227 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
2228 against lazy filterers which return values other than TRUE or
2229 FALSE from their visible func. (#314335)
2231 2005-08-23 Owen Taylor <otaylor@redhat.com>
2233 Fix for #314004, reported by Michael Reinsch:
2236 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
2237 Add gdk_screen_get/set_resolution_libgtk_only()
2239 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
2240 the options for the screen on the newly created context.
2242 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
2243 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
2244 the font options on the screen.
2246 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
2247 the font options from the screen and set them on the context.
2249 2005-08-23 Kristian Rietveld <kris@gtk.org>
2251 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
2252 bother inserting new rows in a level with a zero refcount and
2253 immediately free the level. (Fixes #312350, reported by Markku Vire).
2255 2005-08-23 Matthias Clasen <mclasen@redhat.com>
2257 * gtk/updateiconcache.c: Complain when there is no index.theme file
2258 in the specified directory, unless --force is used. Also add an
2259 --index-only option to create caches without image data.
2261 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
2262 C99ism. (#314262, Robert Jeff Mitchell)
2264 2005-08-22 Manish Singh <yosh@gimp.org>
2266 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
2268 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
2270 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2272 * gtk/gtkwindow.c (gtk_window_client_event):
2273 * gtk/gtkicontheme.c (ensure_valid_themes)
2274 (_gtk_icon_theme_check_reload): Implement a clientmessage based
2275 scheme for makeing sure that all GTK+ applications notice if an
2276 icon theme has been updated. This should prevent multiple versions
2277 of an icon theme cache to be mapped in memory at the same time,
2278 which can cause excessive memory consumption. (#313156, Chris
2281 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2283 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
2284 regarding icon theme changes.
2286 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
2287 pixbufs which are backed by the mmapped memory of an icon cache,
2288 increase the refcount of the icon cache, so that the memory is not
2289 munmapped away underneath the pixbuf upon icon theme changes.
2290 (#314170, Kjartan Maraas)
2292 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
2293 to link against Xext. (#314062)
2295 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
2296 overruns. (#314081, Hans Breuer)
2298 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2300 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
2301 returned layout must not be modified.
2303 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
2305 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
2306 scroll_to_path if the model changes.
2308 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
2309 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
2310 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
2311 we're realized, #312798
2312 (gtk_icon_view_set_model): clear scroll_to_path if the model
2315 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2317 * gtk/gtkrange.c (gtk_range_adjustment_changed)
2318 (gtk_range_adjustment_value_changed): Don't queue a draw
2319 if the layout has not changed. (#313991, Benjamin Berg)
2321 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2323 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
2326 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
2329 * gtk/gtkfilechooserbutton.c (change_icon_theme)
2330 (model_add_special, model_add_special, model_add_volumes):
2331 Handle pixbuf being NULL without warnings. Also, don't
2332 leak pixbuf references when the icon theme is changed.
2334 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
2335 the user data on destroyed windows, since at best
2336 it can be a stale pointer. (#313953, Robin Green)
2338 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2340 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
2341 (#313900, Sebastien Bacher)
2343 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
2344 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
2346 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
2347 (xdnd_read_actions, get_client_window_at_coords_recurse):
2348 Free data returned from XGetWindowProperty.
2350 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
2351 Free data returned from XGetWindowProperty. (313867, Kjartan
2354 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
2355 children in all cases. (#313862, Kjartan Maraas)
2357 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
2358 in the per-directory hash, even if they come from the icon cache.
2359 We tried to avoid that before, but as a result leaked icon data
2360 structs. (#313852, Kjartan Maraas)
2362 2005-08-18 Matthias Clasen <mclasen@redhat.com>
2364 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
2365 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
2367 2005-08-15 Owen Taylor <otaylor@redhat.com>
2369 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
2370 files for x11/xext. (Jonas Bonn)
2372 2005-08-15 Tor Lillqvist <tml@novell.com>
2374 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
2377 2005-08-15 Owen Taylor <otaylor@redhat.com>
2379 * configure.in: Fix have_base_pc / have_base_x_pc typo.
2381 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
2382 (#313417, James Andrewartha)
2384 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
2385 FcNameConstant(). (More of #313417)
2387 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2389 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
2390 modal dialogs, make sure to inherit the window group from
2391 the parent, since we don't inherit window groups across
2392 transient parents currently. (#312918, Christian Persch)
2394 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
2395 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
2397 * gtk/gtkiconview.c (gtk_icon_view_select_path)
2398 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
2399 gracefully. (#312796, Jonathan Blandford)
2401 * tests/testtoolbar.c: Add some more tests for menu placement.
2403 * gtk/gtkmenutoolbutton.c (menu_position_func):
2404 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
2405 of toolbutton menus and of the overflow menu. (#312937,
2406 #153870, Christian Persch, Paolo Borelli)
2408 2005-08-15 Tor Lillqvist <tml@novell.com>
2410 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
2411 the nonportable <libgen.h> and dirname().
2413 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2415 * gtk/gtksizegroup.c: Use object data to mark widgets and
2416 groups as visited, so that we avoid constant extra list
2417 traversals. Also allocate quarks in class_init. (#311618,
2420 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
2421 download location for the hicolor icon theme. (#313475, Olexiy
2424 * gtk/gtkicontheme.c: Remove debug spew.
2426 2005-08-15 Owen Taylor <otaylor@redhat.com>
2428 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
2429 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
2430 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
2431 Handle pixmap == NULL when checking for a colormap.
2434 2005-08-14 Matthias Clasen <mclasen@redhat.com>
2436 * gtk/updateiconcache.c: Store only one copy of the pixel data
2437 for symlinked icons. To achieve this, maintain a hashtable
2438 mapping pathnames to pixel data, and share the pixel data for
2439 all symlinks resolving to the same pathname. When writing out
2440 the image data, write out the pixel data only the first time
2441 it is met, and store the offset pointing to the first copy
2442 for use in all later cases.
2443 This reduces the size of the Bluecurve icon cache from 40