1 2005-11-03 Tor Lillqvist <tml@novell.com>
3 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
4 the Win32 backend, check that GdkDisplay* parameters are equal to
5 _gdk_display instead of using the unnecessarily general
8 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
9 color bitmap to have "color" in their name, for similarity with
10 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
11 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
12 the mask bitmap's contents, ones for those pixels in the color
13 bitmap where the alpha is zero, zero for other pixels. We used to
14 use an unitialized mask bitmap! This meant that icons and cursors
15 created presumably worked more or less by accident. Totally blank
16 icons with zero alpha everywhere
17 (as used by gtktrayicon.c) definitely did not work as expected.
19 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
21 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
22 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
23 necessary and can be removed from CVS. It has never been mentioned
24 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
25 are used on Win32. One label widget is used (but never shown) as
26 gtk_widget_render_icon() needs a widget.
28 Ifdefs used as necessary in several places. It might be cleaner to
29 split out the backend-specific parts to separate files, or at
30 least collect them into separate blocks in the file.
32 (wndproc): New function. Window procedure to monitor mouse events
33 in the system tray icon. Call gtk_status_icon_button_press() as
35 (create_tray_observer): New function. Creates a hidden window that
36 only serves as a tray icon message observer.
38 * tests/teststatusicon.c (icon_activated): Position the dialog
39 with GTK_WIN_POS_CENTER.
40 (do_quit): New function, hide and unref the GtkStatusIcon, and
42 (popup_menu): Add a Quit menu item that calls do_quit().
44 2005-11-02 Tor Lillqvist <tml@novell.com>
46 * gdk/win32/gdkcolor-win32.c
47 * gdk/win32/gdkscreen-win32.c
48 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
49 fixes. Remove superfluous test for GdkWindow* parameters being
50 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
51 GdkScreen and one GdkDisplay in the Win32 backend, use those
52 variables instead of the getter functions. For GdkDisplay* and
53 GdkScreen* parameters, check that they are equal to the
54 corresponding singleton variables instead of the more general
55 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
57 2005-11-02 Matthias Clasen <mclasen@redhat.com>
59 * gtk/gtktextview.c: Remove some g_return_if_fail() from
60 static functions, replace some others by g_assert().
62 * gtk/gtktextview.c (selection_motion_event_handler)
63 (gtk_text_view_start_selection_drag): Keep track of the original
64 selection boundaries during a drag selection, in order to correctly
65 decide when to extend or shrink the selection. (#320167,
66 reported by Arvind S N, patch by Paolo Borelli)
68 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
69 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
70 manual offset calculations by g_utf8_offset_to_pointer().
71 (#320360, Paolo Borelli)
73 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
75 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
76 nodes via the g_slice_*() API.
77 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
79 2005-11-01 Tor Lillqvist <tml@novell.com>
81 * gdk/win32/gdkprivate-win32.h
82 * gdk/win32/gdkglobals-win32.c
83 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
84 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
85 their declarations, definitions and assignments into a more
86 logical and consistent order.
88 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
89 CF_ prefix for the predefined clipboard format names. Put quotes
90 around registered format names to distinguish them.
92 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
93 immediately with a warning if the property type is STRING, TEXT,
94 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
95 should never pretend to handle on Win32. Handle only UTF8_STRING
96 here, other formats with delayed rendering. Use \uc1 instead of
97 \uc0 when generating Rich Text Format for easier testability on
98 XP, where WordPad misinterprets \uc0 encoded characters. Add more
99 GDK_NOTE debugging output for Clipboard operations.
101 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
102 (gdk_selection_convert): Don't pretent to handle STRING, just
103 UTF8_STRING. Streamline error handling, don't unnecessarily have a
104 GError which then isn't used for anything anyway if it gets set.
105 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
106 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
108 * config.h.win32.in: Sync with what configure produces.
110 * configure.in: Don't look for X_PACKAGES unless building for
111 x11. (#313986, John Ehresman)
113 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
115 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
116 Wondered why there was no ku there before??
118 2005-10-28 Matthias Clasen <mclasen@redhat.com>
120 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
121 window to the toplevels window group. (#319912, Christian Persch)
123 2005-10-28 Kristian Rietveld <kris@gtk.org>
125 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
128 2005-10-28 Matthias Clasen <mclasen@redhat.com>
130 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
131 drag cursors. (#319200, Federico Mena Quintero)
133 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
134 Shift-G to go to the previous match, like firefox. (#320061, Christian
137 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
138 C99ism. (#320000, Kazuki Iwamoto)
140 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
141 stars. (#319985, Bastien Nocera)
143 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
144 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
146 2005-10-26 Michael Natterer <mitch@imendio.com>
150 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
151 make sure that setting any of pixbuf/stock-id/icon-name resets the
152 others because they are mutually exclusive, and that unsetting any
153 of them only resets the pixbuf and nothing else. Also added
154 some missing g_object_notify().
156 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
157 g_value_set_object().
159 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
160 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
161 g_object_notify ("pixbuf").
163 2005-10-27 Matthias Clasen <mclasen@redhat.com>
165 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
166 careful about initializing cell_area. (#319382, Tommi
169 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
170 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
172 * demos/gtk-demo/clipboard.c (paste_received): Only set the
173 text if it is not NULL. (#319930, Thomas Klausner)
175 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
176 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
178 2005-10-26 Matthias Clasen <mclasen@redhat.com>
180 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
181 * gtk/gtkthemes.c (gtk_theme_engine_load):
182 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
183 when dlopening modules. (#319557, Laszlo Peter)
185 2005-10-26 Matthias Clasen <mclasen@redhat.com>
187 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
188 segments when determining text direction. (#319065, Tommi Komulainen)
190 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
191 on duplicate destroy. (#318953, Gustavo Carneiro)
193 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
194 Point out that destroy-with-parent is a bad idea for the dialog
195 passed to this function. (#318943, Christian Persch)
197 * */Makefile.am: use $(GLIB_MKENUMS) instead of
198 glib-mkenums. (#318582, Damien Carbery)
200 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
201 docs. (#317682, Christian Neumair)
203 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
204 seem to affect the placement of the data in the readonly
205 section, and causes problems with some compilers. (#317844)
207 2005-10-25 Matthias Clasen <mclasen@redhat.com>
209 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
210 Fix some issues with background drawing in RTL. (#318781,
214 * tests/testentrycompletion.c: Apply a patch by Christian
215 Persch to add property editors.
217 * gtk/gtkstatusicon.c: Emit activate on single-click,
218 not on double-click, change proposed by Milosz Derezynski.
220 2005-10-25 Kristian Rietveld <kris@gtk.org>
222 Fixes #311955, reported by Markku Vire; and a lot more.
224 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
225 Levels can now have invisible nodes cached, functions have been
226 rewritten/refactored to take this into account; also the logic in
227 some functions has been corrected.
229 Each referenced node now references all visible children or a single
230 invisible child, in order to be able to monitor all changes in the
231 child model required for correct operation.
233 When a virtual root is set, all nodes on the virtual root level are
236 At last, a bunch of random bug fixes and comment updates.
238 2005-10-25 Matthias Clasen <mclasen@redhat.com>
240 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
241 more docs. (#319722, Paolo Borelli)
243 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
244 initialization of screen_x11->xft_rgba more explicit. (#319627,
247 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
248 in a blurb. (#319499, Francisco Javier F. Serrador)
250 2005-10-24 Matthias Clasen <mclasen@redhat.com>
252 Add settings to hide the input method and Unicode control character
253 submenus in the context menus of GtkEntry and GtkTextView.
255 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
257 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
259 * gtk/gtktextview.c (popup_targets_received):
260 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
262 2005-10-24 Kristian Rietveld <kris@gtk.org>
264 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
265 row-has-child-toggled when the level is not in the cache does not
266 make sense. (This bug probably crept in during the early stages
267 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
269 (gtk_tree_model_sort_real_unref_node): only get the child iter
270 when we will actually also use it.
272 2005-10-22 Michael Natterer <mitch@imendio.com>
274 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
275 widget being realized, in addition to being visible, to avoid
276 running into precondition check in gtk_tree_view_get_cell_area().
279 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
281 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
282 Experimentally, scrollbar steppers can shrink to 8 pixels on
283 Win32. Reflect that in the theme.
284 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
285 there is a 1-pixel border between a scrollbar and its child
286 in ScrolledWindows on Win32. Reflect that in the theme.
288 2005-10-20 Matthias Clasen <mclasen@redhat.com>
290 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
291 for the selection window. (#318806, Alex Larsson)
293 2005-10-18 Federico Mena Quintero <federico@ximian.com>
297 * tests/autotestfilechooser.c
298 (test_button_folder_states_for_action): Test that we have either
299 $cwd or the explicitly-set folder.
300 (test_reload_sequence): Likewise.
302 * gtk/gtkfilechooserdefault.c
303 (gtk_file_chooser_default_get_current_folder): If our reload_state
304 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
306 2005-10-14 Tor Lillqvist <tml@novell.com>
308 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
309 It didn't really do anything useful, and was just confusing and
310 incomplete. Comments claimed we don't do delayed rendering, but in
311 fact we do, for images. (The delayed rendering code has other
312 problems, though, see #168173.) The clipboard viewer code was
313 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
314 the message when necessary). It was just test code, it said so in
315 a comment. Add something similar back later if necessary.
317 (_win32_on_clipboard_change,
318 _gdk_win32_register_clipboard_notification): Remove.
320 (gdk_display_supports_selection_notification,
321 gdk_display_request_selection_notification): Always just return
322 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
324 2005-10-13 Tor Lillqvist <tml@novell.com>
326 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
327 Alt-Enter specially. It does not have any special meaning and
328 should be passed on to the application. (#318378, Tim Evans)
330 2005-10-13 Tor Lillqvist <tml@novell.com>
332 Set visual depth to 24 for 32 bits-per-pixel devices on
333 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
334 optimized composite_0888() function rather than the slower image
335 dithering functions to draw pixbufs (#313993, John Ehresman)
337 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
338 _gdk_windowing_get_bits_for_depth() to initialize
339 GdkImage::bits_per_pixel.
340 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
342 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
343 _gdk_windowing_get_bits_for_depth() to initialize
344 BITMAPINFOHEADER::biBitCount.
346 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
347 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
350 2005-10-12 Stefan Kost <ensonic@users.sf.net>
352 * demos/gtk-demo/appwindow.c: (about_cb):
353 use PACKAGE_VERSION,bump year (#318654)
355 2005-10-11 Matthias Clasen <mclasen@redhat.com>
357 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
358 toggle here with the matching on toggle if it immediately follows.
359 This is a common case, and handling it here prevents quadratic blowup
360 in cleanup_line() below. (#317125)
362 * gtk/gtktextsegment.h:
363 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
364 the character counts into this function instead of computing them
367 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
369 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
371 * gtk/gtkfilechooserdefault.c
372 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
373 when the shortcut already exists in the sidebar. (#147521)
375 2005-10-09 Matthias Clasen <mclasen@redhat.com>
377 * tests/testcombo.c: Demonstrate how to use custom widgets in
380 2005-10-07 Federico Mena Quintero <federico@ximian.com>
384 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
385 the the result of gtk_file_chooser_get_folder() is NULL or
386 non-NULL at the right times. Log the tests.
387 (test_button_folder_states): New test for the initial states of
388 the current folder in GtkFileChooserButton.
389 (main): Test that the number of warnings/errors/critical errors is
392 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
393 Clarify the documentation on when this can return NULL.
394 (gtk_file_chooser_get_current_folder_uri): Likewise.
396 * gtk/gtkfilechooserbutton.c (struct
397 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
398 we use it to keep track of whether a folder has been set.
399 (gtk_file_chooser_button_map): Implement. If no folder has been
400 loaded before, we at least try to load $cwd here.
401 (gtk_file_chooser_button_constructor): If the construct-time
402 dialog already has a folder set, turn on our folder_has_been_set
404 (dialog_current_folder_changed_cb): Turn on our
405 folder_has_been_set flag.
407 2005-10-07 Michael Natterer <mitch@gimp.org>
409 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
410 PROFILE_FILE_CHOOSER because they break compilation after the
411 removal of <unistd.h>.
413 2005-10-07 Matthias Clasen <mclasen@redhat.com>
415 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
416 by moving it out of the profiling ifdef.
418 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
419 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
421 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
422 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
425 2005-10-06 Matthias Clasen <mclasen@redhat.com>
428 * gtk/gtktextbuffer.h:
429 * gtk/gtktextbuffer.c: Add a readonly has-selection property
430 with a getter. (#318161, Paolo Borelli)
432 2005-10-05 Matthias Clasen <mclasen@redhat.com>
434 * README.in: Start collecting release notes for 2.10.
436 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
437 leak fix, since the assertion failures were traced to
438 an xchat bug. (#314696)
440 * gtk/gtkstyle.c (gtk_style_detach):
441 (gtk_style_attach): Documentation improvements.
442 (gtk_style_detach): Assert that the attach_count is > 0.
444 2005-10-04 Federico Mena Quintero <federico@ximian.com>
446 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
447 shortcut position, not a ShortcutsIndex, to make the function more
449 (home_folder_handler): Pass the resolved index to
450 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
451 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
452 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
453 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
454 make the respective key switch to the first, second, ..., tenth
456 (quick_bookmark_handler): Implement.
458 2005-10-04 Federico Mena Quintero <federico@ximian.com>
460 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
461 Desktop; just use their real names on the file system for the
464 * gtk/gtkfilechooserdefault.c
465 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
466 binding signal, and bind it to M-d by default.
467 (desktop_folder_handler): Implement the default handler.
468 (home_folder_handler): Use a helper function.
469 (switch_to_shortcut): New helper function.
470 (shortcuts_append_home): Don't special-case the name of "Home";
471 just use the folder name.
473 2005-10-04 Tor Lillqvist <tml@novell.com>
475 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
476 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
478 2005-10-04 Matthias Clasen <mclasen@redhat.com>
480 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
481 from yesterday, since it leads to assertion failures. (#317879,
484 2005-10-03 Matthias Clasen <mclasen@redhat.com>
486 * gtk/gtkcalendar.c (gtk_calendar_init): Call
487 calendar_compute_days() after setting priv->week_start.
489 2005-10-03 Matthias Clasen <mclasen@redhat.com>
491 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
492 removing it from the hash table. (#314696, Benjamin Berg)
494 2005-10-01 Tor Lillqvist <tml@novell.com>
496 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
497 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
498 is that the the desktop isn't visible because the session has been
499 switched, the screen is locked, or a terminal server session
500 disconnected, so no error message necessary. (#137796)
502 It is of course remotely possible that BitBlt() failing with
503 ERROR_INVALID_HANDLE might also be caused by some other
504 problem. We could strive for perfection and track whether the
505 desktop is visible by using WTSRegisterSessionNotification() and
506 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
507 this issue, though. If we would track desktop visibility, we
508 should then avoid even trying to update the display at all while
509 the desktop isn't visible.
511 2005-09-30 Matthias Clasen <mclasen@redhat.com>
513 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
514 to correct the calculations for the first week day. We may
515 just have to remove this code if too many locales turn out
518 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
519 some cases. (#317611, Tommi Komulainen)
521 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
522 Prevent overflow when storing size hints in an unsigned
523 short variable. Tracked down by Ray Strode and Søren Sandmann.
525 2005-09-29 Matthias Clasen <mclasen@redhat.com>
527 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
530 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
531 grab shadowed. (#317332)
533 2005-09-29 Tor Lillqvist <tml@novell.com>
535 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
537 2005-09-28 Federico Mena Quintero <federico@ximian.com>
539 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
540 if the unmap test fails.
541 (test_reload_sequence): Use gtk_widget_show_now() instead of
542 gtk_widget_show() for the dialog.
543 Thanks to Tim Janik for noticing these.
545 2005-09-28 Federico Mena Quintero <federico@ximian.com>
547 * tests/testcellrenderertext.c: New file with a set of tests for
548 GtkCellRendererText. The idea is to run a text renderer through
549 most of its interesting property values to see that it works
552 * tests/Makefile.am: Added testcellrenderertext.
554 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
555 entry/exit of this function for profiling.
556 (gtk_file_chooser_default_style_set): Mark the start/end of the
557 calls to the parent class and the the signal emission for profiling.
559 2005-09-29 Tor Lillqvist <tml@novell.com>
561 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
562 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
563 system codepage using g_win32_locale_filename_from_utf8().
564 (#317457, Kazuki Iwamoto)
566 2005-09-28 Matthias Clasen <mclasen@redhat.com>
568 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
569 here. (#317039, Paolo Borelli)
572 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
573 to make this function work as boxed copy function. (#317455,
576 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
577 NULL. (#316828, Tor Lillqvist)
579 2005-09-28 Tor Lillqvist <tml@novell.com>
581 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
584 2005-09-27 Federico Mena Quintero <federico@ximian.com>
586 Don't reload the current folder unnecessarily on ::map().
588 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
590 (struct _GtkFileChooserDefault): Added a "reload_state" field.
592 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
593 Initialize impl->reload_state.
594 (gtk_file_chooser_default_map): Check the impl->reload_state; load
595 a default folder if no folder has been set, or reload the current
596 one only if we had been unmapped first.
597 (gtk_file_chooser_default_update_current_folder): Set the
598 reload_state to RELOAD_HAS_FOLDER.
599 (gtk_file_chooser_default_unmap): Implement, and set the
600 reload_state to RELOAD_WAS_UNMAPPED.
601 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
602 here; they'll get (re)loaded on ::map() anyway.
604 * gtk/gtkfilechooserwidget.c
605 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
607 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
608 a dialog; build it ourselves.
609 (test_reload): New test to ensure that we don't load the default
610 folder more than once, and that we reload it when
612 (get_impl_from_dialog): New utility function.
613 (test_widgets_for_current_action): Use get_impl_from_dialog().
615 2005-09-27 Federico Mena Quintero <federico@ximian.com>
617 * gtk/gtkfilechooserdefault.c
618 (gtk_file_chooser_default_constructor): Mark the entry/exit of
619 this function for profiling.
620 (check_icon_theme): Likewise.
621 (change_icon_theme): Likewise.
622 (settings_notify_cb): Likewise.
623 (gtk_file_chooser_default_screen_changed): Likewise.
624 (update_chooser_entry): If the selection is empty, clear the file
625 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
626 nothing will be selected when the user starts typeahead in the
627 treeview, and we don't want to clear the file name entry in that
628 case --- the user could be typing-ahead to look for a folder name.
629 Fixes bug #308332, patch by Jürg Billeter.
631 2005-09-27 Matthias Clasen <mclasen@redhat.com>
633 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
634 Pop below the entry if there's more free space below the entry
635 than above. (#316948, Tommi Komulainen)
637 2005-09-26 Federico Mena Quintero <federico@ximian.com>
639 Do not create the save mode-specific widgets in the open modes, so
640 that we don't carry their baggage around.
642 * gtk/gtkfilechooserdefault.c
643 (gtk_file_chooser_default_constructor): Don't create the
645 (save_widgets_create): Set the impl->save_widgets directly here,
646 instead of passing the widgets back to the caller. Also, pack
647 them into the impl's box.
648 (update_appearance): Create or destroy the save widgets as
649 appropriate. Set the action of the save_file_name_entry here.
650 (shortcuts_add_current_folder): Set the active item in the
651 save_folder_combo only if it exists.
652 (gtk_file_chooser_default_set_property): Don't set the action of
653 the save_file_name_entry here.
654 (gtk_file_chooser_default_update_current_folder): Set the base
655 folder of the save_file_name_entry only if the entry exists.
656 (shortcuts_drag_data_received_cb): Cast the selection_data->data
657 to (const char *) since that's what shortcuts_drop_uris() expects.
658 (file_list_drag_data_received_cb): Likewise, for
659 g_uri_list_extract_uris().
661 2005-09-26 Tor Lillqvist <tml@novell.com>
663 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
664 the shaped flag here, too. (#316871)
665 (gdk_window_shape_combine_region): Currently unimplemented, so
666 don't do anything to the shaped flag here.
668 2005-09-26 Matthias Clasen <mclasen@redhat.com>
670 Fix #316871, reported by Dan Winship:
672 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
674 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
675 (gdk_window_shape_combine_region): Set it here.
677 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
678 remove the child area for shaped windows.
680 2005-09-23 Matthias Clasen <mclasen@redhat.com>
682 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
683 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
685 2005-09-22 Michael Natterer <mitch@imendio.com>
687 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
688 consistent with GTK+ terminology:
690 * gtk/gtkcellrendererkeys.[ch]
691 * tests/testkeys.c: removed...
693 * gtk/gtkcellrendereraccel.[ch]
694 * tests/testaccel.c: ...and added.
699 * tests/Makefile.am: changed accordingly.
701 2005-09-22 Matthias Clasen <mclasen@redhat.com>
703 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
704 for the grab-broken-event signal, noticed by Damon Chaplin.
706 2005-09-21 Tor Lillqvist <tml@novell.com>
708 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
709 gdk_text_property_to_text_list_for_display,
710 gdk_text_property_to_utf8_list_for_display,
711 gdk_win32_selection_add_targets,
712 _gdk_win32_selection_convert_to_dib): Free return value from
714 (gdk_text_property_to_text_list_for_display): Drop GError variable
715 that isn't actually used after being set.
717 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
719 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
722 2005-09-20 Tor Lillqvist <tml@novell.com>
724 * gdk/win32/gdkselection-win32.c
725 (gdk_selection_owner_get_for_display): Do return the correct owner
726 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
727 a window GDK knows about). The reason to return NULL seems to have
728 gone when in the fix for bug #163702 the artificial
729 GDK_SELECTION_CLEAR event generation was removed from
730 gdk_selection_send_notify_for_display(). Fixes bug #316552.
732 2005-09-20 Matthias Clasen <mclasen@redhat.com>
734 Avoid unnecessary XkbGetState() calls and XkbStateNotify
735 events. (#151555, Søren Sandmann)
737 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
738 XkbSelectEventDetails() to select XkbStateNotify events
739 for only the state we care about.
741 * gdk/x11/gdkprivate-x11.h:
742 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
743 the event into the function and update the keymap state from
744 the state information contained in the event. Adjust all callers.
746 2005-09-19 Matthias Clasen <mclasen@redhat.com>
748 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
749 in multiple places to avoid segfaults if the index is out of range.
750 (#316422, Guillaume Cottenceau)
751 (gtk_icon_view_set_drag_dest_item):
752 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
753 #316424, Guillaume Cottenceau)
755 2005-09-18 Hans Breuer <hans@breuer.org>
757 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
758 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
760 2005-09-18 Hans Breuer <hans@breuer.org>
762 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
763 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
764 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
765 the icon and is blinking with teststatusicon. More to come ...
767 2005-09-18 Hans Breuer <hans@breuer.org>
769 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
770 cause gtkprogressbar.c has #include <config.h> conditionally; less
771 noise from generated gtk.def
772 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
774 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
775 For me it works as well as the *NIX implemenation, that is not at all.
777 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
779 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
780 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
781 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
782 again - if compiled properly.
784 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
785 already coming with Gtk+. Makes it compile on win32.
787 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
789 * README.cvs-commits: fixed some tiny typos
791 2005-09-16 Tor Lillqvist <tml@novell.com>
793 * modules/engines/ms-windows/msw_style.c (draw_extension,
794 draw_box_gap): Check whether the widget actually is a GtkNotebook
795 before treating it as such. Drop some unneeded local variables,
796 use parameter with same information instead. (#316412)
798 2005-09-15 Federico Mena Quintero <federico@ximian.com>
800 * tests/autotestfilechooser.c: Start a set of automated tests for
801 the file chooser. The only test in there right now doesn't pass
802 yet. It specifies the intended behavior of the first optimization
803 of a series which I'll do on the file chooser (see
804 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
805 details of this optimization).
807 * tests/Makefile.am: Added autotestfilechooser.c.
809 * gtk/gtkfilechooserprivate.h (struct
810 _GtkFileChooserDialogPrivate): Move all the file chooser's private
811 structures to here, so that they can be accessed by
812 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
813 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
815 * gtk/gtkfilechooserdialog.c: See above.
817 * gtk/gtkfilechooserwidget.c: See above.
819 * gtk/gtkfilechooserdefault.c: See above.
821 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
824 gtk_window_map_event(): new function to work around lost unmap requests.
827 2005-09-14 Federico Mena Quintero <federico@ximian.com>
829 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
830 an easy-to-find profiling marker when starting to create a file
832 (browse_files_model_finished_loading_cb): Likewise, for when the
833 chooser is finished loading.
835 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
837 * gtk/gtkcolorbutton.c: Check "color" argument in
838 gtk_color_button_set_color ()
840 2005-09-14 Matthias Clasen <mclasen@redhat.com>
842 * gtk/gtklabel.c (gtk_label_get_type):
843 * gtk/gtkbutton.c (gtk_button_get_type):
844 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
845 using a mem chunk for window groups, buttons, labels.
847 * gtk/updateiconcache.c (foreach_remove_func): Fix
848 a use-after-free bug. (#316256, Alexander Nedotsukov)
850 2005-09-13 Matthias Clasen <mclasen@redhat.com>
852 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
854 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
856 2005-09-13 Matthias Clasen <mclasen@redhat.com>
858 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
859 Let GDK_Return pass through in some more cases.
861 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
862 activating the entry.
864 * gtk/gtkiconview.c (gtk_icon_view_class_init):
865 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
866 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
868 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
869 (#316001, Guillaume Cottenceau)
871 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
872 mistake in the docs. (#315993, Guillaume Cottenceau)
874 * tests/testentrycompletion.c (create_simple_completion_model): Add
875 some strings containing multibyte characters.
877 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
878 Fix prefix insertion for multibyte characters. (#316095,
881 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
882 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
883 return NULL if the widget is not realized. (#316023,
884 Guillaume Cottenceau)
886 2005-09-11 Matthias Clasen <mclasen@redhat.com>
890 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
891 New function to avoid pointless strdups when creating atoms
895 * gtk/*.c: Use gdk_atom_intern_static_string() where
898 2005-09-09 Matthias Clasen <mclasen@redhat.com>
900 * gtk/gtkcellrendererkeys.h:
901 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
902 and editing accelerators, a port of EggCellRendererKeys .
906 * gtk/Makefile.am: Add the keys cell renderer.
909 * tests/testkeys.c: Test GtkCellRendererKeys
911 2005-09-09 Matthias Clasen <mclasen@redhat.com>
913 Make it possible to determine if a key event is for a
916 * gdk/x11/gdkprivate-x11.h:
917 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
918 New function to determine if a keycode is mapped to a modifier.
919 (get_xkb): Get the modmap.
921 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
922 is_modifier bit by calling _gdk_keymap_key_is_modifier().
924 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
927 2005-09-09 Matthias Clasen <mclasen@redhat.com>
929 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
930 unused variable, noticed by Kjartan Maraas.
932 2005-09-09 Matthias Clasen <mclasen@redhat.com>
934 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
935 Make drag reordering work properly for columns other than the
936 first. (#315054, Dan Winship)
938 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
939 invalid fontnames better. (#136926, Michael R. Walton)
941 Stop cursor blinking in non-editable regions of a text view.
942 (#311508, Torbjörn Andersson)
944 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
945 (cursor_blinks): Take editability into account when deciding
946 whether the cursor blinks.
947 (gtk_text_view_button_release_event):
948 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
950 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
951 Use connect_after to connect to the focus_out event. This
952 ensures that the entry has already stopped blinking by the time
953 we emit the edited signal. (#315229, Thomas Leonard)
955 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
957 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
958 unsigned ints to -1. (#315481, Kjartan Maraas)
960 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
961 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
962 (#314473, Stanislav Brabec)
964 2005-09-09 Matthias Clasen <mclasen@redhat.com>
966 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
967 memory handling. (#314975, Torsten Schoenfeld)
969 * gtk/gtkiconview.c (gtk_icon_view_class_init):
970 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
971 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
972 * gtk/gtklabel.c (gtk_label_class_init):
973 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
974 Stylistic improvements and clarifications for some blurbs.
975 (#315520, Clytie Siddall)
977 2005-09-09 Tor Lillqvist <tml@novell.com>
979 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
980 display name. There is only one GdkDisplay on Win32, and
981 constructing the display name isn't entirely trivial, so cacheing
982 is probably worth it. For instance GIMP calls this function a lot.
983 (gdk_display_open): Call gdk_display_get_name() to prime the
985 (gdk_display_get_n_screens, gdk_display_get_screen,
986 gdk_display_get_default_screen): Verify parameter correctness like
987 the X11 backend does.
989 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
990 Return a freshly allocated string, as the API specifies. Fixes a
991 heap corruption problem that caused random errors and crashes in
994 2005-09-07 Matthias Clasen <mclasen@redhat.com>
996 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
997 Make C-u commit and restart hex input if we are already in a
1000 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1002 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1003 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1004 if they are mapped to the same modifier.
1006 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1007 to gtkstatusicon.c and gtktrayicon-x11.c
1009 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1010 default accel mod mask.
1012 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1013 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1014 Don't use GDK_ALT_MASK.
1016 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1018 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1020 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1022 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1025 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1026 Mod2 - Mod5 and against Super, Hyper, Meta.
1028 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1029 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1030 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1032 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1033 modmap to maintain the information which X modifiers map to
1035 (get_xkb): Set up the modmap from the XKB tables.
1036 (update_keymaps): Set up the modmap from the information returned
1037 by XGetModifierMapping in the non-XKB case.
1039 * gdk/x11/gdkprivate-x11.h:
1040 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1041 function to set the virtual modifiers in the state.
1043 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1044 _gdk_keymap_add_virtual_modifiers here.
1046 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1047 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1050 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1052 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1053 if it has no child. (#315253, John Finlay)
1055 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1057 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1059 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1061 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1062 on destroy to avoid problems when they are called on a destroyed
1063 widget. (#315135, John Cupitt)
1065 * gtk/gtkentry.c (gtk_entry_class_init):
1066 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1067 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1069 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1070 code. Now we only steal a single key combination, Ctrl-Shift-U,
1072 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1073 by a sequence of hex digits entered with Ctrl-Shift still held.
1074 Releasing one of the modifiers or pressing space while the modifiers
1075 are still held commits the character. It is possible to erase
1076 digits using backspace.
1077 As an extension to the above, we also allow to start the sequence
1078 with Ctrl-Shift-U, then release the modifiers before typing any
1079 digits, and enter the digits without modifiers.
1080 (#82011, Owen Taylor)
1082 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1084 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1085 we still need to deliver the destroy event. (#314980, Chris Lahey)
1087 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1088 im context before committing \n or \t.
1090 2005-09-02 Alexander Larsson <alexl@redhat.com>
1092 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1093 (shortcuts_activate_volume):
1094 Handle base_path being null in the rest of the cases (#310270)
1096 2005-09-02 Tor Lillqvist <tml@novell.com>
1098 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1099 cursor position also in root window coordinates. Prune out
1100 superfluous WM_MOUSEMOVE events even earlier, based on root window
1101 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1102 window has ben mapped below the cursor even if the mouse doesn't
1103 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1104 confused at least gtk_menu_motion_notify(). (#314995)
1106 * gtk/gtkintl.h: No need to include config.h here. It caused
1107 warnings about GTK_LOCALEDIR being redefined on Win32 when
1108 compiling files where gtkintl.h is included after gtkprivate.h
1109 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1111 * gtk/gtkplug.c: Include config.h.
1113 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1115 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1116 xdg_mime_get_mime_type_for_file() where possible, to avoid
1119 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1120 typo. (#314921, Guillaume Cottenceau)
1122 * gdk/*.c: Intern some more strings.
1124 * gtk/*.c: Define an I_() macro and use it instead of the
1125 bulky g_intern_static_string().
1127 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1129 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1130 instead of copying it.
1132 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1134 * gtk/*.c: Also intern static strings passed to
1135 g_object_set_data().
1138 * gtk/Makefile.am: Intern type names in code generated by
1143 * gdk/*.c: Intern type names before registering the type to avoid
1146 * configure.in: Require GLib 2.9.0
1148 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1150 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1151 and add icon-size and icon-size-set properties. (#314172)
1153 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1154 groups across transient parents. (#312918, Christian Persch)
1156 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1157 Guillaume Cottenceau)
1159 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1160 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1162 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1164 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1165 make C-/ select all and C-\ unselect all. (#309301,
1168 * gtk/gtkimcontextsimple.c: Change the compose sequence for
1169 soft hyphen to be multi_key-minus-minus-space, and add
1170 compose sequences multi_key-minus-minus-period and
1171 multi_key-minus-minus-minus for en dash and em dash.
1172 (#172653, Christian Lohmaier)
1174 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
1175 code. (#313946, Christian Persch)
1177 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
1178 fix for the default value of the "ui" property.
1180 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1183 * gtk/gtkselection.h:
1184 * gtk/gtkselection.c: Add functions which look for text, image
1185 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1188 * gtk/gtkselection.h:
1189 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1190 Add a function to check wether targets include uri.
1191 (#314092, Mark Wielaard)
1195 * gtk/gtkwindow.c: Add a deletable property with getter
1196 and setter, to control the close button in the window
1197 frame. (#59718, Havoc Pennington)
1199 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1201 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1202 to the arrow keys for menu navigation. (#162825, Carl Worth)
1204 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1206 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1208 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1209 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1210 refer to nonexisting stock ids.
1212 * gtk/gtktextview.c (popup_targets_received):
1213 * gtk/gtkentry.c (popup_targets_received): Construct
1214 the "Select All" menuitem from stock.
1216 * gtk/stock-icons/stock_select_all_{16,24}.png:
1217 * gtk/stock-icons/Makefile.am:
1218 * gtk/gtkiconfactory.c:
1220 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1223 * gtk/gtktrayicon.c: Add a pointer to the spec.
1225 * gtk/gtkstatusicon-x11.c: Add docs.
1227 * gtk/gtkstatusicon.h: Fix a typo.
1229 Add a cross-platform "tray icon" API, by
1230 porting EggStatusIcon/EggTrayIcon (#105101)
1232 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1233 displays an icon in a notification area.
1235 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1236 X11, using GtkTrayIcon.
1238 * gtk/gtktrayicon.h:
1239 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1240 system tray specification, not public API.
1242 * gtk/gtk.symbols: Add new exported functions.
1244 * gtk/gtk.h: Include gtkstatusicon.h.
1246 * gtk/Makefile.am: Add new files.
1248 * tests/Makefile.am:
1249 * tests/teststatusicon.c: Test for GtkStatusIcon.
1251 2005-08-29 Christopher Aillon <caillon@redhat.com>
1253 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1254 and GTK_STOCK_DISCONNECT
1256 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1258 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1259 Use XFixesChangeSaveSet if available. (#314682)
1261 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1262 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1264 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1266 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1267 accidentally leftover duplicate pixbuf creation. (#314700,
1270 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1271 leak the cursor theme name. (#314693, Kjartan Maraas)
1273 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1274 state.children in all cases. (#313862, Kjartan Maraas)
1276 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1278 * po/POTFILES.in, po-properties/POTFILES.in:
1281 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1283 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1284 value of the ui property. (#314532, Yong Wang)
1286 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1287 when G_MAXLONG is passed as length.
1289 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1291 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1292 to avoid overloading --force. (JP Rosevaar)
1294 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1296 * configure.in: Bump version to 2.9.0
1300 * gdk/gdkscreen.c: Make the GdkScreen font options api
1301 public, and add properties GdkScreen::font-options and
1302 GdkScreen::resolution. (#314004)
1305 * gtk/gtksettings.c:
1306 * gtk/gtkwidget.c: Adjust all callers.
1308 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1309 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1310 * gdk/gdkscreen.c: Include gdkintl.h.
1312 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1313 variable warning, pointed out by Colin Walters. (#314585)
1315 2005-08-26 Tor Lillqvist <tml@novell.com>
1317 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1319 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1321 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1323 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1324 of week_start. (#314473, JP Rosevaar)
1326 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1328 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1329 lock. (#314533, Thomas Fitzsimmons)
1331 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1333 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1334 NULL gracefully. (#314523, Ed Catmur)
1336 2005-08-25 Owen Taylor <otaylor@redhat.com>
1338 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1339 Handle theme == NULL.
1341 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1343 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1344 y offset into account when positioning the popup. (#314470,
1347 2005-08-25 Owen Taylor <otaylor@redhat.com>
1349 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1350 as instance_init, not base_init! (#314452, Fix from Frederic
1351 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1352 rather than 1 for a negative flag value.
1354 2005-08-24 Owen Taylor <otaylor@redhat.com>
1356 * gdk/gdkpango.c (draw_error_underline): Add a note about
1357 cut-and-paste between here and Pango.
1359 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1361 * === Released 2.8.2 ===
1363 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1364 callback for image/gif, and also try image/bmp. (#314086, Mark
1367 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1368 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1373 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1374 and cursor settings get propagated down to the screen initially.
1375 Pointed out by Frederic Crozat.
1377 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1378 message if the screen is NULL. Noticed by Kjartan Maraas.
1380 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1384 * === Released 2.8.1 ===
1388 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1390 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1391 against lazy filterers which return values other than TRUE or
1392 FALSE from their visible func. (#314335)
1394 2005-08-23 Owen Taylor <otaylor@redhat.com>
1396 Fix for #314004, reported by Michael Reinsch:
1399 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1400 Add gdk_screen_get/set_resolution_libgtk_only()
1402 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1403 the options for the screen on the newly created context.
1405 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1406 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1407 the font options on the screen.
1409 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1410 the font options from the screen and set them on the context.
1412 2005-08-23 Kristian Rietveld <kris@gtk.org>
1414 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1415 bother inserting new rows in a level with a zero refcount and
1416 immediately free the level. (Fixes #312350, reported by Markku Vire).
1418 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1420 * gtk/updateiconcache.c: Complain when there is no index.theme file
1421 in the specified directory, unless --force is used. Also add an
1422 --index-only option to create caches without image data.
1424 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1425 C99ism. (#314262, Robert Jeff Mitchell)
1427 2005-08-22 Manish Singh <yosh@gimp.org>
1429 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1431 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1433 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1435 * gtk/gtkwindow.c (gtk_window_client_event):
1436 * gtk/gtkicontheme.c (ensure_valid_themes)
1437 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1438 scheme for makeing sure that all GTK+ applications notice if an
1439 icon theme has been updated. This should prevent multiple versions
1440 of an icon theme cache to be mapped in memory at the same time,
1441 which can cause excessive memory consumption. (#313156, Chris
1444 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1446 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1447 regarding icon theme changes.
1449 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1450 pixbufs which are backed by the mmapped memory of an icon cache,
1451 increase the refcount of the icon cache, so that the memory is not
1452 munmapped away underneath the pixbuf upon icon theme changes.
1453 (#314170, Kjartan Maraas)
1455 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1456 to link against Xext. (#314062)
1458 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1459 overruns. (#314081, Hans Breuer)
1461 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1463 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1464 returned layout must not be modified.
1466 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1468 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1469 scroll_to_path if the model changes.
1471 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1472 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1473 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1474 we're realized, #312798
1475 (gtk_icon_view_set_model): clear scroll_to_path if the model
1478 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1480 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1481 (gtk_range_adjustment_value_changed): Don't queue a draw
1482 if the layout has not changed. (#313991, Benjamin Berg)
1484 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1486 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1489 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1492 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1493 (model_add_special, model_add_special, model_add_volumes):
1494 Handle pixbuf being NULL without warnings. Also, don't
1495 leak pixbuf references when the icon theme is changed.
1497 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1498 the user data on destroyed windows, since at best
1499 it can be a stale pointer. (#313953, Robin Green)
1501 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1503 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1504 (#313900, Sebastien Bacher)
1506 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1507 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1509 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1510 (xdnd_read_actions, get_client_window_at_coords_recurse):
1511 Free data returned from XGetWindowProperty.
1513 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1514 Free data returned from XGetWindowProperty. (313867, Kjartan
1517 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1518 children in all cases. (#313862, Kjartan Maraas)
1520 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1521 in the per-directory hash, even if they come from the icon cache.
1522 We tried to avoid that before, but as a result leaked icon data
1523 structs. (#313852, Kjartan Maraas)
1525 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1527 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1528 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1530 2005-08-15 Owen Taylor <otaylor@redhat.com>
1532 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1533 files for x11/xext. (Jonas Bonn)
1535 2005-08-15 Tor Lillqvist <tml@novell.com>
1537 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1540 2005-08-15 Owen Taylor <otaylor@redhat.com>
1542 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1544 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1545 (#313417, James Andrewartha)
1547 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1548 FcNameConstant(). (More of #313417)
1550 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1552 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1553 modal dialogs, make sure to inherit the window group from
1554 the parent, since we don't inherit window groups across
1555 transient parents currently. (#312918, Christian Persch)
1557 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1558 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1560 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1561 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1562 gracefully. (#312796, Jonathan Blandford)
1564 * tests/testtoolbar.c: Add some more tests for menu placement.
1566 * gtk/gtkmenutoolbutton.c (menu_position_func):
1567 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1568 of toolbutton menus and of the overflow menu. (#312937,
1569 #153870, Christian Persch, Paolo Borelli)
1571 2005-08-15 Tor Lillqvist <tml@novell.com>
1573 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1574 the nonportable <libgen.h> and dirname().
1576 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1578 * gtk/gtksizegroup.c: Use object data to mark widgets and
1579 groups as visited, so that we avoid constant extra list
1580 traversals. Also allocate quarks in class_init. (#311618,
1583 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1584 download location for the hicolor icon theme. (#313475, Olexiy
1587 * gtk/gtkicontheme.c: Remove debug spew.
1589 2005-08-15 Owen Taylor <otaylor@redhat.com>
1591 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1592 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1593 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1594 Handle pixmap == NULL when checking for a colormap.
1597 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1599 * gtk/updateiconcache.c: Store only one copy of the pixel data
1600 for symlinked icons. To achieve this, maintain a hashtable
1601 mapping pathnames to pixel data, and share the pixel data for
1602 all symlinks resolving to the same pathname. When writing out
1603 the image data, write out the pixel data only the first time
1604 it is met, and store the offset pointing to the first copy
1605 for use in all later cases.
1606 This reduces the size of the Bluecurve icon cache from 40