1 2004-11-01 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtkfilechooserbutton.c: Move some docs inline.
5 * gtk/gtkaboutdialog.c (gtk_show_about_dialog): Doc update.
7 * gtk/gtktextbuffer.c (gtk_text_buffer_backspace): Revalidate the
8 iter. (#156924, Murray Cumming)
10 * gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Don't crash on
11 broken ClientMessage events. (#157056, Owen Taylor)
13 * gtk/gtkactiongroup.c (gtk_action_group_get_visible): Fix a typo in
14 the docs. (#157044, Masao Mutoh)
16 2004-10-31 Matthias Clasen <mclasen@redhat.com>
18 * gtk/gtkcombobox.c (gtk_combo_box_button_state_changed): Update the
19 state of the cell view when the state of the button changes (to
20 get prelighted drawing right). (#138650, Frances Keenan, Christian Persch)
22 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
23 Don't force the height of the action area, we don't scroll
24 it anyway, and the current way of calculating the height can lead
25 to broken display. (#156573, Christian Persch)
27 * tests/testentrycompletion.c (animation_timer): Don't try to
28 remove stuff from an empty model. (#156575, Christian Persch)
30 * gtk/gtkentrycompletion.c (gtk_entry_completion_class_init):
31 * gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_class_init):
34 2004-10-31 Tor Lillqvist <tml@iki.fi>
36 * gdk/win32/gdkprivate-win32.h
37 * gdk/win32/gdkglobals-win32.c
38 * gdk/win32/gdkmain-win32.c: Remove _windows_version and the
41 * gdk/win32/*.c: Use G_WIN32_IS_NT_BASED() from GLib instead.
43 2004-10-31 Matthias Clasen <mclasen@redhat.com>
45 Add api for image transfer via copy-and-paste (#156408)
47 * gtk/gtkclipboard.c (gtk_clipboard_set_image)
48 (gtk_clipboard_request_image, gtk_clipboard_wait_for_image)
49 (gtk_clipboard_wait_is_image_available): New functions for image
53 * gtk/gtkselection.c (gtk_selection_data_targets_include_image):
54 New function, similar to gtk_selection_data_targets_include_text().
56 * gtk/gtkprogressbar.[hc]: Add an ellipsize property with
57 getter and setter. (#156845, Morten Welinder)
59 2004-10-29 Robert Ă–gren <gtk@roboros.com>
61 * gdk/win32/gdkwindow-win32.c (gdk_window_begin_resize_drag),
62 (gdk_window_begin_move_drag): Implement these on win32, currently
63 only for button 1. Fixes the resize grip of GtkStatusbar on
66 2004-10-30 Matthias Clasen <mclasen@redhat.com>
68 * gtk/gtktextbtree.c (_gtk_text_btree_select_range): Redisplay
71 * gtk/gtktextview.c (gtk_text_view_select_all): Use
72 gtk_text_buffer_select_range().
74 * tests/testtext.c: Add a "Select All" menuitem. (#156792,
77 * gtk/gtkicontheme.c (insert_theme): Sort the dir_mtimes
78 list in the same way as the search path.
79 (theme_subdir_load): Avoid stat()ing subdirs if the theme
80 directory doesn't exist. (#156866)
82 2004-10-29 Matthias Clasen <mclasen@redhat.com>
84 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
85 Drop the reference to the pixbuf, regardless whether it is
86 a stock pixbuf. (#156863, Philip Langdale)
88 2004-10-29 Hans Breuer <hans@breuer.org>
90 * gdk/makefile.msc gtk/makefile.msc.in : updated
92 * gdk/win32/gdkdisplay-win32.c : dummy implementations for
93 gdk_display_supports_clipboard_persistence, gdk_display_store_clipboard
95 * gtk/gtkmodules.c : #include "gtkprivate.h" for GTK_LIBDIR
97 2004-10-29 Matthias Clasen <mclasen@redhat.com>
99 * gtk/gtkclipboard.c (gtk_clipboard_set_text): Don't hardwire
100 the supported text targets here, use
101 gtk_target_list_add_text_targets(). (#156404)
103 * gtk/gtkliststore.c (gtk_list_store_reorder): Don't
104 loop over the sentinel node. (#156298, Torsten Schoenfeld)
106 2004-10-28 Matthias Clasen <mclasen@redhat.com>
108 * gtk/gtkcombobox.c (gtk_combo_box_start_editing): Use
109 g_signal_connect_object() to prevent premature finalization
110 of the cell_editable while the key_press_event signal is
111 handled. (#156325, Olivier Andrieu)
113 * *: Clean up many sparse warnings. (#156698, Kjartan Maraas)
115 * gtk/gtktreeview.c (gtk_tree_view_remove_widget): Disconnect
116 from the remove-widget signal after removing the signal.
118 * gtk/gtkaboutdialog.c (gtk_show_about_dialog): Destroy
119 the dialog with the parent. (#156557, Paolo Borelli)
121 2004-10-27 Matthias Clasen <mclasen@redhat.com>
125 * === Released 2.5.4 ===
127 * Makefile.am (EXTRA_DIST): Remove po/makefile.mingw
129 2004-10-28 Anders Carlsson <andersca@gnome.org>
131 * gtk/gtkclipboard.c: (gtk_clipboard_set_can_store):
132 * gtk/gtkclipboard.h:
135 2004-10-27 Matthias Clasen <mclasen@redhat.com>
137 * gtk/Makefile.am (gtkalias.h):
138 * gdk/Makefile.am (gdkalias.h): Fix srcdir != builddir build.
139 (#156547, Thomas Fitzsimmons)
143 * gtk/gtkclipboard.c (gtk_clipboard_set_can_store): Silently
144 ignore non-CLIPBOARD clipboards. (#156610, Christian Persch)
146 * gtk/gtksettings.c: Make it build on windows. (#156618,
149 2004-10-26 Matthias Clasen <mclasen@redhat.com>
151 * gtk/gtkimcontextsimple.c (check_hex): Stop preediting if strtoul
152 couldn't parse the complete preedit string. (#156434)
154 * gtk/gtkmessagedialog.c:
155 * gtk/gtkfilechooserbutton.c: Add missing includes. (#156503,
159 * gtk/gtkimage.c (gtk_image_get_icon_name): Make the icon_name
160 parameter G_CONST_RETURN.
162 * gtk/gtkimage.c: It is enough to listen for screen changes and
163 style-set to catch all icon theme changes.
164 (gtk_image_set_property): Reset the image size if the pixel size
167 * gtk/gtk.symbols: Add new symbols.
169 * gdk/x11/gdkdisplay-x11.c (gdk_display_store_clipboard): Fix the
172 2004-10-26 Anders Carlsson <andersca@imendio.com>
174 * gtk/gtktextbuffer.c: (gtk_text_buffer_finalize),
175 (create_clipboard_contents_buffer), (clipboard_get_contents_cb),
176 (clipboard_clear_contents_cb), (cut_or_copy):
177 Rewrite clipboard handling so that the clipboard contents
178 won't be freed when the text buffer is finalized. Also add
179 clipboard manager support. Fixes #95496.
181 2004-10-25 Anders Carlsson <andersca@gnome.org>
183 * gtk/gtkentry.c: (gtk_entry_completion_timeout):
184 * gtk/gtkentrycompletion.c: (gtk_entry_completion_set_model),
185 (gtk_entry_completion_get_model), (gtk_entry_completion_complete):
186 Really handle a NULL model, fixes #137211 for real.
188 * gtk/gtkfilechooserentry.c:
189 (gtk_file_chooser_entry_maybe_update_directory):
190 Remove _clear, #137211 is fixed.
192 * tests/testentrycompletion.c: (main):
193 Add completion with an empty model.
195 2004-10-25 Carlos Garnacho Parro <carlosg@gnome.org>
197 Fix for #118764, David Bordoley:
199 * gtk/gtkmessagedialog.[ch]
200 (gtk_message_dialog_format_secondary_text),
201 (gtk_message_dialog_format_secondary_format): API additions to
202 create HIG-like dialogs
204 * demos/gtk-demo/dialog.c: Use the new API in the example
206 * docs/reference/gtk/gtk-sections.txt:
207 * docs/reference/gtk/tmpl/gtkmessagedialog.sgml: documented API
210 2004-10-25 James M. Cape <jcape@ignore-your.tv>
212 Rework of GtkFileChooserButton, some cleanups. Fixes #154388,
213 #154390, #154390, #156272.
215 * docs/reference/gtk/gtk-docs.sgml: Moved GtkFileChooserButton
216 below GtkFileChooser.
217 * docs/reference/gtk/gtk-sections.txt: Added
218 gtk_file_chooser_button_get_width_chars(),
219 gtk_file_chooser_button_set_width_chars(),
220 gtk_label_set_width_chars(), gtk_label_get_width_chars().
221 * docs/reference/gtk/gtk.types: Added
222 gtk_cell_renderer_combo_get_type,
223 gtk_cell_view_get_type,
224 gtk_text_iter_get_type.
225 * docs/reference/gtk/tmpl/gtkaboutdialog.sgml: Add
226 "logo-icon-name" property.
227 * docs/reference/gtk/tmpl/gtkcellview.sgml: Updates for properties
228 (b/c of get_type() inclusion above).
229 * docs/reference/gtk/tmpl/gtkfilechooserbutton.sgml:
230 * docs/reference/gtk/tmpl/gtklabel.sgml: Add "width-chars" property,
232 * docs/reference/gtk/tmpl/gtkcellrenderercombo.sgml: Added.
233 * gtk/gtkentrycompletion.c:
234 (_gtk_entry_completion_popdown): Don't show if the entry isn't
236 * gtk/gtkfilechooserbutton.[c,h]: (*): About 45%
237 rewritten, adds "width-chars" property, icons, working save modes,
238 volume/Home/Desktop friendly-naming support.
239 * gtk/gtklabel.[c,h]:
240 (gtk_label_class_init), (gtk_label_init),
241 (gtk_label_get_property), (gtk_label_set_property),
242 (gtk_label_get_width_chars), (gtk_label_set_width_chars),
243 (gtk_label_size_request): Add "width-chars" property.
244 * tests/testfilechooserbutton.c: Update, use 4 different buttons for
245 the different ACTIONs.
246 * gtk/.cvsignore: Ignore gtk-update-icon-cache.
247 * tests/.cvsignore: Ignore testimage.
249 2004-10-25 Matthias Clasen <mclasen@redhat.com>
251 * gtk/gtkcellrenderercombo.c (find_text): Don't leak text. (#156325,
254 2004-10-25 Anders Carlsson <andersca@imendio.com>
258 * gdk/x11/gdkdisplay-x11.c:
259 (gdk_display_supports_clipboard_persistence),
260 (gdk_display_store_clipboard):
261 New API to handle the clipboard manager.
264 * gtk/gtkclipboard.c: (gtk_clipboard_class_init),
265 (gtk_clipboard_finalize), (selection_clear_event_cb),
266 (clipboard_unset), (gtk_clipboard_set_text),
267 (gtk_clipboard_request_targets), (gtk_clipboard_wait_for_targets),
268 (clipboard_peek), (gtk_clipboard_owner_change),
269 (gtk_clipboard_wait_is_target_available),
270 (gtk_clipboard_store_timeout), (gtk_clipboard_set_can_store),
271 (gtk_clipboard_selection_notify), (gtk_clipboard_store),
272 (_gtk_clipboard_store_all):
273 * gtk/gtkclipboard.h:
274 Add API for clipboard persistence and implement it, also add
275 gtk_clipboard_wait_is_target_available.
277 * gtk/gtkmain.c: (gtk_main):
278 Call _gtk_clipboard_store_all before exiting.
280 2004-10-25 Matthias Clasen <mclasen@redhat.com>
282 * gtk/gtkaboutdialog.h:
283 * gtk/gtkaboutdialog.c (gtk_about_dialog_set_logo_icon_name)
284 (gtk_about_dialog_get_logo_icon_name): Support named icons as
285 logos. (#156378, James Henstridge)
287 * gtk/gtkdialog.c (gtk_dialog_set_alternative_button_order): Fix the
290 * gtk/gtkcellview.[hc]: Make function parameter names consistent.
292 * tests/Makefile.am (noinst_PROGRAMS): Add testimage.
294 * tests/testicontheme.c (main): Use gtk_image_new_from_icon_name().
296 2004-10-25 Matthias Clasen <mclasen@redhat.com>
298 Add a public setting for button ordering (#74669, Owen Taylor)
300 * gtk/gtksettings.c (gtk_settings_class_init): Add a
301 gtk-alternative-button-order setting.
304 * gtk/gtkdialog.c (gtk_alternative_dialog_button_order): A
305 getter for the alternative button order setting.
306 * gtk/gtkdialog.c (gtk_dialog_set_alternative_button_order):
307 New function to install an alternative button order for a
310 * gtk/gtkfilesel.c (gtk_file_selection_init):
311 * gtk/gtkfontsel.c (gtk_font_selection_dialog_init):
312 * gtk/gtkmessagedialog.c (gtk_message_dialog_add_buttons):
313 * gtk/gtkcolorseldialog.c (gtk_color_selection_dialog_init):
314 * gtk/gtkfilechooserdefault.c (location_popup_handler):
315 Set up an alternative button order.
317 2004-10-25 Matthias Clasen <mclasen@redhat.com>
320 * gtk/gtkimage.c (gtk_image_new_from_icon_name)
321 (gtk_image_set_from_icon_name, gtk_image_get_icon_name)
322 (gtk_image_set_pixel_size, gtk_image_get_pixel_size): Add a
323 new type GTK_IMAGE_ICON_NAME for named icons, update the size
324 and content of stock, icon set and named icon images upon style
325 changes, and allow to set a fixed pixel size for named icon
326 images. (#155688, James Henstridge)
328 * tests/testimage.c: Test application for theming behaviour of
329 different image types and for image dnd.
331 2004-10-24 Matthias Clasen <mclasen@redhat.com>
333 * gtk/gtkcellrenderercombo.c: Use G_DEFINE_TYPE, initialize the
334 has_entry property, ref the model and add a finalizer. (#156325,
337 Sun Oct 24 02:56:43 2004 Jonathan Blandford <jrb@redhat.com>
339 * docs/tools/widgets.c: Update GtkFileChooserButton doc shot.
341 2004-10-24 Matthias Clasen <mclasen@redhat.com>
343 * gtk/gtkicontheme.c: Use the new g_key_file api in GLib.
345 * gtk/Makefile.am (gtk_c_sources): Remove gtkiconthemeparser.[hc]
347 * gtk/gtkiconthemeparser.[hc]: Removed.
349 * gtk/gtkfilechooserdefault.c (location_popup_handler): If the
350 location dialog is brought up by typing '/', insert the slash
351 in the entry. (#155370, Warren Togami)
353 2004-10-23 Matthias Clasen <mclasen@redhat.com>
355 * gtk/gtkfilechooserdefault.c (tree_view_keybinding_cb)
356 (trap_activate_cb): Accept shift-/ for bringing up the location
357 popup, since German and French keyboards generate such
358 events. (#154163, Frederic Crozat)
360 * gtk/gtktreeview.c (gtk_tree_view_size_allocate): Invalidate
361 the window if the tree is empty, to avoid resizing artifacts
362 from the focus rectangle. (#155881, Vincent Noel, patch by
365 Sat Oct 23 16:14:37 2004 Søren Sandmann <sandmann@redhat.com>
367 * gtk/gtksequence.c (_gtk_sequence_node_insert_sorted): Remove
368 assertion that can get triggered by broken sort functions.
370 Sat Oct 23 16:07:46 2004 Søren Sandmann <sandmann@redhat.com>
372 * gtk/gtksequence.c (_gtk_sequence_swap): Replace broken, overly
373 clever implementation with one that works.
375 * gtk/gtkliststore.c (gtk_list_store_swap): emit "rows_reordered"
376 instead of "changed" twice.
380 Sat Oct 23 15:17:55 2004 Søren Sandmann <sandmann@redhat.com>
382 * gtk/gtkmenutoolbutton.c (button_state_changed_cb): Remove check
383 for previous state being ACTIVE. Bug 153876.
385 2004-10-22 Matthias Clasen <mclasen@redhat.com>
387 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_drag_data_received)
388 (gtk_file_chooser_button_init): Use the new file DND api.
391 * gtk/gtkdnd.c (gtk_drag_dest_add_uri_targets)
392 (gtk_drag_source_add_uri_targets):
394 * gtk/gtkselection.h:
395 * gtk/gtkselection.c (gtk_target_list_add_uri_targets):
396 (gtk_selection_data_set_uris):
397 (gtk_selection_data_get_uris): New functions to allow
398 handling file DND "without knowing jack shit".
400 * configure.in: Bump glib requirement to 2.5.4.
402 * gtk/gtkfilechooserdefault.c (shortcuts_drop_uris): Use
403 g_uri_list_extract_uris().
405 Fri Oct 22 13:25:25 2004 Owen Taylor <otaylor@redhat.com>
407 * gtk/gtktextbuffer.c (gtk_text_buffer_backspace): Fix
408 backspacing on the empty last line of a buffer
409 (https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=136840,
412 2004-10-22 Matthias Clasen <mclasen@redhat.com>
414 * gtk/gtkdnd.c: Document how to use info with text/image
417 * gtk/gtkselection.h:
418 * gtk/gtkselection.c (gtk_target_list_add_text_targets):
419 (gtk_target_list_add_image_targets): Add info argument.
421 * gtk/gtkcalendar.c (gtk_calendar_motion_notify):
422 * gtk/gtkentry.c (gtk_entry_init):
423 * gtk/gtktextview.c (gtk_text_view_init): Adjust all callers.
425 2004-10-22 Anders Carlsson <andersca@gnome.org>
427 * gtk/gtktexttag.c: (gtk_text_tag_get_property):
428 GdkBitmap is a GObject, not a boxed type.
430 Thu Oct 21 15:01:09 2004 Owen Taylor <otaylor@redhat.com>
434 * gtk/gtkentry.c: Fix checking the wrong position for
435 the backspace_deletes_character PangoLogAttr.
437 * gtk/gtktextbuffer.[ch] gtk/gtk.symbols (gtk_text_buffer_backspace):
438 Move backspace logic from GtkTextView to here, check
439 backspace_deletes_char.
441 * gtk/gtktextview.c: Use gtk_text_buffer_backspace().
443 2004-10-21 Matthias Clasen <mclasen@redhat.com>
445 * gtk/gtkiconcache.c: Include io.h on windows. (#156075,
447 (_gtk_icon_cache_new_for_path): Don't use MAP_FAILED if we don't
450 * gtk/gtkicontheme.c (gtk_icon_theme_has_icon): Implement for
453 * gtk/gtkiconcache.h:
454 * gtk/gtkiconcache.c (_gtk_icon_cache_has_icon): New function.
456 * gtk/updateiconcache.c (scan_directory): Don't skip .icon
457 files which are listed before their images.
458 (foreach_remove_func): Instead filter lonely .icon files out
461 * gtk/gtkicontheme.c (theme_dir_get_icon_suffix): Filter out
462 the HAS_ICON_FILE flag.
464 2004-10-21 Matthias Clasen <mclasen@redhat.com>
466 * gtk/gtkiconcache.c: Make it compile without mmap() and
467 add some more checks. (#155973, Morten Welinder)
469 Add convenience api for image dnd (#150165):
471 * gtk/gtkselection.h:
472 * gtk/gtkselection.c (gtk_target_list_add_image_targets)
473 (gtk_selection_data_set_pixbuf, gtk_selection_data_get_pixbuf):
474 New functions to handle the image formats readable/writable
478 * gtk/gtkdnd.c (gtk_drag_dest_add_image_targets)
479 (gtk_drag_source_add_text_targets): New functions to handle
480 the image formats readable/writable by gdk-pixbuf.
482 2004-10-20 Matthias Clasen <mclasen@redhat.com>
484 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_new): Make
485 the code clearer. (#155239, Murray Cumming)
487 * gtk/gtkicontheme.c: Small fixes.
489 * gtk/gtkrc.c: Include gtkmodules.h. (#155885, Kazuki IWAMOTO)
491 * gtk/gtktoolbar.h: Add _gtk_toolbar_rebuild_menu(). (#155885)
493 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
494 Fix a wrong blurb. (#155838, Morten Welinder)
496 2004-10-19 Matthias Clasen <mclasen@redhat.com>
498 Implement icon theme caching. (#154034, Martijn Vernooij,
499 caching schema proposed by Owen Taylor, initial implementation
503 * gtk/gtkmain.c: Add a "icontheme" debug flag.
505 * gtk/Makefile.am (gtk_c_sources): Add gtkiconcache.c
506 (gtk_private_h_sources): Add gtkiconcache.h
507 (bin_PROGRAMS): Add gtk-update-icon-cache
509 * gtk/gtkicontheme.c: Use icon caches if they are available.
510 Currently, GTK+ uses the cache to get information about the
511 available sizes, image file formats and .icon files. The
512 actual image data, and the .icon file contents are not
515 * gtk/updateiconcache.c: A cmdline utility for generating
518 * gtk/gtkiconcache.h:
519 * gtk/gtkiconcache.c: The glue code to mmap an icon cache
520 file and manage the information it contains.
522 * tests/testicontheme.c: Add a "display" option.
524 2004-10-19 Matthias Clasen <mclasen@redhat.com>
526 * tests/testicontheme.c: Set the locale, tidy up output.
528 2004-10-18 Matthias Clasen <mclasen@redhat.com>
530 Fix #155658, Sebastien Bacher:
532 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Add a new
535 * gdk/x11/gdkwindow-x11.c (update_wm_hints): Set wm hints on
536 leader windows even if they are withdrawn.
537 (gdk_window_set_group): Mark the new leader window as such. We
538 never remove the flag again, but that should a) be vanishingly
539 rare and b) not a problem, since the flag just turns off an
542 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Mark the default
543 leader window as such.
545 2004-10-17 Matthias Clasen <mclasen@redhat.com>
547 * gtk/gtkaboutdialog.c (gtk_about_dialog_new): Destroy secondary
548 dialogs if the main dialog is hidden. (#155084, Paolo Borelli)
550 2004-10-16 Matthias Clasen <mclasen@redhat.com>
552 * gtk/gtkaboutdialog.c (gtk_about_dialog_destroy): Don't leak
553 the secondary dialogs. (#155084, Paolo Borelli)
555 * gtk/gtkhsv.c (gtk_hsv_expose): Fix redraw issues with the
558 2004-10-15 Matthias Clasen <mclasen@redhat.com>
560 * gdk/makegdkalias.pl: Include linux-fb/gdkfb.h when building
561 the framebuffer backend. (#155486, Olexiy Avramchenko)
563 2004-10-15 Matthias Clasen <mclasen@redhat.com>
565 * gtk/gtksizegroup.c (do_size_request): Unset GTK_REQUEST_NEEDED
566 before emitting ::size-request, following this weeks discussion
567 on gtk-devel-list@gnome.org.
569 * gtk/gtkcellview.c (gtk_cell_view_get_size_of_row): Restore
570 the size info for the current row after measuring another
571 row. (#154945, William Jon McCann)
573 2004-10-14 Matthias Clasen <mclasen@redhat.com>
575 * gtk/gtkfilechooserdefault.c (shortcuts_remove_rows): Don't
576 get text unnecessarily. (#155384, Morten Welinder)
577 (gtk_file_chooser_default_finalize): Don't forget to
578 unref the tooltips. (#155412, Morten Welinder)
579 (shortcuts_add_current_folder): Don't leak volume. (#155400,
582 2004-10-12 Matthias Clasen <mclasen@redhat.com>
584 * gtk/gtkcontainer.c (_gtk_container_queue_resize): Acknowledge
585 the fact that invariants are broken and loop all the way up to
586 the resize container.
588 Tue Oct 12 17:11:02 2004 <timj@birnet.org>
590 * gtk/gtkwidget.c (gtk_widget_set_usize_internal): don't queue the
591 widget for resize or emit change notification if the usize didn't
592 change. this works around a buggy signal connection in #155139.
594 2004-10-11 Matthias Clasen <matthias@localhost.localdomain>
596 * docs/tools/widgets.c: Create scrolledwindow, statusbar,
597 scale and image images.
599 2004-10-10 Matthias Clasen <matthias@localhost.localdomain>
601 * docs/tools/widgets.c: Create a toolbar, menubar, progressbar,
602 notebook and messagedialog images.
604 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_select_all):
607 Sun Oct 10 11:24:56 2004 Jonathan Blandford <jrb@redhat.com>
609 * gtk/gtkcontainer.h (struct _GtkContainer): add /*< private >*/
612 2004-10-09 Matthias Clasen <mclasen@redhat.com>
614 * docs/tools/widgets.c: Shrink panes and separators images to MEDIUM.
616 * gtk/gtkcellview.c: Add docs.
618 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_get_menu): Fix
621 * gtk/gtkactiongroup.h:
622 * gtk/gtkactiongroup.c: Reinstate the accidentally lost addition
623 of gtk_action_group_translate_string().
625 * gtk/gtkaccelgroup.h: Declare gtk_accelerator_get_label.
627 2004-10-08 Matthias Clasen <mclasen@redhat.com>
629 * gdk/x11/gdkx.h: Declare gdk_x11_window_set_user_time here.
631 * gtk/gtktreeview.c (gtk_tree_view_grab_notify): Don't start a
632 drag if we loose the grab.
634 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Set the cell
635 renderer to inert mode to avoid bug #154921. This fixes a crash
636 which would otherwise occur if the editing is stopped for the second
637 time. (#154767, Manuel Baena GarcĂa)
640 * gtk/gtkwidget.c (gtk_widget_size_allocate): Add a new debug
641 flag, geometry, to debug size allocation.
643 * gtk/gtktreeview.c (gtk_tree_view_button_press): Set cell data
644 unconditionally. (#152562, Federico Mena Quintero)
646 2004-10-08 Matthias Clasen <mclasen@redhat.com>
648 * gtk/gtkuimanager.c (update_node): Also update smart separators
649 if the visibility of a menuitem with a submenu changes. (#153791,
652 2004-10-08 Matthias Clasen <mclasen@redhat.com>
656 * gtk/gtkentrycompletion.c:
657 * gtk/gtkspinbutton.c: Share the three copies of get_borders()
658 under the name _gtk_entry_get_borders(). (#116368, Owen Taylor)
660 2004-10-07 Matthias Clasen <mclasen@redhat.com>
662 * gtk/gtkfilechooserdefault.c (check_is_folder): Don't free
663 info too early. (#154703, Morten Welinder)
665 * gtk/gtkfilechooserdefault.c: Include gtkeventbox.h.
666 (#154798, Morten Welinder)
668 2004-10-06 Matthias Clasen <mclasen@redhat.com>
670 * gtk/gtkpaned.c (gtk_paned_compute_position): Reduce rounding
671 error. (#154658, John Cupitt)
673 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Clear
674 the iter instead of returning it unmodified. (#154186, Jonathan Blandford)
676 * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_focus): Pop up
677 the completions again after tab. (#147700, Jens Bech Madsen)
679 * gtk/gtktreeview.c (gtk_tree_view_search_iter): Set the cursor
680 before changing the selection to make the file chooser preview
681 update work better. (#143826, Tommi Komulainen)
683 2004-10-06 Matthias Clasen <mclasen@redhat.com>
685 * gtk/gtkrange.c (gtk_range_real_change_value): Replace a really
686 gross way of rounding to a specified number of digits. (#145232,
687 Peter Zelezny, patch by Soeren Sandmann)
689 Wed Oct 6 00:45:04 2004 <timj@birnet.org>
691 * gdk/gdkwindow.c (gdk_window_is_viewable): check the iteration window
692 variable, not just the window passed in. fixes #145270.
694 Tue Oct 5 21:00:54 2004 Tim Janik <timj@gtk.org>
696 * gtk/gtkwidget.c (gtk_widget_size_allocate): reverted my last change
697 and applied owen's leaner conditional flag update which should be good
698 enough to preserve resizing flag invariants.
700 2004-10-05 Matthias Clasen <mclasen@redhat.com>
704 Tue Oct 5 19:29:06 2004 Tim Janik <timj@gtk.org>
706 * gtk/gtkentry.h: removed redundant gtk_entry_get_layout() decl.
708 2004-10-05 Matthias Clasen <mclasen@redhat.com>
710 * gtk/gtkicontheme.c (icon_info_ensure_scale_and_pixbuf): Go back to
711 not scaling up at all. Less magic.
713 Tue Oct 5 17:06:26 2004 Tim Janik <timj@gtk.org>
715 * gtk/gtkwidget.c (gtk_widget_size_allocate): if REQUEST_NEEDED is still
716 set on ::size-allocate, another size-request has been queued since
717 ::size-request and needs to be requeued.
719 2004-10-05 Paolo Borelli <pborelli@katamail.com>
721 * gtk/gtkmenutoolbutton.c: rename the activate-menu signal to
722 show-menu as discussed in bug #153873.
724 2004-10-05 Matthias Clasen <mclasen@redhat.com>
726 * gtk/gtkuimanager.c (gtk_ui_manager_add_ui): Set
727 action_name. (#154526, John Finlay)
729 * gdk/x11/gdkwindow-x11.c (gdk_window_foreign_new_for_display):
730 Return a new reference to an existing GdkWindow if one already
731 exists. (#151378, Gustavo Carneiro)
733 2004-10-05 Matthias Clasen <mclasen@redhat.com>
735 Provide access to the string representation of accelerators used
736 in GtkAccelLabel. (#154068, John Spray)
738 * gtk/gtkaccelgroup.h:
739 * gtk/gtkaccelgroup.c (gtk_accelerator_get_label): New function
740 to return the accelerator label used in GtkAccelLabel.
741 (gtk_accelerator_name): Update docs to point to
742 gtk_accelerator_get_label().
743 * gtk/gtkaccellabel.h:
744 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
745 New auxiliary function which creates the string representing the
748 2004-10-05 Matthias Clasen <mclasen@redhat.com>
750 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Resize the
751 popup if a new model is set. (#154129, Bernd Demian)
753 2004-10-04 Matthias Clasen <mclasen@redhat.com>
755 * gtk/gtkicontheme.c (icon_info_ensure_scale_and_pixbuf):
756 Make the code work as intended for unthemed icons; don't scale
757 them up too much. Allow to scale them down, and do so
758 exactly. (#154142, Ross Burton)
759 (gtk_icon_info_load_icon): Amend docs.
761 * gtk/gtkcelllayout.c (gtk_cell_layout_clear): Improve
762 docs. (#154504, Dave Cook)
764 * gtk/gtkwindow.c (gtk_window_set_icon_list):
765 (gtk_window_set_default_icon_list): Ref the new icons
766 before unreffing the old ones. (#154468, Morten Welinder)
767 (gtk_window_realize_icon): Only set using_themed_icon if
768 we actually got an icon list from the theme. (#154472, Morten
771 2004-10-03 Matthias Clasen <mclasen@redhat.com>
773 * gtk/gtkiconview.c (gtk_icon_view_set_model): Reset pointers
774 pointing to the old model. (#154350)
776 * gtk/gtkwindow.c (icon_list_from_theme): Don't leak the
777 sizes array. (#154310, Christian Persch)
779 * gtk/gtktreeviewcolumn.c
780 (gtk_tree_view_column_setup_sort_column_id_callback):
781 Set sort_indicator to FALSE when appropriate. (#153714,
782 Reinout van Schouwen)
784 * gtk/gtktreeview.c (gtk_tree_view_search_position_func):
785 Fix positioning near the monitor boundaries. (#154341,
788 2004-10-01 Paolo Borelli <pborelli@katamail.com>
790 * gtk/gtkmenutoolbutton.c: deactivate the menu before setting it
791 to something else. Bug #153887.
793 2004-10-01 Matthias Clasen <mclasen@redhat.com>
797 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size): Fix the
798 calculation of x_offset when ellipsized and in RTL mode.
799 (gtk_cell_renderer_text_render): Fix the calculation of the layout
800 width when ellipsized.
802 2004-10-01 Tor Lillqvist <tml@iki.fi>
804 * gdk/win32/gdkglobals-win32.c: Set _gdk_input_ignore_wintab to
805 FALSE, thus enabling tablet input by default.
807 * gdk/win32/gdkmain-win32.c (_gdk_windowing_args): Accept the
808 --use-wintab option again (but without effect, as this is now the
809 default, see above). (#153788)
811 * modules/input/gtkimcontextime.c: Numerous changes.
813 Remove the ifdef UNICODE conditionals. Always use the
814 wide-character Imm* API. It is present also in Windows 98 and
815 Me. (Not Windows 95, but I think we don't care about that.) Using
816 the multibyte API wouldn't work anyway on systems where the system
817 codepage doesn't support the language the user uses an IME for, so
818 for instance I wouldn't be able to test this module on my English
819 Windows 2000 although I do have C, J and K IMEs available.
821 Guard against IMM not being active, always check ImmGetContext()
822 returning NULL. Work to some extent even without any IME. Fixes
823 #153800 at least partially.
825 * modules/input/imime.c (ime_info): Rename to "ime" to match the
826 naming pattern of other input modules. Make it default for
829 2004-10-01 Matthias Clasen <mclasen@redhat.com>
831 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Add a comment regarding
832 cell renderers to the docs.
834 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear_attributes):
835 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_clear_attributes):
836 Silently ignore info being NULL. This is unavoidable with the
837 current design where we have every implementation of layout_clear
838 call layout_clear_attributes, and also delegate calls to dependent
839 cell layouts. (#154191, Martyn Russell)
841 2004-10-01 Matthias Clasen <mclasen@redhat.com>
843 * modules/input/iminuktitut.c: Fix the spelling of Inuktitut
844 in several places. (#154176, John Austin)
846 2004-09-30 Paolo Borelli <pborelli@katamail.com>
848 * tests/testellipsize.c: exit on close.
850 2004-09-29 Matthias Clasen <mclasen@redhat.com>
852 * gtk/gtkmain.c: Make --g-fatal-warnings a G_OPTION_ARG_NONE,
853 since it doesn't take an argument.
855 2004-09-29 Christopher Blizzard <blizzard@redhat.com>
857 * gtk/gtkmenutoolbutton.h: Remove trailing semicolon on
860 2004-09-29 Paolo Borelli <pborelli@katamail.com>
862 * tests/testtoolbar.c: add a GtkMenuToolButton.
864 2004-09-29 Matthias Clasen <mclasen@redhat.com>
866 * gtk/gtkiconview.c (gtk_icon_view_move_cursor_left_right)
867 (gtk_icon_view_move_cursor_start_end)
868 (gtk_icon_view_move_cursor_page_up_down)
869 (gtk_icon_view_move_cursor_up_down): Handle an empty icon
870 view gracefully. (#152486)
872 Allow keynav to selectable labels (#138085, David Hawthorne):
874 * gtk/gtkdialog.c (gtk_dialog_map): Skip selectable labels when
875 looking for the initial focus widget.
877 * gtk/gtklabel.c (gtk_label_focus): Remove to put selectable labels
878 in the regular focus chain again.
880 2004-09-28 Matthias Clasen <mclasen@redhat.com>
882 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render): Don't
883 reuse insensitive pixbufs across multiple rows. (#153984, Milosz
886 * gtk/gtkmain.c (gtk_parse_args): Use gtk_get_option_group()
887 to obtain an option group with correctly set pre- and post-
888 parse hooks, instead of manually calling the hooks. This fixes
889 a problem with setting the program class in the gdk preparse
890 hook. (#153788, Robert Ă–gren)
892 2004-09-27 Matthias Clasen <mclasen@redhat.com>
896 * gtk/gtkmain.c (do_pre_parse_initialization): Don't call gdk_parse_args()
897 here, we don't want to parse args twice.
898 (gtk_init_with_args): Add the ugid check here as well.
899 (gtk_parse_args): Add the gdk options to the main option group as well.
901 2004-09-27 Paolo Borelli <pborelli@katamail.com>
905 * gtk/gtkmenutoolbutton.[ch]: add the GtkMenuToolButton widget
906 discussed in bug #151441.
908 * docs/reference/gtk/gtk-docs.sgml:
909 * docs/reference/gtk/gtk-sections.txt:
910 * docs/reference/gtk/gtk.types:
911 * docs/reference/gtk/tmpl/gtkmenutoolbutton.sgml: docs for the
914 2004-09-27 Matthias Clasen <mclasen@redhat.com>
916 * gtk/gtkfilesystemunix.c (gtk_file_folder_unix_list_children):
917 Emit ::finished-loading.
919 2004-09-27 Roozbeh Pournader <roozbeh@farsiweb.info>
921 * configure.in: Added Iranian Azerbaijani (az_IR) to ALL_LINUGAS.
923 2004-09-27 Matthias Clasen <mclasen@redhat.com>
925 * gtk/gtktreeview.c (gtk_tree_view_append_column): Fix typo in
926 docs. (#153811, Billy Biggs)
928 * gtk/gtkpathbar.h (struct _GtkPathBar): Only need a bit for
931 2004-09-26 Matthias Clasen <mclasen@redhat.com>
933 * gtk/gtknotebook.c (gtk_notebook_class_init): Add a missing _
934 to the name of the has_secondary_backward_stepper property.
935 Noticed by Michèle Garoche.
937 Sun Sep 26 02:06:43 2004 Jonathan Blandford <jrb@gnome.org>
939 * gtk/gtkpathbar.h (struct _GtkPathBar): add missing structures.
941 2004-09-26 Matthias Clasen <mclasen@redhat.com>
943 * gtk/gtkpathbar.c (gtk_path_bar_check_parent_path): Scroll
944 to make the current folder visible. (#152921)
946 * gtk/gtkbutton.c: Revert the button state to !button_down,
947 if we're missing the release event due to grab shadowing
950 * gtk/gtkpathbar.c: Make the slider buttons scroll.
952 * gtk/gtkfilechooserdefault.c (shortcuts_remove_rows): Remove
954 (bookmarks_check_remove_sensitivity): Don't free an uninitialized
957 * gtk/gtkimcontext.c (gtk_im_context_get_preedit_string):
958 cursor_pos is in characters, not bytes. (#153332, Owen Taylor)
960 2004-09-25 Robert Ă–gren <gtk@roboros.com>
962 * gdk/win32/gdkinput-win32.c (gdk_input_wintab_init): Set
963 lcSysOrgX and lcSysOrgY from device instead of hardcoding to 0,
964 a further fix for bug #145467.
966 2004-09-25 Matthias Clasen <mclasen@redhat.com>
968 * gtk/gtktextiter.c (inside_word_func): Don't access
969 attr[-1]. (#153628, Padraig O'Briain)
971 2004-09-23 Matthias Clasen <mclasen@redhat.com>
973 * gtk/gtkfilechooserdefault.c: Add some tooltips.
975 2004-09-22 Matthias Clasen <mclasen@redhat.com>
977 * gtk/gtkrange.c (gtk_range_map, gtk_range_unmap):
978 * gtk/gtkbutton.c (gtk_button_map, gtk_button_unmap): Remove
979 unnecessary g_return_if_fail()s from virtual functions. (#153469,
982 * gtk/gtkaboutdialog.c (gtk_about_dialog_finalize): Don't leak
983 cursors. (#153468, Christian Persch)
985 * gtk/gtktreeview.c (gtk_tree_view_key_press): Don't leak old_text.
986 (#153467, Christian Persch)
988 * gtk/gtkfilechooserdefault.c (selection_check_foreach_cb): Don't use
990 (gtk_file_chooser_default_should_respond): Make it easier to
991 select folders in SELECT_FOLDER mode.
993 Wed Sep 22 00:54:34 2004 Matthias Clasen <mclasen@redhat.com>
995 * demos/gtk-demo/pixbufs.c (do_pixbufs): Don't leak the frame
998 Tue Sep 21 16:55:38 2004 Manish Singh <yosh@gimp.org>
1000 * tests/testtreemodel.c: #include <config.h> for HAVE_MALLINFO define,
1001 other minor cleanups.
1003 Tue Sep 21 16:27:19 2004 Manish Singh <yosh@gimp.org>
1005 * gdk/gdk.c: remove now unused arg variables.
1007 * gdk/gdkinternals.h: declare _gdk_windowing_init ().
1009 * gtk/gtkmain.c (do_pre_parse_initialization): call gdk_parse_args ()
1010 here instead of gdk_pre_parse_libgtk_only (). Should fix #153082.
1012 2004-09-21 Matthias Clasen <mclasen@redhat.com>
1014 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_should_respond):
1015 Don't assert that current_focus != NULL, just return FALSE.
1017 * gtk/gtkpathbar.c (gtk_path_bar_size_request): Give the path
1018 bar arrows some more space.
1020 * configure.in: Check for mallinfo.
1022 * tests/testtreemodel.c: Only include malloc.h if HAVE_MALLINFO
1023 is defined. (#153168, Darren Creutz)
1025 * gtk/gtkactiongroup.c: Fix typos in signal docs. (#153224,
1028 Mon Sep 20 19:44:58 2004 Matthias Clasen <mclasen@redhat.com>
1030 * gtk/gtkfilechooserdefault.c (shortcuts_activate_iter): Don't
1031 return FALSE from a void function. (#153185, Joel Fredrikson)
1033 2004-09-20 Matthias Clasen <mclasen@redhat.com>
1035 * gtk/gtkbutton.c (gtk_button_class_init): Add a boolean ::displace-focus
1036 style property and apply child displacement to the focus rectangle
1037 if it is TRUE. (#141170, Soeren Sandmann)
1039 Sun Sep 19 23:56:18 2004 Søren Sandmann <sandmann@redhat.com>
1041 * gtk/gtkmenu.c (MENU_SCROLL_TIMEOUT2): Change from 50 to 20 to
1042 make the menus scroll faster.
1044 2004-09-19 Matthias Clasen <mclasen@redhat.com>
1046 * configure.in: Bump version
1048 * === Released 2.5.3 ===
1050 2004-09-18 Matthias Clasen <mclasen@redhat.com>
1052 Make GtkFileChooserButton activatable via mnemonics.
1053 (#152925, Dennis Cranston, patch by James M. Cape)
1055 * gtk/gtkfilechooserbutton.c: Add a ::mnemonic-activate signal
1056 and a suitable default handler.
1058 * tests/testfilechooserbutton.c: Add a mnemonic.
1060 2004-09-18 Matthias Clasen <mclasen@redhat.com>
1062 Fix win32 build errors. (#153032, #153028, Robert Ă–gren)
1064 * gdk/win32/gdkmain-win32.c: Make it compile.
1066 * gtk/gtkmain.c: Include glib.h.
1068 2004-09-18 Federico Mena Quintero <federico@ximian.com>
1072 * gtk/gtkfilesystem.h: Removed the GTK_FILE_PATH() and
1073 GTK_IS_FILE_PATH() macros. They are not supposed to exist, as
1074 GtkFilePath is not an object. And they never worked, anyway.
1076 2004-09-18 Marco Pesenti Gritti <marco@gnome.org>
1078 * gtk/gtkentry.c: (gtk_entry_completion_key_press):
1080 Make numeric pad enter activate the selected completion
1081 entry. Fix bug 143486 reported by Edd Dumbill.
1083 2004-09-17 Matthias Clasen <mclasen@redhat.com>
1087 * gtk/gtkfilechooserdefault.c (select_func): Scroll to the selected
1088 row. (#143868, Christian Persch)
1090 2004-09-17 Matthias Clasen <mclasen@redhat.com>
1092 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render): Remove
1093 leftover debug code.
1095 Improve the behaviour of the file chooser in save mode. Fixes bugs
1096 #151031, #151608, #151994 reported by Owen Taylor and Alexander
1099 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_set_property):
1100 (location_entry_create): Propagate the action to the file
1102 (gtk_file_chooser_default_should_respond): Switch folders if
1103 the user enters a directory name in the entry and clear the entry
1104 after switching folders.
1105 (gtk_file_chooser_default_should_respond, shortcuts_row_activated_cb):
1106 Move focus to the file list when activating a shortcut.
1107 (gtk_file_chooser_default_should_respond): Handle the case where the
1108 user clicks on "Save" after selecting a folder in the file list.
1110 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_set_property):
1111 Propagate the action to the file chooser entries.
1113 * gtk/gtkfilechooserentry.h:
1114 * gtk/gtkfilechooserentry.c (_gtk_file_chooser_entry_set_action):
1115 (_gtk_file_chooser_entry_get_action): New functions to propagate
1116 the GtkFileChooserAction of the file chooser to the file chooser
1118 (check_completion_callback): If we are in save mode, only do
1119 inline completion for directories.
1121 Fri Sep 17 11:20:03 2004 Jonathan Blandford <jrb@gnome.org>
1123 * gtk/gtklabel.c (gtk_label_set_markup): Add an example to the
1126 Thu Sep 16 23:20:05 2004 Matthias Clasen <maclas@gmx.de>
1128 * gtk/gtkselection.c (selection_get_text_plain):
1129 * gdk/x11/gdkselection-x11.c (make_list): Warn if a UTF8_STRING
1130 or text/plain;charset=utf-8 roperty contains invalid
1131 UTF-8. (#152845, Owen Taylor)
1133 2004-09-16 Matthias Clasen <mclasen@redhat.com>
1135 Fix #152760, Christian Persch:
1137 * gtk/gtkaboutdialog.c (gtk_about_dialog_finalize): Don't free
1139 (gtk_about_dialog_set_translator_credits): Recommend the msg
1140 id translator-credits.
1141 (display_credits_dialog): Show translator credits if they're
1142 translated, not if they're untranslated.
1144 Thu Sep 16 02:07:56 2004 Jonathan Blandford <jrb@gnome.org>
1146 * docs/tools/widgets.c (create_icon_view): load images at normal
1149 * docs/reference/gtk/images/*png: Update shots.
1151 Thu Sep 16 00:33:11 2004 Jonathan Blandford <jrb@gnome.org>
1153 * docs/tools/widgets.c (new_widget_info): Add constrained sizing
1154 to the widgets. This gives us all images running the same size,
1155 which will make the table layout look better.
1157 2004-09-15 Tor Lillqvist <tml@iki.fi>
1159 * gdk/win32/gdkwindow-win32.c (gdk_window_get_frame_extents):
1160 Remove bogus code that tried to do what the X11 backend does in
1161 its version of this function. There are no "frame windows" (for
1162 toplevel window decoration) on Windows. The desktop ("root")
1163 window is not the parent of a toplevel window. (#152481)
1165 2004-09-15 Matthias Clasen <mclasen@redhat.com>
1169 Wed Sep 15 00:57:37 2004 Matthias Clasen <maclas@gmx.de>
1171 * docs/tools/widgets.c: Add accel label, file button
1174 Tue Sep 14 22:01:49 2004 Matthias Clasen <maclas@gmx.de>
1176 * configure.in: New option --disable-visibility to disable
1177 the use of ELF visibility attributes for PLT reduction.
1179 * gtk/makegtkalias.pl:
1180 * gdk/makegdkalias.pl: Respect the DISABLE_VISIBILITY
1183 Tue Sep 14 23:20:56 2004 Søren Sandmann <sandmann@redhat.com>
1185 * gtk/gtkaction.c (connect_proxy): Call
1186 gtk_tool_item_rebuild_menu().
1188 * gtk/gtktoolitem.c (gtk_tool_item_class_init): Update
1189 documentation for GtkToolItem::create_menu_proxy.
1191 * gtk/gtktoolitem.c (gtk_tool_item_rebuild_menu): New
1192 API to make the toolbar update itself when the proxy menu item
1193 for a tool item changes.
1195 * gtk/gtktoolbutton.c (gtk_tool_button_construct_contents): Call
1196 gtk_tool_item_rebuild_menu here()
1198 * gtk/gtktoolbutton.c (gtk_tool_button_construct_contents):
1199 Remove redundant check for need_label.
1201 2004-09-14 Matthias Clasen <mclasen@redhat.com>
1203 * gtk/gtkmain.c (do_post_parse_initialization): Remove an unused
1204 variable, spotted by Morten Welinder.
1206 * gtk/queryimmodules.c (escape_string): Copy code from queryloaders.c
1207 which turns backslashes in slashes on win32. (#152608, Kazuki IWAMOTO)
1209 * gtk/gtktreeview.c (gtk_tree_view_focus_to_cursor): Set the cursor
1210 to the first selected row instead of always to the first row if there
1211 is no cursor. (#143270, Jean Bréfort)
1213 * tests/testfilechooser.c (main): Fix a few typos.
1215 2004-09-13 Matthias Clasen <mclasen@redhat.com>
1217 * gtk/gtkexpander.c:
1218 * gtk/gtktreeview.c: Change the default expander size to 12 to compensate
1219 for the recent change to gtk_default_draw_expander().
1221 * gtk/gtkstyle.c (gtk_default_draw_expander): Use a linewidth of one
1222 for expander sizes up to 16
1224 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_model): Resize the
1225 popup if the model is replaced. (#152333)
1227 Mon Sep 13 09:11:53 2004 Manish Singh <yosh@gimp.org>
1229 * gtk/gtkrange.c: fix gtk_range_real_change_value args. Addresses part
1232 2004-09-13 Matthias Clasen <mclasen@redhat.com>
1234 Fix some problems reported by Morten Welinder:
1236 * gtk/gtkfilesystem.c: Include gtkmodules.h, not gtkmain.h, since
1237 the modules stuff moved.
1239 * gtk/gtkmain.c (gtk_arg_no_debug_cb): Add a missing return
1241 * gtk/gtksettings.c: Add missing include.
1242 (settings_update_modules): Remove an unused variable.
1244 2004-09-13 Matthias Clasen <mclasen@redhat.com>
1246 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1247 Improve positioning of entry completion popup.
1249 2004-09-09 Matthias Clasen <mclasen@redhat.com>
1251 * gtk/makegtkalias.pl:
1252 * gdk/makegdkalias.pl: Use the short prefix "IA__" for
1253 aliases instead of the long suffix "__internal_alias".
1255 * tests/testfilechooser.c (main): Update sensitivity of the "Select all"
1258 Wed Sep 8 18:38:08 2004 Soeren Sandmann <sandmann@redhat.com>
1260 Make dropping of expandable items look nicer.
1262 * gtk/gtktoolbar.c (gtk_toolbar_set_drop_highlight_item): Make
1263 placeholder expand if highlight item is expanding.
1265 * gtk/gtktoolbar.c (toolbar_content_set_expand): New function.
1267 * gtk/gtktoolbar.c (toolbar_content_get_expand): Return TRUE only
1268 if the item is not disappering.
1270 2004-09-07 Matthias Clasen <mclasen@redhat.com>
1272 * gtk/gtkuimanager.c (gtk_ui_manager_add_ui): Use the proper node type
1273 for placeholders in toolbars. (#151963, Olivier Andrieu)
1275 * gtk/gtkstyle.c (gtk_default_draw_expander): Draw expanders a bit
1278 Sun Sep 5 17:14:16 2004 Matthias Clasen <maclas@gmx.de>
1282 * gdk/x11/gdkmain-x11.c:
1283 * gdk/win32/gdkmain-win32.c: Add descriptions for the
1284 commandline arguments. The actual descriptions are mostly
1285 taken from libbonoboui, so translators should be able to
1286 copy existing translations from there.
1288 2004-09-05 Anders Carlsson <andersca@gnome.org>
1294 2004-09-05 Anders Carlsson <andersca@gnome.org>
1296 * gdk/gdk.c: (gdk_arg_class_cb), (gdk_arg_name_cb),
1297 (gdk_add_option_entries_libgtk_only), (gdk_pre_parse_libgtk_only),
1300 * gdk/gdkinternals.h:
1301 * gdk/linux-fb/gdkmain-fb.c: (_gdk_windowing_init):
1302 * gdk/win32/gdkmain-win32.c: (_gdk_windowing_init):
1303 * gdk/x11/gdkdisplay-x11.c: (gdk_display_open):
1304 * gdk/x11/gdkmain-x11.c: (_gdk_windowing_init):
1305 * gtk/gtkmain.c: (gtk_arg_debug_cb), (gtk_arg_no_debug_cb),
1306 (gtk_arg_module_cb), (gtk_arg_warnings_cb),
1307 (do_pre_parse_initialization), (do_post_parse_initialization),
1308 (pre_parse_hook), (post_parse_hook), (gtk_get_option_group),
1309 (gtk_init_with_args), (gtk_parse_args):
1311 Make gtk argument parsing use goption. Add gtk_get_option_group and
1314 * tests/testtreemodel.c: (main):
1315 Use gtk_init_with_args.
1317 Sun Sep 5 01:04:01 2004 Matthias Clasen <maclas@gmx.de>
1319 Allow sorting of tree models to be turned off
1320 again. (#151139, Torsten Schoenfeld)
1322 * gtk/gtktreesortable.h:
1323 Add GTK_TREE_SORTABLE_UNSORTED_SORT_COLUMN_ID.
1325 * gtk/gtktreestore.c (gtk_tree_store_sort):
1326 * gtk/gtkliststore.c (gtk_list_store_sort): Don't sort if
1327 the list store is not sorted.
1329 Sat Sep 4 23:37:56 2004 Matthias Clasen <maclas@gmx.de>
1331 * configure.in: Fix the Solaris Xinerama checks. (#151754)
1333 Sat Sep 4 22:45:49 2004 Matthias Clasen <maclas@gmx.de>
1335 * gtk/gtkentry.c (gtk_entry_backspace): Don't refuse to delete
1336 text in passwords. (#151723, Owen Taylor)
1338 Sat Sep 4 16:51:00 2004 Søren Sandmann <sandmann@redhat.com>
1340 * gdk/x11/gdkevents-x11.c (gdk_event_prepare): Revert accidental
1341 change from Aug 02 that removed a flush of the X connection from
1342 gdk_event_prepare() causing applications to get stuck. (#151732,
1345 Fri Sep 3 22:45:03 2004 Matthias Clasen <maclas@gmx.de>
1347 * gtk/gtkuimanager.c (print_node): Don't print out attributes
1348 for the <ui> root node. (#151752, Lorenzo Gil SĂ¡nchez)
1350 Sat Sep 4 02:38:57 2004 Søren Sandmann <sandmann@redhat.com>
1352 * gtk/gtktoolbar.c (position): Accelerate the animation when it
1353 has been running for a while. (#143647).
1355 2004-09-03 Tor Lillqvist <tml@iki.fi>
1357 * gtk-zip.sh.in: List the three theme gtkrc files separately, zip
1358 doesn't do anything if one of the files on its command line
1361 Handle changes of screen resolution on Win32. (#151581, reported by
1364 * gdk/win32/gdkwindow-win32.c (_gdk_windowing_window_init,
1365 _gdk_root_window_size_init): Factor out setting the root window's
1366 size (as the size of the union of all monitors) to a new function.
1368 * gdk/win32/gdkdisplay-win32.c (gdk_display_open,
1369 _gdk_monitor_init): Factor out the monitor query to a new
1372 * gdk/win32/gdkprivate-win32.h: Declare above new functions.
1374 * gdk/win32/gdkevents-win32.c (gdk_event_translate,
1375 handle_display_change): Handle WM_DISPLAYCHANGE by calling the
1376 above two functions, and emitting the "size_changed" signal on our
1379 2004-09-01 Matthias Clasen <mclasen@redhat.com>
1381 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible):
1382 Document the return value.
1384 2004-09-01 Matthias Clasen <mclasen@redhat.com>
1386 Make it possible to specify additional modules to load
1387 via a setting. (#117236, Alex Graveley)
1390 * gtk/gtkmodules.c: New files which contain the module
1391 handling code which was previously in gtkmain.[hc].
1392 Additionally, the code now looks for the gtk-modules
1393 setting, which can specify additional modules to load.
1396 * gtk/gtkmain.h: Remove all the module handling code.
1398 * gtk/gtkdebug.h: Add a debug flag for modules.
1400 * gtk/gtk.h: Include gtkmodules.h
1402 * gtk/Makefile.am (gtk_public_h_sources): Add gtkmodules.h
1403 (gtk_c_sources): Add gtkmodules.c
1405 * gtk/gtksettings.c: Add the gtk-modules setting.
1407 * gdk/x11/gdkevents-x11.c: Add the Gtk/Modules XSetting.
1409 Wed Sep 1 19:11:44 2004 Søren Sandmann <sandmann@redhat.com>
1411 * gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Make sure
1412 children of the toolbar are given positive dimensions. (149540,
1415 2004-09-01 Matthias Clasen <mclasen@redhat.com>
1417 * gtk/gtkfilesystemunix.c:
1418 * gtk/gtkfilechooserbutton.c: Protect the unistd.h include
1421 Wed Sep 1 02:38:48 2004 Matthias Clasen <maclas@gmx.de>
1423 * gtk/gtkaccellabel.c (gtk_accel_label_expose_event): Make
1424 accel labels ellipsize correctly. (#151559, Christian Persch)
1426 Wed Sep 1 00:55:56 2004 Matthias Clasen <maclas@gmx.de>
1428 * gtk/gtkimage.c (gtk_image_clear): Don't leak the iter
1429 of a running animation. (#151542)
1431 Tue Aug 31 23:40:29 2004 Matthias Clasen <maclas@gmx.de>
1433 * gdk/win32/gdkproperty-win32.c (gdk_screen_get_setting): Make
1434 "ms-windows" the default theme on Win32.
1436 Tue Aug 31 23:24:49 2004 Matthias Clasen <maclas@gmx.de>
1438 * gtk/gtkcalendar.c (gtk_calendar_main_button): Only start
1439 a drag if the left button is pressed. (#151490, Frederic Croszat)
1441 Tue Aug 31 23:20:58 2004 Matthias Clasen <maclas@gmx.de>
1443 * gdk/x11/gdkdnd-x11.c (gdk_drop_finish): Remove debug spew.
1445 Tue Aug 31 17:07:41 2004 Jonathan Blandford <jrb@redhat.com>
1447 * gtk/gtktreeviewcolumn.c
1448 (gtk_tree_view_column_cell_process_action): constrain cell area to
1449 passed in cell_area, #147867
1451 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size): if
1452 ellipsizing, get_size is only 3 chars wide.
1454 * docs/tree-column-sizing.png: Add Matthias's excellent image.
1456 2004-08-28 Robert Ă–gren <gtk@roboros.com>
1458 On Win32, do not produce tablet motion or button events while a
1459 window is being moved or resized. (#151090, reported by Shaneyfelt)
1461 * gdk/win32/gdkprivate-win32.h
1462 * gdk/win32/gdkglobals-win32.c
1463 * gdk/win32/gdkevents-win32.c: Rename the variable resizing to
1464 _sizemove_in_progress and make it extern.
1466 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Ignore
1467 motion and button events if _sizemove_in_progress is true.
1469 2004-08-30 Tor Lillqvist <tml@iki.fi>
1471 Make the ms-windows theme engine build with mingw.
1473 * configure.in: Expand also modules/engines/ms-windows/Theme/
1474 Makefile and .../Theme/gtk-2.0/Makefile.
1476 * modules/engines/ms-windows/Makefile.am: Adapt for building
1477 inside the GTK sources.
1479 * modules/engines/ms-windows/*.c: Use "foo.h" style includes for
1480 GTK and GDK headers. Use correct path for gdkwin32.h header.
1482 * modules/engines/ms-windows/msw_style.c: Don't use deprecated GDK
1485 * modules/engines/ms-windows/xp_theme_defs.h
1486 * modules/engines/ms-windows/xp_theme.c: Move definitions of TMT_*
1487 to xp_theme.c, as they are neither in mingw's nor Platform
1490 * modules/engines/ms-windows/xp_theme.c: Define _WIN32_WINNT as
1491 0x0501 to get the necesssary stuff from mingw's uxtheme.h.
1493 2004-08-30 Matthias Clasen <mclasen@redhat.com>
1495 Integrate the ms-windows theme engine (better known as Wimp)
1496 into the autotools build. Wimp (http://gtk-wimp.sourceforge.net/)
1497 was written by Raymond Penners and Dom Lachowicz. The Wimp 0.6.2
1498 sources have been added to the GTK+ source tree in
1499 modules/engines/ms-windows, and there is a ChangeLog detailing
1500 the history of Wimp. (#109615, Havoc Pennington)
1502 * configure.in: Generate modules/engines/Makefile and
1503 modules/engines/ms-windows/Makefile.
1505 * modules/Makefile.am (SUBDIRS): Add engines.
1507 * modules/engines/Makefile.am: Compile ms-windows for win32.
1509 2004-08-30 Matthias Clasen <mclasen@redhat.com>
1511 * gtk/gtktextview.c (gtk_text_view_delete_surrounding_handler):
1514 2004-08-27 Matthias Clasen <mclasen@redhat.com>
1516 Fix #151112, Olexiy Avramchenko:
1518 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout):
1519 * gtk/gtkiconview.c (scroll_timeout, layout_callback)
1520 (gtk_icon_view_item_accessible_idle_do_action):
1521 * gtk/gtkcombobox.c (list_popup_resize_idle, popdown_idle)
1522 (popup_idle): Protect idle callbacks and timeouts with
1523 GDK_THREADS_ENTER/_LEAVE.
1525 * gtk/gtkfilechooserbutton.c (update_dialog_idle): New function to
1526 call update_dialog() from an idle with the necessary protection.
1528 Mon Aug 30 01:34:42 2004 Matthias Clasen <maclas@gmx.de>
1530 Changes to make sure input methods respect the editability
1531 of entries and text views. #114173, Noah Levitt.
1533 * gtk/gtkentry.c (popup_targets_received): Make the Input
1534 Methods menuitem insensitive if we're not editable.
1536 * gtk/gtkentry.c (gtk_entry_delete_surrounding_cb):
1537 * gtk/gtkentry.c (gtk_entry_preedit_changed_cb):
1538 * gtk/gtkentry.c (gtk_entry_commit_cb): Don't change anything
1539 if we're not editable.
1541 * gtk/gtkentry.c (gtk_entry_focus_out):
1542 * gtk/gtkentry.c (gtk_entry_focus_in): Only send focus_in and
1543 focus_out to the im context if we're editable.
1545 * gtk/gtkentry.c (gtk_entry_set_property): Reset the im context
1546 if the entry just became non-editable.
1548 * gtk/gtktextview.c (gtk_text_view_delete_surrounding_handler):
1549 Use gtk_text_buffer_delete_interactive() to not delete
1550 non-editable portions of text.
1552 2004-08-30 Tor Lillqvist <tml@iki.fi>
1554 * modules/input/Makefile.am (im_ime_la_LIBADD): Link with -limm32.
1556 * modules/input/gtkimcontextime.c: Use quotes in #includes, to
1557 find headers when building inside GTK+ sources.
1559 2004-08-27 Tor Lillqvist <tml@iki.fi>
1561 * gdk/win32/gdkdnd-win32.c (GdkDragContextPrivateWin32): Add
1562 drop_failed, like in the X11 backend. Nothing sets it, though.
1563 (gdk_drag_drop_succeeded): Copy from X11 backend.
1565 Thu Aug 26 23:58:11 2004 Matthias Clasen <maclas@gmx.de>
1567 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't crash
1568 if model is not set. Noted by Mariano Suarez-Alvarez.
1570 Thu Aug 26 22:44:12 2004 Matthias Clasen <maclas@gmx.de>
1572 Provide information about how an adjustment change in a range
1573 widget happened. Add a "change-value" signal which reports how
1574 a user is interacting with the range, whether they are clicking
1575 on a stepper or the trough, or dragging the slider. (#133263,
1578 * gtk/gtkmarshalers.list: Add signal type BOOLEAN:ENUM,DOUBLE.
1579 * gtk/gtkrange.c (gtk_range_class_init): Add "change-value"
1581 (gtk_range_internal_set_value): Rename to
1582 gtk_range_real_change_value. Add GtkScrollType parameter. Emit
1583 the change-value signal when the range's value changes.
1584 (update_slider_position, gtk_range_scroll_event, step_back,
1585 step_forward, page_back, page_forward, scroll_begin,
1586 scroll_end): Change gtk_range_internal_set_value to
1587 gtk_range_real_change_value.
1588 * gtk/gtkrange.h (struct _GtkRangeClass): Declare change_value
1591 2004-08-26 Matthias Clasen <mclasen@redhat.com>
1593 * modules/input/Makefile.am: Build imime.la on Windows.
1595 * modules/input/gtkimcontextime.h:
1596 * modules/input/gtkimcontextime.c:
1597 * modules/input/imime.c:
1598 * modules/input/imm-extra.h: Add the IME input method for Win32
1599 written by Takuro Ashie and Kazuki IWAMOTO. The code was previously
1600 hosted at http://sourceforge.jp/projects/imime. (#135195)
1602 2004-08-26 Bill Haneman <billh@gnome.org>
1605 (gtk_tree_view_move_cursor_up_down):
1606 If a multi-selection list contains only one item,
1607 select it on cursor_up or cursor_down.
1609 [patch from Padraig O'Briain]
1611 2004-08-26 Matthias Clasen <mclasen@redhat.com>
1613 Make gdk_window_process_[all]_updates() respect
1614 update_freeze_counter (#144272, Soeren Sandmann)
1616 * gdk/gdkwindow.c (gdk_window_schedule_update): New function to
1617 install an idle for gdk_window_update_idle() if one isn't there
1619 (gdk_window_process_all_updates):
1620 (gdk_window_process_updates): Only process the updates if the
1621 window isn't frozen.
1622 (gdk_window_invalidate_maybe_recurse): Schedule an update when
1624 (gdk_window_thaw_updates): Use gdk_window_schedule_update() instead
1625 of directly installing the idle.
1627 2004-08-22 Robert Ă–gren <gtk@roboros.com>
1629 On Win32, make graphical tablets work on multi-monitor systems.
1630 (#145467, reported by buttknock1@ya...)
1632 * gdk/win32/gdkinput-win32.c (gdk_input_translate_coordinates):
1633 Use dimensions of _gdk_parent_root as screen size.
1634 (gdk_input_get_root_relative_geometry): Get coordinates relative
1635 to GDK root window instead of Win32 coordinates.
1636 (_gdk_input_other_event): Updated accordingly.
1638 Wed Aug 25 17:24:17 2004 Manish Singh <yosh@gimp.org>
1640 * gdk/x11/gdkfont-x11.c: remove unused gdk_font_charset_for_locale()
1643 * gdk/x11/gdkinput-x11.c (_gdk_input_common_init): remove unused
1644 variables num_extensions and extensions.
1646 * gtk/gtkhsv.c: remove unused gtk_hsv_get_focus_gc() function.
1648 Wed Aug 25 17:14:58 2004 Manish Singh <yosh@gimp.org>
1650 * gtk/gtktreeview.c (gtk_tree_view_search_activate): initialize
1651 path so we don't potentially use an undefined pointer.
1653 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): add G_CALLBACK
1654 cast for tree_view_keybinding_cb.
1656 * gtk/gtkfilechooserdefault.c (location_entry_create): cast to
1657 GTK_FILE_CHOOSER_ENTRY for _gtk_file_chooser_entry_set_file_part()
1660 * gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_start_editing):
1661 cast to GTK_COMBO_BOX for gtk_combo_box_set_active_iter() call.
1663 * gtk/gtkselection.c (selection_get_text_plain): make len a gsize,
1664 since that's what g_convert_with_fallback() expects.
1666 Wed Aug 25 16:14:34 2004 Jonathan Blandford <jrb@redhat.com>
1668 * gtk/gtktreeview.c (gtk_tree_view_search_activate): activate the
1669 typeahead entry on enter.
1671 2004-08-25 Matthias Clasen <mclasen@redhat.com>
1673 * gtk/gtkmenu.c (gtk_menu_attach_to_widget): Steal ATTACHED_MENUS
1674 list so its tail isn't freed when we re-set it, noticed
1675 by Hans Petter Jansson.
1677 * gtk/gtksizegroup.c (gtk_size_group_add_widget): Fix
1678 a typo, noticed by Tim Janik.
1680 Wed Aug 25 15:15:56 2004 Jonathan Blandford <jrb@redhat.com>
1682 * gtk/gtkpathbar.c (gtk_path_bar_size_allocate): Change the Down
1683 button to be end-justified, so that clicking on it is a stable
1686 Tue Aug 24 02:06:37 2004 Jonathan Blandford <jrb@gnome.org>
1689 (gtk_tree_view_real_expand_collapse_cursor_row): Don't handle the
1690 event if we have no children.
1692 * gtk/gtkfilechooserdefault.c (trap_activate_cb):
1693 (tree_view_keybinding_cb):Since GtkTreeView has a keybinding
1694 attached to '/', we need to catch keypresses before the TreeView
1696 (gtk_file_chooser_default_class_init): add '/' to be a keybinding
1698 (location_entry_create): Clear the text to "" when loading a file.
1699 This has a much better feel than putting the currently selected
1701 * #include <errno.h>
1703 2004-08-25 Matthias Clasen <mclasen@redhat.com>
1705 * gtk/gtkfilechooserdefault.c (check_is_folder): Use get_file_info() rather
1706 than trying get_folder() and checking for an error directly because older
1707 versions of the gnome-vfs backend don't return an error
1708 immediately. (#150852, Zack Cerza )
1710 2004-08-25 Matthias Clasen <mclasen@redhat.com>
1712 * configure.in: Post-release version bump.
1714 * === Released 2.5.2 ===
1717 * gtk/abicheck.sh: Make work during make distcheck.
1719 * docs/RELEASE-HOWTO: Add hint about doing make check
1720 before make distcheck.
1722 * gtk/gtk.symbols: Add some missing symbols.
1724 * gtk/gtkiconview.c: Add some missing statics.
1726 2004-08-24 Matthias Clasen <mclasen@redhat.com>
1728 * NEWS: Updates for 2.5.2
1730 Wed Aug 25 00:22:48 2004 Søren Sandmann <sandmann@redhat.com>
1732 * gtk/gtksequence.c: Remove debug spew
1734 Wed Aug 25 00:09:07 2004 Søren Sandmann <sandmann@redhat.com>
1736 * gtk/gtkliststore.c (gtk_list_store_move_after): Fix logical
1737 errors in gtk_list_store_move_before/after(). (#150983, patch by
1740 Tue Aug 24 21:46:42 2004 Søren Sandmann <sandmann@redhat.com>
1742 * gtk/gtksequence.c (_gtk_sequence_move): Just return if the
1743 parameters are identical. (#150159, Robert Ă–gren)
1745 2004-08-24 Matthias Clasen <mclasen@redhat.com>
1747 * gtk/gtkaction.c (connect_proxy, disconnect_proxy): Handle
1748 action_group being NULL. (#150869, Tommi Komulainen)
1750 2004-08-24 Matthias Clasen <mclasen@redhat.com>
1752 * gdk/gdkimage.c (allocate_scratch_images): Use the correct
1753 index variable. (#150941, Tommi Komulainen)
1755 2004-08-24 Matthias Clasen <mclasen@redhat.com>
1757 * gtk/gtktreeview.c (gtk_tree_view_node_queue_redraw): Take header
1758 height and adjustment into account. (#136496, Pawek Salek)
1760 Mon Aug 23 17:19:19 2004 Jonathan Blandford <jrb@redhat.com>
1763 * docs/tools/Makefile.am (clean-local): add the doc shooter to the
1764 docs dir as an uninstalled helper tool.
1766 2004-08-23 Matthias Clasen <mclasen@redhat.com>
1768 * gdk/x11/gdkwindow-x11.c (show_window_internal): Make it compile.
1770 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Add a
1773 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Update
1774 toplevel->user_time.
1775 (show_window_internal): Update the user time when re-mapping a
1776 toplevel window. (#150502, Elijah Newren)
1778 2004-08-23 Matthias Clasen <mclasen@redhat.com>
1780 Fix #150822, reported by Christian Persch
1782 * gtk/gtklabel.c (gtk_label_ensure_layout): Set the layout width
1783 appropriately when ellipsized.
1784 (gtk_label_size_allocate): Only set the layout width if there
1787 2004-08-23 Matthias Clasen <mclasen@redhat.com>
1789 * gdk/x11/gdkwindow-x11.c (gdk_window_focus): Support the latest
1790 EWMH additions to the _NET_ACTIVE_WINDOW client message
1791 format. (#150668, Elijah Newren)
1793 Mon Aug 23 01:17:59 2004 Matthias Clasen <maclas@gmx.de>
1795 * gdk/gdkrgb.c (gdk_rgb_xpixel_from_rgb_internal): Set unused
1796 bits in pixel to 1s in case they are used as alpha; copying
1797 code from gdk_colormap_alloc_colors(). (#150466, Rich Wareham)
1799 2004-08-22 Philip Langdale <plangdale@vmware.com>
1801 * gtk/gtkaction.c (gtk_action_disconnect_proxy): Two signals
1802 (gtk_action_sync_property and gtk_action_sync_sensitive) were
1803 not being correctly disconnected, leading to actions continuing
1804 to affect disconnected proxies. (#150607)
1806 2004-08-22 Tor Lillqvist <tml@iki.fi>
1808 * gdk/win32/gdkwindow-win32.c (gdk_window_new_internal,
1809 gdk_window_new, gdk_window_set_skip_taskbar_hint): Don't show TEMP
1810 windows in the Task Manager. Implement by calling
1811 gdk_window_set_skip_taskbar_hint(TRUE) on them. (#145481, Tim
1814 * gdk/win32/gdkdisplay-win32.c (enum_monitor, gdk_display_open):
1815 Report whole of (primary) monitor, including any taskbars.
1816 Excluding the taskbar area from the "root window" reported to GDK
1817 doesn't seem to be that useful although gdk/win32 had been doing it
1818 for a very long time. (#149013, see also #145467 and #148526)
1820 Sun Aug 22 16:55:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1823 * gtk/gtkalignment.c:
1825 Make enums match property names. Found by a script by Tommi
1828 * gtk/gtkpaned.c (gtk_paned_class_init): fix min/max mixup.
1830 Sun Aug 22 16:09:49 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1832 * gtk/gtkliststore.h (struct _GtkListStore):
1833 * gtk/gtkliststore.c (gtk_list_store_init):
1834 * gtk/gtkliststore.c (gtk_list_store_insert):
1835 * gtk/gtkliststore.c (gtk_list_store_remove):
1836 Restore length field; PyGTK and maybe others use it directly.
1838 Sun Aug 22 15:46:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1840 * gtk/gtkpaned.c (gtk_paned_class_init):
1841 s/CYCLE_HANDLE_FOCUS/CYCLE_CHILD_FOCUS/
1843 * gtk/gtkfontbutton.c (gtk_font_button_class_init):
1844 s/PROP_SHOW_SIZE/PROP_SHOW_STYLE/
1846 Both pointed out by Tommi Komulainen.
1848 Sun Aug 22 13:44:53 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1850 * gtk/gtkpaned.c (gtk_paned_class_init): Use PROP_MAX_POSITION,
1851 not PROP_MIN_POSITION for the max_position property. Fix pointed
1852 out by Tommi Komulainen.
1854 Sun Aug 22 13:32:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1856 * gtk/gtkliststore.c (gtk_list_store_insert): Normalize the
1857 position so we don't create paths with off-list
1860 Sun Aug 22 12:04:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1862 * gtk/gtkliststore.c (gtk_list_store_sort_iter_changed): Use the
1863 correct tree path (#150289, Morten Welinder).
1865 Sun Aug 22 00:08:44 2004 Matthias Clasen <maclas@gmx.de>
1867 Fix #150406, reported by Fernando San MartĂn Woerner, patch
1868 by Gustavo Carneiro.
1870 * gtk/gtkentrycompletion.c
1871 (gtk_entry_completion_default_completion_func): Check that
1872 column is of type G_TYPE_STRING before proceeding.
1874 Sat Aug 21 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
1876 * gtk/gtktreestore.c (gtk_tree_store_swap): Don't use an
1877 uninitialized tree iter. (#150414, Torsten Schoenfeld)
1879 Sat Aug 21 23:29:54 2004 Matthias Clasen <maclas@gmx.de>
1881 Fix #150738, Tomislav Jonjic.
1883 * gtk/gtktoolitem.h (GTK_IS_TOOL_ITEM_CLASS):
1884 * gtk/gtktoolbutton.h (GTK_IS_TOOL_BUTTON_CLASS):
1885 * gtk/gtktoggleaction.h (GTK_IS_TOGGLE_ACTION_CLASS):
1886 * gtk/gtkseparatortoolitem.h (GTK_IS_SEPARATOR_TOOL_ITEM_CLASS):
1887 * gtk/gtkradiotoolbutton.h (GTK_IS_RADIO_TOOL_BUTTON_CLASS):
1888 * gtk/gtkradioaction.h (GTK_IS_RADIO_ACTION_CLASS):
1889 * gtk/gtkuimanager.h (GTK_IS_UI_MANAGER_CLASS):
1890 * gtk/gtkaction.h (GTK_IS_ACTION_CLASS): Fix macro definitions.
1892 Wed Aug 18 17:25:26 2004 Manish Singh <yosh@gimp.org>
1894 * demos/testpixbuf-save.c
1895 * demos/gtk-demo/hypertext.c: Get rid of some unnecessary casts.
1897 * demos/gtk-demo/appwindow.c: Make activate_email and activate_url
1898 match the arguments for GtkAboutDialogActivateLinkFunc.
1900 Wed Aug 18 16:18:00 2004 Manish Singh <yosh@gimp.org>
1902 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): Initialize height
1903 from fixed_height before we do anything, so it always has a valid
1906 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Fix call
1907 to gtk_tree_model_get (missing "," in param list).
1909 2004-08-18 Federico Mena Quintero <federico@ximian.com>
1915 * gtk/gtkfilechooserdefault.c: Renamed SHORTCUTS_COL_PATH to
1916 SHORTCUTS_COL_DATA. Add SHORTCUTS_COL_IS_VOLUME, to determine
1917 easily whether the SHORTCUTS_COL_DATA points to a GtkFilePath or a
1918 GtkFileSystemVolume.
1919 (shortcuts_model_create): Create a boolean column for
1920 SHORTCUTS_COL_IS_VOLUME.
1921 (shortcuts_reload_icons): Simplify with the use of the
1922 SHORTCUTS_COL_IS_VOLUME column. Don't leak the pixbuf.
1923 (shortcuts_insert_path): Add the SHORTCUTS_COL_IS_VOLUME data.
1924 (shortcuts_free_row_data): New helper function; frees the data
1925 columns for an iter.
1926 (shortcuts_remove_rows): Don't take a callback for freeing the
1927 data; free everything here instead. Use
1928 shortcuts_free_row_data().
1929 (volume_remove_cb): Removed.
1930 (remove_bookmark_cb): Removed.
1931 (remove_row_cb): Make this a single generic function to delete
1933 (shortcuts_add_volumes): Use remove_row_cb().
1934 (shortcuts_add_bookmarks): Likewise.
1935 (struct _GtkFileChooserDefault): Removed the
1936 shortcuts_current_folder_is_volume field.
1937 (shortcuts_add_current_folder): Oops, don't free the volume.
1938 (remove_current_folder_cb): Removed.
1939 (shortcut_find_position): Simplify through the use of the
1940 SHORTCUTS_COL_IS_VOLUME column.
1941 (remove_selected_bookmarks): Assert that we don't get a volume.
1942 (shortcuts_reorder): Likewise; also, plug a leak.
1943 (gtk_file_chooser_default_remove_shortcut_folder): Simplify
1944 through the use of shortcuts_remove_rows().
1945 (gtk_file_chooser_default_list_shortcut_folders): Assert that we
1947 (shortcuts_activate_iter): Simplify.
1948 (home_folder_handler): Simplify by using
1949 shortcuts_activate_iter().
1950 (shortcuts_free): New function; frees all the data columns.
1951 (gtk_file_chooser_default_finalize): Unref the
1952 shortcuts_filter_model and the shortcuts model data first.
1954 Wed Aug 18 08:31:17 2004 Manish Singh <yosh@gimp.org>
1956 * gtk/gtkiconview.c: Applied patch from Olivier Andrieu to fix
1959 * gtk/gtkicontheme.c (gtk_icon_theme_init): xdg_data_dirs should
1960 match constness attributes of g_get_system_data_dirs ().
1962 2004-08-17 Matthias Clasen <mclasen@redhat.com>
1964 * gtk/gtkicontheme.c (gtk_icon_theme_init): Look up icon themes in the
1965 directories specified in the icon theme spec: $HOME/.icons,
1966 $XDG_DATA_DIRS/icons, /usr/share/pixmaps. Note that GTK+ used to also look
1967 in $GTK_DATA_DIR/icons, $GTK_DATA_DIR/pixmaps and /usr/share/icons. (#148694)
1970 * gtk/gtkframe.c (gtk_frame_paint): Take widget->state into account when
1971 painting the shadows. (#150351, Tim Janik)
1973 2004-08-17 Matthias Clasen <mclasen@redhat.com>
1975 * gtk/abicheck.sh: No need for INCLUDE_INTERNAL_SYMBOLS anymore.
1977 * gdk/gdk.symbols: Don't use #if defined().
1979 * gdk/Makefile.am (gdkalias.h):
1980 * gtk/Makefile.am (gtkalias.h): Don't use cpp to filter gtk.symbols.
1982 * gdk/makegdkalias.pl:
1983 * gtk/makegtkalias.pl: Move the #ifdef processing into the perl script, and
1984 keep the #ifdefs which differentiate between platforms.
1986 * gtk/Makefile.am (gtk_private_h_sources): Remove gtkinternals.h, it is no
1989 2004-08-17 Matthias Clasen <mclasen@redhat.com>
1991 * tests/testfilechooserbutton.c: Use g_message() throughout, add RTL envar for
1994 * gtk/gtkfilechooserbutton.c: Get rid of HAVE_CONFIG_H.
1995 (gtk_file_chooser_button_init): Use gtk_drag_dest_add_text_targets().
1996 (gtk_file_chooser_button_drag_data_received): Use gtk_selection_data_get_text().
1997 (gtk_file_chooser_button_set_dialog): _gtk_file_chooser_entry_set_base_folder()
1998 seems to expect a path, not an uri.
1999 (update_dialog): Handle g_filename_from_uri() returning NULL, don't free
2002 * gtk/gtkfilechooserbutton.h: Minor stylistic changes.
2004 2004-08-17 Matthias Clasen <mclasen@redhat.com>
2006 * gtk/gtkfilechooserbutton.[hc]: New widget to go along with
2007 GtkFontButton and GtkColorButton for use in preference dialogs.
2008 Replaces GnomeFileEntry. (#148108, James M. Cape)
2010 * gtk/gtk.h: Include gtkfilechooserbutton.h
2012 * gtk/Makefile.am (gtk_public_h_sources): Add gtkfilechooserbutton.h
2013 (gtk_c_sources): Add gtkfilechooserbutton.c
2015 * gtk/gtk.symbols: Add the GtkFileChooserButton symbols.
2017 * gtk/gtkfilechooserutils.[hc]: Make the delegate quark available.
2019 * gtk/gtkfilechooserentry.[hc] (_gtk_file_chooser_entry_new): Allow
2020 to suppress tab-eating using the new eat_tabs argument. Adjust all
2023 * tests/testfilechooserbutton.c: Test for GtkFileChooserButton.
2025 * tests/Makefile.am (noinst_PROGRAMS): Add testfilechooserbutton
2027 2004-08-16 Matthias Clasen <mclasen@redhat.com>
2029 * gtk/gtkwidget.c (gtk_widget_render_icon): Doc update.
2031 * gtk/gtkiconfactory.c (render_icon_name_pixbuf): When the size is -1,
2032 use the available size closest to 48. (#150147)
2034 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): Actually return
2035 a pointer to the beginning of the sizes array, not the end.
2037 2004-08-16 Morten Welinder <terra@gnome.org>
2039 * tests/testtreemodel.c (test_run): Comment out mallinfo stuff.
2040 Fix g_print %-strings.
2042 * gtk/gtksequence.c (_gtk_sequence_set): Fix C99ism.
2044 2004-08-16 Christian Rose <menthos@menthos.com>
2046 * configure.in: Added "bs" to ALL_LINGUAS.
2048 Mon Aug 16 01:35:25 2004 Matthias Clasen <maclas@gmx.de>
2051 * gtk/gtkcombobox.[hc]: Add a ::focus-on-click property and
2052 change the default behaviour to focus on click.
2054 * gtk/gtkbutton.c (gtk_button_set_focus_on_click): Typo fix.
2056 Mon Aug 16 01:03:08 2004 Matthias Clasen <maclas@gmx.de>
2058 * gtk/gtktextiter.c (gtk_text_iter_set_visible_line_offset):
2059 (gtk_text_iter_set_visible_line_index): Count from the
2060 beginning of the line, not from the current position. (#150101,
2063 2004-08-15 Tor Lillqvist <tml@iki.fi>
2065 * gtk-zip.sh.in: Fix typo. The gtk.immodules file had never been
2066 included in my zipfiles...!
2068 * gtk/gtkfilesystemwin32.c (extract_icon): Improve handling of
2069 icon alpha channel (on Windows XP) and mask (older Windows
2070 versions). (#148641, Tim Evans)
2072 Sun Aug 15 02:31:55 2004 Matthias Clasen <maclas@gmx.de>
2074 * gtk/gtkfilesystemunix.c (get_icon_type_from_stat): Make
2075 the use of S_ISFIFO and S_ISSOCK conditional. (#150146,
2078 2004-08-14 Tor Lillqvist <tml@iki.fi>
2080 * gtk/gtkfilechooserdefault.c (shortcuts_append_home,
2081 shortcuts_append_desktop, set_local_only)
2082 * gtk/gtkfilesystemwin32.c (gtk_file_system_win32_render_icon)
2083 * gtk/gtkpathbar.c (find_button_type, _gtk_path_bar_set_file_system):
2084 Guard against g_get_home_dir() returning NULL. (#150007)
2086 Sat Aug 14 17:56:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2088 * gtk/gtkentry.c (gtk_entry_get_pixel_ranges): New function.
2090 * gtk/gtkentry.c (in_selection): New function using
2091 gtk_entry_get_pixel_ranges() to determine whether a click is in
2092 the selection. Improve entry behavior wrt. dragging and
2093 selecting. Bug #143249.
2095 Sat Aug 14 17:53:46 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2097 * configure.in: Require glib 2.5.2
2099 * gtk/gtksequence.[ch]: New internal data structure.
2101 * gtk/gtkliststore.[hc]: Reimplement in terms of new data
2104 * tests/Makefile.am (testtreemodel_SOURCES):
2105 * tests/testtreemodel.c: New test program written by Matthias.
2107 2004-08-13 Matthias Clasen <mclasen@redhat.com>
2109 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_style_set):
2110 Don't install the settings_notify_cb from here, since it
2111 may be called before the first screen_changed signal,
2112 confusing the logic in gtk_file_chooser_screen_changed().
2113 (#148803, Abel Daniel)
2115 * gtk/gtkcombobox.c: Make re-sensitivation work
2118 * gtk/gtkaction.c (gtk_action_new): Fix the docs.
2120 Fri Aug 13 01:06:56 2004 Matthias Clasen <maclas@gmx.de>
2122 * gtk/gtktreeview.c (gtk_tree_view_row_inserted):
2123 Make fixed height mode handle insertions. (#135955,
2124 Michael Vogt, testcase by Tim-Philipp MĂ¼ller, fix by
2127 Fri Aug 13 00:40:18 2004 Matthias Clasen <maclas@gmx.de>
2129 * gtk/gtkhandlebox.c: Add missing include.
2131 Thu Aug 12 23:52:12 2004 Matthias Clasen <maclas@gmx.de>
2133 Fix #149547, Markus Lausser:
2135 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate):
2136 * gtk/gtkcombobox.c (gtk_combo_box_size_request): Don't
2137 crash if size_request or size_allocate are called early.
2139 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate): Protect
2140 against being allocated too small.
2142 Thu Aug 12 21:02:57 2004 Matthias Clasen <maclas@gmx.de>
2144 * demos/gtk-demo/appwindow.c (about_cb): Adjust to GtkAboutDialog
2147 * gtk/gtkaboutdialog.h:
2148 * gtk/gtkaboutdialog.c (gtk_about_dialog_set_email_hook):
2149 (gtk_about_dialog_set_url_hook): Add callback data and destroy notify
2150 for language bindings. (#149999, Olivier Andrieu)
2152 2004-08-12 Matthias Clasen <mclasen@redhat.com>
2154 * gtk/gtkfilesystem.c: Underscore-prefix gtk_file_system_module_get_type().
2155 * gtk/gtkfilechooserdefault.c: Underscore-prefix shortcuts_model_filter_get_type().
2157 * gtk/gtkimmodule.c: Make gtk_im_module_get_type() static.
2159 * gtk/gtkinternals.h: Remove the no longer exported get_type functions.
2161 Thu Aug 12 01:35:46 2004 Matthias Clasen <maclas@gmx.de>
2163 * gtk/gtkiconview.c: Make the icon view accessible by
2164 implementing the necessary ATK interfaces. (#149728,
2167 Thu Aug 12 00:02:29 2004 Matthias Clasen <maclas@gmx.de
2169 * gtk/gtkaction.c (gtk_action_new): Link to information about
2170 allowed action names. (#149620, David Malcolm)
2172 Wed Aug 11 23:14:25 2004 Matthias Clasen <maclas@gmx.de>
2176 * gtk/gtkaction.c (gtk_action_set_sensitive):
2177 (gtk_action_set_visible): Add setters for the ::sensitive
2178 and ::visible properties of GtkAction. (#149622, David Malcolm)
2180 2004-08-11 Federico Mena Quintero <federico@ximian.com>
2182 Fix #149422, #143457:
2184 * gtk/gtkfilechooserdefault.c
2185 (gtk_file_chooser_default_should_respond): Rewrite to take the
2186 current focus into account, the contents of the save entry, and
2187 the last focus for the shortcuts list.
2188 (switch_to_selected_folder): We don't need an assertion on the
2191 Wed Aug 11 20:56:00 2004 Matthias Clasen <maclas@gmx.de>
2193 * gtk/gtkinternals.h:
2194 * gtk/gtk.symbols: Add shortcuts_model_filter_get_type.
2196 * gtk/abicheck.sh: Check all symbols.
2198 Wed Aug 11 19:20:34 2004 Matthias Clasen <maclas@gmx.de>
2200 * gtk/gtktreeview.c (gtk_tree_view_maybe_begin_dragging_row):
2201 Don't start a drag if the treeview is only a
2202 drag destination. (#149836, Pawel Salek)
2204 2004-08-11 Matthias Clasen <mclasen@redhat.com>
2206 * gtk/gtktreedatalist.[hc]:
2207 * gtk/gtkliststore.c:
2208 * gtk/gtktreestore.c: Underscore-prefix
2209 gtk_tree_data_list_compare_func.
2211 * gtk/gtk.symbols: Remove gtk_tree_data_list_compare_func.
2213 * gtk/makegtkalias.pl: No need to include gtktreedatalist.h
2216 2004-08-10 Matthias Clasen <mclasen@redhat.com>
2219 * gtk/Makefile.am: Define TESTS, not TEST, so that make check
2220 actually triggers abicheck.sh.
2222 * gdk/makegdkalias.pl:
2223 * gtk/makegtkalias.pl: Include glib.h before using glib symbols. D'oh.
2225 * gdk/makegdkalias.pl:
2226 * gtk/makegtkalias.pl: Protect gtkalias.h by G_HAVE_GNUC_VISIBILITY.
2228 * gtk/Makefile.am: Include gtkalias.h in the generated
2229 sources gtkmarhalers.c and gtkmarshal.c.
2231 * gtk/makegtkalias.pl: Cosmetic fix.
2233 * gdk/Makefile.am: Remove the . which was accidentally added
2234 to SUBDIRS. Include gdkalias.h in the generated sources
2235 gdkenumtypes.c and gdkmarshalers.c.
2237 * gdk/makegdkalias.pl: Cosmetic fix.
2239 * gdk/Makefile.am: Add gdkalias.h to BUILT_SOURCES.
2241 2004-08-09 Hans Breuer <hans@breuer.org>
2243 * gtk/makefile.msc.in : autogenerate gtk.def, cleanup
2245 * gdk/win32/gdkwindow-win32.c gdk/win32/gdkevents-win32.c :
2246 removed long time unused ifdef/ed code (WITHOUT_WM_CREATE),
2247 removed duplicated call to gdk_window_set_cursor()
2249 Mon Aug 9 15:41:17 2004 Matthias Clasen <maclas@gmx.de>
2251 Add hidden aliases for exported symbols which are
2252 used internally in order to get rid of many PLT
2253 entries. (#145519, Arjan van de Ven)
2255 * gdk/Makefile.am: Add rules to generate gdk.def and
2256 gdkalias.h from gdk.symbols, and make make check check
2257 the abi with abicheck.sh.
2259 * gdk/gdk.symbols: New file. Definition of the GDK ABI.
2260 The file can be processed by cpp to filter out certain
2263 * gdk/abicheck.sh: New file. Script to check the actually
2264 symbols exported from libgdk-x11.2.0.so against the symbols
2265 found in gdk.symbols.
2267 * gdk/makegdkalias.pl: New file. Perl script to generate the
2268 header containing the alias definitions for internally used
2269 exported symbols from a list of symbols.
2271 * gdk/*.c, gdk/x11/*.c: Include gdkalias.h
2273 2004-08-09 Morten Welinder <terra@gnome.org>
2275 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): Fix C99ism.
2277 Mon Aug 9 15:27:01 2004 Matthias Clasen <maclas@gmx.de>
2279 * gtk/makegtkalias.pl: Also revert
2280 GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API to its old status.
2282 Mon Aug 9 15:19:34 2004 Matthias Clasen <maclas@gmx.de>
2285 * gdk/gdkrgb.h: Add the exported functions
2286 gdk_rgb_colormap_ditherable(), gdk_pointer_grab_info_libgtk_only(),
2287 gdk_keyboard_grab_info_libgtk_only() to the appropriate
2290 Mon Aug 9 14:24:46 2004 Matthias Clasen <maclas@gmx.de>
2292 * gdk/x11/gdkevents-x11.c (gdk_event_send_client_message_to_all_recurse):
2295 Mon Aug 9 12:48:04 2004 Matthias Clasen <maclas@gmx.de>
2297 Add hidden aliases for exported symbols which are
2298 used internally in order to get rid of many PLT
2299 entries. (#145519, Arjan van de Ven)
2301 * gtk/Makefile.am: Add rules to generate gtk.def and
2302 gtkalias.h from gtk.symbols, and make make check check
2303 the abi with abicheck.sh.
2304 (gtk_private_h_sources): Add gtkinternals.h
2305 (gtk_built_private_headers): Add gtkalias.h
2306 (gtk_extra_sources): Add gtk.symbols
2307 (EXTRA_DIST): Add makegtkalias.pl and abicheck.sh
2309 * gtk/gtk.symbols: New file. Definition of the GTK+ ABI.
2310 The file can be processed by cpp to filter out certain
2313 * gtk/abicheck.sh: New file. Script to check the actually
2314 symbols exported from libgtk-x11.2.0.so against the symbols
2315 found in gtk.symbols.
2317 * gtk/makegtkalias.pl: New file. Perl script to generate the
2318 header containing the alias definitions for internally used
2319 exported symbols from a list of symbols.
2321 * gtk/gtkinternals.h: New file. An uninstalled header listing
2322 symbols which must be exported for some reason and do not appear
2323 in any other header.
2325 * gtk/*.c: Include gtkalias.h
2327 Mon Aug 9 11:49:46 2004 Matthias Clasen <maclas@gmx.de>
2329 * gtk/gtkmain.c: Only undef gtk_init_check and gtk_init on win32.
2331 Mon Aug 9 10:50:05 2004 Matthias Clasen <maclas@gmx.de>
2333 * gtk/gtkentry.h: Add gtk_entry_layout_index_to_text_index()
2334 and its inverse. The have always been exported and are meant
2337 Mon Aug 9 00:28:34 2004 Matthias Clasen <maclas@gmx.de>
2339 * gtk/gtkicontheme.c (load_svg_at_size): Don't leak the
2342 Mon Aug 9 00:13:03 2004 Matthias Clasen <maclas@gmx.de>
2344 * gtk/gtkaboutdialog.c (icon_set_new_from_pixbufs): Don't
2345 leak the icon source.
2347 Sun Aug 8 23:46:20 2004 Matthias Clasen <maclas@gmx.de>
2349 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Don't
2350 leak a reference to the pixbufs.
2352 Sun Aug 8 23:36:55 2004 Matthias Clasen <maclas@gmx.de>
2354 * gtk/gtkcombobox.c (gtk_combo_box_menu_setup): Ref
2355 and sink the column.
2356 (gtk_combo_box_menu_destroy): Unref the column.
2358 Sun Aug 8 23:35:00 2004 Matthias Clasen <maclas@gmx.de>
2360 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets):
2361 (gtk_drag_dest_add_text_targets): Don't leak a reference
2364 Sun Aug 8 22:52:26 2004 Matthias Clasen <maclas@gmx.de>
2366 * gtk/gtkcombobox.c (find_menu_by_path): Don't stumble over
2367 separators which are not backed by model rows.
2369 Sun Aug 8 11:01:23 2004 Matthias Clasen <maclas@gmx.de>
2371 * gtk/gtkcombobox.c (gtk_combo_box_set_active): Don't leak
2374 2004-08-08 Hans Breuer <hans@breuer.org>
2376 * gtk/gtkdnd.c (gtk_drag_dest_set) : take targets into
2377 account again to allow dnd of other things than text
2379 * gdk/win32/gdkselection-win32.c : offer windows bitmap to
2380 be pasted from clipboard (makes The GIMP 2.1's
2381 "File/Acquire/Paste as New" work, only using gtk+ API)
2383 Sun Aug 8 01:32:36 2004 Matthias Clasen <maclas@gmx.de>
2385 * gtk/gtk.def: Add gtk_cell_renderer_progress_get_type.
2387 Sun Aug 8 01:29:08 2004 Matthias Clasen <maclas@gmx.de>
2389 * gtk/gtk.def: Replace duplicate gtk_tree_view_get_hover_expand
2390 by gtk_tree_view_set_hover_expand.
2392 Sun Aug 8 01:23:08 2004 Matthias Clasen <maclas@gmx.de>
2394 * gtk/gtk.def: Remove the static function gtk_menu_get_private.
2396 2004-08-07 Tor Lillqvist <tml@iki.fi>
2398 * gdk/win32/gdkkeys-win32.c (update_keymap): Don't hardcode
2399 mapping of VK_DECIMAL to GDK_KP_Decimal. Instead, let ToAsciiEx()
2400 map it to what's printed on the keypad decimal key for the current
2401 input locale (keyboard layout). (#149404)
2403 Sat Aug 7 18:19:03 2004 Matthias Clasen <maclas@gmx.de>
2405 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
2406 (shortcuts_list_create): Use GtkTreeViewRowSeparatorFunc
2407 instead of GtkCellRendererSepText. (#147864)
2409 * gtk/gtkcellrendererseptext.[hc]: Removed.
2411 * gtk/Makefile.am: Remove gtkcellrendererseptext.[hc]
2413 Sat Aug 7 18:15:15 2004 Matthias Clasen <maclas@gmx.de>
2415 * gtk/gtkcombobox.c (gtk_combo_box_menu_row_deleted):
2416 (gtk_combo_box_menu_row_inserted):
2417 (gtk_combo_box_menu_row_changed): Correctly handle
2418 insertion and deletion of separators in menu mode.
2420 2004-08-07 Tor Lillqvist <tml@iki.fi>
2422 * gdk/win32/gdkevents-win32.c (handle_configure_event,
2423 gdk_event_translate:WM_WINDOWPOSCHANGED): Add _gdk_offset_{x,y} to
2424 top-level window coordinates, not just in generated
2425 events. (#148526, Robert Ă–gren)
2427 Sat Aug 7 01:26:08 2004 Matthias Clasen <maclas@gmx.de>
2429 Make the column drag code a bit more robust (still scary,
2430 though). (#106992, Christian Biere)
2432 * gtk/gtktreeview.c (_gtk_tree_view_column_start_drag): Assert
2433 that cur_reorder is NULL here.
2435 * gtk/gtktreeview.c (gtk_tree_view_button_release_drag_column):
2436 Reset cur_reorder to NULL, and only hide drag_highlight_window
2439 2004-08-06 Federico Mena Quintero <federico@ximian.com>
2443 * gtk/gtkfilechooserdefault.c (save_widgets_create): Use a
2444 GtkFileChooserEntry for the file name, rather than a GtkEntry.
2445 (update_chooser_entry): Set the contents of the file chooser entry
2446 rather than the plain entry's.
2447 (gtk_file_chooser_default_set_current_folder): Set the new folder
2449 (gtk_file_chooser_default_set_current_name): Set the name on the
2451 (check_save_entry): Use the file chooser entry rather than the
2454 * gtk/gtkfilechooserentry.c
2455 (_gtk_file_chooser_entry_set_base_folder): Call
2456 gtk_file_chooser_entry_changed() so that we recompute the current
2457 folder based on the new base folder.
2459 2004-08-06 Hans Breuer <hans@breuer.org>
2461 * gdk/win32/gdkwindow-win32.c : make it compile and more
2462 similar to the X11 implementation [backward compatibility
2463 for GDK_WINDOW_TEMP, GDK_INPUT_ONLY (fixes bug #148702),
2464 use the *screen* function variants, dont reparent already
2466 (get_visible_region) : take the win32 part into account
2467 (_gdk_windowing_window_destroy) : remove from handle table
2469 * gdk/win32/gdkdisplay-win32.c : added
2470 gdk_display_(request|supports)_selection_notification ()
2471 with a currently mostly pointless implementation ;-)
2473 * gtk/gtkfilesystemwin32.c (*_to_path) : same changes as on *NIX,
2475 (gtk_file_system_win32_render_icon) : use new GTK_STOCK_DIRECTORY
2477 * gtk/makefile.msc.in demos/gtk-demo/makefile.msc.in
2478 gtk/stock-icons/makefile.msc tests/makefile.msc : updated
2480 * gdk/gdk.def gtk/gtk.def : updated externals
2482 * tests/testiconview.c : remove unneeded dirent.h inclusion
2484 2004-08-06 Matthias Clasen <mclasen@redhat.com>
2486 * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): Fix
2487 an off-by-one error. (#141809, Markku Vire)
2489 * gtk/gtkdnd.c (gtk_drag_dest_set, gtk_drag_source_set): Really
2490 fix the initialization of the target list.
2492 Support XDND v5. (#10220, Owen Taylor)
2494 * gdk/x11/gdkdnd-x11.c: Record the XDND version and whether the
2495 drop was successful in the GdkDragContextPrivateX11 struct.
2496 (xdnd_finished_filter): Store the success status of the drop
2497 for an XDND version 5 interaction. For other versions, always
2498 assume the drop was successful.
2499 (xdnd_check_dest): Return the protocol version.
2500 (_gdk_drag_get_protocol_for_display): Return the protocol version.
2501 (gdk_drag_find_window_for_screen): Store the used protocol version
2502 in the GdkDragContext.
2503 (xdnd_send_enter): Send the used protocol version from the context,
2504 instead of hardwiring 3.
2505 (xdnd_enter_filter): Accept protocol versions >= 3 and store the
2506 used protocol version in the context.
2509 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): New function
2510 to find out whether a drop was successful.
2512 2004-07-28 Robert Ă–gren <gtk@roboros.com>
2514 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Set x_root
2515 and y_root in button and motion events from the tablet. (#148715)
2517 Thu Aug 5 19:58:08 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2519 * gtk/gtkplug.c (gtk_plug_realize): Call
2520 gdk_window_enable_synchronized_configure()
2522 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): Make
2523 noop if gdk_window_enable_synchronized_configure() has not been
2526 2004-08-04 Matthias Clasen <mclasen@redhat.com>
2528 * gtk/gtkfilechooser.[hc]: Add setter and getter for the
2529 ::show-hidden property. (#145610, Jeff Franks)
2531 * tests/testiconview.c: Add buttons to select and unselect all
2532 nodes, make the popup menu actually work.
2534 * gtk/gtkiconview.c: Make GTK_SELECTION_BROWSE work as intended,
2535 let button 3 presses through to the app, to make popup menus
2538 * tests/Makefile.am: Add testiconview.
2539 * tests/testiconview.c: A test for GtkIconView
2540 * tests/gnome-textfile.png: ...which uses this image.
2542 Wed Aug 4 01:37:57 2004 Matthias Clasen <maclas@gmx.de>
2544 * gtk/gtktreeview.c:
2545 * gtk/gtktreestore.c:
2546 * gtk/gtktreemodelfilter.c:
2547 * gtk/gtknotebook.c: s/childs/children/g.
2549 Wed Aug 4 01:04:48 2004 Matthias Clasen <maclas@gmx.de>
2551 Fix #133446, noticed by Christian Persch:
2553 * gtk/gtkaction.c (gtk_action_class_init): Add a new boolean
2554 property ::visible-overflown.
2555 * gtk/gtkaction.c (gtk_action_create_menu_proxy): Don't create
2556 a menu proxy if visible_overflown is FALSE.
2558 Tue Aug 3 20:16:26 2004 Matthias Clasen <maclas@gmx.de>
2560 * gtk/gtkactiongroup.[hc]: Make the the GtkAction{Toggle,Radio,}Entry*
2561 arguments to the gtk_action_group_add_..._actions() functions const,
2562 since the most common use case is to use a static array. (142334,
2563 Mariano Suarez-Alvarez)
2565 Tue Aug 3 20:03:33 2004 Matthias Clasen <maclas@gmx.de>
2567 * gtk/gtkuimanager.c (get_node): Make gtk_ui_manager_add_ui()
2568 accept paths with a leading "/ui". (#149077, David Malcolm)
2570 Tue Aug 3 19:59:29 2004 Matthias Clasen <maclas@gmx.de>
2572 * gtk/gtkiconview.c: Fix some warnings.
2574 Tue Aug 3 18:38:40 2004 Matthias Clasen <maclas@gmx.de>
2576 * gtk/gtktreemodelfilter.c: Correct the return type
2577 of gtk_tree_model_filter_get_flags(). (#149195, Morten Welinder)
2579 Tue Aug 3 18:16:55 2004 Matthias Clasen <maclas@gmx.de>
2581 Fix #149191, reported by Morten Welinder:
2583 * gtk/gtkmain.c: Include gtkclipboard.h,
2584 * gtk/gtkwidget.h: Declare _gtk_widget_grab_notify, not
2585 _gtk_widget_emit_grab_notify.
2587 Tue Aug 3 14:50:14 2004 Matthias Clasen <maclas@gmx.de>
2589 * gtk/gtkicontheme.c (add_size): Add missing parens.
2590 (#149190, Morten Welinder)
2592 Tue Aug 3 14:29:49 2004 Matthias Clasen <maclas@gmx.de>
2594 * gtk/gtkcombobox.c (gtk_combo_box_menu_fill): Remove
2595 accidentally committed debug code.
2597 Tue Aug 3 01:19:12 2004 Matthias Clasen <maclas@gmx.de>
2599 * gtk/gtkcombobox.c (gtk_combo_box_relayout_item): Optimize
2600 for the case that row_column and col_column are unset.
2601 (#148868, Lorenzo Gil SĂ¡nchez)
2603 Mon Aug 2 21:52:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2605 * gdk/x11/gdkwindow-x11.c (ensure_sync_counter): New
2606 function. Make sure the sync counter is recreated when a window is
2607 reparented to become a toplevel. (#148358)
2609 2004-08-02 Matthias Clasen <mclasen@redhat.com>
2611 * tests/testcombo.c: Some trees in combo boxes.
2613 * gtk/gtkcombobox.c: Rework the combo box to handle
2614 tree models. (#139582, Matt Walton)
2616 * gtk/gtktreeview.h:
2617 * gtk/gtktreeview.c:
2618 * gtk/gtktreeprivate.h: Add a new boolean property
2619 ::hover-expand and make the treeview expand/collapse rows
2620 on mouseover if it is set.
2622 * gtk/gtkiconview.h: Remove some erroneous declarations.
2624 * gtk/gtkcellview.c (gtk_cell_view_set_cell_data): Don't
2625 crash if the displayed row is gone.
2627 2004-08-02 Morten Welinder <terra@gnome.org>
2629 * gtk/gtkentry.c (gtk_entry_motion_notify): C99ism.
2631 Mon Aug 2 01:30:03 2004 Matthias Clasen <maclas@gmx.de>
2633 * gtk/gtktextview.[hc]:
2634 * gtk/gtkentry.[hc]: Add a new binding signal ::backspace,
2635 bind it to the backspace key, and make it pay attention
2636 to the Pango backspace_deletes_character
2637 attribute. (#119891, Noah Levitt, patch by Theppitak
2640 Mon Aug 2 01:02:57 2004 Matthias Clasen <maclas@gmx.de>
2642 * gdk/x11/gdkevents-x11.c (gdk_check_wm_state_changed):
2643 (gdk_check_wm_desktop_changed): Add missing error
2644 traps. (#149011, Thomas Leonard)
2646 Mon Aug 2 00:21:26 2004 Matthias Clasen <maclas@gmx.de>
2648 * gtk/gtktextview.c (blink_cb): Add the same warning
2649 that the blink_cb() in GtkEntry already has. (#148733)
2651 Mon Aug 2 00:12:16 2004 Matthias Clasen <maclas@gmx.de>
2653 * gtk/gtkentry.c (gtk_entry_class_init):
2654 (gtk_entry_get_alignment):
2655 (gtk_entry_set_alignment): Document the xalign property
2656 and its getter and setter as 2.4 additions. (#148978,
2659 Mon Aug 2 00:11:31 2004 Matthias Clasen <maclas@gmx.de>
2661 * gtk/gtkuimanager.c (gtk_ui_manager_class_init):
2662 * gtk/gtkactiongroup.c (gtk_action_group_class_init): Use
2663 canonical signal names in doc comments, since gtk-doc won't
2664 pick up signal docs with underscores.
2666 2004-08-01 Matthias Clasen <mclasen@redhat.com>
2668 * configure.in: Post-release version bump
2670 * === Released 2.5.1 ===
2672 Thu Jul 29 16:36:42 2004 Jonathan Blandford <jrb@redhat.com>
2674 * gtk/gtktreeprivate.h: New arguments
2676 * gtk/gtktreeview.c:
2677 (gtk_tree_view_class_init): Add key_release callback
2678 (gtk_tree_view_init): Initialize timeout handler
2679 (gtk_tree_view_unrealize): clear timeout if needed
2680 (gtk_tree_view_key_press): Typeahead support
2681 (gtk_tree_view_key_release): Not used yet -- will be needed for
2683 (gtk_tree_view_search_entry_flush_timeout): Remove typeahead entry
2685 (gtk_tree_view_ensure_interactive_directory):
2686 (gtk_tree_view_real_start_interactive_search):
2687 (gtk_tree_view_search_init):
2688 (gtk_tree_view_start_interactive_search): Typeahead support added.
2689 (gtk_tree_view_search_dialog_hide): Clear timeout and text when we
2692 Sat Jul 31 23:17:44 2004 Matthias Clasen <maclas@gmx.de>
2696 Sat Jul 31 01:13:01 2004 Matthias Clasen <maclas@gmx.de>
2700 * gtk/gtkaction.c: Use the canonical form of signal names
2701 after "notify::". Otherwise, no notification arrives.
2702 GObject should have a warning for that, really. (#148879,
2703 Lorenzo Gil SĂ¡nchez)
2705 Sat Jul 31 00:42:08 2004 Matthias Clasen <maclas@gmx.de>
2707 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below):
2708 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_above): Don't
2709 set both states at once. (#148789, Matthew Garrett)
2711 2004-07-30 Matthias Clasen <mclasen@redhat.com>
2713 * gtk/gtkcombobox.c: Don't forget to destroy the row separator
2714 function user data when the combo box is destroyed.
2716 2004-07-30 Matthias Clasen <mclasen@redhat.com>
2718 * gtk/gtkcombobox.h:
2719 * gtk/gtkcombobox.c: Change the api for separators to use a
2720 separator function instead of a boolean column.
2722 * tests/testcombo.c: Update to match the api change.
2724 Fri Jul 30 02:21:41 2004 Matthias Clasen <maclas@gmx.de>
2726 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2727 Fix the positioning of the popup.
2729 Fri Jul 30 00:56:31 2004 Matthias Clasen <maclas@gmx.de>
2731 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_active_changed):
2732 Implement this in terms of gtk_combo_box_get_active_iter(),
2733 instead of gtk_combo_box_get_active().
2735 2004-07-29 Federico Mena Quintero <federico@ximian.com>
2737 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
2738 a field for an "add to shortcuts" menu item.
2739 (popup_menu_detach_cb): Clear out the field.
2740 (file_list_build_popup_menu): Only build the menu here.
2741 (file_list_update_popup_menu): Build the menu, then update the
2742 sensitivity of its items.
2743 (file_list_popup_menu): Use file_list_update_popup_menu().
2744 (bookmarks_check_add_sensitivity): Also set the sensitivity of the
2745 popup menu item. Correctly handle the case for a *single* file.
2747 (bookmarks_add_selected_folder): New helper function; code moved
2748 over from add_bookmark_button_clicked_cb().
2749 (add_bookmark_button_clicked_cb): Use the function above.
2750 (selection_check): Rather than returning a boolean value for
2751 emptiness, actually return the number of selected rows. Also,
2753 (get_selected_path): New helper function.
2755 2004-07-29 Anders Carlsson <andersca@gnome.org>
2757 * demos/gtk-demo/Makefile.am:
2758 * demos/gtk-demo/clipboard.c: (copy_button_clicked),
2759 (paste_received), (paste_button_clicked), (do_clipboard):
2762 2004-07-28 Federico Mena Quintero <federico@ximian.com>
2764 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
2765 Store signal IDs in gulongs, not guints!
2766 (gtk_file_chooser_default_hierarchy_changed): We now monitor the
2767 focus widget on our toplevel to know which widget was last focused
2768 at the time our "should_respond" method gets called.
2769 (shortcuts_activate_selected): New helper function.
2770 (shortcuts_get_selected): New helper function.
2771 (remove_selected_bookmarks): Use shortcuts_get_selected().
2772 (bookmarks_check_remove_sensitivity): Likewise.
2773 (shortcuts_reorder): Likewise.
2774 (shortcuts_activate_iter): Renamed from shortcuts_activate_item().
2775 Activate by iter, not by item number.
2776 (save_folder_combo_changed_cb): Use shortcuts_activate_iter().
2777 (shortcuts_row_activated_cb): Likewise.
2778 (gtk_file_chooser_default_should_respond): If the last focused
2779 widget on the toplevel was the shortcuts list, activate the
2782 2004-07-28 Matthias Clasen <mclasen@redhat.com>
2784 * gdk/linux-fb/gdkprivate-fb.h: Make the fb backend compile against
2785 current freetype. (#148558, Nicolas Deves)
2787 * gtk/gtktreeview.c: Replace the EXPANDER_MAX macro by
2788 ROW_HEIGHT. (#145528)
2790 * gtk/gtkuimanager.c: Warning fixes.
2792 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_background): Fix
2793 prototype mismatch. (#148589, Nicolas Deves)
2795 2004-07-28 Anders Carlsson <andersca@gnome.org>
2797 * gdk/x11/gdkdrawable-x11.c (gdk_draw_rectangle_alpha_libgtk_only):
2798 Cast to 32-bit integers when premultiplying, suggested by Keith Packard.
2800 2004-07-27 Anders Carlsson <andersca@gnome.org>
2802 * demos/gtk-demo/iconview.c: (do_iconview):
2803 Change selection mode to multiple.
2805 * gdk/gdkdrawable.h:
2806 * gdk/linux-fb/gdkdrawable-fb2.c:
2807 (gdk_draw_rectangle_alpha_libgtk_only):
2808 * gdk/win32/gdkdrawable-win32.c:
2809 (gdk_draw_rectangle_alpha_libgtk_only):
2810 * gdk/x11/gdkdrawable-x11.c: (gdk_x11_draw_image),
2811 (get_impl_drawable), (gdk_x11_draw_pixbuf),
2812 (gdk_draw_rectangle_alpha_libgtk_only):
2813 Add gdk_draw_rectangle_alpha_libgtk_only which uses
2814 XRenderFillRectangle on X11. It's stubbed out on the
2815 Win32 and fb backends.
2817 * gtk/gtkiconview.c:
2818 (gtk_icon_view_paint_rubberband):
2819 Use gdk_draw_rectangle_alpha_libgtk_only here.
2821 2004-07-27 Anders Carlsson <andersca@gnome.org>
2823 * gtk/gtkaboutdialog.c: (gtk_about_dialog_init),
2824 (text_view_style_set), (add_credits_page),
2825 (display_credits_dialog), (display_license_dialog):
2826 Remove dialog separators, fix text view background setting,
2827 use Close buttons instead of OK buttons.
2829 2004-07-27 Matthias Clasen <mclasen@redhat.com>
2831 * gtk/gtktreeview.c (gtk_tree_view_ensure_interactive_directory):
2832 Add a frame around the C-f popup to stop it from merging visually
2833 in whatever is underneath.
2835 * gtk/gtkcombobox.h:
2836 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible): New
2837 function necessary to make GtkComboBox accessible. (#132847,
2840 Tue Jul 27 02:34:06 2004 Matthias Clasen <maclas@gmx.de>
2842 * gtk/gtkwidget.c (gtk_widget_dispose): Hide parentless
2843 windows when disposing them. (#133231, Michael Natterer)
2845 2004-07-26 Matthias Clasen <mclasen@redhat.com>
2847 * gtk/gtklabel.c (gtk_label_class_init): Expand the documentation
2848 for GtkLabel::ellipsize.
2850 Mon Jul 26 00:38:27 2004 Matthias Clasen <maclas@gmx.de>
2852 Make the GtkComboBox in list mode scroll if the list is too
2853 large to fit in the popup. (#135543)
2855 * gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Add a
2856 o scrolled window to the popup in list mode.
2857 (gtk_combo_box_list_position): Calculate the height of the
2858 popup so that it fits on the screen, set the scrollbar policy
2859 of the scrolled window appropriately.
2860 (gtk_combo_box_popup): Use the height calculated by
2861 gtk_combo_box_list_position().
2862 (gtk_combo_box_remeasure): Don't add unnecessary padding.
2863 (gtk_combo_box_size_request): But add the focus with here.
2864 (gtk_combo_box_list_setup): Connect to enter notify on the
2865 popup window to activate auto scrolling.
2866 (gtk_combo_box_list_enter_notify): Activate auto scrolling.
2867 (gtk_combo_box_list_button_pressed): Setup a timeout for
2869 (gtk_combo_box_list_scroll_timeout): Timeout function for
2871 (gtk_combo_box_list_auto_scroll): Scroll the list when the
2872 pointer leaves the window.
2874 Sun Jul 25 19:51:17 2004 Matthias Clasen <maclas@gmx.de>
2876 * gtk/gtknotebook.c (gtk_notebook_scroll): Ignore scroll
2877 events from the content of the page. (#148409, Gabriel
2880 Sat Jul 24 21:38:12 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2882 * gtk/gtktoolbar.c (internal_insert_element): Warn if you try to
2883 add a tool item to a toolbar using the deprecated API.
2885 Fri Jul 23 13:04:10 2004 Matthias Clasen <maclas@gmx.de>
2887 * gtk/gtkdnd.c (gtk_drag_dest_set): Revert the change to
2888 initialize target_list to an empty list instead of NULL,
2889 since it broke tree dnd. (#148215, Ernst Persson)
2891 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
2892 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): Instead
2893 handle target list being NULL here.
2895 2004-07-23 Dafydd Harries <daf@muse.19inch.net>
2897 * gtk/gtkradioaction.c:
2898 * gtk/gtkradiobutton.c:
2901 Improve various translatable messages. (#137616)
2903 Fri Jul 23 11:11:10 2004 Matthias Clasen <maclas@gmx.de>
2905 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
2906 Align the entry in the same way as the cell. (#136749)
2908 Fri Jul 23 11:01:00 2004 Matthias Clasen <maclas@gmx.de>
2910 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
2911 Don't iterate too far up. (#147965, Olivier Sessink)
2913 Fri Jul 23 10:28:43 2004 Matthias Clasen <maclas@gmx.de>
2915 * gtk/gtktreeview.c (gtk_tree_view_finalize):
2916 * gtk/gtkradioaction.c (gtk_radio_action_finalize):
2917 * gtk/gtkfontsel.c (gtk_font_selection_finalize):
2918 * gtk/gtkcellview.c (gtk_cell_view_finalize):
2919 * gtk/gtkcalendar.c (gtk_calendar_finalize):
2920 * gtk/gtkactiongroup.c (gtk_action_group_finalize): Remove
2921 unnecessary checks. (#148175, Morten Welinder)
2923 Thu Jul 22 01:42:16 2004 Matthias Clasen <maclas@gmx.de>
2925 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
2926 Add a new :ellipsize property which controls ellipsization of the
2927 rendered text. (#144835, Vincent Untz, patch by Jonathan Blandford
2928 and Anders Carlsson)
2930 * gtk/gtkfilechooserdefault.c (create_file_list): Use ellipsization
2931 for the name column.
2933 Thu Jul 22 01:21:28 2004 Matthias Clasen <maclas@gmx.de>
2935 * gtk/gtkfontsel.c (gtk_font_selection_init): Add additional
2936 accessability relations. (#141804, Padraig O'Briain)
2938 Thu Jul 22 01:16:23 2004 Matthias Clasen <maclas@gmx.de>
2940 * gtk/gtkcombobox.c: Avoid some warnings.
2942 Thu Jul 22 01:05:16 2004 Matthias Clasen <maclas@gmx.de>
2944 * configure.in: Require Pango 1.5.1 (for ellipsisation).
2947 * gtk/gtklabel.c (gtk_label_class_init): Add a new :ellipsize
2948 property which controls ellipsization of the label. (#125250,
2949 Tim Van Wassenhove, patch by James M. Cape)
2951 * tests/testellipsise.c: Simple test for ellipsizsation.
2953 Wed Jul 21 22:46:27 2004 Matthias Clasen <maclas@gmx.de>
2955 * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
2956 list store. (#148134, Crispin Flowerday)
2958 Wed Jul 21 22:35:47 2004 Matthias Clasen <maclas@gmx.de>
2960 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
2961 menu. (#148110, Tommi Komulainen)
2963 Wed Jul 21 22:24:10 2004 Matthias Clasen <maclas@gmx.de>
2965 * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak
2966 tree model and tree row reference. (#148125, Crispin Flowerday)
2968 Wed Jul 21 22:17:06 2004 Matthias Clasen <maclas@gmx.de>
2970 * tests/testcombo.c (main): Don't leak models. (#148128,
2973 Wed Jul 21 21:26:08 2004 Matthias Clasen <maclas@gmx.de>
2975 * gtk/gtkviewport.c (viewport_set_adjustment): Don't leak
2976 the adjustments. (#148089, Tommi Komulainen)
2978 Wed Jul 21 21:20:21 2004 Matthias Clasen <maclas@gmx.de>
2980 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't leak
2981 the adjustments. (#148073, Tommi Komulainen)
2983 Wed Jul 21 21:04:50 2004 Matthias Clasen <maclas@gmx.de>
2985 * gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the
2986 arrow. (#148064, Tommi Komulainen)
2988 2004-07-21 Matthias Clasen <mclasen@redhat.com>
2990 * gtk/gtkcalendar.c: Use the new text target functionality
2991 in GtkTargetList instead of hardcoding a subset of text targets.
2993 Tue Jul 20 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
2995 * gdk/x11/gdkevents-x11.c: Hook up gtk-menu-bar-accel to
2996 an XSetting, Gtk/MenuBarAccel. (#120859, Scott James Remnant)
2998 Tue Jul 20 22:26:29 2004 Matthias Clasen <maclas@gmx.de>
3000 * gtk/gtkfilechooserutils.h:
3001 * gtk/gtktoolbutton.c:
3003 * gtk/gtkicontheme.c:
3004 * gtk/gtkcalendar.c:
3005 * demos/gtk-demo/ui_manager.c:
3006 * demos/gtk-demo/appwindow.c: Remove trailing commas
3007 from enumerations. (#148035)
3009 2004-07-20 Federico Mena Quintero <federico@ximian.com>
3011 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Fix the
3012 documentation comment for the editing-started signal.
3014 * gtk/gtkmarshalers.list: Added VOID:OBJECT,STRING for
3015 GtkCellRenderer::editing-started.
3017 2004-07-20 Matthias Clasen <mclasen@redhat.com>
3019 * tests/testactions.c (main):
3020 * tests/testmerge.c (main): Add some refcount debugging.
3022 * gtk/gtkuimanager.c (update_node, free_node): Ref an sink
3023 all proxies, so that we can properly clean up floating proxies
3024 which the app didn't adopt. (#147926, Tommi Komulainen)
3026 2004-07-20 Matthias Clasen <mclasen@redhat.com>
3028 Allow custom initialization of cell editables. (#147221)
3030 * gtk/gtkcellrenderer.h (struct _GtkCellRendererClass):
3031 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Add a
3032 ::editing-started signal as a hook for setting up the
3034 (gtk_cell_renderer_start_editing): ...and emit it here.
3036 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
3038 * gtk/gtktreeview.c (gtk_tree_view_button_press): Set drag_pos
3039 before grabbing the focus, since we may reenter into
3040 gtk_tree_view_motion_resize_column() which requires drag_pos
3041 to be set. (#147913, Guilherme Salgado, patch by John Finlay)
3043 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
3045 * gtk/gtktreeview.c (gtk_tree_view_enter_notify): Don't
3046 use uninitialized node pointer. (#147911, Peter Zelezny)
3048 Tue Jul 20 04:34:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3050 * configure.in: Bump version number
3052 Sun Jul 18 17:21:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3054 * === Released 2.5.0 ===
3058 * tests/testcombo.c: Fix compilation
3060 2004-07-19 Matthias Clasen <mclasen@redhat.com>
3062 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_popup_completion):
3065 2004-07-19 Matthias Clasen <mclasen@redhat.com>
3067 Make GtkCellView public, since people seem to have uses for it,
3068 it is clean API and we were just conservative in not making it
3069 public initially. At the same time, get rid of GtkCellViewMenuItem,
3070 which doesn't have any function which can't be served by a
3071 GtkMenuItem with a GtkCellView child. (#136637, Padraig O'Briain)
3073 * gtk/gtk.h: Include gtkcellview.h
3075 * gtk/Makefile.am (gtk_public_h_sources):
3077 * gtk/Makefile.am (gtk_private_h_sources):
3078 (gtk_c_sources): Remove gtkcellviewmenuitem.[hc]
3079 * gtk/gtkcombobox.c: Replace all uses of GtkCellViewMenuItem by
3080 GtkMenuItem with a GtkCellView child.
3082 * gtk/gtkcellviewmenuitem.[hc]: Removed.
3084 2004-07-19 Matthias Clasen <mclasen@redhat.com>
3086 Support inline autocompletion in entries (#135953)
3088 * gtk/gtkentryprivate.h:
3089 * gtk/gtkentrycompletion.h:
3090 * gtk/gtkentrycompletion.c (gtk_entry_completion_class_init):
3091 Add a new signal ::insert-prefix which can be used to override
3092 the default inline-completion behaviour. Add two new boolean
3093 properties, :popup_completion and :inline_completion which
3094 determine how the possible completions should be presented.
3095 (gtk_entry_completion_insert_prefix): New function to request
3098 * gtk/gtkentry.c: Add the necessary glue for inline completion.
3100 Sun Jul 18 15:28:24 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3102 * gtk/gtkdnd.c (gtk_drag_source_set, gtk_drag_dest_set): Create an
3103 empty target list if targets is NULL.
3105 * configure.in: Add check for X11/extensions/sync.h. (#147416,
3108 Sun Jul 18 01:24:31 2004 Matthias Clasen <maclas@gmx.de>
3110 * NEWS: Updates for 2.5.0
3112 Sat Jul 17 23:11:04 2004 Matthias Clasen <maclas@gmx.de>
3114 * gtk/gtkiconview.h:
3115 * gtk/gtkiconview.c (gtk_icon_view_class_init):
3116 * gtk/gtkiconview.c (gtk_icon_view_set_orientation):
3117 * gtk/gtkiconview.c (gtk_icon_view_get_orientation):
3118 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
3119 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row):
3120 Add a new :orientation property to determine whether text
3121 is positioned below or beside icons. (#147463)
3123 Sat Jul 17 23:03:30 2004 Matthias Clasen <maclas@gmx.de>
3125 * gtk/gtkiconview.c (gtk_icon_view_paint_item):
3126 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
3127 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row): Draw
3128 focus indicator outside the selection, respect focus
3129 line width. (#147460)
3131 Sat Jul 17 01:17:33 2004 Matthias Clasen <maclas@gmx.de>
3133 * gdk/x11/gdkdnd-x11.c (xdnd_check_dest): Fix a warning
3136 Sat Jul 17 00:48:27 2004 Matthias Clasen <maclas@gmx.de>
3138 Support text/plain selection target (#55117, Owen Taylor)
3140 * gtk/gtkselection.h:
3142 * gtk/gtkselection.c (gtk_target_list_add_text_targets):
3143 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
3144 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): New
3145 functions to facilitate handling of text targets.
3148 * gtk/gtktextview.c: Use the new text target handling
3149 functions instead of hardwiring the list of supported
3150 text targets everywhere.
3152 * gtk/gtkselection.c (gtk_selection_data_get_text):
3153 (gtk_selection_data_set_text):
3154 Support the targets text/plain, text/plain?charset=utf-8
3155 and text/plain?charset=<LOCALE-CHARSET> as outlined in
3157 For text/plain send only ASCII, but accept 8-bit text
3158 and treat it as ISO-8859-1 as specified by the Xdnd spec.
3159 Always send CRLF terminators. Accept either and convert
3160 into the native terminator for the platform.
3162 Fri Jul 16 23:20:34 2004 Matthias Clasen <maclas@gmx.de>
3164 Support themed window icons. (#92346, Calum Benson)
3166 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): New
3167 function to obtain information about the sizes in which an
3171 * gtk/gtkwindow.c (gtk_window_class_init):
3172 (gtk_window_set_icon_name):
3173 (gtk_window_get_icon_name): Add an "icon_name" property
3174 (gtk_window_set_default_icon_name): ...and a default icon name.
3175 (icon_list_from_theme):
3176 (update_themed_icon): New auxiliary functions to create a
3177 list of all available sizes of a themed icon and update the
3178 window icon list from it.
3180 2004-07-16 Matthias Clasen <mclasen@redhat.com>
3182 * gtk/gtkcombobox.c (gtk_combo_box_scroll_event): Make
3183 scrolling work if no item is selected.
3184 (gtk_cell_editable_key_press): Don't eat space.
3186 Add a combo box cell renderer (#139347, Lorenzo Gil Sanchez)
3188 * gtk/gtkcellrenderercombo.[hc]: New Files.
3191 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
3194 * gtk/gtkcombobox.[hc]: Implement GtkCellEditable, add a
3195 :has-frame property for suppressing the frame around
3196 the child and redo the size allocation logic to take
3197 focus width into account.
3199 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_init):
3200 Acknowledge the GtkComboBox:has-frame property and make
3201 the entry fill its allocation vertically.
3203 * gtk/gtkmarshalers.list: Add BOOLEAN:STRING.
3205 * gtk/gtktreeview.c (gtk_tree_view_remove_widget): Queue
3206 a draw here to keep non-widget windows from leaving
3209 2004-07-16 Matthias Clasen <mclasen@redhat.com>
3211 * gtk/gtkcombobox.c (gtk_combo_box_forall): Don't iterate
3212 multiple times over some of the children.
3214 Thu Jul 15 22:19:40 2004 Matthias Clasen <maclas@gmx.de>
3216 Fix #60128, #58307, #144706:
3218 * gtk/gtkstyle.c (gtk_style_real_copy): Handle references
3219 to bg_pixmaps properly.
3220 (gtk_style_real_unrealize): Don't keep dangling references
3222 (gtk_style_attach): Split the loop into two loops, first
3223 looking for a matching style, then for an empty one.
3224 (gtk_style_finalize):
3225 (gtk_style_duplicate): Add comments explaining the handling
3228 Thu Jul 15 20:31:28 2004 Matthias Clasen <maclas@gmx.de>
3230 * gtk/gtkspinbutton.c (start_spinning): Install the timeout
3231 before changing the value, so that a ::value_changed handler
3232 has a chance to remove it. (#122427, Elke Meier)
3234 Thu Jul 15 19:20:05 2004 Matthias Clasen <maclas@gmx.de>
3236 * gdk/x11/gdkgtk+/im-x11.c (_gdk_x11_initialize_locale):
3237 * gtk/gtkcalendar.c (gtk_calendar_class_init): Use 'cannot'
3238 instead of 'can not' in messages. (#144226, Morten Welinder)
3240 2004-07-15 Matthias Clasen <mclasen@redhat.com>
3242 * gtk/gtktreeview.c (gtk_tree_view_class_init):
3243 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
3244 Correct the declared default values of several properties
3245 to be in sync with the actual initial values.
3247 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_class_init):
3248 Make spacing a property, correct the declared default values
3249 of several properties to be in sync with the actual initial
3250 values. (#147654, Matthias Clasen)
3252 * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Don't reparent
3253 back to menu->toplevel if it is already gone because we're
3254 shutting down. (#147656, John Cupitt)
3256 2004-07-14 Federico Mena Quintero <federico@ximian.com>
3260 * gtk/gtktreeview.c (gtk_tree_view_bin_expose): Draw a focus
3261 indicator along the edge of the bin_window when the tree is empty.
3262 (grab_focus_and_unset_draw_keyfocus): New helper function.
3263 (gtk_tree_view_button_press): Remove a bit of superfluous code.
3264 Use the helper function to save on duplicated code.
3265 (gtk_tree_view_button_press): Grab the focus if the tree is empty.
3266 (gtk_tree_view_focus): Allow focusing into an empty tree.
3268 2004-07-14 Matthias Clasen <mclasen@redhat.com>
3270 * gtk/gtkaboutdialog.c (add_credits_page): Don't use
3271 gcc extensions for the ternary ?: operator. (#147590,
3274 2004-07-14 Federico Mena Quintero <federico@ximian.com>
3276 Fix #144405, patch by Padraig O'Briain <padraig.obriain@sun.com>:
3278 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): Set the
3279 accessible object name for the tree view.
3280 (create_file_list): Likewise.
3282 Tue Jul 13 21:53:08 2004 Matthias Clasen <maclas@gmx.de>
3284 * gtk/gtkicontheme.c (free_unthemed_icon): Don't leak
3285 no_svg_filename. (#147399, Kjartan Maraas)
3287 2004-07-13 Matthias Clasen <mclasen@redhat.com>
3289 * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_get_neighbor_sizes):
3290 Make this work in RTL context.
3292 2004-07-13 Federico Mena Quintero <federico@ximian.com>
3294 * gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Set a
3295 busy cursor while mounting the volume. Also, ref the chooser
3296 while mounting, as we may re-enter. Fixes #139376.
3298 2004-07-13 Matthias Clasen <mclasen@redhat.com>
3300 * gtk/gtktreeview.c (gtk_tree_view_adjustment_changed):
3301 Prepare to handle composite implementations of
3302 GtkCellEditable, but recursively poking at
3303 allocation->y (hack stolen from GtkCList).
3304 (check_expander_max): Tweak the warning.
3306 * gtk/gtkmain.h: Add gtk_parse_args(), its a public
3307 function. (#147476, Owen Taylor)
3309 * gtk/gtkcombobox.c (gtk_combo_box_popdown): Don't
3310 crash if unrealized.
3312 Tue Jul 13 01:50:06 2004 Matthias Clasen <maclas@gmx.de>
3314 * gtk/gtkaboutdialog.c (display_credits_dialog): Don't
3315 display untranslated translator credits.
3317 Tue Jul 13 01:15:05 2004 Matthias Clasen <maclas@gmx.de>
3319 * gtk/gtkiconview.c: Some documentation updates.
3321 Tue Jul 13 00:40:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3323 * gdk/gdkwindow.c (gdk_window_process_updates_internal): Do an
3324 empty begin_paint_region()/end_paint() for windows without
3327 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_unset_bg,
3328 _gdk_x11_window_tmp_reset_bg): Remove checks for EXPOSURE_MASK.
3330 2004-07-12 Matthias Clasen <mclasen@redhat.com>
3332 * demos/gtk-demo/appwindow.c: Use a GtkAboutDialog.
3334 * gtk/gtkaboutdialog.h:
3335 * gtk/gtkaboutdialog.c: New widget: GtkAboutDialog.
3337 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
3338 * gtk/gtk.h: Add GtkAboutDialog. (#109435, Paolo Borelli,
3339 patch by Matthias Clasen)
3341 * gtk/gtkrc.c (_gtk_rc_init): Apply the gtk-default-menu-item-style
3342 to cell view menu items as well. (#147405, John Cupitt)
3344 * gtk/gtkentrycompletion.c: Warning fixes. (#147420,
3347 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Pop down
3348 first. (#147399, John Cupitt)
3350 Mon Jul 12 01:56:26 2004 Matthias Clasen <maclas@gmx.de>
3352 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
3353 Include the update_counter check in the HAVE_XSYNC condition,
3354 since update_counter isn't present in the !HAVE_XSYNC case.
3356 Mon Jul 12 00:52:04 2004 Matthias Clasen <maclas@gmx.de>
3358 * gtk/stock-icons/Makefile.am:
3359 * gtk/stock-icons/stock_about_{16,24}.png:
3360 * gtk/stock-icons/stock_connect_{16,24}.png:
3361 * gtk/stock-icons/stock_disconnect_{16,24}.png:
3362 * gtk/stock-icons/stock_edit_{16,24}.png:
3363 * gtk/stock-icons/stock_media_forward_{16,24}.png:
3364 * gtk/stock-icons/stock_media_next_{16,24}.png:
3365 * gtk/stock-icons/stock_media_pause_{16,24}.png:
3366 * gtk/stock-icons/stock_media_play_{16,24}.png:
3367 * gtk/stock-icons/stock_media_previous_{16,24}.png:
3368 * gtk/stock-icons/stock_media_record_{16,24}.png:
3369 * gtk/stock-icons/stock_media_rewind_{16,24}.png:
3370 * gtk/stock-icons/stock_media_stop_{16,24}.png:
3371 * gtk/gtkstock.h (GTK_STOCK_ABOUT):
3372 * gtk/gtkstock.h (GTK_STOCK_CONNECT):
3373 * gtk/gtkstock.h (GTK_STOCK_DISCONNECT):
3374 * gtk/gtkstock.h (GTK_STOCK_EDIT):
3375 * gtk/gtkstock.h (GTK_STOCK_MEDIA_FORWARD):
3376 * gtk/gtkstock.h (GTK_STOCK_MEDIA_NEXT):
3377 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PAUSE):
3378 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PLAY):
3379 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PREVIOUS):
3380 * gtk/gtkstock.h (GTK_STOCK_MEDIA_RECORD):
3381 * gtk/gtkstock.h (GTK_STOCK_MEDIA_REWIND):
3382 * gtk/gtkstock.h (GTK_STOCK_MEDIA_STOP):
3383 * gtk/gtkiconfactory.c (get_default_icons):
3384 * gtk/gtkstock.c (builtin_items): Add a number of new stock
3385 items. (#102530, #68015, #109811, Jordi Mallach, Benjamin Otte,
3388 Sun Jul 11 15:24:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3390 Bug 143330, support update counter spec.
3392 * configure.in: Add check for the Sync extension
3394 * gdk/gdkwindow.h: gdk_window_enable_synchronized_configure() and
3395 gdk_window_configure_finished()
3397 * gtk/gtkwindow.c (gtk_window_move_resize): Call gdk_window_finish_configure().
3398 * gtk/gtkwindow.c (gtk_window_realize): Automatically enable
3399 synchronized configures.
3401 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Store current
3402 and pending counter values.
3404 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): New function.
3405 * gdk/x11/gdkwindow-x11.c
3406 (gdk_window_enable_synchronized_configure): New function.
3407 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
3408 Delete update counter.
3409 * gdk/x11/gdkwindow-x11.c (set_wm_protocols): Advertise
3410 _NET_WM_SYNC_REQUEST when Sync is available
3412 * gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Handle
3413 _NET_WM_SYNC_REQUEST messages
3414 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Save counter
3415 value for use by gdk_window_configure_finished() when receiving
3418 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add use_sync flag
3419 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Check if the XSync
3420 extension is available
3421 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_SYNC_REQUEST and
3422 _NET_WM_SYNC_REQUEST_COUNTER to list of supported atoms.
3424 * gdk/linux-fb/gdkwindow-fb.c, gdk/win32/gdkwindow-win32.c: Add
3425 stubs for enable_synchronized_configure() and configure_finished()
3427 Sat Jul 10 23:35:13 2004 Matthias Clasen <maclas@gmx.de>
3429 * gtk/gtkentry.c (paste_received): Make middle-button pasting
3430 work as expected inside the entry. (#116789, Scott Bronson)
3432 Sat Jul 10 22:13:53 2004 Matthias Clasen <maclas@gmx.de>
3434 * gtk/gtktextbuffer.c (gtk_text_buffer_select_range): Update
3435 clipboards. (#142805, Mikael Hallendal)
3437 Sun Jul 11 01:38:48 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3439 * gtk/gtkpaned.c (gtk_paned_expose): Remove clip-region computing
3440 code. Just use &paned->handle_pos.
3442 Sun Jul 11 01:12:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3446 * gtk/gtknotebook.c (gtk_notebook_size_allocate): Remove an
3447 unnecessary redraw..
3449 * gtk/gtknotebook.c (gtk_notebook_page_allocate): Remove some
3452 Sat Jul 10 01:33:25 2004 Matthias Clasen <maclas@gmx.de>
3454 * docs/RELEASE-HOWTO: Updates.
3456 Sat Jul 10 01:55:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3458 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{re|un}set_bg):
3459 Insert checks for root window. The root window is never mapped.
3461 Sat Jul 10 01:06:05 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3463 * gdk/x11/gdkwindow-x11.c (post_unmap): Fix a warning
3464 * gdk/x11/gdkwindow-x11.c (show_window_internal): Actually unset
3467 Sat Jul 10 00:37:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3471 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{un|re}set_bg):
3472 New functions that can do a recursive unset/reset bg.
3474 * gdk/x11/gdkgeometry-x11.c: Remove
3475 gdk_window_tmp_{un|re}set_bg().
3477 * gdk/x11/gdkwindow-x11.c (pre_unmap, post_unmap): New functions
3478 called before and after unmapping a window. They unset the
3479 background of all other windows to prevent flicker from the X
3480 server repainting the background. post_unmap() also invalidates
3481 the parent of the unmapped window to draw it without roundtrips.
3483 * gdk/x11/gdkwindow-x11.c (show_window_internal): Unset
3484 background of newly mapped windows and all desendants to prevent
3487 Fri Jul 9 15:33:55 2004 Manish Singh <yosh@gimp.org>
3489 * gdk/gdkevents.c: have a dummy case GDK_OWNER_CHANGE in switch
3490 statements to avoid gcc warnings about not all enum values handled.
3492 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): ignore should live in
3495 Fri Jul 9 23:26:09 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3499 * gdk/x11/gdkwindow-x11.h (struct _GdkWindowImplX11): Add an
3500 "override_redirect" bit.
3502 * gdk/x11/gdkwindow-x11.c (gdk_window_new): Set it here.
3504 * gdk/x11/gdkwindow-x11.c (gdk_window_move, gdk_window_resize,
3505 gdk_window_move_resize):
3506 Update the local size/position cache
3507 immediately for override redirect windows.
3509 * gdk/x11/gdkwindow-x11.c (show_window_internal): Invalidate
3510 newly mapped child and override redirect windows.
3512 2004-07-09 Federico Mena Quintero <federico@ximian.com>
3516 * gtk/gtkfilesystemunix.c (get_fallback_icon): New helper
3517 function, fetches a stock icon as a fallback.
3518 (gtk_file_system_unix_volume_render_icon): Fall back to a stock
3520 (gtk_file_system_unix_render_icon): Fall back to a stock icon.
3521 Use helper functions rather than being a mega-function.
3522 (get_icon_name_for_directory): Renamed from
3523 get_icon_for_directory().
3524 (get_icon_type_from_path): New helper function; code pulled out
3525 from gtk_file_system_unix_render_icon().
3526 (get_special_icon): Likewise.
3527 (get_icon_for_mime_type): Likewise.
3529 2004-07-09 Federico Mena Quintero <federico@ximian.com>
3531 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Fix typo; tmp_event ->
3534 2004-07-09 Matthias Clasen <mclasen@redhat.com>
3536 * gtk/gtktooltips.c (gtk_tooltips_paint_window): Use the
3537 requisition of the widget instead of relying on the style
3538 drawing function to supply the size of the drawable. (#146531)
3540 2004-07-09 Matthias Clasen <mclasen@redhat.com>
3542 Make GtkEntry work harder to protect passwords: (#143955,
3545 * gtk/gtkentry.c (gtk_entry_destroy): Add a destroy handler
3546 to clear the password even if the widget is leaked.
3548 * gtk/gtkentry.c (gtk_entry_real_delete_text):
3549 * gtk/gtkentry.c (gtk_entry_finalize): Zero out the memory
3552 * gtk/gtkentry.c (gtk_entry_real_insert_text): Zero and free
3553 the old memory instead of just reallocating it.
3555 * gtk/gtkentry.c (gtk_entry_create_layout): Don't leak text
3556 direction information for passwords.
3558 2004-07-09 Matthias Clasen <mclasen@redhat.com>
3560 * gtk/gtkstyle.c: Fix some cases where style functions were
3561 not handling widget == NULL properly. (#146282)
3563 Thu Jul 8 22:38:58 2004 Matthias Clasen <maclas@gmx.de>
3565 * gtk/gtktreeview.c: Improve the EXPANDER_MAX warning.
3567 2004-07-08 Federico Mena Quintero <federico@ximian.com>
3571 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Add a
3572 GError argument. Do check for errors when getting the
3573 GtkFileFolder: get the folder and read the children before
3574 actually creating the model. Removed obsolete code that handled
3575 roots-changed on the file system.
3576 (file_model_node_get_info): Assert that we don't reach the old
3577 case to display file system roots.
3578 (roots_changed_callback): Removed.
3580 * gtk/gtkfilechooserdefault.c (set_list_model): Add a GError
3581 argument, and a boolean return value. Return an error if we
3582 cannot create the file system model. On error, set a NULL model
3584 (gtk_file_chooser_default_set_current_folder): Use the error value
3585 from set_list_model().
3586 (gtk_file_chooser_default_set_property): Set the show_hidden
3587 property only if the browse_files_model exists.
3588 (gtk_file_chooser_default_unselect_path): Only operate if the
3589 browse_files_model exists.
3590 (check_preview_change): Check whether we have the sort_model.
3591 (change_folder_and_display_error): Copy the path we get passed
3592 before using it. There's a comment in there that explains why we
3593 need to copy it; basically, if the passed path belongs to the
3594 model, the model may go away in the middle of this function and
3595 we'll be left with a dangling pointer.
3596 (install_list_model_filter): Assert that the model is not NULL.
3597 (set_current_filter): Check whether the model exists.
3599 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Don't
3600 g_return_if_fail if the model is NULL.
3601 (gtk_tree_selection_get_selected_rows): Likewise.
3602 (gtk_tree_selection_count_selected_rows): Likewise.
3603 (gtk_tree_selection_selected_foreach): Likewise.
3604 (gtk_tree_selection_path_is_selected): Likewise; rather just
3606 (gtk_tree_selection_select_all): Likewise.
3607 (gtk_tree_selection_unselect_all): Likewise.
3608 (gtk_tree_selection_select_range): Do g_return_if_fail() if the
3610 (gtk_tree_selection_unselect_range): Likewise.
3612 * gtk/gtkfilesystemunix.c (fill_in_names): Return immediately if
3613 g_dir_open() fails: there is no need to set the error ourselves,
3614 as g_dir_open() already does it.
3616 2004-07-08 Matthias Clasen <mclasen@redhat.com>
3618 * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Allow
3619 to restore the default search function. (#145365, John Finlay)
3621 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Don't leak
3622 references to the drag context. (#144324, Alex Larsson)
3624 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
3626 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
3627 when a new model is set. (#145566, Dmitry M. Shatrov)
3629 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
3631 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
3632 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
3633 in order to avoid rendering artifacts from misaligned
3634 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
3636 2004-07-07 Matthias Clasen <mclasen@redhat.com>
3638 * gtk/gtktreeview.c:
3639 * gtk/gtktreeview.h: Small documentation fixes.
3641 2004-07-07 Matthias Clasen <mclasen@redhat.com>
3643 Support separators in combo boxes and more generally in tree
3646 * gtk/gtkcombobox.h:
3647 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
3648 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
3649 Add a ::row-separator-column property with getter and setter,
3650 which can indicate a boolean model column to determine which
3651 rows are separators.
3653 * gtk/gtkcombobox.c: Display separator rows as separator menu
3654 items in menu mode, and by using the new treeview separator
3655 functionality in list mode.
3657 * gtk/gtktreeview.h:
3658 * gtk/gtktreeprivate.h:
3659 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
3660 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
3661 Add a callback to determine whether a row is a separator.
3663 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
3664 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
3665 * gtk/gtktreeview.c (validate_row): Use the new callback
3666 to determine whether a row is a separator, and draw it
3667 as a separator then. Since separators should take up less
3668 vertical space than regular rows, this requires removing
3669 the redundant MAX(...,expander_size) calls which appear in
3670 many places. Instead, the MAX() is now only done in
3671 validate_row(), and only if the row is not a separator.
3672 To catch possible side effects of this intrusive change,
3673 I have left EXPANDER_MAX() calls in place of the MAX() calls
3674 which will emit a warning if something breaks. They should
3675 be removed before 2.6.
3677 * gtk/gtktreeselection.c (row_is_selectable): Don't let
3678 separator rows be selected.
3680 * tests/testcombo.c (create_blaat): Add a separator column.
3682 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
3684 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
3685 a 64bit alignment issue. (#144302, Sunil)
3687 2004-07-07 Tor Lillqvist <tml@iki.fi>
3689 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
3690 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
3691 * gdk/win32/gdkproperty-win32.c (find_common_locale,
3692 gdk_property_change)
3693 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
3694 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
3697 * gdk/win32/gdkglobals-win32.c
3698 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
3699 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
3700 atom. Initialize it. Declare it. Drop the variable for the
3703 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
3704 function is supposed to return the string in the locale's charset
3705 and encoding. Use g_convert().
3707 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
3708 string in the locale's charset. Use g_convert().
3710 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
3711 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
3712 GLib's UTF-16 functions instead. Windows uses UTF-16.
3714 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
3715 functions mentioned above.
3717 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
3718 also if the string is of type STRING, i.e. ISO-8859-1, and the
3719 current codepage is 1252, and contains no C1 chars. Accept
3722 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
3723 Mark as static. When storing STRING data, convert to
3725 (gdk_selection_owner_set_for_display): Now that STRING is always
3726 ISO-8859-1, use UTF8_STRING when sending the selection request
3729 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
3732 (gdk_text_property_to_text_list_for_display): Make work more like
3733 X11 version. Do obey the encoding parameter.
3735 (gdk_string_to_compound_text_for_display,
3736 gdk_utf8_to_compound_text_for_display): Don't even pretend
3737 supporting COMPOUND_TEXT.
3739 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
3741 (sanitize_utf8): Zero-terminate string.
3743 2004-07-06 Matthias Clasen <mclasen@redhat.com>
3745 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
3746 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
3748 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
3749 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
3750 fallbacks for gtkfilechooser. Currently these are the same images
3751 as the "new" and "open" items...
3753 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
3755 Fix for #136496, Pawel Salek:
3757 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
3758 a node when it changes in fixed_height mode.
3760 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
3763 2004-07-06 Matthias Clasen <mclasen@redhat.com>
3765 * gtk/gtkmenu.c (gtk_menu_position): Make sure
3766 private->monitor_num is a valid monitor number before
3767 using it. (#139187, Michael Natterer)
3769 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
3771 * gtk/gtkfilechooserdefault.c (popup_position_func):
3772 * gtk/gtkentry.c (popup_position_func):
3773 * gtk/gtktextview.c (popup_position_func): Improve positioning
3774 of keyboard-activated menus with Xinerama.
3776 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
3778 * gtk/gtkuimanager.c (do_updates):
3779 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
3780 when called from an idle handler. (#145429, Jan-Marek Glogowski)
3782 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
3784 * gtk/gtkfilechooserutils.c (delegate_notify): Use
3785 the less efficient g_object_interface_find_property () instead
3786 of the param_id range check, since the GParamSpecs we're
3787 dealing with are the overridden onces on the interface, whose
3788 param_id is always zero. (#145312, Alex Roitman, fix proposed
3791 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
3793 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
3794 virtual method of GtkContainer.
3795 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
3796 method slot of the container class.
3798 2004-07-05 Anders Carlsson <andersca@gnome.org>
3800 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
3801 * gtk/gtkiconview.h:
3802 Use gint, not int in gtk_icon_view_set_markup_column,
3805 2004-07-05 Anders Carlsson <andersca@gnome.org>
3807 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
3808 (gtk_icon_view_real_select_cursor_item),
3809 (gtk_icon_view_real_activate_cursor_item):
3810 * gtk/gtkiconview.h:
3811 Add an "activate_cursor_item" action signal
3812 and bind it to the return key.
3814 2004-07-04 Anders Carlsson <andersca@gnome.org>
3816 * demos/gtk-demo/Makefile.am:
3817 * demos/gtk-demo/gnome-fs-directory.png:
3818 * demos/gtk-demo/gnome-fs-regular.png:
3819 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
3820 (sort_func), (create_store), (item_activated), (up_clicked),
3821 (home_clicked), (do_iconview):
3822 Add a simple file browser based on the icon view.
3825 Add gtk/gtkiconview.h
3827 * gtk/gtkiconview.c: (gtk_icon_view_layout),
3828 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
3829 Fix a few bugs discovered while writing the demo.
3831 2004-07-04 Anders Carlsson <andersca@gnome.org>
3835 * gtk/gtkiconview.h:
3836 Add GtkIconView to the build, remove debugging output.
3838 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
3840 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
3841 (gtk_calendar_drag_data_received): Fix off-by-one error.
3842 GDate month is one-based and GtkCalendar month is zero-based.
3843 (#145134, William Jon McCann)
3845 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
3847 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
3848 somebody tries to move a node after itself in a list of
3849 length 1. (#145291, Sampo Nurmentaus)
3851 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
3853 * docs/faq/gtk-faq.sgml:
3854 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
3857 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
3859 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
3860 and current_height to 0 when ending the embedding. (#143675,
3861 Nickolay V. Shmyrev)
3863 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
3865 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
3866 to the right end of the entry text, even if it ends in combining
3867 marks. (#141728, Theppitak Karoonboonyanan)
3869 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
3871 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
3872 row when unsetting the model. (#138560, Christian Persch)
3874 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
3876 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
3879 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
3881 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
3882 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
3884 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
3886 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
3887 to the event mask, set a scroll_event handler.
3888 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
3889 by switching tabs. (#145244, Gabriel de Perthuis)
3891 2004-07-02 Anders Carlsson <andersca@gnome.org>
3893 * gtk/gtktreeview.c (gtk_tree_view_set_model):
3894 Make sure we check for a NULL model first.
3896 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
3898 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
3899 win32 build problem w/o wintab. Fixed #145242
3901 2004-06-30 Anders Carlsson <andersca@gnome.org>
3903 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
3904 g_return_if_fail to make sure that the model is a GtkTreeModel.
3906 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3908 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
3909 current state, not GTK_STATE_NORMAL
3911 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
3913 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3915 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
3917 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
3919 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
3920 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
3923 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
3925 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
3926 recursion by resetting icon_set->cache before freeing
3927 the cache. (#144947, Tim Janik)
3929 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
3931 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
3932 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
3933 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
3936 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
3938 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
3939 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
3940 last change in the docs.
3942 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
3944 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
3945 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
3946 NULL to unset the model. (#137211, patch by Mariano SuĂ¡rez-Alvarez)
3948 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
3950 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
3951 placement policy for GtkComboBoxEntry to be: if it fits below,
3952 place below, if it fits above place above, else place in the
3953 larger space and scroll so that the scroll arrow appear at the
3954 far end. (#144362, David A. Knight)
3956 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
3958 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
3959 use of &parent_iter. (#145007, John Finlay)
3961 2004-06-25 Bastien Nocera <hadess@hadess.net>
3963 reviewed by: Matthias Clasen <maclas@gmx.de>
3965 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
3966 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
3967 the number of keysyms per keycode is odd. Fixes #144808.
3969 2004-06-25 Matthias Clasen <mclasen@redhat.com>
3971 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
3972 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
3974 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
3976 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
3977 which was mentioned below.
3979 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
3981 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
3982 string change. (#139503, Baris Cicek)
3984 2004-06-22 Federico Mena Quintero <federico@ximian.com>
3986 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
3987 or an Open stock button for the C-l dialog depending on the action
3988 in which the file chooser operates. Fixes #141753.
3990 2004-06-22 Federico Mena Quintero <federico@ximian.com>
3992 Fixes the GTK+ part of #142308:
3994 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
3995 Use filename_to_path().
3996 (gtk_file_system_unix_uri_to_path): Likewise.
3997 (filename_to_path): Use remove_trailing_slash().
3999 2004-06-22 Matthias Clasen <mclasen@redhat.com>
4001 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
4002 for the ::move_cursor signal.
4004 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
4005 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
4008 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
4009 this gets defined for all backends, so linux-fb has a
4010 chance of compiling.
4012 * gdk/x11/gdkgc-x11.c:
4013 * gdk/gdkgc.c: Move function docs inline, add hints about
4014 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
4016 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
4017 for children of the root. (#139785, Jean-François Wauthy,
4018 patch by John Finlay)
4020 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
4021 fix. (#144750, Jeff Franks)
4023 2004-06-21 Michael Natterer <mitch@gimp.org>
4026 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
4027 function public as _gdk_x11_convert_to_format().
4029 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
4030 the pixels from the GdkPixbuf when putting them in the
4031 Xcursor image. Fixes bug #144350.
4033 2004-06-16 Federico Mena Quintero <federico@ximian.com>
4035 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
4036 visible node, free the old path before creating the new one.
4039 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
4041 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
4042 (#144198, Mariano SuĂ¡rez-Alvarez)
4044 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
4046 * gtk/gtkfilechooserdefault.c: Don't use
4047 contractions like "don't" or "isn't" in error messages.
4048 It isn't nice to use them in log entries either...
4049 (#137774, Morten Welinder, patch by Alexander Winston)
4051 2004-06-11 Federico Mena Quintero <federico@ximian.com>
4055 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
4056 Don't ref the editable node.
4057 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
4058 (_gtk_file_system_model_remove_editable): Ahem, free the node.
4060 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
4061 Added fields for edited_idle and edited_new_text.
4062 (renderer_edited_cb): Queue the
4063 creation of the folder in an idle handler.
4064 (renderer_editing_canceled_cb): Likewise for the cancellation.
4065 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
4067 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
4069 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
4071 2004-06-10 Federico Mena Quintero <federico@ximian.com>
4073 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
4075 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
4076 Refer to gtk_file_chooser_add_shortcut_folder().
4077 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
4078 gtk_file_chooser_add_shortcut_folder_uri().
4080 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
4082 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
4083 the drag before focusing the selected.day.
4084 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
4085 a beginning drag if the widget becomes insensitive.
4087 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
4089 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
4090 spinning before calling arrow_action(), so that a signal
4091 handler triggered from arrow_action() has a chance to
4092 stop the spinning. (#143966, Davyd Madeley)
4094 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
4096 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
4097 typo. (#144070, Kent Sandvik)
4099 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4101 * gtk/gtkmenu.c: Revert the "drag select" part of
4104 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
4106 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
4107 priv->model being NULL. (#143856, Mariano SuĂ¡rez-Alvarez)
4109 2004-06-07 Federico Mena Quintero <federico@ximian.com>
4111 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
4112 from 2003/Sep/12. This kept DnD in tree views within modal
4113 dialogs from working, which is especially bad for the file
4114 chooser. Fixes #135168.
4116 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
4118 Make the entry context menu work in editable text cells. The changes
4119 are based on a patch by Kristian Rietveld, which implemented an
4120 approach outlined by Owen Taylor. (#50075)
4122 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
4123 Ignore focus out if the entry menu is posted.
4124 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
4125 posted, and set up a signal handler to clear the flag if the menu
4127 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
4128 set up a timeout to stop editing if the focus is lost.
4129 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
4130 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
4131 signal on the entry and keep a pointer to the entry.
4132 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
4133 clear the pointer to the entry.
4135 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
4137 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
4138 of the ::language property. (#143802, Owen Taylor)
4140 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
4142 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
4143 (gtk_entry_completion_list_enter_notify),
4144 (gtk_entry_completion_list_motion_notify),
4145 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
4146 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
4147 use it as in the menu code to avoid the initial selection if
4148 the window pops up under the pointer. (Anders Carlsson)
4150 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4152 * tests/testmerge.c: Add a checkbox to queue an
4153 merge/unmerge. Patch from Matthias Clasen.
4155 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
4157 (rebuild_menu): New function that rebuilds the overflow menu and
4158 makes sure it doesn't start or end with a separator.
4159 (toolbar_content_new_tool_item)
4160 (toolbar_content_remove)
4161 (toolbar_content_new_compatibility): Set the rebuild_needed flag
4162 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
4163 have actually overflown an item with a proxy menu item. Also make
4164 sure we rebuild the menu if needed.
4166 Fix #125504, #142377, #143463
4168 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
4169 Obey the "priv->draw" flag. (#143692)
4171 2004-06-04 Matthias Clasen <mclasen@redhat.com>
4173 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
4174 quirk in the button size allocation code.
4176 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
4177 requested for drawing the focus indicator to the child in the
4178 !CAN_FOCUS case. This should fix issues which the Gimp has with
4179 the button allocation changes in 2.4.2.
4181 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
4183 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
4184 length of the entry contents in characters, not in bytes.
4186 * gtk/gtkentry.c (paste_received): Don't pop up the completion
4187 window on paste, noticed by Anders Carlsson.
4189 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
4191 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
4192 values and default value for the ::active property. (#143669,
4195 2004-06-03 Michael Natterer <mitch@gimp.org>
4197 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
4198 instead of accessing item->image->allocation.width/height
4199 directly. Makes widgets which only have a requisition set using
4200 gtk_widget_set_size_request() work and fixes bug #142789.
4202 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4204 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
4205 of sticky right click menus to return.
4207 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4209 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
4210 better handle the "click" case. bug Better fix for #141169.
4212 2004-06-02 Federico Mena Quintero <federico@ximian.com>
4214 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
4215 model is empty. Fixes #143536.
4217 2004-06-02 Matthias Clasen <mclasen@redhat.com>
4219 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
4220 close the dialog on focus out of the size entry. (#143505,
4223 2004-06-02 Federico Mena Quintero <federico@ximian.com>
4227 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
4228 (gtk_fnmatch_intern): Likewise; also implement this option.
4230 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
4232 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
4233 no_leading_period argument of _gtk_fnmatch().
4234 (attempt_file_completion): Likewise.
4236 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
4237 no_leading_period argument of _gtk_fnmatch().
4239 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
4241 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
4244 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
4246 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
4247 allow unless selection mode is multiple. (#142634, John Finlay)
4249 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
4253 * gtk/gtkentrycompletion.h:
4254 * gtk/gtkentrycompletion.c:
4255 * gtk/gtkcombobox.h:
4256 * gtk/gtkcombobox.c: Rename function parameters from
4257 index to index_ to prevent clash with BSD index(). (#143001)
4259 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
4261 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
4262 NULL on an accel label. (#139641, Sam Stephenson, patch by
4265 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
4267 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
4268 lookup finding icons in the wrong prefix. (#143328,
4271 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4275 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
4276 only stay up if you release within 500 milliseconds.
4277 (gtk_menu_shell_button_press): Set the activate_time to the event
4278 time when a button is pressed.
4280 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
4281 Interprete button releases as activate when we have seen both an
4282 enter an a motion event.
4284 2004-06-01 Federico Mena Quintero <federico@ximian.com>
4286 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
4287 dummy node if there is no parent node. Fixes #143362.
4289 2004-05-31 Federico Mena Quintero <federico@ximian.com>
4291 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
4292 newly-created folder. Fixes #138932.
4293 (trap_activate_cb): Only return TRUE if we did handle the event.
4294 Fixes #143359; patch by jylefort@brutele.be.
4296 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
4298 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
4299 docs. (#142892, Tommi Komulainen)
4301 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
4303 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
4304 parent is minimized, porting the fix from 1.2. (#1923, #57182)
4306 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
4308 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
4309 unmapped windows work.
4311 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
4313 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
4316 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
4318 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
4319 Refer to ::update-preview, not ::selection-changed.
4321 2004-05-29 Christian Rose <menthos@menthos.com>
4323 * configure.in: Added "tk" to ALL_LINGUAS.
4325 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
4327 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
4328 messages for common problems. (#137974, Owen Taylor)
4330 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
4332 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
4333 errors. (#143337, Billy Biggs)
4335 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
4337 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
4338 bits within visual->depth that aren't used for color to
4339 1s, in case they are alpha.
4341 2004-05-27 Anders Carlsson <andersca@gnome.org>
4343 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
4344 Make separator rows insensitive.
4346 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
4348 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
4351 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
4353 * gtk/gtkentrycompletion.h:
4354 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
4355 Getter for text_column. Also make ::text_column a property.
4357 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
4359 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
4361 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
4363 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
4364 signal if the box exists.
4366 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
4368 Support insensitive cells in tree views and combo boxes:
4370 * gtk/gtkcellrenderer.h:
4371 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
4373 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
4374 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
4375 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
4376 Support drawing insensitive.
4378 * gtk/gtkcellview.h:
4379 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
4380 function to obtain the cell renderers from a cell view. Also
4381 export gtk_cell_view_set_cell_data().
4383 * gtk/gtktreeselection.c (tree_column_is_sensitive):
4384 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
4385 to determine whether all visible cells in a row are insensitive
4386 and whether a row is selectable. A row is not selectable if the
4387 user function says so or if all visible cells are insensitive.
4388 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
4389 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
4390 Use row_is_selectable().
4392 * gtk/gtkcombobox.c (row_is_sensitive):
4393 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
4394 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
4395 to determine row sensitivity in menu or list mode.
4397 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
4398 to set up sensitivity menu items from the underlying rows.
4400 * gtk/gtkcombobox.c (gtk_combo_box_popup):
4401 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
4402 update_menu_sensitivity().
4404 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
4407 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
4410 * tests/testcombo.c (main): Make some rows insensitive.
4412 2004-05-26 Robert Ă–gren <gtk@roboros.com>
4414 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
4415 modifiers (shift, ctrl etc) in button and motion events from the
4418 2004-05-26 Robert Ă–gren <gtk@roboros.com>
4420 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
4421 implementation for extended input devices using last known
4422 device state (#143237)
4424 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
4426 * gtk/gtkframe.c: Move docs inline, fixing them on the
4427 way. (#143029, Steve Chaplin)
4429 2004-05-11 Robert Ă–gren <gtk@roboros.com>
4431 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
4432 events to windows that want extended input events. (#142943)
4433 (gdk_event_translate): Move check for extended input devices to
4434 propagate, new parameter to propagate.
4435 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
4436 _gdk_input_(un)grab_pointer. (#142943)
4438 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
4439 input grab. [Fix missing update of impl in "dijkstra" event
4440 propagation loop] Drop the parallel "impl" pointer, just use a
4441 cast. Don't propagate beyond windows that want normal input
4443 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
4444 implementation of input grab. (#142943)
4446 2004-05-22 Tor Lillqvist <tml@iki.fi>
4448 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
4449 line. (Spotted by Benoît Carpentier.)
4451 2004-05-18 Matthias Clasen <mclasen@redhat.com>
4453 * configure.in: Check for XFIXES extension.
4455 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
4456 a gboolean have_xfixes member.
4458 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
4459 XFIXES events and set have_xfixes.
4461 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
4462 (GdkEventOwnerChange): New event struct for owner change events.
4463 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
4465 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
4466 XFixesSelectionNotify events into GdkEventOwnerChange events.
4469 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
4470 (gdk_display_request_selection_notification): New api
4471 to support selection ownership notification.
4473 * gtk/gtkclipboard.h:
4474 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
4475 api to handle owner change events.
4476 (clipboard_peek): Refactored out the body of
4477 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
4479 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
4480 by calling _gtk_clipboard_handle_event().
4482 2004-05-18 Matthias Clasen <mclasen@redhat.com>
4484 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
4485 the P_() macros ourselves.
4487 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
4488 Restrict the width of the popup to be no larger than the
4489 monitor. (#142678, DmD Ljungmark)
4491 * gtk/gtkbutton.c: Go back to the initial fix for the
4492 focus-overdrawing problem, which was actually correct
4493 according to docs/widget_geometry.txt.
4495 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
4496 arrow size from 11 to 15 to compensate for that.
4498 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
4499 arguments of the ::move-cursor signal. (#142725)
4501 2004-05-17 Matthias Clasen <mclasen@redhat.com>
4505 * gtk/gtkbutton.c (gtk_button_size_request)
4506 (gtk_button_size_allocate, _gtk_button_paint): Allocate
4507 space for the focus rectangle only if necessary. (#142668,
4510 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
4514 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
4515 lines. (#142479, Morten Welinder)
4517 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
4519 * gtk/gtkintl.h (Q_): Add a Q_() macro.
4521 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
4522 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
4523 they are not really needed.
4525 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
4526 instead of hardwired padding, use Q_() for the default label,
4527 compute a reasonable minimal size. (#142571, #142572, #142573,
4528 Tommi Komulainen, Christian Persch)
4530 2004-05-15 Tor Lillqvist <tml@iki.fi>
4532 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
4533 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
4534 time). It is used by the OLE2_DND code, which is unfinished and
4535 presumably horribly broken, but still, let's not make it not
4536 compile on purpose. Silence some gcc warnings in the OLE2_DND
4539 2004-05-14 Matthias Clasen <mclasen@redhat.com>
4541 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
4542 New function to go from tree window to tree coordinates, kept
4543 static for now until we figure out the multiple coordinate
4544 system mess in GtkTreeView API-wise.
4545 (gtk_tree_view_scroll_to_cell): Transform the coordinates
4546 from tree window to tree coordinates, using the new function.
4547 Previously, the x coordinate was wrongly transformed. (#142494)
4549 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
4552 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
4553 modifier bit to mark stock item which need to be freed
4554 eventually. (#140654, Michal Pasternak, Scott Tsai)
4556 2004-05-11 Robert Ă–gren <gtk@roboros.com>
4558 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
4559 call to g_object_ref in Wintab code. (#138341)
4561 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
4562 including unallocated buffers for event->motion.axes and
4563 event->button.axes, unsigned wraparound problem in the code for
4564 detecting missing press/release events and assigning min instead
4565 of max when setting up axes.
4567 2004-05-12 Matthias Clasen <mclasen@redhat.com>
4569 * tests/testtreeedit.c: Add a progress column.
4571 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
4574 * gtk/gtk.h: Include gtkcellrendererprogress.h.
4576 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
4577 based on the one found in Epiphany.
4579 2004-05-11 Michael Natterer <mitch@gimp.org>
4581 * gtk/gtkcombobox.c (gtk_combo_box_popup)
4582 (gtk_combo_box_menu_button_press): don't allocate the popup
4583 smaller than the combobox. Fixes bug #59660.
4585 2004-05-11 Matthias Clasen <mclasen@redhat.com>
4587 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
4588 previous change to this function, clarify the docs instead.
4590 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
4591 GTK_SELECTION_BROWSE.
4593 * gtk/gtktreeview.c: Make hover selection work for
4594 GTK_SELECTION_BROWSE as well.
4596 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
4598 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
4599 Document the ::toggled signal.
4601 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4603 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
4605 2004-05-10 Matthias Clasen <mclasen@redhat.com>
4607 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
4609 * gdk/gdkdisplay.c (singlehead_...):
4610 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
4611 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
4612 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
4614 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
4615 note about COLUMN_FIXED restriction.
4617 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
4618 Set the entry in the default handler of the ::match-selected signal.
4621 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
4622 do the move-selected-item below pointer thingie, do the
4623 place-below-or-above one.
4625 * tests/testentrycompletion.c: Make the second example use the
4626 ::match-selected signal to make it actually work.
4628 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
4629 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
4630 mode. (#127648, Dave Bordoley)
4632 * gtk/gtktreeview.h:
4633 * gtk/gtktreeview.c: Add a new property "hover_selection", which
4634 when TRUE makes the selection follow the mouse. Also add setter
4635 and getter for the fixed_height property.
4637 2004-05-10 Matthias Clasen <mclasen@redhat.com>
4639 * gtk/gtkcombobox.c (gtk_combo_box_popup)
4640 (gtk_combo_box_menu_button_press): Make sure the menu pops up
4641 as wide as the combobox. (#59660, Havoc Pennington)
4643 2004-05-10 Matthias Clasen <mclasen@redhat.com>
4645 * gtk/gtkcombobox.h:
4646 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
4647 mode). Add a new property, add-tearoffs, for this. (#135956)
4649 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
4650 default button. (#118921)
4652 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4654 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
4655 that emits the grab notify signal.
4657 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
4659 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
4661 * gtk/gtkmenu.c: Make destruction of a torn off menu work
4662 like un-tearing off.
4664 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
4668 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
4669 Allow to suppress the stock accelerator by using "". (#142196,
4672 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
4676 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
4677 In list mode, accept the same mouse/wheel bindings on
4678 the cellview as on the button. (#136967)
4680 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
4682 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
4683 cached icons. (#135888, Crispin Flowerday)
4685 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
4687 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
4688 that we actually return menus for nodes of type menu, not the
4689 menuitems they're attached to.
4691 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
4693 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
4694 Add a note regarding UTF-8 requirements, proposed by
4695 Mariano SuĂ¡rez-Alvarez.
4697 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
4699 * gtk/gtktearoffmenuitem.h:
4700 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
4701 into the GtkTearoffMenuItem struct, since it is used
4702 by the Gimp, and keep it synchronized with the
4703 tearoff_state property of the parent menu.
4705 2004-05-08 Hans Breuer <hans@breuer.org>
4707 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
4708 create the correct mask for 'pseudo mime' icons
4710 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
4711 take focus_on_map into account
4713 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
4715 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
4716 ... must return a value
4718 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
4720 2004-05-07 Matthias Clasen <mclasen@redhat.com>
4722 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
4723 draw over the focus rectangle.
4725 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
4726 standard focus style. (#63071, Bill Haneman, idea for new
4727 style by Owen Taylor)
4729 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
4730 focus on the colorwheel via details.
4732 2004-05-06 Matthias Clasen <mclasen@redhat.com>
4736 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
4737 this no longer needed signal handler. (#141817, Paul Pogonyshev)
4739 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
4741 * gtk/gtktearoffmenuitem.h:
4742 * gtk/gtktearoffmenuitem.c: Make the tearoff
4743 functionality model/view, the tearoffmenuitem being
4744 the view and the tearoff_state property of the menu
4745 being the model. (#101185, Owen Taylor)
4747 * gtk/gtkmenu.c: Add a tearoff_state property.
4749 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
4753 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
4754 popup the submenu for items in torn off menus. (#122051)
4756 2004-05-06 Sven Neumann <sven@gimp.org>
4758 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
4759 position the title lable next to the arrow just as we do for LTR
4760 rendering. Fixes bug #141825.
4762 2004-05-06 Matthias Clasen <mclasen@redhat.com>
4764 * docs/RELEASE-HOWTO: Document the new policy of
4765 bumping version numbers after release.
4767 * configure.in: Bump version number to 2.5.0.
4769 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
4772 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
4775 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
4777 * gtk/gtkactiongroup.h:
4778 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
4779 New function to translate a string with translate_func.
4782 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
4784 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
4785 (gtk_combo_box_get_row_span_column):
4786 (gtk_combo_box_get_column_span_column): Add missing getters
4787 for readwrite properies. (#135649)
4789 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
4791 * gtk/gtkcombobox.h:
4792 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
4793 Add gtk_combo_box_get_active_text() convenience
4794 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
4796 2004-05-05 Elijah Newren <newren@math.utah.edu>
4798 Changes to support do-not-focus-on-map hint in conjunction with
4799 _NET_WM_USER_TIME (#115650):
4801 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
4804 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
4807 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
4808 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
4810 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
4811 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
4812 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
4813 Initialize the focus_on_map field to TRUE.
4815 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
4816 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
4817 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
4818 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
4819 Implementations for the various backends. The Win32 and linux-fb
4820 implementations set the focus_on_map field, but don't use it yet
4821 to actually implement noinput windows. The X implementation sets
4822 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
4824 * gdk/x11/gdkwindow-x11.h:
4825 * gdk/x11/gdkevents-x11.c (set_user_time):
4826 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
4827 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
4828 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
4829 since we want that function to be part of the public API.
4831 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
4835 * gtk/gtkiconfactory.c (icon_source_clear): Don't
4836 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
4838 2004-05-05 Matthias Clasen <mclasen@redhat.com>
4842 * gtk/gtkuimanager.c (print_node): Make the output
4843 parseable. (#141929, Sven Neumann)
4845 2004-05-05 Tor Lillqvist <tml@iki.fi>
4847 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
4848 multi-monitor offset. (#141842, John Ehresman)
4850 2004-05-04 Federico Mena Quintero <federico@ximian.com>
4852 Fixes #139562, based on a patch by Christian Neumair.
4854 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
4855 a filter_combo_hbox field to contain the filter combo.
4856 (show_filters): Show/hide the filter_combo_hbox.
4857 (create_filename_entry_and_filter_combo): Removed.
4858 (file_pane_create): Create the filter_combo_hbox here.
4860 2004-05-04 Matthias Clasen <mclasen@redhat.com>
4862 * modules/input/gtkimcontextxim.c: Fix the recent
4863 string_conversion_callback change to work on
4864 Solaris. (#141190, Padraig O'Briain)
4866 * gtk/gtkselection.c: Disable debug logging again.
4868 2004-05-03 Matthias Clasen <mclasen@redhat.com>
4870 * gtk/gtkselection.c: Make the chunk size for
4871 incremental transfers depend on the maximal request
4872 size, capped at 256k. This should allow most selections
4873 to be transferred nonincrementally, avoiding many
4874 roundtrips and protocol overhead.
4876 2004-05-03 Federico Mena Quintero <federico@ximian.com>
4878 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
4879 g_signal_new() correctly and initialize the signal fields. Fixes
4880 #141749; patch based on Michael Natterer's.
4882 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
4884 * gtk/gtkselection.c (_gtk_selection_request): Fix
4885 a debug message to show correct information.
4886 (_gtk_selection_incr_event): Make INCRemental transfer
4887 of MULTIPLE targets work. This was broken since 1997!
4889 2004-05-02 Hans Breuer <hans@breuer.org>
4891 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
4892 modify the passed in GdkSegment(s) in place, we may get
4893 them again to draw at the same place. Fixes bug #129095,
4895 (draw_segments) draw the end pixel again to get the
4896 pixmap mask right, fixes bug #126710, #130202
4898 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
4899 fixes bug #106013, John Ehresman
4901 * gtk/makefile.msc.in : don't try to link gtk.res but
4902 use gtk-win32.res (as supposed to be fixed below :)
4904 2004-05-01 Hans Breuer <hans@breuer.org>
4906 * tests/Makefile.am : tests/makefile.msc is in CVS for
4907 a long time, finally added to EXTRA_DIST : fixes bug
4908 #141334, John Ehresman
4910 2004-04-30 Matthias Clasen <mclasen@redhat.com>
4912 * === Released 2.4.1 ===
4914 * configure.in: Version 2.4.1, interface age 1.
4918 2004-04-29 Federico Mena Quintero <federico@ximian.com>
4922 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
4923 function; moved the code over from
4924 remove_bookmark_button_clicked_cb().
4925 (remove_selected_bookmarks): Now, getting a non-removable bookmark
4926 is not an error, as we may be called as a result of hitting the
4928 (shortcuts_key_press_event_cb): New handler; delete the bookmark
4929 if the user presses Backspace, Delete, or KP_Delete.
4931 2004-04-29 Matthias Clasen <mclasen@redhat.com>
4933 * gtk/gtkaction.c (closure_accel_activate): Use
4934 _gtk_action_emit_activate() instead of directly
4935 emitting the activate signal. (#141429, Jody Goldberg)
4937 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
4938 Warn people when the accelerator can not be
4939 parsed. (#141429, Jody Goldberg)
4941 2004-04-29 Matthias Clasen <mclasen@redhat.com>
4943 * tests/testentrycompletion.c (main): Add a missing
4944 cat. (#141070, Chris Sherlock)
4946 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
4947 variable. (#141022, Chris Sherlock)
4949 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
4950 cast. (#141013, Chris Sherlock)
4952 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
4953 unused variable. (#141011, Chris Sherlock)
4955 2004-04-29 Tor Lillqvist <tml@iki.fi>
4957 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
4958 leak. (#140775, John Ehresman)
4960 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
4962 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
4963 to index the cached gcs, not depth. (#139494)
4965 2004-04-28 Matthias Clasen <mclasen@redhat.com>
4967 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
4969 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4971 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
4972 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
4974 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
4976 Patch to add support for string conversion callbacks to
4977 GtkIMContextXIM (#101814)
4979 * modules/input/gtkimcontextxim.c: Set the string conversion callback
4980 if supported by the XIC.
4982 (struct _GtkIMContextXIM): Add string_conversion_callback member.
4984 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
4985 whether string conversion callback is supported.
4987 (gtk_im_context_get_ic, +set_string_conversion_callback,
4988 +string_conversion_callback): Also initialize string conversion
4989 callback, if supported, along with the IC initialization.
4991 * modules/input/imxim.c: Make "xim" module default for Thai as well.
4993 2004-04-23 Matthias Clasen <mclasen@redhat.com>
4995 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
4996 initialize targets. (#139883, John Finlay)
4998 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
5000 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
5001 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
5002 Tim-Philipp MĂ¼ller)
5004 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
5005 Remove an excessive g_return_if_fail().
5007 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
5009 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
5010 _-prefix calls of gdk_x11_window_set_user_time().
5012 2004-04-22 Matthias Clasen <mclasen@redhat.com>
5014 * gtk/gtkuimanager.c (update_node): Make sure the separators
5015 used to demarkate placeholder ends don't show up on
5016 show_all(). (#140496, Murray Cumming)
5018 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
5019 work with negative increments. (#137975, Tim Gerla)
5021 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
5023 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
5024 gtk_tool_button_set_icon_widget): Remove the old widget from the
5025 tool button before overwriting it with the new widget.
5027 (#140508, Todd Goyen)
5029 2004-04-22 Tor Lillqvist <tml@iki.fi>
5031 Fix the file chooser on Windows. I can't make it misbehave or
5032 crash any more now. But presumably there are still corner cases
5033 not handled. I haven't really checked behaviour of UNC paths, for
5036 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
5037 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
5040 (gtk_file_system_win32_get_parent): Like the Unix version, assert
5041 filename is absolute, and avoid one unnecessary string allocation
5044 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
5045 letters more correctly.
5047 (gtk_file_system_win32_render_icon): Assure correct syntax is used
5048 for root folder of a drive. (#137962, Morten Welinder)
5050 (filename_is_some_root): New function that accepts also root
5051 without any drive specified.
5053 (filename_is_drive_root): Rename from filename_is_root.
5055 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
5058 2004-04-21 Matthias Clasen <mclasen@redhat.com>
5060 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
5061 completion window if there are no completions anymore.
5063 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
5064 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
5065 It doesn't like that. (#140642, Christian Persch)
5067 * demos/gtk-demo/expander.c (do_expander): A new demo.
5069 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
5071 2004-04-20 Matthias Clasen <mclasen@redhat.com>
5073 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
5074 sure anchored children get size allocated, even if the layout
5075 is valid. (#122323, Andrew E. Makeev)
5076 (gtk_text_view_scroll_pages):
5077 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
5078 if we already have pending scrolls. Bandaid fix for #78513.
5080 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
5082 * INSTALL.in: Update libpng and libjpeg URLs, remove
5083 note about building without since that's not the normal
5086 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
5088 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
5089 handling of SVG/non-SVG unthemed icons.
5091 2004-04-19 Morten Welinder <terra@gnome.org>
5093 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
5096 2004-04-19 Matthias Clasen <mclasen@redhat.com>
5098 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
5099 Don't stop the iteration up to the tag_root too
5100 early. (#109945, Dongho Shin)
5102 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
5104 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
5105 gdk_keymap_translate_keyboard_state() handle NULL
5106 keymaps. (#139715, Torsten Schoenfeld).
5108 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
5110 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
5111 reported by Pedro RODRIGUEZ, about compilation problems when
5112 Xcursor is installed in a non-standard location.
5114 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
5116 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
5119 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
5120 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
5122 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
5124 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
5127 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
5128 property on user interaction.
5130 2004-04-15 Federico Mena Quintero <federico@ximian.com>
5132 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
5133 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
5135 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
5136 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
5139 2004-04-15 Matthias Clasen <mclasen@redhat.com>
5141 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
5142 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
5144 2004-04-14 Matthias Clasen <mclasen@redhat.com>
5146 * gtk/gtkcombobox.c:
5148 Make all style properties readonly.
5150 2004-04-14 Matthias Clasen <mclasen@redhat.com>
5152 * gtk/gtkcolorsel.c: Add a11y relations between the color
5153 wheel and the spin buttons. (#132745, Padraig O'Briain)
5155 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
5156 the meaning of size == -1.
5158 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
5159 a size of -1. (#137436, Brian Cameron)
5161 * gtk/gtkcombobox.c: Make the arrow and separator regular
5162 children of an hbox inside the button, and propagate state
5163 changes from the button to the cell view. (part of the fix
5164 for #138650, should also fix #137535)
5166 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
5167 state to gtk_cell_renderer_render() when prelighted. (part
5168 of the fix for #138650)
5170 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
5171 Use PRELIGHT state when appropriate. (part of the fix for
5174 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
5175 out warnings if called before the combo box is
5176 realized. (#139742, Philip Langdale)
5178 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
5180 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
5183 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
5185 * gtk/gtkpathbar.c (make_directory_button): remove spurious
5188 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
5190 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
5191 make the buttons sized by a bold label. This makes the text
5192 'swim' a little, but stops the buttons from resizing, #137210
5194 2004-04-13 Matthias Clasen <mclasen@redhat.com>
5196 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
5198 (start_element_handler): Accept separators without unique
5199 names. (#133302, Anders Carlsson)
5201 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
5202 possible accelerator gotcha when using this function. (#139641,
5205 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
5206 list nodes. (#138862, Morten Welinder)
5208 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
5210 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
5212 (gtk_tree_view_button_press): If we activated the row we don't
5213 want to grab focus back, as moving focus to another widget is
5214 pretty common, #138458
5216 2004-04-12 Federico Mena Quintero <federico@ximian.com>
5218 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
5219 documentation to all the signals.
5221 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
5223 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
5224 model if it is NULL. (#139770)
5226 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
5228 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
5229 a shadow inside the scrolled window, add it around the vbox.
5231 * gtk/gtkentryprivate.h:
5232 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
5233 Return a boolean indicating whether the popup is positioned above
5234 or below. Scroll the completions to the beginning or the end,
5235 depending on the positioning.
5237 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
5238 wrap around in the entry completion popup, and allow GDK_UP to
5239 enter the popup. (#137440)
5241 2004-04-12 Matthias Clasen <mclasen@redhat.com>
5243 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
5244 there before using it.
5246 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
5248 * gtk/gtktreeprivate.h: Moved search entries into priv data.
5250 * gtk/gtktreeview.c: Prep for type-ahead support.
5252 (gtk_tree_view_destroy): Destroy the search window explicitly.
5253 (gtk_tree_view_key_press): Minor change; prep for type-ahead
5254 (gtk_tree_view_ensure_interactive_directory): New function
5255 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
5256 (gtk_tree_view_real_start_interactive_search): rework
5257 (gtk_tree_view_search_dialog_hide): ditto
5258 (gtk_tree_view_search_delete_event): ditto
5259 (gtk_tree_view_search_button_press_event): ditto
5260 (gtk_tree_view_search_key_press_event): ditto
5261 (gtk_tree_view_search_move): ditto
5262 (gtk_tree_view_search_init): ditto
5264 * gtk/gtktreeviewcolumn.c:
5265 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
5267 * tests/testfilechooser.c: (main): change
5269 2004-04-11 Hans Breuer <hans@breuer.org>
5271 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
5272 the real fix would involve just another small API breakage,
5273 i.e. gdk_spawn_* using GPid not just gint.
5275 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
5277 2004-04-10 Tor Lillqvist <tml@iki.fi>
5279 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
5280 If both Shift and CapsLock pressed, ignore the shift only for
5281 letters (that would have been affected by the CapsLock). (#139095)
5283 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
5284 seems to be even buggier now than it used to be. (#138341)
5285 Initialize _gdk_input_ignore_wintab to TRUE.
5287 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
5288 GDK_USE_WINTAB environment variable to turn on tablet support.
5290 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
5292 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
5293 (gtk_ui_manager_remove_action_group): Terminate
5294 g_object_[dis]connect() calls with NULL instead of 0.
5297 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
5299 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
5301 2004-04-07 Federico Mena Quintero <federico@ximian.com>
5305 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
5306 passed-in 'str' is not NULL.
5308 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
5309 expands "~/" or "~foo/" at the beginning of a filename.
5310 (gtk_file_system_unix_parse): Use expand_tilde() before doing
5313 * gtk/gtkfilechooserentry.c
5314 (gtk_file_chooser_entry_maybe_update_directory): Take in a
5315 force_reload argument.
5316 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
5317 returns an error, set the file_part_pos to -1.
5318 (load_directory_callback): Only populate the model if the
5319 file_part_pos is not -1.
5321 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
5323 * configure.in: Added Icelandic (is) to ALL_LINGUAS
5325 2004-04-05 Federico Mena Quintero <federico@ximian.com>
5327 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
5328 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
5330 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
5331 for G_DIR_SEPARATOR in the display_name, and err out if it is
5332 present; use the same error message as Nautilus. Fixes #136467.
5334 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
5335 new-folder button say "Create Fo_lder" rather than "Create
5336 _Folder", so that the mnemonic doesn't conflict with the "Save in
5337 _folder" label. Fixes #136975.
5339 2004-04-05 Federico Mena Quintero <federico@ximian.com>
5341 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
5342 buttons. Also, free them correctly upon failure. Based on a
5343 patch by Morten Welinder, fixes #137956.
5345 2004-04-05 Anders Carlsson <andersca@gnome.org>
5347 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
5349 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
5351 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
5352 correctly for fixed height when inserting a node, #138082
5354 2004-04-01 Federico Mena Quintero <federico@ximian.com>
5358 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
5359 "child_is_hidden" boolean argument to the "path-clicked" signal.
5361 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
5363 (make_directory_button): Take a file_is_hidden argument; put it in
5365 (_gtk_path_bar_set_path): See whether each path component path is
5367 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
5368 "path-clicked" signal.
5369 (button_clicked_cb): See if the downwards button represents a
5370 hidden file for the file_is_hidden argument in the signal
5373 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
5375 * gtk/gtkfilechooserdefault.c
5376 (gtk_file_chooser_default_select_path): If we fail to switch
5377 folders, don't try to select the path in the file system model.
5378 Also, return the result from _gtk_file_system_model_path_do().
5379 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
5380 file system model if we are asked to select a hidden file.
5381 (path_bar_clicked): Show hidden files based on whether the
5382 immediate downwards folder in the path bar is a hidden file
5384 (struct _GtkFileChooserDefault): Added fields
5385 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
5386 (create_file_list): Set an object data key of
5387 "GtkFileChooserDefault" on the tree view so that we can find the
5388 impl from the popup menu callbacks. Also, hook up to the
5389 "button-press-event" and "popup-menu" signals in the file list to
5390 bring up a popup menu.
5391 (list_popup_menu_cb): New callback.
5392 (list_button_press_event_cb): New callback.
5396 * gtk/gtkfilesystemmodel.c
5397 (_gtk_file_system_model_new): Oops, connect_object to
5400 2004-03-31 Tor Lillqvist <tml@iki.fi>
5402 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
5403 for native Win32. (#136559, J. Ali Harlow)
5405 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
5406 angles. Thanks to Tim Newsham.
5408 2004-03-29 Federico Mena Quintero <federico@ximian.com>
5412 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
5413 for an ::is_finished_loading() method and a ::finished_loading()
5414 signal at the end of the struct.
5416 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
5417 "finished-loading" signal.
5418 (gtk_file_folder_is_finished_loading): New function.
5420 * gtk/gtkfilesystemunix.c
5421 (gtk_file_folder_unix_is_finished_loading): Implement.
5423 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
5424 slot for a "finished-loading" signal.
5425 (gtk_file_system_model_class_init): Create the "finished-loading"
5427 (struct _GtkFileSystemModel): New field
5428 idle_finished_loading_source. We emit the "finished-loading"
5429 signal in an idle if the root folder was done loading right in
5430 _gtk_file_system_model_new(), so that the caller has a chance to
5431 connect to the signal.
5432 (_gtk_file_system_model_new): Connect to the normal signals of the
5433 folder even if the initial _list_children() fails. Also, see if
5434 the folder is finished loading; connect to the "finished-loading"
5436 (gtk_file_system_model_finalize): Remove the idle handler.
5438 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
5439 and connect to the model's "finished-loading" signal.
5440 (get_toplevel): New helper function.
5441 (error_message): Use get_toplevel().
5442 (trap_activate_cb): Likewise.
5443 (location_popup_handler): Likewise.
5444 (set_busy_cursor): New function.
5445 (browse_files_model_finished_loading_cb): New callback.
5447 2004-03-25 Federico Mena Quintero <federico@ximian.com>
5449 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
5450 file under the cursor; we don't need the logic from
5451 GtkFileSelection after all. Fixes #132255.
5453 2004-03-25 Federico Mena Quintero <federico@ximian.com>
5455 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
5456 location entry with the display name of the file under the cursor
5457 for Open mode, or the typed filename in Save mode.
5459 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
5461 * gtk/gtkfilesystemwin32.c
5462 (filename_is_root): Bare drive designators (eg., "c:") are
5463 no longer considered as root filenames. Fixed #137942
5465 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
5467 * gtk/gtkfilesystemwin32.c
5468 (gtk_file_system_win32_create_folder): Invert test for error in
5469 mkdir. Fixes #137945
5471 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
5473 Fixed #138004 using Federico's code from #132327.
5475 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
5476 folder_hash field to keep a list of live folder objects.
5477 (gtk_file_system_win32_init): Create the folder_hash.
5478 (gtk_file_system_win32_finalize): Destroy the folder_hash.
5479 (gtk_file_system_win32_get_folder): Ref and return an existing
5480 folder if we have it around, otherwise return a new folder object.
5481 (struct _GtkFileFolderWin32): Add a field for the parent file system.
5482 (gtk_file_folder_win32_finalize): Remove the folder from the file
5483 system's hash table.
5484 (gtk_file_system_win32_create_folder): Emit "files-added" on the
5485 newly-created folder's parent. Fixes #138004.
5487 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
5489 * gtk/gtkfilesystemwin32.c
5490 (gtk_file_system_win32_get_folder): Test that path is actually
5491 a directory and throw error if not. Fixed bug #137950
5493 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
5495 * gtk/gtkfilesystemwin32.c
5496 (gtk_file_system_win32_volume_get_display_name): Ignore empty
5497 volume labels; assume that GetVolumeInformation would fail if
5498 GetVolumeInformationW does; catches a small memory leak;
5499 pass the buffer size to GetVolumeInformationW in wide
5500 characters instead of bytes. Fixes bug #137543
5501 (list_volumes): Cope with the theoretical possibility of
5502 more than 26 logical drives. Fixes bug #137940
5503 (bookmarks_serialize): Now actually removes bookmarks.
5506 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
5508 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
5510 2004-03-21 Tor Lillqvist <tml@iki.fi>
5512 * gtk/gtkfilesystemwin32.c
5513 (gtk_file_system_win32_volume_get_base_path): Include the
5514 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
5515 NULL for a volume base path, as g_filename_to_uri() requires an
5516 absolute path, and just a drive letter and colon isn't. (#137543)
5518 2004-03-20 Hans Breuer <hans@breuer.org>
5520 * gtk/gtkfilesystemwin32.c : applied the undisputable and
5521 required [due to recent gtkfilesystem internal api semantic
5522 changes] part of patches to fix bug #137543 (Tor Lillqvist,
5525 * gdk/gdkevents-win32.c (handle_configure_event) :
5526 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
5527 GdkWindowObject::x, y with screen coords to make
5528 gdk_window_get_position () return the right thing and thus fix
5529 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
5531 2004-03-19 Federico Mena Quintero <federico@ximian.com>
5533 * Revert the patch to #137520, as 2.4.1 is for conservative bug
5534 fixes only. The patch is attached to the bug report, for
5537 2004-03-19 Morten Welinder <terra@gnome.org>
5539 * gtk/gtkfilechooserdefault.c
5540 (gtk_file_chooser_default_set_current_folder): Test existance of
5541 the path after checking for locality, if needed.
5543 2004-03-19 Federico Mena Quintero <federico@ximian.com>
5547 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
5548 for an ::is_finished_loading() method and a ::finished_loading()
5549 signal at the end of the struct.
5551 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
5552 "finished-loading" signal.
5553 (gtk_file_folder_is_finished_loading): New function.
5555 * gtk/gtkfilesystemunix.c
5556 (gtk_file_folder_unix_is_finished_loading): Implement.
5558 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
5559 slot for a "finished-loading" signal.
5560 (gtk_file_system_model_class_init): Create the "finished-loading"
5562 (struct _GtkFileSystemModel): New field
5563 idle_finished_loading_source. We emit the "finished-loading"
5564 signal in an idle if the root folder was done loading right in
5565 _gtk_file_system_model_new(), so that the caller has a chance to
5566 connect to the signal.
5567 (_gtk_file_system_model_new): Connect to the normal signals of the
5568 folder even if the initial _list_children() fails. Also, see if
5569 the folder is finished loading; connect to the "finished-loading"
5571 (gtk_file_system_model_finalize): Remove the idle handler.
5573 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
5574 and connect to the model's "finished-loading" signal.
5575 (get_toplevel): New helper function.
5576 (error_message): Use get_toplevel().
5577 (trap_activate_cb): Likewise.
5578 (location_popup_handler): Likewise.
5579 (set_busy_cursor): New function.
5580 (browse_files_model_finished_loading_cb): New callback.
5582 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
5584 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
5585 eventbox for expander. (#137564, reported by
5588 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
5590 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
5592 2004-03-17 Morten Welinder <terra@gnome.org>
5594 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
5595 volumes not actually put into the shortcut list.
5597 * tests/prop-editor.c (object_changed): Plug leak.
5599 * tests/testfilechooser.c (main): Plug some leaks and expose
5602 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
5603 object. Fixed #136652.
5605 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
5606 have no screen. Fixes #137260.
5607 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
5608 thereby fixing leak. Fixes #137259.
5610 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
5611 slider buttons have been destroyed.
5612 (gtk_path_bar_remove): Make this work for slider buttons too.
5615 2004-03-15 Morten Welinder <terra@gnome.org>
5617 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
5618 Sanitize and plug leak.
5619 (check_icon_theme): Only do something if the widget has a screen.
5621 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
5623 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
5624 Move the repositioning logic from _gtk_entry_completion() popup
5625 over here. Fixes #137355, reported by Niklas Knutsson.