1 2005-09-30 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
4 Prevent overflow when storing size hints in an unsigned
5 short variable. Tracked down by Ray Strode and Søren Sandmann.
7 2005-09-29 Matthias Clasen <mclasen@redhat.com>
9 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
12 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
13 grab shadowed. (#317332)
15 2005-09-29 Tor Lillqvist <tml@novell.com>
17 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
19 2005-09-28 Federico Mena Quintero <federico@ximian.com>
21 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
22 if the unmap test fails.
23 (test_reload_sequence): Use gtk_widget_show_now() instead of
24 gtk_widget_show() for the dialog.
25 Thanks to Tim Janik for noticing these.
27 2005-09-28 Federico Mena Quintero <federico@ximian.com>
29 * tests/testcellrenderertext.c: New file with a set of tests for
30 GtkCellRendererText. The idea is to run a text renderer through
31 most of its interesting property values to see that it works
34 * tests/Makefile.am: Added testcellrenderertext.
36 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
37 entry/exit of this function for profiling.
38 (gtk_file_chooser_default_style_set): Mark the start/end of the
39 calls to the parent class and the the signal emission for profiling.
41 2005-09-29 Tor Lillqvist <tml@novell.com>
43 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
44 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
45 system codepage using g_win32_locale_filename_from_utf8().
46 (#317457, Kazuki Iwamoto)
48 2005-09-28 Matthias Clasen <mclasen@redhat.com>
50 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
51 here. (#317039, Paolo Borelli)
54 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
55 to make this function work as boxed copy function. (#317455,
58 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
59 NULL. (#316828, Tor Lillqvist)
61 2005-09-28 Tor Lillqvist <tml@novell.com>
63 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
66 2005-09-27 Federico Mena Quintero <federico@ximian.com>
68 Don't reload the current folder unnecessarily on ::map().
70 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
72 (struct _GtkFileChooserDefault): Added a "reload_state" field.
74 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
75 Initialize impl->reload_state.
76 (gtk_file_chooser_default_map): Check the impl->reload_state; load
77 a default folder if no folder has been set, or reload the current
78 one only if we had been unmapped first.
79 (gtk_file_chooser_default_update_current_folder): Set the
80 reload_state to RELOAD_HAS_FOLDER.
81 (gtk_file_chooser_default_unmap): Implement, and set the
82 reload_state to RELOAD_WAS_UNMAPPED.
83 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
84 here; they'll get (re)loaded on ::map() anyway.
86 * gtk/gtkfilechooserwidget.c
87 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
89 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
90 a dialog; build it ourselves.
91 (test_reload): New test to ensure that we don't load the default
92 folder more than once, and that we reload it when
94 (get_impl_from_dialog): New utility function.
95 (test_widgets_for_current_action): Use get_impl_from_dialog().
97 2005-09-27 Federico Mena Quintero <federico@ximian.com>
99 * gtk/gtkfilechooserdefault.c
100 (gtk_file_chooser_default_constructor): Mark the entry/exit of
101 this function for profiling.
102 (check_icon_theme): Likewise.
103 (change_icon_theme): Likewise.
104 (settings_notify_cb): Likewise.
105 (gtk_file_chooser_default_screen_changed): Likewise.
106 (update_chooser_entry): If the selection is empty, clear the file
107 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
108 nothing will be selected when the user starts typeahead in the
109 treeview, and we don't want to clear the file name entry in that
110 case --- the user could be typing-ahead to look for a folder name.
111 Fixes bug #308332, patch by Jürg Billeter.
113 2005-09-27 Matthias Clasen <mclasen@redhat.com>
115 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
116 Pop below the entry if there's more free space below the entry
117 than above. (#316948, Tommi Komulainen)
119 2005-09-26 Federico Mena Quintero <federico@ximian.com>
121 Do not create the save mode-specific widgets in the open modes, so
122 that we don't carry their baggage around.
124 * gtk/gtkfilechooserdefault.c
125 (gtk_file_chooser_default_constructor): Don't create the
127 (save_widgets_create): Set the impl->save_widgets directly here,
128 instead of passing the widgets back to the caller. Also, pack
129 them into the impl's box.
130 (update_appearance): Create or destroy the save widgets as
131 appropriate. Set the action of the save_file_name_entry here.
132 (shortcuts_add_current_folder): Set the active item in the
133 save_folder_combo only if it exists.
134 (gtk_file_chooser_default_set_property): Don't set the action of
135 the save_file_name_entry here.
136 (gtk_file_chooser_default_update_current_folder): Set the base
137 folder of the save_file_name_entry only if the entry exists.
138 (shortcuts_drag_data_received_cb): Cast the selection_data->data
139 to (const char *) since that's what shortcuts_drop_uris() expects.
140 (file_list_drag_data_received_cb): Likewise, for
141 g_uri_list_extract_uris().
143 2005-09-26 Tor Lillqvist <tml@novell.com>
145 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
146 the shaped flag here, too. (#316871)
147 (gdk_window_shape_combine_region): Currently unimplemented, so
148 don't do anything to the shaped flag here.
150 2005-09-26 Matthias Clasen <mclasen@redhat.com>
152 Fix #316871, reported by Dan Winship:
154 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
156 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
157 (gdk_window_shape_combine_region): Set it here.
159 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
160 remove the child area for shaped windows.
162 2005-09-23 Matthias Clasen <mclasen@redhat.com>
164 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
165 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
167 2005-09-22 Michael Natterer <mitch@imendio.com>
169 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
170 consistent with GTK+ terminology:
172 * gtk/gtkcellrendererkeys.[ch]
173 * tests/testkeys.c: removed...
175 * gtk/gtkcellrendereraccel.[ch]
176 * tests/testaccel.c: ...and added.
181 * tests/Makefile.am: changed accordingly.
183 2005-09-22 Matthias Clasen <mclasen@redhat.com>
185 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
186 for the grab-broken-event signal, noticed by Damon Chaplin.
188 2005-09-21 Tor Lillqvist <tml@novell.com>
190 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
191 gdk_text_property_to_text_list_for_display,
192 gdk_text_property_to_utf8_list_for_display,
193 gdk_win32_selection_add_targets,
194 _gdk_win32_selection_convert_to_dib): Free return value from
196 (gdk_text_property_to_text_list_for_display): Drop GError variable
197 that isn't actually used after being set.
199 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
201 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
204 2005-09-20 Tor Lillqvist <tml@novell.com>
206 * gdk/win32/gdkselection-win32.c
207 (gdk_selection_owner_get_for_display): Do return the correct owner
208 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
209 a window GDK knows about). The reason to return NULL seems to have
210 gone when in the fix for bug #163702 the artificial
211 GDK_SELECTION_CLEAR event generation was removed from
212 gdk_selection_send_notify_for_display(). Fixes bug #316552.
214 2005-09-20 Matthias Clasen <mclasen@redhat.com>
216 Avoid unnecessary XkbGetState() calls and XkbStateNotify
217 events. (#151555, Søren Sandmann)
219 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
220 XkbSelectEventDetails() to select XkbStateNotify events
221 for only the state we care about.
223 * gdk/x11/gdkprivate-x11.h:
224 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
225 the event into the function and update the keymap state from
226 the state information contained in the event. Adjust all callers.
228 2005-09-19 Matthias Clasen <mclasen@redhat.com>
230 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
231 in multiple places to avoid segfaults if the index is out of range.
232 (#316422, Guillaume Cottenceau)
233 (gtk_icon_view_set_drag_dest_item):
234 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
235 #316424, Guillaume Cottenceau)
237 2005-09-18 Hans Breuer <hans@breuer.org>
239 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
240 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
242 2005-09-18 Hans Breuer <hans@breuer.org>
244 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
245 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
246 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
247 the icon and is blinking with teststatusicon. More to come ...
249 2005-09-18 Hans Breuer <hans@breuer.org>
251 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
252 cause gtkprogressbar.c has #include <config.h> conditionally; less
253 noise from generated gtk.def
254 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
256 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
257 For me it works as well as the *NIX implemenation, that is not at all.
259 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
261 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
262 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
263 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
264 again - if compiled properly.
266 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
267 already coming with Gtk+. Makes it compile on win32.
269 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
271 * README.cvs-commits: fixed some tiny typos
273 2005-09-16 Tor Lillqvist <tml@novell.com>
275 * modules/engines/ms-windows/msw_style.c (draw_extension,
276 draw_box_gap): Check whether the widget actually is a GtkNotebook
277 before treating it as such. Drop some unneeded local variables,
278 use parameter with same information instead. (#316412)
280 2005-09-15 Federico Mena Quintero <federico@ximian.com>
282 * tests/autotestfilechooser.c: Start a set of automated tests for
283 the file chooser. The only test in there right now doesn't pass
284 yet. It specifies the intended behavior of the first optimization
285 of a series which I'll do on the file chooser (see
286 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
287 details of this optimization).
289 * tests/Makefile.am: Added autotestfilechooser.c.
291 * gtk/gtkfilechooserprivate.h (struct
292 _GtkFileChooserDialogPrivate): Move all the file chooser's private
293 structures to here, so that they can be accessed by
294 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
295 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
297 * gtk/gtkfilechooserdialog.c: See above.
299 * gtk/gtkfilechooserwidget.c: See above.
301 * gtk/gtkfilechooserdefault.c: See above.
303 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
306 gtk_window_map_event(): new function to work around lost unmap requests.
309 2005-09-14 Federico Mena Quintero <federico@ximian.com>
311 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
312 an easy-to-find profiling marker when starting to create a file
314 (browse_files_model_finished_loading_cb): Likewise, for when the
315 chooser is finished loading.
317 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
319 * gtk/gtkcolorbutton.c: Check "color" argument in
320 gtk_color_button_set_color ()
322 2005-09-14 Matthias Clasen <mclasen@redhat.com>
324 * gtk/gtklabel.c (gtk_label_get_type):
325 * gtk/gtkbutton.c (gtk_button_get_type):
326 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
327 using a mem chunk for window groups, buttons, labels.
329 * gtk/updateiconcache.c (foreach_remove_func): Fix
330 a use-after-free bug. (#316256, Alexander Nedotsukov)
332 2005-09-13 Matthias Clasen <mclasen@redhat.com>
334 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
336 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
338 2005-09-13 Matthias Clasen <mclasen@redhat.com>
340 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
341 Let GDK_Return pass through in some more cases.
343 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
344 activating the entry.
346 * gtk/gtkiconview.c (gtk_icon_view_class_init):
347 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
348 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
350 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
351 (#316001, Guillaume Cottenceau)
353 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
354 mistake in the docs. (#315993, Guillaume Cottenceau)
356 * tests/testentrycompletion.c (create_simple_completion_model): Add
357 some strings containing multibyte characters.
359 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
360 Fix prefix insertion for multibyte characters. (#316095,
363 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
364 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
365 return NULL if the widget is not realized. (#316023,
366 Guillaume Cottenceau)
368 2005-09-11 Matthias Clasen <mclasen@redhat.com>
372 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
373 New function to avoid pointless strdups when creating atoms
377 * gtk/*.c: Use gdk_atom_intern_static_string() where
380 2005-09-09 Matthias Clasen <mclasen@redhat.com>
382 * gtk/gtkcellrendererkeys.h:
383 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
384 and editing accelerators, a port of EggCellRendererKeys .
388 * gtk/Makefile.am: Add the keys cell renderer.
391 * tests/testkeys.c: Test GtkCellRendererKeys
393 2005-09-09 Matthias Clasen <mclasen@redhat.com>
395 Make it possible to determine if a key event is for a
398 * gdk/x11/gdkprivate-x11.h:
399 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
400 New function to determine if a keycode is mapped to a modifier.
401 (get_xkb): Get the modmap.
403 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
404 is_modifier bit by calling _gdk_keymap_key_is_modifier().
406 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
409 2005-09-09 Matthias Clasen <mclasen@redhat.com>
411 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
412 unused variable, noticed by Kjartan Maraas.
414 2005-09-09 Matthias Clasen <mclasen@redhat.com>
416 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
417 Make drag reordering work properly for columns other than the
418 first. (#315054, Dan Winship)
420 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
421 invalid fontnames better. (#136926, Michael R. Walton)
423 Stop cursor blinking in non-editable regions of a text view.
424 (#311508, Torbjörn Andersson)
426 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
427 (cursor_blinks): Take editability into account when deciding
428 whether the cursor blinks.
429 (gtk_text_view_button_release_event):
430 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
432 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
433 Use connect_after to connect to the focus_out event. This
434 ensures that the entry has already stopped blinking by the time
435 we emit the edited signal. (#315229, Thomas Leonard)
437 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
439 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
440 unsigned ints to -1. (#315481, Kjartan Maraas)
442 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
443 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
444 (#314473, Stanislav Brabec)
446 2005-09-09 Matthias Clasen <mclasen@redhat.com>
448 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
449 memory handling. (#314975, Torsten Schoenfeld)
451 * gtk/gtkiconview.c (gtk_icon_view_class_init):
452 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
453 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
454 * gtk/gtklabel.c (gtk_label_class_init):
455 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
456 Stylistic improvements and clarifications for some blurbs.
457 (#315520, Clytie Siddall)
459 2005-09-09 Tor Lillqvist <tml@novell.com>
461 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
462 display name. There is only one GdkDisplay on Win32, and
463 constructing the display name isn't entirely trivial, so cacheing
464 is probably worth it. For instance GIMP calls this function a lot.
465 (gdk_display_open): Call gdk_display_get_name() to prime the
467 (gdk_display_get_n_screens, gdk_display_get_screen,
468 gdk_display_get_default_screen): Verify parameter correctness like
469 the X11 backend does.
471 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
472 Return a freshly allocated string, as the API specifies. Fixes a
473 heap corruption problem that caused random errors and crashes in
476 2005-09-07 Matthias Clasen <mclasen@redhat.com>
478 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
479 Make C-u commit and restart hex input if we are already in a
482 2005-09-06 Matthias Clasen <mclasen@redhat.com>
484 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
485 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
486 if they are mapped to the same modifier.
488 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
489 to gtkstatusicon.c and gtktrayicon-x11.c
491 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
492 default accel mod mask.
494 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
495 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
496 Don't use GDK_ALT_MASK.
498 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
500 2005-09-06 Matthias Clasen <mclasen@redhat.com>
502 Add support for extra virtual modifiers: (#85780, Owen Taylor)
504 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
507 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
508 Mod2 - Mod5 and against Super, Hyper, Meta.
510 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
511 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
512 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
514 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
515 modmap to maintain the information which X modifiers map to
517 (get_xkb): Set up the modmap from the XKB tables.
518 (update_keymaps): Set up the modmap from the information returned
519 by XGetModifierMapping in the non-XKB case.
521 * gdk/x11/gdkprivate-x11.h:
522 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
523 function to set the virtual modifiers in the state.
525 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
526 _gdk_keymap_add_virtual_modifiers here.
528 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
529 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
532 2005-09-05 Matthias Clasen <mclasen@redhat.com>
534 * gtk/gtkaction.c (connect_proxy): Set the label of a button
535 if it has no child. (#315253, John Finlay)
537 2005-09-02 Matthias Clasen <mclasen@redhat.com>
539 * gtkimcontextsimple.h: Add a modifiers_dropped bit
541 2005-09-02 Matthias Clasen <mclasen@redhat.com>
543 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
544 on destroy to avoid problems when they are called on a destroyed
545 widget. (#315135, John Cupitt)
547 * gtk/gtkentry.c (gtk_entry_class_init):
548 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
549 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
551 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
552 code. Now we only steal a single key combination, Ctrl-Shift-U,
554 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
555 by a sequence of hex digits entered with Ctrl-Shift still held.
556 Releasing one of the modifiers or pressing space while the modifiers
557 are still held commits the character. It is possible to erase
558 digits using backspace.
559 As an extension to the above, we also allow to start the sequence
560 with Ctrl-Shift-U, then release the modifiers before typing any
561 digits, and enter the digits without modifiers.
562 (#82011, Owen Taylor)
564 2005-09-02 Matthias Clasen <mclasen@redhat.com>
566 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
567 we still need to deliver the destroy event. (#314980, Chris Lahey)
569 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
570 im context before committing \n or \t.
572 2005-09-02 Alexander Larsson <alexl@redhat.com>
574 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
575 (shortcuts_activate_volume):
576 Handle base_path being null in the rest of the cases (#310270)
578 2005-09-02 Tor Lillqvist <tml@novell.com>
580 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
581 cursor position also in root window coordinates. Prune out
582 superfluous WM_MOUSEMOVE events even earlier, based on root window
583 coordinates. Windows sends WM_MOUSEMOVE messages after a new
584 window has ben mapped below the cursor even if the mouse doesn't
585 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
586 confused at least gtk_menu_motion_notify(). (#314995)
588 * gtk/gtkintl.h: No need to include config.h here. It caused
589 warnings about GTK_LOCALEDIR being redefined on Win32 when
590 compiling files where gtkintl.h is included after gtkprivate.h
591 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
593 * gtk/gtkplug.c: Include config.h.
595 2005-09-01 Matthias Clasen <mclasen@redhat.com>
597 * gtk/gtkfilesystemunix.c: Pass statbufs down to
598 xdg_mime_get_mime_type_for_file() where possible, to avoid
601 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
602 typo. (#314921, Guillaume Cottenceau)
604 * gdk/*.c: Intern some more strings.
606 * gtk/*.c: Define an I_() macro and use it instead of the
607 bulky g_intern_static_string().
609 2005-08-31 Matthias Clasen <mclasen@redhat.com>
611 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
612 instead of copying it.
614 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
616 * gtk/*.c: Also intern static strings passed to
620 * gtk/Makefile.am: Intern type names in code generated by
625 * gdk/*.c: Intern type names before registering the type to avoid
628 * configure.in: Require GLib 2.9.0
630 2005-08-31 Matthias Clasen <mclasen@redhat.com>
632 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
633 and add icon-size and icon-size-set properties. (#314172)
635 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
636 groups across transient parents. (#312918, Christian Persch)
638 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
639 Guillaume Cottenceau)
641 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
642 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
644 2005-08-30 Matthias Clasen <mclasen@redhat.com>
646 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
647 make C-/ select all and C-\ unselect all. (#309301,
650 * gtk/gtkimcontextsimple.c: Change the compose sequence for
651 soft hyphen to be multi_key-minus-minus-space, and add
652 compose sequences multi_key-minus-minus-period and
653 multi_key-minus-minus-minus for en dash and em dash.
654 (#172653, Christian Lohmaier)
656 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
657 code. (#313946, Christian Persch)
659 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
660 fix for the default value of the "ui" property.
662 2005-08-30 Matthias Clasen <mclasen@redhat.com>
665 * gtk/gtkselection.h:
666 * gtk/gtkselection.c: Add functions which look for text, image
667 or uri targets in an array of atoms. (#314089, Mark Wielaard)
670 * gtk/gtkselection.h:
671 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
672 Add a function to check wether targets include uri.
673 (#314092, Mark Wielaard)
677 * gtk/gtkwindow.c: Add a deletable property with getter
678 and setter, to control the close button in the window
679 frame. (#59718, Havoc Pennington)
681 2005-08-29 Matthias Clasen <mclasen@redhat.com>
683 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
684 to the arrow keys for menu navigation. (#162825, Carl Worth)
686 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
688 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
690 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
691 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
692 refer to nonexisting stock ids.
694 * gtk/gtktextview.c (popup_targets_received):
695 * gtk/gtkentry.c (popup_targets_received): Construct
696 the "Select All" menuitem from stock.
698 * gtk/stock-icons/stock_select_all_{16,24}.png:
699 * gtk/stock-icons/Makefile.am:
700 * gtk/gtkiconfactory.c:
702 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
705 * gtk/gtktrayicon.c: Add a pointer to the spec.
707 * gtk/gtkstatusicon-x11.c: Add docs.
709 * gtk/gtkstatusicon.h: Fix a typo.
711 Add a cross-platform "tray icon" API, by
712 porting EggStatusIcon/EggTrayIcon (#105101)
714 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
715 displays an icon in a notification area.
717 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
718 X11, using GtkTrayIcon.
721 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
722 system tray specification, not public API.
724 * gtk/gtk.symbols: Add new exported functions.
726 * gtk/gtk.h: Include gtkstatusicon.h.
728 * gtk/Makefile.am: Add new files.
731 * tests/teststatusicon.c: Test for GtkStatusIcon.
733 2005-08-29 Christopher Aillon <caillon@redhat.com>
735 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
736 and GTK_STOCK_DISCONNECT
738 2005-08-29 Matthias Clasen <mclasen@redhat.com>
740 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
741 Use XFixesChangeSaveSet if available. (#314682)
743 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
744 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
746 2005-08-29 Matthias Clasen <mclasen@redhat.com>
748 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
749 accidentally leftover duplicate pixbuf creation. (#314700,
752 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
753 leak the cursor theme name. (#314693, Kjartan Maraas)
755 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
756 state.children in all cases. (#313862, Kjartan Maraas)
758 2005-08-28 Matthias Clasen <mclasen@redhat.com>
760 * po/POTFILES.in, po-properties/POTFILES.in:
763 2005-08-27 Matthias Clasen <mclasen@redhat.com>
765 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
766 value of the ui property. (#314532, Yong Wang)
768 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
769 when G_MAXLONG is passed as length.
771 2005-08-26 Matthias Clasen <mclasen@redhat.com>
773 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
774 to avoid overloading --force. (JP Rosevaar)
776 2005-08-26 Matthias Clasen <mclasen@redhat.com>
778 * configure.in: Bump version to 2.9.0
782 * gdk/gdkscreen.c: Make the GdkScreen font options api
783 public, and add properties GdkScreen::font-options and
784 GdkScreen::resolution. (#314004)
788 * gtk/gtkwidget.c: Adjust all callers.
790 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
791 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
792 * gdk/gdkscreen.c: Include gdkintl.h.
794 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
795 variable warning, pointed out by Colin Walters. (#314585)
797 2005-08-26 Tor Lillqvist <tml@novell.com>
799 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
801 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
803 2005-08-26 Matthias Clasen <mclasen@redhat.com>
805 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
806 of week_start. (#314473, JP Rosevaar)
808 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
810 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
811 lock. (#314533, Thomas Fitzsimmons)
813 2005-08-25 Matthias Clasen <mclasen@redhat.com>
815 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
816 NULL gracefully. (#314523, Ed Catmur)
818 2005-08-25 Owen Taylor <otaylor@redhat.com>
820 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
821 Handle theme == NULL.
823 2005-08-25 Matthias Clasen <mclasen@redhat.com>
825 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
826 y offset into account when positioning the popup. (#314470,
829 2005-08-25 Owen Taylor <otaylor@redhat.com>
831 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
832 as instance_init, not base_init! (#314452, Fix from Frederic
833 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
834 rather than 1 for a negative flag value.
836 2005-08-24 Owen Taylor <otaylor@redhat.com>
838 * gdk/gdkpango.c (draw_error_underline): Add a note about
839 cut-and-paste between here and Pango.
841 2005-08-24 Matthias Clasen <mclasen@redhat.com>
843 * === Released 2.8.2 ===
845 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
846 callback for image/gif, and also try image/bmp. (#314086, Mark
849 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
850 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
855 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
856 and cursor settings get propagated down to the screen initially.
857 Pointed out by Frederic Crozat.
859 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
860 message if the screen is NULL. Noticed by Kjartan Maraas.
862 2005-08-24 Matthias Clasen <mclasen@redhat.com>
866 * === Released 2.8.1 ===
870 2005-08-24 Matthias Clasen <mclasen@redhat.com>
872 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
873 against lazy filterers which return values other than TRUE or
874 FALSE from their visible func. (#314335)
876 2005-08-23 Owen Taylor <otaylor@redhat.com>
878 Fix for #314004, reported by Michael Reinsch:
881 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
882 Add gdk_screen_get/set_resolution_libgtk_only()
884 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
885 the options for the screen on the newly created context.
887 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
888 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
889 the font options on the screen.
891 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
892 the font options from the screen and set them on the context.
894 2005-08-23 Kristian Rietveld <kris@gtk.org>
896 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
897 bother inserting new rows in a level with a zero refcount and
898 immediately free the level. (Fixes #312350, reported by Markku Vire).
900 2005-08-23 Matthias Clasen <mclasen@redhat.com>
902 * gtk/updateiconcache.c: Complain when there is no index.theme file
903 in the specified directory, unless --force is used. Also add an
904 --index-only option to create caches without image data.
906 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
907 C99ism. (#314262, Robert Jeff Mitchell)
909 2005-08-22 Manish Singh <yosh@gimp.org>
911 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
913 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
915 2005-08-22 Matthias Clasen <mclasen@redhat.com>
917 * gtk/gtkwindow.c (gtk_window_client_event):
918 * gtk/gtkicontheme.c (ensure_valid_themes)
919 (_gtk_icon_theme_check_reload): Implement a clientmessage based
920 scheme for makeing sure that all GTK+ applications notice if an
921 icon theme has been updated. This should prevent multiple versions
922 of an icon theme cache to be mapped in memory at the same time,
923 which can cause excessive memory consumption. (#313156, Chris
926 2005-08-22 Matthias Clasen <mclasen@redhat.com>
928 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
929 regarding icon theme changes.
931 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
932 pixbufs which are backed by the mmapped memory of an icon cache,
933 increase the refcount of the icon cache, so that the memory is not
934 munmapped away underneath the pixbuf upon icon theme changes.
935 (#314170, Kjartan Maraas)
937 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
938 to link against Xext. (#314062)
940 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
941 overruns. (#314081, Hans Breuer)
943 2005-08-20 Matthias Clasen <mclasen@redhat.com>
945 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
946 returned layout must not be modified.
948 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
950 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
951 scroll_to_path if the model changes.
953 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
954 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
955 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
956 we're realized, #312798
957 (gtk_icon_view_set_model): clear scroll_to_path if the model
960 2005-08-20 Matthias Clasen <mclasen@redhat.com>
962 * gtk/gtkrange.c (gtk_range_adjustment_changed)
963 (gtk_range_adjustment_value_changed): Don't queue a draw
964 if the layout has not changed. (#313991, Benjamin Berg)
966 2005-08-19 Matthias Clasen <mclasen@redhat.com>
968 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
971 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
974 * gtk/gtkfilechooserbutton.c (change_icon_theme)
975 (model_add_special, model_add_special, model_add_volumes):
976 Handle pixbuf being NULL without warnings. Also, don't
977 leak pixbuf references when the icon theme is changed.
979 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
980 the user data on destroyed windows, since at best
981 it can be a stale pointer. (#313953, Robin Green)
983 2005-08-19 Matthias Clasen <mclasen@redhat.com>
985 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
986 (#313900, Sebastien Bacher)
988 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
989 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
991 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
992 (xdnd_read_actions, get_client_window_at_coords_recurse):
993 Free data returned from XGetWindowProperty.
995 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
996 Free data returned from XGetWindowProperty. (313867, Kjartan
999 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1000 children in all cases. (#313862, Kjartan Maraas)
1002 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1003 in the per-directory hash, even if they come from the icon cache.
1004 We tried to avoid that before, but as a result leaked icon data
1005 structs. (#313852, Kjartan Maraas)
1007 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1009 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1010 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1012 2005-08-15 Owen Taylor <otaylor@redhat.com>
1014 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1015 files for x11/xext. (Jonas Bonn)
1017 2005-08-15 Tor Lillqvist <tml@novell.com>
1019 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1022 2005-08-15 Owen Taylor <otaylor@redhat.com>
1024 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1026 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1027 (#313417, James Andrewartha)
1029 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1030 FcNameConstant(). (More of #313417)
1032 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1034 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1035 modal dialogs, make sure to inherit the window group from
1036 the parent, since we don't inherit window groups across
1037 transient parents currently. (#312918, Christian Persch)
1039 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1040 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1042 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1043 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1044 gracefully. (#312796, Jonathan Blandford)
1046 * tests/testtoolbar.c: Add some more tests for menu placement.
1048 * gtk/gtkmenutoolbutton.c (menu_position_func):
1049 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1050 of toolbutton menus and of the overflow menu. (#312937,
1051 #153870, Christian Persch, Paolo Borelli)
1053 2005-08-15 Tor Lillqvist <tml@novell.com>
1055 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1056 the nonportable <libgen.h> and dirname().
1058 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1060 * gtk/gtksizegroup.c: Use object data to mark widgets and
1061 groups as visited, so that we avoid constant extra list
1062 traversals. Also allocate quarks in class_init. (#311618,
1065 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1066 download location for the hicolor icon theme. (#313475, Olexiy
1069 * gtk/gtkicontheme.c: Remove debug spew.
1071 2005-08-15 Owen Taylor <otaylor@redhat.com>
1073 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1074 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1075 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1076 Handle pixmap == NULL when checking for a colormap.
1079 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1081 * gtk/updateiconcache.c: Store only one copy of the pixel data
1082 for symlinked icons. To achieve this, maintain a hashtable
1083 mapping pathnames to pixel data, and share the pixel data for
1084 all symlinks resolving to the same pathname. When writing out
1085 the image data, write out the pixel data only the first time
1086 it is met, and store the offset pointing to the first copy
1087 for use in all later cases.
1088 This reduces the size of the Bluecurve icon cache from 40