1 2004-10-14 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtkfilechooserdefault.c (shortcuts_remove_rows): Don't
4 get text unnecessarily. (#155384, Morten Welinder)
5 (gtk_file_chooser_default_finalize): Don't forget to
6 unref the tooltips. (#155412, Morten Welinder)
8 2004-10-12 Matthias Clasen <mclasen@redhat.com>
10 * gtk/gtkcontainer.c (_gtk_container_queue_resize): Acknowledge
11 the fact that invariants are broken and loop all the way up to
14 Tue Oct 12 17:11:02 2004 <timj@birnet.org>
16 * gtk/gtkwidget.c (gtk_widget_set_usize_internal): don't queue the
17 widget for resize or emit change notification if the usize didn't
18 change. this works around a buggy signal connection in #155139.
20 2004-10-11 Matthias Clasen <matthias@localhost.localdomain>
22 * docs/tools/widgets.c: Create scrolledwindow, statusbar,
23 scale and image images.
25 2004-10-10 Matthias Clasen <matthias@localhost.localdomain>
27 * docs/tools/widgets.c: Create a toolbar, menubar, progressbar,
28 notebook and messagedialog images.
30 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_select_all):
33 Sun Oct 10 11:24:56 2004 Jonathan Blandford <jrb@redhat.com>
35 * gtk/gtkcontainer.h (struct _GtkContainer): add /*< private >*/
38 2004-10-09 Matthias Clasen <mclasen@redhat.com>
40 * docs/tools/widgets.c: Shrink panes and separators images to MEDIUM.
42 * gtk/gtkcellview.c: Add docs.
44 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_get_menu): Fix
47 * gtk/gtkactiongroup.h:
48 * gtk/gtkactiongroup.c: Reinstate the accidentally lost addition
49 of gtk_action_group_translate_string().
51 * gtk/gtkaccelgroup.h: Declare gtk_accelerator_get_label.
53 2004-10-08 Matthias Clasen <mclasen@redhat.com>
55 * gdk/x11/gdkx.h: Declare gdk_x11_window_set_user_time here.
57 * gtk/gtktreeview.c (gtk_tree_view_grab_notify): Don't start a
58 drag if we loose the grab.
60 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Set the cell
61 renderer to inert mode to avoid bug #154921. This fixes a crash
62 which would otherwise occur if the editing is stopped for the second
63 time. (#154767, Manuel Baena GarcĂa)
66 * gtk/gtkwidget.c (gtk_widget_size_allocate): Add a new debug
67 flag, geometry, to debug size allocation.
69 * gtk/gtktreeview.c (gtk_tree_view_button_press): Set cell data
70 unconditionally. (#152562, Federico Mena Quintero)
72 2004-10-08 Matthias Clasen <mclasen@redhat.com>
74 * gtk/gtkuimanager.c (update_node): Also update smart separators
75 if the visibility of a menuitem with a submenu changes. (#153791,
78 2004-10-08 Matthias Clasen <mclasen@redhat.com>
82 * gtk/gtkentrycompletion.c:
83 * gtk/gtkspinbutton.c: Share the three copies of get_borders()
84 under the name _gtk_entry_get_borders(). (#116368, Owen Taylor)
86 2004-10-07 Matthias Clasen <mclasen@redhat.com>
88 * gtk/gtkfilechooserdefault.c (check_is_folder): Don't free
89 info too early. (#154703, Morten Welinder)
91 * gtk/gtkfilechooserdefault.c: Include gtkeventbox.h.
92 (#154798, Morten Welinder)
94 2004-10-06 Matthias Clasen <mclasen@redhat.com>
96 * gtk/gtkpaned.c (gtk_paned_compute_position): Reduce rounding
97 error. (#154658, John Cupitt)
99 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Clear
100 the iter instead of returning it unmodified. (#154186, Jonathan Blandford)
102 * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_focus): Pop up
103 the completions again after tab. (#147700, Jens Bech Madsen)
105 * gtk/gtktreeview.c (gtk_tree_view_search_iter): Set the cursor
106 before changing the selection to make the file chooser preview
107 update work better. (#143826, Tommi Komulainen)
109 2004-10-06 Matthias Clasen <mclasen@redhat.com>
111 * gtk/gtkrange.c (gtk_range_real_change_value): Replace a really
112 gross way of rounding to a specified number of digits. (#145232,
113 Peter Zelezny, patch by Soeren Sandmann)
115 Wed Oct 6 00:45:04 2004 <timj@birnet.org>
117 * gdk/gdkwindow.c (gdk_window_is_viewable): check the iteration window
118 variable, not just the window passed in. fixes #145270.
120 Tue Oct 5 21:00:54 2004 Tim Janik <timj@gtk.org>
122 * gtk/gtkwidget.c (gtk_widget_size_allocate): reverted my last change
123 and applied owen's leaner conditional flag update which should be good
124 enough to preserve resizing flag invariants.
126 2004-10-05 Matthias Clasen <mclasen@redhat.com>
130 Tue Oct 5 19:29:06 2004 Tim Janik <timj@gtk.org>
132 * gtk/gtkentry.h: removed redundant gtk_entry_get_layout() decl.
134 2004-10-05 Matthias Clasen <mclasen@redhat.com>
136 * gtk/gtkicontheme.c (icon_info_ensure_scale_and_pixbuf): Go back to
137 not scaling up at all. Less magic.
139 Tue Oct 5 17:06:26 2004 Tim Janik <timj@gtk.org>
141 * gtk/gtkwidget.c (gtk_widget_size_allocate): if REQUEST_NEEDED is still
142 set on ::size-allocate, another size-request has been queued since
143 ::size-request and needs to be requeued.
145 2004-10-05 Paolo Borelli <pborelli@katamail.com>
147 * gtk/gtkmenutoolbutton.c: rename the activate-menu signal to
148 show-menu as discussed in bug #153873.
150 2004-10-05 Matthias Clasen <mclasen@redhat.com>
152 * gtk/gtkuimanager.c (gtk_ui_manager_add_ui): Set
153 action_name. (#154526, John Finlay)
155 * gdk/x11/gdkwindow-x11.c (gdk_window_foreign_new_for_display):
156 Return a new reference to an existing GdkWindow if one already
157 exists. (#151378, Gustavo Carneiro)
159 2004-10-05 Matthias Clasen <mclasen@redhat.com>
161 Provide access to the string representation of accelerators used
162 in GtkAccelLabel. (#154068, John Spray)
164 * gtk/gtkaccelgroup.h:
165 * gtk/gtkaccelgroup.c (gtk_accelerator_get_label): New function
166 to return the accelerator label used in GtkAccelLabel.
167 (gtk_accelerator_name): Update docs to point to
168 gtk_accelerator_get_label().
169 * gtk/gtkaccellabel.h:
170 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
171 New auxiliary function which creates the string representing the
174 2004-10-05 Matthias Clasen <mclasen@redhat.com>
176 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Resize the
177 popup if a new model is set. (#154129, Bernd Demian)
179 2004-10-04 Matthias Clasen <mclasen@redhat.com>
181 * gtk/gtkicontheme.c (icon_info_ensure_scale_and_pixbuf):
182 Make the code work as intended for unthemed icons; don't scale
183 them up too much. Allow to scale them down, and do so
184 exactly. (#154142, Ross Burton)
185 (gtk_icon_info_load_icon): Amend docs.
187 * gtk/gtkcelllayout.c (gtk_cell_layout_clear): Improve
188 docs. (#154504, Dave Cook)
190 * gtk/gtkwindow.c (gtk_window_set_icon_list):
191 (gtk_window_set_default_icon_list): Ref the new icons
192 before unreffing the old ones. (#154468, Morten Welinder)
193 (gtk_window_realize_icon): Only set using_themed_icon if
194 we actually got an icon list from the theme. (#154472, Morten
197 2004-10-03 Matthias Clasen <mclasen@redhat.com>
199 * gtk/gtkiconview.c (gtk_icon_view_set_model): Reset pointers
200 pointing to the old model. (#154350)
202 * gtk/gtkwindow.c (icon_list_from_theme): Don't leak the
203 sizes array. (#154310, Christian Persch)
205 * gtk/gtktreeviewcolumn.c
206 (gtk_tree_view_column_setup_sort_column_id_callback):
207 Set sort_indicator to FALSE when appropriate. (#153714,
208 Reinout van Schouwen)
210 * gtk/gtktreeview.c (gtk_tree_view_search_position_func):
211 Fix positioning near the monitor boundaries. (#154341,
214 2004-10-01 Paolo Borelli <pborelli@katamail.com>
216 * gtk/gtkmenutoolbutton.c: deactivate the menu before setting it
217 to something else. Bug #153887.
219 2004-10-01 Matthias Clasen <mclasen@redhat.com>
223 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size): Fix the
224 calculation of x_offset when ellipsized and in RTL mode.
225 (gtk_cell_renderer_text_render): Fix the calculation of the layout
226 width when ellipsized.
228 2004-10-01 Tor Lillqvist <tml@iki.fi>
230 * gdk/win32/gdkglobals-win32.c: Set _gdk_input_ignore_wintab to
231 FALSE, thus enabling tablet input by default.
233 * gdk/win32/gdkmain-win32.c (_gdk_windowing_args): Accept the
234 --use-wintab option again (but without effect, as this is now the
235 default, see above). (#153788)
237 * modules/input/gtkimcontextime.c: Numerous changes.
239 Remove the ifdef UNICODE conditionals. Always use the
240 wide-character Imm* API. It is present also in Windows 98 and
241 Me. (Not Windows 95, but I think we don't care about that.) Using
242 the multibyte API wouldn't work anyway on systems where the system
243 codepage doesn't support the language the user uses an IME for, so
244 for instance I wouldn't be able to test this module on my English
245 Windows 2000 although I do have C, J and K IMEs available.
247 Guard against IMM not being active, always check ImmGetContext()
248 returning NULL. Work to some extent even without any IME. Fixes
249 #153800 at least partially.
251 * modules/input/imime.c (ime_info): Rename to "ime" to match the
252 naming pattern of other input modules. Make it default for
255 2004-10-01 Matthias Clasen <mclasen@redhat.com>
257 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Add a comment regarding
258 cell renderers to the docs.
260 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear_attributes):
261 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_clear_attributes):
262 Silently ignore info being NULL. This is unavoidable with the
263 current design where we have every implementation of layout_clear
264 call layout_clear_attributes, and also delegate calls to dependent
265 cell layouts. (#154191, Martyn Russell)
267 2004-10-01 Matthias Clasen <mclasen@redhat.com>
269 * modules/input/iminuktitut.c: Fix the spelling of Inuktitut
270 in several places. (#154176, John Austin)
272 2004-09-30 Paolo Borelli <pborelli@katamail.com>
274 * tests/testellipsize.c: exit on close.
276 2004-09-29 Matthias Clasen <mclasen@redhat.com>
278 * gtk/gtkmain.c: Make --g-fatal-warnings a G_OPTION_ARG_NONE,
279 since it doesn't take an argument.
281 2004-09-29 Christopher Blizzard <blizzard@redhat.com>
283 * gtk/gtkmenutoolbutton.h: Remove trailing semicolon on
286 2004-09-29 Paolo Borelli <pborelli@katamail.com>
288 * tests/testtoolbar.c: add a GtkMenuToolButton.
290 2004-09-29 Matthias Clasen <mclasen@redhat.com>
292 * gtk/gtkiconview.c (gtk_icon_view_move_cursor_left_right)
293 (gtk_icon_view_move_cursor_start_end)
294 (gtk_icon_view_move_cursor_page_up_down)
295 (gtk_icon_view_move_cursor_up_down): Handle an empty icon
296 view gracefully. (#152486)
298 Allow keynav to selectable labels (#138085, David Hawthorne):
300 * gtk/gtkdialog.c (gtk_dialog_map): Skip selectable labels when
301 looking for the initial focus widget.
303 * gtk/gtklabel.c (gtk_label_focus): Remove to put selectable labels
304 in the regular focus chain again.
306 2004-09-28 Matthias Clasen <mclasen@redhat.com>
308 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render): Don't
309 reuse insensitive pixbufs across multiple rows. (#153984, Milosz
312 * gtk/gtkmain.c (gtk_parse_args): Use gtk_get_option_group()
313 to obtain an option group with correctly set pre- and post-
314 parse hooks, instead of manually calling the hooks. This fixes
315 a problem with setting the program class in the gdk preparse
316 hook. (#153788, Robert Ă–gren)
318 2004-09-27 Matthias Clasen <mclasen@redhat.com>
322 * gtk/gtkmain.c (do_pre_parse_initialization): Don't call gdk_parse_args()
323 here, we don't want to parse args twice.
324 (gtk_init_with_args): Add the ugid check here as well.
325 (gtk_parse_args): Add the gdk options to the main option group as well.
327 2004-09-27 Paolo Borelli <pborelli@katamail.com>
331 * gtk/gtkmenutoolbutton.[ch]: add the GtkMenuToolButton widget
332 discussed in bug #151441.
334 * docs/reference/gtk/gtk-docs.sgml:
335 * docs/reference/gtk/gtk-sections.txt:
336 * docs/reference/gtk/gtk.types:
337 * docs/reference/gtk/tmpl/gtkmenutoolbutton.sgml: docs for the
340 2004-09-27 Matthias Clasen <mclasen@redhat.com>
342 * gtk/gtkfilesystemunix.c (gtk_file_folder_unix_list_children):
343 Emit ::finished-loading.
345 2004-09-27 Roozbeh Pournader <roozbeh@farsiweb.info>
347 * configure.in: Added Iranian Azerbaijani (az_IR) to ALL_LINUGAS.
349 2004-09-27 Matthias Clasen <mclasen@redhat.com>
351 * gtk/gtktreeview.c (gtk_tree_view_append_column): Fix typo in
352 docs. (#153811, Billy Biggs)
354 * gtk/gtkpathbar.h (struct _GtkPathBar): Only need a bit for
357 2004-09-26 Matthias Clasen <mclasen@redhat.com>
359 * gtk/gtknotebook.c (gtk_notebook_class_init): Add a missing _
360 to the name of the has_secondary_backward_stepper property.
361 Noticed by Michèle Garoche.
363 Sun Sep 26 02:06:43 2004 Jonathan Blandford <jrb@gnome.org>
365 * gtk/gtkpathbar.h (struct _GtkPathBar): add missing structures.
367 2004-09-26 Matthias Clasen <mclasen@redhat.com>
369 * gtk/gtkpathbar.c (gtk_path_bar_check_parent_path): Scroll
370 to make the current folder visible. (#152921)
372 * gtk/gtkbutton.c: Revert the button state to !button_down,
373 if we're missing the release event due to grab shadowing
376 * gtk/gtkpathbar.c: Make the slider buttons scroll.
378 * gtk/gtkfilechooserdefault.c (shortcuts_remove_rows): Remove
380 (bookmarks_check_remove_sensitivity): Don't free an uninitialized
383 * gtk/gtkimcontext.c (gtk_im_context_get_preedit_string):
384 cursor_pos is in characters, not bytes. (#153332, Owen Taylor)
386 2004-09-25 Robert Ă–gren <gtk@roboros.com>
388 * gdk/win32/gdkinput-win32.c (gdk_input_wintab_init): Set
389 lcSysOrgX and lcSysOrgY from device instead of hardcoding to 0,
390 a further fix for bug #145467.
392 2004-09-25 Matthias Clasen <mclasen@redhat.com>
394 * gtk/gtktextiter.c (inside_word_func): Don't access
395 attr[-1]. (#153628, Padraig O'Briain)
397 2004-09-23 Matthias Clasen <mclasen@redhat.com>
399 * gtk/gtkfilechooserdefault.c: Add some tooltips.
401 2004-09-22 Matthias Clasen <mclasen@redhat.com>
403 * gtk/gtkrange.c (gtk_range_map, gtk_range_unmap):
404 * gtk/gtkbutton.c (gtk_button_map, gtk_button_unmap): Remove
405 unnecessary g_return_if_fail()s from virtual functions. (#153469,
408 * gtk/gtkaboutdialog.c (gtk_about_dialog_finalize): Don't leak
409 cursors. (#153468, Christian Persch)
411 * gtk/gtktreeview.c (gtk_tree_view_key_press): Don't leak old_text.
412 (#153467, Christian Persch)
414 * gtk/gtkfilechooserdefault.c (selection_check_foreach_cb): Don't use
416 (gtk_file_chooser_default_should_respond): Make it easier to
417 select folders in SELECT_FOLDER mode.
419 Wed Sep 22 00:54:34 2004 Matthias Clasen <mclasen@redhat.com>
421 * demos/gtk-demo/pixbufs.c (do_pixbufs): Don't leak the frame
424 Tue Sep 21 16:55:38 2004 Manish Singh <yosh@gimp.org>
426 * tests/testtreemodel.c: #include <config.h> for HAVE_MALLINFO define,
427 other minor cleanups.
429 Tue Sep 21 16:27:19 2004 Manish Singh <yosh@gimp.org>
431 * gdk/gdk.c: remove now unused arg variables.
433 * gdk/gdkinternals.h: declare _gdk_windowing_init ().
435 * gtk/gtkmain.c (do_pre_parse_initialization): call gdk_parse_args ()
436 here instead of gdk_pre_parse_libgtk_only (). Should fix #153082.
438 2004-09-21 Matthias Clasen <mclasen@redhat.com>
440 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_should_respond):
441 Don't assert that current_focus != NULL, just return FALSE.
443 * gtk/gtkpathbar.c (gtk_path_bar_size_request): Give the path
444 bar arrows some more space.
446 * configure.in: Check for mallinfo.
448 * tests/testtreemodel.c: Only include malloc.h if HAVE_MALLINFO
449 is defined. (#153168, Darren Creutz)
451 * gtk/gtkactiongroup.c: Fix typos in signal docs. (#153224,
454 Mon Sep 20 19:44:58 2004 Matthias Clasen <mclasen@redhat.com>
456 * gtk/gtkfilechooserdefault.c (shortcuts_activate_iter): Don't
457 return FALSE from a void function. (#153185, Joel Fredrikson)
459 2004-09-20 Matthias Clasen <mclasen@redhat.com>
461 * gtk/gtkbutton.c (gtk_button_class_init): Add a boolean ::displace-focus
462 style property and apply child displacement to the focus rectangle
463 if it is TRUE. (#141170, Soeren Sandmann)
465 Sun Sep 19 23:56:18 2004 Søren Sandmann <sandmann@redhat.com>
467 * gtk/gtkmenu.c (MENU_SCROLL_TIMEOUT2): Change from 50 to 20 to
468 make the menus scroll faster.
470 2004-09-19 Matthias Clasen <mclasen@redhat.com>
472 * configure.in: Bump version
474 * === Released 2.5.3 ===
476 2004-09-18 Matthias Clasen <mclasen@redhat.com>
478 Make GtkFileChooserButton activatable via mnemonics.
479 (#152925, Dennis Cranston, patch by James M. Cape)
481 * gtk/gtkfilechooserbutton.c: Add a ::mnemonic-activate signal
482 and a suitable default handler.
484 * tests/testfilechooserbutton.c: Add a mnemonic.
486 2004-09-18 Matthias Clasen <mclasen@redhat.com>
488 Fix win32 build errors. (#153032, #153028, Robert Ă–gren)
490 * gdk/win32/gdkmain-win32.c: Make it compile.
492 * gtk/gtkmain.c: Include glib.h.
494 2004-09-18 Federico Mena Quintero <federico@ximian.com>
498 * gtk/gtkfilesystem.h: Removed the GTK_FILE_PATH() and
499 GTK_IS_FILE_PATH() macros. They are not supposed to exist, as
500 GtkFilePath is not an object. And they never worked, anyway.
502 2004-09-18 Marco Pesenti Gritti <marco@gnome.org>
504 * gtk/gtkentry.c: (gtk_entry_completion_key_press):
506 Make numeric pad enter activate the selected completion
507 entry. Fix bug 143486 reported by Edd Dumbill.
509 2004-09-17 Matthias Clasen <mclasen@redhat.com>
513 * gtk/gtkfilechooserdefault.c (select_func): Scroll to the selected
514 row. (#143868, Christian Persch)
516 2004-09-17 Matthias Clasen <mclasen@redhat.com>
518 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render): Remove
521 Improve the behaviour of the file chooser in save mode. Fixes bugs
522 #151031, #151608, #151994 reported by Owen Taylor and Alexander
525 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_set_property):
526 (location_entry_create): Propagate the action to the file
528 (gtk_file_chooser_default_should_respond): Switch folders if
529 the user enters a directory name in the entry and clear the entry
530 after switching folders.
531 (gtk_file_chooser_default_should_respond, shortcuts_row_activated_cb):
532 Move focus to the file list when activating a shortcut.
533 (gtk_file_chooser_default_should_respond): Handle the case where the
534 user clicks on "Save" after selecting a folder in the file list.
536 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_set_property):
537 Propagate the action to the file chooser entries.
539 * gtk/gtkfilechooserentry.h:
540 * gtk/gtkfilechooserentry.c (_gtk_file_chooser_entry_set_action):
541 (_gtk_file_chooser_entry_get_action): New functions to propagate
542 the GtkFileChooserAction of the file chooser to the file chooser
544 (check_completion_callback): If we are in save mode, only do
545 inline completion for directories.
547 Fri Sep 17 11:20:03 2004 Jonathan Blandford <jrb@gnome.org>
549 * gtk/gtklabel.c (gtk_label_set_markup): Add an example to the
552 Thu Sep 16 23:20:05 2004 Matthias Clasen <maclas@gmx.de>
554 * gtk/gtkselection.c (selection_get_text_plain):
555 * gdk/x11/gdkselection-x11.c (make_list): Warn if a UTF8_STRING
556 or text/plain;charset=utf-8 roperty contains invalid
557 UTF-8. (#152845, Owen Taylor)
559 2004-09-16 Matthias Clasen <mclasen@redhat.com>
561 Fix #152760, Christian Persch:
563 * gtk/gtkaboutdialog.c (gtk_about_dialog_finalize): Don't free
565 (gtk_about_dialog_set_translator_credits): Recommend the msg
566 id translator-credits.
567 (display_credits_dialog): Show translator credits if they're
568 translated, not if they're untranslated.
570 Thu Sep 16 02:07:56 2004 Jonathan Blandford <jrb@gnome.org>
572 * docs/tools/widgets.c (create_icon_view): load images at normal
575 * docs/reference/gtk/images/*png: Update shots.
577 Thu Sep 16 00:33:11 2004 Jonathan Blandford <jrb@gnome.org>
579 * docs/tools/widgets.c (new_widget_info): Add constrained sizing
580 to the widgets. This gives us all images running the same size,
581 which will make the table layout look better.
583 2004-09-15 Tor Lillqvist <tml@iki.fi>
585 * gdk/win32/gdkwindow-win32.c (gdk_window_get_frame_extents):
586 Remove bogus code that tried to do what the X11 backend does in
587 its version of this function. There are no "frame windows" (for
588 toplevel window decoration) on Windows. The desktop ("root")
589 window is not the parent of a toplevel window. (#152481)
591 2004-09-15 Matthias Clasen <mclasen@redhat.com>
595 Wed Sep 15 00:57:37 2004 Matthias Clasen <maclas@gmx.de>
597 * docs/tools/widgets.c: Add accel label, file button
600 Tue Sep 14 22:01:49 2004 Matthias Clasen <maclas@gmx.de>
602 * configure.in: New option --disable-visibility to disable
603 the use of ELF visibility attributes for PLT reduction.
605 * gtk/makegtkalias.pl:
606 * gdk/makegdkalias.pl: Respect the DISABLE_VISIBILITY
609 Tue Sep 14 23:20:56 2004 Søren Sandmann <sandmann@redhat.com>
611 * gtk/gtkaction.c (connect_proxy): Call
612 gtk_tool_item_rebuild_menu().
614 * gtk/gtktoolitem.c (gtk_tool_item_class_init): Update
615 documentation for GtkToolItem::create_menu_proxy.
617 * gtk/gtktoolitem.c (gtk_tool_item_rebuild_menu): New
618 API to make the toolbar update itself when the proxy menu item
619 for a tool item changes.
621 * gtk/gtktoolbutton.c (gtk_tool_button_construct_contents): Call
622 gtk_tool_item_rebuild_menu here()
624 * gtk/gtktoolbutton.c (gtk_tool_button_construct_contents):
625 Remove redundant check for need_label.
627 2004-09-14 Matthias Clasen <mclasen@redhat.com>
629 * gtk/gtkmain.c (do_post_parse_initialization): Remove an unused
630 variable, spotted by Morten Welinder.
632 * gtk/queryimmodules.c (escape_string): Copy code from queryloaders.c
633 which turns backslashes in slashes on win32. (#152608, Kazuki IWAMOTO)
635 * gtk/gtktreeview.c (gtk_tree_view_focus_to_cursor): Set the cursor
636 to the first selected row instead of always to the first row if there
637 is no cursor. (#143270, Jean Bréfort)
639 * tests/testfilechooser.c (main): Fix a few typos.
641 2004-09-13 Matthias Clasen <mclasen@redhat.com>
644 * gtk/gtktreeview.c: Change the default expander size to 12 to compensate
645 for the recent change to gtk_default_draw_expander().
647 * gtk/gtkstyle.c (gtk_default_draw_expander): Use a linewidth of one
648 for expander sizes up to 16
650 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_model): Resize the
651 popup if the model is replaced. (#152333)
653 Mon Sep 13 09:11:53 2004 Manish Singh <yosh@gimp.org>
655 * gtk/gtkrange.c: fix gtk_range_real_change_value args. Addresses part
658 2004-09-13 Matthias Clasen <mclasen@redhat.com>
660 Fix some problems reported by Morten Welinder:
662 * gtk/gtkfilesystem.c: Include gtkmodules.h, not gtkmain.h, since
663 the modules stuff moved.
665 * gtk/gtkmain.c (gtk_arg_no_debug_cb): Add a missing return
667 * gtk/gtksettings.c: Add missing include.
668 (settings_update_modules): Remove an unused variable.
670 2004-09-13 Matthias Clasen <mclasen@redhat.com>
672 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
673 Improve positioning of entry completion popup.
675 2004-09-09 Matthias Clasen <mclasen@redhat.com>
677 * gtk/makegtkalias.pl:
678 * gdk/makegdkalias.pl: Use the short prefix "IA__" for
679 aliases instead of the long suffix "__internal_alias".
681 * tests/testfilechooser.c (main): Update sensitivity of the "Select all"
684 Wed Sep 8 18:38:08 2004 Soeren Sandmann <sandmann@redhat.com>
686 Make dropping of expandable items look nicer.
688 * gtk/gtktoolbar.c (gtk_toolbar_set_drop_highlight_item): Make
689 placeholder expand if highlight item is expanding.
691 * gtk/gtktoolbar.c (toolbar_content_set_expand): New function.
693 * gtk/gtktoolbar.c (toolbar_content_get_expand): Return TRUE only
694 if the item is not disappering.
696 2004-09-07 Matthias Clasen <mclasen@redhat.com>
698 * gtk/gtkuimanager.c (gtk_ui_manager_add_ui): Use the proper node type
699 for placeholders in toolbars. (#151963, Olivier Andrieu)
701 * gtk/gtkstyle.c (gtk_default_draw_expander): Draw expanders a bit
704 Sun Sep 5 17:14:16 2004 Matthias Clasen <maclas@gmx.de>
708 * gdk/x11/gdkmain-x11.c:
709 * gdk/win32/gdkmain-win32.c: Add descriptions for the
710 commandline arguments. The actual descriptions are mostly
711 taken from libbonoboui, so translators should be able to
712 copy existing translations from there.
714 2004-09-05 Anders Carlsson <andersca@gnome.org>
720 2004-09-05 Anders Carlsson <andersca@gnome.org>
722 * gdk/gdk.c: (gdk_arg_class_cb), (gdk_arg_name_cb),
723 (gdk_add_option_entries_libgtk_only), (gdk_pre_parse_libgtk_only),
726 * gdk/gdkinternals.h:
727 * gdk/linux-fb/gdkmain-fb.c: (_gdk_windowing_init):
728 * gdk/win32/gdkmain-win32.c: (_gdk_windowing_init):
729 * gdk/x11/gdkdisplay-x11.c: (gdk_display_open):
730 * gdk/x11/gdkmain-x11.c: (_gdk_windowing_init):
731 * gtk/gtkmain.c: (gtk_arg_debug_cb), (gtk_arg_no_debug_cb),
732 (gtk_arg_module_cb), (gtk_arg_warnings_cb),
733 (do_pre_parse_initialization), (do_post_parse_initialization),
734 (pre_parse_hook), (post_parse_hook), (gtk_get_option_group),
735 (gtk_init_with_args), (gtk_parse_args):
737 Make gtk argument parsing use goption. Add gtk_get_option_group and
740 * tests/testtreemodel.c: (main):
741 Use gtk_init_with_args.
743 Sun Sep 5 01:04:01 2004 Matthias Clasen <maclas@gmx.de>
745 Allow sorting of tree models to be turned off
746 again. (#151139, Torsten Schoenfeld)
748 * gtk/gtktreesortable.h:
749 Add GTK_TREE_SORTABLE_UNSORTED_SORT_COLUMN_ID.
751 * gtk/gtktreestore.c (gtk_tree_store_sort):
752 * gtk/gtkliststore.c (gtk_list_store_sort): Don't sort if
753 the list store is not sorted.
755 Sat Sep 4 23:37:56 2004 Matthias Clasen <maclas@gmx.de>
757 * configure.in: Fix the Solaris Xinerama checks. (#151754)
759 Sat Sep 4 22:45:49 2004 Matthias Clasen <maclas@gmx.de>
761 * gtk/gtkentry.c (gtk_entry_backspace): Don't refuse to delete
762 text in passwords. (#151723, Owen Taylor)
764 Sat Sep 4 16:51:00 2004 Søren Sandmann <sandmann@redhat.com>
766 * gdk/x11/gdkevents-x11.c (gdk_event_prepare): Revert accidental
767 change from Aug 02 that removed a flush of the X connection from
768 gdk_event_prepare() causing applications to get stuck. (#151732,
771 Fri Sep 3 22:45:03 2004 Matthias Clasen <maclas@gmx.de>
773 * gtk/gtkuimanager.c (print_node): Don't print out attributes
774 for the <ui> root node. (#151752, Lorenzo Gil Sánchez)
776 Sat Sep 4 02:38:57 2004 Søren Sandmann <sandmann@redhat.com>
778 * gtk/gtktoolbar.c (position): Accelerate the animation when it
779 has been running for a while. (#143647).
781 2004-09-03 Tor Lillqvist <tml@iki.fi>
783 * gtk-zip.sh.in: List the three theme gtkrc files separately, zip
784 doesn't do anything if one of the files on its command line
787 Handle changes of screen resolution on Win32. (#151581, reported by
790 * gdk/win32/gdkwindow-win32.c (_gdk_windowing_window_init,
791 _gdk_root_window_size_init): Factor out setting the root window's
792 size (as the size of the union of all monitors) to a new function.
794 * gdk/win32/gdkdisplay-win32.c (gdk_display_open,
795 _gdk_monitor_init): Factor out the monitor query to a new
798 * gdk/win32/gdkprivate-win32.h: Declare above new functions.
800 * gdk/win32/gdkevents-win32.c (gdk_event_translate,
801 handle_display_change): Handle WM_DISPLAYCHANGE by calling the
802 above two functions, and emitting the "size_changed" signal on our
805 2004-09-01 Matthias Clasen <mclasen@redhat.com>
807 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible):
808 Document the return value.
810 2004-09-01 Matthias Clasen <mclasen@redhat.com>
812 Make it possible to specify additional modules to load
813 via a setting. (#117236, Alex Graveley)
816 * gtk/gtkmodules.c: New files which contain the module
817 handling code which was previously in gtkmain.[hc].
818 Additionally, the code now looks for the gtk-modules
819 setting, which can specify additional modules to load.
822 * gtk/gtkmain.h: Remove all the module handling code.
824 * gtk/gtkdebug.h: Add a debug flag for modules.
826 * gtk/gtk.h: Include gtkmodules.h
828 * gtk/Makefile.am (gtk_public_h_sources): Add gtkmodules.h
829 (gtk_c_sources): Add gtkmodules.c
831 * gtk/gtksettings.c: Add the gtk-modules setting.
833 * gdk/x11/gdkevents-x11.c: Add the Gtk/Modules XSetting.
835 Wed Sep 1 19:11:44 2004 Søren Sandmann <sandmann@redhat.com>
837 * gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Make sure
838 children of the toolbar are given positive dimensions. (149540,
841 2004-09-01 Matthias Clasen <mclasen@redhat.com>
843 * gtk/gtkfilesystemunix.c:
844 * gtk/gtkfilechooserbutton.c: Protect the unistd.h include
847 Wed Sep 1 02:38:48 2004 Matthias Clasen <maclas@gmx.de>
849 * gtk/gtkaccellabel.c (gtk_accel_label_expose_event): Make
850 accel labels ellipsize correctly. (#151559, Christian Persch)
852 Wed Sep 1 00:55:56 2004 Matthias Clasen <maclas@gmx.de>
854 * gtk/gtkimage.c (gtk_image_clear): Don't leak the iter
855 of a running animation. (#151542)
857 Tue Aug 31 23:40:29 2004 Matthias Clasen <maclas@gmx.de>
859 * gdk/win32/gdkproperty-win32.c (gdk_screen_get_setting): Make
860 "ms-windows" the default theme on Win32.
862 Tue Aug 31 23:24:49 2004 Matthias Clasen <maclas@gmx.de>
864 * gtk/gtkcalendar.c (gtk_calendar_main_button): Only start
865 a drag if the left button is pressed. (#151490, Frederic Croszat)
867 Tue Aug 31 23:20:58 2004 Matthias Clasen <maclas@gmx.de>
869 * gdk/x11/gdkdnd-x11.c (gdk_drop_finish): Remove debug spew.
871 Tue Aug 31 17:07:41 2004 Jonathan Blandford <jrb@redhat.com>
873 * gtk/gtktreeviewcolumn.c
874 (gtk_tree_view_column_cell_process_action): constrain cell area to
875 passed in cell_area, #147867
877 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size): if
878 ellipsizing, get_size is only 3 chars wide.
880 * docs/tree-column-sizing.png: Add Matthias's excellent image.
882 2004-08-28 Robert Ă–gren <gtk@roboros.com>
884 On Win32, do not produce tablet motion or button events while a
885 window is being moved or resized. (#151090, reported by Shaneyfelt)
887 * gdk/win32/gdkprivate-win32.h
888 * gdk/win32/gdkglobals-win32.c
889 * gdk/win32/gdkevents-win32.c: Rename the variable resizing to
890 _sizemove_in_progress and make it extern.
892 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Ignore
893 motion and button events if _sizemove_in_progress is true.
895 2004-08-30 Tor Lillqvist <tml@iki.fi>
897 Make the ms-windows theme engine build with mingw.
899 * configure.in: Expand also modules/engines/ms-windows/Theme/
900 Makefile and .../Theme/gtk-2.0/Makefile.
902 * modules/engines/ms-windows/Makefile.am: Adapt for building
903 inside the GTK sources.
905 * modules/engines/ms-windows/*.c: Use "foo.h" style includes for
906 GTK and GDK headers. Use correct path for gdkwin32.h header.
908 * modules/engines/ms-windows/msw_style.c: Don't use deprecated GDK
911 * modules/engines/ms-windows/xp_theme_defs.h
912 * modules/engines/ms-windows/xp_theme.c: Move definitions of TMT_*
913 to xp_theme.c, as they are neither in mingw's nor Platform
916 * modules/engines/ms-windows/xp_theme.c: Define _WIN32_WINNT as
917 0x0501 to get the necesssary stuff from mingw's uxtheme.h.
919 2004-08-30 Matthias Clasen <mclasen@redhat.com>
921 Integrate the ms-windows theme engine (better known as Wimp)
922 into the autotools build. Wimp (http://gtk-wimp.sourceforge.net/)
923 was written by Raymond Penners and Dom Lachowicz. The Wimp 0.6.2
924 sources have been added to the GTK+ source tree in
925 modules/engines/ms-windows, and there is a ChangeLog detailing
926 the history of Wimp. (#109615, Havoc Pennington)
928 * configure.in: Generate modules/engines/Makefile and
929 modules/engines/ms-windows/Makefile.
931 * modules/Makefile.am (SUBDIRS): Add engines.
933 * modules/engines/Makefile.am: Compile ms-windows for win32.
935 2004-08-30 Matthias Clasen <mclasen@redhat.com>
937 * gtk/gtktextview.c (gtk_text_view_delete_surrounding_handler):
940 2004-08-27 Matthias Clasen <mclasen@redhat.com>
942 Fix #151112, Olexiy Avramchenko:
944 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout):
945 * gtk/gtkiconview.c (scroll_timeout, layout_callback)
946 (gtk_icon_view_item_accessible_idle_do_action):
947 * gtk/gtkcombobox.c (list_popup_resize_idle, popdown_idle)
948 (popup_idle): Protect idle callbacks and timeouts with
949 GDK_THREADS_ENTER/_LEAVE.
951 * gtk/gtkfilechooserbutton.c (update_dialog_idle): New function to
952 call update_dialog() from an idle with the necessary protection.
954 Mon Aug 30 01:34:42 2004 Matthias Clasen <maclas@gmx.de>
956 Changes to make sure input methods respect the editability
957 of entries and text views. #114173, Noah Levitt.
959 * gtk/gtkentry.c (popup_targets_received): Make the Input
960 Methods menuitem insensitive if we're not editable.
962 * gtk/gtkentry.c (gtk_entry_delete_surrounding_cb):
963 * gtk/gtkentry.c (gtk_entry_preedit_changed_cb):
964 * gtk/gtkentry.c (gtk_entry_commit_cb): Don't change anything
965 if we're not editable.
967 * gtk/gtkentry.c (gtk_entry_focus_out):
968 * gtk/gtkentry.c (gtk_entry_focus_in): Only send focus_in and
969 focus_out to the im context if we're editable.
971 * gtk/gtkentry.c (gtk_entry_set_property): Reset the im context
972 if the entry just became non-editable.
974 * gtk/gtktextview.c (gtk_text_view_delete_surrounding_handler):
975 Use gtk_text_buffer_delete_interactive() to not delete
976 non-editable portions of text.
978 2004-08-30 Tor Lillqvist <tml@iki.fi>
980 * modules/input/Makefile.am (im_ime_la_LIBADD): Link with -limm32.
982 * modules/input/gtkimcontextime.c: Use quotes in #includes, to
983 find headers when building inside GTK+ sources.
985 2004-08-27 Tor Lillqvist <tml@iki.fi>
987 * gdk/win32/gdkdnd-win32.c (GdkDragContextPrivateWin32): Add
988 drop_failed, like in the X11 backend. Nothing sets it, though.
989 (gdk_drag_drop_succeeded): Copy from X11 backend.
991 Thu Aug 26 23:58:11 2004 Matthias Clasen <maclas@gmx.de>
993 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't crash
994 if model is not set. Noted by Mariano Suarez-Alvarez.
996 Thu Aug 26 22:44:12 2004 Matthias Clasen <maclas@gmx.de>
998 Provide information about how an adjustment change in a range
999 widget happened. Add a "slider-moved" signal which reports how
1000 a user is interacting with the range, whether they are clicking
1001 on a stepper or the trough, or dragging the slider. (#133263,
1004 * gtk/gtkmarshalers.list: Add signal type BOOLEAN:ENUM,DOUBLE.
1005 * gtk/gtkrange.c (gtk_range_class_init): Add "change-value"
1007 (gtk_range_internal_set_value): Rename to
1008 gtk_range_real_change_value. Add GtkScrollType parameter. Emit
1009 the change-value signal when the range's value changes.
1010 (update_slider_position, gtk_range_scroll_event, step_back,
1011 step_forward, page_back, page_forward, scroll_begin,
1012 scroll_end): Change gtk_range_internal_set_value to
1013 gtk_range_real_change_value.
1014 * gtk/gtkrange.h (struct _GtkRangeClass): Declare change_value
1017 2004-08-26 Matthias Clasen <mclasen@redhat.com>
1019 * modules/input/Makefile.am: Build imime.la on Windows.
1021 * modules/input/gtkimcontextime.h:
1022 * modules/input/gtkimcontextime.c:
1023 * modules/input/imime.c:
1024 * modules/input/imm-extra.h: Add the IME input method for Win32
1025 written by Takuro Ashie and Kazuki IWAMOTO. The code was previously
1026 hosted at http://sourceforge.jp/projects/imime. (#135195)
1028 2004-08-26 Bill Haneman <billh@gnome.org>
1031 (gtk_tree_view_move_cursor_up_down):
1032 If a multi-selection list contains only one item,
1033 select it on cursor_up or cursor_down.
1035 [patch from Padraig O'Briain]
1037 2004-08-26 Matthias Clasen <mclasen@redhat.com>
1039 Make gdk_window_process_[all]_updates() respect
1040 update_freeze_counter (#144272, Soeren Sandmann)
1042 * gdk/gdkwindow.c (gdk_window_schedule_update): New function to
1043 install an idle for gdk_window_update_idle() if one isn't there
1045 (gdk_window_process_all_updates):
1046 (gdk_window_process_updates): Only process the updates if the
1047 window isn't frozen.
1048 (gdk_window_invalidate_maybe_recurse): Schedule an update when
1050 (gdk_window_thaw_updates): Use gdk_window_schedule_update() instead
1051 of directly installing the idle.
1053 2004-08-22 Robert Ă–gren <gtk@roboros.com>
1055 On Win32, make graphical tablets work on multi-monitor systems.
1056 (#145467, reported by buttknock1@ya...)
1058 * gdk/win32/gdkinput-win32.c (gdk_input_translate_coordinates):
1059 Use dimensions of _gdk_parent_root as screen size.
1060 (gdk_input_get_root_relative_geometry): Get coordinates relative
1061 to GDK root window instead of Win32 coordinates.
1062 (_gdk_input_other_event): Updated accordingly.
1064 Wed Aug 25 17:24:17 2004 Manish Singh <yosh@gimp.org>
1066 * gdk/x11/gdkfont-x11.c: remove unused gdk_font_charset_for_locale()
1069 * gdk/x11/gdkinput-x11.c (_gdk_input_common_init): remove unused
1070 variables num_extensions and extensions.
1072 * gtk/gtkhsv.c: remove unused gtk_hsv_get_focus_gc() function.
1074 Wed Aug 25 17:14:58 2004 Manish Singh <yosh@gimp.org>
1076 * gtk/gtktreeview.c (gtk_tree_view_search_activate): initialize
1077 path so we don't potentially use an undefined pointer.
1079 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): add G_CALLBACK
1080 cast for tree_view_keybinding_cb.
1082 * gtk/gtkfilechooserdefault.c (location_entry_create): cast to
1083 GTK_FILE_CHOOSER_ENTRY for _gtk_file_chooser_entry_set_file_part()
1086 * gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_start_editing):
1087 cast to GTK_COMBO_BOX for gtk_combo_box_set_active_iter() call.
1089 * gtk/gtkselection.c (selection_get_text_plain): make len a gsize,
1090 since that's what g_convert_with_fallback() expects.
1092 Wed Aug 25 16:14:34 2004 Jonathan Blandford <jrb@redhat.com>
1094 * gtk/gtktreeview.c (gtk_tree_view_search_activate): activate the
1095 typeahead entry on enter.
1097 2004-08-25 Matthias Clasen <mclasen@redhat.com>
1099 * gtk/gtkmenu.c (gtk_menu_attach_to_widget): Steal ATTACHED_MENUS
1100 list so its tail isn't freed when we re-set it, noticed
1101 by Hans Petter Jansson.
1103 * gtk/gtksizegroup.c (gtk_size_group_add_widget): Fix
1104 a typo, noticed by Tim Janik.
1106 Wed Aug 25 15:15:56 2004 Jonathan Blandford <jrb@redhat.com>
1108 * gtk/gtkpathbar.c (gtk_path_bar_size_allocate): Change the Down
1109 button to be end-justified, so that clicking on it is a stable
1112 Tue Aug 24 02:06:37 2004 Jonathan Blandford <jrb@gnome.org>
1115 (gtk_tree_view_real_expand_collapse_cursor_row): Don't handle the
1116 event if we have no children.
1118 * gtk/gtkfilechooserdefault.c (trap_activate_cb):
1119 (tree_view_keybinding_cb):Since GtkTreeView has a keybinding
1120 attached to '/', we need to catch keypresses before the TreeView
1122 (gtk_file_chooser_default_class_init): add '/' to be a keybinding
1124 (location_entry_create): Clear the text to "" when loading a file.
1125 This has a much better feel than putting the currently selected
1127 * #include <errno.h>
1129 2004-08-25 Matthias Clasen <mclasen@redhat.com>
1131 * gtk/gtkfilechooserdefault.c (check_is_folder): Use get_file_info() rather
1132 than trying get_folder() and checking for an error directly because older
1133 versions of the gnome-vfs backend don't return an error
1134 immediately. (#150852, Zack Cerza )
1136 2004-08-25 Matthias Clasen <mclasen@redhat.com>
1138 * configure.in: Post-release version bump.
1140 * === Released 2.5.2 ===
1143 * gtk/abicheck.sh: Make work during make distcheck.
1145 * docs/RELEASE-HOWTO: Add hint about doing make check
1146 before make distcheck.
1148 * gtk/gtk.symbols: Add some missing symbols.
1150 * gtk/gtkiconview.c: Add some missing statics.
1152 2004-08-24 Matthias Clasen <mclasen@redhat.com>
1154 * NEWS: Updates for 2.5.2
1156 Wed Aug 25 00:22:48 2004 Søren Sandmann <sandmann@redhat.com>
1158 * gtk/gtksequence.c: Remove debug spew
1160 Wed Aug 25 00:09:07 2004 Søren Sandmann <sandmann@redhat.com>
1162 * gtk/gtkliststore.c (gtk_list_store_move_after): Fix logical
1163 errors in gtk_list_store_move_before/after(). (#150983, patch by
1166 Tue Aug 24 21:46:42 2004 Søren Sandmann <sandmann@redhat.com>
1168 * gtk/gtksequence.c (_gtk_sequence_move): Just return if the
1169 parameters are identical. (#150159, Robert Ă–gren)
1171 2004-08-24 Matthias Clasen <mclasen@redhat.com>
1173 * gtk/gtkaction.c (connect_proxy, disconnect_proxy): Handle
1174 action_group being NULL. (#150869, Tommi Komulainen)
1176 2004-08-24 Matthias Clasen <mclasen@redhat.com>
1178 * gdk/gdkimage.c (allocate_scratch_images): Use the correct
1179 index variable. (#150941, Tommi Komulainen)
1181 2004-08-24 Matthias Clasen <mclasen@redhat.com>
1183 * gtk/gtktreeview.c (gtk_tree_view_node_queue_redraw): Take header
1184 height and adjustment into account. (#136496, Pawek Salek)
1186 Mon Aug 23 17:19:19 2004 Jonathan Blandford <jrb@redhat.com>
1189 * docs/tools/Makefile.am (clean-local): add the doc shooter to the
1190 docs dir as an uninstalled helper tool.
1192 2004-08-23 Matthias Clasen <mclasen@redhat.com>
1194 * gdk/x11/gdkwindow-x11.c (show_window_internal): Make it compile.
1196 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Add a
1199 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Update
1200 toplevel->user_time.
1201 (show_window_internal): Update the user time when re-mapping a
1202 toplevel window. (#150502, Elijah Newren)
1204 2004-08-23 Matthias Clasen <mclasen@redhat.com>
1206 Fix #150822, reported by Christian Persch
1208 * gtk/gtklabel.c (gtk_label_ensure_layout): Set the layout width
1209 appropriately when ellipsized.
1210 (gtk_label_size_allocate): Only set the layout width if there
1213 2004-08-23 Matthias Clasen <mclasen@redhat.com>
1215 * gdk/x11/gdkwindow-x11.c (gdk_window_focus): Support the latest
1216 EWMH additions to the _NET_ACTIVE_WINDOW client message
1217 format. (#150668, Elijah Newren)
1219 Mon Aug 23 01:17:59 2004 Matthias Clasen <maclas@gmx.de>
1221 * gdk/gdkrgb.c (gdk_rgb_xpixel_from_rgb_internal): Set unused
1222 bits in pixel to 1s in case they are used as alpha; copying
1223 code from gdk_colormap_alloc_colors(). (#150466, Rich Wareham)
1225 2004-08-22 Philip Langdale <plangdale@vmware.com>
1227 * gtk/gtkaction.c (gtk_action_disconnect_proxy): Two signals
1228 (gtk_action_sync_property and gtk_action_sync_sensitive) were
1229 not being correctly disconnected, leading to actions continuing
1230 to affect disconnected proxies. (#150607)
1232 2004-08-22 Tor Lillqvist <tml@iki.fi>
1234 * gdk/win32/gdkwindow-win32.c (gdk_window_new_internal,
1235 gdk_window_new, gdk_window_set_skip_taskbar_hint): Don't show TEMP
1236 windows in the Task Manager. Implement by calling
1237 gdk_window_set_skip_taskbar_hint(TRUE) on them. (#145481, Tim
1240 * gdk/win32/gdkdisplay-win32.c (enum_monitor, gdk_display_open):
1241 Report whole of (primary) monitor, including any taskbars.
1242 Excluding the taskbar area from the "root window" reported to GDK
1243 doesn't seem to be that useful although gdk/win32 had been doing it
1244 for a very long time. (#149013, see also #145467 and #148526)
1246 Sun Aug 22 16:55:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1249 * gtk/gtkalignment.c:
1251 Make enums match property names. Found by a script by Tommi
1254 * gtk/gtkpaned.c (gtk_paned_class_init): fix min/max mixup.
1256 Sun Aug 22 16:09:49 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1258 * gtk/gtkliststore.h (struct _GtkListStore):
1259 * gtk/gtkliststore.c (gtk_list_store_init):
1260 * gtk/gtkliststore.c (gtk_list_store_insert):
1261 * gtk/gtkliststore.c (gtk_list_store_remove):
1262 Restore length field; PyGTK and maybe others use it directly.
1264 Sun Aug 22 15:46:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1266 * gtk/gtkpaned.c (gtk_paned_class_init):
1267 s/CYCLE_HANDLE_FOCUS/CYCLE_CHILD_FOCUS/
1269 * gtk/gtkfontbutton.c (gtk_font_button_class_init):
1270 s/PROP_SHOW_SIZE/PROP_SHOW_STYLE/
1272 Both pointed out by Tommi Komulainen.
1274 Sun Aug 22 13:44:53 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1276 * gtk/gtkpaned.c (gtk_paned_class_init): Use PROP_MAX_POSITION,
1277 not PROP_MIN_POSITION for the max_position property. Fix pointed
1278 out by Tommi Komulainen.
1280 Sun Aug 22 13:32:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1282 * gtk/gtkliststore.c (gtk_list_store_insert): Normalize the
1283 position so we don't create paths with off-list
1286 Sun Aug 22 12:04:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1288 * gtk/gtkliststore.c (gtk_list_store_sort_iter_changed): Use the
1289 correct tree path (#150289, Morten Welinder).
1291 Sun Aug 22 00:08:44 2004 Matthias Clasen <maclas@gmx.de>
1293 Fix #150406, reported by Fernando San MartĂn Woerner, patch
1294 by Gustavo Carneiro.
1296 * gtk/gtkentrycompletion.c
1297 (gtk_entry_completion_default_completion_func): Check that
1298 column is of type G_TYPE_STRING before proceeding.
1300 Sat Aug 21 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
1302 * gtk/gtktreestore.c (gtk_tree_store_swap): Don't use an
1303 uninitialized tree iter. (#150414, Torsten Schoenfeld)
1305 Sat Aug 21 23:29:54 2004 Matthias Clasen <maclas@gmx.de>
1307 Fix #150738, Tomislav Jonjic.
1309 * gtk/gtktoolitem.h (GTK_IS_TOOL_ITEM_CLASS):
1310 * gtk/gtktoolbutton.h (GTK_IS_TOOL_BUTTON_CLASS):
1311 * gtk/gtktoggleaction.h (GTK_IS_TOGGLE_ACTION_CLASS):
1312 * gtk/gtkseparatortoolitem.h (GTK_IS_SEPARATOR_TOOL_ITEM_CLASS):
1313 * gtk/gtkradiotoolbutton.h (GTK_IS_RADIO_TOOL_BUTTON_CLASS):
1314 * gtk/gtkradioaction.h (GTK_IS_RADIO_ACTION_CLASS):
1315 * gtk/gtkuimanager.h (GTK_IS_UI_MANAGER_CLASS):
1316 * gtk/gtkaction.h (GTK_IS_ACTION_CLASS): Fix macro definitions.
1318 Wed Aug 18 17:25:26 2004 Manish Singh <yosh@gimp.org>
1320 * demos/testpixbuf-save.c
1321 * demos/gtk-demo/hypertext.c: Get rid of some unnecessary casts.
1323 * demos/gtk-demo/appwindow.c: Make activate_email and activate_url
1324 match the arguments for GtkAboutDialogActivateLinkFunc.
1326 Wed Aug 18 16:18:00 2004 Manish Singh <yosh@gimp.org>
1328 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): Initialize height
1329 from fixed_height before we do anything, so it always has a valid
1332 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Fix call
1333 to gtk_tree_model_get (missing "," in param list).
1335 2004-08-18 Federico Mena Quintero <federico@ximian.com>
1341 * gtk/gtkfilechooserdefault.c: Renamed SHORTCUTS_COL_PATH to
1342 SHORTCUTS_COL_DATA. Add SHORTCUTS_COL_IS_VOLUME, to determine
1343 easily whether the SHORTCUTS_COL_DATA points to a GtkFilePath or a
1344 GtkFileSystemVolume.
1345 (shortcuts_model_create): Create a boolean column for
1346 SHORTCUTS_COL_IS_VOLUME.
1347 (shortcuts_reload_icons): Simplify with the use of the
1348 SHORTCUTS_COL_IS_VOLUME column. Don't leak the pixbuf.
1349 (shortcuts_insert_path): Add the SHORTCUTS_COL_IS_VOLUME data.
1350 (shortcuts_free_row_data): New helper function; frees the data
1351 columns for an iter.
1352 (shortcuts_remove_rows): Don't take a callback for freeing the
1353 data; free everything here instead. Use
1354 shortcuts_free_row_data().
1355 (volume_remove_cb): Removed.
1356 (remove_bookmark_cb): Removed.
1357 (remove_row_cb): Make this a single generic function to delete
1359 (shortcuts_add_volumes): Use remove_row_cb().
1360 (shortcuts_add_bookmarks): Likewise.
1361 (struct _GtkFileChooserDefault): Removed the
1362 shortcuts_current_folder_is_volume field.
1363 (shortcuts_add_current_folder): Oops, don't free the volume.
1364 (remove_current_folder_cb): Removed.
1365 (shortcut_find_position): Simplify through the use of the
1366 SHORTCUTS_COL_IS_VOLUME column.
1367 (remove_selected_bookmarks): Assert that we don't get a volume.
1368 (shortcuts_reorder): Likewise; also, plug a leak.
1369 (gtk_file_chooser_default_remove_shortcut_folder): Simplify
1370 through the use of shortcuts_remove_rows().
1371 (gtk_file_chooser_default_list_shortcut_folders): Assert that we
1373 (shortcuts_activate_iter): Simplify.
1374 (home_folder_handler): Simplify by using
1375 shortcuts_activate_iter().
1376 (shortcuts_free): New function; frees all the data columns.
1377 (gtk_file_chooser_default_finalize): Unref the
1378 shortcuts_filter_model and the shortcuts model data first.
1380 Wed Aug 18 08:31:17 2004 Manish Singh <yosh@gimp.org>
1382 * gtk/gtkiconview.c: Applied patch from Olivier Andrieu to fix
1385 * gtk/gtkicontheme.c (gtk_icon_theme_init): xdg_data_dirs should
1386 match constness attributes of g_get_system_data_dirs ().
1388 2004-08-17 Matthias Clasen <mclasen@redhat.com>
1390 * gtk/gtkicontheme.c (gtk_icon_theme_init): Look up icon themes in the
1391 directories specified in the icon theme spec: $HOME/.icons,
1392 $XDG_DATA_DIRS/icons, /usr/share/pixmaps. Note that GTK+ used to also look
1393 in $GTK_DATA_DIR/icons, $GTK_DATA_DIR/pixmaps and /usr/share/icons. (#148694)
1396 * gtk/gtkframe.c (gtk_frame_paint): Take widget->state into account when
1397 painting the shadows. (#150351, Tim Janik)
1399 2004-08-17 Matthias Clasen <mclasen@redhat.com>
1401 * gtk/abicheck.sh: No need for INCLUDE_INTERNAL_SYMBOLS anymore.
1403 * gdk/gdk.symbols: Don't use #if defined().
1405 * gdk/Makefile.am (gdkalias.h):
1406 * gtk/Makefile.am (gtkalias.h): Don't use cpp to filter gtk.symbols.
1408 * gdk/makegdkalias.pl:
1409 * gtk/makegtkalias.pl: Move the #ifdef processing into the perl script, and
1410 keep the #ifdefs which differentiate between platforms.
1412 * gtk/Makefile.am (gtk_private_h_sources): Remove gtkinternals.h, it is no
1415 2004-08-17 Matthias Clasen <mclasen@redhat.com>
1417 * tests/testfilechooserbutton.c: Use g_message() throughout, add RTL envar for
1420 * gtk/gtkfilechooserbutton.c: Get rid of HAVE_CONFIG_H.
1421 (gtk_file_chooser_button_init): Use gtk_drag_dest_add_text_targets().
1422 (gtk_file_chooser_button_drag_data_received): Use gtk_selection_data_get_text().
1423 (gtk_file_chooser_button_set_dialog): _gtk_file_chooser_entry_set_base_folder()
1424 seems to expect a path, not an uri.
1425 (update_dialog): Handle g_filename_from_uri() returning NULL, don't free
1428 * gtk/gtkfilechooserbutton.h: Minor stylistic changes.
1430 2004-08-17 Matthias Clasen <mclasen@redhat.com>
1432 * gtk/gtkfilechooserbutton.[hc]: New widget to go along with
1433 GtkFontButton and GtkColorButton for use in preference dialogs.
1434 Replaces GnomeFileEntry. (#148108, James M. Cape)
1436 * gtk/gtk.h: Include gtkfilechooserbutton.h
1438 * gtk/Makefile.am (gtk_public_h_sources): Add gtkfilechooserbutton.h
1439 (gtk_c_sources): Add gtkfilechooserbutton.c
1441 * gtk/gtk.symbols: Add the GtkFileChooserButton symbols.
1443 * gtk/gtkfilechooserutils.[hc]: Make the delegate quark available.
1445 * gtk/gtkfilechooserentry.[hc] (_gtk_file_chooser_entry_new): Allow
1446 to suppress tab-eating using the new eat_tabs argument. Adjust all
1449 * tests/testfilechooserbutton.c: Test for GtkFileChooserButton.
1451 * tests/Makefile.am (noinst_PROGRAMS): Add testfilechooserbutton
1453 2004-08-16 Matthias Clasen <mclasen@redhat.com>
1455 * gtk/gtkwidget.c (gtk_widget_render_icon): Doc update.
1457 * gtk/gtkiconfactory.c (render_icon_name_pixbuf): When the size is -1,
1458 use the available size closest to 48. (#150147)
1460 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): Actually return
1461 a pointer to the beginning of the sizes array, not the end.
1463 2004-08-16 Morten Welinder <terra@gnome.org>
1465 * tests/testtreemodel.c (test_run): Comment out mallinfo stuff.
1466 Fix g_print %-strings.
1468 * gtk/gtksequence.c (_gtk_sequence_set): Fix C99ism.
1470 2004-08-16 Christian Rose <menthos@menthos.com>
1472 * configure.in: Added "bs" to ALL_LINGUAS.
1474 Mon Aug 16 01:35:25 2004 Matthias Clasen <maclas@gmx.de>
1477 * gtk/gtkcombobox.[hc]: Add a ::focus-on-click property and
1478 change the default behaviour to focus on click.
1480 * gtk/gtkbutton.c (gtk_button_set_focus_on_click): Typo fix.
1482 Mon Aug 16 01:03:08 2004 Matthias Clasen <maclas@gmx.de>
1484 * gtk/gtktextiter.c (gtk_text_iter_set_visible_line_offset):
1485 (gtk_text_iter_set_visible_line_index): Count from the
1486 beginning of the line, not from the current position. (#150101,
1489 2004-08-15 Tor Lillqvist <tml@iki.fi>
1491 * gtk-zip.sh.in: Fix typo. The gtk.immodules file had never been
1492 included in my zipfiles...!
1494 * gtk/gtkfilesystemwin32.c (extract_icon): Improve handling of
1495 icon alpha channel (on Windows XP) and mask (older Windows
1496 versions). (#148641, Tim Evans)
1498 Sun Aug 15 02:31:55 2004 Matthias Clasen <maclas@gmx.de>
1500 * gtk/gtkfilesystemunix.c (get_icon_type_from_stat): Make
1501 the use of S_ISFIFO and S_ISSOCK conditional. (#150146,
1504 2004-08-14 Tor Lillqvist <tml@iki.fi>
1506 * gtk/gtkfilechooserdefault.c (shortcuts_append_home,
1507 shortcuts_append_desktop, set_local_only)
1508 * gtk/gtkfilesystemwin32.c (gtk_file_system_win32_render_icon)
1509 * gtk/gtkpathbar.c (find_button_type, _gtk_path_bar_set_file_system):
1510 Guard against g_get_home_dir() returning NULL. (#150007)
1512 Sat Aug 14 17:56:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1514 * gtk/gtkentry.c (gtk_entry_get_pixel_ranges): New function.
1516 * gtk/gtkentry.c (in_selection): New function using
1517 gtk_entry_get_pixel_ranges() to determine whether a click is in
1518 the selection. Improve entry behavior wrt. dragging and
1519 selecting. Bug #143249.
1521 Sat Aug 14 17:53:46 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1523 * configure.in: Require glib 2.5.2
1525 * gtk/gtksequence.[ch]: New internal data structure.
1527 * gtk/gtkliststore.[hc]: Reimplement in terms of new data
1530 * tests/Makefile.am (testtreemodel_SOURCES):
1531 * tests/testtreemodel.c: New test program written by Matthias.
1533 2004-08-13 Matthias Clasen <mclasen@redhat.com>
1535 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_style_set):
1536 Don't install the settings_notify_cb from here, since it
1537 may be called before the first screen_changed signal,
1538 confusing the logic in gtk_file_chooser_screen_changed().
1539 (#148803, Abel Daniel)
1541 * gtk/gtkcombobox.c: Make re-sensitivation work
1544 * gtk/gtkaction.c (gtk_action_new): Fix the docs.
1546 Fri Aug 13 01:06:56 2004 Matthias Clasen <maclas@gmx.de>
1548 * gtk/gtktreeview.c (gtk_tree_view_row_inserted):
1549 Make fixed height mode handle insertions. (#135955,
1550 Michael Vogt, testcase by Tim-Philipp MĂĽller, fix by
1553 Fri Aug 13 00:40:18 2004 Matthias Clasen <maclas@gmx.de>
1555 * gtk/gtkhandlebox.c: Add missing include.
1557 Thu Aug 12 23:52:12 2004 Matthias Clasen <maclas@gmx.de>
1559 Fix #149547, Markus Lausser:
1561 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate):
1562 * gtk/gtkcombobox.c (gtk_combo_box_size_request): Don't
1563 crash if size_request or size_allocate are called early.
1565 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate): Protect
1566 against being allocated too small.
1568 Thu Aug 12 21:02:57 2004 Matthias Clasen <maclas@gmx.de>
1570 * demos/gtk-demo/appwindow.c (about_cb): Adjust to GtkAboutDialog
1573 * gtk/gtkaboutdialog.h:
1574 * gtk/gtkaboutdialog.c (gtk_about_dialog_set_email_hook):
1575 (gtk_about_dialog_set_url_hook): Add callback data and destroy notify
1576 for language bindings. (#149999, Olivier Andrieu)
1578 2004-08-12 Matthias Clasen <mclasen@redhat.com>
1580 * gtk/gtkfilesystem.c: Underscore-prefix gtk_file_system_module_get_type().
1581 * gtk/gtkfilechooserdefault.c: Underscore-prefix shortcuts_model_filter_get_type().
1583 * gtk/gtkimmodule.c: Make gtk_im_module_get_type() static.
1585 * gtk/gtkinternals.h: Remove the no longer exported get_type functions.
1587 Thu Aug 12 01:35:46 2004 Matthias Clasen <maclas@gmx.de>
1589 * gtk/gtkiconview.c: Make the icon view accessible by
1590 implementing the necessary ATK interfaces. (#149728,
1593 Thu Aug 12 00:02:29 2004 Matthias Clasen <maclas@gmx.de
1595 * gtk/gtkaction.c (gtk_action_new): Link to information about
1596 allowed action names. (#149620, David Malcolm)
1598 Wed Aug 11 23:14:25 2004 Matthias Clasen <maclas@gmx.de>
1602 * gtk/gtkaction.c (gtk_action_set_sensitive):
1603 (gtk_action_set_visible): Add setters for the ::sensitive
1604 and ::visible properties of GtkAction. (#149622, David Malcolm)
1606 2004-08-11 Federico Mena Quintero <federico@ximian.com>
1608 Fix #149422, #143457:
1610 * gtk/gtkfilechooserdefault.c
1611 (gtk_file_chooser_default_should_respond): Rewrite to take the
1612 current focus into account, the contents of the save entry, and
1613 the last focus for the shortcuts list.
1614 (switch_to_selected_folder): We don't need an assertion on the
1617 Wed Aug 11 20:56:00 2004 Matthias Clasen <maclas@gmx.de>
1619 * gtk/gtkinternals.h:
1620 * gtk/gtk.symbols: Add shortcuts_model_filter_get_type.
1622 * gtk/abicheck.sh: Check all symbols.
1624 Wed Aug 11 19:20:34 2004 Matthias Clasen <maclas@gmx.de>
1626 * gtk/gtktreeview.c (gtk_tree_view_maybe_begin_dragging_row):
1627 Don't start a drag if the treeview is only a
1628 drag destination. (#149836, Pawel Salek)
1630 2004-08-11 Matthias Clasen <mclasen@redhat.com>
1632 * gtk/gtktreedatalist.[hc]:
1633 * gtk/gtkliststore.c:
1634 * gtk/gtktreestore.c: Underscore-prefix
1635 gtk_tree_data_list_compare_func.
1637 * gtk/gtk.symbols: Remove gtk_tree_data_list_compare_func.
1639 * gtk/makegtkalias.pl: No need to include gtktreedatalist.h
1642 2004-08-10 Matthias Clasen <mclasen@redhat.com>
1645 * gtk/Makefile.am: Define TESTS, not TEST, so that make check
1646 actually triggers abicheck.sh.
1648 * gdk/makegdkalias.pl:
1649 * gtk/makegtkalias.pl: Include glib.h before using glib symbols. D'oh.
1651 * gdk/makegdkalias.pl:
1652 * gtk/makegtkalias.pl: Protect gtkalias.h by G_HAVE_GNUC_VISIBILITY.
1654 * gtk/Makefile.am: Include gtkalias.h in the generated
1655 sources gtkmarhalers.c and gtkmarshal.c.
1657 * gtk/makegtkalias.pl: Cosmetic fix.
1659 * gdk/Makefile.am: Remove the . which was accidentally added
1660 to SUBDIRS. Include gdkalias.h in the generated sources
1661 gdkenumtypes.c and gdkmarshalers.c.
1663 * gdk/makegdkalias.pl: Cosmetic fix.
1665 * gdk/Makefile.am: Add gdkalias.h to BUILT_SOURCES.
1667 2004-08-09 Hans Breuer <hans@breuer.org>
1669 * gtk/makefile.msc.in : autogenerate gtk.def, cleanup
1671 * gdk/win32/gdkwindow-win32.c gdk/win32/gdkevents-win32.c :
1672 removed long time unused ifdef/ed code (WITHOUT_WM_CREATE),
1673 removed duplicated call to gdk_window_set_cursor()
1675 Mon Aug 9 15:41:17 2004 Matthias Clasen <maclas@gmx.de>
1677 Add hidden aliases for exported symbols which are
1678 used internally in order to get rid of many PLT
1679 entries. (#145519, Arjan van de Ven)
1681 * gdk/Makefile.am: Add rules to generate gdk.def and
1682 gdkalias.h from gdk.symbols, and make make check check
1683 the abi with abicheck.sh.
1685 * gdk/gdk.symbols: New file. Definition of the GDK ABI.
1686 The file can be processed by cpp to filter out certain
1689 * gdk/abicheck.sh: New file. Script to check the actually
1690 symbols exported from libgdk-x11.2.0.so against the symbols
1691 found in gdk.symbols.
1693 * gdk/makegdkalias.pl: New file. Perl script to generate the
1694 header containing the alias definitions for internally used
1695 exported symbols from a list of symbols.
1697 * gdk/*.c, gdk/x11/*.c: Include gdkalias.h
1699 2004-08-09 Morten Welinder <terra@gnome.org>
1701 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): Fix C99ism.
1703 Mon Aug 9 15:27:01 2004 Matthias Clasen <maclas@gmx.de>
1705 * gtk/makegtkalias.pl: Also revert
1706 GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API to its old status.
1708 Mon Aug 9 15:19:34 2004 Matthias Clasen <maclas@gmx.de>
1711 * gdk/gdkrgb.h: Add the exported functions
1712 gdk_rgb_colormap_ditherable(), gdk_pointer_grab_info_libgtk_only(),
1713 gdk_keyboard_grab_info_libgtk_only() to the appropriate
1716 Mon Aug 9 14:24:46 2004 Matthias Clasen <maclas@gmx.de>
1718 * gdk/x11/gdkevents-x11.c (gdk_event_send_client_message_to_all_recurse):
1721 Mon Aug 9 12:48:04 2004 Matthias Clasen <maclas@gmx.de>
1723 Add hidden aliases for exported symbols which are
1724 used internally in order to get rid of many PLT
1725 entries. (#145519, Arjan van de Ven)
1727 * gtk/Makefile.am: Add rules to generate gtk.def and
1728 gtkalias.h from gtk.symbols, and make make check check
1729 the abi with abicheck.sh.
1730 (gtk_private_h_sources): Add gtkinternals.h
1731 (gtk_built_private_headers): Add gtkalias.h
1732 (gtk_extra_sources): Add gtk.symbols
1733 (EXTRA_DIST): Add makegtkalias.pl and abicheck.sh
1735 * gtk/gtk.symbols: New file. Definition of the GTK+ ABI.
1736 The file can be processed by cpp to filter out certain
1739 * gtk/abicheck.sh: New file. Script to check the actually
1740 symbols exported from libgtk-x11.2.0.so against the symbols
1741 found in gtk.symbols.
1743 * gtk/makegtkalias.pl: New file. Perl script to generate the
1744 header containing the alias definitions for internally used
1745 exported symbols from a list of symbols.
1747 * gtk/gtkinternals.h: New file. An uninstalled header listing
1748 symbols which must be exported for some reason and do not appear
1749 in any other header.
1751 * gtk/*.c: Include gtkalias.h
1753 Mon Aug 9 11:49:46 2004 Matthias Clasen <maclas@gmx.de>
1755 * gtk/gtkmain.c: Only undef gtk_init_check and gtk_init on win32.
1757 Mon Aug 9 10:50:05 2004 Matthias Clasen <maclas@gmx.de>
1759 * gtk/gtkentry.h: Add gtk_entry_layout_index_to_text_index()
1760 and its inverse. The have always been exported and are meant
1763 Mon Aug 9 00:28:34 2004 Matthias Clasen <maclas@gmx.de>
1765 * gtk/gtkicontheme.c (load_svg_at_size): Don't leak the
1768 Mon Aug 9 00:13:03 2004 Matthias Clasen <maclas@gmx.de>
1770 * gtk/gtkaboutdialog.c (icon_set_new_from_pixbufs): Don't
1771 leak the icon source.
1773 Sun Aug 8 23:46:20 2004 Matthias Clasen <maclas@gmx.de>
1775 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Don't
1776 leak a reference to the pixbufs.
1778 Sun Aug 8 23:36:55 2004 Matthias Clasen <maclas@gmx.de>
1780 * gtk/gtkcombobox.c (gtk_combo_box_menu_setup): Ref
1781 and sink the column.
1782 (gtk_combo_box_menu_destroy): Unref the column.
1784 Sun Aug 8 23:35:00 2004 Matthias Clasen <maclas@gmx.de>
1786 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets):
1787 (gtk_drag_dest_add_text_targets): Don't leak a reference
1790 Sun Aug 8 22:52:26 2004 Matthias Clasen <maclas@gmx.de>
1792 * gtk/gtkcombobox.c (find_menu_by_path): Don't stumble over
1793 separators which are not backed by model rows.
1795 Sun Aug 8 11:01:23 2004 Matthias Clasen <maclas@gmx.de>
1797 * gtk/gtkcombobox.c (gtk_combo_box_set_active): Don't leak
1800 2004-08-08 Hans Breuer <hans@breuer.org>
1802 * gtk/gtkdnd.c (gtk_drag_dest_set) : take targets into
1803 account again to allow dnd of other things than text
1805 * gdk/win32/gdkselection-win32.c : offer windows bitmap to
1806 be pasted from clipboard (makes The GIMP 2.1's
1807 "File/Acquire/Paste as New" work, only using gtk+ API)
1809 Sun Aug 8 01:32:36 2004 Matthias Clasen <maclas@gmx.de>
1811 * gtk/gtk.def: Add gtk_cell_renderer_progress_get_type.
1813 Sun Aug 8 01:29:08 2004 Matthias Clasen <maclas@gmx.de>
1815 * gtk/gtk.def: Replace duplicate gtk_tree_view_get_hover_expand
1816 by gtk_tree_view_set_hover_expand.
1818 Sun Aug 8 01:23:08 2004 Matthias Clasen <maclas@gmx.de>
1820 * gtk/gtk.def: Remove the static function gtk_menu_get_private.
1822 2004-08-07 Tor Lillqvist <tml@iki.fi>
1824 * gdk/win32/gdkkeys-win32.c (update_keymap): Don't hardcode
1825 mapping of VK_DECIMAL to GDK_KP_Decimal. Instead, let ToAsciiEx()
1826 map it to what's printed on the keypad decimal key for the current
1827 input locale (keyboard layout). (#149404)
1829 Sat Aug 7 18:19:03 2004 Matthias Clasen <maclas@gmx.de>
1831 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
1832 (shortcuts_list_create): Use GtkTreeViewRowSeparatorFunc
1833 instead of GtkCellRendererSepText. (#147864)
1835 * gtk/gtkcellrendererseptext.[hc]: Removed.
1837 * gtk/Makefile.am: Remove gtkcellrendererseptext.[hc]
1839 Sat Aug 7 18:15:15 2004 Matthias Clasen <maclas@gmx.de>
1841 * gtk/gtkcombobox.c (gtk_combo_box_menu_row_deleted):
1842 (gtk_combo_box_menu_row_inserted):
1843 (gtk_combo_box_menu_row_changed): Correctly handle
1844 insertion and deletion of separators in menu mode.
1846 2004-08-07 Tor Lillqvist <tml@iki.fi>
1848 * gdk/win32/gdkevents-win32.c (handle_configure_event,
1849 gdk_event_translate:WM_WINDOWPOSCHANGED): Add _gdk_offset_{x,y} to
1850 top-level window coordinates, not just in generated
1851 events. (#148526, Robert Ă–gren)
1853 Sat Aug 7 01:26:08 2004 Matthias Clasen <maclas@gmx.de>
1855 Make the column drag code a bit more robust (still scary,
1856 though). (#106992, Christian Biere)
1858 * gtk/gtktreeview.c (_gtk_tree_view_column_start_drag): Assert
1859 that cur_reorder is NULL here.
1861 * gtk/gtktreeview.c (gtk_tree_view_button_release_drag_column):
1862 Reset cur_reorder to NULL, and only hide drag_highlight_window
1865 2004-08-06 Federico Mena Quintero <federico@ximian.com>
1869 * gtk/gtkfilechooserdefault.c (save_widgets_create): Use a
1870 GtkFileChooserEntry for the file name, rather than a GtkEntry.
1871 (update_chooser_entry): Set the contents of the file chooser entry
1872 rather than the plain entry's.
1873 (gtk_file_chooser_default_set_current_folder): Set the new folder
1875 (gtk_file_chooser_default_set_current_name): Set the name on the
1877 (check_save_entry): Use the file chooser entry rather than the
1880 * gtk/gtkfilechooserentry.c
1881 (_gtk_file_chooser_entry_set_base_folder): Call
1882 gtk_file_chooser_entry_changed() so that we recompute the current
1883 folder based on the new base folder.
1885 2004-08-06 Hans Breuer <hans@breuer.org>
1887 * gdk/win32/gdkwindow-win32.c : make it compile and more
1888 similar to the X11 implementation [backward compatibility
1889 for GDK_WINDOW_TEMP, GDK_INPUT_ONLY (fixes bug #148702),
1890 use the *screen* function variants, dont reparent already
1892 (get_visible_region) : take the win32 part into account
1893 (_gdk_windowing_window_destroy) : remove from handle table
1895 * gdk/win32/gdkdisplay-win32.c : added
1896 gdk_display_(request|supports)_selection_notification ()
1897 with a currently mostly pointless implementation ;-)
1899 * gtk/gtkfilesystemwin32.c (*_to_path) : same changes as on *NIX,
1901 (gtk_file_system_win32_render_icon) : use new GTK_STOCK_DIRECTORY
1903 * gtk/makefile.msc.in demos/gtk-demo/makefile.msc.in
1904 gtk/stock-icons/makefile.msc tests/makefile.msc : updated
1906 * gdk/gdk.def gtk/gtk.def : updated externals
1908 * tests/testiconview.c : remove unneeded dirent.h inclusion
1910 2004-08-06 Matthias Clasen <mclasen@redhat.com>
1912 * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): Fix
1913 an off-by-one error. (#141809, Markku Vire)
1915 * gtk/gtkdnd.c (gtk_drag_dest_set, gtk_drag_source_set): Really
1916 fix the initialization of the target list.
1918 Support XDND v5. (#10220, Owen Taylor)
1920 * gdk/x11/gdkdnd-x11.c: Record the XDND version and whether the
1921 drop was successful in the GdkDragContextPrivateX11 struct.
1922 (xdnd_finished_filter): Store the success status of the drop
1923 for an XDND version 5 interaction. For other versions, always
1924 assume the drop was successful.
1925 (xdnd_check_dest): Return the protocol version.
1926 (_gdk_drag_get_protocol_for_display): Return the protocol version.
1927 (gdk_drag_find_window_for_screen): Store the used protocol version
1928 in the GdkDragContext.
1929 (xdnd_send_enter): Send the used protocol version from the context,
1930 instead of hardwiring 3.
1931 (xdnd_enter_filter): Accept protocol versions >= 3 and store the
1932 used protocol version in the context.
1935 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): New function
1936 to find out whether a drop was successful.
1938 2004-07-28 Robert Ă–gren <gtk@roboros.com>
1940 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Set x_root
1941 and y_root in button and motion events from the tablet. (#148715)
1943 Thu Aug 5 19:58:08 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1945 * gtk/gtkplug.c (gtk_plug_realize): Call
1946 gdk_window_enable_synchronized_configure()
1948 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): Make
1949 noop if gdk_window_enable_synchronized_configure() has not been
1952 2004-08-04 Matthias Clasen <mclasen@redhat.com>
1954 * gtk/gtkfilechooser.[hc]: Add setter and getter for the
1955 ::show-hidden property. (#145610, Jeff Franks)
1957 * tests/testiconview.c: Add buttons to select and unselect all
1958 nodes, make the popup menu actually work.
1960 * gtk/gtkiconview.c: Make GTK_SELECTION_BROWSE work as intended,
1961 let button 3 presses through to the app, to make popup menus
1964 * tests/Makefile.am: Add testiconview.
1965 * tests/testiconview.c: A test for GtkIconView
1966 * tests/gnome-textfile.png: ...which uses this image.
1968 Wed Aug 4 01:37:57 2004 Matthias Clasen <maclas@gmx.de>
1970 * gtk/gtktreeview.c:
1971 * gtk/gtktreestore.c:
1972 * gtk/gtktreemodelfilter.c:
1973 * gtk/gtknotebook.c: s/childs/children/g.
1975 Wed Aug 4 01:04:48 2004 Matthias Clasen <maclas@gmx.de>
1977 Fix #133446, noticed by Christian Persch:
1979 * gtk/gtkaction.c (gtk_action_class_init): Add a new boolean
1980 property ::visible-overflown.
1981 * gtk/gtkaction.c (gtk_action_create_menu_proxy): Don't create
1982 a menu proxy if visible_overflown is FALSE.
1984 Tue Aug 3 20:16:26 2004 Matthias Clasen <maclas@gmx.de>
1986 * gtk/gtkactiongroup.[hc]: Make the the GtkAction{Toggle,Radio,}Entry*
1987 arguments to the gtk_action_group_add_..._actions() functions const,
1988 since the most common use case is to use a static array. (142334,
1989 Mariano Suarez-Alvarez)
1991 Tue Aug 3 20:03:33 2004 Matthias Clasen <maclas@gmx.de>
1993 * gtk/gtkuimanager.c (get_node): Make gtk_ui_manager_add_ui()
1994 accept paths with a leading "/ui". (#149077, David Malcolm)
1996 Tue Aug 3 19:59:29 2004 Matthias Clasen <maclas@gmx.de>
1998 * gtk/gtkiconview.c: Fix some warnings.
2000 Tue Aug 3 18:38:40 2004 Matthias Clasen <maclas@gmx.de>
2002 * gtk/gtktreemodelfilter.c: Correct the return type
2003 of gtk_tree_model_filter_get_flags(). (#149195, Morten Welinder)
2005 Tue Aug 3 18:16:55 2004 Matthias Clasen <maclas@gmx.de>
2007 Fix #149191, reported by Morten Welinder:
2009 * gtk/gtkmain.c: Include gtkclipboard.h,
2010 * gtk/gtkwidget.h: Declare _gtk_widget_grab_notify, not
2011 _gtk_widget_emit_grab_notify.
2013 Tue Aug 3 14:50:14 2004 Matthias Clasen <maclas@gmx.de>
2015 * gtk/gtkicontheme.c (add_size): Add missing parens.
2016 (#149190, Morten Welinder)
2018 Tue Aug 3 14:29:49 2004 Matthias Clasen <maclas@gmx.de>
2020 * gtk/gtkcombobox.c (gtk_combo_box_menu_fill): Remove
2021 accidentally committed debug code.
2023 Tue Aug 3 01:19:12 2004 Matthias Clasen <maclas@gmx.de>
2025 * gtk/gtkcombobox.c (gtk_combo_box_relayout_item): Optimize
2026 for the case that row_column and col_column are unset.
2027 (#148868, Lorenzo Gil Sánchez)
2029 Mon Aug 2 21:52:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2031 * gdk/x11/gdkwindow-x11.c (ensure_sync_counter): New
2032 function. Make sure the sync counter is recreated when a window is
2033 reparented to become a toplevel. (#148358)
2035 2004-08-02 Matthias Clasen <mclasen@redhat.com>
2037 * tests/testcombo.c: Some trees in combo boxes.
2039 * gtk/gtkcombobox.c: Rework the combo box to handle
2040 tree models. (#139582, Matt Walton)
2042 * gtk/gtktreeview.h:
2043 * gtk/gtktreeview.c:
2044 * gtk/gtktreeprivate.h: Add a new boolean property
2045 ::hover-expand and make the treeview expand/collapse rows
2046 on mouseover if it is set.
2048 * gtk/gtkiconview.h: Remove some erroneous declarations.
2050 * gtk/gtkcellview.c (gtk_cell_view_set_cell_data): Don't
2051 crash if the displayed row is gone.
2053 2004-08-02 Morten Welinder <terra@gnome.org>
2055 * gtk/gtkentry.c (gtk_entry_motion_notify): C99ism.
2057 Mon Aug 2 01:30:03 2004 Matthias Clasen <maclas@gmx.de>
2059 * gtk/gtktextview.[hc]:
2060 * gtk/gtkentry.[hc]: Add a new binding signal ::backspace,
2061 bind it to the backspace key, and make it pay attention
2062 to the Pango backspace_deletes_character
2063 attribute. (#119891, Noah Levitt, patch by Theppitak
2066 Mon Aug 2 01:02:57 2004 Matthias Clasen <maclas@gmx.de>
2068 * gdk/x11/gdkevents-x11.c (gdk_check_wm_state_changed):
2069 (gdk_check_wm_desktop_changed): Add missing error
2070 traps. (#149011, Thomas Leonard)
2072 Mon Aug 2 00:21:26 2004 Matthias Clasen <maclas@gmx.de>
2074 * gtk/gtktextview.c (blink_cb): Add the same warning
2075 that the blink_cb() in GtkEntry already has. (#148733)
2077 Mon Aug 2 00:12:16 2004 Matthias Clasen <maclas@gmx.de>
2079 * gtk/gtkentry.c (gtk_entry_class_init):
2080 (gtk_entry_get_alignment):
2081 (gtk_entry_set_alignment): Document the xalign property
2082 and its getter and setter as 2.4 additions. (#148978,
2085 Mon Aug 2 00:11:31 2004 Matthias Clasen <maclas@gmx.de>
2087 * gtk/gtkuimanager.c (gtk_ui_manager_class_init):
2088 * gtk/gtkactiongroup.c (gtk_action_group_class_init): Use
2089 canonical signal names in doc comments, since gtk-doc won't
2090 pick up signal docs with underscores.
2092 2004-08-01 Matthias Clasen <mclasen@redhat.com>
2094 * configure.in: Post-release version bump
2096 * === Released 2.5.1 ===
2098 Thu Jul 29 16:36:42 2004 Jonathan Blandford <jrb@redhat.com>
2100 * gtk/gtktreeprivate.h: New arguments
2102 * gtk/gtktreeview.c:
2103 (gtk_tree_view_class_init): Add key_release callback
2104 (gtk_tree_view_init): Initialize timeout handler
2105 (gtk_tree_view_unrealize): clear timeout if needed
2106 (gtk_tree_view_key_press): Typeahead support
2107 (gtk_tree_view_key_release): Not used yet -- will be needed for
2109 (gtk_tree_view_search_entry_flush_timeout): Remove typeahead entry
2111 (gtk_tree_view_ensure_interactive_directory):
2112 (gtk_tree_view_real_start_interactive_search):
2113 (gtk_tree_view_search_init):
2114 (gtk_tree_view_start_interactive_search): Typeahead support added.
2115 (gtk_tree_view_search_dialog_hide): Clear timeout and text when we
2118 Sat Jul 31 23:17:44 2004 Matthias Clasen <maclas@gmx.de>
2122 Sat Jul 31 01:13:01 2004 Matthias Clasen <maclas@gmx.de>
2126 * gtk/gtkaction.c: Use the canonical form of signal names
2127 after "notify::". Otherwise, no notification arrives.
2128 GObject should have a warning for that, really. (#148879,
2129 Lorenzo Gil Sánchez)
2131 Sat Jul 31 00:42:08 2004 Matthias Clasen <maclas@gmx.de>
2133 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below):
2134 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_above): Don't
2135 set both states at once. (#148789, Matthew Garrett)
2137 2004-07-30 Matthias Clasen <mclasen@redhat.com>
2139 * gtk/gtkcombobox.c: Don't forget to destroy the row separator
2140 function user data when the combo box is destroyed.
2142 2004-07-30 Matthias Clasen <mclasen@redhat.com>
2144 * gtk/gtkcombobox.h:
2145 * gtk/gtkcombobox.c: Change the api for separators to use a
2146 separator function instead of a boolean column.
2148 * tests/testcombo.c: Update to match the api change.
2150 Fri Jul 30 02:21:41 2004 Matthias Clasen <maclas@gmx.de>
2152 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2153 Fix the positioning of the popup.
2155 Fri Jul 30 00:56:31 2004 Matthias Clasen <maclas@gmx.de>
2157 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_active_changed):
2158 Implement this in terms of gtk_combo_box_get_active_iter(),
2159 instead of gtk_combo_box_get_active().
2161 2004-07-29 Federico Mena Quintero <federico@ximian.com>
2163 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
2164 a field for an "add to shortcuts" menu item.
2165 (popup_menu_detach_cb): Clear out the field.
2166 (file_list_build_popup_menu): Only build the menu here.
2167 (file_list_update_popup_menu): Build the menu, then update the
2168 sensitivity of its items.
2169 (file_list_popup_menu): Use file_list_update_popup_menu().
2170 (bookmarks_check_add_sensitivity): Also set the sensitivity of the
2171 popup menu item. Correctly handle the case for a *single* file.
2173 (bookmarks_add_selected_folder): New helper function; code moved
2174 over from add_bookmark_button_clicked_cb().
2175 (add_bookmark_button_clicked_cb): Use the function above.
2176 (selection_check): Rather than returning a boolean value for
2177 emptiness, actually return the number of selected rows. Also,
2179 (get_selected_path): New helper function.
2181 2004-07-29 Anders Carlsson <andersca@gnome.org>
2183 * demos/gtk-demo/Makefile.am:
2184 * demos/gtk-demo/clipboard.c: (copy_button_clicked),
2185 (paste_received), (paste_button_clicked), (do_clipboard):
2188 2004-07-28 Federico Mena Quintero <federico@ximian.com>
2190 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
2191 Store signal IDs in gulongs, not guints!
2192 (gtk_file_chooser_default_hierarchy_changed): We now monitor the
2193 focus widget on our toplevel to know which widget was last focused
2194 at the time our "should_respond" method gets called.
2195 (shortcuts_activate_selected): New helper function.
2196 (shortcuts_get_selected): New helper function.
2197 (remove_selected_bookmarks): Use shortcuts_get_selected().
2198 (bookmarks_check_remove_sensitivity): Likewise.
2199 (shortcuts_reorder): Likewise.
2200 (shortcuts_activate_iter): Renamed from shortcuts_activate_item().
2201 Activate by iter, not by item number.
2202 (save_folder_combo_changed_cb): Use shortcuts_activate_iter().
2203 (shortcuts_row_activated_cb): Likewise.
2204 (gtk_file_chooser_default_should_respond): If the last focused
2205 widget on the toplevel was the shortcuts list, activate the
2208 2004-07-28 Matthias Clasen <mclasen@redhat.com>
2210 * gdk/linux-fb/gdkprivate-fb.h: Make the fb backend compile against
2211 current freetype. (#148558, Nicolas Deves)
2213 * gtk/gtktreeview.c: Replace the EXPANDER_MAX macro by
2214 ROW_HEIGHT. (#145528)
2216 * gtk/gtkuimanager.c: Warning fixes.
2218 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_background): Fix
2219 prototype mismatch. (#148589, Nicolas Deves)
2221 2004-07-28 Anders Carlsson <andersca@gnome.org>
2223 * gdk/x11/gdkdrawable-x11.c (gdk_draw_rectangle_alpha_libgtk_only):
2224 Cast to 32-bit integers when premultiplying, suggested by Keith Packard.
2226 2004-07-27 Anders Carlsson <andersca@gnome.org>
2228 * demos/gtk-demo/iconview.c: (do_iconview):
2229 Change selection mode to multiple.
2231 * gdk/gdkdrawable.h:
2232 * gdk/linux-fb/gdkdrawable-fb2.c:
2233 (gdk_draw_rectangle_alpha_libgtk_only):
2234 * gdk/win32/gdkdrawable-win32.c:
2235 (gdk_draw_rectangle_alpha_libgtk_only):
2236 * gdk/x11/gdkdrawable-x11.c: (gdk_x11_draw_image),
2237 (get_impl_drawable), (gdk_x11_draw_pixbuf),
2238 (gdk_draw_rectangle_alpha_libgtk_only):
2239 Add gdk_draw_rectangle_alpha_libgtk_only which uses
2240 XRenderFillRectangle on X11. It's stubbed out on the
2241 Win32 and fb backends.
2243 * gtk/gtkiconview.c:
2244 (gtk_icon_view_paint_rubberband):
2245 Use gdk_draw_rectangle_alpha_libgtk_only here.
2247 2004-07-27 Anders Carlsson <andersca@gnome.org>
2249 * gtk/gtkaboutdialog.c: (gtk_about_dialog_init),
2250 (text_view_style_set), (add_credits_page),
2251 (display_credits_dialog), (display_license_dialog):
2252 Remove dialog separators, fix text view background setting,
2253 use Close buttons instead of OK buttons.
2255 2004-07-27 Matthias Clasen <mclasen@redhat.com>
2257 * gtk/gtktreeview.c (gtk_tree_view_ensure_interactive_directory):
2258 Add a frame around the C-f popup to stop it from merging visually
2259 in whatever is underneath.
2261 * gtk/gtkcombobox.h:
2262 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible): New
2263 function necessary to make GtkComboBox accessible. (#132847,
2266 Tue Jul 27 02:34:06 2004 Matthias Clasen <maclas@gmx.de>
2268 * gtk/gtkwidget.c (gtk_widget_dispose): Hide parentless
2269 windows when disposing them. (#133231, Michael Natterer)
2271 2004-07-26 Matthias Clasen <mclasen@redhat.com>
2273 * gtk/gtklabel.c (gtk_label_class_init): Expand the documentation
2274 for GtkLabel::ellipsize.
2276 Mon Jul 26 00:38:27 2004 Matthias Clasen <maclas@gmx.de>
2278 Make the GtkComboBox in list mode scroll if the list is too
2279 large to fit in the popup. (#135543)
2281 * gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Add a
2282 o scrolled window to the popup in list mode.
2283 (gtk_combo_box_list_position): Calculate the height of the
2284 popup so that it fits on the screen, set the scrollbar policy
2285 of the scrolled window appropriately.
2286 (gtk_combo_box_popup): Use the height calculated by
2287 gtk_combo_box_list_position().
2288 (gtk_combo_box_remeasure): Don't add unnecessary padding.
2289 (gtk_combo_box_size_request): But add the focus with here.
2290 (gtk_combo_box_list_setup): Connect to enter notify on the
2291 popup window to activate auto scrolling.
2292 (gtk_combo_box_list_enter_notify): Activate auto scrolling.
2293 (gtk_combo_box_list_button_pressed): Setup a timeout for
2295 (gtk_combo_box_list_scroll_timeout): Timeout function for
2297 (gtk_combo_box_list_auto_scroll): Scroll the list when the
2298 pointer leaves the window.
2300 Sun Jul 25 19:51:17 2004 Matthias Clasen <maclas@gmx.de>
2302 * gtk/gtknotebook.c (gtk_notebook_scroll): Ignore scroll
2303 events from the content of the page. (#148409, Gabriel
2306 Sat Jul 24 21:38:12 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2308 * gtk/gtktoolbar.c (internal_insert_element): Warn if you try to
2309 add a tool item to a toolbar using the deprecated API.
2311 Fri Jul 23 13:04:10 2004 Matthias Clasen <maclas@gmx.de>
2313 * gtk/gtkdnd.c (gtk_drag_dest_set): Revert the change to
2314 initialize target_list to an empty list instead of NULL,
2315 since it broke tree dnd. (#148215, Ernst Persson)
2317 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
2318 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): Instead
2319 handle target list being NULL here.
2321 2004-07-23 Dafydd Harries <daf@muse.19inch.net>
2323 * gtk/gtkradioaction.c:
2324 * gtk/gtkradiobutton.c:
2327 Improve various translatable messages. (#137616)
2329 Fri Jul 23 11:11:10 2004 Matthias Clasen <maclas@gmx.de>
2331 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
2332 Align the entry in the same way as the cell. (#136749)
2334 Fri Jul 23 11:01:00 2004 Matthias Clasen <maclas@gmx.de>
2336 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
2337 Don't iterate too far up. (#147965, Olivier Sessink)
2339 Fri Jul 23 10:28:43 2004 Matthias Clasen <maclas@gmx.de>
2341 * gtk/gtktreeview.c (gtk_tree_view_finalize):
2342 * gtk/gtkradioaction.c (gtk_radio_action_finalize):
2343 * gtk/gtkfontsel.c (gtk_font_selection_finalize):
2344 * gtk/gtkcellview.c (gtk_cell_view_finalize):
2345 * gtk/gtkcalendar.c (gtk_calendar_finalize):
2346 * gtk/gtkactiongroup.c (gtk_action_group_finalize): Remove
2347 unnecessary checks. (#148175, Morten Welinder)
2349 Thu Jul 22 01:42:16 2004 Matthias Clasen <maclas@gmx.de>
2351 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
2352 Add a new :ellipsize property which controls ellipsization of the
2353 rendered text. (#144835, Vincent Untz, patch by Jonathan Blandford
2354 and Anders Carlsson)
2356 * gtk/gtkfilechooserdefault.c (create_file_list): Use ellipsization
2357 for the name column.
2359 Thu Jul 22 01:21:28 2004 Matthias Clasen <maclas@gmx.de>
2361 * gtk/gtkfontsel.c (gtk_font_selection_init): Add additional
2362 accessability relations. (#141804, Padraig O'Briain)
2364 Thu Jul 22 01:16:23 2004 Matthias Clasen <maclas@gmx.de>
2366 * gtk/gtkcombobox.c: Avoid some warnings.
2368 Thu Jul 22 01:05:16 2004 Matthias Clasen <maclas@gmx.de>
2370 * configure.in: Require Pango 1.5.1 (for ellipsisation).
2373 * gtk/gtklabel.c (gtk_label_class_init): Add a new :ellipsize
2374 property which controls ellipsization of the label. (#125250,
2375 Tim Van Wassenhove, patch by James M. Cape)
2377 * tests/testellipsise.c: Simple test for ellipsizsation.
2379 Wed Jul 21 22:46:27 2004 Matthias Clasen <maclas@gmx.de>
2381 * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
2382 list store. (#148134, Crispin Flowerday)
2384 Wed Jul 21 22:35:47 2004 Matthias Clasen <maclas@gmx.de>
2386 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
2387 menu. (#148110, Tommi Komulainen)
2389 Wed Jul 21 22:24:10 2004 Matthias Clasen <maclas@gmx.de>
2391 * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak
2392 tree model and tree row reference. (#148125, Crispin Flowerday)
2394 Wed Jul 21 22:17:06 2004 Matthias Clasen <maclas@gmx.de>
2396 * tests/testcombo.c (main): Don't leak models. (#148128,
2399 Wed Jul 21 21:26:08 2004 Matthias Clasen <maclas@gmx.de>
2401 * gtk/gtkviewport.c (viewport_set_adjustment): Don't leak
2402 the adjustments. (#148089, Tommi Komulainen)
2404 Wed Jul 21 21:20:21 2004 Matthias Clasen <maclas@gmx.de>
2406 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't leak
2407 the adjustments. (#148073, Tommi Komulainen)
2409 Wed Jul 21 21:04:50 2004 Matthias Clasen <maclas@gmx.de>
2411 * gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the
2412 arrow. (#148064, Tommi Komulainen)
2414 2004-07-21 Matthias Clasen <mclasen@redhat.com>
2416 * gtk/gtkcalendar.c: Use the new text target functionality
2417 in GtkTargetList instead of hardcoding a subset of text targets.
2419 Tue Jul 20 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
2421 * gdk/x11/gdkevents-x11.c: Hook up gtk-menu-bar-accel to
2422 an XSetting, Gtk/MenuBarAccel. (#120859, Scott James Remnant)
2424 Tue Jul 20 22:26:29 2004 Matthias Clasen <maclas@gmx.de>
2426 * gtk/gtkfilechooserutils.h:
2427 * gtk/gtktoolbutton.c:
2429 * gtk/gtkicontheme.c:
2430 * gtk/gtkcalendar.c:
2431 * demos/gtk-demo/ui_manager.c:
2432 * demos/gtk-demo/appwindow.c: Remove trailing commas
2433 from enumerations. (#148035)
2435 2004-07-20 Federico Mena Quintero <federico@ximian.com>
2437 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Fix the
2438 documentation comment for the editing-started signal.
2440 * gtk/gtkmarshalers.list: Added VOID:OBJECT,STRING for
2441 GtkCellRenderer::editing-started.
2443 2004-07-20 Matthias Clasen <mclasen@redhat.com>
2445 * tests/testactions.c (main):
2446 * tests/testmerge.c (main): Add some refcount debugging.
2448 * gtk/gtkuimanager.c (update_node, free_node): Ref an sink
2449 all proxies, so that we can properly clean up floating proxies
2450 which the app didn't adopt. (#147926, Tommi Komulainen)
2452 2004-07-20 Matthias Clasen <mclasen@redhat.com>
2454 Allow custom initialization of cell editables. (#147221)
2456 * gtk/gtkcellrenderer.h (struct _GtkCellRendererClass):
2457 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Add a
2458 ::editing-started signal as a hook for setting up the
2460 (gtk_cell_renderer_start_editing): ...and emit it here.
2462 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
2464 * gtk/gtktreeview.c (gtk_tree_view_button_press): Set drag_pos
2465 before grabbing the focus, since we may reenter into
2466 gtk_tree_view_motion_resize_column() which requires drag_pos
2467 to be set. (#147913, Guilherme Salgado, patch by John Finlay)
2469 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
2471 * gtk/gtktreeview.c (gtk_tree_view_enter_notify): Don't
2472 use uninitialized node pointer. (#147911, Peter Zelezny)
2474 Tue Jul 20 04:34:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2476 * configure.in: Bump version number
2478 Sun Jul 18 17:21:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2480 * === Released 2.5.0 ===
2484 * tests/testcombo.c: Fix compilation
2486 2004-07-19 Matthias Clasen <mclasen@redhat.com>
2488 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_popup_completion):
2491 2004-07-19 Matthias Clasen <mclasen@redhat.com>
2493 Make GtkCellView public, since people seem to have uses for it,
2494 it is clean API and we were just conservative in not making it
2495 public initially. At the same time, get rid of GtkCellViewMenuItem,
2496 which doesn't have any function which can't be served by a
2497 GtkMenuItem with a GtkCellView child. (#136637, Padraig O'Briain)
2499 * gtk/gtk.h: Include gtkcellview.h
2501 * gtk/Makefile.am (gtk_public_h_sources):
2503 * gtk/Makefile.am (gtk_private_h_sources):
2504 (gtk_c_sources): Remove gtkcellviewmenuitem.[hc]
2505 * gtk/gtkcombobox.c: Replace all uses of GtkCellViewMenuItem by
2506 GtkMenuItem with a GtkCellView child.
2508 * gtk/gtkcellviewmenuitem.[hc]: Removed.
2510 2004-07-19 Matthias Clasen <mclasen@redhat.com>
2512 Support inline autocompletion in entries (#135953)
2514 * gtk/gtkentryprivate.h:
2515 * gtk/gtkentrycompletion.h:
2516 * gtk/gtkentrycompletion.c (gtk_entry_completion_class_init):
2517 Add a new signal ::insert-prefix which can be used to override
2518 the default inline-completion behaviour. Add two new boolean
2519 properties, :popup_completion and :inline_completion which
2520 determine how the possible completions should be presented.
2521 (gtk_entry_completion_insert_prefix): New function to request
2524 * gtk/gtkentry.c: Add the necessary glue for inline completion.
2526 Sun Jul 18 15:28:24 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2528 * gtk/gtkdnd.c (gtk_drag_source_set, gtk_drag_dest_set): Create an
2529 empty target list if targets is NULL.
2531 * configure.in: Add check for X11/extensions/sync.h. (#147416,
2534 Sun Jul 18 01:24:31 2004 Matthias Clasen <maclas@gmx.de>
2536 * NEWS: Updates for 2.5.0
2538 Sat Jul 17 23:11:04 2004 Matthias Clasen <maclas@gmx.de>
2540 * gtk/gtkiconview.h:
2541 * gtk/gtkiconview.c (gtk_icon_view_class_init):
2542 * gtk/gtkiconview.c (gtk_icon_view_set_orientation):
2543 * gtk/gtkiconview.c (gtk_icon_view_get_orientation):
2544 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
2545 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row):
2546 Add a new :orientation property to determine whether text
2547 is positioned below or beside icons. (#147463)
2549 Sat Jul 17 23:03:30 2004 Matthias Clasen <maclas@gmx.de>
2551 * gtk/gtkiconview.c (gtk_icon_view_paint_item):
2552 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
2553 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row): Draw
2554 focus indicator outside the selection, respect focus
2555 line width. (#147460)
2557 Sat Jul 17 01:17:33 2004 Matthias Clasen <maclas@gmx.de>
2559 * gdk/x11/gdkdnd-x11.c (xdnd_check_dest): Fix a warning
2562 Sat Jul 17 00:48:27 2004 Matthias Clasen <maclas@gmx.de>
2564 Support text/plain selection target (#55117, Owen Taylor)
2566 * gtk/gtkselection.h:
2568 * gtk/gtkselection.c (gtk_target_list_add_text_targets):
2569 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
2570 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): New
2571 functions to facilitate handling of text targets.
2574 * gtk/gtktextview.c: Use the new text target handling
2575 functions instead of hardwiring the list of supported
2576 text targets everywhere.
2578 * gtk/gtkselection.c (gtk_selection_data_get_text):
2579 (gtk_selection_data_set_text):
2580 Support the targets text/plain, text/plain?charset=utf-8
2581 and text/plain?charset=<LOCALE-CHARSET> as outlined in
2583 For text/plain send only ASCII, but accept 8-bit text
2584 and treat it as ISO-8859-1 as specified by the Xdnd spec.
2585 Always send CRLF terminators. Accept either and convert
2586 into the native terminator for the platform.
2588 Fri Jul 16 23:20:34 2004 Matthias Clasen <maclas@gmx.de>
2590 Support themed window icons. (#92346, Calum Benson)
2592 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): New
2593 function to obtain information about the sizes in which an
2597 * gtk/gtkwindow.c (gtk_window_class_init):
2598 (gtk_window_set_icon_name):
2599 (gtk_window_get_icon_name): Add an "icon_name" property
2600 (gtk_window_set_default_icon_name): ...and a default icon name.
2601 (icon_list_from_theme):
2602 (update_themed_icon): New auxiliary functions to create a
2603 list of all available sizes of a themed icon and update the
2604 window icon list from it.
2606 2004-07-16 Matthias Clasen <mclasen@redhat.com>
2608 * gtk/gtkcombobox.c (gtk_combo_box_scroll_event): Make
2609 scrolling work if no item is selected.
2610 (gtk_cell_editable_key_press): Don't eat space.
2612 Add a combo box cell renderer (#139347, Lorenzo Gil Sanchez)
2614 * gtk/gtkcellrenderercombo.[hc]: New Files.
2617 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
2620 * gtk/gtkcombobox.[hc]: Implement GtkCellEditable, add a
2621 :has-frame property for suppressing the frame around
2622 the child and redo the size allocation logic to take
2623 focus width into account.
2625 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_init):
2626 Acknowledge the GtkComboBox:has-frame property and make
2627 the entry fill its allocation vertically.
2629 * gtk/gtkmarshalers.list: Add BOOLEAN:STRING.
2631 * gtk/gtktreeview.c (gtk_tree_view_remove_widget): Queue
2632 a draw here to keep non-widget windows from leaving
2635 2004-07-16 Matthias Clasen <mclasen@redhat.com>
2637 * gtk/gtkcombobox.c (gtk_combo_box_forall): Don't iterate
2638 multiple times over some of the children.
2640 Thu Jul 15 22:19:40 2004 Matthias Clasen <maclas@gmx.de>
2642 Fix #60128, #58307, #144706:
2644 * gtk/gtkstyle.c (gtk_style_real_copy): Handle references
2645 to bg_pixmaps properly.
2646 (gtk_style_real_unrealize): Don't keep dangling references
2648 (gtk_style_attach): Split the loop into two loops, first
2649 looking for a matching style, then for an empty one.
2650 (gtk_style_finalize):
2651 (gtk_style_duplicate): Add comments explaining the handling
2654 Thu Jul 15 20:31:28 2004 Matthias Clasen <maclas@gmx.de>
2656 * gtk/gtkspinbutton.c (start_spinning): Install the timeout
2657 before changing the value, so that a ::value_changed handler
2658 has a chance to remove it. (#122427, Elke Meier)
2660 Thu Jul 15 19:20:05 2004 Matthias Clasen <maclas@gmx.de>
2662 * gdk/x11/gdkgtk+/im-x11.c (_gdk_x11_initialize_locale):
2663 * gtk/gtkcalendar.c (gtk_calendar_class_init): Use 'cannot'
2664 instead of 'can not' in messages. (#144226, Morten Welinder)
2666 2004-07-15 Matthias Clasen <mclasen@redhat.com>
2668 * gtk/gtktreeview.c (gtk_tree_view_class_init):
2669 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
2670 Correct the declared default values of several properties
2671 to be in sync with the actual initial values.
2673 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_class_init):
2674 Make spacing a property, correct the declared default values
2675 of several properties to be in sync with the actual initial
2676 values. (#147654, Matthias Clasen)
2678 * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Don't reparent
2679 back to menu->toplevel if it is already gone because we're
2680 shutting down. (#147656, John Cupitt)
2682 2004-07-14 Federico Mena Quintero <federico@ximian.com>
2686 * gtk/gtktreeview.c (gtk_tree_view_bin_expose): Draw a focus
2687 indicator along the edge of the bin_window when the tree is empty.
2688 (grab_focus_and_unset_draw_keyfocus): New helper function.
2689 (gtk_tree_view_button_press): Remove a bit of superfluous code.
2690 Use the helper function to save on duplicated code.
2691 (gtk_tree_view_button_press): Grab the focus if the tree is empty.
2692 (gtk_tree_view_focus): Allow focusing into an empty tree.
2694 2004-07-14 Matthias Clasen <mclasen@redhat.com>
2696 * gtk/gtkaboutdialog.c (add_credits_page): Don't use
2697 gcc extensions for the ternary ?: operator. (#147590,
2700 2004-07-14 Federico Mena Quintero <federico@ximian.com>
2702 Fix #144405, patch by Padraig O'Briain <padraig.obriain@sun.com>:
2704 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): Set the
2705 accessible object name for the tree view.
2706 (create_file_list): Likewise.
2708 Tue Jul 13 21:53:08 2004 Matthias Clasen <maclas@gmx.de>
2710 * gtk/gtkicontheme.c (free_unthemed_icon): Don't leak
2711 no_svg_filename. (#147399, Kjartan Maraas)
2713 2004-07-13 Matthias Clasen <mclasen@redhat.com>
2715 * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_get_neighbor_sizes):
2716 Make this work in RTL context.
2718 2004-07-13 Federico Mena Quintero <federico@ximian.com>
2720 * gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Set a
2721 busy cursor while mounting the volume. Also, ref the chooser
2722 while mounting, as we may re-enter. Fixes #139376.
2724 2004-07-13 Matthias Clasen <mclasen@redhat.com>
2726 * gtk/gtktreeview.c (gtk_tree_view_adjustment_changed):
2727 Prepare to handle composite implementations of
2728 GtkCellEditable, but recursively poking at
2729 allocation->y (hack stolen from GtkCList).
2730 (check_expander_max): Tweak the warning.
2732 * gtk/gtkmain.h: Add gtk_parse_args(), its a public
2733 function. (#147476, Owen Taylor)
2735 * gtk/gtkcombobox.c (gtk_combo_box_popdown): Don't
2736 crash if unrealized.
2738 Tue Jul 13 01:50:06 2004 Matthias Clasen <maclas@gmx.de>
2740 * gtk/gtkaboutdialog.c (display_credits_dialog): Don't
2741 display untranslated translator credits.
2743 Tue Jul 13 01:15:05 2004 Matthias Clasen <maclas@gmx.de>
2745 * gtk/gtkiconview.c: Some documentation updates.
2747 Tue Jul 13 00:40:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2749 * gdk/gdkwindow.c (gdk_window_process_updates_internal): Do an
2750 empty begin_paint_region()/end_paint() for windows without
2753 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_unset_bg,
2754 _gdk_x11_window_tmp_reset_bg): Remove checks for EXPOSURE_MASK.
2756 2004-07-12 Matthias Clasen <mclasen@redhat.com>
2758 * demos/gtk-demo/appwindow.c: Use a GtkAboutDialog.
2760 * gtk/gtkaboutdialog.h:
2761 * gtk/gtkaboutdialog.c: New widget: GtkAboutDialog.
2763 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
2764 * gtk/gtk.h: Add GtkAboutDialog. (#109435, Paolo Borelli,
2765 patch by Matthias Clasen)
2767 * gtk/gtkrc.c (_gtk_rc_init): Apply the gtk-default-menu-item-style
2768 to cell view menu items as well. (#147405, John Cupitt)
2770 * gtk/gtkentrycompletion.c: Warning fixes. (#147420,
2773 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Pop down
2774 first. (#147399, John Cupitt)
2776 Mon Jul 12 01:56:26 2004 Matthias Clasen <maclas@gmx.de>
2778 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
2779 Include the update_counter check in the HAVE_XSYNC condition,
2780 since update_counter isn't present in the !HAVE_XSYNC case.
2782 Mon Jul 12 00:52:04 2004 Matthias Clasen <maclas@gmx.de>
2784 * gtk/stock-icons/Makefile.am:
2785 * gtk/stock-icons/stock_about_{16,24}.png:
2786 * gtk/stock-icons/stock_connect_{16,24}.png:
2787 * gtk/stock-icons/stock_disconnect_{16,24}.png:
2788 * gtk/stock-icons/stock_edit_{16,24}.png:
2789 * gtk/stock-icons/stock_media_forward_{16,24}.png:
2790 * gtk/stock-icons/stock_media_next_{16,24}.png:
2791 * gtk/stock-icons/stock_media_pause_{16,24}.png:
2792 * gtk/stock-icons/stock_media_play_{16,24}.png:
2793 * gtk/stock-icons/stock_media_previous_{16,24}.png:
2794 * gtk/stock-icons/stock_media_record_{16,24}.png:
2795 * gtk/stock-icons/stock_media_rewind_{16,24}.png:
2796 * gtk/stock-icons/stock_media_stop_{16,24}.png:
2797 * gtk/gtkstock.h (GTK_STOCK_ABOUT):
2798 * gtk/gtkstock.h (GTK_STOCK_CONNECT):
2799 * gtk/gtkstock.h (GTK_STOCK_DISCONNECT):
2800 * gtk/gtkstock.h (GTK_STOCK_EDIT):
2801 * gtk/gtkstock.h (GTK_STOCK_MEDIA_FORWARD):
2802 * gtk/gtkstock.h (GTK_STOCK_MEDIA_NEXT):
2803 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PAUSE):
2804 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PLAY):
2805 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PREVIOUS):
2806 * gtk/gtkstock.h (GTK_STOCK_MEDIA_RECORD):
2807 * gtk/gtkstock.h (GTK_STOCK_MEDIA_REWIND):
2808 * gtk/gtkstock.h (GTK_STOCK_MEDIA_STOP):
2809 * gtk/gtkiconfactory.c (get_default_icons):
2810 * gtk/gtkstock.c (builtin_items): Add a number of new stock
2811 items. (#102530, #68015, #109811, Jordi Mallach, Benjamin Otte,
2814 Sun Jul 11 15:24:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2816 Bug 143330, support update counter spec.
2818 * configure.in: Add check for the Sync extension
2820 * gdk/gdkwindow.h: gdk_window_enable_synchronized_configure() and
2821 gdk_window_configure_finished()
2823 * gtk/gtkwindow.c (gtk_window_move_resize): Call gdk_window_finish_configure().
2824 * gtk/gtkwindow.c (gtk_window_realize): Automatically enable
2825 synchronized configures.
2827 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Store current
2828 and pending counter values.
2830 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): New function.
2831 * gdk/x11/gdkwindow-x11.c
2832 (gdk_window_enable_synchronized_configure): New function.
2833 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
2834 Delete update counter.
2835 * gdk/x11/gdkwindow-x11.c (set_wm_protocols): Advertise
2836 _NET_WM_SYNC_REQUEST when Sync is available
2838 * gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Handle
2839 _NET_WM_SYNC_REQUEST messages
2840 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Save counter
2841 value for use by gdk_window_configure_finished() when receiving
2844 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add use_sync flag
2845 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Check if the XSync
2846 extension is available
2847 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_SYNC_REQUEST and
2848 _NET_WM_SYNC_REQUEST_COUNTER to list of supported atoms.
2850 * gdk/linux-fb/gdkwindow-fb.c, gdk/win32/gdkwindow-win32.c: Add
2851 stubs for enable_synchronized_configure() and configure_finished()
2853 Sat Jul 10 23:35:13 2004 Matthias Clasen <maclas@gmx.de>
2855 * gtk/gtkentry.c (paste_received): Make middle-button pasting
2856 work as expected inside the entry. (#116789, Scott Bronson)
2858 Sat Jul 10 22:13:53 2004 Matthias Clasen <maclas@gmx.de>
2860 * gtk/gtktextbuffer.c (gtk_text_buffer_select_range): Update
2861 clipboards. (#142805, Mikael Hallendal)
2863 Sun Jul 11 01:38:48 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2865 * gtk/gtkpaned.c (gtk_paned_expose): Remove clip-region computing
2866 code. Just use &paned->handle_pos.
2868 Sun Jul 11 01:12:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2872 * gtk/gtknotebook.c (gtk_notebook_size_allocate): Remove an
2873 unnecessary redraw..
2875 * gtk/gtknotebook.c (gtk_notebook_page_allocate): Remove some
2878 Sat Jul 10 01:33:25 2004 Matthias Clasen <maclas@gmx.de>
2880 * docs/RELEASE-HOWTO: Updates.
2882 Sat Jul 10 01:55:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2884 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{re|un}set_bg):
2885 Insert checks for root window. The root window is never mapped.
2887 Sat Jul 10 01:06:05 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2889 * gdk/x11/gdkwindow-x11.c (post_unmap): Fix a warning
2890 * gdk/x11/gdkwindow-x11.c (show_window_internal): Actually unset
2893 Sat Jul 10 00:37:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2897 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{un|re}set_bg):
2898 New functions that can do a recursive unset/reset bg.
2900 * gdk/x11/gdkgeometry-x11.c: Remove
2901 gdk_window_tmp_{un|re}set_bg().
2903 * gdk/x11/gdkwindow-x11.c (pre_unmap, post_unmap): New functions
2904 called before and after unmapping a window. They unset the
2905 background of all other windows to prevent flicker from the X
2906 server repainting the background. post_unmap() also invalidates
2907 the parent of the unmapped window to draw it without roundtrips.
2909 * gdk/x11/gdkwindow-x11.c (show_window_internal): Unset
2910 background of newly mapped windows and all desendants to prevent
2913 Fri Jul 9 15:33:55 2004 Manish Singh <yosh@gimp.org>
2915 * gdk/gdkevents.c: have a dummy case GDK_OWNER_CHANGE in switch
2916 statements to avoid gcc warnings about not all enum values handled.
2918 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): ignore should live in
2921 Fri Jul 9 23:26:09 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2925 * gdk/x11/gdkwindow-x11.h (struct _GdkWindowImplX11): Add an
2926 "override_redirect" bit.
2928 * gdk/x11/gdkwindow-x11.c (gdk_window_new): Set it here.
2930 * gdk/x11/gdkwindow-x11.c (gdk_window_move, gdk_window_resize,
2931 gdk_window_move_resize):
2932 Update the local size/position cache
2933 immediately for override redirect windows.
2935 * gdk/x11/gdkwindow-x11.c (show_window_internal): Invalidate
2936 newly mapped child and override redirect windows.
2938 2004-07-09 Federico Mena Quintero <federico@ximian.com>
2942 * gtk/gtkfilesystemunix.c (get_fallback_icon): New helper
2943 function, fetches a stock icon as a fallback.
2944 (gtk_file_system_unix_volume_render_icon): Fall back to a stock
2946 (gtk_file_system_unix_render_icon): Fall back to a stock icon.
2947 Use helper functions rather than being a mega-function.
2948 (get_icon_name_for_directory): Renamed from
2949 get_icon_for_directory().
2950 (get_icon_type_from_path): New helper function; code pulled out
2951 from gtk_file_system_unix_render_icon().
2952 (get_special_icon): Likewise.
2953 (get_icon_for_mime_type): Likewise.
2955 2004-07-09 Federico Mena Quintero <federico@ximian.com>
2957 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Fix typo; tmp_event ->
2960 2004-07-09 Matthias Clasen <mclasen@redhat.com>
2962 * gtk/gtktooltips.c (gtk_tooltips_paint_window): Use the
2963 requisition of the widget instead of relying on the style
2964 drawing function to supply the size of the drawable. (#146531)
2966 2004-07-09 Matthias Clasen <mclasen@redhat.com>
2968 Make GtkEntry work harder to protect passwords: (#143955,
2971 * gtk/gtkentry.c (gtk_entry_destroy): Add a destroy handler
2972 to clear the password even if the widget is leaked.
2974 * gtk/gtkentry.c (gtk_entry_real_delete_text):
2975 * gtk/gtkentry.c (gtk_entry_finalize): Zero out the memory
2978 * gtk/gtkentry.c (gtk_entry_real_insert_text): Zero and free
2979 the old memory instead of just reallocating it.
2981 * gtk/gtkentry.c (gtk_entry_create_layout): Don't leak text
2982 direction information for passwords.
2984 2004-07-09 Matthias Clasen <mclasen@redhat.com>
2986 * gtk/gtkstyle.c: Fix some cases where style functions were
2987 not handling widget == NULL properly. (#146282)
2989 Thu Jul 8 22:38:58 2004 Matthias Clasen <maclas@gmx.de>
2991 * gtk/gtktreeview.c: Improve the EXPANDER_MAX warning.
2993 2004-07-08 Federico Mena Quintero <federico@ximian.com>
2997 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Add a
2998 GError argument. Do check for errors when getting the
2999 GtkFileFolder: get the folder and read the children before
3000 actually creating the model. Removed obsolete code that handled
3001 roots-changed on the file system.
3002 (file_model_node_get_info): Assert that we don't reach the old
3003 case to display file system roots.
3004 (roots_changed_callback): Removed.
3006 * gtk/gtkfilechooserdefault.c (set_list_model): Add a GError
3007 argument, and a boolean return value. Return an error if we
3008 cannot create the file system model. On error, set a NULL model
3010 (gtk_file_chooser_default_set_current_folder): Use the error value
3011 from set_list_model().
3012 (gtk_file_chooser_default_set_property): Set the show_hidden
3013 property only if the browse_files_model exists.
3014 (gtk_file_chooser_default_unselect_path): Only operate if the
3015 browse_files_model exists.
3016 (check_preview_change): Check whether we have the sort_model.
3017 (change_folder_and_display_error): Copy the path we get passed
3018 before using it. There's a comment in there that explains why we
3019 need to copy it; basically, if the passed path belongs to the
3020 model, the model may go away in the middle of this function and
3021 we'll be left with a dangling pointer.
3022 (install_list_model_filter): Assert that the model is not NULL.
3023 (set_current_filter): Check whether the model exists.
3025 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Don't
3026 g_return_if_fail if the model is NULL.
3027 (gtk_tree_selection_get_selected_rows): Likewise.
3028 (gtk_tree_selection_count_selected_rows): Likewise.
3029 (gtk_tree_selection_selected_foreach): Likewise.
3030 (gtk_tree_selection_path_is_selected): Likewise; rather just
3032 (gtk_tree_selection_select_all): Likewise.
3033 (gtk_tree_selection_unselect_all): Likewise.
3034 (gtk_tree_selection_select_range): Do g_return_if_fail() if the
3036 (gtk_tree_selection_unselect_range): Likewise.
3038 * gtk/gtkfilesystemunix.c (fill_in_names): Return immediately if
3039 g_dir_open() fails: there is no need to set the error ourselves,
3040 as g_dir_open() already does it.
3042 2004-07-08 Matthias Clasen <mclasen@redhat.com>
3044 * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Allow
3045 to restore the default search function. (#145365, John Finlay)
3047 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Don't leak
3048 references to the drag context. (#144324, Alex Larsson)
3050 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
3052 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
3053 when a new model is set. (#145566, Dmitry M. Shatrov)
3055 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
3057 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
3058 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
3059 in order to avoid rendering artifacts from misaligned
3060 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
3062 2004-07-07 Matthias Clasen <mclasen@redhat.com>
3064 * gtk/gtktreeview.c:
3065 * gtk/gtktreeview.h: Small documentation fixes.
3067 2004-07-07 Matthias Clasen <mclasen@redhat.com>
3069 Support separators in combo boxes and more generally in tree
3072 * gtk/gtkcombobox.h:
3073 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
3074 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
3075 Add a ::row-separator-column property with getter and setter,
3076 which can indicate a boolean model column to determine which
3077 rows are separators.
3079 * gtk/gtkcombobox.c: Display separator rows as separator menu
3080 items in menu mode, and by using the new treeview separator
3081 functionality in list mode.
3083 * gtk/gtktreeview.h:
3084 * gtk/gtktreeprivate.h:
3085 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
3086 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
3087 Add a callback to determine whether a row is a separator.
3089 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
3090 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
3091 * gtk/gtktreeview.c (validate_row): Use the new callback
3092 to determine whether a row is a separator, and draw it
3093 as a separator then. Since separators should take up less
3094 vertical space than regular rows, this requires removing
3095 the redundant MAX(...,expander_size) calls which appear in
3096 many places. Instead, the MAX() is now only done in
3097 validate_row(), and only if the row is not a separator.
3098 To catch possible side effects of this intrusive change,
3099 I have left EXPANDER_MAX() calls in place of the MAX() calls
3100 which will emit a warning if something breaks. They should
3101 be removed before 2.6.
3103 * gtk/gtktreeselection.c (row_is_selectable): Don't let
3104 separator rows be selected.
3106 * tests/testcombo.c (create_blaat): Add a separator column.
3108 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
3110 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
3111 a 64bit alignment issue. (#144302, Sunil)
3113 2004-07-07 Tor Lillqvist <tml@iki.fi>
3115 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
3116 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
3117 * gdk/win32/gdkproperty-win32.c (find_common_locale,
3118 gdk_property_change)
3119 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
3120 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
3123 * gdk/win32/gdkglobals-win32.c
3124 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
3125 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
3126 atom. Initialize it. Declare it. Drop the variable for the
3129 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
3130 function is supposed to return the string in the locale's charset
3131 and encoding. Use g_convert().
3133 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
3134 string in the locale's charset. Use g_convert().
3136 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
3137 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
3138 GLib's UTF-16 functions instead. Windows uses UTF-16.
3140 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
3141 functions mentioned above.
3143 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
3144 also if the string is of type STRING, i.e. ISO-8859-1, and the
3145 current codepage is 1252, and contains no C1 chars. Accept
3148 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
3149 Mark as static. When storing STRING data, convert to
3151 (gdk_selection_owner_set_for_display): Now that STRING is always
3152 ISO-8859-1, use UTF8_STRING when sending the selection request
3155 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
3158 (gdk_text_property_to_text_list_for_display): Make work more like
3159 X11 version. Do obey the encoding parameter.
3161 (gdk_string_to_compound_text_for_display,
3162 gdk_utf8_to_compound_text_for_display): Don't even pretend
3163 supporting COMPOUND_TEXT.
3165 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
3167 (sanitize_utf8): Zero-terminate string.
3169 2004-07-06 Matthias Clasen <mclasen@redhat.com>
3171 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
3172 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
3174 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
3175 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
3176 fallbacks for gtkfilechooser. Currently these are the same images
3177 as the "new" and "open" items...
3179 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
3181 Fix for #136496, Pawel Salek:
3183 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
3184 a node when it changes in fixed_height mode.
3186 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
3189 2004-07-06 Matthias Clasen <mclasen@redhat.com>
3191 * gtk/gtkmenu.c (gtk_menu_position): Make sure
3192 private->monitor_num is a valid monitor number before
3193 using it. (#139187, Michael Natterer)
3195 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
3197 * gtk/gtkfilechooserdefault.c (popup_position_func):
3198 * gtk/gtkentry.c (popup_position_func):
3199 * gtk/gtktextview.c (popup_position_func): Improve positioning
3200 of keyboard-activated menus with Xinerama.
3202 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
3204 * gtk/gtkuimanager.c (do_updates):
3205 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
3206 when called from an idle handler. (#145429, Jan-Marek Glogowski)
3208 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
3210 * gtk/gtkfilechooserutils.c (delegate_notify): Use
3211 the less efficient g_object_interface_find_property () instead
3212 of the param_id range check, since the GParamSpecs we're
3213 dealing with are the overridden onces on the interface, whose
3214 param_id is always zero. (#145312, Alex Roitman, fix proposed
3217 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
3219 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
3220 virtual method of GtkContainer.
3221 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
3222 method slot of the container class.
3224 2004-07-05 Anders Carlsson <andersca@gnome.org>
3226 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
3227 * gtk/gtkiconview.h:
3228 Use gint, not int in gtk_icon_view_set_markup_column,
3231 2004-07-05 Anders Carlsson <andersca@gnome.org>
3233 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
3234 (gtk_icon_view_real_select_cursor_item),
3235 (gtk_icon_view_real_activate_cursor_item):
3236 * gtk/gtkiconview.h:
3237 Add an "activate_cursor_item" action signal
3238 and bind it to the return key.
3240 2004-07-04 Anders Carlsson <andersca@gnome.org>
3242 * demos/gtk-demo/Makefile.am:
3243 * demos/gtk-demo/gnome-fs-directory.png:
3244 * demos/gtk-demo/gnome-fs-regular.png:
3245 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
3246 (sort_func), (create_store), (item_activated), (up_clicked),
3247 (home_clicked), (do_iconview):
3248 Add a simple file browser based on the icon view.
3251 Add gtk/gtkiconview.h
3253 * gtk/gtkiconview.c: (gtk_icon_view_layout),
3254 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
3255 Fix a few bugs discovered while writing the demo.
3257 2004-07-04 Anders Carlsson <andersca@gnome.org>
3261 * gtk/gtkiconview.h:
3262 Add GtkIconView to the build, remove debugging output.
3264 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
3266 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
3267 (gtk_calendar_drag_data_received): Fix off-by-one error.
3268 GDate month is one-based and GtkCalendar month is zero-based.
3269 (#145134, William Jon McCann)
3271 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
3273 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
3274 somebody tries to move a node after itself in a list of
3275 length 1. (#145291, Sampo Nurmentaus)
3277 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
3279 * docs/faq/gtk-faq.sgml:
3280 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
3283 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
3285 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
3286 and current_height to 0 when ending the embedding. (#143675,
3287 Nickolay V. Shmyrev)
3289 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
3291 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
3292 to the right end of the entry text, even if it ends in combining
3293 marks. (#141728, Theppitak Karoonboonyanan)
3295 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
3297 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
3298 row when unsetting the model. (#138560, Christian Persch)
3300 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
3302 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
3305 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
3307 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
3308 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
3310 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
3312 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
3313 to the event mask, set a scroll_event handler.
3314 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
3315 by switching tabs. (#145244, Gabriel de Perthuis)
3317 2004-07-02 Anders Carlsson <andersca@gnome.org>
3319 * gtk/gtktreeview.c (gtk_tree_view_set_model):
3320 Make sure we check for a NULL model first.
3322 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
3324 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
3325 win32 build problem w/o wintab. Fixed #145242
3327 2004-06-30 Anders Carlsson <andersca@gnome.org>
3329 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
3330 g_return_if_fail to make sure that the model is a GtkTreeModel.
3332 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3334 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
3335 current state, not GTK_STATE_NORMAL
3337 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
3339 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3341 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
3343 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
3345 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
3346 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
3349 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
3351 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
3352 recursion by resetting icon_set->cache before freeing
3353 the cache. (#144947, Tim Janik)
3355 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
3357 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
3358 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
3359 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
3362 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
3364 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
3365 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
3366 last change in the docs.
3368 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
3370 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
3371 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
3372 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
3374 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
3376 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
3377 placement policy for GtkComboBoxEntry to be: if it fits below,
3378 place below, if it fits above place above, else place in the
3379 larger space and scroll so that the scroll arrow appear at the
3380 far end. (#144362, David A. Knight)
3382 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
3384 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
3385 use of &parent_iter. (#145007, John Finlay)
3387 2004-06-25 Bastien Nocera <hadess@hadess.net>
3389 reviewed by: Matthias Clasen <maclas@gmx.de>
3391 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
3392 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
3393 the number of keysyms per keycode is odd. Fixes #144808.
3395 2004-06-25 Matthias Clasen <mclasen@redhat.com>
3397 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
3398 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
3400 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
3402 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
3403 which was mentioned below.
3405 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
3407 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
3408 string change. (#139503, Baris Cicek)
3410 2004-06-22 Federico Mena Quintero <federico@ximian.com>
3412 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
3413 or an Open stock button for the C-l dialog depending on the action
3414 in which the file chooser operates. Fixes #141753.
3416 2004-06-22 Federico Mena Quintero <federico@ximian.com>
3418 Fixes the GTK+ part of #142308:
3420 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
3421 Use filename_to_path().
3422 (gtk_file_system_unix_uri_to_path): Likewise.
3423 (filename_to_path): Use remove_trailing_slash().
3425 2004-06-22 Matthias Clasen <mclasen@redhat.com>
3427 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
3428 for the ::move_cursor signal.
3430 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
3431 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
3434 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
3435 this gets defined for all backends, so linux-fb has a
3436 chance of compiling.
3438 * gdk/x11/gdkgc-x11.c:
3439 * gdk/gdkgc.c: Move function docs inline, add hints about
3440 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
3442 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
3443 for children of the root. (#139785, Jean-François Wauthy,
3444 patch by John Finlay)
3446 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
3447 fix. (#144750, Jeff Franks)
3449 2004-06-21 Michael Natterer <mitch@gimp.org>
3452 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
3453 function public as _gdk_x11_convert_to_format().
3455 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
3456 the pixels from the GdkPixbuf when putting them in the
3457 Xcursor image. Fixes bug #144350.
3459 2004-06-16 Federico Mena Quintero <federico@ximian.com>
3461 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
3462 visible node, free the old path before creating the new one.
3465 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
3467 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
3468 (#144198, Mariano Suárez-Alvarez)
3470 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
3472 * gtk/gtkfilechooserdefault.c: Don't use
3473 contractions like "don't" or "isn't" in error messages.
3474 It isn't nice to use them in log entries either...
3475 (#137774, Morten Welinder, patch by Alexander Winston)
3477 2004-06-11 Federico Mena Quintero <federico@ximian.com>
3481 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
3482 Don't ref the editable node.
3483 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
3484 (_gtk_file_system_model_remove_editable): Ahem, free the node.
3486 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
3487 Added fields for edited_idle and edited_new_text.
3488 (renderer_edited_cb): Queue the
3489 creation of the folder in an idle handler.
3490 (renderer_editing_canceled_cb): Likewise for the cancellation.
3491 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
3493 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
3495 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
3497 2004-06-10 Federico Mena Quintero <federico@ximian.com>
3499 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
3501 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
3502 Refer to gtk_file_chooser_add_shortcut_folder().
3503 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
3504 gtk_file_chooser_add_shortcut_folder_uri().
3506 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
3508 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
3509 the drag before focusing the selected.day.
3510 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
3511 a beginning drag if the widget becomes insensitive.
3513 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
3515 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
3516 spinning before calling arrow_action(), so that a signal
3517 handler triggered from arrow_action() has a chance to
3518 stop the spinning. (#143966, Davyd Madeley)
3520 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
3522 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
3523 typo. (#144070, Kent Sandvik)
3525 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3527 * gtk/gtkmenu.c: Revert the "drag select" part of
3530 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
3532 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
3533 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
3535 2004-06-07 Federico Mena Quintero <federico@ximian.com>
3537 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
3538 from 2003/Sep/12. This kept DnD in tree views within modal
3539 dialogs from working, which is especially bad for the file
3540 chooser. Fixes #135168.
3542 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
3544 Make the entry context menu work in editable text cells. The changes
3545 are based on a patch by Kristian Rietveld, which implemented an
3546 approach outlined by Owen Taylor. (#50075)
3548 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
3549 Ignore focus out if the entry menu is posted.
3550 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
3551 posted, and set up a signal handler to clear the flag if the menu
3553 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
3554 set up a timeout to stop editing if the focus is lost.
3555 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
3556 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
3557 signal on the entry and keep a pointer to the entry.
3558 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
3559 clear the pointer to the entry.
3561 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
3563 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
3564 of the ::language property. (#143802, Owen Taylor)
3566 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
3568 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
3569 (gtk_entry_completion_list_enter_notify),
3570 (gtk_entry_completion_list_motion_notify),
3571 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
3572 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
3573 use it as in the menu code to avoid the initial selection if
3574 the window pops up under the pointer. (Anders Carlsson)
3576 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3578 * tests/testmerge.c: Add a checkbox to queue an
3579 merge/unmerge. Patch from Matthias Clasen.
3581 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
3583 (rebuild_menu): New function that rebuilds the overflow menu and
3584 makes sure it doesn't start or end with a separator.
3585 (toolbar_content_new_tool_item)
3586 (toolbar_content_remove)
3587 (toolbar_content_new_compatibility): Set the rebuild_needed flag
3588 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
3589 have actually overflown an item with a proxy menu item. Also make
3590 sure we rebuild the menu if needed.
3592 Fix #125504, #142377, #143463
3594 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
3595 Obey the "priv->draw" flag. (#143692)
3597 2004-06-04 Matthias Clasen <mclasen@redhat.com>
3599 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
3600 quirk in the button size allocation code.
3602 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
3603 requested for drawing the focus indicator to the child in the
3604 !CAN_FOCUS case. This should fix issues which the Gimp has with
3605 the button allocation changes in 2.4.2.
3607 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
3609 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
3610 length of the entry contents in characters, not in bytes.
3612 * gtk/gtkentry.c (paste_received): Don't pop up the completion
3613 window on paste, noticed by Anders Carlsson.
3615 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
3617 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
3618 values and default value for the ::active property. (#143669,
3621 2004-06-03 Michael Natterer <mitch@gimp.org>
3623 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
3624 instead of accessing item->image->allocation.width/height
3625 directly. Makes widgets which only have a requisition set using
3626 gtk_widget_set_size_request() work and fixes bug #142789.
3628 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3630 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
3631 of sticky right click menus to return.
3633 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3635 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
3636 better handle the "click" case. bug Better fix for #141169.
3638 2004-06-02 Federico Mena Quintero <federico@ximian.com>
3640 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
3641 model is empty. Fixes #143536.
3643 2004-06-02 Matthias Clasen <mclasen@redhat.com>
3645 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
3646 close the dialog on focus out of the size entry. (#143505,
3649 2004-06-02 Federico Mena Quintero <federico@ximian.com>
3653 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
3654 (gtk_fnmatch_intern): Likewise; also implement this option.
3656 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
3658 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
3659 no_leading_period argument of _gtk_fnmatch().
3660 (attempt_file_completion): Likewise.
3662 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
3663 no_leading_period argument of _gtk_fnmatch().
3665 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
3667 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
3670 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
3672 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
3673 allow unless selection mode is multiple. (#142634, John Finlay)
3675 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
3679 * gtk/gtkentrycompletion.h:
3680 * gtk/gtkentrycompletion.c:
3681 * gtk/gtkcombobox.h:
3682 * gtk/gtkcombobox.c: Rename function parameters from
3683 index to index_ to prevent clash with BSD index(). (#143001)
3685 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
3687 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
3688 NULL on an accel label. (#139641, Sam Stephenson, patch by
3691 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
3693 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
3694 lookup finding icons in the wrong prefix. (#143328,
3697 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3701 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
3702 only stay up if you release within 500 milliseconds.
3703 (gtk_menu_shell_button_press): Set the activate_time to the event
3704 time when a button is pressed.
3706 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
3707 Interprete button releases as activate when we have seen both an
3708 enter an a motion event.
3710 2004-06-01 Federico Mena Quintero <federico@ximian.com>
3712 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
3713 dummy node if there is no parent node. Fixes #143362.
3715 2004-05-31 Federico Mena Quintero <federico@ximian.com>
3717 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
3718 newly-created folder. Fixes #138932.
3719 (trap_activate_cb): Only return TRUE if we did handle the event.
3720 Fixes #143359; patch by jylefort@brutele.be.
3722 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
3724 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
3725 docs. (#142892, Tommi Komulainen)
3727 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
3729 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
3730 parent is minimized, porting the fix from 1.2. (#1923, #57182)
3732 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
3734 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
3735 unmapped windows work.
3737 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
3739 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
3742 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
3744 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
3745 Refer to ::update-preview, not ::selection-changed.
3747 2004-05-29 Christian Rose <menthos@menthos.com>
3749 * configure.in: Added "tk" to ALL_LINGUAS.
3751 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
3753 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
3754 messages for common problems. (#137974, Owen Taylor)
3756 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
3758 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
3759 errors. (#143337, Billy Biggs)
3761 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
3763 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
3764 bits within visual->depth that aren't used for color to
3765 1s, in case they are alpha.
3767 2004-05-27 Anders Carlsson <andersca@gnome.org>
3769 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
3770 Make separator rows insensitive.
3772 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
3774 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
3777 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
3779 * gtk/gtkentrycompletion.h:
3780 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
3781 Getter for text_column. Also make ::text_column a property.
3783 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
3785 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
3787 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
3789 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
3790 signal if the box exists.
3792 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
3794 Support insensitive cells in tree views and combo boxes:
3796 * gtk/gtkcellrenderer.h:
3797 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
3799 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
3800 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
3801 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
3802 Support drawing insensitive.
3804 * gtk/gtkcellview.h:
3805 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
3806 function to obtain the cell renderers from a cell view. Also
3807 export gtk_cell_view_set_cell_data().
3809 * gtk/gtktreeselection.c (tree_column_is_sensitive):
3810 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
3811 to determine whether all visible cells in a row are insensitive
3812 and whether a row is selectable. A row is not selectable if the
3813 user function says so or if all visible cells are insensitive.
3814 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
3815 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
3816 Use row_is_selectable().
3818 * gtk/gtkcombobox.c (row_is_sensitive):
3819 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
3820 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
3821 to determine row sensitivity in menu or list mode.
3823 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
3824 to set up sensitivity menu items from the underlying rows.
3826 * gtk/gtkcombobox.c (gtk_combo_box_popup):
3827 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
3828 update_menu_sensitivity().
3830 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
3833 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
3836 * tests/testcombo.c (main): Make some rows insensitive.
3838 2004-05-26 Robert Ă–gren <gtk@roboros.com>
3840 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
3841 modifiers (shift, ctrl etc) in button and motion events from the
3844 2004-05-26 Robert Ă–gren <gtk@roboros.com>
3846 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
3847 implementation for extended input devices using last known
3848 device state (#143237)
3850 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
3852 * gtk/gtkframe.c: Move docs inline, fixing them on the
3853 way. (#143029, Steve Chaplin)
3855 2004-05-11 Robert Ă–gren <gtk@roboros.com>
3857 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
3858 events to windows that want extended input events. (#142943)
3859 (gdk_event_translate): Move check for extended input devices to
3860 propagate, new parameter to propagate.
3861 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
3862 _gdk_input_(un)grab_pointer. (#142943)
3864 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
3865 input grab. [Fix missing update of impl in "dijkstra" event
3866 propagation loop] Drop the parallel "impl" pointer, just use a
3867 cast. Don't propagate beyond windows that want normal input
3869 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
3870 implementation of input grab. (#142943)
3872 2004-05-22 Tor Lillqvist <tml@iki.fi>
3874 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
3875 line. (Spotted by Benoît Carpentier.)
3877 2004-05-18 Matthias Clasen <mclasen@redhat.com>
3879 * configure.in: Check for XFIXES extension.
3881 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
3882 a gboolean have_xfixes member.
3884 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
3885 XFIXES events and set have_xfixes.
3887 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
3888 (GdkEventOwnerChange): New event struct for owner change events.
3889 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
3891 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
3892 XFixesSelectionNotify events into GdkEventOwnerChange events.
3895 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
3896 (gdk_display_request_selection_notification): New api
3897 to support selection ownership notification.
3899 * gtk/gtkclipboard.h:
3900 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
3901 api to handle owner change events.
3902 (clipboard_peek): Refactored out the body of
3903 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
3905 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
3906 by calling _gtk_clipboard_handle_event().
3908 2004-05-18 Matthias Clasen <mclasen@redhat.com>
3910 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
3911 the P_() macros ourselves.
3913 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3914 Restrict the width of the popup to be no larger than the
3915 monitor. (#142678, DmD Ljungmark)
3917 * gtk/gtkbutton.c: Go back to the initial fix for the
3918 focus-overdrawing problem, which was actually correct
3919 according to docs/widget_geometry.txt.
3921 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
3922 arrow size from 11 to 15 to compensate for that.
3924 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
3925 arguments of the ::move-cursor signal. (#142725)
3927 2004-05-17 Matthias Clasen <mclasen@redhat.com>
3931 * gtk/gtkbutton.c (gtk_button_size_request)
3932 (gtk_button_size_allocate, _gtk_button_paint): Allocate
3933 space for the focus rectangle only if necessary. (#142668,
3936 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
3940 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
3941 lines. (#142479, Morten Welinder)
3943 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
3945 * gtk/gtkintl.h (Q_): Add a Q_() macro.
3947 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
3948 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
3949 they are not really needed.
3951 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
3952 instead of hardwired padding, use Q_() for the default label,
3953 compute a reasonable minimal size. (#142571, #142572, #142573,
3954 Tommi Komulainen, Christian Persch)
3956 2004-05-15 Tor Lillqvist <tml@iki.fi>
3958 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
3959 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
3960 time). It is used by the OLE2_DND code, which is unfinished and
3961 presumably horribly broken, but still, let's not make it not
3962 compile on purpose. Silence some gcc warnings in the OLE2_DND
3965 2004-05-14 Matthias Clasen <mclasen@redhat.com>
3967 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
3968 New function to go from tree window to tree coordinates, kept
3969 static for now until we figure out the multiple coordinate
3970 system mess in GtkTreeView API-wise.
3971 (gtk_tree_view_scroll_to_cell): Transform the coordinates
3972 from tree window to tree coordinates, using the new function.
3973 Previously, the x coordinate was wrongly transformed. (#142494)
3975 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
3978 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
3979 modifier bit to mark stock item which need to be freed
3980 eventually. (#140654, Michal Pasternak, Scott Tsai)
3982 2004-05-11 Robert Ă–gren <gtk@roboros.com>
3984 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
3985 call to g_object_ref in Wintab code. (#138341)
3987 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
3988 including unallocated buffers for event->motion.axes and
3989 event->button.axes, unsigned wraparound problem in the code for
3990 detecting missing press/release events and assigning min instead
3991 of max when setting up axes.
3993 2004-05-12 Matthias Clasen <mclasen@redhat.com>
3995 * tests/testtreeedit.c: Add a progress column.
3997 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
4000 * gtk/gtk.h: Include gtkcellrendererprogress.h.
4002 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
4003 based on the one found in Epiphany.
4005 2004-05-11 Michael Natterer <mitch@gimp.org>
4007 * gtk/gtkcombobox.c (gtk_combo_box_popup)
4008 (gtk_combo_box_menu_button_press): don't allocate the popup
4009 smaller than the combobox. Fixes bug #59660.
4011 2004-05-11 Matthias Clasen <mclasen@redhat.com>
4013 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
4014 previous change to this function, clarify the docs instead.
4016 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
4017 GTK_SELECTION_BROWSE.
4019 * gtk/gtktreeview.c: Make hover selection work for
4020 GTK_SELECTION_BROWSE as well.
4022 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
4024 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
4025 Document the ::toggled signal.
4027 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4029 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
4031 2004-05-10 Matthias Clasen <mclasen@redhat.com>
4033 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
4035 * gdk/gdkdisplay.c (singlehead_...):
4036 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
4037 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
4038 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
4040 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
4041 note about COLUMN_FIXED restriction.
4043 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
4044 Set the entry in the default handler of the ::match-selected signal.
4047 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
4048 do the move-selected-item below pointer thingie, do the
4049 place-below-or-above one.
4051 * tests/testentrycompletion.c: Make the second example use the
4052 ::match-selected signal to make it actually work.
4054 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
4055 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
4056 mode. (#127648, Dave Bordoley)
4058 * gtk/gtktreeview.h:
4059 * gtk/gtktreeview.c: Add a new property "hover_selection", which
4060 when TRUE makes the selection follow the mouse. Also add setter
4061 and getter for the fixed_height property.
4063 2004-05-10 Matthias Clasen <mclasen@redhat.com>
4065 * gtk/gtkcombobox.c (gtk_combo_box_popup)
4066 (gtk_combo_box_menu_button_press): Make sure the menu pops up
4067 as wide as the combobox. (#59660, Havoc Pennington)
4069 2004-05-10 Matthias Clasen <mclasen@redhat.com>
4071 * gtk/gtkcombobox.h:
4072 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
4073 mode). Add a new property, add-tearoffs, for this. (#135956)
4075 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
4076 default button. (#118921)
4078 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4080 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
4081 that emits the grab notify signal.
4083 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
4085 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
4087 * gtk/gtkmenu.c: Make destruction of a torn off menu work
4088 like un-tearing off.
4090 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
4094 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
4095 Allow to suppress the stock accelerator by using "". (#142196,
4098 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
4102 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
4103 In list mode, accept the same mouse/wheel bindings on
4104 the cellview as on the button. (#136967)
4106 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
4108 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
4109 cached icons. (#135888, Crispin Flowerday)
4111 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
4113 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
4114 that we actually return menus for nodes of type menu, not the
4115 menuitems they're attached to.
4117 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
4119 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
4120 Add a note regarding UTF-8 requirements, proposed by
4121 Mariano Suárez-Alvarez.
4123 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
4125 * gtk/gtktearoffmenuitem.h:
4126 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
4127 into the GtkTearoffMenuItem struct, since it is used
4128 by the Gimp, and keep it synchronized with the
4129 tearoff_state property of the parent menu.
4131 2004-05-08 Hans Breuer <hans@breuer.org>
4133 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
4134 create the correct mask for 'pseudo mime' icons
4136 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
4137 take focus_on_map into account
4139 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
4141 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
4142 ... must return a value
4144 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
4146 2004-05-07 Matthias Clasen <mclasen@redhat.com>
4148 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
4149 draw over the focus rectangle.
4151 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
4152 standard focus style. (#63071, Bill Haneman, idea for new
4153 style by Owen Taylor)
4155 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
4156 focus on the colorwheel via details.
4158 2004-05-06 Matthias Clasen <mclasen@redhat.com>
4162 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
4163 this no longer needed signal handler. (#141817, Paul Pogonyshev)
4165 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
4167 * gtk/gtktearoffmenuitem.h:
4168 * gtk/gtktearoffmenuitem.c: Make the tearoff
4169 functionality model/view, the tearoffmenuitem being
4170 the view and the tearoff_state property of the menu
4171 being the model. (#101185, Owen Taylor)
4173 * gtk/gtkmenu.c: Add a tearoff_state property.
4175 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
4179 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
4180 popup the submenu for items in torn off menus. (#122051)
4182 2004-05-06 Sven Neumann <sven@gimp.org>
4184 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
4185 position the title lable next to the arrow just as we do for LTR
4186 rendering. Fixes bug #141825.
4188 2004-05-06 Matthias Clasen <mclasen@redhat.com>
4190 * docs/RELEASE-HOWTO: Document the new policy of
4191 bumping version numbers after release.
4193 * configure.in: Bump version number to 2.5.0.
4195 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
4198 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
4201 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
4203 * gtk/gtkactiongroup.h:
4204 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
4205 New function to translate a string with translate_func.
4208 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
4210 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
4211 (gtk_combo_box_get_row_span_column):
4212 (gtk_combo_box_get_column_span_column): Add missing getters
4213 for readwrite properies. (#135649)
4215 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
4217 * gtk/gtkcombobox.h:
4218 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
4219 Add gtk_combo_box_get_active_text() convenience
4220 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
4222 2004-05-05 Elijah Newren <newren@math.utah.edu>
4224 Changes to support do-not-focus-on-map hint in conjunction with
4225 _NET_WM_USER_TIME (#115650):
4227 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
4230 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
4233 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
4234 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
4236 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
4237 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
4238 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
4239 Initialize the focus_on_map field to TRUE.
4241 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
4242 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
4243 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
4244 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
4245 Implementations for the various backends. The Win32 and linux-fb
4246 implementations set the focus_on_map field, but don't use it yet
4247 to actually implement noinput windows. The X implementation sets
4248 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
4250 * gdk/x11/gdkwindow-x11.h:
4251 * gdk/x11/gdkevents-x11.c (set_user_time):
4252 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
4253 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
4254 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
4255 since we want that function to be part of the public API.
4257 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
4261 * gtk/gtkiconfactory.c (icon_source_clear): Don't
4262 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
4264 2004-05-05 Matthias Clasen <mclasen@redhat.com>
4268 * gtk/gtkuimanager.c (print_node): Make the output
4269 parseable. (#141929, Sven Neumann)
4271 2004-05-05 Tor Lillqvist <tml@iki.fi>
4273 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
4274 multi-monitor offset. (#141842, John Ehresman)
4276 2004-05-04 Federico Mena Quintero <federico@ximian.com>
4278 Fixes #139562, based on a patch by Christian Neumair.
4280 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
4281 a filter_combo_hbox field to contain the filter combo.
4282 (show_filters): Show/hide the filter_combo_hbox.
4283 (create_filename_entry_and_filter_combo): Removed.
4284 (file_pane_create): Create the filter_combo_hbox here.
4286 2004-05-04 Matthias Clasen <mclasen@redhat.com>
4288 * modules/input/gtkimcontextxim.c: Fix the recent
4289 string_conversion_callback change to work on
4290 Solaris. (#141190, Padraig O'Briain)
4292 * gtk/gtkselection.c: Disable debug logging again.
4294 2004-05-03 Matthias Clasen <mclasen@redhat.com>
4296 * gtk/gtkselection.c: Make the chunk size for
4297 incremental transfers depend on the maximal request
4298 size, capped at 256k. This should allow most selections
4299 to be transferred nonincrementally, avoiding many
4300 roundtrips and protocol overhead.
4302 2004-05-03 Federico Mena Quintero <federico@ximian.com>
4304 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
4305 g_signal_new() correctly and initialize the signal fields. Fixes
4306 #141749; patch based on Michael Natterer's.
4308 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
4310 * gtk/gtkselection.c (_gtk_selection_request): Fix
4311 a debug message to show correct information.
4312 (_gtk_selection_incr_event): Make INCRemental transfer
4313 of MULTIPLE targets work. This was broken since 1997!
4315 2004-05-02 Hans Breuer <hans@breuer.org>
4317 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
4318 modify the passed in GdkSegment(s) in place, we may get
4319 them again to draw at the same place. Fixes bug #129095,
4321 (draw_segments) draw the end pixel again to get the
4322 pixmap mask right, fixes bug #126710, #130202
4324 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
4325 fixes bug #106013, John Ehresman
4327 * gtk/makefile.msc.in : don't try to link gtk.res but
4328 use gtk-win32.res (as supposed to be fixed below :)
4330 2004-05-01 Hans Breuer <hans@breuer.org>
4332 * tests/Makefile.am : tests/makefile.msc is in CVS for
4333 a long time, finally added to EXTRA_DIST : fixes bug
4334 #141334, John Ehresman
4336 2004-04-30 Matthias Clasen <mclasen@redhat.com>
4338 * === Released 2.4.1 ===
4340 * configure.in: Version 2.4.1, interface age 1.
4344 2004-04-29 Federico Mena Quintero <federico@ximian.com>
4348 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
4349 function; moved the code over from
4350 remove_bookmark_button_clicked_cb().
4351 (remove_selected_bookmarks): Now, getting a non-removable bookmark
4352 is not an error, as we may be called as a result of hitting the
4354 (shortcuts_key_press_event_cb): New handler; delete the bookmark
4355 if the user presses Backspace, Delete, or KP_Delete.
4357 2004-04-29 Matthias Clasen <mclasen@redhat.com>
4359 * gtk/gtkaction.c (closure_accel_activate): Use
4360 _gtk_action_emit_activate() instead of directly
4361 emitting the activate signal. (#141429, Jody Goldberg)
4363 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
4364 Warn people when the accelerator can not be
4365 parsed. (#141429, Jody Goldberg)
4367 2004-04-29 Matthias Clasen <mclasen@redhat.com>
4369 * tests/testentrycompletion.c (main): Add a missing
4370 cat. (#141070, Chris Sherlock)
4372 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
4373 variable. (#141022, Chris Sherlock)
4375 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
4376 cast. (#141013, Chris Sherlock)
4378 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
4379 unused variable. (#141011, Chris Sherlock)
4381 2004-04-29 Tor Lillqvist <tml@iki.fi>
4383 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
4384 leak. (#140775, John Ehresman)
4386 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
4388 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
4389 to index the cached gcs, not depth. (#139494)
4391 2004-04-28 Matthias Clasen <mclasen@redhat.com>
4393 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
4395 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4397 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
4398 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
4400 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
4402 Patch to add support for string conversion callbacks to
4403 GtkIMContextXIM (#101814)
4405 * modules/input/gtkimcontextxim.c: Set the string conversion callback
4406 if supported by the XIC.
4408 (struct _GtkIMContextXIM): Add string_conversion_callback member.
4410 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
4411 whether string conversion callback is supported.
4413 (gtk_im_context_get_ic, +set_string_conversion_callback,
4414 +string_conversion_callback): Also initialize string conversion
4415 callback, if supported, along with the IC initialization.
4417 * modules/input/imxim.c: Make "xim" module default for Thai as well.
4419 2004-04-23 Matthias Clasen <mclasen@redhat.com>
4421 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
4422 initialize targets. (#139883, John Finlay)
4424 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
4426 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
4427 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
4428 Tim-Philipp MĂĽller)
4430 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
4431 Remove an excessive g_return_if_fail().
4433 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
4435 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
4436 _-prefix calls of gdk_x11_window_set_user_time().
4438 2004-04-22 Matthias Clasen <mclasen@redhat.com>
4440 * gtk/gtkuimanager.c (update_node): Make sure the separators
4441 used to demarkate placeholder ends don't show up on
4442 show_all(). (#140496, Murray Cumming)
4444 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
4445 work with negative increments. (#137975, Tim Gerla)
4447 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4449 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
4450 gtk_tool_button_set_icon_widget): Remove the old widget from the
4451 tool button before overwriting it with the new widget.
4453 (#140508, Todd Goyen)
4455 2004-04-22 Tor Lillqvist <tml@iki.fi>
4457 Fix the file chooser on Windows. I can't make it misbehave or
4458 crash any more now. But presumably there are still corner cases
4459 not handled. I haven't really checked behaviour of UNC paths, for
4462 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
4463 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
4466 (gtk_file_system_win32_get_parent): Like the Unix version, assert
4467 filename is absolute, and avoid one unnecessary string allocation
4470 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
4471 letters more correctly.
4473 (gtk_file_system_win32_render_icon): Assure correct syntax is used
4474 for root folder of a drive. (#137962, Morten Welinder)
4476 (filename_is_some_root): New function that accepts also root
4477 without any drive specified.
4479 (filename_is_drive_root): Rename from filename_is_root.
4481 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
4484 2004-04-21 Matthias Clasen <mclasen@redhat.com>
4486 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
4487 completion window if there are no completions anymore.
4489 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
4490 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
4491 It doesn't like that. (#140642, Christian Persch)
4493 * demos/gtk-demo/expander.c (do_expander): A new demo.
4495 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
4497 2004-04-20 Matthias Clasen <mclasen@redhat.com>
4499 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
4500 sure anchored children get size allocated, even if the layout
4501 is valid. (#122323, Andrew E. Makeev)
4502 (gtk_text_view_scroll_pages):
4503 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
4504 if we already have pending scrolls. Bandaid fix for #78513.
4506 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
4508 * INSTALL.in: Update libpng and libjpeg URLs, remove
4509 note about building without since that's not the normal
4512 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
4514 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
4515 handling of SVG/non-SVG unthemed icons.
4517 2004-04-19 Morten Welinder <terra@gnome.org>
4519 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
4522 2004-04-19 Matthias Clasen <mclasen@redhat.com>
4524 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
4525 Don't stop the iteration up to the tag_root too
4526 early. (#109945, Dongho Shin)
4528 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4530 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
4531 gdk_keymap_translate_keyboard_state() handle NULL
4532 keymaps. (#139715, Torsten Schoenfeld).
4534 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4536 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
4537 reported by Pedro RODRIGUEZ, about compilation problems when
4538 Xcursor is installed in a non-standard location.
4540 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
4542 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
4545 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
4546 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
4548 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
4550 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
4553 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
4554 property on user interaction.
4556 2004-04-15 Federico Mena Quintero <federico@ximian.com>
4558 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
4559 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
4561 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
4562 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
4565 2004-04-15 Matthias Clasen <mclasen@redhat.com>
4567 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
4568 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
4570 2004-04-14 Matthias Clasen <mclasen@redhat.com>
4572 * gtk/gtkcombobox.c:
4574 Make all style properties readonly.
4576 2004-04-14 Matthias Clasen <mclasen@redhat.com>
4578 * gtk/gtkcolorsel.c: Add a11y relations between the color
4579 wheel and the spin buttons. (#132745, Padraig O'Briain)
4581 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
4582 the meaning of size == -1.
4584 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
4585 a size of -1. (#137436, Brian Cameron)
4587 * gtk/gtkcombobox.c: Make the arrow and separator regular
4588 children of an hbox inside the button, and propagate state
4589 changes from the button to the cell view. (part of the fix
4590 for #138650, should also fix #137535)
4592 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
4593 state to gtk_cell_renderer_render() when prelighted. (part
4594 of the fix for #138650)
4596 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
4597 Use PRELIGHT state when appropriate. (part of the fix for
4600 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
4601 out warnings if called before the combo box is
4602 realized. (#139742, Philip Langdale)
4604 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
4606 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
4609 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
4611 * gtk/gtkpathbar.c (make_directory_button): remove spurious
4614 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
4616 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
4617 make the buttons sized by a bold label. This makes the text
4618 'swim' a little, but stops the buttons from resizing, #137210
4620 2004-04-13 Matthias Clasen <mclasen@redhat.com>
4622 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
4624 (start_element_handler): Accept separators without unique
4625 names. (#133302, Anders Carlsson)
4627 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
4628 possible accelerator gotcha when using this function. (#139641,
4631 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
4632 list nodes. (#138862, Morten Welinder)
4634 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
4636 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
4638 (gtk_tree_view_button_press): If we activated the row we don't
4639 want to grab focus back, as moving focus to another widget is
4640 pretty common, #138458
4642 2004-04-12 Federico Mena Quintero <federico@ximian.com>
4644 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
4645 documentation to all the signals.
4647 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
4649 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
4650 model if it is NULL. (#139770)
4652 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
4654 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
4655 a shadow inside the scrolled window, add it around the vbox.
4657 * gtk/gtkentryprivate.h:
4658 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
4659 Return a boolean indicating whether the popup is positioned above
4660 or below. Scroll the completions to the beginning or the end,
4661 depending on the positioning.
4663 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
4664 wrap around in the entry completion popup, and allow GDK_UP to
4665 enter the popup. (#137440)
4667 2004-04-12 Matthias Clasen <mclasen@redhat.com>
4669 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
4670 there before using it.
4672 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
4674 * gtk/gtktreeprivate.h: Moved search entries into priv data.
4676 * gtk/gtktreeview.c: Prep for type-ahead support.
4678 (gtk_tree_view_destroy): Destroy the search window explicitly.
4679 (gtk_tree_view_key_press): Minor change; prep for type-ahead
4680 (gtk_tree_view_ensure_interactive_directory): New function
4681 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
4682 (gtk_tree_view_real_start_interactive_search): rework
4683 (gtk_tree_view_search_dialog_hide): ditto
4684 (gtk_tree_view_search_delete_event): ditto
4685 (gtk_tree_view_search_button_press_event): ditto
4686 (gtk_tree_view_search_key_press_event): ditto
4687 (gtk_tree_view_search_move): ditto
4688 (gtk_tree_view_search_init): ditto
4690 * gtk/gtktreeviewcolumn.c:
4691 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
4693 * tests/testfilechooser.c: (main): change
4695 2004-04-11 Hans Breuer <hans@breuer.org>
4697 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
4698 the real fix would involve just another small API breakage,
4699 i.e. gdk_spawn_* using GPid not just gint.
4701 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
4703 2004-04-10 Tor Lillqvist <tml@iki.fi>
4705 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
4706 If both Shift and CapsLock pressed, ignore the shift only for
4707 letters (that would have been affected by the CapsLock). (#139095)
4709 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
4710 seems to be even buggier now than it used to be. (#138341)
4711 Initialize _gdk_input_ignore_wintab to TRUE.
4713 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
4714 GDK_USE_WINTAB environment variable to turn on tablet support.
4716 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
4718 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
4719 (gtk_ui_manager_remove_action_group): Terminate
4720 g_object_[dis]connect() calls with NULL instead of 0.
4723 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
4725 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
4727 2004-04-07 Federico Mena Quintero <federico@ximian.com>
4731 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
4732 passed-in 'str' is not NULL.
4734 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
4735 expands "~/" or "~foo/" at the beginning of a filename.
4736 (gtk_file_system_unix_parse): Use expand_tilde() before doing
4739 * gtk/gtkfilechooserentry.c
4740 (gtk_file_chooser_entry_maybe_update_directory): Take in a
4741 force_reload argument.
4742 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
4743 returns an error, set the file_part_pos to -1.
4744 (load_directory_callback): Only populate the model if the
4745 file_part_pos is not -1.
4747 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
4749 * configure.in: Added Icelandic (is) to ALL_LINGUAS
4751 2004-04-05 Federico Mena Quintero <federico@ximian.com>
4753 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
4754 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
4756 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
4757 for G_DIR_SEPARATOR in the display_name, and err out if it is
4758 present; use the same error message as Nautilus. Fixes #136467.
4760 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
4761 new-folder button say "Create Fo_lder" rather than "Create
4762 _Folder", so that the mnemonic doesn't conflict with the "Save in
4763 _folder" label. Fixes #136975.
4765 2004-04-05 Federico Mena Quintero <federico@ximian.com>
4767 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
4768 buttons. Also, free them correctly upon failure. Based on a
4769 patch by Morten Welinder, fixes #137956.
4771 2004-04-05 Anders Carlsson <andersca@gnome.org>
4773 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
4775 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
4777 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
4778 correctly for fixed height when inserting a node, #138082
4780 2004-04-01 Federico Mena Quintero <federico@ximian.com>
4784 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
4785 "child_is_hidden" boolean argument to the "path-clicked" signal.
4787 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
4789 (make_directory_button): Take a file_is_hidden argument; put it in
4791 (_gtk_path_bar_set_path): See whether each path component path is
4793 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
4794 "path-clicked" signal.
4795 (button_clicked_cb): See if the downwards button represents a
4796 hidden file for the file_is_hidden argument in the signal
4799 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
4801 * gtk/gtkfilechooserdefault.c
4802 (gtk_file_chooser_default_select_path): If we fail to switch
4803 folders, don't try to select the path in the file system model.
4804 Also, return the result from _gtk_file_system_model_path_do().
4805 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
4806 file system model if we are asked to select a hidden file.
4807 (path_bar_clicked): Show hidden files based on whether the
4808 immediate downwards folder in the path bar is a hidden file
4810 (struct _GtkFileChooserDefault): Added fields
4811 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
4812 (create_file_list): Set an object data key of
4813 "GtkFileChooserDefault" on the tree view so that we can find the
4814 impl from the popup menu callbacks. Also, hook up to the
4815 "button-press-event" and "popup-menu" signals in the file list to
4816 bring up a popup menu.
4817 (list_popup_menu_cb): New callback.
4818 (list_button_press_event_cb): New callback.
4822 * gtk/gtkfilesystemmodel.c
4823 (_gtk_file_system_model_new): Oops, connect_object to
4826 2004-03-31 Tor Lillqvist <tml@iki.fi>
4828 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
4829 for native Win32. (#136559, J. Ali Harlow)
4831 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
4832 angles. Thanks to Tim Newsham.
4834 2004-03-29 Federico Mena Quintero <federico@ximian.com>
4838 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
4839 for an ::is_finished_loading() method and a ::finished_loading()
4840 signal at the end of the struct.
4842 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
4843 "finished-loading" signal.
4844 (gtk_file_folder_is_finished_loading): New function.
4846 * gtk/gtkfilesystemunix.c
4847 (gtk_file_folder_unix_is_finished_loading): Implement.
4849 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
4850 slot for a "finished-loading" signal.
4851 (gtk_file_system_model_class_init): Create the "finished-loading"
4853 (struct _GtkFileSystemModel): New field
4854 idle_finished_loading_source. We emit the "finished-loading"
4855 signal in an idle if the root folder was done loading right in
4856 _gtk_file_system_model_new(), so that the caller has a chance to
4857 connect to the signal.
4858 (_gtk_file_system_model_new): Connect to the normal signals of the
4859 folder even if the initial _list_children() fails. Also, see if
4860 the folder is finished loading; connect to the "finished-loading"
4862 (gtk_file_system_model_finalize): Remove the idle handler.
4864 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
4865 and connect to the model's "finished-loading" signal.
4866 (get_toplevel): New helper function.
4867 (error_message): Use get_toplevel().
4868 (trap_activate_cb): Likewise.
4869 (location_popup_handler): Likewise.
4870 (set_busy_cursor): New function.
4871 (browse_files_model_finished_loading_cb): New callback.
4873 2004-03-25 Federico Mena Quintero <federico@ximian.com>
4875 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
4876 file under the cursor; we don't need the logic from
4877 GtkFileSelection after all. Fixes #132255.
4879 2004-03-25 Federico Mena Quintero <federico@ximian.com>
4881 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
4882 location entry with the display name of the file under the cursor
4883 for Open mode, or the typed filename in Save mode.
4885 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4887 * gtk/gtkfilesystemwin32.c
4888 (filename_is_root): Bare drive designators (eg., "c:") are
4889 no longer considered as root filenames. Fixed #137942
4891 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4893 * gtk/gtkfilesystemwin32.c
4894 (gtk_file_system_win32_create_folder): Invert test for error in
4895 mkdir. Fixes #137945
4897 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4899 Fixed #138004 using Federico's code from #132327.
4901 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
4902 folder_hash field to keep a list of live folder objects.
4903 (gtk_file_system_win32_init): Create the folder_hash.
4904 (gtk_file_system_win32_finalize): Destroy the folder_hash.
4905 (gtk_file_system_win32_get_folder): Ref and return an existing
4906 folder if we have it around, otherwise return a new folder object.
4907 (struct _GtkFileFolderWin32): Add a field for the parent file system.
4908 (gtk_file_folder_win32_finalize): Remove the folder from the file
4909 system's hash table.
4910 (gtk_file_system_win32_create_folder): Emit "files-added" on the
4911 newly-created folder's parent. Fixes #138004.
4913 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4915 * gtk/gtkfilesystemwin32.c
4916 (gtk_file_system_win32_get_folder): Test that path is actually
4917 a directory and throw error if not. Fixed bug #137950
4919 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
4921 * gtk/gtkfilesystemwin32.c
4922 (gtk_file_system_win32_volume_get_display_name): Ignore empty
4923 volume labels; assume that GetVolumeInformation would fail if
4924 GetVolumeInformationW does; catches a small memory leak;
4925 pass the buffer size to GetVolumeInformationW in wide
4926 characters instead of bytes. Fixes bug #137543
4927 (list_volumes): Cope with the theoretical possibility of
4928 more than 26 logical drives. Fixes bug #137940
4929 (bookmarks_serialize): Now actually removes bookmarks.
4932 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
4934 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
4936 2004-03-21 Tor Lillqvist <tml@iki.fi>
4938 * gtk/gtkfilesystemwin32.c
4939 (gtk_file_system_win32_volume_get_base_path): Include the
4940 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
4941 NULL for a volume base path, as g_filename_to_uri() requires an
4942 absolute path, and just a drive letter and colon isn't. (#137543)
4944 2004-03-20 Hans Breuer <hans@breuer.org>
4946 * gtk/gtkfilesystemwin32.c : applied the undisputable and
4947 required [due to recent gtkfilesystem internal api semantic
4948 changes] part of patches to fix bug #137543 (Tor Lillqvist,
4951 * gdk/gdkevents-win32.c (handle_configure_event) :
4952 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
4953 GdkWindowObject::x, y with screen coords to make
4954 gdk_window_get_position () return the right thing and thus fix
4955 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
4957 2004-03-19 Federico Mena Quintero <federico@ximian.com>
4959 * Revert the patch to #137520, as 2.4.1 is for conservative bug
4960 fixes only. The patch is attached to the bug report, for
4963 2004-03-19 Morten Welinder <terra@gnome.org>
4965 * gtk/gtkfilechooserdefault.c
4966 (gtk_file_chooser_default_set_current_folder): Test existance of
4967 the path after checking for locality, if needed.
4969 2004-03-19 Federico Mena Quintero <federico@ximian.com>
4973 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
4974 for an ::is_finished_loading() method and a ::finished_loading()
4975 signal at the end of the struct.
4977 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
4978 "finished-loading" signal.
4979 (gtk_file_folder_is_finished_loading): New function.
4981 * gtk/gtkfilesystemunix.c
4982 (gtk_file_folder_unix_is_finished_loading): Implement.
4984 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
4985 slot for a "finished-loading" signal.
4986 (gtk_file_system_model_class_init): Create the "finished-loading"
4988 (struct _GtkFileSystemModel): New field
4989 idle_finished_loading_source. We emit the "finished-loading"
4990 signal in an idle if the root folder was done loading right in
4991 _gtk_file_system_model_new(), so that the caller has a chance to
4992 connect to the signal.
4993 (_gtk_file_system_model_new): Connect to the normal signals of the
4994 folder even if the initial _list_children() fails. Also, see if
4995 the folder is finished loading; connect to the "finished-loading"
4997 (gtk_file_system_model_finalize): Remove the idle handler.
4999 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
5000 and connect to the model's "finished-loading" signal.
5001 (get_toplevel): New helper function.
5002 (error_message): Use get_toplevel().
5003 (trap_activate_cb): Likewise.
5004 (location_popup_handler): Likewise.
5005 (set_busy_cursor): New function.
5006 (browse_files_model_finished_loading_cb): New callback.
5008 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
5010 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
5011 eventbox for expander. (#137564, reported by
5014 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
5016 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
5018 2004-03-17 Morten Welinder <terra@gnome.org>
5020 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
5021 volumes not actually put into the shortcut list.
5023 * tests/prop-editor.c (object_changed): Plug leak.
5025 * tests/testfilechooser.c (main): Plug some leaks and expose
5028 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
5029 object. Fixed #136652.
5031 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
5032 have no screen. Fixes #137260.
5033 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
5034 thereby fixing leak. Fixes #137259.
5036 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
5037 slider buttons have been destroyed.
5038 (gtk_path_bar_remove): Make this work for slider buttons too.
5041 2004-03-15 Morten Welinder <terra@gnome.org>
5043 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
5044 Sanitize and plug leak.
5045 (check_icon_theme): Only do something if the widget has a screen.
5047 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
5049 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
5050 Move the repositioning logic from _gtk_entry_completion() popup
5051 over here. Fixes #137355, reported by Niklas Knutsson.