1 Sat Sep 4 22:45:49 2004 Matthias Clasen <maclas@gmx.de>
3 * gtk/gtkentry.c (gtk_entry_backspace): Don't refuse to delete
4 text in passwords. (#151723, Owen Taylor)
6 Sat Sep 4 16:51:00 2004 Søren Sandmann <sandmann@redhat.com>
8 * gdk/x11/gdkevents-x11.c (gdk_event_prepare): Revert accidental
9 change from Aug 02 that removed a flush of the X connection from
10 gdk_event_prepare() causing applications to get stuck. (#151732,
13 Fri Sep 3 22:45:03 2004 Matthias Clasen <maclas@gmx.de>
15 * gtk/gtkuimanager.c (print_node): Don't print out attributes
16 for the <ui> root node. (#151752, Lorenzo Gil Sánchez)
18 Sat Sep 4 02:38:57 2004 Søren Sandmann <sandmann@redhat.com>
20 * gtk/gtktoolbar.c (position): Accelerate the animation when it
21 has been running for a while. (#143647).
23 2004-09-03 Tor Lillqvist <tml@iki.fi>
25 * gtk-zip.sh.in: List the three theme gtkrc files separately, zip
26 doesn't do anything if one of the files on its command line
29 Handle changes of screen resolution on Win32. (#151581, reported by
32 * gdk/win32/gdkwindow-win32.c (_gdk_windowing_window_init,
33 _gdk_root_window_size_init): Factor out setting the root window's
34 size (as the size of the union of all monitors) to a new function.
36 * gdk/win32/gdkdisplay-win32.c (gdk_display_open,
37 _gdk_monitor_init): Factor out the monitor query to a new
40 * gdk/win32/gdkprivate-win32.h: Declare above new functions.
42 * gdk/win32/gdkevents-win32.c (gdk_event_translate,
43 handle_display_change): Handle WM_DISPLAYCHANGE by calling the
44 above two functions, and emitting the "size_changed" signal on our
47 2004-09-01 Matthias Clasen <mclasen@redhat.com>
49 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible):
50 Document the return value.
52 2004-09-01 Matthias Clasen <mclasen@redhat.com>
54 Make it possible to specify additional modules to load
55 via a setting. (#117236, Alex Graveley)
58 * gtk/gtkmodules.c: New files which contain the module
59 handling code which was previously in gtkmain.[hc].
60 Additionally, the code now looks for the gtk-modules
61 setting, which can specify additional modules to load.
64 * gtk/gtkmain.h: Remove all the module handling code.
66 * gtk/gtkdebug.h: Add a debug flag for modules.
68 * gtk/gtk.h: Include gtkmodules.h
70 * gtk/Makefile.am (gtk_public_h_sources): Add gtkmodules.h
71 (gtk_c_sources): Add gtkmodules.c
73 * gtk/gtksettings.c: Add the gtk-modules setting.
75 * gdk/x11/gdkevents-x11.c: Add the Gtk/Modules XSetting.
77 Wed Sep 1 19:11:44 2004 Søren Sandmann <sandmann@redhat.com>
79 * gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Make sure
80 children of the toolbar are given positive dimensions. (149540,
83 2004-09-01 Matthias Clasen <mclasen@redhat.com>
85 * gtk/gtkfilesystemunix.c:
86 * gtk/gtkfilechooserbutton.c: Protect the unistd.h include
89 Wed Sep 1 02:38:48 2004 Matthias Clasen <maclas@gmx.de>
91 * gtk/gtkaccellabel.c (gtk_accel_label_expose_event): Make
92 accel labels ellipsize correctly. (#151559, Christian Persch)
94 Wed Sep 1 00:55:56 2004 Matthias Clasen <maclas@gmx.de>
96 * gtk/gtkimage.c (gtk_image_clear): Don't leak the iter
97 of a running animation. (#151542)
99 Tue Aug 31 23:40:29 2004 Matthias Clasen <maclas@gmx.de>
101 * gdk/win32/gdkproperty-win32.c (gdk_screen_get_setting): Make
102 "ms-windows" the default theme on Win32.
104 Tue Aug 31 23:24:49 2004 Matthias Clasen <maclas@gmx.de>
106 * gtk/gtkcalendar.c (gtk_calendar_main_button): Only start
107 a drag if the left button is pressed. (#151490, Frederic Croszat)
109 Tue Aug 31 23:20:58 2004 Matthias Clasen <maclas@gmx.de>
111 * gdk/x11/gdkdnd-x11.c (gdk_drop_finish): Remove debug spew.
113 Tue Aug 31 17:07:41 2004 Jonathan Blandford <jrb@redhat.com>
115 * gtk/gtktreeviewcolumn.c
116 (gtk_tree_view_column_cell_process_action): constrain cell area to
117 passed in cell_area, #147867
119 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size): if
120 ellipsizing, get_size is only 3 chars wide.
122 * docs/tree-column-sizing.png: Add Matthias's excellent image.
124 2004-08-28 Robert Ögren <gtk@roboros.com>
126 On Win32, do not produce tablet motion or button events while a
127 window is being moved or resized. (#151090, reported by Shaneyfelt)
129 * gdk/win32/gdkprivate-win32.h
130 * gdk/win32/gdkglobals-win32.c
131 * gdk/win32/gdkevents-win32.c: Rename the variable resizing to
132 _sizemove_in_progress and make it extern.
134 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Ignore
135 motion and button events if _sizemove_in_progress is true.
137 2004-08-30 Tor Lillqvist <tml@iki.fi>
139 Make the ms-windows theme engine build with mingw.
141 * configure.in: Expand also modules/engines/ms-windows/Theme/
142 Makefile and .../Theme/gtk-2.0/Makefile.
144 * modules/engines/ms-windows/Makefile.am: Adapt for building
145 inside the GTK sources.
147 * modules/engines/ms-windows/*.c: Use "foo.h" style includes for
148 GTK and GDK headers. Use correct path for gdkwin32.h header.
150 * modules/engines/ms-windows/msw_style.c: Don't use deprecated GDK
153 * modules/engines/ms-windows/xp_theme_defs.h
154 * modules/engines/ms-windows/xp_theme.c: Move definitions of TMT_*
155 to xp_theme.c, as they are neither in mingw's nor Platform
158 * modules/engines/ms-windows/xp_theme.c: Define _WIN32_WINNT as
159 0x0501 to get the necesssary stuff from mingw's uxtheme.h.
161 2004-08-30 Matthias Clasen <mclasen@redhat.com>
163 Integrate the ms-windows theme engine (better known as Wimp)
164 into the autotools build. Wimp (http://gtk-wimp.sourceforge.net/)
165 was written by Raymond Penners and Dom Lachowicz. The Wimp 0.6.2
166 sources have been added to the GTK+ source tree in
167 modules/engines/ms-windows, and there is a ChangeLog detailing
168 the history of Wimp. (#109615, Havoc Pennington)
170 * configure.in: Generate modules/engines/Makefile and
171 modules/engines/ms-windows/Makefile.
173 * modules/Makefile.am (SUBDIRS): Add engines.
175 * modules/engines/Makefile.am: Compile ms-windows for win32.
177 2004-08-30 Matthias Clasen <mclasen@redhat.com>
179 * gtk/gtktextview.c (gtk_text_view_delete_surrounding_handler):
182 2004-08-27 Matthias Clasen <mclasen@redhat.com>
184 Fix #151112, Olexiy Avramchenko:
186 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout):
187 * gtk/gtkiconview.c (scroll_timeout, layout_callback)
188 (gtk_icon_view_item_accessible_idle_do_action):
189 * gtk/gtkcombobox.c (list_popup_resize_idle, popdown_idle)
190 (popup_idle): Protect idle callbacks and timeouts with
191 GDK_THREADS_ENTER/_LEAVE.
193 * gtk/gtkfilechooserbutton.c (update_dialog_idle): New function to
194 call update_dialog() from an idle with the necessary protection.
196 Mon Aug 30 01:34:42 2004 Matthias Clasen <maclas@gmx.de>
198 Changes to make sure input methods respect the editability
199 of entries and text views. #114173, Noah Levitt.
201 * gtk/gtkentry.c (popup_targets_received): Make the Input
202 Methods menuitem insensitive if we're not editable.
204 * gtk/gtkentry.c (gtk_entry_delete_surrounding_cb):
205 * gtk/gtkentry.c (gtk_entry_preedit_changed_cb):
206 * gtk/gtkentry.c (gtk_entry_commit_cb): Don't change anything
207 if we're not editable.
209 * gtk/gtkentry.c (gtk_entry_focus_out):
210 * gtk/gtkentry.c (gtk_entry_focus_in): Only send focus_in and
211 focus_out to the im context if we're editable.
213 * gtk/gtkentry.c (gtk_entry_set_property): Reset the im context
214 if the entry just became non-editable.
216 * gtk/gtktextview.c (gtk_text_view_delete_surrounding_handler):
217 Use gtk_text_buffer_delete_interactive() to not delete
218 non-editable portions of text.
220 2004-08-30 Tor Lillqvist <tml@iki.fi>
222 * modules/input/Makefile.am (im_ime_la_LIBADD): Link with -limm32.
224 * modules/input/gtkimcontextime.c: Use quotes in #includes, to
225 find headers when building inside GTK+ sources.
227 2004-08-27 Tor Lillqvist <tml@iki.fi>
229 * gdk/win32/gdkdnd-win32.c (GdkDragContextPrivateWin32): Add
230 drop_failed, like in the X11 backend. Nothing sets it, though.
231 (gdk_drag_drop_succeeded): Copy from X11 backend.
233 Thu Aug 26 23:58:11 2004 Matthias Clasen <maclas@gmx.de>
235 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't crash
236 if model is not set. Noted by Mariano Suarez-Alvarez.
238 Thu Aug 26 22:44:12 2004 Matthias Clasen <maclas@gmx.de>
240 Provide information about how an adjustment change in a range
241 widget happened. Add a "slider-moved" signal which reports how
242 a user is interacting with the range, whether they are clicking
243 on a stepper or the trough, or dragging the slider. (#133263,
246 * gtk/gtkmarshalers.list: Add signal type BOOLEAN:ENUM,DOUBLE.
247 * gtk/gtkrange.c (gtk_range_class_init): Add "change-value"
249 (gtk_range_internal_set_value): Rename to
250 gtk_range_real_change_value. Add GtkScrollType parameter. Emit
251 the change-value signal when the range's value changes.
252 (update_slider_position, gtk_range_scroll_event, step_back,
253 step_forward, page_back, page_forward, scroll_begin,
254 scroll_end): Change gtk_range_internal_set_value to
255 gtk_range_real_change_value.
256 * gtk/gtkrange.h (struct _GtkRangeClass): Declare change_value
259 2004-08-26 Matthias Clasen <mclasen@redhat.com>
261 * modules/input/Makefile.am: Build imime.la on Windows.
263 * modules/input/gtkimcontextime.h:
264 * modules/input/gtkimcontextime.c:
265 * modules/input/imime.c:
266 * modules/input/imm-extra.h: Add the IME input method for Win32
267 written by Takuro Ashie and Kazuko IWAMOTO. The code was previously
268 hosted at http://sourceforge.jp/projects/imime. (#135195)
270 2004-08-26 Bill Haneman <billh@gnome.org>
273 (gtk_tree_view_move_cursor_up_down):
274 If a multi-selection list contains only one item,
275 select it on cursor_up or cursor_down.
277 [patch from Padraig O'Briain]
279 2004-08-26 Matthias Clasen <mclasen@redhat.com>
281 Make gdk_window_process_[all]_updates() respect
282 update_freeze_counter (#144272, Soeren Sandmann)
284 * gdk/gdkwindow.c (gdk_window_schedule_update): New function to
285 install an idle for gdk_window_update_idle() if one isn't there
287 (gdk_window_process_all_updates):
288 (gdk_window_process_updates): Only process the updates if the
290 (gdk_window_invalidate_maybe_recurse): Schedule an update when
292 (gdk_window_thaw_updates): Use gdk_window_schedule_update() instead
293 of directly installing the idle.
295 2004-08-22 Robert Ögren <gtk@roboros.com>
297 On Win32, make graphical tablets work on multi-monitor systems.
298 (#145467, reported by buttknock1@ya...)
300 * gdk/win32/gdkinput-win32.c (gdk_input_translate_coordinates):
301 Use dimensions of _gdk_parent_root as screen size.
302 (gdk_input_get_root_relative_geometry): Get coordinates relative
303 to GDK root window instead of Win32 coordinates.
304 (_gdk_input_other_event): Updated accordingly.
306 Wed Aug 25 17:24:17 2004 Manish Singh <yosh@gimp.org>
308 * gdk/x11/gdkfont-x11.c: remove unused gdk_font_charset_for_locale()
311 * gdk/x11/gdkinput-x11.c (_gdk_input_common_init): remove unused
312 variables num_extensions and extensions.
314 * gtk/gtkhsv.c: remove unused gtk_hsv_get_focus_gc() function.
316 Wed Aug 25 17:14:58 2004 Manish Singh <yosh@gimp.org>
318 * gtk/gtktreeview.c (gtk_tree_view_search_activate): initialize
319 path so we don't potentially use an undefined pointer.
321 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): add G_CALLBACK
322 cast for tree_view_keybinding_cb.
324 * gtk/gtkfilechooserdefault.c (location_entry_create): cast to
325 GTK_FILE_CHOOSER_ENTRY for _gtk_file_chooser_entry_set_file_part()
328 * gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_start_editing):
329 cast to GTK_COMBO_BOX for gtk_combo_box_set_active_iter() call.
331 * gtk/gtkselection.c (selection_get_text_plain): make len a gsize,
332 since that's what g_convert_with_fallback() expects.
334 Wed Aug 25 16:14:34 2004 Jonathan Blandford <jrb@redhat.com>
336 * gtk/gtktreeview.c (gtk_tree_view_search_activate): activate the
337 typeahead entry on enter.
339 2004-08-25 Matthias Clasen <mclasen@redhat.com>
341 * gtk/gtkmenu.c (gtk_menu_attach_to_widget): Steal ATTACHED_MENUS
342 list so its tail isn't freed when we re-set it, noticed
343 by Hans Petter Jansson.
345 * gtk/gtksizegroup.c (gtk_size_group_add_widget): Fix
346 a typo, noticed by Tim Janik.
348 Wed Aug 25 15:15:56 2004 Jonathan Blandford <jrb@redhat.com>
350 * gtk/gtkpathbar.c (gtk_path_bar_size_allocate): Change the Down
351 button to be end-justified, so that clicking on it is a stable
354 Tue Aug 24 02:06:37 2004 Jonathan Blandford <jrb@gnome.org>
357 (gtk_tree_view_real_expand_collapse_cursor_row): Don't handle the
358 event if we have no children.
360 * gtk/gtkfilechooserdefault.c (trap_activate_cb):
361 (tree_view_keybinding_cb):Since GtkTreeView has a keybinding
362 attached to '/', we need to catch keypresses before the TreeView
364 (gtk_file_chooser_default_class_init): add '/' to be a keybinding
366 (location_entry_create): Clear the text to "" when loading a file.
367 This has a much better feel than putting the currently selected
371 2004-08-25 Matthias Clasen <mclasen@redhat.com>
373 * gtk/gtkfilechooserdefault.c (check_is_folder): Use get_file_info() rather
374 than trying get_folder() and checking for an error directly because older
375 versions of the gnome-vfs backend don't return an error
376 immediately. (#150852, Zack Cerza )
378 2004-08-25 Matthias Clasen <mclasen@redhat.com>
380 * configure.in: Post-release version bump.
382 * === Released 2.5.2 ===
385 * gtk/abicheck.sh: Make work during make distcheck.
387 * docs/RELEASE-HOWTO: Add hint about doing make check
388 before make distcheck.
390 * gtk/gtk.symbols: Add some missing symbols.
392 * gtk/gtkiconview.c: Add some missing statics.
394 2004-08-24 Matthias Clasen <mclasen@redhat.com>
396 * NEWS: Updates for 2.5.2
398 Wed Aug 25 00:22:48 2004 Søren Sandmann <sandmann@redhat.com>
400 * gtk/gtksequence.c: Remove debug spew
402 Wed Aug 25 00:09:07 2004 Søren Sandmann <sandmann@redhat.com>
404 * gtk/gtkliststore.c (gtk_list_store_move_after): Fix logical
405 errors in gtk_list_store_move_before/after(). (#150983, patch by
408 Tue Aug 24 21:46:42 2004 Søren Sandmann <sandmann@redhat.com>
410 * gtk/gtksequence.c (_gtk_sequence_move): Just return if the
411 parameters are identical. (#150159, Robert Ögren)
413 2004-08-24 Matthias Clasen <mclasen@redhat.com>
415 * gtk/gtkaction.c (connect_proxy, disconnect_proxy): Handle
416 action_group being NULL. (#150869, Tommi Komulainen)
418 2004-08-24 Matthias Clasen <mclasen@redhat.com>
420 * gdk/gdkimage.c (allocate_scratch_images): Use the correct
421 index variable. (#150941, Tommi Komulainen)
423 2004-08-24 Matthias Clasen <mclasen@redhat.com>
425 * gtk/gtktreeview.c (gtk_tree_view_node_queue_redraw): Take header
426 height and adjustment into account. (#136496, Pawek Salek)
428 Mon Aug 23 17:19:19 2004 Jonathan Blandford <jrb@redhat.com>
431 * docs/tools/Makefile.am (clean-local): add the doc shooter to the
432 docs dir as an uninstalled helper tool.
434 2004-08-23 Matthias Clasen <mclasen@redhat.com>
436 * gdk/x11/gdkwindow-x11.c (show_window_internal): Make it compile.
438 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Add a
441 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Update
443 (show_window_internal): Update the user time when re-mapping a
444 toplevel window. (#150502, Elijah Newren)
446 2004-08-23 Matthias Clasen <mclasen@redhat.com>
448 Fix #150822, reported by Christian Persch
450 * gtk/gtklabel.c (gtk_label_ensure_layout): Set the layout width
451 appropriately when ellipsized.
452 (gtk_label_size_allocate): Only set the layout width if there
455 2004-08-23 Matthias Clasen <mclasen@redhat.com>
457 * gdk/x11/gdkwindow-x11.c (gdk_window_focus): Support the latest
458 EWMH additions to the _NET_ACTIVE_WINDOW client message
459 format. (#150668, Elijah Newren)
461 Mon Aug 23 01:17:59 2004 Matthias Clasen <maclas@gmx.de>
463 * gdk/gdkrgb.c (gdk_rgb_xpixel_from_rgb_internal): Set unused
464 bits in pixel to 1s in case they are used as alpha; copying
465 code from gdk_colormap_alloc_colors(). (#150466, Rich Wareham)
467 2004-08-22 Philip Langdale <plangdale@vmware.com>
469 * gtk/gtkaction.c (gtk_action_disconnect_proxy): Two signals
470 (gtk_action_sync_property and gtk_action_sync_sensitive) were
471 not being correctly disconnected, leading to actions continuing
472 to affect disconnected proxies. (#150607)
474 2004-08-22 Tor Lillqvist <tml@iki.fi>
476 * gdk/win32/gdkwindow-win32.c (gdk_window_new_internal,
477 gdk_window_new, gdk_window_set_skip_taskbar_hint): Don't show TEMP
478 windows in the Task Manager. Implement by calling
479 gdk_window_set_skip_taskbar_hint(TRUE) on them. (#145481, Tim
482 * gdk/win32/gdkdisplay-win32.c (enum_monitor, gdk_display_open):
483 Report whole of (primary) monitor, including any taskbars.
484 Excluding the taskbar area from the "root window" reported to GDK
485 doesn't seem to be that useful although gdk/win32 had been doing it
486 for a very long time. (#149013, see also #145467 and #148526)
488 Sun Aug 22 16:55:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
491 * gtk/gtkalignment.c:
493 Make enums match property names. Found by a script by Tommi
496 * gtk/gtkpaned.c (gtk_paned_class_init): fix min/max mixup.
498 Sun Aug 22 16:09:49 2004 Soeren Sandmann <sandmann@daimi.au.dk>
500 * gtk/gtkliststore.h (struct _GtkListStore):
501 * gtk/gtkliststore.c (gtk_list_store_init):
502 * gtk/gtkliststore.c (gtk_list_store_insert):
503 * gtk/gtkliststore.c (gtk_list_store_remove):
504 Restore length field; PyGTK and maybe others use it directly.
506 Sun Aug 22 15:46:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
508 * gtk/gtkpaned.c (gtk_paned_class_init):
509 s/CYCLE_HANDLE_FOCUS/CYCLE_CHILD_FOCUS/
511 * gtk/gtkfontbutton.c (gtk_font_button_class_init):
512 s/PROP_SHOW_SIZE/PROP_SHOW_STYLE/
514 Both pointed out by Tommi Komulainen.
516 Sun Aug 22 13:44:53 2004 Soeren Sandmann <sandmann@daimi.au.dk>
518 * gtk/gtkpaned.c (gtk_paned_class_init): Use PROP_MAX_POSITION,
519 not PROP_MIN_POSITION for the max_position property. Fix pointed
520 out by Tommi Komulainen.
522 Sun Aug 22 13:32:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
524 * gtk/gtkliststore.c (gtk_list_store_insert): Normalize the
525 position so we don't create paths with off-list
528 Sun Aug 22 12:04:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
530 * gtk/gtkliststore.c (gtk_list_store_sort_iter_changed): Use the
531 correct tree path (#150289, Morten Welinder).
533 Sun Aug 22 00:08:44 2004 Matthias Clasen <maclas@gmx.de>
535 Fix #150406, reported by Fernando San Martín Woerner, patch
538 * gtk/gtkentrycompletion.c
539 (gtk_entry_completion_default_completion_func): Check that
540 column is of type G_TYPE_STRING before proceeding.
542 Sat Aug 21 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
544 * gtk/gtktreestore.c (gtk_tree_store_swap): Don't use an
545 uninitialized tree iter. (#150414, Torsten Schoenfeld)
547 Sat Aug 21 23:29:54 2004 Matthias Clasen <maclas@gmx.de>
549 Fix #150738, Tomislav Jonjic.
551 * gtk/gtktoolitem.h (GTK_IS_TOOL_ITEM_CLASS):
552 * gtk/gtktoolbutton.h (GTK_IS_TOOL_BUTTON_CLASS):
553 * gtk/gtktoggleaction.h (GTK_IS_TOGGLE_ACTION_CLASS):
554 * gtk/gtkseparatortoolitem.h (GTK_IS_SEPARATOR_TOOL_ITEM_CLASS):
555 * gtk/gtkradiotoolbutton.h (GTK_IS_RADIO_TOOL_BUTTON_CLASS):
556 * gtk/gtkradioaction.h (GTK_IS_RADIO_ACTION_CLASS):
557 * gtk/gtkuimanager.h (GTK_IS_UI_MANAGER_CLASS):
558 * gtk/gtkaction.h (GTK_IS_ACTION_CLASS): Fix macro definitions.
560 Wed Aug 18 17:25:26 2004 Manish Singh <yosh@gimp.org>
562 * demos/testpixbuf-save.c
563 * demos/gtk-demo/hypertext.c: Get rid of some unnecessary casts.
565 * demos/gtk-demo/appwindow.c: Make activate_email and activate_url
566 match the arguments for GtkAboutDialogActivateLinkFunc.
568 Wed Aug 18 16:18:00 2004 Manish Singh <yosh@gimp.org>
570 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): Initialize height
571 from fixed_height before we do anything, so it always has a valid
574 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Fix call
575 to gtk_tree_model_get (missing "," in param list).
577 2004-08-18 Federico Mena Quintero <federico@ximian.com>
583 * gtk/gtkfilechooserdefault.c: Renamed SHORTCUTS_COL_PATH to
584 SHORTCUTS_COL_DATA. Add SHORTCUTS_COL_IS_VOLUME, to determine
585 easily whether the SHORTCUTS_COL_DATA points to a GtkFilePath or a
587 (shortcuts_model_create): Create a boolean column for
588 SHORTCUTS_COL_IS_VOLUME.
589 (shortcuts_reload_icons): Simplify with the use of the
590 SHORTCUTS_COL_IS_VOLUME column. Don't leak the pixbuf.
591 (shortcuts_insert_path): Add the SHORTCUTS_COL_IS_VOLUME data.
592 (shortcuts_free_row_data): New helper function; frees the data
594 (shortcuts_remove_rows): Don't take a callback for freeing the
595 data; free everything here instead. Use
596 shortcuts_free_row_data().
597 (volume_remove_cb): Removed.
598 (remove_bookmark_cb): Removed.
599 (remove_row_cb): Make this a single generic function to delete
601 (shortcuts_add_volumes): Use remove_row_cb().
602 (shortcuts_add_bookmarks): Likewise.
603 (struct _GtkFileChooserDefault): Removed the
604 shortcuts_current_folder_is_volume field.
605 (shortcuts_add_current_folder): Oops, don't free the volume.
606 (remove_current_folder_cb): Removed.
607 (shortcut_find_position): Simplify through the use of the
608 SHORTCUTS_COL_IS_VOLUME column.
609 (remove_selected_bookmarks): Assert that we don't get a volume.
610 (shortcuts_reorder): Likewise; also, plug a leak.
611 (gtk_file_chooser_default_remove_shortcut_folder): Simplify
612 through the use of shortcuts_remove_rows().
613 (gtk_file_chooser_default_list_shortcut_folders): Assert that we
615 (shortcuts_activate_iter): Simplify.
616 (home_folder_handler): Simplify by using
617 shortcuts_activate_iter().
618 (shortcuts_free): New function; frees all the data columns.
619 (gtk_file_chooser_default_finalize): Unref the
620 shortcuts_filter_model and the shortcuts model data first.
622 Wed Aug 18 08:31:17 2004 Manish Singh <yosh@gimp.org>
624 * gtk/gtkiconview.c: Applied patch from Olivier Andrieu to fix
627 * gtk/gtkicontheme.c (gtk_icon_theme_init): xdg_data_dirs should
628 match constness attributes of g_get_system_data_dirs ().
630 2004-08-17 Matthias Clasen <mclasen@redhat.com>
632 * gtk/gtkicontheme.c (gtk_icon_theme_init): Look up icon themes in the
633 directories specified in the icon theme spec: $HOME/.icons,
634 $XDG_DATA_DIRS/icons, /usr/share/pixmaps. Note that GTK+ used to also look
635 in $GTK_DATA_DIR/icons, $GTK_DATA_DIR/pixmaps and /usr/share/icons. (#148694)
638 * gtk/gtkframe.c (gtk_frame_paint): Take widget->state into account when
639 painting the shadows. (#150351, Tim Janik)
641 2004-08-17 Matthias Clasen <mclasen@redhat.com>
643 * gtk/abicheck.sh: No need for INCLUDE_INTERNAL_SYMBOLS anymore.
645 * gdk/gdk.symbols: Don't use #if defined().
647 * gdk/Makefile.am (gdkalias.h):
648 * gtk/Makefile.am (gtkalias.h): Don't use cpp to filter gtk.symbols.
650 * gdk/makegdkalias.pl:
651 * gtk/makegtkalias.pl: Move the #ifdef processing into the perl script, and
652 keep the #ifdefs which differentiate between platforms.
654 * gtk/Makefile.am (gtk_private_h_sources): Remove gtkinternals.h, it is no
657 2004-08-17 Matthias Clasen <mclasen@redhat.com>
659 * tests/testfilechooserbutton.c: Use g_message() throughout, add RTL envar for
662 * gtk/gtkfilechooserbutton.c: Get rid of HAVE_CONFIG_H.
663 (gtk_file_chooser_button_init): Use gtk_drag_dest_add_text_targets().
664 (gtk_file_chooser_button_drag_data_received): Use gtk_selection_data_get_text().
665 (gtk_file_chooser_button_set_dialog): _gtk_file_chooser_entry_set_base_folder()
666 seems to expect a path, not an uri.
667 (update_dialog): Handle g_filename_from_uri() returning NULL, don't free
670 * gtk/gtkfilechooserbutton.h: Minor stylistic changes.
672 2004-08-17 Matthias Clasen <mclasen@redhat.com>
674 * gtk/gtkfilechooserbutton.[hc]: New widget to go along with
675 GtkFontButton and GtkColorButton for use in preference dialogs.
676 Replaces GnomeFileEntry. (#148108, James M. Cape)
678 * gtk/gtk.h: Include gtkfilechooserbutton.h
680 * gtk/Makefile.am (gtk_public_h_sources): Add gtkfilechooserbutton.h
681 (gtk_c_sources): Add gtkfilechooserbutton.c
683 * gtk/gtk.symbols: Add the GtkFileChooserButton symbols.
685 * gtk/gtkfilechooserutils.[hc]: Make the delegate quark available.
687 * gtk/gtkfilechooserentry.[hc] (_gtk_file_chooser_entry_new): Allow
688 to suppress tab-eating using the new eat_tabs argument. Adjust all
691 * tests/testfilechooserbutton.c: Test for GtkFileChooserButton.
693 * tests/Makefile.am (noinst_PROGRAMS): Add testfilechooserbutton
695 2004-08-16 Matthias Clasen <mclasen@redhat.com>
697 * gtk/gtkwidget.c (gtk_widget_render_icon): Doc update.
699 * gtk/gtkiconfactory.c (render_icon_name_pixbuf): When the size is -1,
700 use the available size closest to 48. (#150147)
702 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): Actually return
703 a pointer to the beginning of the sizes array, not the end.
705 2004-08-16 Morten Welinder <terra@gnome.org>
707 * tests/testtreemodel.c (test_run): Comment out mallinfo stuff.
708 Fix g_print %-strings.
710 * gtk/gtksequence.c (_gtk_sequence_set): Fix C99ism.
712 2004-08-16 Christian Rose <menthos@menthos.com>
714 * configure.in: Added "bs" to ALL_LINGUAS.
716 Mon Aug 16 01:35:25 2004 Matthias Clasen <maclas@gmx.de>
719 * gtk/gtkcombobox.[hc]: Add a ::focus-on-click property and
720 change the default behaviour to focus on click.
722 * gtk/gtkbutton.c (gtk_button_set_focus_on_click): Typo fix.
724 Mon Aug 16 01:03:08 2004 Matthias Clasen <maclas@gmx.de>
726 * gtk/gtktextiter.c (gtk_text_iter_set_visible_line_offset):
727 (gtk_text_iter_set_visible_line_index): Count from the
728 beginning of the line, not from the current position. (#150101,
731 2004-08-15 Tor Lillqvist <tml@iki.fi>
733 * gtk-zip.sh.in: Fix typo. The gtk.immodules file had never been
734 included in my zipfiles...!
736 * gtk/gtkfilesystemwin32.c (extract_icon): Improve handling of
737 icon alpha channel (on Windows XP) and mask (older Windows
738 versions). (#148641, Tim Evans)
740 Sun Aug 15 02:31:55 2004 Matthias Clasen <maclas@gmx.de>
742 * gtk/gtkfilesystemunix.c (get_icon_type_from_stat): Make
743 the use of S_ISFIFO and S_ISSOCK conditional. (#150146,
746 2004-08-14 Tor Lillqvist <tml@iki.fi>
748 * gtk/gtkfilechooserdefault.c (shortcuts_append_home,
749 shortcuts_append_desktop, set_local_only)
750 * gtk/gtkfilesystemwin32.c (gtk_file_system_win32_render_icon)
751 * gtk/gtkpathbar.c (find_button_type, _gtk_path_bar_set_file_system):
752 Guard against g_get_home_dir() returning NULL. (#150007)
754 Sat Aug 14 17:56:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
756 * gtk/gtkentry.c (gtk_entry_get_pixel_ranges): New function.
758 * gtk/gtkentry.c (in_selection): New function using
759 gtk_entry_get_pixel_ranges() to determine whether a click is in
760 the selection. Improve entry behavior wrt. dragging and
761 selecting. Bug #143249.
763 Sat Aug 14 17:53:46 2004 Soeren Sandmann <sandmann@daimi.au.dk>
765 * configure.in: Require glib 2.5.2
767 * gtk/gtksequence.[ch]: New internal data structure.
769 * gtk/gtkliststore.[hc]: Reimplement in terms of new data
772 * tests/Makefile.am (testtreemodel_SOURCES):
773 * tests/testtreemodel.c: New test program written by Matthias.
775 2004-08-13 Matthias Clasen <mclasen@redhat.com>
777 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_style_set):
778 Don't install the settings_notify_cb from here, since it
779 may be called before the first screen_changed signal,
780 confusing the logic in gtk_file_chooser_screen_changed().
781 (#148803, Abel Daniel)
783 * gtk/gtkcombobox.c: Make re-sensitivation work
786 * gtk/gtkaction.c (gtk_action_new): Fix the docs.
788 Fri Aug 13 01:06:56 2004 Matthias Clasen <maclas@gmx.de>
790 * gtk/gtktreeview.c (gtk_tree_view_row_inserted):
791 Make fixed height mode handle insertions. (#135955,
792 Michael Vogt, testcase by Tim-Philipp Müller, fix by
795 Fri Aug 13 00:40:18 2004 Matthias Clasen <maclas@gmx.de>
797 * gtk/gtkhandlebox.c: Add missing include.
799 Thu Aug 12 23:52:12 2004 Matthias Clasen <maclas@gmx.de>
801 Fix #149547, Markus Lausser:
803 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate):
804 * gtk/gtkcombobox.c (gtk_combo_box_size_request): Don't
805 crash if size_request or size_allocate are called early.
807 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate): Protect
808 against being allocated too small.
810 Thu Aug 12 21:02:57 2004 Matthias Clasen <maclas@gmx.de>
812 * demos/gtk-demo/appwindow.c (about_cb): Adjust to GtkAboutDialog
815 * gtk/gtkaboutdialog.h:
816 * gtk/gtkaboutdialog.c (gtk_about_dialog_set_email_hook):
817 (gtk_about_dialog_set_url_hook): Add callback data and destroy notify
818 for language bindings. (#149999, Olivier Andrieu)
820 2004-08-12 Matthias Clasen <mclasen@redhat.com>
822 * gtk/gtkfilesystem.c: Underscore-prefix gtk_file_system_module_get_type().
823 * gtk/gtkfilechooserdefault.c: Underscore-prefix shortcuts_model_filter_get_type().
825 * gtk/gtkimmodule.c: Make gtk_im_module_get_type() static.
827 * gtk/gtkinternals.h: Remove the no longer exported get_type functions.
829 Thu Aug 12 01:35:46 2004 Matthias Clasen <maclas@gmx.de>
831 * gtk/gtkiconview.c: Make the icon view accessible by
832 implementing the necessary ATK interfaces. (#149728,
835 Thu Aug 12 00:02:29 2004 Matthias Clasen <maclas@gmx.de
837 * gtk/gtkaction.c (gtk_action_new): Link to information about
838 allowed action names. (#149620, David Malcolm)
840 Wed Aug 11 23:14:25 2004 Matthias Clasen <maclas@gmx.de>
844 * gtk/gtkaction.c (gtk_action_set_sensitive):
845 (gtk_action_set_visible): Add setters for the ::sensitive
846 and ::visible properties of GtkAction. (#149622, David Malcolm)
848 2004-08-11 Federico Mena Quintero <federico@ximian.com>
850 Fix #149422, #143457:
852 * gtk/gtkfilechooserdefault.c
853 (gtk_file_chooser_default_should_respond): Rewrite to take the
854 current focus into account, the contents of the save entry, and
855 the last focus for the shortcuts list.
856 (switch_to_selected_folder): We don't need an assertion on the
859 Wed Aug 11 20:56:00 2004 Matthias Clasen <maclas@gmx.de>
861 * gtk/gtkinternals.h:
862 * gtk/gtk.symbols: Add shortcuts_model_filter_get_type.
864 * gtk/abicheck.sh: Check all symbols.
866 Wed Aug 11 19:20:34 2004 Matthias Clasen <maclas@gmx.de>
868 * gtk/gtktreeview.c (gtk_tree_view_maybe_begin_dragging_row):
869 Don't start a drag if the treeview is only a
870 drag destination. (#149836, Pawel Salek)
872 2004-08-11 Matthias Clasen <mclasen@redhat.com>
874 * gtk/gtktreedatalist.[hc]:
875 * gtk/gtkliststore.c:
876 * gtk/gtktreestore.c: Underscore-prefix
877 gtk_tree_data_list_compare_func.
879 * gtk/gtk.symbols: Remove gtk_tree_data_list_compare_func.
881 * gtk/makegtkalias.pl: No need to include gtktreedatalist.h
884 2004-08-10 Matthias Clasen <mclasen@redhat.com>
887 * gtk/Makefile.am: Define TESTS, not TEST, so that make check
888 actually triggers abicheck.sh.
890 * gdk/makegdkalias.pl:
891 * gtk/makegtkalias.pl: Include glib.h before using glib symbols. D'oh.
893 * gdk/makegdkalias.pl:
894 * gtk/makegtkalias.pl: Protect gtkalias.h by G_HAVE_GNUC_VISIBILITY.
896 * gtk/Makefile.am: Include gtkalias.h in the generated
897 sources gtkmarhalers.c and gtkmarshal.c.
899 * gtk/makegtkalias.pl: Cosmetic fix.
901 * gdk/Makefile.am: Remove the . which was accidentally added
902 to SUBDIRS. Include gdkalias.h in the generated sources
903 gdkenumtypes.c and gdkmarshalers.c.
905 * gdk/makegdkalias.pl: Cosmetic fix.
907 * gdk/Makefile.am: Add gdkalias.h to BUILT_SOURCES.
909 2004-08-09 Hans Breuer <hans@breuer.org>
911 * gtk/makefile.msc.in : autogenerate gtk.def, cleanup
913 * gdk/win32/gdkwindow-win32.c gdk/win32/gdkevents-win32.c :
914 removed long time unused ifdef/ed code (WITHOUT_WM_CREATE),
915 removed duplicated call to gdk_window_set_cursor()
917 Mon Aug 9 15:41:17 2004 Matthias Clasen <maclas@gmx.de>
919 Add hidden aliases for exported symbols which are
920 used internally in order to get rid of many PLT
921 entries. (#145519, Arjan van de Ven)
923 * gdk/Makefile.am: Add rules to generate gdk.def and
924 gdkalias.h from gdk.symbols, and make make check check
925 the abi with abicheck.sh.
927 * gdk/gdk.symbols: New file. Definition of the GDK ABI.
928 The file can be processed by cpp to filter out certain
931 * gdk/abicheck.sh: New file. Script to check the actually
932 symbols exported from libgdk-x11.2.0.so against the symbols
933 found in gdk.symbols.
935 * gdk/makegdkalias.pl: New file. Perl script to generate the
936 header containing the alias definitions for internally used
937 exported symbols from a list of symbols.
939 * gdk/*.c, gdk/x11/*.c: Include gdkalias.h
941 2004-08-09 Morten Welinder <terra@gnome.org>
943 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): Fix C99ism.
945 Mon Aug 9 15:27:01 2004 Matthias Clasen <maclas@gmx.de>
947 * gtk/makegtkalias.pl: Also revert
948 GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API to its old status.
950 Mon Aug 9 15:19:34 2004 Matthias Clasen <maclas@gmx.de>
953 * gdk/gdkrgb.h: Add the exported functions
954 gdk_rgb_colormap_ditherable(), gdk_pointer_grab_info_libgtk_only(),
955 gdk_keyboard_grab_info_libgtk_only() to the appropriate
958 Mon Aug 9 14:24:46 2004 Matthias Clasen <maclas@gmx.de>
960 * gdk/x11/gdkevents-x11.c (gdk_event_send_client_message_to_all_recurse):
963 Mon Aug 9 12:48:04 2004 Matthias Clasen <maclas@gmx.de>
965 Add hidden aliases for exported symbols which are
966 used internally in order to get rid of many PLT
967 entries. (#145519, Arjan van de Ven)
969 * gtk/Makefile.am: Add rules to generate gtk.def and
970 gtkalias.h from gtk.symbols, and make make check check
971 the abi with abicheck.sh.
972 (gtk_private_h_sources): Add gtkinternals.h
973 (gtk_built_private_headers): Add gtkalias.h
974 (gtk_extra_sources): Add gtk.symbols
975 (EXTRA_DIST): Add makegtkalias.pl and abicheck.sh
977 * gtk/gtk.symbols: New file. Definition of the GTK+ ABI.
978 The file can be processed by cpp to filter out certain
981 * gtk/abicheck.sh: New file. Script to check the actually
982 symbols exported from libgtk-x11.2.0.so against the symbols
983 found in gtk.symbols.
985 * gtk/makegtkalias.pl: New file. Perl script to generate the
986 header containing the alias definitions for internally used
987 exported symbols from a list of symbols.
989 * gtk/gtkinternals.h: New file. An uninstalled header listing
990 symbols which must be exported for some reason and do not appear
993 * gtk/*.c: Include gtkalias.h
995 Mon Aug 9 11:49:46 2004 Matthias Clasen <maclas@gmx.de>
997 * gtk/gtkmain.c: Only undef gtk_init_check and gtk_init on win32.
999 Mon Aug 9 10:50:05 2004 Matthias Clasen <maclas@gmx.de>
1001 * gtk/gtkentry.h: Add gtk_entry_layout_index_to_text_index()
1002 and its inverse. The have always been exported and are meant
1005 Mon Aug 9 00:28:34 2004 Matthias Clasen <maclas@gmx.de>
1007 * gtk/gtkicontheme.c (load_svg_at_size): Don't leak the
1010 Mon Aug 9 00:13:03 2004 Matthias Clasen <maclas@gmx.de>
1012 * gtk/gtkaboutdialog.c (icon_set_new_from_pixbufs): Don't
1013 leak the icon source.
1015 Sun Aug 8 23:46:20 2004 Matthias Clasen <maclas@gmx.de>
1017 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Don't
1018 leak a reference to the pixbufs.
1020 Sun Aug 8 23:36:55 2004 Matthias Clasen <maclas@gmx.de>
1022 * gtk/gtkcombobox.c (gtk_combo_box_menu_setup): Ref
1023 and sink the column.
1024 (gtk_combo_box_menu_destroy): Unref the column.
1026 Sun Aug 8 23:35:00 2004 Matthias Clasen <maclas@gmx.de>
1028 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets):
1029 (gtk_drag_dest_add_text_targets): Don't leak a reference
1032 Sun Aug 8 22:52:26 2004 Matthias Clasen <maclas@gmx.de>
1034 * gtk/gtkcombobox.c (find_menu_by_path): Don't stumble over
1035 separators which are not backed by model rows.
1037 Sun Aug 8 11:01:23 2004 Matthias Clasen <maclas@gmx.de>
1039 * gtk/gtkcombobox.c (gtk_combo_box_set_active): Don't leak
1042 2004-08-08 Hans Breuer <hans@breuer.org>
1044 * gtk/gtkdnd.c (gtk_drag_dest_set) : take targets into
1045 account again to allow dnd of other things than text
1047 * gdk/win32/gdkselection-win32.c : offer windows bitmap to
1048 be pasted from clipboard (makes The GIMP 2.1's
1049 "File/Acquire/Paste as New" work, only using gtk+ API)
1051 Sun Aug 8 01:32:36 2004 Matthias Clasen <maclas@gmx.de>
1053 * gtk/gtk.def: Add gtk_cell_renderer_progress_get_type.
1055 Sun Aug 8 01:29:08 2004 Matthias Clasen <maclas@gmx.de>
1057 * gtk/gtk.def: Replace duplicate gtk_tree_view_get_hover_expand
1058 by gtk_tree_view_set_hover_expand.
1060 Sun Aug 8 01:23:08 2004 Matthias Clasen <maclas@gmx.de>
1062 * gtk/gtk.def: Remove the static function gtk_menu_get_private.
1064 2004-08-07 Tor Lillqvist <tml@iki.fi>
1066 * gdk/win32/gdkkeys-win32.c (update_keymap): Don't hardcode
1067 mapping of VK_DECIMAL to GDK_KP_Decimal. Instead, let ToAsciiEx()
1068 map it to what's printed on the keypad decimal key for the current
1069 input locale (keyboard layout). (#149404)
1071 Sat Aug 7 18:19:03 2004 Matthias Clasen <maclas@gmx.de>
1073 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
1074 (shortcuts_list_create): Use GtkTreeViewRowSeparatorFunc
1075 instead of GtkCellRendererSepText. (#147864)
1077 * gtk/gtkcellrendererseptext.[hc]: Removed.
1079 * gtk/Makefile.am: Remove gtkcellrendererseptext.[hc]
1081 Sat Aug 7 18:15:15 2004 Matthias Clasen <maclas@gmx.de>
1083 * gtk/gtkcombobox.c (gtk_combo_box_menu_row_deleted):
1084 (gtk_combo_box_menu_row_inserted):
1085 (gtk_combo_box_menu_row_changed): Correctly handle
1086 insertion and deletion of separators in menu mode.
1088 2004-08-07 Tor Lillqvist <tml@iki.fi>
1090 * gdk/win32/gdkevents-win32.c (handle_configure_event,
1091 gdk_event_translate:WM_WINDOWPOSCHANGED): Add _gdk_offset_{x,y} to
1092 top-level window coordinates, not just in generated
1093 events. (#148526, Robert Ögren)
1095 Sat Aug 7 01:26:08 2004 Matthias Clasen <maclas@gmx.de>
1097 Make the column drag code a bit more robust (still scary,
1098 though). (#106992, Christian Biere)
1100 * gtk/gtktreeview.c (_gtk_tree_view_column_start_drag): Assert
1101 that cur_reorder is NULL here.
1103 * gtk/gtktreeview.c (gtk_tree_view_button_release_drag_column):
1104 Reset cur_reorder to NULL, and only hide drag_highlight_window
1107 2004-08-06 Federico Mena Quintero <federico@ximian.com>
1111 * gtk/gtkfilechooserdefault.c (save_widgets_create): Use a
1112 GtkFileChooserEntry for the file name, rather than a GtkEntry.
1113 (update_chooser_entry): Set the contents of the file chooser entry
1114 rather than the plain entry's.
1115 (gtk_file_chooser_default_set_current_folder): Set the new folder
1117 (gtk_file_chooser_default_set_current_name): Set the name on the
1119 (check_save_entry): Use the file chooser entry rather than the
1122 * gtk/gtkfilechooserentry.c
1123 (_gtk_file_chooser_entry_set_base_folder): Call
1124 gtk_file_chooser_entry_changed() so that we recompute the current
1125 folder based on the new base folder.
1127 2004-08-06 Hans Breuer <hans@breuer.org>
1129 * gdk/win32/gdkwindow-win32.c : make it compile and more
1130 similar to the X11 implementation [backward compatibility
1131 for GDK_WINDOW_TEMP, GDK_INPUT_ONLY (fixes bug #148702),
1132 use the *screen* function variants, dont reparent already
1134 (get_visible_region) : take the win32 part into account
1135 (_gdk_windowing_window_destroy) : remove from handle table
1137 * gdk/win32/gdkdisplay-win32.c : added
1138 gdk_display_(request|supports)_selection_notification ()
1139 with a currently mostly pointless implementation ;-)
1141 * gtk/gtkfilesystemwin32.c (*_to_path) : same changes as on *NIX,
1143 (gtk_file_system_win32_render_icon) : use new GTK_STOCK_DIRECTORY
1145 * gtk/makefile.msc.in demos/gtk-demo/makefile.msc.in
1146 gtk/stock-icons/makefile.msc tests/makefile.msc : updated
1148 * gdk/gdk.def gtk/gtk.def : updated externals
1150 * tests/testiconview.c : remove unneeded dirent.h inclusion
1152 2004-08-06 Matthias Clasen <mclasen@redhat.com>
1154 * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): Fix
1155 an off-by-one error. (#141809, Markku Vire)
1157 * gtk/gtkdnd.c (gtk_drag_dest_set, gtk_drag_source_set): Really
1158 fix the initialization of the target list.
1160 Support XDND v5. (#10220, Owen Taylor)
1162 * gdk/x11/gdkdnd-x11.c: Record the XDND version and whether the
1163 drop was successful in the GdkDragContextPrivateX11 struct.
1164 (xdnd_finished_filter): Store the success status of the drop
1165 for an XDND version 5 interaction. For other versions, always
1166 assume the drop was successful.
1167 (xdnd_check_dest): Return the protocol version.
1168 (_gdk_drag_get_protocol_for_display): Return the protocol version.
1169 (gdk_drag_find_window_for_screen): Store the used protocol version
1170 in the GdkDragContext.
1171 (xdnd_send_enter): Send the used protocol version from the context,
1172 instead of hardwiring 3.
1173 (xdnd_enter_filter): Accept protocol versions >= 3 and store the
1174 used protocol version in the context.
1177 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): New function
1178 to find out whether a drop was successful.
1180 2004-07-28 Robert Ögren <gtk@roboros.com>
1182 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Set x_root
1183 and y_root in button and motion events from the tablet. (#148715)
1185 Thu Aug 5 19:58:08 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1187 * gtk/gtkplug.c (gtk_plug_realize): Call
1188 gdk_window_enable_synchronized_configure()
1190 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): Make
1191 noop if gdk_window_enable_synchronized_configure() has not been
1194 2004-08-04 Matthias Clasen <mclasen@redhat.com>
1196 * gtk/gtkfilechooser.[hc]: Add setter and getter for the
1197 ::show-hidden property. (#145610, Jeff Franks)
1199 * tests/testiconview.c: Add buttons to select and unselect all
1200 nodes, make the popup menu actually work.
1202 * gtk/gtkiconview.c: Make GTK_SELECTION_BROWSE work as intended,
1203 let button 3 presses through to the app, to make popup menus
1206 * tests/Makefile.am: Add testiconview.
1207 * tests/testiconview.c: A test for GtkIconView
1208 * tests/gnome-textfile.png: ...which uses this image.
1210 Wed Aug 4 01:37:57 2004 Matthias Clasen <maclas@gmx.de>
1212 * gtk/gtktreeview.c:
1213 * gtk/gtktreestore.c:
1214 * gtk/gtktreemodelfilter.c:
1215 * gtk/gtknotebook.c: s/childs/children/g.
1217 Wed Aug 4 01:04:48 2004 Matthias Clasen <maclas@gmx.de>
1219 Fix #133446, noticed by Christian Persch:
1221 * gtk/gtkaction.c (gtk_action_class_init): Add a new boolean
1222 property ::visible-overflown.
1223 * gtk/gtkaction.c (gtk_action_create_menu_proxy): Don't create
1224 a menu proxy if visible_overflown is FALSE.
1226 Tue Aug 3 20:16:26 2004 Matthias Clasen <maclas@gmx.de>
1228 * gtk/gtkactiongroup.[hc]: Make the the GtkAction{Toggle,Radio,}Entry*
1229 arguments to the gtk_action_group_add_..._actions() functions const,
1230 since the most common use case is to use a static array. (142334,
1231 Mariano Suarez-Alvarez)
1233 Tue Aug 3 20:03:33 2004 Matthias Clasen <maclas@gmx.de>
1235 * gtk/gtkuimanager.c (get_node): Make gtk_ui_manager_add_ui()
1236 accept paths with a leading "/ui". (#149077, David Malcolm)
1238 Tue Aug 3 19:59:29 2004 Matthias Clasen <maclas@gmx.de>
1240 * gtk/gtkiconview.c: Fix some warnings.
1242 Tue Aug 3 18:38:40 2004 Matthias Clasen <maclas@gmx.de>
1244 * gtk/gtktreemodelfilter.c: Correct the return type
1245 of gtk_tree_model_filter_get_flags(). (#149195, Morten Welinder)
1247 Tue Aug 3 18:16:55 2004 Matthias Clasen <maclas@gmx.de>
1249 Fix #149191, reported by Morten Welinder:
1251 * gtk/gtkmain.c: Include gtkclipboard.h,
1252 * gtk/gtkwidget.h: Declare _gtk_widget_grab_notify, not
1253 _gtk_widget_emit_grab_notify.
1255 Tue Aug 3 14:50:14 2004 Matthias Clasen <maclas@gmx.de>
1257 * gtk/gtkicontheme.c (add_size): Add missing parens.
1258 (#149190, Morten Welinder)
1260 Tue Aug 3 14:29:49 2004 Matthias Clasen <maclas@gmx.de>
1262 * gtk/gtkcombobox.c (gtk_combo_box_menu_fill): Remove
1263 accidentally committed debug code.
1265 Tue Aug 3 01:19:12 2004 Matthias Clasen <maclas@gmx.de>
1267 * gtk/gtkcombobox.c (gtk_combo_box_relayout_item): Optimize
1268 for the case that row_column and col_column are unset.
1269 (#148868, Lorenzo Gil Sánchez)
1271 Mon Aug 2 21:52:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1273 * gdk/x11/gdkwindow-x11.c (ensure_sync_counter): New
1274 function. Make sure the sync counter is recreated when a window is
1275 reparented to become a toplevel. (#148358)
1277 2004-08-02 Matthias Clasen <mclasen@redhat.com>
1279 * tests/testcombo.c: Some trees in combo boxes.
1281 * gtk/gtkcombobox.c: Rework the combo box to handle
1282 tree models. (#139582, Matt Walton)
1284 * gtk/gtktreeview.h:
1285 * gtk/gtktreeview.c:
1286 * gtk/gtktreeprivate.h: Add a new boolean property
1287 ::hover-expand and make the treeview expand/collapse rows
1288 on mouseover if it is set.
1290 * gtk/gtkiconview.h: Remove some erroneous declarations.
1292 * gtk/gtkcellview.c (gtk_cell_view_set_cell_data): Don't
1293 crash if the displayed row is gone.
1295 2004-08-02 Morten Welinder <terra@gnome.org>
1297 * gtk/gtkentry.c (gtk_entry_motion_notify): C99ism.
1299 Mon Aug 2 01:30:03 2004 Matthias Clasen <maclas@gmx.de>
1301 * gtk/gtktextview.[hc]:
1302 * gtk/gtkentry.[hc]: Add a new binding signal ::backspace,
1303 bind it to the backspace key, and make it pay attention
1304 to the Pango backspace_deletes_character
1305 attribute. (#119891, Noah Levitt, patch by Theppitak
1308 Mon Aug 2 01:02:57 2004 Matthias Clasen <maclas@gmx.de>
1310 * gdk/x11/gdkevents-x11.c (gdk_check_wm_state_changed):
1311 (gdk_check_wm_desktop_changed): Add missing error
1312 traps. (#149011, Thomas Leonard)
1314 Mon Aug 2 00:21:26 2004 Matthias Clasen <maclas@gmx.de>
1316 * gtk/gtktextview.c (blink_cb): Add the same warning
1317 that the blink_cb() in GtkEntry already has. (#148733)
1319 Mon Aug 2 00:12:16 2004 Matthias Clasen <maclas@gmx.de>
1321 * gtk/gtkentry.c (gtk_entry_class_init):
1322 (gtk_entry_get_alignment):
1323 (gtk_entry_set_alignment): Document the xalign property
1324 and its getter and setter as 2.4 additions. (#148978,
1327 Mon Aug 2 00:11:31 2004 Matthias Clasen <maclas@gmx.de>
1329 * gtk/gtkuimanager.c (gtk_ui_manager_class_init):
1330 * gtk/gtkactiongroup.c (gtk_action_group_class_init): Use
1331 canonical signal names in doc comments, since gtk-doc won't
1332 pick up signal docs with underscores.
1334 2004-08-01 Matthias Clasen <mclasen@redhat.com>
1336 * configure.in: Post-release version bump
1338 * === Released 2.5.1 ===
1340 Thu Jul 29 16:36:42 2004 Jonathan Blandford <jrb@redhat.com>
1342 * gtk/gtktreeprivate.h: New arguments
1344 * gtk/gtktreeview.c:
1345 (gtk_tree_view_class_init): Add key_release callback
1346 (gtk_tree_view_init): Initialize timeout handler
1347 (gtk_tree_view_unrealize): clear timeout if needed
1348 (gtk_tree_view_key_press): Typeahead support
1349 (gtk_tree_view_key_release): Not used yet -- will be needed for
1351 (gtk_tree_view_search_entry_flush_timeout): Remove typeahead entry
1353 (gtk_tree_view_ensure_interactive_directory):
1354 (gtk_tree_view_real_start_interactive_search):
1355 (gtk_tree_view_search_init):
1356 (gtk_tree_view_start_interactive_search): Typeahead support added.
1357 (gtk_tree_view_search_dialog_hide): Clear timeout and text when we
1360 Sat Jul 31 23:17:44 2004 Matthias Clasen <maclas@gmx.de>
1364 Sat Jul 31 01:13:01 2004 Matthias Clasen <maclas@gmx.de>
1368 * gtk/gtkaction.c: Use the canonical form of signal names
1369 after "notify::". Otherwise, no notification arrives.
1370 GObject should have a warning for that, really. (#148879,
1371 Lorenzo Gil Sánchez)
1373 Sat Jul 31 00:42:08 2004 Matthias Clasen <maclas@gmx.de>
1375 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below):
1376 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_above): Don't
1377 set both states at once. (#148789, Matthew Garrett)
1379 2004-07-30 Matthias Clasen <mclasen@redhat.com>
1381 * gtk/gtkcombobox.c: Don't forget to destroy the row separator
1382 function user data when the combo box is destroyed.
1384 2004-07-30 Matthias Clasen <mclasen@redhat.com>
1386 * gtk/gtkcombobox.h:
1387 * gtk/gtkcombobox.c: Change the api for separators to use a
1388 separator function instead of a boolean column.
1390 * tests/testcombo.c: Update to match the api change.
1392 Fri Jul 30 02:21:41 2004 Matthias Clasen <maclas@gmx.de>
1394 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1395 Fix the positioning of the popup.
1397 Fri Jul 30 00:56:31 2004 Matthias Clasen <maclas@gmx.de>
1399 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_active_changed):
1400 Implement this in terms of gtk_combo_box_get_active_iter(),
1401 instead of gtk_combo_box_get_active().
1403 2004-07-29 Federico Mena Quintero <federico@ximian.com>
1405 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
1406 a field for an "add to shortcuts" menu item.
1407 (popup_menu_detach_cb): Clear out the field.
1408 (file_list_build_popup_menu): Only build the menu here.
1409 (file_list_update_popup_menu): Build the menu, then update the
1410 sensitivity of its items.
1411 (file_list_popup_menu): Use file_list_update_popup_menu().
1412 (bookmarks_check_add_sensitivity): Also set the sensitivity of the
1413 popup menu item. Correctly handle the case for a *single* file.
1415 (bookmarks_add_selected_folder): New helper function; code moved
1416 over from add_bookmark_button_clicked_cb().
1417 (add_bookmark_button_clicked_cb): Use the function above.
1418 (selection_check): Rather than returning a boolean value for
1419 emptiness, actually return the number of selected rows. Also,
1421 (get_selected_path): New helper function.
1423 2004-07-29 Anders Carlsson <andersca@gnome.org>
1425 * demos/gtk-demo/Makefile.am:
1426 * demos/gtk-demo/clipboard.c: (copy_button_clicked),
1427 (paste_received), (paste_button_clicked), (do_clipboard):
1430 2004-07-28 Federico Mena Quintero <federico@ximian.com>
1432 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
1433 Store signal IDs in gulongs, not guints!
1434 (gtk_file_chooser_default_hierarchy_changed): We now monitor the
1435 focus widget on our toplevel to know which widget was last focused
1436 at the time our "should_respond" method gets called.
1437 (shortcuts_activate_selected): New helper function.
1438 (shortcuts_get_selected): New helper function.
1439 (remove_selected_bookmarks): Use shortcuts_get_selected().
1440 (bookmarks_check_remove_sensitivity): Likewise.
1441 (shortcuts_reorder): Likewise.
1442 (shortcuts_activate_iter): Renamed from shortcuts_activate_item().
1443 Activate by iter, not by item number.
1444 (save_folder_combo_changed_cb): Use shortcuts_activate_iter().
1445 (shortcuts_row_activated_cb): Likewise.
1446 (gtk_file_chooser_default_should_respond): If the last focused
1447 widget on the toplevel was the shortcuts list, activate the
1450 2004-07-28 Matthias Clasen <mclasen@redhat.com>
1452 * gdk/linux-fb/gdkprivate-fb.h: Make the fb backend compile against
1453 current freetype. (#148558, Nicolas Deves)
1455 * gtk/gtktreeview.c: Replace the EXPANDER_MAX macro by
1456 ROW_HEIGHT. (#145528)
1458 * gtk/gtkuimanager.c: Warning fixes.
1460 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_background): Fix
1461 prototype mismatch. (#148589, Nicolas Deves)
1463 2004-07-28 Anders Carlsson <andersca@gnome.org>
1465 * gdk/x11/gdkdrawable-x11.c (gdk_draw_rectangle_alpha_libgtk_only):
1466 Cast to 32-bit integers when premultiplying, suggested by Keith Packard.
1468 2004-07-27 Anders Carlsson <andersca@gnome.org>
1470 * demos/gtk-demo/iconview.c: (do_iconview):
1471 Change selection mode to multiple.
1473 * gdk/gdkdrawable.h:
1474 * gdk/linux-fb/gdkdrawable-fb2.c:
1475 (gdk_draw_rectangle_alpha_libgtk_only):
1476 * gdk/win32/gdkdrawable-win32.c:
1477 (gdk_draw_rectangle_alpha_libgtk_only):
1478 * gdk/x11/gdkdrawable-x11.c: (gdk_x11_draw_image),
1479 (get_impl_drawable), (gdk_x11_draw_pixbuf),
1480 (gdk_draw_rectangle_alpha_libgtk_only):
1481 Add gdk_draw_rectangle_alpha_libgtk_only which uses
1482 XRenderFillRectangle on X11. It's stubbed out on the
1483 Win32 and fb backends.
1485 * gtk/gtkiconview.c:
1486 (gtk_icon_view_paint_rubberband):
1487 Use gdk_draw_rectangle_alpha_libgtk_only here.
1489 2004-07-27 Anders Carlsson <andersca@gnome.org>
1491 * gtk/gtkaboutdialog.c: (gtk_about_dialog_init),
1492 (text_view_style_set), (add_credits_page),
1493 (display_credits_dialog), (display_license_dialog):
1494 Remove dialog separators, fix text view background setting,
1495 use Close buttons instead of OK buttons.
1497 2004-07-27 Matthias Clasen <mclasen@redhat.com>
1499 * gtk/gtktreeview.c (gtk_tree_view_ensure_interactive_directory):
1500 Add a frame around the C-f popup to stop it from merging visually
1501 in whatever is underneath.
1503 * gtk/gtkcombobox.h:
1504 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible): New
1505 function necessary to make GtkComboBox accessible. (#132847,
1508 Tue Jul 27 02:34:06 2004 Matthias Clasen <maclas@gmx.de>
1510 * gtk/gtkwidget.c (gtk_widget_dispose): Hide parentless
1511 windows when disposing them. (#133231, Michael Natterer)
1513 2004-07-26 Matthias Clasen <mclasen@redhat.com>
1515 * gtk/gtklabel.c (gtk_label_class_init): Expand the documentation
1516 for GtkLabel::ellipsize.
1518 Mon Jul 26 00:38:27 2004 Matthias Clasen <maclas@gmx.de>
1520 Make the GtkComboBox in list mode scroll if the list is too
1521 large to fit in the popup. (#135543)
1523 * gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Add a
1524 o scrolled window to the popup in list mode.
1525 (gtk_combo_box_list_position): Calculate the height of the
1526 popup so that it fits on the screen, set the scrollbar policy
1527 of the scrolled window appropriately.
1528 (gtk_combo_box_popup): Use the height calculated by
1529 gtk_combo_box_list_position().
1530 (gtk_combo_box_remeasure): Don't add unnecessary padding.
1531 (gtk_combo_box_size_request): But add the focus with here.
1532 (gtk_combo_box_list_setup): Connect to enter notify on the
1533 popup window to activate auto scrolling.
1534 (gtk_combo_box_list_enter_notify): Activate auto scrolling.
1535 (gtk_combo_box_list_button_pressed): Setup a timeout for
1537 (gtk_combo_box_list_scroll_timeout): Timeout function for
1539 (gtk_combo_box_list_auto_scroll): Scroll the list when the
1540 pointer leaves the window.
1542 Sun Jul 25 19:51:17 2004 Matthias Clasen <maclas@gmx.de>
1544 * gtk/gtknotebook.c (gtk_notebook_scroll): Ignore scroll
1545 events from the content of the page. (#148409, Gabriel
1548 Sat Jul 24 21:38:12 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1550 * gtk/gtktoolbar.c (internal_insert_element): Warn if you try to
1551 add a tool item to a toolbar using the deprecated API.
1553 Fri Jul 23 13:04:10 2004 Matthias Clasen <maclas@gmx.de>
1555 * gtk/gtkdnd.c (gtk_drag_dest_set): Revert the change to
1556 initialize target_list to an empty list instead of NULL,
1557 since it broke tree dnd. (#148215, Ernst Persson)
1559 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
1560 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): Instead
1561 handle target list being NULL here.
1563 2004-07-23 Dafydd Harries <daf@muse.19inch.net>
1565 * gtk/gtkradioaction.c:
1566 * gtk/gtkradiobutton.c:
1569 Improve various translatable messages. (#137616)
1571 Fri Jul 23 11:11:10 2004 Matthias Clasen <maclas@gmx.de>
1573 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1574 Align the entry in the same way as the cell. (#136749)
1576 Fri Jul 23 11:01:00 2004 Matthias Clasen <maclas@gmx.de>
1578 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1579 Don't iterate too far up. (#147965, Olivier Sessink)
1581 Fri Jul 23 10:28:43 2004 Matthias Clasen <maclas@gmx.de>
1583 * gtk/gtktreeview.c (gtk_tree_view_finalize):
1584 * gtk/gtkradioaction.c (gtk_radio_action_finalize):
1585 * gtk/gtkfontsel.c (gtk_font_selection_finalize):
1586 * gtk/gtkcellview.c (gtk_cell_view_finalize):
1587 * gtk/gtkcalendar.c (gtk_calendar_finalize):
1588 * gtk/gtkactiongroup.c (gtk_action_group_finalize): Remove
1589 unnecessary checks. (#148175, Morten Welinder)
1591 Thu Jul 22 01:42:16 2004 Matthias Clasen <maclas@gmx.de>
1593 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1594 Add a new :ellipsize property which controls ellipsization of the
1595 rendered text. (#144835, Vincent Untz, patch by Jonathan Blandford
1596 and Anders Carlsson)
1598 * gtk/gtkfilechooserdefault.c (create_file_list): Use ellipsization
1599 for the name column.
1601 Thu Jul 22 01:21:28 2004 Matthias Clasen <maclas@gmx.de>
1603 * gtk/gtkfontsel.c (gtk_font_selection_init): Add additional
1604 accessability relations. (#141804, Padraig O'Briain)
1606 Thu Jul 22 01:16:23 2004 Matthias Clasen <maclas@gmx.de>
1608 * gtk/gtkcombobox.c: Avoid some warnings.
1610 Thu Jul 22 01:05:16 2004 Matthias Clasen <maclas@gmx.de>
1612 * configure.in: Require Pango 1.5.1 (for ellipsisation).
1615 * gtk/gtklabel.c (gtk_label_class_init): Add a new :ellipsize
1616 property which controls ellipsization of the label. (#125250,
1617 Tim Van Wassenhove, patch by James M. Cape)
1619 * tests/testellipsise.c: Simple test for ellipsizsation.
1621 Wed Jul 21 22:46:27 2004 Matthias Clasen <maclas@gmx.de>
1623 * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
1624 list store. (#148134, Crispin Flowerday)
1626 Wed Jul 21 22:35:47 2004 Matthias Clasen <maclas@gmx.de>
1628 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
1629 menu. (#148110, Tommi Komulainen)
1631 Wed Jul 21 22:24:10 2004 Matthias Clasen <maclas@gmx.de>
1633 * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak
1634 tree model and tree row reference. (#148125, Crispin Flowerday)
1636 Wed Jul 21 22:17:06 2004 Matthias Clasen <maclas@gmx.de>
1638 * tests/testcombo.c (main): Don't leak models. (#148128,
1641 Wed Jul 21 21:26:08 2004 Matthias Clasen <maclas@gmx.de>
1643 * gtk/gtkviewport.c (viewport_set_adjustment): Don't leak
1644 the adjustments. (#148089, Tommi Komulainen)
1646 Wed Jul 21 21:20:21 2004 Matthias Clasen <maclas@gmx.de>
1648 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't leak
1649 the adjustments. (#148073, Tommi Komulainen)
1651 Wed Jul 21 21:04:50 2004 Matthias Clasen <maclas@gmx.de>
1653 * gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the
1654 arrow. (#148064, Tommi Komulainen)
1656 2004-07-21 Matthias Clasen <mclasen@redhat.com>
1658 * gtk/gtkcalendar.c: Use the new text target functionality
1659 in GtkTargetList instead of hardcoding a subset of text targets.
1661 Tue Jul 20 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
1663 * gdk/x11/gdkevents-x11.c: Hook up gtk-menu-bar-accel to
1664 an XSetting, Gtk/MenuBarAccel. (#120859, Scott James Remnant)
1666 Tue Jul 20 22:26:29 2004 Matthias Clasen <maclas@gmx.de>
1668 * gtk/gtkfilechooserutils.h:
1669 * gtk/gtktoolbutton.c:
1671 * gtk/gtkicontheme.c:
1672 * gtk/gtkcalendar.c:
1673 * demos/gtk-demo/ui_manager.c:
1674 * demos/gtk-demo/appwindow.c: Remove trailing commas
1675 from enumerations. (#148035)
1677 2004-07-20 Federico Mena Quintero <federico@ximian.com>
1679 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Fix the
1680 documentation comment for the editing-started signal.
1682 * gtk/gtkmarshalers.list: Added VOID:OBJECT,STRING for
1683 GtkCellRenderer::editing-started.
1685 2004-07-20 Matthias Clasen <mclasen@redhat.com>
1687 * tests/testactions.c (main):
1688 * tests/testmerge.c (main): Add some refcount debugging.
1690 * gtk/gtkuimanager.c (update_node, free_node): Ref an sink
1691 all proxies, so that we can properly clean up floating proxies
1692 which the app didn't adopt. (#147926, Tommi Komulainen)
1694 2004-07-20 Matthias Clasen <mclasen@redhat.com>
1696 Allow custom initialization of cell editables. (#147221)
1698 * gtk/gtkcellrenderer.h (struct _GtkCellRendererClass):
1699 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Add a
1700 ::editing-started signal as a hook for setting up the
1702 (gtk_cell_renderer_start_editing): ...and emit it here.
1704 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
1706 * gtk/gtktreeview.c (gtk_tree_view_button_press): Set drag_pos
1707 before grabbing the focus, since we may reenter into
1708 gtk_tree_view_motion_resize_column() which requires drag_pos
1709 to be set. (#147913, Guilherme Salgado, patch by John Finlay)
1711 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
1713 * gtk/gtktreeview.c (gtk_tree_view_enter_notify): Don't
1714 use uninitialized node pointer. (#147911, Peter Zelezny)
1716 Tue Jul 20 04:34:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1718 * configure.in: Bump version number
1720 Sun Jul 18 17:21:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1722 * === Released 2.5.0 ===
1726 * tests/testcombo.c: Fix compilation
1728 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1730 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_popup_completion):
1733 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1735 Make GtkCellView public, since people seem to have uses for it,
1736 it is clean API and we were just conservative in not making it
1737 public initially. At the same time, get rid of GtkCellViewMenuItem,
1738 which doesn't have any function which can't be served by a
1739 GtkMenuItem with a GtkCellView child. (#136637, Padraig O'Briain)
1741 * gtk/gtk.h: Include gtkcellview.h
1743 * gtk/Makefile.am (gtk_public_h_sources):
1745 * gtk/Makefile.am (gtk_private_h_sources):
1746 (gtk_c_sources): Remove gtkcellviewmenuitem.[hc]
1747 * gtk/gtkcombobox.c: Replace all uses of GtkCellViewMenuItem by
1748 GtkMenuItem with a GtkCellView child.
1750 * gtk/gtkcellviewmenuitem.[hc]: Removed.
1752 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1754 Support inline autocompletion in entries (#135953)
1756 * gtk/gtkentryprivate.h:
1757 * gtk/gtkentrycompletion.h:
1758 * gtk/gtkentrycompletion.c (gtk_entry_completion_class_init):
1759 Add a new signal ::insert-prefix which can be used to override
1760 the default inline-completion behaviour. Add two new boolean
1761 properties, :popup_completion and :inline_completion which
1762 determine how the possible completions should be presented.
1763 (gtk_entry_completion_insert_prefix): New function to request
1766 * gtk/gtkentry.c: Add the necessary glue for inline completion.
1768 Sun Jul 18 15:28:24 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1770 * gtk/gtkdnd.c (gtk_drag_source_set, gtk_drag_dest_set): Create an
1771 empty target list if targets is NULL.
1773 * configure.in: Add check for X11/extensions/sync.h. (#147416,
1776 Sun Jul 18 01:24:31 2004 Matthias Clasen <maclas@gmx.de>
1778 * NEWS: Updates for 2.5.0
1780 Sat Jul 17 23:11:04 2004 Matthias Clasen <maclas@gmx.de>
1782 * gtk/gtkiconview.h:
1783 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1784 * gtk/gtkiconview.c (gtk_icon_view_set_orientation):
1785 * gtk/gtkiconview.c (gtk_icon_view_get_orientation):
1786 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
1787 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row):
1788 Add a new :orientation property to determine whether text
1789 is positioned below or beside icons. (#147463)
1791 Sat Jul 17 23:03:30 2004 Matthias Clasen <maclas@gmx.de>
1793 * gtk/gtkiconview.c (gtk_icon_view_paint_item):
1794 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
1795 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row): Draw
1796 focus indicator outside the selection, respect focus
1797 line width. (#147460)
1799 Sat Jul 17 01:17:33 2004 Matthias Clasen <maclas@gmx.de>
1801 * gdk/x11/gdkdnd-x11.c (xdnd_check_dest): Fix a warning
1804 Sat Jul 17 00:48:27 2004 Matthias Clasen <maclas@gmx.de>
1806 Support text/plain selection target (#55117, Owen Taylor)
1808 * gtk/gtkselection.h:
1810 * gtk/gtkselection.c (gtk_target_list_add_text_targets):
1811 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
1812 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): New
1813 functions to facilitate handling of text targets.
1816 * gtk/gtktextview.c: Use the new text target handling
1817 functions instead of hardwiring the list of supported
1818 text targets everywhere.
1820 * gtk/gtkselection.c (gtk_selection_data_get_text):
1821 (gtk_selection_data_set_text):
1822 Support the targets text/plain, text/plain?charset=utf-8
1823 and text/plain?charset=<LOCALE-CHARSET> as outlined in
1825 For text/plain send only ASCII, but accept 8-bit text
1826 and treat it as ISO-8859-1 as specified by the Xdnd spec.
1827 Always send CRLF terminators. Accept either and convert
1828 into the native terminator for the platform.
1830 Fri Jul 16 23:20:34 2004 Matthias Clasen <maclas@gmx.de>
1832 Support themed window icons. (#92346, Calum Benson)
1834 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): New
1835 function to obtain information about the sizes in which an
1839 * gtk/gtkwindow.c (gtk_window_class_init):
1840 (gtk_window_set_icon_name):
1841 (gtk_window_get_icon_name): Add an "icon_name" property
1842 (gtk_window_set_default_icon_name): ...and a default icon name.
1843 (icon_list_from_theme):
1844 (update_themed_icon): New auxiliary functions to create a
1845 list of all available sizes of a themed icon and update the
1846 window icon list from it.
1848 2004-07-16 Matthias Clasen <mclasen@redhat.com>
1850 * gtk/gtkcombobox.c (gtk_combo_box_scroll_event): Make
1851 scrolling work if no item is selected.
1852 (gtk_cell_editable_key_press): Don't eat space.
1854 Add a combo box cell renderer (#139347, Lorenzo Gil Sanchez)
1856 * gtk/gtkcellrenderercombo.[hc]: New Files.
1859 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
1862 * gtk/gtkcombobox.[hc]: Implement GtkCellEditable, add a
1863 :has-frame property for suppressing the frame around
1864 the child and redo the size allocation logic to take
1865 focus width into account.
1867 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_init):
1868 Acknowledge the GtkComboBox:has-frame property and make
1869 the entry fill its allocation vertically.
1871 * gtk/gtkmarshalers.list: Add BOOLEAN:STRING.
1873 * gtk/gtktreeview.c (gtk_tree_view_remove_widget): Queue
1874 a draw here to keep non-widget windows from leaving
1877 2004-07-16 Matthias Clasen <mclasen@redhat.com>
1879 * gtk/gtkcombobox.c (gtk_combo_box_forall): Don't iterate
1880 multiple times over some of the children.
1882 Thu Jul 15 22:19:40 2004 Matthias Clasen <maclas@gmx.de>
1884 Fix #60128, #58307, #144706:
1886 * gtk/gtkstyle.c (gtk_style_real_copy): Handle references
1887 to bg_pixmaps properly.
1888 (gtk_style_real_unrealize): Don't keep dangling references
1890 (gtk_style_attach): Split the loop into two loops, first
1891 looking for a matching style, then for an empty one.
1892 (gtk_style_finalize):
1893 (gtk_style_duplicate): Add comments explaining the handling
1896 Thu Jul 15 20:31:28 2004 Matthias Clasen <maclas@gmx.de>
1898 * gtk/gtkspinbutton.c (start_spinning): Install the timeout
1899 before changing the value, so that a ::value_changed handler
1900 has a chance to remove it. (#122427, Elke Meier)
1902 Thu Jul 15 19:20:05 2004 Matthias Clasen <maclas@gmx.de>
1904 * gdk/x11/gdkgtk+/im-x11.c (_gdk_x11_initialize_locale):
1905 * gtk/gtkcalendar.c (gtk_calendar_class_init): Use 'cannot'
1906 instead of 'can not' in messages. (#144226, Morten Welinder)
1908 2004-07-15 Matthias Clasen <mclasen@redhat.com>
1910 * gtk/gtktreeview.c (gtk_tree_view_class_init):
1911 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1912 Correct the declared default values of several properties
1913 to be in sync with the actual initial values.
1915 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_class_init):
1916 Make spacing a property, correct the declared default values
1917 of several properties to be in sync with the actual initial
1918 values. (#147654, Matthias Clasen)
1920 * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Don't reparent
1921 back to menu->toplevel if it is already gone because we're
1922 shutting down. (#147656, John Cupitt)
1924 2004-07-14 Federico Mena Quintero <federico@ximian.com>
1928 * gtk/gtktreeview.c (gtk_tree_view_bin_expose): Draw a focus
1929 indicator along the edge of the bin_window when the tree is empty.
1930 (grab_focus_and_unset_draw_keyfocus): New helper function.
1931 (gtk_tree_view_button_press): Remove a bit of superfluous code.
1932 Use the helper function to save on duplicated code.
1933 (gtk_tree_view_button_press): Grab the focus if the tree is empty.
1934 (gtk_tree_view_focus): Allow focusing into an empty tree.
1936 2004-07-14 Matthias Clasen <mclasen@redhat.com>
1938 * gtk/gtkaboutdialog.c (add_credits_page): Don't use
1939 gcc extensions for the ternary ?: operator. (#147590,
1942 2004-07-14 Federico Mena Quintero <federico@ximian.com>
1944 Fix #144405, patch by Padraig O'Briain <padraig.obriain@sun.com>:
1946 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): Set the
1947 accessible object name for the tree view.
1948 (create_file_list): Likewise.
1950 Tue Jul 13 21:53:08 2004 Matthias Clasen <maclas@gmx.de>
1952 * gtk/gtkicontheme.c (free_unthemed_icon): Don't leak
1953 no_svg_filename. (#147399, Kjartan Maraas)
1955 2004-07-13 Matthias Clasen <mclasen@redhat.com>
1957 * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_get_neighbor_sizes):
1958 Make this work in RTL context.
1960 2004-07-13 Federico Mena Quintero <federico@ximian.com>
1962 * gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Set a
1963 busy cursor while mounting the volume. Also, ref the chooser
1964 while mounting, as we may re-enter. Fixes #139376.
1966 2004-07-13 Matthias Clasen <mclasen@redhat.com>
1968 * gtk/gtktreeview.c (gtk_tree_view_adjustment_changed):
1969 Prepare to handle composite implementations of
1970 GtkCellEditable, but recursively poking at
1971 allocation->y (hack stolen from GtkCList).
1972 (check_expander_max): Tweak the warning.
1974 * gtk/gtkmain.h: Add gtk_parse_args(), its a public
1975 function. (#147476, Owen Taylor)
1977 * gtk/gtkcombobox.c (gtk_combo_box_popdown): Don't
1978 crash if unrealized.
1980 Tue Jul 13 01:50:06 2004 Matthias Clasen <maclas@gmx.de>
1982 * gtk/gtkaboutdialog.c (display_credits_dialog): Don't
1983 display untranslated translator credits.
1985 Tue Jul 13 01:15:05 2004 Matthias Clasen <maclas@gmx.de>
1987 * gtk/gtkiconview.c: Some documentation updates.
1989 Tue Jul 13 00:40:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1991 * gdk/gdkwindow.c (gdk_window_process_updates_internal): Do an
1992 empty begin_paint_region()/end_paint() for windows without
1995 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_unset_bg,
1996 _gdk_x11_window_tmp_reset_bg): Remove checks for EXPOSURE_MASK.
1998 2004-07-12 Matthias Clasen <mclasen@redhat.com>
2000 * demos/gtk-demo/appwindow.c: Use a GtkAboutDialog.
2002 * gtk/gtkaboutdialog.h:
2003 * gtk/gtkaboutdialog.c: New widget: GtkAboutDialog.
2005 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
2006 * gtk/gtk.h: Add GtkAboutDialog. (#109435, Paolo Borelli,
2007 patch by Matthias Clasen)
2009 * gtk/gtkrc.c (_gtk_rc_init): Apply the gtk-default-menu-item-style
2010 to cell view menu items as well. (#147405, John Cupitt)
2012 * gtk/gtkentrycompletion.c: Warning fixes. (#147420,
2015 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Pop down
2016 first. (#147399, John Cupitt)
2018 Mon Jul 12 01:56:26 2004 Matthias Clasen <maclas@gmx.de>
2020 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
2021 Include the update_counter check in the HAVE_XSYNC condition,
2022 since update_counter isn't present in the !HAVE_XSYNC case.
2024 Mon Jul 12 00:52:04 2004 Matthias Clasen <maclas@gmx.de>
2026 * gtk/stock-icons/Makefile.am:
2027 * gtk/stock-icons/stock_about_{16,24}.png:
2028 * gtk/stock-icons/stock_connect_{16,24}.png:
2029 * gtk/stock-icons/stock_disconnect_{16,24}.png:
2030 * gtk/stock-icons/stock_edit_{16,24}.png:
2031 * gtk/stock-icons/stock_media_forward_{16,24}.png:
2032 * gtk/stock-icons/stock_media_next_{16,24}.png:
2033 * gtk/stock-icons/stock_media_pause_{16,24}.png:
2034 * gtk/stock-icons/stock_media_play_{16,24}.png:
2035 * gtk/stock-icons/stock_media_previous_{16,24}.png:
2036 * gtk/stock-icons/stock_media_record_{16,24}.png:
2037 * gtk/stock-icons/stock_media_rewind_{16,24}.png:
2038 * gtk/stock-icons/stock_media_stop_{16,24}.png:
2039 * gtk/gtkstock.h (GTK_STOCK_ABOUT):
2040 * gtk/gtkstock.h (GTK_STOCK_CONNECT):
2041 * gtk/gtkstock.h (GTK_STOCK_DISCONNECT):
2042 * gtk/gtkstock.h (GTK_STOCK_EDIT):
2043 * gtk/gtkstock.h (GTK_STOCK_MEDIA_FORWARD):
2044 * gtk/gtkstock.h (GTK_STOCK_MEDIA_NEXT):
2045 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PAUSE):
2046 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PLAY):
2047 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PREVIOUS):
2048 * gtk/gtkstock.h (GTK_STOCK_MEDIA_RECORD):
2049 * gtk/gtkstock.h (GTK_STOCK_MEDIA_REWIND):
2050 * gtk/gtkstock.h (GTK_STOCK_MEDIA_STOP):
2051 * gtk/gtkiconfactory.c (get_default_icons):
2052 * gtk/gtkstock.c (builtin_items): Add a number of new stock
2053 items. (#102530, #68015, #109811, Jordi Mallach, Benjamin Otte,
2056 Sun Jul 11 15:24:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2058 Bug 143330, support update counter spec.
2060 * configure.in: Add check for the Sync extension
2062 * gdk/gdkwindow.h: gdk_window_enable_synchronized_configure() and
2063 gdk_window_configure_finished()
2065 * gtk/gtkwindow.c (gtk_window_move_resize): Call gdk_window_finish_configure().
2066 * gtk/gtkwindow.c (gtk_window_realize): Automatically enable
2067 synchronized configures.
2069 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Store current
2070 and pending counter values.
2072 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): New function.
2073 * gdk/x11/gdkwindow-x11.c
2074 (gdk_window_enable_synchronized_configure): New function.
2075 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
2076 Delete update counter.
2077 * gdk/x11/gdkwindow-x11.c (set_wm_protocols): Advertise
2078 _NET_WM_SYNC_REQUEST when Sync is available
2080 * gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Handle
2081 _NET_WM_SYNC_REQUEST messages
2082 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Save counter
2083 value for use by gdk_window_configure_finished() when receiving
2086 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add use_sync flag
2087 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Check if the XSync
2088 extension is available
2089 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_SYNC_REQUEST and
2090 _NET_WM_SYNC_REQUEST_COUNTER to list of supported atoms.
2092 * gdk/linux-fb/gdkwindow-fb.c, gdk/win32/gdkwindow-win32.c: Add
2093 stubs for enable_synchronized_configure() and configure_finished()
2095 Sat Jul 10 23:35:13 2004 Matthias Clasen <maclas@gmx.de>
2097 * gtk/gtkentry.c (paste_received): Make middle-button pasting
2098 work as expected inside the entry. (#116789, Scott Bronson)
2100 Sat Jul 10 22:13:53 2004 Matthias Clasen <maclas@gmx.de>
2102 * gtk/gtktextbuffer.c (gtk_text_buffer_select_range): Update
2103 clipboards. (#142805, Mikael Hallendal)
2105 Sun Jul 11 01:38:48 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2107 * gtk/gtkpaned.c (gtk_paned_expose): Remove clip-region computing
2108 code. Just use &paned->handle_pos.
2110 Sun Jul 11 01:12:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2114 * gtk/gtknotebook.c (gtk_notebook_size_allocate): Remove an
2115 unnecessary redraw..
2117 * gtk/gtknotebook.c (gtk_notebook_page_allocate): Remove some
2120 Sat Jul 10 01:33:25 2004 Matthias Clasen <maclas@gmx.de>
2122 * docs/RELEASE-HOWTO: Updates.
2124 Sat Jul 10 01:55:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2126 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{re|un}set_bg):
2127 Insert checks for root window. The root window is never mapped.
2129 Sat Jul 10 01:06:05 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2131 * gdk/x11/gdkwindow-x11.c (post_unmap): Fix a warning
2132 * gdk/x11/gdkwindow-x11.c (show_window_internal): Actually unset
2135 Sat Jul 10 00:37:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2139 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{un|re}set_bg):
2140 New functions that can do a recursive unset/reset bg.
2142 * gdk/x11/gdkgeometry-x11.c: Remove
2143 gdk_window_tmp_{un|re}set_bg().
2145 * gdk/x11/gdkwindow-x11.c (pre_unmap, post_unmap): New functions
2146 called before and after unmapping a window. They unset the
2147 background of all other windows to prevent flicker from the X
2148 server repainting the background. post_unmap() also invalidates
2149 the parent of the unmapped window to draw it without roundtrips.
2151 * gdk/x11/gdkwindow-x11.c (show_window_internal): Unset
2152 background of newly mapped windows and all desendants to prevent
2155 Fri Jul 9 15:33:55 2004 Manish Singh <yosh@gimp.org>
2157 * gdk/gdkevents.c: have a dummy case GDK_OWNER_CHANGE in switch
2158 statements to avoid gcc warnings about not all enum values handled.
2160 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): ignore should live in
2163 Fri Jul 9 23:26:09 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2167 * gdk/x11/gdkwindow-x11.h (struct _GdkWindowImplX11): Add an
2168 "override_redirect" bit.
2170 * gdk/x11/gdkwindow-x11.c (gdk_window_new): Set it here.
2172 * gdk/x11/gdkwindow-x11.c (gdk_window_move, gdk_window_resize,
2173 gdk_window_move_resize):
2174 Update the local size/position cache
2175 immediately for override redirect windows.
2177 * gdk/x11/gdkwindow-x11.c (show_window_internal): Invalidate
2178 newly mapped child and override redirect windows.
2180 2004-07-09 Federico Mena Quintero <federico@ximian.com>
2184 * gtk/gtkfilesystemunix.c (get_fallback_icon): New helper
2185 function, fetches a stock icon as a fallback.
2186 (gtk_file_system_unix_volume_render_icon): Fall back to a stock
2188 (gtk_file_system_unix_render_icon): Fall back to a stock icon.
2189 Use helper functions rather than being a mega-function.
2190 (get_icon_name_for_directory): Renamed from
2191 get_icon_for_directory().
2192 (get_icon_type_from_path): New helper function; code pulled out
2193 from gtk_file_system_unix_render_icon().
2194 (get_special_icon): Likewise.
2195 (get_icon_for_mime_type): Likewise.
2197 2004-07-09 Federico Mena Quintero <federico@ximian.com>
2199 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Fix typo; tmp_event ->
2202 2004-07-09 Matthias Clasen <mclasen@redhat.com>
2204 * gtk/gtktooltips.c (gtk_tooltips_paint_window): Use the
2205 requisition of the widget instead of relying on the style
2206 drawing function to supply the size of the drawable. (#146531)
2208 2004-07-09 Matthias Clasen <mclasen@redhat.com>
2210 Make GtkEntry work harder to protect passwords: (#143955,
2213 * gtk/gtkentry.c (gtk_entry_destroy): Add a destroy handler
2214 to clear the password even if the widget is leaked.
2216 * gtk/gtkentry.c (gtk_entry_real_delete_text):
2217 * gtk/gtkentry.c (gtk_entry_finalize): Zero out the memory
2220 * gtk/gtkentry.c (gtk_entry_real_insert_text): Zero and free
2221 the old memory instead of just reallocating it.
2223 * gtk/gtkentry.c (gtk_entry_create_layout): Don't leak text
2224 direction information for passwords.
2226 2004-07-09 Matthias Clasen <mclasen@redhat.com>
2228 * gtk/gtkstyle.c: Fix some cases where style functions were
2229 not handling widget == NULL properly. (#146282)
2231 Thu Jul 8 22:38:58 2004 Matthias Clasen <maclas@gmx.de>
2233 * gtk/gtktreeview.c: Improve the EXPANDER_MAX warning.
2235 2004-07-08 Federico Mena Quintero <federico@ximian.com>
2239 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Add a
2240 GError argument. Do check for errors when getting the
2241 GtkFileFolder: get the folder and read the children before
2242 actually creating the model. Removed obsolete code that handled
2243 roots-changed on the file system.
2244 (file_model_node_get_info): Assert that we don't reach the old
2245 case to display file system roots.
2246 (roots_changed_callback): Removed.
2248 * gtk/gtkfilechooserdefault.c (set_list_model): Add a GError
2249 argument, and a boolean return value. Return an error if we
2250 cannot create the file system model. On error, set a NULL model
2252 (gtk_file_chooser_default_set_current_folder): Use the error value
2253 from set_list_model().
2254 (gtk_file_chooser_default_set_property): Set the show_hidden
2255 property only if the browse_files_model exists.
2256 (gtk_file_chooser_default_unselect_path): Only operate if the
2257 browse_files_model exists.
2258 (check_preview_change): Check whether we have the sort_model.
2259 (change_folder_and_display_error): Copy the path we get passed
2260 before using it. There's a comment in there that explains why we
2261 need to copy it; basically, if the passed path belongs to the
2262 model, the model may go away in the middle of this function and
2263 we'll be left with a dangling pointer.
2264 (install_list_model_filter): Assert that the model is not NULL.
2265 (set_current_filter): Check whether the model exists.
2267 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Don't
2268 g_return_if_fail if the model is NULL.
2269 (gtk_tree_selection_get_selected_rows): Likewise.
2270 (gtk_tree_selection_count_selected_rows): Likewise.
2271 (gtk_tree_selection_selected_foreach): Likewise.
2272 (gtk_tree_selection_path_is_selected): Likewise; rather just
2274 (gtk_tree_selection_select_all): Likewise.
2275 (gtk_tree_selection_unselect_all): Likewise.
2276 (gtk_tree_selection_select_range): Do g_return_if_fail() if the
2278 (gtk_tree_selection_unselect_range): Likewise.
2280 * gtk/gtkfilesystemunix.c (fill_in_names): Return immediately if
2281 g_dir_open() fails: there is no need to set the error ourselves,
2282 as g_dir_open() already does it.
2284 2004-07-08 Matthias Clasen <mclasen@redhat.com>
2286 * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Allow
2287 to restore the default search function. (#145365, John Finlay)
2289 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Don't leak
2290 references to the drag context. (#144324, Alex Larsson)
2292 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
2294 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
2295 when a new model is set. (#145566, Dmitry M. Shatrov)
2297 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
2299 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
2300 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
2301 in order to avoid rendering artifacts from misaligned
2302 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
2304 2004-07-07 Matthias Clasen <mclasen@redhat.com>
2306 * gtk/gtktreeview.c:
2307 * gtk/gtktreeview.h: Small documentation fixes.
2309 2004-07-07 Matthias Clasen <mclasen@redhat.com>
2311 Support separators in combo boxes and more generally in tree
2314 * gtk/gtkcombobox.h:
2315 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
2316 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
2317 Add a ::row-separator-column property with getter and setter,
2318 which can indicate a boolean model column to determine which
2319 rows are separators.
2321 * gtk/gtkcombobox.c: Display separator rows as separator menu
2322 items in menu mode, and by using the new treeview separator
2323 functionality in list mode.
2325 * gtk/gtktreeview.h:
2326 * gtk/gtktreeprivate.h:
2327 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
2328 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
2329 Add a callback to determine whether a row is a separator.
2331 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
2332 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
2333 * gtk/gtktreeview.c (validate_row): Use the new callback
2334 to determine whether a row is a separator, and draw it
2335 as a separator then. Since separators should take up less
2336 vertical space than regular rows, this requires removing
2337 the redundant MAX(...,expander_size) calls which appear in
2338 many places. Instead, the MAX() is now only done in
2339 validate_row(), and only if the row is not a separator.
2340 To catch possible side effects of this intrusive change,
2341 I have left EXPANDER_MAX() calls in place of the MAX() calls
2342 which will emit a warning if something breaks. They should
2343 be removed before 2.6.
2345 * gtk/gtktreeselection.c (row_is_selectable): Don't let
2346 separator rows be selected.
2348 * tests/testcombo.c (create_blaat): Add a separator column.
2350 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
2352 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
2353 a 64bit alignment issue. (#144302, Sunil)
2355 2004-07-07 Tor Lillqvist <tml@iki.fi>
2357 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
2358 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
2359 * gdk/win32/gdkproperty-win32.c (find_common_locale,
2360 gdk_property_change)
2361 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
2362 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
2365 * gdk/win32/gdkglobals-win32.c
2366 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
2367 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
2368 atom. Initialize it. Declare it. Drop the variable for the
2371 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
2372 function is supposed to return the string in the locale's charset
2373 and encoding. Use g_convert().
2375 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
2376 string in the locale's charset. Use g_convert().
2378 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
2379 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
2380 GLib's UTF-16 functions instead. Windows uses UTF-16.
2382 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
2383 functions mentioned above.
2385 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
2386 also if the string is of type STRING, i.e. ISO-8859-1, and the
2387 current codepage is 1252, and contains no C1 chars. Accept
2390 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
2391 Mark as static. When storing STRING data, convert to
2393 (gdk_selection_owner_set_for_display): Now that STRING is always
2394 ISO-8859-1, use UTF8_STRING when sending the selection request
2397 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
2400 (gdk_text_property_to_text_list_for_display): Make work more like
2401 X11 version. Do obey the encoding parameter.
2403 (gdk_string_to_compound_text_for_display,
2404 gdk_utf8_to_compound_text_for_display): Don't even pretend
2405 supporting COMPOUND_TEXT.
2407 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
2409 (sanitize_utf8): Zero-terminate string.
2411 2004-07-06 Matthias Clasen <mclasen@redhat.com>
2413 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
2414 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
2416 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
2417 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
2418 fallbacks for gtkfilechooser. Currently these are the same images
2419 as the "new" and "open" items...
2421 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
2423 Fix for #136496, Pawel Salek:
2425 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
2426 a node when it changes in fixed_height mode.
2428 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
2431 2004-07-06 Matthias Clasen <mclasen@redhat.com>
2433 * gtk/gtkmenu.c (gtk_menu_position): Make sure
2434 private->monitor_num is a valid monitor number before
2435 using it. (#139187, Michael Natterer)
2437 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
2439 * gtk/gtkfilechooserdefault.c (popup_position_func):
2440 * gtk/gtkentry.c (popup_position_func):
2441 * gtk/gtktextview.c (popup_position_func): Improve positioning
2442 of keyboard-activated menus with Xinerama.
2444 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
2446 * gtk/gtkuimanager.c (do_updates):
2447 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
2448 when called from an idle handler. (#145429, Jan-Marek Glogowski)
2450 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
2452 * gtk/gtkfilechooserutils.c (delegate_notify): Use
2453 the less efficient g_object_interface_find_property () instead
2454 of the param_id range check, since the GParamSpecs we're
2455 dealing with are the overridden onces on the interface, whose
2456 param_id is always zero. (#145312, Alex Roitman, fix proposed
2459 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
2461 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
2462 virtual method of GtkContainer.
2463 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
2464 method slot of the container class.
2466 2004-07-05 Anders Carlsson <andersca@gnome.org>
2468 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
2469 * gtk/gtkiconview.h:
2470 Use gint, not int in gtk_icon_view_set_markup_column,
2473 2004-07-05 Anders Carlsson <andersca@gnome.org>
2475 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
2476 (gtk_icon_view_real_select_cursor_item),
2477 (gtk_icon_view_real_activate_cursor_item):
2478 * gtk/gtkiconview.h:
2479 Add an "activate_cursor_item" action signal
2480 and bind it to the return key.
2482 2004-07-04 Anders Carlsson <andersca@gnome.org>
2484 * demos/gtk-demo/Makefile.am:
2485 * demos/gtk-demo/gnome-fs-directory.png:
2486 * demos/gtk-demo/gnome-fs-regular.png:
2487 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
2488 (sort_func), (create_store), (item_activated), (up_clicked),
2489 (home_clicked), (do_iconview):
2490 Add a simple file browser based on the icon view.
2493 Add gtk/gtkiconview.h
2495 * gtk/gtkiconview.c: (gtk_icon_view_layout),
2496 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
2497 Fix a few bugs discovered while writing the demo.
2499 2004-07-04 Anders Carlsson <andersca@gnome.org>
2503 * gtk/gtkiconview.h:
2504 Add GtkIconView to the build, remove debugging output.
2506 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
2508 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
2509 (gtk_calendar_drag_data_received): Fix off-by-one error.
2510 GDate month is one-based and GtkCalendar month is zero-based.
2511 (#145134, William Jon McCann)
2513 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
2515 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
2516 somebody tries to move a node after itself in a list of
2517 length 1. (#145291, Sampo Nurmentaus)
2519 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
2521 * docs/faq/gtk-faq.sgml:
2522 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
2525 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
2527 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
2528 and current_height to 0 when ending the embedding. (#143675,
2529 Nickolay V. Shmyrev)
2531 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
2533 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
2534 to the right end of the entry text, even if it ends in combining
2535 marks. (#141728, Theppitak Karoonboonyanan)
2537 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
2539 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
2540 row when unsetting the model. (#138560, Christian Persch)
2542 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
2544 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
2547 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
2549 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
2550 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
2552 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
2554 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
2555 to the event mask, set a scroll_event handler.
2556 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
2557 by switching tabs. (#145244, Gabriel de Perthuis)
2559 2004-07-02 Anders Carlsson <andersca@gnome.org>
2561 * gtk/gtktreeview.c (gtk_tree_view_set_model):
2562 Make sure we check for a NULL model first.
2564 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
2566 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
2567 win32 build problem w/o wintab. Fixed #145242
2569 2004-06-30 Anders Carlsson <andersca@gnome.org>
2571 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
2572 g_return_if_fail to make sure that the model is a GtkTreeModel.
2574 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2576 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
2577 current state, not GTK_STATE_NORMAL
2579 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
2581 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2583 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
2585 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
2587 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
2588 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
2591 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
2593 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
2594 recursion by resetting icon_set->cache before freeing
2595 the cache. (#144947, Tim Janik)
2597 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
2599 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
2600 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
2601 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
2604 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
2606 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
2607 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
2608 last change in the docs.
2610 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
2612 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
2613 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
2614 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
2616 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
2618 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
2619 placement policy for GtkComboBoxEntry to be: if it fits below,
2620 place below, if it fits above place above, else place in the
2621 larger space and scroll so that the scroll arrow appear at the
2622 far end. (#144362, David A. Knight)
2624 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
2626 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
2627 use of &parent_iter. (#145007, John Finlay)
2629 2004-06-25 Bastien Nocera <hadess@hadess.net>
2631 reviewed by: Matthias Clasen <maclas@gmx.de>
2633 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
2634 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
2635 the number of keysyms per keycode is odd. Fixes #144808.
2637 2004-06-25 Matthias Clasen <mclasen@redhat.com>
2639 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
2640 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
2642 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
2644 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
2645 which was mentioned below.
2647 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
2649 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
2650 string change. (#139503, Baris Cicek)
2652 2004-06-22 Federico Mena Quintero <federico@ximian.com>
2654 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
2655 or an Open stock button for the C-l dialog depending on the action
2656 in which the file chooser operates. Fixes #141753.
2658 2004-06-22 Federico Mena Quintero <federico@ximian.com>
2660 Fixes the GTK+ part of #142308:
2662 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
2663 Use filename_to_path().
2664 (gtk_file_system_unix_uri_to_path): Likewise.
2665 (filename_to_path): Use remove_trailing_slash().
2667 2004-06-22 Matthias Clasen <mclasen@redhat.com>
2669 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
2670 for the ::move_cursor signal.
2672 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
2673 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
2676 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
2677 this gets defined for all backends, so linux-fb has a
2678 chance of compiling.
2680 * gdk/x11/gdkgc-x11.c:
2681 * gdk/gdkgc.c: Move function docs inline, add hints about
2682 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
2684 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
2685 for children of the root. (#139785, Jean-François Wauthy,
2686 patch by John Finlay)
2688 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
2689 fix. (#144750, Jeff Franks)
2691 2004-06-21 Michael Natterer <mitch@gimp.org>
2694 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
2695 function public as _gdk_x11_convert_to_format().
2697 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
2698 the pixels from the GdkPixbuf when putting them in the
2699 Xcursor image. Fixes bug #144350.
2701 2004-06-16 Federico Mena Quintero <federico@ximian.com>
2703 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
2704 visible node, free the old path before creating the new one.
2707 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
2709 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
2710 (#144198, Mariano Suárez-Alvarez)
2712 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
2714 * gtk/gtkfilechooserdefault.c: Don't use
2715 contractions like "don't" or "isn't" in error messages.
2716 It isn't nice to use them in log entries either...
2717 (#137774, Morten Welinder, patch by Alexander Winston)
2719 2004-06-11 Federico Mena Quintero <federico@ximian.com>
2723 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
2724 Don't ref the editable node.
2725 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
2726 (_gtk_file_system_model_remove_editable): Ahem, free the node.
2728 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
2729 Added fields for edited_idle and edited_new_text.
2730 (renderer_edited_cb): Queue the
2731 creation of the folder in an idle handler.
2732 (renderer_editing_canceled_cb): Likewise for the cancellation.
2733 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
2735 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
2737 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
2739 2004-06-10 Federico Mena Quintero <federico@ximian.com>
2741 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
2743 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
2744 Refer to gtk_file_chooser_add_shortcut_folder().
2745 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
2746 gtk_file_chooser_add_shortcut_folder_uri().
2748 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
2750 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
2751 the drag before focusing the selected.day.
2752 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
2753 a beginning drag if the widget becomes insensitive.
2755 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
2757 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
2758 spinning before calling arrow_action(), so that a signal
2759 handler triggered from arrow_action() has a chance to
2760 stop the spinning. (#143966, Davyd Madeley)
2762 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
2764 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
2765 typo. (#144070, Kent Sandvik)
2767 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2769 * gtk/gtkmenu.c: Revert the "drag select" part of
2772 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
2774 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
2775 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
2777 2004-06-07 Federico Mena Quintero <federico@ximian.com>
2779 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
2780 from 2003/Sep/12. This kept DnD in tree views within modal
2781 dialogs from working, which is especially bad for the file
2782 chooser. Fixes #135168.
2784 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
2786 Make the entry context menu work in editable text cells. The changes
2787 are based on a patch by Kristian Rietveld, which implemented an
2788 approach outlined by Owen Taylor. (#50075)
2790 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
2791 Ignore focus out if the entry menu is posted.
2792 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
2793 posted, and set up a signal handler to clear the flag if the menu
2795 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
2796 set up a timeout to stop editing if the focus is lost.
2797 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
2798 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
2799 signal on the entry and keep a pointer to the entry.
2800 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
2801 clear the pointer to the entry.
2803 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
2805 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
2806 of the ::language property. (#143802, Owen Taylor)
2808 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
2810 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
2811 (gtk_entry_completion_list_enter_notify),
2812 (gtk_entry_completion_list_motion_notify),
2813 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
2814 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
2815 use it as in the menu code to avoid the initial selection if
2816 the window pops up under the pointer. (Anders Carlsson)
2818 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2820 * tests/testmerge.c: Add a checkbox to queue an
2821 merge/unmerge. Patch from Matthias Clasen.
2823 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
2825 (rebuild_menu): New function that rebuilds the overflow menu and
2826 makes sure it doesn't start or end with a separator.
2827 (toolbar_content_new_tool_item)
2828 (toolbar_content_remove)
2829 (toolbar_content_new_compatibility): Set the rebuild_needed flag
2830 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
2831 have actually overflown an item with a proxy menu item. Also make
2832 sure we rebuild the menu if needed.
2834 Fix #125504, #142377, #143463
2836 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
2837 Obey the "priv->draw" flag. (#143692)
2839 2004-06-04 Matthias Clasen <mclasen@redhat.com>
2841 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
2842 quirk in the button size allocation code.
2844 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
2845 requested for drawing the focus indicator to the child in the
2846 !CAN_FOCUS case. This should fix issues which the Gimp has with
2847 the button allocation changes in 2.4.2.
2849 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
2851 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
2852 length of the entry contents in characters, not in bytes.
2854 * gtk/gtkentry.c (paste_received): Don't pop up the completion
2855 window on paste, noticed by Anders Carlsson.
2857 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
2859 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
2860 values and default value for the ::active property. (#143669,
2863 2004-06-03 Michael Natterer <mitch@gimp.org>
2865 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
2866 instead of accessing item->image->allocation.width/height
2867 directly. Makes widgets which only have a requisition set using
2868 gtk_widget_set_size_request() work and fixes bug #142789.
2870 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2872 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
2873 of sticky right click menus to return.
2875 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2877 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
2878 better handle the "click" case. bug Better fix for #141169.
2880 2004-06-02 Federico Mena Quintero <federico@ximian.com>
2882 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
2883 model is empty. Fixes #143536.
2885 2004-06-02 Matthias Clasen <mclasen@redhat.com>
2887 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
2888 close the dialog on focus out of the size entry. (#143505,
2891 2004-06-02 Federico Mena Quintero <federico@ximian.com>
2895 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
2896 (gtk_fnmatch_intern): Likewise; also implement this option.
2898 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
2900 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
2901 no_leading_period argument of _gtk_fnmatch().
2902 (attempt_file_completion): Likewise.
2904 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
2905 no_leading_period argument of _gtk_fnmatch().
2907 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
2909 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
2912 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
2914 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
2915 allow unless selection mode is multiple. (#142634, John Finlay)
2917 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
2921 * gtk/gtkentrycompletion.h:
2922 * gtk/gtkentrycompletion.c:
2923 * gtk/gtkcombobox.h:
2924 * gtk/gtkcombobox.c: Rename function parameters from
2925 index to index_ to prevent clash with BSD index(). (#143001)
2927 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
2929 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
2930 NULL on an accel label. (#139641, Sam Stephenson, patch by
2933 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
2935 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
2936 lookup finding icons in the wrong prefix. (#143328,
2939 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2943 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
2944 only stay up if you release within 500 milliseconds.
2945 (gtk_menu_shell_button_press): Set the activate_time to the event
2946 time when a button is pressed.
2948 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
2949 Interprete button releases as activate when we have seen both an
2950 enter an a motion event.
2952 2004-06-01 Federico Mena Quintero <federico@ximian.com>
2954 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
2955 dummy node if there is no parent node. Fixes #143362.
2957 2004-05-31 Federico Mena Quintero <federico@ximian.com>
2959 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
2960 newly-created folder. Fixes #138932.
2961 (trap_activate_cb): Only return TRUE if we did handle the event.
2962 Fixes #143359; patch by jylefort@brutele.be.
2964 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
2966 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
2967 docs. (#142892, Tommi Komulainen)
2969 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
2971 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
2972 parent is minimized, porting the fix from 1.2. (#1923, #57182)
2974 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
2976 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
2977 unmapped windows work.
2979 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
2981 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
2984 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
2986 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
2987 Refer to ::update-preview, not ::selection-changed.
2989 2004-05-29 Christian Rose <menthos@menthos.com>
2991 * configure.in: Added "tk" to ALL_LINGUAS.
2993 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
2995 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
2996 messages for common problems. (#137974, Owen Taylor)
2998 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
3000 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
3001 errors. (#143337, Billy Biggs)
3003 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
3005 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
3006 bits within visual->depth that aren't used for color to
3007 1s, in case they are alpha.
3009 2004-05-27 Anders Carlsson <andersca@gnome.org>
3011 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
3012 Make separator rows insensitive.
3014 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
3016 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
3019 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
3021 * gtk/gtkentrycompletion.h:
3022 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
3023 Getter for text_column. Also make ::text_column a property.
3025 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
3027 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
3029 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
3031 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
3032 signal if the box exists.
3034 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
3036 Support insensitive cells in tree views and combo boxes:
3038 * gtk/gtkcellrenderer.h:
3039 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
3041 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
3042 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
3043 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
3044 Support drawing insensitive.
3046 * gtk/gtkcellview.h:
3047 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
3048 function to obtain the cell renderers from a cell view. Also
3049 export gtk_cell_view_set_cell_data().
3051 * gtk/gtktreeselection.c (tree_column_is_sensitive):
3052 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
3053 to determine whether all visible cells in a row are insensitive
3054 and whether a row is selectable. A row is not selectable if the
3055 user function says so or if all visible cells are insensitive.
3056 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
3057 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
3058 Use row_is_selectable().
3060 * gtk/gtkcombobox.c (row_is_sensitive):
3061 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
3062 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
3063 to determine row sensitivity in menu or list mode.
3065 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
3066 to set up sensitivity menu items from the underlying rows.
3068 * gtk/gtkcombobox.c (gtk_combo_box_popup):
3069 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
3070 update_menu_sensitivity().
3072 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
3075 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
3078 * tests/testcombo.c (main): Make some rows insensitive.
3080 2004-05-26 Robert Ögren <gtk@roboros.com>
3082 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
3083 modifiers (shift, ctrl etc) in button and motion events from the
3086 2004-05-26 Robert Ögren <gtk@roboros.com>
3088 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
3089 implementation for extended input devices using last known
3090 device state (#143237)
3092 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
3094 * gtk/gtkframe.c: Move docs inline, fixing them on the
3095 way. (#143029, Steve Chaplin)
3097 2004-05-11 Robert Ögren <gtk@roboros.com>
3099 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
3100 events to windows that want extended input events. (#142943)
3101 (gdk_event_translate): Move check for extended input devices to
3102 propagate, new parameter to propagate.
3103 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
3104 _gdk_input_(un)grab_pointer. (#142943)
3106 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
3107 input grab. [Fix missing update of impl in "dijkstra" event
3108 propagation loop] Drop the parallel "impl" pointer, just use a
3109 cast. Don't propagate beyond windows that want normal input
3111 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
3112 implementation of input grab. (#142943)
3114 2004-05-22 Tor Lillqvist <tml@iki.fi>
3116 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
3117 line. (Spotted by Benoît Carpentier.)
3119 2004-05-18 Matthias Clasen <mclasen@redhat.com>
3121 * configure.in: Check for XFIXES extension.
3123 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
3124 a gboolean have_xfixes member.
3126 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
3127 XFIXES events and set have_xfixes.
3129 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
3130 (GdkEventOwnerChange): New event struct for owner change events.
3131 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
3133 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
3134 XFixesSelectionNotify events into GdkEventOwnerChange events.
3137 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
3138 (gdk_display_request_selection_notification): New api
3139 to support selection ownership notification.
3141 * gtk/gtkclipboard.h:
3142 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
3143 api to handle owner change events.
3144 (clipboard_peek): Refactored out the body of
3145 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
3147 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
3148 by calling _gtk_clipboard_handle_event().
3150 2004-05-18 Matthias Clasen <mclasen@redhat.com>
3152 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
3153 the P_() macros ourselves.
3155 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3156 Restrict the width of the popup to be no larger than the
3157 monitor. (#142678, DmD Ljungmark)
3159 * gtk/gtkbutton.c: Go back to the initial fix for the
3160 focus-overdrawing problem, which was actually correct
3161 according to docs/widget_geometry.txt.
3163 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
3164 arrow size from 11 to 15 to compensate for that.
3166 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
3167 arguments of the ::move-cursor signal. (#142725)
3169 2004-05-17 Matthias Clasen <mclasen@redhat.com>
3173 * gtk/gtkbutton.c (gtk_button_size_request)
3174 (gtk_button_size_allocate, _gtk_button_paint): Allocate
3175 space for the focus rectangle only if necessary. (#142668,
3178 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
3182 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
3183 lines. (#142479, Morten Welinder)
3185 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
3187 * gtk/gtkintl.h (Q_): Add a Q_() macro.
3189 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
3190 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
3191 they are not really needed.
3193 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
3194 instead of hardwired padding, use Q_() for the default label,
3195 compute a reasonable minimal size. (#142571, #142572, #142573,
3196 Tommi Komulainen, Christian Persch)
3198 2004-05-15 Tor Lillqvist <tml@iki.fi>
3200 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
3201 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
3202 time). It is used by the OLE2_DND code, which is unfinished and
3203 presumably horribly broken, but still, let's not make it not
3204 compile on purpose. Silence some gcc warnings in the OLE2_DND
3207 2004-05-14 Matthias Clasen <mclasen@redhat.com>
3209 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
3210 New function to go from tree window to tree coordinates, kept
3211 static for now until we figure out the multiple coordinate
3212 system mess in GtkTreeView API-wise.
3213 (gtk_tree_view_scroll_to_cell): Transform the coordinates
3214 from tree window to tree coordinates, using the new function.
3215 Previously, the x coordinate was wrongly transformed. (#142494)
3217 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
3220 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
3221 modifier bit to mark stock item which need to be freed
3222 eventually. (#140654, Michal Pasternak, Scott Tsai)
3224 2004-05-11 Robert Ögren <gtk@roboros.com>
3226 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
3227 call to g_object_ref in Wintab code. (#138341)
3229 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
3230 including unallocated buffers for event->motion.axes and
3231 event->button.axes, unsigned wraparound problem in the code for
3232 detecting missing press/release events and assigning min instead
3233 of max when setting up axes.
3235 2004-05-12 Matthias Clasen <mclasen@redhat.com>
3237 * tests/testtreeedit.c: Add a progress column.
3239 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
3242 * gtk/gtk.h: Include gtkcellrendererprogress.h.
3244 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
3245 based on the one found in Epiphany.
3247 2004-05-11 Michael Natterer <mitch@gimp.org>
3249 * gtk/gtkcombobox.c (gtk_combo_box_popup)
3250 (gtk_combo_box_menu_button_press): don't allocate the popup
3251 smaller than the combobox. Fixes bug #59660.
3253 2004-05-11 Matthias Clasen <mclasen@redhat.com>
3255 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
3256 previous change to this function, clarify the docs instead.
3258 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
3259 GTK_SELECTION_BROWSE.
3261 * gtk/gtktreeview.c: Make hover selection work for
3262 GTK_SELECTION_BROWSE as well.
3264 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
3266 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
3267 Document the ::toggled signal.
3269 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3271 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
3273 2004-05-10 Matthias Clasen <mclasen@redhat.com>
3275 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
3277 * gdk/gdkdisplay.c (singlehead_...):
3278 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
3279 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
3280 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
3282 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
3283 note about COLUMN_FIXED restriction.
3285 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
3286 Set the entry in the default handler of the ::match-selected signal.
3289 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
3290 do the move-selected-item below pointer thingie, do the
3291 place-below-or-above one.
3293 * tests/testentrycompletion.c: Make the second example use the
3294 ::match-selected signal to make it actually work.
3296 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
3297 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
3298 mode. (#127648, Dave Bordoley)
3300 * gtk/gtktreeview.h:
3301 * gtk/gtktreeview.c: Add a new property "hover_selection", which
3302 when TRUE makes the selection follow the mouse. Also add setter
3303 and getter for the fixed_height property.
3305 2004-05-10 Matthias Clasen <mclasen@redhat.com>
3307 * gtk/gtkcombobox.c (gtk_combo_box_popup)
3308 (gtk_combo_box_menu_button_press): Make sure the menu pops up
3309 as wide as the combobox. (#59660, Havoc Pennington)
3311 2004-05-10 Matthias Clasen <mclasen@redhat.com>
3313 * gtk/gtkcombobox.h:
3314 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
3315 mode). Add a new property, add-tearoffs, for this. (#135956)
3317 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
3318 default button. (#118921)
3320 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3322 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
3323 that emits the grab notify signal.
3325 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
3327 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
3329 * gtk/gtkmenu.c: Make destruction of a torn off menu work
3330 like un-tearing off.
3332 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
3336 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
3337 Allow to suppress the stock accelerator by using "". (#142196,
3340 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
3344 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
3345 In list mode, accept the same mouse/wheel bindings on
3346 the cellview as on the button. (#136967)
3348 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
3350 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
3351 cached icons. (#135888, Crispin Flowerday)
3353 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
3355 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
3356 that we actually return menus for nodes of type menu, not the
3357 menuitems they're attached to.
3359 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
3361 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
3362 Add a note regarding UTF-8 requirements, proposed by
3363 Mariano Suárez-Alvarez.
3365 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
3367 * gtk/gtktearoffmenuitem.h:
3368 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
3369 into the GtkTearoffMenuItem struct, since it is used
3370 by the Gimp, and keep it synchronized with the
3371 tearoff_state property of the parent menu.
3373 2004-05-08 Hans Breuer <hans@breuer.org>
3375 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
3376 create the correct mask for 'pseudo mime' icons
3378 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
3379 take focus_on_map into account
3381 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
3383 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
3384 ... must return a value
3386 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
3388 2004-05-07 Matthias Clasen <mclasen@redhat.com>
3390 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
3391 draw over the focus rectangle.
3393 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
3394 standard focus style. (#63071, Bill Haneman, idea for new
3395 style by Owen Taylor)
3397 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
3398 focus on the colorwheel via details.
3400 2004-05-06 Matthias Clasen <mclasen@redhat.com>
3404 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
3405 this no longer needed signal handler. (#141817, Paul Pogonyshev)
3407 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
3409 * gtk/gtktearoffmenuitem.h:
3410 * gtk/gtktearoffmenuitem.c: Make the tearoff
3411 functionality model/view, the tearoffmenuitem being
3412 the view and the tearoff_state property of the menu
3413 being the model. (#101185, Owen Taylor)
3415 * gtk/gtkmenu.c: Add a tearoff_state property.
3417 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
3421 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
3422 popup the submenu for items in torn off menus. (#122051)
3424 2004-05-06 Sven Neumann <sven@gimp.org>
3426 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
3427 position the title lable next to the arrow just as we do for LTR
3428 rendering. Fixes bug #141825.
3430 2004-05-06 Matthias Clasen <mclasen@redhat.com>
3432 * docs/RELEASE-HOWTO: Document the new policy of
3433 bumping version numbers after release.
3435 * configure.in: Bump version number to 2.5.0.
3437 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
3440 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
3443 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
3445 * gtk/gtkactiongroup.h:
3446 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
3447 New function to translate a string with translate_func.
3450 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
3452 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
3453 (gtk_combo_box_get_row_span_column):
3454 (gtk_combo_box_get_column_span_column): Add missing getters
3455 for readwrite properies. (#135649)
3457 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
3459 * gtk/gtkcombobox.h:
3460 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
3461 Add gtk_combo_box_get_active_text() convenience
3462 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
3464 2004-05-05 Elijah Newren <newren@math.utah.edu>
3466 Changes to support do-not-focus-on-map hint in conjunction with
3467 _NET_WM_USER_TIME (#115650):
3469 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
3472 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
3475 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
3476 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
3478 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
3479 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
3480 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
3481 Initialize the focus_on_map field to TRUE.
3483 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
3484 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
3485 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
3486 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
3487 Implementations for the various backends. The Win32 and linux-fb
3488 implementations set the focus_on_map field, but don't use it yet
3489 to actually implement noinput windows. The X implementation sets
3490 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
3492 * gdk/x11/gdkwindow-x11.h:
3493 * gdk/x11/gdkevents-x11.c (set_user_time):
3494 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
3495 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
3496 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
3497 since we want that function to be part of the public API.
3499 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
3503 * gtk/gtkiconfactory.c (icon_source_clear): Don't
3504 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
3506 2004-05-05 Matthias Clasen <mclasen@redhat.com>
3510 * gtk/gtkuimanager.c (print_node): Make the output
3511 parseable. (#141929, Sven Neumann)
3513 2004-05-05 Tor Lillqvist <tml@iki.fi>
3515 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
3516 multi-monitor offset. (#141842, John Ehresman)
3518 2004-05-04 Federico Mena Quintero <federico@ximian.com>
3520 Fixes #139562, based on a patch by Christian Neumair.
3522 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
3523 a filter_combo_hbox field to contain the filter combo.
3524 (show_filters): Show/hide the filter_combo_hbox.
3525 (create_filename_entry_and_filter_combo): Removed.
3526 (file_pane_create): Create the filter_combo_hbox here.
3528 2004-05-04 Matthias Clasen <mclasen@redhat.com>
3530 * modules/input/gtkimcontextxim.c: Fix the recent
3531 string_conversion_callback change to work on
3532 Solaris. (#141190, Padraig O'Briain)
3534 * gtk/gtkselection.c: Disable debug logging again.
3536 2004-05-03 Matthias Clasen <mclasen@redhat.com>
3538 * gtk/gtkselection.c: Make the chunk size for
3539 incremental transfers depend on the maximal request
3540 size, capped at 256k. This should allow most selections
3541 to be transferred nonincrementally, avoiding many
3542 roundtrips and protocol overhead.
3544 2004-05-03 Federico Mena Quintero <federico@ximian.com>
3546 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
3547 g_signal_new() correctly and initialize the signal fields. Fixes
3548 #141749; patch based on Michael Natterer's.
3550 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
3552 * gtk/gtkselection.c (_gtk_selection_request): Fix
3553 a debug message to show correct information.
3554 (_gtk_selection_incr_event): Make INCRemental transfer
3555 of MULTIPLE targets work. This was broken since 1997!
3557 2004-05-02 Hans Breuer <hans@breuer.org>
3559 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
3560 modify the passed in GdkSegment(s) in place, we may get
3561 them again to draw at the same place. Fixes bug #129095,
3563 (draw_segments) draw the end pixel again to get the
3564 pixmap mask right, fixes bug #126710, #130202
3566 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
3567 fixes bug #106013, John Ehresman
3569 * gtk/makefile.msc.in : don't try to link gtk.res but
3570 use gtk-win32.res (as supposed to be fixed below :)
3572 2004-05-01 Hans Breuer <hans@breuer.org>
3574 * tests/Makefile.am : tests/makefile.msc is in CVS for
3575 a long time, finally added to EXTRA_DIST : fixes bug
3576 #141334, John Ehresman
3578 2004-04-30 Matthias Clasen <mclasen@redhat.com>
3580 * === Released 2.4.1 ===
3582 * configure.in: Version 2.4.1, interface age 1.
3586 2004-04-29 Federico Mena Quintero <federico@ximian.com>
3590 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
3591 function; moved the code over from
3592 remove_bookmark_button_clicked_cb().
3593 (remove_selected_bookmarks): Now, getting a non-removable bookmark
3594 is not an error, as we may be called as a result of hitting the
3596 (shortcuts_key_press_event_cb): New handler; delete the bookmark
3597 if the user presses Backspace, Delete, or KP_Delete.
3599 2004-04-29 Matthias Clasen <mclasen@redhat.com>
3601 * gtk/gtkaction.c (closure_accel_activate): Use
3602 _gtk_action_emit_activate() instead of directly
3603 emitting the activate signal. (#141429, Jody Goldberg)
3605 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
3606 Warn people when the accelerator can not be
3607 parsed. (#141429, Jody Goldberg)
3609 2004-04-29 Matthias Clasen <mclasen@redhat.com>
3611 * tests/testentrycompletion.c (main): Add a missing
3612 cat. (#141070, Chris Sherlock)
3614 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
3615 variable. (#141022, Chris Sherlock)
3617 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
3618 cast. (#141013, Chris Sherlock)
3620 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
3621 unused variable. (#141011, Chris Sherlock)
3623 2004-04-29 Tor Lillqvist <tml@iki.fi>
3625 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
3626 leak. (#140775, John Ehresman)
3628 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
3630 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
3631 to index the cached gcs, not depth. (#139494)
3633 2004-04-28 Matthias Clasen <mclasen@redhat.com>
3635 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
3637 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3639 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
3640 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
3642 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
3644 Patch to add support for string conversion callbacks to
3645 GtkIMContextXIM (#101814)
3647 * modules/input/gtkimcontextxim.c: Set the string conversion callback
3648 if supported by the XIC.
3650 (struct _GtkIMContextXIM): Add string_conversion_callback member.
3652 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
3653 whether string conversion callback is supported.
3655 (gtk_im_context_get_ic, +set_string_conversion_callback,
3656 +string_conversion_callback): Also initialize string conversion
3657 callback, if supported, along with the IC initialization.
3659 * modules/input/imxim.c: Make "xim" module default for Thai as well.
3661 2004-04-23 Matthias Clasen <mclasen@redhat.com>
3663 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
3664 initialize targets. (#139883, John Finlay)
3666 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
3668 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
3669 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
3672 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
3673 Remove an excessive g_return_if_fail().
3675 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
3677 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
3678 _-prefix calls of gdk_x11_window_set_user_time().
3680 2004-04-22 Matthias Clasen <mclasen@redhat.com>
3682 * gtk/gtkuimanager.c (update_node): Make sure the separators
3683 used to demarkate placeholder ends don't show up on
3684 show_all(). (#140496, Murray Cumming)
3686 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
3687 work with negative increments. (#137975, Tim Gerla)
3689 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3691 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
3692 gtk_tool_button_set_icon_widget): Remove the old widget from the
3693 tool button before overwriting it with the new widget.
3695 (#140508, Todd Goyen)
3697 2004-04-22 Tor Lillqvist <tml@iki.fi>
3699 Fix the file chooser on Windows. I can't make it misbehave or
3700 crash any more now. But presumably there are still corner cases
3701 not handled. I haven't really checked behaviour of UNC paths, for
3704 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
3705 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
3708 (gtk_file_system_win32_get_parent): Like the Unix version, assert
3709 filename is absolute, and avoid one unnecessary string allocation
3712 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
3713 letters more correctly.
3715 (gtk_file_system_win32_render_icon): Assure correct syntax is used
3716 for root folder of a drive. (#137962, Morten Welinder)
3718 (filename_is_some_root): New function that accepts also root
3719 without any drive specified.
3721 (filename_is_drive_root): Rename from filename_is_root.
3723 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
3726 2004-04-21 Matthias Clasen <mclasen@redhat.com>
3728 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
3729 completion window if there are no completions anymore.
3731 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3732 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
3733 It doesn't like that. (#140642, Christian Persch)
3735 * demos/gtk-demo/expander.c (do_expander): A new demo.
3737 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
3739 2004-04-20 Matthias Clasen <mclasen@redhat.com>
3741 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
3742 sure anchored children get size allocated, even if the layout
3743 is valid. (#122323, Andrew E. Makeev)
3744 (gtk_text_view_scroll_pages):
3745 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
3746 if we already have pending scrolls. Bandaid fix for #78513.
3748 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
3750 * INSTALL.in: Update libpng and libjpeg URLs, remove
3751 note about building without since that's not the normal
3754 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
3756 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
3757 handling of SVG/non-SVG unthemed icons.
3759 2004-04-19 Morten Welinder <terra@gnome.org>
3761 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
3764 2004-04-19 Matthias Clasen <mclasen@redhat.com>
3766 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
3767 Don't stop the iteration up to the tag_root too
3768 early. (#109945, Dongho Shin)
3770 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3772 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
3773 gdk_keymap_translate_keyboard_state() handle NULL
3774 keymaps. (#139715, Torsten Schoenfeld).
3776 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3778 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
3779 reported by Pedro RODRIGUEZ, about compilation problems when
3780 Xcursor is installed in a non-standard location.
3782 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3784 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
3787 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
3788 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
3790 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
3792 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
3795 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
3796 property on user interaction.
3798 2004-04-15 Federico Mena Quintero <federico@ximian.com>
3800 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
3801 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
3803 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
3804 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
3807 2004-04-15 Matthias Clasen <mclasen@redhat.com>
3809 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
3810 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
3812 2004-04-14 Matthias Clasen <mclasen@redhat.com>
3814 * gtk/gtkcombobox.c:
3816 Make all style properties readonly.
3818 2004-04-14 Matthias Clasen <mclasen@redhat.com>
3820 * gtk/gtkcolorsel.c: Add a11y relations between the color
3821 wheel and the spin buttons. (#132745, Padraig O'Briain)
3823 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
3824 the meaning of size == -1.
3826 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
3827 a size of -1. (#137436, Brian Cameron)
3829 * gtk/gtkcombobox.c: Make the arrow and separator regular
3830 children of an hbox inside the button, and propagate state
3831 changes from the button to the cell view. (part of the fix
3832 for #138650, should also fix #137535)
3834 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
3835 state to gtk_cell_renderer_render() when prelighted. (part
3836 of the fix for #138650)
3838 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
3839 Use PRELIGHT state when appropriate. (part of the fix for
3842 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
3843 out warnings if called before the combo box is
3844 realized. (#139742, Philip Langdale)
3846 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
3848 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
3851 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
3853 * gtk/gtkpathbar.c (make_directory_button): remove spurious
3856 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
3858 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
3859 make the buttons sized by a bold label. This makes the text
3860 'swim' a little, but stops the buttons from resizing, #137210
3862 2004-04-13 Matthias Clasen <mclasen@redhat.com>
3864 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
3866 (start_element_handler): Accept separators without unique
3867 names. (#133302, Anders Carlsson)
3869 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
3870 possible accelerator gotcha when using this function. (#139641,
3873 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
3874 list nodes. (#138862, Morten Welinder)
3876 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
3878 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
3880 (gtk_tree_view_button_press): If we activated the row we don't
3881 want to grab focus back, as moving focus to another widget is
3882 pretty common, #138458
3884 2004-04-12 Federico Mena Quintero <federico@ximian.com>
3886 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
3887 documentation to all the signals.
3889 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
3891 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
3892 model if it is NULL. (#139770)
3894 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
3896 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
3897 a shadow inside the scrolled window, add it around the vbox.
3899 * gtk/gtkentryprivate.h:
3900 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3901 Return a boolean indicating whether the popup is positioned above
3902 or below. Scroll the completions to the beginning or the end,
3903 depending on the positioning.
3905 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
3906 wrap around in the entry completion popup, and allow GDK_UP to
3907 enter the popup. (#137440)
3909 2004-04-12 Matthias Clasen <mclasen@redhat.com>
3911 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
3912 there before using it.
3914 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
3916 * gtk/gtktreeprivate.h: Moved search entries into priv data.
3918 * gtk/gtktreeview.c: Prep for type-ahead support.
3920 (gtk_tree_view_destroy): Destroy the search window explicitly.
3921 (gtk_tree_view_key_press): Minor change; prep for type-ahead
3922 (gtk_tree_view_ensure_interactive_directory): New function
3923 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
3924 (gtk_tree_view_real_start_interactive_search): rework
3925 (gtk_tree_view_search_dialog_hide): ditto
3926 (gtk_tree_view_search_delete_event): ditto
3927 (gtk_tree_view_search_button_press_event): ditto
3928 (gtk_tree_view_search_key_press_event): ditto
3929 (gtk_tree_view_search_move): ditto
3930 (gtk_tree_view_search_init): ditto
3932 * gtk/gtktreeviewcolumn.c:
3933 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
3935 * tests/testfilechooser.c: (main): change
3937 2004-04-11 Hans Breuer <hans@breuer.org>
3939 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
3940 the real fix would involve just another small API breakage,
3941 i.e. gdk_spawn_* using GPid not just gint.
3943 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
3945 2004-04-10 Tor Lillqvist <tml@iki.fi>
3947 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
3948 If both Shift and CapsLock pressed, ignore the shift only for
3949 letters (that would have been affected by the CapsLock). (#139095)
3951 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
3952 seems to be even buggier now than it used to be. (#138341)
3953 Initialize _gdk_input_ignore_wintab to TRUE.
3955 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
3956 GDK_USE_WINTAB environment variable to turn on tablet support.
3958 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
3960 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
3961 (gtk_ui_manager_remove_action_group): Terminate
3962 g_object_[dis]connect() calls with NULL instead of 0.
3965 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
3967 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
3969 2004-04-07 Federico Mena Quintero <federico@ximian.com>
3973 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
3974 passed-in 'str' is not NULL.
3976 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
3977 expands "~/" or "~foo/" at the beginning of a filename.
3978 (gtk_file_system_unix_parse): Use expand_tilde() before doing
3981 * gtk/gtkfilechooserentry.c
3982 (gtk_file_chooser_entry_maybe_update_directory): Take in a
3983 force_reload argument.
3984 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
3985 returns an error, set the file_part_pos to -1.
3986 (load_directory_callback): Only populate the model if the
3987 file_part_pos is not -1.
3989 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
3991 * configure.in: Added Icelandic (is) to ALL_LINGUAS
3993 2004-04-05 Federico Mena Quintero <federico@ximian.com>
3995 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
3996 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
3998 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
3999 for G_DIR_SEPARATOR in the display_name, and err out if it is
4000 present; use the same error message as Nautilus. Fixes #136467.
4002 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
4003 new-folder button say "Create Fo_lder" rather than "Create
4004 _Folder", so that the mnemonic doesn't conflict with the "Save in
4005 _folder" label. Fixes #136975.
4007 2004-04-05 Federico Mena Quintero <federico@ximian.com>
4009 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
4010 buttons. Also, free them correctly upon failure. Based on a
4011 patch by Morten Welinder, fixes #137956.
4013 2004-04-05 Anders Carlsson <andersca@gnome.org>
4015 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
4017 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
4019 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
4020 correctly for fixed height when inserting a node, #138082
4022 2004-04-01 Federico Mena Quintero <federico@ximian.com>
4026 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
4027 "child_is_hidden" boolean argument to the "path-clicked" signal.
4029 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
4031 (make_directory_button): Take a file_is_hidden argument; put it in
4033 (_gtk_path_bar_set_path): See whether each path component path is
4035 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
4036 "path-clicked" signal.
4037 (button_clicked_cb): See if the downwards button represents a
4038 hidden file for the file_is_hidden argument in the signal
4041 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
4043 * gtk/gtkfilechooserdefault.c
4044 (gtk_file_chooser_default_select_path): If we fail to switch
4045 folders, don't try to select the path in the file system model.
4046 Also, return the result from _gtk_file_system_model_path_do().
4047 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
4048 file system model if we are asked to select a hidden file.
4049 (path_bar_clicked): Show hidden files based on whether the
4050 immediate downwards folder in the path bar is a hidden file
4052 (struct _GtkFileChooserDefault): Added fields
4053 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
4054 (create_file_list): Set an object data key of
4055 "GtkFileChooserDefault" on the tree view so that we can find the
4056 impl from the popup menu callbacks. Also, hook up to the
4057 "button-press-event" and "popup-menu" signals in the file list to
4058 bring up a popup menu.
4059 (list_popup_menu_cb): New callback.
4060 (list_button_press_event_cb): New callback.
4064 * gtk/gtkfilesystemmodel.c
4065 (_gtk_file_system_model_new): Oops, connect_object to
4068 2004-03-31 Tor Lillqvist <tml@iki.fi>
4070 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
4071 for native Win32. (#136559, J. Ali Harlow)
4073 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
4074 angles. Thanks to Tim Newsham.
4076 2004-03-29 Federico Mena Quintero <federico@ximian.com>
4080 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
4081 for an ::is_finished_loading() method and a ::finished_loading()
4082 signal at the end of the struct.
4084 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
4085 "finished-loading" signal.
4086 (gtk_file_folder_is_finished_loading): New function.
4088 * gtk/gtkfilesystemunix.c
4089 (gtk_file_folder_unix_is_finished_loading): Implement.
4091 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
4092 slot for a "finished-loading" signal.
4093 (gtk_file_system_model_class_init): Create the "finished-loading"
4095 (struct _GtkFileSystemModel): New field
4096 idle_finished_loading_source. We emit the "finished-loading"
4097 signal in an idle if the root folder was done loading right in
4098 _gtk_file_system_model_new(), so that the caller has a chance to
4099 connect to the signal.
4100 (_gtk_file_system_model_new): Connect to the normal signals of the
4101 folder even if the initial _list_children() fails. Also, see if
4102 the folder is finished loading; connect to the "finished-loading"
4104 (gtk_file_system_model_finalize): Remove the idle handler.
4106 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
4107 and connect to the model's "finished-loading" signal.
4108 (get_toplevel): New helper function.
4109 (error_message): Use get_toplevel().
4110 (trap_activate_cb): Likewise.
4111 (location_popup_handler): Likewise.
4112 (set_busy_cursor): New function.
4113 (browse_files_model_finished_loading_cb): New callback.
4115 2004-03-25 Federico Mena Quintero <federico@ximian.com>
4117 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
4118 file under the cursor; we don't need the logic from
4119 GtkFileSelection after all. Fixes #132255.
4121 2004-03-25 Federico Mena Quintero <federico@ximian.com>
4123 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
4124 location entry with the display name of the file under the cursor
4125 for Open mode, or the typed filename in Save mode.
4127 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4129 * gtk/gtkfilesystemwin32.c
4130 (filename_is_root): Bare drive designators (eg., "c:") are
4131 no longer considered as root filenames. Fixed #137942
4133 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4135 * gtk/gtkfilesystemwin32.c
4136 (gtk_file_system_win32_create_folder): Invert test for error in
4137 mkdir. Fixes #137945
4139 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4141 Fixed #138004 using Federico's code from #132327.
4143 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
4144 folder_hash field to keep a list of live folder objects.
4145 (gtk_file_system_win32_init): Create the folder_hash.
4146 (gtk_file_system_win32_finalize): Destroy the folder_hash.
4147 (gtk_file_system_win32_get_folder): Ref and return an existing
4148 folder if we have it around, otherwise return a new folder object.
4149 (struct _GtkFileFolderWin32): Add a field for the parent file system.
4150 (gtk_file_folder_win32_finalize): Remove the folder from the file
4151 system's hash table.
4152 (gtk_file_system_win32_create_folder): Emit "files-added" on the
4153 newly-created folder's parent. Fixes #138004.
4155 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4157 * gtk/gtkfilesystemwin32.c
4158 (gtk_file_system_win32_get_folder): Test that path is actually
4159 a directory and throw error if not. Fixed bug #137950
4161 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
4163 * gtk/gtkfilesystemwin32.c
4164 (gtk_file_system_win32_volume_get_display_name): Ignore empty
4165 volume labels; assume that GetVolumeInformation would fail if
4166 GetVolumeInformationW does; catches a small memory leak;
4167 pass the buffer size to GetVolumeInformationW in wide
4168 characters instead of bytes. Fixes bug #137543
4169 (list_volumes): Cope with the theoretical possibility of
4170 more than 26 logical drives. Fixes bug #137940
4171 (bookmarks_serialize): Now actually removes bookmarks.
4174 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
4176 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
4178 2004-03-21 Tor Lillqvist <tml@iki.fi>
4180 * gtk/gtkfilesystemwin32.c
4181 (gtk_file_system_win32_volume_get_base_path): Include the
4182 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
4183 NULL for a volume base path, as g_filename_to_uri() requires an
4184 absolute path, and just a drive letter and colon isn't. (#137543)
4186 2004-03-20 Hans Breuer <hans@breuer.org>
4188 * gtk/gtkfilesystemwin32.c : applied the undisputable and
4189 required [due to recent gtkfilesystem internal api semantic
4190 changes] part of patches to fix bug #137543 (Tor Lillqvist,
4193 * gdk/gdkevents-win32.c (handle_configure_event) :
4194 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
4195 GdkWindowObject::x, y with screen coords to make
4196 gdk_window_get_position () return the right thing and thus fix
4197 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
4199 2004-03-19 Federico Mena Quintero <federico@ximian.com>
4201 * Revert the patch to #137520, as 2.4.1 is for conservative bug
4202 fixes only. The patch is attached to the bug report, for
4205 2004-03-19 Morten Welinder <terra@gnome.org>
4207 * gtk/gtkfilechooserdefault.c
4208 (gtk_file_chooser_default_set_current_folder): Test existance of
4209 the path after checking for locality, if needed.
4211 2004-03-19 Federico Mena Quintero <federico@ximian.com>
4215 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
4216 for an ::is_finished_loading() method and a ::finished_loading()
4217 signal at the end of the struct.
4219 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
4220 "finished-loading" signal.
4221 (gtk_file_folder_is_finished_loading): New function.
4223 * gtk/gtkfilesystemunix.c
4224 (gtk_file_folder_unix_is_finished_loading): Implement.
4226 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
4227 slot for a "finished-loading" signal.
4228 (gtk_file_system_model_class_init): Create the "finished-loading"
4230 (struct _GtkFileSystemModel): New field
4231 idle_finished_loading_source. We emit the "finished-loading"
4232 signal in an idle if the root folder was done loading right in
4233 _gtk_file_system_model_new(), so that the caller has a chance to
4234 connect to the signal.
4235 (_gtk_file_system_model_new): Connect to the normal signals of the
4236 folder even if the initial _list_children() fails. Also, see if
4237 the folder is finished loading; connect to the "finished-loading"
4239 (gtk_file_system_model_finalize): Remove the idle handler.
4241 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
4242 and connect to the model's "finished-loading" signal.
4243 (get_toplevel): New helper function.
4244 (error_message): Use get_toplevel().
4245 (trap_activate_cb): Likewise.
4246 (location_popup_handler): Likewise.
4247 (set_busy_cursor): New function.
4248 (browse_files_model_finished_loading_cb): New callback.
4250 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
4252 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
4253 eventbox for expander. (#137564, reported by
4256 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
4258 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
4260 2004-03-17 Morten Welinder <terra@gnome.org>
4262 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
4263 volumes not actually put into the shortcut list.
4265 * tests/prop-editor.c (object_changed): Plug leak.
4267 * tests/testfilechooser.c (main): Plug some leaks and expose
4270 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
4271 object. Fixed #136652.
4273 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
4274 have no screen. Fixes #137260.
4275 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
4276 thereby fixing leak. Fixes #137259.
4278 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
4279 slider buttons have been destroyed.
4280 (gtk_path_bar_remove): Make this work for slider buttons too.
4283 2004-03-15 Morten Welinder <terra@gnome.org>
4285 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
4286 Sanitize and plug leak.
4287 (check_icon_theme): Only do something if the widget has a screen.
4289 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
4291 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
4292 Move the repositioning logic from _gtk_entry_completion() popup
4293 over here. Fixes #137355, reported by Niklas Knutsson.