1 2005-11-04 Tor Lillqvist <tml@novell.com>
3 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
6 2005-11-03 Tor Lillqvist <tml@novell.com>
8 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
9 the Win32 backend, check that GdkDisplay* parameters are equal to
10 _gdk_display instead of using the unnecessarily general
13 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
14 color bitmap to have "color" in their name, for similarity with
15 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
16 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
17 the mask bitmap's contents, ones for those pixels in the color
18 bitmap where the alpha is zero, zero for other pixels. We used to
19 use an uninitialized mask bitmap! This meant that icons and
20 cursors created presumably worked more or less by accident.
21 Totally blank icons with zero alpha everywhere (as used by
22 gtktrayicon.c) definitely did not work as expected.
24 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
26 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
27 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
28 necessary and can be removed from CVS. It has never been mentioned
29 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
30 are used on Win32. One label widget is used (but never shown) as
31 gtk_widget_render_icon() needs a widget.
33 Ifdefs used as necessary in several places. It might be cleaner to
34 split out the backend-specific parts to separate files, or at
35 least collect them into separate blocks in the file.
37 (wndproc): New function. Window procedure to monitor mouse events
38 in the system tray icon. Call gtk_status_icon_button_press() as
40 (create_tray_observer): New function. Creates a hidden window that
41 only serves as a tray icon message observer.
43 * tests/teststatusicon.c (icon_activated): Position the dialog
44 with GTK_WIN_POS_CENTER.
45 (do_quit): New function, hide and unref the GtkStatusIcon, and
47 (popup_menu): Add a Quit menu item that calls do_quit().
49 2005-11-02 Tor Lillqvist <tml@novell.com>
51 * gdk/win32/gdkcolor-win32.c
52 * gdk/win32/gdkscreen-win32.c
53 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
54 fixes. Remove superfluous test for GdkWindow* parameters being
55 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
56 GdkScreen and one GdkDisplay in the Win32 backend, use those
57 variables instead of the getter functions. For GdkDisplay* and
58 GdkScreen* parameters, check that they are equal to the
59 corresponding singleton variables instead of the more general
60 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
62 2005-11-02 Matthias Clasen <mclasen@redhat.com>
64 * gtk/gtktextview.c: Remove some g_return_if_fail() from
65 static functions, replace some others by g_assert().
67 * gtk/gtktextview.c (selection_motion_event_handler)
68 (gtk_text_view_start_selection_drag): Keep track of the original
69 selection boundaries during a drag selection, in order to correctly
70 decide when to extend or shrink the selection. (#320167,
71 reported by Arvind S N, patch by Paolo Borelli)
73 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
74 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
75 manual offset calculations by g_utf8_offset_to_pointer().
76 (#320360, Paolo Borelli)
78 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
80 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
81 nodes via the g_slice_*() API.
82 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
84 2005-11-01 Tor Lillqvist <tml@novell.com>
86 * gdk/win32/gdkprivate-win32.h
87 * gdk/win32/gdkglobals-win32.c
88 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
89 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
90 their declarations, definitions and assignments into a more
91 logical and consistent order.
93 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
94 CF_ prefix for the predefined clipboard format names. Put quotes
95 around registered format names to distinguish them.
97 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
98 immediately with a warning if the property type is STRING, TEXT,
99 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
100 should never pretend to handle on Win32. Handle only UTF8_STRING
101 here, other formats with delayed rendering. Use \uc1 instead of
102 \uc0 when generating Rich Text Format for easier testability on
103 XP, where WordPad misinterprets \uc0 encoded characters. Add more
104 GDK_NOTE debugging output for Clipboard operations.
106 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
107 (gdk_selection_convert): Don't pretent to handle STRING, just
108 UTF8_STRING. Streamline error handling, don't unnecessarily have a
109 GError which then isn't used for anything anyway if it gets set.
110 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
111 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
113 * config.h.win32.in: Sync with what configure produces.
115 * configure.in: Don't look for X_PACKAGES unless building for
116 x11. (#313986, John Ehresman)
118 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
120 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
121 Wondered why there was no ku there before??
123 2005-10-28 Matthias Clasen <mclasen@redhat.com>
125 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
126 window to the toplevels window group. (#319912, Christian Persch)
128 2005-10-28 Kristian Rietveld <kris@gtk.org>
130 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
133 2005-10-28 Matthias Clasen <mclasen@redhat.com>
135 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
136 drag cursors. (#319200, Federico Mena Quintero)
138 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
139 Shift-G to go to the previous match, like firefox. (#320061, Christian
142 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
143 C99ism. (#320000, Kazuki Iwamoto)
145 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
146 stars. (#319985, Bastien Nocera)
148 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
149 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
151 2005-10-26 Michael Natterer <mitch@imendio.com>
155 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
156 make sure that setting any of pixbuf/stock-id/icon-name resets the
157 others because they are mutually exclusive, and that unsetting any
158 of them only resets the pixbuf and nothing else. Also added
159 some missing g_object_notify().
161 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
162 g_value_set_object().
164 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
165 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
166 g_object_notify ("pixbuf").
168 2005-10-27 Matthias Clasen <mclasen@redhat.com>
170 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
171 careful about initializing cell_area. (#319382, Tommi
174 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
175 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
177 * demos/gtk-demo/clipboard.c (paste_received): Only set the
178 text if it is not NULL. (#319930, Thomas Klausner)
180 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
181 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
183 2005-10-26 Matthias Clasen <mclasen@redhat.com>
185 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
186 * gtk/gtkthemes.c (gtk_theme_engine_load):
187 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
188 when dlopening modules. (#319557, Laszlo Peter)
190 2005-10-26 Matthias Clasen <mclasen@redhat.com>
192 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
193 segments when determining text direction. (#319065, Tommi Komulainen)
195 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
196 on duplicate destroy. (#318953, Gustavo Carneiro)
198 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
199 Point out that destroy-with-parent is a bad idea for the dialog
200 passed to this function. (#318943, Christian Persch)
202 * */Makefile.am: use $(GLIB_MKENUMS) instead of
203 glib-mkenums. (#318582, Damien Carbery)
205 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
206 docs. (#317682, Christian Neumair)
208 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
209 seem to affect the placement of the data in the readonly
210 section, and causes problems with some compilers. (#317844)
212 2005-10-25 Matthias Clasen <mclasen@redhat.com>
214 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
215 Fix some issues with background drawing in RTL. (#318781,
219 * tests/testentrycompletion.c: Apply a patch by Christian
220 Persch to add property editors.
222 * gtk/gtkstatusicon.c: Emit activate on single-click,
223 not on double-click, change proposed by Milosz Derezynski.
225 2005-10-25 Kristian Rietveld <kris@gtk.org>
227 Fixes #311955, reported by Markku Vire; and a lot more.
229 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
230 Levels can now have invisible nodes cached, functions have been
231 rewritten/refactored to take this into account; also the logic in
232 some functions has been corrected.
234 Each referenced node now references all visible children or a single
235 invisible child, in order to be able to monitor all changes in the
236 child model required for correct operation.
238 When a virtual root is set, all nodes on the virtual root level are
241 At last, a bunch of random bug fixes and comment updates.
243 2005-10-25 Matthias Clasen <mclasen@redhat.com>
245 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
246 more docs. (#319722, Paolo Borelli)
248 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
249 initialization of screen_x11->xft_rgba more explicit. (#319627,
252 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
253 in a blurb. (#319499, Francisco Javier F. Serrador)
255 2005-10-24 Matthias Clasen <mclasen@redhat.com>
257 Add settings to hide the input method and Unicode control character
258 submenus in the context menus of GtkEntry and GtkTextView.
260 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
262 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
264 * gtk/gtktextview.c (popup_targets_received):
265 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
267 2005-10-24 Kristian Rietveld <kris@gtk.org>
269 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
270 row-has-child-toggled when the level is not in the cache does not
271 make sense. (This bug probably crept in during the early stages
272 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
274 (gtk_tree_model_sort_real_unref_node): only get the child iter
275 when we will actually also use it.
277 2005-10-22 Michael Natterer <mitch@imendio.com>
279 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
280 widget being realized, in addition to being visible, to avoid
281 running into precondition check in gtk_tree_view_get_cell_area().
284 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
286 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
287 Experimentally, scrollbar steppers can shrink to 8 pixels on
288 Win32. Reflect that in the theme.
289 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
290 there is a 1-pixel border between a scrollbar and its child
291 in ScrolledWindows on Win32. Reflect that in the theme.
293 2005-10-20 Matthias Clasen <mclasen@redhat.com>
295 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
296 for the selection window. (#318806, Alex Larsson)
298 2005-10-18 Federico Mena Quintero <federico@ximian.com>
302 * tests/autotestfilechooser.c
303 (test_button_folder_states_for_action): Test that we have either
304 $cwd or the explicitly-set folder.
305 (test_reload_sequence): Likewise.
307 * gtk/gtkfilechooserdefault.c
308 (gtk_file_chooser_default_get_current_folder): If our reload_state
309 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
311 2005-10-14 Tor Lillqvist <tml@novell.com>
313 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
314 It didn't really do anything useful, and was just confusing and
315 incomplete. Comments claimed we don't do delayed rendering, but in
316 fact we do, for images. (The delayed rendering code has other
317 problems, though, see #168173.) The clipboard viewer code was
318 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
319 the message when necessary). It was just test code, it said so in
320 a comment. Add something similar back later if necessary.
322 (_win32_on_clipboard_change,
323 _gdk_win32_register_clipboard_notification): Remove.
325 (gdk_display_supports_selection_notification,
326 gdk_display_request_selection_notification): Always just return
327 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
329 2005-10-13 Tor Lillqvist <tml@novell.com>
331 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
332 Alt-Enter specially. It does not have any special meaning and
333 should be passed on to the application. (#318378, Tim Evans)
335 2005-10-13 Tor Lillqvist <tml@novell.com>
337 Set visual depth to 24 for 32 bits-per-pixel devices on
338 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
339 optimized composite_0888() function rather than the slower image
340 dithering functions to draw pixbufs (#313993, John Ehresman)
342 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
343 _gdk_windowing_get_bits_for_depth() to initialize
344 GdkImage::bits_per_pixel.
345 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
347 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
348 _gdk_windowing_get_bits_for_depth() to initialize
349 BITMAPINFOHEADER::biBitCount.
351 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
352 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
355 2005-10-12 Stefan Kost <ensonic@users.sf.net>
357 * demos/gtk-demo/appwindow.c: (about_cb):
358 use PACKAGE_VERSION,bump year (#318654)
360 2005-10-11 Matthias Clasen <mclasen@redhat.com>
362 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
363 toggle here with the matching on toggle if it immediately follows.
364 This is a common case, and handling it here prevents quadratic blowup
365 in cleanup_line() below. (#317125)
367 * gtk/gtktextsegment.h:
368 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
369 the character counts into this function instead of computing them
372 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
374 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
376 * gtk/gtkfilechooserdefault.c
377 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
378 when the shortcut already exists in the sidebar. (#147521)
380 2005-10-09 Matthias Clasen <mclasen@redhat.com>
382 * tests/testcombo.c: Demonstrate how to use custom widgets in
385 2005-10-07 Federico Mena Quintero <federico@ximian.com>
389 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
390 the the result of gtk_file_chooser_get_folder() is NULL or
391 non-NULL at the right times. Log the tests.
392 (test_button_folder_states): New test for the initial states of
393 the current folder in GtkFileChooserButton.
394 (main): Test that the number of warnings/errors/critical errors is
397 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
398 Clarify the documentation on when this can return NULL.
399 (gtk_file_chooser_get_current_folder_uri): Likewise.
401 * gtk/gtkfilechooserbutton.c (struct
402 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
403 we use it to keep track of whether a folder has been set.
404 (gtk_file_chooser_button_map): Implement. If no folder has been
405 loaded before, we at least try to load $cwd here.
406 (gtk_file_chooser_button_constructor): If the construct-time
407 dialog already has a folder set, turn on our folder_has_been_set
409 (dialog_current_folder_changed_cb): Turn on our
410 folder_has_been_set flag.
412 2005-10-07 Michael Natterer <mitch@gimp.org>
414 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
415 PROFILE_FILE_CHOOSER because they break compilation after the
416 removal of <unistd.h>.
418 2005-10-07 Matthias Clasen <mclasen@redhat.com>
420 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
421 by moving it out of the profiling ifdef.
423 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
424 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
426 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
427 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
430 2005-10-06 Matthias Clasen <mclasen@redhat.com>
433 * gtk/gtktextbuffer.h:
434 * gtk/gtktextbuffer.c: Add a readonly has-selection property
435 with a getter. (#318161, Paolo Borelli)
437 2005-10-05 Matthias Clasen <mclasen@redhat.com>
439 * README.in: Start collecting release notes for 2.10.
441 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
442 leak fix, since the assertion failures were traced to
443 an xchat bug. (#314696)
445 * gtk/gtkstyle.c (gtk_style_detach):
446 (gtk_style_attach): Documentation improvements.
447 (gtk_style_detach): Assert that the attach_count is > 0.
449 2005-10-04 Federico Mena Quintero <federico@ximian.com>
451 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
452 shortcut position, not a ShortcutsIndex, to make the function more
454 (home_folder_handler): Pass the resolved index to
455 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
456 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
457 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
458 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
459 make the respective key switch to the first, second, ..., tenth
461 (quick_bookmark_handler): Implement.
463 2005-10-04 Federico Mena Quintero <federico@ximian.com>
465 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
466 Desktop; just use their real names on the file system for the
469 * gtk/gtkfilechooserdefault.c
470 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
471 binding signal, and bind it to M-d by default.
472 (desktop_folder_handler): Implement the default handler.
473 (home_folder_handler): Use a helper function.
474 (switch_to_shortcut): New helper function.
475 (shortcuts_append_home): Don't special-case the name of "Home";
476 just use the folder name.
478 2005-10-04 Tor Lillqvist <tml@novell.com>
480 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
481 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
483 2005-10-04 Matthias Clasen <mclasen@redhat.com>
485 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
486 from yesterday, since it leads to assertion failures. (#317879,
489 2005-10-03 Matthias Clasen <mclasen@redhat.com>
491 * gtk/gtkcalendar.c (gtk_calendar_init): Call
492 calendar_compute_days() after setting priv->week_start.
494 2005-10-03 Matthias Clasen <mclasen@redhat.com>
496 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
497 removing it from the hash table. (#314696, Benjamin Berg)
499 2005-10-01 Tor Lillqvist <tml@novell.com>
501 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
502 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
503 is that the the desktop isn't visible because the session has been
504 switched, the screen is locked, or a terminal server session
505 disconnected, so no error message necessary. (#137796)
507 It is of course remotely possible that BitBlt() failing with
508 ERROR_INVALID_HANDLE might also be caused by some other
509 problem. We could strive for perfection and track whether the
510 desktop is visible by using WTSRegisterSessionNotification() and
511 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
512 this issue, though. If we would track desktop visibility, we
513 should then avoid even trying to update the display at all while
514 the desktop isn't visible.
516 2005-09-30 Matthias Clasen <mclasen@redhat.com>
518 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
519 to correct the calculations for the first week day. We may
520 just have to remove this code if too many locales turn out
523 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
524 some cases. (#317611, Tommi Komulainen)
526 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
527 Prevent overflow when storing size hints in an unsigned
528 short variable. Tracked down by Ray Strode and Søren Sandmann.
530 2005-09-29 Matthias Clasen <mclasen@redhat.com>
532 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
535 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
536 grab shadowed. (#317332)
538 2005-09-29 Tor Lillqvist <tml@novell.com>
540 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
542 2005-09-28 Federico Mena Quintero <federico@ximian.com>
544 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
545 if the unmap test fails.
546 (test_reload_sequence): Use gtk_widget_show_now() instead of
547 gtk_widget_show() for the dialog.
548 Thanks to Tim Janik for noticing these.
550 2005-09-28 Federico Mena Quintero <federico@ximian.com>
552 * tests/testcellrenderertext.c: New file with a set of tests for
553 GtkCellRendererText. The idea is to run a text renderer through
554 most of its interesting property values to see that it works
557 * tests/Makefile.am: Added testcellrenderertext.
559 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
560 entry/exit of this function for profiling.
561 (gtk_file_chooser_default_style_set): Mark the start/end of the
562 calls to the parent class and the the signal emission for profiling.
564 2005-09-29 Tor Lillqvist <tml@novell.com>
566 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
567 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
568 system codepage using g_win32_locale_filename_from_utf8().
569 (#317457, Kazuki Iwamoto)
571 2005-09-28 Matthias Clasen <mclasen@redhat.com>
573 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
574 here. (#317039, Paolo Borelli)
577 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
578 to make this function work as boxed copy function. (#317455,
581 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
582 NULL. (#316828, Tor Lillqvist)
584 2005-09-28 Tor Lillqvist <tml@novell.com>
586 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
589 2005-09-27 Federico Mena Quintero <federico@ximian.com>
591 Don't reload the current folder unnecessarily on ::map().
593 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
595 (struct _GtkFileChooserDefault): Added a "reload_state" field.
597 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
598 Initialize impl->reload_state.
599 (gtk_file_chooser_default_map): Check the impl->reload_state; load
600 a default folder if no folder has been set, or reload the current
601 one only if we had been unmapped first.
602 (gtk_file_chooser_default_update_current_folder): Set the
603 reload_state to RELOAD_HAS_FOLDER.
604 (gtk_file_chooser_default_unmap): Implement, and set the
605 reload_state to RELOAD_WAS_UNMAPPED.
606 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
607 here; they'll get (re)loaded on ::map() anyway.
609 * gtk/gtkfilechooserwidget.c
610 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
612 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
613 a dialog; build it ourselves.
614 (test_reload): New test to ensure that we don't load the default
615 folder more than once, and that we reload it when
617 (get_impl_from_dialog): New utility function.
618 (test_widgets_for_current_action): Use get_impl_from_dialog().
620 2005-09-27 Federico Mena Quintero <federico@ximian.com>
622 * gtk/gtkfilechooserdefault.c
623 (gtk_file_chooser_default_constructor): Mark the entry/exit of
624 this function for profiling.
625 (check_icon_theme): Likewise.
626 (change_icon_theme): Likewise.
627 (settings_notify_cb): Likewise.
628 (gtk_file_chooser_default_screen_changed): Likewise.
629 (update_chooser_entry): If the selection is empty, clear the file
630 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
631 nothing will be selected when the user starts typeahead in the
632 treeview, and we don't want to clear the file name entry in that
633 case --- the user could be typing-ahead to look for a folder name.
634 Fixes bug #308332, patch by Jürg Billeter.
636 2005-09-27 Matthias Clasen <mclasen@redhat.com>
638 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
639 Pop below the entry if there's more free space below the entry
640 than above. (#316948, Tommi Komulainen)
642 2005-09-26 Federico Mena Quintero <federico@ximian.com>
644 Do not create the save mode-specific widgets in the open modes, so
645 that we don't carry their baggage around.
647 * gtk/gtkfilechooserdefault.c
648 (gtk_file_chooser_default_constructor): Don't create the
650 (save_widgets_create): Set the impl->save_widgets directly here,
651 instead of passing the widgets back to the caller. Also, pack
652 them into the impl's box.
653 (update_appearance): Create or destroy the save widgets as
654 appropriate. Set the action of the save_file_name_entry here.
655 (shortcuts_add_current_folder): Set the active item in the
656 save_folder_combo only if it exists.
657 (gtk_file_chooser_default_set_property): Don't set the action of
658 the save_file_name_entry here.
659 (gtk_file_chooser_default_update_current_folder): Set the base
660 folder of the save_file_name_entry only if the entry exists.
661 (shortcuts_drag_data_received_cb): Cast the selection_data->data
662 to (const char *) since that's what shortcuts_drop_uris() expects.
663 (file_list_drag_data_received_cb): Likewise, for
664 g_uri_list_extract_uris().
666 2005-09-26 Tor Lillqvist <tml@novell.com>
668 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
669 the shaped flag here, too. (#316871)
670 (gdk_window_shape_combine_region): Currently unimplemented, so
671 don't do anything to the shaped flag here.
673 2005-09-26 Matthias Clasen <mclasen@redhat.com>
675 Fix #316871, reported by Dan Winship:
677 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
679 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
680 (gdk_window_shape_combine_region): Set it here.
682 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
683 remove the child area for shaped windows.
685 2005-09-23 Matthias Clasen <mclasen@redhat.com>
687 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
688 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
690 2005-09-22 Michael Natterer <mitch@imendio.com>
692 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
693 consistent with GTK+ terminology:
695 * gtk/gtkcellrendererkeys.[ch]
696 * tests/testkeys.c: removed...
698 * gtk/gtkcellrendereraccel.[ch]
699 * tests/testaccel.c: ...and added.
704 * tests/Makefile.am: changed accordingly.
706 2005-09-22 Matthias Clasen <mclasen@redhat.com>
708 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
709 for the grab-broken-event signal, noticed by Damon Chaplin.
711 2005-09-21 Tor Lillqvist <tml@novell.com>
713 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
714 gdk_text_property_to_text_list_for_display,
715 gdk_text_property_to_utf8_list_for_display,
716 gdk_win32_selection_add_targets,
717 _gdk_win32_selection_convert_to_dib): Free return value from
719 (gdk_text_property_to_text_list_for_display): Drop GError variable
720 that isn't actually used after being set.
722 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
724 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
727 2005-09-20 Tor Lillqvist <tml@novell.com>
729 * gdk/win32/gdkselection-win32.c
730 (gdk_selection_owner_get_for_display): Do return the correct owner
731 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
732 a window GDK knows about). The reason to return NULL seems to have
733 gone when in the fix for bug #163702 the artificial
734 GDK_SELECTION_CLEAR event generation was removed from
735 gdk_selection_send_notify_for_display(). Fixes bug #316552.
737 2005-09-20 Matthias Clasen <mclasen@redhat.com>
739 Avoid unnecessary XkbGetState() calls and XkbStateNotify
740 events. (#151555, Søren Sandmann)
742 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
743 XkbSelectEventDetails() to select XkbStateNotify events
744 for only the state we care about.
746 * gdk/x11/gdkprivate-x11.h:
747 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
748 the event into the function and update the keymap state from
749 the state information contained in the event. Adjust all callers.
751 2005-09-19 Matthias Clasen <mclasen@redhat.com>
753 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
754 in multiple places to avoid segfaults if the index is out of range.
755 (#316422, Guillaume Cottenceau)
756 (gtk_icon_view_set_drag_dest_item):
757 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
758 #316424, Guillaume Cottenceau)
760 2005-09-18 Hans Breuer <hans@breuer.org>
762 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
763 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
765 2005-09-18 Hans Breuer <hans@breuer.org>
767 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
768 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
769 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
770 the icon and is blinking with teststatusicon. More to come ...
772 2005-09-18 Hans Breuer <hans@breuer.org>
774 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
775 cause gtkprogressbar.c has #include <config.h> conditionally; less
776 noise from generated gtk.def
777 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
779 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
780 For me it works as well as the *NIX implemenation, that is not at all.
782 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
784 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
785 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
786 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
787 again - if compiled properly.
789 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
790 already coming with Gtk+. Makes it compile on win32.
792 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
794 * README.cvs-commits: fixed some tiny typos
796 2005-09-16 Tor Lillqvist <tml@novell.com>
798 * modules/engines/ms-windows/msw_style.c (draw_extension,
799 draw_box_gap): Check whether the widget actually is a GtkNotebook
800 before treating it as such. Drop some unneeded local variables,
801 use parameter with same information instead. (#316412)
803 2005-09-15 Federico Mena Quintero <federico@ximian.com>
805 * tests/autotestfilechooser.c: Start a set of automated tests for
806 the file chooser. The only test in there right now doesn't pass
807 yet. It specifies the intended behavior of the first optimization
808 of a series which I'll do on the file chooser (see
809 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
810 details of this optimization).
812 * tests/Makefile.am: Added autotestfilechooser.c.
814 * gtk/gtkfilechooserprivate.h (struct
815 _GtkFileChooserDialogPrivate): Move all the file chooser's private
816 structures to here, so that they can be accessed by
817 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
818 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
820 * gtk/gtkfilechooserdialog.c: See above.
822 * gtk/gtkfilechooserwidget.c: See above.
824 * gtk/gtkfilechooserdefault.c: See above.
826 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
829 gtk_window_map_event(): new function to work around lost unmap requests.
832 2005-09-14 Federico Mena Quintero <federico@ximian.com>
834 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
835 an easy-to-find profiling marker when starting to create a file
837 (browse_files_model_finished_loading_cb): Likewise, for when the
838 chooser is finished loading.
840 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
842 * gtk/gtkcolorbutton.c: Check "color" argument in
843 gtk_color_button_set_color ()
845 2005-09-14 Matthias Clasen <mclasen@redhat.com>
847 * gtk/gtklabel.c (gtk_label_get_type):
848 * gtk/gtkbutton.c (gtk_button_get_type):
849 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
850 using a mem chunk for window groups, buttons, labels.
852 * gtk/updateiconcache.c (foreach_remove_func): Fix
853 a use-after-free bug. (#316256, Alexander Nedotsukov)
855 2005-09-13 Matthias Clasen <mclasen@redhat.com>
857 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
859 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
861 2005-09-13 Matthias Clasen <mclasen@redhat.com>
863 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
864 Let GDK_Return pass through in some more cases.
866 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
867 activating the entry.
869 * gtk/gtkiconview.c (gtk_icon_view_class_init):
870 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
871 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
873 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
874 (#316001, Guillaume Cottenceau)
876 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
877 mistake in the docs. (#315993, Guillaume Cottenceau)
879 * tests/testentrycompletion.c (create_simple_completion_model): Add
880 some strings containing multibyte characters.
882 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
883 Fix prefix insertion for multibyte characters. (#316095,
886 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
887 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
888 return NULL if the widget is not realized. (#316023,
889 Guillaume Cottenceau)
891 2005-09-11 Matthias Clasen <mclasen@redhat.com>
895 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
896 New function to avoid pointless strdups when creating atoms
900 * gtk/*.c: Use gdk_atom_intern_static_string() where
903 2005-09-09 Matthias Clasen <mclasen@redhat.com>
905 * gtk/gtkcellrendererkeys.h:
906 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
907 and editing accelerators, a port of EggCellRendererKeys .
911 * gtk/Makefile.am: Add the keys cell renderer.
914 * tests/testkeys.c: Test GtkCellRendererKeys
916 2005-09-09 Matthias Clasen <mclasen@redhat.com>
918 Make it possible to determine if a key event is for a
921 * gdk/x11/gdkprivate-x11.h:
922 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
923 New function to determine if a keycode is mapped to a modifier.
924 (get_xkb): Get the modmap.
926 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
927 is_modifier bit by calling _gdk_keymap_key_is_modifier().
929 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
932 2005-09-09 Matthias Clasen <mclasen@redhat.com>
934 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
935 unused variable, noticed by Kjartan Maraas.
937 2005-09-09 Matthias Clasen <mclasen@redhat.com>
939 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
940 Make drag reordering work properly for columns other than the
941 first. (#315054, Dan Winship)
943 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
944 invalid fontnames better. (#136926, Michael R. Walton)
946 Stop cursor blinking in non-editable regions of a text view.
947 (#311508, Torbjörn Andersson)
949 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
950 (cursor_blinks): Take editability into account when deciding
951 whether the cursor blinks.
952 (gtk_text_view_button_release_event):
953 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
955 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
956 Use connect_after to connect to the focus_out event. This
957 ensures that the entry has already stopped blinking by the time
958 we emit the edited signal. (#315229, Thomas Leonard)
960 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
962 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
963 unsigned ints to -1. (#315481, Kjartan Maraas)
965 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
966 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
967 (#314473, Stanislav Brabec)
969 2005-09-09 Matthias Clasen <mclasen@redhat.com>
971 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
972 memory handling. (#314975, Torsten Schoenfeld)
974 * gtk/gtkiconview.c (gtk_icon_view_class_init):
975 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
976 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
977 * gtk/gtklabel.c (gtk_label_class_init):
978 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
979 Stylistic improvements and clarifications for some blurbs.
980 (#315520, Clytie Siddall)
982 2005-09-09 Tor Lillqvist <tml@novell.com>
984 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
985 display name. There is only one GdkDisplay on Win32, and
986 constructing the display name isn't entirely trivial, so cacheing
987 is probably worth it. For instance GIMP calls this function a lot.
988 (gdk_display_open): Call gdk_display_get_name() to prime the
990 (gdk_display_get_n_screens, gdk_display_get_screen,
991 gdk_display_get_default_screen): Verify parameter correctness like
992 the X11 backend does.
994 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
995 Return a freshly allocated string, as the API specifies. Fixes a
996 heap corruption problem that caused random errors and crashes in
999 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1001 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1002 Make C-u commit and restart hex input if we are already in a
1005 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1007 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1008 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1009 if they are mapped to the same modifier.
1011 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1012 to gtkstatusicon.c and gtktrayicon-x11.c
1014 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1015 default accel mod mask.
1017 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1018 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1019 Don't use GDK_ALT_MASK.
1021 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1023 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1025 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1027 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1030 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1031 Mod2 - Mod5 and against Super, Hyper, Meta.
1033 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1034 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1035 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1037 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1038 modmap to maintain the information which X modifiers map to
1040 (get_xkb): Set up the modmap from the XKB tables.
1041 (update_keymaps): Set up the modmap from the information returned
1042 by XGetModifierMapping in the non-XKB case.
1044 * gdk/x11/gdkprivate-x11.h:
1045 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1046 function to set the virtual modifiers in the state.
1048 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1049 _gdk_keymap_add_virtual_modifiers here.
1051 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1052 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1055 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1057 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1058 if it has no child. (#315253, John Finlay)
1060 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1062 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1064 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1066 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1067 on destroy to avoid problems when they are called on a destroyed
1068 widget. (#315135, John Cupitt)
1070 * gtk/gtkentry.c (gtk_entry_class_init):
1071 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1072 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1074 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1075 code. Now we only steal a single key combination, Ctrl-Shift-U,
1077 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1078 by a sequence of hex digits entered with Ctrl-Shift still held.
1079 Releasing one of the modifiers or pressing space while the modifiers
1080 are still held commits the character. It is possible to erase
1081 digits using backspace.
1082 As an extension to the above, we also allow to start the sequence
1083 with Ctrl-Shift-U, then release the modifiers before typing any
1084 digits, and enter the digits without modifiers.
1085 (#82011, Owen Taylor)
1087 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1089 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1090 we still need to deliver the destroy event. (#314980, Chris Lahey)
1092 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1093 im context before committing \n or \t.
1095 2005-09-02 Alexander Larsson <alexl@redhat.com>
1097 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1098 (shortcuts_activate_volume):
1099 Handle base_path being null in the rest of the cases (#310270)
1101 2005-09-02 Tor Lillqvist <tml@novell.com>
1103 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1104 cursor position also in root window coordinates. Prune out
1105 superfluous WM_MOUSEMOVE events even earlier, based on root window
1106 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1107 window has ben mapped below the cursor even if the mouse doesn't
1108 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1109 confused at least gtk_menu_motion_notify(). (#314995)
1111 * gtk/gtkintl.h: No need to include config.h here. It caused
1112 warnings about GTK_LOCALEDIR being redefined on Win32 when
1113 compiling files where gtkintl.h is included after gtkprivate.h
1114 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1116 * gtk/gtkplug.c: Include config.h.
1118 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1120 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1121 xdg_mime_get_mime_type_for_file() where possible, to avoid
1124 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1125 typo. (#314921, Guillaume Cottenceau)
1127 * gdk/*.c: Intern some more strings.
1129 * gtk/*.c: Define an I_() macro and use it instead of the
1130 bulky g_intern_static_string().
1132 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1134 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1135 instead of copying it.
1137 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1139 * gtk/*.c: Also intern static strings passed to
1140 g_object_set_data().
1143 * gtk/Makefile.am: Intern type names in code generated by
1148 * gdk/*.c: Intern type names before registering the type to avoid
1151 * configure.in: Require GLib 2.9.0
1153 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1155 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1156 and add icon-size and icon-size-set properties. (#314172)
1158 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1159 groups across transient parents. (#312918, Christian Persch)
1161 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1162 Guillaume Cottenceau)
1164 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1165 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1167 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1169 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1170 make C-/ select all and C-\ unselect all. (#309301,
1173 * gtk/gtkimcontextsimple.c: Change the compose sequence for
1174 soft hyphen to be multi_key-minus-minus-space, and add
1175 compose sequences multi_key-minus-minus-period and
1176 multi_key-minus-minus-minus for en dash and em dash.
1177 (#172653, Christian Lohmaier)
1179 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
1180 code. (#313946, Christian Persch)
1182 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
1183 fix for the default value of the "ui" property.
1185 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1188 * gtk/gtkselection.h:
1189 * gtk/gtkselection.c: Add functions which look for text, image
1190 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1193 * gtk/gtkselection.h:
1194 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1195 Add a function to check wether targets include uri.
1196 (#314092, Mark Wielaard)
1200 * gtk/gtkwindow.c: Add a deletable property with getter
1201 and setter, to control the close button in the window
1202 frame. (#59718, Havoc Pennington)
1204 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1206 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1207 to the arrow keys for menu navigation. (#162825, Carl Worth)
1209 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1211 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1213 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1214 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1215 refer to nonexisting stock ids.
1217 * gtk/gtktextview.c (popup_targets_received):
1218 * gtk/gtkentry.c (popup_targets_received): Construct
1219 the "Select All" menuitem from stock.
1221 * gtk/stock-icons/stock_select_all_{16,24}.png:
1222 * gtk/stock-icons/Makefile.am:
1223 * gtk/gtkiconfactory.c:
1225 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1228 * gtk/gtktrayicon.c: Add a pointer to the spec.
1230 * gtk/gtkstatusicon-x11.c: Add docs.
1232 * gtk/gtkstatusicon.h: Fix a typo.
1234 Add a cross-platform "tray icon" API, by
1235 porting EggStatusIcon/EggTrayIcon (#105101)
1237 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1238 displays an icon in a notification area.
1240 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1241 X11, using GtkTrayIcon.
1243 * gtk/gtktrayicon.h:
1244 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1245 system tray specification, not public API.
1247 * gtk/gtk.symbols: Add new exported functions.
1249 * gtk/gtk.h: Include gtkstatusicon.h.
1251 * gtk/Makefile.am: Add new files.
1253 * tests/Makefile.am:
1254 * tests/teststatusicon.c: Test for GtkStatusIcon.
1256 2005-08-29 Christopher Aillon <caillon@redhat.com>
1258 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1259 and GTK_STOCK_DISCONNECT
1261 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1263 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1264 Use XFixesChangeSaveSet if available. (#314682)
1266 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1267 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1269 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1271 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1272 accidentally leftover duplicate pixbuf creation. (#314700,
1275 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1276 leak the cursor theme name. (#314693, Kjartan Maraas)
1278 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1279 state.children in all cases. (#313862, Kjartan Maraas)
1281 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1283 * po/POTFILES.in, po-properties/POTFILES.in:
1286 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1288 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1289 value of the ui property. (#314532, Yong Wang)
1291 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1292 when G_MAXLONG is passed as length.
1294 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1296 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1297 to avoid overloading --force. (JP Rosevaar)
1299 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1301 * configure.in: Bump version to 2.9.0
1305 * gdk/gdkscreen.c: Make the GdkScreen font options api
1306 public, and add properties GdkScreen::font-options and
1307 GdkScreen::resolution. (#314004)
1310 * gtk/gtksettings.c:
1311 * gtk/gtkwidget.c: Adjust all callers.
1313 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1314 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1315 * gdk/gdkscreen.c: Include gdkintl.h.
1317 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1318 variable warning, pointed out by Colin Walters. (#314585)
1320 2005-08-26 Tor Lillqvist <tml@novell.com>
1322 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1324 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1326 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1328 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1329 of week_start. (#314473, JP Rosevaar)
1331 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1333 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1334 lock. (#314533, Thomas Fitzsimmons)
1336 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1338 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1339 NULL gracefully. (#314523, Ed Catmur)
1341 2005-08-25 Owen Taylor <otaylor@redhat.com>
1343 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1344 Handle theme == NULL.
1346 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1348 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1349 y offset into account when positioning the popup. (#314470,
1352 2005-08-25 Owen Taylor <otaylor@redhat.com>
1354 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1355 as instance_init, not base_init! (#314452, Fix from Frederic
1356 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1357 rather than 1 for a negative flag value.
1359 2005-08-24 Owen Taylor <otaylor@redhat.com>
1361 * gdk/gdkpango.c (draw_error_underline): Add a note about
1362 cut-and-paste between here and Pango.
1364 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1366 * === Released 2.8.2 ===
1368 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1369 callback for image/gif, and also try image/bmp. (#314086, Mark
1372 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1373 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1378 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1379 and cursor settings get propagated down to the screen initially.
1380 Pointed out by Frederic Crozat.
1382 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1383 message if the screen is NULL. Noticed by Kjartan Maraas.
1385 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1389 * === Released 2.8.1 ===
1393 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1395 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1396 against lazy filterers which return values other than TRUE or
1397 FALSE from their visible func. (#314335)
1399 2005-08-23 Owen Taylor <otaylor@redhat.com>
1401 Fix for #314004, reported by Michael Reinsch:
1404 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1405 Add gdk_screen_get/set_resolution_libgtk_only()
1407 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1408 the options for the screen on the newly created context.
1410 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1411 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1412 the font options on the screen.
1414 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1415 the font options from the screen and set them on the context.
1417 2005-08-23 Kristian Rietveld <kris@gtk.org>
1419 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1420 bother inserting new rows in a level with a zero refcount and
1421 immediately free the level. (Fixes #312350, reported by Markku Vire).
1423 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1425 * gtk/updateiconcache.c: Complain when there is no index.theme file
1426 in the specified directory, unless --force is used. Also add an
1427 --index-only option to create caches without image data.
1429 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1430 C99ism. (#314262, Robert Jeff Mitchell)
1432 2005-08-22 Manish Singh <yosh@gimp.org>
1434 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1436 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1438 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1440 * gtk/gtkwindow.c (gtk_window_client_event):
1441 * gtk/gtkicontheme.c (ensure_valid_themes)
1442 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1443 scheme for makeing sure that all GTK+ applications notice if an
1444 icon theme has been updated. This should prevent multiple versions
1445 of an icon theme cache to be mapped in memory at the same time,
1446 which can cause excessive memory consumption. (#313156, Chris
1449 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1451 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1452 regarding icon theme changes.
1454 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1455 pixbufs which are backed by the mmapped memory of an icon cache,
1456 increase the refcount of the icon cache, so that the memory is not
1457 munmapped away underneath the pixbuf upon icon theme changes.
1458 (#314170, Kjartan Maraas)
1460 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1461 to link against Xext. (#314062)
1463 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1464 overruns. (#314081, Hans Breuer)
1466 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1468 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1469 returned layout must not be modified.
1471 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1473 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1474 scroll_to_path if the model changes.
1476 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1477 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1478 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1479 we're realized, #312798
1480 (gtk_icon_view_set_model): clear scroll_to_path if the model
1483 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1485 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1486 (gtk_range_adjustment_value_changed): Don't queue a draw
1487 if the layout has not changed. (#313991, Benjamin Berg)
1489 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1491 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1494 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1497 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1498 (model_add_special, model_add_special, model_add_volumes):
1499 Handle pixbuf being NULL without warnings. Also, don't
1500 leak pixbuf references when the icon theme is changed.
1502 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1503 the user data on destroyed windows, since at best
1504 it can be a stale pointer. (#313953, Robin Green)
1506 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1508 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1509 (#313900, Sebastien Bacher)
1511 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1512 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1514 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1515 (xdnd_read_actions, get_client_window_at_coords_recurse):
1516 Free data returned from XGetWindowProperty.
1518 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1519 Free data returned from XGetWindowProperty. (313867, Kjartan
1522 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1523 children in all cases. (#313862, Kjartan Maraas)
1525 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1526 in the per-directory hash, even if they come from the icon cache.
1527 We tried to avoid that before, but as a result leaked icon data
1528 structs. (#313852, Kjartan Maraas)
1530 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1532 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1533 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1535 2005-08-15 Owen Taylor <otaylor@redhat.com>
1537 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1538 files for x11/xext. (Jonas Bonn)
1540 2005-08-15 Tor Lillqvist <tml@novell.com>
1542 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1545 2005-08-15 Owen Taylor <otaylor@redhat.com>
1547 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1549 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1550 (#313417, James Andrewartha)
1552 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1553 FcNameConstant(). (More of #313417)
1555 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1557 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1558 modal dialogs, make sure to inherit the window group from
1559 the parent, since we don't inherit window groups across
1560 transient parents currently. (#312918, Christian Persch)
1562 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1563 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1565 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1566 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1567 gracefully. (#312796, Jonathan Blandford)
1569 * tests/testtoolbar.c: Add some more tests for menu placement.
1571 * gtk/gtkmenutoolbutton.c (menu_position_func):
1572 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1573 of toolbutton menus and of the overflow menu. (#312937,
1574 #153870, Christian Persch, Paolo Borelli)
1576 2005-08-15 Tor Lillqvist <tml@novell.com>
1578 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1579 the nonportable <libgen.h> and dirname().
1581 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1583 * gtk/gtksizegroup.c: Use object data to mark widgets and
1584 groups as visited, so that we avoid constant extra list
1585 traversals. Also allocate quarks in class_init. (#311618,
1588 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1589 download location for the hicolor icon theme. (#313475, Olexiy
1592 * gtk/gtkicontheme.c: Remove debug spew.
1594 2005-08-15 Owen Taylor <otaylor@redhat.com>
1596 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1597 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1598 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1599 Handle pixmap == NULL when checking for a colormap.
1602 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1604 * gtk/updateiconcache.c: Store only one copy of the pixel data
1605 for symlinked icons. To achieve this, maintain a hashtable
1606 mapping pathnames to pixel data, and share the pixel data for
1607 all symlinks resolving to the same pathname. When writing out
1608 the image data, write out the pixel data only the first time
1609 it is met, and store the offset pointing to the first copy
1610 for use in all later cases.
1611 This reduces the size of the Bluecurve icon cache from 40