1 2005-10-03 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtkcalendar.c (gtk_calendar_init): Call
4 calendar_compute_days() after setting priv->week_start.
6 2005-10-03 Matthias Clasen <mclasen@redhat.com>
8 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
9 removing it from the hash table. (#314696, Benjamin Berg)
11 2005-10-01 Tor Lillqvist <tml@novell.com>
13 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
14 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
15 is that the the desktop isn't visible because the session has been
16 switched, the screen is locked, or a terminal server session
17 disconnected, so no error message necessary. (#137796)
19 It is of course remotely possible that BitBlt() failing with
20 ERROR_INVALID_HANDLE might also be caused by some other
21 problem. We could strive for perfection and track whether the
22 desktop is visible by using WTSRegisterSessionNotification() and
23 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
24 this issue, though. If we would track desktop visibility, we
25 should then avoid even trying to update the display at all while
26 the desktop isn't visible.
28 2005-09-30 Matthias Clasen <mclasen@redhat.com>
30 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
31 to correct the calculations for the first week day. We may
32 just have to remove this code if too many locales turn out
35 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
36 some cases. (#317611, Tommi Komulainen)
38 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
39 Prevent overflow when storing size hints in an unsigned
40 short variable. Tracked down by Ray Strode and Søren Sandmann.
42 2005-09-29 Matthias Clasen <mclasen@redhat.com>
44 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
47 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
48 grab shadowed. (#317332)
50 2005-09-29 Tor Lillqvist <tml@novell.com>
52 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
54 2005-09-28 Federico Mena Quintero <federico@ximian.com>
56 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
57 if the unmap test fails.
58 (test_reload_sequence): Use gtk_widget_show_now() instead of
59 gtk_widget_show() for the dialog.
60 Thanks to Tim Janik for noticing these.
62 2005-09-28 Federico Mena Quintero <federico@ximian.com>
64 * tests/testcellrenderertext.c: New file with a set of tests for
65 GtkCellRendererText. The idea is to run a text renderer through
66 most of its interesting property values to see that it works
69 * tests/Makefile.am: Added testcellrenderertext.
71 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
72 entry/exit of this function for profiling.
73 (gtk_file_chooser_default_style_set): Mark the start/end of the
74 calls to the parent class and the the signal emission for profiling.
76 2005-09-29 Tor Lillqvist <tml@novell.com>
78 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
79 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
80 system codepage using g_win32_locale_filename_from_utf8().
81 (#317457, Kazuki Iwamoto)
83 2005-09-28 Matthias Clasen <mclasen@redhat.com>
85 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
86 here. (#317039, Paolo Borelli)
89 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
90 to make this function work as boxed copy function. (#317455,
93 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
94 NULL. (#316828, Tor Lillqvist)
96 2005-09-28 Tor Lillqvist <tml@novell.com>
98 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
101 2005-09-27 Federico Mena Quintero <federico@ximian.com>
103 Don't reload the current folder unnecessarily on ::map().
105 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
107 (struct _GtkFileChooserDefault): Added a "reload_state" field.
109 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
110 Initialize impl->reload_state.
111 (gtk_file_chooser_default_map): Check the impl->reload_state; load
112 a default folder if no folder has been set, or reload the current
113 one only if we had been unmapped first.
114 (gtk_file_chooser_default_update_current_folder): Set the
115 reload_state to RELOAD_HAS_FOLDER.
116 (gtk_file_chooser_default_unmap): Implement, and set the
117 reload_state to RELOAD_WAS_UNMAPPED.
118 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
119 here; they'll get (re)loaded on ::map() anyway.
121 * gtk/gtkfilechooserwidget.c
122 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
124 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
125 a dialog; build it ourselves.
126 (test_reload): New test to ensure that we don't load the default
127 folder more than once, and that we reload it when
129 (get_impl_from_dialog): New utility function.
130 (test_widgets_for_current_action): Use get_impl_from_dialog().
132 2005-09-27 Federico Mena Quintero <federico@ximian.com>
134 * gtk/gtkfilechooserdefault.c
135 (gtk_file_chooser_default_constructor): Mark the entry/exit of
136 this function for profiling.
137 (check_icon_theme): Likewise.
138 (change_icon_theme): Likewise.
139 (settings_notify_cb): Likewise.
140 (gtk_file_chooser_default_screen_changed): Likewise.
141 (update_chooser_entry): If the selection is empty, clear the file
142 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
143 nothing will be selected when the user starts typeahead in the
144 treeview, and we don't want to clear the file name entry in that
145 case --- the user could be typing-ahead to look for a folder name.
146 Fixes bug #308332, patch by Jürg Billeter.
148 2005-09-27 Matthias Clasen <mclasen@redhat.com>
150 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
151 Pop below the entry if there's more free space below the entry
152 than above. (#316948, Tommi Komulainen)
154 2005-09-26 Federico Mena Quintero <federico@ximian.com>
156 Do not create the save mode-specific widgets in the open modes, so
157 that we don't carry their baggage around.
159 * gtk/gtkfilechooserdefault.c
160 (gtk_file_chooser_default_constructor): Don't create the
162 (save_widgets_create): Set the impl->save_widgets directly here,
163 instead of passing the widgets back to the caller. Also, pack
164 them into the impl's box.
165 (update_appearance): Create or destroy the save widgets as
166 appropriate. Set the action of the save_file_name_entry here.
167 (shortcuts_add_current_folder): Set the active item in the
168 save_folder_combo only if it exists.
169 (gtk_file_chooser_default_set_property): Don't set the action of
170 the save_file_name_entry here.
171 (gtk_file_chooser_default_update_current_folder): Set the base
172 folder of the save_file_name_entry only if the entry exists.
173 (shortcuts_drag_data_received_cb): Cast the selection_data->data
174 to (const char *) since that's what shortcuts_drop_uris() expects.
175 (file_list_drag_data_received_cb): Likewise, for
176 g_uri_list_extract_uris().
178 2005-09-26 Tor Lillqvist <tml@novell.com>
180 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
181 the shaped flag here, too. (#316871)
182 (gdk_window_shape_combine_region): Currently unimplemented, so
183 don't do anything to the shaped flag here.
185 2005-09-26 Matthias Clasen <mclasen@redhat.com>
187 Fix #316871, reported by Dan Winship:
189 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
191 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
192 (gdk_window_shape_combine_region): Set it here.
194 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
195 remove the child area for shaped windows.
197 2005-09-23 Matthias Clasen <mclasen@redhat.com>
199 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
200 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
202 2005-09-22 Michael Natterer <mitch@imendio.com>
204 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
205 consistent with GTK+ terminology:
207 * gtk/gtkcellrendererkeys.[ch]
208 * tests/testkeys.c: removed...
210 * gtk/gtkcellrendereraccel.[ch]
211 * tests/testaccel.c: ...and added.
216 * tests/Makefile.am: changed accordingly.
218 2005-09-22 Matthias Clasen <mclasen@redhat.com>
220 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
221 for the grab-broken-event signal, noticed by Damon Chaplin.
223 2005-09-21 Tor Lillqvist <tml@novell.com>
225 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
226 gdk_text_property_to_text_list_for_display,
227 gdk_text_property_to_utf8_list_for_display,
228 gdk_win32_selection_add_targets,
229 _gdk_win32_selection_convert_to_dib): Free return value from
231 (gdk_text_property_to_text_list_for_display): Drop GError variable
232 that isn't actually used after being set.
234 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
236 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
239 2005-09-20 Tor Lillqvist <tml@novell.com>
241 * gdk/win32/gdkselection-win32.c
242 (gdk_selection_owner_get_for_display): Do return the correct owner
243 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
244 a window GDK knows about). The reason to return NULL seems to have
245 gone when in the fix for bug #163702 the artificial
246 GDK_SELECTION_CLEAR event generation was removed from
247 gdk_selection_send_notify_for_display(). Fixes bug #316552.
249 2005-09-20 Matthias Clasen <mclasen@redhat.com>
251 Avoid unnecessary XkbGetState() calls and XkbStateNotify
252 events. (#151555, Søren Sandmann)
254 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
255 XkbSelectEventDetails() to select XkbStateNotify events
256 for only the state we care about.
258 * gdk/x11/gdkprivate-x11.h:
259 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
260 the event into the function and update the keymap state from
261 the state information contained in the event. Adjust all callers.
263 2005-09-19 Matthias Clasen <mclasen@redhat.com>
265 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
266 in multiple places to avoid segfaults if the index is out of range.
267 (#316422, Guillaume Cottenceau)
268 (gtk_icon_view_set_drag_dest_item):
269 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
270 #316424, Guillaume Cottenceau)
272 2005-09-18 Hans Breuer <hans@breuer.org>
274 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
275 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
277 2005-09-18 Hans Breuer <hans@breuer.org>
279 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
280 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
281 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
282 the icon and is blinking with teststatusicon. More to come ...
284 2005-09-18 Hans Breuer <hans@breuer.org>
286 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
287 cause gtkprogressbar.c has #include <config.h> conditionally; less
288 noise from generated gtk.def
289 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
291 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
292 For me it works as well as the *NIX implemenation, that is not at all.
294 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
296 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
297 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
298 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
299 again - if compiled properly.
301 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
302 already coming with Gtk+. Makes it compile on win32.
304 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
306 * README.cvs-commits: fixed some tiny typos
308 2005-09-16 Tor Lillqvist <tml@novell.com>
310 * modules/engines/ms-windows/msw_style.c (draw_extension,
311 draw_box_gap): Check whether the widget actually is a GtkNotebook
312 before treating it as such. Drop some unneeded local variables,
313 use parameter with same information instead. (#316412)
315 2005-09-15 Federico Mena Quintero <federico@ximian.com>
317 * tests/autotestfilechooser.c: Start a set of automated tests for
318 the file chooser. The only test in there right now doesn't pass
319 yet. It specifies the intended behavior of the first optimization
320 of a series which I'll do on the file chooser (see
321 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
322 details of this optimization).
324 * tests/Makefile.am: Added autotestfilechooser.c.
326 * gtk/gtkfilechooserprivate.h (struct
327 _GtkFileChooserDialogPrivate): Move all the file chooser's private
328 structures to here, so that they can be accessed by
329 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
330 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
332 * gtk/gtkfilechooserdialog.c: See above.
334 * gtk/gtkfilechooserwidget.c: See above.
336 * gtk/gtkfilechooserdefault.c: See above.
338 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
341 gtk_window_map_event(): new function to work around lost unmap requests.
344 2005-09-14 Federico Mena Quintero <federico@ximian.com>
346 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
347 an easy-to-find profiling marker when starting to create a file
349 (browse_files_model_finished_loading_cb): Likewise, for when the
350 chooser is finished loading.
352 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
354 * gtk/gtkcolorbutton.c: Check "color" argument in
355 gtk_color_button_set_color ()
357 2005-09-14 Matthias Clasen <mclasen@redhat.com>
359 * gtk/gtklabel.c (gtk_label_get_type):
360 * gtk/gtkbutton.c (gtk_button_get_type):
361 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
362 using a mem chunk for window groups, buttons, labels.
364 * gtk/updateiconcache.c (foreach_remove_func): Fix
365 a use-after-free bug. (#316256, Alexander Nedotsukov)
367 2005-09-13 Matthias Clasen <mclasen@redhat.com>
369 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
371 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
373 2005-09-13 Matthias Clasen <mclasen@redhat.com>
375 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
376 Let GDK_Return pass through in some more cases.
378 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
379 activating the entry.
381 * gtk/gtkiconview.c (gtk_icon_view_class_init):
382 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
383 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
385 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
386 (#316001, Guillaume Cottenceau)
388 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
389 mistake in the docs. (#315993, Guillaume Cottenceau)
391 * tests/testentrycompletion.c (create_simple_completion_model): Add
392 some strings containing multibyte characters.
394 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
395 Fix prefix insertion for multibyte characters. (#316095,
398 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
399 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
400 return NULL if the widget is not realized. (#316023,
401 Guillaume Cottenceau)
403 2005-09-11 Matthias Clasen <mclasen@redhat.com>
407 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
408 New function to avoid pointless strdups when creating atoms
412 * gtk/*.c: Use gdk_atom_intern_static_string() where
415 2005-09-09 Matthias Clasen <mclasen@redhat.com>
417 * gtk/gtkcellrendererkeys.h:
418 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
419 and editing accelerators, a port of EggCellRendererKeys .
423 * gtk/Makefile.am: Add the keys cell renderer.
426 * tests/testkeys.c: Test GtkCellRendererKeys
428 2005-09-09 Matthias Clasen <mclasen@redhat.com>
430 Make it possible to determine if a key event is for a
433 * gdk/x11/gdkprivate-x11.h:
434 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
435 New function to determine if a keycode is mapped to a modifier.
436 (get_xkb): Get the modmap.
438 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
439 is_modifier bit by calling _gdk_keymap_key_is_modifier().
441 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
444 2005-09-09 Matthias Clasen <mclasen@redhat.com>
446 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
447 unused variable, noticed by Kjartan Maraas.
449 2005-09-09 Matthias Clasen <mclasen@redhat.com>
451 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
452 Make drag reordering work properly for columns other than the
453 first. (#315054, Dan Winship)
455 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
456 invalid fontnames better. (#136926, Michael R. Walton)
458 Stop cursor blinking in non-editable regions of a text view.
459 (#311508, Torbjörn Andersson)
461 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
462 (cursor_blinks): Take editability into account when deciding
463 whether the cursor blinks.
464 (gtk_text_view_button_release_event):
465 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
467 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
468 Use connect_after to connect to the focus_out event. This
469 ensures that the entry has already stopped blinking by the time
470 we emit the edited signal. (#315229, Thomas Leonard)
472 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
474 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
475 unsigned ints to -1. (#315481, Kjartan Maraas)
477 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
478 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
479 (#314473, Stanislav Brabec)
481 2005-09-09 Matthias Clasen <mclasen@redhat.com>
483 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
484 memory handling. (#314975, Torsten Schoenfeld)
486 * gtk/gtkiconview.c (gtk_icon_view_class_init):
487 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
488 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
489 * gtk/gtklabel.c (gtk_label_class_init):
490 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
491 Stylistic improvements and clarifications for some blurbs.
492 (#315520, Clytie Siddall)
494 2005-09-09 Tor Lillqvist <tml@novell.com>
496 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
497 display name. There is only one GdkDisplay on Win32, and
498 constructing the display name isn't entirely trivial, so cacheing
499 is probably worth it. For instance GIMP calls this function a lot.
500 (gdk_display_open): Call gdk_display_get_name() to prime the
502 (gdk_display_get_n_screens, gdk_display_get_screen,
503 gdk_display_get_default_screen): Verify parameter correctness like
504 the X11 backend does.
506 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
507 Return a freshly allocated string, as the API specifies. Fixes a
508 heap corruption problem that caused random errors and crashes in
511 2005-09-07 Matthias Clasen <mclasen@redhat.com>
513 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
514 Make C-u commit and restart hex input if we are already in a
517 2005-09-06 Matthias Clasen <mclasen@redhat.com>
519 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
520 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
521 if they are mapped to the same modifier.
523 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
524 to gtkstatusicon.c and gtktrayicon-x11.c
526 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
527 default accel mod mask.
529 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
530 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
531 Don't use GDK_ALT_MASK.
533 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
535 2005-09-06 Matthias Clasen <mclasen@redhat.com>
537 Add support for extra virtual modifiers: (#85780, Owen Taylor)
539 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
542 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
543 Mod2 - Mod5 and against Super, Hyper, Meta.
545 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
546 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
547 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
549 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
550 modmap to maintain the information which X modifiers map to
552 (get_xkb): Set up the modmap from the XKB tables.
553 (update_keymaps): Set up the modmap from the information returned
554 by XGetModifierMapping in the non-XKB case.
556 * gdk/x11/gdkprivate-x11.h:
557 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
558 function to set the virtual modifiers in the state.
560 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
561 _gdk_keymap_add_virtual_modifiers here.
563 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
564 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
567 2005-09-05 Matthias Clasen <mclasen@redhat.com>
569 * gtk/gtkaction.c (connect_proxy): Set the label of a button
570 if it has no child. (#315253, John Finlay)
572 2005-09-02 Matthias Clasen <mclasen@redhat.com>
574 * gtkimcontextsimple.h: Add a modifiers_dropped bit
576 2005-09-02 Matthias Clasen <mclasen@redhat.com>
578 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
579 on destroy to avoid problems when they are called on a destroyed
580 widget. (#315135, John Cupitt)
582 * gtk/gtkentry.c (gtk_entry_class_init):
583 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
584 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
586 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
587 code. Now we only steal a single key combination, Ctrl-Shift-U,
589 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
590 by a sequence of hex digits entered with Ctrl-Shift still held.
591 Releasing one of the modifiers or pressing space while the modifiers
592 are still held commits the character. It is possible to erase
593 digits using backspace.
594 As an extension to the above, we also allow to start the sequence
595 with Ctrl-Shift-U, then release the modifiers before typing any
596 digits, and enter the digits without modifiers.
597 (#82011, Owen Taylor)
599 2005-09-02 Matthias Clasen <mclasen@redhat.com>
601 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
602 we still need to deliver the destroy event. (#314980, Chris Lahey)
604 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
605 im context before committing \n or \t.
607 2005-09-02 Alexander Larsson <alexl@redhat.com>
609 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
610 (shortcuts_activate_volume):
611 Handle base_path being null in the rest of the cases (#310270)
613 2005-09-02 Tor Lillqvist <tml@novell.com>
615 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
616 cursor position also in root window coordinates. Prune out
617 superfluous WM_MOUSEMOVE events even earlier, based on root window
618 coordinates. Windows sends WM_MOUSEMOVE messages after a new
619 window has ben mapped below the cursor even if the mouse doesn't
620 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
621 confused at least gtk_menu_motion_notify(). (#314995)
623 * gtk/gtkintl.h: No need to include config.h here. It caused
624 warnings about GTK_LOCALEDIR being redefined on Win32 when
625 compiling files where gtkintl.h is included after gtkprivate.h
626 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
628 * gtk/gtkplug.c: Include config.h.
630 2005-09-01 Matthias Clasen <mclasen@redhat.com>
632 * gtk/gtkfilesystemunix.c: Pass statbufs down to
633 xdg_mime_get_mime_type_for_file() where possible, to avoid
636 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
637 typo. (#314921, Guillaume Cottenceau)
639 * gdk/*.c: Intern some more strings.
641 * gtk/*.c: Define an I_() macro and use it instead of the
642 bulky g_intern_static_string().
644 2005-08-31 Matthias Clasen <mclasen@redhat.com>
646 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
647 instead of copying it.
649 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
651 * gtk/*.c: Also intern static strings passed to
655 * gtk/Makefile.am: Intern type names in code generated by
660 * gdk/*.c: Intern type names before registering the type to avoid
663 * configure.in: Require GLib 2.9.0
665 2005-08-31 Matthias Clasen <mclasen@redhat.com>
667 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
668 and add icon-size and icon-size-set properties. (#314172)
670 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
671 groups across transient parents. (#312918, Christian Persch)
673 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
674 Guillaume Cottenceau)
676 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
677 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
679 2005-08-30 Matthias Clasen <mclasen@redhat.com>
681 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
682 make C-/ select all and C-\ unselect all. (#309301,
685 * gtk/gtkimcontextsimple.c: Change the compose sequence for
686 soft hyphen to be multi_key-minus-minus-space, and add
687 compose sequences multi_key-minus-minus-period and
688 multi_key-minus-minus-minus for en dash and em dash.
689 (#172653, Christian Lohmaier)
691 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
692 code. (#313946, Christian Persch)
694 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
695 fix for the default value of the "ui" property.
697 2005-08-30 Matthias Clasen <mclasen@redhat.com>
700 * gtk/gtkselection.h:
701 * gtk/gtkselection.c: Add functions which look for text, image
702 or uri targets in an array of atoms. (#314089, Mark Wielaard)
705 * gtk/gtkselection.h:
706 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
707 Add a function to check wether targets include uri.
708 (#314092, Mark Wielaard)
712 * gtk/gtkwindow.c: Add a deletable property with getter
713 and setter, to control the close button in the window
714 frame. (#59718, Havoc Pennington)
716 2005-08-29 Matthias Clasen <mclasen@redhat.com>
718 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
719 to the arrow keys for menu navigation. (#162825, Carl Worth)
721 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
723 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
725 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
726 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
727 refer to nonexisting stock ids.
729 * gtk/gtktextview.c (popup_targets_received):
730 * gtk/gtkentry.c (popup_targets_received): Construct
731 the "Select All" menuitem from stock.
733 * gtk/stock-icons/stock_select_all_{16,24}.png:
734 * gtk/stock-icons/Makefile.am:
735 * gtk/gtkiconfactory.c:
737 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
740 * gtk/gtktrayicon.c: Add a pointer to the spec.
742 * gtk/gtkstatusicon-x11.c: Add docs.
744 * gtk/gtkstatusicon.h: Fix a typo.
746 Add a cross-platform "tray icon" API, by
747 porting EggStatusIcon/EggTrayIcon (#105101)
749 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
750 displays an icon in a notification area.
752 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
753 X11, using GtkTrayIcon.
756 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
757 system tray specification, not public API.
759 * gtk/gtk.symbols: Add new exported functions.
761 * gtk/gtk.h: Include gtkstatusicon.h.
763 * gtk/Makefile.am: Add new files.
766 * tests/teststatusicon.c: Test for GtkStatusIcon.
768 2005-08-29 Christopher Aillon <caillon@redhat.com>
770 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
771 and GTK_STOCK_DISCONNECT
773 2005-08-29 Matthias Clasen <mclasen@redhat.com>
775 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
776 Use XFixesChangeSaveSet if available. (#314682)
778 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
779 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
781 2005-08-29 Matthias Clasen <mclasen@redhat.com>
783 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
784 accidentally leftover duplicate pixbuf creation. (#314700,
787 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
788 leak the cursor theme name. (#314693, Kjartan Maraas)
790 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
791 state.children in all cases. (#313862, Kjartan Maraas)
793 2005-08-28 Matthias Clasen <mclasen@redhat.com>
795 * po/POTFILES.in, po-properties/POTFILES.in:
798 2005-08-27 Matthias Clasen <mclasen@redhat.com>
800 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
801 value of the ui property. (#314532, Yong Wang)
803 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
804 when G_MAXLONG is passed as length.
806 2005-08-26 Matthias Clasen <mclasen@redhat.com>
808 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
809 to avoid overloading --force. (JP Rosevaar)
811 2005-08-26 Matthias Clasen <mclasen@redhat.com>
813 * configure.in: Bump version to 2.9.0
817 * gdk/gdkscreen.c: Make the GdkScreen font options api
818 public, and add properties GdkScreen::font-options and
819 GdkScreen::resolution. (#314004)
823 * gtk/gtkwidget.c: Adjust all callers.
825 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
826 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
827 * gdk/gdkscreen.c: Include gdkintl.h.
829 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
830 variable warning, pointed out by Colin Walters. (#314585)
832 2005-08-26 Tor Lillqvist <tml@novell.com>
834 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
836 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
838 2005-08-26 Matthias Clasen <mclasen@redhat.com>
840 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
841 of week_start. (#314473, JP Rosevaar)
843 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
845 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
846 lock. (#314533, Thomas Fitzsimmons)
848 2005-08-25 Matthias Clasen <mclasen@redhat.com>
850 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
851 NULL gracefully. (#314523, Ed Catmur)
853 2005-08-25 Owen Taylor <otaylor@redhat.com>
855 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
856 Handle theme == NULL.
858 2005-08-25 Matthias Clasen <mclasen@redhat.com>
860 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
861 y offset into account when positioning the popup. (#314470,
864 2005-08-25 Owen Taylor <otaylor@redhat.com>
866 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
867 as instance_init, not base_init! (#314452, Fix from Frederic
868 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
869 rather than 1 for a negative flag value.
871 2005-08-24 Owen Taylor <otaylor@redhat.com>
873 * gdk/gdkpango.c (draw_error_underline): Add a note about
874 cut-and-paste between here and Pango.
876 2005-08-24 Matthias Clasen <mclasen@redhat.com>
878 * === Released 2.8.2 ===
880 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
881 callback for image/gif, and also try image/bmp. (#314086, Mark
884 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
885 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
890 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
891 and cursor settings get propagated down to the screen initially.
892 Pointed out by Frederic Crozat.
894 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
895 message if the screen is NULL. Noticed by Kjartan Maraas.
897 2005-08-24 Matthias Clasen <mclasen@redhat.com>
901 * === Released 2.8.1 ===
905 2005-08-24 Matthias Clasen <mclasen@redhat.com>
907 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
908 against lazy filterers which return values other than TRUE or
909 FALSE from their visible func. (#314335)
911 2005-08-23 Owen Taylor <otaylor@redhat.com>
913 Fix for #314004, reported by Michael Reinsch:
916 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
917 Add gdk_screen_get/set_resolution_libgtk_only()
919 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
920 the options for the screen on the newly created context.
922 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
923 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
924 the font options on the screen.
926 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
927 the font options from the screen and set them on the context.
929 2005-08-23 Kristian Rietveld <kris@gtk.org>
931 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
932 bother inserting new rows in a level with a zero refcount and
933 immediately free the level. (Fixes #312350, reported by Markku Vire).
935 2005-08-23 Matthias Clasen <mclasen@redhat.com>
937 * gtk/updateiconcache.c: Complain when there is no index.theme file
938 in the specified directory, unless --force is used. Also add an
939 --index-only option to create caches without image data.
941 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
942 C99ism. (#314262, Robert Jeff Mitchell)
944 2005-08-22 Manish Singh <yosh@gimp.org>
946 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
948 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
950 2005-08-22 Matthias Clasen <mclasen@redhat.com>
952 * gtk/gtkwindow.c (gtk_window_client_event):
953 * gtk/gtkicontheme.c (ensure_valid_themes)
954 (_gtk_icon_theme_check_reload): Implement a clientmessage based
955 scheme for makeing sure that all GTK+ applications notice if an
956 icon theme has been updated. This should prevent multiple versions
957 of an icon theme cache to be mapped in memory at the same time,
958 which can cause excessive memory consumption. (#313156, Chris
961 2005-08-22 Matthias Clasen <mclasen@redhat.com>
963 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
964 regarding icon theme changes.
966 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
967 pixbufs which are backed by the mmapped memory of an icon cache,
968 increase the refcount of the icon cache, so that the memory is not
969 munmapped away underneath the pixbuf upon icon theme changes.
970 (#314170, Kjartan Maraas)
972 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
973 to link against Xext. (#314062)
975 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
976 overruns. (#314081, Hans Breuer)
978 2005-08-20 Matthias Clasen <mclasen@redhat.com>
980 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
981 returned layout must not be modified.
983 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
985 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
986 scroll_to_path if the model changes.
988 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
989 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
990 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
991 we're realized, #312798
992 (gtk_icon_view_set_model): clear scroll_to_path if the model
995 2005-08-20 Matthias Clasen <mclasen@redhat.com>
997 * gtk/gtkrange.c (gtk_range_adjustment_changed)
998 (gtk_range_adjustment_value_changed): Don't queue a draw
999 if the layout has not changed. (#313991, Benjamin Berg)
1001 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1003 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1006 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1009 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1010 (model_add_special, model_add_special, model_add_volumes):
1011 Handle pixbuf being NULL without warnings. Also, don't
1012 leak pixbuf references when the icon theme is changed.
1014 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1015 the user data on destroyed windows, since at best
1016 it can be a stale pointer. (#313953, Robin Green)
1018 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1020 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1021 (#313900, Sebastien Bacher)
1023 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1024 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1026 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1027 (xdnd_read_actions, get_client_window_at_coords_recurse):
1028 Free data returned from XGetWindowProperty.
1030 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1031 Free data returned from XGetWindowProperty. (313867, Kjartan
1034 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1035 children in all cases. (#313862, Kjartan Maraas)
1037 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1038 in the per-directory hash, even if they come from the icon cache.
1039 We tried to avoid that before, but as a result leaked icon data
1040 structs. (#313852, Kjartan Maraas)
1042 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1044 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1045 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1047 2005-08-15 Owen Taylor <otaylor@redhat.com>
1049 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1050 files for x11/xext. (Jonas Bonn)
1052 2005-08-15 Tor Lillqvist <tml@novell.com>
1054 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1057 2005-08-15 Owen Taylor <otaylor@redhat.com>
1059 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1061 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1062 (#313417, James Andrewartha)
1064 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1065 FcNameConstant(). (More of #313417)
1067 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1069 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1070 modal dialogs, make sure to inherit the window group from
1071 the parent, since we don't inherit window groups across
1072 transient parents currently. (#312918, Christian Persch)
1074 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1075 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1077 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1078 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1079 gracefully. (#312796, Jonathan Blandford)
1081 * tests/testtoolbar.c: Add some more tests for menu placement.
1083 * gtk/gtkmenutoolbutton.c (menu_position_func):
1084 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1085 of toolbutton menus and of the overflow menu. (#312937,
1086 #153870, Christian Persch, Paolo Borelli)
1088 2005-08-15 Tor Lillqvist <tml@novell.com>
1090 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1091 the nonportable <libgen.h> and dirname().
1093 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1095 * gtk/gtksizegroup.c: Use object data to mark widgets and
1096 groups as visited, so that we avoid constant extra list
1097 traversals. Also allocate quarks in class_init. (#311618,
1100 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1101 download location for the hicolor icon theme. (#313475, Olexiy
1104 * gtk/gtkicontheme.c: Remove debug spew.
1106 2005-08-15 Owen Taylor <otaylor@redhat.com>
1108 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1109 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1110 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1111 Handle pixmap == NULL when checking for a colormap.
1114 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1116 * gtk/updateiconcache.c: Store only one copy of the pixel data
1117 for symlinked icons. To achieve this, maintain a hashtable
1118 mapping pathnames to pixel data, and share the pixel data for
1119 all symlinks resolving to the same pathname. When writing out
1120 the image data, write out the pixel data only the first time
1121 it is met, and store the offset pointing to the first copy
1122 for use in all later cases.
1123 This reduces the size of the Bluecurve icon cache from 40