1 2005-12-12 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtktextview.c (gtk_text_view_get_border_window_size): Don't
4 fall thru to the wrong window types. (#323843)
6 Make the gtk-color-scheme setting work.
9 * gtk/gtksettings.c (_gtk_settings_get_color_hash): Add a getter
10 that takes care of initializing the color hash if it is not
13 * gtk/gtkrc.c (gtk_rc_color_scheme_changed, gtk_rc_context_get):
16 2005-12-10 Matthias Clasen <mclasen@redhat.com>
18 * gdk/gdk.c (gdk_parse_args): Warn if parsing fails,
21 2005-12-09 Matthias Clasen <mclasen@redhat.com>
23 * gtk/gtkselection.c (gtk_selection_data_get_uris): Don't
24 leak list[0]. (#323629, Markku Vire)
26 * gtk/gtktextbuffer.c (paste_from_buffer): Unref the buffer
27 when freeing the RequestData. (#323577)
29 2005-12-07 Matthias Clasen <mclasen@redhat.com>
31 * demos/gtk-demo/iconview_edit.c (set_cell_color): Don't
34 * gtk/gtktoolbutton.c (clone_image_menu_size): Fix a
35 variable name clash. (#323475, Ross Burton)
37 2005-12-07 Ross Burton <ross@burtonini.com>
39 * docs/reference/gtk/tmpl/gtkenums.sgml:
40 * gtk/gtktoolbutton.c:
41 If the toolbar mode is ICONS and there is no icon set then show
42 the label, and vice versa (#322019)
44 2005-12-07 Matthias Clasen <mclasen@redhat.com>
46 * gtk/gtktoolbutton.c (clone_image_menu_size): Fix a
47 variable name clash. (#323475, Ross Burton)
49 * gtk/gtktreeview.c (gtk_tree_view_key_press): Use the correct
50 window when synthesizing the key event. (#323077,
51 Sadrul Habib Chowdhury)
53 (gtk_tree_view_search_key_press_event): Also listen for
54 GDK_ISO_Left_Tab. (#323077, Sadrul Habib Chowdhury)
56 * gtk/gtktextview.c (gtk_text_view_preedit_changed_handler):
57 Only scroll if we have focus. (#316310, Paolo Borelli)
59 * gtk/gtkfilesystemunix.c (cb_fill_in_mime_type): Fix a C99ism,
60 spotted by Crispin Flowerday.
62 2005-12-06 Behdad Esfahbod <behdad@gnome.org>
64 * gtk/gtksettings.c (settings_update_font_options): Turn metrics
65 hinting on (part of #307196)
67 2005-12-06 Matthias Clasen <mclasen@redhat.com>
69 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_reset): Don't
70 commit from reset, it upstets GtkTextView.
72 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink): Be more
73 careful when turning blinking on and off.
74 (gtk_text_view_focus_out_event): Make the cursor really invisible
75 when the focus goes away. (#323087, Sadrul Habib Chowdhury)
76 (cursor_blinks): Check the gtk-cursor-blink setting first.
78 * gtk/gtktreeview.c (gtk_tree_view_key_press): Fix refcounting
79 issues with new_event and its window.
81 * gtk/gtkmenu.c (gtk_menu_attach_to_widget): Accept NULL
82 as a detach func. (#323386, Jorn Baayen)
84 * gtk/gtkcalendar.c: Avoid conflict with win32 headers in
85 the libdate routines. (#323045, Kazuki Iwamoto)
87 * gdk/gdk.c (gdk_parse_args):
88 * gtk/gtkmain.c (gtk_parse_args): Don't ignore errors
89 from g_option_context_parse().
91 Tue Dec 6 11:37:59 2005 Tim Janik <timj@gtk.org>
93 * gdk/gdkevents.c (gdk_event_new): fix missing hash table
96 Tue Dec 6 10:32:17 2005 Tim Janik <timj@gtk.org>
98 * gtk/gtkstatusbar.c: ported memchunk uses to g_slice, so the code
101 2005-12-05 Federico Mena Quintero <federico@ximian.com>
103 * gtk/gtkfilechooserdefault.c (trap_activate_cb): "event->state &
104 modifiers", not "event->state && modifiers". Patch by Sadrul
105 Habib Chowdhury <imadil@gmail.com>. Fixes bug #323073.
107 2005-12-05 Matthias Clasen <mclasen@redhat.com>
110 * gtk/gtkuimanager.c:
111 * gtk/gtktreedatalist.c:
114 * gtk/gtkitemfactory.c:
115 * gtk/gtkseparator.[hc]:
118 * gtk/gtkgc.c: Use g_slice instead of mem chunks.
120 2005-12-05 Michael Natterer <mitch@imendio.com>
122 * gdk/x11/gdkevents-x11.c: map the new GtkSettings properties
123 "timeout-initial", "timeout-repeat", "color-scheme" and
124 "enable-enimations" to X settings.
126 2005-12-05 Matthias Clasen <mclasen@redhat.com>
129 * gdk/gdkcolor.c: Use g_slice instead of mem chunks.
131 * gtk/gtktreeview.c (gtk_tree_view_key_press): Free new_event
132 after sending it to the search entry. (#323209, Crispin Flowerday)
134 * README.in: Add a note about GTK_FLOATING.
136 * gtk/gtkobject.h (GTK_OBJECT_FLOATING): Use g_object_is_floating.
138 2005-12-02 Matthias Clasen <mclasen@redhat.com>
140 * gtk/gtktoolbutton.c (clone_image_menu_size): Don't leak
141 a pixbuf. (#323024, Paolo Borelli)
143 2005-12-02 Matthias Clasen <mclasen@redhat.com>
145 * gtk/gtkfilesystemunix.c (get_icon_for_mime_type): Don't crash
146 if mime_type is NULL. (#322998, Sadrul Habib Chowdhury)
148 2005-12-02 Michael Natterer <mitch@imendio.com>
150 * gtk/gtkmenu.c: applied modified patch from maemo-gtk which
151 adds a "horizontal-padding" style property. Fixes bug #323036.
153 2005-12-01 Michael Natterer <mitch@imendio.com>
155 Merged modified patch from maemo-gtk that allows to disable
156 toolbar animations. Addresses bug #142582.
158 * gtk/gtksettings.c: added boolean property "gtk-enable-animations".
159 (patch from Christian Neumair)
161 * gtk/gtktoolbar.c: don't animate toolbar changes if the settings
162 property is FALSE. Replaced the individual "notify::foo"
163 connections to GtkSettings by a single "notify" callback and
166 2005-12-01 Michael Natterer <mitch@imendio.com>
168 * gtk/gtkmenu.c (gtk_menu_class_init): removed redundant
169 assignment of widget_class->motion_notify_event.
171 2005-11-29 Matthias Clasen <mclasen@redhat.com>
173 * gtk/gtktoggleaction.c (gtk_toggle_action_class_init): Add
174 an active property. (#322673, Jorn Baayen)
176 Properly handle model changes in GtkTreeSelection: (#322569,
179 * gtk/gtktreeselection.c (gtk_tree_selection_selected_foreach):
180 Get a reference to the model, and stop the iteration if the model
181 of the treeview is changed on the way.
183 * gtk/gtktreeprivate.h:
184 * gtk/gtktreeselection.c (_gtk_tree_selection_emit_changed): New
185 private function to emit the GtkTreeSelection::changed signal.
187 * gtk/gtktreeview.c (gtk_tree_view_set_model): Call
188 _gtk_tree_selection_emit_changed() when the model changes.
190 2005-11-28 Federico Mena Quintero <federico@ximian.com>
192 Fixes the critical warnings from bug #317999, thus fixing the bug
195 * gtk/gtkfilechooserdefault.c
196 (gtk_file_chooser_default_get_paths): In SELECT_FOLDER mode,
197 use _gtk_file_chooser_get_current_folder_path() instead of fetching the
198 impl->current_folder directly. The latter may be null if we are
199 in RELOAD_NONE state.
201 2005-11-28 Federico Mena Quintero <federico@ximian.com>
203 Fix bug #321560, based on a patch by Bogdan Nicula (bogdanni@hotmail.com):
205 * gtk/gtkfilechooserdefault.c (up_folder_handler): Don't add the
206 current_folder to the pending select paths here; the path bar will
208 (path_bar_clicked): Add the child_path to the pending select paths
210 (show_and_select_paths): Don't filter out folders.
211 (show_and_select_paths): Don't take separate arguments for
212 only_one_path and multiple paths.
214 * tests/autotestfilechooser.c (test_folder_switch_and_filters):
215 New test about preserving the filters when we change folders.
217 2005-11-28 Matthias Clasen <mclasen@redhat.com>
219 * gtk/gtkscale.c (_gtk_scale_format_value): Insert an LRM, to prevent
220 -20 to come out as 20- in RTL locales. (#322571, Tze'ela Hebron)
222 * gtk/gtkaction.c (gtk_action_sync_button_stock_id)
223 (connect_proxy): Buttons use the label property for stock ids. (#322565,
226 * gtk/gtkiconview.c (update_text_cell, update_pixbuf_cell): Correctly
227 handle the cell list and indices into it. (#321856)
229 2005-11-28 Matthias Clasen <mclasen@redhat.com>
231 * gtk/gtktooltips.c (gtk_tooltips_timeout): Set timer_tag to 0 when
232 the timeout is done. (#322291, Jean-Yves Lefort)
234 2005-11-28 Matthias Clasen <mclasen@redhat.com>
236 * gtk/gtkfilechooserdefault.c (shortcuts_key_press_event_cb): Make
237 F2 work for renaming bookmarks. (#320822, Jaap A. Haitsma, patch
240 2005-11-28 Tor Lillqvist <tml@novell.com>
242 * gdk/win32/gdkwindow-win32.c (gdk_window_set_urgency_hint):
243 Implement the conditional use of FlashWindowEx() properly for MSVC
244 compilations. The code was confusingly assuming that if compiled
245 with a "new" compiler, it will only be run on "new" Windows
246 versions. We want it to run on "old" versions, too, even if
247 compiled with a "new" compiler. There are two orthogonal issues:
248 whether the compiler defines the necessary API in its headers, and
249 whether it is present at run-time. (#318077)
251 * gtk/gtkcalendar.c (gtk_calendar_init): Use GetLocaleInfo() on
252 Windows to get the localized weekday and month names. strftime()
253 in the Microsoft C library returns strings in the default codepage
254 for the locale of the process, not the system codepage. Thus
255 g_locale_to_utf8() isn't useable on the return value from
256 strftime(). (#322603)
258 2005-11-27 Matthias Clasen <mclasen@redhat.com>
260 * gtk/gtkmessagedialog.c (gtk_message_dialog_new_with_markup):
261 Fix an example. (#322493, Elie De Brauwer)
263 Fix two memory handling problems in GtkTreeView: (#322350,
266 * gtk/gtktreeview.c (gtk_tree_view_destroy)
267 (gtk_tree_view_set_model): Remove all references to nodes in
269 (gtk_tree_view_real_collapse_row): Unmark expanded_collapsed_node
270 before removing the children.
272 * gtk/gtkcolorbutton.c (gtk_color_button_init): Don't leak a
273 PangoLayout here. (#322505, Paolo Borelli)
275 2005-11-27 Tor Lillqvist <tml@novell.com>
277 Once again rework Win32 window decoration code. Doesn't break
278 #104514. The dialogs in gtk-demo now have the same decorations and
279 behaviour as on X11. Tried to fix #322516 but it seems very hard
280 to make the trivial sample program there behave as expected. OTOH,
281 simply moving the gtk_window_decorate() call in the #322516 sample
282 program after the call to gtk_widget_show() helps...
284 * gdk/win32/gdkwindow-win32.c (set_or_clear_style_bits): Revert to
285 the correct semantics. Each call to gdk_window_set_decorations()
286 which calls this function is supposed to affect all decorations.
288 (decorate_based_on_hints): New function, looks at both geometry
289 hints and type hint and sets window decorations based on
290 that. Consolidate code from gdk_window_set_geometry_hints() and
291 gdk_window_set_type_hint() here.
293 (gdk_window_set_geometry_hints, gdk_window_set_type_hint): Call
294 decorate_based_on_hints().
296 2005-11-25 Dom Lachowicz <cinamod@hotmail.com>
298 * modules/engines/ms-windows/*.[ch]: Merge with gtk-wimp's CVS.
299 Includes improved menu icon spacing, [+]/[-] expander drawing,
300 status-bar gippie drawing, and notebook tab drawing.
302 2005-11-24 Michael Natterer <mitch@imendio.com>
304 * gtk/gtktoolbar.h (struct _GtkToolbar): changed two private guint
305 that used to hold signal handler IDs to two guint of padding.
307 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): added them as
310 (gtk_toolbar_screen_changed): changed accordingly.
312 Wed Nov 23 18:55:47 2005 Tim Janik <timj@imendio.com>
314 * gtk/gtkobject.[hc]: deprecated floating/sink API and implemented it
315 in terms of the GObject floating/sink API.
317 * gtk/gtkaboutdialog.c:
323 * gtk/gtkfilechooserdefault.c:
325 * gtk/gtkinvisible.c:
326 * gtk/gtkitemfactory.c:
329 * gtk/gtkmenutoolbutton.c:
333 * gtk/gtkspinbutton.c:
334 * gtk/gtkstatusicon.c:
338 * gtk/gtktoolbutton.c:
342 * gtk/gtktreeviewcolumn.c:
343 * gtk/gtkuimanager.c:
347 ported to use GObject's g_object_ref_sink().
350 * gtk/gtkfilechooserdefault.c:
351 * gtk/gtkaboutdialog.c:
352 fixed compiler warnings.
354 2005-11-23 Matthias Clasen <mclasen@redhat.com>
356 * gtk/gtksettings.c (gtk_settings_class_init): Add some docs
357 about gtk-color-scheme.
359 2005-11-23 Behdad Esfahbod <behdad@gnome.org>
361 * configure.in (enable_explicit_deps): Fix typo when checking
362 libtool config deplibs_check_method. Moreover, enable explicit
363 deps if we get anything other than pass_all from libtool. (part of
366 2005-11-23 Matthias Clasen <mclasen@redhat.com>
368 * gtk/updateiconcache.c (write_csource): Don't create a big
369 string, since Visual C++ doesn't like strings longer than 64k.
370 (#322238, Kazuki IWAMOTO
372 * gtk/gtkentry.c: Include gtkimcontextsimple.h (#322235,
375 2005-11-23 Michael Natterer <mitch@imendio.com>
377 * gtk/gtkrc.c (gtk_rc_reset_widgets): don't leak all toplevel
378 windows on other screens (correctly remove all temporary
381 2005-11-23 Michael Natterer <mitch@imendio.com>
383 Added symbolic themable colors. Patch is a merged version of
384 proposals from Matthias and maemo-gtk. Fixes bug #114355.
386 * configure.in: require glib >= 2.9.1 for refcountable hashtables.
388 * gtk/gtksettings.c: added property "color-scheme" which is a
389 string defining colors like "foreground:black\nbackground:grey".
390 Automatically provide a name->GdkColor hash table mapping for the
393 * gtk/gtkrc.[ch]: added list of color hashes that works like the
394 list of icon factories. Append the color scheme hash from
395 GtkSettings if it exists. Extended gtkrc syntax to allow defining
396 and referencing of logical colors. Also allow to modulate colors
397 in gtkrc by using arbitrary expressions of mix(), shade(),
398 lighter() and darker(). Added internal function
399 _gtk_rc_style_get_color_hashes().
401 * gtk/gtkstyle.[ch]: keep a private list of color hashes around.
402 Get the list from _gtk_rc_style_get_color_hashes(). Export
403 internal function _gtk_style_shade() (used by above color
404 expressions). Added public API gtk_style_lookup_color() which
405 looks up a logical color by name.
407 * gtk/gtk.symbols: add gtk_style_lookup_color
409 * tests/testgtkrc: use symbolic colors for making
412 2005-11-22 Michael Natterer <mitch@imendio.com>
414 Made button-press timeouts which work like key repeat timeouts
415 configurable. Addresses bug #142582:
417 * gtk/gtksettings.c: added properties "gtk-timeout-initial" and
418 "gtk-timeout-repeat" which defalt to 200/20 (ms).
420 Use the values from GtkSettings instead of hardcoding them
421 (the repeat value is either taken as-is for fast repeat or
422 multiplied by 5 for slow repeat). Changed all places to use these
423 two standard initial/repeat timings:
425 * gtk/gtkcalendar.c (unchanged 200/20)
426 * gtk/gtknotebook.c (unchanged 200/100)
427 * gtk/gtkpathbar.c (changed from 300/150 to 200/100)
428 * gtk/gtkrange.c (changed from 250/100 to 200/100)
429 * gtk/gtkspinbutton.c (unchanged 200/20)
431 2005-11-21 Anders Carlsson <andersca@imendio.com>
439 * docs/tools/Makefile.am:
440 Only build docshooter when the X11 backend is used.
442 * gtk/gtkplug-stub.c:
443 Include gtkplug.h here.
445 * gtk/gtksocket-stub.c:
446 Include gtksocket.h here.
448 2005-11-21 Matthias Clasen <mclasen@redhat.com>
450 * gtk/gtkinputdialog.c: Convert GtkInputDialog to
451 g_type_class_add_private.
453 * gtk/gtksocket.c: Convert GtkSocket to g_type_class_add_private.
455 * gtk/gtkmenu.c: Convert GtkMenu to g_type_class_add_private.
458 * gtk/gtkcombobox.[hc]: Add a tearoff-title property,
459 with getter and setter. (#316482, Olexiy Avramchenko)
461 * tests/testcombo.c (main): Test gtk_combo_box_set_title
463 * gtk/gtkpathbar.c: Merge remaining fixes from the 2.8 branch,
464 pointed out by Michael Natterer.
466 Fix for bug #321542, Benedikt Meurer:
468 * gtk/gtkcombobox.c (gtk_combo_box_set_active_internal):
471 (gtk_combo_box_child_show, gtk_combo_box_child_hide): Use
472 g_signal_emit, not g_signal_emit_by_name.
474 2005-11-18 Matthias Clasen <mclasen@redhat.com>
476 Fix crashes in connection with pathbar scrolling (#321560,
479 * gtk/gtkpathbar.c (gtk_path_bar_update_slider_buttons):
480 Stop scrolling when desensitising slider buttons.
481 (gtk_path_bar_scroll_timeout, gtk_path_bar_slider_button_press):
484 * gtk/gtkpathbar.h (struct _GtkPathBar): Add a separate
487 2005-11-18 Matthias Clasen <mclasen@redhat.com>
489 * gtk/gtkpathbar.c (button_clicked_cb): Fix a C99ism.
490 (#321777, Jens Granseuer)
492 * gtk/gtkaction.c (disconnect_proxy): Disconnect the
493 sync callback for the visibility property. (#321761,
496 Turn off input methods in invisible entries, since
497 they are confusing. (#317002, James Su)
499 * gtk/gtkentry.c (gtk_entry_set_visibility): Toggle input
500 methods if visibility changes.
501 (popup_targets_received): Don't show the input method
502 menu if the entry is invisible.
504 2005-11-17 Matthias Clasen <mclasen@redhat.com>
506 * README.in: Add a note about range arrow sensitivity.
508 * perf/treeview.c: const correctness fixes
509 found by Arjan van de Ven and gcc.
511 2005-11-16 Michael Natterer <mitch@imendio.com>
513 * gtk/gtkimage.c (animation_timeout): call
514 gtk_window_process_updates() so the animation keeps running even
515 if the main loop is busy with sources that eat a lot of cpu with
516 high priority. Fixes bug #321444.
518 (gtk_image_new_from_animation): document the fact that the
519 animation will stop running if the main loop is busy with sources
520 that have priorities higher than G_PRIORITY_DEFAULT.
522 * tests/testimage.c: added test case that shows an animation even
523 though a cpu-eating idle function is running.
525 2005-11-16 Michael Natterer <mitch@imendio.com>
527 * gdk/x11/gdkevents-x11.c (_gdk_events_uninit): new internal
528 function which destroys the display's event source. Also removes
529 the source from the global display_sources list and unrefs it.
531 * gdk/x11/gdkprivate-x11.h: declare the function.
533 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_dispose): call it
534 instead of half-destroying the source here.
536 2005-11-15 Matthias Clasen <mclasen@redhat.com>
538 * gtk/gtktreestore.c (gtk_tree_store_move): Fix a memory
539 leak. (#321032, Peter Zelezny)
541 2005-11-15 Michael Natterer <mitch@imendio.com>
543 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_finalize): destroy
544 display->xid_ht as late as possible (right before XCloseDisplay)
545 because it still needs to be around when the display's screens are
548 2005-11-14 Matthias Clasen <mclasen@redhat.com>
550 * gtk/gtkselection.c (gtk_selection_data_set_uris): Don't
551 leak result. (#321441, Tommi Komulainen)
553 2005-11-14 Matthias Clasen <mclasen@redhat.com>
555 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes):
556 Don't crash if there is no builtin icon.
558 2005-11-14 Michael Natterer <mitch@imendio.com>
560 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_set_property):
561 removed redundant calls to g_object_notify().
563 2005-11-13 Matthias Clasen <mclasen@redhat.com>
565 * gdk/gdkcolor.c (gdk_color_parse): Documentation
566 improvements. (#321338)
568 * gtk/gtktextiter.c (gtk_text_iter_forward_search): Make
569 limit an inclusive boundary. (#321299)
571 2005-11-12 Michael Natterer <mitch@imendio.com>
573 * gtk/Makefile.am: fixed icon rules so gtkbuiltincache.h is only
576 2005-11-12 Dom Lachowicz <cinamod@hotmail.com>
578 * modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
579 theme's handling of toolbars, handleboxes, and menubars more in-line
580 with Microsoft's IE style.
581 * modules/engines/ms-windows/*.c: Indentation cleanups
583 2005-11-12 Matthias Clasen <mclasen@redhat.com>
585 Make builtin icons work in gtk_window_set_icon_name()
586 (#321046, Maxim Udushlivy)
588 * gtk/gtkicontheme.c (insert_theme): Always insert the default
590 (ensure_valid_themes): Call _gtk_icon_theme_ensure_builtin_cache()
592 (theme_lookup_icon, find_builtin_icon): ...and not from here.
593 (gtk_icon_theme_lookup_icon): Remove an unncessary assert.
594 (gtk_icon_theme_get_icon_sizes): Also check builtin icons.
596 2005-11-12 Tor Lillqvist <tml@novell.com>
598 * gtk/gtkfilesystemwin32.c (filename_get_info): Don't hide
599 dotfiles, no such convention on Win32. Just hide files with the
600 hidden attribute. (#314627)
602 2005-11-11 Federico Mena Quintero <federico@ximian.com>
604 * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Do not
605 check whether the path is a folder. It is useful to bookmark
606 files as well (e.g. todo.txt), and this will also help
608 (shortcuts_add_bookmark_from_path): Likewise.
609 (shortcuts_activate_iter): Change folders or select files, as
612 2005-11-11 Federico Mena Quintero <federico@ximian.com>
614 * tests/autotestfilechooser.c (main): Use
615 g_log_set_default_handler() instead of explicitly setting a
616 handler for each domain.
618 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Only get
619 the base path of the volume if it is mounted.
621 2005-11-11 Michael Natterer <mitch@imendio.com>
623 Added per-stepper API for GtkRange's stepper sensitivity as
624 discussed in bug #321056:
626 * gtk/gtkenums.h: added GtkSensitivityType which can be
629 * gtk/gtkrange.[ch]: added properties "lower-stepper-sensitivity"
630 and "upper-stepper-sensitivity" and public getters/setters for
631 them. Changed stepper drawing to honor the new properties.
633 * gtk/gtk.symbols: added the new symbols.
635 2005-11-10 Matthias Clasen <mclasen@redhat.com>
637 * gtk/gtkcombobox.c: Add show-popup and hide-popup signals and
638 emit them when the popup is shown or hidden. (#162531, Tommi
641 * tests/testcombo.c: Add an example of popuplating a combobox
644 * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Another
647 * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
650 Don't corrupt odd keymaps (#316638, Kean Johnston)
652 * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
653 handle frobbing keymaps with odd numbers of syms/code.
655 * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
658 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
660 * gtk/gtkpathbar.[hc]: Add a child_path argument to
661 the path_clicked signal.
662 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
663 child_path, if it is provided.
664 * gtk/marshalers.list (path_bar_clicked): Add the necessary
667 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
672 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
673 (#163851, Richard Hult)
675 2005-11-10 Michael Natterer <mitch@imendio.com>
677 Applied patch from maemo-gtk that addresses many issues wrt
678 display migration and display closing (bug #85715).
680 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
681 default display to NULL when it's closed. Instead set the most
682 recently opened display as new default (if one exists).
684 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
687 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
688 exist before unrefing them.
690 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
691 is closed, allow destruction of the root window.
693 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
694 dispose(), free stuff that was leaked before.
696 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
697 the xsettings_client still exists before destroying it.
699 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
702 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
703 dispose() implementation.
705 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
706 dispose() and check if it still exists before unrefing it. Set
707 their pointers to NULL/None *after* upchaining in dispose(),
708 because X11 implementations of members of the parent class still
709 need them for their own destruction.
711 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
712 was g_error()ing when finalizing a visual.
714 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
715 get_clipboard_widget() because it would create the widget if it
716 doesn't exist. Use g_object_get_data() directly instead.
718 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
721 2005-11-10 Simos Xenitellis <simos@gnome.org>
723 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
725 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
727 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
728 to render its arrows insensitive when the adjustment is in
729 its min or max position. this makes range arrow behaviour
730 consistent with spin button behaviour. (#321056)
732 2005-11-09 Tor Lillqvist <tml@novell.com>
735 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
736 the GdkDebugFlag enum.
738 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
739 this file instead of MISC. Now asking for MISC will give mainly
740 window manipulation debugging output with the Win32 backend.
742 2005-11-09 Tor Lillqvist <tml@novell.com>
744 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
746 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
747 function which was used only in one place.
749 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
751 (gdk_window_set_geometry_hints): If we have identical minimum and
752 maximum size hints, remove the resize and maximize
753 decorations/functions. (#104514)
755 If we have a maximum size hint, remove the maximize
756 decoration/function but ensure the resize decoration/function is
757 available. Otherwise ensure both resize and maximize
758 decorations/functions are there.
760 (set_or_clear_style_bits): Factored out common code from
761 gdk_window_set_decorations() and gdk_window_set_functions().
763 Hack the window style setting once more: Only touch the window
764 style bits corresponding to the GdkWMDecoration or GdkWMFunction
765 parameter bitmasks. Hopefully this finally is the correct thing to
766 do. We used to clear all other bits than those that were being
767 set, or set all other bits than those that were being cleared.
769 Take into account that adding or removing decorations leaves the
770 window's outer size unchanged, i.e., the client area's size and
771 position change. This is apparently not what we want, so change
772 also the window's (outer) position and size appropriately so that
773 the client area's position and size stay constant.
775 gtk-demo's color selector dialog is now non-resizable like on X11
776 (I tested with metacity in GNOME). Torn off menus are shrinkable
777 vertically but have a maximum size, and are not maximizable or
778 minimizable, like on X11.
780 (gdk_window_set_decorations, gdk_window_set_functions): Let
781 set_or_clear_decorations() do most of the job.
783 * gdk/win32/gdkprivate-win32.h: Remove declaration of
784 _gdk_win32_get_adjusted_client_rect().
786 2005-11-09 Tor Lillqvist <tml@novell.com>
788 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
789 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
790 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
791 type hint. Implement gdk_window_get_type_hint() by just returning
794 2005-11-09 Tor Lillqvist <tml@novell.com>
796 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
797 Remove code that has been permanently ifdeffed out for two years.
799 2005-11-08 Matthias Clasen <mclasen@redhat.com>
801 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
802 finalizing a gc. (#320789, Nickolay V. Shmyrev)
804 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
805 icons if they would make the request large enough to cause
806 Xlib to loose the connection. (#320909, Claudio Saavedra)
808 2005-11-08 Michael Natterer <mitch@imendio.com>
812 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
813 extracted from maemo-gtk). Fixes bug #320872.
815 2005-11-07 Matthias Clasen <mclasen@redhat.com>
817 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
818 looks the bookmark label when reordering. (#320720, Jeremy Cook)
820 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
821 Don't grab focus when a slider button is pressed, instead, use
822 a bit in the pathbar struct to determine whether to scroll up
823 or down. (#314486, Carlos Garnacho)
825 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
826 Don't popup the completions if the focus has already been
827 moved somewhere else. (#319914, Christian Persch)
829 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
830 Raise the drag_window after reconfiguring the
831 toolbar. (#320803, Christian Persch)
834 * gtk/gtkfilechooserbutton.h:
835 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
836 with setter and getter. (#318945, Christian Persch)
838 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
840 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
842 2005-11-07 Matthias Clasen <mclasen@redhat.com>
844 * configure.in: Adjust to the stock icon changes.
846 2005-11-07 Tor Lillqvist <tml@novell.com>
848 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
849 Correct the calculation of maskstride. (#320152, Peter Zelezny)
851 2005-11-06 Michael Natterer <mitch@imendio.com>
853 * gtk/Makefile.am (icons): fixed rule to actually create the
854 symlinks, erroring out if anything goes wrong.
856 2005-11-06 Tor Lillqvist <tml@novell.com>
858 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
859 target exists on Win32. First rename the target temporarily, then
860 if the renaming of the source to target fails, restore the
861 original name for the target.
863 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
865 2005-11-06 Tor Lillqvist <tml@novell.com>
867 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
868 like pixbuf_to_hbitmaps_normal().
869 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
870 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
871 setting the G_WIN32_PRETEND_WIN9X environment variable.
873 2005-11-06 Tor Lillqvist <tml@novell.com>
875 Make icon masks work on Win98 (#320152, Peter Zelezny)
877 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
878 parameter for the depth of the bitmap, so that this function can
879 be used to create 1-bit bitmaps, too.
880 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
881 and initialize it properly.
883 2005-11-04 Matthias Clasen <mclasen@redhat.com>
885 Store builtin stock icons in an icon cache, instead of
886 populating a hash table with pixbufs at startup, to save both
887 memory and startup time.
889 * gtk/stock-icons/*: Reorganize the icons in a directory structure
890 suitable for gtk-update-icon-cache, and rename them to match the
893 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
894 add _gtk_icon_cache_has_icon_in_directory().
896 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
897 to store the contents of the icon cache in a C header.
899 * gtk/gtkbuiltincache.h: Generated private header which contains
900 the icon cache for the builtin icons.
902 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
903 icons, and use that in addition to the hash table whenever
904 builtin icons are searched.
906 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
907 use it for static stock ids.
908 (get_default_icons): Don't add the builtin
909 icons to the icon theme, just register the stock ids.
910 (render_fallback_image): Take the fallback image out of the
913 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
914 the necessary machinery to rebuild gtkbuiltincache.h.
916 2005-11-04 Michael Natterer <mitch@imendio.com>
918 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
919 from maemo-gtk that changes the mtime check for rc files from
920 '>' to '!=', otherwise theme changes go unnoticed when turning
921 back the clock (Tommi Komulainen).
923 2005-11-04 Tor Lillqvist <tml@novell.com>
925 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
928 2005-11-03 Tor Lillqvist <tml@novell.com>
930 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
931 the Win32 backend, check that GdkDisplay* parameters are equal to
932 _gdk_display instead of using the unnecessarily general
935 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
936 color bitmap to have "color" in their name, for similarity with
937 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
938 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
939 the mask bitmap's contents, ones for those pixels in the color
940 bitmap where the alpha is zero, zero for other pixels. We used to
941 use an uninitialized mask bitmap! This meant that icons and
942 cursors created presumably worked more or less by accident.
943 Totally blank icons with zero alpha everywhere (as used by
944 gtktrayicon.c) definitely did not work as expected.
946 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
948 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
949 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
950 necessary and can be removed from CVS. It has never been mentioned
951 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
952 are used on Win32. One label widget is used (but never shown) as
953 gtk_widget_render_icon() needs a widget.
955 Ifdefs used as necessary in several places. It might be cleaner to
956 split out the backend-specific parts to separate files, or at
957 least collect them into separate blocks in the file.
959 (wndproc): New function. Window procedure to monitor mouse events
960 in the system tray icon. Call gtk_status_icon_button_press() as
962 (create_tray_observer): New function. Creates a hidden window that
963 only serves as a tray icon message observer.
965 * tests/teststatusicon.c (icon_activated): Position the dialog
966 with GTK_WIN_POS_CENTER.
967 (do_quit): New function, hide and unref the GtkStatusIcon, and
968 call gtk_main_quit().
969 (popup_menu): Add a Quit menu item that calls do_quit().
971 2005-11-02 Tor Lillqvist <tml@novell.com>
973 * gdk/win32/gdkcolor-win32.c
974 * gdk/win32/gdkscreen-win32.c
975 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
976 fixes. Remove superfluous test for GdkWindow* parameters being
977 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
978 GdkScreen and one GdkDisplay in the Win32 backend, use those
979 variables instead of the getter functions. For GdkDisplay* and
980 GdkScreen* parameters, check that they are equal to the
981 corresponding singleton variables instead of the more general
982 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
984 2005-11-02 Matthias Clasen <mclasen@redhat.com>
986 * gtk/gtktextview.c: Remove some g_return_if_fail() from
987 static functions, replace some others by g_assert().
989 * gtk/gtktextview.c (selection_motion_event_handler)
990 (gtk_text_view_start_selection_drag): Keep track of the original
991 selection boundaries during a drag selection, in order to correctly
992 decide when to extend or shrink the selection. (#320167,
993 reported by Arvind S N, patch by Paolo Borelli)
995 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
996 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
997 manual offset calculations by g_utf8_offset_to_pointer().
998 (#320360, Paolo Borelli)
1000 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
1002 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
1003 nodes via the g_slice_*() API.
1004 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
1006 2005-11-01 Tor Lillqvist <tml@novell.com>
1008 * gdk/win32/gdkprivate-win32.h
1009 * gdk/win32/gdkglobals-win32.c
1010 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
1011 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
1012 their declarations, definitions and assignments into a more
1013 logical and consistent order.
1015 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
1016 CF_ prefix for the predefined clipboard format names. Put quotes
1017 around registered format names to distinguish them.
1019 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
1020 immediately with a warning if the property type is STRING, TEXT,
1021 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
1022 should never pretend to handle on Win32. Handle only UTF8_STRING
1023 here, other formats with delayed rendering. Use \uc1 instead of
1024 \uc0 when generating Rich Text Format for easier testability on
1025 XP, where WordPad misinterprets \uc0 encoded characters. Add more
1026 GDK_NOTE debugging output for Clipboard operations.
1028 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
1029 (gdk_selection_convert): Don't pretent to handle STRING, just
1030 UTF8_STRING. Streamline error handling, don't unnecessarily have a
1031 GError which then isn't used for anything anyway if it gets set.
1032 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
1033 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
1035 * config.h.win32.in: Sync with what configure produces.
1037 * configure.in: Don't look for X_PACKAGES unless building for
1038 x11. (#313986, John Ehresman)
1040 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
1042 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
1043 Wondered why there was no ku there before??
1045 2005-10-28 Matthias Clasen <mclasen@redhat.com>
1047 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
1048 window to the toplevels window group. (#319912, Christian Persch)
1050 2005-10-28 Kristian Rietveld <kris@gtk.org>
1052 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
1055 2005-10-28 Matthias Clasen <mclasen@redhat.com>
1057 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
1058 drag cursors. (#319200, Federico Mena Quintero)
1060 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
1061 Shift-G to go to the previous match, like firefox. (#320061, Christian
1064 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
1065 C99ism. (#320000, Kazuki Iwamoto)
1067 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
1068 stars. (#319985, Bastien Nocera)
1070 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
1071 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
1073 2005-10-26 Michael Natterer <mitch@imendio.com>
1077 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
1078 make sure that setting any of pixbuf/stock-id/icon-name resets the
1079 others because they are mutually exclusive, and that unsetting any
1080 of them only resets the pixbuf and nothing else. Also added
1081 some missing g_object_notify().
1083 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
1084 g_value_set_object().
1086 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
1087 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
1088 g_object_notify ("pixbuf").
1090 2005-10-27 Matthias Clasen <mclasen@redhat.com>
1092 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
1093 careful about initializing cell_area. (#319382, Tommi
1096 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
1097 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
1099 * demos/gtk-demo/clipboard.c (paste_received): Only set the
1100 text if it is not NULL. (#319930, Thomas Klausner)
1102 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
1103 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
1105 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1107 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
1108 * gtk/gtkthemes.c (gtk_theme_engine_load):
1109 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
1110 when dlopening modules. (#319557, Laszlo Peter)
1112 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1114 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
1115 segments when determining text direction. (#319065, Tommi Komulainen)
1117 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
1118 on duplicate destroy. (#318953, Gustavo Carneiro)
1120 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
1121 Point out that destroy-with-parent is a bad idea for the dialog
1122 passed to this function. (#318943, Christian Persch)
1124 * */Makefile.am: use $(GLIB_MKENUMS) instead of
1125 glib-mkenums. (#318582, Damien Carbery)
1127 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
1128 docs. (#317682, Christian Neumair)
1130 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
1131 seem to affect the placement of the data in the readonly
1132 section, and causes problems with some compilers. (#317844)
1134 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1136 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
1137 Fix some issues with background drawing in RTL. (#318781,
1140 * tests/Makefile.am:
1141 * tests/testentrycompletion.c: Apply a patch by Christian
1142 Persch to add property editors.
1144 * gtk/gtkstatusicon.c: Emit activate on single-click,
1145 not on double-click, change proposed by Milosz Derezynski.
1147 2005-10-25 Kristian Rietveld <kris@gtk.org>
1149 Fixes #311955, reported by Markku Vire; and a lot more.
1151 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
1152 Levels can now have invisible nodes cached, functions have been
1153 rewritten/refactored to take this into account; also the logic in
1154 some functions has been corrected.
1156 Each referenced node now references all visible children or a single
1157 invisible child, in order to be able to monitor all changes in the
1158 child model required for correct operation.
1160 When a virtual root is set, all nodes on the virtual root level are
1163 At last, a bunch of random bug fixes and comment updates.
1165 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1167 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
1168 more docs. (#319722, Paolo Borelli)
1170 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
1171 initialization of screen_x11->xft_rgba more explicit. (#319627,
1174 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
1175 in a blurb. (#319499, Francisco Javier F. Serrador)
1177 2005-10-24 Matthias Clasen <mclasen@redhat.com>
1179 Add settings to hide the input method and Unicode control character
1180 submenus in the context menus of GtkEntry and GtkTextView.
1182 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
1184 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
1186 * gtk/gtktextview.c (popup_targets_received):
1187 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
1189 2005-10-24 Kristian Rietveld <kris@gtk.org>
1191 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
1192 row-has-child-toggled when the level is not in the cache does not
1193 make sense. (This bug probably crept in during the early stages
1194 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
1195 implementation yet),
1196 (gtk_tree_model_sort_real_unref_node): only get the child iter
1197 when we will actually also use it.
1199 2005-10-22 Michael Natterer <mitch@imendio.com>
1201 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
1202 widget being realized, in addition to being visible, to avoid
1203 running into precondition check in gtk_tree_view_get_cell_area().
1206 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
1208 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
1209 Experimentally, scrollbar steppers can shrink to 8 pixels on
1210 Win32. Reflect that in the theme.
1211 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
1212 there is a 1-pixel border between a scrollbar and its child
1213 in ScrolledWindows on Win32. Reflect that in the theme.
1215 2005-10-20 Matthias Clasen <mclasen@redhat.com>
1217 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
1218 for the selection window. (#318806, Alex Larsson)
1220 2005-10-18 Federico Mena Quintero <federico@ximian.com>
1224 * tests/autotestfilechooser.c
1225 (test_button_folder_states_for_action): Test that we have either
1226 $cwd or the explicitly-set folder.
1227 (test_reload_sequence): Likewise.
1229 * gtk/gtkfilechooserdefault.c
1230 (gtk_file_chooser_default_get_current_folder): If our reload_state
1231 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
1233 2005-10-14 Tor Lillqvist <tml@novell.com>
1235 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
1236 It didn't really do anything useful, and was just confusing and
1237 incomplete. Comments claimed we don't do delayed rendering, but in
1238 fact we do, for images. (The delayed rendering code has other
1239 problems, though, see #168173.) The clipboard viewer code was
1240 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
1241 the message when necessary). It was just test code, it said so in
1242 a comment. Add something similar back later if necessary.
1244 (_win32_on_clipboard_change,
1245 _gdk_win32_register_clipboard_notification): Remove.
1247 (gdk_display_supports_selection_notification,
1248 gdk_display_request_selection_notification): Always just return
1249 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
1251 2005-10-13 Tor Lillqvist <tml@novell.com>
1253 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
1254 Alt-Enter specially. It does not have any special meaning and
1255 should be passed on to the application. (#318378, Tim Evans)
1257 2005-10-13 Tor Lillqvist <tml@novell.com>
1259 Set visual depth to 24 for 32 bits-per-pixel devices on
1260 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
1261 optimized composite_0888() function rather than the slower image
1262 dithering functions to draw pixbufs (#313993, John Ehresman)
1264 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
1265 _gdk_windowing_get_bits_for_depth() to initialize
1266 GdkImage::bits_per_pixel.
1267 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
1269 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
1270 _gdk_windowing_get_bits_for_depth() to initialize
1271 BITMAPINFOHEADER::biBitCount.
1273 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
1274 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
1277 2005-10-12 Stefan Kost <ensonic@users.sf.net>
1279 * demos/gtk-demo/appwindow.c: (about_cb):
1280 use PACKAGE_VERSION,bump year (#318654)
1282 2005-10-11 Matthias Clasen <mclasen@redhat.com>
1284 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
1285 toggle here with the matching on toggle if it immediately follows.
1286 This is a common case, and handling it here prevents quadratic blowup
1287 in cleanup_line() below. (#317125)
1289 * gtk/gtktextsegment.h:
1290 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
1291 the character counts into this function instead of computing them
1294 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
1296 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
1298 * gtk/gtkfilechooserdefault.c
1299 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
1300 when the shortcut already exists in the sidebar. (#147521)
1302 2005-10-09 Matthias Clasen <mclasen@redhat.com>
1304 * tests/testcombo.c: Demonstrate how to use custom widgets in
1307 2005-10-07 Federico Mena Quintero <federico@ximian.com>
1311 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
1312 the the result of gtk_file_chooser_get_folder() is NULL or
1313 non-NULL at the right times. Log the tests.
1314 (test_button_folder_states): New test for the initial states of
1315 the current folder in GtkFileChooserButton.
1316 (main): Test that the number of warnings/errors/critical errors is
1319 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
1320 Clarify the documentation on when this can return NULL.
1321 (gtk_file_chooser_get_current_folder_uri): Likewise.
1323 * gtk/gtkfilechooserbutton.c (struct
1324 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
1325 we use it to keep track of whether a folder has been set.
1326 (gtk_file_chooser_button_map): Implement. If no folder has been
1327 loaded before, we at least try to load $cwd here.
1328 (gtk_file_chooser_button_constructor): If the construct-time
1329 dialog already has a folder set, turn on our folder_has_been_set
1331 (dialog_current_folder_changed_cb): Turn on our
1332 folder_has_been_set flag.
1334 2005-10-07 Michael Natterer <mitch@gimp.org>
1336 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
1337 PROFILE_FILE_CHOOSER because they break compilation after the
1338 removal of <unistd.h>.
1340 2005-10-07 Matthias Clasen <mclasen@redhat.com>
1342 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
1343 by moving it out of the profiling ifdef.
1345 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
1346 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
1348 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
1349 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
1352 2005-10-06 Matthias Clasen <mclasen@redhat.com>
1355 * gtk/gtktextbuffer.h:
1356 * gtk/gtktextbuffer.c: Add a readonly has-selection property
1357 with a getter. (#318161, Paolo Borelli)
1359 2005-10-05 Matthias Clasen <mclasen@redhat.com>
1361 * README.in: Start collecting release notes for 2.10.
1363 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
1364 leak fix, since the assertion failures were traced to
1365 an xchat bug. (#314696)
1367 * gtk/gtkstyle.c (gtk_style_detach):
1368 (gtk_style_attach): Documentation improvements.
1369 (gtk_style_detach): Assert that the attach_count is > 0.
1371 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1373 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
1374 shortcut position, not a ShortcutsIndex, to make the function more
1376 (home_folder_handler): Pass the resolved index to
1377 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
1378 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
1379 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
1380 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
1381 make the respective key switch to the first, second, ..., tenth
1383 (quick_bookmark_handler): Implement.
1385 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1387 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
1388 Desktop; just use their real names on the file system for the
1391 * gtk/gtkfilechooserdefault.c
1392 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
1393 binding signal, and bind it to M-d by default.
1394 (desktop_folder_handler): Implement the default handler.
1395 (home_folder_handler): Use a helper function.
1396 (switch_to_shortcut): New helper function.
1397 (shortcuts_append_home): Don't special-case the name of "Home";
1398 just use the folder name.
1400 2005-10-04 Tor Lillqvist <tml@novell.com>
1402 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
1403 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
1405 2005-10-04 Matthias Clasen <mclasen@redhat.com>
1407 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
1408 from yesterday, since it leads to assertion failures. (#317879,
1411 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1413 * gtk/gtkcalendar.c (gtk_calendar_init): Call
1414 calendar_compute_days() after setting priv->week_start.
1416 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1418 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
1419 removing it from the hash table. (#314696, Benjamin Berg)
1421 2005-10-01 Tor Lillqvist <tml@novell.com>
1423 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
1424 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
1425 is that the the desktop isn't visible because the session has been
1426 switched, the screen is locked, or a terminal server session
1427 disconnected, so no error message necessary. (#137796)
1429 It is of course remotely possible that BitBlt() failing with
1430 ERROR_INVALID_HANDLE might also be caused by some other
1431 problem. We could strive for perfection and track whether the
1432 desktop is visible by using WTSRegisterSessionNotification() and
1433 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
1434 this issue, though. If we would track desktop visibility, we
1435 should then avoid even trying to update the display at all while
1436 the desktop isn't visible.
1438 2005-09-30 Matthias Clasen <mclasen@redhat.com>
1440 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
1441 to correct the calculations for the first week day. We may
1442 just have to remove this code if too many locales turn out
1443 to have broken data.
1445 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
1446 some cases. (#317611, Tommi Komulainen)
1448 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
1449 Prevent overflow when storing size hints in an unsigned
1450 short variable. Tracked down by Ray Strode and Søren Sandmann.
1452 2005-09-29 Matthias Clasen <mclasen@redhat.com>
1454 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
1457 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
1458 grab shadowed. (#317332)
1460 2005-09-29 Tor Lillqvist <tml@novell.com>
1462 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
1464 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1466 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
1467 if the unmap test fails.
1468 (test_reload_sequence): Use gtk_widget_show_now() instead of
1469 gtk_widget_show() for the dialog.
1470 Thanks to Tim Janik for noticing these.
1472 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1474 * tests/testcellrenderertext.c: New file with a set of tests for
1475 GtkCellRendererText. The idea is to run a text renderer through
1476 most of its interesting property values to see that it works
1479 * tests/Makefile.am: Added testcellrenderertext.
1481 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
1482 entry/exit of this function for profiling.
1483 (gtk_file_chooser_default_style_set): Mark the start/end of the
1484 calls to the parent class and the the signal emission for profiling.
1486 2005-09-29 Tor Lillqvist <tml@novell.com>
1488 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
1489 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
1490 system codepage using g_win32_locale_filename_from_utf8().
1491 (#317457, Kazuki Iwamoto)
1493 2005-09-28 Matthias Clasen <mclasen@redhat.com>
1495 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
1496 here. (#317039, Paolo Borelli)
1499 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
1500 to make this function work as boxed copy function. (#317455,
1503 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
1504 NULL. (#316828, Tor Lillqvist)
1506 2005-09-28 Tor Lillqvist <tml@novell.com>
1508 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
1511 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1513 Don't reload the current folder unnecessarily on ::map().
1515 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
1516 the reloading state.
1517 (struct _GtkFileChooserDefault): Added a "reload_state" field.
1519 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
1520 Initialize impl->reload_state.
1521 (gtk_file_chooser_default_map): Check the impl->reload_state; load
1522 a default folder if no folder has been set, or reload the current
1523 one only if we had been unmapped first.
1524 (gtk_file_chooser_default_update_current_folder): Set the
1525 reload_state to RELOAD_HAS_FOLDER.
1526 (gtk_file_chooser_default_unmap): Implement, and set the
1527 reload_state to RELOAD_WAS_UNMAPPED.
1528 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
1529 here; they'll get (re)loaded on ::map() anyway.
1531 * gtk/gtkfilechooserwidget.c
1532 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
1534 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
1535 a dialog; build it ourselves.
1536 (test_reload): New test to ensure that we don't load the default
1537 folder more than once, and that we reload it when
1538 unmapping/remapping.
1539 (get_impl_from_dialog): New utility function.
1540 (test_widgets_for_current_action): Use get_impl_from_dialog().
1542 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1544 * gtk/gtkfilechooserdefault.c
1545 (gtk_file_chooser_default_constructor): Mark the entry/exit of
1546 this function for profiling.
1547 (check_icon_theme): Likewise.
1548 (change_icon_theme): Likewise.
1549 (settings_notify_cb): Likewise.
1550 (gtk_file_chooser_default_screen_changed): Likewise.
1551 (update_chooser_entry): If the selection is empty, clear the file
1552 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
1553 nothing will be selected when the user starts typeahead in the
1554 treeview, and we don't want to clear the file name entry in that
1555 case --- the user could be typing-ahead to look for a folder name.
1556 Fixes bug #308332, patch by Jürg Billeter.
1558 2005-09-27 Matthias Clasen <mclasen@redhat.com>
1560 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1561 Pop below the entry if there's more free space below the entry
1562 than above. (#316948, Tommi Komulainen)
1564 2005-09-26 Federico Mena Quintero <federico@ximian.com>
1566 Do not create the save mode-specific widgets in the open modes, so
1567 that we don't carry their baggage around.
1569 * gtk/gtkfilechooserdefault.c
1570 (gtk_file_chooser_default_constructor): Don't create the
1572 (save_widgets_create): Set the impl->save_widgets directly here,
1573 instead of passing the widgets back to the caller. Also, pack
1574 them into the impl's box.
1575 (update_appearance): Create or destroy the save widgets as
1576 appropriate. Set the action of the save_file_name_entry here.
1577 (shortcuts_add_current_folder): Set the active item in the
1578 save_folder_combo only if it exists.
1579 (gtk_file_chooser_default_set_property): Don't set the action of
1580 the save_file_name_entry here.
1581 (gtk_file_chooser_default_update_current_folder): Set the base
1582 folder of the save_file_name_entry only if the entry exists.
1583 (shortcuts_drag_data_received_cb): Cast the selection_data->data
1584 to (const char *) since that's what shortcuts_drop_uris() expects.
1585 (file_list_drag_data_received_cb): Likewise, for
1586 g_uri_list_extract_uris().
1588 2005-09-26 Tor Lillqvist <tml@novell.com>
1590 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
1591 the shaped flag here, too. (#316871)
1592 (gdk_window_shape_combine_region): Currently unimplemented, so
1593 don't do anything to the shaped flag here.
1595 2005-09-26 Matthias Clasen <mclasen@redhat.com>
1597 Fix #316871, reported by Dan Winship:
1599 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
1601 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
1602 (gdk_window_shape_combine_region): Set it here.
1604 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
1605 remove the child area for shaped windows.
1607 2005-09-23 Matthias Clasen <mclasen@redhat.com>
1609 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
1610 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
1612 2005-09-22 Michael Natterer <mitch@imendio.com>
1614 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
1615 consistent with GTK+ terminology:
1617 * gtk/gtkcellrendererkeys.[ch]
1618 * tests/testkeys.c: removed...
1620 * gtk/gtkcellrendereraccel.[ch]
1621 * tests/testaccel.c: ...and added.
1626 * tests/Makefile.am: changed accordingly.
1628 2005-09-22 Matthias Clasen <mclasen@redhat.com>
1630 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
1631 for the grab-broken-event signal, noticed by Damon Chaplin.
1633 2005-09-21 Tor Lillqvist <tml@novell.com>
1635 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
1636 gdk_text_property_to_text_list_for_display,
1637 gdk_text_property_to_utf8_list_for_display,
1638 gdk_win32_selection_add_targets,
1639 _gdk_win32_selection_convert_to_dib): Free return value from
1641 (gdk_text_property_to_text_list_for_display): Drop GError variable
1642 that isn't actually used after being set.
1644 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
1646 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
1649 2005-09-20 Tor Lillqvist <tml@novell.com>
1651 * gdk/win32/gdkselection-win32.c
1652 (gdk_selection_owner_get_for_display): Do return the correct owner
1653 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
1654 a window GDK knows about). The reason to return NULL seems to have
1655 gone when in the fix for bug #163702 the artificial
1656 GDK_SELECTION_CLEAR event generation was removed from
1657 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1659 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1661 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1662 events. (#151555, Søren Sandmann)
1664 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1665 XkbSelectEventDetails() to select XkbStateNotify events
1666 for only the state we care about.
1668 * gdk/x11/gdkprivate-x11.h:
1669 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1670 the event into the function and update the keymap state from
1671 the state information contained in the event. Adjust all callers.
1673 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1675 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1676 in multiple places to avoid segfaults if the index is out of range.
1677 (#316422, Guillaume Cottenceau)
1678 (gtk_icon_view_set_drag_dest_item):
1679 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1680 #316424, Guillaume Cottenceau)
1682 2005-09-18 Hans Breuer <hans@breuer.org>
1684 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1685 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1687 2005-09-18 Hans Breuer <hans@breuer.org>
1689 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1690 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1691 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1692 the icon and is blinking with teststatusicon. More to come ...
1694 2005-09-18 Hans Breuer <hans@breuer.org>
1696 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1697 cause gtkprogressbar.c has #include <config.h> conditionally; less
1698 noise from generated gtk.def
1699 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1701 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1702 For me it works as well as the *NIX implemenation, that is not at all.
1704 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1706 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1707 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1708 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1709 again - if compiled properly.
1711 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1712 already coming with Gtk+. Makes it compile on win32.
1714 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1716 * README.cvs-commits: fixed some tiny typos
1718 2005-09-16 Tor Lillqvist <tml@novell.com>
1720 * modules/engines/ms-windows/msw_style.c (draw_extension,
1721 draw_box_gap): Check whether the widget actually is a GtkNotebook
1722 before treating it as such. Drop some unneeded local variables,
1723 use parameter with same information instead. (#316412)
1725 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1727 * tests/autotestfilechooser.c: Start a set of automated tests for
1728 the file chooser. The only test in there right now doesn't pass
1729 yet. It specifies the intended behavior of the first optimization
1730 of a series which I'll do on the file chooser (see
1731 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1732 details of this optimization).
1734 * tests/Makefile.am: Added autotestfilechooser.c.
1736 * gtk/gtkfilechooserprivate.h (struct
1737 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1738 structures to here, so that they can be accessed by
1739 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1740 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1742 * gtk/gtkfilechooserdialog.c: See above.
1744 * gtk/gtkfilechooserwidget.c: See above.
1746 * gtk/gtkfilechooserdefault.c: See above.
1748 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1751 gtk_window_map_event(): new function to work around lost unmap requests.
1754 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1756 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1757 an easy-to-find profiling marker when starting to create a file
1759 (browse_files_model_finished_loading_cb): Likewise, for when the
1760 chooser is finished loading.
1762 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1764 * gtk/gtkcolorbutton.c: Check "color" argument in
1765 gtk_color_button_set_color ()
1767 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1769 * gtk/gtklabel.c (gtk_label_get_type):
1770 * gtk/gtkbutton.c (gtk_button_get_type):
1771 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1772 using a mem chunk for window groups, buttons, labels.
1774 * gtk/updateiconcache.c (foreach_remove_func): Fix
1775 a use-after-free bug. (#316256, Alexander Nedotsukov)
1777 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1779 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1781 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1783 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1785 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1786 Let GDK_Return pass through in some more cases.
1788 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1789 activating the entry.
1791 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1792 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1793 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1795 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1796 (#316001, Guillaume Cottenceau)
1798 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1799 mistake in the docs. (#315993, Guillaume Cottenceau)
1801 * tests/testentrycompletion.c (create_simple_completion_model): Add
1802 some strings containing multibyte characters.
1804 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1805 Fix prefix insertion for multibyte characters. (#316095,
1808 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1809 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1810 return NULL if the widget is not realized. (#316023,
1811 Guillaume Cottenceau)
1813 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1816 * gdk/gdkproperty.h:
1817 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1818 New function to avoid pointless strdups when creating atoms
1819 from static strings.
1822 * gtk/*.c: Use gdk_atom_intern_static_string() where
1825 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1827 * gtk/gtkcellrendererkeys.h:
1828 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1829 and editing accelerators, a port of EggCellRendererKeys .
1833 * gtk/Makefile.am: Add the keys cell renderer.
1835 * tests/Makefile.am:
1836 * tests/testkeys.c: Test GtkCellRendererKeys
1838 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1840 Make it possible to determine if a key event is for a
1843 * gdk/x11/gdkprivate-x11.h:
1844 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1845 New function to determine if a keycode is mapped to a modifier.
1846 (get_xkb): Get the modmap.
1848 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1849 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1851 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1854 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1856 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1857 unused variable, noticed by Kjartan Maraas.
1859 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1861 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1862 Make drag reordering work properly for columns other than the
1863 first. (#315054, Dan Winship)
1865 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1866 invalid fontnames better. (#136926, Michael R. Walton)
1868 Stop cursor blinking in non-editable regions of a text view.
1869 (#311508, Torbjörn Andersson)
1871 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1872 (cursor_blinks): Take editability into account when deciding
1873 whether the cursor blinks.
1874 (gtk_text_view_button_release_event):
1875 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1877 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1878 Use connect_after to connect to the focus_out event. This
1879 ensures that the entry has already stopped blinking by the time
1880 we emit the edited signal. (#315229, Thomas Leonard)
1882 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1884 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1885 unsigned ints to -1. (#315481, Kjartan Maraas)
1887 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1888 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1889 (#314473, Stanislav Brabec)
1891 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1893 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1894 memory handling. (#314975, Torsten Schoenfeld)
1896 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1897 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1898 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1899 * gtk/gtklabel.c (gtk_label_class_init):
1900 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1901 Stylistic improvements and clarifications for some blurbs.
1902 (#315520, Clytie Siddall)
1904 2005-09-09 Tor Lillqvist <tml@novell.com>
1906 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1907 display name. There is only one GdkDisplay on Win32, and
1908 constructing the display name isn't entirely trivial, so cacheing
1909 is probably worth it. For instance GIMP calls this function a lot.
1910 (gdk_display_open): Call gdk_display_get_name() to prime the
1912 (gdk_display_get_n_screens, gdk_display_get_screen,
1913 gdk_display_get_default_screen): Verify parameter correctness like
1914 the X11 backend does.
1916 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1917 Return a freshly allocated string, as the API specifies. Fixes a
1918 heap corruption problem that caused random errors and crashes in
1921 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1923 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1924 Make C-u commit and restart hex input if we are already in a
1927 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1929 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1930 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1931 if they are mapped to the same modifier.
1933 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1934 to gtkstatusicon.c and gtktrayicon-x11.c
1936 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1937 default accel mod mask.
1939 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1940 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1941 Don't use GDK_ALT_MASK.
1943 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1945 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1947 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1949 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1952 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1953 Mod2 - Mod5 and against Super, Hyper, Meta.
1955 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1956 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1957 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1959 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1960 modmap to maintain the information which X modifiers map to
1962 (get_xkb): Set up the modmap from the XKB tables.
1963 (update_keymaps): Set up the modmap from the information returned
1964 by XGetModifierMapping in the non-XKB case.
1966 * gdk/x11/gdkprivate-x11.h:
1967 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1968 function to set the virtual modifiers in the state.
1970 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1971 _gdk_keymap_add_virtual_modifiers here.
1973 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1974 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1977 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1979 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1980 if it has no child. (#315253, John Finlay)
1982 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1984 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1986 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1988 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1989 on destroy to avoid problems when they are called on a destroyed
1990 widget. (#315135, John Cupitt)
1992 * gtk/gtkentry.c (gtk_entry_class_init):
1993 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1994 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1996 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1997 code. Now we only steal a single key combination, Ctrl-Shift-U,
1999 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
2000 by a sequence of hex digits entered with Ctrl-Shift still held.
2001 Releasing one of the modifiers or pressing space while the modifiers
2002 are still held commits the character. It is possible to erase
2003 digits using backspace.
2004 As an extension to the above, we also allow to start the sequence
2005 with Ctrl-Shift-U, then release the modifiers before typing any
2006 digits, and enter the digits without modifiers.
2007 (#82011, Owen Taylor)
2009 2005-09-02 Matthias Clasen <mclasen@redhat.com>
2011 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
2012 we still need to deliver the destroy event. (#314980, Chris Lahey)
2014 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
2015 im context before committing \n or \t.
2017 2005-09-02 Alexander Larsson <alexl@redhat.com>
2019 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
2020 (shortcuts_activate_volume):
2021 Handle base_path being null in the rest of the cases (#310270)
2023 2005-09-02 Tor Lillqvist <tml@novell.com>
2025 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
2026 cursor position also in root window coordinates. Prune out
2027 superfluous WM_MOUSEMOVE events even earlier, based on root window
2028 coordinates. Windows sends WM_MOUSEMOVE messages after a new
2029 window has ben mapped below the cursor even if the mouse doesn't
2030 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
2031 confused at least gtk_menu_motion_notify(). (#314995)
2033 * gtk/gtkintl.h: No need to include config.h here. It caused
2034 warnings about GTK_LOCALEDIR being redefined on Win32 when
2035 compiling files where gtkintl.h is included after gtkprivate.h
2036 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
2038 * gtk/gtkplug.c: Include config.h.
2040 2005-09-01 Matthias Clasen <mclasen@redhat.com>
2042 * gtk/gtkfilesystemunix.c: Pass statbufs down to
2043 xdg_mime_get_mime_type_for_file() where possible, to avoid
2046 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
2047 typo. (#314921, Guillaume Cottenceau)
2049 * gdk/*.c: Intern some more strings.
2051 * gtk/*.c: Define an I_() macro and use it instead of the
2052 bulky g_intern_static_string().
2054 2005-08-31 Matthias Clasen <mclasen@redhat.com>
2056 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
2057 instead of copying it.
2059 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
2061 * gtk/*.c: Also intern static strings passed to
2062 g_object_set_data().
2065 * gtk/Makefile.am: Intern type names in code generated by
2070 * gdk/*.c: Intern type names before registering the type to avoid
2073 * configure.in: Require GLib 2.9.0
2075 2005-08-31 Matthias Clasen <mclasen@redhat.com>
2077 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
2078 and add icon-size and icon-size-set properties. (#314172)
2080 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
2081 groups across transient parents. (#312918, Christian Persch)
2083 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
2084 Guillaume Cottenceau)
2086 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
2087 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
2089 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2091 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
2092 make C-/ select all and C-\ unselect all. (#309301,
2095 * gtk/gtkimcontextsimple.c: Change the compose sequence for
2096 soft hyphen to be multi_key-minus-minus-space, and add
2097 compose sequences multi_key-minus-minus-period and
2098 multi_key-minus-minus-minus for en dash and em dash.
2099 (#172653, Christian Lohmaier)
2101 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
2102 code. (#313946, Christian Persch)
2104 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
2105 fix for the default value of the "ui" property.
2107 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2110 * gtk/gtkselection.h:
2111 * gtk/gtkselection.c: Add functions which look for text, image
2112 or uri targets in an array of atoms. (#314089, Mark Wielaard)
2115 * gtk/gtkselection.h:
2116 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
2117 Add a function to check wether targets include uri.
2118 (#314092, Mark Wielaard)
2122 * gtk/gtkwindow.c: Add a deletable property with getter
2123 and setter, to control the close button in the window
2124 frame. (#59718, Havoc Pennington)
2126 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2128 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
2129 to the arrow keys for menu navigation. (#162825, Carl Worth)
2131 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
2133 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
2135 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
2136 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
2137 refer to nonexisting stock ids.
2139 * gtk/gtktextview.c (popup_targets_received):
2140 * gtk/gtkentry.c (popup_targets_received): Construct
2141 the "Select All" menuitem from stock.
2143 * gtk/stock-icons/stock_select_all_{16,24}.png:
2144 * gtk/stock-icons/Makefile.am:
2145 * gtk/gtkiconfactory.c:
2147 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
2150 * gtk/gtktrayicon.c: Add a pointer to the spec.
2152 * gtk/gtkstatusicon-x11.c: Add docs.
2154 * gtk/gtkstatusicon.h: Fix a typo.
2156 Add a cross-platform "tray icon" API, by
2157 porting EggStatusIcon/EggTrayIcon (#105101)
2159 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
2160 displays an icon in a notification area.
2162 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
2163 X11, using GtkTrayIcon.
2165 * gtk/gtktrayicon.h:
2166 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
2167 system tray specification, not public API.
2169 * gtk/gtk.symbols: Add new exported functions.
2171 * gtk/gtk.h: Include gtkstatusicon.h.
2173 * gtk/Makefile.am: Add new files.
2175 * tests/Makefile.am:
2176 * tests/teststatusicon.c: Test for GtkStatusIcon.
2178 2005-08-29 Christopher Aillon <caillon@redhat.com>
2180 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
2181 and GTK_STOCK_DISCONNECT
2183 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2185 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
2186 Use XFixesChangeSaveSet if available. (#314682)
2188 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
2189 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
2191 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2193 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
2194 accidentally leftover duplicate pixbuf creation. (#314700,
2197 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
2198 leak the cursor theme name. (#314693, Kjartan Maraas)
2200 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
2201 state.children in all cases. (#313862, Kjartan Maraas)
2203 2005-08-28 Matthias Clasen <mclasen@redhat.com>
2205 * po/POTFILES.in, po-properties/POTFILES.in:
2208 2005-08-27 Matthias Clasen <mclasen@redhat.com>
2210 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
2211 value of the ui property. (#314532, Yong Wang)
2213 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
2214 when G_MAXLONG is passed as length.
2216 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2218 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
2219 to avoid overloading --force. (JP Rosevaar)
2221 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2223 * configure.in: Bump version to 2.9.0
2227 * gdk/gdkscreen.c: Make the GdkScreen font options api
2228 public, and add properties GdkScreen::font-options and
2229 GdkScreen::resolution. (#314004)
2232 * gtk/gtksettings.c:
2233 * gtk/gtkwidget.c: Adjust all callers.
2235 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
2236 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
2237 * gdk/gdkscreen.c: Include gdkintl.h.
2239 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
2240 variable warning, pointed out by Colin Walters. (#314585)
2242 2005-08-26 Tor Lillqvist <tml@novell.com>
2244 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
2246 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
2248 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2250 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
2251 of week_start. (#314473, JP Rosevaar)
2253 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
2255 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
2256 lock. (#314533, Thomas Fitzsimmons)
2258 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2260 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
2261 NULL gracefully. (#314523, Ed Catmur)
2263 2005-08-25 Owen Taylor <otaylor@redhat.com>
2265 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
2266 Handle theme == NULL.
2268 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2270 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
2271 y offset into account when positioning the popup. (#314470,
2274 2005-08-25 Owen Taylor <otaylor@redhat.com>
2276 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
2277 as instance_init, not base_init! (#314452, Fix from Frederic
2278 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
2279 rather than 1 for a negative flag value.
2281 2005-08-24 Owen Taylor <otaylor@redhat.com>
2283 * gdk/gdkpango.c (draw_error_underline): Add a note about
2284 cut-and-paste between here and Pango.
2286 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2288 * === Released 2.8.2 ===
2290 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
2291 callback for image/gif, and also try image/bmp. (#314086, Mark
2294 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
2295 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
2300 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
2301 and cursor settings get propagated down to the screen initially.
2302 Pointed out by Frederic Crozat.
2304 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
2305 message if the screen is NULL. Noticed by Kjartan Maraas.
2307 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2311 * === Released 2.8.1 ===
2315 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2317 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
2318 against lazy filterers which return values other than TRUE or
2319 FALSE from their visible func. (#314335)
2321 2005-08-23 Owen Taylor <otaylor@redhat.com>
2323 Fix for #314004, reported by Michael Reinsch:
2326 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
2327 Add gdk_screen_get/set_resolution_libgtk_only()
2329 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
2330 the options for the screen on the newly created context.
2332 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
2333 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
2334 the font options on the screen.
2336 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
2337 the font options from the screen and set them on the context.
2339 2005-08-23 Kristian Rietveld <kris@gtk.org>
2341 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
2342 bother inserting new rows in a level with a zero refcount and
2343 immediately free the level. (Fixes #312350, reported by Markku Vire).
2345 2005-08-23 Matthias Clasen <mclasen@redhat.com>
2347 * gtk/updateiconcache.c: Complain when there is no index.theme file
2348 in the specified directory, unless --force is used. Also add an
2349 --index-only option to create caches without image data.
2351 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
2352 C99ism. (#314262, Robert Jeff Mitchell)
2354 2005-08-22 Manish Singh <yosh@gimp.org>
2356 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
2358 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
2360 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2362 * gtk/gtkwindow.c (gtk_window_client_event):
2363 * gtk/gtkicontheme.c (ensure_valid_themes)
2364 (_gtk_icon_theme_check_reload): Implement a clientmessage based
2365 scheme for makeing sure that all GTK+ applications notice if an
2366 icon theme has been updated. This should prevent multiple versions
2367 of an icon theme cache to be mapped in memory at the same time,
2368 which can cause excessive memory consumption. (#313156, Chris
2371 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2373 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
2374 regarding icon theme changes.
2376 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
2377 pixbufs which are backed by the mmapped memory of an icon cache,
2378 increase the refcount of the icon cache, so that the memory is not
2379 munmapped away underneath the pixbuf upon icon theme changes.
2380 (#314170, Kjartan Maraas)
2382 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
2383 to link against Xext. (#314062)
2385 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
2386 overruns. (#314081, Hans Breuer)
2388 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2390 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
2391 returned layout must not be modified.
2393 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
2395 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
2396 scroll_to_path if the model changes.
2398 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
2399 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
2400 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
2401 we're realized, #312798
2402 (gtk_icon_view_set_model): clear scroll_to_path if the model
2405 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2407 * gtk/gtkrange.c (gtk_range_adjustment_changed)
2408 (gtk_range_adjustment_value_changed): Don't queue a draw
2409 if the layout has not changed. (#313991, Benjamin Berg)
2411 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2413 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
2416 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
2419 * gtk/gtkfilechooserbutton.c (change_icon_theme)
2420 (model_add_special, model_add_special, model_add_volumes):
2421 Handle pixbuf being NULL without warnings. Also, don't
2422 leak pixbuf references when the icon theme is changed.
2424 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
2425 the user data on destroyed windows, since at best
2426 it can be a stale pointer. (#313953, Robin Green)
2428 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2430 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
2431 (#313900, Sebastien Bacher)
2433 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
2434 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
2436 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
2437 (xdnd_read_actions, get_client_window_at_coords_recurse):
2438 Free data returned from XGetWindowProperty.
2440 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
2441 Free data returned from XGetWindowProperty. (313867, Kjartan
2444 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
2445 children in all cases. (#313862, Kjartan Maraas)
2447 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
2448 in the per-directory hash, even if they come from the icon cache.
2449 We tried to avoid that before, but as a result leaked icon data
2450 structs. (#313852, Kjartan Maraas)
2452 2005-08-18 Matthias Clasen <mclasen@redhat.com>
2454 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
2455 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
2457 2005-08-15 Owen Taylor <otaylor@redhat.com>
2459 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
2460 files for x11/xext. (Jonas Bonn)
2462 2005-08-15 Tor Lillqvist <tml@novell.com>
2464 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
2467 2005-08-15 Owen Taylor <otaylor@redhat.com>
2469 * configure.in: Fix have_base_pc / have_base_x_pc typo.
2471 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
2472 (#313417, James Andrewartha)
2474 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
2475 FcNameConstant(). (More of #313417)
2477 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2479 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
2480 modal dialogs, make sure to inherit the window group from
2481 the parent, since we don't inherit window groups across
2482 transient parents currently. (#312918, Christian Persch)
2484 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
2485 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
2487 * gtk/gtkiconview.c (gtk_icon_view_select_path)
2488 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
2489 gracefully. (#312796, Jonathan Blandford)
2491 * tests/testtoolbar.c: Add some more tests for menu placement.
2493 * gtk/gtkmenutoolbutton.c (menu_position_func):
2494 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
2495 of toolbutton menus and of the overflow menu. (#312937,
2496 #153870, Christian Persch, Paolo Borelli)
2498 2005-08-15 Tor Lillqvist <tml@novell.com>
2500 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
2501 the nonportable <libgen.h> and dirname().
2503 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2505 * gtk/gtksizegroup.c: Use object data to mark widgets and
2506 groups as visited, so that we avoid constant extra list
2507 traversals. Also allocate quarks in class_init. (#311618,
2510 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
2511 download location for the hicolor icon theme. (#313475, Olexiy
2514 * gtk/gtkicontheme.c: Remove debug spew.
2516 2005-08-15 Owen Taylor <otaylor@redhat.com>
2518 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
2519 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
2520 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
2521 Handle pixmap == NULL when checking for a colormap.
2524 2005-08-14 Matthias Clasen <mclasen@redhat.com>
2526 * gtk/updateiconcache.c: Store only one copy of the pixel data
2527 for symlinked icons. To achieve this, maintain a hashtable
2528 mapping pathnames to pixel data, and share the pixel data for
2529 all symlinks resolving to the same pathname. When writing out
2530 the image data, write out the pixel data only the first time
2531 it is met, and store the offset pointing to the first copy
2532 for use in all later cases.
2533 This reduces the size of the Bluecurve icon cache from 40