1 2005-11-01 Tor Lillqvist <tml@novell.com>
3 * config.h.win32.in: Sync with what configure produces.
5 * configure.in: Don't look for X_PACKAGES unless building for
6 x11. (#313986, John Ehresman)
8 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
10 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
11 Wondered why there was no ku there before??
13 2005-10-28 Matthias Clasen <mclasen@redhat.com>
15 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
16 window to the toplevels window group. (#319912, Christian Persch)
18 2005-10-28 Kristian Rietveld <kris@gtk.org>
20 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
23 2005-10-28 Matthias Clasen <mclasen@redhat.com>
25 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
26 drag cursors. (#319200, Federico Mena Quintero)
28 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
29 Shift-G to go to the previous match, like firefox. (#320061, Christian
32 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
33 C99ism. (#320000, Kazuki Iwamoto)
35 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
36 stars. (#319985, Bastien Nocera)
38 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
39 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
41 2005-10-26 Michael Natterer <mitch@imendio.com>
45 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
46 make sure that setting any of pixbuf/stock-id/icon-name resets the
47 others because they are mutually exclusive, and that unsetting any
48 of them only resets the pixbuf and nothing else. Also added
49 some missing g_object_notify().
51 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
54 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
55 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
56 g_object_notify ("pixbuf").
58 2005-10-27 Matthias Clasen <mclasen@redhat.com>
60 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
61 careful about initializing cell_area. (#319382, Tommi
64 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
65 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
67 * demos/gtk-demo/clipboard.c (paste_received): Only set the
68 text if it is not NULL. (#319930, Thomas Klausner)
70 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
71 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
73 2005-10-26 Matthias Clasen <mclasen@redhat.com>
75 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
76 * gtk/gtkthemes.c (gtk_theme_engine_load):
77 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
78 when dlopening modules. (#319557, Laszlo Peter)
80 2005-10-26 Matthias Clasen <mclasen@redhat.com>
82 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
83 segments when determining text direction. (#319065, Tommi Komulainen)
85 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
86 on duplicate destroy. (#318953, Gustavo Carneiro)
88 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
89 Point out that destroy-with-parent is a bad idea for the dialog
90 passed to this function. (#318943, Christian Persch)
92 * */Makefile.am: use $(GLIB_MKENUMS) instead of
93 glib-mkenums. (#318582, Damien Carbery)
95 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
96 docs. (#317682, Christian Neumair)
98 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
99 seem to affect the placement of the data in the readonly
100 section, and causes problems with some compilers. (#317844)
102 2005-10-25 Matthias Clasen <mclasen@redhat.com>
104 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
105 Fix some issues with background drawing in RTL. (#318781,
109 * tests/testentrycompletion.c: Apply a patch by Christian
110 Persch to add property editors.
112 * gtk/gtkstatusicon.c: Emit activate on single-click,
113 not on double-click, change proposed by Milosz Derezynski.
115 2005-10-25 Kristian Rietveld <kris@gtk.org>
117 Fixes #311955, reported by Markku Vire; and a lot more.
119 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
120 Levels can now have invisible nodes cached, functions have been
121 rewritten/refactored to take this into account; also the logic in
122 some functions has been corrected.
124 Each referenced node now references all visible children or a single
125 invisible child, in order to be able to monitor all changes in the
126 child model required for correct operation.
128 When a virtual root is set, all nodes on the virtual root level are
131 At last, a bunch of random bug fixes and comment updates.
133 2005-10-25 Matthias Clasen <mclasen@redhat.com>
135 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
136 more docs. (#319722, Paolo Borelli)
138 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
139 initialization of screen_x11->xft_rgba more explicit. (#319627,
142 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
143 in a blurb. (#319499, Francisco Javier F. Serrador)
145 2005-10-24 Matthias Clasen <mclasen@redhat.com>
147 Add settings to hide the input method and Unicode control character
148 submenus in the context menus of GtkEntry and GtkTextView.
150 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
152 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
154 * gtk/gtktextview.c (popup_targets_received):
155 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
157 2005-10-24 Kristian Rietveld <kris@gtk.org>
159 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
160 row-has-child-toggled when the level is not in the cache does not
161 make sense. (This bug probably crept in during the early stages
162 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
164 (gtk_tree_model_sort_real_unref_node): only get the child iter
165 when we will actually also use it.
167 2005-10-22 Michael Natterer <mitch@imendio.com>
169 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
170 widget being realized, in addition to being visible, to avoid
171 running into precondition check in gtk_tree_view_get_cell_area().
174 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
176 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
177 Experimentally, scrollbar steppers can shrink to 8 pixels on
178 Win32. Reflect that in the theme.
179 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
180 there is a 1-pixel border between a scrollbar and its child
181 in ScrolledWindows on Win32. Reflect that in the theme.
183 2005-10-20 Matthias Clasen <mclasen@redhat.com>
185 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
186 for the selection window. (#318806, Alex Larsson)
188 2005-10-18 Federico Mena Quintero <federico@ximian.com>
192 * tests/autotestfilechooser.c
193 (test_button_folder_states_for_action): Test that we have either
194 $cwd or the explicitly-set folder.
195 (test_reload_sequence): Likewise.
197 * gtk/gtkfilechooserdefault.c
198 (gtk_file_chooser_default_get_current_folder): If our reload_state
199 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
201 2005-10-14 Tor Lillqvist <tml@novell.com>
203 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
204 It didn't really do anything useful, and was just confusing and
205 incomplete. Comments claimed we don't do delayed rendering, but in
206 fact we do, for images. (The delayed rendering code has other
207 problems, though, see #168173.) The clipboard viewer code was
208 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
209 the message when necessary). It was just test code, it said so in
210 a comment. Add something similar back later if necessary.
212 (_win32_on_clipboard_change,
213 _gdk_win32_register_clipboard_notification): Remove.
215 (gdk_display_supports_selection_notification,
216 gdk_display_request_selection_notification): Always just return
217 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
219 2005-10-13 Tor Lillqvist <tml@novell.com>
221 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
222 Alt-Enter specially. It does not have any special meaning and
223 should be passed on to the application. (#318378, Tim Evans)
225 2005-10-13 Tor Lillqvist <tml@novell.com>
227 Set visual depth to 24 for 32 bits-per-pixel devices on
228 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
229 optimized composite_0888() function rather than the slower image
230 dithering functions to draw pixbufs (#313993, John Ehresman)
232 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
233 _gdk_windowing_get_bits_for_depth() to initialize
234 GdkImage::bits_per_pixel.
235 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
237 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
238 _gdk_windowing_get_bits_for_depth() to initialize
239 BITMAPINFOHEADER::biBitCount.
241 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
242 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
245 2005-10-12 Stefan Kost <ensonic@users.sf.net>
247 * demos/gtk-demo/appwindow.c: (about_cb):
248 use PACKAGE_VERSION,bump year (#318654)
250 2005-10-11 Matthias Clasen <mclasen@redhat.com>
252 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
253 toggle here with the matching on toggle if it immediately follows.
254 This is a common case, and handling it here prevents quadratic blowup
255 in cleanup_line() below. (#317125)
257 * gtk/gtktextsegment.h:
258 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
259 the character counts into this function instead of computing them
262 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
264 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
266 * gtk/gtkfilechooserdefault.c
267 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
268 when the shortcut already exists in the sidebar. (#147521)
270 2005-10-09 Matthias Clasen <mclasen@redhat.com>
272 * tests/testcombo.c: Demonstrate how to use custom widgets in
275 2005-10-07 Federico Mena Quintero <federico@ximian.com>
279 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
280 the the result of gtk_file_chooser_get_folder() is NULL or
281 non-NULL at the right times. Log the tests.
282 (test_button_folder_states): New test for the initial states of
283 the current folder in GtkFileChooserButton.
284 (main): Test that the number of warnings/errors/critical errors is
287 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
288 Clarify the documentation on when this can return NULL.
289 (gtk_file_chooser_get_current_folder_uri): Likewise.
291 * gtk/gtkfilechooserbutton.c (struct
292 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
293 we use it to keep track of whether a folder has been set.
294 (gtk_file_chooser_button_map): Implement. If no folder has been
295 loaded before, we at least try to load $cwd here.
296 (gtk_file_chooser_button_constructor): If the construct-time
297 dialog already has a folder set, turn on our folder_has_been_set
299 (dialog_current_folder_changed_cb): Turn on our
300 folder_has_been_set flag.
302 2005-10-07 Michael Natterer <mitch@gimp.org>
304 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
305 PROFILE_FILE_CHOOSER because they break compilation after the
306 removal of <unistd.h>.
308 2005-10-07 Matthias Clasen <mclasen@redhat.com>
310 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
311 by moving it out of the profiling ifdef.
313 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
314 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
316 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
317 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
320 2005-10-06 Matthias Clasen <mclasen@redhat.com>
323 * gtk/gtktextbuffer.h:
324 * gtk/gtktextbuffer.c: Add a readonly has-selection property
325 with a getter. (#318161, Paolo Borelli)
327 2005-10-05 Matthias Clasen <mclasen@redhat.com>
329 * README.in: Start collecting release notes for 2.10.
331 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
332 leak fix, since the assertion failures were traced to
333 an xchat bug. (#314696)
335 * gtk/gtkstyle.c (gtk_style_detach):
336 (gtk_style_attach): Documentation improvements.
337 (gtk_style_detach): Assert that the attach_count is > 0.
339 2005-10-04 Federico Mena Quintero <federico@ximian.com>
341 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
342 shortcut position, not a ShortcutsIndex, to make the function more
344 (home_folder_handler): Pass the resolved index to
345 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
346 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
347 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
348 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
349 make the respective key switch to the first, second, ..., tenth
351 (quick_bookmark_handler): Implement.
353 2005-10-04 Federico Mena Quintero <federico@ximian.com>
355 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
356 Desktop; just use their real names on the file system for the
359 * gtk/gtkfilechooserdefault.c
360 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
361 binding signal, and bind it to M-d by default.
362 (desktop_folder_handler): Implement the default handler.
363 (home_folder_handler): Use a helper function.
364 (switch_to_shortcut): New helper function.
365 (shortcuts_append_home): Don't special-case the name of "Home";
366 just use the folder name.
368 2005-10-04 Tor Lillqvist <tml@novell.com>
370 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
371 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
373 2005-10-04 Matthias Clasen <mclasen@redhat.com>
375 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
376 from yesterday, since it leads to assertion failures. (#317879,
379 2005-10-03 Matthias Clasen <mclasen@redhat.com>
381 * gtk/gtkcalendar.c (gtk_calendar_init): Call
382 calendar_compute_days() after setting priv->week_start.
384 2005-10-03 Matthias Clasen <mclasen@redhat.com>
386 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
387 removing it from the hash table. (#314696, Benjamin Berg)
389 2005-10-01 Tor Lillqvist <tml@novell.com>
391 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
392 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
393 is that the the desktop isn't visible because the session has been
394 switched, the screen is locked, or a terminal server session
395 disconnected, so no error message necessary. (#137796)
397 It is of course remotely possible that BitBlt() failing with
398 ERROR_INVALID_HANDLE might also be caused by some other
399 problem. We could strive for perfection and track whether the
400 desktop is visible by using WTSRegisterSessionNotification() and
401 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
402 this issue, though. If we would track desktop visibility, we
403 should then avoid even trying to update the display at all while
404 the desktop isn't visible.
406 2005-09-30 Matthias Clasen <mclasen@redhat.com>
408 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
409 to correct the calculations for the first week day. We may
410 just have to remove this code if too many locales turn out
413 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
414 some cases. (#317611, Tommi Komulainen)
416 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
417 Prevent overflow when storing size hints in an unsigned
418 short variable. Tracked down by Ray Strode and Søren Sandmann.
420 2005-09-29 Matthias Clasen <mclasen@redhat.com>
422 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
425 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
426 grab shadowed. (#317332)
428 2005-09-29 Tor Lillqvist <tml@novell.com>
430 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
432 2005-09-28 Federico Mena Quintero <federico@ximian.com>
434 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
435 if the unmap test fails.
436 (test_reload_sequence): Use gtk_widget_show_now() instead of
437 gtk_widget_show() for the dialog.
438 Thanks to Tim Janik for noticing these.
440 2005-09-28 Federico Mena Quintero <federico@ximian.com>
442 * tests/testcellrenderertext.c: New file with a set of tests for
443 GtkCellRendererText. The idea is to run a text renderer through
444 most of its interesting property values to see that it works
447 * tests/Makefile.am: Added testcellrenderertext.
449 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
450 entry/exit of this function for profiling.
451 (gtk_file_chooser_default_style_set): Mark the start/end of the
452 calls to the parent class and the the signal emission for profiling.
454 2005-09-29 Tor Lillqvist <tml@novell.com>
456 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
457 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
458 system codepage using g_win32_locale_filename_from_utf8().
459 (#317457, Kazuki Iwamoto)
461 2005-09-28 Matthias Clasen <mclasen@redhat.com>
463 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
464 here. (#317039, Paolo Borelli)
467 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
468 to make this function work as boxed copy function. (#317455,
471 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
472 NULL. (#316828, Tor Lillqvist)
474 2005-09-28 Tor Lillqvist <tml@novell.com>
476 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
479 2005-09-27 Federico Mena Quintero <federico@ximian.com>
481 Don't reload the current folder unnecessarily on ::map().
483 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
485 (struct _GtkFileChooserDefault): Added a "reload_state" field.
487 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
488 Initialize impl->reload_state.
489 (gtk_file_chooser_default_map): Check the impl->reload_state; load
490 a default folder if no folder has been set, or reload the current
491 one only if we had been unmapped first.
492 (gtk_file_chooser_default_update_current_folder): Set the
493 reload_state to RELOAD_HAS_FOLDER.
494 (gtk_file_chooser_default_unmap): Implement, and set the
495 reload_state to RELOAD_WAS_UNMAPPED.
496 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
497 here; they'll get (re)loaded on ::map() anyway.
499 * gtk/gtkfilechooserwidget.c
500 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
502 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
503 a dialog; build it ourselves.
504 (test_reload): New test to ensure that we don't load the default
505 folder more than once, and that we reload it when
507 (get_impl_from_dialog): New utility function.
508 (test_widgets_for_current_action): Use get_impl_from_dialog().
510 2005-09-27 Federico Mena Quintero <federico@ximian.com>
512 * gtk/gtkfilechooserdefault.c
513 (gtk_file_chooser_default_constructor): Mark the entry/exit of
514 this function for profiling.
515 (check_icon_theme): Likewise.
516 (change_icon_theme): Likewise.
517 (settings_notify_cb): Likewise.
518 (gtk_file_chooser_default_screen_changed): Likewise.
519 (update_chooser_entry): If the selection is empty, clear the file
520 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
521 nothing will be selected when the user starts typeahead in the
522 treeview, and we don't want to clear the file name entry in that
523 case --- the user could be typing-ahead to look for a folder name.
524 Fixes bug #308332, patch by Jürg Billeter.
526 2005-09-27 Matthias Clasen <mclasen@redhat.com>
528 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
529 Pop below the entry if there's more free space below the entry
530 than above. (#316948, Tommi Komulainen)
532 2005-09-26 Federico Mena Quintero <federico@ximian.com>
534 Do not create the save mode-specific widgets in the open modes, so
535 that we don't carry their baggage around.
537 * gtk/gtkfilechooserdefault.c
538 (gtk_file_chooser_default_constructor): Don't create the
540 (save_widgets_create): Set the impl->save_widgets directly here,
541 instead of passing the widgets back to the caller. Also, pack
542 them into the impl's box.
543 (update_appearance): Create or destroy the save widgets as
544 appropriate. Set the action of the save_file_name_entry here.
545 (shortcuts_add_current_folder): Set the active item in the
546 save_folder_combo only if it exists.
547 (gtk_file_chooser_default_set_property): Don't set the action of
548 the save_file_name_entry here.
549 (gtk_file_chooser_default_update_current_folder): Set the base
550 folder of the save_file_name_entry only if the entry exists.
551 (shortcuts_drag_data_received_cb): Cast the selection_data->data
552 to (const char *) since that's what shortcuts_drop_uris() expects.
553 (file_list_drag_data_received_cb): Likewise, for
554 g_uri_list_extract_uris().
556 2005-09-26 Tor Lillqvist <tml@novell.com>
558 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
559 the shaped flag here, too. (#316871)
560 (gdk_window_shape_combine_region): Currently unimplemented, so
561 don't do anything to the shaped flag here.
563 2005-09-26 Matthias Clasen <mclasen@redhat.com>
565 Fix #316871, reported by Dan Winship:
567 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
569 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
570 (gdk_window_shape_combine_region): Set it here.
572 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
573 remove the child area for shaped windows.
575 2005-09-23 Matthias Clasen <mclasen@redhat.com>
577 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
578 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
580 2005-09-22 Michael Natterer <mitch@imendio.com>
582 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
583 consistent with GTK+ terminology:
585 * gtk/gtkcellrendererkeys.[ch]
586 * tests/testkeys.c: removed...
588 * gtk/gtkcellrendereraccel.[ch]
589 * tests/testaccel.c: ...and added.
594 * tests/Makefile.am: changed accordingly.
596 2005-09-22 Matthias Clasen <mclasen@redhat.com>
598 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
599 for the grab-broken-event signal, noticed by Damon Chaplin.
601 2005-09-21 Tor Lillqvist <tml@novell.com>
603 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
604 gdk_text_property_to_text_list_for_display,
605 gdk_text_property_to_utf8_list_for_display,
606 gdk_win32_selection_add_targets,
607 _gdk_win32_selection_convert_to_dib): Free return value from
609 (gdk_text_property_to_text_list_for_display): Drop GError variable
610 that isn't actually used after being set.
612 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
614 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
617 2005-09-20 Tor Lillqvist <tml@novell.com>
619 * gdk/win32/gdkselection-win32.c
620 (gdk_selection_owner_get_for_display): Do return the correct owner
621 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
622 a window GDK knows about). The reason to return NULL seems to have
623 gone when in the fix for bug #163702 the artificial
624 GDK_SELECTION_CLEAR event generation was removed from
625 gdk_selection_send_notify_for_display(). Fixes bug #316552.
627 2005-09-20 Matthias Clasen <mclasen@redhat.com>
629 Avoid unnecessary XkbGetState() calls and XkbStateNotify
630 events. (#151555, Søren Sandmann)
632 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
633 XkbSelectEventDetails() to select XkbStateNotify events
634 for only the state we care about.
636 * gdk/x11/gdkprivate-x11.h:
637 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
638 the event into the function and update the keymap state from
639 the state information contained in the event. Adjust all callers.
641 2005-09-19 Matthias Clasen <mclasen@redhat.com>
643 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
644 in multiple places to avoid segfaults if the index is out of range.
645 (#316422, Guillaume Cottenceau)
646 (gtk_icon_view_set_drag_dest_item):
647 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
648 #316424, Guillaume Cottenceau)
650 2005-09-18 Hans Breuer <hans@breuer.org>
652 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
653 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
655 2005-09-18 Hans Breuer <hans@breuer.org>
657 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
658 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
659 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
660 the icon and is blinking with teststatusicon. More to come ...
662 2005-09-18 Hans Breuer <hans@breuer.org>
664 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
665 cause gtkprogressbar.c has #include <config.h> conditionally; less
666 noise from generated gtk.def
667 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
669 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
670 For me it works as well as the *NIX implemenation, that is not at all.
672 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
674 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
675 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
676 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
677 again - if compiled properly.
679 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
680 already coming with Gtk+. Makes it compile on win32.
682 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
684 * README.cvs-commits: fixed some tiny typos
686 2005-09-16 Tor Lillqvist <tml@novell.com>
688 * modules/engines/ms-windows/msw_style.c (draw_extension,
689 draw_box_gap): Check whether the widget actually is a GtkNotebook
690 before treating it as such. Drop some unneeded local variables,
691 use parameter with same information instead. (#316412)
693 2005-09-15 Federico Mena Quintero <federico@ximian.com>
695 * tests/autotestfilechooser.c: Start a set of automated tests for
696 the file chooser. The only test in there right now doesn't pass
697 yet. It specifies the intended behavior of the first optimization
698 of a series which I'll do on the file chooser (see
699 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
700 details of this optimization).
702 * tests/Makefile.am: Added autotestfilechooser.c.
704 * gtk/gtkfilechooserprivate.h (struct
705 _GtkFileChooserDialogPrivate): Move all the file chooser's private
706 structures to here, so that they can be accessed by
707 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
708 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
710 * gtk/gtkfilechooserdialog.c: See above.
712 * gtk/gtkfilechooserwidget.c: See above.
714 * gtk/gtkfilechooserdefault.c: See above.
716 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
719 gtk_window_map_event(): new function to work around lost unmap requests.
722 2005-09-14 Federico Mena Quintero <federico@ximian.com>
724 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
725 an easy-to-find profiling marker when starting to create a file
727 (browse_files_model_finished_loading_cb): Likewise, for when the
728 chooser is finished loading.
730 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
732 * gtk/gtkcolorbutton.c: Check "color" argument in
733 gtk_color_button_set_color ()
735 2005-09-14 Matthias Clasen <mclasen@redhat.com>
737 * gtk/gtklabel.c (gtk_label_get_type):
738 * gtk/gtkbutton.c (gtk_button_get_type):
739 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
740 using a mem chunk for window groups, buttons, labels.
742 * gtk/updateiconcache.c (foreach_remove_func): Fix
743 a use-after-free bug. (#316256, Alexander Nedotsukov)
745 2005-09-13 Matthias Clasen <mclasen@redhat.com>
747 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
749 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
751 2005-09-13 Matthias Clasen <mclasen@redhat.com>
753 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
754 Let GDK_Return pass through in some more cases.
756 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
757 activating the entry.
759 * gtk/gtkiconview.c (gtk_icon_view_class_init):
760 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
761 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
763 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
764 (#316001, Guillaume Cottenceau)
766 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
767 mistake in the docs. (#315993, Guillaume Cottenceau)
769 * tests/testentrycompletion.c (create_simple_completion_model): Add
770 some strings containing multibyte characters.
772 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
773 Fix prefix insertion for multibyte characters. (#316095,
776 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
777 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
778 return NULL if the widget is not realized. (#316023,
779 Guillaume Cottenceau)
781 2005-09-11 Matthias Clasen <mclasen@redhat.com>
785 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
786 New function to avoid pointless strdups when creating atoms
790 * gtk/*.c: Use gdk_atom_intern_static_string() where
793 2005-09-09 Matthias Clasen <mclasen@redhat.com>
795 * gtk/gtkcellrendererkeys.h:
796 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
797 and editing accelerators, a port of EggCellRendererKeys .
801 * gtk/Makefile.am: Add the keys cell renderer.
804 * tests/testkeys.c: Test GtkCellRendererKeys
806 2005-09-09 Matthias Clasen <mclasen@redhat.com>
808 Make it possible to determine if a key event is for a
811 * gdk/x11/gdkprivate-x11.h:
812 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
813 New function to determine if a keycode is mapped to a modifier.
814 (get_xkb): Get the modmap.
816 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
817 is_modifier bit by calling _gdk_keymap_key_is_modifier().
819 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
822 2005-09-09 Matthias Clasen <mclasen@redhat.com>
824 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
825 unused variable, noticed by Kjartan Maraas.
827 2005-09-09 Matthias Clasen <mclasen@redhat.com>
829 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
830 Make drag reordering work properly for columns other than the
831 first. (#315054, Dan Winship)
833 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
834 invalid fontnames better. (#136926, Michael R. Walton)
836 Stop cursor blinking in non-editable regions of a text view.
837 (#311508, Torbjörn Andersson)
839 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
840 (cursor_blinks): Take editability into account when deciding
841 whether the cursor blinks.
842 (gtk_text_view_button_release_event):
843 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
845 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
846 Use connect_after to connect to the focus_out event. This
847 ensures that the entry has already stopped blinking by the time
848 we emit the edited signal. (#315229, Thomas Leonard)
850 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
852 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
853 unsigned ints to -1. (#315481, Kjartan Maraas)
855 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
856 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
857 (#314473, Stanislav Brabec)
859 2005-09-09 Matthias Clasen <mclasen@redhat.com>
861 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
862 memory handling. (#314975, Torsten Schoenfeld)
864 * gtk/gtkiconview.c (gtk_icon_view_class_init):
865 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
866 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
867 * gtk/gtklabel.c (gtk_label_class_init):
868 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
869 Stylistic improvements and clarifications for some blurbs.
870 (#315520, Clytie Siddall)
872 2005-09-09 Tor Lillqvist <tml@novell.com>
874 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
875 display name. There is only one GdkDisplay on Win32, and
876 constructing the display name isn't entirely trivial, so cacheing
877 is probably worth it. For instance GIMP calls this function a lot.
878 (gdk_display_open): Call gdk_display_get_name() to prime the
880 (gdk_display_get_n_screens, gdk_display_get_screen,
881 gdk_display_get_default_screen): Verify parameter correctness like
882 the X11 backend does.
884 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
885 Return a freshly allocated string, as the API specifies. Fixes a
886 heap corruption problem that caused random errors and crashes in
889 2005-09-07 Matthias Clasen <mclasen@redhat.com>
891 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
892 Make C-u commit and restart hex input if we are already in a
895 2005-09-06 Matthias Clasen <mclasen@redhat.com>
897 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
898 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
899 if they are mapped to the same modifier.
901 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
902 to gtkstatusicon.c and gtktrayicon-x11.c
904 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
905 default accel mod mask.
907 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
908 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
909 Don't use GDK_ALT_MASK.
911 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
913 2005-09-06 Matthias Clasen <mclasen@redhat.com>
915 Add support for extra virtual modifiers: (#85780, Owen Taylor)
917 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
920 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
921 Mod2 - Mod5 and against Super, Hyper, Meta.
923 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
924 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
925 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
927 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
928 modmap to maintain the information which X modifiers map to
930 (get_xkb): Set up the modmap from the XKB tables.
931 (update_keymaps): Set up the modmap from the information returned
932 by XGetModifierMapping in the non-XKB case.
934 * gdk/x11/gdkprivate-x11.h:
935 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
936 function to set the virtual modifiers in the state.
938 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
939 _gdk_keymap_add_virtual_modifiers here.
941 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
942 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
945 2005-09-05 Matthias Clasen <mclasen@redhat.com>
947 * gtk/gtkaction.c (connect_proxy): Set the label of a button
948 if it has no child. (#315253, John Finlay)
950 2005-09-02 Matthias Clasen <mclasen@redhat.com>
952 * gtkimcontextsimple.h: Add a modifiers_dropped bit
954 2005-09-02 Matthias Clasen <mclasen@redhat.com>
956 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
957 on destroy to avoid problems when they are called on a destroyed
958 widget. (#315135, John Cupitt)
960 * gtk/gtkentry.c (gtk_entry_class_init):
961 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
962 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
964 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
965 code. Now we only steal a single key combination, Ctrl-Shift-U,
967 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
968 by a sequence of hex digits entered with Ctrl-Shift still held.
969 Releasing one of the modifiers or pressing space while the modifiers
970 are still held commits the character. It is possible to erase
971 digits using backspace.
972 As an extension to the above, we also allow to start the sequence
973 with Ctrl-Shift-U, then release the modifiers before typing any
974 digits, and enter the digits without modifiers.
975 (#82011, Owen Taylor)
977 2005-09-02 Matthias Clasen <mclasen@redhat.com>
979 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
980 we still need to deliver the destroy event. (#314980, Chris Lahey)
982 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
983 im context before committing \n or \t.
985 2005-09-02 Alexander Larsson <alexl@redhat.com>
987 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
988 (shortcuts_activate_volume):
989 Handle base_path being null in the rest of the cases (#310270)
991 2005-09-02 Tor Lillqvist <tml@novell.com>
993 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
994 cursor position also in root window coordinates. Prune out
995 superfluous WM_MOUSEMOVE events even earlier, based on root window
996 coordinates. Windows sends WM_MOUSEMOVE messages after a new
997 window has ben mapped below the cursor even if the mouse doesn't
998 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
999 confused at least gtk_menu_motion_notify(). (#314995)
1001 * gtk/gtkintl.h: No need to include config.h here. It caused
1002 warnings about GTK_LOCALEDIR being redefined on Win32 when
1003 compiling files where gtkintl.h is included after gtkprivate.h
1004 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1006 * gtk/gtkplug.c: Include config.h.
1008 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1010 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1011 xdg_mime_get_mime_type_for_file() where possible, to avoid
1014 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1015 typo. (#314921, Guillaume Cottenceau)
1017 * gdk/*.c: Intern some more strings.
1019 * gtk/*.c: Define an I_() macro and use it instead of the
1020 bulky g_intern_static_string().
1022 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1024 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1025 instead of copying it.
1027 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1029 * gtk/*.c: Also intern static strings passed to
1030 g_object_set_data().
1033 * gtk/Makefile.am: Intern type names in code generated by
1038 * gdk/*.c: Intern type names before registering the type to avoid
1041 * configure.in: Require GLib 2.9.0
1043 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1045 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1046 and add icon-size and icon-size-set properties. (#314172)
1048 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1049 groups across transient parents. (#312918, Christian Persch)
1051 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1052 Guillaume Cottenceau)
1054 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1055 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1057 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1059 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1060 make C-/ select all and C-\ unselect all. (#309301,
1063 * gtk/gtkimcontextsimple.c: Change the compose sequence for
1064 soft hyphen to be multi_key-minus-minus-space, and add
1065 compose sequences multi_key-minus-minus-period and
1066 multi_key-minus-minus-minus for en dash and em dash.
1067 (#172653, Christian Lohmaier)
1069 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
1070 code. (#313946, Christian Persch)
1072 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
1073 fix for the default value of the "ui" property.
1075 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1078 * gtk/gtkselection.h:
1079 * gtk/gtkselection.c: Add functions which look for text, image
1080 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1083 * gtk/gtkselection.h:
1084 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1085 Add a function to check wether targets include uri.
1086 (#314092, Mark Wielaard)
1090 * gtk/gtkwindow.c: Add a deletable property with getter
1091 and setter, to control the close button in the window
1092 frame. (#59718, Havoc Pennington)
1094 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1096 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1097 to the arrow keys for menu navigation. (#162825, Carl Worth)
1099 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1101 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1103 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1104 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1105 refer to nonexisting stock ids.
1107 * gtk/gtktextview.c (popup_targets_received):
1108 * gtk/gtkentry.c (popup_targets_received): Construct
1109 the "Select All" menuitem from stock.
1111 * gtk/stock-icons/stock_select_all_{16,24}.png:
1112 * gtk/stock-icons/Makefile.am:
1113 * gtk/gtkiconfactory.c:
1115 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1118 * gtk/gtktrayicon.c: Add a pointer to the spec.
1120 * gtk/gtkstatusicon-x11.c: Add docs.
1122 * gtk/gtkstatusicon.h: Fix a typo.
1124 Add a cross-platform "tray icon" API, by
1125 porting EggStatusIcon/EggTrayIcon (#105101)
1127 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1128 displays an icon in a notification area.
1130 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1131 X11, using GtkTrayIcon.
1133 * gtk/gtktrayicon.h:
1134 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1135 system tray specification, not public API.
1137 * gtk/gtk.symbols: Add new exported functions.
1139 * gtk/gtk.h: Include gtkstatusicon.h.
1141 * gtk/Makefile.am: Add new files.
1143 * tests/Makefile.am:
1144 * tests/teststatusicon.c: Test for GtkStatusIcon.
1146 2005-08-29 Christopher Aillon <caillon@redhat.com>
1148 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1149 and GTK_STOCK_DISCONNECT
1151 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1153 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1154 Use XFixesChangeSaveSet if available. (#314682)
1156 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1157 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1159 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1161 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1162 accidentally leftover duplicate pixbuf creation. (#314700,
1165 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1166 leak the cursor theme name. (#314693, Kjartan Maraas)
1168 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1169 state.children in all cases. (#313862, Kjartan Maraas)
1171 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1173 * po/POTFILES.in, po-properties/POTFILES.in:
1176 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1178 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1179 value of the ui property. (#314532, Yong Wang)
1181 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1182 when G_MAXLONG is passed as length.
1184 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1186 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1187 to avoid overloading --force. (JP Rosevaar)
1189 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1191 * configure.in: Bump version to 2.9.0
1195 * gdk/gdkscreen.c: Make the GdkScreen font options api
1196 public, and add properties GdkScreen::font-options and
1197 GdkScreen::resolution. (#314004)
1200 * gtk/gtksettings.c:
1201 * gtk/gtkwidget.c: Adjust all callers.
1203 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1204 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1205 * gdk/gdkscreen.c: Include gdkintl.h.
1207 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1208 variable warning, pointed out by Colin Walters. (#314585)
1210 2005-08-26 Tor Lillqvist <tml@novell.com>
1212 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1214 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1216 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1218 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1219 of week_start. (#314473, JP Rosevaar)
1221 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1223 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1224 lock. (#314533, Thomas Fitzsimmons)
1226 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1228 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1229 NULL gracefully. (#314523, Ed Catmur)
1231 2005-08-25 Owen Taylor <otaylor@redhat.com>
1233 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1234 Handle theme == NULL.
1236 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1238 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1239 y offset into account when positioning the popup. (#314470,
1242 2005-08-25 Owen Taylor <otaylor@redhat.com>
1244 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1245 as instance_init, not base_init! (#314452, Fix from Frederic
1246 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1247 rather than 1 for a negative flag value.
1249 2005-08-24 Owen Taylor <otaylor@redhat.com>
1251 * gdk/gdkpango.c (draw_error_underline): Add a note about
1252 cut-and-paste between here and Pango.
1254 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1256 * === Released 2.8.2 ===
1258 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1259 callback for image/gif, and also try image/bmp. (#314086, Mark
1262 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1263 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1268 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1269 and cursor settings get propagated down to the screen initially.
1270 Pointed out by Frederic Crozat.
1272 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1273 message if the screen is NULL. Noticed by Kjartan Maraas.
1275 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1279 * === Released 2.8.1 ===
1283 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1285 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1286 against lazy filterers which return values other than TRUE or
1287 FALSE from their visible func. (#314335)
1289 2005-08-23 Owen Taylor <otaylor@redhat.com>
1291 Fix for #314004, reported by Michael Reinsch:
1294 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1295 Add gdk_screen_get/set_resolution_libgtk_only()
1297 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1298 the options for the screen on the newly created context.
1300 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1301 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1302 the font options on the screen.
1304 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1305 the font options from the screen and set them on the context.
1307 2005-08-23 Kristian Rietveld <kris@gtk.org>
1309 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1310 bother inserting new rows in a level with a zero refcount and
1311 immediately free the level. (Fixes #312350, reported by Markku Vire).
1313 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1315 * gtk/updateiconcache.c: Complain when there is no index.theme file
1316 in the specified directory, unless --force is used. Also add an
1317 --index-only option to create caches without image data.
1319 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1320 C99ism. (#314262, Robert Jeff Mitchell)
1322 2005-08-22 Manish Singh <yosh@gimp.org>
1324 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1326 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1328 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1330 * gtk/gtkwindow.c (gtk_window_client_event):
1331 * gtk/gtkicontheme.c (ensure_valid_themes)
1332 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1333 scheme for makeing sure that all GTK+ applications notice if an
1334 icon theme has been updated. This should prevent multiple versions
1335 of an icon theme cache to be mapped in memory at the same time,
1336 which can cause excessive memory consumption. (#313156, Chris
1339 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1341 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1342 regarding icon theme changes.
1344 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1345 pixbufs which are backed by the mmapped memory of an icon cache,
1346 increase the refcount of the icon cache, so that the memory is not
1347 munmapped away underneath the pixbuf upon icon theme changes.
1348 (#314170, Kjartan Maraas)
1350 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1351 to link against Xext. (#314062)
1353 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1354 overruns. (#314081, Hans Breuer)
1356 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1358 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1359 returned layout must not be modified.
1361 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1363 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1364 scroll_to_path if the model changes.
1366 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1367 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1368 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1369 we're realized, #312798
1370 (gtk_icon_view_set_model): clear scroll_to_path if the model
1373 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1375 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1376 (gtk_range_adjustment_value_changed): Don't queue a draw
1377 if the layout has not changed. (#313991, Benjamin Berg)
1379 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1381 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1384 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1387 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1388 (model_add_special, model_add_special, model_add_volumes):
1389 Handle pixbuf being NULL without warnings. Also, don't
1390 leak pixbuf references when the icon theme is changed.
1392 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1393 the user data on destroyed windows, since at best
1394 it can be a stale pointer. (#313953, Robin Green)
1396 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1398 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1399 (#313900, Sebastien Bacher)
1401 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1402 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1404 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1405 (xdnd_read_actions, get_client_window_at_coords_recurse):
1406 Free data returned from XGetWindowProperty.
1408 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1409 Free data returned from XGetWindowProperty. (313867, Kjartan
1412 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1413 children in all cases. (#313862, Kjartan Maraas)
1415 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1416 in the per-directory hash, even if they come from the icon cache.
1417 We tried to avoid that before, but as a result leaked icon data
1418 structs. (#313852, Kjartan Maraas)
1420 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1422 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1423 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1425 2005-08-15 Owen Taylor <otaylor@redhat.com>
1427 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1428 files for x11/xext. (Jonas Bonn)
1430 2005-08-15 Tor Lillqvist <tml@novell.com>
1432 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1435 2005-08-15 Owen Taylor <otaylor@redhat.com>
1437 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1439 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1440 (#313417, James Andrewartha)
1442 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1443 FcNameConstant(). (More of #313417)
1445 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1447 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1448 modal dialogs, make sure to inherit the window group from
1449 the parent, since we don't inherit window groups across
1450 transient parents currently. (#312918, Christian Persch)
1452 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1453 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1455 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1456 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1457 gracefully. (#312796, Jonathan Blandford)
1459 * tests/testtoolbar.c: Add some more tests for menu placement.
1461 * gtk/gtkmenutoolbutton.c (menu_position_func):
1462 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1463 of toolbutton menus and of the overflow menu. (#312937,
1464 #153870, Christian Persch, Paolo Borelli)
1466 2005-08-15 Tor Lillqvist <tml@novell.com>
1468 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1469 the nonportable <libgen.h> and dirname().
1471 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1473 * gtk/gtksizegroup.c: Use object data to mark widgets and
1474 groups as visited, so that we avoid constant extra list
1475 traversals. Also allocate quarks in class_init. (#311618,
1478 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1479 download location for the hicolor icon theme. (#313475, Olexiy
1482 * gtk/gtkicontheme.c: Remove debug spew.
1484 2005-08-15 Owen Taylor <otaylor@redhat.com>
1486 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1487 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1488 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1489 Handle pixmap == NULL when checking for a colormap.
1492 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1494 * gtk/updateiconcache.c: Store only one copy of the pixel data
1495 for symlinked icons. To achieve this, maintain a hashtable
1496 mapping pathnames to pixel data, and share the pixel data for
1497 all symlinks resolving to the same pathname. When writing out
1498 the image data, write out the pixel data only the first time
1499 it is met, and store the offset pointing to the first copy
1500 for use in all later cases.
1501 This reduces the size of the Bluecurve icon cache from 40