1 Wed Aug 18 17:25:26 2004 Manish Singh <yosh@gimp.org>
3 * demos/testpixbuf-save.c
4 * demos/gtk-demo/hypertext.c: Get rid of some unnecessary casts.
6 * demos/gtk-demo/appwindow.c: Make activate_email and activate_url
7 match the arguments for GtkAboutDialogActivateLinkFunc.
9 Wed Aug 18 16:18:00 2004 Manish Singh <yosh@gimp.org>
11 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): Initialize height
12 from fixed_height before we do anything, so it always has a valid
15 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Fix call
16 to gtk_tree_model_get (missing "," in param list).
18 2004-08-18 Federico Mena Quintero <federico@ximian.com>
24 * gtk/gtkfilechooserdefault.c: Renamed SHORTCUTS_COL_PATH to
25 SHORTCUTS_COL_DATA. Add SHORTCUTS_COL_IS_VOLUME, to determine
26 easily whether the SHORTCUTS_COL_DATA points to a GtkFilePath or a
28 (shortcuts_model_create): Create a boolean column for
29 SHORTCUTS_COL_IS_VOLUME.
30 (shortcuts_reload_icons): Simplify with the use of the
31 SHORTCUTS_COL_IS_VOLUME column. Don't leak the pixbuf.
32 (shortcuts_insert_path): Add the SHORTCUTS_COL_IS_VOLUME data.
33 (shortcuts_free_row_data): New helper function; frees the data
35 (shortcuts_remove_rows): Don't take a callback for freeing the
36 data; free everything here instead. Use
37 shortcuts_free_row_data().
38 (volume_remove_cb): Removed.
39 (remove_bookmark_cb): Removed.
40 (remove_row_cb): Make this a single generic function to delete
42 (shortcuts_add_volumes): Use remove_row_cb().
43 (shortcuts_add_bookmarks): Likewise.
44 (struct _GtkFileChooserDefault): Removed the
45 shortcuts_current_folder_is_volume field.
46 (shortcuts_add_current_folder): Oops, don't free the volume.
47 (remove_current_folder_cb): Removed.
48 (shortcut_find_position): Simplify through the use of the
49 SHORTCUTS_COL_IS_VOLUME column.
50 (remove_selected_bookmarks): Assert that we don't get a volume.
51 (shortcuts_reorder): Likewise; also, plug a leak.
52 (gtk_file_chooser_default_remove_shortcut_folder): Simplify
53 through the use of shortcuts_remove_rows().
54 (gtk_file_chooser_default_list_shortcut_folders): Assert that we
56 (shortcuts_activate_iter): Simplify.
57 (home_folder_handler): Simplify by using
58 shortcuts_activate_iter().
59 (shortcuts_free): New function; frees all the data columns.
60 (gtk_file_chooser_default_finalize): Unref the
61 shortcuts_filter_model and the shortcuts model data first.
63 Wed Aug 18 08:31:17 2004 Manish Singh <yosh@gimp.org>
65 * gtk/gtkiconview.c: Applied patch from Olivier Andrieu to fix
68 * gtk/gtkicontheme.c (gtk_icon_theme_init): xdg_data_dirs should
69 match constness attributes of g_get_system_data_dirs ().
71 2004-08-17 Matthias Clasen <mclasen@redhat.com>
73 * gtk/gtkicontheme.c (gtk_icon_theme_init): Look up icon themes in the
74 directories specified in the icon theme spec: $HOME/.icons,
75 $XDG_DATA_DIRS/icons, /usr/share/pixmaps. Note that GTK+ used to also look
76 in $GTK_DATA_DIR/icons, $GTK_DATA_DIR/pixmaps and /usr/share/icons. (#148694)
79 * gtk/gtkframe.c (gtk_frame_paint): Take widget->state into account when
80 painting the shadows. (#150351, Tim Janik)
82 2004-08-17 Matthias Clasen <mclasen@redhat.com>
84 * gtk/abicheck.sh: No need for INCLUDE_INTERNAL_SYMBOLS anymore.
86 * gdk/gdk.symbols: Don't use #if defined().
88 * gdk/Makefile.am (gdkalias.h):
89 * gtk/Makefile.am (gtkalias.h): Don't use cpp to filter gtk.symbols.
91 * gdk/makegdkalias.pl:
92 * gtk/makegtkalias.pl: Move the #ifdef processing into the perl script, and
93 keep the #ifdefs which differentiate between platforms.
95 * gtk/Makefile.am (gtk_private_h_sources): Remove gtkinternals.h, it is no
98 2004-08-17 Matthias Clasen <mclasen@redhat.com>
100 * tests/testfilechooserbutton.c: Use g_message() throughout, add RTL envar for
103 * gtk/gtkfilechooserbutton.c: Get rid of HAVE_CONFIG_H.
104 (gtk_file_chooser_button_init): Use gtk_drag_dest_add_text_targets().
105 (gtk_file_chooser_button_drag_data_received): Use gtk_selection_data_get_text().
106 (gtk_file_chooser_button_set_dialog): _gtk_file_chooser_entry_set_base_folder()
107 seems to expect a path, not an uri.
108 (update_dialog): Handle g_filename_from_uri() returning NULL, don't free
111 * gtk/gtkfilechooserbutton.h: Minor stylistic changes.
113 2004-08-17 Matthias Clasen <mclasen@redhat.com>
115 * gtk/gtkfilechooserbutton.[hc]: New widget to go along with
116 GtkFontButton and GtkColorButton for use in preference dialogs.
117 Replaces GnomeFileEntry. (#148108, James M. Cape)
119 * gtk/gtk.h: Include gtkfilechooserbutton.h
121 * gtk/Makefile.am (gtk_public_h_sources): Add gtkfilechooserbutton.h
122 (gtk_c_sources): Add gtkfilechooserbutton.c
124 * gtk/gtk.symbols: Add the GtkFileChooserButton symbols.
126 * gtk/gtkfilechooserutils.[hc]: Make the delegate quark available.
128 * gtk/gtkfilechooserentry.[hc] (_gtk_file_chooser_entry_new): Allow
129 to suppress tab-eating using the new eat_tabs argument. Adjust all
132 * tests/testfilechooserbutton.c: Test for GtkFileChooserButton.
134 * tests/Makefile.am (noinst_PROGRAMS): Add testfilechooserbutton
136 2004-08-16 Matthias Clasen <mclasen@redhat.com>
138 * gtk/gtkwidget.c (gtk_widget_render_icon): Doc update.
140 * gtk/gtkiconfactory.c (render_icon_name_pixbuf): When the size is -1,
141 use the available size closest to 48. (#150147)
143 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): Actually return
144 a pointer to the beginning of the sizes array, not the end.
146 2004-08-16 Morten Welinder <terra@gnome.org>
148 * tests/testtreemodel.c (test_run): Comment out mallinfo stuff.
149 Fix g_print %-strings.
151 * gtk/gtksequence.c (_gtk_sequence_set): Fix C99ism.
153 2004-08-16 Christian Rose <menthos@menthos.com>
155 * configure.in: Added "bs" to ALL_LINGUAS.
157 Mon Aug 16 01:35:25 2004 Matthias Clasen <maclas@gmx.de>
160 * gtk/gtkcombobox.[hc]: Add a ::focus-on-click property and
161 change the default behaviour to focus on click.
163 * gtk/gtkbutton.c (gtk_button_set_focus_on_click): Typo fix.
165 Mon Aug 16 01:03:08 2004 Matthias Clasen <maclas@gmx.de>
167 * gtk/gtktextiter.c (gtk_text_iter_set_visible_line_offset):
168 (gtk_text_iter_set_visible_line_index): Count from the
169 beginning of the line, not from the current position. (#150101,
172 2004-08-15 Tor Lillqvist <tml@iki.fi>
174 * gtk-zip.sh.in: Fix typo. The gtk.immodules file had never been
175 included in my zipfiles...!
177 * gtk/gtkfilesystemwin32.c (extract_icon): Improve handling of
178 icon alpha channel (on Windows XP) and mask (older Windows
179 versions). (#148641, Tim Evans)
181 Sun Aug 15 02:31:55 2004 Matthias Clasen <maclas@gmx.de>
183 * gtk/gtkfilesystemunix.c (get_icon_type_from_stat): Make
184 the use of S_ISFIFO and S_ISSOCK conditional. (#150146,
187 2004-08-14 Tor Lillqvist <tml@iki.fi>
189 * gtk/gtkfilechooserdefault.c (shortcuts_append_home,
190 shortcuts_append_desktop, set_local_only)
191 * gtk/gtkfilesystemwin32.c (gtk_file_system_win32_render_icon)
192 * gtk/gtkpathbar.c (find_button_type, _gtk_path_bar_set_file_system):
193 Guard against g_get_home_dir() returning NULL. (#150007)
195 Sat Aug 14 17:56:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
197 * gtk/gtkentry.c (gtk_entry_get_pixel_ranges): New function.
199 * gtk/gtkentry.c (in_selection): New function using
200 gtk_entry_get_pixel_ranges() to determine whether a click is in
201 the selection. Improve entry behavior wrt. dragging and
202 selecting. Bug #143249.
204 Sat Aug 14 17:53:46 2004 Soeren Sandmann <sandmann@daimi.au.dk>
206 * configure.in: Require glib 2.5.2
208 * gtk/gtksequence.[ch]: New internal data structure.
210 * gtk/gtkliststore.[hc]: Reimplement in terms of new data
213 * tests/Makefile.am (testtreemodel_SOURCES):
214 * tests/testtreemodel.c: New test program written by Matthias.
216 2004-08-13 Matthias Clasen <mclasen@redhat.com>
218 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_style_set):
219 Don't install the settings_notify_cb from here, since it
220 may be called before the first screen_changed signal,
221 confusing the logic in gtk_file_chooser_screen_changed().
222 (#148803, Abel Daniel)
224 * gtk/gtkcombobox.c: Make re-sensitivation work
227 * gtk/gtkaction.c (gtk_action_new): Fix the docs.
229 Fri Aug 13 01:06:56 2004 Matthias Clasen <maclas@gmx.de>
231 * gtk/gtktreeview.c (gtk_tree_view_row_inserted):
232 Make fixed height mode handle insertions. (#135955,
233 Michael Vogt, testcase by Tim-Philipp Müller, fix by
236 Fri Aug 13 00:40:18 2004 Matthias Clasen <maclas@gmx.de>
238 * gtk/gtkhandlebox.c: Add missing include.
240 Thu Aug 12 23:52:12 2004 Matthias Clasen <maclas@gmx.de>
242 Fix #149547, Markus Lausser:
244 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate):
245 * gtk/gtkcombobox.c (gtk_combo_box_size_request): Don't
246 crash if size_request or size_allocate are called early.
248 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate): Protect
249 against being allocated too small.
251 Thu Aug 12 21:02:57 2004 Matthias Clasen <maclas@gmx.de>
253 * demos/gtk-demo/appwindow.c (about_cb): Adjust to GtkAboutDialog
256 * gtk/gtkaboutdialog.h:
257 * gtk/gtkaboutdialog.c (gtk_about_dialog_set_email_hook):
258 (gtk_about_dialog_set_url_hook): Add callback data and destroy notify
259 for language bindings. (#149999, Olivier Andrieu)
261 2004-08-12 Matthias Clasen <mclasen@redhat.com>
263 * gtk/gtkfilesystem.c: Underscore-prefix gtk_file_system_module_get_type().
264 * gtk/gtkfilechooserdefault.c: Underscore-prefix shortcuts_model_filter_get_type().
266 * gtk/gtkimmodule.c: Make gtk_im_module_get_type() static.
268 * gtk/gtkinternals.h: Remove the no longer exported get_type functions.
270 Thu Aug 12 01:35:46 2004 Matthias Clasen <maclas@gmx.de>
272 * gtk/gtkiconview.c: Make the icon view accessible by
273 implementing the necesssary ATK interfaces. (#149728,
276 Thu Aug 12 00:02:29 2004 Matthias Clasen <maclas@gmx.de
278 * gtk/gtkaction.c (gtk_action_new): Link to information about
279 allowed action names. (#149620, David Malcolm)
281 Wed Aug 11 23:14:25 2004 Matthias Clasen <maclas@gmx.de>
285 * gtk/gtkaction.c (gtk_action_set_sensitive):
286 (gtk_action_set_visible): Add setters for the ::sensitive
287 and ::visible properties of GtkAction. (#149622, David Malcolm)
289 2004-08-11 Federico Mena Quintero <federico@ximian.com>
291 Fix #149422, #143457:
293 * gtk/gtkfilechooserdefault.c
294 (gtk_file_chooser_default_should_respond): Rewrite to take the
295 current focus into account, the contents of the save entry, and
296 the last focus for the shortcuts list.
297 (switch_to_selected_folder): We don't need an assertion on the
300 Wed Aug 11 20:56:00 2004 Matthias Clasen <maclas@gmx.de>
302 * gtk/gtkinternals.h:
303 * gtk/gtk.symbols: Add shortcuts_model_filter_get_type.
305 * gtk/abicheck.sh: Check all symbols.
307 Wed Aug 11 19:20:34 2004 Matthias Clasen <maclas@gmx.de>
309 * gtk/gtktreeview.c (gtk_tree_view_maybe_begin_dragging_row):
310 Don't start a drag if the treeview is only a
311 drag destination. (#149836, Pawel Salek)
313 2004-08-11 Matthias Clasen <mclasen@redhat.com>
315 * gtk/gtktreedatalist.[hc]:
316 * gtk/gtkliststore.c:
317 * gtk/gtktreestore.c: Underscore-prefix
318 gtk_tree_data_list_compare_func.
320 * gtk/gtk.symbols: Remove gtk_tree_data_list_compare_func.
322 * gtk/makegtkalias.pl: No need to include gtktreedatalist.h
325 2004-08-10 Matthias Clasen <mclasen@redhat.com>
328 * gtk/Makefile.am: Define TESTS, not TEST, so that make check
329 actually triggers abicheck.sh.
331 * gdk/makegdkalias.pl:
332 * gtk/makegtkalias.pl: Include glib.h before using glib symbols. D'oh.
334 * gdk/makegdkalias.pl:
335 * gtk/makegtkalias.pl: Protect gtkalias.h by G_HAVE_GNUC_VISIBILITY.
337 * gtk/Makefile.am: Include gtkalias.h in the generated
338 sources gtkmarhalers.c and gtkmarshal.c.
340 * gtk/makegtkalias.pl: Cosmetic fix.
342 * gdk/Makefile.am: Remove the . which was accidentally added
343 to SUBDIRS. Include gdkalias.h in the generated sources
344 gdkenumtypes.c and gdkmarshalers.c.
346 * gdk/makegdkalias.pl: Cosmetic fix.
348 * gdk/Makefile.am: Add gdkalias.h to BUILT_SOURCES.
350 2004-08-09 Hans Breuer <hans@breuer.org>
352 * gtk/makefile.msc.in : autogenerate gtk.def, cleanup
354 * gdk/win32/gdkwindow-win32.c gdk/win32/gdkevents-win32.c :
355 removed long time unused ifdef/ed code (WITHOUT_WM_CREATE),
356 removed duplicated call to gdk_window_set_cursor()
358 Mon Aug 9 15:41:17 2004 Matthias Clasen <maclas@gmx.de>
360 Add hidden aliases for exported symbols which are
361 used internally in order to get rid of many PLT
362 entries. (#145519, Arjan van de Ven)
364 * gdk/Makefile.am: Add rules to generate gdk.def and
365 gdkalias.h from gdk.symbols, and make make check check
366 the abi with abicheck.sh.
368 * gdk/gdk.symbols: New file. Definition of the GDK ABI.
369 The file can be processed by cpp to filter out certain
372 * gdk/abicheck.sh: New file. Script to check the actually
373 symbols exported from libgdk-x11.2.0.so against the symbols
374 found in gdk.symbols.
376 * gdk/makegdkalias.pl: New file. Perl script to generate the
377 header containing the alias definitions for internally used
378 exported symbols from a list of symbols.
380 * gdk/*.c, gdk/x11/*.c: Include gdkalias.h
382 2004-08-09 Morten Welinder <terra@gnome.org>
384 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): Fix C99ism.
386 Mon Aug 9 15:27:01 2004 Matthias Clasen <maclas@gmx.de>
388 * gtk/makegtkalias.pl: Also revert
389 GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API to its old status.
391 Mon Aug 9 15:19:34 2004 Matthias Clasen <maclas@gmx.de>
394 * gdk/gdkrgb.h: Add the exported functions
395 gdk_rgb_colormap_ditherable(), gdk_pointer_grab_info_libgtk_only(),
396 gdk_keyboard_grab_info_libgtk_only() to the appropriate
399 Mon Aug 9 14:24:46 2004 Matthias Clasen <maclas@gmx.de>
401 * gdk/x11/gdkevents-x11.c (gdk_event_send_client_message_to_all_recurse):
404 Mon Aug 9 12:48:04 2004 Matthias Clasen <maclas@gmx.de>
406 Add hidden aliases for exported symbols which are
407 used internally in order to get rid of many PLT
408 entries. (#145519, Arjan van de Ven)
410 * gtk/Makefile.am: Add rules to generate gtk.def and
411 gtkalias.h from gtk.symbols, and make make check check
412 the abi with abicheck.sh.
413 (gtk_private_h_sources): Add gtkinternals.h
414 (gtk_built_private_headers): Add gtkalias.h
415 (gtk_extra_sources): Add gtk.symbols
416 (EXTRA_DIST): Add makegtkalias.pl and abicheck.sh
418 * gtk/gtk.symbols: New file. Definition of the GTK+ ABI.
419 The file can be processed by cpp to filter out certain
422 * gtk/abicheck.sh: New file. Script to check the actually
423 symbols exported from libgtk-x11.2.0.so against the symbols
424 found in gtk.symbols.
426 * gtk/makegtkalias.pl: New file. Perl script to generate the
427 header containing the alias definitions for internally used
428 exported symbols from a list of symbols.
430 * gtk/gtkinternals.h: New file. An uninstalled header listing
431 symbols which must be exported for some reason and do not appear
434 * gtk/*.c: Include gtkalias.h
436 Mon Aug 9 11:49:46 2004 Matthias Clasen <maclas@gmx.de>
438 * gtk/gtkmain.c: Only undef gtk_init_check and gtk_init on win32.
440 Mon Aug 9 10:50:05 2004 Matthias Clasen <maclas@gmx.de>
442 * gtk/gtkentry.h: Add gtk_entry_layout_index_to_text_index()
443 and its inverse. The have always been exported and are meant
446 Mon Aug 9 00:28:34 2004 Matthias Clasen <maclas@gmx.de>
448 * gtk/gtkicontheme.c (load_svg_at_size): Don't leak the
451 Mon Aug 9 00:13:03 2004 Matthias Clasen <maclas@gmx.de>
453 * gtk/gtkaboutdialog.c (icon_set_new_from_pixbufs): Don't
454 leak the icon source.
456 Sun Aug 8 23:46:20 2004 Matthias Clasen <maclas@gmx.de>
458 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Don't
459 leak a reference to the pixbufs.
461 Sun Aug 8 23:36:55 2004 Matthias Clasen <maclas@gmx.de>
463 * gtk/gtkcombobox.c (gtk_combo_box_menu_setup): Ref
465 (gtk_combo_box_menu_destroy): Unref the column.
467 Sun Aug 8 23:35:00 2004 Matthias Clasen <maclas@gmx.de>
469 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets):
470 (gtk_drag_dest_add_text_targets): Don't leak a reference
473 Sun Aug 8 22:52:26 2004 Matthias Clasen <maclas@gmx.de>
475 * gtk/gtkcombobox.c (find_menu_by_path): Don't stumble over
476 separators which are not backed by model rows.
478 Sun Aug 8 11:01:23 2004 Matthias Clasen <maclas@gmx.de>
480 * gtk/gtkcombobox.c (gtk_combo_box_set_active): Don't leak
483 2004-08-08 Hans Breuer <hans@breuer.org>
485 * gtk/gtkdnd.c (gtk_drag_dest_set) : take targets into
486 account again to allow dnd of other things than text
488 * gdk/win32/gdkselection-win32.c : offer windows bitmap to
489 be pasted from clipboard (makes The GIMP 2.1's
490 "File/Acquire/Paste as New" work, only using gtk+ API)
492 Sun Aug 8 01:32:36 2004 Matthias Clasen <maclas@gmx.de>
494 * gtk/gtk.def: Add gtk_cell_renderer_progress_get_type.
496 Sun Aug 8 01:29:08 2004 Matthias Clasen <maclas@gmx.de>
498 * gtk/gtk.def: Replace duplicate gtk_tree_view_get_hover_expand
499 by gtk_tree_view_set_hover_expand.
501 Sun Aug 8 01:23:08 2004 Matthias Clasen <maclas@gmx.de>
503 * gtk/gtk.def: Remove the static function gtk_menu_get_private.
505 2004-08-07 Tor Lillqvist <tml@iki.fi>
507 * gdk/win32/gdkkeys-win32.c (update_keymap): Don't hardcode
508 mapping of VK_DECIMAL to GDK_KP_Decimal. Instead, let ToAsciiEx()
509 map it to what's printed on the keypad decimal key for the current
510 input locale (keyboard layout). (#149404)
512 Sat Aug 7 18:19:03 2004 Matthias Clasen <maclas@gmx.de>
514 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
515 (shortcuts_list_create): Use GtkTreeViewRowSeparatorFunc
516 instead of GtkCellRendererSepText. (#147864)
518 * gtk/gtkcellrendererseptext.[hc]: Removed.
520 * gtk/Makefile.am: Remove gtkcellrendererseptext.[hc]
522 Sat Aug 7 18:15:15 2004 Matthias Clasen <maclas@gmx.de>
524 * gtk/gtkcombobox.c (gtk_combo_box_menu_row_deleted):
525 (gtk_combo_box_menu_row_inserted):
526 (gtk_combo_box_menu_row_changed): Correctly handle
527 insertion and deletion of separators in menu mode.
529 2004-08-07 Tor Lillqvist <tml@iki.fi>
531 * gdk/win32/gdkevents-win32.c (handle_configure_event,
532 gdk_event_translate:WM_WINDOWPOSCHANGED): Add _gdk_offset_{x,y} to
533 top-level window coordinates, not just in generated
534 events. (#148526, Robert Ögren)
536 Sat Aug 7 01:26:08 2004 Matthias Clasen <maclas@gmx.de>
538 Make the column drag code a bit more robust (still scary,
539 though). (#106992, Christian Biere)
541 * gtk/gtktreeview.c (_gtk_tree_view_column_start_drag): Assert
542 that cur_reorder is NULL here.
544 * gtk/gtktreeview.c (gtk_tree_view_button_release_drag_column):
545 Reset cur_reorder to NULL, and only hide drag_highlight_window
548 2004-08-06 Federico Mena Quintero <federico@ximian.com>
552 * gtk/gtkfilechooserdefault.c (save_widgets_create): Use a
553 GtkFileChooserEntry for the file name, rather than a GtkEntry.
554 (update_chooser_entry): Set the contents of the file chooser entry
555 rather than the plain entry's.
556 (gtk_file_chooser_default_set_current_folder): Set the new folder
558 (gtk_file_chooser_default_set_current_name): Set the name on the
560 (check_save_entry): Use the file chooser entry rather than the
563 * gtk/gtkfilechooserentry.c
564 (_gtk_file_chooser_entry_set_base_folder): Call
565 gtk_file_chooser_entry_changed() so that we recompute the current
566 folder based on the new base folder.
568 2004-08-06 Hans Breuer <hans@breuer.org>
570 * gdk/win32/gdkwindow-win32.c : make it compile and more
571 similar to the X11 implementation [backward compatibility
572 for GDK_WINDOW_TEMP, GDK_INPUT_ONLY (fixes bug #148702),
573 use the *screen* function variants, dont reparent already
575 (get_visible_region) : take the win32 part into account
576 (_gdk_windowing_window_destroy) : remove from handle table
578 * gdk/win32/gdkdisplay-win32.c : added
579 gdk_display_(request|supports)_selection_notification ()
580 with a currently mostly pointless implementation ;-)
582 * gtk/gtkfilesystemwin32.c (*_to_path) : same changes as on *NIX,
584 (gtk_file_system_win32_render_icon) : use new GTK_STOCK_DIRECTORY
586 * gtk/makefile.msc.in demos/gtk-demo/makefile.msc.in
587 gtk/stock-icons/makefile.msc tests/makefile.msc : updated
589 * gdk/gdk.def gtk/gtk.def : updated externals
591 * tests/testiconview.c : remove unneeded dirent.h inclusion
593 2004-08-06 Matthias Clasen <mclasen@redhat.com>
595 * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): Fix
596 an off-by-one error. (#141809, Markku Vire)
598 * gtk/gtkdnd.c (gtk_drag_dest_set, gtk_drag_source_set): Really
599 fix the initialization of the target list.
601 Support XDND v5. (#10220, Owen Taylor)
603 * gdk/x11/gdkdnd-x11.c: Record the XDND version and whether the
604 drop was successful in the GdkDragContextPrivateX11 struct.
605 (xdnd_finished_filter): Store the success status of the drop
606 for an XDND version 5 interaction. For other versions, always
607 assume the drop was successful.
608 (xdnd_check_dest): Return the protocol version.
609 (_gdk_drag_get_protocol_for_display): Return the protocol version.
610 (gdk_drag_find_window_for_screen): Store the used protocol version
611 in the GdkDragContext.
612 (xdnd_send_enter): Send the used protocol version from the context,
613 instead of hardwiring 3.
614 (xdnd_enter_filter): Accept protocol versions >= 3 and store the
615 used protocol version in the context.
618 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): New function
619 to find out whether a drop was successful.
621 2004-07-28 Robert Ögren <gtk@roboros.com>
623 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Set x_root
624 and y_root in button and motion events from the tablet. (#148715)
626 Thu Aug 5 19:58:08 2004 Soeren Sandmann <sandmann@daimi.au.dk>
628 * gtk/gtkplug.c (gtk_plug_realize): Call
629 gdk_window_enable_synchronized_configure()
631 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): Make
632 noop if gdk_window_enable_synchronized_configure() has not been
635 2004-08-04 Matthias Clasen <mclasen@redhat.com>
637 * gtk/gtkfilechooser.[hc]: Add setter and getter for the
638 ::show-hidden property. (#145610, Jeff Franks)
640 * tests/testiconview.c: Add buttons to select and unselect all
641 nodes, make the popup menu actually work.
643 * gtk/gtkiconview.c: Make GTK_SELECTION_BROWSE work as intended,
644 let button 3 presses through to the app, to make popup menus
647 * tests/Makefile.am: Add testiconview.
648 * tests/testiconview.c: A test for GtkIconView
649 * tests/gnome-textfile.png: ...which uses this image.
651 Wed Aug 4 01:37:57 2004 Matthias Clasen <maclas@gmx.de>
654 * gtk/gtktreestore.c:
655 * gtk/gtktreemodelfilter.c:
656 * gtk/gtknotebook.c: s/childs/children/g.
658 Wed Aug 4 01:04:48 2004 Matthias Clasen <maclas@gmx.de>
660 Fix #133446, noticed by Christian Persch:
662 * gtk/gtkaction.c (gtk_action_class_init): Add a new boolean
663 property ::visible-overflown.
664 * gtk/gtkaction.c (gtk_action_create_menu_proxy): Don't create
665 a menu proxy if visible_overflown is FALSE.
667 Tue Aug 3 20:16:26 2004 Matthias Clasen <maclas@gmx.de>
669 * gtk/gtkactiongroup.[hc]: Make the the GtkAction{Toggle,Radio,}Entry*
670 arguments to the gtk_action_group_add_..._actions() functions const,
671 since the most common use case is to use a static array. (142334,
672 Mariano Suarez-Alvarez)
674 Tue Aug 3 20:03:33 2004 Matthias Clasen <maclas@gmx.de>
676 * gtk/gtkuimanager.c (get_node): Make gtk_ui_manager_add_ui()
677 accept paths with a leading "/ui". (#149077, David Malcolm)
679 Tue Aug 3 19:59:29 2004 Matthias Clasen <maclas@gmx.de>
681 * gtk/gtkiconview.c: Fix some warnings.
683 Tue Aug 3 18:38:40 2004 Matthias Clasen <maclas@gmx.de>
685 * gtk/gtktreemodelfilter.c: Correct the return type
686 of gtk_tree_model_filter_get_flags(). (#149195, Morten Welinder)
688 Tue Aug 3 18:16:55 2004 Matthias Clasen <maclas@gmx.de>
690 Fix #149191, reported by Morten Welinder:
692 * gtk/gtkmain.c: Include gtkclipboard.h,
693 * gtk/gtkwidget.h: Declare _gtk_widget_grab_notify, not
694 _gtk_widget_emit_grab_notify.
696 Tue Aug 3 14:50:14 2004 Matthias Clasen <maclas@gmx.de>
698 * gtk/gtkicontheme.c (add_size): Add missing parens.
699 (#149190, Morten Welinder)
701 Tue Aug 3 14:29:49 2004 Matthias Clasen <maclas@gmx.de>
703 * gtk/gtkcombobox.c (gtk_combo_box_menu_fill): Remove
704 accidentally committed debug code.
706 Tue Aug 3 01:19:12 2004 Matthias Clasen <maclas@gmx.de>
708 * gtk/gtkcombobox.c (gtk_combo_box_relayout_item): Optimize
709 for the case that row_column and col_column are unset.
710 (#148868, Lorenzo Gil Sánchez)
712 Mon Aug 2 21:52:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
714 * gdk/x11/gdkwindow-x11.c (ensure_sync_counter): New
715 function. Make sure the sync counter is recreated when a window is
716 reparented to become a toplevel. (#148358)
718 2004-08-02 Matthias Clasen <mclasen@redhat.com>
720 * tests/testcombo.c: Some trees in combo boxes.
722 * gtk/gtkcombobox.c: Rework the combo box to handle
723 tree models. (#139582, Matt Walton)
727 * gtk/gtktreeprivate.h: Add a new boolean property
728 ::hover-expand and make the treeview expand/collapse rows
729 on mouseover if it is set.
731 * gtk/gtkiconview.h: Remove some erroneous declarations.
733 * gtk/gtkcellview.c (gtk_cell_view_set_cell_data): Don't
734 crash if the displayed row is gone.
736 2004-08-02 Morten Welinder <terra@gnome.org>
738 * gtk/gtkentry.c (gtk_entry_motion_notify): C99ism.
740 Mon Aug 2 01:30:03 2004 Matthias Clasen <maclas@gmx.de>
742 * gtk/gtktextview.[hc]:
743 * gtk/gtkentry.[hc]: Add a new binding signal ::backspace,
744 bind it to the backspace key, and make it pay attention
745 to the Pango backspace_deletes_character
746 attribute. (#119891, Noah Levitt, patch by Theppitak
749 Mon Aug 2 01:02:57 2004 Matthias Clasen <maclas@gmx.de>
751 * gdk/x11/gdkevents-x11.c (gdk_check_wm_state_changed):
752 (gdk_check_wm_desktop_changed): Add missing error
753 traps. (#149011, Thomas Leonard)
755 Mon Aug 2 00:21:26 2004 Matthias Clasen <maclas@gmx.de>
757 * gtk/gtktextview.c (blink_cb): Add the same warning
758 that the blink_cb() in GtkEntry already has. (#148733)
760 Mon Aug 2 00:12:16 2004 Matthias Clasen <maclas@gmx.de>
762 * gtk/gtkentry.c (gtk_entry_class_init):
763 (gtk_entry_get_alignment):
764 (gtk_entry_set_alignment): Document the xalign property
765 and its getter and setter as 2.4 additions. (#148978,
768 Mon Aug 2 00:11:31 2004 Matthias Clasen <maclas@gmx.de>
770 * gtk/gtkuimanager.c (gtk_ui_manager_class_init):
771 * gtk/gtkactiongroup.c (gtk_action_group_class_init): Use
772 canonical signal names in doc comments, since gtk-doc won't
773 pick up signal docs with underscores.
775 2004-08-01 Matthias Clasen <mclasen@redhat.com>
777 * configure.in: Post-release version bump
779 * === Released 2.5.1 ===
781 Thu Jul 29 16:36:42 2004 Jonathan Blandford <jrb@redhat.com>
783 * gtk/gtktreeprivate.h: New arguments
786 (gtk_tree_view_class_init): Add key_release callback
787 (gtk_tree_view_init): Initialize timeout handler
788 (gtk_tree_view_unrealize): clear timeout if needed
789 (gtk_tree_view_key_press): Typeahead support
790 (gtk_tree_view_key_release): Not used yet -- will be needed for
792 (gtk_tree_view_search_entry_flush_timeout): Remove typeahead entry
794 (gtk_tree_view_ensure_interactive_directory):
795 (gtk_tree_view_real_start_interactive_search):
796 (gtk_tree_view_search_init):
797 (gtk_tree_view_start_interactive_search): Typeahead support added.
798 (gtk_tree_view_search_dialog_hide): Clear timeout and text when we
801 Sat Jul 31 23:17:44 2004 Matthias Clasen <maclas@gmx.de>
805 Sat Jul 31 01:13:01 2004 Matthias Clasen <maclas@gmx.de>
809 * gtk/gtkaction.c: Use the canonical form of signal names
810 after "notify::". Otherwise, no notification arrives.
811 GObject should have a warning for that, really. (#148879,
812 Lorenzo Gil Sánchez)
814 Sat Jul 31 00:42:08 2004 Matthias Clasen <maclas@gmx.de>
816 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below):
817 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_above): Don't
818 set both states at once. (#148789, Matthew Garrett)
820 2004-07-30 Matthias Clasen <mclasen@redhat.com>
822 * gtk/gtkcombobox.c: Don't forget to destroy the row separator
823 function user data when the combo box is destroyed.
825 2004-07-30 Matthias Clasen <mclasen@redhat.com>
828 * gtk/gtkcombobox.c: Change the api for separators to use a
829 separator function instead of a boolean column.
831 * tests/testcombo.c: Update to match the api change.
833 Fri Jul 30 02:21:41 2004 Matthias Clasen <maclas@gmx.de>
835 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
836 Fix the positioning of the popup.
838 Fri Jul 30 00:56:31 2004 Matthias Clasen <maclas@gmx.de>
840 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_active_changed):
841 Implement this in terms of gtk_combo_box_get_active_iter(),
842 instead of gtk_combo_box_get_active().
844 2004-07-29 Federico Mena Quintero <federico@ximian.com>
846 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
847 a field for an "add to shortcuts" menu item.
848 (popup_menu_detach_cb): Clear out the field.
849 (file_list_build_popup_menu): Only build the menu here.
850 (file_list_update_popup_menu): Build the menu, then update the
851 sensitivity of its items.
852 (file_list_popup_menu): Use file_list_update_popup_menu().
853 (bookmarks_check_add_sensitivity): Also set the sensitivity of the
854 popup menu item. Correctly handle the case for a *single* file.
856 (bookmarks_add_selected_folder): New helper function; code moved
857 over from add_bookmark_button_clicked_cb().
858 (add_bookmark_button_clicked_cb): Use the function above.
859 (selection_check): Rather than returning a boolean value for
860 emptiness, actually return the number of selected rows. Also,
862 (get_selected_path): New helper function.
864 2004-07-29 Anders Carlsson <andersca@gnome.org>
866 * demos/gtk-demo/Makefile.am:
867 * demos/gtk-demo/clipboard.c: (copy_button_clicked),
868 (paste_received), (paste_button_clicked), (do_clipboard):
871 2004-07-28 Federico Mena Quintero <federico@ximian.com>
873 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
874 Store signal IDs in gulongs, not guints!
875 (gtk_file_chooser_default_hierarchy_changed): We now monitor the
876 focus widget on our toplevel to know which widget was last focused
877 at the time our "should_respond" method gets called.
878 (shortcuts_activate_selected): New helper function.
879 (shortcuts_get_selected): New helper function.
880 (remove_selected_bookmarks): Use shortcuts_get_selected().
881 (bookmarks_check_remove_sensitivity): Likewise.
882 (shortcuts_reorder): Likewise.
883 (shortcuts_activate_iter): Renamed from shortcuts_activate_item().
884 Activate by iter, not by item number.
885 (save_folder_combo_changed_cb): Use shortcuts_activate_iter().
886 (shortcuts_row_activated_cb): Likewise.
887 (gtk_file_chooser_default_should_respond): If the last focused
888 widget on the toplevel was the shortcuts list, activate the
891 2004-07-28 Matthias Clasen <mclasen@redhat.com>
893 * gdk/linux-fb/gdkprivate-fb.h: Make the fb backend compile against
894 current freetype. (#148558, Nicolas Deves)
896 * gtk/gtktreeview.c: Replace the EXPANDER_MAX macro by
897 ROW_HEIGHT. (#145528)
899 * gtk/gtkuimanager.c: Warning fixes.
901 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_background): Fix
902 prototype mismatch. (#148589, Nicolas Deves)
904 2004-07-28 Anders Carlsson <andersca@gnome.org>
906 * gdk/x11/gdkdrawable-x11.c (gdk_draw_rectangle_alpha_libgtk_only):
907 Cast to 32-bit integers when premultiplying, suggested by Keith Packard.
909 2004-07-27 Anders Carlsson <andersca@gnome.org>
911 * demos/gtk-demo/iconview.c: (do_iconview):
912 Change selection mode to multiple.
915 * gdk/linux-fb/gdkdrawable-fb2.c:
916 (gdk_draw_rectangle_alpha_libgtk_only):
917 * gdk/win32/gdkdrawable-win32.c:
918 (gdk_draw_rectangle_alpha_libgtk_only):
919 * gdk/x11/gdkdrawable-x11.c: (gdk_x11_draw_image),
920 (get_impl_drawable), (gdk_x11_draw_pixbuf),
921 (gdk_draw_rectangle_alpha_libgtk_only):
922 Add gdk_draw_rectangle_alpha_libgtk_only which uses
923 XRenderFillRectangle on X11. It's stubbed out on the
924 Win32 and fb backends.
927 (gtk_icon_view_paint_rubberband):
928 Use gdk_draw_rectangle_alpha_libgtk_only here.
930 2004-07-27 Anders Carlsson <andersca@gnome.org>
932 * gtk/gtkaboutdialog.c: (gtk_about_dialog_init),
933 (text_view_style_set), (add_credits_page),
934 (display_credits_dialog), (display_license_dialog):
935 Remove dialog separators, fix text view background setting,
936 use Close buttons instead of OK buttons.
938 2004-07-27 Matthias Clasen <mclasen@redhat.com>
940 * gtk/gtktreeview.c (gtk_tree_view_ensure_interactive_directory):
941 Add a frame around the C-f popup to stop it from merging visually
942 in whatever is underneath.
945 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible): New
946 function necessary to make GtkComboBox accessible. (#132847,
949 Tue Jul 27 02:34:06 2004 Matthias Clasen <maclas@gmx.de>
951 * gtk/gtkwidget.c (gtk_widget_dispose): Hide parentless
952 windows when disposing them. (#133231, Michael Natterer)
954 2004-07-26 Matthias Clasen <mclasen@redhat.com>
956 * gtk/gtklabel.c (gtk_label_class_init): Expand the documentation
957 for GtkLabel::ellipsize.
959 Mon Jul 26 00:38:27 2004 Matthias Clasen <maclas@gmx.de>
961 Make the GtkComboBox in list mode scroll if the list is too
962 large to fit in the popup. (#135543)
964 * gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Add a
965 o scrolled window to the popup in list mode.
966 (gtk_combo_box_list_position): Calculate the height of the
967 popup so that it fits on the screen, set the scrollbar policy
968 of the scrolled window appropriately.
969 (gtk_combo_box_popup): Use the height calculated by
970 gtk_combo_box_list_position().
971 (gtk_combo_box_remeasure): Don't add unnecessary padding.
972 (gtk_combo_box_size_request): But add the focus with here.
973 (gtk_combo_box_list_setup): Connect to enter notify on the
974 popup window to activate auto scrolling.
975 (gtk_combo_box_list_enter_notify): Activate auto scrolling.
976 (gtk_combo_box_list_button_pressed): Setup a timeout for
978 (gtk_combo_box_list_scroll_timeout): Timeout function for
980 (gtk_combo_box_list_auto_scroll): Scroll the list when the
981 pointer leaves the window.
983 Sun Jul 25 19:51:17 2004 Matthias Clasen <maclas@gmx.de>
985 * gtk/gtknotebook.c (gtk_notebook_scroll): Ignore scroll
986 events from the content of the page. (#148409, Gabriel
989 Sat Jul 24 21:38:12 2004 Soeren Sandmann <sandmann@daimi.au.dk>
991 * gtk/gtktoolbar.c (internal_insert_element): Warn if you try to
992 add a tool item to a toolbar using the deprecated API.
994 Fri Jul 23 13:04:10 2004 Matthias Clasen <maclas@gmx.de>
996 * gtk/gtkdnd.c (gtk_drag_dest_set): Revert the change to
997 initialize target_list to an empty list instead of NULL,
998 since it broke tree dnd. (#148215, Ernst Persson)
1000 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
1001 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): Instead
1002 handle target list being NULL here.
1004 2004-07-23 Dafydd Harries <daf@muse.19inch.net>
1006 * gtk/gtkradioaction.c:
1007 * gtk/gtkradiobutton.c:
1010 Improve various translatable messages. (#137616)
1012 Fri Jul 23 11:11:10 2004 Matthias Clasen <maclas@gmx.de>
1014 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1015 Align the entry in the same way as the cell. (#136749)
1017 Fri Jul 23 11:01:00 2004 Matthias Clasen <maclas@gmx.de>
1019 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1020 Don't iterate too far up. (#147965, Olivier Sessink)
1022 Fri Jul 23 10:28:43 2004 Matthias Clasen <maclas@gmx.de>
1024 * gtk/gtktreeview.c (gtk_tree_view_finalize):
1025 * gtk/gtkradioaction.c (gtk_radio_action_finalize):
1026 * gtk/gtkfontsel.c (gtk_font_selection_finalize):
1027 * gtk/gtkcellview.c (gtk_cell_view_finalize):
1028 * gtk/gtkcalendar.c (gtk_calendar_finalize):
1029 * gtk/gtkactiongroup.c (gtk_action_group_finalize): Remove
1030 unnecessary checks. (#148175, Morten Welinder)
1032 Thu Jul 22 01:42:16 2004 Matthias Clasen <maclas@gmx.de>
1034 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1035 Add a new :ellipsize property which controls ellipsization of the
1036 rendered text. (#144835, Vincent Untz, patch by Jonathan Blandford
1037 and Anders Carlsson)
1039 * gtk/gtkfilechooserdefault.c (create_file_list): Use ellipsization
1040 for the name column.
1042 Thu Jul 22 01:21:28 2004 Matthias Clasen <maclas@gmx.de>
1044 * gtk/gtkfontsel.c (gtk_font_selection_init): Add additional
1045 accessability relations. (#141804, Padraig O'Briain)
1047 Thu Jul 22 01:16:23 2004 Matthias Clasen <maclas@gmx.de>
1049 * gtk/gtkcombobox.c: Avoid some warnings.
1051 Thu Jul 22 01:05:16 2004 Matthias Clasen <maclas@gmx.de>
1053 * configure.in: Require Pango 1.5.1 (for ellipsisation).
1056 * gtk/gtklabel.c (gtk_label_class_init): Add a new :ellipsize
1057 property which controls ellipsization of the label. (#125250,
1058 Tim Van Wassenhove, patch by James M. Cape)
1060 * tests/testellipsise.c: Simple test for ellipsizsation.
1062 Wed Jul 21 22:46:27 2004 Matthias Clasen <maclas@gmx.de>
1064 * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
1065 list store. (#148134, Crispin Flowerday)
1067 Wed Jul 21 22:35:47 2004 Matthias Clasen <maclas@gmx.de>
1069 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
1070 menu. (#148110, Tommi Komulainen)
1072 Wed Jul 21 22:24:10 2004 Matthias Clasen <maclas@gmx.de>
1074 * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak
1075 tree model and tree row reference. (#148125, Crispin Flowerday)
1077 Wed Jul 21 22:17:06 2004 Matthias Clasen <maclas@gmx.de>
1079 * tests/testcombo.c (main): Don't leak models. (#148128,
1082 Wed Jul 21 21:26:08 2004 Matthias Clasen <maclas@gmx.de>
1084 * gtk/gtkviewport.c (viewport_set_adjustment): Don't leak
1085 the adjustments. (#148089, Tommi Komulainen)
1087 Wed Jul 21 21:20:21 2004 Matthias Clasen <maclas@gmx.de>
1089 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't leak
1090 the adjustments. (#148073, Tommi Komulainen)
1092 Wed Jul 21 21:04:50 2004 Matthias Clasen <maclas@gmx.de>
1094 * gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the
1095 arrow. (#148064, Tommi Komulainen)
1097 2004-07-21 Matthias Clasen <mclasen@redhat.com>
1099 * gtk/gtkcalendar.c: Use the new text target functionality
1100 in GtkTargetList instead of hardcoding a subset of text targets.
1102 Tue Jul 20 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
1104 * gdk/x11/gdkevents-x11.c: Hook up gtk-menu-bar-accel to
1105 an XSetting, Gtk/MenuBarAccel. (#120859, Scott James Remnant)
1107 Tue Jul 20 22:26:29 2004 Matthias Clasen <maclas@gmx.de>
1109 * gtk/gtkfilechooserutils.h:
1110 * gtk/gtktoolbutton.c:
1112 * gtk/gtkicontheme.c:
1113 * gtk/gtkcalendar.c:
1114 * demos/gtk-demo/ui_manager.c:
1115 * demos/gtk-demo/appwindow.c: Remove trailing commas
1116 from enumerations. (#148035)
1118 2004-07-20 Federico Mena Quintero <federico@ximian.com>
1120 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Fix the
1121 documentation comment for the editing-started signal.
1123 * gtk/gtkmarshalers.list: Added VOID:OBJECT,STRING for
1124 GtkCellRenderer::editing-started.
1126 2004-07-20 Matthias Clasen <mclasen@redhat.com>
1128 * tests/testactions.c (main):
1129 * tests/testmerge.c (main): Add some refcount debugging.
1131 * gtk/gtkuimanager.c (update_node, free_node): Ref an sink
1132 all proxies, so that we can properly clean up floating proxies
1133 which the app didn't adopt. (#147926, Tommi Komulainen)
1135 2004-07-20 Matthias Clasen <mclasen@redhat.com>
1137 Allow custom initialization of cell editables. (#147221)
1139 * gtk/gtkcellrenderer.h (struct _GtkCellRendererClass):
1140 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Add a
1141 ::editing-started signal as a hook for setting up the
1143 (gtk_cell_renderer_start_editing): ...and emit it here.
1145 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
1147 * gtk/gtktreeview.c (gtk_tree_view_button_press): Set drag_pos
1148 before grabbing the focus, since we may reenter into
1149 gtk_tree_view_motion_resize_column() which requires drag_pos
1150 to be set. (#147913, Guilherme Salgado, patch by John Finlay)
1152 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
1154 * gtk/gtktreeview.c (gtk_tree_view_enter_notify): Don't
1155 use uninitialized node pointer. (#147911, Peter Zelezny)
1157 Tue Jul 20 04:34:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1159 * configure.in: Bump version number
1161 Sun Jul 18 17:21:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1163 * === Released 2.5.0 ===
1167 * tests/testcombo.c: Fix compilation
1169 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1171 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_popup_completion):
1174 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1176 Make GtkCellView public, since people seem to have uses for it,
1177 it is clean API and we were just conservative in not making it
1178 public initially. At the same time, get rid of GtkCellViewMenuItem,
1179 which doesn't have any function which can't be served by a
1180 GtkMenuItem with a GtkCellView child. (#136637, Padraig O'Briain)
1182 * gtk/gtk.h: Include gtkcellview.h
1184 * gtk/Makefile.am (gtk_public_h_sources):
1186 * gtk/Makefile.am (gtk_private_h_sources):
1187 (gtk_c_sources): Remove gtkcellviewmenuitem.[hc]
1188 * gtk/gtkcombobox.c: Replace all uses of GtkCellViewMenuItem by
1189 GtkMenuItem with a GtkCellView child.
1191 * gtk/gtkcellviewmenuitem.[hc]: Removed.
1193 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1195 Support inline autocompletion in entries (#135953)
1197 * gtk/gtkentryprivate.h:
1198 * gtk/gtkentrycompletion.h:
1199 * gtk/gtkentrycompletion.c (gtk_entry_completion_class_init):
1200 Add a new signal ::insert-prefix which can be used to override
1201 the default inline-completion behaviour. Add two new boolean
1202 properties, :popup_completion and :inline_completion which
1203 determine how the possible completions should be presented.
1204 (gtk_entry_completion_insert_prefix): New function to request
1207 * gtk/gtkentry.c: Add the necessary glue for inline completion.
1209 Sun Jul 18 15:28:24 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1211 * gtk/gtkdnd.c (gtk_drag_source_set, gtk_drag_dest_set): Create an
1212 empty target list if targets is NULL.
1214 * configure.in: Add check for X11/extensions/sync.h. (#147416,
1217 Sun Jul 18 01:24:31 2004 Matthias Clasen <maclas@gmx.de>
1219 * NEWS: Updates for 2.5.0
1221 Sat Jul 17 23:11:04 2004 Matthias Clasen <maclas@gmx.de>
1223 * gtk/gtkiconview.h:
1224 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1225 * gtk/gtkiconview.c (gtk_icon_view_set_orientation):
1226 * gtk/gtkiconview.c (gtk_icon_view_get_orientation):
1227 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
1228 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row):
1229 Add a new :orientation property to determine whether text
1230 is positioned below or beside icons. (#147463)
1232 Sat Jul 17 23:03:30 2004 Matthias Clasen <maclas@gmx.de>
1234 * gtk/gtkiconview.c (gtk_icon_view_paint_item):
1235 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
1236 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row): Draw
1237 focus indicator outside the selection, respect focus
1238 line width. (#147460)
1240 Sat Jul 17 01:17:33 2004 Matthias Clasen <maclas@gmx.de>
1242 * gdk/x11/gdkdnd-x11.c (xdnd_check_dest): Fix a warning
1245 Sat Jul 17 00:48:27 2004 Matthias Clasen <maclas@gmx.de>
1247 Support text/plain selection target (#55117, Owen Taylor)
1249 * gtk/gtkselection.h:
1251 * gtk/gtkselection.c (gtk_target_list_add_text_targets):
1252 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
1253 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): New
1254 functions to facilitate handling of text targets.
1257 * gtk/gtktextview.c: Use the new text target handling
1258 functions instead of hardwiring the list of supported
1259 text targets everywhere.
1261 * gtk/gtkselection.c (gtk_selection_data_get_text):
1262 (gtk_selection_data_set_text):
1263 Support the targets text/plain, text/plain?charset=utf-8
1264 and text/plain?charset=<LOCALE-CHARSET> as outlined in
1266 For text/plain send only ASCII, but accept 8-bit text
1267 and treat it as ISO-8859-1 as specified by the Xdnd spec.
1268 Always send CRLF terminators. Accept either and convert
1269 into the native terminator for the platform.
1271 Fri Jul 16 23:20:34 2004 Matthias Clasen <maclas@gmx.de>
1273 Support themed window icons. (#92346, Calum Benson)
1275 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): New
1276 function to obtain information about the sizes in which an
1280 * gtk/gtkwindow.c (gtk_window_class_init):
1281 (gtk_window_set_icon_name):
1282 (gtk_window_get_icon_name): Add an "icon_name" property
1283 (gtk_window_set_default_icon_name): ...and a default icon name.
1284 (icon_list_from_theme):
1285 (update_themed_icon): New auxiliary functions to create a
1286 list of all available sizes of a themed icon and update the
1287 window icon list from it.
1289 2004-07-16 Matthias Clasen <mclasen@redhat.com>
1291 * gtk/gtkcombobox.c (gtk_combo_box_scroll_event): Make
1292 scrolling work if no item is selected.
1293 (gtk_cell_editable_key_press): Don't eat space.
1295 Add a combo box cell renderer (#139347, Lorenzo Gil Sanchez)
1297 * gtk/gtkcellrenderercombo.[hc]: New Files.
1300 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
1303 * gtk/gtkcombobox.[hc]: Implement GtkCellEditable, add a
1304 :has-frame property for suppressing the frame around
1305 the child and redo the size allocation logic to take
1306 focus width into account.
1308 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_init):
1309 Acknowledge the GtkComboBox:has-frame property and make
1310 the entry fill its allocation vertically.
1312 * gtk/gtkmarshalers.list: Add BOOLEAN:STRING.
1314 * gtk/gtktreeview.c (gtk_tree_view_remove_widget): Queue
1315 a draw here to keep non-widget windows from leaving
1318 2004-07-16 Matthias Clasen <mclasen@redhat.com>
1320 * gtk/gtkcombobox.c (gtk_combo_box_forall): Don't iterate
1321 multiple times over some of the children.
1323 Thu Jul 15 22:19:40 2004 Matthias Clasen <maclas@gmx.de>
1325 Fix #60128, #58307, #144706:
1327 * gtk/gtkstyle.c (gtk_style_real_copy): Handle references
1328 to bg_pixmaps properly.
1329 (gtk_style_real_unrealize): Don't keep dangling references
1331 (gtk_style_attach): Split the loop into two loops, first
1332 looking for a matching style, then for an empty one.
1333 (gtk_style_finalize):
1334 (gtk_style_duplicate): Add comments explaining the handling
1337 Thu Jul 15 20:31:28 2004 Matthias Clasen <maclas@gmx.de>
1339 * gtk/gtkspinbutton.c (start_spinning): Install the timeout
1340 before changing the value, so that a ::value_changed handler
1341 has a chance to remove it. (#122427, Elke Meier)
1343 Thu Jul 15 19:20:05 2004 Matthias Clasen <maclas@gmx.de>
1345 * gdk/x11/gdkgtk+/im-x11.c (_gdk_x11_initialize_locale):
1346 * gtk/gtkcalendar.c (gtk_calendar_class_init): Use 'cannot'
1347 instead of 'can not' in messages. (#144226, Morten Welinder)
1349 2004-07-15 Matthias Clasen <mclasen@redhat.com>
1351 * gtk/gtktreeview.c (gtk_tree_view_class_init):
1352 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1353 Correct the declared default values of several properties
1354 to be in sync with the actual initial values.
1356 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_class_init):
1357 Make spacing a property, correct the declared default values
1358 of several properties to be in sync with the actual initial
1359 values. (#147654, Matthias Clasen)
1361 * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Don't reparent
1362 back to menu->toplevel if it is already gone because we're
1363 shutting down. (#147656, John Cupitt)
1365 2004-07-14 Federico Mena Quintero <federico@ximian.com>
1369 * gtk/gtktreeview.c (gtk_tree_view_bin_expose): Draw a focus
1370 indicator along the edge of the bin_window when the tree is empty.
1371 (grab_focus_and_unset_draw_keyfocus): New helper function.
1372 (gtk_tree_view_button_press): Remove a bit of superfluous code.
1373 Use the helper function to save on duplicated code.
1374 (gtk_tree_view_button_press): Grab the focus if the tree is empty.
1375 (gtk_tree_view_focus): Allow focusing into an empty tree.
1377 2004-07-14 Matthias Clasen <mclasen@redhat.com>
1379 * gtk/gtkaboutdialog.c (add_credits_page): Don't use
1380 gcc extensions for the ternary ?: operator. (#147590,
1383 2004-07-14 Federico Mena Quintero <federico@ximian.com>
1385 Fix #144405, patch by Padraig O'Briain <padraig.obriain@sun.com>:
1387 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): Set the
1388 accessible object name for the tree view.
1389 (create_file_list): Likewise.
1391 Tue Jul 13 21:53:08 2004 Matthias Clasen <maclas@gmx.de>
1393 * gtk/gtkicontheme.c (free_unthemed_icon): Don't leak
1394 no_svg_filename. (#147399, Kjartan Maraas)
1396 2004-07-13 Matthias Clasen <mclasen@redhat.com>
1398 * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_get_neighbor_sizes):
1399 Make this work in RTL context.
1401 2004-07-13 Federico Mena Quintero <federico@ximian.com>
1403 * gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Set a
1404 busy cursor while mounting the volume. Also, ref the chooser
1405 while mounting, as we may re-enter. Fixes #139376.
1407 2004-07-13 Matthias Clasen <mclasen@redhat.com>
1409 * gtk/gtktreeview.c (gtk_tree_view_adjustment_changed):
1410 Prepare to handle composite implementations of
1411 GtkCellEditable, but recursively poking at
1412 allocation->y (hack stolen from GtkCList).
1413 (check_expander_max): Tweak the warning.
1415 * gtk/gtkmain.h: Add gtk_parse_args(), its a public
1416 function. (#147476, Owen Taylor)
1418 * gtk/gtkcombobox.c (gtk_combo_box_popdown): Don't
1419 crash if unrealized.
1421 Tue Jul 13 01:50:06 2004 Matthias Clasen <maclas@gmx.de>
1423 * gtk/gtkaboutdialog.c (display_credits_dialog): Don't
1424 display untranslated translator credits.
1426 Tue Jul 13 01:15:05 2004 Matthias Clasen <maclas@gmx.de>
1428 * gtk/gtkiconview.c: Some documentation updates.
1430 Tue Jul 13 00:40:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1432 * gdk/gdkwindow.c (gdk_window_process_updates_internal): Do an
1433 empty begin_paint_region()/end_paint() for windows without
1436 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_unset_bg,
1437 _gdk_x11_window_tmp_reset_bg): Remove checks for EXPOSURE_MASK.
1439 2004-07-12 Matthias Clasen <mclasen@redhat.com>
1441 * demos/gtk-demo/appwindow.c: Use a GtkAboutDialog.
1443 * gtk/gtkaboutdialog.h:
1444 * gtk/gtkaboutdialog.c: New widget: GtkAboutDialog.
1446 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
1447 * gtk/gtk.h: Add GtkAboutDialog. (#109435, Paolo Borelli,
1448 patch by Matthias Clasen)
1450 * gtk/gtkrc.c (_gtk_rc_init): Apply the gtk-default-menu-item-style
1451 to cell view menu items as well. (#147405, John Cupitt)
1453 * gtk/gtkentrycompletion.c: Warning fixes. (#147420,
1456 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Pop down
1457 first. (#147399, John Cupitt)
1459 Mon Jul 12 01:56:26 2004 Matthias Clasen <maclas@gmx.de>
1461 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
1462 Include the update_counter check in the HAVE_XSYNC condition,
1463 since update_counter isn't present in the !HAVE_XSYNC case.
1465 Mon Jul 12 00:52:04 2004 Matthias Clasen <maclas@gmx.de>
1467 * gtk/stock-icons/Makefile.am:
1468 * gtk/stock-icons/stock_about_{16,24}.png:
1469 * gtk/stock-icons/stock_connect_{16,24}.png:
1470 * gtk/stock-icons/stock_disconnect_{16,24}.png:
1471 * gtk/stock-icons/stock_edit_{16,24}.png:
1472 * gtk/stock-icons/stock_media_forward_{16,24}.png:
1473 * gtk/stock-icons/stock_media_next_{16,24}.png:
1474 * gtk/stock-icons/stock_media_pause_{16,24}.png:
1475 * gtk/stock-icons/stock_media_play_{16,24}.png:
1476 * gtk/stock-icons/stock_media_previous_{16,24}.png:
1477 * gtk/stock-icons/stock_media_record_{16,24}.png:
1478 * gtk/stock-icons/stock_media_rewind_{16,24}.png:
1479 * gtk/stock-icons/stock_media_stop_{16,24}.png:
1480 * gtk/gtkstock.h (GTK_STOCK_ABOUT):
1481 * gtk/gtkstock.h (GTK_STOCK_CONNECT):
1482 * gtk/gtkstock.h (GTK_STOCK_DISCONNECT):
1483 * gtk/gtkstock.h (GTK_STOCK_EDIT):
1484 * gtk/gtkstock.h (GTK_STOCK_MEDIA_FORWARD):
1485 * gtk/gtkstock.h (GTK_STOCK_MEDIA_NEXT):
1486 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PAUSE):
1487 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PLAY):
1488 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PREVIOUS):
1489 * gtk/gtkstock.h (GTK_STOCK_MEDIA_RECORD):
1490 * gtk/gtkstock.h (GTK_STOCK_MEDIA_REWIND):
1491 * gtk/gtkstock.h (GTK_STOCK_MEDIA_STOP):
1492 * gtk/gtkiconfactory.c (get_default_icons):
1493 * gtk/gtkstock.c (builtin_items): Add a number of new stock
1494 items. (#102530, #68015, #109811, Jordi Mallach, Benjamin Otte,
1497 Sun Jul 11 15:24:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1499 Bug 143330, support update counter spec.
1501 * configure.in: Add check for the Sync extension
1503 * gdk/gdkwindow.h: gdk_window_enable_synchronized_configure() and
1504 gdk_window_configure_finished()
1506 * gtk/gtkwindow.c (gtk_window_move_resize): Call gdk_window_finish_configure().
1507 * gtk/gtkwindow.c (gtk_window_realize): Automatically enable
1508 synchronized configures.
1510 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Store current
1511 and pending counter values.
1513 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): New function.
1514 * gdk/x11/gdkwindow-x11.c
1515 (gdk_window_enable_synchronized_configure): New function.
1516 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
1517 Delete update counter.
1518 * gdk/x11/gdkwindow-x11.c (set_wm_protocols): Advertise
1519 _NET_WM_SYNC_REQUEST when Sync is available
1521 * gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Handle
1522 _NET_WM_SYNC_REQUEST messages
1523 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Save counter
1524 value for use by gdk_window_configure_finished() when receiving
1527 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add use_sync flag
1528 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Check if the XSync
1529 extension is available
1530 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_SYNC_REQUEST and
1531 _NET_WM_SYNC_REQUEST_COUNTER to list of supported atoms.
1533 * gdk/linux-fb/gdkwindow-fb.c, gdk/win32/gdkwindow-win32.c: Add
1534 stubs for enable_synchronized_configure() and configure_finished()
1536 Sat Jul 10 23:35:13 2004 Matthias Clasen <maclas@gmx.de>
1538 * gtk/gtkentry.c (paste_received): Make middle-button pasting
1539 work as expected inside the entry. (#116789, Scott Bronson)
1541 Sat Jul 10 22:13:53 2004 Matthias Clasen <maclas@gmx.de>
1543 * gtk/gtktextbuffer.c (gtk_text_buffer_select_range): Update
1544 clipboards. (#142805, Mikael Hallendal)
1546 Sun Jul 11 01:38:48 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1548 * gtk/gtkpaned.c (gtk_paned_expose): Remove clip-region computing
1549 code. Just use &paned->handle_pos.
1551 Sun Jul 11 01:12:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1555 * gtk/gtknotebook.c (gtk_notebook_size_allocate): Remove an
1556 unnecessary redraw..
1558 * gtk/gtknotebook.c (gtk_notebook_page_allocate): Remove some
1561 Sat Jul 10 01:33:25 2004 Matthias Clasen <maclas@gmx.de>
1563 * docs/RELEASE-HOWTO: Updates.
1565 Sat Jul 10 01:55:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1567 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{re|un}set_bg):
1568 Insert checks for root window. The root window is never mapped.
1570 Sat Jul 10 01:06:05 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1572 * gdk/x11/gdkwindow-x11.c (post_unmap): Fix a warning
1573 * gdk/x11/gdkwindow-x11.c (show_window_internal): Actually unset
1576 Sat Jul 10 00:37:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1580 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{un|re}set_bg):
1581 New functions that can do a recursive unset/reset bg.
1583 * gdk/x11/gdkgeometry-x11.c: Remove
1584 gdk_window_tmp_{un|re}set_bg().
1586 * gdk/x11/gdkwindow-x11.c (pre_unmap, post_unmap): New functions
1587 called before and after unmapping a window. They unset the
1588 background of all other windows to prevent flicker from the X
1589 server repainting the background. post_unmap() also invalidates
1590 the parent of the unmapped window to draw it without roundtrips.
1592 * gdk/x11/gdkwindow-x11.c (show_window_internal): Unset
1593 background of newly mapped windows and all desendants to prevent
1596 Fri Jul 9 15:33:55 2004 Manish Singh <yosh@gimp.org>
1598 * gdk/gdkevents.c: have a dummy case GDK_OWNER_CHANGE in switch
1599 statements to avoid gcc warnings about not all enum values handled.
1601 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): ignore should live in
1604 Fri Jul 9 23:26:09 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1608 * gdk/x11/gdkwindow-x11.h (struct _GdkWindowImplX11): Add an
1609 "override_redirect" bit.
1611 * gdk/x11/gdkwindow-x11.c (gdk_window_new): Set it here.
1613 * gdk/x11/gdkwindow-x11.c (gdk_window_move, gdk_window_resize,
1614 gdk_window_move_resize):
1615 Update the local size/position cache
1616 immediately for override redirect windows.
1618 * gdk/x11/gdkwindow-x11.c (show_window_internal): Invalidate
1619 newly mapped child and override redirect windows.
1621 2004-07-09 Federico Mena Quintero <federico@ximian.com>
1625 * gtk/gtkfilesystemunix.c (get_fallback_icon): New helper
1626 function, fetches a stock icon as a fallback.
1627 (gtk_file_system_unix_volume_render_icon): Fall back to a stock
1629 (gtk_file_system_unix_render_icon): Fall back to a stock icon.
1630 Use helper functions rather than being a mega-function.
1631 (get_icon_name_for_directory): Renamed from
1632 get_icon_for_directory().
1633 (get_icon_type_from_path): New helper function; code pulled out
1634 from gtk_file_system_unix_render_icon().
1635 (get_special_icon): Likewise.
1636 (get_icon_for_mime_type): Likewise.
1638 2004-07-09 Federico Mena Quintero <federico@ximian.com>
1640 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Fix typo; tmp_event ->
1643 2004-07-09 Matthias Clasen <mclasen@redhat.com>
1645 * gtk/gtktooltips.c (gtk_tooltips_paint_window): Use the
1646 requisition of the widget instead of relying on the style
1647 drawing function to supply the size of the drawable. (#146531)
1649 2004-07-09 Matthias Clasen <mclasen@redhat.com>
1651 Make GtkEntry work harder to protect passwords: (#143955,
1654 * gtk/gtkentry.c (gtk_entry_destroy): Add a destroy handler
1655 to clear the password even if the widget is leaked.
1657 * gtk/gtkentry.c (gtk_entry_real_delete_text):
1658 * gtk/gtkentry.c (gtk_entry_finalize): Zero out the memory
1661 * gtk/gtkentry.c (gtk_entry_real_insert_text): Zero and free
1662 the old memory instead of just reallocating it.
1664 * gtk/gtkentry.c (gtk_entry_create_layout): Don't leak text
1665 direction information for passwords.
1667 2004-07-09 Matthias Clasen <mclasen@redhat.com>
1669 * gtk/gtkstyle.c: Fix some cases where style functions were
1670 not handling widget == NULL properly. (#146282)
1672 Thu Jul 8 22:38:58 2004 Matthias Clasen <maclas@gmx.de>
1674 * gtk/gtktreeview.c: Improve the EXPANDER_MAX warning.
1676 2004-07-08 Federico Mena Quintero <federico@ximian.com>
1680 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Add a
1681 GError argument. Do check for errors when getting the
1682 GtkFileFolder: get the folder and read the children before
1683 actually creating the model. Removed obsolete code that handled
1684 roots-changed on the file system.
1685 (file_model_node_get_info): Assert that we don't reach the old
1686 case to display file system roots.
1687 (roots_changed_callback): Removed.
1689 * gtk/gtkfilechooserdefault.c (set_list_model): Add a GError
1690 argument, and a boolean return value. Return an error if we
1691 cannot create the file system model. On error, set a NULL model
1693 (gtk_file_chooser_default_set_current_folder): Use the error value
1694 from set_list_model().
1695 (gtk_file_chooser_default_set_property): Set the show_hidden
1696 property only if the browse_files_model exists.
1697 (gtk_file_chooser_default_unselect_path): Only operate if the
1698 browse_files_model exists.
1699 (check_preview_change): Check whether we have the sort_model.
1700 (change_folder_and_display_error): Copy the path we get passed
1701 before using it. There's a comment in there that explains why we
1702 need to copy it; basically, if the passed path belongs to the
1703 model, the model may go away in the middle of this function and
1704 we'll be left with a dangling pointer.
1705 (install_list_model_filter): Assert that the model is not NULL.
1706 (set_current_filter): Check whether the model exists.
1708 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Don't
1709 g_return_if_fail if the model is NULL.
1710 (gtk_tree_selection_get_selected_rows): Likewise.
1711 (gtk_tree_selection_count_selected_rows): Likewise.
1712 (gtk_tree_selection_selected_foreach): Likewise.
1713 (gtk_tree_selection_path_is_selected): Likewise; rather just
1715 (gtk_tree_selection_select_all): Likewise.
1716 (gtk_tree_selection_unselect_all): Likewise.
1717 (gtk_tree_selection_select_range): Do g_return_if_fail() if the
1719 (gtk_tree_selection_unselect_range): Likewise.
1721 * gtk/gtkfilesystemunix.c (fill_in_names): Return immediately if
1722 g_dir_open() fails: there is no need to set the error ourselves,
1723 as g_dir_open() already does it.
1725 2004-07-08 Matthias Clasen <mclasen@redhat.com>
1727 * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Allow
1728 to restore the default search function. (#145365, John Finlay)
1730 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Don't leak
1731 references to the drag context. (#144324, Alex Larsson)
1733 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
1735 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
1736 when a new model is set. (#145566, Dmitry M. Shatrov)
1738 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
1740 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
1741 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
1742 in order to avoid rendering artifacts from misaligned
1743 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
1745 2004-07-07 Matthias Clasen <mclasen@redhat.com>
1747 * gtk/gtktreeview.c:
1748 * gtk/gtktreeview.h: Small documentation fixes.
1750 2004-07-07 Matthias Clasen <mclasen@redhat.com>
1752 Support separators in combo boxes and more generally in tree
1755 * gtk/gtkcombobox.h:
1756 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
1757 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
1758 Add a ::row-separator-column property with getter and setter,
1759 which can indicate a boolean model column to determine which
1760 rows are separators.
1762 * gtk/gtkcombobox.c: Display separator rows as separator menu
1763 items in menu mode, and by using the new treeview separator
1764 functionality in list mode.
1766 * gtk/gtktreeview.h:
1767 * gtk/gtktreeprivate.h:
1768 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
1769 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
1770 Add a callback to determine whether a row is a separator.
1772 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
1773 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1774 * gtk/gtktreeview.c (validate_row): Use the new callback
1775 to determine whether a row is a separator, and draw it
1776 as a separator then. Since separators should take up less
1777 vertical space than regular rows, this requires removing
1778 the redundant MAX(...,expander_size) calls which appear in
1779 many places. Instead, the MAX() is now only done in
1780 validate_row(), and only if the row is not a separator.
1781 To catch possible side effects of this intrusive change,
1782 I have left EXPANDER_MAX() calls in place of the MAX() calls
1783 which will emit a warning if something breaks. They should
1784 be removed before 2.6.
1786 * gtk/gtktreeselection.c (row_is_selectable): Don't let
1787 separator rows be selected.
1789 * tests/testcombo.c (create_blaat): Add a separator column.
1791 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
1793 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
1794 a 64bit alignment issue. (#144302, Sunil)
1796 2004-07-07 Tor Lillqvist <tml@iki.fi>
1798 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
1799 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
1800 * gdk/win32/gdkproperty-win32.c (find_common_locale,
1801 gdk_property_change)
1802 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
1803 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
1806 * gdk/win32/gdkglobals-win32.c
1807 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
1808 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
1809 atom. Initialize it. Declare it. Drop the variable for the
1812 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
1813 function is supposed to return the string in the locale's charset
1814 and encoding. Use g_convert().
1816 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
1817 string in the locale's charset. Use g_convert().
1819 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
1820 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
1821 GLib's UTF-16 functions instead. Windows uses UTF-16.
1823 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
1824 functions mentioned above.
1826 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
1827 also if the string is of type STRING, i.e. ISO-8859-1, and the
1828 current codepage is 1252, and contains no C1 chars. Accept
1831 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
1832 Mark as static. When storing STRING data, convert to
1834 (gdk_selection_owner_set_for_display): Now that STRING is always
1835 ISO-8859-1, use UTF8_STRING when sending the selection request
1838 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
1841 (gdk_text_property_to_text_list_for_display): Make work more like
1842 X11 version. Do obey the encoding parameter.
1844 (gdk_string_to_compound_text_for_display,
1845 gdk_utf8_to_compound_text_for_display): Don't even pretend
1846 supporting COMPOUND_TEXT.
1848 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
1850 (sanitize_utf8): Zero-terminate string.
1852 2004-07-06 Matthias Clasen <mclasen@redhat.com>
1854 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
1855 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
1857 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
1858 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
1859 fallbacks for gtkfilechooser. Currently these are the same images
1860 as the "new" and "open" items...
1862 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
1864 Fix for #136496, Pawel Salek:
1866 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
1867 a node when it changes in fixed_height mode.
1869 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
1872 2004-07-06 Matthias Clasen <mclasen@redhat.com>
1874 * gtk/gtkmenu.c (gtk_menu_position): Make sure
1875 private->monitor_num is a valid monitor number before
1876 using it. (#139187, Michael Natterer)
1878 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
1880 * gtk/gtkfilechooserdefault.c (popup_position_func):
1881 * gtk/gtkentry.c (popup_position_func):
1882 * gtk/gtktextview.c (popup_position_func): Improve positioning
1883 of keyboard-activated menus with Xinerama.
1885 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
1887 * gtk/gtkuimanager.c (do_updates):
1888 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
1889 when called from an idle handler. (#145429, Jan-Marek Glogowski)
1891 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
1893 * gtk/gtkfilechooserutils.c (delegate_notify): Use
1894 the less efficient g_object_interface_find_property () instead
1895 of the param_id range check, since the GParamSpecs we're
1896 dealing with are the overridden onces on the interface, whose
1897 param_id is always zero. (#145312, Alex Roitman, fix proposed
1900 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
1902 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
1903 virtual method of GtkContainer.
1904 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
1905 method slot of the container class.
1907 2004-07-05 Anders Carlsson <andersca@gnome.org>
1909 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
1910 * gtk/gtkiconview.h:
1911 Use gint, not int in gtk_icon_view_set_markup_column,
1914 2004-07-05 Anders Carlsson <andersca@gnome.org>
1916 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
1917 (gtk_icon_view_real_select_cursor_item),
1918 (gtk_icon_view_real_activate_cursor_item):
1919 * gtk/gtkiconview.h:
1920 Add an "activate_cursor_item" action signal
1921 and bind it to the return key.
1923 2004-07-04 Anders Carlsson <andersca@gnome.org>
1925 * demos/gtk-demo/Makefile.am:
1926 * demos/gtk-demo/gnome-fs-directory.png:
1927 * demos/gtk-demo/gnome-fs-regular.png:
1928 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
1929 (sort_func), (create_store), (item_activated), (up_clicked),
1930 (home_clicked), (do_iconview):
1931 Add a simple file browser based on the icon view.
1934 Add gtk/gtkiconview.h
1936 * gtk/gtkiconview.c: (gtk_icon_view_layout),
1937 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
1938 Fix a few bugs discovered while writing the demo.
1940 2004-07-04 Anders Carlsson <andersca@gnome.org>
1944 * gtk/gtkiconview.h:
1945 Add GtkIconView to the build, remove debugging output.
1947 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
1949 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
1950 (gtk_calendar_drag_data_received): Fix off-by-one error.
1951 GDate month is one-based and GtkCalendar month is zero-based.
1952 (#145134, William Jon McCann)
1954 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
1956 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
1957 somebody tries to move a node after itself in a list of
1958 length 1. (#145291, Sampo Nurmentaus)
1960 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
1962 * docs/faq/gtk-faq.sgml:
1963 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
1966 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
1968 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
1969 and current_height to 0 when ending the embedding. (#143675,
1970 Nickolay V. Shmyrev)
1972 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
1974 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
1975 to the right end of the entry text, even if it ends in combining
1976 marks. (#141728, Theppitak Karoonboonyanan)
1978 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
1980 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
1981 row when unsetting the model. (#138560, Christian Persch)
1983 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
1985 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
1988 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
1990 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
1991 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
1993 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
1995 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
1996 to the event mask, set a scroll_event handler.
1997 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
1998 by switching tabs. (#145244, Gabriel de Perthuis)
2000 2004-07-02 Anders Carlsson <andersca@gnome.org>
2002 * gtk/gtktreeview.c (gtk_tree_view_set_model):
2003 Make sure we check for a NULL model first.
2005 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
2007 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
2008 win32 build problem w/o wintab. Fixed #145242
2010 2004-06-30 Anders Carlsson <andersca@gnome.org>
2012 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
2013 g_return_if_fail to make sure that the model is a GtkTreeModel.
2015 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2017 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
2018 current state, not GTK_STATE_NORMAL
2020 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
2022 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2024 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
2026 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
2028 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
2029 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
2032 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
2034 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
2035 recursion by resetting icon_set->cache before freeing
2036 the cache. (#144947, Tim Janik)
2038 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
2040 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
2041 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
2042 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
2045 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
2047 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
2048 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
2049 last change in the docs.
2051 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
2053 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
2054 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
2055 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
2057 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
2059 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
2060 placement policy for GtkComboBoxEntry to be: if it fits below,
2061 place below, if it fits above place above, else place in the
2062 larger space and scroll so that the scroll arrow appear at the
2063 far end. (#144362, David A. Knight)
2065 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
2067 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
2068 use of &parent_iter. (#145007, John Finlay)
2070 2004-06-25 Bastien Nocera <hadess@hadess.net>
2072 reviewed by: Matthias Clasen <maclas@gmx.de>
2074 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
2075 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
2076 the number of keysyms per keycode is odd. Fixes #144808.
2078 2004-06-25 Matthias Clasen <mclasen@redhat.com>
2080 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
2081 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
2083 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
2085 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
2086 which was mentioned below.
2088 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
2090 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
2091 string change. (#139503, Baris Cicek)
2093 2004-06-22 Federico Mena Quintero <federico@ximian.com>
2095 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
2096 or an Open stock button for the C-l dialog depending on the action
2097 in which the file chooser operates. Fixes #141753.
2099 2004-06-22 Federico Mena Quintero <federico@ximian.com>
2101 Fixes the GTK+ part of #142308:
2103 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
2104 Use filename_to_path().
2105 (gtk_file_system_unix_uri_to_path): Likewise.
2106 (filename_to_path): Use remove_trailing_slash().
2108 2004-06-22 Matthias Clasen <mclasen@redhat.com>
2110 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
2111 for the ::move_cursor signal.
2113 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
2114 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
2117 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
2118 this gets defined for all backends, so linux-fb has a
2119 chance of compiling.
2121 * gdk/x11/gdkgc-x11.c:
2122 * gdk/gdkgc.c: Move function docs inline, add hints about
2123 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
2125 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
2126 for children of the root. (#139785, Jean-François Wauthy,
2127 patch by John Finlay)
2129 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
2130 fix. (#144750, Jeff Franks)
2132 2004-06-21 Michael Natterer <mitch@gimp.org>
2135 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
2136 function public as _gdk_x11_convert_to_format().
2138 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
2139 the pixels from the GdkPixbuf when putting them in the
2140 Xcursor image. Fixes bug #144350.
2142 2004-06-16 Federico Mena Quintero <federico@ximian.com>
2144 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
2145 visible node, free the old path before creating the new one.
2148 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
2150 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
2151 (#144198, Mariano Suárez-Alvarez)
2153 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
2155 * gtk/gtkfilechooserdefault.c: Don't use
2156 contractions like "don't" or "isn't" in error messages.
2157 It isn't nice to use them in log entries either...
2158 (#137774, Morten Welinder, patch by Alexander Winston)
2160 2004-06-11 Federico Mena Quintero <federico@ximian.com>
2164 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
2165 Don't ref the editable node.
2166 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
2167 (_gtk_file_system_model_remove_editable): Ahem, free the node.
2169 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
2170 Added fields for edited_idle and edited_new_text.
2171 (renderer_edited_cb): Queue the
2172 creation of the folder in an idle handler.
2173 (renderer_editing_canceled_cb): Likewise for the cancellation.
2174 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
2176 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
2178 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
2180 2004-06-10 Federico Mena Quintero <federico@ximian.com>
2182 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
2184 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
2185 Refer to gtk_file_chooser_add_shortcut_folder().
2186 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
2187 gtk_file_chooser_add_shortcut_folder_uri().
2189 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
2191 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
2192 the drag before focusing the selected.day.
2193 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
2194 a beginning drag if the widget becomes insensitive.
2196 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
2198 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
2199 spinning before calling arrow_action(), so that a signal
2200 handler triggered from arrow_action() has a chance to
2201 stop the spinning. (#143966, Davyd Madeley)
2203 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
2205 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
2206 typo. (#144070, Kent Sandvik)
2208 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2210 * gtk/gtkmenu.c: Revert the "drag select" part of
2213 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
2215 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
2216 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
2218 2004-06-07 Federico Mena Quintero <federico@ximian.com>
2220 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
2221 from 2003/Sep/12. This kept DnD in tree views within modal
2222 dialogs from working, which is especially bad for the file
2223 chooser. Fixes #135168.
2225 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
2227 Make the entry context menu work in editable text cells. The changes
2228 are based on a patch by Kristian Rietveld, which implemented an
2229 approach outlined by Owen Taylor. (#50075)
2231 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
2232 Ignore focus out if the entry menu is posted.
2233 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
2234 posted, and set up a signal handler to clear the flag if the menu
2236 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
2237 set up a timeout to stop editing if the focus is lost.
2238 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
2239 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
2240 signal on the entry and keep a pointer to the entry.
2241 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
2242 clear the pointer to the entry.
2244 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
2246 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
2247 of the ::language property. (#143802, Owen Taylor)
2249 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
2251 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
2252 (gtk_entry_completion_list_enter_notify),
2253 (gtk_entry_completion_list_motion_notify),
2254 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
2255 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
2256 use it as in the menu code to avoid the initial selection if
2257 the window pops up under the pointer. (Anders Carlsson)
2259 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2261 * tests/testmerge.c: Add a checkbox to queue an
2262 merge/unmerge. Patch from Matthias Clasen.
2264 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
2266 (rebuild_menu): New function that rebuilds the overflow menu and
2267 makes sure it doesn't start or end with a separator.
2268 (toolbar_content_new_tool_item)
2269 (toolbar_content_remove)
2270 (toolbar_content_new_compatibility): Set the rebuild_needed flag
2271 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
2272 have actually overflown an item with a proxy menu item. Also make
2273 sure we rebuild the menu if needed.
2275 Fix #125504, #142377, #143463
2277 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
2278 Obey the "priv->draw" flag. (#143692)
2280 2004-06-04 Matthias Clasen <mclasen@redhat.com>
2282 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
2283 quirk in the button size allocation code.
2285 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
2286 requested for drawing the focus indicator to the child in the
2287 !CAN_FOCUS case. This should fix issues which the Gimp has with
2288 the button allocation changes in 2.4.2.
2290 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
2292 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
2293 length of the entry contents in characters, not in bytes.
2295 * gtk/gtkentry.c (paste_received): Don't pop up the completion
2296 window on paste, noticed by Anders Carlsson.
2298 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
2300 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
2301 values and default value for the ::active property. (#143669,
2304 2004-06-03 Michael Natterer <mitch@gimp.org>
2306 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
2307 instead of accessing item->image->allocation.width/height
2308 directly. Makes widgets which only have a requisition set using
2309 gtk_widget_set_size_request() work and fixes bug #142789.
2311 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2313 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
2314 of sticky right click menus to return.
2316 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2318 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
2319 better handle the "click" case. bug Better fix for #141169.
2321 2004-06-02 Federico Mena Quintero <federico@ximian.com>
2323 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
2324 model is empty. Fixes #143536.
2326 2004-06-02 Matthias Clasen <mclasen@redhat.com>
2328 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
2329 close the dialog on focus out of the size entry. (#143505,
2332 2004-06-02 Federico Mena Quintero <federico@ximian.com>
2336 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
2337 (gtk_fnmatch_intern): Likewise; also implement this option.
2339 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
2341 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
2342 no_leading_period argument of _gtk_fnmatch().
2343 (attempt_file_completion): Likewise.
2345 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
2346 no_leading_period argument of _gtk_fnmatch().
2348 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
2350 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
2353 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
2355 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
2356 allow unless selection mode is multiple. (#142634, John Finlay)
2358 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
2362 * gtk/gtkentrycompletion.h:
2363 * gtk/gtkentrycompletion.c:
2364 * gtk/gtkcombobox.h:
2365 * gtk/gtkcombobox.c: Rename function parameters from
2366 index to index_ to prevent clash with BSD index(). (#143001)
2368 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
2370 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
2371 NULL on an accel label. (#139641, Sam Stephenson, patch by
2374 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
2376 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
2377 lookup finding icons in the wrong prefix. (#143328,
2380 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2384 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
2385 only stay up if you release within 500 milliseconds.
2386 (gtk_menu_shell_button_press): Set the activate_time to the event
2387 time when a button is pressed.
2389 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
2390 Interprete button releases as activate when we have seen both an
2391 enter an a motion event.
2393 2004-06-01 Federico Mena Quintero <federico@ximian.com>
2395 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
2396 dummy node if there is no parent node. Fixes #143362.
2398 2004-05-31 Federico Mena Quintero <federico@ximian.com>
2400 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
2401 newly-created folder. Fixes #138932.
2402 (trap_activate_cb): Only return TRUE if we did handle the event.
2403 Fixes #143359; patch by jylefort@brutele.be.
2405 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
2407 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
2408 docs. (#142892, Tommi Komulainen)
2410 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
2412 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
2413 parent is minimized, porting the fix from 1.2. (#1923, #57182)
2415 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
2417 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
2418 unmapped windows work.
2420 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
2422 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
2425 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
2427 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
2428 Refer to ::update-preview, not ::selection-changed.
2430 2004-05-29 Christian Rose <menthos@menthos.com>
2432 * configure.in: Added "tk" to ALL_LINGUAS.
2434 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
2436 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
2437 messages for common problems. (#137974, Owen Taylor)
2439 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
2441 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
2442 errors. (#143337, Billy Biggs)
2444 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
2446 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
2447 bits within visual->depth that aren't used for color to
2448 1s, in case they are alpha.
2450 2004-05-27 Anders Carlsson <andersca@gnome.org>
2452 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
2453 Make separator rows insensitive.
2455 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
2457 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
2460 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
2462 * gtk/gtkentrycompletion.h:
2463 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
2464 Getter for text_column. Also make ::text_column a property.
2466 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
2468 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
2470 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
2472 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
2473 signal if the box exists.
2475 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
2477 Support insensitive cells in tree views and combo boxes:
2479 * gtk/gtkcellrenderer.h:
2480 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
2482 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
2483 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
2484 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
2485 Support drawing insensitive.
2487 * gtk/gtkcellview.h:
2488 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
2489 function to obtain the cell renderers from a cell view. Also
2490 export gtk_cell_view_set_cell_data().
2492 * gtk/gtktreeselection.c (tree_column_is_sensitive):
2493 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
2494 to determine whether all visible cells in a row are insensitive
2495 and whether a row is selectable. A row is not selectable if the
2496 user function says so or if all visible cells are insensitive.
2497 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
2498 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
2499 Use row_is_selectable().
2501 * gtk/gtkcombobox.c (row_is_sensitive):
2502 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
2503 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
2504 to determine row sensitivity in menu or list mode.
2506 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
2507 to set up sensitivity menu items from the underlying rows.
2509 * gtk/gtkcombobox.c (gtk_combo_box_popup):
2510 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
2511 update_menu_sensitivity().
2513 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
2516 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
2519 * tests/testcombo.c (main): Make some rows insensitive.
2521 2004-05-26 Robert Ögren <gtk@roboros.com>
2523 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
2524 modifiers (shift, ctrl etc) in button and motion events from the
2527 2004-05-26 Robert Ögren <gtk@roboros.com>
2529 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
2530 implementation for extended input devices using last known
2531 device state (#143237)
2533 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
2535 * gtk/gtkframe.c: Move docs inline, fixing them on the
2536 way. (#143029, Steve Chaplin)
2538 2004-05-11 Robert Ögren <gtk@roboros.com>
2540 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
2541 events to windows that want extended input events. (#142943)
2542 (gdk_event_translate): Move check for extended input devices to
2543 propagate, new parameter to propagate.
2544 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
2545 _gdk_input_(un)grab_pointer. (#142943)
2547 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
2548 input grab. [Fix missing update of impl in "dijkstra" event
2549 propagation loop] Drop the parallel "impl" pointer, just use a
2550 cast. Don't propagate beyond windows that want normal input
2552 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
2553 implementation of input grab. (#142943)
2555 2004-05-22 Tor Lillqvist <tml@iki.fi>
2557 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
2558 line. (Spotted by Benoît Carpentier.)
2560 2004-05-18 Matthias Clasen <mclasen@redhat.com>
2562 * configure.in: Check for XFIXES extension.
2564 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
2565 a gboolean have_xfixes member.
2567 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
2568 XFIXES events and set have_xfixes.
2570 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
2571 (GdkEventOwnerChange): New event struct for owner change events.
2572 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
2574 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
2575 XFixesSelectionNotify events into GdkEventOwnerChange events.
2578 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
2579 (gdk_display_request_selection_notification): New api
2580 to support selection ownership notification.
2582 * gtk/gtkclipboard.h:
2583 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
2584 api to handle owner change events.
2585 (clipboard_peek): Refactored out the body of
2586 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
2588 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
2589 by calling _gtk_clipboard_handle_event().
2591 2004-05-18 Matthias Clasen <mclasen@redhat.com>
2593 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
2594 the P_() macros ourselves.
2596 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2597 Restrict the width of the popup to be no larger than the
2598 monitor. (#142678, DmD Ljungmark)
2600 * gtk/gtkbutton.c: Go back to the initial fix for the
2601 focus-overdrawing problem, which was actually correct
2602 according to docs/widget_geometry.txt.
2604 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
2605 arrow size from 11 to 15 to compensate for that.
2607 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
2608 arguments of the ::move-cursor signal. (#142725)
2610 2004-05-17 Matthias Clasen <mclasen@redhat.com>
2614 * gtk/gtkbutton.c (gtk_button_size_request)
2615 (gtk_button_size_allocate, _gtk_button_paint): Allocate
2616 space for the focus rectangle only if necessary. (#142668,
2619 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
2623 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
2624 lines. (#142479, Morten Welinder)
2626 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
2628 * gtk/gtkintl.h (Q_): Add a Q_() macro.
2630 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
2631 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
2632 they are not really needed.
2634 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
2635 instead of hardwired padding, use Q_() for the default label,
2636 compute a reasonable minimal size. (#142571, #142572, #142573,
2637 Tommi Komulainen, Christian Persch)
2639 2004-05-15 Tor Lillqvist <tml@iki.fi>
2641 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
2642 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
2643 time). It is used by the OLE2_DND code, which is unfinished and
2644 presumably horribly broken, but still, let's not make it not
2645 compile on purpose. Silence some gcc warnings in the OLE2_DND
2648 2004-05-14 Matthias Clasen <mclasen@redhat.com>
2650 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
2651 New function to go from tree window to tree coordinates, kept
2652 static for now until we figure out the multiple coordinate
2653 system mess in GtkTreeView API-wise.
2654 (gtk_tree_view_scroll_to_cell): Transform the coordinates
2655 from tree window to tree coordinates, using the new function.
2656 Previously, the x coordinate was wrongly transformed. (#142494)
2658 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
2661 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
2662 modifier bit to mark stock item which need to be freed
2663 eventually. (#140654, Michal Pasternak, Scott Tsai)
2665 2004-05-11 Robert Ögren <gtk@roboros.com>
2667 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
2668 call to g_object_ref in Wintab code. (#138341)
2670 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
2671 including unallocated buffers for event->motion.axes and
2672 event->button.axes, unsigned wraparound problem in the code for
2673 detecting missing press/release events and assigning min instead
2674 of max when setting up axes.
2676 2004-05-12 Matthias Clasen <mclasen@redhat.com>
2678 * tests/testtreeedit.c: Add a progress column.
2680 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
2683 * gtk/gtk.h: Include gtkcellrendererprogress.h.
2685 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
2686 based on the one found in Epiphany.
2688 2004-05-11 Michael Natterer <mitch@gimp.org>
2690 * gtk/gtkcombobox.c (gtk_combo_box_popup)
2691 (gtk_combo_box_menu_button_press): don't allocate the popup
2692 smaller than the combobox. Fixes bug #59660.
2694 2004-05-11 Matthias Clasen <mclasen@redhat.com>
2696 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
2697 previous change to this function, clarify the docs instead.
2699 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
2700 GTK_SELECTION_BROWSE.
2702 * gtk/gtktreeview.c: Make hover selection work for
2703 GTK_SELECTION_BROWSE as well.
2705 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
2707 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
2708 Document the ::toggled signal.
2710 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2712 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
2714 2004-05-10 Matthias Clasen <mclasen@redhat.com>
2716 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
2718 * gdk/gdkdisplay.c (singlehead_...):
2719 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
2720 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
2721 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
2723 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
2724 note about COLUMN_FIXED restriction.
2726 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
2727 Set the entry in the default handler of the ::match-selected signal.
2730 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
2731 do the move-selected-item below pointer thingie, do the
2732 place-below-or-above one.
2734 * tests/testentrycompletion.c: Make the second example use the
2735 ::match-selected signal to make it actually work.
2737 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
2738 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
2739 mode. (#127648, Dave Bordoley)
2741 * gtk/gtktreeview.h:
2742 * gtk/gtktreeview.c: Add a new property "hover_selection", which
2743 when TRUE makes the selection follow the mouse. Also add setter
2744 and getter for the fixed_height property.
2746 2004-05-10 Matthias Clasen <mclasen@redhat.com>
2748 * gtk/gtkcombobox.c (gtk_combo_box_popup)
2749 (gtk_combo_box_menu_button_press): Make sure the menu pops up
2750 as wide as the combobox. (#59660, Havoc Pennington)
2752 2004-05-10 Matthias Clasen <mclasen@redhat.com>
2754 * gtk/gtkcombobox.h:
2755 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
2756 mode). Add a new property, add-tearoffs, for this. (#135956)
2758 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
2759 default button. (#118921)
2761 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2763 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
2764 that emits the grab notify signal.
2766 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
2768 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
2770 * gtk/gtkmenu.c: Make destruction of a torn off menu work
2771 like un-tearing off.
2773 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
2777 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
2778 Allow to suppress the stock accelerator by using "". (#142196,
2781 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
2785 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
2786 In list mode, accept the same mouse/wheel bindings on
2787 the cellview as on the button. (#136967)
2789 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
2791 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
2792 cached icons. (#135888, Crispin Flowerday)
2794 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
2796 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
2797 that we actually return menus for nodes of type menu, not the
2798 menuitems they're attached to.
2800 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
2802 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
2803 Add a note regarding UTF-8 requirements, proposed by
2804 Mariano Suárez-Alvarez.
2806 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
2808 * gtk/gtktearoffmenuitem.h:
2809 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
2810 into the GtkTearoffMenuItem struct, since it is used
2811 by the Gimp, and keep it synchronized with the
2812 tearoff_state property of the parent menu.
2814 2004-05-08 Hans Breuer <hans@breuer.org>
2816 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
2817 create the correct mask for 'pseudo mime' icons
2819 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
2820 take focus_on_map into account
2822 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
2824 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
2825 ... must return a value
2827 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
2829 2004-05-07 Matthias Clasen <mclasen@redhat.com>
2831 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
2832 draw over the focus rectangle.
2834 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
2835 standard focus style. (#63071, Bill Haneman, idea for new
2836 style by Owen Taylor)
2838 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
2839 focus on the colorwheel via details.
2841 2004-05-06 Matthias Clasen <mclasen@redhat.com>
2845 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
2846 this no longer needed signal handler. (#141817, Paul Pogonyshev)
2848 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
2850 * gtk/gtktearoffmenuitem.h:
2851 * gtk/gtktearoffmenuitem.c: Make the tearoff
2852 functionality model/view, the tearoffmenuitem being
2853 the view and the tearoff_state property of the menu
2854 being the model. (#101185, Owen Taylor)
2856 * gtk/gtkmenu.c: Add a tearoff_state property.
2858 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
2862 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
2863 popup the submenu for items in torn off menus. (#122051)
2865 2004-05-06 Sven Neumann <sven@gimp.org>
2867 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
2868 position the title lable next to the arrow just as we do for LTR
2869 rendering. Fixes bug #141825.
2871 2004-05-06 Matthias Clasen <mclasen@redhat.com>
2873 * docs/RELEASE-HOWTO: Document the new policy of
2874 bumping version numbers after release.
2876 * configure.in: Bump version number to 2.5.0.
2878 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
2881 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
2884 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
2886 * gtk/gtkactiongroup.h:
2887 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
2888 New function to translate a string with translate_func.
2891 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
2893 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
2894 (gtk_combo_box_get_row_span_column):
2895 (gtk_combo_box_get_column_span_column): Add missing getters
2896 for readwrite properies. (#135649)
2898 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
2900 * gtk/gtkcombobox.h:
2901 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
2902 Add gtk_combo_box_get_active_text() convenience
2903 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
2905 2004-05-05 Elijah Newren <newren@math.utah.edu>
2907 Changes to support do-not-focus-on-map hint in conjunction with
2908 _NET_WM_USER_TIME (#115650):
2910 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
2913 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
2916 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
2917 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
2919 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
2920 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
2921 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
2922 Initialize the focus_on_map field to TRUE.
2924 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
2925 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
2926 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
2927 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
2928 Implementations for the various backends. The Win32 and linux-fb
2929 implementations set the focus_on_map field, but don't use it yet
2930 to actually implement noinput windows. The X implementation sets
2931 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
2933 * gdk/x11/gdkwindow-x11.h:
2934 * gdk/x11/gdkevents-x11.c (set_user_time):
2935 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
2936 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
2937 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
2938 since we want that function to be part of the public API.
2940 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
2944 * gtk/gtkiconfactory.c (icon_source_clear): Don't
2945 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
2947 2004-05-05 Matthias Clasen <mclasen@redhat.com>
2951 * gtk/gtkuimanager.c (print_node): Make the output
2952 parseable. (#141929, Sven Neumann)
2954 2004-05-05 Tor Lillqvist <tml@iki.fi>
2956 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
2957 multi-monitor offset. (#141842, John Ehresman)
2959 2004-05-04 Federico Mena Quintero <federico@ximian.com>
2961 Fixes #139562, based on a patch by Christian Neumair.
2963 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
2964 a filter_combo_hbox field to contain the filter combo.
2965 (show_filters): Show/hide the filter_combo_hbox.
2966 (create_filename_entry_and_filter_combo): Removed.
2967 (file_pane_create): Create the filter_combo_hbox here.
2969 2004-05-04 Matthias Clasen <mclasen@redhat.com>
2971 * modules/input/gtkimcontextxim.c: Fix the recent
2972 string_conversion_callback change to work on
2973 Solaris. (#141190, Padraig O'Briain)
2975 * gtk/gtkselection.c: Disable debug logging again.
2977 2004-05-03 Matthias Clasen <mclasen@redhat.com>
2979 * gtk/gtkselection.c: Make the chunk size for
2980 incremental transfers depend on the maximal request
2981 size, capped at 256k. This should allow most selections
2982 to be transferred nonincrementally, avoiding many
2983 roundtrips and protocol overhead.
2985 2004-05-03 Federico Mena Quintero <federico@ximian.com>
2987 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
2988 g_signal_new() correctly and initialize the signal fields. Fixes
2989 #141749; patch based on Michael Natterer's.
2991 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
2993 * gtk/gtkselection.c (_gtk_selection_request): Fix
2994 a debug message to show correct information.
2995 (_gtk_selection_incr_event): Make INCRemental transfer
2996 of MULTIPLE targets work. This was broken since 1997!
2998 2004-05-02 Hans Breuer <hans@breuer.org>
3000 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
3001 modify the passed in GdkSegment(s) in place, we may get
3002 them again to draw at the same place. Fixes bug #129095,
3004 (draw_segments) draw the end pixel again to get the
3005 pixmap mask right, fixes bug #126710, #130202
3007 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
3008 fixes bug #106013, John Ehresman
3010 * gtk/makefile.msc.in : don't try to link gtk.res but
3011 use gtk-win32.res (as supposed to be fixed below :)
3013 2004-05-01 Hans Breuer <hans@breuer.org>
3015 * tests/Makefile.am : tests/makefile.msc is in CVS for
3016 a long time, finally added to EXTRA_DIST : fixes bug
3017 #141334, John Ehresman
3019 2004-04-30 Matthias Clasen <mclasen@redhat.com>
3021 * === Released 2.4.1 ===
3023 * configure.in: Version 2.4.1, interface age 1.
3027 2004-04-29 Federico Mena Quintero <federico@ximian.com>
3031 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
3032 function; moved the code over from
3033 remove_bookmark_button_clicked_cb().
3034 (remove_selected_bookmarks): Now, getting a non-removable bookmark
3035 is not an error, as we may be called as a result of hitting the
3037 (shortcuts_key_press_event_cb): New handler; delete the bookmark
3038 if the user presses Backspace, Delete, or KP_Delete.
3040 2004-04-29 Matthias Clasen <mclasen@redhat.com>
3042 * gtk/gtkaction.c (closure_accel_activate): Use
3043 _gtk_action_emit_activate() instead of directly
3044 emitting the activate signal. (#141429, Jody Goldberg)
3046 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
3047 Warn people when the accelerator can not be
3048 parsed. (#141429, Jody Goldberg)
3050 2004-04-29 Matthias Clasen <mclasen@redhat.com>
3052 * tests/testentrycompletion.c (main): Add a missing
3053 cat. (#141070, Chris Sherlock)
3055 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
3056 variable. (#141022, Chris Sherlock)
3058 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
3059 cast. (#141013, Chris Sherlock)
3061 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
3062 unused variable. (#141011, Chris Sherlock)
3064 2004-04-29 Tor Lillqvist <tml@iki.fi>
3066 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
3067 leak. (#140775, John Ehresman)
3069 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
3071 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
3072 to index the cached gcs, not depth. (#139494)
3074 2004-04-28 Matthias Clasen <mclasen@redhat.com>
3076 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
3078 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3080 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
3081 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
3083 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
3085 Patch to add support for string conversion callbacks to
3086 GtkIMContextXIM (#101814)
3088 * modules/input/gtkimcontextxim.c: Set the string conversion callback
3089 if supported by the XIC.
3091 (struct _GtkIMContextXIM): Add string_conversion_callback member.
3093 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
3094 whether string conversion callback is supported.
3096 (gtk_im_context_get_ic, +set_string_conversion_callback,
3097 +string_conversion_callback): Also initialize string conversion
3098 callback, if supported, along with the IC initialization.
3100 * modules/input/imxim.c: Make "xim" module default for Thai as well.
3102 2004-04-23 Matthias Clasen <mclasen@redhat.com>
3104 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
3105 initialize targets. (#139883, John Finlay)
3107 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
3109 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
3110 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
3111 Tim-Philipp Müller)
3113 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
3114 Remove an excessive g_return_if_fail().
3116 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
3118 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
3119 _-prefix calls of gdk_x11_window_set_user_time().
3121 2004-04-22 Matthias Clasen <mclasen@redhat.com>
3123 * gtk/gtkuimanager.c (update_node): Make sure the separators
3124 used to demarkate placeholder ends don't show up on
3125 show_all(). (#140496, Murray Cumming)
3127 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
3128 work with negative increments. (#137975, Tim Gerla)
3130 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3132 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
3133 gtk_tool_button_set_icon_widget): Remove the old widget from the
3134 tool button before overwriting it with the new widget.
3136 (#140508, Todd Goyen)
3138 2004-04-22 Tor Lillqvist <tml@iki.fi>
3140 Fix the file chooser on Windows. I can't make it misbehave or
3141 crash any more now. But presumably there are still corner cases
3142 not handled. I haven't really checked behaviour of UNC paths, for
3145 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
3146 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
3149 (gtk_file_system_win32_get_parent): Like the Unix version, assert
3150 filename is absolute, and avoid one unnecessary string allocation
3153 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
3154 letters more correctly.
3156 (gtk_file_system_win32_render_icon): Assure correct syntax is used
3157 for root folder of a drive. (#137962, Morten Welinder)
3159 (filename_is_some_root): New function that accepts also root
3160 without any drive specified.
3162 (filename_is_drive_root): Rename from filename_is_root.
3164 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
3167 2004-04-21 Matthias Clasen <mclasen@redhat.com>
3169 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
3170 completion window if there are no completions anymore.
3172 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3173 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
3174 It doesn't like that. (#140642, Christian Persch)
3176 * demos/gtk-demo/expander.c (do_expander): A new demo.
3178 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
3180 2004-04-20 Matthias Clasen <mclasen@redhat.com>
3182 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
3183 sure anchored children get size allocated, even if the layout
3184 is valid. (#122323, Andrew E. Makeev)
3185 (gtk_text_view_scroll_pages):
3186 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
3187 if we already have pending scrolls. Bandaid fix for #78513.
3189 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
3191 * INSTALL.in: Update libpng and libjpeg URLs, remove
3192 note about building without since that's not the normal
3195 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
3197 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
3198 handling of SVG/non-SVG unthemed icons.
3200 2004-04-19 Morten Welinder <terra@gnome.org>
3202 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
3205 2004-04-19 Matthias Clasen <mclasen@redhat.com>
3207 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
3208 Don't stop the iteration up to the tag_root too
3209 early. (#109945, Dongho Shin)
3211 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3213 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
3214 gdk_keymap_translate_keyboard_state() handle NULL
3215 keymaps. (#139715, Torsten Schoenfeld).
3217 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3219 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
3220 reported by Pedro RODRIGUEZ, about compilation problems when
3221 Xcursor is installed in a non-standard location.
3223 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3225 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
3228 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
3229 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
3231 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
3233 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
3236 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
3237 property on user interaction.
3239 2004-04-15 Federico Mena Quintero <federico@ximian.com>
3241 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
3242 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
3244 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
3245 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
3248 2004-04-15 Matthias Clasen <mclasen@redhat.com>
3250 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
3251 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
3253 2004-04-14 Matthias Clasen <mclasen@redhat.com>
3255 * gtk/gtkcombobox.c:
3257 Make all style properties readonly.
3259 2004-04-14 Matthias Clasen <mclasen@redhat.com>
3261 * gtk/gtkcolorsel.c: Add a11y relations between the color
3262 wheel and the spin buttons. (#132745, Padraig O'Briain)
3264 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
3265 the meaning of size == -1.
3267 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
3268 a size of -1. (#137436, Brian Cameron)
3270 * gtk/gtkcombobox.c: Make the arrow and separator regular
3271 children of an hbox inside the button, and propagate state
3272 changes from the button to the cell view. (part of the fix
3273 for #138650, should also fix #137535)
3275 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
3276 state to gtk_cell_renderer_render() when prelighted. (part
3277 of the fix for #138650)
3279 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
3280 Use PRELIGHT state when appropriate. (part of the fix for
3283 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
3284 out warnings if called before the combo box is
3285 realized. (#139742, Philip Langdale)
3287 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
3289 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
3292 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
3294 * gtk/gtkpathbar.c (make_directory_button): remove spurious
3297 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
3299 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
3300 make the buttons sized by a bold label. This makes the text
3301 'swim' a little, but stops the buttons from resizing, #137210
3303 2004-04-13 Matthias Clasen <mclasen@redhat.com>
3305 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
3307 (start_element_handler): Accept separators without unique
3308 names. (#133302, Anders Carlsson)
3310 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
3311 possible accelerator gotcha when using this function. (#139641,
3314 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
3315 list nodes. (#138862, Morten Welinder)
3317 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
3319 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
3321 (gtk_tree_view_button_press): If we activated the row we don't
3322 want to grab focus back, as moving focus to another widget is
3323 pretty common, #138458
3325 2004-04-12 Federico Mena Quintero <federico@ximian.com>
3327 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
3328 documentation to all the signals.
3330 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
3332 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
3333 model if it is NULL. (#139770)
3335 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
3337 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
3338 a shadow inside the scrolled window, add it around the vbox.
3340 * gtk/gtkentryprivate.h:
3341 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3342 Return a boolean indicating whether the popup is positioned above
3343 or below. Scroll the completions to the beginning or the end,
3344 depending on the positioning.
3346 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
3347 wrap around in the entry completion popup, and allow GDK_UP to
3348 enter the popup. (#137440)
3350 2004-04-12 Matthias Clasen <mclasen@redhat.com>
3352 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
3353 there before using it.
3355 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
3357 * gtk/gtktreeprivate.h: Moved search entries into priv data.
3359 * gtk/gtktreeview.c: Prep for type-ahead support.
3361 (gtk_tree_view_destroy): Destroy the search window explicitly.
3362 (gtk_tree_view_key_press): Minor change; prep for type-ahead
3363 (gtk_tree_view_ensure_interactive_directory): New function
3364 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
3365 (gtk_tree_view_real_start_interactive_search): rework
3366 (gtk_tree_view_search_dialog_hide): ditto
3367 (gtk_tree_view_search_delete_event): ditto
3368 (gtk_tree_view_search_button_press_event): ditto
3369 (gtk_tree_view_search_key_press_event): ditto
3370 (gtk_tree_view_search_move): ditto
3371 (gtk_tree_view_search_init): ditto
3373 * gtk/gtktreeviewcolumn.c:
3374 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
3376 * tests/testfilechooser.c: (main): change
3378 2004-04-11 Hans Breuer <hans@breuer.org>
3380 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
3381 the real fix would involve just another small API breakage,
3382 i.e. gdk_spawn_* using GPid not just gint.
3384 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
3386 2004-04-10 Tor Lillqvist <tml@iki.fi>
3388 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
3389 If both Shift and CapsLock pressed, ignore the shift only for
3390 letters (that would have been affected by the CapsLock). (#139095)
3392 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
3393 seems to be even buggier now than it used to be. (#138341)
3394 Initialize _gdk_input_ignore_wintab to TRUE.
3396 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
3397 GDK_USE_WINTAB environment variable to turn on tablet support.
3399 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
3401 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
3402 (gtk_ui_manager_remove_action_group): Terminate
3403 g_object_[dis]connect() calls with NULL instead of 0.
3406 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
3408 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
3410 2004-04-07 Federico Mena Quintero <federico@ximian.com>
3414 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
3415 passed-in 'str' is not NULL.
3417 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
3418 expands "~/" or "~foo/" at the beginning of a filename.
3419 (gtk_file_system_unix_parse): Use expand_tilde() before doing
3422 * gtk/gtkfilechooserentry.c
3423 (gtk_file_chooser_entry_maybe_update_directory): Take in a
3424 force_reload argument.
3425 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
3426 returns an error, set the file_part_pos to -1.
3427 (load_directory_callback): Only populate the model if the
3428 file_part_pos is not -1.
3430 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
3432 * configure.in: Added Icelandic (is) to ALL_LINGUAS
3434 2004-04-05 Federico Mena Quintero <federico@ximian.com>
3436 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
3437 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
3439 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
3440 for G_DIR_SEPARATOR in the display_name, and err out if it is
3441 present; use the same error message as Nautilus. Fixes #136467.
3443 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
3444 new-folder button say "Create Fo_lder" rather than "Create
3445 _Folder", so that the mnemonic doesn't conflict with the "Save in
3446 _folder" label. Fixes #136975.
3448 2004-04-05 Federico Mena Quintero <federico@ximian.com>
3450 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
3451 buttons. Also, free them correctly upon failure. Based on a
3452 patch by Morten Welinder, fixes #137956.
3454 2004-04-05 Anders Carlsson <andersca@gnome.org>
3456 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
3458 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
3460 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
3461 correctly for fixed height when inserting a node, #138082
3463 2004-04-01 Federico Mena Quintero <federico@ximian.com>
3467 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
3468 "child_is_hidden" boolean argument to the "path-clicked" signal.
3470 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
3472 (make_directory_button): Take a file_is_hidden argument; put it in
3474 (_gtk_path_bar_set_path): See whether each path component path is
3476 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
3477 "path-clicked" signal.
3478 (button_clicked_cb): See if the downwards button represents a
3479 hidden file for the file_is_hidden argument in the signal
3482 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
3484 * gtk/gtkfilechooserdefault.c
3485 (gtk_file_chooser_default_select_path): If we fail to switch
3486 folders, don't try to select the path in the file system model.
3487 Also, return the result from _gtk_file_system_model_path_do().
3488 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
3489 file system model if we are asked to select a hidden file.
3490 (path_bar_clicked): Show hidden files based on whether the
3491 immediate downwards folder in the path bar is a hidden file
3493 (struct _GtkFileChooserDefault): Added fields
3494 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
3495 (create_file_list): Set an object data key of
3496 "GtkFileChooserDefault" on the tree view so that we can find the
3497 impl from the popup menu callbacks. Also, hook up to the
3498 "button-press-event" and "popup-menu" signals in the file list to
3499 bring up a popup menu.
3500 (list_popup_menu_cb): New callback.
3501 (list_button_press_event_cb): New callback.
3505 * gtk/gtkfilesystemmodel.c
3506 (_gtk_file_system_model_new): Oops, connect_object to
3509 2004-03-31 Tor Lillqvist <tml@iki.fi>
3511 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
3512 for native Win32. (#136559, J. Ali Harlow)
3514 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
3515 angles. Thanks to Tim Newsham.
3517 2004-03-29 Federico Mena Quintero <federico@ximian.com>
3521 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
3522 for an ::is_finished_loading() method and a ::finished_loading()
3523 signal at the end of the struct.
3525 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
3526 "finished-loading" signal.
3527 (gtk_file_folder_is_finished_loading): New function.
3529 * gtk/gtkfilesystemunix.c
3530 (gtk_file_folder_unix_is_finished_loading): Implement.
3532 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
3533 slot for a "finished-loading" signal.
3534 (gtk_file_system_model_class_init): Create the "finished-loading"
3536 (struct _GtkFileSystemModel): New field
3537 idle_finished_loading_source. We emit the "finished-loading"
3538 signal in an idle if the root folder was done loading right in
3539 _gtk_file_system_model_new(), so that the caller has a chance to
3540 connect to the signal.
3541 (_gtk_file_system_model_new): Connect to the normal signals of the
3542 folder even if the initial _list_children() fails. Also, see if
3543 the folder is finished loading; connect to the "finished-loading"
3545 (gtk_file_system_model_finalize): Remove the idle handler.
3547 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
3548 and connect to the model's "finished-loading" signal.
3549 (get_toplevel): New helper function.
3550 (error_message): Use get_toplevel().
3551 (trap_activate_cb): Likewise.
3552 (location_popup_handler): Likewise.
3553 (set_busy_cursor): New function.
3554 (browse_files_model_finished_loading_cb): New callback.
3556 2004-03-25 Federico Mena Quintero <federico@ximian.com>
3558 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
3559 file under the cursor; we don't need the logic from
3560 GtkFileSelection after all. Fixes #132255.
3562 2004-03-25 Federico Mena Quintero <federico@ximian.com>
3564 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
3565 location entry with the display name of the file under the cursor
3566 for Open mode, or the typed filename in Save mode.
3568 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
3570 * gtk/gtkfilesystemwin32.c
3571 (filename_is_root): Bare drive designators (eg., "c:") are
3572 no longer considered as root filenames. Fixed #137942
3574 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
3576 * gtk/gtkfilesystemwin32.c
3577 (gtk_file_system_win32_create_folder): Invert test for error in
3578 mkdir. Fixes #137945
3580 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
3582 Fixed #138004 using Federico's code from #132327.
3584 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
3585 folder_hash field to keep a list of live folder objects.
3586 (gtk_file_system_win32_init): Create the folder_hash.
3587 (gtk_file_system_win32_finalize): Destroy the folder_hash.
3588 (gtk_file_system_win32_get_folder): Ref and return an existing
3589 folder if we have it around, otherwise return a new folder object.
3590 (struct _GtkFileFolderWin32): Add a field for the parent file system.
3591 (gtk_file_folder_win32_finalize): Remove the folder from the file
3592 system's hash table.
3593 (gtk_file_system_win32_create_folder): Emit "files-added" on the
3594 newly-created folder's parent. Fixes #138004.
3596 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
3598 * gtk/gtkfilesystemwin32.c
3599 (gtk_file_system_win32_get_folder): Test that path is actually
3600 a directory and throw error if not. Fixed bug #137950
3602 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
3604 * gtk/gtkfilesystemwin32.c
3605 (gtk_file_system_win32_volume_get_display_name): Ignore empty
3606 volume labels; assume that GetVolumeInformation would fail if
3607 GetVolumeInformationW does; catches a small memory leak;
3608 pass the buffer size to GetVolumeInformationW in wide
3609 characters instead of bytes. Fixes bug #137543
3610 (list_volumes): Cope with the theoretical possibility of
3611 more than 26 logical drives. Fixes bug #137940
3612 (bookmarks_serialize): Now actually removes bookmarks.
3615 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
3617 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
3619 2004-03-21 Tor Lillqvist <tml@iki.fi>
3621 * gtk/gtkfilesystemwin32.c
3622 (gtk_file_system_win32_volume_get_base_path): Include the
3623 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
3624 NULL for a volume base path, as g_filename_to_uri() requires an
3625 absolute path, and just a drive letter and colon isn't. (#137543)
3627 2004-03-20 Hans Breuer <hans@breuer.org>
3629 * gtk/gtkfilesystemwin32.c : applied the undisputable and
3630 required [due to recent gtkfilesystem internal api semantic
3631 changes] part of patches to fix bug #137543 (Tor Lillqvist,
3634 * gdk/gdkevents-win32.c (handle_configure_event) :
3635 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
3636 GdkWindowObject::x, y with screen coords to make
3637 gdk_window_get_position () return the right thing and thus fix
3638 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
3640 2004-03-19 Federico Mena Quintero <federico@ximian.com>
3642 * Revert the patch to #137520, as 2.4.1 is for conservative bug
3643 fixes only. The patch is attached to the bug report, for
3646 2004-03-19 Morten Welinder <terra@gnome.org>
3648 * gtk/gtkfilechooserdefault.c
3649 (gtk_file_chooser_default_set_current_folder): Test existance of
3650 the path after checking for locality, if needed.
3652 2004-03-19 Federico Mena Quintero <federico@ximian.com>
3656 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
3657 for an ::is_finished_loading() method and a ::finished_loading()
3658 signal at the end of the struct.
3660 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
3661 "finished-loading" signal.
3662 (gtk_file_folder_is_finished_loading): New function.
3664 * gtk/gtkfilesystemunix.c
3665 (gtk_file_folder_unix_is_finished_loading): Implement.
3667 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
3668 slot for a "finished-loading" signal.
3669 (gtk_file_system_model_class_init): Create the "finished-loading"
3671 (struct _GtkFileSystemModel): New field
3672 idle_finished_loading_source. We emit the "finished-loading"
3673 signal in an idle if the root folder was done loading right in
3674 _gtk_file_system_model_new(), so that the caller has a chance to
3675 connect to the signal.
3676 (_gtk_file_system_model_new): Connect to the normal signals of the
3677 folder even if the initial _list_children() fails. Also, see if
3678 the folder is finished loading; connect to the "finished-loading"
3680 (gtk_file_system_model_finalize): Remove the idle handler.
3682 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
3683 and connect to the model's "finished-loading" signal.
3684 (get_toplevel): New helper function.
3685 (error_message): Use get_toplevel().
3686 (trap_activate_cb): Likewise.
3687 (location_popup_handler): Likewise.
3688 (set_busy_cursor): New function.
3689 (browse_files_model_finished_loading_cb): New callback.
3691 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
3693 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
3694 eventbox for expander. (#137564, reported by
3697 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
3699 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
3701 2004-03-17 Morten Welinder <terra@gnome.org>
3703 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
3704 volumes not actually put into the shortcut list.
3706 * tests/prop-editor.c (object_changed): Plug leak.
3708 * tests/testfilechooser.c (main): Plug some leaks and expose
3711 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
3712 object. Fixed #136652.
3714 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
3715 have no screen. Fixes #137260.
3716 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
3717 thereby fixing leak. Fixes #137259.
3719 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
3720 slider buttons have been destroyed.
3721 (gtk_path_bar_remove): Make this work for slider buttons too.
3724 2004-03-15 Morten Welinder <terra@gnome.org>
3726 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
3727 Sanitize and plug leak.
3728 (check_icon_theme): Only do something if the widget has a screen.
3730 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
3732 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3733 Move the repositioning logic from _gtk_entry_completion() popup
3734 over here. Fixes #137355, reported by Niklas Knutsson.