1 2002-03-25 Mark McLoughlin <mark@skynet.ie>
3 * gtk/gtkbindings.c: (gtk_binding_entry_add_signal),
4 kill code duplicated in gtk_binding_entry_add_signall.
6 Sun Mar 24 10:32:38 2002 Jonathan Blandford <jrb@redhat.com>
8 * gtk/gtktreemodel.c (gtk_tree_path_copy): Make path arg const, #75653
10 * gtk/gtkfontsel.c (gtk_font_selection_show_available_styles): fix
13 * gtk/gtktreeview.c (gtk_tree_view_button_press): remove the grab
14 when we emit row_activated so that listeners of this signal can
15 grab the mouse, #75629
17 2002-03-23 Havoc Pennington <hp@pobox.com>
19 * gtk/gtktextlayout.c (gtk_text_layout_real_invalidate):
20 invalidate the line containing start, even if the [start,end)
21 range is empty (just invalidate [start,end], essentially).
22 Partially fixes #72374
24 2002-03-23 Havoc Pennington <hp@pobox.com>
26 * gtk/gtktextview.c (gtk_text_view_do_popup): end any selection in
27 progress, patch from db@zigo.dhs.org, #74620
29 2002-03-23 Havoc Pennington <hp@pobox.com>
31 * gtk/gtktextview.c (gtk_text_view_move_cursor_internal): extend
32 selection for pageup/pagedown and ctrl+pageup/pagedown if
33 shift is held. more of #53934
35 2002-03-23 Havoc Pennington <hp@pobox.com>
37 * gtk/gtktextview.c (gtk_text_view_destroy_layout): disconnect
38 layout handlers earlier in the function, to avoid possible
40 (gtk_text_view_invalidate): Don't install idle handlers if
41 layout == NULL, otherwise we get problems during finalization
42 since clearing the buffer invalidates and puts the idle handlers
43 back after we destroy the layout. #74660
44 (gtk_text_view_ensure_layout): Install the validation handlers
45 right after creating the layout.
47 * gtk/gtktexttagtable.c (foreach_unref): call
48 _gtk_text_buffer_notify_will_remove_tag(), #75126
50 2002-03-22 Havoc Pennington <hp@pobox.com>
52 * gdk/x11/gdkfont-x11.c (gdk_fontset_load): add more explanatory
53 text to the error message about missing charsets, and use
54 g_printerr() not g_warning() since this is typically not a
55 programming error (we do not export any API to ask whether
56 a font set will have missing charsets so apps realistically can't
57 do anything other than try the gdk_fontset_load())
59 * gtk/gtktextview.c (gtk_text_view_key_press_event): return FALSE
60 if the text view isn't editable and the user presses Return,
61 so default buttons and such can be activated, #74937
63 * gtk/gtktextbuffer.c (paste_from_buffer): don't insert
64 if the insertion point is not editable and the paste
65 is interactive, #74125
67 * gtk/gtkwindow.c (gtk_window_move_resize): enhance the #if 0
70 * gtk/gtktextbuffer.c (cut_or_copy): only remove the previous
71 cut/copied data right before replacing it, when we know we are
72 going to replace it. Fixes #74049
74 2002-03-22 Richard Hult <rhult@codefactory.se>
76 * gdk/gdkevents.c (gdk_event_get_root_coords): Fix typo, where x
77 value was assigned to both x and y.
79 Fri Mar 22 11:29:11 2002 Owen Taylor <otaylor@redhat.com>
81 Partial fix for problem where keypad keys acted
82 as shift-arrows in an entry rather than arrows (#74327)
84 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Sort lookup
85 results by number of modifiers in the entry. Fixes
86 problem where if a key matched both modified and unmodified
87 key bindings ... e.g., the distinguishing key binding
88 was consumed, then it was random which was used.
90 * gtk/gtkbindings.c (gtk_binding_entries_sort_patterns):
91 Catch the case where there are multiple entries from the
92 same bindingset (with different modifiers), and use only
93 the first entry, which, with the change in _gtk_key_hash_lookup()
94 will be the preferred value.
96 Fri Mar 22 10:56:19 2002 Owen Taylor <otaylor@redhat.com>
98 * gtk/gtkaccelmap.c (gtk_accel_map_save_fd): Fix memory
99 leak. (#74400, Morten Welinder.)
101 * gtk/gtkaccelmap.c: Properly handle short returns from
102 write() calls. (Handling EINTR isn't enough... that only
103 handles the case where you were interrupted before you
104 wrote a single byte.)
106 * gdk/linux-fb/gdkmouse-fb.c gdk/linux-fb/gdkkeyboard-fb.c:
107 Robustify against short returns from write() calls.
109 Fri Mar 22 10:12:10 2002 Owen Taylor <otaylor@redhat.com>
111 * gtk/gtktextview.c (gtk_text_view_paint): Change
112 G_BREAKPOINT() to g_assert_not_reached ().
113 (#75865, Ashok Venkiteswaran)
115 2002-03-22 Tor Lillqvist <tml@iki.fi>
117 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Don't clear
118 all of the pen_style, just the PS_STYLE_MASK. Seems to fix #74441,
119 but that is just the special case of one-pixel wide one-pixel
120 on-off dotted lines. To fully implement generic X11 style dashed
121 lines a major rewrite would be needed.
123 2002-03-21 Matthias Clasen <maclas@gmx.de>
125 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Trivial typo
126 fix. (Vitaly Tishkov, #75726)
128 Thu Mar 21 10:04:05 2002 Owen Taylor <otaylor@redhat.com>
130 * gdk/gdkwindow.c (gdk_window_real_get_depth): Remove
131 some left over debugging code with a G_BREAKPOINT()
134 Wed Mar 20 19:33:31 2002 Owen Taylor <otaylor@redhat.com>
136 * gtk/gtkcalendar.c (gtk_calendar_main_button): When
137 changing months when the user clicks on a prev-month
138 or next-month day, focus and select the new day.
139 Ignore double clicks on prev-month, next-month days.
140 (Based on suggestions from Andras Salamon, #74173)
142 * gtk/gtkcalendar.c: Implement the focused/unfocused
143 selected color change.
145 2002-03-20 Alex Larsson <alexl@redhat.com>
147 Patches from Carlo E. Prelz <fluido@fluido.as>
148 Now gtkfb at least compiles and mostly works. The keyboard
149 stuff needs more loving.
151 * gdk/linux-fb/gdkkeyboard-fb.c (xlate_get_for_keyval,
152 xlate_get_for_keycode, raw_get_for_keyval, raw_get_for_keycode):
153 At least set the out parameters for these calls.
155 * gdk/linux-fb/gdkmain-fb.c:
156 (gdk_pointer_grab_info_libgtk_only, gdk_keyboard_grab_info_libgtk_only):
157 Implement new functions.
159 Wed Mar 20 19:00:03 2002 Owen Taylor <otaylor@redhat.com>
161 * gtk/gtkentry.c (gtk_entry_set_text): Short-circuit
162 the text to the exact same thing, so we don't
163 unexpectedly change the selection or cursor position.
164 (#74290, John Ellis.)
166 Thu Mar 21 00:05:14 2002 Kristian Rietveld <kris@gtk.org>
168 * gtk/gtktreeview.c (gtk_tree_view_get_background_area),
169 (gtk_tree_view_get_cell_area): fix logic (fixes #74235, #73593)
171 Wed Mar 20 17:11:51 2002 Owen Taylor <otaylor@redhat.com>
173 * gtk/gtkrc.c: Patch from Richard Hestilow to fix
174 gtk-font-name changes for widgets that get the actual
175 default style. (#73709)
177 Wed Mar 20 22:59:23 2002 Kristian Rietveld <kris@gtk.org>
179 * gtk/gtkrbtree.[ch]: add _gtk_rbtree_set_fixed_height()
181 * gtk/gtktreeprivate.h: add fixed_height_check field
183 * gtk/gtktreeview.c (gtk_tree_view_init): initialize
184 scroll_sync_timer and fixed_height_check
185 (do_validate_rows): add fixed_height_check. If all validated rows
186 in the first cycle have the same height, then we set that height for
187 the entire tree. This is some sort of 'fake' optimization, but helps
188 a lot for the common case. We keep validating the entire tree in
189 the background though.
190 (gtk_tree_view_set_model): reset fixed_height_check
192 Wed Mar 20 16:36:08 2002 Owen Taylor <otaylor@redhat.com>
194 * gtk/*.c: Patch from Erwann Chenede, #73900 fixing
195 a lot of warnings with Forte CC, mostly implicit
196 casts between void * and function pointers.
198 * gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's
199 state field is not a GdkModifierType. (Also #73900)
201 Wed Mar 20 12:35:22 2002 Owen Taylor <otaylor@redhat.com>
203 * gtk/gtkwidget.c (gtk_widget_grab_default): Remove
204 leftover notification of has-default. (#75508, Jacob
207 Wed Mar 20 12:27:07 2002 Owen Taylor <otaylor@redhat.com>
209 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Allow
210 arrow keys as accelerators, as long as some modifier
213 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Fix
214 incorrect example in the docs.
216 Wed Mar 20 12:06:30 2002 Owen Taylor <otaylor@redhat.com>
218 * gtk/gtkwidget.c (gtk_widget_set_child_visible):
219 Fix segfault when widget->parent is NULL.
220 (#75615, Alexey A. Malyshev)
222 Wed Mar 20 11:32:07 2002 Owen Taylor <otaylor@redhat.com>
224 * gtk/gtkentry.c: Improve test to prevent infinite
225 loop. (#74952, Thomas Leonard)
227 * gtk/gtkmenushell.c (gtk_real_menu_shell_cycle_focus):
228 Fix warning when toplevel menu shell isn't a menu
229 bar. (Thomas Leonard, #75602)
231 Wed Mar 20 11:00:59 2002 Owen Taylor <otaylor@redhat.com>
233 * configure.in: Use $PKG_CONFIG, not pkg-config.
234 (LEE Sau Dan, #75572)
236 Wed Mar 20 10:55:56 2002 Owen Taylor <otaylor@redhat.com>
238 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Fix assignment
239 of time in scroll events. (Sven Neumann, #75574)
241 2002-03-20 Tor Lillqvist <tml@iki.fi>
243 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window): Use
244 gdk_window_get_toplevel(), as it is the top-level windows that are
247 * gdk/win32/gdkwin32.h: Don't include gdkinternals.h.
249 2002-03-19 jacob berkman <jacob@ximian.com>
251 * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
252 gtk_combo_func() returns NULL (bug #75464)
254 2002-03-18 jacob berkman <jacob@ximian.com>
256 * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the
257 correct min/max values for the ratio property (fixes #75331)
259 Mon Mar 18 11:55:03 2002 Owen Taylor <otaylor@redhat.com>
261 * gtk/gtkimmulticontext.c (gtk_im_multicontext_get_slave):
262 Patch from Yao Zhang fixing reference count leak.
264 * gtk/gtkentry.c (gtk_entry_key_release): if (entry->editable),
265 not if (!entry->editable).
267 Mon Mar 18 11:09:17 2002 Owen Taylor <otaylor@redhat.com>
269 * gdk/x11/gdkwindow-x11.c (gdk_window_set_override_redirect):
270 Fix backwards conditional. (#75019, Dan Winship.)
272 Sun Mar 17 01:11:16 2002 Kristian Rietveld <kris@gtk.org>
274 * gtk/gtktreeview.c (gtk_tree_view_size_request): use
275 do_validate_rows instead of validate_rows_handler (fix by
278 Sat Mar 16 23:54:56 2002 Kristian Rietveld <kris@gtk.org>
280 * gdk/x11/gdkwindow-x11.c (gdk_window_set_static_bit_gravity): just
281 return when we have an input_only window (fix by Owen Taylor)
283 * gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): add
286 * gtk/gtktreeview.c (install_scroll_sync_handler): new function,
287 (scroll_sync_handler): ditto,
288 (gtk_tree_view_unrealize): take scroll_sync_timer into account
289 (gtk_tree_view_row_deleted): install scroll_sync_timer instead of
290 calling top_row_to_dy/dy_to_top_row directly
291 -- this greatly speeds up clearing the model (#73199)
293 * gtk/gtktreemodelsort.c
294 (gtk_tree_model_sort_convert_path_to_child_path): fix up this function,
295 for some reason I really screwed it up (fixes #74663)
297 2002-03-16 Sven Neumann <sven@gimp.org>
299 * configure.in (GDK_PIXBUF_DEP_CFLAGS) (GDK_PIXBUF_XLIB_DEP_CFLAGS)
300 (GDK_DEP_CFLAGS) (GTK_DEP_CFLAGS): include CFLAGS from gthread-2.0
301 so that the libs work correctly in a threaded environment.
303 Fri Mar 15 12:51:42 2002 Jonathan Blandford <jrb@redhat.com>
305 * gtk/gtktreeviewcolumn.c
306 (gtk_tree_view_column_new_with_attributes): add example to docs,
307 as people are seeming to have trouble with this function.
309 2002-03-15 Tor Lillqvist <tml@iki.fi>
311 * configure.in: Set MATH_LIB to empty also on Win32.
313 Fri Mar 15 15:37:01 2002 Owen Taylor <otaylor@redhat.com>
315 * gdk/x11/gdkdrawable-x11.c (convert_to_format):
316 Fix byte shift arithmetic for big-endian. (Tracked
317 down with help from Tuomas Kuosmanen)
319 Fri Mar 15 11:28:41 2002 Jonathan Blandford <jrb@redhat.com>
321 * gtk/gtktreeview.c (gtk_tree_view_insert_column_with_data_func):
322 make args const, 74159
323 (gtk_tree_view_insert_column_with_attributes): ditto
325 * gtk/gtktreeviewcolumn.c
326 (gtk_tree_view_column_cell_process_action): remov unused variables.
328 Fri Mar 15 13:31:51 2002 Soeren Sandmann <sandmann@daimi.au.dk>
330 * gtk/gtkmenu.c (gtk_menu_leave_notify): Fix test for "active
333 2002-03-15 Padraig O'Briain <padraig.obriain@sun.com>
335 * gdk/x11/gdkkeys-x11.c (update_keymaps): Fudge keymap to have lower
336 upper case variants if there is only a single keysym per keycode and
337 the key symbol has upper and lower case variants (#74512)
339 Thu Mar 14 17:09:52 2002 Owen Taylor <otaylor@redhat.com>
341 * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
342 improbable reentrancy problem if a window is destroyed
343 while updates are being processed on another window. (Noticed
344 by Michael Meeks, #74708)
346 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
348 * gtk/gtktreemodelsort.c
349 typo in docs for gtk_tree_model_sort_convert_iter_to_child_iter() fixed
352 Thu Mar 14 11:17:18 2002 Owen Taylor <otaylor@redhat.com>
354 * gtk/gtkkeyhash.c (_gtk_key_hash_remove_entry): When
355 removing keys from the key hash, reinsert the right list
356 back into the hash. (Dave Camp, #74571)
358 Wed Mar 13 17:17:40 2002 Owen Taylor <otaylor@redhat.com>
360 * gtk/gtkobject.h: Remove left-over GTK_OBJECT_CONNECTED
361 macro that was defined in terms of the now-gone GTK_CONNECTED
362 flag. (Seth Burgess, #74028)
364 Wed Mar 13 17:11:10 2002 Owen Taylor <otaylor@redhat.com>
366 * gtk/gtkaccelgroup.c (accel_group_weak_ref_detach): Unset
367 the acceleratable_groups qdata because qdata isn't removed
368 on ->dispose but rather on ->finalize. (#74569, found
371 Tue Mar 12 23:14:23 2002 Jonathan Blandford <jrb@redhat.com>
373 * gtk/gtktreeselection.c (gtk_tree_selection_unselect_iter): Fix
376 Sat Mar 9 18:23:25 2002 Richard Hestilow <hestilow@ximian.com>
378 * gtk/gtkimage.c (gtk_image_set_from_filename): Allow NULL
381 Tue Mar 12 10:50:09 2002 Owen Taylor <otaylor@redhat.com>
383 * modules/input/gtkimcontextxim.c (gtk_im_context_xim_filter_keypress):
384 Fix incorrect return value, filter out returns of 0x7f for
385 the delete key. (#74179, Kang Jeong-He)
387 Mon Mar 11 23:42:11 2002 Jonathan Blandford <jrb@redhat.com>
389 * gtk/gtktreemodel.c (gtk_tree_model_foreach): fix totally broken
392 2002-03-11 Matthias Clasen <maclas@gmx.de>
394 * gtk/gtkitemfactory.c (gtk_item_factory_add_foreign): Document
395 gtk_{menu_item,widget}_set_accel_path() as the recommended API.
398 2002-03-11 James Henstridge <james@daa.com.au>
400 * configure.in: set CCAS and CCASFLAGS to get automake 1.6
401 compatibility without breaking things for people using 1.4.
403 Sun Mar 10 21:04:30 2002 Jonathan Blandford <jrb@redhat.com>
405 * gtk/gtktreeview.c (gtk_tree_view_button_press): finally get the
408 Mon Mar 11 01:25:14 2002 Kristian Rietveld <kris@gtk.org>
410 * gtk/gtktreeview.c (gtk_tree_view_button_press): compare path with
411 cursor path and not with the selected iter in the 'decide to edit'