1 2005-11-10 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
8 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
9 (#163851, Richard Hult)
11 2005-11-10 Michael Natterer <mitch@imendio.com>
13 Applied patch from maemo-gtk that addresses many issues wrt
14 display migration and display closing (bug #85715).
16 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
17 default display to NULL when it's closed. Instead set the most
18 recently opened display as new default (if one exists).
20 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
23 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
24 exist before unrefing them.
26 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
27 is closed, allow destruction of the root window.
29 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
30 dispose(), free stuff that was leaked before.
32 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
33 the xsettings_client still exists before destroying it.
35 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
38 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
39 dispose() implementation.
41 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
42 dispose() and check if it still exists before unrefing it. Set
43 their pointers to NULL/None *after* upchaining in dispose(),
44 because X11 implementations of members of the parent class still
45 need them for their own destruction.
47 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
48 was g_error()ing when finalizing a visual.
50 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
51 get_clipboard_widget() because it would create the widget if it
52 doesn't exist. Use g_object_get_data() directly instead.
54 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
57 2005-11-10 Simos Xenitellis <simos@gnome.org>
59 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
61 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
63 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
64 to render its arrows insensitive when the adjustment is in
65 its min or max position. this makes range arrow behaviour
66 consistent with spin button behaviour. (#321056)
68 2005-11-09 Tor Lillqvist <tml@novell.com>
71 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
72 the GdkDebugFlag enum.
74 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
75 this file instead of MISC. Now asking for MISC will give mainly
76 window manipulation debugging output with the Win32 backend.
78 2005-11-09 Tor Lillqvist <tml@novell.com>
80 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
82 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
83 function which was used only in one place.
85 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
87 (gdk_window_set_geometry_hints): If we have identical minimum and
88 maximum size hints, remove the resize and maximize
89 decorations/functions. (#104514)
91 If we have a maximum size hint, remove the maximize
92 decoration/function but ensure the resize decoration/function is
93 available. Otherwise ensure both resize and maximize
94 decorations/functions are there.
96 (set_or_clear_style_bits): Factored out common code from
97 gdk_window_set_decorations() and gdk_window_set_functions().
99 Hack the window style setting once more: Only touch the window
100 style bits corresponding to the GdkWMDecoration or GdkWMFunction
101 parameter bitmasks. Hopefully this finally is the correct thing to
102 do. We used to clear all other bits than those that were being
103 set, or set all other bits than those that were being cleared.
105 Take into account that adding or removing decorations leaves the
106 window's outer size unchanged, i.e., the client area's size and
107 position change. This is apparently not what we want, so change
108 also the window's (outer) position and size appropriately so that
109 the client area's position and size stay constant.
111 gtk-demo's color selector dialog is now non-resizable like on X11
112 (I tested with metacity in GNOME). Torn off menus are shrinkable
113 vertically but have a maximum size, and are not maximizable or
114 minimizable, like on X11.
116 (gdk_window_set_decorations, gdk_window_set_functions): Let
117 set_or_clear_decorations() do most of the job.
119 * gdk/win32/gdkprivate-win32.h: Remove declaration of
120 _gdk_win32_get_adjusted_client_rect().
122 2005-11-09 Tor Lillqvist <tml@novell.com>
124 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
125 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
126 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
127 type hint. Implement gdk_window_get_type_hint() by just returning
130 2005-11-09 Tor Lillqvist <tml@novell.com>
132 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
133 Remove code that has been permanently ifdeffed out for two years.
135 2005-11-08 Matthias Clasen <mclasen@redhat.com>
137 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
138 finalizing a gc. (#320789, Nickolay V. Shmyrev)
140 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
141 icons if they would make the request large enough to cause
142 Xlib to loose the connection. (#320909, Claudio Saavedra)
144 2005-11-08 Michael Natterer <mitch@imendio.com>
148 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
149 extracted from maemo-gtk). Fixes bug #320872.
151 2005-11-07 Matthias Clasen <mclasen@redhat.com>
153 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
154 looks the bookmark label when reordering. (#320720, Jeremy Cook)
156 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
157 Don't grab focus when a slider button is pressed, instead, use
158 a bit in the pathbar struct to determine whether to scroll up
159 or down. (#314486, Carlos Garnacho)
161 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
162 Don't popup the completions if the focus has already been
163 moved somewhere else. (#319914, Christian Persch)
165 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
166 Raise the drag_window after reconfiguring the
167 toolbar. (#320803, Christian Persch)
170 * gtk/gtkfilechooserbutton.h:
171 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
172 with setter and getter. (#318945, Christian Persch)
174 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
176 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
178 2005-11-07 Matthias Clasen <mclasen@redhat.com>
180 * configure.in: Adjust to the stock icon changes.
182 2005-11-07 Tor Lillqvist <tml@novell.com>
184 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
185 Correct the calculation of maskstride. (#320152, Peter Zelezny)
187 2005-11-06 Michael Natterer <mitch@imendio.com>
189 * gtk/Makefile.am (icons): fixed rule to actually create the
190 symlinks, erroring out if anything goes wrong.
192 2005-11-06 Tor Lillqvist <tml@novell.com>
194 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
195 target exists on Win32. First rename the target temporarily, then
196 if the renaming of the source to target fails, restore the
197 original name for the target.
199 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
201 2005-11-06 Tor Lillqvist <tml@novell.com>
203 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
204 like pixbuf_to_hbitmaps_normal().
205 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
206 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
207 setting the G_WIN32_PRETEND_WIN9X environment variable.
209 2005-11-06 Tor Lillqvist <tml@novell.com>
211 Make icon masks work on Win98 (#320152, Peter Zelezny)
213 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
214 parameter for the depth of the bitmap, so that this function can
215 be used to create 1-bit bitmaps, too.
216 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
217 and initialize it properly.
219 2005-11-04 Matthias Clasen <mclasen@redhat.com>
221 Store builtin stock icons in an icon cache, instead of
222 populating a hash table with pixbufs at startup, to save both
223 memory and startup time.
225 * gtk/stock-icons/*: Reorganize the icons in a directory structure
226 suitable for gtk-update-icon-cache, and rename them to match the
229 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
230 add _gtk_icon_cache_has_icon_in_directory().
232 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
233 to store the contents of the icon cache in a C header.
235 * gtk/gtkbuiltincache.h: Generated private header which contains
236 the icon cache for the builtin icons.
238 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
239 icons, and use that in addition to the hash table whenever
240 builtin icons are searched.
242 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
243 use it for static stock ids.
244 (get_default_icons): Don't add the builtin
245 icons to the icon theme, just register the stock ids.
246 (render_fallback_image): Take the fallback image out of the
249 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
250 the necessary machinery to rebuild gtkbuiltincache.h.
252 2005-11-04 Michael Natterer <mitch@imendio.com>
254 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
255 from maemo-gtk that changes the mtime check for rc files from
256 '>' to '!=', otherwise theme changes go unnoticed when turning
257 back the clock (Tommi Komulainen).
259 2005-11-04 Tor Lillqvist <tml@novell.com>
261 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
264 2005-11-03 Tor Lillqvist <tml@novell.com>
266 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
267 the Win32 backend, check that GdkDisplay* parameters are equal to
268 _gdk_display instead of using the unnecessarily general
271 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
272 color bitmap to have "color" in their name, for similarity with
273 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
274 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
275 the mask bitmap's contents, ones for those pixels in the color
276 bitmap where the alpha is zero, zero for other pixels. We used to
277 use an uninitialized mask bitmap! This meant that icons and
278 cursors created presumably worked more or less by accident.
279 Totally blank icons with zero alpha everywhere (as used by
280 gtktrayicon.c) definitely did not work as expected.
282 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
284 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
285 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
286 necessary and can be removed from CVS. It has never been mentioned
287 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
288 are used on Win32. One label widget is used (but never shown) as
289 gtk_widget_render_icon() needs a widget.
291 Ifdefs used as necessary in several places. It might be cleaner to
292 split out the backend-specific parts to separate files, or at
293 least collect them into separate blocks in the file.
295 (wndproc): New function. Window procedure to monitor mouse events
296 in the system tray icon. Call gtk_status_icon_button_press() as
298 (create_tray_observer): New function. Creates a hidden window that
299 only serves as a tray icon message observer.
301 * tests/teststatusicon.c (icon_activated): Position the dialog
302 with GTK_WIN_POS_CENTER.
303 (do_quit): New function, hide and unref the GtkStatusIcon, and
304 call gtk_main_quit().
305 (popup_menu): Add a Quit menu item that calls do_quit().
307 2005-11-02 Tor Lillqvist <tml@novell.com>
309 * gdk/win32/gdkcolor-win32.c
310 * gdk/win32/gdkscreen-win32.c
311 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
312 fixes. Remove superfluous test for GdkWindow* parameters being
313 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
314 GdkScreen and one GdkDisplay in the Win32 backend, use those
315 variables instead of the getter functions. For GdkDisplay* and
316 GdkScreen* parameters, check that they are equal to the
317 corresponding singleton variables instead of the more general
318 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
320 2005-11-02 Matthias Clasen <mclasen@redhat.com>
322 * gtk/gtktextview.c: Remove some g_return_if_fail() from
323 static functions, replace some others by g_assert().
325 * gtk/gtktextview.c (selection_motion_event_handler)
326 (gtk_text_view_start_selection_drag): Keep track of the original
327 selection boundaries during a drag selection, in order to correctly
328 decide when to extend or shrink the selection. (#320167,
329 reported by Arvind S N, patch by Paolo Borelli)
331 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
332 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
333 manual offset calculations by g_utf8_offset_to_pointer().
334 (#320360, Paolo Borelli)
336 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
338 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
339 nodes via the g_slice_*() API.
340 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
342 2005-11-01 Tor Lillqvist <tml@novell.com>
344 * gdk/win32/gdkprivate-win32.h
345 * gdk/win32/gdkglobals-win32.c
346 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
347 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
348 their declarations, definitions and assignments into a more
349 logical and consistent order.
351 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
352 CF_ prefix for the predefined clipboard format names. Put quotes
353 around registered format names to distinguish them.
355 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
356 immediately with a warning if the property type is STRING, TEXT,
357 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
358 should never pretend to handle on Win32. Handle only UTF8_STRING
359 here, other formats with delayed rendering. Use \uc1 instead of
360 \uc0 when generating Rich Text Format for easier testability on
361 XP, where WordPad misinterprets \uc0 encoded characters. Add more
362 GDK_NOTE debugging output for Clipboard operations.
364 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
365 (gdk_selection_convert): Don't pretent to handle STRING, just
366 UTF8_STRING. Streamline error handling, don't unnecessarily have a
367 GError which then isn't used for anything anyway if it gets set.
368 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
369 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
371 * config.h.win32.in: Sync with what configure produces.
373 * configure.in: Don't look for X_PACKAGES unless building for
374 x11. (#313986, John Ehresman)
376 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
378 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
379 Wondered why there was no ku there before??
381 2005-10-28 Matthias Clasen <mclasen@redhat.com>
383 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
384 window to the toplevels window group. (#319912, Christian Persch)
386 2005-10-28 Kristian Rietveld <kris@gtk.org>
388 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
391 2005-10-28 Matthias Clasen <mclasen@redhat.com>
393 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
394 drag cursors. (#319200, Federico Mena Quintero)
396 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
397 Shift-G to go to the previous match, like firefox. (#320061, Christian
400 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
401 C99ism. (#320000, Kazuki Iwamoto)
403 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
404 stars. (#319985, Bastien Nocera)
406 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
407 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
409 2005-10-26 Michael Natterer <mitch@imendio.com>
413 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
414 make sure that setting any of pixbuf/stock-id/icon-name resets the
415 others because they are mutually exclusive, and that unsetting any
416 of them only resets the pixbuf and nothing else. Also added
417 some missing g_object_notify().
419 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
420 g_value_set_object().
422 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
423 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
424 g_object_notify ("pixbuf").
426 2005-10-27 Matthias Clasen <mclasen@redhat.com>
428 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
429 careful about initializing cell_area. (#319382, Tommi
432 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
433 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
435 * demos/gtk-demo/clipboard.c (paste_received): Only set the
436 text if it is not NULL. (#319930, Thomas Klausner)
438 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
439 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
441 2005-10-26 Matthias Clasen <mclasen@redhat.com>
443 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
444 * gtk/gtkthemes.c (gtk_theme_engine_load):
445 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
446 when dlopening modules. (#319557, Laszlo Peter)
448 2005-10-26 Matthias Clasen <mclasen@redhat.com>
450 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
451 segments when determining text direction. (#319065, Tommi Komulainen)
453 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
454 on duplicate destroy. (#318953, Gustavo Carneiro)
456 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
457 Point out that destroy-with-parent is a bad idea for the dialog
458 passed to this function. (#318943, Christian Persch)
460 * */Makefile.am: use $(GLIB_MKENUMS) instead of
461 glib-mkenums. (#318582, Damien Carbery)
463 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
464 docs. (#317682, Christian Neumair)
466 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
467 seem to affect the placement of the data in the readonly
468 section, and causes problems with some compilers. (#317844)
470 2005-10-25 Matthias Clasen <mclasen@redhat.com>
472 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
473 Fix some issues with background drawing in RTL. (#318781,
477 * tests/testentrycompletion.c: Apply a patch by Christian
478 Persch to add property editors.
480 * gtk/gtkstatusicon.c: Emit activate on single-click,
481 not on double-click, change proposed by Milosz Derezynski.
483 2005-10-25 Kristian Rietveld <kris@gtk.org>
485 Fixes #311955, reported by Markku Vire; and a lot more.
487 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
488 Levels can now have invisible nodes cached, functions have been
489 rewritten/refactored to take this into account; also the logic in
490 some functions has been corrected.
492 Each referenced node now references all visible children or a single
493 invisible child, in order to be able to monitor all changes in the
494 child model required for correct operation.
496 When a virtual root is set, all nodes on the virtual root level are
499 At last, a bunch of random bug fixes and comment updates.
501 2005-10-25 Matthias Clasen <mclasen@redhat.com>
503 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
504 more docs. (#319722, Paolo Borelli)
506 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
507 initialization of screen_x11->xft_rgba more explicit. (#319627,
510 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
511 in a blurb. (#319499, Francisco Javier F. Serrador)
513 2005-10-24 Matthias Clasen <mclasen@redhat.com>
515 Add settings to hide the input method and Unicode control character
516 submenus in the context menus of GtkEntry and GtkTextView.
518 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
520 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
522 * gtk/gtktextview.c (popup_targets_received):
523 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
525 2005-10-24 Kristian Rietveld <kris@gtk.org>
527 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
528 row-has-child-toggled when the level is not in the cache does not
529 make sense. (This bug probably crept in during the early stages
530 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
532 (gtk_tree_model_sort_real_unref_node): only get the child iter
533 when we will actually also use it.
535 2005-10-22 Michael Natterer <mitch@imendio.com>
537 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
538 widget being realized, in addition to being visible, to avoid
539 running into precondition check in gtk_tree_view_get_cell_area().
542 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
544 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
545 Experimentally, scrollbar steppers can shrink to 8 pixels on
546 Win32. Reflect that in the theme.
547 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
548 there is a 1-pixel border between a scrollbar and its child
549 in ScrolledWindows on Win32. Reflect that in the theme.
551 2005-10-20 Matthias Clasen <mclasen@redhat.com>
553 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
554 for the selection window. (#318806, Alex Larsson)
556 2005-10-18 Federico Mena Quintero <federico@ximian.com>
560 * tests/autotestfilechooser.c
561 (test_button_folder_states_for_action): Test that we have either
562 $cwd or the explicitly-set folder.
563 (test_reload_sequence): Likewise.
565 * gtk/gtkfilechooserdefault.c
566 (gtk_file_chooser_default_get_current_folder): If our reload_state
567 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
569 2005-10-14 Tor Lillqvist <tml@novell.com>
571 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
572 It didn't really do anything useful, and was just confusing and
573 incomplete. Comments claimed we don't do delayed rendering, but in
574 fact we do, for images. (The delayed rendering code has other
575 problems, though, see #168173.) The clipboard viewer code was
576 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
577 the message when necessary). It was just test code, it said so in
578 a comment. Add something similar back later if necessary.
580 (_win32_on_clipboard_change,
581 _gdk_win32_register_clipboard_notification): Remove.
583 (gdk_display_supports_selection_notification,
584 gdk_display_request_selection_notification): Always just return
585 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
587 2005-10-13 Tor Lillqvist <tml@novell.com>
589 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
590 Alt-Enter specially. It does not have any special meaning and
591 should be passed on to the application. (#318378, Tim Evans)
593 2005-10-13 Tor Lillqvist <tml@novell.com>
595 Set visual depth to 24 for 32 bits-per-pixel devices on
596 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
597 optimized composite_0888() function rather than the slower image
598 dithering functions to draw pixbufs (#313993, John Ehresman)
600 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
601 _gdk_windowing_get_bits_for_depth() to initialize
602 GdkImage::bits_per_pixel.
603 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
605 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
606 _gdk_windowing_get_bits_for_depth() to initialize
607 BITMAPINFOHEADER::biBitCount.
609 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
610 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
613 2005-10-12 Stefan Kost <ensonic@users.sf.net>
615 * demos/gtk-demo/appwindow.c: (about_cb):
616 use PACKAGE_VERSION,bump year (#318654)
618 2005-10-11 Matthias Clasen <mclasen@redhat.com>
620 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
621 toggle here with the matching on toggle if it immediately follows.
622 This is a common case, and handling it here prevents quadratic blowup
623 in cleanup_line() below. (#317125)
625 * gtk/gtktextsegment.h:
626 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
627 the character counts into this function instead of computing them
630 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
632 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
634 * gtk/gtkfilechooserdefault.c
635 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
636 when the shortcut already exists in the sidebar. (#147521)
638 2005-10-09 Matthias Clasen <mclasen@redhat.com>
640 * tests/testcombo.c: Demonstrate how to use custom widgets in
643 2005-10-07 Federico Mena Quintero <federico@ximian.com>
647 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
648 the the result of gtk_file_chooser_get_folder() is NULL or
649 non-NULL at the right times. Log the tests.
650 (test_button_folder_states): New test for the initial states of
651 the current folder in GtkFileChooserButton.
652 (main): Test that the number of warnings/errors/critical errors is
655 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
656 Clarify the documentation on when this can return NULL.
657 (gtk_file_chooser_get_current_folder_uri): Likewise.
659 * gtk/gtkfilechooserbutton.c (struct
660 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
661 we use it to keep track of whether a folder has been set.
662 (gtk_file_chooser_button_map): Implement. If no folder has been
663 loaded before, we at least try to load $cwd here.
664 (gtk_file_chooser_button_constructor): If the construct-time
665 dialog already has a folder set, turn on our folder_has_been_set
667 (dialog_current_folder_changed_cb): Turn on our
668 folder_has_been_set flag.
670 2005-10-07 Michael Natterer <mitch@gimp.org>
672 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
673 PROFILE_FILE_CHOOSER because they break compilation after the
674 removal of <unistd.h>.
676 2005-10-07 Matthias Clasen <mclasen@redhat.com>
678 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
679 by moving it out of the profiling ifdef.
681 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
682 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
684 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
685 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
688 2005-10-06 Matthias Clasen <mclasen@redhat.com>
691 * gtk/gtktextbuffer.h:
692 * gtk/gtktextbuffer.c: Add a readonly has-selection property
693 with a getter. (#318161, Paolo Borelli)
695 2005-10-05 Matthias Clasen <mclasen@redhat.com>
697 * README.in: Start collecting release notes for 2.10.
699 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
700 leak fix, since the assertion failures were traced to
701 an xchat bug. (#314696)
703 * gtk/gtkstyle.c (gtk_style_detach):
704 (gtk_style_attach): Documentation improvements.
705 (gtk_style_detach): Assert that the attach_count is > 0.
707 2005-10-04 Federico Mena Quintero <federico@ximian.com>
709 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
710 shortcut position, not a ShortcutsIndex, to make the function more
712 (home_folder_handler): Pass the resolved index to
713 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
714 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
715 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
716 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
717 make the respective key switch to the first, second, ..., tenth
719 (quick_bookmark_handler): Implement.
721 2005-10-04 Federico Mena Quintero <federico@ximian.com>
723 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
724 Desktop; just use their real names on the file system for the
727 * gtk/gtkfilechooserdefault.c
728 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
729 binding signal, and bind it to M-d by default.
730 (desktop_folder_handler): Implement the default handler.
731 (home_folder_handler): Use a helper function.
732 (switch_to_shortcut): New helper function.
733 (shortcuts_append_home): Don't special-case the name of "Home";
734 just use the folder name.
736 2005-10-04 Tor Lillqvist <tml@novell.com>
738 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
739 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
741 2005-10-04 Matthias Clasen <mclasen@redhat.com>
743 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
744 from yesterday, since it leads to assertion failures. (#317879,
747 2005-10-03 Matthias Clasen <mclasen@redhat.com>
749 * gtk/gtkcalendar.c (gtk_calendar_init): Call
750 calendar_compute_days() after setting priv->week_start.
752 2005-10-03 Matthias Clasen <mclasen@redhat.com>
754 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
755 removing it from the hash table. (#314696, Benjamin Berg)
757 2005-10-01 Tor Lillqvist <tml@novell.com>
759 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
760 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
761 is that the the desktop isn't visible because the session has been
762 switched, the screen is locked, or a terminal server session
763 disconnected, so no error message necessary. (#137796)
765 It is of course remotely possible that BitBlt() failing with
766 ERROR_INVALID_HANDLE might also be caused by some other
767 problem. We could strive for perfection and track whether the
768 desktop is visible by using WTSRegisterSessionNotification() and
769 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
770 this issue, though. If we would track desktop visibility, we
771 should then avoid even trying to update the display at all while
772 the desktop isn't visible.
774 2005-09-30 Matthias Clasen <mclasen@redhat.com>
776 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
777 to correct the calculations for the first week day. We may
778 just have to remove this code if too many locales turn out
781 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
782 some cases. (#317611, Tommi Komulainen)
784 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
785 Prevent overflow when storing size hints in an unsigned
786 short variable. Tracked down by Ray Strode and Søren Sandmann.
788 2005-09-29 Matthias Clasen <mclasen@redhat.com>
790 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
793 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
794 grab shadowed. (#317332)
796 2005-09-29 Tor Lillqvist <tml@novell.com>
798 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
800 2005-09-28 Federico Mena Quintero <federico@ximian.com>
802 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
803 if the unmap test fails.
804 (test_reload_sequence): Use gtk_widget_show_now() instead of
805 gtk_widget_show() for the dialog.
806 Thanks to Tim Janik for noticing these.
808 2005-09-28 Federico Mena Quintero <federico@ximian.com>
810 * tests/testcellrenderertext.c: New file with a set of tests for
811 GtkCellRendererText. The idea is to run a text renderer through
812 most of its interesting property values to see that it works
815 * tests/Makefile.am: Added testcellrenderertext.
817 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
818 entry/exit of this function for profiling.
819 (gtk_file_chooser_default_style_set): Mark the start/end of the
820 calls to the parent class and the the signal emission for profiling.
822 2005-09-29 Tor Lillqvist <tml@novell.com>
824 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
825 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
826 system codepage using g_win32_locale_filename_from_utf8().
827 (#317457, Kazuki Iwamoto)
829 2005-09-28 Matthias Clasen <mclasen@redhat.com>
831 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
832 here. (#317039, Paolo Borelli)
835 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
836 to make this function work as boxed copy function. (#317455,
839 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
840 NULL. (#316828, Tor Lillqvist)
842 2005-09-28 Tor Lillqvist <tml@novell.com>
844 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
847 2005-09-27 Federico Mena Quintero <federico@ximian.com>
849 Don't reload the current folder unnecessarily on ::map().
851 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
853 (struct _GtkFileChooserDefault): Added a "reload_state" field.
855 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
856 Initialize impl->reload_state.
857 (gtk_file_chooser_default_map): Check the impl->reload_state; load
858 a default folder if no folder has been set, or reload the current
859 one only if we had been unmapped first.
860 (gtk_file_chooser_default_update_current_folder): Set the
861 reload_state to RELOAD_HAS_FOLDER.
862 (gtk_file_chooser_default_unmap): Implement, and set the
863 reload_state to RELOAD_WAS_UNMAPPED.
864 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
865 here; they'll get (re)loaded on ::map() anyway.
867 * gtk/gtkfilechooserwidget.c
868 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
870 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
871 a dialog; build it ourselves.
872 (test_reload): New test to ensure that we don't load the default
873 folder more than once, and that we reload it when
875 (get_impl_from_dialog): New utility function.
876 (test_widgets_for_current_action): Use get_impl_from_dialog().
878 2005-09-27 Federico Mena Quintero <federico@ximian.com>
880 * gtk/gtkfilechooserdefault.c
881 (gtk_file_chooser_default_constructor): Mark the entry/exit of
882 this function for profiling.
883 (check_icon_theme): Likewise.
884 (change_icon_theme): Likewise.
885 (settings_notify_cb): Likewise.
886 (gtk_file_chooser_default_screen_changed): Likewise.
887 (update_chooser_entry): If the selection is empty, clear the file
888 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
889 nothing will be selected when the user starts typeahead in the
890 treeview, and we don't want to clear the file name entry in that
891 case --- the user could be typing-ahead to look for a folder name.
892 Fixes bug #308332, patch by Jürg Billeter.
894 2005-09-27 Matthias Clasen <mclasen@redhat.com>
896 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
897 Pop below the entry if there's more free space below the entry
898 than above. (#316948, Tommi Komulainen)
900 2005-09-26 Federico Mena Quintero <federico@ximian.com>
902 Do not create the save mode-specific widgets in the open modes, so
903 that we don't carry their baggage around.
905 * gtk/gtkfilechooserdefault.c
906 (gtk_file_chooser_default_constructor): Don't create the
908 (save_widgets_create): Set the impl->save_widgets directly here,
909 instead of passing the widgets back to the caller. Also, pack
910 them into the impl's box.
911 (update_appearance): Create or destroy the save widgets as
912 appropriate. Set the action of the save_file_name_entry here.
913 (shortcuts_add_current_folder): Set the active item in the
914 save_folder_combo only if it exists.
915 (gtk_file_chooser_default_set_property): Don't set the action of
916 the save_file_name_entry here.
917 (gtk_file_chooser_default_update_current_folder): Set the base
918 folder of the save_file_name_entry only if the entry exists.
919 (shortcuts_drag_data_received_cb): Cast the selection_data->data
920 to (const char *) since that's what shortcuts_drop_uris() expects.
921 (file_list_drag_data_received_cb): Likewise, for
922 g_uri_list_extract_uris().
924 2005-09-26 Tor Lillqvist <tml@novell.com>
926 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
927 the shaped flag here, too. (#316871)
928 (gdk_window_shape_combine_region): Currently unimplemented, so
929 don't do anything to the shaped flag here.
931 2005-09-26 Matthias Clasen <mclasen@redhat.com>
933 Fix #316871, reported by Dan Winship:
935 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
937 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
938 (gdk_window_shape_combine_region): Set it here.
940 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
941 remove the child area for shaped windows.
943 2005-09-23 Matthias Clasen <mclasen@redhat.com>
945 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
946 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
948 2005-09-22 Michael Natterer <mitch@imendio.com>
950 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
951 consistent with GTK+ terminology:
953 * gtk/gtkcellrendererkeys.[ch]
954 * tests/testkeys.c: removed...
956 * gtk/gtkcellrendereraccel.[ch]
957 * tests/testaccel.c: ...and added.
962 * tests/Makefile.am: changed accordingly.
964 2005-09-22 Matthias Clasen <mclasen@redhat.com>
966 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
967 for the grab-broken-event signal, noticed by Damon Chaplin.
969 2005-09-21 Tor Lillqvist <tml@novell.com>
971 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
972 gdk_text_property_to_text_list_for_display,
973 gdk_text_property_to_utf8_list_for_display,
974 gdk_win32_selection_add_targets,
975 _gdk_win32_selection_convert_to_dib): Free return value from
977 (gdk_text_property_to_text_list_for_display): Drop GError variable
978 that isn't actually used after being set.
980 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
982 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
985 2005-09-20 Tor Lillqvist <tml@novell.com>
987 * gdk/win32/gdkselection-win32.c
988 (gdk_selection_owner_get_for_display): Do return the correct owner
989 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
990 a window GDK knows about). The reason to return NULL seems to have
991 gone when in the fix for bug #163702 the artificial
992 GDK_SELECTION_CLEAR event generation was removed from
993 gdk_selection_send_notify_for_display(). Fixes bug #316552.
995 2005-09-20 Matthias Clasen <mclasen@redhat.com>
997 Avoid unnecessary XkbGetState() calls and XkbStateNotify
998 events. (#151555, Søren Sandmann)
1000 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1001 XkbSelectEventDetails() to select XkbStateNotify events
1002 for only the state we care about.
1004 * gdk/x11/gdkprivate-x11.h:
1005 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1006 the event into the function and update the keymap state from
1007 the state information contained in the event. Adjust all callers.
1009 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1011 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1012 in multiple places to avoid segfaults if the index is out of range.
1013 (#316422, Guillaume Cottenceau)
1014 (gtk_icon_view_set_drag_dest_item):
1015 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1016 #316424, Guillaume Cottenceau)
1018 2005-09-18 Hans Breuer <hans@breuer.org>
1020 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1021 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1023 2005-09-18 Hans Breuer <hans@breuer.org>
1025 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1026 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1027 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1028 the icon and is blinking with teststatusicon. More to come ...
1030 2005-09-18 Hans Breuer <hans@breuer.org>
1032 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1033 cause gtkprogressbar.c has #include <config.h> conditionally; less
1034 noise from generated gtk.def
1035 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1037 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1038 For me it works as well as the *NIX implemenation, that is not at all.
1040 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1042 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1043 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1044 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1045 again - if compiled properly.
1047 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1048 already coming with Gtk+. Makes it compile on win32.
1050 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1052 * README.cvs-commits: fixed some tiny typos
1054 2005-09-16 Tor Lillqvist <tml@novell.com>
1056 * modules/engines/ms-windows/msw_style.c (draw_extension,
1057 draw_box_gap): Check whether the widget actually is a GtkNotebook
1058 before treating it as such. Drop some unneeded local variables,
1059 use parameter with same information instead. (#316412)
1061 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1063 * tests/autotestfilechooser.c: Start a set of automated tests for
1064 the file chooser. The only test in there right now doesn't pass
1065 yet. It specifies the intended behavior of the first optimization
1066 of a series which I'll do on the file chooser (see
1067 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1068 details of this optimization).
1070 * tests/Makefile.am: Added autotestfilechooser.c.
1072 * gtk/gtkfilechooserprivate.h (struct
1073 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1074 structures to here, so that they can be accessed by
1075 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1076 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1078 * gtk/gtkfilechooserdialog.c: See above.
1080 * gtk/gtkfilechooserwidget.c: See above.
1082 * gtk/gtkfilechooserdefault.c: See above.
1084 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1087 gtk_window_map_event(): new function to work around lost unmap requests.
1090 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1092 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1093 an easy-to-find profiling marker when starting to create a file
1095 (browse_files_model_finished_loading_cb): Likewise, for when the
1096 chooser is finished loading.
1098 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1100 * gtk/gtkcolorbutton.c: Check "color" argument in
1101 gtk_color_button_set_color ()
1103 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1105 * gtk/gtklabel.c (gtk_label_get_type):
1106 * gtk/gtkbutton.c (gtk_button_get_type):
1107 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1108 using a mem chunk for window groups, buttons, labels.
1110 * gtk/updateiconcache.c (foreach_remove_func): Fix
1111 a use-after-free bug. (#316256, Alexander Nedotsukov)
1113 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1115 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1117 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1119 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1121 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1122 Let GDK_Return pass through in some more cases.
1124 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1125 activating the entry.
1127 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1128 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1129 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1131 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1132 (#316001, Guillaume Cottenceau)
1134 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1135 mistake in the docs. (#315993, Guillaume Cottenceau)
1137 * tests/testentrycompletion.c (create_simple_completion_model): Add
1138 some strings containing multibyte characters.
1140 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1141 Fix prefix insertion for multibyte characters. (#316095,
1144 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1145 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1146 return NULL if the widget is not realized. (#316023,
1147 Guillaume Cottenceau)
1149 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1152 * gdk/gdkproperty.h:
1153 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1154 New function to avoid pointless strdups when creating atoms
1155 from static strings.
1158 * gtk/*.c: Use gdk_atom_intern_static_string() where
1161 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1163 * gtk/gtkcellrendererkeys.h:
1164 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1165 and editing accelerators, a port of EggCellRendererKeys .
1169 * gtk/Makefile.am: Add the keys cell renderer.
1171 * tests/Makefile.am:
1172 * tests/testkeys.c: Test GtkCellRendererKeys
1174 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1176 Make it possible to determine if a key event is for a
1179 * gdk/x11/gdkprivate-x11.h:
1180 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1181 New function to determine if a keycode is mapped to a modifier.
1182 (get_xkb): Get the modmap.
1184 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1185 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1187 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1190 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1192 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1193 unused variable, noticed by Kjartan Maraas.
1195 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1197 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1198 Make drag reordering work properly for columns other than the
1199 first. (#315054, Dan Winship)
1201 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1202 invalid fontnames better. (#136926, Michael R. Walton)
1204 Stop cursor blinking in non-editable regions of a text view.
1205 (#311508, Torbjörn Andersson)
1207 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1208 (cursor_blinks): Take editability into account when deciding
1209 whether the cursor blinks.
1210 (gtk_text_view_button_release_event):
1211 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1213 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1214 Use connect_after to connect to the focus_out event. This
1215 ensures that the entry has already stopped blinking by the time
1216 we emit the edited signal. (#315229, Thomas Leonard)
1218 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1220 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1221 unsigned ints to -1. (#315481, Kjartan Maraas)
1223 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1224 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1225 (#314473, Stanislav Brabec)
1227 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1229 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1230 memory handling. (#314975, Torsten Schoenfeld)
1232 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1233 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1234 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1235 * gtk/gtklabel.c (gtk_label_class_init):
1236 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1237 Stylistic improvements and clarifications for some blurbs.
1238 (#315520, Clytie Siddall)
1240 2005-09-09 Tor Lillqvist <tml@novell.com>
1242 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1243 display name. There is only one GdkDisplay on Win32, and
1244 constructing the display name isn't entirely trivial, so cacheing
1245 is probably worth it. For instance GIMP calls this function a lot.
1246 (gdk_display_open): Call gdk_display_get_name() to prime the
1248 (gdk_display_get_n_screens, gdk_display_get_screen,
1249 gdk_display_get_default_screen): Verify parameter correctness like
1250 the X11 backend does.
1252 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1253 Return a freshly allocated string, as the API specifies. Fixes a
1254 heap corruption problem that caused random errors and crashes in
1257 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1259 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1260 Make C-u commit and restart hex input if we are already in a
1263 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1265 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1266 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1267 if they are mapped to the same modifier.
1269 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1270 to gtkstatusicon.c and gtktrayicon-x11.c
1272 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1273 default accel mod mask.
1275 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1276 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1277 Don't use GDK_ALT_MASK.
1279 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1281 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1283 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1285 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1288 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1289 Mod2 - Mod5 and against Super, Hyper, Meta.
1291 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1292 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1293 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1295 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1296 modmap to maintain the information which X modifiers map to
1298 (get_xkb): Set up the modmap from the XKB tables.
1299 (update_keymaps): Set up the modmap from the information returned
1300 by XGetModifierMapping in the non-XKB case.
1302 * gdk/x11/gdkprivate-x11.h:
1303 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1304 function to set the virtual modifiers in the state.
1306 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1307 _gdk_keymap_add_virtual_modifiers here.
1309 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1310 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1313 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1315 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1316 if it has no child. (#315253, John Finlay)
1318 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1320 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1322 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1324 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1325 on destroy to avoid problems when they are called on a destroyed
1326 widget. (#315135, John Cupitt)
1328 * gtk/gtkentry.c (gtk_entry_class_init):
1329 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1330 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1332 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1333 code. Now we only steal a single key combination, Ctrl-Shift-U,
1335 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1336 by a sequence of hex digits entered with Ctrl-Shift still held.
1337 Releasing one of the modifiers or pressing space while the modifiers
1338 are still held commits the character. It is possible to erase
1339 digits using backspace.
1340 As an extension to the above, we also allow to start the sequence
1341 with Ctrl-Shift-U, then release the modifiers before typing any
1342 digits, and enter the digits without modifiers.
1343 (#82011, Owen Taylor)
1345 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1347 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1348 we still need to deliver the destroy event. (#314980, Chris Lahey)
1350 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1351 im context before committing \n or \t.
1353 2005-09-02 Alexander Larsson <alexl@redhat.com>
1355 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1356 (shortcuts_activate_volume):
1357 Handle base_path being null in the rest of the cases (#310270)
1359 2005-09-02 Tor Lillqvist <tml@novell.com>
1361 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1362 cursor position also in root window coordinates. Prune out
1363 superfluous WM_MOUSEMOVE events even earlier, based on root window
1364 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1365 window has ben mapped below the cursor even if the mouse doesn't
1366 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1367 confused at least gtk_menu_motion_notify(). (#314995)
1369 * gtk/gtkintl.h: No need to include config.h here. It caused
1370 warnings about GTK_LOCALEDIR being redefined on Win32 when
1371 compiling files where gtkintl.h is included after gtkprivate.h
1372 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1374 * gtk/gtkplug.c: Include config.h.
1376 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1378 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1379 xdg_mime_get_mime_type_for_file() where possible, to avoid
1382 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1383 typo. (#314921, Guillaume Cottenceau)
1385 * gdk/*.c: Intern some more strings.
1387 * gtk/*.c: Define an I_() macro and use it instead of the
1388 bulky g_intern_static_string().
1390 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1392 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1393 instead of copying it.
1395 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1397 * gtk/*.c: Also intern static strings passed to
1398 g_object_set_data().
1401 * gtk/Makefile.am: Intern type names in code generated by
1406 * gdk/*.c: Intern type names before registering the type to avoid
1409 * configure.in: Require GLib 2.9.0
1411 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1413 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1414 and add icon-size and icon-size-set properties. (#314172)
1416 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1417 groups across transient parents. (#312918, Christian Persch)
1419 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1420 Guillaume Cottenceau)
1422 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1423 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1425 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1427 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1428 make C-/ select all and C-\ unselect all. (#309301,
1431 * gtk/gtkimcontextsimple.c: Change the compose sequence for
1432 soft hyphen to be multi_key-minus-minus-space, and add
1433 compose sequences multi_key-minus-minus-period and
1434 multi_key-minus-minus-minus for en dash and em dash.
1435 (#172653, Christian Lohmaier)
1437 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
1438 code. (#313946, Christian Persch)
1440 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
1441 fix for the default value of the "ui" property.
1443 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1446 * gtk/gtkselection.h:
1447 * gtk/gtkselection.c: Add functions which look for text, image
1448 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1451 * gtk/gtkselection.h:
1452 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1453 Add a function to check wether targets include uri.
1454 (#314092, Mark Wielaard)
1458 * gtk/gtkwindow.c: Add a deletable property with getter
1459 and setter, to control the close button in the window
1460 frame. (#59718, Havoc Pennington)
1462 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1464 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1465 to the arrow keys for menu navigation. (#162825, Carl Worth)
1467 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1469 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1471 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1472 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1473 refer to nonexisting stock ids.
1475 * gtk/gtktextview.c (popup_targets_received):
1476 * gtk/gtkentry.c (popup_targets_received): Construct
1477 the "Select All" menuitem from stock.
1479 * gtk/stock-icons/stock_select_all_{16,24}.png:
1480 * gtk/stock-icons/Makefile.am:
1481 * gtk/gtkiconfactory.c:
1483 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1486 * gtk/gtktrayicon.c: Add a pointer to the spec.
1488 * gtk/gtkstatusicon-x11.c: Add docs.
1490 * gtk/gtkstatusicon.h: Fix a typo.
1492 Add a cross-platform "tray icon" API, by
1493 porting EggStatusIcon/EggTrayIcon (#105101)
1495 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1496 displays an icon in a notification area.
1498 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1499 X11, using GtkTrayIcon.
1501 * gtk/gtktrayicon.h:
1502 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1503 system tray specification, not public API.
1505 * gtk/gtk.symbols: Add new exported functions.
1507 * gtk/gtk.h: Include gtkstatusicon.h.
1509 * gtk/Makefile.am: Add new files.
1511 * tests/Makefile.am:
1512 * tests/teststatusicon.c: Test for GtkStatusIcon.
1514 2005-08-29 Christopher Aillon <caillon@redhat.com>
1516 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1517 and GTK_STOCK_DISCONNECT
1519 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1521 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1522 Use XFixesChangeSaveSet if available. (#314682)
1524 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1525 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1527 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1529 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1530 accidentally leftover duplicate pixbuf creation. (#314700,
1533 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1534 leak the cursor theme name. (#314693, Kjartan Maraas)
1536 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1537 state.children in all cases. (#313862, Kjartan Maraas)
1539 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1541 * po/POTFILES.in, po-properties/POTFILES.in:
1544 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1546 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1547 value of the ui property. (#314532, Yong Wang)
1549 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1550 when G_MAXLONG is passed as length.
1552 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1554 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1555 to avoid overloading --force. (JP Rosevaar)
1557 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1559 * configure.in: Bump version to 2.9.0
1563 * gdk/gdkscreen.c: Make the GdkScreen font options api
1564 public, and add properties GdkScreen::font-options and
1565 GdkScreen::resolution. (#314004)
1568 * gtk/gtksettings.c:
1569 * gtk/gtkwidget.c: Adjust all callers.
1571 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1572 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1573 * gdk/gdkscreen.c: Include gdkintl.h.
1575 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1576 variable warning, pointed out by Colin Walters. (#314585)
1578 2005-08-26 Tor Lillqvist <tml@novell.com>
1580 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1582 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1584 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1586 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1587 of week_start. (#314473, JP Rosevaar)
1589 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1591 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1592 lock. (#314533, Thomas Fitzsimmons)
1594 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1596 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1597 NULL gracefully. (#314523, Ed Catmur)
1599 2005-08-25 Owen Taylor <otaylor@redhat.com>
1601 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1602 Handle theme == NULL.
1604 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1606 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1607 y offset into account when positioning the popup. (#314470,
1610 2005-08-25 Owen Taylor <otaylor@redhat.com>
1612 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1613 as instance_init, not base_init! (#314452, Fix from Frederic
1614 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1615 rather than 1 for a negative flag value.
1617 2005-08-24 Owen Taylor <otaylor@redhat.com>
1619 * gdk/gdkpango.c (draw_error_underline): Add a note about
1620 cut-and-paste between here and Pango.
1622 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1624 * === Released 2.8.2 ===
1626 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1627 callback for image/gif, and also try image/bmp. (#314086, Mark
1630 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1631 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1636 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1637 and cursor settings get propagated down to the screen initially.
1638 Pointed out by Frederic Crozat.
1640 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1641 message if the screen is NULL. Noticed by Kjartan Maraas.
1643 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1647 * === Released 2.8.1 ===
1651 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1653 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1654 against lazy filterers which return values other than TRUE or
1655 FALSE from their visible func. (#314335)
1657 2005-08-23 Owen Taylor <otaylor@redhat.com>
1659 Fix for #314004, reported by Michael Reinsch:
1662 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1663 Add gdk_screen_get/set_resolution_libgtk_only()
1665 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1666 the options for the screen on the newly created context.
1668 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1669 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1670 the font options on the screen.
1672 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1673 the font options from the screen and set them on the context.
1675 2005-08-23 Kristian Rietveld <kris@gtk.org>
1677 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1678 bother inserting new rows in a level with a zero refcount and
1679 immediately free the level. (Fixes #312350, reported by Markku Vire).
1681 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1683 * gtk/updateiconcache.c: Complain when there is no index.theme file
1684 in the specified directory, unless --force is used. Also add an
1685 --index-only option to create caches without image data.
1687 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1688 C99ism. (#314262, Robert Jeff Mitchell)
1690 2005-08-22 Manish Singh <yosh@gimp.org>
1692 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1694 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1696 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1698 * gtk/gtkwindow.c (gtk_window_client_event):
1699 * gtk/gtkicontheme.c (ensure_valid_themes)
1700 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1701 scheme for makeing sure that all GTK+ applications notice if an
1702 icon theme has been updated. This should prevent multiple versions
1703 of an icon theme cache to be mapped in memory at the same time,
1704 which can cause excessive memory consumption. (#313156, Chris
1707 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1709 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1710 regarding icon theme changes.
1712 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1713 pixbufs which are backed by the mmapped memory of an icon cache,
1714 increase the refcount of the icon cache, so that the memory is not
1715 munmapped away underneath the pixbuf upon icon theme changes.
1716 (#314170, Kjartan Maraas)
1718 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1719 to link against Xext. (#314062)
1721 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1722 overruns. (#314081, Hans Breuer)
1724 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1726 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1727 returned layout must not be modified.
1729 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1731 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1732 scroll_to_path if the model changes.
1734 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1735 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1736 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1737 we're realized, #312798
1738 (gtk_icon_view_set_model): clear scroll_to_path if the model
1741 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1743 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1744 (gtk_range_adjustment_value_changed): Don't queue a draw
1745 if the layout has not changed. (#313991, Benjamin Berg)
1747 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1749 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1752 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1755 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1756 (model_add_special, model_add_special, model_add_volumes):
1757 Handle pixbuf being NULL without warnings. Also, don't
1758 leak pixbuf references when the icon theme is changed.
1760 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1761 the user data on destroyed windows, since at best
1762 it can be a stale pointer. (#313953, Robin Green)
1764 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1766 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1767 (#313900, Sebastien Bacher)
1769 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1770 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1772 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1773 (xdnd_read_actions, get_client_window_at_coords_recurse):
1774 Free data returned from XGetWindowProperty.
1776 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1777 Free data returned from XGetWindowProperty. (313867, Kjartan
1780 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1781 children in all cases. (#313862, Kjartan Maraas)
1783 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1784 in the per-directory hash, even if they come from the icon cache.
1785 We tried to avoid that before, but as a result leaked icon data
1786 structs. (#313852, Kjartan Maraas)
1788 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1790 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1791 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1793 2005-08-15 Owen Taylor <otaylor@redhat.com>
1795 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1796 files for x11/xext. (Jonas Bonn)
1798 2005-08-15 Tor Lillqvist <tml@novell.com>
1800 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1803 2005-08-15 Owen Taylor <otaylor@redhat.com>
1805 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1807 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1808 (#313417, James Andrewartha)
1810 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1811 FcNameConstant(). (More of #313417)
1813 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1815 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1816 modal dialogs, make sure to inherit the window group from
1817 the parent, since we don't inherit window groups across
1818 transient parents currently. (#312918, Christian Persch)
1820 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1821 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1823 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1824 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1825 gracefully. (#312796, Jonathan Blandford)
1827 * tests/testtoolbar.c: Add some more tests for menu placement.
1829 * gtk/gtkmenutoolbutton.c (menu_position_func):
1830 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1831 of toolbutton menus and of the overflow menu. (#312937,
1832 #153870, Christian Persch, Paolo Borelli)
1834 2005-08-15 Tor Lillqvist <tml@novell.com>
1836 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1837 the nonportable <libgen.h> and dirname().
1839 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1841 * gtk/gtksizegroup.c: Use object data to mark widgets and
1842 groups as visited, so that we avoid constant extra list
1843 traversals. Also allocate quarks in class_init. (#311618,
1846 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1847 download location for the hicolor icon theme. (#313475, Olexiy
1850 * gtk/gtkicontheme.c: Remove debug spew.
1852 2005-08-15 Owen Taylor <otaylor@redhat.com>
1854 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1855 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1856 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1857 Handle pixmap == NULL when checking for a colormap.
1860 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1862 * gtk/updateiconcache.c: Store only one copy of the pixel data
1863 for symlinked icons. To achieve this, maintain a hashtable
1864 mapping pathnames to pixel data, and share the pixel data for
1865 all symlinks resolving to the same pathname. When writing out
1866 the image data, write out the pixel data only the first time
1867 it is met, and store the offset pointing to the first copy
1868 for use in all later cases.
1869 This reduces the size of the Bluecurve icon cache from 40