1 2005-11-18 Matthias Clasen <mclasen@redhat.com>
3 Fix crashes in connection with pathbar scrolling (#321560,
6 * gtk/gtkpathbar.c (gtk_path_bar_update_slider_buttons):
7 Stop scrolling when desensitising slider buttons.
8 (gtk_path_bar_scroll_timeout, gtk_path_bar_slider_button_press):
11 * gtk/gtkpathbar.h (struct _GtkPathBar): Add a separate
14 2005-11-18 Matthias Clasen <mclasen@redhat.com>
16 * gtk/gtkpathbar.c (button_clicked_cb): Fix a C99ism.
17 (#321777, Jens Granseuer)
19 * gtk/gtkaction.c (disconnect_proxy): Disconnect the
20 sync callback for the visibility property. (#321761,
23 Turn off input methods in invisible entries, since
24 they are confusing. (#317002, James Su)
26 * gtk/gtkentry.c (gtk_entry_set_visibility): Toggle input
27 methods if visibility changes.
28 (popup_targets_received): Don't show the input method
29 menu if the entry is invisible.
31 2005-11-17 Matthias Clasen <mclasen@redhat.com>
33 * README.in: Add a note about range arrow sensitivity.
35 * perf/treeview.c: const correctness fixes
36 found by Arjan van de Ven and gcc.
38 2005-11-16 Michael Natterer <mitch@imendio.com>
40 * gtk/gtkimage.c (animation_timeout): call
41 gtk_window_process_updates() so the animation keeps running even
42 if the main loop is busy with sources that eat a lot of cpu with
43 high priority. Fixes bug #321444.
45 (gtk_image_new_from_animation): document the fact that the
46 animation will stop running if the main loop is busy with sources
47 that have priorities higher than G_PRIORITY_DEFAULT.
49 * tests/testimage.c: added test case that shows an animation even
50 though a cpu-eating idle function is running.
52 2005-11-16 Michael Natterer <mitch@imendio.com>
54 * gdk/x11/gdkevents-x11.c (_gdk_events_uninit): new internal
55 function which destroys the display's event source. Also removes
56 the source from the global display_sources list and unrefs it.
58 * gdk/x11/gdkprivate-x11.h: declare the function.
60 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_dispose): call it
61 instead of half-destroying the source here.
63 2005-11-15 Matthias Clasen <mclasen@redhat.com>
65 * gtk/gtktreestore.c (gtk_tree_store_move): Fix a memory
66 leak. (#321032, Peter Zelezny)
68 2005-11-15 Michael Natterer <mitch@imendio.com>
70 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_finalize): destroy
71 display->xid_ht as late as possible (right before XCloseDisplay)
72 because it still needs to be around when the display's screens are
75 2005-11-14 Matthias Clasen <mclasen@redhat.com>
77 * gtk/gtkselection.c (gtk_selection_data_set_uris): Don't
78 leak result. (#321441, Tommi Komulainen)
80 2005-11-14 Matthias Clasen <mclasen@redhat.com>
82 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes):
83 Don't crash if there is no builtin icon.
85 2005-11-14 Michael Natterer <mitch@imendio.com>
87 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_set_property):
88 removed redundant calls to g_object_notify().
90 2005-11-13 Matthias Clasen <mclasen@redhat.com>
92 * gdk/gdkcolor.c (gdk_color_parse): Documentation
93 improvements. (#321338)
95 * gtk/gtktextiter.c (gtk_text_iter_forward_search): Make
96 limit an inclusive boundary. (#321299)
98 2005-11-12 Michael Natterer <mitch@imendio.com>
100 * gtk/Makefile.am: fixed icon rules so gtkbuiltincache.h is only
103 2005-11-12 Dom Lachowicz <cinamod@hotmail.com>
105 * modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
106 theme's handling of toolbars, handleboxes, and menubars more in-line
107 with Microsoft's IE style.
108 * modules/engines/ms-windows/*.c: Indentation cleanups
110 2005-11-12 Matthias Clasen <mclasen@redhat.com>
112 Make builtin icons work in gtk_window_set_icon_name()
113 (#321046, Maxim Udushlivy)
115 * gtk/gtkicontheme.c (insert_theme): Always insert the default
117 (ensure_valid_themes): Call _gtk_icon_theme_ensure_builtin_cache()
119 (theme_lookup_icon, find_builtin_icon): ...and not from here.
120 (gtk_icon_theme_lookup_icon): Remove an unncessary assert.
121 (gtk_icon_theme_get_icon_sizes): Also check builtin icons.
123 2005-11-12 Tor Lillqvist <tml@novell.com>
125 * gtk/gtkfilesystemwin32.c (filename_get_info): Don't hide
126 dotfiles, no such convention on Win32. Just hide files with the
127 hidden attribute. (#314627)
129 2005-11-11 Federico Mena Quintero <federico@ximian.com>
131 * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Do not
132 check whether the path is a folder. It is useful to bookmark
133 files as well (e.g. todo.txt), and this will also help
135 (shortcuts_add_bookmark_from_path): Likewise.
136 (shortcuts_activate_iter): Change folders or select files, as
139 2005-11-11 Federico Mena Quintero <federico@ximian.com>
141 * tests/autotestfilechooser.c (main): Use
142 g_log_set_default_handler() instead of explicitly setting a
143 handler for each domain.
145 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Only get
146 the base path of the volume if it is mounted.
148 2005-11-11 Michael Natterer <mitch@imendio.com>
150 Added per-stepper API for GtkRange's stepper sensitivity as
151 discussed in bug #321056:
153 * gtk/gtkenums.h: added GtkSensitivityType which can be
156 * gtk/gtkrange.[ch]: added properties "lower-stepper-sensitivity"
157 and "upper-stepper-sensitivity" and public getters/setters for
158 them. Changed stepper drawing to honor the new properties.
160 * gtk/gtk.symbols: added the new symbols.
162 2005-11-10 Matthias Clasen <mclasen@redhat.com>
164 * gtk/gtkcombobox.c: Add show-popup and hide-popup signals and
165 emit them when the popup is shown or hidden. (#162531, Tommi
168 * tests/testcombo.c: Add an example of popuplating a combobox
171 * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Another
174 * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
177 Don't corrupt odd keymaps (#316638, Kean Johnston)
179 * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
180 handle frobbing keymaps with odd numbers of syms/code.
182 * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
185 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
187 * gtk/gtkpathbar.[hc]: Add a child_path argument to
188 the path_clicked signal.
189 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
190 child_path, if it is provided.
191 * gtk/marshalers.list (path_bar_clicked): Add the necessary
194 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
199 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
200 (#163851, Richard Hult)
202 2005-11-10 Michael Natterer <mitch@imendio.com>
204 Applied patch from maemo-gtk that addresses many issues wrt
205 display migration and display closing (bug #85715).
207 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
208 default display to NULL when it's closed. Instead set the most
209 recently opened display as new default (if one exists).
211 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
214 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
215 exist before unrefing them.
217 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
218 is closed, allow destruction of the root window.
220 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
221 dispose(), free stuff that was leaked before.
223 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
224 the xsettings_client still exists before destroying it.
226 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
229 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
230 dispose() implementation.
232 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
233 dispose() and check if it still exists before unrefing it. Set
234 their pointers to NULL/None *after* upchaining in dispose(),
235 because X11 implementations of members of the parent class still
236 need them for their own destruction.
238 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
239 was g_error()ing when finalizing a visual.
241 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
242 get_clipboard_widget() because it would create the widget if it
243 doesn't exist. Use g_object_get_data() directly instead.
245 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
248 2005-11-10 Simos Xenitellis <simos@gnome.org>
250 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
252 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
254 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
255 to render its arrows insensitive when the adjustment is in
256 its min or max position. this makes range arrow behaviour
257 consistent with spin button behaviour. (#321056)
259 2005-11-09 Tor Lillqvist <tml@novell.com>
262 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
263 the GdkDebugFlag enum.
265 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
266 this file instead of MISC. Now asking for MISC will give mainly
267 window manipulation debugging output with the Win32 backend.
269 2005-11-09 Tor Lillqvist <tml@novell.com>
271 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
273 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
274 function which was used only in one place.
276 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
278 (gdk_window_set_geometry_hints): If we have identical minimum and
279 maximum size hints, remove the resize and maximize
280 decorations/functions. (#104514)
282 If we have a maximum size hint, remove the maximize
283 decoration/function but ensure the resize decoration/function is
284 available. Otherwise ensure both resize and maximize
285 decorations/functions are there.
287 (set_or_clear_style_bits): Factored out common code from
288 gdk_window_set_decorations() and gdk_window_set_functions().
290 Hack the window style setting once more: Only touch the window
291 style bits corresponding to the GdkWMDecoration or GdkWMFunction
292 parameter bitmasks. Hopefully this finally is the correct thing to
293 do. We used to clear all other bits than those that were being
294 set, or set all other bits than those that were being cleared.
296 Take into account that adding or removing decorations leaves the
297 window's outer size unchanged, i.e., the client area's size and
298 position change. This is apparently not what we want, so change
299 also the window's (outer) position and size appropriately so that
300 the client area's position and size stay constant.
302 gtk-demo's color selector dialog is now non-resizable like on X11
303 (I tested with metacity in GNOME). Torn off menus are shrinkable
304 vertically but have a maximum size, and are not maximizable or
305 minimizable, like on X11.
307 (gdk_window_set_decorations, gdk_window_set_functions): Let
308 set_or_clear_decorations() do most of the job.
310 * gdk/win32/gdkprivate-win32.h: Remove declaration of
311 _gdk_win32_get_adjusted_client_rect().
313 2005-11-09 Tor Lillqvist <tml@novell.com>
315 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
316 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
317 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
318 type hint. Implement gdk_window_get_type_hint() by just returning
321 2005-11-09 Tor Lillqvist <tml@novell.com>
323 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
324 Remove code that has been permanently ifdeffed out for two years.
326 2005-11-08 Matthias Clasen <mclasen@redhat.com>
328 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
329 finalizing a gc. (#320789, Nickolay V. Shmyrev)
331 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
332 icons if they would make the request large enough to cause
333 Xlib to loose the connection. (#320909, Claudio Saavedra)
335 2005-11-08 Michael Natterer <mitch@imendio.com>
339 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
340 extracted from maemo-gtk). Fixes bug #320872.
342 2005-11-07 Matthias Clasen <mclasen@redhat.com>
344 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
345 looks the bookmark label when reordering. (#320720, Jeremy Cook)
347 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
348 Don't grab focus when a slider button is pressed, instead, use
349 a bit in the pathbar struct to determine whether to scroll up
350 or down. (#314486, Carlos Garnacho)
352 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
353 Don't popup the completions if the focus has already been
354 moved somewhere else. (#319914, Christian Persch)
356 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
357 Raise the drag_window after reconfiguring the
358 toolbar. (#320803, Christian Persch)
361 * gtk/gtkfilechooserbutton.h:
362 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
363 with setter and getter. (#318945, Christian Persch)
365 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
367 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
369 2005-11-07 Matthias Clasen <mclasen@redhat.com>
371 * configure.in: Adjust to the stock icon changes.
373 2005-11-07 Tor Lillqvist <tml@novell.com>
375 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
376 Correct the calculation of maskstride. (#320152, Peter Zelezny)
378 2005-11-06 Michael Natterer <mitch@imendio.com>
380 * gtk/Makefile.am (icons): fixed rule to actually create the
381 symlinks, erroring out if anything goes wrong.
383 2005-11-06 Tor Lillqvist <tml@novell.com>
385 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
386 target exists on Win32. First rename the target temporarily, then
387 if the renaming of the source to target fails, restore the
388 original name for the target.
390 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
392 2005-11-06 Tor Lillqvist <tml@novell.com>
394 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
395 like pixbuf_to_hbitmaps_normal().
396 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
397 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
398 setting the G_WIN32_PRETEND_WIN9X environment variable.
400 2005-11-06 Tor Lillqvist <tml@novell.com>
402 Make icon masks work on Win98 (#320152, Peter Zelezny)
404 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
405 parameter for the depth of the bitmap, so that this function can
406 be used to create 1-bit bitmaps, too.
407 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
408 and initialize it properly.
410 2005-11-04 Matthias Clasen <mclasen@redhat.com>
412 Store builtin stock icons in an icon cache, instead of
413 populating a hash table with pixbufs at startup, to save both
414 memory and startup time.
416 * gtk/stock-icons/*: Reorganize the icons in a directory structure
417 suitable for gtk-update-icon-cache, and rename them to match the
420 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
421 add _gtk_icon_cache_has_icon_in_directory().
423 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
424 to store the contents of the icon cache in a C header.
426 * gtk/gtkbuiltincache.h: Generated private header which contains
427 the icon cache for the builtin icons.
429 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
430 icons, and use that in addition to the hash table whenever
431 builtin icons are searched.
433 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
434 use it for static stock ids.
435 (get_default_icons): Don't add the builtin
436 icons to the icon theme, just register the stock ids.
437 (render_fallback_image): Take the fallback image out of the
440 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
441 the necessary machinery to rebuild gtkbuiltincache.h.
443 2005-11-04 Michael Natterer <mitch@imendio.com>
445 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
446 from maemo-gtk that changes the mtime check for rc files from
447 '>' to '!=', otherwise theme changes go unnoticed when turning
448 back the clock (Tommi Komulainen).
450 2005-11-04 Tor Lillqvist <tml@novell.com>
452 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
455 2005-11-03 Tor Lillqvist <tml@novell.com>
457 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
458 the Win32 backend, check that GdkDisplay* parameters are equal to
459 _gdk_display instead of using the unnecessarily general
462 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
463 color bitmap to have "color" in their name, for similarity with
464 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
465 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
466 the mask bitmap's contents, ones for those pixels in the color
467 bitmap where the alpha is zero, zero for other pixels. We used to
468 use an uninitialized mask bitmap! This meant that icons and
469 cursors created presumably worked more or less by accident.
470 Totally blank icons with zero alpha everywhere (as used by
471 gtktrayicon.c) definitely did not work as expected.
473 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
475 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
476 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
477 necessary and can be removed from CVS. It has never been mentioned
478 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
479 are used on Win32. One label widget is used (but never shown) as
480 gtk_widget_render_icon() needs a widget.
482 Ifdefs used as necessary in several places. It might be cleaner to
483 split out the backend-specific parts to separate files, or at
484 least collect them into separate blocks in the file.
486 (wndproc): New function. Window procedure to monitor mouse events
487 in the system tray icon. Call gtk_status_icon_button_press() as
489 (create_tray_observer): New function. Creates a hidden window that
490 only serves as a tray icon message observer.
492 * tests/teststatusicon.c (icon_activated): Position the dialog
493 with GTK_WIN_POS_CENTER.
494 (do_quit): New function, hide and unref the GtkStatusIcon, and
495 call gtk_main_quit().
496 (popup_menu): Add a Quit menu item that calls do_quit().
498 2005-11-02 Tor Lillqvist <tml@novell.com>
500 * gdk/win32/gdkcolor-win32.c
501 * gdk/win32/gdkscreen-win32.c
502 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
503 fixes. Remove superfluous test for GdkWindow* parameters being
504 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
505 GdkScreen and one GdkDisplay in the Win32 backend, use those
506 variables instead of the getter functions. For GdkDisplay* and
507 GdkScreen* parameters, check that they are equal to the
508 corresponding singleton variables instead of the more general
509 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
511 2005-11-02 Matthias Clasen <mclasen@redhat.com>
513 * gtk/gtktextview.c: Remove some g_return_if_fail() from
514 static functions, replace some others by g_assert().
516 * gtk/gtktextview.c (selection_motion_event_handler)
517 (gtk_text_view_start_selection_drag): Keep track of the original
518 selection boundaries during a drag selection, in order to correctly
519 decide when to extend or shrink the selection. (#320167,
520 reported by Arvind S N, patch by Paolo Borelli)
522 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
523 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
524 manual offset calculations by g_utf8_offset_to_pointer().
525 (#320360, Paolo Borelli)
527 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
529 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
530 nodes via the g_slice_*() API.
531 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
533 2005-11-01 Tor Lillqvist <tml@novell.com>
535 * gdk/win32/gdkprivate-win32.h
536 * gdk/win32/gdkglobals-win32.c
537 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
538 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
539 their declarations, definitions and assignments into a more
540 logical and consistent order.
542 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
543 CF_ prefix for the predefined clipboard format names. Put quotes
544 around registered format names to distinguish them.
546 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
547 immediately with a warning if the property type is STRING, TEXT,
548 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
549 should never pretend to handle on Win32. Handle only UTF8_STRING
550 here, other formats with delayed rendering. Use \uc1 instead of
551 \uc0 when generating Rich Text Format for easier testability on
552 XP, where WordPad misinterprets \uc0 encoded characters. Add more
553 GDK_NOTE debugging output for Clipboard operations.
555 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
556 (gdk_selection_convert): Don't pretent to handle STRING, just
557 UTF8_STRING. Streamline error handling, don't unnecessarily have a
558 GError which then isn't used for anything anyway if it gets set.
559 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
560 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
562 * config.h.win32.in: Sync with what configure produces.
564 * configure.in: Don't look for X_PACKAGES unless building for
565 x11. (#313986, John Ehresman)
567 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
569 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
570 Wondered why there was no ku there before??
572 2005-10-28 Matthias Clasen <mclasen@redhat.com>
574 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
575 window to the toplevels window group. (#319912, Christian Persch)
577 2005-10-28 Kristian Rietveld <kris@gtk.org>
579 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
582 2005-10-28 Matthias Clasen <mclasen@redhat.com>
584 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
585 drag cursors. (#319200, Federico Mena Quintero)
587 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
588 Shift-G to go to the previous match, like firefox. (#320061, Christian
591 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
592 C99ism. (#320000, Kazuki Iwamoto)
594 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
595 stars. (#319985, Bastien Nocera)
597 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
598 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
600 2005-10-26 Michael Natterer <mitch@imendio.com>
604 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
605 make sure that setting any of pixbuf/stock-id/icon-name resets the
606 others because they are mutually exclusive, and that unsetting any
607 of them only resets the pixbuf and nothing else. Also added
608 some missing g_object_notify().
610 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
611 g_value_set_object().
613 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
614 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
615 g_object_notify ("pixbuf").
617 2005-10-27 Matthias Clasen <mclasen@redhat.com>
619 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
620 careful about initializing cell_area. (#319382, Tommi
623 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
624 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
626 * demos/gtk-demo/clipboard.c (paste_received): Only set the
627 text if it is not NULL. (#319930, Thomas Klausner)
629 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
630 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
632 2005-10-26 Matthias Clasen <mclasen@redhat.com>
634 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
635 * gtk/gtkthemes.c (gtk_theme_engine_load):
636 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
637 when dlopening modules. (#319557, Laszlo Peter)
639 2005-10-26 Matthias Clasen <mclasen@redhat.com>
641 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
642 segments when determining text direction. (#319065, Tommi Komulainen)
644 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
645 on duplicate destroy. (#318953, Gustavo Carneiro)
647 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
648 Point out that destroy-with-parent is a bad idea for the dialog
649 passed to this function. (#318943, Christian Persch)
651 * */Makefile.am: use $(GLIB_MKENUMS) instead of
652 glib-mkenums. (#318582, Damien Carbery)
654 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
655 docs. (#317682, Christian Neumair)
657 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
658 seem to affect the placement of the data in the readonly
659 section, and causes problems with some compilers. (#317844)
661 2005-10-25 Matthias Clasen <mclasen@redhat.com>
663 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
664 Fix some issues with background drawing in RTL. (#318781,
668 * tests/testentrycompletion.c: Apply a patch by Christian
669 Persch to add property editors.
671 * gtk/gtkstatusicon.c: Emit activate on single-click,
672 not on double-click, change proposed by Milosz Derezynski.
674 2005-10-25 Kristian Rietveld <kris@gtk.org>
676 Fixes #311955, reported by Markku Vire; and a lot more.
678 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
679 Levels can now have invisible nodes cached, functions have been
680 rewritten/refactored to take this into account; also the logic in
681 some functions has been corrected.
683 Each referenced node now references all visible children or a single
684 invisible child, in order to be able to monitor all changes in the
685 child model required for correct operation.
687 When a virtual root is set, all nodes on the virtual root level are
690 At last, a bunch of random bug fixes and comment updates.
692 2005-10-25 Matthias Clasen <mclasen@redhat.com>
694 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
695 more docs. (#319722, Paolo Borelli)
697 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
698 initialization of screen_x11->xft_rgba more explicit. (#319627,
701 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
702 in a blurb. (#319499, Francisco Javier F. Serrador)
704 2005-10-24 Matthias Clasen <mclasen@redhat.com>
706 Add settings to hide the input method and Unicode control character
707 submenus in the context menus of GtkEntry and GtkTextView.
709 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
711 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
713 * gtk/gtktextview.c (popup_targets_received):
714 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
716 2005-10-24 Kristian Rietveld <kris@gtk.org>
718 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
719 row-has-child-toggled when the level is not in the cache does not
720 make sense. (This bug probably crept in during the early stages
721 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
723 (gtk_tree_model_sort_real_unref_node): only get the child iter
724 when we will actually also use it.
726 2005-10-22 Michael Natterer <mitch@imendio.com>
728 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
729 widget being realized, in addition to being visible, to avoid
730 running into precondition check in gtk_tree_view_get_cell_area().
733 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
735 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
736 Experimentally, scrollbar steppers can shrink to 8 pixels on
737 Win32. Reflect that in the theme.
738 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
739 there is a 1-pixel border between a scrollbar and its child
740 in ScrolledWindows on Win32. Reflect that in the theme.
742 2005-10-20 Matthias Clasen <mclasen@redhat.com>
744 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
745 for the selection window. (#318806, Alex Larsson)
747 2005-10-18 Federico Mena Quintero <federico@ximian.com>
751 * tests/autotestfilechooser.c
752 (test_button_folder_states_for_action): Test that we have either
753 $cwd or the explicitly-set folder.
754 (test_reload_sequence): Likewise.
756 * gtk/gtkfilechooserdefault.c
757 (gtk_file_chooser_default_get_current_folder): If our reload_state
758 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
760 2005-10-14 Tor Lillqvist <tml@novell.com>
762 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
763 It didn't really do anything useful, and was just confusing and
764 incomplete. Comments claimed we don't do delayed rendering, but in
765 fact we do, for images. (The delayed rendering code has other
766 problems, though, see #168173.) The clipboard viewer code was
767 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
768 the message when necessary). It was just test code, it said so in
769 a comment. Add something similar back later if necessary.
771 (_win32_on_clipboard_change,
772 _gdk_win32_register_clipboard_notification): Remove.
774 (gdk_display_supports_selection_notification,
775 gdk_display_request_selection_notification): Always just return
776 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
778 2005-10-13 Tor Lillqvist <tml@novell.com>
780 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
781 Alt-Enter specially. It does not have any special meaning and
782 should be passed on to the application. (#318378, Tim Evans)
784 2005-10-13 Tor Lillqvist <tml@novell.com>
786 Set visual depth to 24 for 32 bits-per-pixel devices on
787 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
788 optimized composite_0888() function rather than the slower image
789 dithering functions to draw pixbufs (#313993, John Ehresman)
791 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
792 _gdk_windowing_get_bits_for_depth() to initialize
793 GdkImage::bits_per_pixel.
794 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
796 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
797 _gdk_windowing_get_bits_for_depth() to initialize
798 BITMAPINFOHEADER::biBitCount.
800 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
801 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
804 2005-10-12 Stefan Kost <ensonic@users.sf.net>
806 * demos/gtk-demo/appwindow.c: (about_cb):
807 use PACKAGE_VERSION,bump year (#318654)
809 2005-10-11 Matthias Clasen <mclasen@redhat.com>
811 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
812 toggle here with the matching on toggle if it immediately follows.
813 This is a common case, and handling it here prevents quadratic blowup
814 in cleanup_line() below. (#317125)
816 * gtk/gtktextsegment.h:
817 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
818 the character counts into this function instead of computing them
821 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
823 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
825 * gtk/gtkfilechooserdefault.c
826 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
827 when the shortcut already exists in the sidebar. (#147521)
829 2005-10-09 Matthias Clasen <mclasen@redhat.com>
831 * tests/testcombo.c: Demonstrate how to use custom widgets in
834 2005-10-07 Federico Mena Quintero <federico@ximian.com>
838 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
839 the the result of gtk_file_chooser_get_folder() is NULL or
840 non-NULL at the right times. Log the tests.
841 (test_button_folder_states): New test for the initial states of
842 the current folder in GtkFileChooserButton.
843 (main): Test that the number of warnings/errors/critical errors is
846 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
847 Clarify the documentation on when this can return NULL.
848 (gtk_file_chooser_get_current_folder_uri): Likewise.
850 * gtk/gtkfilechooserbutton.c (struct
851 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
852 we use it to keep track of whether a folder has been set.
853 (gtk_file_chooser_button_map): Implement. If no folder has been
854 loaded before, we at least try to load $cwd here.
855 (gtk_file_chooser_button_constructor): If the construct-time
856 dialog already has a folder set, turn on our folder_has_been_set
858 (dialog_current_folder_changed_cb): Turn on our
859 folder_has_been_set flag.
861 2005-10-07 Michael Natterer <mitch@gimp.org>
863 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
864 PROFILE_FILE_CHOOSER because they break compilation after the
865 removal of <unistd.h>.
867 2005-10-07 Matthias Clasen <mclasen@redhat.com>
869 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
870 by moving it out of the profiling ifdef.
872 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
873 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
875 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
876 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
879 2005-10-06 Matthias Clasen <mclasen@redhat.com>
882 * gtk/gtktextbuffer.h:
883 * gtk/gtktextbuffer.c: Add a readonly has-selection property
884 with a getter. (#318161, Paolo Borelli)
886 2005-10-05 Matthias Clasen <mclasen@redhat.com>
888 * README.in: Start collecting release notes for 2.10.
890 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
891 leak fix, since the assertion failures were traced to
892 an xchat bug. (#314696)
894 * gtk/gtkstyle.c (gtk_style_detach):
895 (gtk_style_attach): Documentation improvements.
896 (gtk_style_detach): Assert that the attach_count is > 0.
898 2005-10-04 Federico Mena Quintero <federico@ximian.com>
900 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
901 shortcut position, not a ShortcutsIndex, to make the function more
903 (home_folder_handler): Pass the resolved index to
904 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
905 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
906 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
907 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
908 make the respective key switch to the first, second, ..., tenth
910 (quick_bookmark_handler): Implement.
912 2005-10-04 Federico Mena Quintero <federico@ximian.com>
914 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
915 Desktop; just use their real names on the file system for the
918 * gtk/gtkfilechooserdefault.c
919 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
920 binding signal, and bind it to M-d by default.
921 (desktop_folder_handler): Implement the default handler.
922 (home_folder_handler): Use a helper function.
923 (switch_to_shortcut): New helper function.
924 (shortcuts_append_home): Don't special-case the name of "Home";
925 just use the folder name.
927 2005-10-04 Tor Lillqvist <tml@novell.com>
929 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
930 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
932 2005-10-04 Matthias Clasen <mclasen@redhat.com>
934 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
935 from yesterday, since it leads to assertion failures. (#317879,
938 2005-10-03 Matthias Clasen <mclasen@redhat.com>
940 * gtk/gtkcalendar.c (gtk_calendar_init): Call
941 calendar_compute_days() after setting priv->week_start.
943 2005-10-03 Matthias Clasen <mclasen@redhat.com>
945 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
946 removing it from the hash table. (#314696, Benjamin Berg)
948 2005-10-01 Tor Lillqvist <tml@novell.com>
950 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
951 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
952 is that the the desktop isn't visible because the session has been
953 switched, the screen is locked, or a terminal server session
954 disconnected, so no error message necessary. (#137796)
956 It is of course remotely possible that BitBlt() failing with
957 ERROR_INVALID_HANDLE might also be caused by some other
958 problem. We could strive for perfection and track whether the
959 desktop is visible by using WTSRegisterSessionNotification() and
960 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
961 this issue, though. If we would track desktop visibility, we
962 should then avoid even trying to update the display at all while
963 the desktop isn't visible.
965 2005-09-30 Matthias Clasen <mclasen@redhat.com>
967 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
968 to correct the calculations for the first week day. We may
969 just have to remove this code if too many locales turn out
972 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
973 some cases. (#317611, Tommi Komulainen)
975 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
976 Prevent overflow when storing size hints in an unsigned
977 short variable. Tracked down by Ray Strode and Søren Sandmann.
979 2005-09-29 Matthias Clasen <mclasen@redhat.com>
981 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
984 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
985 grab shadowed. (#317332)
987 2005-09-29 Tor Lillqvist <tml@novell.com>
989 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
991 2005-09-28 Federico Mena Quintero <federico@ximian.com>
993 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
994 if the unmap test fails.
995 (test_reload_sequence): Use gtk_widget_show_now() instead of
996 gtk_widget_show() for the dialog.
997 Thanks to Tim Janik for noticing these.
999 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1001 * tests/testcellrenderertext.c: New file with a set of tests for
1002 GtkCellRendererText. The idea is to run a text renderer through
1003 most of its interesting property values to see that it works
1006 * tests/Makefile.am: Added testcellrenderertext.
1008 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
1009 entry/exit of this function for profiling.
1010 (gtk_file_chooser_default_style_set): Mark the start/end of the
1011 calls to the parent class and the the signal emission for profiling.
1013 2005-09-29 Tor Lillqvist <tml@novell.com>
1015 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
1016 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
1017 system codepage using g_win32_locale_filename_from_utf8().
1018 (#317457, Kazuki Iwamoto)
1020 2005-09-28 Matthias Clasen <mclasen@redhat.com>
1022 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
1023 here. (#317039, Paolo Borelli)
1026 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
1027 to make this function work as boxed copy function. (#317455,
1030 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
1031 NULL. (#316828, Tor Lillqvist)
1033 2005-09-28 Tor Lillqvist <tml@novell.com>
1035 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
1038 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1040 Don't reload the current folder unnecessarily on ::map().
1042 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
1043 the reloading state.
1044 (struct _GtkFileChooserDefault): Added a "reload_state" field.
1046 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
1047 Initialize impl->reload_state.
1048 (gtk_file_chooser_default_map): Check the impl->reload_state; load
1049 a default folder if no folder has been set, or reload the current
1050 one only if we had been unmapped first.
1051 (gtk_file_chooser_default_update_current_folder): Set the
1052 reload_state to RELOAD_HAS_FOLDER.
1053 (gtk_file_chooser_default_unmap): Implement, and set the
1054 reload_state to RELOAD_WAS_UNMAPPED.
1055 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
1056 here; they'll get (re)loaded on ::map() anyway.
1058 * gtk/gtkfilechooserwidget.c
1059 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
1061 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
1062 a dialog; build it ourselves.
1063 (test_reload): New test to ensure that we don't load the default
1064 folder more than once, and that we reload it when
1065 unmapping/remapping.
1066 (get_impl_from_dialog): New utility function.
1067 (test_widgets_for_current_action): Use get_impl_from_dialog().
1069 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1071 * gtk/gtkfilechooserdefault.c
1072 (gtk_file_chooser_default_constructor): Mark the entry/exit of
1073 this function for profiling.
1074 (check_icon_theme): Likewise.
1075 (change_icon_theme): Likewise.
1076 (settings_notify_cb): Likewise.
1077 (gtk_file_chooser_default_screen_changed): Likewise.
1078 (update_chooser_entry): If the selection is empty, clear the file
1079 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
1080 nothing will be selected when the user starts typeahead in the
1081 treeview, and we don't want to clear the file name entry in that
1082 case --- the user could be typing-ahead to look for a folder name.
1083 Fixes bug #308332, patch by Jürg Billeter.
1085 2005-09-27 Matthias Clasen <mclasen@redhat.com>
1087 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1088 Pop below the entry if there's more free space below the entry
1089 than above. (#316948, Tommi Komulainen)
1091 2005-09-26 Federico Mena Quintero <federico@ximian.com>
1093 Do not create the save mode-specific widgets in the open modes, so
1094 that we don't carry their baggage around.
1096 * gtk/gtkfilechooserdefault.c
1097 (gtk_file_chooser_default_constructor): Don't create the
1099 (save_widgets_create): Set the impl->save_widgets directly here,
1100 instead of passing the widgets back to the caller. Also, pack
1101 them into the impl's box.
1102 (update_appearance): Create or destroy the save widgets as
1103 appropriate. Set the action of the save_file_name_entry here.
1104 (shortcuts_add_current_folder): Set the active item in the
1105 save_folder_combo only if it exists.
1106 (gtk_file_chooser_default_set_property): Don't set the action of
1107 the save_file_name_entry here.
1108 (gtk_file_chooser_default_update_current_folder): Set the base
1109 folder of the save_file_name_entry only if the entry exists.
1110 (shortcuts_drag_data_received_cb): Cast the selection_data->data
1111 to (const char *) since that's what shortcuts_drop_uris() expects.
1112 (file_list_drag_data_received_cb): Likewise, for
1113 g_uri_list_extract_uris().
1115 2005-09-26 Tor Lillqvist <tml@novell.com>
1117 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
1118 the shaped flag here, too. (#316871)
1119 (gdk_window_shape_combine_region): Currently unimplemented, so
1120 don't do anything to the shaped flag here.
1122 2005-09-26 Matthias Clasen <mclasen@redhat.com>
1124 Fix #316871, reported by Dan Winship:
1126 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
1128 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
1129 (gdk_window_shape_combine_region): Set it here.
1131 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
1132 remove the child area for shaped windows.
1134 2005-09-23 Matthias Clasen <mclasen@redhat.com>
1136 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
1137 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
1139 2005-09-22 Michael Natterer <mitch@imendio.com>
1141 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
1142 consistent with GTK+ terminology:
1144 * gtk/gtkcellrendererkeys.[ch]
1145 * tests/testkeys.c: removed...
1147 * gtk/gtkcellrendereraccel.[ch]
1148 * tests/testaccel.c: ...and added.
1153 * tests/Makefile.am: changed accordingly.
1155 2005-09-22 Matthias Clasen <mclasen@redhat.com>
1157 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
1158 for the grab-broken-event signal, noticed by Damon Chaplin.
1160 2005-09-21 Tor Lillqvist <tml@novell.com>
1162 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
1163 gdk_text_property_to_text_list_for_display,
1164 gdk_text_property_to_utf8_list_for_display,
1165 gdk_win32_selection_add_targets,
1166 _gdk_win32_selection_convert_to_dib): Free return value from
1168 (gdk_text_property_to_text_list_for_display): Drop GError variable
1169 that isn't actually used after being set.
1171 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
1173 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
1176 2005-09-20 Tor Lillqvist <tml@novell.com>
1178 * gdk/win32/gdkselection-win32.c
1179 (gdk_selection_owner_get_for_display): Do return the correct owner
1180 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
1181 a window GDK knows about). The reason to return NULL seems to have
1182 gone when in the fix for bug #163702 the artificial
1183 GDK_SELECTION_CLEAR event generation was removed from
1184 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1186 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1188 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1189 events. (#151555, Søren Sandmann)
1191 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1192 XkbSelectEventDetails() to select XkbStateNotify events
1193 for only the state we care about.
1195 * gdk/x11/gdkprivate-x11.h:
1196 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1197 the event into the function and update the keymap state from
1198 the state information contained in the event. Adjust all callers.
1200 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1202 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1203 in multiple places to avoid segfaults if the index is out of range.
1204 (#316422, Guillaume Cottenceau)
1205 (gtk_icon_view_set_drag_dest_item):
1206 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1207 #316424, Guillaume Cottenceau)
1209 2005-09-18 Hans Breuer <hans@breuer.org>
1211 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1212 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1214 2005-09-18 Hans Breuer <hans@breuer.org>
1216 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1217 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1218 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1219 the icon and is blinking with teststatusicon. More to come ...
1221 2005-09-18 Hans Breuer <hans@breuer.org>
1223 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1224 cause gtkprogressbar.c has #include <config.h> conditionally; less
1225 noise from generated gtk.def
1226 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1228 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1229 For me it works as well as the *NIX implemenation, that is not at all.
1231 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1233 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1234 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1235 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1236 again - if compiled properly.
1238 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1239 already coming with Gtk+. Makes it compile on win32.
1241 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1243 * README.cvs-commits: fixed some tiny typos
1245 2005-09-16 Tor Lillqvist <tml@novell.com>
1247 * modules/engines/ms-windows/msw_style.c (draw_extension,
1248 draw_box_gap): Check whether the widget actually is a GtkNotebook
1249 before treating it as such. Drop some unneeded local variables,
1250 use parameter with same information instead. (#316412)
1252 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1254 * tests/autotestfilechooser.c: Start a set of automated tests for
1255 the file chooser. The only test in there right now doesn't pass
1256 yet. It specifies the intended behavior of the first optimization
1257 of a series which I'll do on the file chooser (see
1258 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1259 details of this optimization).
1261 * tests/Makefile.am: Added autotestfilechooser.c.
1263 * gtk/gtkfilechooserprivate.h (struct
1264 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1265 structures to here, so that they can be accessed by
1266 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1267 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1269 * gtk/gtkfilechooserdialog.c: See above.
1271 * gtk/gtkfilechooserwidget.c: See above.
1273 * gtk/gtkfilechooserdefault.c: See above.
1275 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1278 gtk_window_map_event(): new function to work around lost unmap requests.
1281 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1283 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1284 an easy-to-find profiling marker when starting to create a file
1286 (browse_files_model_finished_loading_cb): Likewise, for when the
1287 chooser is finished loading.
1289 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1291 * gtk/gtkcolorbutton.c: Check "color" argument in
1292 gtk_color_button_set_color ()
1294 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1296 * gtk/gtklabel.c (gtk_label_get_type):
1297 * gtk/gtkbutton.c (gtk_button_get_type):
1298 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1299 using a mem chunk for window groups, buttons, labels.
1301 * gtk/updateiconcache.c (foreach_remove_func): Fix
1302 a use-after-free bug. (#316256, Alexander Nedotsukov)
1304 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1306 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1308 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1310 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1312 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1313 Let GDK_Return pass through in some more cases.
1315 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1316 activating the entry.
1318 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1319 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1320 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1322 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1323 (#316001, Guillaume Cottenceau)
1325 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1326 mistake in the docs. (#315993, Guillaume Cottenceau)
1328 * tests/testentrycompletion.c (create_simple_completion_model): Add
1329 some strings containing multibyte characters.
1331 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1332 Fix prefix insertion for multibyte characters. (#316095,
1335 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1336 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1337 return NULL if the widget is not realized. (#316023,
1338 Guillaume Cottenceau)
1340 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1343 * gdk/gdkproperty.h:
1344 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1345 New function to avoid pointless strdups when creating atoms
1346 from static strings.
1349 * gtk/*.c: Use gdk_atom_intern_static_string() where
1352 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1354 * gtk/gtkcellrendererkeys.h:
1355 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1356 and editing accelerators, a port of EggCellRendererKeys .
1360 * gtk/Makefile.am: Add the keys cell renderer.
1362 * tests/Makefile.am:
1363 * tests/testkeys.c: Test GtkCellRendererKeys
1365 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1367 Make it possible to determine if a key event is for a
1370 * gdk/x11/gdkprivate-x11.h:
1371 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1372 New function to determine if a keycode is mapped to a modifier.
1373 (get_xkb): Get the modmap.
1375 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1376 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1378 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1381 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1383 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1384 unused variable, noticed by Kjartan Maraas.
1386 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1388 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1389 Make drag reordering work properly for columns other than the
1390 first. (#315054, Dan Winship)
1392 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1393 invalid fontnames better. (#136926, Michael R. Walton)
1395 Stop cursor blinking in non-editable regions of a text view.
1396 (#311508, Torbjörn Andersson)
1398 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1399 (cursor_blinks): Take editability into account when deciding
1400 whether the cursor blinks.
1401 (gtk_text_view_button_release_event):
1402 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1404 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1405 Use connect_after to connect to the focus_out event. This
1406 ensures that the entry has already stopped blinking by the time
1407 we emit the edited signal. (#315229, Thomas Leonard)
1409 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1411 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1412 unsigned ints to -1. (#315481, Kjartan Maraas)
1414 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1415 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1416 (#314473, Stanislav Brabec)
1418 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1420 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1421 memory handling. (#314975, Torsten Schoenfeld)
1423 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1424 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1425 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1426 * gtk/gtklabel.c (gtk_label_class_init):
1427 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1428 Stylistic improvements and clarifications for some blurbs.
1429 (#315520, Clytie Siddall)
1431 2005-09-09 Tor Lillqvist <tml@novell.com>
1433 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1434 display name. There is only one GdkDisplay on Win32, and
1435 constructing the display name isn't entirely trivial, so cacheing
1436 is probably worth it. For instance GIMP calls this function a lot.
1437 (gdk_display_open): Call gdk_display_get_name() to prime the
1439 (gdk_display_get_n_screens, gdk_display_get_screen,
1440 gdk_display_get_default_screen): Verify parameter correctness like
1441 the X11 backend does.
1443 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1444 Return a freshly allocated string, as the API specifies. Fixes a
1445 heap corruption problem that caused random errors and crashes in
1448 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1450 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1451 Make C-u commit and restart hex input if we are already in a
1454 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1456 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1457 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1458 if they are mapped to the same modifier.
1460 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1461 to gtkstatusicon.c and gtktrayicon-x11.c
1463 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1464 default accel mod mask.
1466 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1467 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1468 Don't use GDK_ALT_MASK.
1470 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1472 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1474 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1476 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1479 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1480 Mod2 - Mod5 and against Super, Hyper, Meta.
1482 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1483 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1484 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1486 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1487 modmap to maintain the information which X modifiers map to
1489 (get_xkb): Set up the modmap from the XKB tables.
1490 (update_keymaps): Set up the modmap from the information returned
1491 by XGetModifierMapping in the non-XKB case.
1493 * gdk/x11/gdkprivate-x11.h:
1494 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1495 function to set the virtual modifiers in the state.
1497 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1498 _gdk_keymap_add_virtual_modifiers here.
1500 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1501 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1504 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1506 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1507 if it has no child. (#315253, John Finlay)
1509 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1511 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1513 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1515 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1516 on destroy to avoid problems when they are called on a destroyed
1517 widget. (#315135, John Cupitt)
1519 * gtk/gtkentry.c (gtk_entry_class_init):
1520 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1521 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1523 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1524 code. Now we only steal a single key combination, Ctrl-Shift-U,
1526 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1527 by a sequence of hex digits entered with Ctrl-Shift still held.
1528 Releasing one of the modifiers or pressing space while the modifiers
1529 are still held commits the character. It is possible to erase
1530 digits using backspace.
1531 As an extension to the above, we also allow to start the sequence
1532 with Ctrl-Shift-U, then release the modifiers before typing any
1533 digits, and enter the digits without modifiers.
1534 (#82011, Owen Taylor)
1536 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1538 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1539 we still need to deliver the destroy event. (#314980, Chris Lahey)
1541 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1542 im context before committing \n or \t.
1544 2005-09-02 Alexander Larsson <alexl@redhat.com>
1546 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1547 (shortcuts_activate_volume):
1548 Handle base_path being null in the rest of the cases (#310270)
1550 2005-09-02 Tor Lillqvist <tml@novell.com>
1552 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1553 cursor position also in root window coordinates. Prune out
1554 superfluous WM_MOUSEMOVE events even earlier, based on root window
1555 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1556 window has ben mapped below the cursor even if the mouse doesn't
1557 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1558 confused at least gtk_menu_motion_notify(). (#314995)
1560 * gtk/gtkintl.h: No need to include config.h here. It caused
1561 warnings about GTK_LOCALEDIR being redefined on Win32 when
1562 compiling files where gtkintl.h is included after gtkprivate.h
1563 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1565 * gtk/gtkplug.c: Include config.h.
1567 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1569 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1570 xdg_mime_get_mime_type_for_file() where possible, to avoid
1573 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1574 typo. (#314921, Guillaume Cottenceau)
1576 * gdk/*.c: Intern some more strings.
1578 * gtk/*.c: Define an I_() macro and use it instead of the
1579 bulky g_intern_static_string().
1581 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1583 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1584 instead of copying it.
1586 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1588 * gtk/*.c: Also intern static strings passed to
1589 g_object_set_data().
1592 * gtk/Makefile.am: Intern type names in code generated by
1597 * gdk/*.c: Intern type names before registering the type to avoid
1600 * configure.in: Require GLib 2.9.0
1602 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1604 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1605 and add icon-size and icon-size-set properties. (#314172)
1607 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1608 groups across transient parents. (#312918, Christian Persch)
1610 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1611 Guillaume Cottenceau)
1613 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1614 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1616 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1618 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1619 make C-/ select all and C-\ unselect all. (#309301,
1622 * gtk/gtkimcontextsimple.c: Change the compose sequence for
1623 soft hyphen to be multi_key-minus-minus-space, and add
1624 compose sequences multi_key-minus-minus-period and
1625 multi_key-minus-minus-minus for en dash and em dash.
1626 (#172653, Christian Lohmaier)
1628 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
1629 code. (#313946, Christian Persch)
1631 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
1632 fix for the default value of the "ui" property.
1634 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1637 * gtk/gtkselection.h:
1638 * gtk/gtkselection.c: Add functions which look for text, image
1639 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1642 * gtk/gtkselection.h:
1643 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1644 Add a function to check wether targets include uri.
1645 (#314092, Mark Wielaard)
1649 * gtk/gtkwindow.c: Add a deletable property with getter
1650 and setter, to control the close button in the window
1651 frame. (#59718, Havoc Pennington)
1653 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1655 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1656 to the arrow keys for menu navigation. (#162825, Carl Worth)
1658 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1660 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1662 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1663 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1664 refer to nonexisting stock ids.
1666 * gtk/gtktextview.c (popup_targets_received):
1667 * gtk/gtkentry.c (popup_targets_received): Construct
1668 the "Select All" menuitem from stock.
1670 * gtk/stock-icons/stock_select_all_{16,24}.png:
1671 * gtk/stock-icons/Makefile.am:
1672 * gtk/gtkiconfactory.c:
1674 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1677 * gtk/gtktrayicon.c: Add a pointer to the spec.
1679 * gtk/gtkstatusicon-x11.c: Add docs.
1681 * gtk/gtkstatusicon.h: Fix a typo.
1683 Add a cross-platform "tray icon" API, by
1684 porting EggStatusIcon/EggTrayIcon (#105101)
1686 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1687 displays an icon in a notification area.
1689 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1690 X11, using GtkTrayIcon.
1692 * gtk/gtktrayicon.h:
1693 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1694 system tray specification, not public API.
1696 * gtk/gtk.symbols: Add new exported functions.
1698 * gtk/gtk.h: Include gtkstatusicon.h.
1700 * gtk/Makefile.am: Add new files.
1702 * tests/Makefile.am:
1703 * tests/teststatusicon.c: Test for GtkStatusIcon.
1705 2005-08-29 Christopher Aillon <caillon@redhat.com>
1707 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1708 and GTK_STOCK_DISCONNECT
1710 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1712 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1713 Use XFixesChangeSaveSet if available. (#314682)
1715 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1716 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1718 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1720 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1721 accidentally leftover duplicate pixbuf creation. (#314700,
1724 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1725 leak the cursor theme name. (#314693, Kjartan Maraas)
1727 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1728 state.children in all cases. (#313862, Kjartan Maraas)
1730 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1732 * po/POTFILES.in, po-properties/POTFILES.in:
1735 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1737 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1738 value of the ui property. (#314532, Yong Wang)
1740 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1741 when G_MAXLONG is passed as length.
1743 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1745 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1746 to avoid overloading --force. (JP Rosevaar)
1748 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1750 * configure.in: Bump version to 2.9.0
1754 * gdk/gdkscreen.c: Make the GdkScreen font options api
1755 public, and add properties GdkScreen::font-options and
1756 GdkScreen::resolution. (#314004)
1759 * gtk/gtksettings.c:
1760 * gtk/gtkwidget.c: Adjust all callers.
1762 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1763 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1764 * gdk/gdkscreen.c: Include gdkintl.h.
1766 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1767 variable warning, pointed out by Colin Walters. (#314585)
1769 2005-08-26 Tor Lillqvist <tml@novell.com>
1771 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1773 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1775 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1777 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1778 of week_start. (#314473, JP Rosevaar)
1780 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1782 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1783 lock. (#314533, Thomas Fitzsimmons)
1785 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1787 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1788 NULL gracefully. (#314523, Ed Catmur)
1790 2005-08-25 Owen Taylor <otaylor@redhat.com>
1792 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1793 Handle theme == NULL.
1795 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1797 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1798 y offset into account when positioning the popup. (#314470,
1801 2005-08-25 Owen Taylor <otaylor@redhat.com>
1803 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1804 as instance_init, not base_init! (#314452, Fix from Frederic
1805 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1806 rather than 1 for a negative flag value.
1808 2005-08-24 Owen Taylor <otaylor@redhat.com>
1810 * gdk/gdkpango.c (draw_error_underline): Add a note about
1811 cut-and-paste between here and Pango.
1813 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1815 * === Released 2.8.2 ===
1817 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1818 callback for image/gif, and also try image/bmp. (#314086, Mark
1821 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1822 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1827 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1828 and cursor settings get propagated down to the screen initially.
1829 Pointed out by Frederic Crozat.
1831 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1832 message if the screen is NULL. Noticed by Kjartan Maraas.
1834 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1838 * === Released 2.8.1 ===
1842 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1844 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1845 against lazy filterers which return values other than TRUE or
1846 FALSE from their visible func. (#314335)
1848 2005-08-23 Owen Taylor <otaylor@redhat.com>
1850 Fix for #314004, reported by Michael Reinsch:
1853 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1854 Add gdk_screen_get/set_resolution_libgtk_only()
1856 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1857 the options for the screen on the newly created context.
1859 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1860 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1861 the font options on the screen.
1863 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1864 the font options from the screen and set them on the context.
1866 2005-08-23 Kristian Rietveld <kris@gtk.org>
1868 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1869 bother inserting new rows in a level with a zero refcount and
1870 immediately free the level. (Fixes #312350, reported by Markku Vire).
1872 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1874 * gtk/updateiconcache.c: Complain when there is no index.theme file
1875 in the specified directory, unless --force is used. Also add an
1876 --index-only option to create caches without image data.
1878 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1879 C99ism. (#314262, Robert Jeff Mitchell)
1881 2005-08-22 Manish Singh <yosh@gimp.org>
1883 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1885 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1887 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1889 * gtk/gtkwindow.c (gtk_window_client_event):
1890 * gtk/gtkicontheme.c (ensure_valid_themes)
1891 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1892 scheme for makeing sure that all GTK+ applications notice if an
1893 icon theme has been updated. This should prevent multiple versions
1894 of an icon theme cache to be mapped in memory at the same time,
1895 which can cause excessive memory consumption. (#313156, Chris
1898 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1900 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1901 regarding icon theme changes.
1903 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1904 pixbufs which are backed by the mmapped memory of an icon cache,
1905 increase the refcount of the icon cache, so that the memory is not
1906 munmapped away underneath the pixbuf upon icon theme changes.
1907 (#314170, Kjartan Maraas)
1909 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1910 to link against Xext. (#314062)
1912 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1913 overruns. (#314081, Hans Breuer)
1915 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1917 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1918 returned layout must not be modified.
1920 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1922 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1923 scroll_to_path if the model changes.
1925 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1926 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1927 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1928 we're realized, #312798
1929 (gtk_icon_view_set_model): clear scroll_to_path if the model
1932 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1934 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1935 (gtk_range_adjustment_value_changed): Don't queue a draw
1936 if the layout has not changed. (#313991, Benjamin Berg)
1938 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1940 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1943 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1946 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1947 (model_add_special, model_add_special, model_add_volumes):
1948 Handle pixbuf being NULL without warnings. Also, don't
1949 leak pixbuf references when the icon theme is changed.
1951 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1952 the user data on destroyed windows, since at best
1953 it can be a stale pointer. (#313953, Robin Green)
1955 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1957 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1958 (#313900, Sebastien Bacher)
1960 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1961 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1963 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1964 (xdnd_read_actions, get_client_window_at_coords_recurse):
1965 Free data returned from XGetWindowProperty.
1967 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1968 Free data returned from XGetWindowProperty. (313867, Kjartan
1971 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1972 children in all cases. (#313862, Kjartan Maraas)
1974 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1975 in the per-directory hash, even if they come from the icon cache.
1976 We tried to avoid that before, but as a result leaked icon data
1977 structs. (#313852, Kjartan Maraas)
1979 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1981 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1982 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1984 2005-08-15 Owen Taylor <otaylor@redhat.com>
1986 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1987 files for x11/xext. (Jonas Bonn)
1989 2005-08-15 Tor Lillqvist <tml@novell.com>
1991 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1994 2005-08-15 Owen Taylor <otaylor@redhat.com>
1996 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1998 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1999 (#313417, James Andrewartha)
2001 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
2002 FcNameConstant(). (More of #313417)
2004 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2006 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
2007 modal dialogs, make sure to inherit the window group from
2008 the parent, since we don't inherit window groups across
2009 transient parents currently. (#312918, Christian Persch)
2011 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
2012 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
2014 * gtk/gtkiconview.c (gtk_icon_view_select_path)
2015 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
2016 gracefully. (#312796, Jonathan Blandford)
2018 * tests/testtoolbar.c: Add some more tests for menu placement.
2020 * gtk/gtkmenutoolbutton.c (menu_position_func):
2021 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
2022 of toolbutton menus and of the overflow menu. (#312937,
2023 #153870, Christian Persch, Paolo Borelli)
2025 2005-08-15 Tor Lillqvist <tml@novell.com>
2027 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
2028 the nonportable <libgen.h> and dirname().
2030 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2032 * gtk/gtksizegroup.c: Use object data to mark widgets and
2033 groups as visited, so that we avoid constant extra list
2034 traversals. Also allocate quarks in class_init. (#311618,
2037 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
2038 download location for the hicolor icon theme. (#313475, Olexiy
2041 * gtk/gtkicontheme.c: Remove debug spew.
2043 2005-08-15 Owen Taylor <otaylor@redhat.com>
2045 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
2046 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
2047 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
2048 Handle pixmap == NULL when checking for a colormap.
2051 2005-08-14 Matthias Clasen <mclasen@redhat.com>
2053 * gtk/updateiconcache.c: Store only one copy of the pixel data
2054 for symlinked icons. To achieve this, maintain a hashtable
2055 mapping pathnames to pixel data, and share the pixel data for
2056 all symlinks resolving to the same pathname. When writing out
2057 the image data, write out the pixel data only the first time
2058 it is met, and store the offset pointing to the first copy
2059 for use in all later cases.
2060 This reduces the size of the Bluecurve icon cache from 40