1 2005-11-21 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtksocket.c: Convert GtkSocket to g_type_class_add_private.
5 * gtk/gtkmenu.c: Convert GtkMenu to g_type_class_add_private.
8 * gtk/gtkcombobox.[hc]: Add a tearoff-title property,
9 with getter and setter. (#316482, Olexiy Avramchenko)
11 * tests/testcombo.c (main): Test gtk_combo_box_set_title
13 * gtk/gtkpathbar.c: Merge remaining fixes from the 2.8 branch,
14 pointed out by Michael Natterer.
16 Fix for bug #321542, Benedikt Meurer:
18 * gtk/gtkcombobox.c (gtk_combo_box_set_active_internal):
21 (gtk_combo_box_child_show, gtk_combo_box_child_hide): Use
22 g_signal_emit, not g_signal_emit_by_name.
24 2005-11-18 Matthias Clasen <mclasen@redhat.com>
26 Fix crashes in connection with pathbar scrolling (#321560,
29 * gtk/gtkpathbar.c (gtk_path_bar_update_slider_buttons):
30 Stop scrolling when desensitising slider buttons.
31 (gtk_path_bar_scroll_timeout, gtk_path_bar_slider_button_press):
34 * gtk/gtkpathbar.h (struct _GtkPathBar): Add a separate
37 2005-11-18 Matthias Clasen <mclasen@redhat.com>
39 * gtk/gtkpathbar.c (button_clicked_cb): Fix a C99ism.
40 (#321777, Jens Granseuer)
42 * gtk/gtkaction.c (disconnect_proxy): Disconnect the
43 sync callback for the visibility property. (#321761,
46 Turn off input methods in invisible entries, since
47 they are confusing. (#317002, James Su)
49 * gtk/gtkentry.c (gtk_entry_set_visibility): Toggle input
50 methods if visibility changes.
51 (popup_targets_received): Don't show the input method
52 menu if the entry is invisible.
54 2005-11-17 Matthias Clasen <mclasen@redhat.com>
56 * README.in: Add a note about range arrow sensitivity.
58 * perf/treeview.c: const correctness fixes
59 found by Arjan van de Ven and gcc.
61 2005-11-16 Michael Natterer <mitch@imendio.com>
63 * gtk/gtkimage.c (animation_timeout): call
64 gtk_window_process_updates() so the animation keeps running even
65 if the main loop is busy with sources that eat a lot of cpu with
66 high priority. Fixes bug #321444.
68 (gtk_image_new_from_animation): document the fact that the
69 animation will stop running if the main loop is busy with sources
70 that have priorities higher than G_PRIORITY_DEFAULT.
72 * tests/testimage.c: added test case that shows an animation even
73 though a cpu-eating idle function is running.
75 2005-11-16 Michael Natterer <mitch@imendio.com>
77 * gdk/x11/gdkevents-x11.c (_gdk_events_uninit): new internal
78 function which destroys the display's event source. Also removes
79 the source from the global display_sources list and unrefs it.
81 * gdk/x11/gdkprivate-x11.h: declare the function.
83 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_dispose): call it
84 instead of half-destroying the source here.
86 2005-11-15 Matthias Clasen <mclasen@redhat.com>
88 * gtk/gtktreestore.c (gtk_tree_store_move): Fix a memory
89 leak. (#321032, Peter Zelezny)
91 2005-11-15 Michael Natterer <mitch@imendio.com>
93 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_finalize): destroy
94 display->xid_ht as late as possible (right before XCloseDisplay)
95 because it still needs to be around when the display's screens are
98 2005-11-14 Matthias Clasen <mclasen@redhat.com>
100 * gtk/gtkselection.c (gtk_selection_data_set_uris): Don't
101 leak result. (#321441, Tommi Komulainen)
103 2005-11-14 Matthias Clasen <mclasen@redhat.com>
105 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes):
106 Don't crash if there is no builtin icon.
108 2005-11-14 Michael Natterer <mitch@imendio.com>
110 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_set_property):
111 removed redundant calls to g_object_notify().
113 2005-11-13 Matthias Clasen <mclasen@redhat.com>
115 * gdk/gdkcolor.c (gdk_color_parse): Documentation
116 improvements. (#321338)
118 * gtk/gtktextiter.c (gtk_text_iter_forward_search): Make
119 limit an inclusive boundary. (#321299)
121 2005-11-12 Michael Natterer <mitch@imendio.com>
123 * gtk/Makefile.am: fixed icon rules so gtkbuiltincache.h is only
126 2005-11-12 Dom Lachowicz <cinamod@hotmail.com>
128 * modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
129 theme's handling of toolbars, handleboxes, and menubars more in-line
130 with Microsoft's IE style.
131 * modules/engines/ms-windows/*.c: Indentation cleanups
133 2005-11-12 Matthias Clasen <mclasen@redhat.com>
135 Make builtin icons work in gtk_window_set_icon_name()
136 (#321046, Maxim Udushlivy)
138 * gtk/gtkicontheme.c (insert_theme): Always insert the default
140 (ensure_valid_themes): Call _gtk_icon_theme_ensure_builtin_cache()
142 (theme_lookup_icon, find_builtin_icon): ...and not from here.
143 (gtk_icon_theme_lookup_icon): Remove an unncessary assert.
144 (gtk_icon_theme_get_icon_sizes): Also check builtin icons.
146 2005-11-12 Tor Lillqvist <tml@novell.com>
148 * gtk/gtkfilesystemwin32.c (filename_get_info): Don't hide
149 dotfiles, no such convention on Win32. Just hide files with the
150 hidden attribute. (#314627)
152 2005-11-11 Federico Mena Quintero <federico@ximian.com>
154 * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Do not
155 check whether the path is a folder. It is useful to bookmark
156 files as well (e.g. todo.txt), and this will also help
158 (shortcuts_add_bookmark_from_path): Likewise.
159 (shortcuts_activate_iter): Change folders or select files, as
162 2005-11-11 Federico Mena Quintero <federico@ximian.com>
164 * tests/autotestfilechooser.c (main): Use
165 g_log_set_default_handler() instead of explicitly setting a
166 handler for each domain.
168 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Only get
169 the base path of the volume if it is mounted.
171 2005-11-11 Michael Natterer <mitch@imendio.com>
173 Added per-stepper API for GtkRange's stepper sensitivity as
174 discussed in bug #321056:
176 * gtk/gtkenums.h: added GtkSensitivityType which can be
179 * gtk/gtkrange.[ch]: added properties "lower-stepper-sensitivity"
180 and "upper-stepper-sensitivity" and public getters/setters for
181 them. Changed stepper drawing to honor the new properties.
183 * gtk/gtk.symbols: added the new symbols.
185 2005-11-10 Matthias Clasen <mclasen@redhat.com>
187 * gtk/gtkcombobox.c: Add show-popup and hide-popup signals and
188 emit them when the popup is shown or hidden. (#162531, Tommi
191 * tests/testcombo.c: Add an example of popuplating a combobox
194 * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Another
197 * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
200 Don't corrupt odd keymaps (#316638, Kean Johnston)
202 * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
203 handle frobbing keymaps with odd numbers of syms/code.
205 * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
208 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
210 * gtk/gtkpathbar.[hc]: Add a child_path argument to
211 the path_clicked signal.
212 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
213 child_path, if it is provided.
214 * gtk/marshalers.list (path_bar_clicked): Add the necessary
217 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
222 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
223 (#163851, Richard Hult)
225 2005-11-10 Michael Natterer <mitch@imendio.com>
227 Applied patch from maemo-gtk that addresses many issues wrt
228 display migration and display closing (bug #85715).
230 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
231 default display to NULL when it's closed. Instead set the most
232 recently opened display as new default (if one exists).
234 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
237 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
238 exist before unrefing them.
240 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
241 is closed, allow destruction of the root window.
243 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
244 dispose(), free stuff that was leaked before.
246 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
247 the xsettings_client still exists before destroying it.
249 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
252 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
253 dispose() implementation.
255 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
256 dispose() and check if it still exists before unrefing it. Set
257 their pointers to NULL/None *after* upchaining in dispose(),
258 because X11 implementations of members of the parent class still
259 need them for their own destruction.
261 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
262 was g_error()ing when finalizing a visual.
264 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
265 get_clipboard_widget() because it would create the widget if it
266 doesn't exist. Use g_object_get_data() directly instead.
268 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
271 2005-11-10 Simos Xenitellis <simos@gnome.org>
273 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
275 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
277 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
278 to render its arrows insensitive when the adjustment is in
279 its min or max position. this makes range arrow behaviour
280 consistent with spin button behaviour. (#321056)
282 2005-11-09 Tor Lillqvist <tml@novell.com>
285 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
286 the GdkDebugFlag enum.
288 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
289 this file instead of MISC. Now asking for MISC will give mainly
290 window manipulation debugging output with the Win32 backend.
292 2005-11-09 Tor Lillqvist <tml@novell.com>
294 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
296 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
297 function which was used only in one place.
299 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
301 (gdk_window_set_geometry_hints): If we have identical minimum and
302 maximum size hints, remove the resize and maximize
303 decorations/functions. (#104514)
305 If we have a maximum size hint, remove the maximize
306 decoration/function but ensure the resize decoration/function is
307 available. Otherwise ensure both resize and maximize
308 decorations/functions are there.
310 (set_or_clear_style_bits): Factored out common code from
311 gdk_window_set_decorations() and gdk_window_set_functions().
313 Hack the window style setting once more: Only touch the window
314 style bits corresponding to the GdkWMDecoration or GdkWMFunction
315 parameter bitmasks. Hopefully this finally is the correct thing to
316 do. We used to clear all other bits than those that were being
317 set, or set all other bits than those that were being cleared.
319 Take into account that adding or removing decorations leaves the
320 window's outer size unchanged, i.e., the client area's size and
321 position change. This is apparently not what we want, so change
322 also the window's (outer) position and size appropriately so that
323 the client area's position and size stay constant.
325 gtk-demo's color selector dialog is now non-resizable like on X11
326 (I tested with metacity in GNOME). Torn off menus are shrinkable
327 vertically but have a maximum size, and are not maximizable or
328 minimizable, like on X11.
330 (gdk_window_set_decorations, gdk_window_set_functions): Let
331 set_or_clear_decorations() do most of the job.
333 * gdk/win32/gdkprivate-win32.h: Remove declaration of
334 _gdk_win32_get_adjusted_client_rect().
336 2005-11-09 Tor Lillqvist <tml@novell.com>
338 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
339 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
340 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
341 type hint. Implement gdk_window_get_type_hint() by just returning
344 2005-11-09 Tor Lillqvist <tml@novell.com>
346 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
347 Remove code that has been permanently ifdeffed out for two years.
349 2005-11-08 Matthias Clasen <mclasen@redhat.com>
351 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
352 finalizing a gc. (#320789, Nickolay V. Shmyrev)
354 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
355 icons if they would make the request large enough to cause
356 Xlib to loose the connection. (#320909, Claudio Saavedra)
358 2005-11-08 Michael Natterer <mitch@imendio.com>
362 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
363 extracted from maemo-gtk). Fixes bug #320872.
365 2005-11-07 Matthias Clasen <mclasen@redhat.com>
367 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
368 looks the bookmark label when reordering. (#320720, Jeremy Cook)
370 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
371 Don't grab focus when a slider button is pressed, instead, use
372 a bit in the pathbar struct to determine whether to scroll up
373 or down. (#314486, Carlos Garnacho)
375 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
376 Don't popup the completions if the focus has already been
377 moved somewhere else. (#319914, Christian Persch)
379 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
380 Raise the drag_window after reconfiguring the
381 toolbar. (#320803, Christian Persch)
384 * gtk/gtkfilechooserbutton.h:
385 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
386 with setter and getter. (#318945, Christian Persch)
388 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
390 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
392 2005-11-07 Matthias Clasen <mclasen@redhat.com>
394 * configure.in: Adjust to the stock icon changes.
396 2005-11-07 Tor Lillqvist <tml@novell.com>
398 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
399 Correct the calculation of maskstride. (#320152, Peter Zelezny)
401 2005-11-06 Michael Natterer <mitch@imendio.com>
403 * gtk/Makefile.am (icons): fixed rule to actually create the
404 symlinks, erroring out if anything goes wrong.
406 2005-11-06 Tor Lillqvist <tml@novell.com>
408 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
409 target exists on Win32. First rename the target temporarily, then
410 if the renaming of the source to target fails, restore the
411 original name for the target.
413 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
415 2005-11-06 Tor Lillqvist <tml@novell.com>
417 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
418 like pixbuf_to_hbitmaps_normal().
419 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
420 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
421 setting the G_WIN32_PRETEND_WIN9X environment variable.
423 2005-11-06 Tor Lillqvist <tml@novell.com>
425 Make icon masks work on Win98 (#320152, Peter Zelezny)
427 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
428 parameter for the depth of the bitmap, so that this function can
429 be used to create 1-bit bitmaps, too.
430 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
431 and initialize it properly.
433 2005-11-04 Matthias Clasen <mclasen@redhat.com>
435 Store builtin stock icons in an icon cache, instead of
436 populating a hash table with pixbufs at startup, to save both
437 memory and startup time.
439 * gtk/stock-icons/*: Reorganize the icons in a directory structure
440 suitable for gtk-update-icon-cache, and rename them to match the
443 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
444 add _gtk_icon_cache_has_icon_in_directory().
446 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
447 to store the contents of the icon cache in a C header.
449 * gtk/gtkbuiltincache.h: Generated private header which contains
450 the icon cache for the builtin icons.
452 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
453 icons, and use that in addition to the hash table whenever
454 builtin icons are searched.
456 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
457 use it for static stock ids.
458 (get_default_icons): Don't add the builtin
459 icons to the icon theme, just register the stock ids.
460 (render_fallback_image): Take the fallback image out of the
463 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
464 the necessary machinery to rebuild gtkbuiltincache.h.
466 2005-11-04 Michael Natterer <mitch@imendio.com>
468 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
469 from maemo-gtk that changes the mtime check for rc files from
470 '>' to '!=', otherwise theme changes go unnoticed when turning
471 back the clock (Tommi Komulainen).
473 2005-11-04 Tor Lillqvist <tml@novell.com>
475 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
478 2005-11-03 Tor Lillqvist <tml@novell.com>
480 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
481 the Win32 backend, check that GdkDisplay* parameters are equal to
482 _gdk_display instead of using the unnecessarily general
485 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
486 color bitmap to have "color" in their name, for similarity with
487 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
488 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
489 the mask bitmap's contents, ones for those pixels in the color
490 bitmap where the alpha is zero, zero for other pixels. We used to
491 use an uninitialized mask bitmap! This meant that icons and
492 cursors created presumably worked more or less by accident.
493 Totally blank icons with zero alpha everywhere (as used by
494 gtktrayicon.c) definitely did not work as expected.
496 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
498 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
499 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
500 necessary and can be removed from CVS. It has never been mentioned
501 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
502 are used on Win32. One label widget is used (but never shown) as
503 gtk_widget_render_icon() needs a widget.
505 Ifdefs used as necessary in several places. It might be cleaner to
506 split out the backend-specific parts to separate files, or at
507 least collect them into separate blocks in the file.
509 (wndproc): New function. Window procedure to monitor mouse events
510 in the system tray icon. Call gtk_status_icon_button_press() as
512 (create_tray_observer): New function. Creates a hidden window that
513 only serves as a tray icon message observer.
515 * tests/teststatusicon.c (icon_activated): Position the dialog
516 with GTK_WIN_POS_CENTER.
517 (do_quit): New function, hide and unref the GtkStatusIcon, and
518 call gtk_main_quit().
519 (popup_menu): Add a Quit menu item that calls do_quit().
521 2005-11-02 Tor Lillqvist <tml@novell.com>
523 * gdk/win32/gdkcolor-win32.c
524 * gdk/win32/gdkscreen-win32.c
525 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
526 fixes. Remove superfluous test for GdkWindow* parameters being
527 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
528 GdkScreen and one GdkDisplay in the Win32 backend, use those
529 variables instead of the getter functions. For GdkDisplay* and
530 GdkScreen* parameters, check that they are equal to the
531 corresponding singleton variables instead of the more general
532 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
534 2005-11-02 Matthias Clasen <mclasen@redhat.com>
536 * gtk/gtktextview.c: Remove some g_return_if_fail() from
537 static functions, replace some others by g_assert().
539 * gtk/gtktextview.c (selection_motion_event_handler)
540 (gtk_text_view_start_selection_drag): Keep track of the original
541 selection boundaries during a drag selection, in order to correctly
542 decide when to extend or shrink the selection. (#320167,
543 reported by Arvind S N, patch by Paolo Borelli)
545 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
546 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
547 manual offset calculations by g_utf8_offset_to_pointer().
548 (#320360, Paolo Borelli)
550 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
552 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
553 nodes via the g_slice_*() API.
554 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
556 2005-11-01 Tor Lillqvist <tml@novell.com>
558 * gdk/win32/gdkprivate-win32.h
559 * gdk/win32/gdkglobals-win32.c
560 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
561 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
562 their declarations, definitions and assignments into a more
563 logical and consistent order.
565 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
566 CF_ prefix for the predefined clipboard format names. Put quotes
567 around registered format names to distinguish them.
569 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
570 immediately with a warning if the property type is STRING, TEXT,
571 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
572 should never pretend to handle on Win32. Handle only UTF8_STRING
573 here, other formats with delayed rendering. Use \uc1 instead of
574 \uc0 when generating Rich Text Format for easier testability on
575 XP, where WordPad misinterprets \uc0 encoded characters. Add more
576 GDK_NOTE debugging output for Clipboard operations.
578 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
579 (gdk_selection_convert): Don't pretent to handle STRING, just
580 UTF8_STRING. Streamline error handling, don't unnecessarily have a
581 GError which then isn't used for anything anyway if it gets set.
582 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
583 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
585 * config.h.win32.in: Sync with what configure produces.
587 * configure.in: Don't look for X_PACKAGES unless building for
588 x11. (#313986, John Ehresman)
590 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
592 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
593 Wondered why there was no ku there before??
595 2005-10-28 Matthias Clasen <mclasen@redhat.com>
597 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
598 window to the toplevels window group. (#319912, Christian Persch)
600 2005-10-28 Kristian Rietveld <kris@gtk.org>
602 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
605 2005-10-28 Matthias Clasen <mclasen@redhat.com>
607 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
608 drag cursors. (#319200, Federico Mena Quintero)
610 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
611 Shift-G to go to the previous match, like firefox. (#320061, Christian
614 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
615 C99ism. (#320000, Kazuki Iwamoto)
617 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
618 stars. (#319985, Bastien Nocera)
620 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
621 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
623 2005-10-26 Michael Natterer <mitch@imendio.com>
627 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
628 make sure that setting any of pixbuf/stock-id/icon-name resets the
629 others because they are mutually exclusive, and that unsetting any
630 of them only resets the pixbuf and nothing else. Also added
631 some missing g_object_notify().
633 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
634 g_value_set_object().
636 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
637 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
638 g_object_notify ("pixbuf").
640 2005-10-27 Matthias Clasen <mclasen@redhat.com>
642 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
643 careful about initializing cell_area. (#319382, Tommi
646 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
647 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
649 * demos/gtk-demo/clipboard.c (paste_received): Only set the
650 text if it is not NULL. (#319930, Thomas Klausner)
652 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
653 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
655 2005-10-26 Matthias Clasen <mclasen@redhat.com>
657 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
658 * gtk/gtkthemes.c (gtk_theme_engine_load):
659 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
660 when dlopening modules. (#319557, Laszlo Peter)
662 2005-10-26 Matthias Clasen <mclasen@redhat.com>
664 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
665 segments when determining text direction. (#319065, Tommi Komulainen)
667 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
668 on duplicate destroy. (#318953, Gustavo Carneiro)
670 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
671 Point out that destroy-with-parent is a bad idea for the dialog
672 passed to this function. (#318943, Christian Persch)
674 * */Makefile.am: use $(GLIB_MKENUMS) instead of
675 glib-mkenums. (#318582, Damien Carbery)
677 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
678 docs. (#317682, Christian Neumair)
680 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
681 seem to affect the placement of the data in the readonly
682 section, and causes problems with some compilers. (#317844)
684 2005-10-25 Matthias Clasen <mclasen@redhat.com>
686 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
687 Fix some issues with background drawing in RTL. (#318781,
691 * tests/testentrycompletion.c: Apply a patch by Christian
692 Persch to add property editors.
694 * gtk/gtkstatusicon.c: Emit activate on single-click,
695 not on double-click, change proposed by Milosz Derezynski.
697 2005-10-25 Kristian Rietveld <kris@gtk.org>
699 Fixes #311955, reported by Markku Vire; and a lot more.
701 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
702 Levels can now have invisible nodes cached, functions have been
703 rewritten/refactored to take this into account; also the logic in
704 some functions has been corrected.
706 Each referenced node now references all visible children or a single
707 invisible child, in order to be able to monitor all changes in the
708 child model required for correct operation.
710 When a virtual root is set, all nodes on the virtual root level are
713 At last, a bunch of random bug fixes and comment updates.
715 2005-10-25 Matthias Clasen <mclasen@redhat.com>
717 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
718 more docs. (#319722, Paolo Borelli)
720 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
721 initialization of screen_x11->xft_rgba more explicit. (#319627,
724 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
725 in a blurb. (#319499, Francisco Javier F. Serrador)
727 2005-10-24 Matthias Clasen <mclasen@redhat.com>
729 Add settings to hide the input method and Unicode control character
730 submenus in the context menus of GtkEntry and GtkTextView.
732 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
734 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
736 * gtk/gtktextview.c (popup_targets_received):
737 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
739 2005-10-24 Kristian Rietveld <kris@gtk.org>
741 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
742 row-has-child-toggled when the level is not in the cache does not
743 make sense. (This bug probably crept in during the early stages
744 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
746 (gtk_tree_model_sort_real_unref_node): only get the child iter
747 when we will actually also use it.
749 2005-10-22 Michael Natterer <mitch@imendio.com>
751 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
752 widget being realized, in addition to being visible, to avoid
753 running into precondition check in gtk_tree_view_get_cell_area().
756 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
758 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
759 Experimentally, scrollbar steppers can shrink to 8 pixels on
760 Win32. Reflect that in the theme.
761 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
762 there is a 1-pixel border between a scrollbar and its child
763 in ScrolledWindows on Win32. Reflect that in the theme.
765 2005-10-20 Matthias Clasen <mclasen@redhat.com>
767 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
768 for the selection window. (#318806, Alex Larsson)
770 2005-10-18 Federico Mena Quintero <federico@ximian.com>
774 * tests/autotestfilechooser.c
775 (test_button_folder_states_for_action): Test that we have either
776 $cwd or the explicitly-set folder.
777 (test_reload_sequence): Likewise.
779 * gtk/gtkfilechooserdefault.c
780 (gtk_file_chooser_default_get_current_folder): If our reload_state
781 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
783 2005-10-14 Tor Lillqvist <tml@novell.com>
785 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
786 It didn't really do anything useful, and was just confusing and
787 incomplete. Comments claimed we don't do delayed rendering, but in
788 fact we do, for images. (The delayed rendering code has other
789 problems, though, see #168173.) The clipboard viewer code was
790 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
791 the message when necessary). It was just test code, it said so in
792 a comment. Add something similar back later if necessary.
794 (_win32_on_clipboard_change,
795 _gdk_win32_register_clipboard_notification): Remove.
797 (gdk_display_supports_selection_notification,
798 gdk_display_request_selection_notification): Always just return
799 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
801 2005-10-13 Tor Lillqvist <tml@novell.com>
803 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
804 Alt-Enter specially. It does not have any special meaning and
805 should be passed on to the application. (#318378, Tim Evans)
807 2005-10-13 Tor Lillqvist <tml@novell.com>
809 Set visual depth to 24 for 32 bits-per-pixel devices on
810 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
811 optimized composite_0888() function rather than the slower image
812 dithering functions to draw pixbufs (#313993, John Ehresman)
814 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
815 _gdk_windowing_get_bits_for_depth() to initialize
816 GdkImage::bits_per_pixel.
817 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
819 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
820 _gdk_windowing_get_bits_for_depth() to initialize
821 BITMAPINFOHEADER::biBitCount.
823 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
824 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
827 2005-10-12 Stefan Kost <ensonic@users.sf.net>
829 * demos/gtk-demo/appwindow.c: (about_cb):
830 use PACKAGE_VERSION,bump year (#318654)
832 2005-10-11 Matthias Clasen <mclasen@redhat.com>
834 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
835 toggle here with the matching on toggle if it immediately follows.
836 This is a common case, and handling it here prevents quadratic blowup
837 in cleanup_line() below. (#317125)
839 * gtk/gtktextsegment.h:
840 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
841 the character counts into this function instead of computing them
844 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
846 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
848 * gtk/gtkfilechooserdefault.c
849 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
850 when the shortcut already exists in the sidebar. (#147521)
852 2005-10-09 Matthias Clasen <mclasen@redhat.com>
854 * tests/testcombo.c: Demonstrate how to use custom widgets in
857 2005-10-07 Federico Mena Quintero <federico@ximian.com>
861 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
862 the the result of gtk_file_chooser_get_folder() is NULL or
863 non-NULL at the right times. Log the tests.
864 (test_button_folder_states): New test for the initial states of
865 the current folder in GtkFileChooserButton.
866 (main): Test that the number of warnings/errors/critical errors is
869 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
870 Clarify the documentation on when this can return NULL.
871 (gtk_file_chooser_get_current_folder_uri): Likewise.
873 * gtk/gtkfilechooserbutton.c (struct
874 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
875 we use it to keep track of whether a folder has been set.
876 (gtk_file_chooser_button_map): Implement. If no folder has been
877 loaded before, we at least try to load $cwd here.
878 (gtk_file_chooser_button_constructor): If the construct-time
879 dialog already has a folder set, turn on our folder_has_been_set
881 (dialog_current_folder_changed_cb): Turn on our
882 folder_has_been_set flag.
884 2005-10-07 Michael Natterer <mitch@gimp.org>
886 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
887 PROFILE_FILE_CHOOSER because they break compilation after the
888 removal of <unistd.h>.
890 2005-10-07 Matthias Clasen <mclasen@redhat.com>
892 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
893 by moving it out of the profiling ifdef.
895 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
896 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
898 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
899 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
902 2005-10-06 Matthias Clasen <mclasen@redhat.com>
905 * gtk/gtktextbuffer.h:
906 * gtk/gtktextbuffer.c: Add a readonly has-selection property
907 with a getter. (#318161, Paolo Borelli)
909 2005-10-05 Matthias Clasen <mclasen@redhat.com>
911 * README.in: Start collecting release notes for 2.10.
913 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
914 leak fix, since the assertion failures were traced to
915 an xchat bug. (#314696)
917 * gtk/gtkstyle.c (gtk_style_detach):
918 (gtk_style_attach): Documentation improvements.
919 (gtk_style_detach): Assert that the attach_count is > 0.
921 2005-10-04 Federico Mena Quintero <federico@ximian.com>
923 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
924 shortcut position, not a ShortcutsIndex, to make the function more
926 (home_folder_handler): Pass the resolved index to
927 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
928 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
929 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
930 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
931 make the respective key switch to the first, second, ..., tenth
933 (quick_bookmark_handler): Implement.
935 2005-10-04 Federico Mena Quintero <federico@ximian.com>
937 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
938 Desktop; just use their real names on the file system for the
941 * gtk/gtkfilechooserdefault.c
942 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
943 binding signal, and bind it to M-d by default.
944 (desktop_folder_handler): Implement the default handler.
945 (home_folder_handler): Use a helper function.
946 (switch_to_shortcut): New helper function.
947 (shortcuts_append_home): Don't special-case the name of "Home";
948 just use the folder name.
950 2005-10-04 Tor Lillqvist <tml@novell.com>
952 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
953 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
955 2005-10-04 Matthias Clasen <mclasen@redhat.com>
957 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
958 from yesterday, since it leads to assertion failures. (#317879,
961 2005-10-03 Matthias Clasen <mclasen@redhat.com>
963 * gtk/gtkcalendar.c (gtk_calendar_init): Call
964 calendar_compute_days() after setting priv->week_start.
966 2005-10-03 Matthias Clasen <mclasen@redhat.com>
968 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
969 removing it from the hash table. (#314696, Benjamin Berg)
971 2005-10-01 Tor Lillqvist <tml@novell.com>
973 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
974 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
975 is that the the desktop isn't visible because the session has been
976 switched, the screen is locked, or a terminal server session
977 disconnected, so no error message necessary. (#137796)
979 It is of course remotely possible that BitBlt() failing with
980 ERROR_INVALID_HANDLE might also be caused by some other
981 problem. We could strive for perfection and track whether the
982 desktop is visible by using WTSRegisterSessionNotification() and
983 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
984 this issue, though. If we would track desktop visibility, we
985 should then avoid even trying to update the display at all while
986 the desktop isn't visible.
988 2005-09-30 Matthias Clasen <mclasen@redhat.com>
990 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
991 to correct the calculations for the first week day. We may
992 just have to remove this code if too many locales turn out
995 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
996 some cases. (#317611, Tommi Komulainen)
998 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
999 Prevent overflow when storing size hints in an unsigned
1000 short variable. Tracked down by Ray Strode and Søren Sandmann.
1002 2005-09-29 Matthias Clasen <mclasen@redhat.com>
1004 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
1007 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
1008 grab shadowed. (#317332)
1010 2005-09-29 Tor Lillqvist <tml@novell.com>
1012 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
1014 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1016 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
1017 if the unmap test fails.
1018 (test_reload_sequence): Use gtk_widget_show_now() instead of
1019 gtk_widget_show() for the dialog.
1020 Thanks to Tim Janik for noticing these.
1022 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1024 * tests/testcellrenderertext.c: New file with a set of tests for
1025 GtkCellRendererText. The idea is to run a text renderer through
1026 most of its interesting property values to see that it works
1029 * tests/Makefile.am: Added testcellrenderertext.
1031 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
1032 entry/exit of this function for profiling.
1033 (gtk_file_chooser_default_style_set): Mark the start/end of the
1034 calls to the parent class and the the signal emission for profiling.
1036 2005-09-29 Tor Lillqvist <tml@novell.com>
1038 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
1039 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
1040 system codepage using g_win32_locale_filename_from_utf8().
1041 (#317457, Kazuki Iwamoto)
1043 2005-09-28 Matthias Clasen <mclasen@redhat.com>
1045 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
1046 here. (#317039, Paolo Borelli)
1049 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
1050 to make this function work as boxed copy function. (#317455,
1053 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
1054 NULL. (#316828, Tor Lillqvist)
1056 2005-09-28 Tor Lillqvist <tml@novell.com>
1058 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
1061 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1063 Don't reload the current folder unnecessarily on ::map().
1065 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
1066 the reloading state.
1067 (struct _GtkFileChooserDefault): Added a "reload_state" field.
1069 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
1070 Initialize impl->reload_state.
1071 (gtk_file_chooser_default_map): Check the impl->reload_state; load
1072 a default folder if no folder has been set, or reload the current
1073 one only if we had been unmapped first.
1074 (gtk_file_chooser_default_update_current_folder): Set the
1075 reload_state to RELOAD_HAS_FOLDER.
1076 (gtk_file_chooser_default_unmap): Implement, and set the
1077 reload_state to RELOAD_WAS_UNMAPPED.
1078 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
1079 here; they'll get (re)loaded on ::map() anyway.
1081 * gtk/gtkfilechooserwidget.c
1082 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
1084 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
1085 a dialog; build it ourselves.
1086 (test_reload): New test to ensure that we don't load the default
1087 folder more than once, and that we reload it when
1088 unmapping/remapping.
1089 (get_impl_from_dialog): New utility function.
1090 (test_widgets_for_current_action): Use get_impl_from_dialog().
1092 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1094 * gtk/gtkfilechooserdefault.c
1095 (gtk_file_chooser_default_constructor): Mark the entry/exit of
1096 this function for profiling.
1097 (check_icon_theme): Likewise.
1098 (change_icon_theme): Likewise.
1099 (settings_notify_cb): Likewise.
1100 (gtk_file_chooser_default_screen_changed): Likewise.
1101 (update_chooser_entry): If the selection is empty, clear the file
1102 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
1103 nothing will be selected when the user starts typeahead in the
1104 treeview, and we don't want to clear the file name entry in that
1105 case --- the user could be typing-ahead to look for a folder name.
1106 Fixes bug #308332, patch by Jürg Billeter.
1108 2005-09-27 Matthias Clasen <mclasen@redhat.com>
1110 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1111 Pop below the entry if there's more free space below the entry
1112 than above. (#316948, Tommi Komulainen)
1114 2005-09-26 Federico Mena Quintero <federico@ximian.com>
1116 Do not create the save mode-specific widgets in the open modes, so
1117 that we don't carry their baggage around.
1119 * gtk/gtkfilechooserdefault.c
1120 (gtk_file_chooser_default_constructor): Don't create the
1122 (save_widgets_create): Set the impl->save_widgets directly here,
1123 instead of passing the widgets back to the caller. Also, pack
1124 them into the impl's box.
1125 (update_appearance): Create or destroy the save widgets as
1126 appropriate. Set the action of the save_file_name_entry here.
1127 (shortcuts_add_current_folder): Set the active item in the
1128 save_folder_combo only if it exists.
1129 (gtk_file_chooser_default_set_property): Don't set the action of
1130 the save_file_name_entry here.
1131 (gtk_file_chooser_default_update_current_folder): Set the base
1132 folder of the save_file_name_entry only if the entry exists.
1133 (shortcuts_drag_data_received_cb): Cast the selection_data->data
1134 to (const char *) since that's what shortcuts_drop_uris() expects.
1135 (file_list_drag_data_received_cb): Likewise, for
1136 g_uri_list_extract_uris().
1138 2005-09-26 Tor Lillqvist <tml@novell.com>
1140 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
1141 the shaped flag here, too. (#316871)
1142 (gdk_window_shape_combine_region): Currently unimplemented, so
1143 don't do anything to the shaped flag here.
1145 2005-09-26 Matthias Clasen <mclasen@redhat.com>
1147 Fix #316871, reported by Dan Winship:
1149 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
1151 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
1152 (gdk_window_shape_combine_region): Set it here.
1154 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
1155 remove the child area for shaped windows.
1157 2005-09-23 Matthias Clasen <mclasen@redhat.com>
1159 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
1160 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
1162 2005-09-22 Michael Natterer <mitch@imendio.com>
1164 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
1165 consistent with GTK+ terminology:
1167 * gtk/gtkcellrendererkeys.[ch]
1168 * tests/testkeys.c: removed...
1170 * gtk/gtkcellrendereraccel.[ch]
1171 * tests/testaccel.c: ...and added.
1176 * tests/Makefile.am: changed accordingly.
1178 2005-09-22 Matthias Clasen <mclasen@redhat.com>
1180 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
1181 for the grab-broken-event signal, noticed by Damon Chaplin.
1183 2005-09-21 Tor Lillqvist <tml@novell.com>
1185 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
1186 gdk_text_property_to_text_list_for_display,
1187 gdk_text_property_to_utf8_list_for_display,
1188 gdk_win32_selection_add_targets,
1189 _gdk_win32_selection_convert_to_dib): Free return value from
1191 (gdk_text_property_to_text_list_for_display): Drop GError variable
1192 that isn't actually used after being set.
1194 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
1196 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
1199 2005-09-20 Tor Lillqvist <tml@novell.com>
1201 * gdk/win32/gdkselection-win32.c
1202 (gdk_selection_owner_get_for_display): Do return the correct owner
1203 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
1204 a window GDK knows about). The reason to return NULL seems to have
1205 gone when in the fix for bug #163702 the artificial
1206 GDK_SELECTION_CLEAR event generation was removed from
1207 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1209 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1211 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1212 events. (#151555, Søren Sandmann)
1214 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1215 XkbSelectEventDetails() to select XkbStateNotify events
1216 for only the state we care about.
1218 * gdk/x11/gdkprivate-x11.h:
1219 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1220 the event into the function and update the keymap state from
1221 the state information contained in the event. Adjust all callers.
1223 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1225 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1226 in multiple places to avoid segfaults if the index is out of range.
1227 (#316422, Guillaume Cottenceau)
1228 (gtk_icon_view_set_drag_dest_item):
1229 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1230 #316424, Guillaume Cottenceau)
1232 2005-09-18 Hans Breuer <hans@breuer.org>
1234 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1235 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1237 2005-09-18 Hans Breuer <hans@breuer.org>
1239 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1240 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1241 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1242 the icon and is blinking with teststatusicon. More to come ...
1244 2005-09-18 Hans Breuer <hans@breuer.org>
1246 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1247 cause gtkprogressbar.c has #include <config.h> conditionally; less
1248 noise from generated gtk.def
1249 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1251 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1252 For me it works as well as the *NIX implemenation, that is not at all.
1254 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1256 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1257 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1258 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1259 again - if compiled properly.
1261 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1262 already coming with Gtk+. Makes it compile on win32.
1264 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1266 * README.cvs-commits: fixed some tiny typos
1268 2005-09-16 Tor Lillqvist <tml@novell.com>
1270 * modules/engines/ms-windows/msw_style.c (draw_extension,
1271 draw_box_gap): Check whether the widget actually is a GtkNotebook
1272 before treating it as such. Drop some unneeded local variables,
1273 use parameter with same information instead. (#316412)
1275 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1277 * tests/autotestfilechooser.c: Start a set of automated tests for
1278 the file chooser. The only test in there right now doesn't pass
1279 yet. It specifies the intended behavior of the first optimization
1280 of a series which I'll do on the file chooser (see
1281 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1282 details of this optimization).
1284 * tests/Makefile.am: Added autotestfilechooser.c.
1286 * gtk/gtkfilechooserprivate.h (struct
1287 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1288 structures to here, so that they can be accessed by
1289 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1290 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1292 * gtk/gtkfilechooserdialog.c: See above.
1294 * gtk/gtkfilechooserwidget.c: See above.
1296 * gtk/gtkfilechooserdefault.c: See above.
1298 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1301 gtk_window_map_event(): new function to work around lost unmap requests.
1304 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1306 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1307 an easy-to-find profiling marker when starting to create a file
1309 (browse_files_model_finished_loading_cb): Likewise, for when the
1310 chooser is finished loading.
1312 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1314 * gtk/gtkcolorbutton.c: Check "color" argument in
1315 gtk_color_button_set_color ()
1317 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1319 * gtk/gtklabel.c (gtk_label_get_type):
1320 * gtk/gtkbutton.c (gtk_button_get_type):
1321 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1322 using a mem chunk for window groups, buttons, labels.
1324 * gtk/updateiconcache.c (foreach_remove_func): Fix
1325 a use-after-free bug. (#316256, Alexander Nedotsukov)
1327 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1329 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1331 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1333 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1335 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1336 Let GDK_Return pass through in some more cases.
1338 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1339 activating the entry.
1341 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1342 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1343 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1345 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1346 (#316001, Guillaume Cottenceau)
1348 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1349 mistake in the docs. (#315993, Guillaume Cottenceau)
1351 * tests/testentrycompletion.c (create_simple_completion_model): Add
1352 some strings containing multibyte characters.
1354 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1355 Fix prefix insertion for multibyte characters. (#316095,
1358 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1359 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1360 return NULL if the widget is not realized. (#316023,
1361 Guillaume Cottenceau)
1363 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1366 * gdk/gdkproperty.h:
1367 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1368 New function to avoid pointless strdups when creating atoms
1369 from static strings.
1372 * gtk/*.c: Use gdk_atom_intern_static_string() where
1375 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1377 * gtk/gtkcellrendererkeys.h:
1378 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1379 and editing accelerators, a port of EggCellRendererKeys .
1383 * gtk/Makefile.am: Add the keys cell renderer.
1385 * tests/Makefile.am:
1386 * tests/testkeys.c: Test GtkCellRendererKeys
1388 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1390 Make it possible to determine if a key event is for a
1393 * gdk/x11/gdkprivate-x11.h:
1394 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1395 New function to determine if a keycode is mapped to a modifier.
1396 (get_xkb): Get the modmap.
1398 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1399 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1401 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1404 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1406 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1407 unused variable, noticed by Kjartan Maraas.
1409 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1411 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1412 Make drag reordering work properly for columns other than the
1413 first. (#315054, Dan Winship)
1415 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1416 invalid fontnames better. (#136926, Michael R. Walton)
1418 Stop cursor blinking in non-editable regions of a text view.
1419 (#311508, Torbjörn Andersson)
1421 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1422 (cursor_blinks): Take editability into account when deciding
1423 whether the cursor blinks.
1424 (gtk_text_view_button_release_event):
1425 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1427 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1428 Use connect_after to connect to the focus_out event. This
1429 ensures that the entry has already stopped blinking by the time
1430 we emit the edited signal. (#315229, Thomas Leonard)
1432 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1434 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1435 unsigned ints to -1. (#315481, Kjartan Maraas)
1437 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1438 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1439 (#314473, Stanislav Brabec)
1441 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1443 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1444 memory handling. (#314975, Torsten Schoenfeld)
1446 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1447 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1448 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1449 * gtk/gtklabel.c (gtk_label_class_init):
1450 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1451 Stylistic improvements and clarifications for some blurbs.
1452 (#315520, Clytie Siddall)
1454 2005-09-09 Tor Lillqvist <tml@novell.com>
1456 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1457 display name. There is only one GdkDisplay on Win32, and
1458 constructing the display name isn't entirely trivial, so cacheing
1459 is probably worth it. For instance GIMP calls this function a lot.
1460 (gdk_display_open): Call gdk_display_get_name() to prime the
1462 (gdk_display_get_n_screens, gdk_display_get_screen,
1463 gdk_display_get_default_screen): Verify parameter correctness like
1464 the X11 backend does.
1466 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1467 Return a freshly allocated string, as the API specifies. Fixes a
1468 heap corruption problem that caused random errors and crashes in
1471 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1473 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1474 Make C-u commit and restart hex input if we are already in a
1477 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1479 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1480 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1481 if they are mapped to the same modifier.
1483 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1484 to gtkstatusicon.c and gtktrayicon-x11.c
1486 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1487 default accel mod mask.
1489 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1490 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1491 Don't use GDK_ALT_MASK.
1493 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1495 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1497 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1499 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1502 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1503 Mod2 - Mod5 and against Super, Hyper, Meta.
1505 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1506 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1507 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1509 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1510 modmap to maintain the information which X modifiers map to
1512 (get_xkb): Set up the modmap from the XKB tables.
1513 (update_keymaps): Set up the modmap from the information returned
1514 by XGetModifierMapping in the non-XKB case.
1516 * gdk/x11/gdkprivate-x11.h:
1517 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1518 function to set the virtual modifiers in the state.
1520 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1521 _gdk_keymap_add_virtual_modifiers here.
1523 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1524 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1527 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1529 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1530 if it has no child. (#315253, John Finlay)
1532 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1534 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1536 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1538 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1539 on destroy to avoid problems when they are called on a destroyed
1540 widget. (#315135, John Cupitt)
1542 * gtk/gtkentry.c (gtk_entry_class_init):
1543 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1544 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1546 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1547 code. Now we only steal a single key combination, Ctrl-Shift-U,
1549 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1550 by a sequence of hex digits entered with Ctrl-Shift still held.
1551 Releasing one of the modifiers or pressing space while the modifiers
1552 are still held commits the character. It is possible to erase
1553 digits using backspace.
1554 As an extension to the above, we also allow to start the sequence
1555 with Ctrl-Shift-U, then release the modifiers before typing any
1556 digits, and enter the digits without modifiers.
1557 (#82011, Owen Taylor)
1559 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1561 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1562 we still need to deliver the destroy event. (#314980, Chris Lahey)
1564 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1565 im context before committing \n or \t.
1567 2005-09-02 Alexander Larsson <alexl@redhat.com>
1569 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1570 (shortcuts_activate_volume):
1571 Handle base_path being null in the rest of the cases (#310270)
1573 2005-09-02 Tor Lillqvist <tml@novell.com>
1575 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1576 cursor position also in root window coordinates. Prune out
1577 superfluous WM_MOUSEMOVE events even earlier, based on root window
1578 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1579 window has ben mapped below the cursor even if the mouse doesn't
1580 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1581 confused at least gtk_menu_motion_notify(). (#314995)
1583 * gtk/gtkintl.h: No need to include config.h here. It caused
1584 warnings about GTK_LOCALEDIR being redefined on Win32 when
1585 compiling files where gtkintl.h is included after gtkprivate.h
1586 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1588 * gtk/gtkplug.c: Include config.h.
1590 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1592 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1593 xdg_mime_get_mime_type_for_file() where possible, to avoid
1596 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1597 typo. (#314921, Guillaume Cottenceau)
1599 * gdk/*.c: Intern some more strings.
1601 * gtk/*.c: Define an I_() macro and use it instead of the
1602 bulky g_intern_static_string().
1604 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1606 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1607 instead of copying it.
1609 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1611 * gtk/*.c: Also intern static strings passed to
1612 g_object_set_data().
1615 * gtk/Makefile.am: Intern type names in code generated by
1620 * gdk/*.c: Intern type names before registering the type to avoid
1623 * configure.in: Require GLib 2.9.0
1625 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1627 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1628 and add icon-size and icon-size-set properties. (#314172)
1630 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1631 groups across transient parents. (#312918, Christian Persch)
1633 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1634 Guillaume Cottenceau)
1636 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1637 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1639 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1641 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1642 make C-/ select all and C-\ unselect all. (#309301,
1645 * gtk/gtkimcontextsimple.c: Change the compose sequence for
1646 soft hyphen to be multi_key-minus-minus-space, and add
1647 compose sequences multi_key-minus-minus-period and
1648 multi_key-minus-minus-minus for en dash and em dash.
1649 (#172653, Christian Lohmaier)
1651 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
1652 code. (#313946, Christian Persch)
1654 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
1655 fix for the default value of the "ui" property.
1657 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1660 * gtk/gtkselection.h:
1661 * gtk/gtkselection.c: Add functions which look for text, image
1662 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1665 * gtk/gtkselection.h:
1666 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1667 Add a function to check wether targets include uri.
1668 (#314092, Mark Wielaard)
1672 * gtk/gtkwindow.c: Add a deletable property with getter
1673 and setter, to control the close button in the window
1674 frame. (#59718, Havoc Pennington)
1676 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1678 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1679 to the arrow keys for menu navigation. (#162825, Carl Worth)
1681 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1683 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1685 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1686 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1687 refer to nonexisting stock ids.
1689 * gtk/gtktextview.c (popup_targets_received):
1690 * gtk/gtkentry.c (popup_targets_received): Construct
1691 the "Select All" menuitem from stock.
1693 * gtk/stock-icons/stock_select_all_{16,24}.png:
1694 * gtk/stock-icons/Makefile.am:
1695 * gtk/gtkiconfactory.c:
1697 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1700 * gtk/gtktrayicon.c: Add a pointer to the spec.
1702 * gtk/gtkstatusicon-x11.c: Add docs.
1704 * gtk/gtkstatusicon.h: Fix a typo.
1706 Add a cross-platform "tray icon" API, by
1707 porting EggStatusIcon/EggTrayIcon (#105101)
1709 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1710 displays an icon in a notification area.
1712 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1713 X11, using GtkTrayIcon.
1715 * gtk/gtktrayicon.h:
1716 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1717 system tray specification, not public API.
1719 * gtk/gtk.symbols: Add new exported functions.
1721 * gtk/gtk.h: Include gtkstatusicon.h.
1723 * gtk/Makefile.am: Add new files.
1725 * tests/Makefile.am:
1726 * tests/teststatusicon.c: Test for GtkStatusIcon.
1728 2005-08-29 Christopher Aillon <caillon@redhat.com>
1730 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1731 and GTK_STOCK_DISCONNECT
1733 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1735 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1736 Use XFixesChangeSaveSet if available. (#314682)
1738 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1739 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1741 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1743 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1744 accidentally leftover duplicate pixbuf creation. (#314700,
1747 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1748 leak the cursor theme name. (#314693, Kjartan Maraas)
1750 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1751 state.children in all cases. (#313862, Kjartan Maraas)
1753 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1755 * po/POTFILES.in, po-properties/POTFILES.in:
1758 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1760 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1761 value of the ui property. (#314532, Yong Wang)
1763 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1764 when G_MAXLONG is passed as length.
1766 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1768 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1769 to avoid overloading --force. (JP Rosevaar)
1771 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1773 * configure.in: Bump version to 2.9.0
1777 * gdk/gdkscreen.c: Make the GdkScreen font options api
1778 public, and add properties GdkScreen::font-options and
1779 GdkScreen::resolution. (#314004)
1782 * gtk/gtksettings.c:
1783 * gtk/gtkwidget.c: Adjust all callers.
1785 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1786 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1787 * gdk/gdkscreen.c: Include gdkintl.h.
1789 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1790 variable warning, pointed out by Colin Walters. (#314585)
1792 2005-08-26 Tor Lillqvist <tml@novell.com>
1794 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1796 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1798 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1800 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1801 of week_start. (#314473, JP Rosevaar)
1803 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1805 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1806 lock. (#314533, Thomas Fitzsimmons)
1808 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1810 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1811 NULL gracefully. (#314523, Ed Catmur)
1813 2005-08-25 Owen Taylor <otaylor@redhat.com>
1815 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1816 Handle theme == NULL.
1818 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1820 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1821 y offset into account when positioning the popup. (#314470,
1824 2005-08-25 Owen Taylor <otaylor@redhat.com>
1826 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1827 as instance_init, not base_init! (#314452, Fix from Frederic
1828 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1829 rather than 1 for a negative flag value.
1831 2005-08-24 Owen Taylor <otaylor@redhat.com>
1833 * gdk/gdkpango.c (draw_error_underline): Add a note about
1834 cut-and-paste between here and Pango.
1836 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1838 * === Released 2.8.2 ===
1840 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1841 callback for image/gif, and also try image/bmp. (#314086, Mark
1844 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1845 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1850 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1851 and cursor settings get propagated down to the screen initially.
1852 Pointed out by Frederic Crozat.
1854 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1855 message if the screen is NULL. Noticed by Kjartan Maraas.
1857 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1861 * === Released 2.8.1 ===
1865 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1867 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1868 against lazy filterers which return values other than TRUE or
1869 FALSE from their visible func. (#314335)
1871 2005-08-23 Owen Taylor <otaylor@redhat.com>
1873 Fix for #314004, reported by Michael Reinsch:
1876 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1877 Add gdk_screen_get/set_resolution_libgtk_only()
1879 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1880 the options for the screen on the newly created context.
1882 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1883 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1884 the font options on the screen.
1886 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1887 the font options from the screen and set them on the context.
1889 2005-08-23 Kristian Rietveld <kris@gtk.org>
1891 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1892 bother inserting new rows in a level with a zero refcount and
1893 immediately free the level. (Fixes #312350, reported by Markku Vire).
1895 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1897 * gtk/updateiconcache.c: Complain when there is no index.theme file
1898 in the specified directory, unless --force is used. Also add an
1899 --index-only option to create caches without image data.
1901 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1902 C99ism. (#314262, Robert Jeff Mitchell)
1904 2005-08-22 Manish Singh <yosh@gimp.org>
1906 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1908 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1910 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1912 * gtk/gtkwindow.c (gtk_window_client_event):
1913 * gtk/gtkicontheme.c (ensure_valid_themes)
1914 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1915 scheme for makeing sure that all GTK+ applications notice if an
1916 icon theme has been updated. This should prevent multiple versions
1917 of an icon theme cache to be mapped in memory at the same time,
1918 which can cause excessive memory consumption. (#313156, Chris
1921 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1923 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1924 regarding icon theme changes.
1926 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1927 pixbufs which are backed by the mmapped memory of an icon cache,
1928 increase the refcount of the icon cache, so that the memory is not
1929 munmapped away underneath the pixbuf upon icon theme changes.
1930 (#314170, Kjartan Maraas)
1932 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1933 to link against Xext. (#314062)
1935 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1936 overruns. (#314081, Hans Breuer)
1938 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1940 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1941 returned layout must not be modified.
1943 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1945 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1946 scroll_to_path if the model changes.
1948 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1949 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1950 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1951 we're realized, #312798
1952 (gtk_icon_view_set_model): clear scroll_to_path if the model
1955 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1957 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1958 (gtk_range_adjustment_value_changed): Don't queue a draw
1959 if the layout has not changed. (#313991, Benjamin Berg)
1961 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1963 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1966 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1969 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1970 (model_add_special, model_add_special, model_add_volumes):
1971 Handle pixbuf being NULL without warnings. Also, don't
1972 leak pixbuf references when the icon theme is changed.
1974 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1975 the user data on destroyed windows, since at best
1976 it can be a stale pointer. (#313953, Robin Green)
1978 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1980 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1981 (#313900, Sebastien Bacher)
1983 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1984 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1986 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1987 (xdnd_read_actions, get_client_window_at_coords_recurse):
1988 Free data returned from XGetWindowProperty.
1990 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1991 Free data returned from XGetWindowProperty. (313867, Kjartan
1994 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1995 children in all cases. (#313862, Kjartan Maraas)
1997 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1998 in the per-directory hash, even if they come from the icon cache.
1999 We tried to avoid that before, but as a result leaked icon data
2000 structs. (#313852, Kjartan Maraas)
2002 2005-08-18 Matthias Clasen <mclasen@redhat.com>
2004 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
2005 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
2007 2005-08-15 Owen Taylor <otaylor@redhat.com>
2009 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
2010 files for x11/xext. (Jonas Bonn)
2012 2005-08-15 Tor Lillqvist <tml@novell.com>
2014 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
2017 2005-08-15 Owen Taylor <otaylor@redhat.com>
2019 * configure.in: Fix have_base_pc / have_base_x_pc typo.
2021 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
2022 (#313417, James Andrewartha)
2024 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
2025 FcNameConstant(). (More of #313417)
2027 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2029 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
2030 modal dialogs, make sure to inherit the window group from
2031 the parent, since we don't inherit window groups across
2032 transient parents currently. (#312918, Christian Persch)
2034 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
2035 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
2037 * gtk/gtkiconview.c (gtk_icon_view_select_path)
2038 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
2039 gracefully. (#312796, Jonathan Blandford)
2041 * tests/testtoolbar.c: Add some more tests for menu placement.
2043 * gtk/gtkmenutoolbutton.c (menu_position_func):
2044 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
2045 of toolbutton menus and of the overflow menu. (#312937,
2046 #153870, Christian Persch, Paolo Borelli)
2048 2005-08-15 Tor Lillqvist <tml@novell.com>
2050 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
2051 the nonportable <libgen.h> and dirname().
2053 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2055 * gtk/gtksizegroup.c: Use object data to mark widgets and
2056 groups as visited, so that we avoid constant extra list
2057 traversals. Also allocate quarks in class_init. (#311618,
2060 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
2061 download location for the hicolor icon theme. (#313475, Olexiy
2064 * gtk/gtkicontheme.c: Remove debug spew.
2066 2005-08-15 Owen Taylor <otaylor@redhat.com>
2068 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
2069 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
2070 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
2071 Handle pixmap == NULL when checking for a colormap.
2074 2005-08-14 Matthias Clasen <mclasen@redhat.com>
2076 * gtk/updateiconcache.c: Store only one copy of the pixel data
2077 for symlinked icons. To achieve this, maintain a hashtable
2078 mapping pathnames to pixel data, and share the pixel data for
2079 all symlinks resolving to the same pathname. When writing out
2080 the image data, write out the pixel data only the first time
2081 it is met, and store the offset pointing to the first copy
2082 for use in all later cases.
2083 This reduces the size of the Bluecurve icon cache from 40