1 Tue Mar 26 14:46:50 2002 Owen Taylor <otaylor@redhat.com>
3 * gtk/gtkmenu.c (gtk_menu_popup): Shuffle the ordering around
4 some more (position before realizing) fixing problems with
5 arrows popping up at the wrong time (#73386), hopefully not
6 introducing other problems. (Reported by Ettore Perrazoli, others)
8 2002-03-26 Dave Camp <dave@ximian.com>
10 * gtk/gtktreeview.c (gtk_tree_view_button_press): Free the path
11 after calling gtk_tree_view_row_activated() rather than before.
13 2002-03-25 Sven Neumann <sven@gimp.org>
15 * gtk/gtkrc.c (gtk_rc_parse_font_name): free the style's
16 font_description before assigning a new one.
17 (gtk_rc_parse_stock): always unref the created icon_set. #76289
19 2002-03-25 Mark McLoughlin <mark@skynet.ie>
21 * gtk/gtkbindings.c: (gtk_binding_entry_add_signal),
22 kill code duplicated in gtk_binding_entry_add_signall.
24 Sun Mar 24 10:32:38 2002 Jonathan Blandford <jrb@redhat.com>
26 * gtk/gtktreemodel.c (gtk_tree_path_copy): Make path arg const, #75653
28 * gtk/gtkfontsel.c (gtk_font_selection_show_available_styles): fix
31 * gtk/gtktreeview.c (gtk_tree_view_button_press): remove the grab
32 when we emit row_activated so that listeners of this signal can
33 grab the mouse, #75629
35 2002-03-23 Havoc Pennington <hp@pobox.com>
37 * gtk/gtktextlayout.c (gtk_text_layout_real_invalidate):
38 invalidate the line containing start, even if the [start,end)
39 range is empty (just invalidate [start,end], essentially).
40 Partially fixes #72374
42 2002-03-23 Havoc Pennington <hp@pobox.com>
44 * gtk/gtktextview.c (gtk_text_view_do_popup): end any selection in
45 progress, patch from db@zigo.dhs.org, #74620
47 2002-03-23 Havoc Pennington <hp@pobox.com>
49 * gtk/gtktextview.c (gtk_text_view_move_cursor_internal): extend
50 selection for pageup/pagedown and ctrl+pageup/pagedown if
51 shift is held. more of #53934
53 2002-03-23 Havoc Pennington <hp@pobox.com>
55 * gtk/gtktextview.c (gtk_text_view_destroy_layout): disconnect
56 layout handlers earlier in the function, to avoid possible
58 (gtk_text_view_invalidate): Don't install idle handlers if
59 layout == NULL, otherwise we get problems during finalization
60 since clearing the buffer invalidates and puts the idle handlers
61 back after we destroy the layout. #74660
62 (gtk_text_view_ensure_layout): Install the validation handlers
63 right after creating the layout.
65 * gtk/gtktexttagtable.c (foreach_unref): call
66 _gtk_text_buffer_notify_will_remove_tag(), #75126
68 2002-03-22 Havoc Pennington <hp@pobox.com>
70 * gdk/x11/gdkfont-x11.c (gdk_fontset_load): add more explanatory
71 text to the error message about missing charsets, and use
72 g_printerr() not g_warning() since this is typically not a
73 programming error (we do not export any API to ask whether
74 a font set will have missing charsets so apps realistically can't
75 do anything other than try the gdk_fontset_load())
77 * gtk/gtktextview.c (gtk_text_view_key_press_event): return FALSE
78 if the text view isn't editable and the user presses Return,
79 so default buttons and such can be activated, #74937
81 * gtk/gtktextbuffer.c (paste_from_buffer): don't insert
82 if the insertion point is not editable and the paste
83 is interactive, #74125
85 * gtk/gtkwindow.c (gtk_window_move_resize): enhance the #if 0
88 * gtk/gtktextbuffer.c (cut_or_copy): only remove the previous
89 cut/copied data right before replacing it, when we know we are
90 going to replace it. Fixes #74049
92 2002-03-22 Richard Hult <rhult@codefactory.se>
94 * gdk/gdkevents.c (gdk_event_get_root_coords): Fix typo, where x
95 value was assigned to both x and y.
97 Fri Mar 22 11:29:11 2002 Owen Taylor <otaylor@redhat.com>
99 Partial fix for problem where keypad keys acted
100 as shift-arrows in an entry rather than arrows (#74327)
102 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Sort lookup
103 results by number of modifiers in the entry. Fixes
104 problem where if a key matched both modified and unmodified
105 key bindings ... e.g., the distinguishing key binding
106 was consumed, then it was random which was used.
108 * gtk/gtkbindings.c (gtk_binding_entries_sort_patterns):
109 Catch the case where there are multiple entries from the
110 same bindingset (with different modifiers), and use only
111 the first entry, which, with the change in _gtk_key_hash_lookup()
112 will be the preferred value.
114 Fri Mar 22 10:56:19 2002 Owen Taylor <otaylor@redhat.com>
116 * gtk/gtkaccelmap.c (gtk_accel_map_save_fd): Fix memory
117 leak. (#74400, Morten Welinder.)
119 * gtk/gtkaccelmap.c: Properly handle short returns from
120 write() calls. (Handling EINTR isn't enough... that only
121 handles the case where you were interrupted before you
122 wrote a single byte.)
124 * gdk/linux-fb/gdkmouse-fb.c gdk/linux-fb/gdkkeyboard-fb.c:
125 Robustify against short returns from write() calls.
127 Fri Mar 22 10:12:10 2002 Owen Taylor <otaylor@redhat.com>
129 * gtk/gtktextview.c (gtk_text_view_paint): Change
130 G_BREAKPOINT() to g_assert_not_reached ().
131 (#75865, Ashok Venkiteswaran)
133 2002-03-22 Tor Lillqvist <tml@iki.fi>
135 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Don't clear
136 all of the pen_style, just the PS_STYLE_MASK. Seems to fix #74441,
137 but that is just the special case of one-pixel wide one-pixel
138 on-off dotted lines. To fully implement generic X11 style dashed
139 lines a major rewrite would be needed.
141 2002-03-21 Matthias Clasen <maclas@gmx.de>
143 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Trivial typo
144 fix. (Vitaly Tishkov, #75726)
146 Thu Mar 21 10:04:05 2002 Owen Taylor <otaylor@redhat.com>
148 * gdk/gdkwindow.c (gdk_window_real_get_depth): Remove
149 some left over debugging code with a G_BREAKPOINT()
152 Wed Mar 20 19:33:31 2002 Owen Taylor <otaylor@redhat.com>
154 * gtk/gtkcalendar.c (gtk_calendar_main_button): When
155 changing months when the user clicks on a prev-month
156 or next-month day, focus and select the new day.
157 Ignore double clicks on prev-month, next-month days.
158 (Based on suggestions from Andras Salamon, #74173)
160 * gtk/gtkcalendar.c: Implement the focused/unfocused
161 selected color change.
163 2002-03-20 Alex Larsson <alexl@redhat.com>
165 Patches from Carlo E. Prelz <fluido@fluido.as>
166 Now gtkfb at least compiles and mostly works. The keyboard
167 stuff needs more loving.
169 * gdk/linux-fb/gdkkeyboard-fb.c (xlate_get_for_keyval,
170 xlate_get_for_keycode, raw_get_for_keyval, raw_get_for_keycode):
171 At least set the out parameters for these calls.
173 * gdk/linux-fb/gdkmain-fb.c:
174 (gdk_pointer_grab_info_libgtk_only, gdk_keyboard_grab_info_libgtk_only):
175 Implement new functions.
177 Wed Mar 20 19:00:03 2002 Owen Taylor <otaylor@redhat.com>
179 * gtk/gtkentry.c (gtk_entry_set_text): Short-circuit
180 the text to the exact same thing, so we don't
181 unexpectedly change the selection or cursor position.
182 (#74290, John Ellis.)
184 Thu Mar 21 00:05:14 2002 Kristian Rietveld <kris@gtk.org>
186 * gtk/gtktreeview.c (gtk_tree_view_get_background_area),
187 (gtk_tree_view_get_cell_area): fix logic (fixes #74235, #73593)
189 Wed Mar 20 17:11:51 2002 Owen Taylor <otaylor@redhat.com>
191 * gtk/gtkrc.c: Patch from Richard Hestilow to fix
192 gtk-font-name changes for widgets that get the actual
193 default style. (#73709)
195 Wed Mar 20 22:59:23 2002 Kristian Rietveld <kris@gtk.org>
197 * gtk/gtkrbtree.[ch]: add _gtk_rbtree_set_fixed_height()
199 * gtk/gtktreeprivate.h: add fixed_height_check field
201 * gtk/gtktreeview.c (gtk_tree_view_init): initialize
202 scroll_sync_timer and fixed_height_check
203 (do_validate_rows): add fixed_height_check. If all validated rows
204 in the first cycle have the same height, then we set that height for
205 the entire tree. This is some sort of 'fake' optimization, but helps
206 a lot for the common case. We keep validating the entire tree in
207 the background though.
208 (gtk_tree_view_set_model): reset fixed_height_check
210 Wed Mar 20 16:36:08 2002 Owen Taylor <otaylor@redhat.com>
212 * gtk/*.c: Patch from Erwann Chenede, #73900 fixing
213 a lot of warnings with Forte CC, mostly implicit
214 casts between void * and function pointers.
216 * gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's
217 state field is not a GdkModifierType. (Also #73900)
219 Wed Mar 20 12:35:22 2002 Owen Taylor <otaylor@redhat.com>
221 * gtk/gtkwidget.c (gtk_widget_grab_default): Remove
222 leftover notification of has-default. (#75508, Jacob
225 Wed Mar 20 12:27:07 2002 Owen Taylor <otaylor@redhat.com>
227 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Allow
228 arrow keys as accelerators, as long as some modifier
231 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Fix
232 incorrect example in the docs.
234 Wed Mar 20 12:06:30 2002 Owen Taylor <otaylor@redhat.com>
236 * gtk/gtkwidget.c (gtk_widget_set_child_visible):
237 Fix segfault when widget->parent is NULL.
238 (#75615, Alexey A. Malyshev)
240 Wed Mar 20 11:32:07 2002 Owen Taylor <otaylor@redhat.com>
242 * gtk/gtkentry.c: Improve test to prevent infinite
243 loop. (#74952, Thomas Leonard)
245 * gtk/gtkmenushell.c (gtk_real_menu_shell_cycle_focus):
246 Fix warning when toplevel menu shell isn't a menu
247 bar. (Thomas Leonard, #75602)
249 Wed Mar 20 11:00:59 2002 Owen Taylor <otaylor@redhat.com>
251 * configure.in: Use $PKG_CONFIG, not pkg-config.
252 (LEE Sau Dan, #75572)
254 Wed Mar 20 10:55:56 2002 Owen Taylor <otaylor@redhat.com>
256 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Fix assignment
257 of time in scroll events. (Sven Neumann, #75574)
259 2002-03-20 Tor Lillqvist <tml@iki.fi>
261 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window): Use
262 gdk_window_get_toplevel(), as it is the top-level windows that are
265 * gdk/win32/gdkwin32.h: Don't include gdkinternals.h.
267 2002-03-19 jacob berkman <jacob@ximian.com>
269 * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
270 gtk_combo_func() returns NULL (bug #75464)
272 2002-03-18 jacob berkman <jacob@ximian.com>
274 * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the
275 correct min/max values for the ratio property (fixes #75331)
277 Mon Mar 18 11:55:03 2002 Owen Taylor <otaylor@redhat.com>
279 * gtk/gtkimmulticontext.c (gtk_im_multicontext_get_slave):
280 Patch from Yao Zhang fixing reference count leak.
282 * gtk/gtkentry.c (gtk_entry_key_release): if (entry->editable),
283 not if (!entry->editable).
285 Mon Mar 18 11:09:17 2002 Owen Taylor <otaylor@redhat.com>
287 * gdk/x11/gdkwindow-x11.c (gdk_window_set_override_redirect):
288 Fix backwards conditional. (#75019, Dan Winship.)
290 Sun Mar 17 01:11:16 2002 Kristian Rietveld <kris@gtk.org>
292 * gtk/gtktreeview.c (gtk_tree_view_size_request): use
293 do_validate_rows instead of validate_rows_handler (fix by
296 Sat Mar 16 23:54:56 2002 Kristian Rietveld <kris@gtk.org>
298 * gdk/x11/gdkwindow-x11.c (gdk_window_set_static_bit_gravity): just
299 return when we have an input_only window (fix by Owen Taylor)
301 * gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): add
304 * gtk/gtktreeview.c (install_scroll_sync_handler): new function,
305 (scroll_sync_handler): ditto,
306 (gtk_tree_view_unrealize): take scroll_sync_timer into account
307 (gtk_tree_view_row_deleted): install scroll_sync_timer instead of
308 calling top_row_to_dy/dy_to_top_row directly
309 -- this greatly speeds up clearing the model (#73199)
311 * gtk/gtktreemodelsort.c
312 (gtk_tree_model_sort_convert_path_to_child_path): fix up this function,
313 for some reason I really screwed it up (fixes #74663)
315 2002-03-16 Sven Neumann <sven@gimp.org>
317 * configure.in (GDK_PIXBUF_DEP_CFLAGS) (GDK_PIXBUF_XLIB_DEP_CFLAGS)
318 (GDK_DEP_CFLAGS) (GTK_DEP_CFLAGS): include CFLAGS from gthread-2.0
319 so that the libs work correctly in a threaded environment.
321 Fri Mar 15 12:51:42 2002 Jonathan Blandford <jrb@redhat.com>
323 * gtk/gtktreeviewcolumn.c
324 (gtk_tree_view_column_new_with_attributes): add example to docs,
325 as people are seeming to have trouble with this function.
327 2002-03-15 Tor Lillqvist <tml@iki.fi>
329 * configure.in: Set MATH_LIB to empty also on Win32.
331 Fri Mar 15 15:37:01 2002 Owen Taylor <otaylor@redhat.com>
333 * gdk/x11/gdkdrawable-x11.c (convert_to_format):
334 Fix byte shift arithmetic for big-endian. (Tracked
335 down with help from Tuomas Kuosmanen)
337 Fri Mar 15 11:28:41 2002 Jonathan Blandford <jrb@redhat.com>
339 * gtk/gtktreeview.c (gtk_tree_view_insert_column_with_data_func):
340 make args const, 74159
341 (gtk_tree_view_insert_column_with_attributes): ditto
343 * gtk/gtktreeviewcolumn.c
344 (gtk_tree_view_column_cell_process_action): remov unused variables.
346 Fri Mar 15 13:31:51 2002 Soeren Sandmann <sandmann@daimi.au.dk>
348 * gtk/gtkmenu.c (gtk_menu_leave_notify): Fix test for "active
351 2002-03-15 Padraig O'Briain <padraig.obriain@sun.com>
353 * gdk/x11/gdkkeys-x11.c (update_keymaps): Fudge keymap to have lower
354 upper case variants if there is only a single keysym per keycode and
355 the key symbol has upper and lower case variants (#74512)
357 Thu Mar 14 17:09:52 2002 Owen Taylor <otaylor@redhat.com>
359 * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
360 improbable reentrancy problem if a window is destroyed
361 while updates are being processed on another window. (Noticed
362 by Michael Meeks, #74708)
364 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
366 * gtk/gtktreemodelsort.c
367 typo in docs for gtk_tree_model_sort_convert_iter_to_child_iter() fixed
370 Thu Mar 14 11:17:18 2002 Owen Taylor <otaylor@redhat.com>
372 * gtk/gtkkeyhash.c (_gtk_key_hash_remove_entry): When
373 removing keys from the key hash, reinsert the right list
374 back into the hash. (Dave Camp, #74571)
376 Wed Mar 13 17:17:40 2002 Owen Taylor <otaylor@redhat.com>
378 * gtk/gtkobject.h: Remove left-over GTK_OBJECT_CONNECTED
379 macro that was defined in terms of the now-gone GTK_CONNECTED
380 flag. (Seth Burgess, #74028)
382 Wed Mar 13 17:11:10 2002 Owen Taylor <otaylor@redhat.com>
384 * gtk/gtkaccelgroup.c (accel_group_weak_ref_detach): Unset
385 the acceleratable_groups qdata because qdata isn't removed
386 on ->dispose but rather on ->finalize. (#74569, found
389 Tue Mar 12 23:14:23 2002 Jonathan Blandford <jrb@redhat.com>
391 * gtk/gtktreeselection.c (gtk_tree_selection_unselect_iter): Fix
394 Sat Mar 9 18:23:25 2002 Richard Hestilow <hestilow@ximian.com>
396 * gtk/gtkimage.c (gtk_image_set_from_filename): Allow NULL
399 Tue Mar 12 10:50:09 2002 Owen Taylor <otaylor@redhat.com>
401 * modules/input/gtkimcontextxim.c (gtk_im_context_xim_filter_keypress):
402 Fix incorrect return value, filter out returns of 0x7f for
403 the delete key. (#74179, Kang Jeong-He)
405 Mon Mar 11 23:42:11 2002 Jonathan Blandford <jrb@redhat.com>
407 * gtk/gtktreemodel.c (gtk_tree_model_foreach): fix totally broken
410 2002-03-11 Matthias Clasen <maclas@gmx.de>
412 * gtk/gtkitemfactory.c (gtk_item_factory_add_foreign): Document
413 gtk_{menu_item,widget}_set_accel_path() as the recommended API.
416 2002-03-11 James Henstridge <james@daa.com.au>
418 * configure.in: set CCAS and CCASFLAGS to get automake 1.6
419 compatibility without breaking things for people using 1.4.
421 Sun Mar 10 21:04:30 2002 Jonathan Blandford <jrb@redhat.com>
423 * gtk/gtktreeview.c (gtk_tree_view_button_press): finally get the
426 Mon Mar 11 01:25:14 2002 Kristian Rietveld <kris@gtk.org>
428 * gtk/gtktreeview.c (gtk_tree_view_button_press): compare path with
429 cursor path and not with the selected iter in the 'decide to edit'